language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Cache/DynamoDbStore.php | @@ -443,6 +443,8 @@ public function forget($key)
* Remove all items from the cache.
*
* @return bool
+ *
+ * @throws \RuntimeException
*/
public function flush()
{ | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Database/Connectors/ConnectionFactory.php | @@ -194,6 +194,8 @@ protected function createPdoResolverWithHosts(array $config)
*
* @param array $config
* @return array
+ *
+ * @throws \InvalidArgumentException
*/
protected function parseHosts(array $config)
{ | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php | @@ -22,6 +22,8 @@ trait QueriesRelationships
* @param string $boolean
* @param \Closure|null $callback
* @return \Illuminate\Database\Eloquent\Builder|static
+ *
+ * @throws \RuntimeException
*/
public function has($relation, $operator = '>=', $count = 1, $boolean = 'and', Closu... | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php | @@ -393,6 +393,8 @@ public function orWherePivot($column, $operator = null, $value = null)
* @param string|array $column
* @param mixed $value
* @return $this
+ *
+ * @throws \InvalidArgumentException
*/
public function withPivotValue($column, $value = null)
{ | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Database/Query/Builder.php | @@ -1472,6 +1472,8 @@ public function addWhereExistsQuery(self $query, $boolean = 'and', $not = false)
* @param array $values
* @param string $boolean
* @return $this
+ *
+ * @throws \InvalidArgumentException
*/
public function whereRowValues($columns, $operator, $values, $boole... | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Database/Query/Grammars/Grammar.php | @@ -878,6 +878,8 @@ public function compileInsert(Builder $query, array $values)
* @param \Illuminate\Database\Query\Builder $query
* @param array $values
* @return string
+ *
+ * @throws \RuntimeException
*/
public function compileInsertOrIgnore(Builder $query, array $values)
... | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Database/Schema/Builder.php | @@ -319,6 +319,7 @@ protected function createBlueprint($table, Closure $callback = null)
* @return void
*
* @throws \Doctrine\DBAL\DBALException
+ * @throws \RuntimeException
*/
public function registerCustomDoctrineType($class, $name, $type)
{ | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Database/Schema/Grammars/SQLiteGrammar.php | @@ -340,6 +340,8 @@ public function compileRename(Blueprint $blueprint, Fluent $command)
* @param \Illuminate\Support\Fluent $command
* @param \Illuminate\Database\Connection $connection
* @return array
+ *
+ * @throws \RuntimeException
*/
public function compileRenameIndex(Blue... | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Foundation/Application.php | @@ -1005,6 +1005,7 @@ public function isDownForMaintenance()
* @return void
*
* @throws \Symfony\Component\HttpKernel\Exception\HttpException
+ * @throws \Symfony\Component\HttpKernel\Exception\NotFoundHttpException
*/
public function abort($code, $message = '', array $headers = [])
... | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Foundation/Http/Kernel.php | @@ -293,6 +293,8 @@ public function pushMiddleware($middleware)
* @param string $group
* @param string $middleware
* @return $this
+ *
+ * @throws \InvalidArgumentException
*/
public function prependMiddlewareToGroup($group, $middleware)
{
@@ -315,6 +317,8 @@ public functio... | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Foundation/Http/Middleware/CheckForMaintenanceMode.php | @@ -42,6 +42,7 @@ public function __construct(Application $app)
* @return mixed
*
* @throws \Symfony\Component\HttpKernel\Exception\HttpException
+ * @throws \Illuminate\Foundation\Http\Exceptions\MaintenanceModeException
*/
public function handle($request, Closure $next)
{ | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Foundation/Testing/Concerns/InteractsWithExceptionHandling.php | @@ -110,7 +110,8 @@ public function shouldReport(Exception $e)
* @param \Exception $e
* @return mixed
*
- * @throws \Symfony\Component\HttpKernel\Exception\NotFoundHttpException|\Exception
+ * @throws \Symfony\Component\HttpKernel\Exception\NotFoundHtt... | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Foundation/Testing/TestResponse.php | @@ -1240,6 +1240,8 @@ public function offsetGet($offset)
* @param string $offset
* @param mixed $value
* @return void
+ *
+ * @throws \LogicException
*/
public function offsetSet($offset, $value)
{
@@ -1251,6 +1253,8 @@ public function offsetSet($offset, $value)
*
... | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Hashing/Argon2IdHasher.php | @@ -13,6 +13,8 @@ class Argon2IdHasher extends ArgonHasher
* @param string $hashedValue
* @param array $options
* @return bool
+ *
+ * @throws \RuntimeException
*/
public function check($value, $hashedValue, array $options = [])
{ | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Hashing/ArgonHasher.php | @@ -90,6 +90,8 @@ protected function algorithm()
* @param string $hashedValue
* @param array $options
* @return bool
+ *
+ * @throws \RuntimeException
*/
public function check($value, $hashedValue, array $options = [])
{ | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Queue/Failed/DynamoDbFailedJobProvider.php | @@ -165,6 +165,8 @@ public function forget($id)
* Flush all of the failed jobs from storage.
*
* @return void
+ *
+ * @throws \Exception
*/
public function flush()
{ | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Routing/RouteAction.php | @@ -54,6 +54,8 @@ public static function parse($uri, $action)
*
* @param string $uri
* @return array
+ *
+ * @throws \LogicException
*/
protected static function missingAction($uri)
{ | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Support/ConfigurationUrlParser.php | @@ -124,6 +124,8 @@ protected function getQueryOptions($url)
*
* @param string $url
* @return array
+ *
+ * @throws \InvalidArgumentException
*/
protected function parseUrl($url)
{ | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/Support/Testing/Fakes/QueueFake.php | @@ -367,6 +367,8 @@ public function setConnectionName($name)
* @param string $method
* @param array $parameters
* @return mixed
+ *
+ * @throws \BadMethodCallException
*/
public function __call($method, $parameters)
{ | true |
Other | laravel | framework | 0dd1a50f041f227e21c42f0bd92f91af9121eab8.json | add missing docblocks (#30898) | src/Illuminate/View/Compilers/BladeCompiler.php | @@ -510,6 +510,8 @@ public function include($path, $alias = null)
* @param string $name
* @param callable $handler
* @return void
+ *
+ * @throws \InvalidArgumentException
*/
public function directive($name, callable $handler)
{ | true |
Other | laravel | framework | f32662a0f6bce153c8c714a155ae2ea3504a4c59.json | Add withoutMix and withMix test helpers (#30900) | src/Illuminate/Foundation/Testing/Concerns/InteractsWithContainer.php | @@ -3,10 +3,18 @@
namespace Illuminate\Foundation\Testing\Concerns;
use Closure;
+use Illuminate\Foundation\Mix;
use Mockery;
trait InteractsWithContainer
{
+ /**
+ * The original Laravel Mix handler.
+ *
+ * @var \Illuminate\Foundation\Mix|null
+ */
+ protected $originalMix;
+
/**
... | true |
Other | laravel | framework | f32662a0f6bce153c8c714a155ae2ea3504a4c59.json | Add withoutMix and withMix test helpers (#30900) | tests/Foundation/Testing/Concerns/InteractsWithContainerTest.php | @@ -0,0 +1,29 @@
+<?php
+
+namespace Illuminate\Tests\Foundation\Testing\Concerns;
+
+use Illuminate\Foundation\Mix;
+use Orchestra\Testbench\TestCase;
+
+class InteractsWithContainerTest extends TestCase
+{
+ public function testWithoutMixBindsEmptyHandlerAndReturnsInstance()
+ {
+ $instance = $this->with... | true |
Other | laravel | framework | b0dfbdf78ac7178c13384e91e650697e0d6f3397.json | Apply fixes from StyleCI (#30888) | src/Illuminate/Foundation/Http/Kernel.php | @@ -10,7 +10,6 @@
use Illuminate\Routing\Router;
use Illuminate\Support\Facades\Facade;
use InvalidArgumentException;
-use Symfony\Component\Debug\Exception\FatalThrowableError;
use Throwable;
class Kernel implements KernelContract | false |
Other | laravel | framework | a7523c5bcfaa0c48dbca0d16e8134de7d89c61c3.json | add marker interface for authentication middleware | src/Illuminate/Auth/Middleware/Authenticate.php | @@ -5,8 +5,9 @@
use Closure;
use Illuminate\Auth\AuthenticationException;
use Illuminate\Contracts\Auth\Factory as Auth;
+use Illuminate\Contracts\Auth\Middleware\AuthenticatesRequests;
-class Authenticate
+class Authenticate implements AuthenticatesRequests
{
/**
* The authentication factory instance. | true |
Other | laravel | framework | a7523c5bcfaa0c48dbca0d16e8134de7d89c61c3.json | add marker interface for authentication middleware | src/Illuminate/Contracts/Auth/Middleware/AuthenticatesRequests.php | @@ -0,0 +1,8 @@
+<?php
+
+namespace Illuminate\Contracts\Auth\Middleware;
+
+interface AuthenticatesRequests
+{
+ //
+} | true |
Other | laravel | framework | a7523c5bcfaa0c48dbca0d16e8134de7d89c61c3.json | add marker interface for authentication middleware | src/Illuminate/Foundation/Http/Kernel.php | @@ -72,7 +72,8 @@ class Kernel implements KernelContract
protected $middlewarePriority = [
\Illuminate\Session\Middleware\StartSession::class,
\Illuminate\View\Middleware\ShareErrorsFromSession::class,
- \Illuminate\Auth\Middleware\Authenticate::class,
+ \Illuminate\Contracts\Auth\M... | true |
Other | laravel | framework | 6f33feba124d4a7ff2af4f3ed18583d67fb68f7c.json | add some methods for manipulating middleware | src/Illuminate/Foundation/Http/Kernel.php | @@ -10,6 +10,7 @@
use Illuminate\Routing\Pipeline;
use Illuminate\Routing\Router;
use Illuminate\Support\Facades\Facade;
+use InvalidArgumentException;
use Symfony\Component\Debug\Exception\FatalThrowableError;
use Throwable;
@@ -294,6 +295,76 @@ public function pushMiddleware($middleware)
return $this;... | false |
Other | laravel | framework | 67b814b8350dbe0ca1682ca185f2ecef7dd67656.json | remove factory "types" (#30867)
- simplify the global helper `factory()`. since the signature is no longer dynamic, we can be a little more explicit in our parameters
- remove `defineAs`, `createAs`, `makeAs`, and `rawOf` which were methods specific to factory "types"
- update the `FactoryBuilder` to remove referenc... | src/Illuminate/Database/Eloquent/Factory.php | @@ -68,30 +68,16 @@ public static function construct(Faker $faker, $pathToFactories = null)
return (new static($faker))->load($pathToFactories);
}
- /**
- * Define a class with a given short-name.
- *
- * @param string $class
- * @param string $name
- * @param callable $attr... | true |
Other | laravel | framework | 67b814b8350dbe0ca1682ca185f2ecef7dd67656.json | remove factory "types" (#30867)
- simplify the global helper `factory()`. since the signature is no longer dynamic, we can be a little more explicit in our parameters
- remove `defineAs`, `createAs`, `makeAs`, and `rawOf` which were methods specific to factory "types"
- update the `FactoryBuilder` to remove referenc... | src/Illuminate/Database/Eloquent/FactoryBuilder.php | @@ -24,13 +24,6 @@ class FactoryBuilder
*/
protected $class;
- /**
- * The name of the model being built.
- *
- * @var string
- */
- protected $name = 'default';
-
/**
* The database connection on which the model instance should be persisted.
*
@@ -84,18 +77,16 @@ cla... | true |
Other | laravel | framework | 67b814b8350dbe0ca1682ca185f2ecef7dd67656.json | remove factory "types" (#30867)
- simplify the global helper `factory()`. since the signature is no longer dynamic, we can be a little more explicit in our parameters
- remove `defineAs`, `createAs`, `makeAs`, and `rawOf` which were methods specific to factory "types"
- update the `FactoryBuilder` to remove referenc... | src/Illuminate/Foundation/helpers.php | @@ -484,24 +484,21 @@ function event(...$args)
if (! function_exists('factory')) {
/**
- * Create a model factory builder for a given class, name, and amount.
+ * Create a model factory builder for a given class and amount.
*
- * @param dynamic class|class,name|class,amount|class,name,amount... | true |
Other | laravel | framework | 4c30d2c1119576773e8864d5cb9bd4a2c23a267a.json | Enable seed to all option (#30874) | src/Illuminate/Foundation/Console/ModelMakeCommand.php | @@ -42,6 +42,7 @@ public function handle()
if ($this->option('all')) {
$this->input->setOption('factory', true);
+ $this->input->setOption('seed', true);
$this->input->setOption('migration', true);
$this->input->setOption('controller', true);
$th... | false |
Other | laravel | framework | 3c8ccc2fb4ec03572076e6df71608f6bbb7d71e1.json | Prevent duplicate attachments
This will prevent users from adding duplicate attachments. This bug surfaced when rendering a mailable for logging or storage before sending. | src/Illuminate/Mail/Mailable.php | @@ -747,7 +747,10 @@ public function with($key, $value = null)
*/
public function attach($file, array $options = [])
{
- $this->attachments[] = compact('file', 'options');
+ $this->attachments = collect($this->attachments)
+ ->push(compact('file', 'options'))
+ ... | false |
Other | laravel | framework | db794ceea6734cc90286e04a8a2a48e5b4cd4130.json | Update helpers.php (#30838) | src/Illuminate/Foundation/helpers.php | @@ -715,7 +715,7 @@ function rescue(callable $callback, $rescue = null, $report = true)
report($e);
}
- return value($rescue);
+ return $rescue instanceof Closure ? $rescue($e) : $rescue;
}
}
} | false |
Other | laravel | framework | fa4a36788d0f34b22a67a65589e22c34deb3fae1.json | fix non-eloquent model validation | src/Illuminate/Validation/Concerns/ValidatesAttributes.php | @@ -818,12 +818,9 @@ public function parseTable($table)
{
[$connection, $table] = Str::contains($table, '.') ? explode('.', $table, 2) : [null, $table];
- if (Str::contains($table, '\\') && class_exists($table)) {
+ if (Str::contains($table, '\\') && class_exists($table) && is_a($table, Mo... | true |
Other | laravel | framework | fa4a36788d0f34b22a67a65589e22c34deb3fae1.json | fix non-eloquent model validation | tests/Validation/ValidationValidatorTest.php | @@ -4307,6 +4307,10 @@ public function testParsingTablesFromModels()
$this->assertEquals(null, $explicit_no_connection[0]);
$this->assertEquals('explicits', $explicit_no_connection[1]);
+ $noneloquent_no_connection = $v->parseTable(NonEloquentModel::class);
+ $this->assertEquals(null, ... | true |
Other | laravel | framework | 9693cedbfc1fb0e38a8e688375e5b2ce5273b75f.json | add more quotes | src/Illuminate/Foundation/Inspiring.php | @@ -40,6 +40,10 @@ public static function quote()
'I begin to speak only when I am certain what I will say is not better left unsaid - Cato the Younger',
'Order your soul. Reduce your wants. - Augustine',
'Be present above all else. - Naval Ravikant',
+ 'Let all your th... | false |
Other | laravel | framework | f5c3c60d52eccd77274e586fc4c775374e826b0f.json | Implement ArrayAccess on TestResponse (#30817)
When building / testing and JSON API, I like to sometimes interact with the raw JSON payload returned in the response. Normally you would have to access this via $response->original['foo']; however, with this change I implement ArrayAccess on both JsonResponse and TestRes... | src/Illuminate/Foundation/Testing/TestResponse.php | @@ -2,6 +2,7 @@
namespace Illuminate\Foundation\Testing;
+use ArrayAccess;
use Closure;
use Illuminate\Contracts\View\View;
use Illuminate\Database\Eloquent\Model;
@@ -12,12 +13,13 @@
use Illuminate\Support\Str;
use Illuminate\Support\Traits\Macroable;
use Illuminate\Support\Traits\Tappable;
+use LogicExcept... | false |
Other | laravel | framework | 454c2b341a2662fb88bfc42cb030d422783e4bab.json | Apply fixes from StyleCI (#30803) | tests/Integration/Broadcasting/BroadcastManagerTest.php | @@ -7,9 +7,7 @@
use Illuminate\Contracts\Broadcasting\ShouldBroadcastNow;
use Illuminate\Support\Facades\Broadcast;
use Illuminate\Support\Facades\Bus;
-use Illuminate\Support\Facades\Cache;
use Illuminate\Support\Facades\Queue;
-use Illuminate\Support\Str;
use Orchestra\Testbench\TestCase;
/** | false |
Other | laravel | framework | f4b4b8108bb0f5e81e0856697c74aa03cd35b214.json | Handle toJson properly on json resources (#30801)
At the moment when you call toJson on a Json resource it skips the `toArray` method and directly calls toJson on the Eloquent model because of the ForwardsCalls trait. This seems unwanted because if you're formatting the resource in a specific way through the toArray m... | src/Illuminate/Database/Eloquent/JsonEncodingException.php | @@ -18,6 +18,20 @@ public static function forModel($model, $message)
return new static('Error encoding model ['.get_class($model).'] with ID ['.$model->getKey().'] to JSON: '.$message);
}
+ /**
+ * Create a new JSON encoding exception for the resource.
+ *
+ * @param \Illuminate\Http\Res... | true |
Other | laravel | framework | f4b4b8108bb0f5e81e0856697c74aa03cd35b214.json | Handle toJson properly on json resources (#30801)
At the moment when you call toJson on a Json resource it skips the `toArray` method and directly calls toJson on the Eloquent model because of the ForwardsCalls trait. This seems unwanted because if you're formatting the resource in a specific way through the toArray m... | src/Illuminate/Http/Resources/Json/JsonResource.php | @@ -7,6 +7,7 @@
use Illuminate\Contracts\Routing\UrlRoutable;
use Illuminate\Contracts\Support\Arrayable;
use Illuminate\Contracts\Support\Responsable;
+use Illuminate\Database\Eloquent\JsonEncodingException;
use Illuminate\Http\Resources\ConditionallyLoadsAttributes;
use Illuminate\Http\Resources\DelegatesToResou... | true |
Other | laravel | framework | f4b4b8108bb0f5e81e0856697c74aa03cd35b214.json | Handle toJson properly on json resources (#30801)
At the moment when you call toJson on a Json resource it skips the `toArray` method and directly calls toJson on the Eloquent model because of the ForwardsCalls trait. This seems unwanted because if you're formatting the resource in a specific way through the toArray m... | tests/Integration/Http/ResourceTest.php | @@ -38,6 +38,7 @@ public function testResourcesMayBeConvertedToJson()
return new PostResource(new Post([
'id' => 5,
'title' => 'Test Title',
+ 'abstract' => 'Test abstract',
]));
});
@@ -55,6 +56,17 @@ public function testResourcesMay... | true |
Other | laravel | framework | c5c5b75a07af4442c437d8730ad0ecec8a5b97cc.json | Improve ShouldBroadcastNow performance | src/Illuminate/Broadcasting/BroadcastManager.php | @@ -9,6 +9,7 @@
use Illuminate\Broadcasting\Broadcasters\RedisBroadcaster;
use Illuminate\Contracts\Broadcasting\Factory as FactoryContract;
use Illuminate\Contracts\Broadcasting\ShouldBroadcastNow;
+use Illuminate\Contracts\Bus\Dispatcher as BusDispatcherContract;
use InvalidArgumentException;
use Psr\Log\LoggerI... | false |
Other | laravel | framework | 58d5f788dc47b63bc861417fbf9f7bdfff1b0428.json | Update travis file | .travis.yml | @@ -39,4 +39,5 @@ install:
- if [[ $SETUP = 'stable' ]]; then travis_retry composer update --prefer-dist --no-interaction --prefer-stable --no-suggest; fi
- if [[ $SETUP = 'lowest' ]]; then travis_retry composer update --prefer-dist --no-interaction --prefer-lowest --prefer-stable --no-suggest; fi
-script: vend... | false |
Other | laravel | framework | 11f410a3439f47efb60f19cf100e719e461fd75b.json | add doc block return | src/Illuminate/Http/Resources/Json/ResourceCollection.php | @@ -54,6 +54,8 @@ public function __construct($resource)
/**
* Indicate that all current query parameters should be appended to pagination links.
+ *
+ * @return $this
*/
public function preserveQuery()
{ | false |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Auth/MustVerifyEmail.php | @@ -2,6 +2,8 @@
namespace Illuminate\Auth;
+use Illuminate\Auth\Notifications\VerifyEmail;
+
trait MustVerifyEmail
{
/**
@@ -33,7 +35,7 @@ public function markEmailAsVerified()
*/
public function sendEmailVerificationNotification()
{
- $this->notify(new Notifications\VerifyEmail);
+ ... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Auth/SessionGuard.php | @@ -2,6 +2,13 @@
namespace Illuminate\Auth;
+use Illuminate\Auth\Events\Attempting;
+use Illuminate\Auth\Events\Authenticated;
+use Illuminate\Auth\Events\CurrentDeviceLogout;
+use Illuminate\Auth\Events\Failed;
+use Illuminate\Auth\Events\Login;
+use Illuminate\Auth\Events\Logout;
+use Illuminate\Auth\Events\Othe... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Console/Application.php | @@ -3,6 +3,9 @@
namespace Illuminate\Console;
use Closure;
+use Illuminate\Console\Events\ArtisanStarting;
+use Illuminate\Console\Events\CommandFinished;
+use Illuminate\Console\Events\CommandStarting;
use Illuminate\Contracts\Console\Application as ApplicationContract;
use Illuminate\Contracts\Container\Contain... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Container/Util.php | @@ -2,6 +2,8 @@
namespace Illuminate\Container;
+use Closure;
+
class Util
{
/**
@@ -31,6 +33,6 @@ public static function arrayWrap($value)
*/
public static function unwrapIfClosure($value)
{
- return $value instanceof \Closure ? $value() : $value;
+ return $value instanceof Cl... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Database/Connection.php | @@ -8,6 +8,10 @@
use Exception;
use Illuminate\Contracts\Events\Dispatcher;
use Illuminate\Database\Events\QueryExecuted;
+use Illuminate\Database\Events\StatementPrepared;
+use Illuminate\Database\Events\TransactionBeginning;
+use Illuminate\Database\Events\TransactionCommitted;
+use Illuminate\Database\Events\Tran... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Foundation/Application.php | @@ -9,6 +9,7 @@
use Illuminate\Events\EventServiceProvider;
use Illuminate\Filesystem\Filesystem;
use Illuminate\Foundation\Bootstrap\LoadEnvironmentVariables;
+use Illuminate\Foundation\Events\LocaleUpdated;
use Illuminate\Http\Request;
use Illuminate\Log\LogServiceProvider;
use Illuminate\Routing\RoutingService... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Foundation/Http/Kernel.php | @@ -6,6 +6,7 @@
use Illuminate\Contracts\Debug\ExceptionHandler;
use Illuminate\Contracts\Foundation\Application;
use Illuminate\Contracts\Http\Kernel as KernelContract;
+use Illuminate\Foundation\Http\Events\RequestHandled;
use Illuminate\Routing\Pipeline;
use Illuminate\Routing\Router;
use Illuminate\Support\Fa... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Http/UploadedFile.php | @@ -5,6 +5,7 @@
use Illuminate\Container\Container;
use Illuminate\Contracts\Filesystem\Factory as FilesystemFactory;
use Illuminate\Contracts\Filesystem\FileNotFoundException;
+use Illuminate\Http\Testing\FileFactory;
use Illuminate\Support\Arr;
use Illuminate\Support\Traits\Macroable;
use Symfony\Component\Http... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Mail/Mailer.php | @@ -10,6 +10,8 @@
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Contracts\Support\Htmlable;
use Illuminate\Contracts\View\Factory;
+use Illuminate\Mail\Events\MessageSending;
+use Illuminate\Mail\Events\MessageSent;
use Illuminate\Support\HtmlString;
use Illuminate\Support\Traits\Macroable;
use Inval... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Notifications/NotificationSender.php | @@ -6,6 +6,8 @@
use Illuminate\Contracts\Translation\HasLocalePreference;
use Illuminate\Database\Eloquent\Collection as ModelCollection;
use Illuminate\Database\Eloquent\Model;
+use Illuminate\Notifications\Events\NotificationSending;
+use Illuminate\Notifications\Events\NotificationSent;
use Illuminate\Support\Co... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Queue/SyncQueue.php | @@ -5,6 +5,9 @@
use Exception;
use Illuminate\Contracts\Queue\Job;
use Illuminate\Contracts\Queue\Queue as QueueContract;
+use Illuminate\Queue\Events\JobExceptionOccurred;
+use Illuminate\Queue\Events\JobProcessed;
+use Illuminate\Queue\Events\JobProcessing;
use Illuminate\Queue\Jobs\SyncJob;
use Symfony\Componen... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Queue/Worker.php | @@ -8,6 +8,11 @@
use Illuminate\Contracts\Events\Dispatcher;
use Illuminate\Contracts\Queue\Factory as QueueManager;
use Illuminate\Database\DetectsLostConnections;
+use Illuminate\Queue\Events\JobExceptionOccurred;
+use Illuminate\Queue\Events\JobProcessed;
+use Illuminate\Queue\Events\JobProcessing;
+use Illuminat... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Redis/RedisManager.php | @@ -5,6 +5,8 @@
use Closure;
use Illuminate\Contracts\Redis\Factory;
use Illuminate\Redis\Connections\Connection;
+use Illuminate\Redis\Connectors\PhpRedisConnector;
+use Illuminate\Redis\Connectors\PredisConnector;
use Illuminate\Support\ConfigurationUrlParser;
use InvalidArgumentException;
@@ -167,9 +169,9 @@ ... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Routing/Router.php | @@ -15,6 +15,7 @@
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
+use Illuminate\Routing\Events\RouteMatched;
use Illuminate\Support\Collection;
use Illuminate\Support\Str;
use Illuminate\Support\Traits\Macroable;
@@ -651,7 +652,7 @@ protected function runRoute(Reques... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | src/Illuminate/Validation/Rule.php | @@ -4,6 +4,12 @@
use Illuminate\Contracts\Support\Arrayable;
use Illuminate\Support\Traits\Macroable;
+use Illuminate\Validation\Rules\Dimensions;
+use Illuminate\Validation\Rules\Exists;
+use Illuminate\Validation\Rules\In;
+use Illuminate\Validation\Rules\NotIn;
+use Illuminate\Validation\Rules\RequiredIf;
+use I... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | tests/Container/UtilTest.php | @@ -4,6 +4,7 @@
use Illuminate\Container\Util;
use PHPUnit\Framework\TestCase;
+use stdClass;
class UtilTest extends TestCase
{
@@ -19,7 +20,7 @@ public function testArrayWrap()
{
$string = 'a';
$array = ['a'];
- $object = new \stdClass;
+ $object = new stdClass;
$o... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | tests/Cookie/CookieTest.php | @@ -5,6 +5,7 @@
use Illuminate\Cookie\CookieJar;
use Mockery as m;
use PHPUnit\Framework\TestCase;
+use ReflectionObject;
use Symfony\Component\HttpFoundation\Cookie;
class CookieTest extends TestCase
@@ -194,7 +195,7 @@ public function getCreator()
private function getQueuedPropertyValue(CookieJar $cooki... | true |
Other | laravel | framework | 7b074c1ac506c1895f85ec77481b55228a122a05.json | Add missing imports. (#30764) | tests/Queue/QueueWorkerTest.php | @@ -2,6 +2,7 @@
namespace Illuminate\Tests\Queue;
+use Exception;
use Illuminate\Container\Container;
use Illuminate\Contracts\Debug\ExceptionHandler;
use Illuminate\Contracts\Events\Dispatcher;
@@ -249,7 +250,7 @@ public function testJobBasedMaxRetries()
public function testJobBasedFailedDelay()
{
... | true |
Other | laravel | framework | 910cc7473c0772032a8ac4fedb27e695ee69f9f0.json | Fix zero parameter for routes (#30768)
Routes should be allowed to accept a 0 as a route parameter. | src/Illuminate/Routing/RouteUrlGenerator.php | @@ -218,7 +218,7 @@ protected function replaceRouteParameters($path, array &$parameters)
protected function replaceNamedParameters($path, &$parameters)
{
return preg_replace_callback('/\{(.*?)(\?)?\}/', function ($m) use (&$parameters) {
- if (isset($parameters[$m[1]]) && $parameters[$m[1]... | true |
Other | laravel | framework | 910cc7473c0772032a8ac4fedb27e695ee69f9f0.json | Fix zero parameter for routes (#30768)
Routes should be allowed to accept a 0 as a route parameter. | tests/Routing/RoutingUrlGeneratorTest.php | @@ -249,6 +249,7 @@ public function testBasicRouteGeneration()
$this->assertSame('/foo/bar?foo=bar', $url->route('foo', ['foo' => 'bar'], false));
$this->assertSame('http://www.foo.com/foo/bar/taylor/breeze/otwell?fly=wall', $url->route('bar', ['taylor', 'otwell', 'fly' => 'wall']));
$this->a... | true |
Other | laravel | framework | 79ac996b4474c95d55885049bbd8981afc7c6148.json | remove empty line | tests/Integration/Events/EventFakeTest.php | @@ -14,7 +14,6 @@ class EventFakeTest extends TestCase
* Define environment setup.
*
* @param \Illuminate\Contracts\Foundation\Application $app
- *
* @return void
*/
protected function getEnvironmentSetUp($app) | false |
Other | laravel | framework | 679eb00c6852034fee125709decdc1628f4b996b.json | fix single spaces for params in docs | src/Illuminate/Database/Console/WipeCommand.php | @@ -83,7 +83,7 @@ protected function dropAllViews($database)
/**
* Drop all of the database types.
*
- * @param string $database
+ * @param string $database
* @return void
*/
protected function dropAllTypes($database) | true |
Other | laravel | framework | 679eb00c6852034fee125709decdc1628f4b996b.json | fix single spaces for params in docs | src/Illuminate/Database/Eloquent/HigherOrderBuilderProxy.php | @@ -25,7 +25,7 @@ class HigherOrderBuilderProxy
* Create a new proxy instance.
*
* @param \Illuminate\Database\Eloquent\Builder $builder
- * @param string $method
+ * @param string $method
*/
public function __construct(Builder $builder, $method)
{ | true |
Other | laravel | framework | 679eb00c6852034fee125709decdc1628f4b996b.json | fix single spaces for params in docs | src/Illuminate/Database/Schema/Grammars/PostgresGrammar.php | @@ -222,7 +222,7 @@ public function compileDropAllViews($views)
/**
* Compile the SQL needed to drop all types.
*
- * @param array $types
+ * @param array $types
* @return string
*/
public function compileDropAllTypes($types) | true |
Other | laravel | framework | 679eb00c6852034fee125709decdc1628f4b996b.json | fix single spaces for params in docs | src/Illuminate/Filesystem/Cache.php | @@ -31,9 +31,10 @@ class Cache extends AbstractCache
/**
* Create a new cache instance.
*
- * @param \Illuminate\Contracts\Cache\Repository $repository
- * @param string $key
- * @param int|null $expire
+ * @param \Illuminate\Contracts\Cache\Repository $repository
+ * @param s... | true |
Other | laravel | framework | a07bd96a101034a6944e3a58dc50d9936a20e2f9.json | accept a string or array of views (#30746)
this goes along with PR #30651 .
I'm not sure what our practice is for changes like this on an interface.... I'm not technically changing any of the code, just a docblock, so is it safe to send to 6.x? | src/Illuminate/Contracts/Routing/ResponseFactory.php | @@ -26,7 +26,7 @@ public function noContent($status = 204, array $headers = []);
/**
* Create a new response for a given view.
*
- * @param string $view
+ * @param string|array $view
* @param array $data
* @param int $status
* @param array $headers | false |
Other | laravel | framework | 3673354d70b860078d0c88e1d89439e65db9af70.json | Change method visibility | src/Illuminate/Http/Resources/Json/ResourceCollection.php | @@ -99,7 +99,7 @@ public function toResponse($request)
* @param \Illuminate\Http\Request $request
* @return \Illuminate\Http\JsonResponse
*/
- private function preparePaginatedResponse($request)
+ protected function preparePaginatedResponse($request)
{
if ($this->queryParameters) ... | false |
Other | laravel | framework | 6690c2c0f1887475712569cbe902e93be12ccb1a.json | Allow string in some Builder param types (#30744) | src/Illuminate/Database/Concerns/BuildsQueries.php | @@ -135,7 +135,7 @@ public function eachById(callable $callback, $count = 1000, $column = null, $ali
/**
* Execute the query and get the first result.
*
- * @param array $columns
+ * @param array|string $columns
* @return \Illuminate\Database\Eloquent\Model|object|static|null
*/... | true |
Other | laravel | framework | 6690c2c0f1887475712569cbe902e93be12ccb1a.json | Allow string in some Builder param types (#30744) | src/Illuminate/Database/Eloquent/Builder.php | @@ -492,7 +492,7 @@ public function value($column)
/**
* Execute the query as a "select" statement.
*
- * @param array $columns
+ * @param array|string $columns
* @return \Illuminate\Database\Eloquent\Collection|static[]
*/
public function get($columns = ['*'])
@@ -512,7 +5... | true |
Other | laravel | framework | 72deea318efb2886ee589654b584be8500977eb1.json | Remove unnecessary variable (#30735) | src/Illuminate/Auth/GenericUser.php | @@ -41,9 +41,7 @@ public function getAuthIdentifierName()
*/
public function getAuthIdentifier()
{
- $name = $this->getAuthIdentifierName();
-
- return $this->attributes[$name];
+ return $this->attributes[$this->getAuthIdentifierName()];
}
/** | false |
Other | laravel | framework | 663a30fa808072093d2525c068eb36425b4a21e2.json | Fix return type | src/Illuminate/Mail/Mailable.php | @@ -202,7 +202,7 @@ public function later($delay, Queue $queue)
/**
* Render the mailable into a view.
*
- * @return \Illuminate\View\View
+ * @return string
*
* @throws \ReflectionException
*/ | false |
Other | laravel | framework | 93b5068214ddd1c1aa33bb09aea645fc916aed86.json | force usage getting timestamps columns | src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php | @@ -866,7 +866,10 @@ protected function serializeDate(DateTimeInterface $date)
*/
public function getDates()
{
- $defaults = [static::CREATED_AT, static::UPDATED_AT];
+ $defaults = [
+ $this->getCreatedAtColumn(),
+ $this->getUpdatedAtColumn(),
+ ];
... | true |
Other | laravel | framework | 93b5068214ddd1c1aa33bb09aea645fc916aed86.json | force usage getting timestamps columns | src/Illuminate/Database/Eloquent/Concerns/HasTimestamps.php | @@ -38,12 +38,13 @@ protected function updateTimestamps()
{
$time = $this->freshTimestamp();
- if (! is_null(static::UPDATED_AT) && ! $this->isDirty(static::UPDATED_AT)) {
+ $updatedAtColumn = $this->getUpdatedAtColumn();
+ if (! is_null($updatedAtColumn) && ! $this->isDirty($update... | true |
Other | laravel | framework | e1f8eef2a413642aeab6df1a08602a58da58739f.json | accept field for Route binding (#30471)
when resolving the binding for a Route, allow passing an override parameter for the queries field name, instead of the default one on the Model. | src/Illuminate/Contracts/Routing/UrlRoutable.php | @@ -21,8 +21,9 @@ public function getRouteKeyName();
/**
* Retrieve the model for a bound value.
*
- * @param mixed $value
+ * @param mixed $value
+ * @param string $field
* @return \Illuminate\Database\Eloquent\Model|null
*/
- public function resolveRouteBinding($valu... | true |
Other | laravel | framework | e1f8eef2a413642aeab6df1a08602a58da58739f.json | accept field for Route binding (#30471)
when resolving the binding for a Route, allow passing an override parameter for the queries field name, instead of the default one on the Model. | src/Illuminate/Database/Eloquent/Model.php | @@ -1493,12 +1493,13 @@ public function getRouteKeyName()
/**
* Retrieve the model for a bound value.
*
- * @param mixed $value
+ * @param mixed $value
+ * @param string $field
* @return \Illuminate\Database\Eloquent\Model|null
*/
- public function resolveRouteBinding(... | true |
Other | laravel | framework | e1f8eef2a413642aeab6df1a08602a58da58739f.json | accept field for Route binding (#30471)
when resolving the binding for a Route, allow passing an override parameter for the queries field name, instead of the default one on the Model. | src/Illuminate/Http/Resources/DelegatesToResource.php | @@ -32,12 +32,13 @@ public function getRouteKeyName()
/**
* Retrieve the model for a bound value.
*
- * @param mixed $value
+ * @param mixed $value
+ * @param string $field
* @return void
*
* @throws \Exception
*/
- public function resolveRouteBinding($valu... | true |
Other | laravel | framework | e1f8eef2a413642aeab6df1a08602a58da58739f.json | accept field for Route binding (#30471)
when resolving the binding for a Route, allow passing an override parameter for the queries field name, instead of the default one on the Model. | tests/Integration/Routing/UrlSigningTest.php | @@ -101,7 +101,7 @@ public function getRouteKeyName()
return 'routable';
}
- public function resolveRouteBinding($routeKey)
+ public function resolveRouteBinding($routeKey, $field = null)
{
//
} | true |
Other | laravel | framework | e1f8eef2a413642aeab6df1a08602a58da58739f.json | accept field for Route binding (#30471)
when resolving the binding for a Route, allow passing an override parameter for the queries field name, instead of the default one on the Model. | tests/Routing/RoutingUrlGeneratorTest.php | @@ -665,7 +665,7 @@ public function getRouteKeyName()
return 'key';
}
- public function resolveRouteBinding($routeKey)
+ public function resolveRouteBinding($routeKey, $field = null)
{
//
} | true |
Other | laravel | framework | 074cc3cc5df1062fa6ae7e274ad0c73721e6d897.json | Remove Resource class (#30619)
This class is never used and doesn't provide any value over using JsonResource instead. | src/Illuminate/Http/Resources/Json/Resource.php | @@ -1,8 +0,0 @@
-<?php
-
-namespace Illuminate\Http\Resources\Json;
-
-class Resource extends JsonResource
-{
- //
-} | false |
Other | laravel | framework | 08f8ef951e3f54e43bb9829c47393e9975b0a9ff.json | Apply fixes from StyleCI (#30657) | src/Illuminate/Routing/Router.php | @@ -142,7 +142,7 @@ public function __construct(Dispatcher $events, Container $container = null)
public function head($uri, $action = null)
{
return $this->addRoute('HEAD', $uri, $action);
- }
+ }
/**
* Register a new GET route with the router. | false |
Other | laravel | framework | c0eff91020f5cbf014f97d39a4b47df3f8ec3d26.json | Add Route::fallback() PHPDoc (#30647) | src/Illuminate/Support/Facades/Route.php | @@ -3,6 +3,7 @@
namespace Illuminate\Support\Facades;
/**
+ * @method static \Illuminate\Routing\Route fallback(\Closure|array|string|callable|null $action = null)
* @method static \Illuminate\Routing\Route get(string $uri, \Closure|array|string|callable|null $action = null)
* @method static \Illuminate\Routing... | false |
Other | laravel | framework | 57306b716362331b6a95bf05336fcdb52057cca7.json | Allow explicit model definitions in database rules | src/Illuminate/Validation/Rules/DatabaseRule.php | @@ -3,6 +3,8 @@
namespace Illuminate\Validation\Rules;
use Closure;
+use Illuminate\Support\Str;
+use Illuminate\Database\Eloquent\Model;
trait DatabaseRule
{
@@ -43,10 +45,30 @@ trait DatabaseRule
*/
public function __construct($table, $column = 'NULL')
{
- $this->table = $table;
+ ... | true |
Other | laravel | framework | 57306b716362331b6a95bf05336fcdb52057cca7.json | Allow explicit model definitions in database rules | tests/Validation/ValidationExistsRuleTest.php | @@ -42,17 +42,29 @@ public function testItCorrectlyFormatsAStringVersionOfTheRule()
$rule = new Exists('table', 'column');
$rule->where('foo', 'bar');
$this->assertSame('exists:table,column,foo,"bar"', (string) $rule);
+
+ $rule = new Exists(User::class, 'column');
+ $rule->wher... | true |
Other | laravel | framework | c23b0b8b11ec65cdb857044a0c2e917ed62ce8a2.json | Fix QueueFake docblocks on Queue facade (#30629)
The `@method` docblocks on the Queue facade introduced in #30300 are a bit different than the method signatures on the QueueFake. | src/Illuminate/Support/Facades/Queue.php | @@ -16,10 +16,10 @@
* @method static string getConnectionName()
* @method static \Illuminate\Contracts\Queue\Queue setConnectionName(string $name)
* @method static void assertNothingPushed()
- * @method static void assertNotPushed(string $job, \Closure $callback = null)
- * @method static void assertPushed(string... | false |
Other | laravel | framework | 181db51595d546cbd24b3fac0cb276255e147286.json | allow string content on fake file creation | src/Illuminate/Http/Testing/File.php | @@ -49,7 +49,7 @@ public function __construct($name, $tempFile)
* Create a new fake file.
*
* @param string $name
- * @param int $kilobytes
+ * @param string|int $kilobytes
* @return \Illuminate\Http\Testing\File
*/
public static function create($name, $kilobytes = 0) | true |
Other | laravel | framework | 181db51595d546cbd24b3fac0cb276255e147286.json | allow string content on fake file creation | src/Illuminate/Http/Testing/FileFactory.php | @@ -10,13 +10,19 @@ class FileFactory
* Create a new fake file.
*
* @param string $name
- * @param int $kilobytes
+ * @param string|int $kilobytes
* @return \Illuminate\Http\Testing\File
*/
public function create($name, $kilobytes = 0)
{
- return tap(new File... | true |
Other | laravel | framework | b204042056458faefee1be04c0e4b2fb59424cbe.json | Remove prefix before normalizing the channel name. | src/Illuminate/Broadcasting/Broadcasters/RedisBroadcaster.php | @@ -47,15 +47,14 @@ public function __construct(Redis $redis, $connection = null)
*/
public function auth($request)
{
- $channelName = $this->normalizeChannelName($request->channel_name);
+ $channelName = str_replace(config('database.redis.options.prefix', ''), '', $request->channel_name);... | false |
Other | laravel | framework | 174c234b2d7e5108db1395ad5b681e50e0a7794d.json | add conditional methods to dispatchable traits | src/Illuminate/Foundation/Bus/Dispatchable.php | @@ -16,6 +16,32 @@ public static function dispatch()
return new PendingDispatch(new static(...func_get_args()));
}
+ /**
+ * Dispatch the job with the given arguments if the given truth test passes.
+ *
+ * @param bool $boolean
+ * @return \Illuminate\Foundation\Bus\PendingDispatch|... | true |
Other | laravel | framework | 174c234b2d7e5108db1395ad5b681e50e0a7794d.json | add conditional methods to dispatchable traits | src/Illuminate/Foundation/Events/Dispatchable.php | @@ -14,6 +14,32 @@ public static function dispatch()
return event(new static(...func_get_args()));
}
+ /**
+ * Dispatch the event with the given arguments if the given truth test passes.
+ *
+ * @param bool $boolean
+ * @return void
+ */
+ public static function dispatchIf($b... | true |
Other | laravel | framework | 2385358edd9652ce115632002027ac71bf2633db.json | Fix typos (#30581) | CHANGELOG-6.x.md | @@ -11,7 +11,7 @@
### Fixed
- Fixed default value for $count in `PhpRedisConnection::spop()` method ([#30546](https://github.com/laravel/framework/pull/30546))
- Fixed breaking compatibility with multi-schema postgres ([#30562](https://github.com/laravel/framework/pull/30562), [6460d2b](https://github.com/laravel/fr... | false |
Other | laravel | framework | f1cfa859e3826b2d996ffc8af30848bc537f06f9.json | update Model dirty check (#30565)
for attributes that are cast to any type of Object, the strict equivalency (`===`) will never return `true`, because even though the values may be equal, the Object there reference will be different.
this changes checks if the cast type is either `object` or `collection`, both with... | src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php | @@ -1172,6 +1172,9 @@ public function originalIsEquivalent($key, $current)
} elseif ($this->isDateAttribute($key)) {
return $this->fromDateTime($current) ===
$this->fromDateTime($original);
+ } elseif ($this->hasCast($key, ['object', 'collection'])) {
+ return... | true |
Other | laravel | framework | f1cfa859e3826b2d996ffc8af30848bc537f06f9.json | update Model dirty check (#30565)
for attributes that are cast to any type of Object, the strict equivalency (`===`) will never return `true`, because even though the values may be equal, the Object there reference will be different.
this changes checks if the cast type is either `object` or `collection`, both with... | tests/Database/DatabaseEloquentModelTest.php | @@ -116,6 +116,23 @@ public function testDirtyOnCastOrDateAttributes()
$this->assertTrue($model->isDirty('datetimeAttribute'));
}
+ public function testDirtyOnCastedObjects()
+ {
+ $model = new EloquentModelCastingStub;
+ $model->setRawAttributes([
+ 'objectAttribute' ... | true |
Other | laravel | framework | 60a688ae5f5342874cafdcc3603667539e0e9c19.json | Add includeUnless directive (#30538) | src/Illuminate/View/Compilers/Concerns/CompilesIncludes.php | @@ -54,6 +54,19 @@ protected function compileIncludeWhen($expression)
return "<?php echo \$__env->renderWhen($expression, \Illuminate\Support\Arr::except(get_defined_vars(), ['__data', '__path'])); ?>";
}
+ /**
+ * Compile the include-unless statements into valid PHP.
+ *
+ * @param stri... | false |
Other | laravel | framework | 3745d9a97a74185c90d76db921b6daba6d6e24f2.json | Apply fixes from StyleCI (#30527) | src/Illuminate/Database/Schema/Blueprint.php | @@ -5,9 +5,8 @@
use BadMethodCallException;
use Closure;
use Illuminate\Database\Connection;
-use Illuminate\Database\SQLiteConnection;
-use Illuminate\Database\Schema\ForeignKeyDefinition;
use Illuminate\Database\Schema\Grammars\Grammar;
+use Illuminate\Database\SQLiteConnection;
use Illuminate\Support\Fluent;
u... | true |
Other | laravel | framework | 3745d9a97a74185c90d76db921b6daba6d6e24f2.json | Apply fixes from StyleCI (#30527) | tests/Database/DatabaseMySqlSchemaGrammarTest.php | @@ -372,7 +372,6 @@ public function testAddingForeignKey()
$this->assertCount(1, $statements);
$this->assertSame('alter table `users` add constraint `users_foo_id_foreign` foreign key (`foo_id`) references `orders` (`id`)', $statements[0]);
-
$blueprint = new Blueprint('users');
$b... | true |
Other | laravel | framework | ec966c21c4062c8ded5d8add4db91cab61a591dc.json | add helper for on delete cascade | src/Illuminate/Database/Schema/Blueprint.php | @@ -5,8 +5,9 @@
use BadMethodCallException;
use Closure;
use Illuminate\Database\Connection;
-use Illuminate\Database\Schema\Grammars\Grammar;
use Illuminate\Database\SQLiteConnection;
+use Illuminate\Database\Schema\ForeignKeyDefinition;
+use Illuminate\Database\Schema\Grammars\Grammar;
use Illuminate\Support\Flu... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.