language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | laravel | framework | 39c154c6ebcd1c28321d18b431ca703e3c8460a7.json | Apply fixes from StyleCI (#25904) | tests/Console/ConsoleApplicationTest.php | @@ -4,7 +4,6 @@
use Mockery as m;
use PHPUnit\Framework\TestCase;
-use Illuminate\Contracts\Events\Dispatcher;
use Symfony\Component\Console\Command\Command;
use Illuminate\Contracts\Foundation\Application;
| false |
Other | laravel | framework | df0e059f492a17b52d2c4957966aad6358c1abc9.json | add missing @throws docblock (#25887) | src/Illuminate/Validation/Concerns/ValidatesAttributes.php | @@ -1591,6 +1591,8 @@ public function isValidFileInstance($value)
* @param mixed $second
* @param string $operator
* @return bool
+ *
+ * @throws \InvalidArgumentException
*/
protected function compare($first, $second, $operator)
{ | false |
Other | laravel | framework | 8f0f9bf0269df7200069485d3dd854aa633589a9.json | Use class notation in Container tests (#25881) | tests/Container/ContainerTest.php | @@ -523,16 +523,16 @@ public function testCallWithAtSignBasedClassReferencesWithoutMethodThrowsExcepti
public function testCallWithAtSignBasedClassReferences()
{
$container = new Container;
- $result = $container->call('Illuminate\Tests\Container\ContainerTestCallStub@work', ['foo', 'bar']);
+... | false |
Other | laravel | framework | 9e987784c934b9ab012f6c9360ef40646170d7f6.json | add missing docblock (#25853) | src/Illuminate/Encryption/EncryptionServiceProvider.php | @@ -34,6 +34,8 @@ public function register()
*
* @param array $config
* @return string
+ *
+ * @throws \RuntimeException
*/
protected function key(array $config)
{ | false |
Other | laravel | framework | f0312c117ac50361edbcdc2fc2225ae67ecaa060.json | Simplify MorphOneOrMany (#25864) | src/Illuminate/Database/Eloquent/Relations/MorphOneOrMany.php | @@ -67,19 +67,6 @@ public function addEagerConstraints(array $models)
$this->query->where($this->morphType, $this->morphClass);
}
- /**
- * Attach a model instance to the parent model.
- *
- * @param \Illuminate\Database\Eloquent\Model $model
- * @return \Illuminate\Database\Eloquen... | false |
Other | laravel | framework | 5e6473ecc12d9edae6c7a406b457ed08fc4611e2.json | add output to seeder (#25872) | src/Illuminate/Database/Console/Seeds/SeedCommand.php | @@ -62,6 +62,8 @@ public function handle()
Model::unguarded(function () {
$this->getSeeder()->__invoke();
});
+
+ $this->info('Database seeding completed successfully.');
}
/** | false |
Other | laravel | framework | b65cf424d6bf8f820a9ab97c02551e56dde769ff.json | fix auth (#25873) | src/Illuminate/Foundation/Testing/Concerns/InteractsWithAuthentication.php | @@ -29,6 +29,10 @@ public function actingAs(UserContract $user, $driver = null)
*/
public function be(UserContract $user, $driver = null)
{
+ if (isset($user->wasRecentlyCreated) && $user->wasRecentlyCreated) {
+ $user->wasRecentlyCreated = false;
+ }
+
$this->app['auth... | false |
Other | laravel | framework | 54d33832ec1e9c3c0a894c941334e2a6ba6d2be6.json | Trim model class name (#25849)
When passing php class names in middleware, for example
```
->middleware('can:create, App\Models\JobDocument);
```
Developer can accidentally add a whitespace before class name.
This whitespace will cause the linked policy to not found and
cause a 403 http response. | src/Illuminate/Auth/Middleware/Authorize.php | @@ -72,7 +72,7 @@ protected function getGateArguments($request, $models)
*/
protected function getModel($request, $model)
{
- return $this->isClassName($model) ? $model : $request->route($model, $model);
+ return $this->isClassName($model) ? trim($model) : $request->route($model, $model);
... | false |
Other | laravel | framework | 19e7b7b931544f89c875b1e94968ce70c7937533.json | Fix each() on BelongsToMany relationships (#25832) | src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php | @@ -673,6 +673,24 @@ public function chunk($count, callable $callback)
});
}
+ /**
+ * Execute a callback over each item while chunking.
+ *
+ * @param callable $callback
+ * @param int $count
+ * @return bool
+ */
+ public function each(callable $callback, $count = 100... | true |
Other | laravel | framework | 19e7b7b931544f89c875b1e94968ce70c7937533.json | Fix each() on BelongsToMany relationships (#25832) | tests/Database/DatabaseEloquentIntegrationTest.php | @@ -737,6 +737,18 @@ public function testBelongsToManyRelationshipModelsAreProperlyHydratedOverChunke
});
}
+ public function testBelongsToManyRelationshipModelsAreProperlyHydratedOverEachRequest()
+ {
+ $user = EloquentTestUser::create(['email' => 'taylorotwell@gmail.com']);
+ $frie... | true |
Other | laravel | framework | 473ffd34889673a3730456672fdba281febf0737.json | Apply fixes from StyleCI (#25841) | src/Illuminate/Http/Resources/Json/JsonResource.php | @@ -113,7 +113,7 @@ public function toArray($request)
if (is_null($this->resource)) {
return [];
}
-
+
return is_array($this->resource)
? $this->resource
: $this->resource->toArray(); | false |
Other | laravel | framework | e8dc4057c48bb2b2b7607cb4cf2b84a5e2c64db5.json | Remove variable (#25805) | src/Illuminate/Support/Collection.php | @@ -207,9 +207,7 @@ public function median($key = null)
*/
public function mode($key = null)
{
- $count = $this->count();
-
- if ($count == 0) {
+ if ($this->count() == 0) {
return;
}
| false |
Other | laravel | framework | 06118cac748d9465da4e398dd4d16c2045760c27.json | Fix assertions (#25800) | tests/Foundation/FoundationApplicationTest.php | @@ -35,7 +35,7 @@ public function testServiceProvidersAreCorrectlyRegistered()
$app = new Application;
$app->register($provider);
- $this->assertTrue(in_array($class, $app->getLoadedProviders()));
+ $this->assertArrayHasKey($class, $app->getLoadedProviders());
}
public func... | false |
Other | laravel | framework | d618cf3326468086ae9ab5ba1ee556be6182a481.json | Attach all disk attachments and not only first one | src/Illuminate/Mail/Mailable.php | @@ -381,7 +381,7 @@ protected function buildDiskAttachments($message)
FilesystemFactory::class
)->disk($attachment['disk']);
- return $message->attachData(
+ $message->attachData(
$storage->get($attachment['path']),
$attachment['nam... | false |
Other | laravel | framework | 852ff285db8c62e64e61e7c8b88d4671cffa0736.json | Update email.blade.php (#25734) | src/Illuminate/Notifications/resources/views/email.blade.php | @@ -53,12 +53,12 @@
@component('mail::subcopy')
@lang(
"If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\n".
- 'into your web browser: [:actionURL](:actionURL)',
+ 'into your web browser: ',
[
- 'actionText' => $actionText,
- 'actionURL' => $acti... | false |
Other | laravel | framework | 3c397ea1f4c7af4346f4f83144ea8d3ff307f405.json | Update email.blade.php (#25723) | src/Illuminate/Notifications/resources/views/email.blade.php | @@ -51,12 +51,12 @@
@component('mail::subcopy')
@lang(
"If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\n".
- 'into your web browser: [:actionURL](:actionURL)',
+ 'into your web browser: ',
[
- 'actionText' => $actionText,
- 'actionURL' => $acti... | false |
Other | laravel | framework | f40acde14483f4f534c82cae3232fed378650664.json | Use url() instead of plain url (#25725) | src/Illuminate/Foundation/Exceptions/views/illustrated-layout.blade.php | @@ -469,7 +469,7 @@
@yield('message')
</p>
- <a href="/">
+ <a href="{{ url('/') }}">
<button class="bg-transparent text-grey-darkest font-bold uppercase tracking-wide py-3 px-6 border-2 border-grey-light hove... | false |
Other | laravel | framework | 23f259aeacabf532041a926e7c262789760063ea.json | Remove trailing newline from hot url (#25699) | src/Illuminate/Foundation/helpers.php | @@ -581,7 +581,7 @@ function mix($path, $manifestDirectory = '')
}
if (file_exists(public_path($manifestDirectory.'/hot'))) {
- $url = file_get_contents(public_path($manifestDirectory.'/hot'));
+ $url = rtrim(file_get_contents(public_path($manifestDirectory.'/hot')));
... | false |
Other | laravel | framework | 7dc3d8d35ad8bcd3b18334a44320e3162b9f6dc1.json | add callback hook for building mailable data | src/Illuminate/Mail/Mailable.php | @@ -132,6 +132,13 @@ class Mailable implements MailableContract, Renderable
*/
public $callbacks = [];
+ /**
+ * The callback that should be invoked while building the view data.
+ *
+ * @var callable
+ */
+ public static $viewDataCallback;
+
/**
* Send the message using th... | false |
Other | laravel | framework | dcf6f41c49d47b8edc90bc0249766be1a409b954.json | Fix EventTest testBuildCommand on Windows (#25646)
* Fix EventTest testBuildCommand on Windows
* Fix code style
* Fix filesystem tests on Windows
* Fix file permission tests on Windows
* Fix wrong separator in expected path on Windows
* Fix wrong quotes in expected commands on Windows | tests/Console/Scheduling/EventTest.php | @@ -15,20 +15,20 @@ public function tearDown()
public function testBuildCommand()
{
- $quote = (DIRECTORY_SEPARATOR == '\\') ? '"' : "'";
+ $isWindows = DIRECTORY_SEPARATOR == '\\';
+ $quote = ($isWindows) ? '"' : "'";
$event = new Event(m::mock('Illuminate\Console\Scheduling... | true |
Other | laravel | framework | dcf6f41c49d47b8edc90bc0249766be1a409b954.json | Fix EventTest testBuildCommand on Windows (#25646)
* Fix EventTest testBuildCommand on Windows
* Fix code style
* Fix filesystem tests on Windows
* Fix file permission tests on Windows
* Fix wrong separator in expected path on Windows
* Fix wrong quotes in expected commands on Windows | tests/Database/DatabaseMigrationRefreshCommandTest.php | @@ -35,7 +35,8 @@ public function testRefreshCommandCallsCommandsWithProperArguments()
$console->shouldReceive('find')->with('migrate:reset')->andReturn($resetCommand);
$console->shouldReceive('find')->with('migrate')->andReturn($migrateCommand);
- $resetCommand->shouldReceive('run')->with(ne... | true |
Other | laravel | framework | dcf6f41c49d47b8edc90bc0249766be1a409b954.json | Fix EventTest testBuildCommand on Windows (#25646)
* Fix EventTest testBuildCommand on Windows
* Fix code style
* Fix filesystem tests on Windows
* Fix file permission tests on Windows
* Fix wrong separator in expected path on Windows
* Fix wrong quotes in expected commands on Windows | tests/Database/DatabaseMigrationResetCommandTest.php | @@ -23,7 +23,7 @@ public function testResetCommandCallsMigratorWithProperArguments()
$migrator->shouldReceive('paths')->once()->andReturn([]);
$migrator->shouldReceive('setConnection')->once()->with(null);
$migrator->shouldReceive('repositoryExists')->once()->andReturn(true);
- $migrat... | true |
Other | laravel | framework | dcf6f41c49d47b8edc90bc0249766be1a409b954.json | Fix EventTest testBuildCommand on Windows (#25646)
* Fix EventTest testBuildCommand on Windows
* Fix code style
* Fix filesystem tests on Windows
* Fix file permission tests on Windows
* Fix wrong separator in expected path on Windows
* Fix wrong quotes in expected commands on Windows | tests/Database/DatabaseMigrationRollbackCommandTest.php | @@ -22,7 +22,7 @@ public function testRollbackCommandCallsMigratorWithProperArguments()
$command->setLaravel($app);
$migrator->shouldReceive('paths')->once()->andReturn([]);
$migrator->shouldReceive('setConnection')->once()->with(null);
- $migrator->shouldReceive('rollback')->once()->w... | true |
Other | laravel | framework | dcf6f41c49d47b8edc90bc0249766be1a409b954.json | Fix EventTest testBuildCommand on Windows (#25646)
* Fix EventTest testBuildCommand on Windows
* Fix code style
* Fix filesystem tests on Windows
* Fix file permission tests on Windows
* Fix wrong separator in expected path on Windows
* Fix wrong quotes in expected commands on Windows | tests/Filesystem/FilesystemAdapterTest.php | @@ -61,7 +61,7 @@ public function testPath()
{
$this->filesystem->write('file.txt', 'Hello World');
$filesystemAdapter = new FilesystemAdapter($this->filesystem);
- $this->assertEquals($this->tempDir.'/file.txt', $filesystemAdapter->path('file.txt'));
+ $this->assertEquals($this->te... | true |
Other | laravel | framework | dcf6f41c49d47b8edc90bc0249766be1a409b954.json | Fix EventTest testBuildCommand on Windows (#25646)
* Fix EventTest testBuildCommand on Windows
* Fix code style
* Fix filesystem tests on Windows
* Fix file permission tests on Windows
* Fix wrong separator in expected path on Windows
* Fix wrong quotes in expected commands on Windows | tests/Filesystem/FilesystemTest.php | @@ -47,7 +47,8 @@ public function testSetChmod()
$files = new Filesystem;
$files->chmod($this->tempDir.'/file.txt', 0755);
$filePermission = substr(sprintf('%o', fileperms($this->tempDir.'/file.txt')), -4);
- $this->assertEquals('0755', $filePermission);
+ $expectedPermissions =... | true |
Other | laravel | framework | 94f0c26186b3df2f34ac71767a75a0cb100bc823.json | Fix little typo in test function name (#25595) | tests/Database/DatabaseEloquentBuilderTest.php | @@ -362,7 +362,7 @@ public function testPluckReturnsTheDateAttributesOfAModel()
$this->assertEquals(['date_2010-01-01 00:00:00', 'date_2011-01-01 00:00:00'], $builder->pluck('created_at')->all());
}
- public function testPluckWithoutModelGetterJustReturnTheAttributesFoundInDatabase()
+ public func... | false |
Other | laravel | framework | ef681e23923540ddc9021af8b1e8c075faebaace.json | Handle Carbon 2 tests | tests/Support/DateFacadeTest.php | @@ -78,7 +78,7 @@ public function testCarbonImmutable()
'locale' => 'fr',
]));
$this->assertSame('fr', Date::now()->locale);
- Date::swap(null);
+ Date::swap(Carbon::class);
$this->assertSame('en', Date::now()->locale);
include_once __DIR__.'/fixtures/Custo... | true |
Other | laravel | framework | ef681e23923540ddc9021af8b1e8c075faebaace.json | Handle Carbon 2 tests | tests/Support/SupportCarbonTest.php | @@ -4,6 +4,7 @@
use DateTime;
use DateTimeInterface;
+use Carbon\CarbonImmutable;
use Illuminate\Support\Carbon;
use PHPUnit\Framework\TestCase;
use Carbon\Carbon as BaseCarbon;
@@ -87,7 +88,7 @@ public function testCarbonAllowsCustomSerializer()
public function testCarbonCanSerializeToJson()
{
- ... | true |
Other | laravel | framework | ac42a58f42dbbd25afa1eceb32db8c3334c04bfe.json | Prevent command double calling | src/Illuminate/Foundation/Testing/PendingCommand.php | @@ -47,6 +47,13 @@ class PendingCommand
*/
protected $expectedExitCode;
+ /**
+ * Determine if command was called.
+ *
+ * @var bool
+ */
+ private $isCalled = false;
+
/**
* Create a new pending console command run.
*
@@ -111,6 +118,8 @@ public function assertExitCod... | false |
Other | laravel | framework | 70a72fcac9d8852fc1a4ce11eb47842774c11876.json | add storeOutput method | src/Illuminate/Console/Scheduling/Event.php | @@ -338,6 +338,18 @@ public function filtersPass($app)
return true;
}
+ /**
+ * Ensure that the output is stored on disk in a log file.
+ *
+ * @return $this
+ */
+ public function storeOutput()
+ {
+ $this->ensureOutputIsBeingCaptured();
+
+ return $this;
+ }
+... | false |
Other | laravel | framework | f12df3e2061707720671327ef67decd364b0184e.json | Remove unused view tests (#25551) | tests/View/ViewBladeCompilerTest.php | @@ -96,16 +96,4 @@ protected function getFiles()
{
return m::mock('Illuminate\Filesystem\Filesystem');
}
-
- public function testGetTagsProvider()
- {
- return [
- ['{{', '}}'],
- ['{{{', '}}}'],
- ['[[', ']]'],
- ['[[[', ']]]'],
- [... | false |
Other | laravel | framework | b37b7caa6e74e01da76ca403796835156fe0304e.json | Add options array | src/Illuminate/Mail/TransportManager.php | @@ -77,9 +77,10 @@ protected function createSesDriver()
'version' => 'latest', 'service' => 'email',
]);
- return new SesTransport(new SesClient(
- $this->addSesCredentials($config)
- ));
+ return new SesTransport(
+ new SesClient($this->addSesCredentia... | false |
Other | laravel | framework | e21b17fd277b9a2424ea2b3f727325d1df65c713.json | Add options for SES’s sendRawEmail | src/Illuminate/Mail/Transport/SesTransport.php | @@ -14,15 +14,24 @@ class SesTransport extends Transport
*/
protected $ses;
+ /**
+ * Transmission options.
+ *
+ * @var array
+ */
+ protected $options = [];
+
/**
* Create a new SES transport instance.
*
* @param \Aws\Ses\SesClient $ses
+ * @param array... | false |
Other | laravel | framework | a8cf7f4b82762b4738f605e04da637227c7de5a8.json | Add test for the Model push method (#25519) | tests/Integration/Database/EloquentPushTest.php | @@ -0,0 +1,90 @@
+<?php
+
+namespace Illuminate\Tests\Integration\Database;
+
+use Illuminate\Support\Facades\Schema;
+use Illuminate\Database\Eloquent\Model;
+use Illuminate\Database\Schema\Blueprint;
+
+/**
+ * @group integration
+ */
+class EloquentPushTest extends DatabaseTestCase
+{
+ public function setUp()
+ ... | false |
Other | laravel | framework | 1ac97b810cc502c71d7f6ae9d08a7f0b010c9ed3.json | Apply StyleCI fixes. | tests/Validation/ValidationValidatorTest.php | @@ -1540,7 +1540,7 @@ public function testValidateGtPlaceHolderIsReplacedProperly()
'validation.gt.numeric' => ':value',
'validation.gt.string' => ':value',
'validation.gt.file' => ':value',
- 'validation.gt.array' => ':value'
+ 'validation.gt.array' => ':val... | false |
Other | laravel | framework | deeb649e07fdffae98c68f3b5753a64ec0fda537.json | remove getDefaultNamespace method (#25510) | src/Illuminate/Foundation/Console/ModelMakeCommand.php | @@ -125,17 +125,6 @@ protected function getStub()
return __DIR__.'/stubs/model.stub';
}
- /**
- * Get the default namespace for the class.
- *
- * @param string $rootNamespace
- * @return string
- */
- protected function getDefaultNamespace($rootNamespace)
- {
- ret... | false |
Other | laravel | framework | eaac77bfb878b49f2ceff4fb09198e437d38683d.json | fix bug with invokables | src/Illuminate/Console/Scheduling/CallbackEvent.php | @@ -71,7 +71,9 @@ public function run(Container $container)
parent::callBeforeCallbacks($container);
try {
- $response = $container->call($this->callback, $this->parameters);
+ $response = is_object($this->callback)
+ ? $container->call([$this->callback, ... | false |
Other | laravel | framework | 22cdcf7cd02a6e35146b4737321a7ce18a075d43.json | Apply fixes from StyleCI (#25489) | tests/Integration/Console/ConsoleApplicationTest.php | @@ -5,7 +5,6 @@
use Illuminate\Console\Command;
use Orchestra\Testbench\TestCase;
use Illuminate\Contracts\Console\Kernel;
-use Illuminate\Foundation\Testing\PendingCommand;
class ConsoleApplicationTest extends TestCase
{ | false |
Other | laravel | framework | 97b6deec70ed6592b529b29f13c1b10a05c2be5c.json | add missing docblock (#25477) | src/Illuminate/Routing/Console/ControllerMakeCommand.php | @@ -150,6 +150,8 @@ protected function buildModelReplacements(array $replace)
*
* @param string $model
* @return string
+ *
+ * @throws \InvalidArgumentException
*/
protected function parseModel($model)
{ | false |
Other | laravel | framework | 327d5d6410b1c9c392393808428da003710f45f1.json | Add missing docblock. (#25486) | src/Illuminate/Mail/Transport/MailgunTransport.php | @@ -41,6 +41,7 @@ class MailgunTransport extends Transport
* @param \GuzzleHttp\ClientInterface $client
* @param string $key
* @param string $domain
+ * @param string|null $endpoint
* @return void
*/
public function __construct(ClientInterface $client, $key, $domain, $endp... | false |
Other | laravel | framework | 7aeff1d4393afba36c52e301726d848e2a373b12.json | Add the ability to skip algorithm checking | src/Illuminate/Hashing/Argon2IdHasher.php | @@ -16,7 +16,7 @@ class Argon2IdHasher extends ArgonHasher
*/
public function check($value, $hashedValue, array $options = [])
{
- if ($this->info($hashedValue)['algoName'] !== 'argon2id') {
+ if ($this->verifyAlgorithm && $this->info($hashedValue)['algoName'] !== 'argon2id') {
... | true |
Other | laravel | framework | 7aeff1d4393afba36c52e301726d848e2a373b12.json | Add the ability to skip algorithm checking | src/Illuminate/Hashing/ArgonHasher.php | @@ -28,6 +28,13 @@ class ArgonHasher extends AbstractHasher implements HasherContract
*/
protected $threads = 2;
+ /**
+ * Indicates whether to perform an algorithm check.
+ *
+ * @var bool
+ */
+ protected $verifyAlgorithm = true;
+
/**
* Create a new hasher instance.
... | true |
Other | laravel | framework | 7aeff1d4393afba36c52e301726d848e2a373b12.json | Add the ability to skip algorithm checking | src/Illuminate/Hashing/BcryptHasher.php | @@ -14,6 +14,13 @@ class BcryptHasher extends AbstractHasher implements HasherContract
*/
protected $rounds = 10;
+ /**
+ * Indicates whether to perform an algorithm check.
+ *
+ * @var bool
+ */
+ protected $verifyAlgorithm = true;
+
/**
* Create a new hasher instance.
... | true |
Other | laravel | framework | 6b207dfe4ce5e66be9638e02b8d2be9f190e823c.json | Add Test suffix to misnamed tests (#25471) | tests/Database/DatabaseEloquentCastsDatabaseStringTest.php | @@ -6,7 +6,7 @@
use Illuminate\Database\Capsule\Manager as DB;
use Illuminate\Database\Eloquent\Model as Eloquent;
-class DatabaseEloquentCastsDatabaseString extends TestCase
+class DatabaseEloquentCastsDatabaseStringTest extends TestCase
{
public function setUp()
{ | true |
Other | laravel | framework | 6b207dfe4ce5e66be9638e02b8d2be9f190e823c.json | Add Test suffix to misnamed tests (#25471) | tests/Database/DatabaseEloquentTimestampsTest.php | @@ -7,7 +7,7 @@
use Illuminate\Database\Capsule\Manager as DB;
use Illuminate\Database\Eloquent\Model as Eloquent;
-class DatabaseEloquentTimestamps extends TestCase
+class DatabaseEloquentTimestampsTest extends TestCase
{
public function setUp()
{ | true |
Other | laravel | framework | 61396302621d3391721094c71b5fb75860c97bb4.json | Add getStreamedContent to TestResponse class | src/Illuminate/Foundation/Testing/TestResponse.php | @@ -9,6 +9,7 @@
use Illuminate\Contracts\View\View;
use Illuminate\Support\Traits\Macroable;
use PHPUnit\Framework\Assert as PHPUnit;
+use Symfony\Component\HttpFoundation\StreamedResponse;
use Illuminate\Foundation\Testing\Constraints\SeeInOrder;
/**
@@ -27,6 +28,13 @@ class TestResponse
*/
public $b... | false |
Other | laravel | framework | 4e84bdcdffcdb05f5b008456a8c77d5d64233c60.json | Apply fixes from StyleCI (#25462) | src/Illuminate/Auth/MustVerifyEmail.php | @@ -22,7 +22,7 @@ public function hasVerifiedEmail()
public function markEmailAsVerified()
{
return $this->forceFill([
- 'email_verified_at' => $this->freshTimestamp()
+ 'email_verified_at' => $this->freshTimestamp(),
])->save();
}
| false |
Other | laravel | framework | 045cbfd95c611928aef1b877d1a3dc60d5f19580.json | Send an event when the user's email is verified
Upon user email verification we may like to take certain immediate actions. For example, once we have verified that the user has a valid email from a certain company domain, we may assign a role automatically. | src/Illuminate/Auth/Events/Verified.php | @@ -0,0 +1,28 @@
+<?php
+
+namespace Illuminate\Auth\Events;
+
+use Illuminate\Queue\SerializesModels;
+
+class Verified
+{
+ use SerializesModels;
+
+ /**
+ * The verified user.
+ *
+ * @var \Illuminate\Contracts\Auth\MustVerifyEmail
+ */
+ public $user;
+
+ /**
+ * Create a new event i... | true |
Other | laravel | framework | 045cbfd95c611928aef1b877d1a3dc60d5f19580.json | Send an event when the user's email is verified
Upon user email verification we may like to take certain immediate actions. For example, once we have verified that the user has a valid email from a certain company domain, we may assign a role automatically. | src/Illuminate/Auth/MustVerifyEmail.php | @@ -17,11 +17,11 @@ public function hasVerifiedEmail()
/**
* Mark the given user's email as verified.
*
- * @return void
+ * @return bool
*/
public function markEmailAsVerified()
{
- $this->forceFill(['email_verified_at' => $this->freshTimestamp()])->save();
+ retu... | true |
Other | laravel | framework | 045cbfd95c611928aef1b877d1a3dc60d5f19580.json | Send an event when the user's email is verified
Upon user email verification we may like to take certain immediate actions. For example, once we have verified that the user has a valid email from a certain company domain, we may assign a role automatically. | src/Illuminate/Foundation/Auth/VerifiesEmails.php | @@ -2,6 +2,7 @@
namespace Illuminate\Foundation\Auth;
+use Illuminate\Auth\Events\Verified;
use Illuminate\Http\Request;
trait VerifiesEmails
@@ -30,7 +31,9 @@ public function show(Request $request)
public function verify(Request $request)
{
if ($request->route('id') == $request->user()->get... | true |
Other | laravel | framework | b3fe47783d2a0bd6557c1744c3d711cd73c7198c.json | Show maintenance message on error page (#25431) | src/Illuminate/Foundation/Exceptions/views/503.blade.php | @@ -8,4 +8,4 @@
</div>
@endsection
-@section('message', __('Sorry, we are doing some maintenance. Please check back soon.'))
+@section('message', __($exception->getMessage() ?: 'Sorry, we are doing some maintenance. Please check back soon.')) | false |
Other | laravel | framework | a8c505652b24ee7ca695033737ca7a992e750ac6.json | Fix nullable MorphTo and $touches | src/Illuminate/Database/Eloquent/Relations/MorphTo.php | @@ -223,6 +223,21 @@ public function dissociate()
return $this->parent->setRelation($this->relation, null);
}
+ /**
+ * Touch all of the related models for the relationship.
+ *
+ * @return void
+ */
+ public function touch()
+ {
+ // If there is no related model, we'll j... | true |
Other | laravel | framework | a8c505652b24ee7ca695033737ca7a992e750ac6.json | Fix nullable MorphTo and $touches | tests/Integration/Database/EloquentMorphToTouchesTest.php | @@ -0,0 +1,67 @@
+<?php
+
+namespace Illuminate\Tests\Integration\Database\EloquentMorphToTouchesTest;
+
+use Illuminate\Support\Facades\Schema;
+use Illuminate\Database\Eloquent\Model;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Tests\Integration\Database\DatabaseTestCase;
+
+/**
+ * @group integration
... | true |
Other | laravel | framework | 40ccbc3497198333d3c75c51729d94bb32c77d0d.json | Pass authorization by default (#25417) | src/Illuminate/Foundation/Http/FormRequest.php | @@ -150,7 +150,7 @@ protected function passesAuthorization()
return $this->container->call([$this, 'authorize']);
}
- return false;
+ return true;
}
/** | false |
Other | laravel | framework | c074c11bf172e44c5dd2e7acf753f7c1da8efca1.json | Use 4 spaces in views (#25418) | src/Illuminate/Foundation/Exceptions/views/illustrated-layout.blade.php | @@ -1,485 +1,485 @@
<!doctype html>
<html lang="en">
- <head>
- <title>@yield('title')</title>
-
- <meta charset="utf-8">
- <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
-
- <!-- Fonts -->
- <link href="https://fonts.googleapis.com/css?family=Nunito" rel="style... | false |
Other | laravel | framework | 83bd575a3f14a9b48114b9f06b723dcdbe0aa061.json | Fix the return types for Command methods (#25425) | src/Illuminate/Console/Command.php | @@ -315,7 +315,7 @@ public function confirm($question, $default = false)
*
* @param string $question
* @param string|null $default
- * @return string
+ * @return mixed
*/
public function ask($question, $default = null)
{
@@ -328,7 +328,7 @@ public function ask($question, $d... | false |
Other | laravel | framework | 9d8452da5511c72592d14a1d59abda34506d104b.json | Translate error messsages (#25395) | src/Illuminate/Foundation/Exceptions/views/403.blade.php | @@ -1,11 +1,11 @@
@extends('errors::illustrated-layout')
@section('code', '403')
-@section('title', 'Unauthorized')
+@section('title', __('Unauthorized'))
@section('image')
<div style="background-image: url('/svg/403.svg');" class="absolute pin bg-cover bg-no-repeat md:bg-left lg:bg-center">
</div>
@endsectio... | true |
Other | laravel | framework | 9d8452da5511c72592d14a1d59abda34506d104b.json | Translate error messsages (#25395) | src/Illuminate/Foundation/Exceptions/views/404.blade.php | @@ -1,11 +1,11 @@
@extends('errors::illustrated-layout')
@section('code', '404')
-@section('title', 'Page Not Found')
+@section('title', __('Page Not Found'))
@section('image')
<div style="background-image: url('/svg/404.svg');" class="absolute pin bg-cover bg-no-repeat md:bg-left lg:bg-center">
</div>
@endse... | true |
Other | laravel | framework | 9d8452da5511c72592d14a1d59abda34506d104b.json | Translate error messsages (#25395) | src/Illuminate/Foundation/Exceptions/views/419.blade.php | @@ -1,11 +1,11 @@
@extends('errors::illustrated-layout')
@section('code', '419')
-@section('title', 'Page Expired')
+@section('title', __('Page Expired'))
@section('image')
<div style="background-image: url('/svg/403.svg');" class="absolute pin bg-cover bg-no-repeat md:bg-left lg:bg-center">
</div>
@endsectio... | true |
Other | laravel | framework | 9d8452da5511c72592d14a1d59abda34506d104b.json | Translate error messsages (#25395) | src/Illuminate/Foundation/Exceptions/views/429.blade.php | @@ -1,11 +1,11 @@
@extends('errors::illustrated-layout')
@section('code', '429')
-@section('title', 'Too Many Requests')
+@section('title', __('Too Many Requests'))
@section('image')
<div style="background-image: url('/svg/403.svg');" class="absolute pin bg-cover bg-no-repeat md:bg-left lg:bg-center">
</div>
... | true |
Other | laravel | framework | 9d8452da5511c72592d14a1d59abda34506d104b.json | Translate error messsages (#25395) | src/Illuminate/Foundation/Exceptions/views/500.blade.php | @@ -1,11 +1,11 @@
@extends('errors::illustrated-layout')
@section('code', '500')
-@section('title', 'Error')
+@section('title', __('Error'))
@section('image')
<div style="background-image: url('/svg/500.svg');" class="absolute pin bg-cover bg-no-repeat md:bg-left lg:bg-center">
</div>
@endsection
-@section(... | true |
Other | laravel | framework | 9d8452da5511c72592d14a1d59abda34506d104b.json | Translate error messsages (#25395) | src/Illuminate/Foundation/Exceptions/views/503.blade.php | @@ -1,11 +1,11 @@
@extends('errors::illustrated-layout')
@section('code', '503')
-@section('title', 'Service Unavailable')
+@section('title', __('Service Unavailable'))
@section('image')
<div style="background-image: url('/svg/503.svg');" class="absolute pin bg-cover bg-no-repeat md:bg-left lg:bg-center">
</di... | true |
Other | laravel | framework | 9d8452da5511c72592d14a1d59abda34506d104b.json | Translate error messsages (#25395) | src/Illuminate/Foundation/Exceptions/views/illustrated-layout.blade.php | @@ -460,7 +460,7 @@
<div class="w-full md:w-1/2 bg-white flex items-center justify-center">
<div class="max-w-sm m-8">
<div class="text-black text-5xl md:text-15xl font-black">
- @yield('code', 'Oh no')
+ @yield('code', __('Oh no'))
</div>
<div cl... | true |
Other | laravel | framework | 2265a8c9a110679c041da2f9bbe407e732e49071.json | add new error pages | src/Illuminate/Foundation/Exceptions/views/403.blade.php | @@ -0,0 +1,11 @@
+@extends('errors::layout')
+
+@section('code', '403')
+@section('title', 'Unauthorized')
+
+@section('image')
+<div style="background-image: url('/svg/403.svg');" class="absolute pin bg-cover bg-no-repeat md:bg-left lg:bg-center">
+</div>
+@endsection
+
+@section('message', 'Sorry, you may not access ... | true |
Other | laravel | framework | 2265a8c9a110679c041da2f9bbe407e732e49071.json | add new error pages | src/Illuminate/Foundation/Exceptions/views/404.blade.php | @@ -1,5 +1,11 @@
@extends('errors::layout')
+@section('code', '404')
@section('title', 'Page Not Found')
+@section('image')
+<div style="background-image: url('/svg/404.svg');" class="absolute pin bg-cover bg-no-repeat md:bg-left lg:bg-center">
+</div>
+@endsection
+
@section('message', 'Sorry, the page you are ... | true |
Other | laravel | framework | 2265a8c9a110679c041da2f9bbe407e732e49071.json | add new error pages | src/Illuminate/Foundation/Exceptions/views/419.blade.php | @@ -1,9 +1,11 @@
@extends('errors::layout')
+@section('code', '419')
@section('title', 'Page Expired')
-@section('message')
- The page has expired due to inactivity.
- <br/><br/>
- Please refresh and try again.
-@stop
+@section('image')
+<div style="background-image: url('/svg/403.svg');" class="absolute... | true |
Other | laravel | framework | 2265a8c9a110679c041da2f9bbe407e732e49071.json | add new error pages | src/Illuminate/Foundation/Exceptions/views/429.blade.php | @@ -1,5 +1,11 @@
@extends('errors::layout')
-@section('title', 'Error')
+@section('code', '429')
+@section('title', 'Too Many Requests')
-@section('message', 'Too many requests.')
+@section('image')
+<div style="background-image: url('/svg/403.svg');" class="absolute pin bg-cover bg-no-repeat md:bg-left lg:bg-cent... | true |
Other | laravel | framework | 2265a8c9a110679c041da2f9bbe407e732e49071.json | add new error pages | src/Illuminate/Foundation/Exceptions/views/500.blade.php | @@ -1,5 +1,11 @@
@extends('errors::layout')
+@section('code', '500')
@section('title', 'Error')
-@section('message', 'Whoops, looks like something went wrong.')
+@section('image')
+<div style="background-image: url('/svg/500.svg');" class="absolute pin bg-cover bg-no-repeat md:bg-left lg:bg-center">
+</div>
+@end... | true |
Other | laravel | framework | 2265a8c9a110679c041da2f9bbe407e732e49071.json | add new error pages | src/Illuminate/Foundation/Exceptions/views/503.blade.php | @@ -1,5 +1,11 @@
@extends('errors::layout')
+@section('code', '503')
@section('title', 'Service Unavailable')
-@section('message', 'Be right back.')
+@section('image')
+<div style="background-image: url('/svg/503.svg');" class="absolute pin bg-cover bg-no-repeat md:bg-left lg:bg-center">
+</div>
+@endsection
+
+@... | true |
Other | laravel | framework | 2265a8c9a110679c041da2f9bbe407e732e49071.json | add new error pages | src/Illuminate/Foundation/Exceptions/views/layout.blade.php | @@ -1,57 +1,483 @@
-<!DOCTYPE html>
+<!doctype html>
<html lang="en">
- <head>
- <meta charset="utf-8">
- <meta http-equiv="X-UA-Compatible" content="IE=edge">
- <meta name="viewport" content="width=device-width, initial-scale=1">
-
- <title>@yield('title')</title>
-
- <!-- Fonts ... | true |
Other | laravel | framework | 2265a8c9a110679c041da2f9bbe407e732e49071.json | add new error pages | src/Illuminate/Foundation/Exceptions/views/legacy-layout.blade.php | @@ -0,0 +1,57 @@
+<!DOCTYPE html>
+<html lang="en">
+ <head>
+ <meta charset="utf-8">
+ <meta http-equiv="X-UA-Compatible" content="IE=edge">
+ <meta name="viewport" content="width=device-width, initial-scale=1">
+
+ <title>@yield('title')</title>
+
+ <!-- Fonts -->
+ <link ... | true |
Other | laravel | framework | c88acdf0880a551f3ee2a99900efbb458afef135.json | Fix Builder PHPDoc (#25367) | src/Illuminate/Database/Query/Builder.php | @@ -1061,7 +1061,7 @@ public function orWhereNotNull($column)
*
* @param string $column
* @param string $operator
- * @param \DateTimeInterface|string|int $value
+ * @param \DateTimeInterface|string $value
* @param string $boolean
* @return \Illuminate\Database\Query\Buil... | false |
Other | laravel | framework | 1d566d0dece7f0d2e640bc257845b19ad398ed53.json | Fix param docblock. (#25364) | src/Illuminate/Support/Optional.php | @@ -45,7 +45,7 @@ public function __get($key)
/**
* Dynamically check a property exists on the underlying object.
*
- * @param $name
+ * @param mixed $name
* @return bool
*/
public function __isset($name) | false |
Other | laravel | framework | b3079f35c0470e4615a2aa3abd9a50fff412c3c5.json | Simplify facade to use swap method only | src/Illuminate/Support/Facades/Date.php | @@ -2,9 +2,7 @@
namespace Illuminate\Support\Facades;
-use DateTimeInterface;
use ReflectionException;
-use InvalidArgumentException;
use Illuminate\Support\Carbon;
/**
@@ -85,20 +83,6 @@
*/
class Date extends Facade
{
- /**
- * Date instance class name.
- *
- * @var string
- */
- pr... | true |
Other | laravel | framework | b3079f35c0470e4615a2aa3abd9a50fff412c3c5.json | Simplify facade to use swap method only | tests/Support/DateFacadeTest.php | @@ -14,8 +14,8 @@ class DateFacadeTest extends TestCase
protected function tearDown()
{
parent::tearDown();
- Date::use(Carbon::class);
- Date::intercept(function ($date) {
+ Date::swap(Carbon::class);
+ Date::swap(function ($date) {
return $date;
});... | true |
Other | laravel | framework | c5401623dcb8eb3b7511c821c60d97427579cac5.json | Use the getAttributes method on insert (#25355) | src/Illuminate/Database/Eloquent/Model.php | @@ -746,7 +746,7 @@ protected function performInsert(Builder $query)
// If the model has an incrementing key, we can use the "insertGetId" method on
// the query builder, which will give us back the final inserted ID for this
// table from the database. Not all tables have to be incrementing ... | false |
Other | laravel | framework | 9e0b94779f5a1ca38a10114a0a897509509d9d31.json | Use higher order messages in Collection (#25356) | src/Illuminate/Database/Eloquent/Collection.php | @@ -361,9 +361,7 @@ public function except($keys)
*/
public function makeHidden($attributes)
{
- return $this->each(function ($model) use ($attributes) {
- $model->addHidden($attributes);
- });
+ return $this->each->addHidden($attributes);
}
/**
@@ -374,9 +372... | false |
Other | laravel | framework | 61bdc1f845a1c91ddc1cfadb720052e815b493cc.json | Use the getAttributes method on insert (#25349)
Update the performInsert method to use getAttributes instead of accessing the property directly. | src/Illuminate/Database/Eloquent/Model.php | @@ -681,7 +681,7 @@ protected function performInsert(Builder $query)
// If the model has an incrementing key, we can use the "insertGetId" method on
// the query builder, which will give us back the final inserted ID for this
// table from the database. Not all tables have to be incrementing ... | false |
Other | laravel | framework | 8a221bf15334cdc864632f751736cc08d95e1cbb.json | Apply fixes from StyleCI (#25329) | src/Illuminate/Foundation/Testing/PendingCommand.php | @@ -3,10 +3,8 @@
namespace Illuminate\Foundation\Testing;
use Mockery;
-use Illuminate\Support\Str;
use Illuminate\Console\OutputStyle;
use Illuminate\Contracts\Console\Kernel;
-use Mockery\Exception\BadMethodCallException;
use Symfony\Component\Console\Input\ArrayInput;
use PHPUnit\Framework\TestCase as PHPUni... | false |
Other | laravel | framework | 947a4f8e518352698e1291dcd6417e36b7b1c70b.json | Fix whereTime() on SQL Server (#25316) | src/Illuminate/Database/Query/Grammars/SqlServerGrammar.php | @@ -103,6 +103,20 @@ protected function whereDate(Builder $query, $where)
return 'cast('.$this->wrap($where['column']).' as date) '.$where['operator'].' '.$value;
}
+ /**
+ * Compile a "where time" clause.
+ *
+ * @param \Illuminate\Database\Query\Builder $query
+ * @param array $... | true |
Other | laravel | framework | 947a4f8e518352698e1291dcd6417e36b7b1c70b.json | Fix whereTime() on SQL Server (#25316) | tests/Database/DatabaseQueryBuilderTest.php | @@ -404,6 +404,19 @@ public function testWhereTimeOperatorOptionalPostgres()
$this->assertEquals([0 => '22:00'], $builder->getBindings());
}
+ public function testWhereTimeSqlServer()
+ {
+ $builder = $this->getSqlServerBuilder();
+ $builder->select('*')->from('users')->whereTime('cr... | true |
Other | laravel | framework | 850b7531d42b6fcd8941b12339fb3135128ba518.json | Use getter method for access primary key (#25303) | src/Illuminate/Database/Eloquent/Model.php | @@ -1345,7 +1345,7 @@ public function resolveRouteBinding($value)
*/
public function getForeignKey()
{
- return Str::snake(class_basename($this)).'_'.$this->primaryKey;
+ return Str::snake(class_basename($this)).'_'.$this->getKeyName();
}
/** | false |
Other | laravel | framework | 8e7942b063d1bb0c8188f298177dcfb4e0141811.json | remove unused var (#25293) | src/Illuminate/Cache/Repository.php | @@ -172,7 +172,7 @@ protected function handleManyResult($keys, $key, $value)
*/
public function pull($key, $default = null)
{
- return tap($this->get($key, $default), function ($value) use ($key) {
+ return tap($this->get($key, $default), function () use ($key) {
$this->forget... | false |
Other | laravel | framework | f5d8c0a673aa9fc6cd94aa4858a0027fe550a22e.json | adjust argument order | src/Illuminate/Auth/Events/Attempting.php | @@ -4,6 +4,13 @@
class Attempting
{
+ /**
+ * The authentication guard implementation.
+ *
+ * @var \Illuminate\Contracts\Auth\StatefulGuard
+ */
+ public $guard;
+
/**
* The credentials for the user.
*
@@ -18,25 +25,18 @@ class Attempting
*/
public $remember;
- ... | true |
Other | laravel | framework | f5d8c0a673aa9fc6cd94aa4858a0027fe550a22e.json | adjust argument order | src/Illuminate/Auth/Events/Authenticated.php | @@ -9,27 +9,27 @@ class Authenticated
use SerializesModels;
/**
- * The authenticated user.
+ * The authentication guard implementation.
*
- * @var \Illuminate\Contracts\Auth\Authenticatable
+ * @var \Illuminate\Contracts\Auth\StatefulGuard
*/
- public $user;
+ public $guar... | true |
Other | laravel | framework | f5d8c0a673aa9fc6cd94aa4858a0027fe550a22e.json | adjust argument order | src/Illuminate/Auth/Events/Failed.php | @@ -4,6 +4,13 @@
class Failed
{
+ /**
+ * The authentication guard implementation.
+ *
+ * @var \Illuminate\Contracts\Auth\StatefulGuard
+ */
+ public $guard;
+
/**
* The user the attempter was trying to authenticate as.
*
@@ -18,25 +25,18 @@ class Failed
*/
public ... | true |
Other | laravel | framework | f5d8c0a673aa9fc6cd94aa4858a0027fe550a22e.json | adjust argument order | src/Illuminate/Auth/Events/Login.php | @@ -8,6 +8,13 @@ class Login
{
use SerializesModels;
+ /**
+ * The authentication guard implementation.
+ *
+ * @var \Illuminate\Contracts\Auth\StatefulGuard
+ */
+ public $guard;
+
/**
* The authenticated user.
*
@@ -22,25 +29,18 @@ class Login
*/
public $remem... | true |
Other | laravel | framework | f5d8c0a673aa9fc6cd94aa4858a0027fe550a22e.json | adjust argument order | src/Illuminate/Auth/Events/Logout.php | @@ -9,27 +9,27 @@ class Logout
use SerializesModels;
/**
- * The authenticated user.
+ * The authenticationg guard implementation.
*
- * @var \Illuminate\Contracts\Auth\Authenticatable
+ * @var \Illuminate\Contracts\Auth\StatefulGuard
*/
- public $user;
+ public $guard;
... | true |
Other | laravel | framework | f5d8c0a673aa9fc6cd94aa4858a0027fe550a22e.json | adjust argument order | src/Illuminate/Auth/SessionGuard.php | @@ -493,7 +493,7 @@ public function logout()
}
if (isset($this->events)) {
- $this->events->dispatch(new Events\Logout($user, $this));
+ $this->events->dispatch(new Events\Logout($this, $user));
}
// Once we have fired the logout event we will clear the user... | true |
Other | laravel | framework | 69cddedae349956c5f38455e861e3fc490d89a07.json | Add guard to authentication events | src/Illuminate/Auth/Events/Attempting.php | @@ -18,16 +18,25 @@ class Attempting
*/
public $remember;
+ /**
+ * The guard this attempt is made to.
+ *
+ * @var string
+ */
+ public $guard;
+
/**
* Create a new event instance.
*
* @param array $credentials
* @param bool $remember
+ * @param ... | true |
Other | laravel | framework | 69cddedae349956c5f38455e861e3fc490d89a07.json | Add guard to authentication events | src/Illuminate/Auth/Events/Authenticated.php | @@ -15,14 +15,23 @@ class Authenticated
*/
public $user;
+ /**
+ * The guard the user is authenticating to.
+ *
+ * @var string
+ */
+ public $guard;
+
/**
* Create a new event instance.
*
* @param \Illuminate\Contracts\Auth\Authenticatable $user
+ * @para... | true |
Other | laravel | framework | 69cddedae349956c5f38455e861e3fc490d89a07.json | Add guard to authentication events | src/Illuminate/Auth/Events/Failed.php | @@ -18,16 +18,25 @@ class Failed
*/
public $credentials;
+ /**
+ * The guard the user failed to authenticated to.
+ *
+ * @var string
+ */
+ public $guard;
+
/**
* Create a new event instance.
*
* @param \Illuminate\Contracts\Auth\Authenticatable|null $user
... | true |
Other | laravel | framework | 69cddedae349956c5f38455e861e3fc490d89a07.json | Add guard to authentication events | src/Illuminate/Auth/Events/Login.php | @@ -22,16 +22,25 @@ class Login
*/
public $remember;
+ /**
+ * The guard the user authenticated to.
+ *
+ * @var string
+ */
+ public $guard;
+
/**
* Create a new event instance.
*
* @param \Illuminate\Contracts\Auth\Authenticatable $user
* @param bool ... | true |
Other | laravel | framework | 69cddedae349956c5f38455e861e3fc490d89a07.json | Add guard to authentication events | src/Illuminate/Auth/Events/Logout.php | @@ -15,14 +15,23 @@ class Logout
*/
public $user;
+ /**
+ * The guard to which the user was authenticated.
+ *
+ * @var string
+ */
+ public $guard;
+
/**
* Create a new event instance.
*
* @param \Illuminate\Contracts\Auth\Authenticatable $user
+ * @param... | true |
Other | laravel | framework | 69cddedae349956c5f38455e861e3fc490d89a07.json | Add guard to authentication events | src/Illuminate/Auth/SessionGuard.php | @@ -493,7 +493,7 @@ public function logout()
}
if (isset($this->events)) {
- $this->events->dispatch(new Events\Logout($user));
+ $this->events->dispatch(new Events\Logout($user, $this->name));
}
// Once we have fired the logout event we will clear the users... | true |
Other | laravel | framework | a02877f4a610cdc546787b3f40c697778d4c4ae7.json | Fix MorphTo lazy eager loading (#25252) | src/Illuminate/Database/Eloquent/Builder.php | @@ -543,7 +543,7 @@ public function getRelation($name)
// and error prone. We don't want constraints because we add eager ones.
$relation = Relation::noConstraints(function () use ($name) {
try {
- return $this->getModel()->{$name}();
+ return $this->getModel... | true |
Other | laravel | framework | a02877f4a610cdc546787b3f40c697778d4c4ae7.json | Fix MorphTo lazy eager loading (#25252) | tests/Database/DatabaseEloquentBuilderTest.php | @@ -460,7 +460,7 @@ public function testGetRelationProperlySetsNestedRelationships()
{
$builder = $this->getBuilder();
$builder->setModel($this->getMockModel());
- $builder->getModel()->shouldReceive('orders')->once()->andReturn($relation = m::mock('stdClass'));
+ $builder->getModel... | true |
Other | laravel | framework | a02877f4a610cdc546787b3f40c697778d4c4ae7.json | Fix MorphTo lazy eager loading (#25252) | tests/Integration/Database/EloquentMorphToLazyEagerLoadingTest.php | @@ -0,0 +1,94 @@
+<?php
+
+namespace Illuminate\Tests\Integration\Database\EloquentMorphToLazyEagerLoadingTest;
+
+use Illuminate\Support\Facades\Schema;
+use Illuminate\Database\Eloquent\Model;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Tests\Integration\Database\DatabaseTestCase;
+
+/**
+ * @group int... | true |
Other | laravel | framework | ad670c8423a5fdfc929644f63db1b7ca39a8ba59.json | Inform user when a `cache:clear` command fails | src/Illuminate/Cache/Console/ClearCommand.php | @@ -64,7 +64,9 @@ public function handle()
'cache:clearing', [$this->argument('store'), $this->tags()]
);
- $this->cache()->flush();
+ if (! $this->cache()->flush()) {
+ return $this->error('Failed to clear cache. Make sure you have appropriate rights.');
+ }
... | false |
Other | laravel | framework | ef2dc2e7ccbcb3d074e81c552e35df36a6fc25e6.json | Fix MorphTo lazy eager loading (#25240) | src/Illuminate/Database/Eloquent/Builder.php | @@ -543,7 +543,7 @@ public function getRelation($name)
// and error prone. We don't want constraints because we add eager ones.
$relation = Relation::noConstraints(function () use ($name) {
try {
- return $this->getModel()->{$name}();
+ return $this->getModel... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.