language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | laravel | framework | a4c781ac40695051b2559d127e3d7595dcc5f904.json | remove stupid test | src/Illuminate/Foundation/helpers.php | @@ -809,34 +809,34 @@ function storage_path($path = '')
/**
* Translate the given message.
*
- * @param string $id
+ * @param string $key
* @param array $replace
* @param string $locale
* @return \Illuminate\Contracts\Translation\Translator|string|array|null
*/
... | true |
Other | laravel | framework | a4c781ac40695051b2559d127e3d7595dcc5f904.json | remove stupid test | src/Illuminate/Support/Arr.php | @@ -458,27 +458,35 @@ public static function pull(&$array, $key, $default = null)
}
/**
- * Get a random value from an array.
+ * Get one or a specified number of random values from an array.
*
* @param array $array
- * @param int|null $amount
+ * @param int|null $number
... | true |
Other | laravel | framework | a4c781ac40695051b2559d127e3d7595dcc5f904.json | remove stupid test | src/Illuminate/Support/Collection.php | @@ -86,21 +86,21 @@ public static function unwrap($value)
/**
* Create a new collection by invoking the callback a given amount of times.
*
- * @param int $amount
- * @param callable|null $callback
+ * @param int $number
+ * @param callable $callback
* @return static
... | true |
Other | laravel | framework | a4c781ac40695051b2559d127e3d7595dcc5f904.json | remove stupid test | src/Illuminate/View/Compilers/Concerns/CompilesEchos.php | @@ -100,6 +100,6 @@ protected function compileEscapedEchos($value)
*/
public function compileEchoDefaults($value)
{
- return preg_replace('/^(?=\$)(.+?)(?:\s+or\s+)(.+?)$/s', 'isset($1) ? $1 : $2', $value);
+ return preg_replace('/^(?=\$)(.+?)(?:\s+or\s+)(.+?)$/si', 'isset($1) ? $1 : $2', ... | true |
Other | laravel | framework | a4c781ac40695051b2559d127e3d7595dcc5f904.json | remove stupid test | src/Illuminate/View/Engines/EngineResolver.php | @@ -38,7 +38,7 @@ public function register($engine, Closure $resolver)
}
/**
- * Resolver an engine instance by name.
+ * Resolve an engine instance by name.
*
* @param string $engine
* @return \Illuminate\Contracts\View\Engine | true |
Other | laravel | framework | a4c781ac40695051b2559d127e3d7595dcc5f904.json | remove stupid test | tests/Database/DatabaseConcernsBuildsQueriesTraitTest.php | @@ -0,0 +1,17 @@
+<?php
+
+namespace Illuminate\Tests\Database;
+
+use PHPUnit\Framework\TestCase;
+use Illuminate\Database\Concerns\BuildsQueries;
+
+class DatabaseConcernsBuildsQueriesTraitTest extends TestCase
+{
+ public function testTapCallbackInstance()
+ {
+ $mock = $this->getMockForTrait(BuildsQuer... | true |
Other | laravel | framework | a4c781ac40695051b2559d127e3d7595dcc5f904.json | remove stupid test | tests/Support/SupportArrTest.php | @@ -421,22 +421,74 @@ public function testPull()
public function testRandom()
{
- $randomValue = Arr::random(['foo', 'bar', 'baz']);
-
- $this->assertContains($randomValue, ['foo', 'bar', 'baz']);
-
- $randomValues = Arr::random(['foo', 'bar', 'baz'], 1);
+ $random = Arr::random(... | true |
Other | laravel | framework | a4c781ac40695051b2559d127e3d7595dcc5f904.json | remove stupid test | tests/Support/SupportCollectionTest.php | @@ -922,6 +922,10 @@ public function testRandom()
{
$data = new Collection([1, 2, 3, 4, 5, 6]);
+ $random = $data->random();
+ $this->assertInternalType('integer', $random);
+ $this->assertContains($random, $data->all());
+
$random = $data->random(0);
$this->assert... | true |
Other | laravel | framework | b8ba38ff9a432ca8be42e2b7581bddb3456300da.json | add assertQueuedTimes method | src/Illuminate/Support/Testing/Fakes/MailFake.php | @@ -86,17 +86,36 @@ public function assertNothingSent()
* Assert if a mailable was queued based on a truth-test callback.
*
* @param string $mailable
- * @param callable|null $callback
+ * @param callable|int|null $callback
* @return void
*/
public function assertQueued(... | false |
Other | laravel | framework | 24ceb0b6b0f8eb61d748ddb746bfb02377ce6c61.json | remove useless import | src/Illuminate/Support/Testing/Fakes/MailFake.php | @@ -2,7 +2,6 @@
namespace Illuminate\Support\Testing\Fakes;
-use InvalidArgumentException;
use Illuminate\Contracts\Mail\Mailer;
use Illuminate\Contracts\Mail\Mailable;
use PHPUnit\Framework\Assert as PHPUnit; | false |
Other | laravel | framework | 55b9ee34dfbb83576c09b4bb7d1ac286dfa7bd7e.json | add assertPushedTimes and assertSentTimes methods | src/Illuminate/Support/Testing/Fakes/MailFake.php | @@ -30,6 +30,22 @@ public function assertSent($mailable, $callback = null)
);
}
+ /**
+ * Assert if a mailable was sent a number of times based on a truth-test callback.
+ *
+ * @param string $mailable
+ * @param integer $times
+ * @param callable|null $callback
+ * @retu... | true |
Other | laravel | framework | 55b9ee34dfbb83576c09b4bb7d1ac286dfa7bd7e.json | add assertPushedTimes and assertSentTimes methods | src/Illuminate/Support/Testing/Fakes/QueueFake.php | @@ -30,6 +30,22 @@ public function assertPushed($job, $callback = null)
);
}
+ /**
+ * Assert if a job was pushed a number of times based on a truth-test callback.
+ *
+ * @param string $job
+ * @param integer $times
+ * @param callable|null $callback
+ * @return void
+ ... | true |
Other | laravel | framework | f0d417bfa7a2e78d70c7382bfc51fe02321f0a3e.json | update v5.4 changelog | CHANGELOG-5.4.md | @@ -1,5 +1,16 @@
# Release Notes for 5.4.x
+## [Unreleased]
+
+### Changed
+- Moved `tap()` method from `Builder` to `BuildsQueries` ([#20384](https://github.com/laravel/framework/pull/20384))
+- Made Blade `or` operator case-insensitive ([#20425](https://github.com/laravel/framework/pull/20425))
+- Support `$amount... | false |
Other | laravel | framework | 442ea4d4dc8f4035da8adb23ee16e3caefee6f68.json | Move loader to Contracts. (#20460) | src/Illuminate/Contracts/Translation/Loader.php | @@ -1,8 +1,8 @@
<?php
-namespace Illuminate\Translation;
+namespace Illuminate\Contracts\Translation;
-interface LoaderInterface
+interface Loader
{
/**
* Load the messages for the given locale. | true |
Other | laravel | framework | 442ea4d4dc8f4035da8adb23ee16e3caefee6f68.json | Move loader to Contracts. (#20460) | src/Illuminate/Translation/ArrayLoader.php | @@ -2,7 +2,9 @@
namespace Illuminate\Translation;
-class ArrayLoader implements LoaderInterface
+use Illuminate\Contracts\Translation\Loader;
+
+class ArrayLoader implements Loader
{
/**
* All of the translation messages. | true |
Other | laravel | framework | 442ea4d4dc8f4035da8adb23ee16e3caefee6f68.json | Move loader to Contracts. (#20460) | src/Illuminate/Translation/FileLoader.php | @@ -3,8 +3,9 @@
namespace Illuminate\Translation;
use Illuminate\Filesystem\Filesystem;
+use Illuminate\Contracts\Translation\Loader;
-class FileLoader implements LoaderInterface
+class FileLoader implements Loader
{
/**
* The filesystem instance. | true |
Other | laravel | framework | 442ea4d4dc8f4035da8adb23ee16e3caefee6f68.json | Move loader to Contracts. (#20460) | src/Illuminate/Translation/Translator.php | @@ -7,6 +7,7 @@
use Illuminate\Support\Str;
use Illuminate\Support\Collection;
use Illuminate\Support\Traits\Macroable;
+use Illuminate\Contracts\Translation\Loader;
use Illuminate\Support\NamespacedItemResolver;
use Illuminate\Contracts\Translation\Translator as TranslatorContract;
@@ -17,7 +18,7 @@ class Trans... | true |
Other | laravel | framework | 442ea4d4dc8f4035da8adb23ee16e3caefee6f68.json | Move loader to Contracts. (#20460) | tests/Translation/TranslationTranslatorTest.php | @@ -159,6 +159,6 @@ public function testGetJsonForNonExistingReturnsSameKeyAndReplaces()
protected function getLoader()
{
- return m::mock('Illuminate\Translation\LoaderInterface');
+ return m::mock(\Illuminate\Contracts\Translation\Loader::class);
}
} | true |
Other | laravel | framework | 86b67fa1982736a87a935ef1b33f471ffff5b5e7.json | remove redundant class import | src/Illuminate/Support/Testing/Fakes/MailFake.php | @@ -3,9 +3,8 @@
namespace Illuminate\Support\Testing\Fakes;
use InvalidArgumentException;
-use Illuminate\Contracts\Mail\Mailable;
use Illuminate\Contracts\Mail\Mailer;
-use Illuminate\Contracts\Mail\Mailable as MailableContract;
+use Illuminate\Contracts\Mail\Mailable;
use PHPUnit\Framework\Assert as PHPUnit;
... | false |
Other | laravel | framework | 1b4762d2f034cb0cad0776cb31535815260639b5.json | implement mail fake queue method | src/Illuminate/Support/Testing/Fakes/MailFake.php | @@ -2,8 +2,10 @@
namespace Illuminate\Support\Testing\Fakes;
-use Illuminate\Contracts\Mail\Mailer;
+use InvalidArgumentException;
use Illuminate\Contracts\Mail\Mailable;
+use Illuminate\Contracts\Mail\Mailer;
+use Illuminate\Mail\MailableContract;
use PHPUnit\Framework\Assert as PHPUnit;
class MailFake imple... | false |
Other | laravel | framework | 2b676191b1688b8edc9d43317a2989642fe95b5d.json | add new report helper | src/Illuminate/Foundation/helpers.php | @@ -6,6 +6,7 @@
use Illuminate\Contracts\Auth\Access\Gate;
use Illuminate\Contracts\Routing\UrlGenerator;
use Illuminate\Foundation\Bus\PendingDispatch;
+use Illuminate\Contracts\Debug\ExceptionHandler;
use Illuminate\Contracts\Routing\ResponseFactory;
use Illuminate\Contracts\Auth\Factory as AuthFactory;
use Ill... | false |
Other | laravel | framework | f20a5ea8d106c8796aa5622e1bb3718b90833fe6.json | Apply fixes from StyleCI (#20401) | src/Illuminate/Filesystem/FilesystemAdapter.php | @@ -394,7 +394,7 @@ public function temporaryUrl($path, $expiration, array $options = [])
if (method_exists($adapter, 'getTemporaryUrl')) {
return $adapter->getTemporaryUrl($path, $expiration, $options);
- } else if (! $adapter instanceof AwsS3Adapter) {
+ } elseif (! $adapter inst... | false |
Other | laravel | framework | e0755231de6c1f05720fd763a6e782b3f25d8237.json | Update FilesystemAdapter.php (#20398)
* Update FilesystemAdapter.php
The current implementation does not allow other adapters a chance to implement a `temporaryUrl()` as the `$adapter->getClient()` gets called in first which is not how it works in all cases (in openstack for eg, there is no `getClient()` on the ada... | src/Illuminate/Filesystem/FilesystemAdapter.php | @@ -392,12 +392,14 @@ public function temporaryUrl($path, $expiration, array $options = [])
{
$adapter = $this->driver->getAdapter();
- $client = $adapter->getClient();
-
- if (! $adapter instanceof AwsS3Adapter) {
+ if (method_exists($adapter, 'getTemporaryUrl')) {
+ ret... | false |
Other | laravel | framework | a7931c396a2545bd4fd2ba2d73d0d8d5fbd16874.json | Fix Route facade docblock (#20397) | src/Illuminate/Support/Facades/Route.php | @@ -3,18 +3,18 @@
namespace Illuminate\Support\Facades;
/**
- * @method static \Illuminate\Routing\Route get(string $uri, \Closure|array|string $action)
- * @method static \Illuminate\Routing\Route post(string $uri, \Closure|array|string $action)
- * @method static \Illuminate\Routing\Route put(string $uri, \Closur... | false |
Other | laravel | framework | 868d6dc59b5512eddc9bceb9a81abadf1672366b.json | add options argument to temporaryUrl() (#20394)
This allows users to specify additions command arguments such as: `ResponseContentDisposition`. | src/Illuminate/Filesystem/FilesystemAdapter.php | @@ -385,9 +385,10 @@ protected function getLocalUrl($path)
*
* @param string $path
* @param \DateTimeInterface $expiration
+ * @param array $options
* @return string
*/
- public function temporaryUrl($path, $expiration)
+ public function temporaryUrl($path, $expiration, arr... | false |
Other | laravel | framework | 0d7ca93b5647792c2882b3fc96ad8f3d5cf35f1f.json | Remove useless condition. (#20345) | src/Illuminate/Broadcasting/BroadcastManager.php | @@ -83,9 +83,7 @@ public function socket($request = null)
$request = $request ?: $this->app['request'];
- if ($request->hasHeader('X-Socket-ID')) {
- return $request->header('X-Socket-ID');
- }
+ return $request->header('X-Socket-ID');
}
/** | false |
Other | laravel | framework | 54b406891d0e6081e2d766ec25bc64ea0f05f4ba.json | Prefer stricter negative comparisons. (#20346) | src/Illuminate/Database/Query/Builder.php | @@ -536,7 +536,7 @@ public function where($column, $operator = null, $value = null, $boolean = 'and'
// where null clause to the query. So, we will allow a short-cut here to
// that method for convenience so the developer doesn't have to check.
if (is_null($value)) {
- return $this... | true |
Other | laravel | framework | 54b406891d0e6081e2d766ec25bc64ea0f05f4ba.json | Prefer stricter negative comparisons. (#20346) | src/Illuminate/Database/Schema/SQLiteBuilder.php | @@ -11,7 +11,7 @@ class SQLiteBuilder extends Builder
*/
public function dropAllTables()
{
- if ($this->connection->getDatabaseName() != ':memory:') {
+ if ($this->connection->getDatabaseName() !== ':memory:') {
return $this->refreshDatabaseFile();
}
| true |
Other | laravel | framework | 54b406891d0e6081e2d766ec25bc64ea0f05f4ba.json | Prefer stricter negative comparisons. (#20346) | src/Illuminate/Foundation/Testing/Concerns/MakesHttpRequests.php | @@ -295,7 +295,7 @@ protected function transformHeadersToServerVars(array $headers)
*/
protected function formatServerHeaderKey($name)
{
- if (! Str::startsWith($name, 'HTTP_') && $name != 'CONTENT_TYPE') {
+ if (! Str::startsWith($name, 'HTTP_') && $name !== 'CONTENT_TYPE') {
... | true |
Other | laravel | framework | 54b406891d0e6081e2d766ec25bc64ea0f05f4ba.json | Prefer stricter negative comparisons. (#20346) | src/Illuminate/Http/Concerns/InteractsWithInput.php | @@ -331,7 +331,7 @@ public function hasFile($key)
*/
protected function isValidFile($file)
{
- return $file instanceof SplFileInfo && $file->getPath() != '';
+ return $file instanceof SplFileInfo && $file->getPath() !== '';
}
/** | true |
Other | laravel | framework | 54b406891d0e6081e2d766ec25bc64ea0f05f4ba.json | Prefer stricter negative comparisons. (#20346) | src/Illuminate/Http/Request.php | @@ -172,7 +172,7 @@ public function segments()
$segments = explode('/', $this->decodedPath());
return array_values(array_filter($segments, function ($v) {
- return $v != '';
+ return $v !== '';
}));
}
| true |
Other | laravel | framework | 54b406891d0e6081e2d766ec25bc64ea0f05f4ba.json | Prefer stricter negative comparisons. (#20346) | src/Illuminate/Pagination/LengthAwarePaginator.php | @@ -47,7 +47,7 @@ public function __construct($items, $total, $perPage, $currentPage = null, array
$this->total = $total;
$this->perPage = $perPage;
$this->lastPage = max((int) ceil($total / $perPage), 1);
- $this->path = $this->path != '/' ? rtrim($this->path, '/') : $this->path;
+ ... | true |
Other | laravel | framework | 54b406891d0e6081e2d766ec25bc64ea0f05f4ba.json | Prefer stricter negative comparisons. (#20346) | src/Illuminate/Pagination/Paginator.php | @@ -38,7 +38,7 @@ public function __construct($items, $perPage, $currentPage = null, array $option
$this->perPage = $perPage;
$this->currentPage = $this->setCurrentPage($currentPage);
- $this->path = $this->path != '/' ? rtrim($this->path, '/') : $this->path;
+ $this->path = $this->pat... | true |
Other | laravel | framework | 54b406891d0e6081e2d766ec25bc64ea0f05f4ba.json | Prefer stricter negative comparisons. (#20346) | src/Illuminate/Support/Str.php | @@ -100,7 +100,7 @@ public static function camel($value)
public static function contains($haystack, $needles)
{
foreach ((array) $needles as $needle) {
- if ($needle != '' && mb_strpos($haystack, $needle) !== false) {
+ if ($needle !== '' && mb_strpos($haystack, $needle) !== fal... | true |
Other | laravel | framework | 54b406891d0e6081e2d766ec25bc64ea0f05f4ba.json | Prefer stricter negative comparisons. (#20346) | src/Illuminate/Validation/Concerns/ValidatesAttributes.php | @@ -917,7 +917,7 @@ public function validateMimes($attribute, $value, $parameters)
return false;
}
- return $value->getPath() != '' && in_array($value->guessExtension(), $parameters);
+ return $value->getPath() !== '' && in_array($value->guessExtension(), $parameters);
}
... | true |
Other | laravel | framework | 54b406891d0e6081e2d766ec25bc64ea0f05f4ba.json | Prefer stricter negative comparisons. (#20346) | src/Illuminate/Validation/DatabasePresenceVerifier.php | @@ -48,7 +48,7 @@ public function getCount($collection, $column, $value, $excludeId = null, $idCol
{
$query = $this->table($collection)->where($column, '=', $value);
- if (! is_null($excludeId) && $excludeId != 'NULL') {
+ if (! is_null($excludeId) && $excludeId !== 'NULL') {
... | true |
Other | laravel | framework | 54b406891d0e6081e2d766ec25bc64ea0f05f4ba.json | Prefer stricter negative comparisons. (#20346) | src/Illuminate/Validation/ValidationData.php | @@ -82,7 +82,7 @@ public static function extractDataFromPath($attribute, $masterData)
$value = Arr::get($masterData, $attribute, '__missing__');
- if ($value != '__missing__') {
+ if ($value !== '__missing__') {
Arr::set($results, $attribute, $value);
}
| true |
Other | laravel | framework | 9f7d96b8de5e4ed2634e963cff26f0d69ce80705.json | Use proper assertions. (#20343) | tests/Database/DatabaseEloquentIntegrationTest.php | @@ -1118,7 +1118,7 @@ public function testFreshMethodOnModel()
$this->assertInstanceOf(EloquentTestUser::class, $storedUser2);
$this->assertEquals(['id' => 3, 'email' => 'taylorotwell@gmail.com'], $notStoredUser->toArray());
- $this->assertEquals(null, $freshNotStoredUser);
+ $this->as... | true |
Other | laravel | framework | 9f7d96b8de5e4ed2634e963cff26f0d69ce80705.json | Use proper assertions. (#20343) | tests/Database/DatabaseEloquentSoftDeletesIntegrationTest.php | @@ -600,7 +600,7 @@ public function testMorphToWithConstraints()
$q->where('email', 'taylorotwell@gmail.com');
}])->first();
- $this->assertEquals(null, $comment->owner);
+ $this->assertNull($comment->owner);
}
public function testMorphToWithoutConstraints()
@@ -622,7 +... | true |
Other | laravel | framework | 9f7d96b8de5e4ed2634e963cff26f0d69ce80705.json | Use proper assertions. (#20343) | tests/Support/SupportArrTest.php | @@ -415,7 +415,7 @@ public function testPull()
// Does not work for nested keys
$array = ['emails' => ['joe@example.com' => 'Joe', 'jane@localhost' => 'Jane']];
$name = Arr::pull($array, 'emails.joe@example.com');
- $this->assertEquals(null, $name);
+ $this->assertNull($name);
... | true |
Other | laravel | framework | 9f7d96b8de5e4ed2634e963cff26f0d69ce80705.json | Use proper assertions. (#20343) | tests/Validation/ValidationValidatorTest.php | @@ -3301,7 +3301,7 @@ public function testValidateImplicitEachWithAsterisksBeforeAndAfter()
public function testGetLeadingExplicitAttributePath()
{
- $this->assertEquals(null, \Illuminate\Validation\ValidationData::getLeadingExplicitAttributePath('*.email'));
+ $this->assertNull(\Illuminate\Va... | true |
Other | laravel | framework | 5a649288b9be7ff12256c3042dce0982900137b2.json | Add errors to Validator interface. (#20337) | src/Illuminate/Contracts/Validation/Validator.php | @@ -37,4 +37,11 @@ public function sometimes($attribute, $rules, callable $callback);
* @return $this
*/
public function after($callback);
+
+ /**
+ * Get all of the validation error messages.
+ *
+ * @return array
+ */
+ public function errors();
} | false |
Other | laravel | framework | de438fb381df02ea048daa732fb3773618514ecb.json | Add getStore to Repository interface. (#20338) | src/Illuminate/Contracts/Cache/Repository.php | @@ -115,4 +115,11 @@ public function rememberForever($key, Closure $callback);
* @return bool
*/
public function forget($key);
+
+ /**
+ * Get the cache store implementation.
+ *
+ * @return \Illuminate\Contracts\Cache\Store
+ */
+ public function getStore();
} | false |
Other | laravel | framework | c20de0861c2bbf8c894d510aca29d62220c18cf6.json | Add getMessages to MessageBag interface. (#20334) | src/Illuminate/Contracts/Support/MessageBag.php | @@ -62,6 +62,13 @@ public function get($key, $format = null);
*/
public function all($format = null);
+ /**
+ * Get the raw messages in the container.
+ *
+ * @return array
+ */
+ public function getMessages();
+
/**
* Get the default message format.
* | false |
Other | laravel | framework | 545c30d9158fd79126b3d336a97f4c7a07739fac.json | Add command output to the Finished event. | src/Illuminate/Console/Application.php | @@ -82,7 +82,7 @@ public function run(InputInterface $input = null, OutputInterface $output = null
$exitCode = parent::run($input, $output);
$this->events->fire(
- new Events\CommandFinished($commandName, $input, $exitCode)
+ new Events\CommandFinished($commandName, $input, $ou... | true |
Other | laravel | framework | 545c30d9158fd79126b3d336a97f4c7a07739fac.json | Add command output to the Finished event. | src/Illuminate/Console/Events/CommandFinished.php | @@ -3,6 +3,7 @@
namespace Illuminate\Console\Events;
use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
class CommandFinished
{
@@ -27,18 +28,26 @@ class CommandFinished
*/
public $exitCode;
+ /**
+ * The command output.
+ *
+ *... | true |
Other | laravel | framework | b26a9faacc933f5c56dd1b72cc5e443627317aa4.json | Add console events | src/Illuminate/Console/Application.php | @@ -9,7 +9,9 @@
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Process\PhpExecutableFinder;
+use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\BufferedOutput;
+use Symfony\Component\Console\Output\OutputIn... | true |
Other | laravel | framework | b26a9faacc933f5c56dd1b72cc5e443627317aa4.json | Add console events | src/Illuminate/Console/Events/CommandStarting.php | @@ -0,0 +1,35 @@
+<?php
+
+namespace Illuminate\Console\Events;
+
+use Symfony\Component\Console\Input\InputInterface;
+
+class CommandStarting
+{
+ /**
+ * The command name.
+ *
+ * @var string
+ */
+ public $command;
+
+ /**
+ * The console input.
+ *
+ * @var string
+ */
+ ... | true |
Other | laravel | framework | b26a9faacc933f5c56dd1b72cc5e443627317aa4.json | Add console events | src/Illuminate/Console/Events/CommandTerminating.php | @@ -0,0 +1,44 @@
+<?php
+
+namespace Illuminate\Console\Events;
+
+use Symfony\Component\Console\Input\InputInterface;
+
+class CommandTerminating
+{
+ /**
+ * The command name.
+ *
+ * @var string
+ */
+ public $command;
+
+ /**
+ * The console input.
+ *
+ * @var string
+ */
+... | true |
Other | laravel | framework | e4108ee1ae35e76fd6dd896c67e4768a1f0e5c63.json | Update WorkCommand.php (#20306) | src/Illuminate/Queue/Console/WorkCommand.php | @@ -45,7 +45,7 @@ class WorkCommand extends Command
protected $worker;
/**
- * Create a new queue listen command.
+ * Create a new queue work command.
*
* @param \Illuminate\Queue\Worker $worker
* @return void | false |
Other | laravel | framework | 94e6a0f38d12c8b9a84e125a102268dd72e8ca15.json | remove factory comment (#20290)
this comment seems like overkill, because it’ll show up in *every*
generated factory.
people can read the docs to learn about factories | src/Illuminate/Database/Console/Factories/stubs/factory.stub | @@ -2,17 +2,6 @@
use Faker\Generator as Faker;
-/*
-|--------------------------------------------------------------------------
-| Model Factories
-|--------------------------------------------------------------------------
-|
-| This directory should contain each of the model factory definitions for
-| your appli... | false |
Other | laravel | framework | 06dcaaafe3add4a1bd2a41610278fc7f3d8c43df.json | remove unneeded variable | tests/Database/DatabaseSchemaBlueprintTest.php | @@ -79,7 +79,7 @@ public function testDefaultCurrentTimestamp()
public function testUnsignedDecimalTable()
{
$base = new Blueprint('users', function ($table) {
- $table->unsignedDecimal('money', 10, 2, true)->useCurrent();
+ $table->unsignedDecimal('money', 10, 2)->useCurrent();... | false |
Other | laravel | framework | ef0e37d44182ac5043b5459bb25b1861e8e036df.json | pass request to responsable | src/Illuminate/Contracts/Support/Responsable.php | @@ -7,7 +7,8 @@ interface Responsable
/**
* Create an HTTP response that represents the object.
*
+ * @param \Illuminate\Http\Request $request
* @return \Illuminate\Http\Response
*/
- public function toResponse();
+ public function toResponse($request);
} | true |
Other | laravel | framework | ef0e37d44182ac5043b5459bb25b1861e8e036df.json | pass request to responsable | src/Illuminate/Foundation/Exceptions/Handler.php | @@ -168,7 +168,7 @@ public function render($request, Exception $e)
if (method_exists($e, 'render') && $response = $e->render($request)) {
return Router::prepareResponse($request, $response);
} elseif ($e instanceof Responsable) {
- return $e->toResponse();
+ return $... | true |
Other | laravel | framework | ef0e37d44182ac5043b5459bb25b1861e8e036df.json | pass request to responsable | src/Illuminate/Routing/Router.php | @@ -650,7 +650,7 @@ protected function sortMiddleware(Collection $middlewares)
public static function prepareResponse($request, $response)
{
if ($response instanceof Responsable) {
- $response = $response->toResponse();
+ $response = $response->toResponse($request);
}
... | true |
Other | laravel | framework | ef0e37d44182ac5043b5459bb25b1861e8e036df.json | pass request to responsable | tests/Foundation/FoundationExceptionsHandlerTest.php | @@ -128,7 +128,7 @@ public function testReturnsJsonWithoutStackTraceWhenAjaxRequestAndDebugFalseAndA
class CustomException extends Exception implements Responsable
{
- public function toResponse()
+ public function toResponse($request)
{
return response()->json(['response' => 'My custom exceptio... | true |
Other | laravel | framework | ef0e37d44182ac5043b5459bb25b1861e8e036df.json | pass request to responsable | tests/Integration/Routing/ResponsableTest.php | @@ -27,7 +27,7 @@ public function test_responsable_objects_are_rendered()
class TestResponsableResponse implements Responsable
{
- public function toResponse()
+ public function toResponse($request)
{
return response('hello world', 201, ['X-Test-Header' => 'Taylor']);
} | true |
Other | laravel | framework | 5f71c09c2a079e865ec8420e2abe52633d57d310.json | Add guest directive (#20257)
* Add guest directive
* Modify endauth | src/Illuminate/Auth/Console/stubs/make/views/layouts/app.stub | @@ -42,7 +42,7 @@
<!-- Right Side Of Navbar -->
<ul class="nav navbar-nav navbar-right">
<!-- Authentication Links -->
- @if (Auth::guest())
+ @guest
<li><a href="{{ route('login... | false |
Other | laravel | framework | 7f7eb7cd089e72743702e02c278b2bf532d650b6.json | update v5.4 changelog | CHANGELOG-5.4.md | @@ -1,5 +1,17 @@
# Release Notes for 5.4.x
+## [Unreleased]
+
+### Changed
+- Renamed `MakeAuthCommand` to `AuthMakeCommand` ([#20216](https://github.com/laravel/framework/pull/20216))
+- Don't use `asset()` helper inside `mix()` ([#20197](https://github.com/laravel/framework/pull/20197))
+
+### Fixed
+- Make sure `... | false |
Other | laravel | framework | feec50bc19f7861ac9792ccb04bdc9d4d7d46468.json | Apply fixes from StyleCI (#20230) | src/Illuminate/Cache/Repository.php | @@ -17,7 +17,7 @@
use Illuminate\Contracts\Cache\Repository as CacheContract;
/**
- * @mixin \Illuminate\Contracts\Cache\Store
+ * @mixin \Illuminate\Contracts\Cache\Store
*/
class Repository implements CacheContract, ArrayAccess
{ | false |
Other | laravel | framework | 6a69a09f256690c04c3e1b6eb0043ff5501169f7.json | Add test for mix() return value (#20219) | tests/Foundation/FoundationHelpersTest.php | @@ -56,4 +56,25 @@ public function testUnversionedElixir()
unlink(public_path($file));
}
+
+ public function testMixDoesNotIncludeHost()
+ {
+ $file = 'unversioned.css';
+
+ app()->singleton('path.public', function () {
+ return __DIR__;
+ });
+
+ touch(publi... | false |
Other | laravel | framework | f336c75b2c3c8e49e13154c9029d4816fd341639.json | Allow easy ViewFactory override | src/Illuminate/View/ViewServiceProvider.php | @@ -40,7 +40,7 @@ public function registerFactory()
$finder = $app['view.finder'];
- $env = new Factory($resolver, $finder, $app['events']);
+ $env = $this->newFactory($resolver, $finder, $app['events']);
// We will also set the container instance on this view envir... | false |
Other | laravel | framework | 785a7582564450e9f963cb6669553914695c7be1.json | Apply fixes from StyleCI (#20199) | src/Illuminate/Console/Scheduling/Event.php | @@ -532,7 +532,7 @@ public function withoutOverlapping()
/**
* Register a callback to further filter the schedule.
*
- * @param \Closure|boolean $callback
+ * @param \Closure|bool $callback
* @return $this
*/
public function when($callback)
@@ -547,7 +547,7 @@ public functi... | false |
Other | laravel | framework | 1d1a96e405fec58fd287940f005bd8e40d4e546b.json | allow plain boolean into when and skip | src/Illuminate/Console/Scheduling/Event.php | @@ -532,25 +532,29 @@ public function withoutOverlapping()
/**
* Register a callback to further filter the schedule.
*
- * @param \Closure $callback
+ * @param \Closure|boolean $callback
* @return $this
*/
- public function when(Closure $callback)
+ public function when($c... | true |
Other | laravel | framework | 1d1a96e405fec58fd287940f005bd8e40d4e546b.json | allow plain boolean into when and skip | tests/Console/ConsoleScheduledEventTest.php | @@ -55,6 +55,10 @@ public function testBasicCronCompilation()
return false;
})->filtersPass($app));
+ $event = new Event(m::mock('Illuminate\Console\Scheduling\Mutex'), 'php foo');
+ $this->assertEquals('* * * * * *', $event->getExpression());
+ $this->assertFalse($event->wh... | true |
Other | laravel | framework | 3658477a86175c5537674dc968e580aba823525d.json | Apply fixes from StyleCI (#20192) | tests/Integration/Database/EloquentBelongsToManyTest.php | @@ -3,8 +3,8 @@
namespace Illuminate\Tests\Integration\Database\EloquentBelongsToManyTest;
use Carbon\Carbon;
-use Illuminate\Support\Facades\DB;
use Orchestra\Testbench\TestCase;
+use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Schema;
use Illuminate\Database\Eloquent\Model;
@@ -64,7 +64,6 @... | false |
Other | laravel | framework | 11b0de0485632d5712f7fb59071a4acbc4af2bdc.json | add default unauthenticated stub method | src/Illuminate/Foundation/Exceptions/Handler.php | @@ -205,6 +205,20 @@ protected function prepareException(Exception $e)
return $e;
}
+ /**
+ * Convert an authentication exception into a response.
+ *
+ * @param \Illuminate\Http\Request $request
+ * @param \Illuminate\Auth\AuthenticationException $exception
+ * @return \Illum... | false |
Other | laravel | framework | be360a77cc4d3d9d49ac1144cb651ee7d038f9a3.json | unify more validation exceptions (#20177)
* unify more validation exceptions
* use given status
* add factory
* Apply fixes from StyleCI (#20178)
* try php 7.0.21
* tweak travis file | .travis.yml | @@ -1,7 +1,7 @@
language: php
php:
- - 7.0
+ - 7.0.21
- 7.1
env:
@@ -11,9 +11,9 @@ env:
matrix:
fast_finish: true
include:
- - php: 7.0
+ - php: 7.0.21
env: setup=lowest
- - php: 7.0
+ - php: 7.0.21
env: setup=stable
- php: 7.1
env: setup=lowest | true |
Other | laravel | framework | be360a77cc4d3d9d49ac1144cb651ee7d038f9a3.json | unify more validation exceptions (#20177)
* unify more validation exceptions
* use given status
* add factory
* Apply fixes from StyleCI (#20178)
* try php 7.0.21
* tweak travis file | src/Illuminate/Foundation/Auth/AuthenticatesUsers.php | @@ -4,6 +4,7 @@
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
+use Illuminate\Validation\ValidationException;
trait AuthenticatesUsers
{
@@ -124,17 +125,9 @@ protected function authenticated(Request $request, $user)
*/
protected function sendFailedLoginResponse(Request $request)
... | true |
Other | laravel | framework | be360a77cc4d3d9d49ac1144cb651ee7d038f9a3.json | unify more validation exceptions (#20177)
* unify more validation exceptions
* use given status
* add factory
* Apply fixes from StyleCI (#20178)
* try php 7.0.21
* tweak travis file | src/Illuminate/Foundation/Auth/ThrottlesLogins.php | @@ -7,6 +7,7 @@
use Illuminate\Cache\RateLimiter;
use Illuminate\Auth\Events\Lockout;
use Illuminate\Support\Facades\Lang;
+use Illuminate\Validation\ValidationException;
trait ThrottlesLogins
{
@@ -46,17 +47,9 @@ protected function sendLockoutResponse(Request $request)
$this->throttleKey($request)
... | true |
Other | laravel | framework | be360a77cc4d3d9d49ac1144cb651ee7d038f9a3.json | unify more validation exceptions (#20177)
* unify more validation exceptions
* use given status
* add factory
* Apply fixes from StyleCI (#20178)
* try php 7.0.21
* tweak travis file | src/Illuminate/Foundation/Exceptions/Handler.php | @@ -254,7 +254,7 @@ protected function invalidJson($request, ValidationException $exception)
return response()->json([
'message' => $exception->getMessage(),
'errors' => $exception->errors(),
- ], 422);
+ ], $exception->status);
}
/** | true |
Other | laravel | framework | be360a77cc4d3d9d49ac1144cb651ee7d038f9a3.json | unify more validation exceptions (#20177)
* unify more validation exceptions
* use given status
* add factory
* Apply fixes from StyleCI (#20178)
* try php 7.0.21
* tweak travis file | src/Illuminate/Routing/Middleware/ThrottleRequests.php | @@ -95,7 +95,9 @@ protected function resolveRequestSignature($request)
return sha1($route->getDomain().'|'.$request->ip());
}
- throw new RuntimeException('Unable to generate the request signature. Route unavailable.');
+ throw new RuntimeException(
+ 'Unable to generate... | true |
Other | laravel | framework | be360a77cc4d3d9d49ac1144cb651ee7d038f9a3.json | unify more validation exceptions (#20177)
* unify more validation exceptions
* use given status
* add factory
* Apply fixes from StyleCI (#20178)
* try php 7.0.21
* tweak travis file | src/Illuminate/Validation/ValidationException.php | @@ -3,6 +3,7 @@
namespace Illuminate\Validation;
use Exception;
+use Illuminate\Support\Facades\Validator as ValidatorFacade;
class ValidationException extends Exception
{
@@ -20,6 +21,13 @@ class ValidationException extends Exception
*/
public $response;
+ /**
+ * The status code to use for... | true |
Other | laravel | framework | 0b54f945bafc0185a7959901772cae6c9b36646f.json | Add docblock methods in schema facade (#20172) | src/Illuminate/Support/Facades/Schema.php | @@ -3,6 +3,11 @@
namespace Illuminate\Support\Facades;
/**
+ * @method static \Illuminate\Database\Schema\Builder create(string $table, \Closure $callback)
+ * @method static \Illuminate\Database\Schema\Builder drop(string $table)
+ * @method static \Illuminate\Database\Schema\Builder dropIfExists(string $table)
+ ... | false |
Other | laravel | framework | e73fed36f4091ab0c84ef66d217a2d7d45560b61.json | Unify validation exception formatting. (#20173)
* Unify validation exception formatting.
This unifies all validation error formatting into the exception handler
and out of Form Request. “Don’t Flash” is typically a global concept
that always applies to a list of fields for all pages in the
applications, so seeme... | src/Illuminate/Foundation/Exceptions/Handler.php | @@ -41,7 +41,7 @@ class Handler implements ExceptionHandlerContract
protected $container;
/**
- * A list of the exception types that should not be reported.
+ * A list of the exception types that are not reported.
*
* @var array
*/
@@ -62,6 +62,16 @@ class Handler implements Except... | true |
Other | laravel | framework | e73fed36f4091ab0c84ef66d217a2d7d45560b61.json | Unify validation exception formatting. (#20173)
* Unify validation exception formatting.
This unifies all validation error formatting into the exception handler
and out of Form Request. “Don’t Flash” is typically a global concept
that always applies to a list of fields for all pages in the
applications, so seeme... | src/Illuminate/Foundation/Http/FormRequest.php | @@ -3,7 +3,6 @@
namespace Illuminate\Foundation\Http;
use Illuminate\Http\Request;
-use Illuminate\Http\JsonResponse;
use Illuminate\Routing\Redirector;
use Illuminate\Contracts\Container\Container;
use Illuminate\Contracts\Validation\Validator;
@@ -59,13 +58,6 @@ class FormRequest extends Request implements Val... | true |
Other | laravel | framework | e73fed36f4091ab0c84ef66d217a2d7d45560b61.json | Unify validation exception formatting. (#20173)
* Unify validation exception formatting.
This unifies all validation error formatting into the exception handler
and out of Form Request. “Don’t Flash” is typically a global concept
that always applies to a list of fields for all pages in the
applications, so seeme... | src/Illuminate/Validation/ValidationException.php | @@ -27,6 +27,13 @@ class ValidationException extends Exception
*/
public $errorBag;
+ /**
+ * The path the client should be redirected to.
+ *
+ * @var string
+ */
+ public $redirectTo;
+
/**
* Create a new exception instance.
*
@@ -44,6 +51,42 @@ public function __co... | true |
Other | laravel | framework | e73fed36f4091ab0c84ef66d217a2d7d45560b61.json | Unify validation exception formatting. (#20173)
* Unify validation exception formatting.
This unifies all validation error formatting into the exception handler
and out of Form Request. “Don’t Flash” is typically a global concept
that always applies to a list of fields for all pages in the
applications, so seeme... | tests/Foundation/FoundationFormRequestTest.php | @@ -10,7 +10,6 @@
use Illuminate\Routing\UrlGenerator;
use Illuminate\Http\RedirectResponse;
use Illuminate\Foundation\Http\FormRequest;
-use Illuminate\Validation\ValidationException;
use Illuminate\Contracts\Translation\Translator;
use Illuminate\Validation\Factory as ValidationFactory;
use Illuminate\Contracts... | true |
Other | laravel | framework | b7e231b99aecb95a26ec89e5fe73346d4fad7fdc.json | fix validation errors | src/Illuminate/Foundation/Exceptions/Handler.php | @@ -209,8 +209,8 @@ protected function convertValidationExceptionToResponse(ValidationException $e,
}
return $request->expectsJson()
- ? $this->invalid($request, $exception)
- : $this->invalidJson($request, $exception);
+ ? $this->invalidJson(... | false |
Other | laravel | framework | 23f0c68b392613587b263b00b64476c9ba8d9dcc.json | Apply fixes from StyleCI (#20170) | src/Illuminate/Foundation/Exceptions/Handler.php | @@ -238,7 +238,7 @@ protected function invalidJson($request, ValidationException $exception)
{
return response()->json([
'message' => $exception->getMessage(),
- 'errors' => $exception->validator->errors()->messages()
+ 'errors' => $exception->validator->errors()->messag... | false |
Other | laravel | framework | c2a7721606a290d54f2f063c1782b1e4fc11a00b.json | remove asset helper (#20165) | src/Illuminate/Foundation/helpers.php | @@ -560,7 +560,7 @@ function mix($path, $manifestDirectory = '')
);
}
- return new HtmlString(asset($manifestDirectory.$manifest[$path]));
+ return new HtmlString($manifestDirectory.$manifest[$path]);
}
}
| false |
Other | laravel | framework | 29ac0866beaf5fdf4946e05ef3d2af930d3a371e.json | remove extra parenthesis | CHANGELOG-5.4.md | @@ -10,7 +10,7 @@
- Added `--force` option to `make:mail`, `make:model` and `make:notification` ([#19932](https://github.com/laravel/framework/pull/19932))
- Added support for PostgreSQL deletes with `USES` clauses ([#20062](https://github.com/laravel/framework/pull/20062), [f94fc02](https://github.com/laravel/framew... | false |
Other | laravel | framework | f6bdc032f79e3fc3dcc517b245935aa6cd77642a.json | Apply fixes from StyleCI (#20135) | src/Illuminate/Log/LogServiceProvider.php | @@ -48,7 +48,7 @@ protected function channel()
{
if ($this->app->bound('config') &&
$channel = $this->app->make('config')->get('app.log_channel')) {
- return $channel;
+ return $channel;
}
return $this->app->bound('env') ? $this->app->environment(... | false |
Other | laravel | framework | 9fade488f9f427fe140cef4e59f5d6d257fd00bd.json | Remove unused "Closure" class import (#20132) | src/Illuminate/Validation/Validator.php | @@ -2,7 +2,6 @@
namespace Illuminate\Validation;
-use Closure;
use RuntimeException;
use BadMethodCallException;
use Illuminate\Support\Arr; | false |
Other | laravel | framework | 81a0b9f667a288ce6bf2472c9783407367e15ca6.json | Apply fixes from StyleCI (#20128) | src/Illuminate/View/Compilers/Concerns/CompilesConditionals.php | @@ -119,7 +119,7 @@ protected function compileEndAuth()
{
return '<?php endif; ?>';
}
-
+
/**
* Compile the if-guest statements into valid PHP.
* | false |
Other | laravel | framework | 4feb8477bab424da4ff9f34cba7afaed875db42d.json | support no provider | src/Illuminate/Auth/CreatesUserProviders.php | @@ -17,18 +17,17 @@ trait CreatesUserProviders
* Create the user provider implementation for the driver.
*
* @param string|null $provider
- * @return \Illuminate\Contracts\Auth\UserProvider
+ * @return \Illuminate\Contracts\Auth\UserProvider|null
*
* @throws \InvalidArgumentExcep... | false |
Other | laravel | framework | e878807f77bb1cc3b3c428e5d6a6b98b32a6baea.json | Fix doblocks and use Carbon. (#20103) | src/Illuminate/Bus/Queueable.php | @@ -61,7 +61,7 @@ public function onQueue($queue)
/**
* Set the desired delay for the job.
*
- * @param \DateTimeInterface|\Da|int|null $delay
+ * @param \DateTimeInterface|\DateInterval|int|null $delay
* @return $this
*/
public function delay($delay) | true |
Other | laravel | framework | e878807f77bb1cc3b3c428e5d6a6b98b32a6baea.json | Fix doblocks and use Carbon. (#20103) | src/Illuminate/Queue/InteractsWithTime.php | @@ -2,7 +2,6 @@
namespace Illuminate\Queue;
-use DateTime;
use DateInterval;
use DateTimeInterface;
use Illuminate\Support\Carbon;
@@ -12,7 +11,7 @@ trait InteractsWithTime
/**
* Get the number of seconds until the given DateTime.
*
- * @param \DateTimeInterface|\DateInterval $delay
+ ... | true |
Other | laravel | framework | 63944bbb8be65c61b5de2c1f43287bbb3af192e1.json | Use json_last_error() (#20099) | src/Illuminate/Encryption/Encrypter.php | @@ -102,7 +102,7 @@ public function encrypt($value, $serialize = true)
$json = json_encode(compact('iv', 'value', 'mac'));
- if (! is_string($json)) {
+ if (json_last_error() !== JSON_ERROR_NONE) {
throw new EncryptException('Could not encrypt the data.');
}
| false |
Other | laravel | framework | 6ce2f5a6bc7046be8cf3813f2f1894ecaf4f4761.json | Add @auth blade component (#20087)
* Add @auth blade component
* Add tests
* cs
* Escape var
* Fix tests | src/Illuminate/View/Compilers/Concerns/CompilesConditionals.php | @@ -98,4 +98,25 @@ protected function compileEndIsset()
{
return '<?php endif; ?>';
}
+
+ /**
+ * Compile the if-auth statements into valid PHP.
+ *
+ * @param string|null $guard
+ * @return string
+ */
+ protected function compileAuth($guard = null)
+ {
+ return... | true |
Other | laravel | framework | 6ce2f5a6bc7046be8cf3813f2f1894ecaf4f4761.json | Add @auth blade component (#20087)
* Add @auth blade component
* Add tests
* cs
* Escape var
* Fix tests | tests/View/Blade/BladeIfAuthStatementsTest.php | @@ -0,0 +1,32 @@
+<?php
+
+namespace Illuminate\Tests\Blade;
+
+use Mockery as m;
+use PHPUnit\Framework\TestCase;
+use Illuminate\View\Compilers\BladeCompiler;
+
+class BladeIfAuthStatementsTest extends TestCase
+{
+ public function tearDown()
+ {
+ m::close();
+ }
+
+ public function testIfStatemen... | true |
Other | laravel | framework | 72de89c32d3b2ccca51008807d10e698e897d5db.json | Use migrate:fresh in DatabaseMigrations (#20090)
#20089 | src/Illuminate/Foundation/Testing/DatabaseMigrations.php | @@ -13,7 +13,7 @@ trait DatabaseMigrations
*/
public function runDatabaseMigrations()
{
- $this->artisan('migrate');
+ $this->artisan('migrate:fresh');
$this->app[Kernel::class]->setArtisan(null);
| false |
Other | laravel | framework | c80508e7e9b452fdad6577f79d88badb24c9690e.json | Fix visibility of testing helper (#20086)
This `protected` method isn’t used anywhere in the codebase, which seems to indicate it is supposed to be public and called by external code, similarly to the `withoutMiddleware()` method. | src/Illuminate/Foundation/Testing/Concerns/MakesHttpRequests.php | @@ -24,7 +24,7 @@ trait MakesHttpRequests
* @param array $server
* @return $this
*/
- protected function withServerVariables(array $server)
+ public function withServerVariables(array $server)
{
$this->serverVariables = $server;
| false |
Other | laravel | framework | f57b9e23ad4f8552bd5c2c958b9fbed4d2478389.json | Add Collection::wrap method (#20055)
If the given value is not a collection, wrap it in one.
If you pass a collection or an array as the value you get a collection with data in the collection or array back. If you pass in anything else you get a collection of one containing that value. | src/Illuminate/Support/Collection.php | @@ -59,6 +59,19 @@ public static function make($items = [])
return new static($items);
}
+ /**
+ * If the given value is not a collection, wrap it in one.
+ *
+ * @param mixed $value
+ * @return static
+ */
+ public static function wrap($value)
+ {
+ return $value i... | true |
Other | laravel | framework | f57b9e23ad4f8552bd5c2c958b9fbed4d2478389.json | Add Collection::wrap method (#20055)
If the given value is not a collection, wrap it in one.
If you pass a collection or an array as the value you get a collection with data in the collection or array back. If you pass in anything else you get a collection of one containing that value. | tests/Support/SupportCollectionTest.php | @@ -1014,6 +1014,49 @@ public function testMakeMethodFromArray()
$this->assertEquals(['foo' => 'bar'], $collection->all());
}
+ public function testWrapWithScalar()
+ {
+ $collection = Collection::wrap('foo');
+ $this->assertEquals(['foo'], $collection->all());
+ }
+
+ public f... | true |
Other | laravel | framework | 9b41936163a4e7c6e647491ce4d718157cea9a64.json | Return the API resource. (#20029) | src/Illuminate/Routing/Router.php | @@ -297,11 +297,11 @@ public function resource($name, $controller, array $options = [])
* @param string $name
* @param string $controller
* @param array $options
- * @return void
+ * @return \Illuminate\Routing\PendingResourceRegistration
*/
public function apiResource($name, ... | false |
Other | laravel | framework | ac9f29da4785c8b942ced8c4ab308214d618a22b.json | Update Command.php (#20024) | src/Illuminate/Console/Command.php | @@ -177,9 +177,7 @@ public function run(InputInterface $input, OutputInterface $output)
*/
protected function execute(InputInterface $input, OutputInterface $output)
{
- $method = method_exists($this, 'handle') ? 'handle' : 'fire';
-
- return $this->laravel->call([$this, $method]);
+ ... | false |
Other | laravel | framework | e37d48720bea14c3ca4fff7f53bd2273481258ef.json | Retrieve the real original content. (#20002) | src/Illuminate/Http/ResponseTrait.php | @@ -49,7 +49,9 @@ public function content()
*/
public function getOriginalContent()
{
- return $this->original;
+ $original = $this->original;
+
+ return $original instanceof self ? $original->{__FUNCTION__}() : $original;
}
/** | true |
Other | laravel | framework | e37d48720bea14c3ca4fff7f53bd2273481258ef.json | Retrieve the real original content. (#20002) | tests/Http/HttpResponseTest.php | @@ -91,6 +91,14 @@ public function testGetOriginalContent()
$this->assertSame($arr, $response->getOriginalContent());
}
+ public function testGetOriginalContentRetrievesTheFirstOriginalContent()
+ {
+ $previousResponse = new \Illuminate\Http\Response(['foo' => 'bar']);
+ $response = ... | true |
Other | laravel | framework | a9f00e68699001a46c7655dfd35c0fd3dcd5e0e2.json | Apply fixes from StyleCI (#20010) | src/Illuminate/Foundation/Console/EventGenerateCommand.php | @@ -4,7 +4,6 @@
use Illuminate\Support\Str;
use Illuminate\Console\Command;
-use Illuminate\Foundation\Support\Providers\EventServiceProvider;
class EventGenerateCommand extends Command
{ | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.