language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
laravel
framework
19fcecfc782cb7fe0dea6f8a293e167cfb1bf38d.json
Remove remaining priorities. (#17245)
src/Illuminate/Contracts/View/Factory.php
@@ -46,10 +46,9 @@ public function share($key, $value = null); * * @param array|string $views * @param \Closure|string $callback - * @param int|null $priority * @return array */ - public function composer($views, $callback, $priority = null); + public function composer($vie...
true
Other
laravel
framework
19fcecfc782cb7fe0dea6f8a293e167cfb1bf38d.json
Remove remaining priorities. (#17245)
src/Illuminate/View/Concerns/ManagesEvents.php
@@ -50,15 +50,14 @@ public function composers(array $composers) * * @param array|string $views * @param \Closure|string $callback - * @param int|null $priority * @return array */ - public function composer($views, $callback, $priority = null) + public function composer($vie...
true
Other
laravel
framework
19fcecfc782cb7fe0dea6f8a293e167cfb1bf38d.json
Remove remaining priorities. (#17245)
tests/View/ViewFactoryTest.php
@@ -126,18 +126,6 @@ public function testComposersAreProperlyRegistered() $this->assertEquals('bar', $callback()); } - public function testComposersAreProperlyRegisteredWithPriority() - { - $factory = $this->getFactory(); - $factory->getDispatcher()->shouldReceive('listen')->once()->...
true
Other
laravel
framework
76e30db8fe666f11648bc21d731a0cdbb56ebf8e.json
Remove unused parameter (#17244)
src/Illuminate/Translation/Translator.php
@@ -210,7 +210,7 @@ public function choice($key, $number, array $replace = [], $locale = null) $replace['count'] = $number; return $this->makeReplacements( - $this->getSelector()->choose($line, $number, $locale), $replace + $this->getSelector()->choose($line, $number), $replace...
true
Other
laravel
framework
76e30db8fe666f11648bc21d731a0cdbb56ebf8e.json
Remove unused parameter (#17244)
tests/Translation/TranslationTranslatorTest.php
@@ -76,7 +76,7 @@ public function testChoiceMethodProperlyLoadsAndRetrievesItem() $t = $this->getMockBuilder('Illuminate\Translation\Translator')->setMethods(['get'])->setConstructorArgs([$this->getLoader(), 'en'])->getMock(); $t->expects($this->once())->method('get')->with($this->equalTo('foo'), $thi...
true
Other
laravel
framework
dbbfc62beff1625b0d45bbf39650d047555cf4fa.json
Remove event priorities. The whole concept of event priorities doesn’t make sense as a concept and can’t even be trusted as an end user because you are relying on the exact order of listeners. Priority also makes no sense in modern apps where many events may be queued. Can be implemented as a synchronous pipeline. Als...
src/Illuminate/Contracts/Events/Dispatcher.php
@@ -9,10 +9,9 @@ interface Dispatcher * * @param string|array $events * @param mixed $listener - * @param int $priority * @return void */ - public function listen($events, $listener, $priority = 0); + public function listen($events, $listener); /** * Determine ...
true
Other
laravel
framework
dbbfc62beff1625b0d45bbf39650d047555cf4fa.json
Remove event priorities. The whole concept of event priorities doesn’t make sense as a concept and can’t even be trusted as an end user because you are relying on the exact order of listeners. Priority also makes no sense in modern apps where many events may be queued. Can be implemented as a synchronous pipeline. Als...
src/Illuminate/Events/Dispatcher.php
@@ -34,20 +34,6 @@ class Dispatcher implements DispatcherContract */ protected $wildcards = []; - /** - * The sorted event listeners. - * - * @var array - */ - protected $sorted = []; - - /** - * The event firing stack. - * - * @var array - */ - protected $firing...
true
Other
laravel
framework
dbbfc62beff1625b0d45bbf39650d047555cf4fa.json
Remove event priorities. The whole concept of event priorities doesn’t make sense as a concept and can’t even be trusted as an end user because you are relying on the exact order of listeners. Priority also makes no sense in modern apps where many events may be queued. Can be implemented as a synchronous pipeline. Als...
src/Illuminate/Support/Testing/Fakes/EventFake.php
@@ -102,10 +102,9 @@ protected function mapEventArguments($arguments) * * @param string|array $events * @param mixed $listener - * @param int $priority * @return void */ - public function listen($events, $listener, $priority = 0) + public function listen($events, $listener)...
true
Other
laravel
framework
dbbfc62beff1625b0d45bbf39650d047555cf4fa.json
Remove event priorities. The whole concept of event priorities doesn’t make sense as a concept and can’t even be trusted as an end user because you are relying on the exact order of listeners. Priority also makes no sense in modern apps where many events may be queued. Can be implemented as a synchronous pipeline. Als...
tests/Events/EventsDispatcherTest.php
@@ -132,20 +132,21 @@ public function testWildcardListenersCanBeFound() $this->assertTrue($d->hasListeners('foo.*')); } - public function testFiringReturnsCurrentlyFiredEvent() + public function testEventPassedFirstToWildcards() { - unset($_SERVER['__event.test']); $d = new Di...
true
Other
laravel
framework
dbbfc62beff1625b0d45bbf39650d047555cf4fa.json
Remove event priorities. The whole concept of event priorities doesn’t make sense as a concept and can’t even be trusted as an end user because you are relying on the exact order of listeners. Priority also makes no sense in modern apps where many events may be queued. Can be implemented as a synchronous pipeline. Als...
tests/Foundation/FoundationApplicationTest.php
@@ -147,7 +147,7 @@ public function testMethodAfterLoadingEnvironmentAddsClosure() }; $app->afterLoadingEnvironment($closure); $this->assertArrayHasKey(0, $app['events']->getListeners('bootstrapped: Illuminate\Foundation\Bootstrap\LoadEnvironmentVariables')); - $this->assertSame($closu...
true
Other
laravel
framework
33b1deadf128751477a4f1bc1398cc91b9f84ed0.json
Add missing import. (#17220)
src/Illuminate/Routing/RouteParameterBinder.php
@@ -2,6 +2,8 @@ namespace Illuminate\Routing; +use Illuminate\Support\Arr; + class RouteParameterBinder { /**
false
Other
laravel
framework
b122fe2971d18e611ade4d787410f1af12969664.json
Add missing interface method (#17236)
src/Illuminate/Contracts/Pagination/LengthAwarePaginator.php
@@ -4,6 +4,15 @@ interface LengthAwarePaginator extends Paginator { + /** + * Create a range of pagination URLs. + * + * @param int $start + * @param int $end + * @return string + */ + public function getUrlRange($start, $end); + /** * Determine the total number of items...
false
Other
laravel
framework
3f7429c2f687013871e0fbf53bcfe4309007779d.json
Fix MailMessage markdown (#17237)
src/Illuminate/Notifications/Messages/MailMessage.php
@@ -21,7 +21,7 @@ class MailMessage extends SimpleMessage /** * The Markdown template to render (if applicable). * - * @var string + * @var string|null */ public $markdown = 'notifications::email';
false
Other
laravel
framework
30fd0cf229358d09b7029e3fe69abf58a6b02b7e.json
Remove useless property. (#17238)
src/Illuminate/Console/Scheduling/CallbackEvent.php
@@ -9,13 +9,6 @@ class CallbackEvent extends Event { - /** - * The cache store implementation. - * - * @var \Illuminate\Contracts\Cache\Repository - */ - protected $cache; - /** * The callback to call. *
false
Other
laravel
framework
3edb21860311d0c01bccf03ace2fec951d51c4d0.json
Fix docblock. (#17234)
src/Illuminate/Validation/ValidationRuleParser.php
@@ -36,7 +36,7 @@ public function __construct(array $data) * Parse the human-friendly rules into a full rules array for the validator. * * @param array $rules - * @return StdClass + * @return \StdClass */ public function explode($rules) {
false
Other
laravel
framework
89b0c2b53ebd16f0db930701d31c365dd5b176d9.json
Apply fixes from StyleCI (#17232)
src/Illuminate/Database/Console/Migrations/MigrateCommand.php
@@ -4,7 +4,6 @@ use Illuminate\Console\ConfirmableTrait; use Illuminate\Database\Migrations\Migrator; -use Symfony\Component\Console\Input\InputOption; class MigrateCommand extends BaseCommand {
true
Other
laravel
framework
89b0c2b53ebd16f0db930701d31c365dd5b176d9.json
Apply fixes from StyleCI (#17232)
src/Illuminate/Database/Console/Migrations/RollbackCommand.php
@@ -60,7 +60,7 @@ public function fire() $this->migrator->rollback( $this->getMigrationPaths(), [ 'pretend' => $this->option('pretend'), - 'step' => (int) $this->option('step') + 'step' => (int) $this->option('step'), ] );
true
Other
laravel
framework
ab149811dca29130ee354d9e9ff448ab81004ec3.json
Apply fixes from StyleCI (#17230)
src/Illuminate/Database/Eloquent/Relations/Pivot.php
@@ -116,7 +116,7 @@ protected function getDeleteQuery() { return $this->newQuery()->where([ $this->foreignKey => $this->getAttribute($this->foreignKey), - $this->relatedKey => $this->getAttribute($this->relatedKey) + $this->relatedKey => $this->getAttribute($this->relate...
false
Other
laravel
framework
a0707c2f82da6a5320d68018d301887f4696b936.json
Apply fixes from StyleCI (#17229)
src/Illuminate/Database/Eloquent/Relations/Pivot.php
@@ -116,7 +116,7 @@ protected function getDeleteQuery() { return $this->newQuery()->where([ $this->foreignKey => $this->getAttribute($this->foreignKey), - $this->otherKey => $this->getAttribute($this->otherKey) + $this->otherKey => $this->getAttribute($this->otherKey), ...
false
Other
laravel
framework
09bb0ab08626df5cbb5b2dc01db8677bf988debd.json
Apply fixes from StyleCI (#17227)
src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php
@@ -672,8 +672,7 @@ public function touch() $key = $this->getRelated()->getKeyName(); $columns = [ - $this->related->getUpdatedAtColumn() => - $this->related->freshTimestampString() + $this->related->getUpdatedAtColumn() => $this->related->freshTimestampString(), ...
false
Other
laravel
framework
b6339ce45191be4c70b59ec44a1a915f0f662925.json
Fix param docblock. (#17222)
src/Illuminate/Session/DatabaseSessionHandler.php
@@ -103,7 +103,7 @@ public function read($sessionId) /** * Determine if the session is expired. * - * @param StdClass $session + * @param \StdClass $session * @return bool */ protected function expired($session)
false
Other
laravel
framework
c29a4ff85462cf52f296157fd8a07784d3a07eac.json
Remove useless use (#17223)
src/Illuminate/Database/Eloquent/Relations/HasOneOrMany.php
@@ -268,7 +268,7 @@ public function create(array $attributes) // Here we will set the raw attributes to avoid hitting the "fill" method so // that we do not have to worry about a mass accessor rules blocking sets // on the models. Otherwise, some of these attributes will not get set. - ...
false
Other
laravel
framework
84ce4b8dac1e4bc65c98f8bde89d6ec87541eb44.json
Add missing parameter (#17212)
src/Illuminate/Auth/SessionGuard.php
@@ -212,7 +212,7 @@ public function id() */ public function once(array $credentials = []) { - $this->fireAttemptEvent($credentials); + $this->fireAttemptEvent($credentials, false); if ($this->validate($credentials)) { $this->setUser($this->lastAttempted);
false
Other
laravel
framework
a180a0dd63c486d9a06838b58d500f3bb5124547.json
Fix mutexName visibility (#17213)
src/Illuminate/Console/Scheduling/CallbackEvent.php
@@ -115,7 +115,7 @@ public function withoutOverlapping() * * @return string */ - protected function mutexName() + public function mutexName() { return 'framework/schedule-'.sha1($this->description); }
false
Other
laravel
framework
8dc112f61d2e90a0d83d0367bc11b1e4306d0f02.json
use push method
src/Illuminate/Support/Testing/Fakes/QueueFake.php
@@ -210,10 +210,7 @@ public function pop($queue = null) public function bulk($jobs, $data = '', $queue = null) { foreach ($this->jobs as $job) { - $this->jobs[get_class($job)][] = [ - 'job' => $job, - 'queue' => $queue, - ]; + $this->push...
false
Other
laravel
framework
51329309c18d47dcc0e245c25e2173629dca04c7.json
Add dummy code in bulk() function.
src/Illuminate/Support/Testing/Fakes/QueueFake.php
@@ -209,7 +209,12 @@ public function pop($queue = null) */ public function bulk($jobs, $data = '', $queue = null) { - // + foreach ($this->jobs as $job) { + $this->jobs[get_class($job)][] = [ + 'job' => $job, + 'queue' => $queue, + ]; + ...
false
Other
laravel
framework
6bfa29e220adbd35523e897d813524b4c3928dde.json
Add missing methods to QueueFake
src/Illuminate/Support/Testing/Fakes/QueueFake.php
@@ -198,4 +198,38 @@ public function pop($queue = null) { // } + + /** + * Push an array of jobs onto the queue. + * + * @param array $jobs + * @param mixed $data + * @param string $queue + * @return mixed + */ + public function bulk($jobs, $data = '', $queue = nu...
false
Other
laravel
framework
df527d731c2fc21d9c18d513a515e1ba09e550d4.json
Fix Redis docblocks (#17217)
src/Illuminate/Redis/Connectors/PredisConnector.php
@@ -13,9 +13,8 @@ class PredisConnector * Create a new clustered Predis connection. * * @param array $config - * @param array $clusterOptions * @param array $options - * @return \Illuminate\Redis\PredisConnection + * @return \Illuminate\Redis\Connections\PredisConnection ...
false
Other
laravel
framework
0b70896854e1790fd40f52683c6f7b27658d0a3d.json
Fix Collection::mode return docblock. (#17218)
src/Illuminate/Support/Collection.php
@@ -124,7 +124,7 @@ public function median($key = null) * Get the mode of a given key. * * @param mixed $key - * @return array + * @return array|null */ public function mode($key = null) {
false
Other
laravel
framework
305c007f3d01c229b2c68b4b30c4fe0d5da341bb.json
Apply fixes from StyleCI (#17207)
src/Illuminate/Database/Eloquent/Relations/BelongsTo.php
@@ -279,7 +279,7 @@ public function getRelationCountHash() */ protected function relationHasIncrementingId() { - return $this->related->getIncrementing() && + return $this->related->getIncrementing() && $this->related->getKeyType() === 'int'; }
false
Other
laravel
framework
fd9cfe21a0ab2715744a5f9bdb465632fb14eb92.json
Apply fixes from StyleCI (#17206)
src/Illuminate/Database/Eloquent/Relations/BelongsTo.php
@@ -122,7 +122,7 @@ protected function getEagerModelKeys(array $models) // fail plus returns zero results, which should be what the developer expects. if (count($keys) === 0) { return [$this->related->getIncrementing() && - $this->related->getKeyType() === 'int' ? 0 : n...
false
Other
laravel
framework
d3cdfda31827e998c3a1a92e724532fe93ef68a2.json
fix doc block
src/Illuminate/Foundation/Http/FormRequest.php
@@ -21,7 +21,7 @@ class FormRequest extends Request implements ValidatesWhenResolved /** * The container instance. * - * @var \Illuminate\Container\Container + * @var \Illuminate\Contracts\Container\Container */ protected $container;
false
Other
laravel
framework
a2e186009d10523ecdcb8037c8522f772342818a.json
Add Grammar typehint (#17194) Apparently, this was forgotten in b5787e4.
src/Illuminate/Database/Schema/Grammars/RenameColumn.php
@@ -21,7 +21,7 @@ class RenameColumn * @param \Illuminate\Database\Connection $connection * @return array */ - public static function compile($grammar, Blueprint $blueprint, Fluent $command, Connection $connection) + public static function compile(Grammar $grammar, Blueprint $blueprint, Fluent...
false
Other
laravel
framework
332ea7c61f3aebcd2376e9ca4c6b5a5e873cead1.json
Apply fixes from StyleCI (#17185)
src/Illuminate/Database/Eloquent/Relations/BelongsTo.php
@@ -4,7 +4,6 @@ use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Builder; -use Illuminate\Database\Query\Expression; use Illuminate\Database\Eloquent\Collection; class BelongsTo extends Relation
true
Other
laravel
framework
332ea7c61f3aebcd2376e9ca4c6b5a5e873cead1.json
Apply fixes from StyleCI (#17185)
src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php
@@ -4,7 +4,6 @@ use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Builder; -use Illuminate\Database\Query\Expression; use Illuminate\Database\Eloquent\Collection; use Illuminate\Database\Eloquent\SoftDeletes; use Illuminate\Database\Eloquent\ModelNotFoundException;
true
Other
laravel
framework
332ea7c61f3aebcd2376e9ca4c6b5a5e873cead1.json
Apply fixes from StyleCI (#17185)
src/Illuminate/Database/Eloquent/Relations/HasOneOrMany.php
@@ -4,7 +4,6 @@ use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Builder; -use Illuminate\Database\Query\Expression; use Illuminate\Database\Eloquent\Collection; abstract class HasOneOrMany extends Relation
true
Other
laravel
framework
332ea7c61f3aebcd2376e9ca4c6b5a5e873cead1.json
Apply fixes from StyleCI (#17185)
tests/Database/DatabaseEloquentRelationTest.php
@@ -2,12 +2,10 @@ use Mockery as m; use PHPUnit\Framework\TestCase; -use Illuminate\Database\Grammar; use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Builder; use Illuminate\Database\Eloquent\Relations\HasOne; use Illuminate\Database\Eloquent\Relations\Relation; -use Illuminate\Database...
true
Other
laravel
framework
96fa470718120eb8569cc6068b265776fd7ebb46.json
Rename a few things to make more sense.
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
@@ -34,7 +34,7 @@ public function has($relation, $operator = '>=', $count = 1, $boolean = 'and', C // optimize the subquery to only run a "where exists" clause instead of // the full "count" clause. This will make the query run much faster. $queryType = $this->shouldRunExistsQuery($operator, ...
true
Other
laravel
framework
96fa470718120eb8569cc6068b265776fd7ebb46.json
Rename a few things to make more sense.
src/Illuminate/Database/Eloquent/Relations/BelongsTo.php
@@ -87,42 +87,42 @@ public function addConstraints() * Add the constraints for a relationship query. * * @param \Illuminate\Database\Eloquent\Builder $query - * @param \Illuminate\Database\Eloquent\Builder $parent + * @param \Illuminate\Database\Eloquent\Builder $parentQuery * @par...
true
Other
laravel
framework
96fa470718120eb8569cc6068b265776fd7ebb46.json
Rename a few things to make more sense.
src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php
@@ -369,30 +369,30 @@ public function addConstraints() * Add the constraints for a relationship query. * * @param \Illuminate\Database\Eloquent\Builder $query - * @param \Illuminate\Database\Eloquent\Builder $parent + * @param \Illuminate\Database\Eloquent\Builder $parentQuery * @p...
true
Other
laravel
framework
96fa470718120eb8569cc6068b265776fd7ebb46.json
Rename a few things to make more sense.
src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php
@@ -82,21 +82,21 @@ public function addConstraints() * Add the constraints for a relationship query. * * @param \Illuminate\Database\Eloquent\Builder $query - * @param \Illuminate\Database\Eloquent\Builder $parent + * @param \Illuminate\Database\Eloquent\Builder $parentQuery * @par...
true
Other
laravel
framework
96fa470718120eb8569cc6068b265776fd7ebb46.json
Rename a few things to make more sense.
src/Illuminate/Database/Eloquent/Relations/HasOneOrMany.php
@@ -312,38 +312,36 @@ public function update(array $attributes) * Add the constraints for a relationship query. * * @param \Illuminate\Database\Eloquent\Builder $query - * @param \Illuminate\Database\Eloquent\Builder $parent + * @param \Illuminate\Database\Eloquent\Builder $parentQuery ...
true
Other
laravel
framework
96fa470718120eb8569cc6068b265776fd7ebb46.json
Rename a few things to make more sense.
src/Illuminate/Database/Eloquent/Relations/MorphOneOrMany.php
@@ -58,13 +58,13 @@ public function addConstraints() * Get the relationship query. * * @param \Illuminate\Database\Eloquent\Builder $query - * @param \Illuminate\Database\Eloquent\Builder $parent + * @param \Illuminate\Database\Eloquent\Builder $parentQuery * @param array|mixed $...
true
Other
laravel
framework
96fa470718120eb8569cc6068b265776fd7ebb46.json
Rename a few things to make more sense.
src/Illuminate/Database/Eloquent/Relations/MorphToMany.php
@@ -71,13 +71,13 @@ protected function setWhere() * Add the constraints for a relationship count query. * * @param \Illuminate\Database\Eloquent\Builder $query - * @param \Illuminate\Database\Eloquent\Builder $parent + * @param \Illuminate\Database\Eloquent\Builder $parentQuery * @...
true
Other
laravel
framework
96fa470718120eb8569cc6068b265776fd7ebb46.json
Rename a few things to make more sense.
src/Illuminate/Database/Eloquent/Relations/Relation.php
@@ -140,27 +140,30 @@ public function rawUpdate(array $attributes = []) * Add the constraints for a relationship count query. * * @param \Illuminate\Database\Eloquent\Builder $query - * @param \Illuminate\Database\Eloquent\Builder $parent + * @param \Illuminate\Database\Eloquent\Builder ...
true
Other
laravel
framework
96fa470718120eb8569cc6068b265776fd7ebb46.json
Rename a few things to make more sense.
tests/Database/DatabaseEloquentBuilderTest.php
@@ -790,7 +790,7 @@ public function testSelfHasNestedUsesAlias() $sql = preg_replace($aliasRegex, $alias, $sql); - $this->assertContains('"self_related_stubs"."parent_id" = "self_alias_hash"."id"', $sql); + $this->assertContains('"self_alias_hash"."id" = "self_related_stubs"."parent_id"', $sq...
true
Other
laravel
framework
96fa470718120eb8569cc6068b265776fd7ebb46.json
Rename a few things to make more sense.
tests/Database/DatabaseEloquentGlobalScopesTest.php
@@ -99,7 +99,7 @@ public function testHasQueryWhereBothModelsHaveGlobalScopes() { $query = EloquentGlobalScopesWithRelationModel::has('related')->where('bar', 'baz'); - $subQuery = 'select * from "table" where "table"."related_id" = "table2"."id" and "foo" = ? and "active" = ?'; + $subQuer...
true
Other
laravel
framework
96fa470718120eb8569cc6068b265776fd7ebb46.json
Rename a few things to make more sense.
tests/Database/DatabaseEloquentHasOneTest.php
@@ -163,12 +163,9 @@ public function testRelationCountQueryCanBeBuilt() $builder->shouldReceive('select')->once()->with(m::type('Illuminate\Database\Query\Expression'))->andReturnSelf(); $relation->getParent()->shouldReceive('getTable')->andReturn('table'); - $builder->shouldReceive('where')-...
true
Other
laravel
framework
96fa470718120eb8569cc6068b265776fd7ebb46.json
Rename a few things to make more sense.
tests/Database/DatabaseEloquentRelationTest.php
@@ -64,30 +64,6 @@ public function testSettingMorphMapWithNumericKeys() Relation::morphMap([], false); } - - /** - * Testing to ensure loop does not occur during relational queries in global scopes. - * - * Executing parent model's global scopes could result in an infinite loop when the -...
true
Other
laravel
framework
294c006288ee182eeddf3c6deb23a35032a9219d.json
Refactor some method names.
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
@@ -47,6 +47,19 @@ public function has($relation, $operator = '>=', $count = 1, $boolean = 'and', C ); } + /** + * Get the "has relation" base query instance. + * + * @param string $relation + * @return \Illuminate\Database\Eloquent\Relations\Relation + */ + protected functio...
true
Other
laravel
framework
294c006288ee182eeddf3c6deb23a35032a9219d.json
Refactor some method names.
src/Illuminate/Database/Eloquent/Relations/HasOne.php
@@ -81,7 +81,7 @@ protected function getDefaultFor(Model $model) } $instance = $this->related->newInstance()->setAttribute( - $this->getPlainForeignKey(), $model->getAttribute($this->localKey) + $this->getForeignKeyName(), $model->getAttribute($this->localKey) ); ...
true
Other
laravel
framework
294c006288ee182eeddf3c6deb23a35032a9219d.json
Refactor some method names.
src/Illuminate/Database/Eloquent/Relations/HasOneOrMany.php
@@ -61,54 +61,6 @@ public function addConstraints() } } - /** - * Add the constraints for a relationship query. - * - * @param \Illuminate\Database\Eloquent\Builder $query - * @param \Illuminate\Database\Eloquent\Builder $parent - * @param array|mixed $columns - * @retur...
true
Other
laravel
framework
294c006288ee182eeddf3c6deb23a35032a9219d.json
Refactor some method names.
src/Illuminate/Database/Eloquent/Relations/MorphOneOrMany.php
@@ -197,7 +197,7 @@ public function create(array $attributes) */ protected function setForeignAttributesForCreate(Model $model) { - $model->{$this->getPlainForeignKey()} = $this->getParentKey(); + $model->{$this->getForeignKeyName()} = $this->getParentKey(); $model->{last(explod...
true
Other
laravel
framework
294c006288ee182eeddf3c6deb23a35032a9219d.json
Refactor some method names.
src/Illuminate/Database/Eloquent/Relations/Relation.php
@@ -158,11 +158,10 @@ public function getRelationCountQuery(Builder $query, Builder $parent) */ public function getRelationQuery(Builder $query, Builder $parent, $columns = ['*']) { - $query->select($columns); - - $key = $this->wrap($this->getQualifiedParentKeyName()); - - return $q...
true
Other
laravel
framework
294c006288ee182eeddf3c6deb23a35032a9219d.json
Refactor some method names.
tests/Database/DatabaseEloquentHasOneTest.php
@@ -161,7 +161,7 @@ public function testRelationCountQueryCanBeBuilt() $builder->shouldReceive('getQuery')->once()->andReturn($baseQuery); $builder->shouldReceive('getQuery')->once()->andReturn($parentQuery); - $builder->shouldReceive('select')->once()->with(m::type('Illuminate\Database\Query...
true
Other
laravel
framework
294c006288ee182eeddf3c6deb23a35032a9219d.json
Refactor some method names.
tests/Database/DatabaseEloquentModelTest.php
@@ -907,12 +907,12 @@ public function testHasOneCreatesProperRelation() $model = new EloquentModelStub; $this->addMockConnection($model); $relation = $model->hasOne('EloquentModelSaveStub'); - $this->assertEquals('save_stub.eloquent_model_stub_id', $relation->getForeignKey()); + ...
true
Other
laravel
framework
86ded5744cea21fceec75607d1b053770530c6a1.json
add comments and clarity
src/Illuminate/Database/Eloquent/Builder.php
@@ -972,7 +972,7 @@ protected function parseNestedWith($name, $results) } /** - * Add the given scopes to the current builder instance. + * Call the given local model scopes. * * @param array $scopes * @return mixed @@ -982,12 +982,19 @@ public function scopes(array $scopes) ...
false
Other
laravel
framework
a8a171128a889a33ddd8c8c8fafab1930de00255.json
Adjust method location.
src/Illuminate/Database/Eloquent/Builder.php
@@ -994,33 +994,6 @@ public function scopes(array $scopes) return $builder; } - /** - * Apply the given scope on the current builder instance. - * - * @param callable $scope - * @param array $parameters - * @return mixed - */ - protected function callScope(callable $scope...
false
Other
laravel
framework
8f363c0e54661f5ea4fdd0dfca5e906b23db5667.json
Apply fixes from StyleCI (#17181)
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
@@ -5,8 +5,8 @@ use Closure; use Illuminate\Support\Arr; use Illuminate\Support\Str; -use Illuminate\Database\Query\Expression; use Illuminate\Database\Eloquent\Builder; +use Illuminate\Database\Query\Expression; use Illuminate\Database\Eloquent\Relations\Relation; use Illuminate\Database\Query\Builder as QueryBu...
false
Other
laravel
framework
067f6a5173c1527ae6e109f0ba891b104392f7a9.json
Use a tap.
src/Illuminate/Database/Eloquent/Builder.php
@@ -206,7 +206,9 @@ public function findOrFail($id, $columns = ['*']) return $result; } - throw (new ModelNotFoundException)->setModel(get_class($this->model), $id); + throw (new ModelNotFoundException)->setModel( + get_class($this->model), $id + ); } ...
false
Other
laravel
framework
c2f800d4974b06e580b320b1664d2396492a4512.json
Apply fixes from StyleCI (#17169)
src/Illuminate/Database/Eloquent/Concerns/GuardsAttributes.php
@@ -152,7 +152,7 @@ public function isFillable($key) } return empty($this->getFillable()) && - ! Str::startsWith($key, '_'); + ! Str::startsWith($key, '_'); } /**
true
Other
laravel
framework
c2f800d4974b06e580b320b1664d2396492a4512.json
Apply fixes from StyleCI (#17169)
src/Illuminate/Database/Eloquent/Concerns/HasRelationships.php
@@ -39,7 +39,7 @@ trait HasRelationships */ public static $manyMethods = [ 'belongsToMany', 'morphToMany', 'morphedByMany', - 'guessBelongsToManyRelation', 'findFirstMethodThatIsntRelation' + 'guessBelongsToManyRelation', 'findFirstMethodThatIsntRelation', ]; /** @@ -402,7 ...
true
Other
laravel
framework
c0f3538710d3fb8501a78cae7f4a7cf0aa70ad22.json
Add comment for empty functions. (#17162)
src/Illuminate/Http/RedirectResponse.php
@@ -161,6 +161,7 @@ protected function parseErrors($provider) */ public function getOriginalContent() { + // } /**
false
Other
laravel
framework
bafd2c423dca3b88d721b55f2f7f83acc4591321.json
Fix issue #17140 match only APP_KEY in replace Changed str_replace to preg_replace to ensure no clashes with other environment variables
src/Illuminate/Foundation/Console/KeyGenerateCommand.php
@@ -51,8 +51,8 @@ public function fire() */ protected function setKeyInEnvironmentFile($key) { - file_put_contents($this->laravel->environmentFilePath(), str_replace( - 'APP_KEY='.$this->laravel['config']['app.key'], + file_put_contents($this->laravel->environmentFilePath(), pre...
false
Other
laravel
framework
003c4cb6d91b32af79ac1721bf191d24cf27504e.json
Apply fixes from StyleCI (#17147)
src/Illuminate/Http/RedirectResponse.php
@@ -161,7 +161,6 @@ protected function parseErrors($provider) */ public function getOriginalContent() { - return; } /**
false
Other
laravel
framework
5cd45bf3f173740b8987895701932986253987e6.json
Apply fixes from StyleCI (#17146)
src/Illuminate/Database/Schema/Grammars/SqlServerGrammar.php
@@ -82,7 +82,7 @@ public function compileAdd(Blueprint $blueprint, Fluent $command) */ public function compilePrimary(Blueprint $blueprint, Fluent $command) { - return sprintf("alter table %s add constraint %s primary key (%s)", + return sprintf('alter table %s add constraint %s primary ke...
false
Other
laravel
framework
915c93d093323496446003bace29ce16d2e52da7.json
Apply fixes from StyleCI (#17144)
src/Illuminate/Database/Schema/Grammars/SQLiteGrammar.php
@@ -103,7 +103,7 @@ protected function getForeignKey($foreign) // We need to columnize the columns that the foreign key is being defined for // so that it is a properly formatted list. Once we have done this, we can // return the foreign key SQL declaration to the calling method for use. - ...
false
Other
laravel
framework
01a4d896dd5e767dc8405dd28daf240fd8c2b9db.json
Apply fixes from StyleCI (#17143)
src/Illuminate/Database/Schema/Grammars/PostgresGrammar.php
@@ -103,7 +103,7 @@ public function compilePrimary(Blueprint $blueprint, Fluent $command) */ public function compileUnique(Blueprint $blueprint, Fluent $command) { - return sprintf("alter table %s add constraint %s unique (%s)", + return sprintf('alter table %s add constraint %s unique (%s...
false
Other
laravel
framework
86e9e051e8b6ec8ae72b33535a485938c170b756.json
Apply fixes from StyleCI (#17142)
src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php
@@ -203,7 +203,7 @@ public function compileIndex(Blueprint $blueprint, Fluent $command) */ protected function compileKey(Blueprint $blueprint, Fluent $command, $type) { - return sprintf("alter table %s add %s %s%s(%s)", + return sprintf('alter table %s add %s %s%s(%s)', $this-...
false
Other
laravel
framework
e147f579eb64a9897ba58182331a49bf0bcc784b.json
Apply fixes from StyleCI (#17141)
src/Illuminate/Database/Schema/Grammars/Grammar.php
@@ -62,15 +62,15 @@ public function compileForeign(Blueprint $blueprint, Fluent $command) // We need to prepare several of the elements of the foreign key definition // before we can create the SQL, such as wrapping the tables and convert // an array of columns to comma-delimited strings for ...
false
Other
laravel
framework
32fa8266a8431305d6e57ccdb205ed1704be62cd.json
extract change column
src/Illuminate/Database/Schema/Grammars/ChangeColumn.php
@@ -0,0 +1,206 @@ +<?php + +namespace Illuminate\Database\Schema\Grammars; + +use RuntimeException; +use Doctrine\DBAL\Types\Type; +use Illuminate\Support\Fluent; +use Doctrine\DBAL\Schema\Table; +use Doctrine\DBAL\Schema\Column; +use Illuminate\Database\Connection; +use Doctrine\DBAL\Schema\Comparator; +use Illuminate...
true
Other
laravel
framework
32fa8266a8431305d6e57ccdb205ed1704be62cd.json
extract change column
src/Illuminate/Database/Schema/Grammars/Grammar.php
@@ -2,14 +2,12 @@ namespace Illuminate\Database\Schema\Grammars; -use RuntimeException; use Doctrine\DBAL\Types\Type; use Illuminate\Support\Fluent; use Doctrine\DBAL\Schema\Table; use Doctrine\DBAL\Schema\Column; use Doctrine\DBAL\Schema\TableDiff; use Illuminate\Database\Connection; -use Doctrine\DBAL\Sche...
true
Other
laravel
framework
32fa8266a8431305d6e57ccdb205ed1704be62cd.json
extract change column
src/Illuminate/Database/Schema/Grammars/RenameColumn.php
@@ -37,6 +37,7 @@ public static function compile($grammar, Blueprint $blueprint, Fluent $command, /** * Get a new column instance with the new column name. * + * @param \Illuminate\Database\Schema\Grammars\Grammar $grammar * @param \Illuminate\Database\Schema\Blueprint $blueprint * ...
true
Other
laravel
framework
562b869f0fff57fa463ea0ec61b5d0c7de887f35.json
Apply fixes from StyleCI (#17139)
src/Illuminate/Database/Schema/Grammars/RenameColumn.php
@@ -61,7 +61,7 @@ protected static function getRenamedDiff($grammar, Blueprint $blueprint, Fluent protected static function setRenamedColumns(TableDiff $tableDiff, Fluent $command, Column $column) { $tableDiff->renamedColumns = [ - $command->from => new Column($command->to, $column->getTyp...
false
Other
laravel
framework
391d7d755c3678ab67c196c7a225176d4f0d8d41.json
Apply fixes from StyleCI (#17138)
src/Illuminate/Database/Schema/Grammars/RenameColumn.php
@@ -61,7 +61,7 @@ protected static function getRenamedDiff($grammar, Blueprint $blueprint, Fluent protected static function setRenamedColumns(TableDiff $tableDiff, Fluent $command, Column $column) { $tableDiff->renamedColumns = [ - $command->from => new Column($command->to, $column->getTyp...
false
Other
laravel
framework
ab1627d4c08ad9437419f669ab4858f2683d7a1c.json
Continue work on grammars.
src/Illuminate/Database/Grammar.php
@@ -32,11 +32,11 @@ public function wrapArray(array $values) */ public function wrapTable($table) { - if ($this->isExpression($table)) { - return $this->getValue($table); + if (! $this->isExpression($table)) { + return $this->wrap($this->tablePrefix.$table, true); ...
true
Other
laravel
framework
ab1627d4c08ad9437419f669ab4858f2683d7a1c.json
Continue work on grammars.
src/Illuminate/Database/Schema/Blueprint.php
@@ -114,7 +114,7 @@ public function toSql(Connection $connection, Grammar $grammar) } /** - * Add the commands that are implied by the blueprint. + * Add the commands that are implied by the blueprint's state. * * @return void */ @@ -140,20 +140,20 @@ protected function addFluentIn...
true
Other
laravel
framework
ab1627d4c08ad9437419f669ab4858f2683d7a1c.json
Continue work on grammars.
src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php
@@ -791,10 +791,10 @@ protected function modifyComment(Blueprint $blueprint, Fluent $column) */ protected function wrapValue($value) { - if ($value === '*') { - return $value; + if ($value !== '*') { + return '`'.str_replace('`', '``', $value).'`'; } - ...
true
Other
laravel
framework
f91f0191c8c7e909400413517459a208fc941529.json
Apply fixes from StyleCI (#17132)
src/Illuminate/Database/Query/Grammars/PostgresGrammar.php
@@ -75,7 +75,7 @@ protected function compileLock(Builder $query, $value) */ public function compileInsertGetId(Builder $query, $values, $sequence) { - if (!is_null($sequence)) { + if (! is_null($sequence)) { $sequence = 'id'; }
false
Other
laravel
framework
f637c2f9f32cc47209bb877de94d1c7489367b60.json
Apply fixes from StyleCI (#17126)
tests/Bus/BusDispatcherTest.php
@@ -78,31 +78,31 @@ public function testDispatcherCanDispatchStandAloneHandler() $this->assertInstanceOf(StandAloneCommand::class, $response); } - public function testOnConnectionOnJobWhenDispatching() - { - $container = new Container; - $container->singleton('config', function () { - return new Con...
false
Other
laravel
framework
dd305791c6520d2932922c2b2cdac072c899c0f3.json
Factorize cache events.
src/Illuminate/Cache/Events/AbstractCacheEvent.php
@@ -0,0 +1,46 @@ +<?php + +namespace Illuminate\Cache\Events; + +abstract class AbstractCacheEvent +{ + /** + * The key of the event. + * + * @var string + */ + public $key; + + /** + * The tags that were assigned to the key. + * + * @var array + */ + public $tags; + + /**...
true
Other
laravel
framework
dd305791c6520d2932922c2b2cdac072c899c0f3.json
Factorize cache events.
src/Illuminate/Cache/Events/CacheEvent.php
@@ -1,19 +0,0 @@ -<?php - -namespace Illuminate\Cache\Events; - -class CacheEvent -{ - /** - * Set the tags for the cache event. - * - * @param array $tags - * @return $this - */ - public function setTags($tags) - { - $this->tags = $tags; - - return $this; - } -}
true
Other
laravel
framework
dd305791c6520d2932922c2b2cdac072c899c0f3.json
Factorize cache events.
src/Illuminate/Cache/Events/CacheHit.php
@@ -2,29 +2,15 @@ namespace Illuminate\Cache\Events; -class CacheHit extends CacheEvent +class CacheHit extends AbstractCacheEvent { - /** - * The key that was hit. - * - * @var string - */ - public $key; - /** * The value that was retrieved. * * @var mixed */ ...
true
Other
laravel
framework
dd305791c6520d2932922c2b2cdac072c899c0f3.json
Factorize cache events.
src/Illuminate/Cache/Events/CacheMissed.php
@@ -2,32 +2,7 @@ namespace Illuminate\Cache\Events; -class CacheMissed extends CacheEvent +class CacheMissed extends AbstractCacheEvent { - /** - * The key that was missed. - * - * @var string - */ - public $key; - - /** - * The tags that were assigned to the key. - * - * @var...
true
Other
laravel
framework
dd305791c6520d2932922c2b2cdac072c899c0f3.json
Factorize cache events.
src/Illuminate/Cache/Events/KeyForgotten.php
@@ -2,32 +2,7 @@ namespace Illuminate\Cache\Events; -class KeyForgotten extends CacheEvent +class KeyForgotten extends AbstractCacheEvent { - /** - * The key that was forgotten. - * - * @var string - */ - public $key; - - /** - * The tags that were assigned to the key. - * - *...
true
Other
laravel
framework
dd305791c6520d2932922c2b2cdac072c899c0f3.json
Factorize cache events.
src/Illuminate/Cache/Events/KeyWritten.php
@@ -2,15 +2,8 @@ namespace Illuminate\Cache\Events; -class KeyWritten extends CacheEvent +class KeyWritten extends AbstractCacheEvent { - /** - * The key that was written. - * - * @var string - */ - public $key; - /** * The value that was written. * @@ -25,13 +18,6 @@ class ...
true
Other
laravel
framework
602efbadde06601577904c66608829087f2ce771.json
Remove unnecessary variable (#17113)
tests/Broadcasting/BroadcasterTest.php
@@ -63,7 +63,7 @@ public function testNotFoundThrowsHttpException() $broadcaster = new FakeBroadcaster(); $callback = function ($user, BroadcasterTestEloquentModelNotFoundStub $model) { }; - $parameters = $broadcaster->extractAuthParameters('asd.{model}', 'asd.1', $callback); + ...
false
Other
laravel
framework
e9ed2169c1420197fb14f1e9e49a5b0884804e02.json
Allow float value as expiration (#17106)
src/Illuminate/Cache/MemcachedStore.php
@@ -199,7 +199,7 @@ public function flush() */ protected function toTimestamp($minutes) { - return $minutes > 0 ? Carbon::now()->addMinutes($minutes)->getTimestamp() : 0; + return $minutes > 0 ? Carbon::now()->addSeconds($minutes * 60)->getTimestamp() : 0; } /**
false
Other
laravel
framework
fbf68a431f65ccbdb1b16c9eec6e878e7e6d645c.json
Simplify method (#17111)
src/Illuminate/Auth/Access/Gate.php
@@ -197,12 +197,10 @@ public function denies($ability, $arguments = []) public function check($ability, $arguments = []) { try { - $result = $this->raw($ability, $arguments); + return (bool) $this->raw($ability, $arguments); } catch (AuthorizationException $e) { ...
false
Other
laravel
framework
118d50b7eee0f86849b866f055d1e3c823f9f431.json
Remove unused variable (#17109)
tests/Container/ContainerTest.php
@@ -121,7 +121,6 @@ public function testBindingsCanBeOverridden() { $container = new Container; $container['foo'] = 'bar'; - $foo = $container['foo']; $container['foo'] = 'baz'; $this->assertEquals('baz', $container['foo']); }
false
Other
laravel
framework
82a2b1773cc3cd16beea4a2205a7cc9620867fab.json
Apply fixes from StyleCI (#17089)
src/Illuminate/Database/Connection.php
@@ -5,7 +5,6 @@ use PDO; use Closure; use Exception; -use Throwable; use LogicException; use DateTimeInterface; use Illuminate\Support\Arr; @@ -479,7 +478,7 @@ public function unprepared($query) */ public function pretend(Closure $callback) { - return $this->withFreshQueryLog(function() use...
false
Other
laravel
framework
88c745afb24aef1feeb4aaa76c4f87d0cf49ec47.json
Remove unneeded variable.
src/Illuminate/Database/Connection.php
@@ -297,7 +297,7 @@ public function selectFromWriteConnection($query, $bindings = []) */ public function select($query, $bindings = [], $useReadPdo = true) { - return $this->run($query, $bindings, function ($me, $query, $bindings) use ($useReadPdo) { + return $this->run($query, $bindings, ...
false
Other
laravel
framework
ace9702a1a7b17cb33b2f61eb46973de5e4111e6.json
Refactor the MySQL connector.
src/Illuminate/Database/Connectors/MySqlConnector.php
@@ -27,33 +27,61 @@ public function connect(array $config) $connection->exec("use `{$config['database']}`;"); } - $collation = $config['collation']; + $this->configureEncoding($connection, $config); - // Next we will set the "names" and "collation" on the clients connectio...
false
Other
laravel
framework
bfa6e3c948ec2aaf41486da6021061d1ea09e24c.json
Apply fixes from StyleCI (#17081)
src/Illuminate/Foundation/Testing/TestResponse.php
@@ -3,7 +3,6 @@ namespace Illuminate\Foundation\Testing; use Closure; -use Illuminate\Support\Str; use Illuminate\Http\Response; use Illuminate\Contracts\View\View; use PHPUnit_Framework_Assert as PHPUnit;
false
Other
laravel
framework
feb52bf966c0ea517ec0cf688b5a2534b50a8268.json
improve facade loading
src/Illuminate/Foundation/AliasLoader.php
@@ -18,6 +18,13 @@ class AliasLoader */ protected $registered = false; + /** + * The namespace for all real-time facades. + * + * @var string + */ + protected static $facadeNamespace = 'Facades\\'; + /** * The singleton instance of the loader. * @@ -62,11 +69,69 @@ pu...
true
Other
laravel
framework
feb52bf966c0ea517ec0cf688b5a2534b50a8268.json
improve facade loading
src/Illuminate/Foundation/Application.php
@@ -820,6 +820,16 @@ public function shouldSkipMiddleware() $this->make('middleware.disable') === true; } + /** + * Get the path to the cached services.php file. + * + * @return string + */ + public function getCachedServicesPath() + { + return $this->bootstrapPath...
true
Other
laravel
framework
feb52bf966c0ea517ec0cf688b5a2534b50a8268.json
improve facade loading
src/Illuminate/Foundation/stubs/facade.stub
@@ -0,0 +1,21 @@ +<?php + +namespace DummyNamespace; + +use Illuminate\Support\Facades\Facade; + +/** + * @see \DummyTarget + */ +class DummyClass extends Facade +{ + /** + * Get the registered name of the component. + * + * @return string + */ + protected static function getFacadeAccessor() + ...
true
Other
laravel
framework
d25de019447e66fe44376a13dbf09956cdadd354.json
Remove 2 duplicate RouteCollection tests. (#17057)
tests/Routing/RouteCollectionTest.php
@@ -41,24 +41,6 @@ public function testRouteCollectionAddReturnsTheRoute() $this->assertEquals($inputRoute, $outputRoute); } - public function testRouteCollectionAddRouteChangesCount() - { - $this->routeCollection->add(new Route('GET', 'foo', [ - 'uses' => 'FooController@index', ...
false
Other
laravel
framework
712b99df85c7a9daf8fb9f0a9a34fa90cbe99f44.json
Remove accessors that are never used.
src/Illuminate/Queue/Worker.php
@@ -512,25 +512,4 @@ public function setCache(CacheContract $cache) { $this->cache = $cache; } - - /** - * Get the queue manager instance. - * - * @return \Illuminate\Queue\QueueManager - */ - public function getManager() - { - return $this->manager; - } - - /** ...
false
Other
laravel
framework
a82a25f58252eab6831a0efde35a17403710abdc.json
add listener optinos
src/Illuminate/Queue/Console/ListenCommand.php
@@ -4,8 +4,7 @@ use Illuminate\Queue\Listener; use Illuminate\Console\Command; -use Symfony\Component\Console\Input\InputOption; -use Symfony\Component\Console\Input\InputArgument; +use Illuminate\Queue\ListenerOptions; class ListenCommand extends Command { @@ -14,7 +13,14 @@ class ListenCommand extends Command...
true