language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
laravel
framework
99da7163fa53631b0449b11569fddc660e4806a7.json
Add missing throws docblocks.
src/Illuminate/Queue/SyncQueue.php
@@ -17,7 +17,8 @@ class SyncQueue extends Queue implements QueueContract * @param mixed $data * @param string $queue * @return mixed - * @throws \Throwable + * + * @throws \Exception|\Throwable */ public function push($job, $data = '', $queue = null) {
true
Other
laravel
framework
99da7163fa53631b0449b11569fddc660e4806a7.json
Add missing throws docblocks.
src/Illuminate/Routing/UrlGenerator.php
@@ -314,6 +314,8 @@ public function route($name, $parameters = [], $absolute = true) * @param mixed $parameters * @param bool $absolute * @return string + * + * @throws \Illuminate\Routing\Exceptions\UrlGenerationException */ protected function toRoute($route, $parameters, $abs...
true
Other
laravel
framework
99da7163fa53631b0449b11569fddc660e4806a7.json
Add missing throws docblocks.
src/Illuminate/Support/Facades/Facade.php
@@ -199,6 +199,8 @@ public static function setFacadeApplication($app) * @param string $method * @param array $args * @return mixed + * + * @throws \RuntimeException */ public static function __callStatic($method, $args) {
true
Other
laravel
framework
99da7163fa53631b0449b11569fddc660e4806a7.json
Add missing throws docblocks.
src/Illuminate/Support/ServiceProvider.php
@@ -225,6 +225,8 @@ public static function compiles() * @param string $method * @param array $parameters * @return mixed + * + * @throws \BadMethodCallException */ public function __call($method, $parameters) {
true
Other
laravel
framework
99da7163fa53631b0449b11569fddc660e4806a7.json
Add missing throws docblocks.
src/Illuminate/Validation/ValidatesWhenResolvedTrait.php
@@ -41,6 +41,8 @@ protected function getValidatorInstance() * * @param \Illuminate\Validation\Validator $validator * @return mixed + * + * @throws \Illuminate\Contracts\Validation\ValidationExceptio */ protected function failedValidation(Validator $validator) { @@ -64,7 +66,7...
true
Other
laravel
framework
99da7163fa53631b0449b11569fddc660e4806a7.json
Add missing throws docblocks.
src/Illuminate/Validation/Validator.php
@@ -2728,6 +2728,7 @@ protected function callClassBasedReplacer($callback, $message, $attribute, $rule * @param array $parameters * @param string $rule * @return void + * * @throws \InvalidArgumentException */ protected function requireParameterCount($count, $parameters, $rule...
true
Other
laravel
framework
1a770409bedf0b0e4370257732f22ef88c472edc.json
Update docblock with correct return type
src/Illuminate/Auth/Console/stubs/make/controllers/HomeController.stub
@@ -20,7 +20,7 @@ class HomeController extends Controller /** * Show the application dashboard. * - * @return Response + * @return \Illuminate\Http\Response */ public function index() {
false
Other
laravel
framework
8fede3aa56c7b5b0544a70ef90302075d585ba3d.json
Add method for getting the column type Add method for getting the database agnostic datatype of a column.
src/Illuminate/Database/Schema/Builder.php
@@ -89,6 +89,19 @@ public function hasColumns($table, array $columns) return true; } + /** + * Return the data type for the passed column name. + * + * @param string $table + * @param string $column + * + * @return string + */ + public function getColumnType($table,...
false
Other
laravel
framework
bbfc14b60b50d2b9f327479cbbb0918dd4c6fc94.json
Use $fillable and $guarded accessor methods
src/Illuminate/Database/Eloquent/Model.php
@@ -478,8 +478,8 @@ public function forceFill(array $attributes) */ protected function fillableFromArray(array $attributes) { - if (count($this->fillable) > 0 && ! static::$unguarded) { - return array_intersect_key($attributes, array_flip($this->fillable)); + if (count($this->ge...
false
Other
laravel
framework
9cce184103e6ef40d90dd601224efa11e30884b2.json
Fix eager loading within global scope
src/Illuminate/Database/Eloquent/Builder.php
@@ -232,16 +232,18 @@ public function firstOrFail($columns = ['*']) */ public function get($columns = ['*']) { - $models = $this->getModels($columns); + $builder = $this->applyScopes(); + + $models = $builder->getModels($columns); // If we actually found models we will al...
true
Other
laravel
framework
9cce184103e6ef40d90dd601224efa11e30884b2.json
Fix eager loading within global scope
src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php
@@ -173,15 +173,17 @@ public function get($columns = ['*']) $select = $this->getSelectColumns($columns); - $models = $this->query->addSelect($select)->getModels(); + $builder = $this->query->applyScopes(); + + $models = $builder->addSelect($select)->getModels(); $this->hydra...
true
Other
laravel
framework
9cce184103e6ef40d90dd601224efa11e30884b2.json
Fix eager loading within global scope
src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php
@@ -322,13 +322,15 @@ public function get($columns = ['*']) $select = $this->getSelectColumns($columns); - $models = $this->query->addSelect($select)->getModels(); + $builder = $this->query->applyScopes(); + + $models = $builder->addSelect($select)->getModels(); // If we act...
true
Other
laravel
framework
9cce184103e6ef40d90dd601224efa11e30884b2.json
Fix eager loading within global scope
tests/Database/DatabaseEloquentBelongsToManyTest.php
@@ -24,6 +24,7 @@ public function testModelsAreProperlyHydrated() $relation = $this->getRelation(); $relation->getParent()->shouldReceive('getConnectionName')->andReturn('foo.connection'); $relation->getQuery()->shouldReceive('addSelect')->once()->with(['roles.*', 'user_role.user_id as pivot_...
true
Other
laravel
framework
9cce184103e6ef40d90dd601224efa11e30884b2.json
Fix eager loading within global scope
tests/Database/DatabaseEloquentBuilderTest.php
@@ -112,6 +112,7 @@ public function testFirstMethod() public function testGetMethodLoadsModelsAndHydratesEagerRelations() { $builder = m::mock('Illuminate\Database\Eloquent\Builder[getModels,eagerLoadRelations]', [$this->getMockQueryBuilder()]); + $builder->shouldReceive('applyScopes')->andRet...
true
Other
laravel
framework
9cce184103e6ef40d90dd601224efa11e30884b2.json
Fix eager loading within global scope
tests/Database/DatabaseEloquentHasManyThroughTest.php
@@ -102,6 +102,7 @@ public function testAllColumnsAreSelectedByDefault() $relation->getRelated()->shouldReceive('newCollection')->once(); $builder = $relation->getQuery(); + $builder->shouldReceive('applyScopes')->andReturnSelf(); $builder->shouldReceive('getQuery')->andReturn($baseB...
true
Other
laravel
framework
9cce184103e6ef40d90dd601224efa11e30884b2.json
Fix eager loading within global scope
tests/Database/DatabaseEloquentIntegrationTest.php
@@ -598,6 +598,16 @@ public function testDefaultIncrementingPrimaryKeyIntegerCastCanBeOverwritten() $this->assertInternalType('string', $user->id); } + public function testRelationsArePreloadedInGlobalScope() + { + $user = EloquentTestUserWithGlobalScope::create(['email' => 'taylorotwell@gm...
true
Other
laravel
framework
1a7ee5a96754304df0c798969b96a2617a45a168.json
set exception on response
src/Illuminate/Http/Response.php
@@ -2,6 +2,7 @@ namespace Illuminate\Http; +use Exception; use ArrayObject; use JsonSerializable; use Illuminate\Contracts\Support\Jsonable; @@ -93,4 +94,17 @@ public function getOriginalContent() { return $this->original; } + + /** + * Set the exception to attach to the response. + ...
true
Other
laravel
framework
1a7ee5a96754304df0c798969b96a2617a45a168.json
set exception on response
src/Illuminate/Routing/Pipeline.php
@@ -77,6 +77,12 @@ protected function handleException($passable, Exception $e) $handler->report($e); - return $handler->render($passable, $e); + $response = $handler->render($passable, $e); + + if (method_exists($response, 'withException')) { + $response->withException($e); ...
true
Other
laravel
framework
29198f4c1f5bbf0c800e760436e9d13ce5c9fe89.json
fix some formatting issues
src/Illuminate/Foundation/Auth/ResetsPasswords.php
@@ -11,26 +11,6 @@ trait ResetsPasswords { use RedirectsUsers; - /** - * Get the broker to be used during resetting the password. - * - * @return string|null - */ - public function getBroker() - { - return property_exists($this, 'broker') ? $this->broker : null; - } - - /**...
false
Other
laravel
framework
f322d52ce9b41b6b543a49ad0196a7599e1c2f28.json
Fix FormRequest tests.
tests/Foundation/FoundationFormRequestTest.php
@@ -3,27 +3,25 @@ use Mockery as m; use Illuminate\Container\Container; -class FoundationFormRequestTestCase extends PHPUnit_Framework_TestCase +class FoundationFormRequestTest extends PHPUnit_Framework_TestCase { public function tearDown() { m::close(); - unset($_SERVER['__request.valida...
false
Other
laravel
framework
cadee788ab41d6f6122a1caff79a067ed38aebde.json
Add key to collection reject
src/Illuminate/Support/Collection.php
@@ -652,8 +652,8 @@ public function reduce(callable $callback, $initial = null) public function reject($callback) { if ($this->useAsCallable($callback)) { - return $this->filter(function ($item) use ($callback) { - return ! $callback($item); + return $this->filter...
true
Other
laravel
framework
cadee788ab41d6f6122a1caff79a067ed38aebde.json
Add key to collection reject
tests/Support/SupportCollectionTest.php
@@ -883,6 +883,11 @@ public function testRejectRemovesElementsPassingTruthTest() $c = new Collection(['foo', 'bar']); $this->assertEquals(['foo', 'bar'], $c->reject(function ($v) { return $v == 'baz'; })->values()->all()); + + $c = new Collection(['id' => 1, 'primary' => 'foo', 'secondary' =>...
true
Other
laravel
framework
491feeb82ac27542c6a5512f26735451a2d9c09f.json
allow passing of conditions to where with arrays.
src/Illuminate/Database/Query/Builder.php
@@ -450,11 +450,7 @@ public function where($column, $operator = null, $value = null, $boolean = 'and' // and can add them each as a where clause. We will maintain the boolean we // received when the method was called and pass it into the nested where. if (is_array($column)) { - ret...
true
Other
laravel
framework
491feeb82ac27542c6a5512f26735451a2d9c09f.json
allow passing of conditions to where with arrays.
tests/Database/DatabaseQueryBuilderTest.php
@@ -610,6 +610,24 @@ public function testWhereShortcut() $this->assertEquals([0 => 1, 1 => 'foo'], $builder->getBindings()); } + public function testWhereWithArrayConditions() + { + $builder = $this->getBuilder(); + $builder->select('*')->from('users')->where([['foo', 1], ['bar', 2]]...
true
Other
laravel
framework
a38141968d3ce58f9b54b31ee970c14c7d48edbe.json
Add missing methods to the Job contract.
src/Illuminate/Contracts/Queue/Job.php
@@ -46,4 +46,32 @@ public function getName(); * @return string */ public function getQueue(); + + /** + * Determine if the job has been deleted or released. + * + * @return bool + */ + public function isDeletedOrReleased(); + + /** + * Determine if the job has been deleted....
false
Other
laravel
framework
c09af03f61e6b67c1c0625ab0cc170d2a88ca7bc.json
Add hasParameters to Route Route->parameters() throws an exception if the route has none, this helper function allows developers to check the presence of parameters and avoid the exception where none are set. A personal preference would to be remove the "Route not bound" exception but this is an inbetween work around...
src/Illuminate/Routing/Route.php
@@ -279,6 +279,10 @@ public function signatureParameters($subClass = null) */ public function hasParameter($name) { + if(! $this->hasParameters()) { + return false; + } + return array_key_exists($name, $this->parameters()); } @@ -333,6 +337,16 @@ public function for...
false
Other
laravel
framework
0c2b7da2635f7bbbaf63d1b93fa817232bdd9d65.json
Use the current timestamp as a default.
src/Illuminate/Database/Schema/Blueprint.php
@@ -791,9 +791,9 @@ public function nullableTimestamps() */ public function timestamps() { - $this->timestamp('created_at'); + $this->timestamp('created_at')->useCurrent(); - $this->timestamp('updated_at'); + $this->timestamp('updated_at')->useCurrent(); } /**
false
Other
laravel
framework
bf902a261296ee3f9344badf871e4f28e547a411.json
Move exception to validation component.
src/Illuminate/Foundation/Exceptions/Handler.php
@@ -5,12 +5,12 @@ use Exception; use Psr\Log\LoggerInterface; use Illuminate\Http\Response; +use Illuminate\Validation\ValidationException; use Illuminate\Auth\Access\AuthorizationException; use Illuminate\Http\Exception\HttpResponseException; use Symfony\Component\Debug\Exception\FlattenException; use Illuminat...
true
Other
laravel
framework
bf902a261296ee3f9344badf871e4f28e547a411.json
Move exception to validation component.
src/Illuminate/Foundation/Validation/ValidationException.php
@@ -3,45 +3,11 @@ namespace Illuminate\Foundation\Validation; use Exception; +use Illuminate\Validation\ValidationException as BaseException; -class ValidationException extends Exception +/** + * @deprecated since 5.3. Use Illuminate\Validation\ValidationException. + */ +class ValidationException extends BaseExce...
true
Other
laravel
framework
bf902a261296ee3f9344badf871e4f28e547a411.json
Move exception to validation component.
src/Illuminate/Validation/ValidationException.php
@@ -0,0 +1,47 @@ +<?php + +namespace Illuminate\Validation; + +use Exception; + +class ValidationException extends Exception +{ + /** + * The validator instance. + * + * @var \Illuminate\Validation\Validator + */ + public $validator; + + /** + * The recommended response to send to the clien...
true
Other
laravel
framework
7dc8d71494f186478fce8d65b725b5b7f5104a08.json
Declare $selector property.
src/Illuminate/Translation/Translator.php
@@ -39,6 +39,13 @@ class Translator extends NamespacedItemResolver implements TranslatorInterface */ protected $loaded = []; + /** + * The message selector. + * + * @var \Symfony\Component\Translation\MessageSelector + */ + protected $selector; + /** * Create a new transla...
false
Other
laravel
framework
3213f88d9738e952d519b927f3389c72a1b2bb53.json
Fix wrong DocBlocks Parameter name
src/Illuminate/Foundation/Auth/AuthenticatesUsers.php
@@ -105,7 +105,7 @@ protected function handleUserWasAuthenticated(Request $request, $throttles) /** * Get the failed login response instance. * - * @param \Illuminate\Http\Request $response + * @param \Illuminate\Http\Request $request * @return \Illuminate\Http\Response */ pr...
false
Other
laravel
framework
b55592a57eeac8d76c27f343c159e63ebc65c5d2.json
Allow extra conditions using HTTP basic auth
src/Illuminate/Auth/SessionGuard.php
@@ -260,9 +260,10 @@ public function validate(array $credentials = []) * Attempt to authenticate using HTTP Basic Auth. * * @param string $field + * @param array $extraConditions * @return \Symfony\Component\HttpFoundation\Response|null */ - public function basic($field = 'email...
true
Other
laravel
framework
b55592a57eeac8d76c27f343c159e63ebc65c5d2.json
Allow extra conditions using HTTP basic auth
src/Illuminate/Contracts/Auth/SupportsBasicAuth.php
@@ -8,15 +8,17 @@ interface SupportsBasicAuth * Attempt to authenticate using HTTP Basic Auth. * * @param string $field + * @param array $extraConditions * @return \Symfony\Component\HttpFoundation\Response|null */ - public function basic($field = 'email'); + public function ...
true
Other
laravel
framework
b55592a57eeac8d76c27f343c159e63ebc65c5d2.json
Allow extra conditions using HTTP basic auth
tests/Auth/AuthGuardTest.php
@@ -49,6 +49,18 @@ public function testBasicReturnsResponseOnFailure() $this->assertEquals(401, $response->getStatusCode()); } + public function testBasicWithExtraConditions() + { + list($session, $provider, $request, $cookie) = $this->getMocks(); + $guard = m::mock('Illuminate\Auth\...
true
Other
laravel
framework
d56e23f0838644c10ebb9ad3fa31412891a2886e.json
Add support for using keys in Collection filter
src/Illuminate/Support/Collection.php
@@ -186,7 +186,15 @@ public function except($keys) public function filter(callable $callback = null) { if ($callback) { - return new static(array_filter($this->items, $callback)); + $return = []; + + foreach ($this->items as $key => $value) { + if ($cal...
true
Other
laravel
framework
d56e23f0838644c10ebb9ad3fa31412891a2886e.json
Add support for using keys in Collection filter
tests/Support/SupportCollectionTest.php
@@ -254,6 +254,11 @@ public function testFilter() $c = new Collection(['', 'Hello', '', 'World']); $this->assertEquals(['Hello', 'World'], $c->filter()->values()->toArray()); + + $c = new Collection(['id' => 1, 'first' => 'Hello', 'second' => 'World']); + $this->assertEquals(['first' =...
true
Other
laravel
framework
18eb5caa48888e3e21228a652c97490ecfea01cd.json
fix method order
src/Illuminate/Console/Scheduling/Event.php
@@ -498,23 +498,23 @@ public function monthly() } /** - * Schedule the event to run yearly. + * Schedule the event to run quarterly. * * @return $this */ - public function yearly() + public function quarterly() { - return $this->cron('0 0 1 1 * *'); + retur...
false
Other
laravel
framework
3f1c412034d6d3ef233afcb514f65c05a4a2e5b6.json
Add getBroker() and getGuard()
src/Illuminate/Foundation/Auth/ResetsPasswords.php
@@ -11,6 +11,25 @@ trait ResetsPasswords { use RedirectsUsers; + /** + * Get the broker to be used during resetting the password + * @return string|null + */ + public function getBroker() + { + return property_exists($this, 'broker') ? $this->broker : null; + } + + /** + * ...
false
Other
laravel
framework
e53d12ae28536d42f93e6a5c7327eefd05c6b2cf.json
Allow quarterly Scheduling
src/Illuminate/Console/Scheduling/Event.php
@@ -507,6 +507,16 @@ public function yearly() return $this->cron('0 0 1 1 * *'); } + /** + * Schedule the event to run quarterly. + * + * @return $this + */ + public function quarterly() + { + return $this->cron('0 0 1 */3 *'); + } + /** * Schedule the event...
false
Other
laravel
framework
c4f8f492731756ca53a13e656af7f9f2e3574396.json
Use early return
src/Illuminate/Console/Scheduling/Event.php
@@ -702,7 +702,7 @@ public function emailOutputTo($addresses) /** * E-mail the results of the scheduled operation only when it produces output. * - * @param array|mixed $addresses + * @param array|mixed $addresses * @return $this * * @throws \LogicException @@ -732,15 +732,...
false
Other
laravel
framework
2f158e113506130561c484bcd0ea5a8f959393cb.json
Allow listener for core event
src/Illuminate/Foundation/Console/ListenerMakeCommand.php
@@ -55,7 +55,7 @@ protected function buildClass($name) $event = $this->option('event'); - if (! Str::startsWith($event, $this->laravel->getNamespace())) { + if (! Str::startsWith($event, $this->laravel->getNamespace()) && ! Str::startsWith($event, 'Illuminate')) { $event = $this-...
false
Other
laravel
framework
378104e1cdf07ad606482f9b12fddcbd9dadbcda.json
fix docblock CS
src/Illuminate/Foundation/Auth/ResetsPasswords.php
@@ -84,7 +84,7 @@ protected function getEmailSubject() * * If no token is present, display the link request form. * - * @param Request $request + * @param \Illuminate\Http\Request $request * @param string|null $token * @return \Illuminate\Http\Response */
false
Other
laravel
framework
e05d13023bfa2c265ef504eba85993d79fa9b27e.json
Add guard to Auth::logout()
src/Illuminate/Foundation/Auth/AuthenticatesUsers.php
@@ -157,7 +157,7 @@ public function getLogout() */ public function logout() { - Auth::logout(); + Auth::guard($this->getGuard())->logout(); return redirect(property_exists($this, 'redirectAfterLogout') ? $this->redirectAfterLogout : '/'); }
false
Other
laravel
framework
9f4b0260f322517cbb1ee71ca916e908a9a9ff55.json
Add more tests
tests/Database/DatabaseEloquentBuilderTest.php
@@ -457,6 +457,19 @@ public function testHasWithContraintsAndJoinAndHavingInSubquery() $this->assertEquals(['baz', 'quuuuuux', 'qux', 'quuux'], $builder->getBindings()); } + public function testHasWithContraintsAndHavingInSubqueryWithCount() + { + $model = new EloquentBuilderTestModelParent...
false
Other
laravel
framework
f5f843396c2c3cd244334029847fee2c7809123d.json
Fix routing pipeline.
src/Illuminate/Routing/Pipeline.php
@@ -2,6 +2,8 @@ namespace Illuminate\Routing; +use Closure; +use Throwable; use Exception; use Illuminate\Http\Request; use Illuminate\Contracts\Debug\ExceptionHandler; @@ -37,6 +39,25 @@ protected function getSlice() }; } + /** + * Get the initial slice to begin the stack call. + * +...
false
Other
laravel
framework
f9f658aa0b83eabe9d7edc1d88ae195ed8ca0b0f.json
Use extended Routing Pipeline in Kernel
src/Illuminate/Foundation/Http/Kernel.php
@@ -5,7 +5,7 @@ use Exception; use Throwable; use Illuminate\Routing\Router; -use Illuminate\Pipeline\Pipeline; +use Illuminate\Routing\Pipeline; use Illuminate\Support\Facades\Facade; use Illuminate\Contracts\Foundation\Application; use Illuminate\Contracts\Debug\ExceptionHandler;
false
Other
laravel
framework
74910637b1c0389ab57f136721dc09404fa470dc.json
Remove some AJAX handling.
src/Illuminate/Foundation/Auth/AuthenticatesUsers.php
@@ -99,10 +99,6 @@ protected function handleUserWasAuthenticated(Request $request, $throttles) return $this->authenticated($request, Auth::user()); } - if ($request->ajax() || $request->wantsJson()) { - return response()->json(['url' => $request->session()->pull('url.intended')...
true
Other
laravel
framework
74910637b1c0389ab57f136721dc09404fa470dc.json
Remove some AJAX handling.
src/Illuminate/Foundation/Auth/ThrottlesLogins.php
@@ -62,12 +62,6 @@ protected function sendLockoutResponse(Request $request) $this->getThrottleKey($request) ); - if ($request->ajax() || $request->wantsJson()) { - return response()->json([ - $this->loginUsername() => [$this->getLockoutErrorMessage($seconds)], - ...
true
Other
laravel
framework
7af396e528dad506c4121f97fe4c3bfe41fde7b2.json
remove url prefixes from resource route names.
src/Illuminate/Routing/ResourceRegistrar.php
@@ -211,13 +211,7 @@ protected function getResourceName($resource, $method, $options) */ protected function getGroupResourceName($prefix, $resource, $method) { - $group = trim(str_replace('/', '.', $this->router->getLastGroupPrefix()), '.'); - - if (empty($group)) { - return tri...
true
Other
laravel
framework
7af396e528dad506c4121f97fe4c3bfe41fde7b2.json
remove url prefixes from resource route names.
tests/Routing/RoutingRouteTest.php
@@ -693,6 +693,17 @@ public function testResourceRouteNaming() $this->assertTrue($router->getRoutes()->hasNamedRoute('foo.bar.update')); $this->assertTrue($router->getRoutes()->hasNamedRoute('foo.bar.destroy')); + $router = $this->getRouter(); + $router->resource('prefix/foo.bar', 'Foo...
true
Other
laravel
framework
408aba4ec776e0a8bf016bb090eaa354d3725abc.json
Fix each when there's no order by
src/Illuminate/Database/Eloquent/Builder.php
@@ -295,6 +295,10 @@ public function chunk($count, callable $callback) */ public function each(callable $callback, $count = 1000) { + if (is_null($this->getOrderBys())) { + $this->orderBy('id', 'asc'); + } + return $this->chunk($count, function ($results) use ($callback...
true
Other
laravel
framework
408aba4ec776e0a8bf016bb090eaa354d3725abc.json
Fix each when there's no order by
src/Illuminate/Database/Query/Builder.php
@@ -1575,6 +1575,10 @@ public function chunk($count, callable $callback) */ public function each(callable $callback, $count = 1000) { + if (is_null($this->getOrderBys())) { + $this->orderBy('id', 'asc'); + } + return $this->chunk($count, function ($results) use ($callba...
true
Other
laravel
framework
66ce56a6605136110aeac3946020c8f55fbd4b65.json
use facade so we dont break the signature
src/Illuminate/Foundation/Auth/ResetsPasswords.php
@@ -97,11 +97,11 @@ public function getReset($token = null) * * If no token is present, display the link request form. * - * @param string|null $token * @param \Illuminate\Http\Request $request + * @param string|null $token * @return \Illuminate\Http\Response */ - pu...
false
Other
laravel
framework
9990a46cfeb6f25ab55f0e59cf9f91fef02aeee5.json
Ignore non-existent .env files only
composer.json
@@ -38,7 +38,7 @@ "symfony/routing": "2.8.*|3.0.*", "symfony/translation": "2.8.*|3.0.*", "symfony/var-dumper": "2.8.*|3.0.*", - "vlucas/phpdotenv": "~2.0" + "vlucas/phpdotenv": "~2.2" }, "replace": { "illuminate/auth": "self.version",
true
Other
laravel
framework
9990a46cfeb6f25ab55f0e59cf9f91fef02aeee5.json
Ignore non-existent .env files only
src/Illuminate/Foundation/Bootstrap/DetectEnvironment.php
@@ -3,7 +3,7 @@ namespace Illuminate\Foundation\Bootstrap; use Dotenv\Dotenv; -use InvalidArgumentException; +use Dotenv\Exception\InvalidPathException; use Illuminate\Contracts\Foundation\Application; class DetectEnvironment @@ -19,7 +19,7 @@ public function bootstrap(Application $app) if (! $app->con...
true
Other
laravel
framework
fd3056cb55b0f39d21640567f1f277777657bbb6.json
Change elixir helper order for the Javascript I changed the order of the elixir helper at the Javascript section to avoid problems when one tries to ask if a library such as jQuery is available to use.
src/Illuminate/Auth/Console/stubs/make/views/layouts/app.stub
@@ -75,8 +75,8 @@ @yield('content') <!-- JavaScripts --> - {{-- <script src="{{ elixir('js/app.js') }}"></script> --}} <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script> <script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/js/bootstrap.min.js"></sc...
false
Other
laravel
framework
57d8251b26e994f428e3cc0630f90b2b14d2fc1f.json
remove restriction that caused some BC issues
src/Illuminate/Queue/Console/ListenCommand.php
@@ -2,7 +2,6 @@ namespace Illuminate\Queue\Console; -use InvalidArgumentException; use Illuminate\Queue\Listener; use Illuminate\Console\Command; use Symfony\Component\Console\Input\InputOption; @@ -64,12 +63,6 @@ public function fire() $timeout = $this->input->getOption('timeout'); - if ($t...
false
Other
laravel
framework
5744ca139d686c21169cacdaaddbbaf726ed5553.json
Pass array validation rules as array Updated tests
src/Illuminate/Validation/Validator.php
@@ -216,7 +216,7 @@ protected function explodeRules($rules) { foreach ($rules as $key => $rule) { if (Str::contains($key, '*')) { - $this->each($key, $rule); + $this->each($key, [$rule]); unset($rules[$key]); } else {
true
Other
laravel
framework
5744ca139d686c21169cacdaaddbbaf726ed5553.json
Pass array validation rules as array Updated tests
tests/Validation/ValidationValidatorTest.php
@@ -1804,6 +1804,14 @@ public function testValidateEach() $v = new Validator($trans, $data, ['foo' => 'Array']); $v->each('foo', 'numeric|min:4|max:16'); $this->assertTrue($v->passes()); + + $v = new Validator($trans, $data, ['foo' => 'Array']); + $v->each('foo', ['numeric','min...
true
Other
laravel
framework
3789a96ec84fdc94685c90eb12e378dedb97411d.json
use illuminate response
src/Illuminate/Auth/SessionGuard.php
@@ -4,11 +4,11 @@ use RuntimeException; use Illuminate\Support\Str; +use Illuminate\Http\Response; use Illuminate\Contracts\Events\Dispatcher; use Illuminate\Contracts\Auth\UserProvider; use Illuminate\Contracts\Auth\StatefulGuard; use Symfony\Component\HttpFoundation\Request; -use Symfony\Component\HttpFoundat...
false
Other
laravel
framework
b742179af9124cadd8eca3000eca0b5b50ed256f.json
Improve char coverage
src/Illuminate/Support/Str.php
@@ -459,84 +459,108 @@ protected static function charsArray() } return $charsArray = [ - 'a' => ['à', 'á', 'ả', 'ã', 'ạ', 'ă', 'ắ', 'ằ', 'ẳ', 'ẵ', 'ặ', 'â', 'ấ', 'ầ', 'ẩ', 'ẫ', 'ậ', 'ā', 'ą', 'å', 'α', 'ά', 'ἀ', 'ἁ', 'ἂ', 'ἃ', 'ἄ', 'ἅ', 'ἆ', 'ἇ', 'ᾀ', 'ᾁ', 'ᾂ', 'ᾃ', 'ᾄ', 'ᾅ', 'ᾆ', 'ᾇ',...
false
Other
laravel
framework
55259e5178a61dc3393df33a6dd4d8bcbf2c3e59.json
Unify database chunk methods, and add each methods
src/Illuminate/Database/Eloquent/Builder.php
@@ -264,7 +264,7 @@ public function value($column) * * @param int $count * @param callable $callback - * @return void + * @return bool */ public function chunk($count, callable $callback) { @@ -275,13 +275,35 @@ public function chunk($count, callable $callback) ...
true
Other
laravel
framework
55259e5178a61dc3393df33a6dd4d8bcbf2c3e59.json
Unify database chunk methods, and add each methods
src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php
@@ -229,16 +229,16 @@ public function simplePaginate($perPage = null, $columns = ['*']) * * @param int $count * @param callable $callback - * @return void + * @return bool */ public function chunk($count, callable $callback) { $this->query->addSelect($this->getSele...
true
Other
laravel
framework
55259e5178a61dc3393df33a6dd4d8bcbf2c3e59.json
Unify database chunk methods, and add each methods
src/Illuminate/Database/Query/Builder.php
@@ -1566,6 +1566,26 @@ public function chunk($count, callable $callback) return true; } + /** + * Execute a callback over each item. + * + * We're also saving memory by chunking the results into memory. + * + * @param callable $callback + * @param int $count + * @retur...
true
Other
laravel
framework
964f69f66e2c9b4e3e0557ee26417dfe2936cf3d.json
Add knowledge, love and rain to uncountable array
src/Illuminate/Support/Pluralizer.php
@@ -24,6 +24,9 @@ class Pluralizer 'fish', 'gold', 'information', + 'knowledge', + 'love', + 'rain', 'money', 'moose', 'offspring',
false
Other
laravel
framework
06922ce6c041770e3b0a18453d3b992a488bd69b.json
Add tag property to the cache events
src/Illuminate/Cache/Events/CacheHit.php
@@ -18,16 +18,25 @@ class CacheHit */ public $value; + /** + * Any tags that were used. + * + * @var array + */ + public $tags; + /** * Create a new event instance. * * @param string $key * @param mixed $value + * @param array $tags * @retu...
true
Other
laravel
framework
06922ce6c041770e3b0a18453d3b992a488bd69b.json
Add tag property to the cache events
src/Illuminate/Cache/Events/CacheMissed.php
@@ -11,14 +11,23 @@ class CacheMissed */ public $key; + /** + * Any tags that were used. + * + * @var array + */ + public $tags; + /** * Create a new event instance. * * @param string $event + * @param array $tags * @return void */ - publi...
true
Other
laravel
framework
06922ce6c041770e3b0a18453d3b992a488bd69b.json
Add tag property to the cache events
src/Illuminate/Cache/Events/KeyForgotten.php
@@ -11,14 +11,23 @@ class KeyForgotten */ public $key; + /** + * Any tags that were used. + * + * @var array + */ + public $tags; + /** * Create a new event instance. * * @param string $key + * @param array $tags * @return void */ - public...
true
Other
laravel
framework
06922ce6c041770e3b0a18453d3b992a488bd69b.json
Add tag property to the cache events
src/Illuminate/Cache/Events/KeyWritten.php
@@ -25,18 +25,27 @@ class KeyWritten */ public $minutes; + /** + * Any tags that were used. + * + * @var array + */ + public $tags; + /** * Create a new event instance. * * @param string $key * @param mixed $value * @param int $minutes + * ...
true
Other
laravel
framework
06922ce6c041770e3b0a18453d3b992a488bd69b.json
Add tag property to the cache events
src/Illuminate/Cache/Repository.php
@@ -76,13 +76,29 @@ protected function fireCacheEvent($event, $payload) switch ($event) { case 'hit': - return $this->events->fire(new Events\CacheHit($payload[0], $payload[1])); + if (count($payload) == 2) { + $payload[] = []; + } ...
true
Other
laravel
framework
06922ce6c041770e3b0a18453d3b992a488bd69b.json
Add tag property to the cache events
tests/Cache/CacheEventsTest.php
@@ -1,6 +1,10 @@ <?php use Mockery as m; +use Illuminate\Cache\Events\CacheHit; +use Illuminate\Cache\Events\KeyWritten; +use Illuminate\Cache\Events\CacheMissed; +use Illuminate\Cache\Events\KeyForgotten; class CacheEventTest extends PHPUnit_Framework_TestCase { @@ -14,17 +18,16 @@ public function testHasTrigg...
true
Other
laravel
framework
4f9192ffc410c5bf976f0ea6093f37fd0745283a.json
Escape path directly in build command
src/Illuminate/Console/Scheduling/Event.php
@@ -212,12 +212,13 @@ protected function callAfterCallbacks(Container $container) */ public function buildCommand() { + $output = ProcessUtils::escapeArgument($this->output); $redirect = $this->shouldAppendOutput ? ' >> ' : ' > '; if ($this->withoutOverlapping) { - ...
true
Other
laravel
framework
4f9192ffc410c5bf976f0ea6093f37fd0745283a.json
Escape path directly in build command
tests/Console/Scheduling/EventTest.php
@@ -9,7 +9,7 @@ public function testBuildCommand() $event = new Event('php -i'); $defaultOutput = (DIRECTORY_SEPARATOR == '\\') ? 'NUL' : '/dev/null'; - $this->assertSame("php -i > {$defaultOutput} 2>&1 &", $event->buildCommand()); + $this->assertSame("php -i > '{$defaultOutput}' 2>&1 ...
true
Other
laravel
framework
5be7f261e8a2f03d6fa6be99eb79e261a880421d.json
change method order
src/Illuminate/Cache/TaggedCache.php
@@ -71,6 +71,14 @@ public function flush() $this->tags->reset(); } + /** + * {@inheritdoc} + */ + protected function itemKey($key) + { + return $this->taggedItemKey($key); + } + /** * Get a fully qualified key for a tagged item. * @@ -81,12 +89,4 @@ public fun...
false
Other
laravel
framework
5317cb529989e73793a64bbfc3ae9b6ed55ed3fd.json
fix method order.
src/Illuminate/Database/Query/Grammars/PostgresGrammar.php
@@ -33,6 +33,71 @@ protected function compileLock(Builder $query, $value) return $value ? 'for update' : 'for share'; } + /** + * Compile a "where date" clause. + * + * @param \Illuminate\Database\Query\Builder $query + * @param array $where + * @return string + */ + pr...
false
Other
laravel
framework
7f92e438efee87203f018f82beb6aed6e5c1f995.json
Fix typo on closing tag
src/Illuminate/Auth/Console/stubs/make/views/layouts/app.stub
@@ -65,7 +65,7 @@ <ul class="dropdown-menu" role="menu"> <li><a href="{{ url('/logout') }}"><i class="fa fa-btn fa-sign-out"></i>Logout</a></li> </ul> - <li> + </li> ...
false
Other
laravel
framework
bad938609f113c7af6863bedd67076ff8b8cf996.json
Fix closing tag
src/Illuminate/Auth/Console/stubs/make/views/layouts/app.stub
@@ -65,7 +65,7 @@ <ul class="dropdown-menu" role="menu"> <li><a href="{{ url('/logout') }}"><i class="fa fa-btn fa-sign-out"></i>Logout</a></li> </ul> - <li> + </li> ...
false
Other
laravel
framework
92a3b24ba8fea8cb0342c8efbf0b7025ec98496b.json
update validation logic
src/Illuminate/Foundation/Application.php
@@ -25,7 +25,7 @@ class Application extends Container implements ApplicationContract, HttpKernelIn * * @var string */ - const VERSION = '5.2.1'; + const VERSION = '5.2.2'; /** * The base path for the Laravel installation.
true
Other
laravel
framework
92a3b24ba8fea8cb0342c8efbf0b7025ec98496b.json
update validation logic
src/Illuminate/Validation/Validator.php
@@ -806,7 +806,7 @@ protected function validateArray($attribute, $value) return true; } - return is_array($value); + return is_null($value) || is_array($value); } /** @@ -824,7 +824,7 @@ protected function validateBoolean($attribute, $value) $acceptable = [tr...
true
Other
laravel
framework
92a3b24ba8fea8cb0342c8efbf0b7025ec98496b.json
update validation logic
tests/Validation/ValidationValidatorTest.php
@@ -1874,8 +1874,14 @@ public function testThatPrimitiveTypesAreImplicitAndMustBeCorrectIfDataIsPresent $v = new Validator($trans, [], ['foo' => 'numeric']); $this->assertTrue($v->passes()); + // Allow null on these rules unless required $trans = $this->getRealTranslator(); ...
true
Other
laravel
framework
acf0fb9bbf24972defafc2844b9a524e0855306e.json
fix bug in soft delete scope application.
src/Illuminate/Database/Eloquent/Builder.php
@@ -87,6 +87,10 @@ public function withGlobalScope($identifier, $scope) { $this->scopes[$identifier] = $scope; + if (method_exists($scope, 'extend')) { + $scope->extend($this); + } + return $this; }
true
Other
laravel
framework
acf0fb9bbf24972defafc2844b9a524e0855306e.json
fix bug in soft delete scope application.
src/Illuminate/Database/Eloquent/SoftDeletingScope.php
@@ -21,8 +21,6 @@ class SoftDeletingScope implements Scope public function apply(Builder $builder, Model $model) { $builder->whereNull($model->getQualifiedDeletedAtColumn()); - - $this->extend($builder); } /**
true
Other
laravel
framework
acf0fb9bbf24972defafc2844b9a524e0855306e.json
fix bug in soft delete scope application.
tests/Database/DatabaseSoftDeletingScopeTest.php
@@ -16,7 +16,6 @@ public function testApplyingScopeToABuilder() $model = m::mock('Illuminate\Database\Eloquent\Model'); $model->shouldReceive('getQualifiedDeletedAtColumn')->once()->andReturn('table.deleted_at'); $builder->shouldReceive('whereNull')->once()->with('table.deleted_at'); - ...
true
Other
laravel
framework
e5255cd7b57c5e5d3fb04d5512bcc9ce2c4401cf.json
Remove unnecessary in foreach.
src/Illuminate/Support/Collection.php
@@ -153,7 +153,7 @@ public function every($step, $offset = 0) $position = 0; - foreach ($this->items as $key => $item) { + foreach ($this->items as $item) { if ($position % $step === $offset) { $new[] = $item; }
false
Other
laravel
framework
d43f114b02133269e9c2571169e11deb1c456921.json
Remove unnecessary $key in foreach
src/Illuminate/Container/Container.php
@@ -533,7 +533,7 @@ protected function getMethodDependencies($callback, array $parameters = []) { $dependencies = []; - foreach ($this->getCallReflector($callback)->getParameters() as $key => $parameter) { + foreach ($this->getCallReflector($callback)->getParameters() as $parameter) { ...
false
Other
laravel
framework
6547088dbd7ec931761737cfbb5e55a17165f99f.json
Fix bug in validation message retrieval.
src/Illuminate/Validation/Validator.php
@@ -1663,9 +1663,9 @@ protected function getInlineMessage($attribute, $lowerRule, $source = null) // message for the fields, then we will check for a general custom line // that is not attribute specific. If we find either we'll return it. foreach ($keys as $key) { - foreach (array...
false
Other
laravel
framework
8b6c5e6a7c4f00169b217b659ec3d307d2fa81c0.json
fix pagination bug
src/Illuminate/Database/Eloquent/Builder.php
@@ -336,7 +336,7 @@ public function paginate($perPage = null, $columns = ['*'], $pageName = 'page', $total = $query->getCountForPagination(); - $query->forPage( + $this->forPage( $page = $page ?: Paginator::resolveCurrentPage($pageName), $perPage = $perPage ?: $this-...
false
Other
laravel
framework
b17da439be7248cf9fad565982541348de6f90b6.json
Use the new makeVisible method in the tests
tests/Database/DatabaseEloquentCollectionTest.php
@@ -226,7 +226,7 @@ public function testExceptReturnsCollectionWithoutGivenModelKeys() public function testWithHiddenSetsHiddenOnEntireCollection() { $c = new Collection([new TestEloquentCollectionModel]); - $c = $c->withHidden(['hidden']); + $c = $c->makeVisible(['hidden']); ...
true
Other
laravel
framework
b17da439be7248cf9fad565982541348de6f90b6.json
Use the new makeVisible method in the tests
tests/Database/DatabaseEloquentModelTest.php
@@ -698,7 +698,7 @@ public function testWithHidden() { $model = new EloquentModelStub(['name' => 'foo', 'age' => 'bar', 'id' => 'baz']); $model->setHidden(['age', 'id']); - $model->withHidden('age'); + $model->makeVisible('age'); $array = $model->toArray(); $this->...
true
Other
laravel
framework
e5853da9a0484d54aa28a9a2e4ed774bb4f954a4.json
Remove unused variable $declaringClass
src/Illuminate/Container/Container.php
@@ -814,8 +814,6 @@ protected function getDependencies(array $parameters, array $primitives = []) */ protected function resolveNonClass(ReflectionParameter $parameter) { - $declaringClass = $parameter->getDeclaringClass(); - if (! is_null($concrete = $this->getContextualConcrete('$'.$par...
false
Other
laravel
framework
172ef6a271af0776f9f587671d0da7ec18a25d95.json
Fix RequestGuard::user() returning void Broken since f8a8e775c79f012806c9bef4d0302b14d9e14a1f
src/Illuminate/Auth/RequestGuard.php
@@ -51,7 +51,7 @@ public function user() return $this->user; } - $this->user = call_user_func($this->callback, $this->request); + return $this->user = call_user_func($this->callback, $this->request); } /**
false
Other
laravel
framework
84bd1731c43a941758e486e68b890d5b6dbde73c.json
reset global scopes when booted models get cleared
src/Illuminate/Database/Eloquent/Model.php
@@ -332,6 +332,7 @@ protected static function bootTraits() public static function clearBootedModels() { static::$booted = []; + static::$globalScopes = []; } /**
false
Other
laravel
framework
3586d080ea048cf1fa4430dc85e707bb9b0e7473.json
Use data_get in request.
src/Illuminate/Http/Request.php
@@ -290,7 +290,7 @@ public function input($key = null, $default = null) { $input = $this->getInputSource()->all() + $this->query->all(); - return Arr::get($input, $key, $default); + return data_get($input, $key, $default); } /** @@ -308,7 +308,7 @@ public function only($keys) ...
false
Other
laravel
framework
8e6ac01b4a311ec4740ab2bced01fbdf6f1241c5.json
make resource opt in
src/Illuminate/Routing/Console/ControllerMakeCommand.php
@@ -19,7 +19,7 @@ class ControllerMakeCommand extends GeneratorCommand * * @var string */ - protected $description = 'Create a new resource controller class'; + protected $description = 'Create a new controller class'; /** * The type of class being generated. @@ -35,11 +35,11 @@ cla...
false
Other
laravel
framework
cee00096f03e223967a689fdebeca657d5a9c675.json
Add tests for array access implementation.
tests/Support/SupportCollectionTest.php
@@ -142,6 +142,52 @@ public function testOffsetAccess() $this->assertEquals('jason', $c[0]); } + public function testArrayAccessOffsetExists() + { + $c = new Collection(['foo', 'bar']); + $this->assertTrue($c->offsetExists(0)); + $this->assertTrue($c->offsetExists(1)); + ...
false
Other
laravel
framework
29031cb70a60932e40b317ad4c9e693b82564afc.json
Fix a long line.
src/Illuminate/Auth/Console/MakeAuthCommand.php
@@ -50,7 +50,10 @@ public function fire() if (! $this->option('views')) { $this->info('Installed HomeController.'); - copy(__DIR__.'/stubs/make/controllers/HomeController.stub', app_path('Http/Controllers/HomeController.php')); + copy( + __DIR__.'/stubs/make/...
false
Other
laravel
framework
3616c2d43a22df8f6d87d788918a05b22c5c29e4.json
Use provider for consistent language.
src/Illuminate/Auth/AuthManager.php
@@ -99,7 +99,7 @@ protected function callCustomCreator($name, array $config) */ public function createSessionDriver($name, $config) { - $provider = $this->createUserProvider($config['source']); + $provider = $this->createUserProvider($config['provider']); $guard = new SessionGua...
true
Other
laravel
framework
3616c2d43a22df8f6d87d788918a05b22c5c29e4.json
Use provider for consistent language.
src/Illuminate/Auth/CreatesUserProviders.php
@@ -23,7 +23,7 @@ trait CreatesUserProviders */ protected function createUserProvider($provider) { - $config = $this->app['config']['auth.sources.'.$provider]; + $config = $this->app['config']['auth.providers.'.$provider]; if (isset($this->customProviderCreators[$provider])) { ...
true
Other
laravel
framework
3616c2d43a22df8f6d87d788918a05b22c5c29e4.json
Use provider for consistent language.
src/Illuminate/Auth/Passwords/PasswordBrokerManager.php
@@ -69,7 +69,7 @@ protected function resolve($name) // aggregate service of sorts providing a convenient interface for resets. return new PasswordBroker( $this->createTokenRepository($config), - $this->createUserProvider($config['source']), + $this->createUserProvide...
true