language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
laravel
framework
078697196e7f7f6c3315c8657ec2fb2310c4d423.json
Fix selected columns on hasManyThrough
tests/Database/DatabaseEloquentHasManyThroughTest.php
@@ -66,6 +66,43 @@ public function testModelsAreProperlyMatchedToParents() } + public function testAllColumnsAreSelectedByDefault() + { + $select = array('posts.*', 'users.country_id'); + + $baseBuilder = m::mock('Illuminate\Database\Query\Builder'); + + $relation = $this->getRelation(); + $relation->getRelat...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Hashing/HashServiceProvider.php
@@ -1,34 +1,34 @@ -<?php namespace Illuminate\Hashing; - -use Illuminate\Support\ServiceProvider; - -class HashServiceProvider extends ServiceProvider { - - /** - * Indicates if loading of the provider is deferred. - * - * @var bool - */ - protected $defer = true; - - /** - * Register the service pro...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Pagination/PaginationServiceProvider.php
@@ -1,25 +1,25 @@ -<?php namespace Illuminate\Pagination; - -use Illuminate\Support\ServiceProvider; - -class PaginationServiceProvider extends ServiceProvider { - - /** - * Register the service provider. - * - * @return void - */ - public function register() - { - Paginator::currentPathResolver(funct...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Queue/Console/ListenCommand.php
@@ -1,145 +1,145 @@ -<?php namespace Illuminate\Queue\Console; - -use Illuminate\Queue\Listener; -use Illuminate\Console\Command; -use Symfony\Component\Console\Input\InputOption; -use Symfony\Component\Console\Input\InputArgument; - -class ListenCommand extends Command { - - /** - * The console command name...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Redis/RedisServiceProvider.php
@@ -1,37 +1,37 @@ -<?php namespace Illuminate\Redis; - -use Illuminate\Support\ServiceProvider; - -class RedisServiceProvider extends ServiceProvider { - - /** - * Indicates if loading of the provider is deferred. - * - * @var bool - */ - protected $defer = true; - - /** - * Register the service prov...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Routing/Matching/HostValidator.php
@@ -1,22 +1,22 @@ -<?php namespace Illuminate\Routing\Matching; - -use Illuminate\Http\Request; -use Illuminate\Routing\Route; - -class HostValidator implements ValidatorInterface { - - /** - * Validate a given rule against a route and request. - * - * @param \Illuminate\Routing\Route $route - * @param...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Routing/Matching/MethodValidator.php
@@ -1,20 +1,20 @@ -<?php namespace Illuminate\Routing\Matching; - -use Illuminate\Http\Request; -use Illuminate\Routing\Route; - -class MethodValidator implements ValidatorInterface { - - /** - * Validate a given rule against a route and request. - * - * @param \Illuminate\Routing\Route $route - * @par...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Routing/Matching/SchemeValidator.php
@@ -1,29 +1,29 @@ -<?php namespace Illuminate\Routing\Matching; - -use Illuminate\Http\Request; -use Illuminate\Routing\Route; - -class SchemeValidator implements ValidatorInterface { - - /** - * Validate a given rule against a route and request. - * - * @param \Illuminate\Routing\Route $route - * @par...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Routing/Matching/UriValidator.php
@@ -1,22 +1,22 @@ -<?php namespace Illuminate\Routing\Matching; - -use Illuminate\Http\Request; -use Illuminate\Routing\Route; - -class UriValidator implements ValidatorInterface { - - /** - * Validate a given rule against a route and request. - * - * @param \Illuminate\Routing\Route $route - * @param ...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Routing/Matching/ValidatorInterface.php
@@ -1,17 +1,17 @@ -<?php namespace Illuminate\Routing\Matching; - -use Illuminate\Http\Request; -use Illuminate\Routing\Route; - -interface ValidatorInterface { - - /** - * Validate a given rule against a route and request. - * - * @param \Illuminate\Routing\Route $route - * @param \Illuminate\Http\Re...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Session/SessionManager.php
@@ -1,208 +1,208 @@ -<?php namespace Illuminate\Session; - -use Illuminate\Support\Manager; -use Symfony\Component\HttpFoundation\Session\Storage\Handler\NullSessionHandler; - -class SessionManager extends Manager { - - /** - * Call a custom driver creator. - * - * @param string $driver - * @return mix...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Session/SessionServiceProvider.php
@@ -1,52 +1,52 @@ -<?php namespace Illuminate\Session; - -use Illuminate\Support\ServiceProvider; - -class SessionServiceProvider extends ServiceProvider { - - /** - * Register the service provider. - * - * @return void - */ - public function register() - { - $this->registerSessionManager(); - - $t...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/App.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Foundation\Application - */ -class App extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'app'; } - -} +...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Artisan.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Foundation\Artisan - */ -class Artisan extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'Illuminate\Contra...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Auth.php
@@ -1,16 +1,16 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Auth\AuthManager - * @see \Illuminate\Auth\Guard - */ -class Auth extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor()...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Cache.php
@@ -1,16 +1,16 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Cache\CacheManager - * @see \Illuminate\Cache\Repository - */ -class Cache extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeA...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Config.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Config\Repository - */ -class Config extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'config'; } - -} ...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Cookie.php
@@ -1,38 +1,38 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Cookie\CookieJar - */ -class Cookie extends Facade { - - /** - * Determine if a cookie exists on the request. - * - * @param string $key - * @return bool - */ - public static function has($key) - { - return...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Crypt.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Encryption\Encrypter - */ -class Crypt extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'encrypter'; } - ...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/DB.php
@@ -1,16 +1,16 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Database\DatabaseManager - * @see \Illuminate\Database\Connection - */ -class DB extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getF...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Event.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Events\Dispatcher - */ -class Event extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'events'; } - -} +...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/File.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Filesystem\Filesystem - */ -class File extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'files'; } - -} ...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Hash.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Hashing\BcryptHasher - */ -class Hash extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'hash'; } - -} +...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Input.php
@@ -1,29 +1,29 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Http\Request - */ -class Input extends Facade { - - /** - * Get an item from the input data. - * - * This method is used for all request verbs (GET, POST, PUT, and DELETE) - * - * @param string $key - * @para...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Lang.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Translation\Translator - */ -class Lang extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'translator'; } ...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Log.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Log\Writer - */ -class Log extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'log'; } - -} +<?php namesp...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Mail.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Mail\Mailer - */ -class Mail extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'mailer'; } - -} +<?php n...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Redirect.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Routing\Redirector - */ -class Redirect extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'redirect'; } - ...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Redis.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Redis\Database - */ -class Redis extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'redis'; } - -} +<?ph...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Request.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Http\Request - */ -class Request extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'request'; } - -} +<?...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Route.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Routing\Router - */ -class Route extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'router'; } - -} +<?p...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Schema.php
@@ -1,29 +1,29 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Database\Schema\Builder - */ -class Schema extends Facade { - - /** - * Get a schema builder instance for a connection. - * - * @param string $name - * @return \Illuminate\Database\Schema\Builder - */ - public...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Session.php
@@ -1,16 +1,16 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Session\SessionManager - * @see \Illuminate\Session\Store - */ -class Session extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFaca...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/URL.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Routing\UrlGenerator - */ -class URL extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'url'; } - -} +<?...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/Validator.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\Validation\Factory - */ -class Validator extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'validator'; } ...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/Support/Facades/View.php
@@ -1,15 +1,15 @@ -<?php namespace Illuminate\Support\Facades; - -/** - * @see \Illuminate\View\Factory - */ -class View extends Facade { - - /** - * Get the registered name of the component. - * - * @return string - */ - protected static function getFacadeAccessor() { return 'view'; } - -} +<?php na...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
src/Illuminate/View/ViewServiceProvider.php
@@ -1,129 +1,129 @@ -<?php namespace Illuminate\View; - -use Illuminate\View\Engines\PhpEngine; -use Illuminate\Support\ServiceProvider; -use Illuminate\View\Engines\CompilerEngine; -use Illuminate\View\Engines\EngineResolver; -use Illuminate\View\Compilers\BladeCompiler; - -class ViewServiceProvider extends Se...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
tests/Queue/QueueListenerTest.php
@@ -1,47 +1,47 @@ -<?php - -use Mockery as m; - -class QueueListenerTest extends PHPUnit_Framework_TestCase { - - public function tearDown() - { - m::close(); - } - - - public function testRunProcessCallsProcess() - { - $process = m::mock('Symfony\Component\Process\Process')->makePartial(); - $process...
true
Other
laravel
framework
ec0df100c5b97aeeb5e478e65ba5e5689365dd93.json
Normalize all the line endings
tests/Support/SupportMessageBagTest.php
@@ -1,165 +1,165 @@ -<?php - -use Illuminate\Support\MessageBag; -use Mockery as m; - -class SupportMessageBagTest extends PHPUnit_Framework_TestCase { - - public function tearDown() - { - m::close(); - } - - - public function testUniqueness() - { - $container = new MessageBag; - $container->add('foo...
true
Other
laravel
framework
4d2764e9bf1e0fbe05da66d2701db493af870390.json
Ask git to use unix style newlines
.gitattributes
@@ -1,3 +1,5 @@ +* text=auto + /build export-ignore /tests export-ignore .gitattributes export-ignore
false
Other
laravel
framework
6670a242a822676fbf995e6d494c4720acc810ae.json
Use FETCH_OBJ instead of FETCH_CLASS.
src/Illuminate/Database/Capsule/Manager.php
@@ -44,7 +44,7 @@ public function __construct(Container $container = null) */ protected function setupDefaultConfiguration() { - $this->container['config']['database.fetch'] = PDO::FETCH_CLASS; + $this->container['config']['database.fetch'] = PDO::FETCH_OBJ; $this->container['config']['database.default'] ...
true
Other
laravel
framework
6670a242a822676fbf995e6d494c4720acc810ae.json
Use FETCH_OBJ instead of FETCH_CLASS.
src/Illuminate/Database/Connection.php
@@ -66,7 +66,7 @@ class Connection implements ConnectionInterface { * * @var int */ - protected $fetchMode = PDO::FETCH_CLASS; + protected $fetchMode = PDO::FETCH_OBJ; /** * The number of active transactions.
true
Other
laravel
framework
419d3f485ce7946cace4325ef19a30e1d5543951.json
allow forcing of stroage directory for opts
src/Illuminate/Foundation/Application.php
@@ -20,7 +20,7 @@ class Application extends Container implements ApplicationContract, HttpKernelIn * * @var string */ - const VERSION = '5.0.19'; + const VERSION = '5.0.20'; /** * The base path for the Laravel installation. @@ -92,6 +92,13 @@ class Application extends Container implements ApplicationCon...
false
Other
laravel
framework
08f27292942aadabeb577557a16832305e4a655a.json
Use LONGTEXT instead of TEXT
src/Illuminate/Queue/Console/stubs/failed_jobs.stub
@@ -16,7 +16,7 @@ class CreateFailedJobsTable extends Migration $table->increments('id'); $table->text('connection'); $table->text('queue'); - $table->text('payload'); + $table->longText('payload'); $table->timestamp('failed_at'); }); ...
false
Other
laravel
framework
cfba00f2dee92bbba9343004d3d1e8aa0a3e269e.json
Make migration opt-in with shortcut.
src/Illuminate/Foundation/Console/ModelMakeCommand.php
@@ -35,7 +35,7 @@ public function fire() { parent::fire(); - if ( ! $this->option('no-migration')) + if ($this->option('migration')) { $table = str_plural(snake_case(class_basename($this->argument('name')))); @@ -72,7 +72,7 @@ protected function getDefaultNamespace($rootNamespace) protected function...
false
Other
laravel
framework
033801f0ba200a4f7c5e8bb54cbd6c7524e91038.json
Simplify app helper. Remove recursive call.
src/Illuminate/Foundation/helpers.php
@@ -1,6 +1,7 @@ <?php use Illuminate\Support\Str; +use Illuminate\Container\Container; if ( ! function_exists('abort')) { @@ -45,14 +46,11 @@ function action($name, $parameters = array()) * @param array $parameters * @return mixed|\Illuminate\Foundation\Application */ - function app($make = null, $p...
false
Other
laravel
framework
b7c4b1c1acf973b2cc50f1a7c2a7190d91623a06.json
Use useAsCallable instead of is_callable
src/Illuminate/Support/Collection.php
@@ -89,7 +89,7 @@ public function contains($key, $value = null) }); } - if (is_callable($key)) + if ($this->useAsCallable($key)) { return ! is_null($this->first($key)); }
false
Other
laravel
framework
3dbb9588885b93ffde1f65015ff74a057d11329b.json
Add parameters to app() function
src/Illuminate/Foundation/helpers.php
@@ -42,13 +42,14 @@ function action($name, $parameters = array()) * Get the available container instance. * * @param string $make - * @return mixed + * @param array $parameters + * @return mixed|\Illuminate\Foundation\Application */ - function app($make = null) + function app($make = null, $paramete...
false
Other
laravel
framework
e22171a44126d458d6e7f89a5ae38fbf15ae321c.json
Add collection to $casts Add support for collection to $casts
src/Illuminate/Database/Eloquent/Model.php
@@ -2739,6 +2739,8 @@ protected function castAttribute($key, $value) case 'array': case 'json': return json_decode($value, true); + case 'collection': + return new Collection(json_decode($value, true)); default: return $value; }
false
Other
laravel
framework
31cfc3b924b7d67cb7869ed566e39d15133770e7.json
Add test for translator replacements back.
tests/Translation/TranslationTranslatorTest.php
@@ -36,6 +36,7 @@ public function testGetMethodProperlyLoadsAndRetrievesItemWithLongestReplacement { $t = $this->getMock('Illuminate\Translation\Translator', null, array($this->getLoader(), 'en')); $t->getLoader()->shouldReceive('load')->once()->with('en', 'bar', 'foo')->andReturn(array('foo' => 'foo', 'baz' =>...
false
Other
laravel
framework
b7fa52c6abb076e6844798f793231bc2886aa0d5.json
Simplify the find method
src/Illuminate/Database/Eloquent/Builder.php
@@ -70,7 +70,7 @@ public function __construct(QueryBuilder $query) * * @param mixed $id * @param array $columns - * @return \Illuminate\Database\Eloquent\Model|static|null + * @return \Illuminate\Database\Eloquent\Model|\Illuminate\Database\Eloquent\Collection|null */ public function find($id, $colu...
true
Other
laravel
framework
b7fa52c6abb076e6844798f793231bc2886aa0d5.json
Simplify the find method
src/Illuminate/Database/Eloquent/Model.php
@@ -684,11 +684,7 @@ public static function all($columns = array('*')) */ public static function find($id, $columns = array('*')) { - $instance = new static; - - if (is_array($id) && empty($id)) return $instance->newCollection(); - - return $instance->newQuery()->find($id, $columns); + return static::query()...
true
Other
laravel
framework
b7fa52c6abb076e6844798f793231bc2886aa0d5.json
Simplify the find method
tests/Database/DatabaseEloquentIntegrationTest.php
@@ -87,9 +87,30 @@ public function tearDown() public function testBasicModelRetrieval() { - EloquentTestUser::create(['email' => 'taylorotwell@gmail.com']); + EloquentTestUser::create(['id' => 1, 'email' => 'taylorotwell@gmail.com']); + EloquentTestUser::create(['id' => 2, 'email' => 'abigailotwell@gmail.com']...
true
Other
laravel
framework
7768a18fb4db21d82172abd875aca08e3d00267e.json
set the controller router on the RouteListCommand. Signed-off-by: Suhayb Wardany <me@suw.me>
src/Illuminate/Foundation/Console/RouteListCommand.php
@@ -4,6 +4,7 @@ use Illuminate\Routing\Route; use Illuminate\Routing\Router; use Illuminate\Console\Command; +use Illuminate\Routing\Controller; use Symfony\Component\Console\Input\InputOption; class RouteListCommand extends Command { @@ -152,6 +153,8 @@ protected function getMiddleware($route) */ protected...
false
Other
laravel
framework
7374ad508917663aee6235f0267f3a58cb7b2790.json
Fix bug in Translator::sortReplacements function.
src/Illuminate/Support/Collection.php
@@ -620,7 +620,7 @@ public function sortBy($callback, $options = SORT_REGULAR, $descending = false) // and grab the corresponding values for the sorted keys from this array. foreach ($this->items as $key => $value) { - $results[$key] = $callback($value); + $results[$key] = $callback($value, $key); } ...
true
Other
laravel
framework
7374ad508917663aee6235f0267f3a58cb7b2790.json
Fix bug in Translator::sortReplacements function.
src/Illuminate/Translation/Translator.php
@@ -145,9 +145,9 @@ protected function makeReplacements($line, array $replace) */ protected function sortReplacements(array $replace) { - return (new Collection($replace))->sortBy(function($r) + return (new Collection($replace))->sortBy(function($value, $key) { - return mb_strlen($r) * -1; + return mb_s...
true
Other
laravel
framework
7374ad508917663aee6235f0267f3a58cb7b2790.json
Fix bug in Translator::sortReplacements function.
tests/Translation/TranslationTranslatorTest.php
@@ -36,7 +36,7 @@ public function testGetMethodProperlyLoadsAndRetrievesItemWithLongestReplacement { $t = $this->getMock('Illuminate\Translation\Translator', null, array($this->getLoader(), 'en')); $t->getLoader()->shouldReceive('load')->once()->with('en', 'bar', 'foo')->andReturn(array('foo' => 'foo', 'baz' =>...
true
Other
laravel
framework
a83dcabd2ec37359bd728faa36b9282be478c8f1.json
Add support for predis client options
src/Illuminate/Redis/Database.php
@@ -40,7 +40,9 @@ protected function createAggregateClient(array $servers) { $servers = array_except($servers, array('cluster')); - return array('default' => new Client(array_values($servers))); + $options = $this->getClientOptions($servers); + + return array('default' => new Client(array_values($servers), $o...
false
Other
laravel
framework
454a73e455c4d7e21532c874b454ab27a0456ba6.json
escape url in pagination bootstrap presenter @ 5.0
src/Illuminate/Pagination/BootstrapThreePresenter.php
@@ -76,7 +76,7 @@ protected function getAvailablePageWrapper($url, $page, $rel = null) { $rel = is_null($rel) ? '' : ' rel="'.$rel.'"'; - return '<li><a href="'.$url.'"'.$rel.'>'.$page.'</a></li>'; + return '<li><a href="'.urlencode($url).'"'.$rel.'>'.$page.'</a></li>'; } /**
false
Other
laravel
framework
cbe3b38bd9e7bd2935691eacccbd1df249ecb1c1.json
Add setValidators method.
src/Illuminate/Routing/Route.php
@@ -636,6 +636,19 @@ public static function getValidators() ); } + /** + * Set the route validators. + * + * @param array $validators + * + * @return void + */ + public static function setValidators($validators) + { + // set validators to match the route. + static:...
false
Other
laravel
framework
fdef01ac600d3f8aa83a2537ce95ccb165a98c8d.json
Use collection to remove soft delete scope
src/Illuminate/Database/Eloquent/SoftDeletingScope.php
@@ -36,18 +36,10 @@ public function remove(Builder $builder, Model $model) $query = $builder->getQuery(); - foreach ((array) $query->wheres as $key => $where) + $query->wheres = collect($query->wheres)->reject(function($where) use ($column) { - // If the where clause is a soft delete date constraint, we w...
false
Other
laravel
framework
04c4b03c15123ebc9a1f943ce965a29c87e5fa3d.json
Add curly brackets
src/Illuminate/Cookie/Middleware/EncryptCookies.php
@@ -87,7 +87,9 @@ protected function decryptArray(array $cookie) $decrypted = array(); foreach ($cookie as $key => $value) + { $decrypted[$key] = $this->encrypter->decrypt($value); + } return $decrypted; }
false
Other
laravel
framework
9279cb5dad9f9eb5714133dd19813b8a7b602668.json
Add a slash after port number
src/Illuminate/Foundation/Console/ServeCommand.php
@@ -34,7 +34,7 @@ public function fire() $base = $this->laravel->basePath(); - $this->info("Laravel development server started on http://{$host}:{$port}"); + $this->info("Laravel development server started on http://{$host}:{$port}/"); passthru('"'.PHP_BINARY.'"'." -S {$host}:{$port} \"{$base}\"/server.ph...
false
Other
laravel
framework
f1c12d64501202d3b5d178bd4b3d28a61997306d.json
Add argument to cache:clear to specify store name.
src/Illuminate/Cache/Console/ClearCommand.php
@@ -2,6 +2,7 @@ use Illuminate\Console\Command; use Illuminate\Cache\CacheManager; +use Symfony\Component\Console\Input\InputArgument; class ClearCommand extends Command { @@ -46,13 +47,27 @@ public function __construct(CacheManager $cache) */ public function fire() { - $this->laravel['events']->fire('...
true
Other
laravel
framework
f1c12d64501202d3b5d178bd4b3d28a61997306d.json
Add argument to cache:clear to specify store name.
tests/Cache/ClearCommandTest.php
@@ -0,0 +1,84 @@ +<?php + +use Mockery as m; +use Illuminate\Foundation\Application; +use Illuminate\Cache\Console\ClearCommand; + +class ClearCommandTest extends PHPUnit_Framework_TestCase { + + public function tearDown() + { + m::close(); + } + + + public function testClearWithNoStoreOption() + { + $command = new C...
true
Other
laravel
framework
cfa7fcb60fd60b3870606c910559e67186a7a8a8.json
Move the location of some storage files.
src/Illuminate/Foundation/Application.php
@@ -433,7 +433,7 @@ public function runningUnitTests() */ public function registerConfiguredProviders() { - $manifestPath = $this->storagePath().DIRECTORY_SEPARATOR.'framework'.DIRECTORY_SEPARATOR.'services.json'; + $manifestPath = $this->basePath().'/vendor/services.json'; (new ProviderRepository($this, ...
true
Other
laravel
framework
cfa7fcb60fd60b3870606c910559e67186a7a8a8.json
Move the location of some storage files.
src/Illuminate/Foundation/Console/ClearCompiledCommand.php
@@ -25,12 +25,12 @@ class ClearCompiledCommand extends Command { */ public function fire() { - if (file_exists($path = $this->laravel->storagePath().'/framework/compiled.php')) + if (file_exists($path = $this->laravel->basePath().'/vendor/compiled.php')) { @unlink($path); } - if (file_exists($path...
true
Other
laravel
framework
cfa7fcb60fd60b3870606c910559e67186a7a8a8.json
Move the location of some storage files.
src/Illuminate/Foundation/Console/OptimizeCommand.php
@@ -86,7 +86,7 @@ protected function compileClasses() { $this->registerClassPreloaderCommand(); - $outputPath = $this->laravel['path.storage'].'/framework/compiled.php'; + $outputPath = $this->laravel['path.base'].'/vendor/compiled.php'; $this->callSilent('compile', array( '--config' => implode(',', $...
true
Other
laravel
framework
27b1d17a420b4556a261c6f7a49115a90edd1018.json
Add type hinting on $parameters
src/Illuminate/Container/Container.php
@@ -543,7 +543,7 @@ protected function isCallableWithAtSign($callback) * @param array $parameters * @return array */ - protected function getMethodDependencies($callback, $parameters = []) + protected function getMethodDependencies($callback, array $parameters = []) { $dependencies = []; @@ -634,7 +63...
true
Other
laravel
framework
27b1d17a420b4556a261c6f7a49115a90edd1018.json
Add type hinting on $parameters
src/Illuminate/Contracts/Container/Container.php
@@ -102,7 +102,7 @@ public function when($concrete); * @param array $parameters * @return mixed */ - public function make($abstract, $parameters = array()); + public function make($abstract, array $parameters = []); /** * Call the given Closure / class@method and inject its dependencies. @@ -112,7 +1...
true
Other
laravel
framework
27b1d17a420b4556a261c6f7a49115a90edd1018.json
Add type hinting on $parameters
src/Illuminate/Foundation/Application.php
@@ -601,7 +601,7 @@ public function registerDeferredProvider($provider, $service = null) * @param array $parameters * @return mixed */ - public function make($abstract, $parameters = array()) + public function make($abstract, array $parameters = array()) { $abstract = $this->getAlias($abstract);
true
Other
laravel
framework
8f63a4e1e982511592e665cea615111fc5e8aa31.json
Remove unnecessary code
src/Illuminate/Cache/FileStore.php
@@ -57,11 +57,6 @@ protected function getPayload($key) // If the file doesn't exists, we obviously can't return the cache so we will // just return null. Otherwise, we'll get the contents of the file and get // the expiration UNIX timestamps from the start of the file's contents. - if ( ! $this->files->exists...
true
Other
laravel
framework
8f63a4e1e982511592e665cea615111fc5e8aa31.json
Remove unnecessary code
tests/Cache/CacheFileStoreTest.php
@@ -1,13 +1,14 @@ <?php use Illuminate\Cache\FileStore; +use Illuminate\Contracts\Filesystem\FileNotFoundException; class CacheFileStoreTest extends PHPUnit_Framework_TestCase { public function testNullIsReturnedIfFileDoesntExist() { $files = $this->mockFilesystem(); - $files->expects($this->once())->m...
true
Other
laravel
framework
56ec53b2428c27db8cf1d546da17ae27f80c7ff2.json
Add empty line.
src/Illuminate/Database/Eloquent/Model.php
@@ -2449,6 +2449,7 @@ protected function getArrayableAppends() public function relationsToArray() { $attributes = array(); + $hidden = $this->getHidden(); foreach ($this->getArrayableRelations() as $key => $value)
false
Other
laravel
framework
0951a30303b6580a2bdcce5df78f6fbbb6497c0f.json
Shorten code by using the cron method
src/Illuminate/Console/Scheduling/Event.php
@@ -264,9 +264,7 @@ public function cron($expression) */ public function hourly() { - $this->expression = '0 * * * * *'; - - return $this; + return $this->cron('0 * * * * *'); } /** @@ -276,9 +274,7 @@ public function hourly() */ public function daily() { - $this->expression = '0 0 * * * *'; - -...
false
Other
laravel
framework
d0d30dd2730c177eb1001c2509b389c4ec22efdc.json
Reduce line length
src/Illuminate/Console/Scheduling/Event.php
@@ -492,9 +492,9 @@ public function everyThirtyMinutes() */ public function days($days) { - $this->spliceIntoPosition(5, implode(',', is_array($days) ? $days : func_get_args())); + $days = is_array($days) ? $days : func_get_args(); - return $this; + return $this->spliceIntoPosition(5, implode(',', $days));...
false
Other
laravel
framework
7667cd511ee7982a7b8bb60234856482c141dfb5.json
Allow define hidden/visible options dynamically.
src/Illuminate/Database/Eloquent/Model.php
@@ -2472,7 +2472,7 @@ public function relationsToArray() foreach ($this->getArrayableRelations() as $key => $value) { - if (in_array($key, $this->hidden)) continue; + if (in_array($key, $this->getHidden())) continue; // If the values implements the Arrayable interface we can just call this // toAr...
true
Other
laravel
framework
7667cd511ee7982a7b8bb60234856482c141dfb5.json
Allow define hidden/visible options dynamically.
tests/Database/DatabaseEloquentModelTest.php
@@ -686,6 +686,56 @@ public function testToArrayUsesMutators() } + public function testHidden() + { + $model = new EloquentModelStub(['name' => 'foo', 'age' => 'bar', 'id' => 'baz']); + $model->setHidden(['age', 'id']); + $array = $model->toArray(); + $this->assertArrayHasKey('name', $array); + $this->assert...
true
Other
laravel
framework
b7d653e408dd8ef396b2a7552f81460d71db25da.json
Fix getFailedLoginMessage typo
src/Illuminate/Foundation/Auth/AuthenticatesAndRegistersUsers.php
@@ -84,7 +84,7 @@ public function postLogin(Request $request) return redirect($this->loginPath()) ->withInput($request->only('email', 'remember')) ->withErrors([ - 'email' => $this->getFailedLoginMesssage(), + 'email' => $this->getFailedLoginMessage(), ]); } @@ -93,7 +93,7 @@ public f...
false
Other
laravel
framework
f9e48b2d59880db3c415a26689c78cc278755973.json
Remove unnecessary line
src/Illuminate/Console/Scheduling/Event.php
@@ -153,8 +153,6 @@ protected function runCommandInForeground(Container $container) */ protected function callAfterCallbacks(Container $container) { - if (empty($this->afterCallbacks)) return; - foreach ($this->afterCallbacks as $callback) { $container->call($callback);
false
Other
laravel
framework
e1ec42e0f70f86608f89a2b2e03e064a80622dd3.json
Remove unused import. Missed out when reverting mutable dotenv. Signed-off-by: crynobone <crynobone@gmail.com>
src/Illuminate/Foundation/Testing/ApplicationTrait.php
@@ -1,6 +1,5 @@ <?php namespace Illuminate\Foundation\Testing; -use Dotenv; use Illuminate\Http\Request; use Illuminate\Contracts\Auth\Authenticatable as UserContract;
false
Other
laravel
framework
94484cd78c314625192d5255ad7c5192dfb00a2b.json
Update TestValidator due to code style
tests/Validation/ValidationValidatorTest.php
@@ -1390,23 +1390,23 @@ public function testValidateEach() $this->assertTrue($v->passes()); } - public function testValidateEachWithNonIndexedArray() - { - $trans = $this->getRealTranslator(); - $data = ['foobar' => [ - ['key' => 'foo', 'value' => 5], - ['key' => 'foo', ...
false
Other
laravel
framework
839c2f9a9f07948037f76be647a0131fbdc465a0.json
Fix config loading.
src/Illuminate/Foundation/Bootstrap/LoadConfiguration.php
@@ -88,7 +88,7 @@ private function getConfigurationNesting(SplFileInfo $file) { $directory = dirname($file->getRealPath()); - if ($tree = trim(str_replace(config_path(), '', $directory), DIRECTORY_SEPARATOR)) + if ($tree = trim(str_replace(str_replace('\\', '/', config_path()), '', str_replace('\\', '/', $dire...
false
Other
laravel
framework
0889eb49a395d92785c52027a854654f2350ffa5.json
fix community contirbution that broke evrything.
src/Illuminate/Foundation/Bootstrap/LoadConfiguration.php
@@ -88,7 +88,7 @@ private function getConfigurationNesting(SplFileInfo $file) { $directory = dirname($file->getRealPath()); - if ($tree = trim(str_replace(str_replace('/', '\\', config_path()), '', $directory), DIRECTORY_SEPARATOR)) + if ($tree = trim(str_replace(config_path(), '', $directory), DIRECTORY_SEPAR...
false
Other
laravel
framework
69689061c177ae06c9da9015eede47cc24bed670.json
Fix Windows path Fix 9aed416700bc8e9082e8fb17c4a2b1579d3c3942
src/Illuminate/Foundation/Bootstrap/LoadConfiguration.php
@@ -88,7 +88,7 @@ private function getConfigurationNesting(SplFileInfo $file) { $directory = dirname($file->getRealPath()); - if ($tree = trim(str_replace(config_path(), '', $directory), DIRECTORY_SEPARATOR)) + if ($tree = trim(str_replace(str_replace('/', '\\', config_path()), '', $directory), DIRECTORY_SEPAR...
false
Other
laravel
framework
2a32d0526a690e78a5180750de511f934fdec67e.json
Add missing console dependency
src/Illuminate/Console/composer.json
@@ -11,7 +11,8 @@ "require": { "php": ">=5.4.0", "illuminate/contracts": "5.0.*", - "symfony/console": "2.6.*" + "symfony/console": "2.6.*", + "nesbot/carbon": "~1.0" }, "autoload": { "psr-4": {
false
Other
laravel
framework
389bc84afdff2d51fc9f47dfca897f135e1f8159.json
Remove useless brackets
src/Illuminate/Database/Eloquent/Collection.php
@@ -106,7 +106,7 @@ public function max($key) { return $this->reduce(function($result, $item) use ($key) { - return (is_null($result) || $item->{$key} > $result) ? $item->{$key} : $result; + return is_null($result) || $item->{$key} > $result ? $item->{$key} : $result; }); } @@ -120,7 +120,7 @@ public...
true
Other
laravel
framework
389bc84afdff2d51fc9f47dfca897f135e1f8159.json
Remove useless brackets
src/Illuminate/Database/Eloquent/Model.php
@@ -1060,7 +1060,7 @@ protected function getBelongsToManyCaller() { $caller = $trace['function']; - return ( ! in_array($caller, Model::$manyMethods) && $caller != $self); + return ! in_array($caller, Model::$manyMethods) && $caller != $self; }); return ! is_null($caller) ? $caller['function'] : nu...
true
Other
laravel
framework
389bc84afdff2d51fc9f47dfca897f135e1f8159.json
Remove useless brackets
src/Illuminate/Database/Query/Builder.php
@@ -528,7 +528,7 @@ protected function invalidOperatorAndValue($operator, $value) { $isOperator = in_array($operator, $this->operators); - return ($isOperator && $operator != '=' && is_null($value)); + return $isOperator && $operator != '=' && is_null($value); } /**
true
Other
laravel
framework
389bc84afdff2d51fc9f47dfca897f135e1f8159.json
Remove useless brackets
src/Illuminate/Foundation/Console/RouteListCommand.php
@@ -192,8 +192,8 @@ protected function getControllerMiddlewareFromInstance($controller, $method) */ protected function methodExcludedByOptions($method, array $options) { - return (( ! empty($options['only']) && ! in_array($method, (array) $options['only'])) || - ( ! empty($options['except']) && in_array($meth...
true
Other
laravel
framework
389bc84afdff2d51fc9f47dfca897f135e1f8159.json
Remove useless brackets
src/Illuminate/Routing/ControllerDispatcher.php
@@ -141,8 +141,8 @@ protected function getMiddleware($instance, $method) */ public function methodExcludedByOptions($method, array $options) { - return (( ! empty($options['only']) && ! in_array($method, (array) $options['only'])) || - ( ! empty($options['except']) && in_array($method, (array) $options['excep...
true
Other
laravel
framework
389bc84afdff2d51fc9f47dfca897f135e1f8159.json
Remove useless brackets
src/Illuminate/Routing/Router.php
@@ -1107,7 +1107,7 @@ protected function filterSupportsMethod($filter, $method) { $methods = $filter['methods']; - return (is_null($methods) || in_array($method, $methods)); + return is_null($methods) || in_array($method, $methods); } /** @@ -1261,7 +1261,7 @@ public function has($name) */ public fu...
true
Other
laravel
framework
389bc84afdff2d51fc9f47dfca897f135e1f8159.json
Remove useless brackets
src/Illuminate/Support/MessageBag.php
@@ -118,7 +118,7 @@ public function first($key = null, $format = null) { $messages = is_null($key) ? $this->all($format) : $this->get($key, $format); - return (count($messages) > 0) ? $messages[0] : ''; + return count($messages) > 0 ? $messages[0] : ''; } /** @@ -196,7 +196,7 @@ protected function transf...
true
Other
laravel
framework
389bc84afdff2d51fc9f47dfca897f135e1f8159.json
Remove useless brackets
src/Illuminate/Validation/Validator.php
@@ -753,7 +753,7 @@ protected function validateSame($attribute, $value, $parameters) $other = array_get($this->data, $parameters[0]); - return (isset($other) && $value == $other); + return isset($other) && $value == $other; } /** @@ -770,7 +770,7 @@ protected function validateDifferent($attribute, $value...
true
Other
laravel
framework
2b59a8ff744a490a9f4f5f16057386ef7b79f6e6.json
Use str_random instead of str_shuffle.
src/Illuminate/Auth/Passwords/DatabaseTokenRepository.php
@@ -166,11 +166,7 @@ public function deleteExpired() */ public function createNewToken(CanResetPasswordContract $user) { - $email = $user->getEmailForPasswordReset(); - - $value = str_shuffle(sha1($email.spl_object_hash($this).microtime(true))); - - return hash_hmac('sha1', $value, $this->hashKey); + return ...
false
Other
laravel
framework
605e7f0dc56da4e29fd06e332c33e60f23b80b38.json
Fix some bugs in contains.
src/Illuminate/Database/Eloquent/Collection.php
@@ -67,12 +67,22 @@ public function add($item) */ public function contains($key, $value = null) { - if (func_num_args() == 1) + if (func_num_args() == 1 && ! $key instanceof Closure) { - return ! is_null($this->find($key)); + $key = $key instanceof Model ? $key->getKey() : $key; + + return $this->filt...
false
Other
laravel
framework
3f23f3a54c9de14e13a87a1704eeff6d5790cb89.json
Return payload - fixes #7617
src/Illuminate/Queue/Jobs/SyncJob.php
@@ -49,7 +49,7 @@ public function fire() */ public function getRawBody() { - // + return $this->payload; } /**
false
Other
laravel
framework
9e07a6870b44e7a70155c58a60b51eed22984d0e.json
Use FQCN for Auth facade
src/Illuminate/Foundation/Auth/AuthenticatesAndRegistersUsers.php
@@ -1,7 +1,7 @@ <?php namespace Illuminate\Foundation\Auth; -use Auth; use Illuminate\Http\Request; +use Illuminate\Support\Facades\Auth; use Illuminate\Contracts\Auth\Guard; use Illuminate\Contracts\Auth\Registrar;
false
Other
laravel
framework
9f52c6ff60134d709fc13f1201a27f87c81bf50f.json
Run tests on 7.0.
.travis.yml
@@ -4,8 +4,13 @@ php: - 5.4 - 5.5 - 5.6 + - 7.0 - hhvm +matrix: + allow_failures: + - php: 7.0 + sudo: false install: travis_retry composer install --no-interaction --prefer-source
false
Other
laravel
framework
061a24a2c1b1898bf39997bade3105867c848f7f.json
Use fallback in Translation::choice Fixes #7490
src/Illuminate/Translation/Translator.php
@@ -162,7 +162,7 @@ protected function sortReplacements(array $replace) */ public function choice($key, $number, array $replace = array(), $locale = null) { - $line = $this->get($key, $replace, $locale = $locale ?: $this->locale); + $line = $this->get($key, $replace, $locale = $locale ?: $this->locale ?: $this...
false