language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
laravel
framework
8f1c4334297d4aad9ccbd3bac7b894b3ff662855.json
Prevent array_forget() from mixing up references
src/Illuminate/Support/Arr.php
@@ -176,6 +176,8 @@ public static function flatten($array) */ public static function forget(&$array, $keys) { + $original =& $array; + foreach ((array) $keys as $key) { $parts = explode('.', $key); @@ -191,6 +193,9 @@ public static function forget(&$array, $keys) } unset($array[array_shift($...
true
Other
laravel
framework
8f1c4334297d4aad9ccbd3bac7b894b3ff662855.json
Prevent array_forget() from mixing up references
tests/Support/SupportHelpersTest.php
@@ -47,6 +47,11 @@ public function testArrayForget() $this->assertFalse(isset($array['names']['developer'])); $this->assertFalse(isset($array['names']['otherDeveloper'])); $this->assertTrue(isset($array['names']['thirdDeveloper'])); + + $array = ['names' => ['developer' => 'taylor', 'otherDeveloper' => 'dayle...
true
Other
laravel
framework
fef787ba94e20c0942274e68fa10ed84f91c8a2e.json
Rmove useless use in commands
src/Illuminate/Database/Console/Migrations/StatusCommand.php
@@ -1,7 +1,6 @@ <?php namespace Illuminate\Database\Console\Migrations; use Illuminate\Database\Migrations\Migrator; -use Symfony\Component\Console\Input\InputOption; class StatusCommand extends BaseCommand {
true
Other
laravel
framework
fef787ba94e20c0942274e68fa10ed84f91c8a2e.json
Rmove useless use in commands
src/Illuminate/Foundation/Console/RouteCacheCommand.php
@@ -3,8 +3,6 @@ use Illuminate\Console\Command; use Illuminate\Filesystem\Filesystem; use Illuminate\Routing\RouteCollection; -use Symfony\Component\Console\Input\InputOption; -use Symfony\Component\Console\Input\InputArgument; class RouteCacheCommand extends Command {
true
Other
laravel
framework
fef787ba94e20c0942274e68fa10ed84f91c8a2e.json
Rmove useless use in commands
src/Illuminate/Foundation/Console/RouteClearCommand.php
@@ -1,10 +1,7 @@ <?php namespace Illuminate\Foundation\Console; -use Illuminate\Routing\Router; use Illuminate\Console\Command; use Illuminate\Filesystem\Filesystem; -use Symfony\Component\Console\Input\InputOption; -use Symfony\Component\Console\Input\InputArgument; class RouteClearCommand extends Command {
true
Other
laravel
framework
630a717c25e5f443f3e0c9dce053581be7768e0a.json
Add note about changed instance to changes file
src/Illuminate/Foundation/changes.json
@@ -11,7 +11,8 @@ {"message": "Passing an Eloquent model to a URL generator method will now automatically pull its ID.", "backport": null}, {"message": "Make both {{ }} and {{{ }}} escape values by default, new {!! !!} construct to echo raw data.", "backport": null}, {"message": "Add 'after' callback to Valida...
false
Other
laravel
framework
5281856203bdafc48025b2c4bf6dfef0a5496678.json
Remove prefix from tagged cache get. Unnecessary.
src/Illuminate/Cache/TaggedCache.php
@@ -134,11 +134,11 @@ public function forever($key, $value) * Remove an item from the cache. * * @param string $key - * @return void + * @return bool */ public function forget($key) { - $this->store->forget($this->taggedItemKey($key)); + return $this->store->forget($this->taggedItemKey($key)); }...
false
Other
laravel
framework
cc148714b51b56e5eb4701deea8d3be8dcb8e1b6.json
Fix white space.
src/Illuminate/Database/Eloquent/Relations/MorphPivot.php
@@ -70,9 +70,9 @@ public function setMorphType($morphType) */ public function setMorphClass($morphClass) { - $this->morphClass = $morphClass; + $this->morphClass = $morphClass; - return $this; + return $this; }
false
Other
laravel
framework
e1426baacf0c344f2ed241f0a30d49a09cc0abe8.json
Remove helpers that depend on illuminate/html
src/Illuminate/Foundation/helpers.php
@@ -176,74 +176,6 @@ function info($message, $context = array()) } } -if ( ! function_exists('link_to')) -{ - /** - * Generate a HTML link. - * - * @param string $url - * @param string $title - * @param array $attributes - * @param bool $secure - * @return string - */ - function link_to($url, $t...
false
Other
laravel
framework
f74c73a5ec691285bf79cc59b595fd4e1f39b42b.json
Use morph class as morph type value.
src/Illuminate/Database/Eloquent/Relations/MorphPivot.php
@@ -30,7 +30,7 @@ class MorphPivot extends Pivot { */ protected function setKeysForSaveQuery(Builder $query) { - $query->where($this->morphType, $this->getAttribute($this->morphType)); + $query->where($this->morphType, $this->morphClass); return parent::setKeysForSaveQuery($query); } @@ -44,7 +44,7 @@ p...
false
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Contracts/Support/Arrayable.php
@@ -1,6 +1,6 @@ <?php namespace Illuminate\Contracts\Support; -interface ArrayableInterface { +interface Arrayable { /** * Get the instance as an array.
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Contracts/Support/Jsonable.php
@@ -1,6 +1,6 @@ <?php namespace Illuminate\Contracts\Support; -interface JsonableInterface { +interface Jsonable { /** * Convert the object to its JSON representation.
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Contracts/Support/MessageProvider.php
@@ -1,6 +1,6 @@ <?php namespace Illuminate\Contracts\Support; -interface MessageProviderInterface { +interface MessageProvider { /** * Get the messages for the instance.
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Contracts/Support/Renderable.php
@@ -1,6 +1,6 @@ <?php namespace Illuminate\Contracts\Support; -interface RenderableInterface { +interface Renderable { /** * Get the evaluated contents of the object.
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Contracts/Support/ResponsePreparer.php
@@ -1,6 +1,6 @@ <?php namespace Illuminate\Contracts\Support; -interface ResponsePreparerInterface { +interface ResponsePreparer { /** * Prepare the given value as a Response object.
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Contracts/View/View.php
@@ -1,8 +1,8 @@ <?php namespace Illuminate\Contracts\View; -use Illuminate\Contracts\Support\RenderableInterface; +use Illuminate\Contracts\Support\Renderable; -interface View extends RenderableInterface { +interface View extends Renderable { /** * Add a piece of data to the view.
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Database/Eloquent/Model.php
@@ -5,14 +5,14 @@ use Carbon\Carbon; use LogicException; use JsonSerializable; +use Illuminate\Contracts\Support\Jsonable; use Illuminate\Contracts\Events\Dispatcher; +use Illuminate\Contracts\Support\Arrayable; use Illuminate\Contracts\Routing\UrlRoutable; use Illuminate\Database\Eloquent\Relations\Pivot; use I...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Exception/Handler.php
@@ -4,7 +4,7 @@ use Exception; use ErrorException; use ReflectionFunction; -use Illuminate\Contracts\Support\ResponsePreparerInterface; +use Illuminate\Contracts\Support\ResponsePreparer; use Illuminate\Contracts\Exception\Handler as HandlerContract; use Symfony\Component\HttpKernel\Exception\HttpExceptionInterfac...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Foundation/Application.php
@@ -10,13 +10,13 @@ use Illuminate\Support\ServiceProvider; use Illuminate\Events\EventServiceProvider; use Illuminate\Routing\RoutingServiceProvider; +use Illuminate\Contracts\Support\ResponsePreparer; use Illuminate\Exception\ExceptionServiceProvider; use Illuminate\Config\FileEnvironmentVariablesLoader; use Sy...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Foundation/Console/Optimize/config.php
@@ -4,19 +4,19 @@ return array_map('realpath', array( $basePath.'/vendor/laravel/framework/src/Illuminate/Contracts/Container/Container.php', - $basePath.'/vendor/laravel/framework/src/Illuminate/Contracts/Support/RenderableInterface.php', - $basePath.'/vendor/laravel/framework/src/Illuminate/Contracts/Su...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Http/JsonResponse.php
@@ -1,6 +1,6 @@ <?php namespace Illuminate\Http; -use Illuminate\Contracts\Support\JsonableInterface; +use Illuminate\Contracts\Support\Jsonable; class JsonResponse extends \Symfony\Component\HttpFoundation\JsonResponse { @@ -45,7 +45,7 @@ public function getData($assoc = false, $depth = 512) */ public fun...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Http/RedirectResponse.php
@@ -4,7 +4,7 @@ use Illuminate\Support\ViewErrorBag; use Symfony\Component\HttpFoundation\Cookie; use Illuminate\Session\Store as SessionStore; -use Illuminate\Contracts\Support\MessageProviderInterface; +use Illuminate\Contracts\Support\MessageProvider; class RedirectResponse extends \Symfony\Component\HttpFound...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Http/Response.php
@@ -1,8 +1,8 @@ <?php namespace Illuminate\Http; use ArrayObject; -use Illuminate\Contracts\Support\JsonableInterface; -use Illuminate\Contracts\Support\RenderableInterface; +use Illuminate\Contracts\Support\Jsonable; +use Illuminate\Contracts\Support\Renderable; class Response extends \Symfony\Component\HttpFou...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Log/Writer.php
@@ -6,10 +6,10 @@ use Monolog\Formatter\LineFormatter; use Monolog\Handler\ErrorLogHandler; use Monolog\Handler\RotatingFileHandler; +use Illuminate\Contracts\Support\Jsonable; use Illuminate\Contracts\Events\Dispatcher; +use Illuminate\Contracts\Support\Arrayable; use Psr\Log\LoggerInterface as PsrLoggerInterface...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Pagination/Paginator.php
@@ -5,10 +5,10 @@ use ArrayIterator; use IteratorAggregate; use Illuminate\Support\Collection; -use Illuminate\Contracts\Support\JsonableInterface; -use Illuminate\Contracts\Support\ArrayableInterface; +use Illuminate\Contracts\Support\Jsonable; +use Illuminate\Contracts\Support\Arrayable; -class Paginator impleme...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Support/Collection.php
@@ -7,10 +7,10 @@ use CachingIterator; use JsonSerializable; use IteratorAggregate; -use Illuminate\Contracts\Support\JsonableInterface; -use Illuminate\Contracts\Support\ArrayableInterface; +use Illuminate\Contracts\Support\Jsonable; +use Illuminate\Contracts\Support\Arrayable; -class Collection implement...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Support/Facades/Response.php
@@ -2,9 +2,9 @@ use Illuminate\Support\Str; use Illuminate\Http\JsonResponse; +use Illuminate\Contracts\Support\Arrayable; use Illuminate\Support\Traits\MacroableTrait; use Illuminate\Http\Response as IlluminateResponse; -use Illuminate\Contracts\Support\ArrayableInterface; use Symfony\Component\HttpFoundation\S...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Support/Fluent.php
@@ -2,10 +2,10 @@ use ArrayAccess; use JsonSerializable; -use Illuminate\Contracts\Support\JsonableInterface; -use Illuminate\Contracts\Support\ArrayableInterface; +use Illuminate\Contracts\Support\Jsonable; +use Illuminate\Contracts\Support\Arrayable; -class Fluent implements ArrayAccess, ArrayableInterface, Jso...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Support/MessageBag.php
@@ -2,11 +2,11 @@ use Countable; use JsonSerializable; -use Illuminate\Contracts\Support\JsonableInterface; -use Illuminate\Contracts\Support\ArrayableInterface; -use Illuminate\Contracts\Support\MessageProviderInterface; +use Illuminate\Contracts\Support\Jsonable; +use Illuminate\Contracts\Support\Arrayable...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/Validation/Validator.php
@@ -7,11 +7,11 @@ use Illuminate\Support\MessageBag; use Illuminate\Container\Container; use Symfony\Component\HttpFoundation\File\File; +use Illuminate\Contracts\Support\MessageProvider; use Symfony\Component\Translation\TranslatorInterface; use Symfony\Component\HttpFoundation\File\UploadedFile; -use Illuminate\...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/View/Factory.php
@@ -2,10 +2,10 @@ use Closure; use Illuminate\Container\Container; +use Illuminate\Contracts\Support\Arrayable; use Illuminate\View\Engines\EngineResolver; use Illuminate\Contracts\Events\Dispatcher; use Illuminate\Contracts\View\Factory as FactoryContract; -use Illuminate\Contracts\Support\ArrayableInterface as...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
src/Illuminate/View/View.php
@@ -3,11 +3,11 @@ use Closure; use ArrayAccess; use Illuminate\Support\MessageBag; +use Illuminate\Contracts\Support\Arrayable; use Illuminate\View\Engines\EngineInterface; +use Illuminate\Contracts\Support\Renderable; +use Illuminate\Contracts\Support\MessageProvider; use Illuminate\Contracts\View\View as ViewCon...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
tests/Exception/HandlerTest.php
@@ -7,7 +7,7 @@ class HandlerTest extends PHPUnit_Framework_TestCase { protected function setUp() { - $this->responsePreparer = m::mock('Illuminate\Contracts\Support\ResponsePreparerInterface'); + $this->responsePreparer = m::mock('Illuminate\Contracts\Support\ResponsePreparer'); $this->plainDisplayer = m::mo...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
tests/Http/HttpResponseTest.php
@@ -3,7 +3,7 @@ use Mockery as m; use Illuminate\Http\Request; use Illuminate\Http\RedirectResponse; -use Illuminate\Contracts\Support\JsonableInterface; +use Illuminate\Contracts\Support\Jsonable; class HttpResponseTest extends PHPUnit_Framework_TestCase { @@ -28,7 +28,7 @@ public function testJsonResponsesAre...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
tests/Support/SupportCollectionTest.php
@@ -48,9 +48,9 @@ public function testEmptyCollectionIsEmpty() public function testToArrayCallsToArrayOnEachItemInCollection() { - $item1 = m::mock('Illuminate\Contracts\Support\ArrayableInterface'); + $item1 = m::mock('Illuminate\Contracts\Support\Arrayable'); $item1->shouldReceive('toArray')->once()->...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
tests/Support/SupportFacadeResponseTest.php
@@ -13,7 +13,7 @@ public function tearDown() public function testArrayableSendAsJson() { - $data = m::mock('Illuminate\Contracts\Support\ArrayableInterface'); + $data = m::mock('Illuminate\Contracts\Support\Arrayable'); $data->shouldReceive('toArray')->andReturn(array('foo' => 'bar')); $response = Respo...
true
Other
laravel
framework
26982391b8ecf8f9160cec324c74ded96861f2b6.json
Rename some interfaces for consistency.
tests/View/ViewTest.php
@@ -2,7 +2,7 @@ use Mockery as m; use Illuminate\View\View; -use Illuminate\Contracts\Support\ArrayableInterface; +use Illuminate\Contracts\Support\Arrayable; class ViewTest extends PHPUnit_Framework_TestCase { @@ -91,7 +91,7 @@ public function testViewNestBindsASubView() public function testViewAcceptsArr...
true
Other
laravel
framework
e1aa4f27542adf21b4755b5f296b3639bc821fc1.json
Use proper assertions
tests/Auth/AuthDatabaseReminderRepositoryTest.php
@@ -22,7 +22,8 @@ public function testCreateInsertsNewRecordIntoTable() $results = $repo->create($user); - $this->assertTrue(is_string($results) and strlen($results) > 1); + $this->assertInternalType('string', $results); + $this->assertGreaterThan(1, strlen($results)); }
true
Other
laravel
framework
e1aa4f27542adf21b4755b5f296b3639bc821fc1.json
Use proper assertions
tests/Encryption/EncrypterTest.php
@@ -7,19 +7,19 @@ class EncrypterTest extends PHPUnit_Framework_TestCase { public function testEncryption() { $e = $this->getEncrypter(); - $this->assertFalse('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' == $e->encrypt('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa')); + $this->assertNotEquals('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa', $e-...
true
Other
laravel
framework
e1aa4f27542adf21b4755b5f296b3639bc821fc1.json
Use proper assertions
tests/Session/SessionStoreTest.php
@@ -44,14 +44,14 @@ public function testSessionMigration() $oldId = $session->getId(); $session->getHandler()->shouldReceive('destroy')->never(); $this->assertTrue($session->migrate()); - $this->assertFalse($oldId == $session->getId()); + $this->assertNotEquals($oldId, $session->getId()); $session = $...
true
Other
laravel
framework
34f63cbdd84f686aba9283ec0c95be986fb06678.json
Add fresh method to model. This method gets a fresh copy of the model using the ID from the existing instance.
src/Illuminate/Database/Eloquent/Model.php
@@ -675,6 +675,19 @@ public static function findOrFail($id, $columns = array('*')) throw (new ModelNotFoundException)->setModel(get_called_class()); } + /** + * Reload a fresh model instance from the database. + * + * @param array $with + * @return $this + */ + public function fresh(array $with = array())...
false
Other
laravel
framework
1ff457f71b840fa1516be0458020feb0a4708d58.json
Remove duplicate entry.
src/Illuminate/Foundation/changes.json
@@ -8,7 +8,6 @@ {"message": "Added new FormRequest class for simpler validation and authorization.", "backport": null}, {"message": "Contracts for most major components of the framework.", "backport": null}, {"message": "Flysystem integration now included with framework.", "backport": null}, - {"message": "De...
false
Other
laravel
framework
2b9be838df5369d2ff78fc26ade43775b311b701.json
Add missing method.
src/Illuminate/Routing/UrlGenerator.php
@@ -549,6 +549,19 @@ public function setRequest(Request $request) $this->request = $request; } + /** + * Set the route collection. + * + * @param \Illuminate\Routing\RouteCollection $routes + * @return $this + */ + public function setRoutes(RouteCollection $routes) + { + $this->routes = $route...
false
Other
laravel
framework
ea3b8a3f535443b37f9bf29f2e15ab09f2a2460f.json
Fix bug in route caching and route names.
src/Illuminate/Routing/RouteServiceProvider.php
@@ -16,7 +16,10 @@ public function boot() if ($this->app->routesAreCached()) { - require $this->app->getRouteCachePath(); + $this->app->booted(function() + { + require $this->app->getRouteCachePath(); + }); } else {
true
Other
laravel
framework
ea3b8a3f535443b37f9bf29f2e15ab09f2a2460f.json
Fix bug in route caching and route names.
src/Illuminate/Routing/Router.php
@@ -1700,6 +1700,8 @@ public function setRoutes(RouteCollection $routes) } $this->routes = $routes; + + $this->container->instance('routes', $this->routes); } /**
true
Other
laravel
framework
ea3b8a3f535443b37f9bf29f2e15ab09f2a2460f.json
Fix bug in route caching and route names.
src/Illuminate/Routing/RoutingServiceProvider.php
@@ -55,10 +55,22 @@ protected function registerUrlGenerator() // and all the registered routes will be available to the generator. $routes = $app['router']->getRoutes(); - return new UrlGenerator($routes, $app->rebinding('request', function($app, $request) + $app->instance('routes', $routes); + + ...
true
Other
laravel
framework
01b54fbb86224b21786e6caa65bcbce3450aa81f.json
Update changes file.
src/Illuminate/Foundation/changes.json
@@ -31,7 +31,8 @@ {"message": "Allow 'where' route constraints to be passed in array definition of Route.", "backport": null}, {"message": "Properly support Route 'where' constraints on a Route group.", "backport": null}, {"message": "When 'increment' or 'decrement' is called on a single Model instance, the lo...
false
Other
laravel
framework
7602d93ce35e8f0baf9915ebc8be4d885ee0259e.json
Flush the application after each test.
src/Illuminate/Container/Container.php
@@ -872,6 +872,19 @@ public function forgetInstances() $this->instances = array(); } + /** + * Flush the container of all bindings and resolved instances. + * + * @return void + */ + public function flush() + { + $this->aliases = []; + $this->resolved = []; + $this->bindings = []; + $this->instances = []...
true
Other
laravel
framework
7602d93ce35e8f0baf9915ebc8be4d885ee0259e.json
Flush the application after each test.
src/Illuminate/Foundation/Application.php
@@ -1202,6 +1202,18 @@ public function registerCoreContainerAliases() } } + /** + * Flush the container of all bindings and resolved instances. + * + * @return void + */ + public function flush() + { + parent::flush(); + + $this->loadedProviders = []; + } + /** * Dynamically access application service...
true
Other
laravel
framework
7602d93ce35e8f0baf9915ebc8be4d885ee0259e.json
Flush the application after each test.
src/Illuminate/Foundation/Testing/TestCase.php
@@ -4,6 +4,15 @@ abstract class TestCase extends \PHPUnit_Framework_TestCase { use ApplicationTrait, AssertionsTrait; + /** + * Creates the application. + * + * Needs to be implemented by subclasses. + * + * @return \Symfony\Component\HttpKernel\HttpKernelInterface + */ + abstract public function createAppl...
true
Other
laravel
framework
adcdb9abf287b7fdc418ef2b73daff367f654c11.json
Fix double semicolon.
src/Illuminate/Foundation/Providers/PublisherServiceProvider.php
@@ -125,7 +125,7 @@ protected function registerViewPublisher() $this->app->bindShared('view.publisher', function($app) { - $viewPath = $app['path.base'].'/resources/views';; + $viewPath = $app['path.base'].'/resources/views'; // Once we have created the view publisher, we will set the default packages...
false
Other
laravel
framework
855bb1b07e1d0cd8e88115849baf4c5c02136a95.json
Fix path that doesn't exist.
src/Illuminate/Foundation/Providers/PublisherServiceProvider.php
@@ -125,7 +125,7 @@ protected function registerViewPublisher() $this->app->bindShared('view.publisher', function($app) { - $viewPath = $app['path.views']; + $viewPath = $app['path'].'/resources/views';; // Once we have created the view publisher, we will set the default packages // path on this ob...
false
Other
laravel
framework
7f29d869e3eda2046fc49f22d95c28bad041993d.json
Add messages() method stub Add messages() method that returns empty array, when missing a reflection exception is thrown Method App\Http\Requests\RegistrationRequest::messages() does not exist
src/Illuminate/Foundation/Http/FormRequest.php
@@ -224,5 +224,15 @@ public function __get($key) { return $this->input($key); } + + /** + * Set custom messages for validator errors. + * + * @return array + */ + public function messages() + { + return []; + } }
false
Other
laravel
framework
26a13b52396860c695f05d826b044dea3b8d109c.json
Return queue calls.
src/Illuminate/Mail/Mailer.php
@@ -158,13 +158,13 @@ public function send($view, array $data, $callback) * @param array $data * @param \Closure|string $callback * @param string $queue - * @return void + * @return mixed */ public function queue($view, array $data, $callback, $queue = null) { $callback = $this->buildQueueCa...
false
Other
laravel
framework
252d3a534e2f318a6d4d3d70738a4ae300ade88b.json
Update the read me and contribution guide.
CONTRIBUTING.md
@@ -1,28 +1,3 @@ # Laravel Contribution Guide -This page contains guidelines for contributing to the Laravel framework. Please review these guidelines before submitting any pull requests to the framework. - -## Which Branch? - -**ALL** bug fixes should be made to the 4.x branch which they belong. Bug fixes should ne...
true
Other
laravel
framework
252d3a534e2f318a6d4d3d70738a4ae300ade88b.json
Update the read me and contribution guide.
readme.md
@@ -10,19 +10,17 @@ ## Laravel PHP Framework -Laravel is a web application framework with expressive, elegant syntax. We believe development must be an enjoyable, creative experience to be truly fulfilling. Laravel attempts to take the pain out of development by easing common tasks used in the majority of web proj...
true
Other
laravel
framework
86e0a082eb43beb93d8677742c3b3b4fe42bc338.json
Allow Custom Messages Custom Messages for FormRequest Validation
src/Illuminate/Foundation/Http/FormRequest.php
@@ -63,7 +63,7 @@ class FormRequest extends Request { public function validate(ValidationFactory $factory) { $instance = $factory->make( - $this->input(), $this->container->call([$this, 'rules']) + $this->input(), $this->container->call([$this, 'rules']), $this->container->call([$this, 'messages']) ); ...
false
Other
laravel
framework
b257d849d0010c9c6571a4b7c62be948470c95d8.json
Add method to contract.
src/Illuminate/Contracts/Events/Dispatcher.php
@@ -39,6 +39,13 @@ public function until($event, $payload = array()); */ public function fire($event, $payload = array(), $halt = false); + /** + * Get the event that is currently firing. + * + * @return string + */ + public function firing(); + /** * Remove a set of listeners from the dispatcher. *
false
Other
laravel
framework
41e76aed563c83a633c1187b1768e2181c213a28.json
Add missing space
src/Illuminate/Support/SerializableClosure.php
@@ -50,7 +50,7 @@ public function getVariables() */ protected function determineCodeAndVariables() { - if (!$this->code) + if ( ! $this->code) { list($this->code, $this->variables) = unserialize($this->serialize()); }
false
Other
laravel
framework
30001aa8f5ac79dfdb27270f8bc82e8c37d7e0b1.json
Move transport registration to separate class By moving this functionality outside of the service provider and into a class that extends the Manager class, we offer an easier way to user to register their own mail drivers.
src/Illuminate/Mail/MailServiceProvider.php
@@ -2,12 +2,6 @@ use Swift_Mailer; use Illuminate\Support\ServiceProvider; -use Swift_SmtpTransport as SmtpTransport; -use Swift_MailTransport as MailTransport; -use Illuminate\Mail\Transport\LogTransport; -use Illuminate\Mail\Transport\MailgunTransport; -use Illuminate\Mail\Transport\MandrillTransport; -us...
true
Other
laravel
framework
30001aa8f5ac79dfdb27270f8bc82e8c37d7e0b1.json
Move transport registration to separate class By moving this functionality outside of the service provider and into a class that extends the Manager class, we offer an easier way to user to register their own mail drivers.
src/Illuminate/Mail/TransportManager.php
@@ -0,0 +1,122 @@ +<?php namespace Illuminate\Mail; + +use Illuminate\Support\Manager; +use Swift_SmtpTransport as SmtpTransport; +use Swift_MailTransport as MailTransport; +use Illuminate\Mail\Transport\LogTransport; +use Illuminate\Mail\Transport\MailgunTransport; +use Illuminate\Mail\Transport\MandrillTransport; +us...
true
Other
laravel
framework
48e5698fe4c4a669f609c2b9ba22886a33c0fd89.json
Remove unused import statement
src/Illuminate/Mail/Mailer.php
@@ -3,7 +3,6 @@ use Closure; use Swift_Mailer; use Swift_Message; -use Illuminate\Log\Writer; use Psr\Log\LoggerInterface; use Illuminate\Container\Container; use Illuminate\Contracts\View\Factory;
false
Other
laravel
framework
9a2ebbbc2ccf6b2f91db2cea0271d58c38642fd4.json
Change a doc block.
src/Illuminate/Support/ServiceProvider.php
@@ -7,7 +7,7 @@ abstract class ServiceProvider { /** * The application instance. * - * @var \Illuminate\Foundation\Application + * @var \Illuminate\Contracts\Foundation\Application */ protected $app; @@ -21,7 +21,7 @@ abstract class ServiceProvider { /** * Create a new service provider instance. ...
false
Other
laravel
framework
50578255e967c24c34fc02d49f07fa8012ccdf0a.json
Extend the container interface from app.
src/Illuminate/Contracts/Foundation/Application.php
@@ -1,6 +1,8 @@ <?php namespace Illuminate\Contracts\Foundation; -interface Application { +use Illuminate\Contracts\Container\Container; + +interface Application extends Container { /** * Register a service provider with the application.
false
Other
laravel
framework
c79c1ed4ff05f30e6e882473c8dc11f99422a4a4.json
Add a basic application contract.
src/Illuminate/Contracts/Foundation/Application.php
@@ -0,0 +1,47 @@ +<?php namespace Illuminate\Contracts\Foundation; + +interface Application { + + /** + * Register a service provider with the application. + * + * @param \Illuminate\Support\ServiceProvider|string $provider + * @param array $options + * @param bool $force + * @return \Illuminate\Support\Se...
true
Other
laravel
framework
c79c1ed4ff05f30e6e882473c8dc11f99422a4a4.json
Add a basic application contract.
src/Illuminate/Foundation/Application.php
@@ -20,8 +20,12 @@ use Symfony\Component\HttpFoundation\Request as SymfonyRequest; use Symfony\Component\HttpFoundation\Response as SymfonyResponse; use Symfony\Component\HttpKernel\Exception\NotFoundHttpException; +use Illuminate\Contracts\Foundation\Application as ApplicationContract; -class Application extends ...
true
Other
laravel
framework
4d6737d59ad4d5dd532a77c46749c34b624b8e50.json
Remove useless $app argument
src/Illuminate/Auth/GeneratorServiceProvider.php
@@ -72,7 +72,7 @@ protected function registerAuthControllerCommand() */ protected function registerAuthMakeCommand() { - $this->app->bindShared('command.auth.make', function($app) + $this->app->bindShared('command.auth.make', function() { return new AuthMakeCommand; }); @@ -85,7 +85,7 @@ protected fu...
true
Other
laravel
framework
4d6737d59ad4d5dd532a77c46749c34b624b8e50.json
Remove useless $app argument
src/Illuminate/Database/MigrationServiceProvider.php
@@ -145,7 +145,7 @@ protected function registerResetCommand() */ protected function registerRefreshCommand() { - $this->app->bindShared('command.migrate.refresh', function($app) + $this->app->bindShared('command.migrate.refresh', function() { return new RefreshCommand; });
true
Other
laravel
framework
4d6737d59ad4d5dd532a77c46749c34b624b8e50.json
Remove useless $app argument
src/Illuminate/Database/SeedServiceProvider.php
@@ -21,7 +21,7 @@ public function register() { $this->registerSeedCommand(); - $this->app->bindShared('seeder', function($app) + $this->app->bindShared('seeder', function() { return new Seeder; });
true
Other
laravel
framework
4d6737d59ad4d5dd532a77c46749c34b624b8e50.json
Remove useless $app argument
src/Illuminate/Foundation/Providers/ArtisanServiceProvider.php
@@ -155,7 +155,7 @@ protected function registerDownCommand() */ protected function registerEnvironmentCommand() { - $this->app->bindShared('command.environment', function($app) + $this->app->bindShared('command.environment', function() { return new EnvironmentCommand; });
true
Other
laravel
framework
4d6737d59ad4d5dd532a77c46749c34b624b8e50.json
Remove useless $app argument
src/Illuminate/Foundation/Providers/PublisherServiceProvider.php
@@ -173,7 +173,7 @@ protected function registerMigrationPublisher() */ protected function registerMigratePublishCommand() { - $this->app->bindShared('command.migrate.publish', function($app) + $this->app->bindShared('command.migrate.publish', function() { return new MigratePublishCommand; });
true
Other
laravel
framework
4d6737d59ad4d5dd532a77c46749c34b624b8e50.json
Remove useless $app argument
src/Illuminate/Mail/MailServiceProvider.php
@@ -146,7 +146,7 @@ protected function registerSwiftTransport($config) */ protected function registerSmtpTransport($config) { - $this->app['swift.transport'] = $this->app->share(function($app) use ($config) + $this->app['swift.transport'] = $this->app->share(function() use ($config) { extract($con...
true
Other
laravel
framework
4d6737d59ad4d5dd532a77c46749c34b624b8e50.json
Remove useless $app argument
src/Illuminate/Queue/FailConsoleServiceProvider.php
@@ -23,22 +23,22 @@ class FailConsoleServiceProvider extends ServiceProvider { */ public function register() { - $this->app->bindShared('command.queue.failed', function($app) + $this->app->bindShared('command.queue.failed', function() { return new ListFailedCommand; }); - $this->app->bindShared('c...
true
Other
laravel
framework
4d6737d59ad4d5dd532a77c46749c34b624b8e50.json
Remove useless $app argument
src/Illuminate/Queue/QueueServiceProvider.php
@@ -136,7 +136,7 @@ protected function registerListenCommand() */ public function registerRestartCommand() { - $this->app->bindShared('command.queue.restart', function($app) + $this->app->bindShared('command.queue.restart', function() { return new RestartCommand; }); @@ -151,7 +151,7 @@ publi...
true
Other
laravel
framework
4d6737d59ad4d5dd532a77c46749c34b624b8e50.json
Remove useless $app argument
src/Illuminate/View/ViewServiceProvider.php
@@ -35,7 +35,7 @@ public function register() */ public function registerEngineResolver() { - $this->app->bindShared('view.engine.resolver', function($app) + $this->app->bindShared('view.engine.resolver', function() { $resolver = new EngineResolver;
true
Other
laravel
framework
c4a5b3b0967820eacdcc1d351d48f1e1afa07ec9.json
Fix migration path.
src/Illuminate/Database/Console/Migrations/BaseCommand.php
@@ -43,7 +43,7 @@ protected function getMigrationPath() return $this->laravel['path.base'].$path; } - return $this->laravel['path'].'/database/migrations'; + return $this->laravel['path.database'].'/migrations'; } }
true
Other
laravel
framework
c4a5b3b0967820eacdcc1d351d48f1e1afa07ec9.json
Fix migration path.
tests/Database/DatabaseMigrationMigrateCommandTest.php
@@ -14,10 +14,10 @@ public function tearDown() public function testBasicMigrationsCallMigratorWithProperArguments() { $command = new MigrateCommand($migrator = m::mock('Illuminate\Database\Migrations\Migrator'), __DIR__.'/vendor'); - $app = new ApplicationDatabaseMigrationStub(array('path' => __DIR__)); + $app...
true
Other
laravel
framework
ebcdae3af3afb5d39e9fe57764a97da275e8cda6.json
Remove social interfaces.
src/Illuminate/Contracts/Auth/Social/Factory.php
@@ -1,13 +0,0 @@ -<?php namespace Illuminate\Contracts\Auth\Social; - -interface Factory { - - /** - * Get an OAuth provider implementation. - * - * @param string $driver - * @return \Illuminate\Contracts\Auth\Social\Provider - */ - public function driver($driver = null); - -}
true
Other
laravel
framework
ebcdae3af3afb5d39e9fe57764a97da275e8cda6.json
Remove social interfaces.
src/Illuminate/Contracts/Auth/Social/Provider.php
@@ -1,19 +0,0 @@ -<?php namespace Illuminate\Contracts\Auth\Social; - -interface Provider { - - /** - * Redirect the user to the authentication page for the provider. - * - * @return \Symfony\Component\HttpFoundation\RedirectResponse - */ - public function redirect(); - - /** - * Get the User instance for the auth...
true
Other
laravel
framework
ebcdae3af3afb5d39e9fe57764a97da275e8cda6.json
Remove social interfaces.
src/Illuminate/Contracts/Auth/Social/User.php
@@ -1,40 +0,0 @@ -<?php namespace Illuminate\Contracts\Auth\Social; - -interface User { - - /** - * Get the unique identifier for the user. - * - * @return string - */ - public function getId(); - - /** - * Get the nickname / username for the user. - * - * @return string - */ - public function getNickname(); - ...
true
Other
laravel
framework
e9cf10be548d6e233416a634e79478859e23168b.json
Fix doc block.
src/Illuminate/Contracts/Filesystem/Factory.php
@@ -3,7 +3,7 @@ interface Factory { /** - * Get an OAuth provider implementation. + * Get a filesystem implementation. * * @param string $name * @return \Illuminate\Contracts\Filesystem\Filesystem
false
Other
laravel
framework
8056d41b148dfca2d2f73a5c325e8fc91ecff3c5.json
Run provider boot method through Container call.
src/Illuminate/Foundation/Application.php
@@ -7,6 +7,7 @@ use Illuminate\Container\Container; use Illuminate\Filesystem\Filesystem; use Illuminate\Support\Facades\Facade; +use Illuminate\Support\ServiceProvider; use Illuminate\Events\EventServiceProvider; use Illuminate\Routing\RoutingServiceProvider; use Illuminate\Exception\ExceptionServiceProvider; @@...
false
Other
laravel
framework
3082830437b427386870c3c52a74886646de7b26.json
Add logger contract.
src/Illuminate/Contracts/Logging/Logger.php
@@ -0,0 +1,96 @@ +<?php namespace Illuminate\Contracts\Logging; + +interface Logger { + + /** + * Log an alert message to the logs. + * + * @param string $message + * @param array $context + * @return void + */ + public function alert($message, array $context = array()); + + /** + * Log a critical message to...
true
Other
laravel
framework
3082830437b427386870c3c52a74886646de7b26.json
Add logger contract.
src/Illuminate/Log/Writer.php
@@ -9,8 +9,9 @@ use Illuminate\Contracts\Events\Dispatcher; use Illuminate\Contracts\Support\JsonableInterface; use Illuminate\Contracts\Support\ArrayableInterface; +use Illuminate\Contracts\Logging\Logger as LoggerContract; -class Writer { +class Writer implements LoggerContract { /** * The Monolog logger ...
true
Other
laravel
framework
3082830437b427386870c3c52a74886646de7b26.json
Add logger contract.
tests/Log/LogWriterTest.php
@@ -35,19 +35,19 @@ public function testErrorLogHandlerCanBeAdded() } - public function testMagicMethodsPassErrorAdditionsToMonolog() + public function testMethodsPassErrorAdditionsToMonolog() { $writer = new Writer($monolog = m::mock('Monolog\Logger')); - $monolog->shouldReceive('addError')->once()->with('...
true
Other
laravel
framework
6b0985dab4f39dc243e1894d1049ab1e4951409d.json
Stop queue:work --daemon processing when app down. Contrary to the documentation, the 'queue:work --daemon' command happily continues on processing events after the 'down' command has been called, which could lead to queue events being processed while database and code migrations make the application unstable. This f...
src/Illuminate/Queue/QueueManager.php
@@ -196,6 +196,16 @@ public function getName($connection = null) return $connection ?: $this->getDefaultDriver(); } + /** + * Determine if the worker should run in maintenance mode. + * + * @return bool + */ + public function isDownForMaintenance() + { + return $this->app->isDownForMaintenance(); + }...
true
Other
laravel
framework
6b0985dab4f39dc243e1894d1049ab1e4951409d.json
Stop queue:work --daemon processing when app down. Contrary to the documentation, the 'queue:work --daemon' command happily continues on processing events after the 'down' command has been called, which could lead to queue events being processed while database and code migrations make the application unstable. This f...
src/Illuminate/Queue/Worker.php
@@ -123,6 +123,11 @@ protected function runNextJobForDaemon($connectionName, $queue, $delay, $sleep, */ protected function daemonShouldRun() { + if ($this->manager->isDownForMaintenance()) + { + return false; + } + return $this->events->until('illuminate.queue.looping') !== false; }
true
Other
laravel
framework
2608084a12f0596f70cf5a91514345e0a661d168.json
Add ability to set beanstalkd port
src/Illuminate/Queue/Connectors/BeanstalkdConnector.php
@@ -13,7 +13,7 @@ class BeanstalkdConnector implements ConnectorInterface { */ public function connect(array $config) { - $pheanstalk = new Pheanstalk($config['host']); + $pheanstalk = new Pheanstalk($config['host'], array_get($config, 'port', Pheanstalk::DEFAULT_PORT)); return new BeanstalkdQueue( ...
false
Other
laravel
framework
c206fa0a7fe6be8087de5b042a8ad8d81885bb2b.json
Fix queue connection binding.
src/Illuminate/Foundation/Application.php
@@ -1158,7 +1158,7 @@ public function registerCoreContainerAliases() 'paginator' => 'Illuminate\Pagination\Factory', 'auth.reminder' => ['Illuminate\Auth\Reminders\PasswordBroker', 'Illuminate\Contracts\Auth\PasswordBroker'], 'queue' => 'Illuminate\Queue\QueueManager', - 'queue.store' =>...
true
Other
laravel
framework
c206fa0a7fe6be8087de5b042a8ad8d81885bb2b.json
Fix queue connection binding.
src/Illuminate/Queue/QueueServiceProvider.php
@@ -61,7 +61,7 @@ protected function registerManager() return $manager; }); - $this->app->bindShared('queue.driver', function($app) + $this->app->bindShared('queue.connection', function($app) { return $app['queue']->connection(); });
true
Other
laravel
framework
85e114a3a7173232078571e2a54c8c56f2e8ff5c.json
Fix connection binding.
src/Illuminate/Queue/QueueServiceProvider.php
@@ -63,7 +63,7 @@ protected function registerManager() $this->app->bindShared('queue.driver', function($app) { - return $app['queue']->driver(); + return $app['queue']->connection(); }); }
false
Other
laravel
framework
babce912cb57699094f35c42cb133dffedb95675.json
Remove useless $app argument
src/Illuminate/Foundation/Providers/ArtisanServiceProvider.php
@@ -103,7 +103,7 @@ protected function registerAppNameCommand() */ protected function registerChangesCommand() { - $this->app->bindShared('command.changes', function($app) + $this->app->bindShared('command.changes', function() { return new ChangesCommand; }); @@ -142,7 +142,7 @@ protected function re...
false
Other
laravel
framework
b546fbe937ad997fa9071e51c3522687a6cbeaf9.json
Fix auth docblocks
src/Illuminate/Auth/EloquentUserProvider.php
@@ -36,7 +36,7 @@ public function __construct(HasherContract $hasher, $model) * Retrieve a user by their unique identifier. * * @param mixed $identifier - * @return \Illuinate\Contracts\Auth\User|null + * @return \Illuminate\Contracts\Auth\User|null */ public function retrieveById($identifier) { @@ ...
false
Other
laravel
framework
c03924a76733f9c120f5bab566f52007d4b1de0c.json
Use key instead of password.
src/Illuminate/Filesystem/FilesystemManager.php
@@ -111,7 +111,7 @@ public function createS3Driver(array $config) public function createRackspaceDriver(array $config) { $client = new Rackspace($config['endpoint'], [ - 'username' => $config['username'], 'apiKey' => $config['password'], + 'username' => $config['username'], 'apiKey' => $config['key'], ]);...
false
Other
laravel
framework
cc687c786fe1552b200b6bcd81c5367cc0379b86.json
fix docblocks in filesystem
src/Illuminate/Filesystem/FilesystemDecorator.php
@@ -44,7 +44,7 @@ public function exists($path) * @param string $path * @return string * - * @throws FileNotFoundException + * @throws \Illuminate\Contracts\Filesystem\FileNotFoundException */ public function get($path) { @@ -232,6 +232,7 @@ public function directories($directory = null, $recursive ...
false
Other
laravel
framework
d759af406d5743644029217465b3d0fdf3e8c895.json
Update the Travis file of the workbench
src/Illuminate/Workbench/stubs/.travis.yml
@@ -1,14 +1,13 @@ language: php php: - - 5.3 - 5.4 - 5.5 - 5.6 - hhvm before_script: - - composer self-update - - composer install --prefer-source --no-interaction --dev + - travis_retry composer self-update + - travis_retry composer install --prefer-source --no-interaction --dev script: phpu...
false
Other
laravel
framework
3effef38463980fcb762cda0fc76dbc8119a0f30.json
Add contracts dependency.
src/Illuminate/Filesystem/composer.json
@@ -9,6 +9,7 @@ ], "require": { "php": ">=5.4.0", + "illuminate/contracts": "4.3.*", "illuminate/support": "4.3.*", "symfony/finder": "2.6.*" },
false
Other
laravel
framework
257606f53a6ba5468415a0375f08440c3a4f8b69.json
Fix app:name not hitting User class.
src/Illuminate/Foundation/Console/AppNameCommand.php
@@ -95,6 +95,10 @@ protected function setAppDirectoryNamespace() */ protected function replaceNamespace($path) { + $this->replaceIn( + $path, 'namespace '.$this->root().';', 'namespace '.$this->argument('name').';' + ); + $this->replaceIn( $path, 'namespace '.$this->root().'\\', 'namespace '.$this->ar...
false
Other
laravel
framework
2618b79a6a94ba430710fd3083b389f05d6ac8dd.json
Inject the queue driver.
src/Illuminate/Mail/MailServiceProvider.php
@@ -79,7 +79,7 @@ protected function setMailerDependencies($mailer, $app) if ($app->bound('queue')) { - $mailer->setQueue($app['queue']); + $mailer->setQueue($app['queue.driver']); } }
false
Other
laravel
framework
046cb9d8324752c73df5587da84376ec30abe312.json
Remove unecessary use
src/Illuminate/Auth/Console/AuthControllerCommand.php
@@ -1,6 +1,5 @@ <?php namespace Illuminate\Auth\Console; -use Illuminate\Filesystem\Filesystem; use Illuminate\Console\GeneratorCommand; use Symfony\Component\Console\Input\InputArgument;
true