language stringclasses 1 value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2 classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | ca443d01d22409da0c1001557e0852017654045e.json | Update Glimmer to 0.11.0.
* Threads `SymbolTable` throughout the system instead of `blockMeta`.
* Change a few argument signatures for Glimmer syntax's (moving from
options hash to positional, etc). | packages/ember-glimmer/lib/syntax/dynamic-component.js | @@ -12,59 +12,59 @@ function dynamicComponentFor(vm) {
let env = vm.env;
let args = vm.getArgs();
let nameRef = args.positional.at(0);
- let { blockMeta } = this;
+ let { symbolTable } = this;
- return new DynamicComponentReference({ nameRef, env, blockMeta });
+ return new DynamicComponentReference({ nameRef, env, symbolTable });
}
export class DynamicComponentSyntax extends StatementSyntax {
// for {{component componentName}}
- static create({ args, templates, blockMeta }) {
+ static create({ args, templates, symbolTable }) {
let definitionArgs = ArgsSyntax.fromPositionalArgs(args.positional.slice(0, 1));
let invocationArgs = ArgsSyntax.build(args.positional.slice(1), args.named);
- return new this({ definitionArgs, args: invocationArgs, templates, blockMeta });
+ return new this({ definitionArgs, args: invocationArgs, templates, symbolTable });
}
// Transforms {{foo.bar with=args}} or {{#foo.bar with=args}}{{/foo.bar}}
// into {{component foo.bar with=args}} or
// {{#component foo.bar with=args}}{{/component}}
// with all of it's arguments
- static fromPath({ path, args, templates, blockMeta }) {
+ static fromPath({ path, args, templates, symbolTable }) {
let positional = ArgsSyntax.fromPositionalArgs(PositionalArgsSyntax.build([GetSyntax.build(path.join('.'))]));
- return new this({ definitionArgs: positional, args, templates, blockMeta });
+ return new this({ definitionArgs: positional, args, templates, symbolTable });
}
- constructor({ definitionArgs, args, templates, blockMeta }) {
+ constructor({ definitionArgs, args, templates, symbolTable }) {
super();
this.definition = dynamicComponentFor.bind(this);
this.definitionArgs = definitionArgs;
this.args = args;
this.templates = templates;
+ this.symbolTable = symbolTable;
this.shadow = null;
- this.blockMeta = blockMeta;
}
compile(builder) {
- builder.component.dynamic(this);
+ builder.component.dynamic(this.definitionArgs, this.definition, this.args, this.templates, this.symbolTable, this.shadow);
}
}
class DynamicComponentReference {
- constructor({ nameRef, env, blockMeta, args }) {
+ constructor({ nameRef, env, symbolTable, args }) {
this.tag = nameRef.tag;
this.nameRef = nameRef;
this.env = env;
- this.blockMeta = blockMeta;
+ this.symbolTable = symbolTable;
this.args = args;
}
value() {
- let { env, nameRef, blockMeta } = this;
+ let { env, nameRef, symbolTable } = this;
let nameOrDef = nameRef.value();
if (typeof nameOrDef === 'string') {
- let definition = env.getComponentDefinition([nameOrDef], blockMeta);
+ let definition = env.getComponentDefinition([nameOrDef], symbolTable);
assert(`Could not find component named "${nameOrDef}" (no component or template with that name was found)`, definition);
| true |
Other | emberjs | ember.js | ca443d01d22409da0c1001557e0852017654045e.json | Update Glimmer to 0.11.0.
* Threads `SymbolTable` throughout the system instead of `blockMeta`.
* Change a few argument signatures for Glimmer syntax's (moving from
options hash to positional, etc). | packages/ember-glimmer/lib/syntax/outlet.js | @@ -16,17 +16,18 @@ function outletComponentFor(vm) {
}
export class OutletSyntax extends StatementSyntax {
- constructor({ args }) {
+ constructor({ args, symbolTable }) {
super();
this.definitionArgs = args;
this.definition = outletComponentFor;
this.args = ArgsSyntax.empty();
+ this.symbolTable = symbolTable;
this.templates = null;
this.shadow = null;
}
compile(builder) {
- builder.component.dynamic(this);
+ builder.component.dynamic(this.definitionArgs, this.definition, this.args, this.templates, this.symbolTable, this.shadow);
}
}
| true |
Other | emberjs | ember.js | ca443d01d22409da0c1001557e0852017654045e.json | Update Glimmer to 0.11.0.
* Threads `SymbolTable` throughout the system instead of `blockMeta`.
* Change a few argument signatures for Glimmer syntax's (moving from
options hash to positional, etc). | packages/ember-glimmer/lib/syntax/render.js | @@ -41,17 +41,18 @@ function makeComponentDefinition(vm) {
}
export class RenderSyntax extends StatementSyntax {
- constructor({ args }) {
+ constructor({ args, symbolTable }) {
super();
this.definitionArgs = args;
this.definition = makeComponentDefinition;
this.args = ArgsSyntax.fromPositionalArgs(args.positional.slice(1, 2));
this.templates = null;
+ this.symbolTable = symbolTable;
this.shadow = null;
}
compile(builder) {
- builder.component.dynamic(this);
+ builder.component.dynamic(this.definitionArgs, this.definition, this.args, this.templates, this.symbolTable, this.shadow);
}
}
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-glimmer/lib/index.js | @@ -1,2 +1,2 @@
-export { default as Environment } from 'ember-glimmer/environment';
+export { default as Environment } from './environment';
export { default as template } from './template'; | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-glimmer/lib/setup-registry.js | @@ -1,15 +1,15 @@
import { privatize as P } from 'container/registry';
-import { InteractiveRenderer, InertRenderer } from 'ember-glimmer/renderer';
-import { DOMChanges, DOMTreeConstruction } from 'ember-glimmer/dom';
-import OutletView from 'ember-glimmer/views/outlet';
-import TextField from 'ember-glimmer/components/text_field';
-import TextArea from 'ember-glimmer/components/text_area';
-import Checkbox from 'ember-glimmer/components/checkbox';
-import LinkToComponent from 'ember-glimmer/components/link-to';
-import ComponentTemplate from 'ember-glimmer/templates/component';
-import RootTemplate from 'ember-glimmer/templates/root';
-import OutletTemplate from 'ember-glimmer/templates/outlet';
-import Environment from 'ember-glimmer/environment';
+import { InteractiveRenderer, InertRenderer } from './renderer';
+import { DOMChanges, DOMTreeConstruction } from './dom';
+import OutletView from './views/outlet';
+import TextField from './components/text_field';
+import TextArea from './components/text_area';
+import Checkbox from './components/checkbox';
+import LinkToComponent from './components/link-to';
+import ComponentTemplate from './templates/component';
+import RootTemplate from './templates/root';
+import OutletTemplate from './templates/outlet';
+import Environment from './environment';
export function setupApplicationRegistry(registry) {
registry.injection('service:-glimmer-environment', 'appendOperations', 'service:-dom-tree-construction'); | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/alias.js | @@ -1,18 +1,18 @@
-import { assert } from 'ember-metal/debug';
-import { get } from 'ember-metal/property_get';
-import { set } from 'ember-metal/property_set';
-import EmberError from 'ember-metal/error';
+import { assert } from './debug';
+import { get } from './property_get';
+import { set } from './property_set';
+import EmberError from './error';
import {
Descriptor,
defineProperty
-} from 'ember-metal/properties';
-import { ComputedProperty } from 'ember-metal/computed';
-import { inspect } from 'ember-metal/utils';
-import { meta } from 'ember-metal/meta';
+} from './properties';
+import { ComputedProperty } from './computed';
+import { inspect } from './utils';
+import { meta } from './meta';
import {
addDependentKeys,
removeDependentKeys
-} from 'ember-metal/dependent_keys';
+} from './dependent_keys';
export default function alias(altKey) {
return new AliasedProperty(altKey); | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/binding.js | @@ -1,21 +1,21 @@
import Logger from 'ember-console';
import { context, ENV } from 'ember-environment';
-import run from 'ember-metal/run_loop';
-import { assert, deprecate } from 'ember-metal/debug';
-import { get } from 'ember-metal/property_get';
-import { trySet } from 'ember-metal/property_set';
-import { guidFor } from 'ember-metal/utils';
-import { addListener } from 'ember-metal/events';
+import run from './run_loop';
+import { assert, deprecate } from './debug';
+import { get } from './property_get';
+import { trySet } from './property_set';
+import { guidFor } from './utils';
+import { addListener } from './events';
import {
addObserver,
removeObserver,
_suspendObserver
-} from 'ember-metal/observer';
+} from './observer';
import {
isGlobalPath,
getFirstKey,
getTailPath
-} from 'ember-metal/path_cache';
+} from './path_cache';
/**
@module ember | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/cache.js | @@ -1,4 +1,4 @@
-import EmptyObject from 'ember-metal/empty_object';
+import EmptyObject from './empty_object';
export default class Cache {
constructor(limit, func, key, store) { | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/chains.js | @@ -1,7 +1,7 @@
-import { get } from 'ember-metal/property_get';
-import { meta as metaFor, peekMeta } from 'ember-metal/meta';
-import { watchKey, unwatchKey } from 'ember-metal/watch_key';
-import EmptyObject from 'ember-metal/empty_object';
+import { get } from './property_get';
+import { meta as metaFor, peekMeta } from './meta';
+import { watchKey, unwatchKey } from './watch_key';
+import EmptyObject from './empty_object';
const FIRST_KEY = /^([^\.]+)/;
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/computed.js | @@ -1,21 +1,21 @@
-import { assert, warn } from 'ember-metal/debug';
-import { set } from 'ember-metal/property_set';
-import { inspect } from 'ember-metal/utils';
-import { meta as metaFor, peekMeta } from 'ember-metal/meta';
-import expandProperties from 'ember-metal/expand_properties';
-import EmberError from 'ember-metal/error';
+import { assert, warn } from './debug';
+import { set } from './property_set';
+import { inspect } from './utils';
+import { meta as metaFor, peekMeta } from './meta';
+import expandProperties from './expand_properties';
+import EmberError from './error';
import {
Descriptor,
defineProperty
-} from 'ember-metal/properties';
+} from './properties';
import {
propertyWillChange,
propertyDidChange
-} from 'ember-metal/property_events';
+} from './property_events';
import {
addDependentKeys,
removeDependentKeys
-} from 'ember-metal/dependent_keys';
+} from './dependent_keys';
/**
@module ember | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/dependent_keys.js | @@ -5,7 +5,7 @@
import {
watch,
unwatch
-} from 'ember-metal/watching';
+} from './watching';
/**
@module ember | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/deprecate_property.js | @@ -3,9 +3,9 @@
@submodule ember-metal
*/
-import { deprecate } from 'ember-metal/debug';
-import { get } from 'ember-metal/property_get';
-import { set } from 'ember-metal/property_set';
+import { deprecate } from './debug';
+import { get } from './property_get';
+import { set } from './property_set';
/** | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/events.js | @@ -6,12 +6,12 @@
@module ember
@submodule ember-metal
*/
-import { assert } from 'ember-metal/debug';
-import { applyStr } from 'ember-metal/utils';
-import { meta as metaFor, peekMeta } from 'ember-metal/meta';
-import { deprecate } from 'ember-metal/debug';
+import { assert } from './debug';
+import { applyStr } from './utils';
+import { meta as metaFor, peekMeta } from './meta';
+import { deprecate } from './debug';
-import { ONCE, SUSPENDED } from 'ember-metal/meta_listeners';
+import { ONCE, SUSPENDED } from './meta_listeners';
/* | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/expand_properties.js | @@ -1,4 +1,4 @@
-import { assert } from 'ember-metal/debug';
+import { assert } from './debug';
/**
@module ember | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/features.js | @@ -1,5 +1,5 @@
import { ENV } from 'ember-environment';
-import assign from 'ember-metal/assign';
+import assign from './assign';
import DEFAULT_FEATURES from 'ember/features';
/** | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/get_properties.js | @@ -1,4 +1,4 @@
-import { get } from 'ember-metal/property_get';
+import { get } from './property_get';
/**
To get multiple properties at once, call `Ember.getProperties` | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/index.js | @@ -7,17 +7,17 @@
import require, { has } from 'require';
import { ENV, context } from 'ember-environment';
import VERSION from 'ember/version';
-import Ember from 'ember-metal/core'; // reexports
-import { deprecate, deprecateFunc } from 'ember-metal/debug';
-import isEnabled, { FEATURES } from 'ember-metal/features';
-import assign from 'ember-metal/assign';
-import merge from 'ember-metal/merge';
+import Ember from './core'; // reexports
+import { deprecate, deprecateFunc } from './debug';
+import isEnabled, { FEATURES } from './features';
+import assign from './assign';
+import merge from './merge';
import {
instrument,
reset as instrumentationReset,
subscribe as instrumentationSubscribe,
unsubscribe as instrumentationUnsubscribe
-} from 'ember-metal/instrumentation';
+} from './instrumentation';
import {
GUID_KEY,
apply,
@@ -31,20 +31,20 @@ import {
tryInvoke,
uuid,
wrap
-} from 'ember-metal/utils';
+} from './utils';
import {
META_DESC,
meta
-} from 'ember-metal/meta';
-import EmberError from 'ember-metal/error';
-import Cache from 'ember-metal/cache';
+} from './meta';
+import EmberError from './error';
+import Cache from './cache';
import Logger from 'ember-console';
import {
_getPath,
get,
getWithDefault
-} from 'ember-metal/property_get';
+} from './property_get';
import {
accumulateListeners,
@@ -57,9 +57,9 @@ import {
suspendListener,
suspendListeners,
watchedEvents
-} from 'ember-metal/events';
+} from './events';
-import ObserverSet from 'ember-metal/observer_set';
+import ObserverSet from './observer_set';
import {
beginPropertyChanges,
@@ -68,53 +68,53 @@ import {
overrideChains,
propertyDidChange,
propertyWillChange
-} from 'ember-metal/property_events';
+} from './property_events';
import {
defineProperty
-} from 'ember-metal/properties';
+} from './properties';
import {
set,
trySet
-} from 'ember-metal/property_set';
+} from './property_set';
-import WeakMap from 'ember-metal/weak_map';
+import WeakMap from './weak_map';
import {
Map,
MapWithDefault,
OrderedSet
-} from 'ember-metal/map';
+} from './map';
-import getProperties from 'ember-metal/get_properties';
-import setProperties from 'ember-metal/set_properties';
+import getProperties from './get_properties';
+import setProperties from './set_properties';
import {
watchKey,
unwatchKey
-} from 'ember-metal/watch_key';
+} from './watch_key';
import {
ChainNode,
finishChains,
removeChainWatcher
-} from 'ember-metal/chains';
+} from './chains';
import {
watchPath,
unwatchPath
-} from 'ember-metal/watch_path';
+} from './watch_path';
import {
destroy,
isWatching,
rewatch,
unwatch,
watch
-} from 'ember-metal/watching';
-import expandProperties from 'ember-metal/expand_properties';
+} from './watching';
+import expandProperties from './expand_properties';
import {
ComputedProperty,
computed,
cacheFor
-} from 'ember-metal/computed';
+} from './computed';
-import alias from 'ember-metal/alias';
+import alias from './alias';
computed.alias = alias;
@@ -124,7 +124,7 @@ import {
addObserver,
observersFor,
removeObserver
-} from 'ember-metal/observer';
+} from './observer';
import {
NAME_KEY,
Mixin,
@@ -133,30 +133,30 @@ import {
mixin,
observer,
required
-} from 'ember-metal/mixin';
+} from './mixin';
import {
Binding,
bind
-} from 'ember-metal/binding';
+} from './binding';
import {
isGlobalPath
-} from 'ember-metal/path_cache';
+} from './path_cache';
import {
isTesting,
setTesting
-} from 'ember-metal/testing';
+} from './testing';
import {
getOnerror,
setOnerror
-} from 'ember-metal/error_handler';
-
-import run from 'ember-metal/run_loop';
-import libraries from 'ember-metal/libraries';
-import isNone from 'ember-metal/is_none';
-import isEmpty from 'ember-metal/is_empty';
-import isBlank from 'ember-metal/is_blank';
-import isPresent from 'ember-metal/is_present';
+} from './error_handler';
+
+import run from './run_loop';
+import libraries from './libraries';
+import isNone from './is_none';
+import isEmpty from './is_empty';
+import isBlank from './is_blank';
+import isPresent from './is_present';
import Backburner from 'backburner';
// END IMPORTS | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/injected_property.js | @@ -1,7 +1,7 @@
-import { assert } from 'ember-metal/debug';
-import { ComputedProperty } from 'ember-metal/computed';
-import { AliasedProperty } from 'ember-metal/alias';
-import { Descriptor } from 'ember-metal/properties';
+import { assert } from './debug';
+import { ComputedProperty } from './computed';
+import { AliasedProperty } from './alias';
+import { Descriptor } from './properties';
import { getOwner } from 'container/owner';
/** | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/instrumentation.js | @@ -1,5 +1,5 @@
import { ENV } from 'ember-environment';
-import isEnabled from 'ember-metal/features';
+import isEnabled from './features';
/**
The purpose of the Ember Instrumentation module is | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/is_blank.js | @@ -1,4 +1,4 @@
-import isEmpty from 'ember-metal/is_empty';
+import isEmpty from './is_empty';
/**
A value is blank if it is empty or a whitespace string. | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/is_empty.js | @@ -1,5 +1,5 @@
-import { get } from 'ember-metal/property_get';
-import isNone from 'ember-metal/is_none';
+import { get } from './property_get';
+import isNone from './is_none';
/**
Verifies that a value is `null` or an empty string, empty array, | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/is_present.js | @@ -1,4 +1,4 @@
-import isBlank from 'ember-metal/is_blank';
+import isBlank from './is_blank';
/**
A value is present if it not `isBlank`. | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/libraries.js | @@ -1,5 +1,5 @@
-import { warn } from 'ember-metal/debug';
-import isEnabled from 'ember-metal/features';
+import { warn } from './debug';
+import isEnabled from './features';
/**
Helper class that allows you to register your library with Ember. | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/map.js | @@ -20,8 +20,8 @@
Map is mocked out to look like an Ember object, so you can do
`Ember.Map.create()` for symmetry with other Ember classes.
*/
-import { guidFor } from 'ember-metal/utils';
-import EmptyObject from 'ember-metal/empty_object';
+import { guidFor } from './utils';
+import EmptyObject from './empty_object';
function missingFunction(fn) {
throw new TypeError(`${Object.prototype.toString.call(fn)} is not a function`); | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/meta.js | @@ -2,11 +2,11 @@
// Remove "use strict"; from transpiled module until
// https://bugs.webkit.org/show_bug.cgi?id=138038 is fixed
-import isEnabled from 'ember-metal/features';
-import { protoMethods as listenerMethods } from 'ember-metal/meta_listeners';
-import EmptyObject from 'ember-metal/empty_object';
-import { lookupDescriptor } from 'ember-metal/utils';
-import symbol from 'ember-metal/symbol';
+import isEnabled from './features';
+import { protoMethods as listenerMethods } from './meta_listeners';
+import EmptyObject from './empty_object';
+import { lookupDescriptor } from './utils';
+import symbol from './symbol';
/**
@module ember-metal | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/mixin.js | @@ -6,33 +6,33 @@
@module ember
@submodule ember-metal
*/
-import EmberError from 'ember-metal/error';
-import { debugSeal, assert, deprecate, runInDebug } from 'ember-metal/debug';
-import assign from 'ember-metal/assign';
+import EmberError from './error';
+import { debugSeal, assert, deprecate, runInDebug } from './debug';
+import assign from './assign';
import {
guidFor,
GUID_KEY,
wrap,
makeArray
-} from 'ember-metal/utils';
-import { meta as metaFor, peekMeta } from 'ember-metal/meta';
-import expandProperties from 'ember-metal/expand_properties';
+} from './utils';
+import { meta as metaFor, peekMeta } from './meta';
+import expandProperties from './expand_properties';
import {
Descriptor,
defineProperty
-} from 'ember-metal/properties';
-import { ComputedProperty } from 'ember-metal/computed';
-import { Binding } from 'ember-metal/binding';
+} from './properties';
+import { ComputedProperty } from './computed';
+import { Binding } from './binding';
import {
addObserver,
removeObserver,
_addBeforeObserver,
_removeBeforeObserver
-} from 'ember-metal/observer';
+} from './observer';
import {
addListener,
removeListener
-} from 'ember-metal/events';
+} from './events';
function ROOT() {}
ROOT.__hasSuper = false; | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/observer.js | @@ -1,14 +1,14 @@
import {
watch,
unwatch
-} from 'ember-metal/watching';
+} from './watching';
import {
listenersFor,
addListener,
removeListener,
suspendListeners,
suspendListener
-} from 'ember-metal/events';
+} from './events';
/**
@module ember-metal
*/ | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/observer_set.js | @@ -1,5 +1,5 @@
-import { guidFor } from 'ember-metal/utils';
-import { sendEvent } from 'ember-metal/events';
+import { guidFor } from './utils';
+import { sendEvent } from './events';
/*
this.observerSet = { | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/path_cache.js | @@ -1,4 +1,4 @@
-import Cache from 'ember-metal/cache';
+import Cache from './cache';
const IS_GLOBAL = /^[A-Z$]/;
const IS_GLOBAL_PATH = /^[A-Z$].*[\.]/; | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/properties.js | @@ -2,10 +2,10 @@
@module ember-metal
*/
-import { assert } from 'ember-metal/debug';
-import isEnabled from 'ember-metal/features';
-import { meta as metaFor, peekMeta } from 'ember-metal/meta';
-import { overrideChains } from 'ember-metal/property_events';
+import { assert } from './debug';
+import isEnabled from './features';
+import { meta as metaFor, peekMeta } from './meta';
+import { overrideChains } from './property_events';
// ..........................................................
// DESCRIPTOR
// | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/property_events.js | @@ -1,20 +1,20 @@
import {
guidFor
-} from 'ember-metal/utils';
+} from './utils';
import {
peekMeta
-} from 'ember-metal/meta';
+} from './meta';
import {
sendEvent,
accumulateListeners
-} from 'ember-metal/events';
+} from './events';
import {
markObjectAsDirty
} from './tags';
-import ObserverSet from 'ember-metal/observer_set';
-import symbol from 'ember-metal/symbol';
-import isEnabled from 'ember-metal/features';
-import { assertNotRendered } from 'ember-metal/transaction';
+import ObserverSet from './observer_set';
+import symbol from './symbol';
+import isEnabled from './features';
+import { assertNotRendered } from './transaction';
export let PROPERTY_DID_CHANGE = symbol('PROPERTY_DID_CHANGE');
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/property_get.js | @@ -2,8 +2,8 @@
@module ember-metal
*/
-import { assert } from 'ember-metal/debug';
-import { isPath, hasThis } from 'ember-metal/path_cache';
+import { assert } from './debug';
+import { isPath, hasThis } from './path_cache';
const ALLOWABLE_TYPES = {
object: true, | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/property_set.js | @@ -1,23 +1,23 @@
-import { assert } from 'ember-metal/debug';
-import isEnabled from 'ember-metal/features';
-import { _getPath as getPath } from 'ember-metal/property_get';
+import { assert } from './debug';
+import isEnabled from './features';
+import { _getPath as getPath } from './property_get';
import {
propertyWillChange,
propertyDidChange
-} from 'ember-metal/property_events';
+} from './property_events';
-import EmberError from 'ember-metal/error';
+import EmberError from './error';
import {
isPath,
hasThis as pathHasThis
-} from 'ember-metal/path_cache';
+} from './path_cache';
import {
peekMeta
-} from 'ember-metal/meta';
+} from './meta';
import {
toString
-} from 'ember-metal/utils';
+} from './utils';
/**
Sets the value of a property on an object, respecting computed properties | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/run_loop.js | @@ -1,16 +1,16 @@
-import { assert } from 'ember-metal/debug';
-import { isTesting } from 'ember-metal/testing';
+import { assert } from './debug';
+import { isTesting } from './testing';
import {
getOnerror,
setOnerror
-} from 'ember-metal/error_handler';
+} from './error_handler';
import {
GUID_KEY
-} from 'ember-metal/utils';
+} from './utils';
import {
beginPropertyChanges,
endPropertyChanges
-} from 'ember-metal/property_events';
+} from './property_events';
import Backburner from 'backburner';
function onBegin(current) { | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/set_properties.js | @@ -1,5 +1,5 @@
-import { changeProperties } from 'ember-metal/property_events';
-import { set } from 'ember-metal/property_set';
+import { changeProperties } from './property_events';
+import { set } from './property_set';
/**
Set a list of properties on an object. These properties are set inside | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/symbol.js | @@ -1,4 +1,4 @@
-import { GUID_KEY, intern } from 'ember-metal/utils';
+import { GUID_KEY, intern } from './utils';
export default function symbol(debugName) {
// TODO: Investigate using platform symbols, but we do not | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/transaction.js | @@ -1,6 +1,6 @@
import { meta as metaFor } from './meta';
-import { assert, runInDebug, deprecate } from 'ember-metal/debug';
-import isEnabled from 'ember-metal/features';
+import { assert, runInDebug, deprecate } from './debug';
+import isEnabled from './features';
let runInTransaction, didRender, assertNotRendered;
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/watch_key.js | @@ -1,13 +1,13 @@
-import isEnabled from 'ember-metal/features';
+import isEnabled from './features';
import {
meta as metaFor
-} from 'ember-metal/meta';
+} from './meta';
import {
MANDATORY_SETTER_FUNCTION,
DEFAULT_GETTER_FUNCTION,
INHERITING_GETTER_FUNCTION
-} from 'ember-metal/properties';
-import { lookupDescriptor } from 'ember-metal/utils';
+} from './properties';
+import { lookupDescriptor } from './utils';
let handleMandatorySetter;
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/watch_path.js | @@ -1,7 +1,7 @@
import {
meta as metaFor
-} from 'ember-metal/meta';
-import { ChainNode } from 'ember-metal/chains';
+} from './meta';
+import { ChainNode } from './chains';
// get the chains for the current object. If the current object has
// chains inherited from the proto they will be cloned and reconfigured for | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/watching.js | @@ -4,22 +4,22 @@
import {
removeChainWatcher
-} from 'ember-metal/chains';
+} from './chains';
import {
watchKey,
unwatchKey
-} from 'ember-metal/watch_key';
+} from './watch_key';
import {
watchPath,
unwatchPath
-} from 'ember-metal/watch_path';
+} from './watch_path';
import {
isPath
-} from 'ember-metal/path_cache';
+} from './path_cache';
import {
peekMeta,
deleteMeta
-} from 'ember-metal/meta';
+} from './meta';
/**
Starts watching a property on an object. Whenever the property changes, | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-metal/lib/weak_map.js | @@ -1,8 +1,8 @@
-import { GUID_KEY } from 'ember-metal/utils';
+import { GUID_KEY } from './utils';
import {
peekMeta,
meta as metaFor
-} from 'ember-metal/meta';
+} from './meta';
let id = 0;
function UNDEFINED() {} | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/compare.js | @@ -1,5 +1,5 @@
-import { typeOf } from 'ember-runtime/utils';
-import Comparable from 'ember-runtime/mixins/comparable';
+import { typeOf } from './utils';
+import Comparable from './mixins/comparable';
const TYPE_ORDER = {
'undefined': 0, | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/computed/reduce_computed_macros.js | @@ -8,9 +8,9 @@ import { get } from 'ember-metal/property_get';
import EmberError from 'ember-metal/error';
import { ComputedProperty, computed } from 'ember-metal/computed';
import { addObserver, removeObserver } from 'ember-metal/observer';
-import compare from 'ember-runtime/compare';
-import { isArray } from 'ember-runtime/utils';
-import { A as emberA } from 'ember-runtime/system/native_array';
+import compare from '../compare';
+import { isArray } from '../utils';
+import { A as emberA } from '../system/native_array';
import isNone from 'ember-metal/is_none';
import getProperties from 'ember-metal/get_properties';
import EmptyObject from 'ember-metal/empty_object'; | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/controllers/controller.js | @@ -1,8 +1,8 @@
import { assert } from 'ember-metal/debug';
-import EmberObject from 'ember-runtime/system/object';
-import Mixin from 'ember-runtime/mixins/controller';
-import { createInjectionHelper } from 'ember-runtime/inject';
-import { deprecateUnderscoreActions } from 'ember-runtime/mixins/action_handler';
+import EmberObject from '../system/object';
+import Mixin from '../mixins/controller';
+import { createInjectionHelper } from '../inject';
+import { deprecateUnderscoreActions } from '../mixins/action_handler';
/**
@module ember | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/copy.js | @@ -1,6 +1,6 @@
import { assert } from 'ember-metal/debug';
-import EmberObject from 'ember-runtime/system/object';
-import Copyable from 'ember-runtime/mixins/copyable';
+import EmberObject from './system/object';
+import Copyable from './mixins/copyable';
function _copy(obj, deep, seen, copies) {
let ret, loc, key; | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/ext/string.js | @@ -14,7 +14,7 @@ import {
underscore,
capitalize,
classify
-} from 'ember-runtime/system/string';
+} from '../system/string';
const StringPrototype = String.prototype;
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/index.js | @@ -5,45 +5,45 @@
// BEGIN IMPORTS
import Ember from 'ember-metal'; // reexports
-import isEqual from 'ember-runtime/is-equal';
-import compare from 'ember-runtime/compare';
-import copy from 'ember-runtime/copy';
-import inject from 'ember-runtime/inject';
+import isEqual from './is-equal';
+import compare from './compare';
+import copy from './copy';
+import inject from './inject';
import Namespace, {
isSearchDisabled as isNamespaceSearchDisabled,
setSearchDisabled as setNamespaceSearchDisabled
-} from 'ember-runtime/system/namespace';
-import EmberObject from 'ember-runtime/system/object';
-import { Container, Registry, getOwner, setOwner } from 'ember-runtime/system/container';
-import ArrayProxy from 'ember-runtime/system/array_proxy';
-import ObjectProxy from 'ember-runtime/system/object_proxy';
-import CoreObject from 'ember-runtime/system/core_object';
-
-import NativeArray from 'ember-runtime/system/native_array';
-import EmberStringUtils from 'ember-runtime/system/string';
+} from './system/namespace';
+import EmberObject from './system/object';
+import { Container, Registry, getOwner, setOwner } from './system/container';
+import ArrayProxy from './system/array_proxy';
+import ObjectProxy from './system/object_proxy';
+import CoreObject from './system/core_object';
+
+import NativeArray from './system/native_array';
+import EmberStringUtils from './system/string';
import {
onLoad,
runLoadHooks
-} from 'ember-runtime/system/lazy_load';
+} from './system/lazy_load';
-import EmberArray from 'ember-runtime/mixins/array';
-import Comparable from 'ember-runtime/mixins/comparable';
-import Copyable from 'ember-runtime/mixins/copyable';
-import Enumerable from 'ember-runtime/mixins/enumerable';
+import EmberArray from './mixins/array';
+import Comparable from './mixins/comparable';
+import Copyable from './mixins/copyable';
+import Enumerable from './mixins/enumerable';
import {
Freezable,
FROZEN_ERROR
-} from 'ember-runtime/mixins/freezable';
-import _ProxyMixin from 'ember-runtime/mixins/-proxy';
+} from './mixins/freezable';
+import _ProxyMixin from './mixins/-proxy';
-import Observable from 'ember-runtime/mixins/observable';
-import ActionHandler from 'ember-runtime/mixins/action_handler';
-import MutableEnumerable from 'ember-runtime/mixins/mutable_enumerable';
-import MutableArray from 'ember-runtime/mixins/mutable_array';
-import TargetActionSupport from 'ember-runtime/mixins/target_action_support';
-import Evented from 'ember-runtime/mixins/evented';
-import PromiseProxyMixin from 'ember-runtime/mixins/promise_proxy';
+import Observable from './mixins/observable';
+import ActionHandler from './mixins/action_handler';
+import MutableEnumerable from './mixins/mutable_enumerable';
+import MutableArray from './mixins/mutable_array';
+import TargetActionSupport from './mixins/target_action_support';
+import Evented from './mixins/evented';
+import PromiseProxyMixin from './mixins/promise_proxy';
import isEnabled from 'ember-metal/features';
@@ -66,7 +66,7 @@ import {
and,
or,
any
-} from 'ember-runtime/computed/computed_macros';
+} from './computed/computed_macros';
import {
sum,
@@ -83,26 +83,26 @@ import {
union,
intersect,
collect
-} from 'ember-runtime/computed/reduce_computed_macros';
+} from './computed/reduce_computed_macros';
-import Controller from 'ember-runtime/controllers/controller';
-import ControllerMixin from 'ember-runtime/mixins/controller';
+import Controller from './controllers/controller';
+import ControllerMixin from './mixins/controller';
-import Service from 'ember-runtime/system/service';
+import Service from './system/service';
-import RSVP from 'ember-runtime/ext/rsvp'; // just for side effect of extending Ember.RSVP
-import 'ember-runtime/ext/string'; // just for side effect of extending String.prototype
-import 'ember-runtime/ext/function'; // just for side effect of extending Function.prototype
+import RSVP from './ext/rsvp'; // just for side effect of extending Ember.RSVP
+import './ext/string'; // just for side effect of extending String.prototype
+import './ext/function'; // just for side effect of extending Function.prototype
-import { isArray, typeOf } from 'ember-runtime/utils';
+import { isArray, typeOf } from './utils';
-import RegistryProxyMixin from 'ember-runtime/mixins/registry_proxy';
-import ContainerProxyMixin from 'ember-runtime/mixins/container_proxy';
+import RegistryProxyMixin from './mixins/registry_proxy';
+import ContainerProxyMixin from './mixins/container_proxy';
import {
getStrings,
setStrings
-} from 'ember-runtime/string_registry';
+} from './string_registry';
// END IMPORTS
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/-proxy.js | @@ -17,8 +17,8 @@ import {
propertyWillChange,
propertyDidChange
} from 'ember-metal/property_events';
-import { bool } from 'ember-runtime/computed/computed_macros';
-import { POST_INIT } from 'ember-runtime/system/core_object';
+import { bool } from '../computed/computed_macros';
+import { POST_INIT } from '../system/core_object';
import { defineProperty } from 'ember-metal/properties';
import { Mixin, observer } from 'ember-metal/mixin';
import { tagFor } from 'ember-metal/tags'; | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/array.js | @@ -15,7 +15,7 @@ import {
cacheFor
} from 'ember-metal/computed';
import isNone from 'ember-metal/is_none';
-import Enumerable from 'ember-runtime/mixins/enumerable';
+import Enumerable from './enumerable';
import { Mixin } from 'ember-metal/mixin';
import {
propertyWillChange,
@@ -29,7 +29,7 @@ import {
} from 'ember-metal/events';
import { meta as metaFor } from 'ember-metal/meta';
import { markObjectAsDirty } from 'ember-metal/tags';
-import EachProxy from 'ember-runtime/system/each_proxy';
+import EachProxy from '../system/each_proxy';
import { deprecate } from 'ember-metal/debug';
import isEnabled from 'ember-metal/features';
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/controller.js | @@ -1,7 +1,7 @@
import { Mixin } from 'ember-metal/mixin';
import alias from 'ember-metal/alias';
-import ActionHandler from 'ember-runtime/mixins/action_handler';
-import ControllerContentModelAliasDeprecation from 'ember-runtime/mixins/controller_content_model_alias_deprecation';
+import ActionHandler from './action_handler';
+import ControllerContentModelAliasDeprecation from './controller_content_model_alias_deprecation';
/**
@class ControllerMixin | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/copyable.js | @@ -6,7 +6,7 @@
import { deprecate } from 'ember-metal/debug';
import { get } from 'ember-metal/property_get';
import { Mixin } from 'ember-metal/mixin';
-import { Freezable } from 'ember-runtime/mixins/freezable';
+import { Freezable } from './freezable';
import EmberError from 'ember-metal/error';
/** | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/enumerable.js | @@ -27,7 +27,7 @@ import {
sendEvent,
hasListeners
} from 'ember-metal/events';
-import compare from 'ember-runtime/compare';
+import compare from '../compare';
import require from 'require';
import { assert, deprecate } from 'ember-metal/debug';
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/mutable_array.js | @@ -4,13 +4,6 @@
*/
-// require('ember-runtime/mixins/array');
-// require('ember-runtime/mixins/mutable_enumerable');
-
-// ..........................................................
-// CONSTANTS
-//
-
const OUT_OF_RANGE_EXCEPTION = 'Index out of range';
const EMPTY = [];
@@ -21,9 +14,9 @@ const EMPTY = [];
import { get } from 'ember-metal/property_get';
import EmberError from 'ember-metal/error';
import { Mixin } from 'ember-metal/mixin';
-import EmberArray, { objectAt } from 'ember-runtime/mixins/array';
-import MutableEnumerable from 'ember-runtime/mixins/mutable_enumerable';
-import Enumerable from 'ember-runtime/mixins/enumerable';
+import EmberArray, { objectAt } from './array';
+import MutableEnumerable from './mutable_enumerable';
+import Enumerable from './enumerable';
import isEnabled from 'ember-metal/features';
export function removeAt(array, start, len) { | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/mutable_enumerable.js | @@ -1,4 +1,4 @@
-import Enumerable from 'ember-runtime/mixins/enumerable';
+import Enumerable from './enumerable';
import { Mixin } from 'ember-metal/mixin';
import {beginPropertyChanges, endPropertyChanges} from 'ember-metal/property_events';
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/mixins/promise_proxy.js | @@ -1,7 +1,7 @@
import { get } from 'ember-metal/property_get';
import setProperties from 'ember-metal/set_properties';
import { computed } from 'ember-metal/computed';
-import { not, or } from 'ember-runtime/computed/computed_macros';
+import { not, or } from '../computed/computed_macros';
import { Mixin } from 'ember-metal/mixin';
import EmberError from 'ember-metal/error';
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/application.js | @@ -1,3 +1,3 @@
-import Namespace from 'ember-runtime/system/namespace';
+import Namespace from './namespace';
export default Namespace.extend(); | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/array_proxy.js | @@ -2,7 +2,7 @@ import { assert } from 'ember-metal/debug';
import { get } from 'ember-metal/property_get';
import {
isArray
-} from 'ember-runtime/utils';
+} from '../utils';
import { computed } from 'ember-metal/computed';
import {
_beforeObserver,
@@ -13,17 +13,17 @@ import {
endPropertyChanges
} from 'ember-metal/property_events';
import EmberError from 'ember-metal/error';
-import EmberObject from 'ember-runtime/system/object';
-import MutableArray from 'ember-runtime/mixins/mutable_array';
-import Enumerable from 'ember-runtime/mixins/enumerable';
+import EmberObject from './object';
+import MutableArray from '../mixins/mutable_array';
+import Enumerable from '../mixins/enumerable';
import alias from 'ember-metal/alias';
import {
addArrayObserver,
removeArrayObserver,
arrayContentDidChange,
arrayContentWillChange,
objectAt
-} from 'ember-runtime/mixins/array';
+} from '../mixins/array';
/**
@module ember | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/core_object.js | @@ -33,14 +33,14 @@ import {
REQUIRED
} from 'ember-metal/mixin';
import EmberError from 'ember-metal/error';
-import ActionHandler from 'ember-runtime/mixins/action_handler';
+import ActionHandler from '../mixins/action_handler';
import { defineProperty } from 'ember-metal/properties';
import { Binding } from 'ember-metal/binding';
import { ComputedProperty, computed } from 'ember-metal/computed';
import InjectedProperty from 'ember-metal/injected_property';
import run from 'ember-metal/run_loop';
import { destroy } from 'ember-metal/watching';
-import { validatePropertyInjections } from 'ember-runtime/inject';
+import { validatePropertyInjections } from '../inject';
import symbol from 'ember-metal/symbol';
export let POST_INIT = symbol('POST_INIT'); | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/each_proxy.js | @@ -11,7 +11,7 @@ import {
propertyWillChange
} from 'ember-metal/property_events';
import EmptyObject from 'ember-metal/empty_object';
-import { objectAt } from 'ember-runtime/mixins/array';
+import { objectAt } from '../mixins/array';
/**
This is the object instance returned when you get the `@each` property on an | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/namespace.js | @@ -15,7 +15,7 @@ import {
NAME_KEY
} from 'ember-metal/mixin';
-import EmberObject from 'ember-runtime/system/object';
+import EmberObject from './object';
let searchDisabled = false;
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/native_array.js | @@ -10,12 +10,12 @@ import { Mixin } from 'ember-metal/mixin';
import EmberArray, {
arrayContentDidChange,
arrayContentWillChange
-} from 'ember-runtime/mixins/array';
-import MutableArray from 'ember-runtime/mixins/mutable_array';
-import Observable from 'ember-runtime/mixins/observable';
-import Copyable from 'ember-runtime/mixins/copyable';
-import { FROZEN_ERROR } from 'ember-runtime/mixins/freezable';
-import copy from 'ember-runtime/copy';
+} from '../mixins/array';
+import MutableArray from '../mixins/mutable_array';
+import Observable from '../mixins/observable';
+import Copyable from '../mixins/copyable';
+import { FROZEN_ERROR } from '../mixins/freezable';
+import copy from '../copy';
// Add Ember.Array to Array.prototype. Remove methods with native
// implementations and supply some more optimized versions of generic methods | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/object.js | @@ -3,8 +3,8 @@
@submodule ember-runtime
*/
-import CoreObject from 'ember-runtime/system/core_object';
-import Observable from 'ember-runtime/mixins/observable';
+import CoreObject from './core_object';
+import Observable from '../mixins/observable';
/**
`Ember.Object` is the main base class for all Ember objects. It is a subclass | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/object_proxy.js | @@ -1,5 +1,5 @@
-import EmberObject from 'ember-runtime/system/object';
-import _ProxyMixin from 'ember-runtime/mixins/-proxy';
+import EmberObject from './object';
+import _ProxyMixin from '../mixins/-proxy';
/**
`Ember.ObjectProxy` forwards all properties not defined by the proxy itself | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/service.js | @@ -1,5 +1,5 @@
-import EmberObject from 'ember-runtime/system/object';
-import { createInjectionHelper } from 'ember-runtime/inject';
+import EmberObject from './object';
+import { createInjectionHelper } from '../inject';
/** | true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/system/string.js | @@ -6,10 +6,10 @@ import { deprecate } from 'ember-metal/debug';
import {
inspect as emberInspect
} from 'ember-metal/utils';
-import { isArray } from 'ember-runtime/utils';
+import { isArray } from '../utils';
import {
get as getString
-} from 'ember-runtime/string_registry';
+} from '../string_registry';
import Cache from 'ember-metal/cache';
| true |
Other | emberjs | ember.js | aa76fcff3346304f4612868c15490d5872f43e43.json | Use relative imports.
* Use relative imports for ember-glimmer.
* Use relative imports for ember-metal.
* Use relative imports from ember-runtime. | packages/ember-runtime/lib/utils.js | @@ -1,5 +1,5 @@
-import EmberArray from 'ember-runtime/mixins/array';
-import EmberObject from 'ember-runtime/system/object';
+import EmberArray from './mixins/array';
+import EmberObject from './system/object';
// ........................................
// TYPING & ARRAY MESSAGING | true |
Other | emberjs | ember.js | 588a698c732f78b2ed7392d6240d79b9476e9a6f.json | Prevent reordering when using `seed` URL config. | tests/index.html | @@ -162,6 +162,10 @@
QUnit.config.urlConfig.push('nojshint');
QUnit.config.urlConfig.push('forceskip');
+ if (QUnit.config.seed) {
+ QUnit.config.reorder = false;
+ }
+
QUnit.begin(function() {
if (QUnit.urlParams.hideskipped) {
$('#qunit-tests').addClass('hideskipped'); | false |
Other | emberjs | ember.js | 632ecdb07826f16cb1e7cf7a5afecc9d6ae71414.json | Fix issues with test cleanup. | packages/ember-runtime/tests/ext/rsvp_test.js | @@ -3,7 +3,13 @@ import { setOnerror, getOnerror } from 'ember-metal/error_handler';
import run from 'ember-metal/run_loop';
import RSVP from 'ember-runtime/ext/rsvp';
-QUnit.module('Ember.RSVP');
+const ORIGINAL_ONERROR = getOnerror();
+
+QUnit.module('Ember.RSVP', {
+ teardown() {
+ setOnerror(ORIGINAL_ONERROR);
+ }
+});
QUnit.test('Ensure that errors thrown from within a promise are sent to the console', function() {
let error = new Error('Error thrown in a promise for testing purposes.'); | true |
Other | emberjs | ember.js | 632ecdb07826f16cb1e7cf7a5afecc9d6ae71414.json | Fix issues with test cleanup. | packages/ember-runtime/tests/mixins/promise_proxy_test.js | @@ -17,6 +17,10 @@ QUnit.test('present on ember namespace', function() {
QUnit.module('Ember.PromiseProxy - ObjectProxy', {
setup() {
ObjectPromiseProxy = ObjectProxy.extend(PromiseProxyMixin);
+ },
+
+ teardown() {
+ RSVP.on('error', onerrorDefault);
}
});
| true |
Other | emberjs | ember.js | 632ecdb07826f16cb1e7cf7a5afecc9d6ae71414.json | Fix issues with test cleanup. | packages/ember-runtime/tests/system/lazy_load_test.js | @@ -1,7 +1,14 @@
import run from 'ember-metal/run_loop';
-import {onLoad, runLoadHooks} from 'ember-runtime/system/lazy_load';
+import {onLoad, runLoadHooks, _loaded } from 'ember-runtime/system/lazy_load';
-QUnit.module('Lazy Loading');
+QUnit.module('Lazy Loading', {
+ teardown() {
+ let keys = Object.keys(_loaded);
+ for (let i = 0; i < keys.length; i++) {
+ delete _loaded[keys[i]];
+ }
+ }
+});
QUnit.test('if a load hook is registered, it is executed when runLoadHooks are exected', function() {
let count = 0; | true |
Other | emberjs | ember.js | 632ecdb07826f16cb1e7cf7a5afecc9d6ae71414.json | Fix issues with test cleanup. | packages/ember-testing/tests/acceptance_test.js | @@ -17,6 +17,9 @@ QUnit.module('ember-testing Acceptance', {
setup() {
jQuery('<style>#ember-testing-container { position: absolute; background: white; bottom: 0; right: 0; width: 640px; height: 384px; overflow: auto; z-index: 9999; border: 1px solid #ccc; } #ember-testing { zoom: 50%; }</style>').appendTo('head');
jQuery('<div id="ember-testing-container"><div id="ember-testing"></div></div>').appendTo('body');
+
+ originalAdapter = Test.adapter;
+
run(function() {
indexHitCount = 0;
@@ -86,8 +89,6 @@ QUnit.module('ember-testing Acceptance', {
visit = window.visit;
andThen = window.andThen;
currentURL = window.currentURL;
-
- originalAdapter = Test.adapter;
},
teardown() { | true |
Other | emberjs | ember.js | 632ecdb07826f16cb1e7cf7a5afecc9d6ae71414.json | Fix issues with test cleanup. | packages/ember-testing/tests/helpers_test.js | @@ -1018,10 +1018,7 @@ QUnit.module('can override built-in helpers', {
},
teardown() {
- App.removeTestHelpers();
- jQuery('#ember-testing-container, #ember-testing').remove();
- run(App, App.destroy);
- App = null;
+ cleanup();
Test._helpers.visit = originalVisitHelper;
Test._helpers.find = originalFindHelper; | true |
Other | emberjs | ember.js | d21e016c51e0d1b6ce23ee36a67eac2a14e2bede.json | Add failing test for GH#13846. | packages/ember-glimmer/tests/integration/components/curly-components-test.js | @@ -2570,4 +2570,74 @@ moduleFor('Components test: curly components', class extends RenderingTest {
assertElement('foo');
}
+
+ ['@test child triggers revalidate during parent destruction (GH#13846)']() {
+ let select;
+
+ this.registerComponent('x-select', {
+ ComponentClass: Component.extend({
+ tagName: 'select',
+
+ init() {
+ this._super();
+ this.options = emberA([]);
+ this.value = null;
+
+ select = this;
+ },
+
+ updateValue() {
+ var newValue = this.get('options.lastObject.value');
+
+ this.set('value', newValue);
+ },
+
+ registerOption(option) {
+ this.get('options').addObject(option);
+ },
+
+ unregisterOption(option) {
+ this.get('options').removeObject(option);
+
+ this.updateValue();
+ }
+ }),
+
+ template: '{{yield this}}'
+ });
+
+ this.registerComponent('x-option', {
+ ComponentClass: Component.extend({
+ tagName: 'option',
+ attributeBindings: ['selected'],
+
+ didInsertElement() {
+ this._super(...arguments);
+
+ this.get('select').registerOption(this);
+ },
+
+ selected: computed('select.value', function() {
+ return this.get('value') === this.get('select.value');
+ }),
+
+ willDestroyElement() {
+ this._super(...arguments);
+ this.get('select').unregisterOption(this);
+ }
+ })
+ });
+
+ this.render(strip`
+ {{#x-select value=value as |select|}}
+ {{#x-option value="1" select=select}}1{{/x-option}}
+ {{#x-option value="2" select=select}}2{{/x-option}}
+ {{/x-select}}
+ `);
+
+
+ this.teardown();
+
+ this.assert.ok(true, 'no errors during teardown');
+ }
}); | false |
Other | emberjs | ember.js | 39875a4869d73ad34c165bbeecce0b4d4d15ab39.json | Add helpful assertion when template is missing.
Prior to this change, calling `component.appendTo()` when there was no
`template` would trigger an unhelpful error:
```
Cannot read property 'asEntryPoint' of undefined
```
After this change, it will at least point you in the direction of the
offending component:
```
You cannot render `<dummy@component:foo-bar::ember168>` without a template.
``` | packages/ember-glimmer/lib/renderer.js | @@ -180,6 +180,8 @@ class Renderer {
};
let { _env: env } = this;
let render = () => {
+ assert(`You cannot render \`${self.value()}\` without a template.`, template);
+
let result = template.asEntryPoint().render(self, env, {
appendTo: parentElement,
dynamicScope | false |
Other | emberjs | ember.js | 336974825be2aa061c293561e32a2d1f1a9fd531.json | Add v2.8.0-beta.3 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 30ad5145ba199e35314a8ce4afc1253ddd749c11) | CHANGELOG.md | @@ -1,5 +1,15 @@
# Ember Changelog
+### 2.8.0-beta.3 (August 15, 2016)
+
+- [#14009](https://github.com/emberjs/ember.js/pull/14009) [BUGFIX] Fix usage of `role` when used in `attributeBindings`.
+- [#14044](https://github.com/emberjs/ember.js/pull/14044) / [#14062](https://github.com/emberjs/ember.js/pull/14062) / [#14066](https://github.com/emberjs/ember.js/pull/14066) [BUGFIX] Update `router.js` so that `getHandlers` is invoked lazily.
+- [#14054](https://github.com/emberjs/ember.js/pull/14054) [BUGFIX] Ensure substates properly work with `resetNamespace`.
+- [#14033](https://github.com/emberjs/ember.js/pull/14033) [BUGFIX] Ensure `fillIn` acceptance test helper only sets value to first matched element.
+- [#14058](https://github.com/emberjs/ember.js/pull/14058) [BUGFIX] Fix issues related to `Ember.Router.map` changes in 2.7.0.
+- [#14068](https://github.com/emberjs/ember.js/pull/14068) [BUGFIX] Prevent errors when clicking a `{{link-to}}` during an existing transition.
+
+
### 2.8.0-beta.2 (August 1, 2016)
- [#13887](https://github.com/emberjs/ember.js/pull/13887) [BUGFIX] Add assertions for illegal component invocations. | false |
Other | emberjs | ember.js | 1568459714bbe54d03b6711ea7d3501e08758300.json | Add 2.7.1 to the CHANGELOG.md.
[ci skip]
(cherry picked from commit e6a4a3b00ad1c3e978d9a3692510c90958d28add) | CHANGELOG.md | @@ -18,6 +18,12 @@
- [#13855](https://github.com/emberjs/ember.js/pull/13855) [FEATURE ember-runtime-enumerable-includes] Enable by default.
- [#13855](https://github.com/emberjs/ember.js/pull/13855) [FEATURE ember-testing-check-waiters] Enable by default.
+### 2.7.1 (August 15, 2016)
+
+- [#13920](https://github.com/emberjs/ember.js/pull/13920) [BUGFIX] Add more info to the `Ember.Binding` deprecation.
+- [#14058](https://github.com/emberjs/ember.js/pull/14058) [BUGFIX] Fix issues related to `Ember.Router.map` changes in 2.7.0.
+- [#14068](https://github.com/emberjs/ember.js/pull/14068) [BUGFIX] Prevent errors when clicking a `{{link-to}}` during an existing transition.
+
### 2.7.0 (July 25, 2016)
- [#13764](https://github.com/emberjs/ember.js/pull/13764) [BUGFIX] Keep rest positional parameters when nesting contextual components if needed. | false |
Other | emberjs | ember.js | 40fe91a21e39cca4e042278628abf8813b8365f8.json | Add a (failing on Glimmer) test for #13983 | packages/ember-glimmer/tests/integration/syntax/each-test.js | @@ -653,6 +653,52 @@ class SingleEachTest extends AbstractEachTest {
this.assertText('No Thing bar');
}
+ ['@test content that are not initially present updates correctly GH#13983']() {
+ // The root cause of this bug is that Glimmer did not call `didInitializeChildren`
+ // on the inserted `TryOpcode`, causing that `TryOpcode` to have an uninitialized
+ // tag. Currently the only way to observe this the "JUMP-IF-NOT-MODIFIED", i.e. by
+ // wrapping it in an component.
+
+ this.registerComponent('x-wrapper', { template: '{{yield}}' });
+
+ this.makeList([]);
+
+ this.render(`{{#x-wrapper}}{{#each list as |obj|}}[{{obj.text}}]{{/each}}{{/x-wrapper}}`);
+
+ this.assertText('');
+
+ this.runTask(() => this.rerender());
+
+ this.assertText('');
+
+ this.runTask(() => this.pushObject({ text: 'foo' }));
+
+ this.assertText('[foo]');
+
+ this.runTask(() => set(this.objectAt(0), 'text', 'FOO'));
+
+ this.assertText('[FOO]');
+
+ this.runTask(() => this.pushObject({ text: 'bar' }));
+
+ this.assertText('[FOO][bar]');
+
+ this.runTask(() => set(this.objectAt(1), 'text', 'BAR'));
+
+ this.assertText('[FOO][BAR]');
+
+ this.runTask(() => set(this.objectAt(1), 'text', 'baz'));
+
+ this.assertText('[FOO][baz]');
+
+ this.runTask(() => this.replace(1, 1, [{ text: 'BAZ' }]));
+
+ this.assertText('[FOO][BAZ]');
+
+ this.replaceList([]);
+
+ this.assertText('');
+ }
}
moduleFor('Syntax test: {{#each}} with arrays', class extends SingleEachTest { | false |
Other | emberjs | ember.js | d981dadc2a58aa63dc8b74c66e06279465b76974.json | Unify another element action modify test
Unsure if we need to be testing the implementation details here, but the
difference is trivial. | packages/ember-glimmer/tests/integration/helpers/element-action-test.js | @@ -167,22 +167,19 @@ moduleFor('Helpers test: element action', class extends RenderingTest {
this.assert.deepEqual(fooArgs, ['a', 'b'], 'foo has been called with an updated value');
}
- ['@htmlbars it should output a data attribute with a guid']() {
+ ['@test it should output a marker attribute with a guid']() {
this.render('<button {{action "show"}}>me the money</button>');
let button = this.$('button');
- this.assert.ok(button.attr('data-ember-action').match(/\d+/), 'A data-ember-action attribute with a guid was added');
- }
-
- ['@glimmer it should output a marker data attribute and a data attribute with a guid']() {
- this.render('<button {{action "show"}}>me the money</button>');
-
- let button = this.$('button');
- let attributes = getActionAttributes(button.get(0));
+ if (this.isGlimmer) {
+ let attributes = getActionAttributes(button.get(0));
- this.assert.ok(button.attr('data-ember-action').match(''), 'An empty data-ember-action attribute was added');
- this.assert.ok(attributes[0].match(/data-ember-action-\d+/), 'A data-ember-action-xyz attribute with a guid was added');
+ this.assert.ok(button.attr('data-ember-action').match(''), 'An empty data-ember-action attribute was added');
+ this.assert.ok(attributes[0].match(/data-ember-action-\d+/), 'A data-ember-action-xyz attribute with a guid was added');
+ } else {
+ this.assert.ok(button.attr('data-ember-action').match(/\d+/), 'A data-ember-action attribute with a guid was added');
+ }
}
['@test it should allow alternative events to be handled']() { | false |
Other | emberjs | ember.js | 2f5f485d15ea180e4f1733f8f7e06d8d29314f9e.json | Unify another test
The difference is in Glimmer, the hooks are not called when nothing has
changed. This also refactored the tests to be more readable. | packages/ember-glimmer/tests/integration/components/curly-components-test.js | @@ -1016,103 +1016,75 @@ moduleFor('Components test: curly components', class extends RenderingTest {
this.assertText('In layout - someProp: value set in instance');
}
- // Note: Hooks are not re-run for idempotent re-renders
- ['@glimmer rerendering component with attrs from parent'](assert) {
- let willUpdate = 0;
- let didReceiveAttrs = 0;
+ ['@test rerendering component with attrs from parent'](assert) {
+ let willUpdateCount = 0;
+ let didReceiveAttrsCount = 0;
- this.registerComponent('non-block', {
- ComponentClass: Component.extend({
- didReceiveAttrs() {
- didReceiveAttrs++;
- },
-
- willUpdate() {
- willUpdate++;
- }
- }),
- template: 'In layout - someProp: {{someProp}}'
- });
+ function expectHooks({ willUpdate, didReceiveAttrs }, callback) {
+ willUpdateCount = 0;
+ didReceiveAttrsCount = 0;
- this.render('{{non-block someProp=someProp}}', {
- someProp: 'wycats'
- });
-
- assert.equal(didReceiveAttrs, 1, 'The didReceiveAttrs hook fired');
- this.assertText('In layout - someProp: wycats');
-
- this.runTask(() => this.rerender());
-
- this.assertText('In layout - someProp: wycats');
- assert.equal(didReceiveAttrs, 1, 'The didReceiveAttrs hook fired again');
- assert.equal(willUpdate, 0, 'The willUpdate hook fired once');
-
- this.runTask(() => this.context.set('someProp', 'tomdale'));
-
- this.assertText('In layout - someProp: tomdale');
- assert.equal(didReceiveAttrs, 2, 'The didReceiveAttrs hook fired again');
- assert.equal(willUpdate, 1, 'The willUpdate hook fired again');
+ callback();
- this.runTask(() => this.rerender());
-
- this.assertText('In layout - someProp: tomdale');
- assert.equal(didReceiveAttrs, 2, 'The didReceiveAttrs hook fired again');
- assert.equal(willUpdate, 1, 'The willUpdate hook fired again');
-
- this.runTask(() => this.context.set('someProp', 'wycats'));
-
- this.assertText('In layout - someProp: wycats');
- assert.equal(didReceiveAttrs, 3, 'The didReceiveAttrs hook fired again in the R step');
- assert.equal(willUpdate, 2, 'The willUpdate hook fired again in the R step');
- }
+ if (willUpdate) {
+ assert.strictEqual(willUpdateCount, 1, 'The willUpdate hook was fired');
+ } else {
+ assert.strictEqual(willUpdateCount, 0, 'The willUpdate hook was not fired');
+ }
- ['@htmlbars rerendering component with attrs from parent'](assert) {
- let willUpdate = 0;
- let didReceiveAttrs = 0;
+ if (didReceiveAttrs) {
+ assert.strictEqual(didReceiveAttrsCount, 1, 'The didReceiveAttrs hook was fired');
+ } else {
+ assert.strictEqual(didReceiveAttrsCount, 0, 'The didReceiveAttrs hook was not fired');
+ }
+ }
this.registerComponent('non-block', {
ComponentClass: Component.extend({
didReceiveAttrs() {
- didReceiveAttrs++;
+ didReceiveAttrsCount++;
},
willUpdate() {
- willUpdate++;
+ willUpdateCount++;
}
}),
template: 'In layout - someProp: {{someProp}}'
});
- this.render('{{non-block someProp=someProp}}', {
- someProp: 'wycats'
+ expectHooks({ willUpdate: false, didReceiveAttrs: true }, () => {
+ this.render('{{non-block someProp=someProp}}', {
+ someProp: 'wycats'
+ });
});
- assert.equal(didReceiveAttrs, 1, 'The didReceiveAttrs hook fired');
this.assertText('In layout - someProp: wycats');
- this.runTask(() => this.rerender());
+ // Note: Hooks are not fired in Glimmer for idempotent re-renders
+ expectHooks({ willUpdate: this.isHTMLBars, didReceiveAttrs: this.isHTMLBars }, () => {
+ this.runTask(() => this.rerender());
+ });
this.assertText('In layout - someProp: wycats');
- assert.equal(didReceiveAttrs, 2, 'The didReceiveAttrs hook fired again');
- assert.equal(willUpdate, 1, 'The willUpdate hook fired once');
- this.runTask(() => this.context.set('someProp', 'tomdale'));
+ expectHooks({ willUpdate: true, didReceiveAttrs: true }, () => {
+ this.runTask(() => this.context.set('someProp', 'tomdale'));
+ });
this.assertText('In layout - someProp: tomdale');
- assert.equal(didReceiveAttrs, 3, 'The didReceiveAttrs hook fired again');
- assert.equal(willUpdate, 2, 'The willUpdate hook fired again');
- this.runTask(() => this.rerender());
+ // Note: Hooks are not fired in Glimmer for idempotent re-renders
+ expectHooks({ willUpdate: this.isHTMLBars, didReceiveAttrs: this.isHTMLBars }, () => {
+ this.runTask(() => this.rerender());
+ });
this.assertText('In layout - someProp: tomdale');
- assert.equal(didReceiveAttrs, 4, 'The didReceiveAttrs hook fired again');
- assert.equal(willUpdate, 3, 'The willUpdate hook fired again');
- this.runTask(() => this.context.set('someProp', 'wycats'));
+ expectHooks({ willUpdate: true, didReceiveAttrs: true }, () => {
+ this.runTask(() => this.context.set('someProp', 'wycats'));
+ });
this.assertText('In layout - someProp: wycats');
- assert.equal(didReceiveAttrs, 5, 'The didReceiveAttrs hook fired again in the R step');
- assert.equal(willUpdate, 4, 'The willUpdate hook fired again in the R step');
}
['@test non-block with properties on self']() { | false |
Other | emberjs | ember.js | 93ae5ab1c7055edc455562cbab15cd7e8418612e.json | Unify another duplicated test | packages/ember-glimmer/tests/integration/components/attrs-lookup-test.js | @@ -127,66 +127,14 @@ moduleFor('Components test: attrs lookup', class extends RenderingTest {
assert.equal(instance.get('woot'), 'yes', 'component found attr after reset');
}
- // HTMLBars runs `didReceiveAttrs` on `rerender`
- ['@htmlbars getAttr() should return the same value as get()'](assert) {
- assert.expect(20);
- let instance;
- let FooBarComponent = Component.extend({
- init() {
- this._super(...arguments);
- instance = this;
- },
-
- didReceiveAttrs() {
- let rootFirst = this.get('first');
- let rootSecond = this.get('second');
- let attrFirst = this.getAttr('first');
- let attrSecond = this.getAttr('second');
-
- equal(rootFirst, attrFirst, 'root property matches attrs value');
- equal(rootSecond, attrSecond, 'root property matches attrs value');
- }
- });
- this.registerComponent('foo-bar', { ComponentClass: FooBarComponent });
-
- this.render(`{{foo-bar first=first second=second}}`, {
- first: 'first',
- second: 'second'
- });
-
- assert.equal(instance.get('first'), 'first', 'matches known value');
- assert.equal(instance.get('second'), 'second', 'matches known value');
-
- this.runTask(() => this.rerender());
-
- assert.equal(instance.get('first'), 'first', 'matches known value');
- assert.equal(instance.get('second'), 'second', 'matches known value');
-
- this.runTask(() => {
- set(this.context, 'first', 'third');
- });
-
- assert.equal(instance.get('first'), 'third', 'matches known value');
- assert.equal(instance.get('second'), 'second', 'matches known value');
-
- this.runTask(() => {
- set(this.context, 'second', 'fourth');
- });
-
- assert.equal(instance.get('first'), 'third', 'matches known value');
- assert.equal(instance.get('second'), 'fourth', 'matches known value');
-
- this.runTask(() => {
- set(this.context, 'first', 'first');
- set(this.context, 'second', 'second');
- });
-
- assert.equal(instance.get('first'), 'first', 'matches known value');
- assert.equal(instance.get('second'), 'second', 'matches known value');
- }
+ ['@test getAttr() should return the same value as get()'](assert) {
+ if (this.isGlimmer) {
+ assert.expect(18);
+ } else {
+ // HTMLBars runs `didReceiveAttrs` on `rerender`
+ assert.expect(20);
+ }
- ['@glimmer getAttr() should return the same value as get()'](assert) {
- assert.expect(18);
let instance;
let FooBarComponent = Component.extend({
init() { | false |
Other | emberjs | ember.js | cb318bc7fb2d98c8d0434502b9e917f61f50602a.json | Update testem config to use `latest` when possible.
* Use `latest` for Chrome
* Use `latest` for FireFox (was using 45) | testem.dist.json | @@ -6,11 +6,11 @@
"disable_watching": true,
"launchers": {
"SL_Chrome_Current": {
- "command": "npm run sauce:launch -- -b chrome --no-ct -u '<url>'",
+ "command": "npm run sauce:launch -- -p 'Windows 10' -b chrome -v latest --no-ct -u '<url>'",
"protocol": "tap"
},
"SL_Firefox_Current": {
- "command": "npm run sauce:launch -- -b firefox -v 45 --no-ct -u '<url>'",
+ "command": "npm run sauce:launch -- -p 'Windows 10' -b firefox -v latest --no-ct -u '<url>'",
"protocol": "tap"
},
"SL_Safari_Current": {
@@ -22,7 +22,7 @@
"protocol": "tap"
},
"SL_MS_Edge": {
- "command": "npm run sauce:launch -- -b 'microsoftedge' --no-ct -u '<url>'",
+ "command": "npm run sauce:launch -- -p 'Windows 10' -b 'microsoftedge' -v latest --no-ct -u '<url>'",
"protocol": "tap"
},
"SL_IE_11": { | false |
Other | emberjs | ember.js | 18678b75db328f66a67931f8bd8bfde55549a45e.json | Update emberjs-build to v0.14.0.
Updates to a version of emberjs-build that does not use
glimmer-template-precompiler (an obsolete package). Instead it passes
through the current glimmer version to the underlying template
compliation so that the templates shipped with Ember are for the same
version of glimmer that will be used at runtime.
Also, updates to using tagged builds. | ember-cli-build.js | @@ -143,6 +143,7 @@ module.exports = function() {
production: getFeatures('production')
},
htmlbars: require('htmlbars'),
+ glimmer: require('glimmer-engine'),
packages: getPackages(features),
vendoredPackages: vendorPackages,
version: version | true |
Other | emberjs | ember.js | 18678b75db328f66a67931f8bd8bfde55549a45e.json | Update emberjs-build to v0.14.0.
Updates to a version of emberjs-build that does not use
glimmer-template-precompiler (an obsolete package). Instead it passes
through the current glimmer version to the underlying template
compliation so that the templates shipped with Ember are for the same
version of glimmer that will be used at runtime.
Also, updates to using tagged builds. | package.json | @@ -33,13 +33,13 @@
"ember-cli-sauce": "^1.4.2",
"ember-cli-yuidoc": "0.8.4",
"ember-publisher": "0.0.7",
- "emberjs-build": "0.13.5",
+ "emberjs-build": "0.14.0",
"express": "^4.5.0",
"finalhandler": "^0.4.0",
"git-repo-info": "^1.1.4",
"git-repo-version": "^0.3.1",
"github": "^0.2.3",
- "glimmer-engine": "tildeio/glimmer#f961049",
+ "glimmer-engine": "0.7.0",
"glob": "^5.0.13",
"htmlbars": "0.14.24",
"mocha": "^2.4.5", | true |
Other | emberjs | ember.js | 3bdd7b5e68052541fda3c734d9d4c70c2cfa492b.json | Update emberjs-build to 0.13.5.
The cache invalidation issues that were being monkey patched around,
have been fixed upstream in broccoli-babel-transpiler.
These manual hacks are no longer needed. | ember-cli-build.js | @@ -60,27 +60,18 @@ function getFeatures(environment) {
function babelConfigFor(environment) {
var plugins = [];
-
var features = getFeatures(environment);
- var featureFlagPlugin = applyFeatureFlags({
+
+ plugins.push(applyFeatureFlags({
import: { module: 'ember-metal/features' },
features: features
- });
- featureFlagPlugin._augmentCacheKey = function() {
- return JSON.stringify(features);
- };
- plugins.push(featureFlagPlugin);
+ }));
var isProduction = (environment === 'production');
if (isProduction) {
- var debugImportsConfig = {'ember-metal/debug': ['assert', 'debug', 'deprecate', 'info', 'runInDebug', 'warn', 'debugSeal']};
- var filterDebugImportsPlugin = filterImports(debugImportsConfig);
-
- filterDebugImportsPlugin._augmentCacheKey = function() {
- return JSON.stringify(debugImportsConfig);
- };
-
- plugins.push(filterDebugImportsPlugin);
+ plugins.push(filterImports({
+ 'ember-metal/debug': ['assert', 'debug', 'deprecate', 'info', 'runInDebug', 'warn', 'debugSeal']
+ }));
}
return { plugins: plugins }; | true |
Other | emberjs | ember.js | 3bdd7b5e68052541fda3c734d9d4c70c2cfa492b.json | Update emberjs-build to 0.13.5.
The cache invalidation issues that were being monkey patched around,
have been fixed upstream in broccoli-babel-transpiler.
These manual hacks are no longer needed. | package.json | @@ -33,13 +33,13 @@
"ember-cli-sauce": "^1.4.2",
"ember-cli-yuidoc": "0.8.4",
"ember-publisher": "0.0.7",
- "emberjs-build": "0.13.3",
+ "emberjs-build": "0.13.5",
"express": "^4.5.0",
"finalhandler": "^0.4.0",
"git-repo-info": "^1.1.4",
"git-repo-version": "^0.3.1",
"github": "^0.2.3",
- "glimmer-engine": "tildeio/glimmer#efc998a",
+ "glimmer-engine": "tildeio/glimmer#f961049",
"glob": "^5.0.13",
"htmlbars": "0.14.24",
"mocha": "^2.4.5", | true |
Other | emberjs | ember.js | ee050f46f6e5c94266db56292ad7a67d64af6333.json | Remove dead code | packages/ember-views/lib/system/platform.js | @@ -1,14 +0,0 @@
-import { environment } from 'ember-environment';
-
-// IE 6/7 have bugs around setting names on inputs during creation.
-// From http://msdn.microsoft.com/en-us/library/ie/ms536389(v=vs.85).aspx:
-// "To include the NAME attribute at run time on objects created with the createElement method, use the eTag."
-export let canSetNameOnInputs = environment.hasDOM && (function() {
- let div = document.createElement('div');
- let el = document.createElement('input');
-
- el.setAttribute('name', 'foo');
- div.appendChild(el);
-
- return !!div.innerHTML.match('foo');
-})(); | false |
Other | emberjs | ember.js | 639763a81183e17cbc9ee218899c0fefab1de8b4.json | Improve coverage for `ArrayProxy` + `{{#each}}` | packages/ember-glimmer/tests/integration/syntax/each-test.js | @@ -135,14 +135,62 @@ class AbstractEachTest extends RenderingTest {
/* abstract */
makeList() {
- // this.list = ...;
+ // this.list = this.delegate = ...;
throw new Error('Not implemented: `makeList`');
}
replaceList(list) {
this.runTask(() => set(this.context, 'list', this.makeList(list)));
}
+ forEach(callback) {
+ return this.delegate.forEach(callback);
+ }
+
+ objectAt(idx) {
+ return this.delegate.objectAt(idx);
+ }
+
+ clear() {
+ return this.delegate.clear();
+ }
+
+ replace(idx, del, ins) {
+ return this.delegate.replace(idx, del, ins);
+ }
+
+ unshiftObject(obj) {
+ return this.delegate.unshiftObject(obj);
+ }
+
+ unshiftObjects(arr) {
+ return this.delegate.unshiftObjects(arr);
+ }
+
+ pushObject(obj) {
+ return this.delegate.pushObject(obj);
+ }
+
+ pushObjects(arr) {
+ return this.delegate.pushObjects(arr);
+ }
+
+ shiftObject() {
+ return this.delegate.shiftObject();
+ }
+
+ popObject() {
+ return this.delegate.popObject();
+ }
+
+ insertAt(idx, obj) {
+ return this.delegate.insertAt(idx, obj);
+ }
+
+ removeAt(idx, len) {
+ return this.delegate.removeAt(idx, len);
+ }
+
render(template, context = {}) {
if (this.list === undefined) {
throw new Error('Must call `this.makeList()` before calling this.render()');
@@ -158,7 +206,7 @@ class AbstractEachTest extends RenderingTest {
class SingleEachTest extends AbstractEachTest {
['@test it repeats the given block for each item in the array']() {
- let list = this.makeList([{ text: 'hello' }]);
+ this.makeList([{ text: 'hello' }]);
this.render(`{{#each list as |item|}}{{item.text}}{{else}}Empty{{/each}}`);
@@ -168,52 +216,52 @@ class SingleEachTest extends AbstractEachTest {
this.assertText('hello');
- this.runTask(() => set(list.objectAt(0), 'text', 'Hello'));
+ this.runTask(() => set(this.objectAt(0), 'text', 'Hello'));
this.assertText('Hello');
this.runTask(() => {
- list.pushObject({ text: ' ' });
- list.pushObject({ text: 'World' });
+ this.pushObject({ text: ' ' });
+ this.pushObject({ text: 'World' });
});
this.assertText('Hello World');
this.runTask(() => {
- list.pushObject({ text: 'Earth' });
- list.removeAt(1);
- list.insertAt(1, { text: 'Globe' });
+ this.pushObject({ text: 'Earth' });
+ this.removeAt(1);
+ this.insertAt(1, { text: 'Globe' });
});
this.assertText('HelloGlobeWorldEarth');
this.runTask(() => {
- list.pushObject({ text: 'Planet' });
- list.removeAt(1);
- list.insertAt(1, { text: ' ' });
- list.pushObject({ text: ' ' });
- list.pushObject({ text: 'Earth' });
- list.removeAt(3);
+ this.pushObject({ text: 'Planet' });
+ this.removeAt(1);
+ this.insertAt(1, { text: ' ' });
+ this.pushObject({ text: ' ' });
+ this.pushObject({ text: 'Earth' });
+ this.removeAt(3);
});
this.assertText('Hello WorldPlanet Earth');
this.runTask(() => {
- list.pushObject({ text: 'Globe' });
- list.removeAt(1);
- list.insertAt(1, { text: ' ' });
- list.pushObject({ text: ' ' });
- list.pushObject({ text: 'World' });
- list.removeAt(2);
+ this.pushObject({ text: 'Globe' });
+ this.removeAt(1);
+ this.insertAt(1, { text: ' ' });
+ this.pushObject({ text: ' ' });
+ this.pushObject({ text: 'World' });
+ this.removeAt(2);
});
this.assertText('Hello Planet EarthGlobe World');
- this.runTask(() => list.replace(2, 4, { text: 'my' }));
+ this.runTask(() => this.replace(2, 4, { text: 'my' }));
this.assertText('Hello my World');
- this.runTask(() => list.clear());
+ this.runTask(() => this.clear());
this.assertText('Empty');
@@ -223,15 +271,15 @@ class SingleEachTest extends AbstractEachTest {
}
['@test it receives the index as the second parameter']() {
- let list = this.makeList([{ text: 'hello' }, { text: 'world' }]);
+ this.makeList([{ text: 'hello' }, { text: 'world' }]);
this.render(`{{#each list as |item index|}}[{{index}}. {{item.text}}]{{/each}}`);
this.assertText('[0. hello][1. world]');
this.assertStableRerender();
- this.runTask(() => list.insertAt(1, { text: 'my' }));
+ this.runTask(() => this.insertAt(1, { text: 'my' }));
this.assertText('[0. hello][1. my][2. world]');
@@ -241,15 +289,15 @@ class SingleEachTest extends AbstractEachTest {
}
['@test it accepts a string key']() {
- let list = this.makeList([{ text: 'hello' }, { text: 'world' }]);
+ this.makeList([{ text: 'hello' }, { text: 'world' }]);
this.render(`{{#each list key='text' as |item|}}{{item.text}}{{/each}}`);
this.assertText('helloworld');
this.assertStableRerender();
- this.runTask(() => list.pushObject({ text: 'again' }));
+ this.runTask(() => this.pushObject({ text: 'again' }));
this.assertText('helloworldagain');
@@ -259,15 +307,15 @@ class SingleEachTest extends AbstractEachTest {
}
['@test it accepts a numeric key']() {
- let list = this.makeList([{ id: 1 }, { id: 2 }]);
+ this.makeList([{ id: 1 }, { id: 2 }]);
this.render(`{{#each list key='id' as |item|}}{{item.id}}{{/each}}`);
this.assertText('12');
this.assertStableRerender();
- this.runTask(() => list.pushObject({ id: 3 }));
+ this.runTask(() => this.pushObject({ id: 3 }));
this.assertText('123');
@@ -277,15 +325,15 @@ class SingleEachTest extends AbstractEachTest {
}
['@test it can specify @index as the key']() {
- let list = this.makeList([{ id: 1 }, { id: 2 }]);
+ this.makeList([{ id: 1 }, { id: 2 }]);
this.render(`{{#each list key='@index' as |item|}}{{item.id}}{{/each}}`);
this.assertText('12');
this.assertStableRerender();
- this.runTask(() => list.pushObject({ id: 3 }));
+ this.runTask(() => this.pushObject({ id: 3 }));
this.assertText('123');
@@ -295,15 +343,15 @@ class SingleEachTest extends AbstractEachTest {
}
['@test it can specify @identity as the key for arrays of primitives']() {
- let list = this.makeList([1, 2]);
+ this.makeList([1, 2]);
this.render(`{{#each list key='@identity' as |item|}}{{item}}{{/each}}`);
this.assertText('12');
this.assertStableRerender();
- this.runTask(() => list.pushObject(3));
+ this.runTask(() => this.pushObject(3));
this.assertText('123');
@@ -313,15 +361,15 @@ class SingleEachTest extends AbstractEachTest {
}
['@test it can specify @identity as the key for mixed arrays of objects and primitives']() {
- let list = this.makeList([1, { id: 2 }, 3]);
+ this.makeList([1, { id: 2 }, 3]);
this.render(`{{#each list key='@identity' as |item|}}{{if item.id item.id item}}{{/each}}`);
this.assertText('123');
this.assertStableRerender();
- this.runTask(() => list.insertAt(2, { id: 4 }));
+ this.runTask(() => this.insertAt(2, { id: 4 }));
this.assertText('1243');
@@ -331,19 +379,19 @@ class SingleEachTest extends AbstractEachTest {
}
['@test it can render duplicate primitive items']() {
- let list = this.makeList(['a', 'a', 'a']);
+ this.makeList(['a', 'a', 'a']);
this.render(`{{#each list as |item|}}{{item}}{{/each}}`);
this.assertText('aaa');
this.assertStableRerender();
- this.runTask(() => list.pushObject('a'));
+ this.runTask(() => this.pushObject('a'));
this.assertText('aaaa');
- this.runTask(() => list.pushObject('a'));
+ this.runTask(() => this.pushObject('a'));
this.assertText('aaaaa');
@@ -355,19 +403,19 @@ class SingleEachTest extends AbstractEachTest {
['@test it can render duplicate objects']() {
let duplicateItem = { text: 'foo' };
- let list = this.makeList([duplicateItem, duplicateItem, { text: 'bar' }, { text: 'baz' }]);
+ this.makeList([duplicateItem, duplicateItem, { text: 'bar' }, { text: 'baz' }]);
this.render(`{{#each list as |item|}}{{item.text}}{{/each}}`);
this.assertText('foofoobarbaz');
this.assertStableRerender();
- this.runTask(() => list.pushObject(duplicateItem));
+ this.runTask(() => this.pushObject(duplicateItem));
this.assertText('foofoobarbazfoo');
- this.runTask(() => list.pushObject(duplicateItem));
+ this.runTask(() => this.pushObject(duplicateItem));
this.assertText('foofoobarbazfoofoo');
@@ -377,7 +425,7 @@ class SingleEachTest extends AbstractEachTest {
}
[`@test it maintains DOM stability when condition changes between objects with the same keys`]() {
- let list = this.makeList([{ text: 'Hello' }, { text: ' ' }, { text: 'world' }]);
+ this.makeList([{ text: 'Hello' }, { text: ' ' }, { text: 'world' }]);
this.render(`{{#each list key="text" as |item|}}{{item.text}}{{/each}}`);
@@ -386,10 +434,10 @@ class SingleEachTest extends AbstractEachTest {
this.takeSnapshot();
this.runTask(() => {
- list.popObject();
- list.popObject();
- list.pushObject({ text: ' ' });
- list.pushObject({ text: 'world' });
+ this.popObject();
+ this.popObject();
+ this.pushObject({ text: ' ' });
+ this.pushObject({ text: 'world' });
});
this.assertText('Hello world');
@@ -404,21 +452,21 @@ class SingleEachTest extends AbstractEachTest {
}
[`@test it maintains DOM stability for stable keys when list is updated`]() {
- let list = this.makeList([{ text: 'Hello' }, { text: ' ' }, { text: 'world' }]);
+ this.makeList([{ text: 'Hello' }, { text: ' ' }, { text: 'world' }]);
this.render(`{{#each list key="text" as |item|}}{{item.text}}{{/each}}`);
this.assertText('Hello world');
this.assertStableRerender();
- let oldSnapshot = this.snapshot;
+ let oldSnapshot = this.takeSnapshot();
this.runTask(() => {
- list.unshiftObject({ text: ', ' });
- list.unshiftObject({ text: 'Hi' });
- list.pushObject({ text: '!' });
- list.pushObject({ text: 'earth' });
+ this.unshiftObject({ text: ', ' });
+ this.unshiftObject({ text: 'Hi' });
+ this.pushObject({ text: '!' });
+ this.pushObject({ text: 'earth' });
});
this.assertText('Hi, Hello world!earth');
@@ -433,14 +481,14 @@ class SingleEachTest extends AbstractEachTest {
}
[`@test it renders all items with duplicate key values`]() {
- let list = this.makeList([{ text: 'Hello' }, { text: 'Hello' }, { text: 'Hello' }]);
+ this.makeList([{ text: 'Hello' }, { text: 'Hello' }, { text: 'Hello' }]);
this.render(`{{#each list key="text" as |item|}}{{item.text}}{{/each}}`);
this.assertText('HelloHelloHello');
this.runTask(() => {
- list.forEach(hash => set(hash, 'text', 'Goodbye'));
+ this.forEach(hash => set(hash, 'text', 'Goodbye'));
});
this.assertText('GoodbyeGoodbyeGoodbye');
@@ -451,7 +499,7 @@ class SingleEachTest extends AbstractEachTest {
}
['@test context is not changed to the inner scope inside an {{#each as}} block']() {
- let list = this.makeList([{ name: 'Chad' }, { name: 'Zack' }, { name: 'Asa' }]);
+ this.makeList([{ name: 'Chad' }, { name: 'Zack' }, { name: 'Asa' }]);
this.render(`{{name}}-{{#each list as |person|}}{{name}}{{/each}}-{{name}}`, {
name: 'Joel'
@@ -461,7 +509,7 @@ class SingleEachTest extends AbstractEachTest {
this.assertStableRerender();
- this.runTask(() => list.shiftObject());
+ this.runTask(() => this.shiftObject());
this.assertText('Joel-JoelJoel-Joel');
@@ -476,7 +524,7 @@ class SingleEachTest extends AbstractEachTest {
}
['@test can access the item and the original scope']() {
- let list = this.makeList([{ name: 'Tom Dale' }, { name: 'Yehuda Katz' }, { name: 'Godfrey Chan' }]);
+ this.makeList([{ name: 'Tom Dale' }, { name: 'Yehuda Katz' }, { name: 'Godfrey Chan' }]);
this.render(`{{#each list key="name" as |person|}}[{{title}}: {{person.name}}]{{/each}}`, {
title: 'Señor Engineer'
@@ -489,10 +537,10 @@ class SingleEachTest extends AbstractEachTest {
this.assertText('[Señor Engineer: Tom Dale][Señor Engineer: Yehuda Katz][Señor Engineer: Godfrey Chan]');
this.runTask(() => {
- set(list.objectAt(1), 'name', 'Stefan Penner');
- list.removeAt(0);
- list.pushObject({ name: 'Tom Dale' });
- list.insertAt(1, { name: 'Chad Hietala' });
+ set(this.objectAt(1), 'name', 'Stefan Penner');
+ this.removeAt(0);
+ this.pushObject({ name: 'Tom Dale' });
+ this.insertAt(1, { name: 'Chad Hietala' });
set(this.context, 'title', 'Principal Engineer');
});
@@ -505,7 +553,7 @@ class SingleEachTest extends AbstractEachTest {
}
['@test the scoped variable is not available outside the {{#each}} block.']() {
- let list = this.makeList(['Yehuda']);
+ this.makeList(['Yehuda']);
this.render(`{{name}}-{{#each list as |name|}}{{name}}{{/each}}-{{name}}`, {
name: 'Stef'
@@ -517,7 +565,7 @@ class SingleEachTest extends AbstractEachTest {
this.assertText('Stef-Yehuda-Stef');
- this.runTask(() => list.pushObjects([' ', 'Katz']));
+ this.runTask(() => this.pushObjects([' ', 'Katz']));
this.assertText('Stef-Yehuda Katz-Stef');
@@ -532,7 +580,7 @@ class SingleEachTest extends AbstractEachTest {
}
['@test inverse template is displayed with context']() {
- let list = this.makeList([]);
+ this.makeList([]);
this.render(`{{#each list as |thing|}}Has Thing{{else}}No Thing {{otherThing}}{{/each}}`, {
otherThing: 'bar'
@@ -548,7 +596,7 @@ class SingleEachTest extends AbstractEachTest {
this.assertText('No Thing biz');
- this.runTask(() => list.pushObject('non-empty'));
+ this.runTask(() => this.pushObject('non-empty'));
this.assertText('Has Thing');
@@ -567,31 +615,32 @@ class SingleEachTest extends AbstractEachTest {
moduleFor('Syntax test: {{#each}} with arrays', class extends SingleEachTest {
makeList(list) {
- return this.list = emberA(list);
+ return this.list = this.delegate = emberA(list);
}
});
moduleFor('Syntax test: {{#each}} with array-like objects', class extends SingleEachTest {
makeList(list) {
- return this.list = new ArrayLike(list);
+ return this.list = this.delegate = new ArrayLike(list);
}
});
-moduleFor('Syntax test: {{#each}} with array proxies, replacing itself', class extends SingleEachTest {
+moduleFor('Syntax test: {{#each}} with array proxies, modifying itself', class extends SingleEachTest {
makeList(list) {
- return this.list = ArrayProxy.create({ content: emberA(list) });
+ return this.list = this.delegate = ArrayProxy.create({ content: emberA(list) });
}
});
moduleFor('Syntax test: {{#each}} with array proxies, replacing its content', class extends SingleEachTest {
makeList(list) {
- return this.list = ArrayProxy.create({ content: emberA(list) });
+ let content = this.delegate = emberA(list);
+ return this.list = ArrayProxy.create({ content });
}
replaceList(list) { | false |
Other | emberjs | ember.js | a6f3fc4fbbe4371820f66a7c952822aa2e784e60.json | Unify Glimmer and HTMLBars `{{#each}}` tests | packages/ember-glimmer/tests/integration/syntax/each-test.js | @@ -68,59 +68,64 @@ class ArrayLike {
// The following methods are APIs used by the tests
- clear() {
- this._array.length = 0;
- propertyDidChange(this, 'length');
- }
-
objectAt(idx) {
return this._array[idx];
}
+ clear() {
+ this._array.length = 0;
+ this.arrayContentDidChange();
+ }
+
replace(idx, del, ins) {
this._array.splice(idx, del, ...ins);
- propertyDidChange(this, 'length');
+ this.arrayContentDidChange();
}
unshiftObject(obj) {
this._array.unshift(obj);
- propertyDidChange(this, 'length');
+ this.arrayContentDidChange();
}
unshiftObjects(arr) {
this._array.unshift(...arr);
- propertyDidChange(this, 'length');
+ this.arrayContentDidChange();
}
pushObject(obj) {
this._array.push(obj);
- propertyDidChange(this, 'length');
+ this.arrayContentDidChange();
}
pushObjects(arr) {
this._array.push(...arr);
- propertyDidChange(this, 'length');
+ this.arrayContentDidChange();
}
shiftObject() {
let obj = this._array.shift();
- propertyDidChange(this, 'length');
+ this.arrayContentDidChange();
return obj;
}
popObject() {
let obj = this._array.pop();
- propertyDidChange(this, 'length');
+ this.arrayContentDidChange();
return obj;
}
insertAt(idx, obj) {
this._array.splice(idx, 0, obj);
- propertyDidChange(this, 'length');
+ this.arrayContentDidChange();
}
removeAt(idx, len = 1) {
this._array.splice(idx, len);
+ this.arrayContentDidChange();
+ }
+
+ arrayContentDidChange() {
+ propertyDidChange(this, '[]');
propertyDidChange(this, 'length');
}
@@ -573,18 +578,6 @@ moduleFor('Syntax test: {{#each}} with array-like objects', class extends Single
return this.list = new ArrayLike(list);
}
- runTask(taskFunc) {
- // This feature requires manual re-render in HTMLBars
- if (this.isGlimmer) {
- return super.runTask(taskFunc);
- } else {
- return super.runTask(() => {
- taskFunc();
- this.rerender();
- });
- }
- }
-
});
moduleFor('Syntax test: {{#each}} with array proxies, replacing itself', class extends SingleEachTest { | false |
Other | emberjs | ember.js | 868e29c9840592a81f8a67e32262fe28976d762e.json | Add v2.8.0-beta.2 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 7b5186c1c952e480a2712c2f91611f5db9fc0647) | CHANGELOG.md | @@ -1,5 +1,14 @@
# Ember Changelog
+### 2.8.0-beta.2 (August 1, 2016)
+
+- [#13887](https://github.com/emberjs/ember.js/pull/13887) [BUGFIX] Add assertions for illegal component invocations.
+- [#13892](https://github.com/emberjs/ember.js/pull/13892) [CLEANUP] Remove `View#createElement` / `View#destroyElement`.
+- [#13895](https://github.com/emberjs/ember.js/pull/13895) [BUGFIX] Fix template meta lookup for nested tagless and blockless components.
+- [#13911](https://github.com/emberjs/ember.js/pull/13911) [BUGFIX] Avoid using clobbering `.env` property on components.
+- [#13913](https://github.com/emberjs/ember.js/pull/13913) [BUGFIX] Disallow paths beginning with @ in templates.
+- [#13920](https://github.com/emberjs/ember.js/pull/13920) [BUGFIX] Add more info to the `Ember.Binding` deprecation.
+
### 2.8.0-beta.1 (July 25, 2016)
- [#13757](https://github.com/emberjs/ember.js/pull/13757) / [#13773](https://github.com/emberjs/ember.js/pull/13773) [CLEANUP] Remove legacy view layer features. | false |
Other | emberjs | ember.js | 5d2a0ffe1a01ded944c64915d0b499fb2408999e.json | Fix version number for alpha. | ember-cli-build.js | @@ -6,9 +6,11 @@
// DISABLE_ES3=true DISABLE_JSCS=true DISABLE_JSHINT=true DISABLE_MIN=true DISABLE_DEREQUIRE=true ember serve --environment=production
var fs = require('fs');
+var path = require('path');
var EmberBuild = require('emberjs-build');
var getPackages = require('./lib/packages');
+var getGitInfo = require('git-repo-info');
var applyFeatureFlags = require('babel-plugin-feature-flags');
var filterImports = require('babel-plugin-filter-imports');
@@ -86,8 +88,23 @@ function addGlimmerPackage(vendoredPackages, name) {
vendoredPackages[name] = find(glimmerEngine, 'named-amd/' + name + '/**/*.js');
}
+function getVersion() {
+ var projectPath = process.cwd();
+ var info = getGitInfo(projectPath);
+ if (info.tag) {
+ return info.tag;
+ }
+
+ var packageVersion = require(path.join(projectPath, 'package.json')).version;
+ var sha = info.sha || '';
+ var prefix = packageVersion + '-' + (process.env.BUILD_TYPE || info.branch);
+
+ return prefix + '+' + sha.slice(0, 8);
+}
+
module.exports = function() {
var features = getFeatures();
+ var version = getVersion();
var vendorPackages = {
'loader': vendoredPackage('loader'),
@@ -131,7 +148,8 @@ module.exports = function() {
},
htmlbars: require('htmlbars'),
packages: getPackages(features),
- vendoredPackages: vendorPackages
+ vendoredPackages: vendorPackages,
+ version: version
});
return emberBuild.getDistTrees(); | true |
Other | emberjs | ember.js | 5d2a0ffe1a01ded944c64915d0b499fb2408999e.json | Fix version number for alpha. | package.json | @@ -1,7 +1,7 @@
{
"name": "ember",
"license": "MIT",
- "version": "2.9.0-canary",
+ "version": "2.9.0",
"keywords": [
"ember-addon"
],
@@ -33,9 +33,11 @@
"ember-cli-sauce": "^1.4.2",
"ember-cli-yuidoc": "0.8.4",
"ember-publisher": "0.0.7",
- "emberjs-build": "0.12.1",
+ "emberjs-build": "0.13.2",
"express": "^4.5.0",
"finalhandler": "^0.4.0",
+ "git-repo-info": "^1.1.4",
+ "git-repo-version": "^0.3.1",
"github": "^0.2.3",
"glimmer-engine": "tildeio/glimmer#8f4bb56",
"glob": "^5.0.13", | true |
Other | emberjs | ember.js | 3ce73bb00126f20edb7f5cb9ceb6f1a69ae758bb.json | Fix Glimmer builds
Both template compilers seem to need backburner, hoisting it up. | lib/packages.js | @@ -15,7 +15,7 @@ module.exports = function(features) {
trees: null,
templateCompilerOnly: true,
requirements: ['ember-metal', 'ember-environment', 'ember-console', 'ember-templates'],
- templateCompilerVendor: ['simple-html-tokenizer']
+ templateCompilerVendor: ['simple-html-tokenizer', 'backburner']
},
'ember-templates': { trees: null, requirements: ['ember-metal', 'ember-environment'] },
'ember-routing': { trees: null, vendorRequirements: ['router', 'route-recognizer'],
@@ -80,7 +80,7 @@ module.exports = function(features) {
templateCompilerOnly: true,
requirements: [],
vendorRequirements: ['htmlbars-runtime'],
- templateCompilerVendor: ['htmlbars-runtime', 'htmlbars-util', 'htmlbars-compiler', 'htmlbars-syntax', 'htmlbars-test-helpers', 'morph-range', 'backburner']
+ templateCompilerVendor: ['htmlbars-runtime', 'htmlbars-util', 'htmlbars-compiler', 'htmlbars-syntax', 'htmlbars-test-helpers', 'morph-range']
};
packages['ember-htmlbars'] = { | false |
Other | emberjs | ember.js | ed6ed9ebb070de6e689ac415d46496a0accb9aee.json | Add tests for nested `classNameBindings` paths | packages/ember-glimmer/tests/integration/components/class-bindings-test.js | @@ -45,6 +45,92 @@ moduleFor('ClassNameBindings integration', class extends RenderingTest {
this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view foo enabled sad') }, content: 'hello' });
}
+ ['@test it can have class name bindings with nested paths']() {
+ let FooBarComponent = Component.extend({
+ classNameBindings: ['foo.bar', 'is.enabled:enabled', 'is.happy:happy:sad']
+ });
+
+ this.registerComponent('foo-bar', { ComponentClass: FooBarComponent, template: 'hello' });
+
+ this.render('{{foo-bar foo=foo is=is}}', { foo: { bar: 'foo-bar' }, is: { enabled: true, happy: false } });
+
+ this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view foo-bar enabled sad') }, content: 'hello' });
+
+ this.runTask(() => this.rerender());
+
+ this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view foo-bar enabled sad') }, content: 'hello' });
+
+ this.runTask(() => {
+ set(this.context, 'foo.bar', 'FOO-BAR');
+ set(this.context, 'is.enabled', false);
+ });
+
+ this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view FOO-BAR sad') }, content: 'hello' });
+
+ this.runTask(() => {
+ set(this.context, 'foo.bar', null);
+ set(this.context, 'is.happy', true);
+ });
+
+ this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view happy') }, content: 'hello' });
+
+ this.runTask(() => {
+ set(this.context, 'foo', null);
+ set(this.context, 'is', null);
+ });
+
+ this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view sad') }, content: 'hello' });
+
+
+ this.runTask(() => {
+ set(this.context, 'foo', { bar: 'foo-bar' });
+ set(this.context, 'is', { enabled: true, happy: false });
+ });
+
+ this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view foo-bar enabled sad') }, content: 'hello' });
+ }
+
+ ['@test it should dasherize the path when the it resolves to true']() {
+ let FooBarComponent = Component.extend({
+ classNameBindings: ['fooBar', 'nested.fooBarBaz']
+ });
+
+ this.registerComponent('foo-bar', { ComponentClass: FooBarComponent, template: 'hello' });
+
+ this.render('{{foo-bar fooBar=fooBar nested=nested}}', { fooBar: true, nested: { fooBarBaz: false } });
+
+ this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view foo-bar') }, content: 'hello' });
+
+ this.runTask(() => this.rerender());
+
+ this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view foo-bar') }, content: 'hello' });
+
+ this.runTask(() => {
+ set(this.context, 'fooBar', false);
+ set(this.context, 'nested.fooBarBaz', true);
+ });
+
+ this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view foo-bar-baz') }, content: 'hello' });
+
+ this.runTask(() => {
+ set(this.context, 'fooBar', 'FOO-BAR');
+ set(this.context, 'nested.fooBarBaz', null);
+ });
+
+ this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view FOO-BAR') }, content: 'hello' });
+
+ this.runTask(() => set(this.context, 'nested', null));
+
+ this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view FOO-BAR') }, content: 'hello' });
+
+ this.runTask(() => {
+ set(this.context, 'fooBar', true);
+ set(this.context, 'nested', { fooBarBaz: false });
+ });
+
+ this.assertComponentElement(this.firstChild, { tagName: 'div', attrs: { 'class': classes('ember-view foo-bar') }, content: 'hello' });
+ }
+
['@test const bindings can be set as attrs']() {
this.registerComponent('foo-bar', { template: 'hello' });
this.render('{{foo-bar classNameBindings="foo:enabled:disabled"}}', { | false |
Other | emberjs | ember.js | 5327eb0f699761c33341487d46334b56bbc4b57a.json | Remove `View#destroyElement` method. | packages/ember-views/lib/mixins/view_support.js | @@ -325,30 +325,6 @@ export default Mixin.create({
*/
willClearRender: K,
- /**
- Destroys any existing element along with the element for any child views
- as well. If the view does not currently have a element, then this method
- will do nothing.
-
- If you implement `willDestroyElement()` on your view, then this method will
- be invoked on your view before your element is destroyed to give you a
- chance to clean up any event handlers, etc.
-
- If you write a `willDestroyElement()` handler, you can assume that your
- `didInsertElement()` handler was called earlier for the same element.
-
- You should not call or override this method yourself, but you may
- want to implement the above callbacks.
-
- @method destroyElement
- @return {Ember.View} receiver
- @private
- */
- destroyElement() {
- this._currentState.destroyElement(this);
- return this;
- },
-
/**
You must call `destroy` on a view to destroy the view (and all of its
child views). This will remove the view from any parent node, then make | true |
Other | emberjs | ember.js | 5327eb0f699761c33341487d46334b56bbc4b57a.json | Remove `View#destroyElement` method. | packages/ember-views/lib/views/states/default.js | @@ -38,8 +38,6 @@ export default {
return true; // continue event propagation
},
- destroyElement() { },
-
destroy() { },
rerender(view) { | true |
Other | emberjs | ember.js | 5327eb0f699761c33341487d46334b56bbc4b57a.json | Remove `View#destroyElement` method. | packages/ember-views/lib/views/states/destroying.js | @@ -14,9 +14,6 @@ assign(destroying, {
},
rerender() {
throw new EmberError('You can\'t call rerender on a view being destroyed');
- },
- destroyElement() {
- throw new EmberError('You can\'t call destroyElement on a view being destroyed');
}
});
| true |
Other | emberjs | ember.js | 5327eb0f699761c33341487d46334b56bbc4b57a.json | Remove `View#destroyElement` method. | packages/ember-views/lib/views/states/has_element.js | @@ -33,10 +33,6 @@ assign(hasElement, {
view.renderer.rerender(view);
},
- destroyElement(view) {
- view.renderer.remove(view, false);
- },
-
destroy(view) {
view.renderer.remove(view, true);
}, | true |
Other | emberjs | ember.js | 5327eb0f699761c33341487d46334b56bbc4b57a.json | Remove `View#destroyElement` method. | packages/ember-views/tests/views/view/append_to_test.js | @@ -88,28 +88,6 @@ QUnit.test('raises an assert when a target does not exist in the DOM', function(
});
-QUnit.test('remove removes an element from the DOM', function() {
- willDestroyCalled = 0;
-
- view = View.create({
- willDestroyElement() {
- willDestroyCalled++;
- }
- });
-
- ok(!get(view, 'element'), 'precond - should not have an element');
-
- run(() => view.append());
-
- ok(jQuery('#' + get(view, 'elementId')).length === 1, 'precond - element was inserted');
-
- run(() => view.destroyElement());
-
- ok(jQuery('#' + get(view, 'elementId')).length === 0, 'remove removes an element from the DOM');
- ok(!get(view, 'element'), 'remove nulls out the element');
- equal(willDestroyCalled, 1, 'the willDestroyElement hook was called once');
-});
-
QUnit.test('destroy more forcibly removes the view', function() {
willDestroyCalled = 0;
| true |
Other | emberjs | ember.js | 5327eb0f699761c33341487d46334b56bbc4b57a.json | Remove `View#destroyElement` method. | packages/ember-views/tests/views/view/destroy_element_test.js | @@ -1,51 +0,0 @@
-import { get } from 'ember-metal/property_get';
-import run from 'ember-metal/run_loop';
-import EmberView from 'ember-views/views/view';
-
-let view;
-
-QUnit.module('EmberView#destroyElement', {
- teardown() {
- run(() => view.destroy());
- }
-});
-
-QUnit.test('if it has no element, does nothing', function() {
- let callCount = 0;
- view = EmberView.create({
- willDestroyElement() { callCount++; }
- });
-
- ok(!get(view, 'element'), 'precond - does NOT have element');
-
- run(() => view.destroyElement());
-
- equal(callCount, 0, 'did not invoke callback');
-});
-
-QUnit.test('returns receiver', function() {
- let ret;
- view = EmberView.create();
-
- run(() => {
- view.createElement();
- ret = view.destroyElement();
- });
-
- equal(ret, view, 'returns receiver');
-});
-
-QUnit.test('removes element from parentNode if in DOM', function() {
- view = EmberView.create();
-
- run(() => view.append());
-
- let parent = view.$().parent();
-
- ok(get(view, 'element'), 'precond - has element');
-
- run(() => view.destroyElement());
-
- equal(view.$(), undefined, 'view has no selector');
- ok(!parent.find('#' + view.get('elementId')).length, 'element no longer in parent node');
-}); | true |
Other | emberjs | ember.js | 14eb40ce1d55faa282f3da90dbdcd227fd16db88.json | Add 2.8.0-beta.1 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 1234110eeaca1ef479eb3510897b978b1b0bcc2a) | CHANGELOG.md | @@ -1,5 +1,14 @@
# Ember Changelog
+### 2.8.0-beta.1 (July 25, 2016)
+
+- [#13757](https://github.com/emberjs/ember.js/pull/13757) / [#13773](https://github.com/emberjs/ember.js/pull/13773) [CLEANUP] Remove legacy view layer features.
+- [#13819](https://github.com/emberjs/ember.js/pull/13819) [DOC] Add documentation for container (getOwner, etc.)
+- [#13855](https://github.com/emberjs/ember.js/pull/13855) [FEATURE ember-string-ishtmlsafe] Enable by defaut.
+- [#13855](https://github.com/emberjs/ember.js/pull/13855) [FEATURE ember-application-engines] Enable by default.
+- [#13855](https://github.com/emberjs/ember.js/pull/13855) [FEATURE ember-runtime-enumerable-includes] Enable by default.
+- [#13855](https://github.com/emberjs/ember.js/pull/13855) [FEATURE ember-testing-check-waiters] Enable by default.
+
### 2.7.0 (July 25, 2016)
- [#13764](https://github.com/emberjs/ember.js/pull/13764) [BUGFIX] Keep rest positional parameters when nesting contextual components if needed. | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.