language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-runtime/lib/computed/reduce_computed.js | @@ -2,7 +2,8 @@ import Ember from 'ember-metal/core'; // Ember.assert
import { get as e_get } from 'ember-metal/property_get';
import {
guidFor,
- meta as metaFor
+ meta as metaFor,
+ isArray
} from 'ember-metal/utils';
import EmberError from 'ember-metal/error';
import {
@@ -25,7 +26,6 @@ import { forEach } from 'ember-metal/enumerable_utils';
import TrackedArray from 'ember-runtime/system/tracked_array';
import EmberArray from 'ember-runtime/mixins/array';
import run from 'ember-metal/run_loop';
-import { isArray } from 'ember-metal/utils';
var cacheSet = cacheFor.set;
var cacheGet = cacheFor.get; | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-runtime/lib/mixins/copyable.js | @@ -5,9 +5,8 @@
import { get } from "ember-metal/property_get";
-import { required } from "ember-metal/mixin";
+import { required, Mixin } from "ember-metal/mixin";
import { Freezable } from "ember-runtime/mixins/freezable";
-import { Mixin } from 'ember-metal/mixin';
import { fmt } from "ember-runtime/system/string";
import EmberError from 'ember-metal/error';
| true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-runtime/lib/mixins/sortable.js | @@ -7,7 +7,6 @@ import Ember from "ember-metal/core"; // Ember.assert, Ember.A
import { get } from "ember-metal/property_get";
import { forEach } from "ember-metal/enumerable_utils";
-import { Mixin } from "ember-metal/mixin";
import MutableEnumerable from "ember-runtime/mixins/mutable_enumerable";
import compare from "ember-runtime/compare";
import {
@@ -16,6 +15,7 @@ import {
} from "ember-metal/observer";
import { computed } from "ember-metal/computed";
import {
+ Mixin,
beforeObserver,
observer
} from "ember-metal/mixin"; //ES6TODO: should we access these directly from their package or from how their exposed in ember-metal? | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-runtime/lib/system/each_proxy.js | @@ -6,7 +6,10 @@
import Ember from "ember-metal/core"; // Ember.assert
import { get } from "ember-metal/property_get";
-import { guidFor } from "ember-metal/utils";
+import {
+ guidFor,
+ typeOf
+} from "ember-metal/utils";
import { forEach } from "ember-metal/enumerable_utils";
import { indexOf } from "ember-metal/array";
import EmberArray from "ember-runtime/mixins/array"; // ES6TODO: WAT? Circular dep?
@@ -18,7 +21,6 @@ import {
removeBeforeObserver,
removeObserver
} from "ember-metal/observer";
-import { typeOf } from "ember-metal/utils";
import { watchedEvents } from "ember-metal/events";
import { defineProperty } from "ember-metal/properties";
import { | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-views/lib/main.js | @@ -39,8 +39,10 @@ import TextField from "ember-views/views/text_field";
import TextArea from "ember-views/views/text_area";
import SimpleBoundView from "ember-views/views/simple_bound_view";
-import _MetamorphView from "ember-views/views/metamorph_view";
-import { _Metamorph } from "ember-views/views/metamorph_view";
+import {
+ default as _MetamorphView,
+ _Metamorph
+} from "ember-views/views/metamorph_view";
import {
Select,
SelectOption, | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-views/lib/views/bound_partial_view.js | @@ -3,7 +3,6 @@
@submodule ember-views
*/
-import run from 'ember-metal/run_loop';
import _MetamorphView from "ember-views/views/metamorph_view";
import NormalizedRerenderIfNeededSupport from "ember-views/mixins/normalized_rerender_if_needed";
import lookupPartial from "ember-views/system/lookup_partial"; | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-views/lib/views/each.js | @@ -15,8 +15,10 @@ import {
removeBeforeObserver
} from "ember-metal/observer";
-import _MetamorphView from "ember-views/views/metamorph_view";
-import { _Metamorph } from "ember-views/views/metamorph_view";
+import {
+ default as _MetamorphView,
+ _Metamorph
+} from "ember-views/views/metamorph_view";
export default CollectionView.extend(_Metamorph, {
| true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-views/lib/views/select.js | @@ -7,7 +7,8 @@ import {
forEach,
indexOf,
indexesOf,
- replace
+ replace,
+ map
} from "ember-metal/enumerable_utils";
import { get } from "ember-metal/property_get";
@@ -21,7 +22,6 @@ import { A as emberA } from "ember-runtime/system/native_array";
import { observer } from "ember-metal/mixin";
import { defineProperty } from "ember-metal/properties";
import run from "ember-metal/run_loop";
-import { map } from "ember-metal/enumerable_utils";
import htmlbarsTemplate from "ember-htmlbars/templates/select";
| true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-views/lib/views/view.js | @@ -14,17 +14,22 @@ import setProperties from "ember-metal/set_properties";
import run from "ember-metal/run_loop";
import { addObserver, removeObserver } from "ember-metal/observer";
import { defineProperty } from "ember-metal/properties";
-import { guidFor } from "ember-metal/utils";
+import {
+ guidFor,
+ typeOf
+} from "ember-metal/utils";
import { computed } from "ember-metal/computed";
-import { observer } from "ember-metal/mixin";
+import {
+ Mixin,
+ observer,
+ beforeObserver
+} from "ember-metal/mixin";
import SimpleStream from "ember-metal/streams/simple";
import KeyStream from "ember-views/streams/key_stream";
import StreamBinding from "ember-metal/streams/stream_binding";
import ContextStream from "ember-views/streams/context_stream";
-import { typeOf } from "ember-metal/utils";
import isNone from 'ember-metal/is_none';
-import { Mixin } from 'ember-metal/mixin';
import { deprecateProperty } from "ember-metal/deprecate_property";
import { A as emberA } from "ember-runtime/system/native_array";
@@ -39,8 +44,6 @@ import {
removeObject
} from "ember-metal/enumerable_utils";
-import { beforeObserver } from "ember-metal/mixin";
-
import {
propertyWillChange,
propertyDidChange | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-views/lib/views/with_view.js | @@ -4,7 +4,6 @@
*/
import { set } from "ember-metal/property_set";
-import run from 'ember-metal/run_loop';
import _MetamorphView from "ember-views/views/metamorph_view";
import NormalizedRerenderIfNeededSupport from "ember-views/mixins/normalized_rerender_if_needed";
import run from 'ember-metal/run_loop'; | true |
Other | emberjs | ember.js | 80fcde8763928b73a4d7bea8c5f56889a6efec10.json | Support basic Node.js rendering
This commit makes some small cleanup changes across the framework that
ensure that views’ renderers are consistently inherited from their
parents (so that, e.g., if you render a view using a Node renderer, all
subviews will use that same renderer).
It also changes one instance where DOM was being relied upon rather than
using the DOMHelper abstraction.
It also includes a small suite of tests that manually patch views to use
the Node SSR renderer, verifying that compiled HTMLbars templates render
correctly. | package.json | @@ -23,6 +23,7 @@
"htmlbars": "0.8.1",
"qunit-extras": "^1.3.0",
"qunitjs": "^1.16.0",
- "rsvp": "~3.0.6"
+ "rsvp": "~3.0.6",
+ "simple-dom": "^0.1.1"
}
} | true |
Other | emberjs | ember.js | 80fcde8763928b73a4d7bea8c5f56889a6efec10.json | Support basic Node.js rendering
This commit makes some small cleanup changes across the framework that
ensure that views’ renderers are consistently inherited from their
parents (so that, e.g., if you render a view using a Node renderer, all
subviews will use that same renderer).
It also changes one instance where DOM was being relied upon rather than
using the DOMHelper abstraction.
It also includes a small suite of tests that manually patch views to use
the Node SSR renderer, verifying that compiled HTMLbars templates render
correctly. | packages/ember-views/lib/main.js | @@ -16,6 +16,8 @@ import {
getViewBoundingClientRect
} from "ember-views/system/utils";
import RenderBuffer from "ember-views/system/render_buffer";
+import Renderer from "ember-views/system/renderer";
+import { DOMHelper } from "morph";
import "ember-views/system/ext"; // for the side effect of extending Ember.run.queues
import {
cloneStates,
@@ -68,6 +70,8 @@ Ember.CoreView = CoreView;
Ember.View = View;
Ember.View.states = states;
Ember.View.cloneStates = cloneStates;
+Ember.View.DOMHelper = DOMHelper;
+Ember.View._Renderer = Renderer;
Ember.Checkbox = Checkbox;
Ember.TextField = TextField;
Ember.TextArea = TextArea; | true |
Other | emberjs | ember.js | 80fcde8763928b73a4d7bea8c5f56889a6efec10.json | Support basic Node.js rendering
This commit makes some small cleanup changes across the framework that
ensure that views’ renderers are consistently inherited from their
parents (so that, e.g., if you render a view using a Node renderer, all
subviews will use that same renderer).
It also changes one instance where DOM was being relied upon rather than
using the DOMHelper abstraction.
It also includes a small suite of tests that manually patch views to use
the Node SSR renderer, verifying that compiled HTMLbars templates render
correctly. | packages/ember-views/lib/system/render_buffer.js | @@ -520,7 +520,7 @@ RenderBuffer.prototype = {
this.dom.detectNamespace(contextualElement);
if (!this._element) {
- this._element = document.createDocumentFragment();
+ this._element = this.dom.createDocumentFragment();
}
if (content.nodeType) { | true |
Other | emberjs | ember.js | 80fcde8763928b73a4d7bea8c5f56889a6efec10.json | Support basic Node.js rendering
This commit makes some small cleanup changes across the framework that
ensure that views’ renderers are consistently inherited from their
parents (so that, e.g., if you render a view using a Node renderer, all
subviews will use that same renderer).
It also changes one instance where DOM was being relied upon rather than
using the DOMHelper abstraction.
It also includes a small suite of tests that manually patch views to use
the Node SSR renderer, verifying that compiled HTMLbars templates render
correctly. | packages/ember-views/lib/views/view.js | @@ -1878,9 +1878,11 @@ var View = CoreView.extend({
var attrs = _attrs || {};
var view;
attrs._parentView = this;
+ attrs.renderer = this.renderer;
if (CoreView.detect(maybeViewClass)) {
attrs.container = this.container;
+
view = maybeViewClass.create(attrs);
// don't set the property on a virtual view, as they are invisible to | true |
Other | emberjs | ember.js | 80fcde8763928b73a4d7bea8c5f56889a6efec10.json | Support basic Node.js rendering
This commit makes some small cleanup changes across the framework that
ensure that views’ renderers are consistently inherited from their
parents (so that, e.g., if you render a view using a Node renderer, all
subviews will use that same renderer).
It also changes one instance where DOM was being relied upon rather than
using the DOMHelper abstraction.
It also includes a small suite of tests that manually patch views to use
the Node SSR renderer, verifying that compiled HTMLbars templates render
correctly. | tests/node/app-boot-test.js | @@ -3,19 +3,116 @@
var path = require('path');
var distPath = path.join(__dirname, '../../dist');
+/*jshint -W079 */
+var Ember = require(path.join(distPath, 'ember.debug.cjs'));
+Ember.testing = true;
+var DOMHelper = Ember.View.DOMHelper;
+var SimpleDOM = require('simple-dom');
+
QUnit.module("App boot");
QUnit.test("App is created without throwing an exception", function() {
- var Ember = require(path.join(distPath, 'ember.debug.cjs'));
+ var App;
+
+ Ember.run(function() {
+ App = Ember.Application.create();
- var App = Ember.Application.create({
+ App.Router = Ember.Router.extend({
+ location: 'none'
+ });
+
+ App.advanceReadiness();
});
- App.Router = Ember.Router.extend({
- location: 'none'
+ QUnit.ok(App);
+});
+
+QUnit.test("It is possible to render a view in Node", function() {
+ var View = Ember.View.extend({
+ renderer: new Ember.View._Renderer(new DOMHelper(new SimpleDOM.Document())),
+ template: Ember.Handlebars.compile("<h1>Hello</h1>")
});
- App.advanceReadiness();
+ var morph = {
+ contextualElement: {},
+ setContent: function(element) {
+ this.element = element;
+ }
+ };
- QUnit.ok(App);
+ var view = View.create({
+ _domHelper: new DOMHelper(new SimpleDOM.Document()),
+ _morph: morph
+ });
+
+ var renderer = view.renderer;
+
+ Ember.run(function() {
+ renderer.renderTree(view);
+ });
+
+ var serializer = new SimpleDOM.HTMLSerializer(SimpleDOM.voidMap);
+ ok(serializer.serialize(morph.element).match(/<h1>Hello<\/h1>/));
+});
+
+QUnit.test("It is possible to render a view with curlies in Node", function() {
+ var View = Ember.Component.extend({
+ renderer: new Ember.View._Renderer(new DOMHelper(new SimpleDOM.Document())),
+ layout: Ember.Handlebars.compile("<h1>Hello {{location}}</h1>"),
+ location: "World"
+ });
+
+ var morph = {
+ contextualElement: {},
+ setContent: function(element) {
+ this.element = element;
+ }
+ };
+
+ var view = View.create({
+ _domHelper: new DOMHelper(new SimpleDOM.Document()),
+ _morph: morph
+ });
+
+ var renderer = view.renderer;
+
+ Ember.run(function() {
+ renderer.renderTree(view);
+ });
+
+ var serializer = new SimpleDOM.HTMLSerializer(SimpleDOM.voidMap);
+ ok(serializer.serialize(morph.element).match(/<h1>Hello World<\/h1>/));
+});
+
+QUnit.test("It is possible to render a view with a nested {{view}} helper in Node", function() {
+ var View = Ember.Component.extend({
+ renderer: new Ember.View._Renderer(new DOMHelper(new SimpleDOM.Document())),
+ layout: Ember.Handlebars.compile("<h1>Hello {{#if hasExistence}}{{location}}{{/if}}</h1> <div>{{view bar}}</div>"),
+ location: "World",
+ hasExistence: true,
+ bar: Ember.View.extend({
+ template: Ember.Handlebars.compile("<p>The files are *inside* the computer?!</p>")
+ })
+ });
+
+ var morph = {
+ contextualElement: {},
+ setContent: function(element) {
+ this.element = element;
+ }
+ };
+
+ var view = View.create({
+ _domHelper: new DOMHelper(new SimpleDOM.Document()),
+ _morph: morph
+ });
+
+ var renderer = view.renderer;
+
+ Ember.run(function() {
+ renderer.renderTree(view);
+ });
+
+ var serializer = new SimpleDOM.HTMLSerializer(SimpleDOM.voidMap);
+ ok(serializer.serialize(morph.element).match(/<h1>Hello World<\/h1> <div><div id="(.*)" class="ember-view"><p>The files are \*inside\* the computer\?\!<\/p><\/div><\/div>/));
}); | true |
Other | emberjs | ember.js | db3d53eb3aa694fabcc3875d5ba53e226ab5a6cb.json | Update CHANGELOG.md insert comma
My file change inserts a missing comma into the change log. | CHANGELOG.md | @@ -28,8 +28,7 @@
{{some-other-component action="saveMe"}}
```
-Clearly, `component-a` has subscribed to `some-other-component`'s `action`. Previously, if `component-a` did not handle the action
-it would silently continue. Now, an assertion would be triggered.
+Clearly, `component-a` has subscribed to `some-other-component`'s `action`. Previously, if `component-a` did not handle the action, it would silently continue. Now, an assertion would be triggered.
* [PERF] Speedup Mixin creation.
* [BREAKING] Require Handlebars 2.0. See [blog post](http://emberjs.com/blog/2014/10/16/handlebars-update.html) for details. | false |
Other | emberjs | ember.js | 98b4246aabfd2e2d26b413f02ee61bd9920406ec.json | Fix tiny typo in deprecation notice. | packages/ember-runtime/lib/controllers/object_controller.js | @@ -2,7 +2,7 @@ import Ember from 'ember-metal/core';
import ControllerMixin from 'ember-runtime/mixins/controller';
import ObjectProxy from 'ember-runtime/system/object_proxy';
-export var objectControllerDeprecation = 'Ember.ObjectController is deprected, ' +
+export var objectControllerDeprecation = 'Ember.ObjectController is deprecated, ' +
'please use Ember.Controller and use `model.propertyName`.';
/** | false |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM helper can be
created and passed from the view layer to HTMLbars, ensuring that the
two rendering paths are unified.
This PR just refactors some internals to accept a DOM helper where
previously it was hardcoded. However, we did need to update some tests
that were making assumptions about internals that no longer hold. | packages/ember-application/lib/system/application.js | @@ -20,6 +20,7 @@ import EnumerableUtils from "ember-metal/enumerable_utils";
import ObjectController from "ember-runtime/controllers/object_controller";
import ArrayController from "ember-runtime/controllers/array_controller";
import Renderer from "ember-views/system/renderer";
+import { DOMHelper } from "morph";
import SelectView from "ember-views/views/select";
import EventDispatcher from "ember-views/system/event_dispatcher";
import jQuery from "ember-views/system/jquery";
@@ -1002,7 +1003,7 @@ Application.reopenClass({
registry.register('controller:object', ObjectController, { instantiate: false });
registry.register('controller:array', ArrayController, { instantiate: false });
- registry.register('renderer:-dom', { create: function(opts) { return new Renderer(opts); } });
+ registry.register('renderer:-dom', { create: function() { return new Renderer(new DOMHelper()); } });
registry.injection('view', 'renderer', 'renderer:-dom');
registry.register('view:select', SelectView); | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM helper can be
created and passed from the view layer to HTMLbars, ensuring that the
two rendering paths are unified.
This PR just refactors some internals to accept a DOM helper where
previously it was hardcoded. However, we did need to update some tests
that were making assumptions about internals that no longer hold. | packages/ember-htmlbars/lib/env.js | @@ -15,11 +15,7 @@ import set from "ember-htmlbars/hooks/set";
import helpers from "ember-htmlbars/helpers";
-var domHelper = environment.hasDOM ? new DOMHelper() : null;
-
export default {
- dom: domHelper,
-
hooks: {
get: get,
set: set,
@@ -35,3 +31,7 @@ export default {
helpers: helpers
};
+
+var domHelper = environment.hasDOM ? new DOMHelper() : null;
+
+export { domHelper }; | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM helper can be
created and passed from the view layer to HTMLbars, ensuring that the
two rendering paths are unified.
This PR just refactors some internals to accept a DOM helper where
previously it was hardcoded. However, we did need to update some tests
that were making assumptions about internals that no longer hold. | packages/ember-htmlbars/lib/system/render-view.js | @@ -27,7 +27,7 @@ function renderHTMLBarsTemplate(view, buffer, template) {
var args = view._blockArguments;
var env = {
view: this,
- dom: defaultEnv.dom,
+ dom: view.renderer._dom,
hooks: defaultEnv.hooks,
helpers: defaultEnv.helpers,
data: { | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM helper can be
created and passed from the view layer to HTMLbars, ensuring that the
two rendering paths are unified.
This PR just refactors some internals to accept a DOM helper where
previously it was hardcoded. However, we did need to update some tests
that were making assumptions about internals that no longer hold. | packages/ember-htmlbars/tests/attr_nodes/data_test.js | @@ -2,12 +2,12 @@ import EmberView from "ember-views/views/view";
import run from "ember-metal/run_loop";
import EmberObject from "ember-runtime/system/object";
import compile from "ember-template-compiler/system/compile";
+import Renderer from "ember-views/system/renderer";
import { equalInnerHTML } from "htmlbars-test-helpers";
-import defaultEnv from "ember-htmlbars/env";
+import { domHelper as dom } from "ember-htmlbars/env";
import { runAppend, runDestroy } from "ember-runtime/tests/utils";
-var view, originalSetAttribute, setAttributeCalls;
-var dom = defaultEnv.dom;
+var view, originalSetAttribute, setAttributeCalls, renderer;
if (Ember.FEATURES.isEnabled('ember-htmlbars-attribute-syntax')) {
@@ -199,9 +199,13 @@ if (Ember.FEATURES.isEnabled('ember-htmlbars-attribute-syntax')) {
QUnit.module('ember-htmlbars: {{attribute}} helper -- setAttribute', {
setup: function() {
+ renderer = new Renderer(dom);
+
originalSetAttribute = dom.setAttribute;
dom.setAttribute = function(element, name, value) {
- setAttributeCalls.push([name, value]);
+ if (name.substr(0, 5) === 'data-') {
+ setAttributeCalls.push([name, value]);
+ }
originalSetAttribute.call(dom, element, name, value);
};
@@ -219,6 +223,7 @@ if (Ember.FEATURES.isEnabled('ember-htmlbars-attribute-syntax')) {
test('calls setAttribute for new values', function() {
var context = EmberObject.create({ name: 'erik' });
view = EmberView.create({
+ renderer: renderer,
context: context,
template: compile("<div data-name={{name}}>Hi!</div>")
});
@@ -237,6 +242,7 @@ if (Ember.FEATURES.isEnabled('ember-htmlbars-attribute-syntax')) {
test('does not call setAttribute if the same value is set', function() {
var context = EmberObject.create({ name: 'erik' });
view = EmberView.create({
+ renderer: renderer,
context: context,
template: compile("<div data-name={{name}}>Hi!</div>")
}); | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM helper can be
created and passed from the view layer to HTMLbars, ensuring that the
two rendering paths are unified.
This PR just refactors some internals to accept a DOM helper where
previously it was hardcoded. However, we did need to update some tests
that were making assumptions about internals that no longer hold. | packages/ember-htmlbars/tests/htmlbars_test.js | @@ -1,14 +1,19 @@
import compile from "ember-template-compiler/system/compile";
import defaultEnv from "ember-htmlbars/env";
+import { domHelper } from "ember-htmlbars/env";
import { equalHTML } from "htmlbars-test-helpers";
+import merge from "ember-metal/merge";
if (Ember.FEATURES.isEnabled('ember-htmlbars')) {
QUnit.module("ember-htmlbars: main");
test("HTMLBars is present and can be executed", function() {
var template = compile("ohai");
- var output = template.render({}, defaultEnv, document.body);
+
+ var env = merge({ dom: domHelper }, defaultEnv);
+
+ var output = template.render({}, env, document.body);
equalHTML(output, "ohai");
});
} | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM helper can be
created and passed from the view layer to HTMLbars, ensuring that the
two rendering paths are unified.
This PR just refactors some internals to accept a DOM helper where
previously it was hardcoded. However, we did need to update some tests
that were making assumptions about internals that no longer hold. | packages/ember-metal-views/lib/renderer.js | @@ -3,7 +3,7 @@ import environment from "ember-metal/environment";
var domHelper = environment.hasDOM ? new DOMHelper() : null;
-function Renderer() {
+function Renderer(_helper) {
this._uuid = 0;
// These sizes and values are somewhat arbitrary (but sensible)
@@ -13,7 +13,7 @@ function Renderer() {
this._parents = [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0];
this._elements = new Array(17);
this._inserts = {};
- this._dom = domHelper;
+ this._dom = _helper || domHelper;
}
function Renderer_renderTree(_view, _parentView, _insertAt) { | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM helper can be
created and passed from the view layer to HTMLbars, ensuring that the
two rendering paths are unified.
This PR just refactors some internals to accept a DOM helper where
previously it was hardcoded. However, we did need to update some tests
that were making assumptions about internals that no longer hold. | packages/ember-views/lib/system/render_buffer.js | @@ -4,7 +4,6 @@
*/
import jQuery from "ember-views/system/jquery";
-import { DOMHelper } from "morph";
import Ember from "ember-metal/core";
import { create } from "ember-metal/platform";
import environment from "ember-metal/environment";
@@ -39,10 +38,10 @@ import environment from "ember-metal/environment";
var omittedStartTagChildren;
var omittedStartTagChildTest = /(?:<script)*.*?<([\w:]+)/i;
-function detectOmittedStartTag(string, contextualElement) {
+function detectOmittedStartTag(dom, string, contextualElement) {
omittedStartTagChildren = omittedStartTagChildren || {
- tr: document.createElement('tbody'),
- col: document.createElement('colgroup')
+ tr: dom.createElement('tbody'),
+ col: dom.createElement('colgroup')
};
// Omitted start tags are only inside table tags.
@@ -125,31 +124,29 @@ var canSetNameOnInputs = (function() {
})();
/**
- `Ember.renderBuffer` gathers information regarding the view and generates the
- final representation. `Ember.renderBuffer` will generate HTML which can be pushed
+ `Ember.RenderBuffer` gathers information regarding the view and generates the
+ final representation. `Ember.RenderBuffer` will generate HTML which can be pushed
to the DOM.
```javascript
- var buffer = Ember.renderBuffer('div', contextualElement);
+ var buffer = new Ember.RenderBuffer('div', contextualElement);
```
@method renderBuffer
@namespace Ember
@param {String} tagName tag name (such as 'div' or 'p') used for the buffer
*/
-export default function renderBuffer(tagName, contextualElement) {
- return new _RenderBuffer(tagName, contextualElement); // jshint ignore:line
-}
-function _RenderBuffer(tagName, contextualElement) {
- this.tagName = tagName;
- this._outerContextualElement = contextualElement;
+var RenderBuffer = function(domHelper) {
this.buffer = null;
this.childViews = [];
- this.dom = environment.hasDOM ? new DOMHelper() : null;
-}
-_RenderBuffer.prototype = {
+ Ember.assert("RenderBuffer requires a DOM helper to be passed to its constructor.", !!domHelper);
+
+ this.dom = domHelper;
+};
+
+RenderBuffer.prototype = {
reset: function(tagName, contextualElement) {
this.tagName = tagName;
@@ -580,7 +577,7 @@ _RenderBuffer.prototype = {
var omittedStartTag;
if (html) {
- omittedStartTag = detectOmittedStartTag(html, innerContextualElement);
+ omittedStartTag = detectOmittedStartTag(this.dom, html, innerContextualElement);
}
return omittedStartTag || innerContextualElement;
},
@@ -596,3 +593,5 @@ _RenderBuffer.prototype = {
return this.buffer;
}
};
+
+export default RenderBuffer; | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM helper can be
created and passed from the view layer to HTMLbars, ensuring that the
two rendering paths are unified.
This PR just refactors some internals to accept a DOM helper where
previously it was hardcoded. However, we did need to update some tests
that were making assumptions about internals that no longer hold. | packages/ember-views/lib/system/renderer.js | @@ -1,7 +1,7 @@
import Ember from "ember-metal/core";
import Renderer from 'ember-metal-views/renderer';
import { create } from 'ember-metal/platform';
-import renderBuffer from "ember-views/system/render_buffer";
+import RenderBuffer from "ember-views/system/render_buffer";
import run from "ember-metal/run_loop";
import { set } from "ember-metal/property_set";
import { get } from "ember-metal/property_get";
@@ -10,9 +10,9 @@ import {
subscribers
} from "ember-metal/instrumentation";
-function EmberRenderer() {
- this.buffer = renderBuffer();
- this._super$constructor();
+function EmberRenderer(domHelper) {
+ this._super$constructor(domHelper);
+ this.buffer = new RenderBuffer(domHelper);
}
EmberRenderer.prototype = create(Renderer.prototype); | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM helper can be
created and passed from the view layer to HTMLbars, ensuring that the
two rendering paths are unified.
This PR just refactors some internals to accept a DOM helper where
previously it was hardcoded. However, we did need to update some tests
that were making assumptions about internals that no longer hold. | packages/ember-views/lib/views/core_view.js | @@ -1,4 +1,5 @@
import Renderer from "ember-views/system/renderer";
+import { DOMHelper } from "morph";
import {
cloneStates,
@@ -48,8 +49,10 @@ var CoreView = EmberObject.extend(Evented, ActionHandler, {
this.currentState = this._states.preRender;
this._isVisible = get(this, 'isVisible');
+ // Fallback for legacy cases where the view was created directly
+ // via `create()` instead of going through the container.
if (!this.renderer) {
- renderer = renderer || new Renderer();
+ renderer = renderer || new Renderer(new DOMHelper());
this.renderer = renderer;
}
}, | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM helper can be
created and passed from the view layer to HTMLbars, ensuring that the
two rendering paths are unified.
This PR just refactors some internals to accept a DOM helper where
previously it was hardcoded. However, we did need to update some tests
that were making assumptions about internals that no longer hold. | packages/ember-views/tests/system/render_buffer_test.js | @@ -1,5 +1,6 @@
import jQuery from "ember-views/system/jquery";
import RenderBuffer from "ember-views/system/render_buffer";
+import { DOMHelper } from "morph";
var svgNamespace = "http://www.w3.org/2000/svg";
var xhtmlNamespace = "http://www.w3.org/1999/xhtml";
@@ -10,8 +11,17 @@ var trim = jQuery.trim;
//
QUnit.module("RenderBuffer");
+var domHelper = new DOMHelper();
+
+function createRenderBuffer(tagName, contextualElement) {
+ var buffer = new RenderBuffer(domHelper);
+ buffer.reset(tagName, contextualElement);
+
+ return buffer;
+}
+
test("RenderBuffers raise a deprecation warning without a contextualElement", function() {
- var buffer = new RenderBuffer('div');
+ var buffer = createRenderBuffer('div');
expectDeprecation(function() {
buffer.generateElement();
var el = buffer.element();
@@ -20,7 +30,7 @@ test("RenderBuffers raise a deprecation warning without a contextualElement", fu
});
test("reset RenderBuffers raise a deprecation warning without a contextualElement", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
buffer.reset('span');
expectDeprecation(function() {
buffer.generateElement();
@@ -30,7 +40,7 @@ test("reset RenderBuffers raise a deprecation warning without a contextualElemen
});
test("RenderBuffers combine strings", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
buffer.generateElement();
buffer.push('a');
@@ -42,7 +52,7 @@ test("RenderBuffers combine strings", function() {
});
test("RenderBuffers push fragments", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
var fragment = document.createElement('span');
buffer.generateElement();
@@ -54,7 +64,7 @@ test("RenderBuffers push fragments", function() {
});
test("RenderBuffers cannot push fragments when something else is in the buffer", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
var fragment = document.createElement('span');
buffer.generateElement();
@@ -65,7 +75,7 @@ test("RenderBuffers cannot push fragments when something else is in the buffer",
});
test("RenderBuffers cannot push strings after fragments", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
var fragment = document.createElement('span');
buffer.generateElement();
@@ -77,15 +87,15 @@ test("RenderBuffers cannot push strings after fragments", function() {
test("value of 0 is included in output", function() {
var buffer, el;
- buffer = new RenderBuffer('input', document.body);
+ buffer = createRenderBuffer('input', document.body);
buffer.prop('value', 0);
buffer.generateElement();
el = buffer.element();
strictEqual(el.value, '0', "generated element has value of '0'");
});
test("sets attributes with camelCase", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
var content = "javascript:someCode()"; //jshint ignore:line
buffer.attr('onClick', content);
@@ -95,7 +105,7 @@ test("sets attributes with camelCase", function() {
});
test("prevents XSS injection via `id`", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
buffer.id('hacked" megahax="yes');
buffer.generateElement();
@@ -105,7 +115,7 @@ test("prevents XSS injection via `id`", function() {
});
test("prevents XSS injection via `attr`", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
buffer.attr('id', 'trololol" onmouseover="pwn()');
buffer.attr('class', "hax><img src=\"trollface.png\"");
@@ -119,7 +129,7 @@ test("prevents XSS injection via `attr`", function() {
});
test("prevents XSS injection via `addClass`", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
buffer.addClass('megahax" xss="true');
buffer.generateElement();
@@ -129,7 +139,7 @@ test("prevents XSS injection via `addClass`", function() {
});
test("prevents XSS injection via `style`", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
buffer.style('color', 'blue;" xss="true" style="color:red');
buffer.generateElement();
@@ -148,7 +158,7 @@ test("prevents XSS injection via `style`", function() {
});
test("prevents XSS injection via `tagName`", function() {
- var buffer = new RenderBuffer('cool-div><div xss="true"', document.body);
+ var buffer = createRenderBuffer('cool-div><div xss="true"', document.body);
try {
buffer.generateElement();
equal(buffer.element().childNodes.length, 0, 'no extra nodes created');
@@ -158,15 +168,15 @@ test("prevents XSS injection via `tagName`", function() {
});
test("handles null props - Issue #2019", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
buffer.prop('value', null);
buffer.generateElement();
equal(buffer.element().tagName, 'DIV', 'div exists');
});
test("handles browsers like Firefox < 11 that don't support outerHTML Issue #1952", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
buffer.generateElement();
// Make sure element.outerHTML is falsy to trigger the fallback.
var elementStub = '<div></div>';
@@ -176,7 +186,7 @@ test("handles browsers like Firefox < 11 that don't support outerHTML Issue #195
});
test("lets `setClasses` and `addClass` work together", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
buffer.setClasses(['foo', 'bar']);
buffer.addClass('baz');
buffer.generateElement();
@@ -188,7 +198,7 @@ test("lets `setClasses` and `addClass` work together", function() {
test("generates text and a div and text", function() {
var div = document.createElement('div');
- var buffer = new RenderBuffer(undefined, div);
+ var buffer = createRenderBuffer(undefined, div);
buffer.buffer = 'Howdy<div>Nick</div>Cage';
var el = buffer.element();
@@ -201,7 +211,7 @@ test("generates text and a div and text", function() {
test("generates a tr from a tr innerString", function() {
var table = document.createElement('table');
- var buffer = new RenderBuffer(undefined, table);
+ var buffer = createRenderBuffer(undefined, table);
buffer.buffer = '<tr></tr>';
var el = buffer.element();
@@ -210,7 +220,7 @@ test("generates a tr from a tr innerString", function() {
test("generates a tr from a tr innerString with leading <script", function() {
var table = document.createElement('table');
- var buffer = new RenderBuffer(undefined, table);
+ var buffer = createRenderBuffer(undefined, table);
buffer.buffer = '<script></script><tr></tr>';
var el = buffer.element();
@@ -219,15 +229,15 @@ test("generates a tr from a tr innerString with leading <script", function() {
test("generates a tr from a tr innerString with leading comment", function() {
var table = document.createElement('table');
- var buffer = new RenderBuffer(undefined, table);
+ var buffer = createRenderBuffer(undefined, table);
buffer.buffer = '<!-- blargh! --><tr></tr>';
var el = buffer.element();
equal(el.childNodes[1].tagName, 'TR');
});
test("generates a tr from a tr innerString on rerender", function() {
- var buffer = new RenderBuffer('table', document.body);
+ var buffer = createRenderBuffer('table', document.body);
buffer.generateElement();
buffer.buffer = '<tr></tr>';
@@ -237,7 +247,7 @@ test("generates a tr from a tr innerString on rerender", function() {
test("generates a tbody from a tbody innerString", function() {
var table = document.createElement('table');
- var buffer = new RenderBuffer(undefined, table);
+ var buffer = createRenderBuffer(undefined, table);
buffer.buffer = '<tbody><tr></tr></tbody>';
var el = buffer.element();
@@ -246,7 +256,7 @@ test("generates a tbody from a tbody innerString", function() {
test("generates a col from a col innerString", function() {
var table = document.createElement('table');
- var buffer = new RenderBuffer(undefined, table);
+ var buffer = createRenderBuffer(undefined, table);
buffer.buffer = '<col></col>';
var el = buffer.element();
@@ -256,7 +266,7 @@ test("generates a col from a col innerString", function() {
QUnit.module("RenderBuffer - without tagName");
test("It is possible to create a RenderBuffer without a tagName", function() {
- var buffer = new RenderBuffer(undefined, document.body);
+ var buffer = createRenderBuffer(undefined, document.body);
buffer.push('a');
buffer.push('b');
buffer.push('c');
@@ -271,7 +281,7 @@ test("It is possible to create a RenderBuffer without a tagName", function() {
QUnit.module("RenderBuffer#element");
test("properly handles old IE's zero-scope bug", function() {
- var buffer = new RenderBuffer('div', document.body);
+ var buffer = createRenderBuffer('div', document.body);
buffer.generateElement();
buffer.push('<script></script>foo');
@@ -285,7 +295,7 @@ if ('namespaceURI' in document.createElement('div')) {
QUnit.module("RenderBuffer namespaces");
test("properly makes a content string SVG namespace inside an SVG tag", function() {
- var buffer = new RenderBuffer('svg', document.body);
+ var buffer = createRenderBuffer('svg', document.body);
buffer.generateElement();
buffer.push('<path></path>foo');
@@ -298,7 +308,7 @@ if ('namespaceURI' in document.createElement('div')) {
});
test("properly makes a path element svg namespace inside SVG context", function() {
- var buffer = new RenderBuffer('path', document.createElementNS(svgNamespace, 'svg'));
+ var buffer = createRenderBuffer('path', document.createElementNS(svgNamespace, 'svg'));
buffer.generateElement();
buffer.push('<g></g>');
@@ -311,7 +321,7 @@ if ('namespaceURI' in document.createElement('div')) {
});
test("properly makes a foreignObject svg namespace inside SVG context", function() {
- var buffer = new RenderBuffer('foreignObject', document.createElementNS(svgNamespace, 'svg'));
+ var buffer = createRenderBuffer('foreignObject', document.createElementNS(svgNamespace, 'svg'));
buffer.generateElement();
buffer.push('<div></div>');
@@ -324,7 +334,7 @@ if ('namespaceURI' in document.createElement('div')) {
});
test("properly makes a div xhtml namespace inside foreignObject context", function() {
- var buffer = new RenderBuffer('div', document.createElementNS(svgNamespace, 'foreignObject'));
+ var buffer = createRenderBuffer('div', document.createElementNS(svgNamespace, 'foreignObject'));
buffer.generateElement();
buffer.push('<div></div>');
| true |
Other | emberjs | ember.js | 685d9e36fee7a8d99f3811a9f99758a1231ffaa7.json | Make Ember.Map keys and values private. | packages/ember-metal/lib/map.js | @@ -45,11 +45,11 @@ function copyNull(obj) {
}
function copyMap(original, newObject) {
- var keys = original.keys.copy();
- var values = copyNull(original.values);
+ var keys = original._keys.copy();
+ var values = copyNull(original._values);
- newObject.keys = keys;
- newObject.values = values;
+ newObject._keys = keys;
+ newObject._values = values;
newObject.size = original.size;
return newObject;
@@ -252,9 +252,9 @@ deprecateProperty(OrderedSet.prototype, 'length', 'size');
*/
function Map() {
if (this instanceof this.constructor) {
- this.keys = OrderedSet.create();
- this.keys._silenceRemoveDeprecation = true;
- this.values = create(null);
+ this._keys = OrderedSet.create();
+ this._keys._silenceRemoveDeprecation = true;
+ this._values = create(null);
this.size = 0;
} else {
missingNew("OrderedSet");
@@ -294,7 +294,7 @@ Map.prototype = {
get: function(key) {
if (this.size === 0) { return; }
- var values = this.values;
+ var values = this._values;
var guid = guidFor(key);
return values[guid];
@@ -310,8 +310,8 @@ Map.prototype = {
@return {Ember.Map}
*/
set: function(key, value) {
- var keys = this.keys;
- var values = this.values;
+ var keys = this._keys;
+ var values = this._values;
var guid = guidFor(key);
// ensure we don't store -0
@@ -351,8 +351,8 @@ Map.prototype = {
if (this.size === 0) { return false; }
// don't use ES6 "delete" because it will be annoying
// to use in browsers that are not ES6 friendly;
- var keys = this.keys;
- var values = this.values;
+ var keys = this._keys;
+ var values = this._values;
var guid = guidFor(key);
if (keys.delete(key, guid)) {
@@ -372,7 +372,7 @@ Map.prototype = {
@return {Boolean} true if the item was present, false otherwise
*/
has: function(key) {
- return this.keys.has(key);
+ return this._keys.has(key);
},
/**
@@ -409,15 +409,15 @@ Map.prototype = {
};
}
- this.keys.forEach(cb);
+ this._keys.forEach(cb);
},
/**
@method clear
*/
clear: function() {
- this.keys.clear();
- this.values = create(null);
+ this._keys.clear();
+ this._values = create(null);
this.size = 0;
},
| false |
Other | emberjs | ember.js | 7cbdc3354c99faf103f8c3f19645c7b795d26131.json | Disallow empty blocks. | .jscsrc | @@ -13,6 +13,7 @@
"beforeAlternate": true
},
"disallowSpacesInCallExpression": true,
+ "disallowEmptyBlocks": true,
"requireCurlyBraces": [
"if",
"else", | true |
Other | emberjs | ember.js | 7cbdc3354c99faf103f8c3f19645c7b795d26131.json | Disallow empty blocks. | packages/ember-metal/lib/core.js | @@ -67,6 +67,7 @@ Ember.VERSION = 'VERSION_STRING_PLACEHOLDER';
if (Ember.ENV) {
// do nothing if Ember.ENV is already setup
+ Ember.assert('Ember.ENV should be an object.', 'object' !== typeof Ember.ENV);
} else if ('undefined' !== typeof EmberENV) {
Ember.ENV = EmberENV;
} else if ('undefined' !== typeof ENV) { | true |
Other | emberjs | ember.js | 7cbdc3354c99faf103f8c3f19645c7b795d26131.json | Disallow empty blocks. | packages/ember-metal/lib/utils.js | @@ -642,11 +642,13 @@ export function tryInvoke(obj, methodName, args) {
var needsFinallyFix = (function() {
var count = 0;
try {
+ // jscs:disable
try {
} finally {
count++;
throw new Error('needsFinallyFixTest');
}
+ // jscs:enable
} catch (e) {}
return count !== 1; | true |
Other | emberjs | ember.js | 7cbdc3354c99faf103f8c3f19645c7b795d26131.json | Disallow empty blocks. | packages/ember-metal/tests/run_loop/later_test.js | @@ -18,6 +18,19 @@ function wait(callback, maxWaitCount) {
}, 10);
}
+// Synchronous "sleep". This simulates work being done
+// after run.later was called but before the run loop
+// has flushed. In previous versions, this would have
+// caused the run.later callback to have run from
+// within the run loop flush, since by the time the
+// run loop has to flush, it would have considered
+// the timer already expired.
+function pauseUntil(time) {
+ // jscs:disable
+ while (+new Date() < time) { /* do nothing - sleeping */ }
+ // jscs:enable
+}
+
QUnit.module('run.later', {
teardown: function() {
window.setTimeout = originalSetTimeout;
@@ -79,15 +92,7 @@ asyncTest('should always invoke within a separate runloop', function() {
secondRunLoop = run.currentRunLoop;
}, 10, 1);
- // Synchronous "sleep". This simulates work being done
- // after run.later was called but before the run loop
- // has flushed. In previous versions, this would have
- // caused the run.later callback to have run from
- // within the run loop flush, since by the time the
- // run loop has to flush, it would have considered
- // the timer already expired.
- var pauseUntil = +new Date() + 100;
- while (+new Date() < pauseUntil) { /* do nothing - sleeping */ }
+ pauseUntil(+new Date() + 100);
});
ok(firstRunLoop, "first run loop captured");
@@ -218,8 +223,7 @@ asyncTest('setTimeout should never run with a negative wait', function() {
// fine that they're not called in this run loop; just need to
// make sure that invokeLaterTimers doesn't end up scheduling
// a negative setTimeout.
- var pauseUntil = +new Date() + 60;
- while (+new Date() < pauseUntil) { /* do nothing - sleeping */ }
+ pauseUntil(+new Date() + 60);
}, 1);
run.later(function() { | true |
Other | emberjs | ember.js | 7cbdc3354c99faf103f8c3f19645c7b795d26131.json | Disallow empty blocks. | packages/ember-runtime/lib/mixins/action_handler.js | @@ -209,11 +209,8 @@ var ActionHandler = Mixin.create({
var target;
if (this._actions && this._actions[actionName]) {
- if (this._actions[actionName].apply(this, args) === true) {
- // handler returned true, so this action will bubble
- } else {
- return;
- }
+ var shouldBubble = this._actions[actionName].apply(this, args) === true;
+ if (!shouldBubble) { return; }
}
if (target = get(this, 'target')) { | true |
Other | emberjs | ember.js | 7cbdc3354c99faf103f8c3f19645c7b795d26131.json | Disallow empty blocks. | packages/ember-views/lib/views/component.js | @@ -309,11 +309,8 @@ var Component = View.extend(TargetActionSupport, ComponentTemplateDeprecation, {
var hasAction = this._actions && this._actions[actionName];
if (hasAction) {
- if (this._actions[actionName].apply(this, args) === true) {
- // handler returned true, so this action will bubble
- } else {
- return;
- }
+ var shouldBubble = this._actions[actionName].apply(this, args) === true;
+ if (!shouldBubble) { return; }
}
if (target = get(this, 'target')) { | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | .jscsrc | @@ -4,6 +4,7 @@
"additionalRules": [ "lib/jscs-rules/*.js" ],
"disallowMultipleVarDeclWithAssignment": true,
"requireSpaceBeforeObjectValues": true,
+ "requireBlocksOnNewline": 1,
"disallowSpacesBeforeSemicolons": true,
"requireSpacesInConditionalExpression": {
"afterTest": true, | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-metal/lib/deprecate_property.js | @@ -30,8 +30,14 @@ export function deprecateProperty(object, deprecatedKey, newKey) {
defineProperty(object, deprecatedKey, {
configurable: true,
enumerable: false,
- set: function(value) { deprecate(); set(this, newKey, value); },
- get: function() { deprecate(); return get(this, newKey); }
+ set: function(value) {
+ deprecate();
+ set(this, newKey, value);
+ },
+ get: function() {
+ deprecate();
+ return get(this, newKey);
+ }
});
}
} | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-metal/tests/mixin/method_test.js | @@ -70,7 +70,10 @@ test('overriding inherited objects', function() {
});
var MixinB = Mixin.create({
- foo: function() { this._super(); cnt++; }
+ foo: function() {
+ this._super();
+ cnt++;
+ }
});
var objA = {};
@@ -189,11 +192,17 @@ test('applying several mixins at once with sup already defined causes infinite l
});
var MixinB = Mixin.create({
- foo: function() { this._super(); cnt++; }
+ foo: function() {
+ this._super();
+ cnt++;
+ }
});
var MixinC = Mixin.create({
- foo: function() { this._super(); cnt++; }
+ foo: function() {
+ this._super();
+ cnt++;
+ }
});
var obj = {}; | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-metal/tests/observer_test.js | @@ -562,7 +562,8 @@ testBoth('addObserver should respect targets with methods', function(get, set) {
});
-testBoth('addObserver should allow multiple objects to observe a property', function(get, set) { var observed = { foo: 'foo' };
+testBoth('addObserver should allow multiple objects to observe a property', function(get, set) {
+ var observed = { foo: 'foo' };
var target1 = {
count: 0, | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-metal/tests/platform/defineProperty_test.js | @@ -79,8 +79,14 @@ if (hasPropertyAccessors) {
var desc = {
enumerable: true,
- get: function() { getCnt++; return v; },
- set: function(val) { setCnt++; v = val; }
+ get: function() {
+ getCnt++;
+ return v;
+ },
+ set: function(val) {
+ setCnt++;
+ v = val;
+ }
};
defineProperty(obj, 'foo', desc); | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-metal/tests/utils/try_catch_finally_test.js | @@ -13,9 +13,18 @@ QUnit.module("Ember.tryFinally", {
catchableResult = 'catchable return value';
finalizerResult = undefined;
- tryable = function() { tryCount++; return tryableResult; };
- catchable = function() { catchCount++; return catchableResult; };
- finalizer = function() { finalizeCount++; return finalizerResult; };
+ tryable = function() {
+ tryCount++;
+ return tryableResult;
+ };
+ catchable = function() {
+ catchCount++;
+ return catchableResult;
+ };
+ finalizer = function() {
+ finalizeCount++;
+ return finalizerResult;
+ };
},
teardown: function() {
@@ -55,7 +64,10 @@ test("no failure, return from finally", function() {
});
test("try failed", function() {
- tryable = function() { tryCount++; throw error; };
+ tryable = function() {
+ tryCount++;
+ throw error;
+ };
var result = tryCatchFinally(tryable, catchable, finalizer);
@@ -67,7 +79,10 @@ test("try failed", function() {
});
test("catch failed", function() {
- catchable = function() { catchCount++; throw error; };
+ catchable = function() {
+ catchCount++;
+ throw error;
+ };
tryCatchFinally(tryable, catchable, finalizer);
@@ -77,8 +92,14 @@ test("catch failed", function() {
});
test("try and catch failed", function() {
- tryable = function() { tryCount++; throw error; };
- catchable = function() { catchCount++; throw error; };
+ tryable = function() {
+ tryCount++;
+ throw error;
+ };
+ catchable = function() {
+ catchCount++;
+ throw error;
+ };
callTryCatchFinallyWithError();
@@ -88,7 +109,10 @@ test("try and catch failed", function() {
});
test("finally failed", function() {
- finalizer = function() { finalizeCount++; throw error; };
+ finalizer = function() {
+ finalizeCount++;
+ throw error;
+ };
callTryCatchFinallyWithError();
@@ -98,8 +122,14 @@ test("finally failed", function() {
});
test("finally and try failed", function() {
- tryable = function() { tryCount++; throw error; };
- finalizer = function() { finalizeCount++; throw error; };
+ tryable = function() {
+ tryCount++;
+ throw error;
+ };
+ finalizer = function() {
+ finalizeCount++;
+ throw error;
+ };
callTryCatchFinallyWithError();
@@ -109,9 +139,18 @@ test("finally and try failed", function() {
});
test("finally, catch and try failed", function() {
- tryable = function() { tryCount++; throw error; };
- catchable = function() { catchCount++; throw error; };
- finalizer = function() { finalizeCount++; throw error; };
+ tryable = function() {
+ tryCount++;
+ throw error;
+ };
+ catchable = function() {
+ catchCount++;
+ throw error;
+ };
+ finalizer = function() {
+ finalizeCount++;
+ throw error;
+ };
callTryCatchFinallyWithError();
| true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-metal/tests/utils/try_finally_test.js | @@ -10,8 +10,14 @@ QUnit.module("Ember.tryFinally", {
tryableResult = 'tryable return value';
finalizerResult = undefined;
- tryable = function() { tryCount++; return tryableResult; };
- finalizer = function() { finalizeCount++; return finalizerResult; };
+ tryable = function() {
+ tryCount++;
+ return tryableResult;
+ };
+ finalizer = function() {
+ finalizeCount++;
+ return finalizerResult;
+ };
},
teardown: function() {
@@ -48,7 +54,10 @@ test("no failure, return from finally", function() {
});
test("try failed", function() {
- tryable = function() { tryCount++; throw error; };
+ tryable = function() {
+ tryCount++;
+ throw error;
+ };
callTryFinallyWithError();
@@ -57,7 +66,10 @@ test("try failed", function() {
});
test("finally failed", function() {
- finalizer = function() { finalizeCount++; throw error; };
+ finalizer = function() {
+ finalizeCount++;
+ throw error;
+ };
callTryFinallyWithError();
@@ -66,8 +78,14 @@ test("finally failed", function() {
});
test("finally and try failed", function() {
- tryable = function() { tryCount++; throw error; };
- finalizer = function() { finalizeCount++; throw error; };
+ tryable = function() {
+ tryCount++;
+ throw error;
+ };
+ finalizer = function() {
+ finalizeCount++;
+ throw error;
+ };
callTryFinallyWithError();
| true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/computed/reduce_computed_test.js | @@ -180,8 +180,14 @@ test("multiple dependent keys can be specified via brace expansion", function()
baz: Ember.A(),
foo: reduceComputed({
initialValue: Ember.A(),
- addedItem: function(array, item) { array.pushObject('a:' + item); return array; },
- removedItem: function(array, item) { array.pushObject('r:' + item); return array; }
+ addedItem: function(array, item) {
+ array.pushObject('a:' + item);
+ return array;
+ },
+ removedItem: function(array, item) {
+ array.pushObject('r:' + item);
+ return array;
+ }
}).property('{bar,baz}')
});
@@ -423,7 +429,10 @@ test("dependent arrays can use `replace` with a negative index to remove items i
dependentArray: dependentArray,
computed: arrayComputed('dependentArray', {
addedItem: function (acc, item) { return acc; },
- removedItem: function (acc, item) { acc.pushObject(item); return acc; }
+ removedItem: function (acc, item) {
+ acc.pushObject(item);
+ return acc;
+ }
})
}).create();
@@ -465,7 +474,10 @@ test("dependent arrays that call `replace` with a too-large removedCount a) work
dependentArray: dependentArray,
computed: arrayComputed('dependentArray', {
addedItem: function (acc, item) { return acc; },
- removedItem: function (acc, item) { acc.pushObject(item); return acc; }
+ removedItem: function (acc, item) {
+ acc.pushObject(item);
+ return acc;
+ }
})
}).create();
| true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/suites/enumerable/any.js | @@ -15,7 +15,10 @@ suite.test('any should should invoke callback on each item as long as you return
var found = [];
var result;
- result = obj.any(function(i) { found.push(i); return false; });
+ result = obj.any(function(i) {
+ found.push(i);
+ return false;
+ });
equal(result, false, 'return value of obj.any');
deepEqual(found, ary, 'items passed during any() should match');
});
@@ -28,7 +31,10 @@ suite.test('any should stop invoking when you return true', function() {
var found = [];
var result;
- result = obj.any(function(i) { found.push(i); return --cnt <= 0; });
+ result = obj.any(function(i) {
+ found.push(i);
+ return --cnt <= 0;
+ });
equal(result, true, 'return value of obj.any');
equal(found.length, exp, 'should invoke proper number of times');
deepEqual(found, ary.slice(0, -2), 'items passed during any() should match');
@@ -70,17 +76,29 @@ suite.test('any should be aliased to some', function() {
var cnt = ary.length - 2;
var anyResult, someResult;
- anyResult = obj.any(function(i) { anyFound.push(i); return false; });
- someResult = obj.some(function(i) { someFound.push(i); return false; });
+ anyResult = obj.any(function(i) {
+ anyFound.push(i);
+ return false;
+ });
+ someResult = obj.some(function(i) {
+ someFound.push(i);
+ return false;
+ });
equal(someResult, anyResult);
anyFound = [];
someFound = [];
cnt = ary.length - 2;
- anyResult = obj.any(function(i) { anyFound.push(i); return --cnt <= 0; });
+ anyResult = obj.any(function(i) {
+ anyFound.push(i);
+ return --cnt <= 0;
+ });
cnt = ary.length - 2;
- someResult = obj.some(function(i) { someFound.push(i); return --cnt <= 0; });
+ someResult = obj.some(function(i) {
+ someFound.push(i);
+ return --cnt <= 0;
+ });
equal(someResult, anyResult);
}); | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/suites/enumerable/every.js | @@ -15,7 +15,10 @@ suite.test('every should should invoke callback on each item as long as you retu
var found = [];
var result;
- result = obj.every(function(i) { found.push(i); return true; });
+ result = obj.every(function(i) {
+ found.push(i);
+ return true;
+ });
equal(result, true, 'return value of obj.every');
deepEqual(found, ary, 'items passed during every() should match');
});
@@ -28,7 +31,10 @@ suite.test('every should stop invoking when you return false', function() {
var found = [];
var result;
- result = obj.every(function(i) { found.push(i); return --cnt>0; });
+ result = obj.every(function(i) {
+ found.push(i);
+ return --cnt>0;
+ });
equal(result, false, 'return value of obj.every');
equal(found.length, exp, 'should invoke proper number of times');
deepEqual(found, ary.slice(0, -2), 'items passed during every() should match'); | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/suites/enumerable/filter.js | @@ -17,7 +17,10 @@ suite.test('filter should invoke on each item', function() {
var result;
// return true on all but the last two
- result = obj.filter(function(i) { found.push(i); return --cnt>=0; });
+ result = obj.filter(function(i) {
+ found.push(i);
+ return --cnt>=0;
+ });
deepEqual(found, ary, 'should have invoked on each item');
deepEqual(result, ary.slice(0, -2), 'filtered array should exclude items');
}); | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/suites/enumerable/find.js | @@ -14,7 +14,10 @@ suite.test('find should invoke callback on each item as long as you return false
var found = [];
var result;
- result = obj.find(function(i) { found.push(i); return false; });
+ result = obj.find(function(i) {
+ found.push(i);
+ return false;
+ });
equal(result, undefined, 'return value of obj.find');
deepEqual(found, ary, 'items passed during find() should match');
});
@@ -27,7 +30,10 @@ suite.test('every should stop invoking when you return true', function() {
var found = [];
var result;
- result = obj.find(function(i) { found.push(i); return --cnt >= 0; });
+ result = obj.find(function(i) {
+ found.push(i);
+ return --cnt >= 0;
+ });
equal(result, ary[exp-1], 'return value of obj.find');
equal(found.length, exp, 'should invoke proper number of times');
deepEqual(found, ary.slice(0, -2), 'items passed during find() should match'); | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/system/object/create_test.js | @@ -215,11 +215,17 @@ test("Calls init if defined", function() {
test("Calls all mixin inits if defined", function() {
var completed = 0;
var Mixin1 = Mixin.create({
- init: function() { this._super(); completed++; }
+ init: function() {
+ this._super();
+ completed++;
+ }
});
var Mixin2 = Mixin.create({
- init: function() { this._super(); completed++; }
+ init: function() {
+ this._super();
+ completed++;
+ }
});
EmberObject.createWithMixins(Mixin1, Mixin2); | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/system/object/extend_test.js | @@ -29,12 +29,18 @@ test('Overriding a method several layers deep', function() {
var AnotherClass = SomeClass.extend({
barCnt: 0,
- bar: function() { this.barCnt++; this._super(); }
+ bar: function() {
+ this.barCnt++;
+ this._super();
+ }
});
var FinalClass = AnotherClass.extend({
fooCnt: 0,
- foo: function() { this.fooCnt++; this._super(); }
+ foo: function() {
+ this.fooCnt++;
+ this._super();
+ }
});
var obj = new FinalClass();
@@ -45,7 +51,10 @@ test('Overriding a method several layers deep', function() {
// Try overriding on create also
obj = FinalClass.createWithMixins({
- foo: function() { this.fooCnt++; this._super(); }
+ foo: function() {
+ this.fooCnt++;
+ this._super();
+ }
});
obj.foo(); | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-views/lib/views/select.js | @@ -557,7 +557,10 @@ var Select = View.extend({
var prompt = get(this, 'prompt');
if (!content || !get(content, 'length')) { return; }
- if (prompt && selectedIndex === 0) { set(this, 'selection', null); return; }
+ if (prompt && selectedIndex === 0) {
+ set(this, 'selection', null);
+ return;
+ }
if (prompt) { selectedIndex -= 1; }
set(this, 'selection', content.objectAt(selectedIndex)); | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-views/tests/views/container_view_test.js | @@ -543,7 +543,10 @@ test("should be able to modify childViews then remove the ContainerView in same
var count = 0;
var child = View.create({
- template: function () { count++; return 'child'; }
+ template: function () {
+ count++;
+ return 'child';
+ }
});
run(function() {
@@ -563,7 +566,10 @@ test("should be able to modify childViews then destroy the ContainerView in same
var count = 0;
var child = View.create({
- template: function () { count++; return 'child'; }
+ template: function () {
+ count++;
+ return 'child';
+ }
});
run(function() {
@@ -584,7 +590,10 @@ test("should be able to modify childViews then rerender the ContainerView in sam
var count = 0;
var child = View.create({
- template: function () { count++; return 'child'; }
+ template: function () {
+ count++;
+ return 'child';
+ }
});
run(function() { | true |
Other | emberjs | ember.js | 6fb0f61316b70e918fc3fe107a15ea8451fc2bd6.json | Add comment for future intrepid travelers | packages/ember-metal-views/lib/renderer.js | @@ -5,6 +5,9 @@ var domHelper = environment.hasDOM ? new DOMHelper() : null;
function Renderer() {
this._uuid = 0;
+
+ // These sizes and values are somewhat arbitrary (but sensible)
+ // pre-allocation defaults.
this._views = new Array(2000);
this._queue = [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0];
this._parents = [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]; | false |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | .jscsrc | @@ -3,6 +3,7 @@
"excludeFiles": ["ember-runtime/ext/rsvp.js"],
"additionalRules": [ "lib/jscs-rules/*.js" ],
"disallowMultipleVarDeclWithAssignment": true,
+ "requireSpaceBeforeObjectValues": true,
"requireCurlyBraces": [
"if",
"else", | true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-application/tests/system/initializers_test.js | @@ -21,13 +21,13 @@ test("initializers require proper 'name' and 'initialize' properties", function(
expectAssertion(function() {
run(function() {
- MyApplication.initializer({name:'initializer'});
+ MyApplication.initializer({name: 'initializer'});
});
});
expectAssertion(function() {
run(function() {
- MyApplication.initializer({initialize:Ember.K});
+ MyApplication.initializer({initialize: Ember.K});
});
});
| true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-extension-support/tests/container_debug_adapter_test.js | @@ -11,7 +11,7 @@ function boot() {
}
QUnit.module("Container Debug Adapter", {
- setup:function() {
+ setup: function() {
run(function() {
App = Application.create(); // ES6TODO: this comes from the ember-application package NOT ember-runtime
App.toString = function() { return 'App'; }; | true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-extension-support/tests/data_adapter_test.js | @@ -21,7 +21,7 @@ var DataAdapter = EmberDataAdapter.extend({
});
QUnit.module("Data Adapter", {
- setup:function() {
+ setup: function() {
run(function() {
App = EmberApplication.create();
App.toString = function() { return 'App'; }; | true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-metal/lib/platform/create.js | @@ -22,7 +22,7 @@ if (!(Object.create && !Object.create(null).hasOwnProperty)) {
/* jshint scripturl:true, proto:true */
// Contributed by Brandon Benvie, October, 2012
var createEmpty;
- var supportsProto = !({'__proto__':null} instanceof Object);
+ var supportsProto = !({'__proto__': null} instanceof Object);
// the following produces false positives
// in Opera Mini => not a reliable check
// Object.prototype.__proto__ === null | true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-metal/tests/set_properties_test.js | @@ -14,7 +14,7 @@ test("supports setting multiple attributes at once", function() {
deepEqual(setProperties({}, {foo: 1}), {foo: 1}, 'Set a single property');
- deepEqual(setProperties({}, {foo:1, bar: 1}), {foo: 1, bar: 1}, 'Set multiple properties');
+ deepEqual(setProperties({}, {foo: 1, bar: 1}), {foo: 1, bar: 1}, 'Set multiple properties');
deepEqual(setProperties({foo: 2, baz: 2}, {foo: 1}), {foo: 1, baz: 2}, 'Set one of multiple properties');
| true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-runtime/tests/computed/reduce_computed_macros_test.js | @@ -372,10 +372,10 @@ QUnit.module('computedFilterBy', {
setup: function() {
obj = EmberObject.createWithMixins({
array: Ember.A([
- {name: "one", a:1, b:false},
- {name: "two", a:2, b:false},
- {name: "three", a:1, b:true},
- {name: "four", b:true}
+ {name: "one", a: 1, b: false},
+ {name: "two", a: 2, b: false},
+ {name: "three", a: 1, b: true},
+ {name: "four", b: true}
]),
a1s: computedFilterBy('array', 'a', 1),
as: computedFilterBy('array', 'a'),
@@ -408,7 +408,7 @@ test("properties can be filtered by truthiness", function() {
deepEqual(bs.mapBy('name'), ['one', 'three'], "arrays computed by filtered property respond to property changes");
run(function() {
- array.pushObject({name:"five", a:6, b:true});
+ array.pushObject({name: "five", a: 6, b: true});
});
deepEqual(as.mapBy('name'), ['two', 'three', 'four', 'five'], "arrays computed by filter property respond to added objects");
deepEqual(bs.mapBy('name'), ['one', 'three', 'five'], "arrays computed by filtered property respond to added objects");
@@ -420,7 +420,7 @@ test("properties can be filtered by truthiness", function() {
deepEqual(bs.mapBy('name'), ['one', 'three'], "arrays computed by filtered property respond to removed objects");
run(function() {
- set(obj, 'array', Ember.A([{name: "six", a:12, b:true}]));
+ set(obj, 'array', Ember.A([{name: "six", a: 12, b: true}]));
});
deepEqual(as.mapBy('name'), ['six'], "arrays computed by filter property respond to array changes");
deepEqual(bs.mapBy('name'), ['six'], "arrays computed by filtered property respond to array changes");
@@ -433,7 +433,7 @@ test("properties can be filtered by values", function() {
deepEqual(a1s.mapBy('name'), ['one', 'three'], "properties can be filtered by matching value");
run(function() {
- array.pushObject({ name: "five", a:1 });
+ array.pushObject({ name: "five", a: 1 });
});
deepEqual(a1s.mapBy('name'), ['one', 'three', 'five'], "arrays computed by matching value respond to added objects");
@@ -460,7 +460,7 @@ test("properties values can be replaced", function() {
deepEqual(a1bs.mapBy('name'), [], "properties can be filtered by matching value");
run(function() {
- set(obj, 'array', Ember.A([{name: 'item1', a:1, b:true}]));
+ set(obj, 'array', Ember.A([{name: 'item1', a: 1, b: true}]));
});
a1bs = get(obj, 'a1bs'); | true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-runtime/tests/legacy_1x/mixins/observable/observable_test.js | @@ -669,7 +669,7 @@ QUnit.module("Observable objects & object properties ", {
return ret ;
},
- newObserver:function() {
+ newObserver: function() {
this.abnormal = 'changedValueObserved';
},
@@ -758,8 +758,8 @@ QUnit.module("object.addObserver()", {
ObjectC = ObservableObject.create({
- objectE:ObservableObject.create({
- propertyVal:"chainedProperty"
+ objectE: ObservableObject.create({
+ propertyVal: "chainedProperty"
}),
normal: 'value',
@@ -775,7 +775,7 @@ QUnit.module("object.addObserver()", {
this.incrementor= this.incrementor+1;
},
- chainedObserver:function() {
+ chainedObserver: function() {
this.normal2 = 'chainedPropertyObserved' ;
}
@@ -802,8 +802,8 @@ QUnit.module("object.removeObserver()", {
setup: function() {
ObjectD = ObservableObject.create({
- objectF:ObservableObject.create({
- propertyVal:"chainedProperty"
+ objectF: ObservableObject.create({
+ propertyVal: "chainedProperty"
}),
normal: 'value',
@@ -817,7 +817,7 @@ QUnit.module("object.removeObserver()", {
removeAction: function() {
this.normal2 = 'newDependentValue';
},
- removeChainedObserver:function() {
+ removeChainedObserver: function() {
this.normal2 = 'chainedPropertyObserved' ;
},
@@ -896,7 +896,7 @@ QUnit.module("Bind function ", {
objectB = ObservableObject.create({
normal: "value",
- computed:function() {
+ computed: function() {
this.normal = 'newValue';
}
}) ; | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | .jscsrc | @@ -31,5 +31,6 @@
"while",
"with",
"return"
- ]
+ ],
+ "requireSpaceBetweenArguments": true
} | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-application/tests/system/dependency_injection/custom_resolver_test.js | @@ -5,7 +5,7 @@ import DefaultResolver from "ember-application/system/resolver";
var application;
-QUnit.module("Ember.Application Depedency Injection – customResolver",{
+QUnit.module("Ember.Application Depedency Injection – customResolver", {
setup: function() {
function fallbackTemplate() { return "<h1>Fallback</h1>"; }
| true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-application/tests/system/dependency_injection/to_string_test.js | @@ -7,7 +7,7 @@ import { guidFor } from "ember-metal/utils";
var originalLookup, App, originalModelInjections;
-QUnit.module("Ember.Application Dependency Injection – toString",{
+QUnit.module("Ember.Application Dependency Injection – toString", {
setup: function() {
originalModelInjections = Ember.MODEL_FACTORY_INJECTIONS;
Ember.MODEL_FACTORY_INJECTIONS = true;
@@ -45,7 +45,7 @@ test("instances", function() {
});
test("with a custom resolver", function() {
- run(App,'destroy');
+ run(App, 'destroy');
run(function(){
App = Application.create({ | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-htmlbars/tests/helpers/collection_test.js | @@ -641,14 +641,14 @@ test("should allow view objects to be swapped out without throwing an error (#78
ready: true,
items: A([1,2,3])
});
- TemplateTests.datasetController.set('dataset',dataset);
+ TemplateTests.datasetController.set('dataset', dataset);
});
equal(view.$('ul > li').length, 3, "renders the collection with the correct number of items when the dataset is ready");
run(function() {
secondDataset = EmberObject.create({ready: false});
- TemplateTests.datasetController.set('dataset',secondDataset);
+ TemplateTests.datasetController.set('dataset', secondDataset);
});
equal(view.$().text(), "Loading", "renders the loading text when the second dataset is not ready"); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/lib/keys.js | @@ -39,7 +39,7 @@ if (!keys || !canDefineNonEnumerableProperties) {
for (prop in obj) {
if (prop !== '_super' &&
- prop.lastIndexOf('__',0) !== 0 &&
+ prop.lastIndexOf('__', 0) !== 0 &&
hasOwnProperty.call(obj, prop)) {
result.push(prop);
} | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/tests/computed_test.js | @@ -623,7 +623,7 @@ testBoth('chained dependent keys should evaluate computed properties lazily', fu
QUnit.module('computed edge cases');
-test('adding a computed property should show up in key iteration',function() {
+test('adding a computed property should show up in key iteration', function() {
var obj = {};
defineProperty(obj, 'foo', computed(function() {})); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/tests/observer_test.js | @@ -55,7 +55,7 @@ testBoth('observer should fire when property is modified', function(get,set) {
testBoth('observer should fire when dependent property is modified', function(get, set) {
var obj = { bar: 'bar' };
defineProperty(obj, 'foo', computed(function() {
- return get(this,'bar').toUpperCase();
+ return get(this, 'bar').toUpperCase();
}).property('bar'));
get(obj, 'foo');
@@ -115,11 +115,11 @@ if (Ember.EXTEND_PROTOTYPES) {
var count = 0;
defineProperty(obj, 'foo', computed(function() {
- return get(this,'bar').toLowerCase();
+ return get(this, 'bar').toLowerCase();
}).property('bar'));
defineProperty(obj, 'bar', computed(function() {
- return get(this,'baz').toUpperCase();
+ return get(this, 'baz').toUpperCase();
}).property('baz'));
mixin(obj, {
@@ -163,11 +163,11 @@ testBoth('observers watching multiple properties via brace expansion should fire
var count = 0;
defineProperty(obj, 'foo', computed(function() {
- return get(this,'bar').toLowerCase();
+ return get(this, 'bar').toLowerCase();
}).property('bar'));
defineProperty(obj, 'bar', computed(function() {
- return get(this,'baz').toUpperCase();
+ return get(this, 'baz').toUpperCase();
}).property('baz'));
mixin(obj, {
@@ -190,7 +190,7 @@ testBoth('nested observers should fire in order', function(get,set) {
var fooCount = 0;
var barCount = 0;
- addObserver(obj, 'foo' ,function() { fooCount++; });
+ addObserver(obj, 'foo', function() { fooCount++; });
addObserver(obj, 'bar', function() {
set(obj, 'foo', 'BAZ');
equal(fooCount, 1, 'fooCount should have fired already');
@@ -425,7 +425,7 @@ testBoth('deferring property change notifications', function(get,set) {
var obj = { foo: 'foo' };
var fooCount = 0;
- addObserver(obj, 'foo' ,function() { fooCount++; });
+ addObserver(obj, 'foo', function() { fooCount++; });
beginPropertyChanges(obj);
set(obj, 'foo', 'BIFF');
@@ -441,7 +441,7 @@ testBoth('deferring property change notifications safely despite exceptions', fu
var exc = new Error("Something unexpected happened!");
expect(2);
- addObserver(obj, 'foo' ,function() { fooCount++; });
+ addObserver(obj, 'foo', function() { fooCount++; });
try {
changeProperties(function() {
@@ -469,7 +469,7 @@ testBoth('deferring property change notifications will not defer before observer
var obj = { foo: 'foo' };
var fooCount = 0;
- addBeforeObserver(obj, 'foo' ,function() { fooCount++; });
+ addBeforeObserver(obj, 'foo', function() { fooCount++; });
beginPropertyChanges(obj);
set(obj, 'foo', 'BIFF');
@@ -695,7 +695,7 @@ testBoth('observer should fire before a property is modified', function(get,set)
testBoth('observer should fire before dependent property is modified', function(get, set) {
var obj = { bar: 'bar' };
defineProperty(obj, 'foo', computed(function() {
- return get(this,'bar').toUpperCase();
+ return get(this, 'bar').toUpperCase();
}).property('bar'));
get(obj, 'foo');
@@ -736,11 +736,11 @@ if (Ember.EXTEND_PROTOTYPES) {
var count = 0;
defineProperty(obj, 'foo', computed(function() {
- return get(this,'bar').toLowerCase();
+ return get(this, 'bar').toLowerCase();
}).property('bar'));
defineProperty(obj, 'bar', computed(function() {
- return get(this,'baz').toUpperCase();
+ return get(this, 'baz').toUpperCase();
}).property('baz'));
mixin(obj, {
@@ -784,11 +784,11 @@ testBoth('before observer watching multiple properties via brace expansion shoul
var count = 0;
defineProperty(obj, 'foo', computed(function() {
- return get(this,'bar').toLowerCase();
+ return get(this, 'bar').toLowerCase();
}).property('bar'));
defineProperty(obj, 'bar', computed(function() {
- return get(this,'baz').toUpperCase();
+ return get(this, 'baz').toUpperCase();
}).property('baz'));
mixin(obj, { | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/tests/props_helper.js | @@ -5,8 +5,8 @@ import {set as setFromEmberMetal} from 'ember-metal/property_set';
// used by unit tests to test both accessor mode and non-accessor mode
var testBoth = function(testname, callback) {
- function emberget(x,y) { return getFromEmberMetal(x,y); }
- function emberset(x,y,z) { return setFromEmberMetal(x,y,z); }
+ function emberget(x,y) { return getFromEmberMetal(x, y); }
+ function emberset(x,y,z) { return setFromEmberMetal(x, y, z); }
function aget(x,y) { return x[y]; }
function aset(x,y,z) { return (x[y] = z); }
@@ -24,10 +24,10 @@ var testBoth = function(testname, callback) {
};
var testWithDefault = function(testname, callback) {
- function emberget(x,y) { return getFromEmberMetal(x,y); }
- function embergetwithdefault(x,y,z) { return getWithDefaultFromEmberMetal(x,y,z); }
- function getwithdefault(x,y,z) { return x.getWithDefault(y,z); }
- function emberset(x,y,z) { return setFromEmberMetal(x,y,z); }
+ function emberget(x,y) { return getFromEmberMetal(x, y); }
+ function embergetwithdefault(x,y,z) { return getWithDefaultFromEmberMetal(x, y, z); }
+ function getwithdefault(x,y,z) { return x.getWithDefault(y, z); }
+ function emberset(x,y,z) { return setFromEmberMetal(x, y, z); }
function aget(x,y) { return x[y]; }
function aset(x,y,z) { return (x[y] = z); }
| true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/tests/run_loop/add_queue_test.js | @@ -4,7 +4,7 @@ import { indexOf } from "ember-metal/array";
var originalQueues = run.queues;
var queues;
-QUnit.module('system/run_loop/add_queue_test',{
+QUnit.module('system/run_loop/add_queue_test', {
setup: function(){
run.queues = queues = ['blork', 'bleep'];
}, | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/tests/run_loop/debounce_test.js | @@ -2,7 +2,7 @@ import run from 'ember-metal/run_loop';
var originalDebounce = run.backburner.debounce;
var wasCalled = false;
-QUnit.module('Ember.run.debounce',{
+QUnit.module('Ember.run.debounce', {
setup: function() {
run.backburner.debounce = function() { wasCalled = true; };
}, | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/tests/utils/is_array_test.js | @@ -3,7 +3,7 @@ QUnit.module("Ember Type Checking");
var global = this;
-test("Ember.isArray" ,function() {
+test("Ember.isArray", function() {
var numarray = [1,2,3];
var number = 23;
var strarray = ["Hello", "Hi"]; | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/lib/compare.js | @@ -74,7 +74,7 @@ export default function compare(v, w) {
switch (type1) {
case 'boolean':
case 'number':
- return spaceship(v,w);
+ return spaceship(v, w);
case 'string':
return spaceship(v.localeCompare(w), 0); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/lib/mixins/enumerable.js | @@ -333,7 +333,7 @@ export default Mixin.create({
var ret = Ember.A();
this.forEach(function(x, idx, i) {
- ret[idx] = callback.call(target, x, idx,i);
+ ret[idx] = callback.call(target, x, idx, i);
});
return ret ;
@@ -1066,7 +1066,7 @@ export default Mixin.create({
if ('number' === typeof adding) {
addCnt = adding;
} else if (adding) {
- addCnt = get(adding,'length');
+ addCnt = get(adding, 'length');
} else {
addCnt = adding = -1;
} | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/computed/reduce_computed_macros_test.js | @@ -1036,7 +1036,7 @@ function sortByLnameFname(a, b) {
return lna > lnb ? 1 : -1;
}
- return sortByFnameAsc(a,b);
+ return sortByFnameAsc(a, b);
}
function sortByFnameAsc(a, b) { | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/computed/reduce_computed_test.js | @@ -316,7 +316,7 @@ test("modifying properties on dependent array items triggers observers exactly o
equal(removeCalls, 0, 'precond - removed has not been called');
run(function() {
- numbers.replace(0,2,[7,8,9,10]);
+ numbers.replace(0, 2, [7,8,9,10]);
});
equal(addCalls, 10, 'add is called for each item added'); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/core/isEqual_test.js | @@ -9,22 +9,22 @@ test("undefined and null", function() {
ok( !isEqual(null, undefined), "null is not equal to undefined" );
});
-test("strings should be equal",function() {
+test("strings should be equal", function() {
ok( !isEqual("Hello", "Hi"), "different Strings are unequal" );
ok( isEqual("Hello", "Hello"), "same Strings are equal" );
});
-test("numericals should be equal",function() {
+test("numericals should be equal", function() {
ok( isEqual(24, 24), "same numbers are equal" );
ok( !isEqual(24, 21), "different numbers are inequal" );
});
-test("dates should be equal",function() {
+test("dates should be equal", function() {
ok ( isEqual(new Date(1985, 7, 22), new Date(1985, 7, 22)), "same dates are equal" );
ok ( !isEqual(new Date(2014, 7, 22), new Date(1985, 7, 22)), "different dates are not equal" );
});
-test("array should be equal",function() {
+test("array should be equal", function() {
// NOTE: We don't test for array contents -- that would be too expensive.
ok( !isEqual( [1,2], [1,2] ), 'two array instances with the same values should not be equal' );
ok( !isEqual( [1,2], [1] ), 'two array instances with different values should not be equal' ); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/core/is_array_test.js | @@ -4,7 +4,7 @@ import ArrayProxy from "ember-runtime/system/array_proxy";
QUnit.module("Ember Type Checking");
-test("Ember.isArray" ,function() {
+test("Ember.isArray", function() {
var arrayProxy = ArrayProxy.create({ content: Ember.A() });
equal(isArray(arrayProxy), true, "[]"); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/legacy_1x/mixins/observable/observable_test.js | @@ -686,22 +686,22 @@ QUnit.module("Observable objects & object properties ", {
});
-test('incrementProperty and decrementProperty',function() {
+test('incrementProperty and decrementProperty', function() {
var newValue = object.incrementProperty('numberVal');
- equal(25,newValue,'numerical value incremented');
+ equal(25, newValue, 'numerical value incremented');
object.numberVal = 24;
newValue = object.decrementProperty('numberVal');
- equal(23,newValue,'numerical value decremented');
+ equal(23, newValue, 'numerical value decremented');
object.numberVal = 25;
newValue = object.incrementProperty('numberVal', 5);
- equal(30,newValue,'numerical value incremented by specified increment');
+ equal(30, newValue, 'numerical value incremented by specified increment');
object.numberVal = 25;
newValue = object.incrementProperty('numberVal', -5);
- equal(20,newValue,'minus numerical value incremented by specified increment');
+ equal(20, newValue, 'minus numerical value incremented by specified increment');
object.numberVal = 25;
newValue = object.incrementProperty('numberVal', 0);
- equal(25,newValue,'zero numerical value incremented by specified increment');
+ equal(25, newValue, 'zero numerical value incremented by specified increment');
expectAssertion(function() {
newValue = object.incrementProperty('numberVal', (0 - void(0))); // Increment by NaN
@@ -715,17 +715,17 @@ test('incrementProperty and decrementProperty',function() {
newValue = object.incrementProperty('numberVal', 1/0); // Increment by Infinity
}, /Must pass a numeric value to incrementProperty/i);
- equal(25,newValue,'Attempting to increment by non-numeric values should not increment value');
+ equal(25, newValue, 'Attempting to increment by non-numeric values should not increment value');
object.numberVal = 25;
- newValue = object.decrementProperty('numberVal',5);
- equal(20,newValue,'numerical value decremented by specified increment');
+ newValue = object.decrementProperty('numberVal', 5);
+ equal(20, newValue, 'numerical value decremented by specified increment');
object.numberVal = 25;
newValue = object.decrementProperty('numberVal', -5);
- equal(30,newValue,'minus numerical value decremented by specified increment');
+ equal(30, newValue, 'minus numerical value decremented by specified increment');
object.numberVal = 25;
newValue = object.decrementProperty('numberVal', 0);
- equal(25,newValue,'zero numerical value decremented by specified increment');
+ equal(25, newValue, 'zero numerical value decremented by specified increment');
expectAssertion(function() {
newValue = object.decrementProperty('numberVal', (0 - void(0))); // Decrement by NaN
@@ -739,17 +739,17 @@ test('incrementProperty and decrementProperty',function() {
newValue = object.decrementProperty('numberVal', 1/0); // Decrement by Infinity
}, /Must pass a numeric value to decrementProperty/i);
- equal(25,newValue,'Attempting to decrement by non-numeric values should not decrement value');
+ equal(25, newValue, 'Attempting to decrement by non-numeric values should not decrement value');
});
-test('toggle function, should be boolean',function() {
- equal(object.toggleProperty('toggleVal',true,false),object.get('toggleVal'));
- equal(object.toggleProperty('toggleVal',true,false),object.get('toggleVal'));
- equal(object.toggleProperty('toggleVal',undefined,undefined),object.get('toggleVal'));
+test('toggle function, should be boolean', function() {
+ equal(object.toggleProperty('toggleVal', true, false), object.get('toggleVal'));
+ equal(object.toggleProperty('toggleVal', true, false), object.get('toggleVal'));
+ equal(object.toggleProperty('toggleVal', undefined, undefined), object.get('toggleVal'));
});
-test('should notify array observer when array changes',function() {
- get(object, 'normalArray').replace(0,0,6);
+test('should notify array observer when array changes', function() {
+ get(object, 'normalArray').replace(0, 0, 6);
equal(object.abnormal, 'notifiedObserver', 'observer should be notified');
});
@@ -785,17 +785,17 @@ QUnit.module("object.addObserver()", {
test("should register an observer for a property", function() {
ObjectC.addObserver('normal', ObjectC, 'action');
- ObjectC.set('normal','newValue');
+ ObjectC.set('normal', 'newValue');
equal(ObjectC.normal1, 'newZeroValue');
});
test("should register an observer for a property - Special case of chained property", function() {
- ObjectC.addObserver('objectE.propertyVal',ObjectC,'chainedObserver');
- ObjectC.objectE.set('propertyVal',"chainedPropertyValue");
- equal('chainedPropertyObserved',ObjectC.normal2);
+ ObjectC.addObserver('objectE.propertyVal', ObjectC, 'chainedObserver');
+ ObjectC.objectE.set('propertyVal', "chainedPropertyValue");
+ equal('chainedPropertyObserved', ObjectC.normal2);
ObjectC.normal2 = 'dependentValue';
- ObjectC.set('objectE','');
- equal('chainedPropertyObserved',ObjectC.normal2);
+ ObjectC.set('objectE', '');
+ equal('chainedPropertyObserved', ObjectC.normal2);
});
QUnit.module("object.removeObserver()", {
@@ -842,26 +842,26 @@ QUnit.module("object.removeObserver()", {
test("should unregister an observer for a property", function() {
ObjectD.addObserver('normal', ObjectD, 'addAction');
- ObjectD.set('normal','newValue');
+ ObjectD.set('normal', 'newValue');
equal(ObjectD.normal1, 'newZeroValue');
- ObjectD.set('normal1','zeroValue');
+ ObjectD.set('normal1', 'zeroValue');
ObjectD.removeObserver('normal', ObjectD, 'addAction');
- ObjectD.set('normal','newValue');
+ ObjectD.set('normal', 'newValue');
equal(ObjectD.normal1, 'zeroValue');
});
test("should unregister an observer for a property - special case when key has a '.' in it.", function() {
- ObjectD.addObserver('objectF.propertyVal',ObjectD,'removeChainedObserver');
- ObjectD.objectF.set('propertyVal',"chainedPropertyValue");
- ObjectD.removeObserver('objectF.propertyVal',ObjectD,'removeChainedObserver');
+ ObjectD.addObserver('objectF.propertyVal', ObjectD, 'removeChainedObserver');
+ ObjectD.objectF.set('propertyVal', "chainedPropertyValue");
+ ObjectD.removeObserver('objectF.propertyVal', ObjectD, 'removeChainedObserver');
ObjectD.normal2 = 'dependentValue';
- ObjectD.objectF.set('propertyVal',"removedPropertyValue");
- equal('dependentValue',ObjectD.normal2);
- ObjectD.set('objectF','');
- equal('dependentValue',ObjectD.normal2);
+ ObjectD.objectF.set('propertyVal', "removedPropertyValue");
+ equal('dependentValue', ObjectD.normal2);
+ ObjectD.set('objectF', '');
+ equal('dependentValue', ObjectD.normal2);
});
@@ -917,7 +917,7 @@ QUnit.module("Bind function ", {
test("should bind property with method parameter as undefined", function() {
// creating binding
run(function() {
- objectA.bind("name", "Namespace.objectB.normal",undefined) ;
+ objectA.bind("name", "Namespace.objectB.normal", undefined) ;
});
// now make a change to see if the binding triggers. | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/legacy_1x/mixins/observable/propertyChanges_test.js | @@ -106,17 +106,17 @@ test("should indicate that the property of an object has just changed", function
ObjectA.propertyDidChange('foo', null) ;
// Values of prop has just changed
- equal(ObjectA.prop,'changedPropValue') ;
+ equal(ObjectA.prop, 'changedPropValue') ;
});
test("should notify that the property of an object has changed", function() {
// Notify to its subscriber that the values of 'newFoo' will be changed. In this
// case the observer is "newProp". Therefore this will call the notifyAction function
// and value of "newProp" will be changed.
- ObjectA.notifyPropertyChange('newFoo','fooValue');
+ ObjectA.notifyPropertyChange('newFoo', 'fooValue');
//value of newProp changed.
- equal(ObjectA.newProp,'changedNewPropValue') ;
+ equal(ObjectA.newProp, 'changedNewPropValue') ;
});
test("should invalidate function property cache when notifyPropertyChange is called", function() { | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/legacy_1x/system/binding_test.js | @@ -199,7 +199,7 @@ test("changing first output should propograte to third after flush", function()
equal("change", get(first, "output"), "first.output") ;
equal("change", get(second, "input"), "second.input") ;
equal("change", get(second, "output"), "second.output") ;
- equal("change", get(third,"input"), "third.input") ;
+ equal("change", get(third, "input"), "third.input") ;
});
// .......................................................... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/legacy_1x/system/object/base_test.js | @@ -54,7 +54,7 @@ test("Should return its properties when requested using EmberObject#get", functi
});
test("Should allow changing of those properties by calling EmberObject#set", function() {
- equal(get(obj,'foo'), 'bar') ;
+ equal(get(obj, 'foo'), 'bar') ;
equal(get(obj, 'total'), 12345) ;
set(obj, 'foo', 'Chunky Bacon' ) ; | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/legacy_1x/system/set_test.js | @@ -330,7 +330,7 @@ test("the copy() should return an identical set", function() {
obj = set.copy();
});
- equal(oldLength,obj.length,'length of the clone should be same');
+ equal(oldLength, obj.length, 'length of the clone should be same');
equal(obj.contains(set[0]), true);
equal(obj.contains(set[1]), true);
equal(obj.contains(set[2]), true); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/mixins/comparable_test.js | @@ -8,7 +8,7 @@ var Rectangle = EmberObject.extend(Comparable, {
width: 0,
area: function() {
- return get(this,'length') * get(this, 'width');
+ return get(this, 'length') * get(this, 'width');
},
compare: function(a, b) { | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/mixins/copyable_test.js | @@ -34,6 +34,6 @@ CopyableTests.extend({
return false;
}
- return get(a, 'id') === get(b,'id');
+ return get(a, 'id') === get(b, 'id');
}
}).run(); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/mixins/target_action_support_test.js | @@ -76,7 +76,7 @@ test("it should find targets specified using a property path", function() {
test("it should use an actionContext object specified as a property on the object", function() {
expect(2);
- var obj = EmberObject.createWithMixins(TargetActionSupport,{
+ var obj = EmberObject.createWithMixins(TargetActionSupport, {
action: 'anEvent',
actionContext: {},
target: EmberObject.create({
@@ -95,7 +95,7 @@ test("it should find an actionContext specified as a property path", function()
Ember.lookup = { Test: Test };
Test.aContext = {};
- var obj = EmberObject.createWithMixins(TargetActionSupport,{
+ var obj = EmberObject.createWithMixins(TargetActionSupport, {
action: 'anEvent',
actionContext: 'Test.aContext',
target: EmberObject.create({
@@ -114,7 +114,7 @@ test("it should use the target specified in the argument", function() {
ok(true, "anEvent method was called");
}
});
- var obj = EmberObject.createWithMixins(TargetActionSupport,{
+ var obj = EmberObject.createWithMixins(TargetActionSupport, {
action: 'anEvent'
});
@@ -124,7 +124,7 @@ test("it should use the target specified in the argument", function() {
test("it should use the action specified in the argument", function() {
expect(2);
- var obj = EmberObject.createWithMixins(TargetActionSupport,{
+ var obj = EmberObject.createWithMixins(TargetActionSupport, {
target: EmberObject.create({
anEvent: function() {
ok(true, "anEvent method was called");
@@ -137,7 +137,7 @@ test("it should use the action specified in the argument", function() {
test("it should use the actionContext specified in the argument", function() {
expect(2);
var context = {};
- var obj = EmberObject.createWithMixins(TargetActionSupport,{
+ var obj = EmberObject.createWithMixins(TargetActionSupport, {
target: EmberObject.create({
anEvent: function(ctx) {
ok(context === ctx, "anEvent method was called with the expected context");
@@ -153,7 +153,7 @@ test("it should allow multiple arguments from actionContext", function() {
expect(3);
var param1 = 'someParam';
var param2 = 'someOtherParam';
- var obj = EmberObject.createWithMixins(TargetActionSupport,{
+ var obj = EmberObject.createWithMixins(TargetActionSupport, {
target: EmberObject.create({
anEvent: function(first, second) {
ok(first === param1, "anEvent method was called with the expected first argument");
@@ -168,7 +168,7 @@ test("it should allow multiple arguments from actionContext", function() {
test("it should use a null value specified in the actionContext argument", function() {
expect(2);
- var obj = EmberObject.createWithMixins(TargetActionSupport,{
+ var obj = EmberObject.createWithMixins(TargetActionSupport, {
target: EmberObject.create({
anEvent: function(ctx) {
ok(null === ctx, "anEvent method was called with the expected context (null)"); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/suites/enumerable/any.js | @@ -31,7 +31,7 @@ suite.test('any should stop invoking when you return true', function() {
result = obj.any(function(i) { found.push(i); return --cnt <= 0; });
equal(result, true, 'return value of obj.any');
equal(found.length, exp, 'should invoke proper number of times');
- deepEqual(found, ary.slice(0,-2), 'items passed during any() should match');
+ deepEqual(found, ary.slice(0, -2), 'items passed during any() should match');
});
| true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/suites/enumerable/every.js | @@ -31,7 +31,7 @@ suite.test('every should stop invoking when you return false', function() {
result = obj.every(function(i) { found.push(i); return --cnt>0; });
equal(result, false, 'return value of obj.every');
equal(found.length, exp, 'should invoke proper number of times');
- deepEqual(found, ary.slice(0,-2), 'items passed during every() should match');
+ deepEqual(found, ary.slice(0, -2), 'items passed during every() should match');
});
// .......................................................... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/suites/enumerable/filter.js | @@ -19,7 +19,7 @@ suite.test('filter should invoke on each item', function() {
// return true on all but the last two
result = obj.filter(function(i) { found.push(i); return --cnt>=0; });
deepEqual(found, ary, 'should have invoked on each item');
- deepEqual(result, ary.slice(0,-2), 'filtered array should exclude items');
+ deepEqual(result, ary.slice(0, -2), 'filtered array should exclude items');
});
// .......................................................... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/suites/enumerable/find.js | @@ -30,7 +30,7 @@ suite.test('every should stop invoking when you return true', function() {
result = obj.find(function(i) { found.push(i); return --cnt >= 0; });
equal(result, ary[exp-1], 'return value of obj.find');
equal(found.length, exp, 'should invoke proper number of times');
- deepEqual(found, ary.slice(0,-2), 'items passed during find() should match');
+ deepEqual(found, ary.slice(0, -2), 'items passed during find() should match');
});
// .......................................................... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/suites/mutable_array/removeAt.js | @@ -108,7 +108,7 @@ suite.test("[A,B,C,D].removeAt(1,2) => [A,D] + notify", function() {
observer = this.newObserver(obj, '[]', '@each', 'length', 'firstObject', 'lastObject');
obj.getProperties('firstObject', 'lastObject'); /* Prime the cache */
- equal(obj.removeAt(1,2), obj, 'return self');
+ equal(obj.removeAt(1, 2), obj, 'return self');
deepEqual(this.toArray(obj), after, 'post item results');
equal(get(obj, 'length'), after.length, 'length'); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/suites/mutable_array/replace.js | @@ -12,7 +12,7 @@ suite.test("[].replace(0,0,'X') => ['X'] + notify", function() {
observer = this.newObserver(obj, '[]', '@each', 'length', 'firstObject', 'lastObject');
obj.getProperties('firstObject', 'lastObject'); /* Prime the cache */
- obj.replace(0,0,exp) ;
+ obj.replace(0, 0, exp) ;
deepEqual(this.toArray(obj), exp, 'post item results');
@@ -34,7 +34,7 @@ suite.test("[A,B,C,D].replace(1,2,X) => [A,X,D] + notify", function() {
observer = this.newObserver(obj, '[]', '@each', 'length', 'firstObject', 'lastObject');
obj.getProperties('firstObject', 'lastObject'); /* Prime the cache */
- obj.replace(1,2,replace) ;
+ obj.replace(1, 2, replace) ;
deepEqual(this.toArray(obj), after, 'post item results');
@@ -57,7 +57,7 @@ suite.test("[A,B,C,D].replace(1,2,[X,Y]) => [A,X,Y,D] + notify", function() {
observer = this.newObserver(obj, '[]', '@each', 'length', 'firstObject', 'lastObject');
obj.getProperties('firstObject', 'lastObject'); /* Prime the cache */
- obj.replace(1,2,replace) ;
+ obj.replace(1, 2, replace) ;
deepEqual(this.toArray(obj), after, 'post item results');
@@ -80,7 +80,7 @@ suite.test("[A,B].replace(1,0,[X,Y]) => [A,X,Y,B] + notify", function() {
observer = this.newObserver(obj, '[]', '@each', 'length', 'firstObject', 'lastObject');
obj.getProperties('firstObject', 'lastObject'); /* Prime the cache */
- obj.replace(1,0,replace) ;
+ obj.replace(1, 0, replace) ;
deepEqual(this.toArray(obj), after, 'post item results');
@@ -102,7 +102,7 @@ suite.test("[A,B,C,D].replace(2,2) => [A,B] + notify", function() {
observer = this.newObserver(obj, '[]', '@each', 'length', 'firstObject', 'lastObject');
obj.getProperties('firstObject', 'lastObject'); /* Prime the cache */
- obj.replace(2,2);
+ obj.replace(2, 2);
deepEqual(this.toArray(obj), after, 'post item results');
| true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/system/array_proxy/arranged_content_test.js | @@ -54,7 +54,7 @@ test("indexOf - returns index of object in arrangedContent", function() {
test("insertAt - raises, indeterminate behavior", function() {
raises(function() {
- run(function() { array.insertAt(2,3); });
+ run(function() { array.insertAt(2, 3); });
});
});
@@ -98,7 +98,7 @@ test("pushObjects - adds multiple to end of content even if it already exists",
});
test("removeAt - removes from index in arrangedContent", function() {
- run(function() { array.removeAt(1,2); });
+ run(function() { array.removeAt(1, 2); });
deepEqual(array.get('content'), [1,5]);
});
@@ -142,7 +142,7 @@ test("shiftObject - removes from start of arrangedContent", function() {
});
test("slice - returns a slice of the arrangedContent", function() {
- deepEqual(array.slice(1,3), [4,2], 'returns sliced arrangedContent');
+ deepEqual(array.slice(1, 3), [4,2], 'returns sliced arrangedContent');
});
test("toArray - returns copy of arrangedContent", function() {
@@ -282,7 +282,7 @@ test("shiftObject - removes from start of arrangedContent", function() {
});
test("slice - returns a slice of the arrangedContent", function() {
- deepEqual(array.slice(1,3), ['4','2'], 'returns sliced arrangedContent');
+ deepEqual(array.slice(1, 3), ['4','2'], 'returns sliced arrangedContent');
});
test("toArray - returns copy of arrangedContent", function() { | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/system/namespace/base_test.js | @@ -114,7 +114,7 @@ test("A nested namespace can be looked up by its name", function() {
test("Destroying a namespace before caching lookup removes it from the list of namespaces", function(){
var CF = lookup.CF = Namespace.create();
- run(CF,'destroy');
+ run(CF, 'destroy');
equal(Namespace.byName('CF'), undefined, "namespace can not be found after destroyed");
});
@@ -123,6 +123,6 @@ test("Destroying a namespace after looking up removes it from the list of namesp
equal(Namespace.byName('CF'), CF, "precondition - namespace can be looked up by name");
- run(CF,'destroy');
+ run(CF, 'destroy');
equal(Namespace.byName('CF'), undefined, "namespace can not be found after destroyed");
}); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/system/object/create_test.js | @@ -243,7 +243,7 @@ test('creating an object with required properties', function() {
});
var obj = ClassA.createWithMixins({ foo: 'FOO' }); // should not throw
- equal(get(obj,'foo'), 'FOO');
+ equal(get(obj, 'foo'), 'FOO');
});
| true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-views/tests/system/event_dispatcher_test.js | @@ -243,7 +243,7 @@ test("event manager should be able to re-dispatch events to view", function() {
// multiple eventManagers in a single view
// hierarchy would break, but it shows that
// re-dispatching works
- view.$().trigger('mousedown',this);
+ view.$().trigger('mousedown', this);
}
}),
| true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-views/tests/views/text_field_test.js | @@ -43,7 +43,7 @@ var setCaretPosition = function(element, pos) {
if (ctrl.setSelectionRange) {
ctrl.focus();
- ctrl.setSelectionRange(pos,pos);
+ ctrl.setSelectionRange(pos, pos);
} else if (ctrl.createTextRange) {
var range = ctrl.createTextRange();
range.collapse(true); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember/tests/helpers/link_to_test.js | @@ -320,7 +320,7 @@ test("The {{link-to}} helper does not disregard current-when when it is given ex
this.route("about");
});
- this.resource("items",function(){
+ this.resource("items", function(){
this.route('item');
});
}); | true |
Other | emberjs | ember.js | 6218a65476ac4a8fb5906ae9d3a0c2be18a6d0a8.json | Update HTMLBars to 0.7.1. | package.json | @@ -20,7 +20,7 @@
"emberjs-build": "0.0.10",
"express": "^4.5.0",
"glob": "~3.2.8",
- "htmlbars": "0.7.0",
+ "htmlbars": "0.7.1",
"qunit-extras": "^1.3.0",
"qunitjs": "^1.16.0",
"rsvp": "~3.0.6" | false |
Other | emberjs | ember.js | 5849897a343c30169b83004b18a4e1c475a68c1e.json | Disallow trailing commas with JSCS. | .jscsrc | @@ -11,5 +11,6 @@
"do",
"try",
"catch"
- ]
+ ],
+ "disallowTrailingComma": true
} | false |
Other | emberjs | ember.js | 14be80cc6af1ed4cc203cb8b1f6a200f7cf3e400.json | expose Registry as Ember.Registry | packages/ember-runtime/lib/main.js | @@ -17,7 +17,7 @@ import Namespace from 'ember-runtime/system/namespace';
import EmberObject from 'ember-runtime/system/object';
import TrackedArray from 'ember-runtime/system/tracked_array';
import SubArray from 'ember-runtime/system/subarray';
-import { Container } from "ember-runtime/system/container";
+import { Container, Registry } from "ember-runtime/system/container";
import ArrayProxy from 'ember-runtime/system/array_proxy';
import ObjectProxy from 'ember-runtime/system/object_proxy';
import CoreObject from 'ember-runtime/system/core_object';
@@ -152,6 +152,7 @@ Ember.Object = EmberObject;
Ember.TrackedArray = TrackedArray;
Ember.SubArray = SubArray;
Ember.Container = Container;
+Ember.Registry = Registry;
Ember.Namespace = Namespace;
Ember.Enumerable = Enumerable;
Ember.ArrayProxy = ArrayProxy; | false |
Other | emberjs | ember.js | 374ff0a33709fd284c3f988cc4c32b0dcddde6b8.json | Require curly brackets. | .jscsrc | @@ -2,5 +2,14 @@
"esnext": true,
"excludeFiles": ["ember-runtime/ext/rsvp.js"],
"additionalRules": [ "lib/jscs-rules/*.js" ],
- "disallowMultipleVarDeclWithAssignment": true
+ "disallowMultipleVarDeclWithAssignment": true,
+ "requireCurlyBraces": [
+ "if",
+ "else",
+ "for",
+ "while",
+ "do",
+ "try",
+ "catch"
+ ]
} | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.