language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/lib/mixins/mutable_array.js | @@ -19,7 +19,6 @@ var EMPTY = [];
//
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import { isArray } from "ember-metal/utils";
import EmberError from "ember-metal/error";
import { | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/lib/mixins/sortable.js | @@ -6,7 +6,6 @@
import Ember from "ember-metal/core"; // Ember.assert, Ember.A
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import { forEach } from "ember-metal/enumerable_utils";
import { Mixin } from "ember-metal/mixin";
import MutableEnumerable from "ember-runtime/mixins/mutable_enumerable"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/lib/mixins/target_action_support.js | @@ -5,7 +5,6 @@
import Ember from "ember-metal/core"; // Ember.lookup, Ember.assert
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import { typeOf } from "ember-metal/utils";
import { Mixin } from "ember-metal/mixin";
import { computed } from "ember-metal/computed"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/lib/system/array_proxy.js | @@ -1,6 +1,5 @@
import Ember from "ember-metal/core"; // Ember.K, Ember.assert
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import {
isArray,
apply | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/lib/system/core_object.js | @@ -9,7 +9,6 @@ import Ember from "ember-metal/core";
// NOTE: this object should never be included directly. Instead use `Ember.Object`.
// We only define this separately so that `Ember.Set` can depend on it.
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import {
guidFor,
apply | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/lib/system/deferred.js | @@ -1,6 +1,5 @@
import Ember from 'ember-metal/core';
import DeferredMixin from "ember-runtime/mixins/deferred";
-import {get} from "ember-metal/property_get";
import EmberObject from "ember-runtime/system/object";
var Deferred = EmberObject.extend(DeferredMixin, { | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/lib/system/each_proxy.js | @@ -6,7 +6,6 @@
import Ember from "ember-metal/core"; // Ember.assert
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import { guidFor } from "ember-metal/utils";
import { forEach } from "ember-metal/enumerable_utils";
import { indexOf } from "ember-metal/array"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/lib/system/namespace.js | @@ -134,7 +134,7 @@ function tryIsNamespace(lookup, prop) {
function findNamespaces() {
var lookup = Ember.lookup;
- var obj, isNamespace;
+ var obj;
if (Namespace.PROCESSED) { return; }
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/lib/system/native_array.js | @@ -6,7 +6,6 @@
import Ember from "ember-metal/core"; // Ember.EXTEND_PROTOTYPES
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import {
_replace as replace,
forEach | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/lib/system/subarray.js | @@ -1,4 +1,3 @@
-import {get} from "ember-metal/property_get";
import EmberError from "ember-metal/error";
import EnumerableUtils from "ember-metal/enumerable_utils";
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/lib/system/tracked_array.js | @@ -50,7 +50,7 @@ TrackedArray.prototype = {
var arrayOperation = match.operation;
var arrayOperationIndex = match.index;
var arrayOperationRangeStart = match.rangeStart;
- var composeIndex, splitIndex, splitItems, splitArrayOperation, newArrayOperation;
+ var composeIndex, newArrayOperation;
newArrayOperation = new ArrayOperation(INSERT, count, newItems);
@@ -83,7 +83,6 @@ TrackedArray.prototype = {
if (count < 1) { return; }
var match = this._findArrayOperation(index);
- var arrayOperation = match.operation;
var arrayOperationIndex = match.index;
var arrayOperationRangeStart = match.rangeStart;
var newArrayOperation, composeIndex; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/computed/compose_computed_test.js | @@ -1,5 +1,4 @@
import Ember from 'ember-metal/core';
-import {metaFor} from 'ember-metal/utils';
import {addObserver} from 'ember-metal/observer';
import {computed} from 'ember-metal/computed';
import {mapBy, union, sort} from 'ember-runtime/computed/reduce_computed_macros';
@@ -216,7 +215,6 @@ if (Ember.FEATURES.isEnabled('composable-computed-properties')) {
testBoth('composable computed properties work with macros that have non-cp args', function (get, set) {
var equals = computed.equal;
- var not = computed.not;
var or = computed.or;
obj = EmberObject.extend({ | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/computed/reduce_computed_macros_test.js | @@ -1,12 +1,10 @@
import Ember from "ember-metal/core";
-import EnumerableUtils from 'ember-metal/enumerable_utils';
import EmberObject from 'ember-runtime/system/object';
import setProperties from "ember-metal/set_properties";
import ObjectProxy from 'ember-runtime/system/object_proxy';
import { get } from 'ember-metal/property_get';
import { set } from 'ember-metal/property_set';
import run from 'ember-metal/run_loop';
-import { computed } from 'ember-metal/computed';
import { addObserver } from "ember-metal/observer";
import {
beginPropertyChanges,
@@ -22,16 +20,13 @@ import {
sort as computedSort,
setDiff as computedSetDiff,
mapBy as computedMapBy,
- mapProperty,
filter as computedFilter,
filterBy as computedFilterBy,
uniq as computedUniq,
union as computedUnion,
intersect as computedIntersect
} from 'ember-runtime/computed/reduce_computed_macros';
-import NativeArray from "ember-runtime/system/native_array";
-
var obj, sorted, sortProps, items, userFnCalls, todos, filtered, union;
QUnit.module('computedMap', {
@@ -82,7 +77,7 @@ test("it maps simple properties", function() {
test("it caches properly", function() {
var array = get(obj, 'array');
- var mapped = get(obj, 'mapped');
+ get(obj, 'mapped');
equal(userFnCalls, 4, "precond - mapper called expected number of times");
@@ -198,7 +193,7 @@ QUnit.module('computedMapBy', {
});
test("it maps properties", function() {
- var mapped = get(obj, 'mapped');
+ get(obj, 'mapped');
deepEqual(get(obj, 'mapped'), [1, 3, 2, 1]);
@@ -216,7 +211,7 @@ test("it maps properties", function() {
});
test("it is observerable", function() {
- var mapped = get(obj, 'mapped');
+ get(obj, 'mapped');
var calls = 0;
deepEqual(get(obj, 'mapped'), [1, 3, 2, 1]);
@@ -275,7 +270,7 @@ test("it passes the index to the callback", function() {
test("it caches properly", function() {
var array = get(obj, 'array');
- var filtered = get(obj, 'filtered');
+ get(obj, 'filtered');
equal(userFnCalls, 8, "precond - filter called expected number of times");
@@ -348,7 +343,7 @@ test("the dependent array can be `clear`ed directly (#3272)", function() {
});
test("it updates as the array is replaced", function() {
- var array = get(obj, 'array');
+ get(obj, 'array');
var filtered = get(obj, 'filtered');
deepEqual(filtered, [2,4,6,8], "precond - filtered array is initially correct");
@@ -484,7 +479,7 @@ forEach.call([['uniq', computedUniq], ['union', computedUnion]], function (tuple
test("does not include duplicates", function() {
var array = get(obj, 'array');
var array2 = get(obj, 'array2');
- var array3 = get(obj, 'array3');
+ get(obj, 'array3');
var union = get(obj, 'union');
deepEqual(union, [1,2,3,4,5,6,7,8,9,10], alias + " does not include duplicates");
@@ -516,8 +511,8 @@ forEach.call([['uniq', computedUniq], ['union', computedUnion]], function (tuple
test("has set-union semantics", function() {
var array = get(obj, 'array');
- var array2 = get(obj, 'array2');
- var array3 = get(obj, 'array3');
+ get(obj, 'array2');
+ get(obj, 'array3');
var union = get(obj, 'union');
deepEqual(union, [1,2,3,4,5,6,7,8,9,10], alias + " is initially correct");
@@ -571,7 +566,7 @@ QUnit.module('computed.intersect', {
});
test("it has set-intersection semantics", function() {
- var array = get(obj, 'array');
+ get(obj, 'array');
var array2 = get(obj, 'array2');
var array3 = get(obj, 'array3');
var intersection = get(obj, 'intersection');
@@ -1040,10 +1035,6 @@ function sortByFnameAsc(a, b) {
return fna > fnb ? 1 : -1;
}
-function sortByFnameDesc(a, b) {
- return -sortByFnameAsc(a,b);
-}
-
QUnit.module('computedSort - sort function', {
setup: function() {
run(function() {
@@ -1369,7 +1360,7 @@ QUnit.module('Chaining array and reduced CPs', {
});
test("it computes interdependent array computed properties", function() {
- var mapped = get(obj, 'mapped');
+ get(obj, 'mapped');
equal(get(obj, 'max'), 3, 'sanity - it properly computes the maximum value');
equal(userFnCalls, 0, 'observer is not called on initialisation'); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/computed/reduce_computed_test.js | @@ -205,8 +205,6 @@ test("multiple dependent keys can be specified via brace expansion", function()
});
test("multiple item property keys can be specified via brace expansion", function() {
- var addedCalls = 0;
- var removedCalls = 0;
var expected = Ember.A();
var item = { propA: 'A', propB: 'B', propC: 'C' };
var obj = EmberObject.createWithMixins({
@@ -278,7 +276,7 @@ test("doubly nested item property keys (@each.foo.@each) are not supported", fun
});
test("after the first retrieval, array computed properties observe dependent arrays", function() {
- var numbers = get(obj, 'numbers');
+ get(obj, 'numbers');
var evenNumbers = get(obj, 'evenNumbers');
deepEqual(evenNumbers, [2, 4, 6], 'precond -- starts off with correct values');
@@ -292,7 +290,7 @@ test("after the first retrieval, array computed properties observe dependent arr
test("array observers are torn down when dependent arrays change", function() {
var numbers = get(obj, 'numbers');
- var evenNumbers = get(obj, 'evenNumbers');
+ get(obj, 'evenNumbers');
equal(addCalls, 6, 'precond - add has been called for each item in the array');
equal(removeCalls, 0, 'precond - removed has not been called');
@@ -492,7 +490,6 @@ test("removedItem is not erroneously called for dependent arrays during a recomp
return array;
}
- var dependentArray = Ember.A();
var options = {
addedItem: addedItem,
removedItem: removedItem
@@ -540,7 +537,7 @@ QUnit.module('arrayComputed - recomputation DKs', {
test("recomputations from `arrayComputed` observers add back dependent keys", function() {
var meta = metaFor(obj);
- var people = get(obj, 'people');
+ get(obj, 'people');
var titles;
equal(meta.deps, undefined, "precond - nobody depends on people'");
@@ -718,7 +715,6 @@ test("changeMeta includes item and index", function() {
});
test("changeMeta includes changedCount and arrayChanged", function() {
- var callbackLetters = [];
var obj = EmberObject.createWithMixins({
letters: Ember.A(['a', 'b']),
lettersArrayComputed: arrayComputed('letters', { | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/controllers/controller_test.js | @@ -1,4 +1,3 @@
-import Ember from "ember-metal/core";
import Controller from "ember-runtime/controllers/controller";
import ObjectController from "ember-runtime/controllers/object_controller";
import Mixin from "ember-metal/mixin"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/controllers/item_controller_class_test.js | @@ -180,7 +180,7 @@ test("when items are removed from the arrayController, their respective subconta
createArrayController();
var jaimeController = arrayController.objectAtContent(1);
var cerseiController = arrayController.objectAtContent(2);
- var subControllers = get(arrayController, '_subControllers');
+ get(arrayController, '_subControllers');
equal(!!jaimeController.isDestroyed, false, "precond - nobody is destroyed yet");
equal(!!cerseiController.isDestroyed, false, "precond - nobody is destroyed yet");
@@ -195,7 +195,6 @@ test("when items are removed from the arrayController, their respective subconta
test("one cannot remove wrapped model directly when specifying `itemController`", function() {
createArrayController();
- var jaimeController = arrayController.objectAtContent(1);
var cerseiController = arrayController.objectAtContent(2);
equal(arrayController.get('length'), 3, "precondition - array is in initial state");
@@ -213,7 +212,7 @@ test("when items are removed from the underlying array, their respective subcont
createArrayController();
var jaimeController = arrayController.objectAtContent(1);
var cerseiController = arrayController.objectAtContent(2);
- var subContainers = get(arrayController, 'subContainers');
+ get(arrayController, 'subContainers');
equal(!!jaimeController.isDestroying, false, "precond - nobody is destroyed yet");
equal(!!cerseiController.isDestroying, false, "precond - nobody is destroyed yet"); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/ext/function_test.js | @@ -1,4 +1,4 @@
-import {testWithDefault, testBoth} from 'ember-runtime/tests/props_helper';
+import {testBoth} from 'ember-runtime/tests/props_helper';
QUnit.module('Function.prototype.observes() helper');
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/ext/mixin_test.js | @@ -1,8 +1,8 @@
import {set} from "ember-metal/property_set";
import {get} from "ember-metal/property_get";
import {Mixin} from "ember-metal/mixin";
-import {create, platform} from "ember-metal/platform";
-import {Binding, isGlobalPath, bind, oneWay} from "ember-metal/binding";
+import { create } from "ember-metal/platform";
+import { Binding } from "ember-metal/binding";
import run from "ember-metal/run_loop";
QUnit.module('system/mixin/binding_test'); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/legacy_1x/mixins/observable/observable_test.js | @@ -1,5 +1,4 @@
import { get } from 'ember-metal/property_get';
-import { set } from 'ember-metal/property_set';
import { forEach } from 'ember-metal/enumerable_utils';
import { computed } from 'ember-metal/computed';
import run from 'ember-metal/run_loop'; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/legacy_1x/mixins/observable/observersForKey_test.js | @@ -11,10 +11,8 @@
// ========================================================================
// Ember.Observable Tests
// ========================================================================
-/*globals module test ok isObj equals expects Namespace */
import {get} from 'ember-metal/property_get';
-import {set} from 'ember-metal/property_set';
import EmberObject from 'ember-runtime/system/object';
import Observable from 'ember-runtime/mixins/observable';
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/legacy_1x/mixins/observable/propertyChanges_test.js | @@ -16,10 +16,7 @@
// ========================================================================
// Ember.Observable Tests
// ========================================================================
-/*globals module test ok isObj equals expects */
-import {get} from 'ember-metal/property_get';
-import {set} from 'ember-metal/property_set';
import EmberObject from 'ember-runtime/system/object';
import Observable from 'ember-runtime/mixins/observable';
import {computed} from 'ember-metal/computed'; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/legacy_1x/system/object/base_test.js | @@ -26,7 +26,7 @@ import EmberObject from 'ember-runtime/system/object';
// EmberObject Base Tests
// ========================================================================
-var obj, obj1, don, don1 ; // global variables
+var obj, obj1, don; // global variables
var TestNamespace, originalLookup, lookup;
QUnit.module("A new EmberObject instance", { | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/legacy_1x/system/object/concatenated_test.js | @@ -1,6 +1,5 @@
import Ember from "ember-metal/core";
import {get} from 'ember-metal/property_get';
-import {set} from 'ember-metal/property_set';
import EmberStringUtils from 'ember-runtime/system/string';
import EmberObject from 'ember-runtime/system/object';
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/legacy_1x/system/run_loop_test.js | @@ -1,6 +1,3 @@
-import Ember from "ember-metal/core";
-import {get} from 'ember-metal/property_get';
-import {set} from 'ember-metal/property_set';
import {observer as emberObserver} from 'ember-metal/mixin';
import run from "ember-metal/run_loop";
import {Binding} from "ember-metal/binding";
@@ -21,7 +18,7 @@ import EmberObject from 'ember-runtime/system/object';
broken anyway. I don't think it ever even worked.
*/
-var MyApp, binding1, binding2, previousPreventRunloop;
+var MyApp, binding1, binding2;
QUnit.module("System:run_loop() - chained binding", {
setup: function() { | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/legacy_1x/system/set_test.js | @@ -1,5 +1,5 @@
import Ember from "ember-metal/core";
-import {isNone, none} from 'ember-metal/is_none';
+import { isNone } from 'ember-metal/is_none';
import Set from "ember-runtime/system/set";
import EmberObject from 'ember-runtime/system/object';
import EmberArray from "ember-runtime/mixins/array"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/mixins/array_test.js | @@ -4,7 +4,7 @@ import {set} from "ember-metal/property_set";
import {addObserver} from "ember-metal/observer";
import {observer as emberObserver} from "ember-metal/mixin";
import {computed} from "ember-metal/computed";
-import {testWithDefault, testBoth} from 'ember-runtime/tests/props_helper';
+import { testBoth } from 'ember-runtime/tests/props_helper';
import {ArrayTests} from 'ember-runtime/tests/suites/array';
import EmberObject from 'ember-runtime/system/object';
import EmberArray from "ember-runtime/mixins/array"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/mixins/deferred_test.js | @@ -1,10 +1,9 @@
-/* global Promise:true,EmberDev */
+/* global EmberDev */
import Ember from 'ember-metal/core';
import run from 'ember-metal/run_loop';
import EmberObject from 'ember-runtime/system/object';
import Deferred from "ember-runtime/mixins/deferred";
-import RSVP from "ember-runtime/ext/rsvp";
var originalDeprecate;
@@ -124,7 +123,6 @@ test("resolve prevent reject", function() {
var deferred;
var resolved = false;
var rejected = false;
- var progress = 0;
run(function() {
deferred = EmberObject.createWithMixins(Deferred);
@@ -147,7 +145,6 @@ test("reject prevent resolve", function() {
var deferred;
var resolved = false;
var rejected = false;
- var progress = 0;
run(function() {
deferred = EmberObject.createWithMixins(Deferred); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/mixins/enumerable_test.js | @@ -5,7 +5,6 @@ import EmberObject from 'ember-runtime/system/object';
import Enumerable from 'ember-runtime/mixins/enumerable';
import EmberArray from 'ember-runtime/mixins/array';
import { get } from 'ember-metal/property_get';
-import { set } from 'ember-metal/property_set';
import { computed } from 'ember-metal/computed';
import { observer as emberObserver } from 'ember-metal/mixin';
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/mixins/mutable_enumerable_test.js | @@ -4,7 +4,6 @@ import { indexOf } from 'ember-metal/enumerable_utils';
import EmberObject from 'ember-runtime/system/object';
import { computed } from 'ember-metal/computed';
import { get } from 'ember-metal/property_get';
-import { set } from 'ember-metal/property_set';
/*
Implement a basic fake mutable array. This validates that any non-native | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/mixins/promise_proxy_test.js | @@ -20,11 +20,6 @@ QUnit.module("Ember.PromiseProxy - ObjectProxy", {
});
test("no promise, invoking then should raise", function(){
- var value = {
- firstName: 'stef',
- lastName: 'penner'
- };
-
var proxy = ObjectPromiseProxy.create();
raises(function(){
@@ -164,7 +159,7 @@ test("unhandled rejects still propogate to RSVP.on('error', ...) ", function(){
promise: deferred.promise
});
- var promise = proxy.get('promise');
+ proxy.get('promise');
function onerror(reason) {
equal(reason, expectedReason, 'expected reason'); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/mixins/sortable_test.js | @@ -1,5 +1,4 @@
import Ember from "ember-metal/core";
-import {get} from "ember-metal/property_get";
import {set} from "ember-metal/property_set";
import run from "ember-metal/run_loop";
import {observer as emberObserver} from "ember-metal/mixin"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/props_helper.js | @@ -21,7 +21,6 @@ var testBoth = function(testname, callback) {
};
var testWithDefault = function(testname, callback) {
- function get(x,y) { return x.get(y); }
function emberget(x,y) { return getFromEmberMetal(x,y); }
function embergetwithdefault(x,y,z) { return getWithDefaultFromEmberMetal(x,y,z); }
function getwithdefault(x,y,z) { return x.getWithDefault(y,z); } | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/suites/copyable.js | @@ -1,4 +1,4 @@
-import {Suite, SuiteModuleBuilder} from 'ember-runtime/tests/suites/suite';
+import { Suite } from 'ember-runtime/tests/suites/suite';
import {required} from "ember-metal/mixin";
var CopyableTests = Suite.extend({ | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/suites/enumerable.js | @@ -1,4 +1,4 @@
-import {Suite, SuiteModuleBuilder} from 'ember-runtime/tests/suites/suite';
+import { Suite } from 'ember-runtime/tests/suites/suite';
import EmberObject from "ember-runtime/system/object";
import {required} from "ember-metal/mixin";
import {guidFor, generateGuid} from "ember-metal/utils"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/suites/enumerable/any.js | @@ -68,7 +68,6 @@ suite.test('any should be aliased to some', function() {
var anyFound = [];
var someFound = [];
var cnt = ary.length - 2;
- var exp = cnt;
var anyResult, someResult;
anyResult = obj.any(function(i) { anyFound.push(i); return false; }); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/suites/enumerable/forEach.js | @@ -3,7 +3,6 @@ import {get} from 'ember-metal/property_get';
import {guidFor} from "ember-metal/utils";
var suite = SuiteModuleBuilder.create();
-var global = this;
suite.module('forEach');
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/suites/enumerable/map.js | @@ -4,7 +4,6 @@ import {get} from 'ember-metal/property_get';
import {guidFor} from "ember-metal/utils";
var suite = SuiteModuleBuilder.create();
-var global = this;
suite.module('map');
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/suites/mutable_array.js | @@ -1,4 +1,4 @@
-import {ArrayTests, ObserverClass} from 'ember-runtime/tests/suites/array';
+import { ArrayTests } from 'ember-runtime/tests/suites/array';
import insertAtTests from 'ember-runtime/tests/suites/mutable_array/insertAt';
import popObjectTests from 'ember-runtime/tests/suites/mutable_array/popObject'; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/suites/mutable_array/replace.js | @@ -93,7 +93,7 @@ suite.test("[A,B].replace(1,0,[X,Y]) => [A,X,Y,B] + notify", function() {
});
suite.test("[A,B,C,D].replace(2,2) => [A,B] + notify", function() {
- var obj, observer, before, replace, after;
+ var obj, observer, before, after;
before = this.newFixture(4);
after = [before[0], before[1]]; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/suites/mutable_enumerable.js | @@ -1,4 +1,4 @@
-import {EnumerableTests, ObserverClass} from 'ember-runtime/tests/suites/enumerable';
+import { EnumerableTests } from 'ember-runtime/tests/suites/enumerable';
import addObjectTests from 'ember-runtime/tests/suites/mutable_enumerable/addObject';
import removeObjectTests from 'ember-runtime/tests/suites/mutable_enumerable/removeObject'; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/suites/suite.js | @@ -1,8 +1,7 @@
import EmberObject from "ember-runtime/system/object";
import { required } from "ember-metal/mixin";
import {
- guidFor,
- generateGuid
+ guidFor
} from "ember-metal/utils";
import { get } from "ember-metal/property_get";
import { forEach } from "ember-metal/enumerable_utils"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/system/deferred_test.js | @@ -1,4 +1,3 @@
-import Ember from 'ember-metal/core';
import run from 'ember-metal/run_loop';
import Deferred from "ember-runtime/system/deferred";
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/system/lazy_load_test.js | @@ -1,4 +1,3 @@
-import Ember from 'ember-metal/core';
import run from 'ember-metal/run_loop';
import {onLoad, runLoadHooks} from "ember-runtime/system/lazy_load";
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/system/namespace/base_test.js | @@ -2,7 +2,6 @@ import Ember from "ember-metal/core";
import run from "ember-metal/run_loop";
import {get} from "ember-metal/property_get";
import EmberObject from "ember-runtime/system/object";
-import EmberArray from "ember-runtime/mixins/array";
import Namespace from "ember-runtime/system/namespace";
var originalLookup, lookup; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/system/object/computed_test.js | @@ -1,7 +1,7 @@
import {computed} from "ember-metal/computed";
import {get as emberGet} from "ember-metal/property_get";
import {observer} from "ember-metal/mixin";
-import {testWithDefault, testBoth} from 'ember-runtime/tests/props_helper';
+import { testWithDefault } from 'ember-runtime/tests/props_helper';
import EmberObject from "ember-runtime/system/object";
QUnit.module('EmberObject computed property'); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/system/object/create_test.js | @@ -85,7 +85,7 @@ test("calls setUnknownProperty if defined", function() {
}
});
- var o = MyClass.create({foo: 'bar'});
+ MyClass.create({foo: 'bar'});
ok(setUnknownPropertyCalled, 'setUnknownProperty was called');
});
@@ -115,7 +115,7 @@ test("throws if you try to 'mixin' a definition", function() {
});
expectAssertion(function() {
- var o = EmberObject.create(myMixin);
+ EmberObject.create(myMixin);
}, "Ember.Object.create no longer supports mixing in other definitions, use createWithMixins instead.");
});
@@ -139,7 +139,7 @@ test("throws if you try to pass anything a string as a parameter", function(){
var expected = "EmberObject.create only accepts an objects.";
throws(function() {
- var o = EmberObject.create("some-string");
+ EmberObject.create("some-string");
}, expected);
});
@@ -201,7 +201,7 @@ test("Configures _super() on methods with override", function() {
test("Calls init if defined", function() {
var completed = false;
- var obj = EmberObject.createWithMixins({
+ EmberObject.createWithMixins({
init: function() {
this._super();
completed = true;
@@ -227,7 +227,7 @@ test("Calls all mixin inits if defined", function() {
test("Triggers init", function() {
var completed = false;
- var obj = EmberObject.createWithMixins({
+ EmberObject.createWithMixins({
markAsCompleted: on("init", function(){
completed = true;
}) | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/system/object/destroy_test.js | @@ -1,4 +1,3 @@
-import Ember from "ember-metal/core";
import run from "ember-metal/run_loop";
import { platform } from "ember-metal/platform";
import { observer } from "ember-metal/mixin";
@@ -133,7 +132,7 @@ test("destroyed objects should not see each others changes during teardown but a
objs.c = new C();
- var longLivedObject = new LongLivedObject();
+ new LongLivedObject();
run(function () {
var keys = objectKeys(objs); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/system/object/observer_test.js | @@ -1,7 +1,7 @@
import Ember from "ember-metal/core";
import {observer} from "ember-metal/mixin";
import run from "ember-metal/run_loop";
-import {testWithDefault, testBoth} from 'ember-runtime/tests/props_helper';
+import {testBoth} from 'ember-runtime/tests/props_helper';
import EmberObject from "ember-runtime/system/object";
QUnit.module('EmberObject observer'); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/system/object/strict-mode-test.js | @@ -1,8 +1,5 @@
-import Ember from "ember-metal/core";
import EmberObject from "ember-runtime/system/object";
-var originalLookup, lookup;
-
QUnit.module('strict mode tests');
test('__superWrapper does not throw errors in strict mode', function() { | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/system/set/extra_test.js | @@ -1,6 +1,5 @@
import EnumerableUtils from "ember-metal/enumerable_utils";
import {get} from "ember-metal/property_get";
-import {set} from "ember-metal/property_set";
import {addObserver} from "ember-metal/observer";
import Set from "ember-runtime/system/set";
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/system/subarray_test.js | @@ -80,8 +80,6 @@ test("Retains split filters", function() {
});
test("`addItem` returns the index of the item in the subarray", function() {
- var indexes = [];
-
equal(subarray.addItem(0, true), 0, "`addItem` returns the index of the item in the subarray");
subarray.addItem(1, false);
equal(subarray.addItem(2, true), 1, "`addItem` returns the index of the item in the subarray"); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-runtime/tests/system/tracked_array_test.js | @@ -1,4 +1,3 @@
-import { forEach } from 'ember-metal/enumerable_utils';
import TrackedArray from "ember-runtime/system/tracked_array";
var trackedArray; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-testing/lib/adapters/adapter.js | @@ -1,5 +1,4 @@
import Ember from "ember-metal/core"; // Ember.K
-import { inspect } from "ember-metal/utils";
import EmberObject from "ember-runtime/system/object";
/** | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-testing/tests/adapters/qunit_test.js | @@ -1,4 +1,3 @@
-import Ember from "ember-metal/core"; // Ember.K
import run from "ember-metal/run_loop";
import QUnitAdapter from "ember-testing/adapters/qunit";
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-testing/tests/helpers_test.js | @@ -1,6 +1,5 @@
import Ember from "ember-metal/core";
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import run from "ember-metal/run_loop";
import EmberObject from "ember-runtime/system/object";
import RSVP from "ember-runtime/ext/rsvp"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-testing/tests/simple_setup.js | @@ -1,4 +1,3 @@
-import Ember from "ember-metal/core";
import run from "ember-metal/run_loop";
import jQuery from "ember-views/system/jquery";
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/lib/system/ext.js | @@ -8,6 +8,5 @@ import run from "ember-metal/run_loop";
// Add a new named queue for rendering views that happens
// after bindings have synced, and a queue for scheduling actions
// that that should occur after view rendering.
-var queues = run.queues;
run._addQueue('render', 'actions');
run._addQueue('afterRender', 'render'); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/lib/system/render_buffer.js | @@ -3,10 +3,6 @@
@submodule ember-views
*/
-import Ember from 'ember-metal/core'; // jQuery
-
-import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import { setInnerHTML } from "ember-views/system/utils";
import jQuery from "ember-views/system/jquery";
import {DOMHelper} from "morph"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/lib/system/renderer.js | @@ -12,21 +12,6 @@ function EmberRenderer() {
EmberRenderer.prototype = create(Renderer.prototype);
EmberRenderer.prototype.constructor = EmberRenderer;
-var BAD_TAG_NAME_TEST_REGEXP = /[^a-zA-Z0-9\-]/;
-var BAD_TAG_NAME_REPLACE_REGEXP = /[^a-zA-Z0-9\-]/g;
-
-function stripTagName(tagName) {
- if (!tagName) {
- return tagName;
- }
-
- if (!BAD_TAG_NAME_TEST_REGEXP.test(tagName)) {
- return tagName;
- }
-
- return tagName.replace(BAD_TAG_NAME_REPLACE_REGEXP, '');
-}
-
EmberRenderer.prototype.scheduleRender =
function EmberRenderer_scheduleRender(ctx, fn) {
return run.scheduleOnce('render', ctx, fn); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/lib/views/collection_view.js | @@ -5,9 +5,7 @@
*/
import Ember from "ember-metal/core"; // Ember.assert
-import { create } from "ember-metal/platform";
import { isGlobalPath } from "ember-metal/binding";
-import merge from "ember-metal/merge";
import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
import { fmt } from "ember-runtime/system/string"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/lib/views/container_view.js | @@ -19,7 +19,6 @@ import { forEach } from "ember-metal/enumerable_utils";
import { computed } from "ember-metal/computed";
import run from "ember-metal/run_loop";
import { defineProperty } from "ember-metal/properties";
-import renderBuffer from "ember-views/system/render_buffer";
import {
observer,
beforeObserver | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/lib/views/core_view.js | @@ -10,13 +10,9 @@ import ActionHandler from "ember-runtime/mixins/action_handler";
import { deprecateProperty } from "ember-metal/properties";
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import { computed } from "ember-metal/computed";
import { typeOf } from "ember-metal/utils";
-
-import { instrument } from "ember-metal/instrumentation";
-
/**
`Ember.CoreView` is an abstract class that exists to give view-like behavior
to both Ember's main view class `Ember.View` and other classes like | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/lib/views/states/default.js | @@ -1,7 +1,4 @@
import Ember from "ember-metal/core"; // Ember.K
-import {get} from "ember-metal/property_get";
-import {set} from "ember-metal/property_set";
-import run from "ember-metal/run_loop";
import EmberError from "ember-metal/error";
/** | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/lib/views/states/has_element.js | @@ -11,7 +11,6 @@ import EmberError from "ember-metal/error";
*/
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
var hasElement = create(_default);
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/lib/views/states/pre_render.js | @@ -1,7 +1,5 @@
import _default from "ember-views/views/states/default";
import { create } from "ember-metal/platform";
-import merge from "ember-metal/merge";
-import jQuery from "ember-views/system/jquery";
/**
@module ember | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/lib/views/view.js | @@ -13,9 +13,8 @@ import setProperties from "ember-metal/set_properties";
import run from "ember-metal/run_loop";
import { addObserver, removeObserver } from "ember-metal/observer";
-import { defineProperty, deprecateProperty } from "ember-metal/properties";
+import { defineProperty } from "ember-metal/properties";
import { guidFor } from "ember-metal/utils";
-import { meta } from "ember-metal/utils";
import { computed } from "ember-metal/computed";
import { observer } from "ember-metal/mixin";
@@ -57,7 +56,6 @@ import CoreView from "ember-views/views/core_view";
var childViewsProperty = computed(function() {
var childViews = this._childViews;
var ret = emberA();
- var view = this;
forEach(childViews, function(view) {
var currentChildViews;
@@ -1774,11 +1772,9 @@ var View = CoreView.extend({
@method destroy
*/
destroy: function() {
- var childViews = this._childViews;
// get parentView before calling super because it'll be destroyed
var nonVirtualParentView = get(this, 'parentView');
var viewName = this.viewName;
- var childLen, i;
if (!this._super()) { return; }
@@ -2003,10 +1999,6 @@ var View = CoreView.extend({
// once the view has been inserted into the DOM, legal manipulations
// are done on the DOM element.
-function notifyMutationListeners() {
- run.once(View, 'notifyMutationListeners');
-}
-
View.reopenClass({
/** | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/mixins/view_target_action_support_test.js | @@ -1,4 +1,3 @@
-import Ember from "ember-metal/core";
import EmberObject from "ember-runtime/system/object";
import View from "ember-views/views/view";
import ViewTargetActionSupport from "ember-views/mixins/view_target_action_support"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/system/event_dispatcher_test.js | @@ -1,6 +1,5 @@
import Ember from 'ember-metal/core'; // A, FEATURES, assert, TESTING_DEPRECATION
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import run from "ember-metal/run_loop";
import EmberObject from "ember-runtime/system/object"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/system/render_buffer_test.js | @@ -1,5 +1,3 @@
-import { set } from "ember-metal/property_set";
-import { get } from "ember-metal/property_get";
import jQuery from "ember-views/system/jquery";
import RenderBuffer from "ember-views/system/render_buffer";
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/instrumentation_test.js | @@ -3,8 +3,6 @@ import {
reset as instrumentationReset
} from "ember-metal/instrumentation";
import run from "ember-metal/run_loop";
-import { guidFor } from "ember-metal/utils";
-import { computed } from "ember-metal/computed";
import EmberView from "ember-views/views/view";
var view, beforeCalls, afterCalls; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/actions_test.js | @@ -1,6 +1,3 @@
-import Ember from "ember-metal/core";
-import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import run from "ember-metal/run_loop";
import { Mixin } from "ember-metal/mixin";
import Controller from "ember-runtime/controllers/controller";
@@ -97,7 +94,7 @@ test("Actions cannot be provided at create time", function() {
});
});
// but should be OK on an object that doesn't mix in Ember.ActionHandler
- var obj = EmberObject.create({
+ EmberObject.create({
actions: ['foo']
});
}); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/append_to_test.js | @@ -1,6 +1,4 @@
-import Ember from "ember-metal/core";
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import run from "ember-metal/run_loop";
import jQuery from "ember-views/system/jquery"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/attribute_bindings_test.js | @@ -1,5 +1,4 @@
import Ember from "ember-metal/core";
-import { get } from "ember-metal/property_get";
import run from "ember-metal/run_loop";
import { observersFor } from "ember-metal/observer";
import { changeProperties } from "ember-metal/property_events"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/child_views_test.js | @@ -1,5 +1,3 @@
-import Ember from "ember-metal/core";
-import { get } from "ember-metal/property_get";
import run from "ember-metal/run_loop";
import EmberView from "ember-views/views/view"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/class_name_bindings_test.js | @@ -1,5 +1,3 @@
-import Ember from "ember-metal/core";
-import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
import run from "ember-metal/run_loop";
import { changeProperties } from "ember-metal/property_events"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/context_test.js | @@ -1,4 +1,3 @@
-import Ember from "ember-metal/core";
import run from "ember-metal/run_loop";
import EmberView from "ember-views/views/view"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/controller_test.js | @@ -1,4 +1,3 @@
-import Ember from "ember-metal/core";
import run from "ember-metal/run_loop";
import ContainerView from "ember-views/views/container_view"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/element_test.js | @@ -2,11 +2,10 @@ import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
import run from "ember-metal/run_loop";
-import jQuery from "ember-views/system/jquery";
import EmberView from "ember-views/views/view";
import ContainerView from "ember-views/views/container_view";
-var parentView, child, parentDom, childDom, view;
+var parentView, view;
QUnit.module("Ember.View#element", {
teardown: function() { | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/evented_test.js | @@ -1,4 +1,3 @@
-import { get } from "ember-metal/property_get";
import run from "ember-metal/run_loop";
import EmberObject from "ember-runtime/system/object";
import EmberView from "ember-views/views/view"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/init_test.js | @@ -2,7 +2,6 @@ import Ember from "ember-metal/core";
import { get } from "ember-metal/property_get";
import run from "ember-metal/run_loop";
import { computed } from "ember-metal/computed";
-import EmberObject from "ember-runtime/system/object";
import EmberView from "ember-views/views/view";
var originalLookup = Ember.lookup; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/is_visible_test.js | @@ -1,7 +1,6 @@
import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
import run from "ember-metal/run_loop";
-import EmberObject from "ember-runtime/system/object";
import EmberView from "ember-views/views/view";
import ContainerView from "ember-views/views/container_view";
@@ -119,7 +118,6 @@ test("view should be notified after isVisible is set to false and the element ha
test("view should be notified after isVisible is set to false and the element has been hidden", function() {
view = View.create({ isVisible: true });
var childView = view.get('childViews').objectAt(0);
- var grandchildView = childView.get('childViews').objectAt(0);
run(function() {
view.append();
@@ -139,8 +137,6 @@ test("view should be notified after isVisible is set to false and the element ha
test("view should be notified after isVisible is set to true and the element has been shown", function() {
view = View.create({ isVisible: false });
- var childView = view.get('childViews').objectAt(0);
- var grandchildView = childView.get('childViews').objectAt(0);
run(function() {
view.append();
@@ -162,7 +158,6 @@ test("view should be notified after isVisible is set to true and the element has
test("if a view descends from a hidden view, making isVisible true should not trigger becameVisible", function() {
view = View.create({ isVisible: true });
var childView = view.get('childViews').objectAt(0);
- var grandchildView = childView.get('childViews').objectAt(0);
run(function() {
view.append();
@@ -192,7 +187,6 @@ test("if a view descends from a hidden view, making isVisible true should not tr
test("if a child view becomes visible while its parent is hidden, if its parent later becomes visible, it receives a becameVisible callback", function() {
view = View.create({ isVisible: false });
var childView = view.get('childViews').objectAt(0);
- var grandchildView = childView.get('childViews').objectAt(0);
run(function() {
view.append(); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/jquery_test.js | @@ -1,6 +1,5 @@
import { get } from "ember-metal/property_get";
import run from "ember-metal/run_loop";
-import EmberObject from "ember-runtime/system/object";
import EmberView from "ember-views/views/view";
var view ; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/nearest_of_type_test.js | @@ -1,5 +1,3 @@
-import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import run from "ember-metal/run_loop";
import { Mixin as EmberMixin } from "ember-metal/mixin";
import View from "ember-views/views/view"; | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/remove_test.js | @@ -1,5 +1,4 @@
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
import run from "ember-metal/run_loop";
import { indexOf } from "ember-metal/enumerable_utils";
import jQuery from "ember-views/system/jquery";
@@ -114,7 +113,6 @@ test("returns receiver", function() {
});
test("does nothing if not in parentView", function() {
- var callCount = 0;
child = View.create();
// monkey patch for testing... | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/render_test.js | @@ -1,6 +1,5 @@
import { get } from "ember-metal/property_get";
import run from "ember-metal/run_loop";
-import EmberObject from "ember-runtime/system/object";
import jQuery from "ember-views/system/jquery";
import EmberView from "ember-views/views/view";
import ContainerView from "ember-views/views/container_view";
@@ -20,9 +19,7 @@ QUnit.module("EmberView#render", {
test("default implementation does not render child views", function() {
var rendered = 0;
- var updated = 0;
var parentRendered = 0;
- var parentUpdated = 0 ;
view = ContainerView.createWithMixins({
childViews: ["child"],
@@ -52,7 +49,6 @@ test("default implementation does not render child views", function() {
test("should invoke renderChildViews if layer is destroyed then re-rendered", function() {
var rendered = 0;
var parentRendered = 0;
- var parentUpdated = 0 ;
view = ContainerView.createWithMixins({
childViews: ["child"],
@@ -92,10 +88,6 @@ test("should invoke renderChildViews if layer is destroyed then re-rendered", fu
});
test("should render child views with a different tagName", function() {
- var rendered = 0;
- var parentRendered = 0;
- var parentUpdated = 0 ;
-
view = ContainerView.create({
childViews: ["child"],
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/replace_in_test.js | @@ -4,7 +4,7 @@ import jQuery from "ember-views/system/jquery";
import EmberView from "ember-views/views/view";
import ContainerView from "ember-views/views/container_view";
-var View, view, willDestroyCalled, childView;
+var View, view;
QUnit.module("EmberView - replaceIn()", {
setup: function() { | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/transition_to_deprecation_test.js | @@ -1,4 +1,3 @@
-import { platform } from 'ember-metal/platform';
import EmberView from 'ember-views/views/view';
import run from 'ember-metal/run_loop';
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/view_lifecycle_test.js | @@ -1,5 +1,4 @@
import Ember from "ember-metal/core";
-import { get } from "ember-metal/property_get";
import run from "ember-metal/run_loop";
import EmberObject from "ember-runtime/system/object";
import jQuery from "ember-views/system/jquery";
@@ -143,7 +142,7 @@ test("rerender should throw inside a template", function() {
}
});
- var child2 = view.appendChild(EmberView, {
+ view.appendChild(EmberView, {
template: function(context, options) {
options.data.buffer.push("Inside child2");
child1.rerender(); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember-views/tests/views/view/virtual_views_test.js | @@ -1,7 +1,5 @@
-import Ember from "ember-metal/core";
import { get } from "ember-metal/property_get";
import run from "ember-metal/run_loop";
-import EmberObject from "ember-runtime/system/object";
import jQuery from "ember-views/system/jquery";
import EmberView from "ember-views/views/view";
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember/tests/application_lifecycle.js | @@ -61,7 +61,7 @@ test("Resetting the application allows controller properties to be set when a ro
}
});
- var router = container.lookup('router:main');
+ container.lookup('router:main');
Ember.run(App, 'advanceReadiness');
@@ -98,7 +98,7 @@ test("Destroying the application resets the router before the container is destr
}
});
- var router = container.lookup('router:main');
+ container.lookup('router:main');
Ember.run(App, 'advanceReadiness');
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember/tests/helpers/link_to_test.js | @@ -1,7 +1,7 @@
import "ember";
-var Router, App, AppView, templates, router, eventDispatcher, container;
-var get = Ember.get, set = Ember.set, map = Ember.ArrayPolyfills.map;
+var Router, App, AppView, router, container;
+var set = Ember.set;
function bootApplication() {
router = container.lookup('router:main');
@@ -859,7 +859,6 @@ test("The {{link-to}} helper's bound parameter functionality works as expected i
equal(normalizeUrl($link.attr('href')), '/posts/1', 'self link renders post 1');
Ember.run(postController, 'set', 'model', secondPost);
- var linkView = Ember.View.views['self-link'];
equal(normalizeUrl($link.attr('href')), '/posts/2', 'self link updated to post 2');
}); | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember/tests/routing/basic_test.js | @@ -4,7 +4,7 @@ import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
import ActionManager from "ember-views/system/action_manager";
-var Router, App, AppView, templates, router, container, originalLoggerError;
+var Router, App, router, container, originalLoggerError;
var compile = Ember.Handlebars.compile;
function bootApplication() {
@@ -1035,7 +1035,7 @@ asyncTest("Nested callbacks are not exited when moving to siblings", function()
})
});
- var menuItem, resolve;
+ var menuItem;
App.MenuItem = Ember.Object.extend();
App.MenuItem.reopenClass({
@@ -1568,7 +1568,7 @@ test("Route inherits model from parent route", function() {
});
var post1 = {}, post2 = {}, post3 = {}, currentPost;
- var share1 = {}, share2 = {}, share3 = {}, currentShare;
+ var share1 = {}, share2 = {}, share3 = {};
var posts = {
1: post1, | true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember/tests/routing/query_params_test.js | @@ -1,15 +1,10 @@
import "ember";
-import {
- forEach,
- map
-} from "ember-metal/enumerable_utils";
import { computed } from "ember-metal/computed";
import { platform } from 'ember-metal/platform';
import { capitalize } from "ember-runtime/system/string";
-var Router, App, AppView, templates, router, container;
+var Router, App, router, container;
var get = Ember.get;
-var set = Ember.set;
var compile = Ember.Handlebars.compile;
function withoutMeta(object) {
@@ -41,26 +36,6 @@ function handleURL(path) {
});
}
-function handleURLAborts(path) {
- Ember.run(function() {
- router.handleURL(path).then(function(value) {
- ok(false, 'url: `' + path + '` was NOT to be handled');
- }, function(reason) {
- ok(reason && reason.message === "TransitionAborted", 'url: `' + path + '` was to be aborted');
- });
- });
-}
-
-function handleURLRejectsWith(path, expectedReason) {
- Ember.run(function() {
- router.handleURL(path).then(function(value) {
- ok(false, 'expected handleURLing: `' + path + '` to fail');
- }, function(reason) {
- equal(expectedReason, reason);
- });
- });
-}
-
var startingURL = '', expectedReplaceURL, expectedPushURL;
function setAndFlush(obj, prop, value) {
@@ -691,7 +666,7 @@ test("can opt into full transition by setting refreshModel in route queryParams
equal(parentModelCount, 1);
- var parentController = container.lookup('controller:parent');
+ container.lookup('controller:parent');
Ember.run(Ember.$('#parent-link'), 'click');
| true |
Other | emberjs | ember.js | bfd75e4f464e702608ed2bc3842a6b4d5b41eefa.json | remove unused vars and enforce in jshint | packages/ember/tests/routing/substates_test.js | @@ -1,7 +1,7 @@
import "ember";
-var Router, App, AppView, templates, router, container, counter;
-var get = Ember.get, set = Ember.set, compile = Ember.Handlebars.compile;
+var Router, App, templates, router, container, counter;
+var compile = Ember.Handlebars.compile;
function step(expectedValue, description) {
equal(counter, expectedValue, "Step " + expectedValue + ": " + description);
@@ -25,18 +25,6 @@ function bootApplication(startingURL) {
Ember.run(App, 'advanceReadiness');
}
-function handleURL(path) {
- return Ember.run(function() {
- return router.handleURL(path).then(function(value) {
- ok(true, 'url: `' + path + '` was handled');
- return value;
- }, function(reason) {
- ok(false, 'failed to visit:`' + path + '` reason: `' + QUnit.jsDump.parse(reason));
- throw reason;
- });
- });
-}
-
QUnit.module("Loading/Error Substates", {
setup: function() {
counter = 1;
@@ -334,8 +322,6 @@ test("Loading actions bubble to root, but don't enter substates above pivot", fu
var sallyDeferred = Ember.RSVP.defer();
var smellsDeferred = Ember.RSVP.defer();
- var shouldBubbleToApplication = true;
-
Router.map(function() {
this.resource('grandma', function() {
this.resource('mom', function() { | true |
Other | emberjs | ember.js | dc3d707141a39bb4dedee3f8e86d6b7ad39f2591.json | Prevent extra method.toString checks.
It appears that the intent here was to only check the
`method.toString().indexOf('_super')` once, and store the result so that
we do not need to check the same method twice, but we were never actual
storing `__hasSuper` on the method so it was just always going to check
the `toString`. | packages/ember-metal/lib/mixin.js | @@ -167,6 +167,7 @@ function giveMethodSuper(obj, key, method, values, descs) {
if (hasSuper === undefined) {
hasSuper = method.toString().indexOf('_super');
+ method.__hasSuper = hasSuper;
}
if (hasSuper) { | false |
Other | emberjs | ember.js | b3887a0d0ed5aeb31fdb0f7ce1c5c7e8cea99b16.json | Update CHANGELOG for 1.7 and 1.8.0-beta.1. | CHANGELOG.md | @@ -1,11 +1,54 @@
# Ember Changelog
+### Ember 1.8.0-beta.1 (August 20, 2014)
+
+* Remove `metamorph` in favor of `morph` package (removes the need for `<script>` tags in the DOM).
+* [FEATURE] ember-routing-linkto-target-attribute
+* [FEATURE] ember-routing-multi-current-when
+* [FEATURE] ember-routing-auto-location-uses-replace-state-for-history
+* [FEATURE] ember-metal-is-present
+* [FEATURE] property-brace-expansion-improvement
* Deprecate usage of Internet Explorer 6 & 7.
+* Deprecate global access to view classes from template (see the [deprecation guide](http://emberjs.com/guides/deprecations/)).
+* Deprecate `Ember.Set` (note: this is NOT the `Ember.set`).
+* Deprecate `Ember.computed.defaultTo`.
+* Remove long deprecated `Ember.StateManager` warnings.
+* Use intelligent caching for `Ember.String` (`camelize`, `dasherize`, etc.).
+* Use intelligent caching for container normalization.
+* Polyfill `Object.create` (use for new caching techniques).
+* Refactor internals to make debugging easier (use a single assignment per `var` statement).
* [BREAKING] Remove deprecated controller action lookup. Support for pre-1.0.0 applications with actions in the root
of the controller (instead of inside the `actions` hash) has been removed.
-### Ember 1.7.0-beta.2 (July, 16, 2014)
-
+### Ember 1.7.0 (August 19, 2014)
+
+* Update `Ember.computed.notEmpty` to properly respect arrays.
+* Bind `tabindex` property on LinkView.
+* Update to RSVP 3.0.13 (fixes an error with `RSVP.hash` in IE8 amongst other changes).
+* Fix incorrect quoteless action deprecation warnings.
+* Prevent duplicate message getting printed by errors in Route hooks.
+* Deprecate observing container views like arrays.
+* Add `catch` and `finally` to Transition.
+* [BUGFIX] paramsFor: don’t clobber falsy params.
+* [BUGFIX] Controllers with query params are unit testable.
+* [BUGFIX] Controllers have new QP values before setupController.
+* [BUGFIX] Fix initial render of {{input type=bound}} for checkboxes.
+* [BUGFIX] makeBoundHelper supports unquoted bound property options.
+* [BUGFIX] link-to helper can be inserted in DOM when the router is not present.
+* [PERFORMANCE] Do not pass `arguments` around in a hot-path.
+* Remove Container.defaultContainer.
+* Polyfill contains for older browsers.
+* [BUGFIX] Ensure that `triggerEvent` handles all argument signatures properly.
+* [BUGFIX] Stub meta on AliasedProperty (fixes regression from beta.2 with Ember Data).
+* [DOC] Fixed issue with docs showing 'Ember.run' as 'run.run'.
+* [BUGFIX] SimpleHandlebarsView should not re-render if normalized value is unchanged.
+* Allow Router DSL to nest routes via `this.route`.
+* [BUGFIX] Don't pass function UNDEFINED as oldValue to computed properties.
+* [BUGFIX] dramatically improve performance of eachComputedProperty.
+* [BUGFIX] Prevent strict mode errors from superWrapper.
+* Deprecate Ember.DeferredMixin and Ember.Deferred.
+* Deprecate `.then` on Ember.Application.
+* Revert ember-routing-consistent-resources.
* [BUGFIX] Wrap es3 keywords in quotes.
* [BUGFIX] Use injected integration test helpers instead of local functions.
* [BUGFIX] Add alias descriptor, and replace `Ember.computed.alias` with new descriptor.
@@ -16,9 +59,6 @@
* [BUGFIX] Use view:toplevel for {{view}} instead of view:default.
* [BUGFIX] Do not throw uncaught errors mid-transition.
* [BUGFIX] Don't assume that the router has a container.
-
-### Ember 1.7.0-beta.1 (July, 8, 2014)
-
* Fix components inside group helper.
* [BUGFIX] Fix wrong view keyword in a component block.
* Update to RSVP 3.0.7. | false |
Other | emberjs | ember.js | 2f2c8ac314f692599a7307242b0985f6347ed020.json | Remove isContainer flag | packages/ember-views/lib/system/renderer.js | @@ -37,25 +37,6 @@ EmberRenderer.prototype.cancelRender =
run.cancel(id);
};
-EmberRenderer.prototype.createChildViewsMorph =
- function EmberRenderer_createChildViewsMorph(view, _element) {
- if (view.createChildViewsMorph) {
- return view.createChildViewsMorph(_element);
- }
- var element = _element;
- if (view.tagName === '') {
- if (view._morph) {
- view._childViewsMorph = view._morph;
- } else {
- element = document.createDocumentFragment();
- view._childViewsMorph = this._dom.appendMorph(element);
- }
- } else {
- view._childViewsMorph = this._dom.createMorph(element, element.lastChild, null);
- }
- return element;
- };
-
EmberRenderer.prototype.createElement =
function EmberRenderer_createElement(view) {
// If this is the top-most view, start a new buffer. Otherwise,
@@ -91,10 +72,6 @@ EmberRenderer.prototype.createElement =
var element = buffer.element();
- if (view.isContainer) {
- this.createChildViewsMorph(view, element);
- }
-
view.buffer = null;
if (element && element.nodeType === 1) {
// We have hooks, we shouldn't make element observable | true |
Other | emberjs | ember.js | 2f2c8ac314f692599a7307242b0985f6347ed020.json | Remove isContainer flag | packages/ember-views/lib/views/container_view.js | @@ -184,7 +184,6 @@ var states = cloneStates(EmberViewStates);
@extends Ember.View
*/
var ContainerView = View.extend(MutableArray, {
- isContainer: true,
_states: states,
willWatchProperty: function(prop){
@@ -263,6 +262,21 @@ var ContainerView = View.extend(MutableArray, {
@param {Ember.RenderBuffer} buffer the buffer to render to
*/
render: function(buffer) {
+ var element = buffer.element();
+ var dom = buffer.dom;
+
+ if (this.tagName === '') {
+ if (this._morph) {
+ this._childViewsMorph = this._morph;
+ } else {
+ element = dom.createDocumentFragment();
+ this._childViewsMorph = dom.appendMorph(element);
+ }
+ } else {
+ this._childViewsMorph = dom.createMorph(element, element.lastChild, null);
+ }
+
+ return element;
},
instrumentName: 'container', | true |
Other | emberjs | ember.js | 2f2c8ac314f692599a7307242b0985f6347ed020.json | Remove isContainer flag | packages/ember-views/lib/views/core_view.js | @@ -35,7 +35,6 @@ import { instrument } from "ember-metal/instrumentation";
var CoreView = EmberObject.extend(Evented, ActionHandler, {
isView: true,
isVirtual: false,
- isContainer: false,
_states: cloneStates(states),
| true |
Other | emberjs | ember.js | 2f2c8ac314f692599a7307242b0985f6347ed020.json | Remove isContainer flag | packages/ember-views/tests/system/event_dispatcher_test.js | @@ -35,24 +35,22 @@ test("should dispatch events to views", function() {
var childKeyDownCalled = 0;
var parentKeyDownCalled = 0;
- view = ContainerView.createWithMixins({
- childViews: ['child'],
-
- child: View.extend({
- render: function(buffer) {
- buffer.push('<span id="wot">ewot</span>');
- },
+ var childView = View.createWithMixins({
+ render: function(buffer) {
+ buffer.push('<span id="wot">ewot</span>');
+ },
- keyDown: function(evt) {
- childKeyDownCalled++;
+ keyDown: function(evt) {
+ childKeyDownCalled++;
- return false;
- }
- }),
+ return false;
+ }
+ });
+ view = View.createWithMixins({
render: function(buffer) {
buffer.push('some <span id="awesome">awesome</span> content');
- this._super(buffer);
+ this.appendChild(childView);
},
mouseDown: function(evt) { | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.