language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
Homebrew
brew
532460c098d7417a7477f7f54e790133880e8d26.json
keg_relocate: fix new GCC lib directory Also add comment explaining what this line does, along with a TODO suggesting a replacement once we've shipped the GCC PR.
Library/Homebrew/extend/os/linux/keg_relocate.rb
@@ -32,7 +32,13 @@ def change_rpath(file, old_prefix, new_prefix) lib_path = "#{new_prefix}/lib" rpath << lib_path unless rpath.include? lib_path - rpath.prepend HOMEBREW_PREFIX/"opt/gcc/lib/current" if rpath.any? { |rp| rp.match?(%r{lib/gcc/\d+$}) } + + # Add GCC's lib directory (as of GCC 12+) to RPATH when there is existing linkage. + # This fixes linkage for newly-poured bottles. + # TODO: Replace with + # rpath.map! { |path| path = path.sub(%r{lib/gcc/\d+$}, "lib/gcc/current") } + # when Homebrew/homebrew-core#106755 is merged. + rpath.prepend HOMEBREW_PREFIX/"opt/gcc/lib/gcc/current" if rpath.any? { |rp| rp.match?(%r{lib/gcc/\d+$}) } rpath.join(":") end
false
Other
Homebrew
brew
41a526546661f400011d0ea56f7daa60cec458af.json
Improve messaging of debug source location
Library/Homebrew/mktemp.rb
@@ -29,6 +29,11 @@ def retain? @retain end + # True if the source files should be retained. + def retain_in_sources? + @retain_in_sources + end + # Instructs this Mktemp to not emit messages when retention is triggered. sig { void } def quiet! @@ -73,7 +78,10 @@ def run ignore_interrupts { chmod_rm_rf(tmpdir) } unless retain? end ensure - ohai "Temporary files retained at:", @tmpdir.to_s if retain? && !@tmpdir.nil? && !@quiet + if retain? && !@tmpdir.nil? && !@quiet + message = retain_in_sources? ? "Source files for debugging available at:" : "Temporary files retained at:" + ohai message, @tmpdir.to_s + end end private
false
Other
Homebrew
brew
b2d94dc897f25083cddb994c9b981834d9df6fd0.json
update arg names in docs and signature
Library/Homebrew/formula.rb
@@ -1625,18 +1625,19 @@ def extract_macho_slice_from(file, arch = Hardware::CPU.arch) end private :extract_macho_slice_from - # Generate shell completions for a formula for bash, zsh, and fish, using the formula's binary. + # Generate shell completions for a formula for bash, zsh, and fish, using the formula's executable. # # @param base_name [String] the base name of the generated completion script. Defaults to the formula name. # @param shells [Array<Symbol>] the shells to generate completion scripts for. Defaults to `[:bash, :zsh, :fish]`. - # @param binary [Pathname] the binary to use for generating the completion scripts. Defaults to the binary with the - # name of the formula. + # @param executable [Pathname] the executable to use for generating the completion scripts. Defaults to the + # executable with the name of the formula. # @param cmd [String] the command to pass to the `binary`. Defaults to 'completion'. - # @param shell_as_flag [Boolean] specify if `shells` should each be passed as flags to the `binary`. - # Defaults to `false`. + # @param shell_parameter_format [String]/[Symbol] specify how `shells` should each be passed + # to the `executable`. Takes either a String representing a prefix, or one of [:flag, :arg, :none]. + # Defaults to plainly passing the shell. sig { - params(base_name: String, shells: T::Array[Symbol], binary: Pathname, cmd: String, - shell_prefix: T.nilable(T.any(Symbol, String))).void + params(base_name: String, shells: T::Array[Symbol], executable: Pathname, cmd: String, + shell_parameter_format: T.nilable(T.any(Symbol, String))).void } def generate_completions_from_executable(base_name: name, shells: [:bash, :zsh, :fish],
false
Other
Homebrew
brew
7d1197e8eb938f30c3db9a8754c5557a8c08ed5c.json
audit_glibc: Permit glibc 2.27, 2.31, or 2.35
Library/Homebrew/formula_auditor.rb
@@ -411,7 +411,8 @@ def audit_postgresql def audit_glibc return unless @core_tap - return if formula.name != "glibc" || [OS::CI_GLIBC_VERSION, "2.35"].include?(formula.version.to_s) + return if formula.name != "glibc" + return if [OS::CI_GLIBC_VERSION, "2.27", "2.31", "2.35"].include?(formula.version.to_s) problem "The glibc version must be #{OS::CI_GLIBC_VERSION}, as this is the version used by our CI on Linux. " \ "Glibc is for users who have a system Glibc with a lower version, " \
false
Other
Homebrew
brew
1ac5fc05bd4c46c5f5812428790f465f531dec4e.json
audit_glibc: Permit glibc 2.35 See https://github.com/Homebrew/brew/issues/13619
Library/Homebrew/formula_auditor.rb
@@ -411,7 +411,7 @@ def audit_postgresql def audit_glibc return unless @core_tap - return if formula.name != "glibc" || formula.version.to_s == OS::CI_GLIBC_VERSION + return if formula.name != "glibc" || [OS::CI_GLIBC_VERSION, "2.35"].include?(formula.version.to_s) problem "The glibc version must be #{OS::CI_GLIBC_VERSION}, as this is the version used by our CI on Linux. " \ "Glibc is for users who have a system Glibc with a lower version, " \
false
Other
Homebrew
brew
291eacd4825273693f0ce117e3076d7bb1b2ae9f.json
audit_glibc: Fix the error message "The glibc version must be 2.35" should have read "The glibc version must be 2.23".
Library/Homebrew/formula_auditor.rb
@@ -410,13 +410,10 @@ def audit_postgresql end def audit_glibc - return if formula.name != "glibc" return unless @core_tap + return if formula.name != "glibc" || formula.version.to_s == OS::CI_GLIBC_VERSION - version = formula.version.to_s - return if version == OS::CI_GLIBC_VERSION - - problem "The glibc version must be #{version}, as this is the version used by our CI on Linux. " \ + problem "The glibc version must be #{OS::CI_GLIBC_VERSION}, as this is the version used by our CI on Linux. " \ "Glibc is for users who have a system Glibc with a lower version, " \ "which allows them to use our Linux bottles, which were compiled against system Glibc on CI." end
false
Other
Homebrew
brew
c42169249e6dce5eb39239eb314873977ba9e57b.json
cmd/update: stop fsmonitor after all Git operations complete Also, skip the status check, as that doesn't really help us.
Library/Homebrew/cmd/update.sh
@@ -556,12 +556,6 @@ EOS [[ -d "${DIR}/.git" ]] || continue cd "${DIR}" || continue - # Git's fsmonitor daemon will not release our lock unless we stop it. - if git fsmonitor--daemon status &>/dev/null - then - git fsmonitor--daemon stop 2>/dev/null - fi - if ! git config --local --get remote.origin.url &>/dev/null then opoo "No remote 'origin' in ${DIR}, skipping update!" @@ -746,6 +740,9 @@ EOS merge_or_rebase "${DIR}" "${TAP_VAR}" "${UPSTREAM_BRANCH}" [[ -n "${HOMEBREW_VERBOSE}" ]] && echo fi + + # Git's fsmonitor daemon will not release our lock unless we stop it. + git fsmonitor--daemon stop 2>/dev/null done if [[ -n "${HOMEBREW_INSTALL_FROM_API}" ]]
false
Other
Homebrew
brew
dff3fc9d2f9db62ec555e75b7902e699a828c6a4.json
fix symbol in SHELL env
Library/Homebrew/formula.rb
@@ -1664,7 +1664,7 @@ def generate_completions_from_executable(base_name: name, end script_path.dirname.mkpath - script_path.write Utils.safe_popen_read({ "SHELL" => shell }, executable, cmd, shell_parameter) + script_path.write Utils.safe_popen_read({ "SHELL" => shell.to_s }, executable, cmd, shell_parameter) end end
false
Other
Homebrew
brew
91065b9ddd24bcc3c279b1b120ec34a2b3810f8b.json
Improve flag passing for debug-symbols
Library/Homebrew/formula_installer.rb
@@ -879,9 +879,11 @@ def sanitized_argv_options args << "--debug" if debug? args << "--cc=#{@cc}" if @cc args << "--keep-tmp" if keep_tmp? - args << "--debug-symbols" if debug_symbols? - # Avoids dependecy error on flag - args << "--build-from-source" if build_from_source? && debug_symbols? + + if debug_symbols? + args << "--debug-symbols" + args << "--build-from-source" + end if @env.present? args << "--env=#{@env}"
false
Other
Homebrew
brew
f4cb9a40a6d5f14659b337beedfd6b537fb14e31.json
remove macos specific dummy call Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Library/Homebrew/keg.rb
@@ -533,8 +533,6 @@ def binary_executable_or_library_files def codesign_patched_binary(file); end - def dsymutil_binary(file); end - private def resolve_any_conflicts(dst, dry_run: false, verbose: false, overwrite: false)
false
Other
Homebrew
brew
2d4c792b0b6e74c06b9bc58ec93dbce50e89b67e.json
Make one function
Library/Homebrew/extend/os/mac/keg.rb
@@ -64,19 +64,17 @@ def codesign_patched_binary(file) end def dsymutil - binary_executable_or_library_files.each { |file| dsymutil_binary(file) } - end - - def dsymutil_binary(file) - odebug "Extracting symbols #{file}" + binary_executable_or_library_files.each do |file| + odebug "Extracting symbols #{file}" - result = system_command("dsymutil", args: [file]) - return if result.success? + result = system_command("dsymutil", args: [file]) + next if result.success? - # If it fails again, error out - onoe <<~EOS - Failed to extract symbols from #{file}: - #{result.stderr} - EOS + # If it fails again, error out + onoe <<~EOS + Failed to extract symbols from #{file}: + #{result.stderr} + EOS + end end end
false
Other
Homebrew
brew
d5d6456b24ac675dcf9a340b31cd9c987327c651.json
Add checks for `on_system` method
Library/Homebrew/rubocops/lines.rb
@@ -382,18 +382,40 @@ class OnSystemConditionals < FormulaCop NO_ON_SYSTEM_METHOD_NAMES = [:install, :post_install].freeze NO_ON_SYSTEM_BLOCK_NAMES = [:service, :test].freeze + ON_ARCH_OPTIONS = [:intel, :arm].freeze + ON_BASE_OS_OPTIONS = [:macos, :linux].freeze + ON_MACOS_VERSION_OPTIONS = MacOSVersions::SYMBOLS.keys.freeze + ALL_SYSTEM_OPTIONS = [*ON_ARCH_OPTIONS, *ON_BASE_OS_OPTIONS, *ON_MACOS_VERSION_OPTIONS, :system].freeze + MACOS_VERSION_CONDITIONALS = { "==" => nil, "<=" => :or_older, ">=" => :or_newer, }.freeze - def audit_formula(_node, _class_node, _parent_class_node, body_node) - on_arch_options = [:intel, :arm] - on_base_os_options = [:macos, :linux] - on_macos_version_options = MacOSVersions::SYMBOLS.keys - all_system_options = on_arch_options + on_base_os_options + on_macos_version_options + ON_SYSTEM_CONDITIONALS = [:<, :<=].freeze + + def on_system_method_info(on_system_option) + info = {} + info[:method] = :"on_#{on_system_option}" + info[:if_module], info[:if_method] = if ON_ARCH_OPTIONS.include?(on_system_option) + ["Hardware::CPU", :"#{on_system_option}?"] + elsif ON_BASE_OS_OPTIONS.include?(on_system_option) + ["OS", on_system_option == :macos ? :mac? : :linux?] + else + ["MacOS", :version] + end + info[:on_system_string] = "on_#{on_system_option}" + info[:if_string] = if on_system_option == :system + "if OS.linux? || MacOS.version" + else + "if #{info[:if_module]}.#{info[:if_method]}" + end + info + end + + def audit_formula(_node, _class_node, _parent_class_node, body_node) top_level_nodes_to_check = [] NO_ON_SYSTEM_METHOD_NAMES.each do |formula_method_name| method_node = find_method_def(body_node, formula_method_name) @@ -404,17 +426,8 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node) top_level_nodes_to_check << [formula_block_name, block_node] if block_node end - all_system_options.each do |on_system_option| - on_system_method = :"on_#{on_system_option}" - if_module_name, if_method_name = if on_arch_options.include?(on_system_option) - ["Hardware::CPU", :"#{on_system_option}?"] - elsif on_base_os_options.include?(on_system_option) - ["OS", on_system_option == :macos ? :mac? : :linux?] - else - ["MacOS", :version] - end - on_system_method_string = on_system_method.to_s - if_statement_string = "if #{if_module_name}.#{if_method_name}" + ALL_SYSTEM_OPTIONS.each do |on_system_option| + method_info = on_system_method_info(on_system_option) top_level_nodes_to_check.each do |top_level_name, top_level_node| top_level_node_string = if top_level_node.def_type? @@ -423,45 +436,60 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node) "#{top_level_name} do" end - find_every_method_call_by_name(top_level_node, on_system_method).each do |method| - if on_macos_version_options.include?(on_system_option) - on_macos_version_method_call(method, on_method: on_system_method) do |on_method_parameters| + find_every_method_call_by_name(top_level_node, method_info[:method]).each do |method| + if ON_MACOS_VERSION_OPTIONS.include?(on_system_option) + on_macos_version_method_call(method, on_method: method_info[:method]) do |on_method_parameters| if on_method_parameters.empty? - if_statement_string = "#{if_statement_string} == :#{on_system_option}" + method_info[:if_string] = "if MacOS.version == :#{on_system_option}" else - on_system_method_string = "#{on_system_method} :#{on_method_parameters.first}" + method_info[:on_system_string] = "#{method_info[:method]} :#{on_method_parameters.first}" if_condition_operator = MACOS_VERSION_CONDITIONALS.key(on_method_parameters.first) - if_statement_string = "#{if_statement_string} #{if_condition_operator} :#{on_system_option}" + method_info[:if_string] = "if MacOS.version #{if_condition_operator} :#{on_system_option}" end end + elsif method_info[:method] == :on_system + on_system_method_call(method) do |macos_symbol| + base_os, condition = macos_symbol.to_s.split(/_(?=or_)/).map(&:to_sym) + method_info[:on_system_string] = if condition.present? + "on_system :linux, macos: :#{base_os}_#{condition}" + else + "on_system :linux, macos: :#{base_os}" + end + if_condition_operator = MACOS_VERSION_CONDITIONALS.key(condition) + method_info[:if_string] = "if OS.linux? || MacOS.version #{if_condition_operator} :#{base_os}" + end end offending_node(method) - problem "Don't use `#{on_system_method_string}` in `#{top_level_node_string}`, " \ - "use `#{if_statement_string}` instead." do |corrector| + problem "Don't use `#{method_info[:on_system_string]}` in `#{top_level_node_string}`, " \ + "use `#{method_info[:if_string]}` instead." do |corrector| block_node = offending_node.parent next if block_node.type != :block # TODO: could fix corrector to handle this but punting for now. next if block_node.single_line? source_range = offending_node.source_range.join(offending_node.parent.loc.begin) - corrector.replace(source_range, if_statement_string) + corrector.replace(source_range, method_info[:if_string]) end end end + end - # Don't restrict OS.mac? or OS.linux? usage in taps; they don't care - # as much as we do about e.g. formulae.brew.sh generation, often use - # platform-specific URLs and we don't want to add DSLs to support - # that case. - next if formula_tap != "homebrew-core" + # Don't restrict OS.mac? or OS.linux? usage in taps; they don't care + # as much as we do about e.g. formulae.brew.sh generation, often use + # platform-specific URLs and we don't want to add DSLs to support + # that case. + return if formula_tap != "homebrew-core" + + ALL_SYSTEM_OPTIONS.each do |on_system_option| + method_info = on_system_method_info(on_system_option) if_nodes_to_check = [] - if on_arch_options.include?(on_system_option) - if_arch_node_search(body_node, arch: if_method_name) do |if_node, else_node| + if ON_ARCH_OPTIONS.include?(on_system_option) + if_arch_node_search(body_node, arch: method_info[:if_method]) do |if_node, else_node| else_info = if else_node.present? { can_autocorrect: true, @@ -472,8 +500,8 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node) if_nodes_to_check << [if_node, else_info] end - elsif on_base_os_options.include?(on_system_option) - if_base_os_node_search(body_node, base_os: if_method_name) do |if_node, else_node| + elsif ON_BASE_OS_OPTIONS.include?(on_system_option) + if_base_os_node_search(body_node, base_os: method_info[:if_method]) do |if_node, else_node| else_info = if else_node.present? { can_autocorrect: true, @@ -486,10 +514,16 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node) end else if_macos_version_node_search(body_node, os_name: on_system_option) do |if_node, operator, else_node| - if operator != :== && MACOS_VERSION_CONDITIONALS.key?(operator.to_s) - on_system_method_string = "#{on_system_method} :#{MACOS_VERSION_CONDITIONALS[operator.to_s]}" + if operator == :< + method_info[:on_system_string] = "on_system" + elsif operator == :<= + method_info[:on_system_string] = "on_system :linux, macos: :#{on_system_option}_or_older" + elsif operator != :== && MACOS_VERSION_CONDITIONALS.key?(operator.to_s) + method_info[:on_system_string] = "#{method_info[:method]} " \ + ":#{MACOS_VERSION_CONDITIONALS[operator.to_s]}" end - if_statement_string = "if #{if_module_name}.#{if_method_name} #{operator} :#{on_system_option}" + method_info[:if_string] = "if #{method_info[:if_module]}.#{method_info[:if_method]} #{operator} " \ + ":#{on_system_option}" if else_node.present? || !MACOS_VERSION_CONDITIONALS.key?(operator.to_s) else_info = { can_autocorrect: false } end @@ -519,20 +553,20 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node) offending_node(if_node) - problem "Don't use `#{if_statement_string}`, " \ - "use `#{on_system_method_string} do` instead." do |corrector| + problem "Don't use `#{method_info[:if_string]}`, " \ + "use `#{method_info[:on_system_string]} do` instead." do |corrector| # TODO: could fix corrector to handle this but punting for now. next if if_node.unless? if else_info.present? next unless else_info[:can_autocorrect] corrector.replace(if_node.source_range, - "#{on_system_method_string} do\n#{if_node.body.source}\nend\n" \ + "#{method_info[:on_system_string]} do\n#{if_node.body.source}\nend\n" \ "#{else_info[:on_system_method]} do\n#{else_info[:node].source}\nend") else corrector.replace(if_node.source_range, - "#{on_system_method_string} do\n#{if_node.body.source}\nend") + "#{method_info[:on_system_string]} do\n#{if_node.body.source}\nend") end end end @@ -543,6 +577,10 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node) (send nil? %on_method (sym ${:or_newer :or_older})?) PATTERN + def_node_matcher :on_system_method_call, <<~PATTERN + (send nil? :on_system (sym :linux) (hash (pair (sym :macos) (sym $_)))) + PATTERN + def_node_search :if_arch_node_search, <<~PATTERN $(if (send (const (const nil? :Hardware) :CPU) %arch) _ $_) PATTERN
true
Other
Homebrew
brew
d5d6456b24ac675dcf9a340b31cd9c987327c651.json
Add checks for `on_system` method
Library/Homebrew/rubocops/lines.rbi
@@ -7,6 +7,9 @@ module RuboCop sig { params(node: T.any, on_method: Symbol, block: T.proc.params(parameters: T::Array[T.any]).void).void } def on_macos_version_method_call(node, on_method:, &block); end + sig { params(node: T.any, block: T.proc.params(macos_symbol: Symbol).void).void } + def on_system_method_call(node, &block); end + sig { params(node: T.any, arch: Symbol, block: T.proc.params(node: T.any, else_node: T.any).void).void } def if_arch_node_search(node, arch:, &block); end
true
Other
Homebrew
brew
d5d6456b24ac675dcf9a340b31cd9c987327c651.json
Add checks for `on_system` method
Library/Homebrew/test/rubocops/text/on_system_conditionals_spec.rb
@@ -315,7 +315,7 @@ class Foo < Formula class Foo < Formula desc "foo" if MacOS.version <= :monterey - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't use `if MacOS.version <= :monterey`, use `on_monterey :or_older do` instead. + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't use `if MacOS.version <= :monterey`, use `on_system :linux, macos: :monterey_or_older do` instead. url 'https://brew.sh/mac-1.0.tgz' end end @@ -324,7 +324,7 @@ class Foo < Formula expect_correction(<<~RUBY) class Foo < Formula desc "foo" - on_monterey :or_older do + on_system :linux, macos: :monterey_or_older do url 'https://brew.sh/mac-1.0.tgz' end end @@ -336,7 +336,7 @@ class Foo < Formula class Foo < Formula desc "foo" if MacOS.version < :monterey - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't use `if MacOS.version < :monterey`, use `on_monterey do` instead. + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't use `if MacOS.version < :monterey`, use `on_system do` instead. url 'https://brew.sh/mac-1.0.tgz' end end @@ -456,6 +456,35 @@ def install RUBY end + it "reports an offense when `on_system :linux, macos: :monterey_or_newer` is used in install method" do + expect_offense(<<~RUBY, "/homebrew-core/Formula/foo.rb") + class Foo < Formula + desc "foo" + url 'https://brew.sh/foo-1.0.tgz' + + def install + on_system :linux, macos: :monterey_or_newer do + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't use `on_system :linux, macos: :monterey_or_newer` in `def install`, use `if OS.linux? || MacOS.version >= :monterey` instead. + true + end + end + end + RUBY + + expect_correction(<<~RUBY) + class Foo < Formula + desc "foo" + url 'https://brew.sh/foo-1.0.tgz' + + def install + if OS.linux? || MacOS.version >= :monterey + true + end + end + end + RUBY + end + it "reports an offense when `on_monterey` is used in test block" do expect_offense(<<~RUBY, "/homebrew-core/Formula/foo.rb") class Foo < Formula @@ -484,5 +513,34 @@ class Foo < Formula end RUBY end + + it "reports an offense when `on_system :linux, macos: :monterey` is used in test block" do + expect_offense(<<~RUBY, "/homebrew-core/Formula/foo.rb") + class Foo < Formula + desc "foo" + url 'https://brew.sh/foo-1.0.tgz' + + test do + on_system :linux, macos: :monterey do + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't use `on_system :linux, macos: :monterey` in `test do`, use `if OS.linux? || MacOS.version == :monterey` instead. + true + end + end + end + RUBY + + expect_correction(<<~RUBY) + class Foo < Formula + desc "foo" + url 'https://brew.sh/foo-1.0.tgz' + + test do + if OS.linux? || MacOS.version == :monterey + true + end + end + end + RUBY + end end end
true
Other
Homebrew
brew
7392f9811e6c5a03038b336d9560c6fa1d76682d.json
`Formulary`: use variations hash when installing from API
Library/Homebrew/formulary.rb
@@ -136,6 +136,11 @@ def self.load_formula_from_api(name, flags:) class_s = Formulary.class_s(name) json_formula = Homebrew::API::Formula.all_formulae[name] + bottle_tag = Utils::Bottles.tag.to_s + if json_formula.key?("variations") && json_formula["variations"].key?(bottle_tag) + json_formula = json_formula.merge(json_formula["variations"][bottle_tag]) + end + klass = Class.new(::Formula) do desc json_formula["desc"] homepage json_formula["homepage"]
true
Other
Homebrew
brew
7392f9811e6c5a03038b336d9560c6fa1d76682d.json
`Formulary`: use variations hash when installing from API
Library/Homebrew/test/formulary_spec.rb
@@ -260,6 +260,16 @@ def formula_json_contents(extra_items = {}) } end + let(:variations_json) do + { + "variations" => { + Utils::Bottles.tag.to_s => { + "dependencies" => ["dep", "variations_dep"], + }, + }, + } + end + before do allow(described_class).to receive(:loader_for).and_return(described_class::FormulaAPILoader.new(formula_name)) end @@ -303,6 +313,16 @@ def formula_json_contents(extra_items = {}) formula.install }.to raise_error("Cannot build from source from abstract formula.") end + + it "returns a Formula with variations when given a name", :needs_macos do + allow(Homebrew::API::Formula).to receive(:all_formulae).and_return formula_json_contents(variations_json) + allow(Utils::Bottles).to receive(:tag).and_return(:arm64_monterey) + + formula = described_class.factory(formula_name) + expect(formula).to be_kind_of(Formula) + expect(formula.deps.count).to eq 5 + expect(formula.deps.map(&:name).include?("variations_dep")).to be true + end end end
true
Other
Homebrew
brew
92bccd2074e7278e3bc71cd2f4c4c92b4b103875.json
apply naming suggestions
Library/Homebrew/formula.rb
@@ -1638,11 +1638,11 @@ def extract_macho_slice_from(file, arch = Hardware::CPU.arch) params(base_name: String, shells: T::Array[Symbol], binary: Pathname, cmd: String, shell_prefix: T.nilable(T.any(Symbol, String))).void } - def generate_completions(base_name: name, - shells: [:bash, :zsh, :fish], - binary: bin/base_name, - cmd: "completion", - shell_prefix: nil) + def generate_completions_from_executable(base_name: name, + shells: [:bash, :zsh, :fish], + executable: bin/base_name, + cmd: "completion", + shell_parameter: nil) completion_script_path_map = { bash: bash_completion/base_name, zsh: zsh_completion/"_#{base_name}", @@ -1651,16 +1651,16 @@ def generate_completions(base_name: name, shells.each do |shell| script_path = completion_script_path_map[shell] - shell_parameter = if shell_prefix.nil? + shell_parameter = if shell_parameter.nil? shell.to_s - elsif shell_prefix == :flag + elsif shell_parameter == :flag "--#{shell}" else - "#{shell_prefix}#{shell}" + "#{shell_parameter}#{shell}" end script_path.dirname.mkpath - script_path.write Utils.safe_popen_read({ "SHELL" => shell }, binary, cmd, shell_parameter) + script_path.write Utils.safe_popen_read({ "SHELL" => shell }, executable, cmd, shell_parameter) end end
false
Other
Homebrew
brew
ebf52091eb372171f529aff3324b6eb3af59c9c5.json
Check only formulas with resources
Library/Homebrew/dev-cmd/livecheck.rb
@@ -70,8 +70,8 @@ def livecheck casks = args.formula? ? [] : Cask::Caskroom.casks formulae + casks elsif args.resources? - livecheckable_resources = Formula.all.map { |formula| formula.resources }.flatten.filter{ |resource| resource.livecheckable? } - livecheckable_resources + formula_with_resources = Formula.all.select { |formula| formula.resources.any? } + formula_with_resources elsif args.all? formulae = args.cask? ? [] : Formula.all casks = args.formula? ? [] : Cask::Cask.all @@ -99,10 +99,10 @@ def livecheck raise UsageError, "A watchlist file is required when no arguments are given." end - p package_and_resource_to_check.class - p package_and_resource_to_check.length - p package_and_resource_to_check[0].class - p package_and_resource_to_check.map { |d| d.name } + # p package_and_resource_to_check.class + # p package_and_resource_to_check.length + # p package_and_resource_to_check[0].class + # p package_and_resource_to_check.map { |d| d.name } package_and_resource_to_check = package_and_resource_to_check.sort_by do |package_or_resource| package_or_resource.respond_to?(:token) ? package_or_resource.token : package_or_resource.name
false
Other
Homebrew
brew
e1f5fc7e69d8753f172a90886d4ae50ef43631b4.json
Update RBI files for rubocop.
Library/Homebrew/sorbet/rbi/gems/rubocop@1.32.0.rbi
@@ -3157,13 +3157,15 @@ class RuboCop::Cop::Layout::LineContinuationLeadingSpace < ::RuboCop::Cop::Base private def continuation?(line); end - def investigate(first_line, second_line, range_start); end - def offense_range(range_start, matches); end + def enforced_style_leading?; end + def investigate_leading_style(first_line, end_of_first_line); end + def investigate_trailing_style(second_line, end_of_first_line); end + def leading_offense_range(end_of_first_line, matches); end + def message(_range); end def raw_lines(node); end + def trailing_offense_range(end_of_first_line, matches); end end -RuboCop::Cop::Layout::LineContinuationLeadingSpace::MSG = T.let(T.unsafe(nil), String) - class RuboCop::Cop::Layout::LineContinuationSpacing < ::RuboCop::Cop::Base include ::RuboCop::Cop::RangeHelp extend ::RuboCop::Cop::AutoCorrector @@ -3216,6 +3218,7 @@ class RuboCop::Cop::Layout::LineLength < ::RuboCop::Cop::Base def max=(value); end def on_array(node); end def on_block(node); end + def on_def(node); end def on_hash(node); end def on_investigation_end; end def on_new_investigation; end @@ -3417,6 +3420,15 @@ RuboCop::Cop::Layout::MultilineMethodDefinitionBraceLayout::ALWAYS_SAME_LINE_MES RuboCop::Cop::Layout::MultilineMethodDefinitionBraceLayout::NEW_LINE_MESSAGE = T.let(T.unsafe(nil), String) RuboCop::Cop::Layout::MultilineMethodDefinitionBraceLayout::SAME_LINE_MESSAGE = T.let(T.unsafe(nil), String) +class RuboCop::Cop::Layout::MultilineMethodParameterLineBreaks < ::RuboCop::Cop::Base + include ::RuboCop::Cop::MultilineElementLineBreaks + extend ::RuboCop::Cop::AutoCorrector + + def on_def(node); end +end + +RuboCop::Cop::Layout::MultilineMethodParameterLineBreaks::MSG = T.let(T.unsafe(nil), String) + class RuboCop::Cop::Layout::MultilineOperationIndentation < ::RuboCop::Cop::Base include ::RuboCop::Cop::ConfigurableEnforcedStyle include ::RuboCop::Cop::Alignment @@ -5128,14 +5140,21 @@ class RuboCop::Cop::Lint::NonAtomicFileOperation < ::RuboCop::Cop::Base def allowable_use_with_if?(if_node); end def autocorrect(corrector, node, range); end + def autocorrect_replace_method(corrector, node); end + def force_method?(node); end + def force_method_name?(node); end def force_option?(node); end - def message(node); end + def if_node_child?(node); end + def message_remove_file_exist_check(node); end def register_offense(node, exist_node); end def replacement_method(node); end end +RuboCop::Cop::Lint::NonAtomicFileOperation::MAKE_FORCE_METHODS = T.let(T.unsafe(nil), Array) RuboCop::Cop::Lint::NonAtomicFileOperation::MAKE_METHODS = T.let(T.unsafe(nil), Array) -RuboCop::Cop::Lint::NonAtomicFileOperation::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::Lint::NonAtomicFileOperation::MSG_CHANGE_FORCE_METHOD = T.let(T.unsafe(nil), String) +RuboCop::Cop::Lint::NonAtomicFileOperation::MSG_REMOVE_FILE_EXIST_CHECK = T.let(T.unsafe(nil), String) +RuboCop::Cop::Lint::NonAtomicFileOperation::REMOVE_FORCE_METHODS = T.let(T.unsafe(nil), Array) RuboCop::Cop::Lint::NonAtomicFileOperation::REMOVE_METHODS = T.let(T.unsafe(nil), Array) RuboCop::Cop::Lint::NonAtomicFileOperation::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) @@ -5554,6 +5573,13 @@ end RuboCop::Cop::Lint::RequireParentheses::MSG = T.let(T.unsafe(nil), String) +class RuboCop::Cop::Lint::RequireRangeParentheses < ::RuboCop::Cop::Base + def on_erange(node); end + def on_irange(node); end +end + +RuboCop::Cop::Lint::RequireRangeParentheses::MSG = T.let(T.unsafe(nil), String) + class RuboCop::Cop::Lint::RequireRelativeSelfPath < ::RuboCop::Cop::Base include ::RuboCop::Cop::RangeHelp extend ::RuboCop::Cop::AutoCorrector @@ -5605,13 +5631,16 @@ RuboCop::Cop::Lint::ReturnInVoidContext::MSG = T.let(T.unsafe(nil), String) class RuboCop::Cop::Lint::SafeNavigationChain < ::RuboCop::Cop::Base include ::RuboCop::Cop::AllowedMethods include ::RuboCop::Cop::NilMethods + extend ::RuboCop::Cop::AutoCorrector extend ::RuboCop::Cop::TargetRubyVersion def bad_method?(param0 = T.unsafe(nil)); end def on_send(node); end private + def add_safe_navigation_operator(offense_range:, send_node:); end + def autocorrect(corrector, offense_range:, send_node:); end def method_chain(node); end end @@ -7127,11 +7156,16 @@ module RuboCop::Cop::PercentArray private def allowed_bracket_array?(node); end + def build_bracketed_array_with_appropriate_whitespace(elements:, node:); end + def build_message_for_bracketed_array(preferred_array_code); end def check_bracketed_array(node, literal_prefix); end def check_percent_array(node); end def comments_in_array?(node); end def invalid_percent_array_contents?(_node); end def invalid_percent_array_context?(node); end + def whitespace_between(node); end + def whitespace_leading(node); end + def whitespace_trailing(node); end end module RuboCop::Cop::PercentLiteral @@ -8551,6 +8585,16 @@ end RuboCop::Cop::Style::EmptyElse::MSG = T.let(T.unsafe(nil), String) +class RuboCop::Cop::Style::EmptyHeredoc < ::RuboCop::Cop::Base + include ::RuboCop::Cop::Heredoc + include ::RuboCop::Cop::RangeHelp + extend ::RuboCop::Cop::AutoCorrector + + def on_heredoc(node); end +end + +RuboCop::Cop::Style::EmptyHeredoc::MSG = T.let(T.unsafe(nil), String) + class RuboCop::Cop::Style::EmptyLambdaParameter < ::RuboCop::Cop::Base include ::RuboCop::Cop::EmptyParameter include ::RuboCop::Cop::RangeHelp @@ -8791,47 +8835,25 @@ RuboCop::Cop::Style::ExponentialNotation::MESSAGES = T.let(T.unsafe(nil), Hash) class RuboCop::Cop::Style::FetchEnvVar < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector - def block_control?(param0 = T.unsafe(nil)); end def env_with_bracket?(param0 = T.unsafe(nil)); end - def offensive_nodes(param0); end def on_send(node); end - def operand_of_or?(param0 = T.unsafe(nil)); end private def allowable_use?(node); end def allowed_var?(node); end def assigned?(node); end - def configured_indentation; end - def conterpart_rhs_of(node); end - def default_nil(node, name_node); end - def default_rhs(node, name_node); end - def default_rhs_in_outer_or(node, name_node); end - def default_rhs_in_same_or(node, name_node); end - def default_to_rhs?(node); end - def first_line_of(source); end - def left_end_of_or_chains?(node); end def message_chained_with_dot?(node); end - def message_template_for(rhs); end - def new_code_default_nil(name_node); end - def new_code_default_rhs(node, name_node); end - def new_code_default_rhs_multiline(node, name_node); end - def new_code_default_rhs_single_line(node, name_node); end + def new_code(name_node); end def offensive?(node); end - def or_chain_root(node); end + def or_lhs?(node); end def partial_matched?(node, condition); end - def rhs_can_be_default_value?(node); end - def rhs_is_block_control?(node); end - def right_end_of_or_chains?(node); end def used_as_flag?(node); end def used_if_condition_in_body(node); end def used_in_condition?(node, condition); end end -RuboCop::Cop::Style::FetchEnvVar::MSG_DEFAULT_NIL = T.let(T.unsafe(nil), String) -RuboCop::Cop::Style::FetchEnvVar::MSG_DEFAULT_RHS_MULTILINE_BLOCK = T.let(T.unsafe(nil), String) -RuboCop::Cop::Style::FetchEnvVar::MSG_DEFAULT_RHS_SECOND_ARG_OF_FETCH = T.let(T.unsafe(nil), String) -RuboCop::Cop::Style::FetchEnvVar::MSG_DEFAULT_RHS_SINGLE_LINE_BLOCK = T.let(T.unsafe(nil), String) +RuboCop::Cop::Style::FetchEnvVar::MSG = T.let(T.unsafe(nil), String) class RuboCop::Cop::Style::FileRead < ::RuboCop::Cop::Base include ::RuboCop::Cop::RangeHelp @@ -11453,8 +11475,10 @@ class RuboCop::Cop::Style::Semicolon < ::RuboCop::Cop::Base def check_for_line_terminator_or_opener; end def each_semicolon; end def expressions_per_line(exprs); end + def find_range_node(token_before_semicolon); end def find_semicolon_positions(line); end - def register_semicolon(line, column, after_expression); end + def range_nodes; end + def register_semicolon(line, column, after_expression, token_before_semicolon = T.unsafe(nil)); end def tokens_for_lines; end class << self @@ -11971,6 +11995,7 @@ class RuboCop::Cop::Style::TopLevelMethodDefinition < ::RuboCop::Cop::Base end RuboCop::Cop::Style::TopLevelMethodDefinition::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::Style::TopLevelMethodDefinition::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) class RuboCop::Cop::Style::TrailingBodyOnClass < ::RuboCop::Cop::Base include ::RuboCop::Cop::Alignment
false
Other
Homebrew
brew
243ff024e3944dedceb0d64712869385fc965d89.json
Remove debug message
Library/Homebrew/cmd/info.rb
@@ -222,7 +222,6 @@ def print_json(args:) if args.bottle? { "formulae" => formulae.map(&:to_recursive_bottle_hash) } elsif args.variations? - opoo "a" { "formulae" => formulae.map(&:to_hash_with_variations), "casks" => casks.map(&:to_hash_with_variations),
false
Other
Homebrew
brew
9f27bd4c678eb6f110744860a12fa42fae338e3b.json
simplify cached_formula_json_file check
Library/Homebrew/api/formula.rb
@@ -30,10 +30,8 @@ def fetch(name) def all_formulae @all_formulae ||= begin curl_args = %w[--compressed --silent https://formulae.brew.sh/api/formula.json] - if cached_formula_json_file.exist? - last_modified = cached_formula_json_file.mtime.utc - last_modified = last_modified.strftime("%a, %d %b %Y %H:%M:%S GMT") - curl_args = ["--time-cond", last_modified, *curl_args] unless cached_formula_json_file.empty? + if cached_formula_json_file.exist? && !cached_formula_json_file.empty? + curl_args.prepend("--time-cond", cached_formula_json_file) end curl_download(*curl_args, to: HOMEBREW_CACHE_API/"#{formula_api_path}.json", max_time: 5)
false
Other
Homebrew
brew
db9a878ef0679975a408c425dfb4e394be4397f4.json
Update RBI files for tzinfo.
Library/Homebrew/sorbet/rbi/gems/tzinfo@2.0.5.rbi
@@ -4,7 +4,11 @@ # This is an autogenerated file for types exported from the `tzinfo` gem. # Please instead update this file by running `bin/tapioca gem tzinfo`. -module TZInfo; end +module TZInfo + class << self + def eager_load!; end + end +end class TZInfo::AbsoluteDayOfYearTransitionRule < ::TZInfo::DayOfYearTransitionRule def initialize(day, transition_at = T.unsafe(nil)); end @@ -94,6 +98,7 @@ class TZInfo::DataSource def country_codes; end def data_timezone_identifiers; end + def eager_load!; end def get_country_info(code); end def get_timezone_info(identifier); end def inspect; end @@ -275,6 +280,7 @@ end TZInfo::DataSources::ZoneinfoDataSource::DEFAULT_ALTERNATE_ISO3166_TAB_SEARCH_PATH = T.let(T.unsafe(nil), Array) TZInfo::DataSources::ZoneinfoDataSource::DEFAULT_SEARCH_PATH = T.let(T.unsafe(nil), Array) +TZInfo::DataSources::ZoneinfoDataSource::EXCLUDED_FILENAMES = T.let(T.unsafe(nil), Array) class TZInfo::DataSources::ZoneinfoDirectoryNotFound < ::StandardError; end class TZInfo::DataSources::ZoneinfoReader
false
Other
Homebrew
brew
7a247fd52d1769797d578d23bdc4e1071f0304dd.json
shims/super/cc: add -nostdinc in cppflags
Library/Homebrew/shims/super/cc
@@ -292,8 +292,6 @@ class Cmd args.concat(optflags) unless runtime_cpu_detection? args.concat(archflags) args << "-std=#{@arg0}" if /c[89]9/.match?(@arg0) - # Add -nostdinc when building against glibc@2.13 to avoid mixing system and brewed glibc headers. - args << "-nostdinc" if @deps.include?("glibc@2.13") args end @@ -306,7 +304,11 @@ class Cmd end def cppflags - path_flags("-isystem", isystem_paths) + path_flags("-I", include_paths) + args = [] + args += path_flags("-isystem", isystem_paths) + path_flags("-I", include_paths) + # Add -nostdinc when building against glibc@2.13 to avoid mixing system and brewed glibc headers. + args << "-nostdinc" if @deps.include?("glibc@2.13") + args end def ldflags_mac(args) @@ -324,7 +326,11 @@ class Cmd def ldflags_linux(args) unless mode == :ld wl = "-Wl," - args << "-B#{@opt}/glibc/lib" + if @deps.include?("glibc@2.13") + args << "-B#{@opt}/glibc@2.13/lib" + else + args << "-B#{@opt}/glibc/lib" + end end args += rpath_flags("#{wl}-rpath=", rpath_paths) args += ["#{wl}--dynamic-linker=#{dynamic_linker_path}"] if dynamic_linker_path
false
Other
Homebrew
brew
8993ebca88e6462502d2bddae5393c54ba876a3d.json
use --time-cond when caching the formula api json
Library/Homebrew/api/formula.rb
@@ -33,7 +33,7 @@ def all_formulae if cached_formula_json_file.exist? last_modified = cached_formula_json_file.mtime.utc last_modified = last_modified.strftime("%a, %d %b %Y %H:%M:%S GMT") - curl_args = ["--header", "If-Modified-Since: #{last_modified}", *curl_args] + curl_args = ["--time-cond", last_modified, *curl_args] unless cached_formula_json_file.empty? end curl_download(*curl_args, to: HOMEBREW_CACHE_API/"#{formula_api_path}.json", max_time: 5)
false
Other
Homebrew
brew
95fc1e41b95f981f926a2b351374af1eb2bc8e2a.json
Remove reference to Travis bot
docs/Cask-Cookbook.md
@@ -108,7 +108,7 @@ cask "<cask-token>" do [`<cask-token>`](#token-reference) should match the Cask filename, without the `.rb` extension, enclosed in single quotes. -There are currently some arbitrary limitations on Cask tokens which are in the process of being removed. The Travis bot will catch any errors during the transition. +There are currently some arbitrary limitations on Cask tokens which are in the process of being removed. GitHub Actions will catch any errors during the transition. ## Stanza order
false
Other
Homebrew
brew
f387c7f0b24d83bebe0fc38cc0d3f74af1fd8e85.json
Require deprecate_disable module in formulary This solves a recurrent issue where various brew commands (e.g. doctor, cleanup) would print the following stack trace: Error: uninitialized constant Formulary::DeprecateDisable Did you mean? DeprecatedOption /opt/homebrew/Library/Homebrew/formulary.rb:269:in `convert_to_deprecate_disable_reason_string_or_symbol' /opt/homebrew/Library/Homebrew/formulary.rb:171:in `block in load_formula_from_api' /opt/homebrew/Library/Homebrew/formulary.rb:139:in `initialize' /opt/homebrew/Library/Homebrew/formulary.rb:139:in `new' /opt/homebrew/Library/Homebrew/formulary.rb:139:in `load_formula_from_api' /opt/homebrew/Library/Homebrew/formulary.rb:519:in `load_from_api' /opt/homebrew/Library/Homebrew/formulary.rb:510:in `klass' /opt/homebrew/Library/Homebrew/formulary.rb:296:in `get_formula' /opt/homebrew/Library/Homebrew/formulary.rb:542:in `factory' /opt/homebrew/Library/Homebrew/formulary.rb:565:in `from_rack' /opt/homebrew/Library/Homebrew/cleanup.rb:85:in `stale_formula?' /opt/homebrew/Library/Homebrew/cleanup.rb:58:in `stale?' /opt/homebrew/Library/Homebrew/cleanup.rb:356:in `block in cleanup_cache' /opt/homebrew/Library/Homebrew/cleanup.rb:339:in `each' /opt/homebrew/Library/Homebrew/cleanup.rb:339:in `cleanup_cache' /opt/homebrew/Library/Homebrew/cleanup.rb:222:in `clean!' /opt/homebrew/Library/Homebrew/cmd/cleanup.rb:58:in `cleanup' /opt/homebrew/Library/Homebrew/brew.rb:93:in `<main>'
Library/Homebrew/formulary.rb
@@ -264,6 +264,7 @@ def self.convert_to_string_or_symbol(string) end def self.convert_to_deprecate_disable_reason_string_or_symbol(string) + require "deprecate_disable" return string unless DeprecateDisable::DEPRECATE_DISABLE_REASONS.keys.map(&:to_s).include?(string) string.to_sym
false
Other
Homebrew
brew
94138c0848d586fbe9c76327a45069036642b0fb.json
Ignore empty `patch` blocks
Library/Homebrew/software_spec.rb
@@ -205,6 +205,8 @@ def recursive_requirements def patch(strip = :p1, src = nil, &block) p = Patch.create(strip, src, &block) + return if p.is_a?(ExternalPatch) && p.url.blank? + dependency_collector.add(p.resource) if p.is_a? ExternalPatch patches << p end
true
Other
Homebrew
brew
94138c0848d586fbe9c76327a45069036642b0fb.json
Ignore empty `patch` blocks
Library/Homebrew/test/software_spec_spec.rb
@@ -171,5 +171,12 @@ expect(spec.patches.count).to eq(1) expect(spec.patches.first.strip).to eq(:p1) end + + it "doesn't add a patch with no url" do + spec.patch do + sha256 "7852a7a365f518b12a1afd763a6a80ece88ac7aeea3c9023aa6c1fe46ac5a1ae" + end + expect(spec.patches.empty?).to be true + end end end
true
Other
Homebrew
brew
114f909ff99d7ef0529be9e03ee27d220c4232c9.json
Update RBI files for rubocop-performance.
Library/Homebrew/sorbet/rbi/gems/rubocop-performance@1.14.3.rbi
@@ -6,6 +6,7 @@ module RuboCop; end module RuboCop::Cop; end +RuboCop::Cop::IgnoredPattern = RuboCop::Cop::AllowedPattern module RuboCop::Cop::Performance; end class RuboCop::Cop::Performance::AncestorsInclude < ::RuboCop::Cop::Base
false
Other
Homebrew
brew
e61bcb45f7490706846b295d30080db3ece1d165.json
linkage_checker: report linkage with system frameworks Currently, `brew linkage` reports linkage with system frameworks only if they can be found on the file system. This results in this linkage not being reported on Big Sur and newer, where system libraries are stored in the dyld cache instead. Let's fix that by avoiding silently ignoring system frameworks by moving them out of `#harmless_broken_link?`. We retain the behaviour desired from 7228e60da51392b20d55e0c087b2082b86fb3bbf by deferring checking if a broken library is actually a system framework to just before we add it to `@broken_dylibs`. To see how this changes the behaviour of `brew linkage`, here's an example with this change: ❯ brew linkage neovim System libraries: /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices /usr/lib/libSystem.B.dylib /usr/lib/libiconv.2.dylib /usr/lib/libutil.dylib Homebrew libraries: /usr/local/opt/gettext/lib/libintl.8.dylib (gettext) /usr/local/opt/libtermkey/lib/libtermkey.1.dylib (libtermkey) /usr/local/opt/libuv/lib/libuv.1.dylib (libuv) /usr/local/opt/luajit/lib/libluajit-5.1.2.dylib (luajit) /usr/local/opt/luv/lib/libluv.1.dylib (luv) /usr/local/opt/msgpack/lib/libmsgpackc.2.dylib (msgpack) /usr/local/opt/tree-sitter/lib/libtree-sitter.0.dylib (tree-sitter) /usr/local/opt/unibilium/lib/libunibilium.4.dylib (unibilium) and without this change: ❯ brew linkage neovim System libraries: /usr/lib/libSystem.B.dylib /usr/lib/libiconv.2.dylib /usr/lib/libutil.dylib Homebrew libraries: /usr/local/opt/gettext/lib/libintl.8.dylib (gettext) /usr/local/opt/libtermkey/lib/libtermkey.1.dylib (libtermkey) /usr/local/opt/libuv/lib/libuv.1.dylib (libuv) /usr/local/opt/luajit/lib/libluajit-5.1.2.dylib (luajit) /usr/local/opt/luv/lib/libluv.1.dylib (luv) /usr/local/opt/msgpack/lib/libmsgpackc.2.dylib (msgpack) /usr/local/opt/tree-sitter/lib/libtree-sitter.0.dylib (tree-sitter) /usr/local/opt/unibilium/lib/libunibilium.4.dylib (unibilium)
Library/Homebrew/linkage_checker.rb
@@ -198,7 +198,7 @@ def check_dylibs(rebuild_cache:) # In macOS Big Sur and later, system libraries do not exist on-disk and instead exist in a cache. # If dlopen finds the dylib, then the linkage is not broken. @system_dylibs << dylib - else + elsif !system_framework?(dylib) @broken_dylibs << dylib end else @@ -306,11 +306,13 @@ def sort_by_formula_full_name!(arr) def harmless_broken_link?(dylib) # libgcc_s_* is referenced by programs that use the Java Service Wrapper, # and is harmless on x86(_64) machines - return true if [ + [ "/usr/lib/libgcc_s_ppc64.1.dylib", "/opt/local/lib/libgcc/libgcc_s.1.dylib", ].include?(dylib) + end + def system_framework?(dylib) dylib.start_with?("/System/Library/Frameworks/") end
false
Other
Homebrew
brew
6ab6382518fd1b46869f035d1665bdd707df9d1f.json
shims/super/cc: add nostdinc and rpath-link when using glibc@2.13
Library/Homebrew/shims/super/cc
@@ -292,6 +292,8 @@ class Cmd args.concat(optflags) unless runtime_cpu_detection? args.concat(archflags) args << "-std=#{@arg0}" if /c[89]9/.match?(@arg0) + # Add -nostdinc when building against glibc@2.13 to avoid mixing system and brewed glibc headers. + args << "-nostdinc" if @deps.include?("glibc@2.13") args end @@ -326,6 +328,9 @@ class Cmd end args += rpath_flags("#{wl}-rpath=", rpath_paths) args += ["#{wl}--dynamic-linker=#{dynamic_linker_path}"] if dynamic_linker_path + # Use -rpath-link to make sure linker uses glibc@2.13 rather than the system glibc for indirect + # dependencies because -L will only handle direct dependencies. + args << "#{wl}-rpath-link=#{@opt}/glibc@2.13/lib" if @deps.include?("glibc@2.13") args end
false
Other
Homebrew
brew
8ef6118ba06a5ae45b11681829cd925e424f92a8.json
Work in progress: Fetch all resources with livecheck block
Library/Homebrew/dev-cmd/livecheck.rb
@@ -73,10 +73,12 @@ def livecheck resources = Formula.all do |formula| formula.resources.any do |resource| if resource.livecheckable? - p resource + resource end end + # formula.resources.filter? { |resource| !resource.livecheckable? } end + resources elsif args.all? formulae = args.cask? ? [] : Formula.all casks = args.formula? ? [] : Cask::Cask.all
false
Other
Homebrew
brew
59165ed3ec78466b0536f347dcbeb60cde7587cc.json
Get all resources in all formulae
Library/Homebrew/dev-cmd/livecheck.rb
@@ -69,6 +69,14 @@ def livecheck formulae = args.cask? ? [] : Formula.installed casks = args.formula? ? [] : Cask::Caskroom.casks formulae + casks + elsif args.resources? + resources = Formula.all do |formula| + formula.resources.any do |resource| + if resource.livecheckable? + p resource + end + end + end elsif args.all? formulae = args.cask? ? [] : Formula.all casks = args.formula? ? [] : Cask::Cask.all @@ -95,6 +103,11 @@ def livecheck else raise UsageError, "A watchlist file is required when no arguments are given." end + p formulae_and_casks_to_check.class + p formulae_and_casks_to_check.length + p formulae_and_casks_to_check[0].class + p formulae_and_casks_to_check[0] + formulae_and_casks_to_check = formulae_and_casks_to_check.sort_by do |formula_or_cask| formula_or_cask.respond_to?(:token) ? formula_or_cask.token : formula_or_cask.name end @@ -111,6 +124,6 @@ def livecheck verbose: args.verbose?, }.compact - Livecheck.run_checks(formulae_and_casks_to_check, **options) + # Livecheck.run_checks(formulae_and_casks_to_check, **options) end end
false
Other
Homebrew
brew
95f4eb048282bc4bab3df403ac5878182a1d9c0d.json
Update RBI files for i18n.
Library/Homebrew/sorbet/rbi/gems/i18n@1.12.0.rbi
@@ -333,10 +333,6 @@ module I18n::Backend::Pluralization def pluralizer(locale); end def pluralizers; end - - private - - def symbolic_count(count); end end class I18n::Backend::Simple
false
Other
Homebrew
brew
672668f6c198f2fc4308058b8a3bacdafee24442.json
Update RBI files for sorbet-static-and-runtime.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -4356,6 +4356,8 @@ class Resource def on_sierra(or_condition=T.unsafe(nil), &block); end + def on_system(linux, macos:, &block); end + def on_ventura(or_condition=T.unsafe(nil), &block); end end
false
Other
Homebrew
brew
5056b1ec0ae384be2abc7730c19fe53096aac422.json
Update RBI files for activesupport.
Library/Homebrew/sorbet/rbi/gems/activesupport@6.1.6.1.rbi
@@ -2784,6 +2784,7 @@ end module ActiveSupport::VERSION; end ActiveSupport::VERSION::MAJOR = T.let(T.unsafe(nil), Integer) ActiveSupport::VERSION::MINOR = T.let(T.unsafe(nil), Integer) +ActiveSupport::VERSION::PRE = T.let(T.unsafe(nil), String) ActiveSupport::VERSION::STRING = T.let(T.unsafe(nil), String) ActiveSupport::VERSION::TINY = T.let(T.unsafe(nil), Integer)
true
Other
Homebrew
brew
5056b1ec0ae384be2abc7730c19fe53096aac422.json
Update RBI files for activesupport.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -24,10 +24,6 @@ module ActiveSupport::ForkTracker::CoreExtPrivate include ::ActiveSupport::ForkTracker::CoreExt end -module ActiveSupport::VERSION - PRE = ::T.let(nil, ::T.untyped) -end - class Addrinfo def connect_internal(local_addrinfo, timeout=T.unsafe(nil)); end end
true
Other
Homebrew
brew
ee68f813d812dd7e04efd500a138525752017c32.json
cask/cmd/list_spec.rb: fix leaky version variable The lazy evaluation in let() was failing to reset MacOS#full_version to the original_macos_version. This meant that all tests run after this one automatically had MacOS#version == 12 which caused some of the tests to fail if you were running a different macOS version.
Library/Homebrew/test/cask/cmd/list_spec.rb
@@ -246,7 +246,7 @@ ] EOS } - let(:original_macos_version) { MacOS.full_version.to_s } + let!(:original_macos_version) { MacOS.full_version.to_s } before do # Use a more limited symbols list to shorten the variations hash
false
Other
Homebrew
brew
29a25eb7f5ba8ca82be05ebc009351df425e3879.json
Update RBI files for i18n.
Library/Homebrew/sorbet/rbi/gems/i18n@1.11.0.rbi
@@ -154,7 +154,7 @@ module I18n::Backend::Fallbacks private - def on_fallback(_original_locale, _fallback_locale, _key, _optoins); end + def on_fallback(_original_locale, _fallback_locale, _key, _options); end end module I18n::Backend::Flatten @@ -333,6 +333,10 @@ module I18n::Backend::Pluralization def pluralizer(locale); end def pluralizers; end + + private + + def symbolic_count(count); end end class I18n::Backend::Simple @@ -427,6 +431,7 @@ module I18n::Base def handle_exception(handling, exception, locale, key, options); end def normalize_key(key, separator); end + def translate_key(key, throw, raise, locale, backend, options); end end class I18n::Config
false
Other
Homebrew
brew
0ba342676d4af17097e1adaf3652b876090aed2b.json
Update RBI files for rubocop-ast.
Library/Homebrew/sorbet/rbi/gems/rubocop-ast@1.19.1.rbi
@@ -1391,7 +1391,6 @@ RuboCop::AST::NodePattern::Sets::SET_ATTR_READER_ATTR_WRITER_ATTR_ACCESSOR = T.l RuboCop::AST::NodePattern::Sets::SET_ATTR_READER_ATTR_WRITER_ATTR_ACCESSOR_ATTR = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_BACKGROUND_SCENARIO_XSCENARIO_ETC = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_BEFORE_AFTER = T.let(T.unsafe(nil), Set) -RuboCop::AST::NodePattern::Sets::SET_BEGINNING_OF_DAY_BEGINNING_OF_WEEK_BEGINNING_OF_MONTH_ETC = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_BELONGS_TO_HAS_ONE_HAS_MANY_HAS_AND_BELONGS_TO_MANY = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_BE_EQ_EQL_EQUAL = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_BE_TRUTHY_BE_FALSEY_BE_FALSY_ETC = T.let(T.unsafe(nil), Set) @@ -1418,13 +1417,14 @@ RuboCop::AST::NodePattern::Sets::SET_DOWNCASE_UPCASE = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_EACH_EXAMPLE = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_EACH_WITH_INDEX_WITH_INDEX = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_EACH_WITH_OBJECT_WITH_OBJECT = T.let(T.unsafe(nil), Set) -RuboCop::AST::NodePattern::Sets::SET_END_OF_DAY_END_OF_WEEK_END_OF_MONTH_ETC = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_ENUMERATOR_RATIONAL_COMPLEX_THREAD = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_EQL_EQ_BE = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_ESCAPE_ENCODE_UNESCAPE_DECODE = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_EXACTLY_AT_LEAST_AT_MOST = T.let(T.unsafe(nil), Set) +RuboCop::AST::NodePattern::Sets::SET_EXIST_EXISTS = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_EXPECT_ALLOW = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_FACTORYGIRL_FACTORYBOT = T.let(T.unsafe(nil), Set) +RuboCop::AST::NodePattern::Sets::SET_FILETEST_FILE_DIR_SHELL = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_FIRST_LAST__ETC = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_FIXNUM_BIGNUM = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET_FLATTEN_FLATTEN = T.let(T.unsafe(nil), Set) @@ -1504,7 +1504,9 @@ RuboCop::AST::NodePattern::Sets::SET_TYPE_TEMPLATE_TYPE_MEMBER = T.let(T.unsafe( RuboCop::AST::NodePattern::Sets::SET_ZERO_POSITIVE_NEGATIVE = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET__ = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET__AT_SLICE = T.let(T.unsafe(nil), Set) +RuboCop::AST::NodePattern::Sets::SET__EQL_ = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET__EQUAL_EQL = T.let(T.unsafe(nil), Set) +RuboCop::AST::NodePattern::Sets::SET__FETCH = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET__GLOB = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET___ = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET___2 = T.let(T.unsafe(nil), Set) @@ -1514,12 +1516,14 @@ RuboCop::AST::NodePattern::Sets::SET___5 = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET___6 = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET___7 = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET___8 = T.let(T.unsafe(nil), Set) -RuboCop::AST::NodePattern::Sets::SET___EQL = T.let(T.unsafe(nil), Set) +RuboCop::AST::NodePattern::Sets::SET___EQL_ETC = T.let(T.unsafe(nil), Set) +RuboCop::AST::NodePattern::Sets::SET___EQL_INCLUDE = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET___METHOD_____CALLEE__ = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET____ = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET____ETC = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET____ETC_2 = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::Sets::SET____ETC_3 = T.let(T.unsafe(nil), Set) +RuboCop::AST::NodePattern::Sets::SET_____2 = T.let(T.unsafe(nil), Set) RuboCop::AST::NodePattern::VAR = T.let(T.unsafe(nil), String) module RuboCop::AST::NumericNode @@ -1778,6 +1782,7 @@ class RuboCop::AST::Token def left_ref_bracket?; end def line; end def pos; end + def regexp_dots?; end def rescue_modifier?; end def right_bracket?; end def right_curly_brace?; end
true
Other
Homebrew
brew
0ba342676d4af17097e1adaf3652b876090aed2b.json
Update RBI files for rubocop-ast.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -4959,16 +4959,9 @@ end module RuboCop::AST::NodePattern::Sets SET_BUILD_RECOMMENDED_TEST_OPTIONAL = ::T.let(nil, ::T.untyped) SET_DEPENDS_ON_USES_FROM_MACOS = ::T.let(nil, ::T.untyped) - SET_EXIST_EXISTS = ::T.let(nil, ::T.untyped) - SET_FILETEST_FILE_DIR_SHELL = ::T.let(nil, ::T.untyped) SET_INCLUDE_WITH_WITHOUT = ::T.let(nil, ::T.untyped) SET_SYSTEM_SHELL_OUTPUT_PIPE_OUTPUT = ::T.let(nil, ::T.untyped) SET_WITH_WITHOUT = ::T.let(nil, ::T.untyped) - SET__EQL_ = ::T.let(nil, ::T.untyped) - SET__FETCH = ::T.let(nil, ::T.untyped) - SET___EQL_ETC = ::T.let(nil, ::T.untyped) - SET___EQL_INCLUDE = ::T.let(nil, ::T.untyped) - SET_____2 = ::T.let(nil, ::T.untyped) end class RuboCop::Cask::AST::CaskHeader
true
Other
Homebrew
brew
5e5c78ebef173099754d2facb0c3b0691dee9334.json
Fix tests and improve style
Library/Homebrew/extend/on_system.rb
@@ -93,7 +93,7 @@ def setup_base_os_methods(base) base.define_method(:on_system) do |linux, macos:, &block| @on_system_blocks_exist = true - raise ArgumentError, "The first argument to `on_system` must be `:linux`" unless linux == :linux + raise ArgumentError, "The first argument to `on_system` must be `:linux`" if linux != :linux os_version, or_condition = if macos.to_s.include?("_or_") macos.to_s.split(/_(?=or_)/).map(&:to_sym)
true
Other
Homebrew
brew
5e5c78ebef173099754d2facb0c3b0691dee9334.json
Fix tests and improve style
Library/Homebrew/test/formula_spec.rb
@@ -1604,35 +1604,35 @@ def install end.new end - it "doesn't call code on Ventura" do + it "doesn't call code on Ventura", :needs_macos do Homebrew::SimulateSystem.os = :ventura f.brew { f.install } expect(f.foo).to eq(0) expect(f.bar).to eq(0) end - it "calls code on Linux" do + it "calls code on Linux", :needs_linux do Homebrew::SimulateSystem.os = :linux f.brew { f.install } expect(f.foo).to eq(1) expect(f.bar).to eq(1) end - it "calls code within `on_system :linux, macos: :monterey` on Monterey" do + it "calls code within `on_system :linux, macos: :monterey` on Monterey", :needs_macos do Homebrew::SimulateSystem.os = :monterey f.brew { f.install } expect(f.foo).to eq(1) expect(f.bar).to eq(0) end - it "calls code within `on_system :linux, macos: :big_sur_or_older` on Big Sur" do + it "calls code within `on_system :linux, macos: :big_sur_or_older` on Big Sur", :needs_macos do Homebrew::SimulateSystem.os = :big_sur f.brew { f.install } expect(f.foo).to eq(0) expect(f.bar).to eq(1) end - it "calls code within `on_system :linux, macos: :big_sur_or_older` on Catalina" do + it "calls code within `on_system :linux, macos: :big_sur_or_older` on Catalina", :needs_macos do Homebrew::SimulateSystem.os = :catalina f.brew { f.install } expect(f.foo).to eq(0)
true
Other
Homebrew
brew
3483ee72d5cb5f3cadbab06a6f13c7c859125f9d.json
add DSL to generate completions
Library/Homebrew/formula.rb
@@ -1625,6 +1625,21 @@ def extract_macho_slice_from(file, arch = Hardware::CPU.arch) end private :extract_macho_slice_from + def generate_completions(base_name = name, shells = [:bash, :zsh, :fish], binary = bin/base_name, cmd = "completion", shell_as_flag = false) + completion_script_path_map = { + :bash => bash_completion/base_name, + :zsh => zsh_completion/"_#{base_name}", + :fish => fish_completion/"#{base_name}.fish", + } + + shells.each do |shell| + script_path = completion_script_path_map[shell] + shell_parameter = shell_as_flag ? "--#{shell.to_s}" : shell.to_s + script_path.dirname.mkpath + script_path.write Utils.safe_popen_read(binary, cmd, shell_parameter) + end + end + # an array of all core {Formula} names # @private def self.core_names
false
Other
Homebrew
brew
3cedf8c7bffcad5a69e9974389389a668d47fe80.json
Update RBI files for rubocop.
Library/Homebrew/sorbet/rbi/gems/rubocop@1.31.2.rbi
@@ -861,6 +861,7 @@ end RuboCop::Cop::Bundler::DuplicatedGem::MSG = T.let(T.unsafe(nil), String) class RuboCop::Cop::Bundler::GemComment < ::RuboCop::Cop::Base + include ::RuboCop::Cop::VisibilityHelp include ::RuboCop::Cop::DefNode include ::RuboCop::Cop::GemDeclaration @@ -1336,6 +1337,7 @@ end RuboCop::Cop::Corrector::NOOP_CONSUMER = T.let(T.unsafe(nil), Proc) module RuboCop::Cop::DefNode + include ::RuboCop::Cop::VisibilityHelp extend ::RuboCop::AST::NodePattern::Macros def non_public_modifier?(param0 = T.unsafe(nil)); end @@ -1344,11 +1346,8 @@ module RuboCop::Cop::DefNode def non_public?(node); end def preceding_non_public_modifier?(node); end - def stripped_source_upto(index); end end -RuboCop::Cop::DefNode::NON_PUBLIC_MODIFIERS = T.let(T.unsafe(nil), Array) - module RuboCop::Cop::Documentation private @@ -2797,7 +2796,7 @@ class RuboCop::Cop::Layout::FirstArrayElementIndentation < ::RuboCop::Cop::Base def base_description(indent_base_type); end def brace_alignment_style; end def check(array_node, left_parenthesis); end - def check_right_bracket(right_bracket, left_bracket, left_parenthesis); end + def check_right_bracket(right_bracket, first_elem, left_bracket, left_parenthesis); end def message(base_description); end def message_for_right_bracket(indent_base_type); end end @@ -2835,7 +2834,7 @@ class RuboCop::Cop::Layout::FirstHashElementIndentation < ::RuboCop::Cop::Base def brace_alignment_style; end def check(hash_node, left_parenthesis); end def check_based_on_longest_key(hash_node, left_brace, left_parenthesis); end - def check_right_brace(right_brace, left_brace, left_parenthesis); end + def check_right_brace(right_brace, first_pair, left_brace, left_parenthesis); end def enforce_first_argument_with_fixed_indentation?; end def message(base_description); end def message_for_right_brace(indent_base_type); end @@ -5127,10 +5126,11 @@ class RuboCop::Cop::Lint::NonAtomicFileOperation < ::RuboCop::Cop::Base private + def allowable_use_with_if?(if_node); end def autocorrect(corrector, node, range); end def force_option?(node); end def message(node); end - def offense(node, exist_node); end + def register_offense(node, exist_node); end def replacement_method(node); end end @@ -6542,11 +6542,10 @@ module RuboCop::Cop::MultilineElementIndentation def detected_styles(actual_column, offset, left_parenthesis, left_brace); end def detected_styles_for_column(column, left_parenthesis, left_brace); end def each_argument_node(node, type); end - def hash_pair_where_value_beginning_with(left_brace); end + def hash_pair_where_value_beginning_with(left_brace, first); end def incorrect_style_detected(styles, first, base_column_type); end - def indent_base(left_brace, left_parenthesis); end + def indent_base(left_brace, first, left_parenthesis); end def key_and_value_begin_on_same_line?(pair); end - def node_beginning_with(left_brace); end def right_sibling_begins_on_subsequent_line?(pair); end end @@ -8421,6 +8420,7 @@ RuboCop::Cop::Style::Documentation::MSG = T.let(T.unsafe(nil), String) class RuboCop::Cop::Style::DocumentationMethod < ::RuboCop::Cop::Base include ::RuboCop::Cop::DocumentationComment + include ::RuboCop::Cop::VisibilityHelp include ::RuboCop::Cop::DefNode def module_function_node?(param0 = T.unsafe(nil)); end @@ -11971,7 +11971,6 @@ class RuboCop::Cop::Style::TopLevelMethodDefinition < ::RuboCop::Cop::Base end RuboCop::Cop::Style::TopLevelMethodDefinition::MSG = T.let(T.unsafe(nil), String) -RuboCop::Cop::Style::TopLevelMethodDefinition::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) class RuboCop::Cop::Style::TrailingBodyOnClass < ::RuboCop::Cop::Base include ::RuboCop::Cop::Alignment
false
Other
Homebrew
brew
da4bf679def7fee08f3856c35130a90ed8ea240a.json
Add new line after donate message
Library/Homebrew/cmd/update-report.rb
@@ -106,7 +106,7 @@ def output_update_report if Settings.read("donationmessage") != "true" && !args.quiet? ohai "Homebrew is run entirely by unpaid volunteers. Please consider donating:" - puts " #{Formatter.url("https://github.com/Homebrew/brew#donations")}\n" + puts " #{Formatter.url("https://github.com/Homebrew/brew#donations")}\n\n" # Consider the message possibly missed if not a TTY. Settings.write "donationmessage", true if $stdout.tty?
false
Other
Homebrew
brew
b878d9c1ca3a25429f4ad6501a4f4636978d4cc7.json
Highlight new revision message
Library/Homebrew/cmd/update-report.rb
@@ -135,7 +135,7 @@ def output_update_report Settings.write "latesttag", new_tag if new_tag != old_tag if new_tag == old_tag - puts "Updated Homebrew from #{shorten_revision(initial_revision)} to #{shorten_revision(current_revision)}." + ohai "Updated Homebrew from #{shorten_revision(initial_revision)} to #{shorten_revision(current_revision)}." elsif old_tag.blank? ohai "Updated Homebrew from #{shorten_revision(initial_revision)} " \ "to #{new_tag} (#{shorten_revision(current_revision)})."
false
Other
Homebrew
brew
a25f827b8fb88a0f61872b95d408f7d58e3fdaf4.json
Report new_tag even when old_tag blank
Library/Homebrew/cmd/update-report.rb
@@ -134,8 +134,11 @@ def output_update_report Settings.write "latesttag", new_tag if new_tag != old_tag - if old_tag.blank? || (new_tag == old_tag) + if new_tag == old_tag puts "Updated Homebrew from #{shorten_revision(initial_revision)} to #{shorten_revision(current_revision)}." + elsif old_tag.blank? + ohai "Updated Homebrew from #{shorten_revision(initial_revision)} " \ + "to #{new_tag} (#{shorten_revision(current_revision)})." else ohai "Updated Homebrew from #{old_tag} (#{shorten_revision(initial_revision)}) " \ "to #{new_tag} (#{shorten_revision(current_revision)})."
false
Other
Homebrew
brew
700e2f19f108ab3b354d939352921952247be6b2.json
Expand output excluded by quiet
Library/Homebrew/cmd/update-report.rb
@@ -236,7 +236,7 @@ def output_update_report EOS end - return if new_tag.blank? || new_tag == old_tag + return if new_tag.blank? || new_tag == old_tag || args.quiet? puts ohai "Homebrew was updated to version #{new_tag}" @@ -245,7 +245,7 @@ def output_update_report More detailed release notes are available on the Homebrew Blog: #{Formatter.url("https://brew.sh/blog/#{new_tag}")} EOS - elsif !args.quiet? + else puts <<~EOS The changelog can be found at: #{Formatter.url("https://github.com/Homebrew/brew/releases/tag/#{new_tag}")}
false
Other
Homebrew
brew
a94f6ec50c5bc27bcd5b13e134462bebe6e3e347.json
Update latesttag in all cases Set latesttag before it is bypassed by return statement and old_tag being blank.
Library/Homebrew/cmd/update-report.rb
@@ -132,6 +132,8 @@ def output_update_report "git", "-C", HOMEBREW_REPOSITORY, "tag", "--list", "--sort=-version:refname", "*.*" ).lines.first.chomp + Settings.write "latesttag", new_tag if new_tag != old_tag + if old_tag.blank? || (new_tag == old_tag) puts "Updated Homebrew from #{shorten_revision(initial_revision)} to #{shorten_revision(current_revision)}." else @@ -238,7 +240,6 @@ def output_update_report puts ohai "Homebrew was updated to version #{new_tag}" - Settings.write "latesttag", new_tag if new_tag != old_tag if new_tag.split(".").last == "0" puts <<~EOS More detailed release notes are available on the Homebrew Blog:
false
Other
Homebrew
brew
ae2196fa57498ba0edad7f43fe0d3d9fa8993468.json
Use x_tag instead of x_repository_version
Library/Homebrew/cmd/update-report.rb
@@ -115,7 +115,7 @@ def output_update_report install_core_tap_if_necessary updated = false - new_repository_version = nil + new_tag = nil initial_revision = ENV["HOMEBREW_UPDATE_BEFORE"].to_s current_revision = ENV["HOMEBREW_UPDATE_AFTER"].to_s @@ -135,7 +135,6 @@ def output_update_report if old_tag.blank? || (new_tag == old_tag) puts "Updated Homebrew from #{shorten_revision(initial_revision)} to #{shorten_revision(current_revision)}." else - new_repository_version = new_tag puts "Updated Homebrew from #{old_tag} (#{shorten_revision(initial_revision)}) " \ "to #{new_tag} (#{shorten_revision(current_revision)})." end @@ -235,20 +234,20 @@ def output_update_report EOS end - return if new_repository_version.blank? + return if new_tag.blank? || new_tag == old_tag puts - ohai "Homebrew was updated to version #{new_repository_version}" - Settings.write "latesttag", new_repository_version - if new_repository_version.split(".").last == "0" + ohai "Homebrew was updated to version #{new_tag}" + Settings.write "latesttag", new_tag if new_tag != old_tag + if new_tag.split(".").last == "0" puts <<~EOS More detailed release notes are available on the Homebrew Blog: - #{Formatter.url("https://brew.sh/blog/#{new_repository_version}")} + #{Formatter.url("https://brew.sh/blog/#{new_tag}")} EOS elsif !args.quiet? puts <<~EOS The changelog can be found at: - #{Formatter.url("https://github.com/Homebrew/brew/releases/tag/#{new_repository_version}")} + #{Formatter.url("https://github.com/Homebrew/brew/releases/tag/#{new_tag}")} EOS end end
false
Other
Homebrew
brew
2769b953b4f6b71fb0d080c9df81d36c1aceeec5.json
Update RBI files for rubocop-rails.
Library/Homebrew/sorbet/rbi/gems/rubocop-rails@2.15.2.rbi
@@ -510,6 +510,7 @@ RuboCop::Cop::Rails::DefaultScope::MSG = T.let(T.unsafe(nil), String) RuboCop::Cop::Rails::DefaultScope::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) class RuboCop::Cop::Rails::Delegate < ::RuboCop::Cop::Base + include ::RuboCop::Cop::VisibilityHelp extend ::RuboCop::Cop::AutoCorrector def delegate?(param0 = T.unsafe(nil)); end @@ -521,9 +522,8 @@ class RuboCop::Cop::Rails::Delegate < ::RuboCop::Cop::Base def include_prefix_case?; end def method_name_matches?(method_name, body); end def prefixed_method_name(body); end - def private_or_protected_before(line); end def private_or_protected_delegation(node); end - def private_or_protected_inline(line); end + def private_or_protected_inline(node); end def register_offense(node); end def trivial_delegate?(def_node); end end @@ -756,13 +756,16 @@ class RuboCop::Cop::Rails::ExpandedDateRange < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector extend ::RuboCop::Cop::TargetRailsVersion - def expanded_date_range(param0 = T.unsafe(nil)); end def on_irange(node); end private - def same_receiver?(begin_node, end_node); end - def use_mapped_methods?(beginning_method, end_method); end + def allow?(begin_node, end_node); end + def any_arguments?(begin_node, end_node); end + def preferred_method(begin_node); end + def receiver_source(node); end + def register_offense(node, preferred_method); end + def same_argument?(begin_node, end_node); end end RuboCop::Cop::Rails::ExpandedDateRange::MAPPED_DATE_RANGE_METHODS = T.let(T.unsafe(nil), Hash)
false
Other
Homebrew
brew
ed1324c9ca3115184b270baa8e46259a3490a6cc.json
add pax to allowlist
Library/Homebrew/rubocops/uses_from_macos.rb
@@ -43,6 +43,7 @@ class ProvidedByMacos < FormulaCop net-snmp netcat openldap + pax pcsc-lite pod2man rpcgen
false
Other
Homebrew
brew
0b50be78d96556b60807252e873d90871d44ebe9.json
Update RBI files for minitest.
Library/Homebrew/sorbet/rbi/gems/minitest@5.16.2.rbi
@@ -293,7 +293,7 @@ class Minitest::Test < ::Minitest::Runnable def capture_exceptions; end def class_name; end def neuter_exception(e); end - def new_exception(klass, msg, bt); end + def new_exception(klass, msg, bt, kill = T.unsafe(nil)); end def run; end def sanitize_exception(e); end def with_info_handler(&block); end
false
Other
Homebrew
brew
286eee7dc47890f284979763cdcabb2e285b2fd0.json
Update RBI files for rubocop-rspec.
Library/Homebrew/sorbet/rbi/gems/rubocop-rspec@2.12.1.rbi
@@ -6,6 +6,7 @@ module RuboCop; end module RuboCop::Cop; end +RuboCop::Cop::IgnoredPattern = RuboCop::Cop::AllowedPattern module RuboCop::Cop::RSpec; end class RuboCop::Cop::RSpec::AlignLeftLetBrace < ::RuboCop::Cop::RSpec::Base @@ -167,6 +168,22 @@ end RuboCop::Cop::RSpec::Capybara::FeatureMethods::MAP = T.let(T.unsafe(nil), Hash) RuboCop::Cop::RSpec::Capybara::FeatureMethods::MSG = T.let(T.unsafe(nil), String) +class RuboCop::Cop::RSpec::Capybara::SpecificMatcher < ::RuboCop::Cop::RSpec::Base + def first_argument(param0 = T.unsafe(nil)); end + def on_send(node); end + + private + + def acceptable_pattern?(arg); end + def good_matcher(node, matcher); end + def message(node, matcher); end + def specific_matcher(arg); end +end + +RuboCop::Cop::RSpec::Capybara::SpecificMatcher::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::RSpec::Capybara::SpecificMatcher::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) +RuboCop::Cop::RSpec::Capybara::SpecificMatcher::SPECIFIC_MATCHER = T.let(T.unsafe(nil), Hash) + class RuboCop::Cop::RSpec::Capybara::VisibilityMatcher < ::RuboCop::Cop::RSpec::Base def on_send(node); end def visible_false?(param0 = T.unsafe(nil)); end @@ -192,7 +209,7 @@ class RuboCop::Cop::RSpec::ChangeByZero < ::RuboCop::Cop::RSpec::Base private def autocorrect(corrector, node); end - def check_offence(node); end + def check_offense(node); end def compound_expectations?(node); end end @@ -586,9 +603,11 @@ class RuboCop::Cop::RSpec::FactoryBot::CreateList < ::RuboCop::Cop::RSpec::Base include ::RuboCop::RSpec::FactoryBot::Language extend ::RuboCop::Cop::AutoCorrector + def arguments_include_method_call?(param0 = T.unsafe(nil)); end def factory_call(param0 = T.unsafe(nil)); end def factory_list_call(param0 = T.unsafe(nil)); end - def n_times_block_without_arg?(param0 = T.unsafe(nil)); end + def n_times_block?(param0 = T.unsafe(nil)); end + def n_times_block_with_arg_and_used?(param0 = T.unsafe(nil)); end def on_block(node); end def on_send(node); end @@ -619,7 +638,7 @@ class RuboCop::Cop::RSpec::FactoryBot::CreateList::CreateListCorrector def call_with_block_replacement(node); end def format_block(node); end def format_multiline_block(node); end - def format_singeline_block(node); end + def format_singleline_block(node); end def node; end end @@ -1171,6 +1190,15 @@ end RuboCop::Cop::RSpec::Rails::AvoidSetupHook::MSG = T.let(T.unsafe(nil), String) +class RuboCop::Cop::RSpec::Rails::HaveHttpStatus < ::RuboCop::Cop::RSpec::Base + extend ::RuboCop::Cop::AutoCorrector + + def match_status(param0 = T.unsafe(nil)); end + def on_send(node); end +end + +RuboCop::Cop::RSpec::Rails::HaveHttpStatus::MSG = T.let(T.unsafe(nil), String) + class RuboCop::Cop::RSpec::Rails::HttpStatus < ::RuboCop::Cop::RSpec::Base include ::RuboCop::Cop::ConfigurableEnforcedStyle extend ::RuboCop::Cop::AutoCorrector @@ -1560,7 +1588,7 @@ class RuboCop::Cop::RSpec::VariableName < ::RuboCop::Cop::RSpec::Base include ::RuboCop::Cop::ConfigurableEnforcedStyle include ::RuboCop::Cop::ConfigurableFormatting include ::RuboCop::Cop::ConfigurableNaming - include ::RuboCop::Cop::IgnoredPattern + include ::RuboCop::Cop::AllowedPattern include ::RuboCop::Cop::RSpec::Variable def on_send(node); end
false
Other
Homebrew
brew
e69345b9421aa3e884c10d6b5213a6a10a8c301c.json
Update livecheck_resource test values
Library/Homebrew/test/resource_spec.rb
@@ -9,12 +9,12 @@ let(:livecheck_resource) { described_class.new do - url "https://brew.sh/test-0.0.1.tgz" + url "https://brew.sh/foo-1.0.tar.gz" sha256 "0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef" livecheck do - url "https://brew.sh/foo-1.0.tar.gz" - regex(/foo/) + url "https://brew.sh/test/releases" + regex(/foo[._-]v?(\d+(?:\.\d+)+)\.t/i) end end } @@ -71,8 +71,8 @@ end specify "when livecheck block is set" do - expect(livecheck_resource.livecheck.url).to eq("https://brew.sh/foo-1.0.tar.gz") - expect(livecheck_resource.livecheck.regex).to eq(/foo/) + expect(livecheck_resource.livecheck.url).to eq("https://brew.sh/test/releases") + expect(livecheck_resource.livecheck.regex).to eq(/foo[._-]v?(\d+(?:\.\d+)+)\.t/i) end end
false
Other
Homebrew
brew
24fb00c770d171c10d2d48c428e63561a006d623.json
Update RBI files for rack.
Library/Homebrew/sorbet/rbi/gems/rack@2.2.4.rbi
@@ -872,6 +872,7 @@ class Rack::QueryParser::Params def to_params_hash; end end +class Rack::QueryParser::ParamsTooDeepError < ::RangeError; end Rack::RACK_ERRORS = T.let(T.unsafe(nil), String) Rack::RACK_HIJACK = T.let(T.unsafe(nil), String) Rack::RACK_HIJACK_IO = T.let(T.unsafe(nil), String) @@ -1610,6 +1611,8 @@ Rack::Utils::KeySpaceConstrainedParams = Rack::QueryParser::Params Rack::Utils::NULL_BYTE = T.let(T.unsafe(nil), String) Rack::Utils::PATH_SEPS = T.let(T.unsafe(nil), Regexp) Rack::Utils::ParameterTypeError = Rack::QueryParser::ParameterTypeError +Rack::Utils::RFC2822_DAY_NAME = T.let(T.unsafe(nil), Array) +Rack::Utils::RFC2822_MONTH_NAME = T.let(T.unsafe(nil), Array) Rack::Utils::STATUS_WITH_NO_ENTITY_BODY = T.let(T.unsafe(nil), Hash) Rack::Utils::SYMBOL_TO_STATUS_CODE = T.let(T.unsafe(nil), Hash) Rack::VERSION = T.let(T.unsafe(nil), Array)
false
Other
Homebrew
brew
da2df987db57b9276f7e6dc45d6fa0f2f7239201.json
sorbet: Update RBI files. Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -3607,6 +3607,16 @@ class Object def self.yaml_tag(url); end end +module OnSystem::MacOSAndLinux + extend ::T::Private::Methods::MethodHooks + extend ::T::Private::Methods::SingletonMethodHooks +end + +module OnSystem::MacOSOnly + extend ::T::Private::Methods::MethodHooks + extend ::T::Private::Methods::SingletonMethodHooks +end + module OnSystem extend ::T::Private::Methods::MethodHooks extend ::T::Private::Methods::SingletonMethodHooks
false
Other
Homebrew
brew
17fc684c9b72132a859bdce25b59f12622959dbc.json
Update RBI files for rubocop-sorbet.
Library/Homebrew/sorbet/rbi/gems/rubocop-sorbet@0.6.11.rbi
@@ -6,6 +6,7 @@ module RuboCop; end module RuboCop::Cop; end +RuboCop::Cop::IgnoredPattern = RuboCop::Cop::AllowedPattern module RuboCop::Cop::Sorbet; end class RuboCop::Cop::Sorbet::AllowIncompatibleOverride < ::RuboCop::Cop::Cop
false
Other
Homebrew
brew
011ea66ebce3b4c273ecc852db78c78f7e08bbc9.json
Update RBI files for rubocop.
Library/Homebrew/sorbet/rbi/gems/json@2.6.2.rbi
@@ -0,0 +1,101 @@ +# typed: true + +# DO NOT EDIT MANUALLY +# This is an autogenerated file for types exported from the `json` gem. +# Please instead update this file by running `bin/tapioca gem json`. + +class Class < ::Module + def json_creatable?; end +end + +module JSON + private + + def dump(obj, anIO = T.unsafe(nil), limit = T.unsafe(nil)); end + def fast_generate(obj, opts = T.unsafe(nil)); end + def fast_unparse(obj, opts = T.unsafe(nil)); end + def generate(obj, opts = T.unsafe(nil)); end + def load(source, proc = T.unsafe(nil), options = T.unsafe(nil)); end + def load_file(filespec, opts = T.unsafe(nil)); end + def load_file!(filespec, opts = T.unsafe(nil)); end + def parse(source, opts = T.unsafe(nil)); end + def parse!(source, opts = T.unsafe(nil)); end + def pretty_generate(obj, opts = T.unsafe(nil)); end + def pretty_unparse(obj, opts = T.unsafe(nil)); end + def recurse_proc(result, &proc); end + def restore(source, proc = T.unsafe(nil), options = T.unsafe(nil)); end + def unparse(obj, opts = T.unsafe(nil)); end + + class << self + def [](object, opts = T.unsafe(nil)); end + def create_fast_state; end + def create_id; end + def create_id=(new_value); end + def create_pretty_state; end + def deep_const_get(path); end + def dump(obj, anIO = T.unsafe(nil), limit = T.unsafe(nil)); end + def dump_default_options; end + def dump_default_options=(_arg0); end + def fast_generate(obj, opts = T.unsafe(nil)); end + def fast_unparse(obj, opts = T.unsafe(nil)); end + def generate(obj, opts = T.unsafe(nil)); end + def generator; end + def generator=(generator); end + def iconv(to, from, string); end + def load(source, proc = T.unsafe(nil), options = T.unsafe(nil)); end + def load_default_options; end + def load_default_options=(_arg0); end + def load_file(filespec, opts = T.unsafe(nil)); end + def load_file!(filespec, opts = T.unsafe(nil)); end + def parse(source, opts = T.unsafe(nil)); end + def parse!(source, opts = T.unsafe(nil)); end + def parser; end + def parser=(parser); end + def pretty_generate(obj, opts = T.unsafe(nil)); end + def pretty_unparse(obj, opts = T.unsafe(nil)); end + def recurse_proc(result, &proc); end + def restore(source, proc = T.unsafe(nil), options = T.unsafe(nil)); end + def state; end + def state=(_arg0); end + def unparse(obj, opts = T.unsafe(nil)); end + end +end + +JSON::CREATE_ID_TLS_KEY = T.let(T.unsafe(nil), String) +JSON::DEFAULT_CREATE_ID = T.let(T.unsafe(nil), String) + +class JSON::GenericObject < ::OpenStruct + def as_json(*_arg0); end + def to_hash; end + def to_json(*a); end + def |(other); end + + class << self + def dump(obj, *args); end + def from_hash(object); end + def json_creatable=(_arg0); end + def json_creatable?; end + def json_create(data); end + def load(source, proc = T.unsafe(nil), opts = T.unsafe(nil)); end + end +end + +class JSON::JSONError < ::StandardError + class << self + def wrap(exception); end + end +end + +JSON::Parser = JSON::Ext::Parser +JSON::State = JSON::Ext::Generator::State +JSON::UnparserError = JSON::GeneratorError + +module Kernel + extend ::Forwardable + + private + + def JSON(object, *args); end + def j(*objs); end + def jj(*objs); end +end
true
Other
Homebrew
brew
011ea66ebce3b4c273ecc852db78c78f7e08bbc9.json
Update RBI files for rubocop.
Library/Homebrew/sorbet/rbi/gems/rubocop@1.31.1.rbi
@@ -3178,6 +3178,7 @@ class RuboCop::Cop::Layout::LineContinuationSpacing < ::RuboCop::Cop::Base def find_offensive_spacing(line); end def ignore_range?(backtick_range); end def investigate(line, line_number); end + def last_line(processed_source); end def message(_range); end def no_space_style?; end def space_style?; end @@ -6546,6 +6547,7 @@ module RuboCop::Cop::MultilineElementIndentation def indent_base(left_brace, left_parenthesis); end def key_and_value_begin_on_same_line?(pair); end def node_beginning_with(left_brace); end + def right_sibling_begins_on_subsequent_line?(pair); end end module RuboCop::Cop::MultilineElementLineBreaks
true
Other
Homebrew
brew
011ea66ebce3b4c273ecc852db78c78f7e08bbc9.json
Update RBI files for rubocop.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -1044,8 +1044,6 @@ end class Class def any_instance(); end - - def json_creatable?(); end end class CompilerSelector::Compiler @@ -2963,12 +2961,6 @@ class JSON::Ext::Parser def initialize(*arg); end end -JSON::Parser = JSON::Ext::Parser - -JSON::State = JSON::Ext::Generator::State - -JSON::UnparserError = JSON::GeneratorError - class Keg::ConflictError extend ::T::Private::Methods::MethodHooks extend ::T::Private::Methods::SingletonMethodHooks @@ -3391,13 +3383,7 @@ end Net::HTTPFatalErrorCode = Net::HTTPClientError -class Net::HTTPInformation -end - -Net::HTTPInformationCode::EXCEPTION_TYPE = Net::HTTPError - -class Net::HTTPInformation -end +Net::HTTPInformationCode = Net::HTTPInformation class Net::HTTPLoopDetected HAS_BODY = ::T.let(nil, ::T.untyped) @@ -3457,13 +3443,7 @@ Net::HTTPServerErrorCode = Net::HTTPServerError Net::HTTPSession = Net::HTTP -class Net::HTTPSuccess -end - -Net::HTTPSuccessCode::EXCEPTION_TYPE = Net::HTTPError - -class Net::HTTPSuccess -end +Net::HTTPSuccessCode = Net::HTTPSuccess class Net::HTTPURITooLong HAS_BODY = ::T.let(nil, ::T.untyped)
true
Other
Homebrew
brew
4b1ac96a258b967c4a6f53a7217a609b0b51d466.json
Update RBI files for rubocop.
Library/Homebrew/sorbet/rbi/gems/rubocop@1.31.0.rbi
@@ -227,6 +227,7 @@ class RuboCop::Config def [](*args, &block); end def []=(*args, &block); end + def active_support_extensions_enabled?; end def add_excludes_from_higher_level(highest_config); end def allowed_camel_case_file?(file); end def base_dir_for_path_parameters; end @@ -754,6 +755,7 @@ class RuboCop::Cop::Base def initialize(config = T.unsafe(nil), options = T.unsafe(nil)); end + def active_support_extensions_enabled?; end def add_global_offense(message = T.unsafe(nil), severity: T.unsafe(nil)); end def add_offense(node_or_range, message: T.unsafe(nil), severity: T.unsafe(nil), &block); end def callbacks_needed; end @@ -1533,16 +1535,6 @@ end module RuboCop::Cop::Gemspec; end -class RuboCop::Cop::Gemspec::DateAssignment < ::RuboCop::Cop::Base - include ::RuboCop::Cop::RangeHelp - include ::RuboCop::Cop::GemspecHelp - extend ::RuboCop::Cop::AutoCorrector - - def on_block(block_node); end -end - -RuboCop::Cop::Gemspec::DateAssignment::MSG = T.let(T.unsafe(nil), String) - class RuboCop::Cop::Gemspec::DependencyVersion < ::RuboCop::Cop::Base include ::RuboCop::Cop::ConfigurableEnforcedStyle include ::RuboCop::Cop::GemspecHelp @@ -1581,7 +1573,9 @@ class RuboCop::Cop::Gemspec::DeprecatedAttributeAssignment < ::RuboCop::Cop::Bas private - def use_test_files?(node, block_parameter); end + def format_message_from; end + def node_and_method_name(node, attribute); end + def use_deprecated_attributes?(node, block_parameter); end end RuboCop::Cop::Gemspec::DeprecatedAttributeAssignment::MSG = T.let(T.unsafe(nil), String) @@ -2559,7 +2553,10 @@ class RuboCop::Cop::Layout::EmptyLinesAroundAttributeAccessor < ::RuboCop::Cop:: def allow_alias?(node); end def allow_alias_syntax?; end def attribute_or_allowed_method?(node); end + def autocorrect(corrector, node); end def next_line_empty?(line); end + def next_line_empty_or_enable_directive_comment?(line); end + def next_line_enable_directive_comment?(line); end def next_line_node(node); end def require_empty_line?(node); end end @@ -2797,12 +2794,12 @@ class RuboCop::Cop::Layout::FirstArrayElementIndentation < ::RuboCop::Cop::Base private def autocorrect(corrector, node); end - def base_description(left_parenthesis); end + def base_description(indent_base_type); end def brace_alignment_style; end def check(array_node, left_parenthesis); end def check_right_bracket(right_bracket, left_bracket, left_parenthesis); end def message(base_description); end - def msg(left_parenthesis); end + def message_for_right_bracket(indent_base_type); end end RuboCop::Cop::Layout::FirstArrayElementIndentation::MSG = T.let(T.unsafe(nil), String) @@ -2834,14 +2831,14 @@ class RuboCop::Cop::Layout::FirstHashElementIndentation < ::RuboCop::Cop::Base def argument_alignment_config; end def autocorrect(corrector, node); end - def base_description(left_parenthesis); end + def base_description(indent_base_type); end def brace_alignment_style; end def check(hash_node, left_parenthesis); end def check_based_on_longest_key(hash_node, left_brace, left_parenthesis); end def check_right_brace(right_brace, left_brace, left_parenthesis); end def enforce_first_argument_with_fixed_indentation?; end def message(base_description); end - def message_for_right_brace(left_parenthesis); end + def message_for_right_brace(indent_base_type); end def separator_style?(first_pair); end end @@ -3153,6 +3150,40 @@ end RuboCop::Cop::Layout::LeadingEmptyLines::MSG = T.let(T.unsafe(nil), String) +class RuboCop::Cop::Layout::LineContinuationLeadingSpace < ::RuboCop::Cop::Base + include ::RuboCop::Cop::RangeHelp + + def on_dstr(node); end + + private + + def continuation?(line); end + def investigate(first_line, second_line, range_start); end + def offense_range(range_start, matches); end + def raw_lines(node); end +end + +RuboCop::Cop::Layout::LineContinuationLeadingSpace::MSG = T.let(T.unsafe(nil), String) + +class RuboCop::Cop::Layout::LineContinuationSpacing < ::RuboCop::Cop::Base + include ::RuboCop::Cop::RangeHelp + extend ::RuboCop::Cop::AutoCorrector + + def on_new_investigation; end + + private + + def autocorrect(corrector, range); end + def comment_ranges(comments); end + def find_offensive_spacing(line); end + def ignore_range?(backtick_range); end + def investigate(line, line_number); end + def message(_range); end + def no_space_style?; end + def space_style?; end + def string_literal_ranges(ast); end +end + class RuboCop::Cop::Layout::LineEndStringConcatenationIndentation < ::RuboCop::Cop::Base include ::RuboCop::Cop::ConfigurableEnforcedStyle include ::RuboCop::Cop::Alignment @@ -3896,6 +3927,7 @@ class RuboCop::Cop::Layout::SpaceInsideBlockBraces < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector def on_block(node); end + def on_numblock(node); end private @@ -4314,6 +4346,20 @@ end RuboCop::Cop::Lint::ConstantDefinitionInBlock::MSG = T.let(T.unsafe(nil), String) +class RuboCop::Cop::Lint::ConstantOverwrittenInRescue < ::RuboCop::Cop::Base + include ::RuboCop::Cop::RangeHelp + extend ::RuboCop::Cop::AutoCorrector + + def on_resbody(node); end + def overwritten_constant(param0 = T.unsafe(nil)); end + + class << self + def autocorrect_incompatible_with; end + end +end + +RuboCop::Cop::Lint::ConstantOverwrittenInRescue::MSG = T.let(T.unsafe(nil), String) + class RuboCop::Cop::Lint::ConstantResolution < ::RuboCop::Cop::Base def on_const(node); end def unqualified_const?(param0 = T.unsafe(nil)); end @@ -5067,6 +5113,31 @@ end RuboCop::Cop::Lint::NoReturnInBeginEndBlocks::MSG = T.let(T.unsafe(nil), String) +class RuboCop::Cop::Lint::NonAtomicFileOperation < ::RuboCop::Cop::Base + include ::RuboCop::Cop::Alignment + include ::RuboCop::Cop::RangeHelp + extend ::RuboCop::Cop::AutoCorrector + + def explicit_not_force?(param0); end + def force?(param0); end + def on_send(node); end + def receiver_and_method_name(param0 = T.unsafe(nil)); end + def send_exist_node(param0); end + + private + + def autocorrect(corrector, node, range); end + def force_option?(node); end + def message(node); end + def offense(node, exist_node); end + def replacement_method(node); end +end + +RuboCop::Cop::Lint::NonAtomicFileOperation::MAKE_METHODS = T.let(T.unsafe(nil), Array) +RuboCop::Cop::Lint::NonAtomicFileOperation::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::Lint::NonAtomicFileOperation::REMOVE_METHODS = T.let(T.unsafe(nil), Array) +RuboCop::Cop::Lint::NonAtomicFileOperation::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) + class RuboCop::Cop::Lint::NonDeterministicRequireOrder < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector @@ -6021,6 +6092,12 @@ end RuboCop::Cop::Lint::UselessAssignment::MSG = T.let(T.unsafe(nil), String) +class RuboCop::Cop::Lint::UselessElseWithoutRescue < ::RuboCop::Cop::Base + def on_new_investigation; end +end + +RuboCop::Cop::Lint::UselessElseWithoutRescue::MSG = T.let(T.unsafe(nil), String) + class RuboCop::Cop::Lint::UselessMethodDefinition < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector @@ -6459,13 +6536,16 @@ end module RuboCop::Cop::MultilineElementIndentation private - def base_column(left_brace, left_parenthesis); end def check_expected_style(styles); end def check_first(first, left_brace, left_parenthesis, offset); end def detected_styles(actual_column, offset, left_parenthesis, left_brace); end def detected_styles_for_column(column, left_parenthesis, left_brace); end def each_argument_node(node, type); end - def incorrect_style_detected(styles, first, left_parenthesis); end + def hash_pair_where_value_beginning_with(left_brace); end + def incorrect_style_detected(styles, first, base_column_type); end + def indent_base(left_brace, left_parenthesis); end + def key_and_value_begin_on_same_line?(pair); end + def node_beginning_with(left_brace); end end module RuboCop::Cop::MultilineElementLineBreaks @@ -7155,11 +7235,12 @@ module RuboCop::Cop::RangeHelp def range_between(start_pos, end_pos); end def range_by_whole_lines(range, include_final_newline: T.unsafe(nil)); end def range_with_surrounding_comma(range, side = T.unsafe(nil)); end - def range_with_surrounding_space(range:, side: T.unsafe(nil), newlines: T.unsafe(nil), whitespace: T.unsafe(nil), continuations: T.unsafe(nil)); end + def range_with_surrounding_space(range_positional = T.unsafe(nil), range: T.unsafe(nil), side: T.unsafe(nil), newlines: T.unsafe(nil), whitespace: T.unsafe(nil), continuations: T.unsafe(nil)); end def source_range(source_buffer, line_number, column, length = T.unsafe(nil)); end end RuboCop::Cop::RangeHelp::BYTE_ORDER_MARK = T.let(T.unsafe(nil), Integer) +module RuboCop::Cop::RangeHelp::NOT_GIVEN; end module RuboCop::Cop::RationalLiteral extend ::RuboCop::AST::NodePattern::Macros @@ -7739,6 +7820,7 @@ class RuboCop::Cop::Style::BlockDelimiters < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector def on_block(node); end + def on_numblock(node); end def on_send(node); end private @@ -8528,6 +8610,7 @@ class RuboCop::Cop::Style::EmptyMethod < ::RuboCop::Cop::Base def expanded?(node); end def expanded_style?; end def joint(node); end + def max_line_length; end def message(_range); end end @@ -8857,14 +8940,18 @@ class RuboCop::Cop::Style::FormatStringToken < ::RuboCop::Cop::Base include ::RuboCop::Cop::ConfigurableEnforcedStyle include ::RuboCop::Cop::IgnoredMethods extend ::RuboCop::Cop::IgnoredMethods::Config + extend ::RuboCop::Cop::AutoCorrector def format_string_in_typical_context?(param0 = T.unsafe(nil)); end def on_str(node); end private def allowed_unannotated?(detections); end + def autocorrect_sequence(corrector, detected_sequence, token_range); end + def check_sequence(detected_sequence, token_range); end def collect_detections(node); end + def correctable_sequence?(detected_type); end def format_string_token?(node); end def max_unannotated_placeholders_allowed; end def message(detected_style); end @@ -8953,9 +9040,9 @@ class RuboCop::Cop::Style::GuardClause < ::RuboCop::Cop::Base def check_ending_if(node); end def consecutive_conditionals?(parent, node); end def guard_clause_source(guard_clause); end - def opposite_keyword(node); end def register_offense(node, scope_exiting_keyword, conditional_keyword); end def too_long_for_single_line?(node, example); end + def trivial?(node); end end RuboCop::Cop::Style::GuardClause::MSG = T.let(T.unsafe(nil), String) @@ -9029,12 +9116,19 @@ class RuboCop::Cop::Style::HashExcept < ::RuboCop::Cop::Base extend ::RuboCop::Cop::TargetRubyVersion extend ::RuboCop::Cop::AutoCorrector - def bad_method?(param0 = T.unsafe(nil)); end + def bad_method_with_active_support?(param0 = T.unsafe(nil)); end + def bad_method_with_poro?(param0 = T.unsafe(nil)); end def on_send(node); end private + def bad_method?(block); end + def decorate_source(value); end def except_key(node); end + def except_key_source(key); end + def extract_body_if_nagated(body); end + def included?(negated, body); end + def not_included?(negated, body); end def offense_range(node); end def safe_to_register_offense?(block, except_key); end def semantically_except_method?(send, block); end @@ -9520,7 +9614,7 @@ module RuboCop::Cop::Style::MethodCallWithArgsParentheses::OmitParentheses def allowed_string_interpolation_method_call?(node); end def ambigious_literal?(node); end def assigned_before?(node, target); end - def auto_correct(corrector, node); end + def autocorrect(corrector, node); end def call_as_argument_or_chain?(node); end def call_in_literals?(node); end def call_in_logical_operators?(node); end @@ -10034,14 +10128,17 @@ end RuboCop::Cop::Style::NestedParenthesizedCalls::MSG = T.let(T.unsafe(nil), String) class RuboCop::Cop::Style::NestedTernaryOperator < ::RuboCop::Cop::Base + include ::RuboCop::Cop::RangeHelp extend ::RuboCop::Cop::AutoCorrector def on_if(node); end private + def autocorrect(corrector, if_node); end def if_node(node); end def remove_parentheses(source); end + def replace_loc_and_whitespace(corrector, range, replacement); end end RuboCop::Cop::Style::NestedTernaryOperator::MSG = T.let(T.unsafe(nil), String) @@ -11052,10 +11149,6 @@ class RuboCop::Cop::Style::RedundantSelf < ::RuboCop::Cop::Base def allowed_send_node?(node); end def on_argument(node); end def regular_method_call?(node); end - - class << self - def autocorrect_incompatible_with; end - end end RuboCop::Cop::Style::RedundantSelf::KERNEL_METHODS = T.let(T.unsafe(nil), Array) @@ -13045,6 +13138,8 @@ RuboCop::Formatter::FuubarStyleFormatter::RESET_SEQUENCE = T.let(T.unsafe(nil), class RuboCop::Formatter::GitHubActionsFormatter < ::RuboCop::Formatter::BaseFormatter def file_finished(file, offenses); end + def finished(_inspected_files); end + def started(_target_files); end private @@ -13269,7 +13364,7 @@ class RuboCop::Formatter::SimpleTextFormatter::Report include ::RuboCop::Formatter::Colorizable include ::RuboCop::Formatter::TextUtil - def initialize(file_count, offense_count, correction_count, correctable_count, rainbow, safe_auto_correct: T.unsafe(nil)); end + def initialize(file_count, offense_count, correction_count, correctable_count, rainbow, safe_autocorrect: T.unsafe(nil)); end def summary; end @@ -13433,6 +13528,7 @@ class RuboCop::Options def add_cop_selection_csv_option(option, opts); end def add_general_options(opts); end def add_output_options(opts); end + def add_server_options(opts); end def add_severity_option(opts); end def args_from_env; end def args_from_file; end @@ -13798,6 +13894,7 @@ module RuboCop::Version end RuboCop::Version::CANONICAL_FEATURE_NAMES = T.let(T.unsafe(nil), Hash) +RuboCop::Version::EXTENSION_PATH_NAMES = T.let(T.unsafe(nil), Hash) RuboCop::Version::MSG = T.let(T.unsafe(nil), String) RuboCop::Version::STRING = T.let(T.unsafe(nil), String) class RuboCop::Warning < ::StandardError; end
true
Other
Homebrew
brew
4b1ac96a258b967c4a6f53a7217a609b0b51d466.json
Update RBI files for rubocop.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -4969,10 +4969,15 @@ end module RuboCop::AST::NodePattern::Sets SET_BUILD_RECOMMENDED_TEST_OPTIONAL = ::T.let(nil, ::T.untyped) SET_DEPENDS_ON_USES_FROM_MACOS = ::T.let(nil, ::T.untyped) + SET_EXIST_EXISTS = ::T.let(nil, ::T.untyped) + SET_FILETEST_FILE_DIR_SHELL = ::T.let(nil, ::T.untyped) SET_INCLUDE_WITH_WITHOUT = ::T.let(nil, ::T.untyped) SET_SYSTEM_SHELL_OUTPUT_PIPE_OUTPUT = ::T.let(nil, ::T.untyped) SET_WITH_WITHOUT = ::T.let(nil, ::T.untyped) + SET__EQL_ = ::T.let(nil, ::T.untyped) SET__FETCH = ::T.let(nil, ::T.untyped) + SET___EQL_ETC = ::T.let(nil, ::T.untyped) + SET___EQL_INCLUDE = ::T.let(nil, ::T.untyped) SET_____2 = ::T.let(nil, ::T.untyped) end
true
Other
Homebrew
brew
3df8b9761402477704de44efae3b4484df01f990.json
sorbet: Update RBI files. Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -2662,6 +2662,10 @@ module Homebrew::Livecheck::Strategy extend ::T::Private::Methods::SingletonMethodHooks end +class Homebrew::SimulateSystem + extend ::T::Private::Methods::SingletonMethodHooks +end + class Homebrew::Style::LineLocation extend ::T::Private::Methods::MethodHooks extend ::T::Private::Methods::SingletonMethodHooks @@ -3623,7 +3627,7 @@ class Object def self.yaml_tag(url); end end -module OnOS +module OnSystem extend ::T::Private::Methods::MethodHooks extend ::T::Private::Methods::SingletonMethodHooks end @@ -4344,6 +4348,29 @@ end class Resource include ::FileUtils::StreamUtils_ + def on_arm(&block); end + + def on_big_sur(or_condition=T.unsafe(nil), &block); end + + def on_catalina(or_condition=T.unsafe(nil), &block); end + + def on_el_capitan(or_condition=T.unsafe(nil), &block); end + + def on_high_sierra(or_condition=T.unsafe(nil), &block); end + + def on_intel(&block); end + + def on_linux(&block); end + + def on_macos(&block); end + + def on_mojave(or_condition=T.unsafe(nil), &block); end + + def on_monterey(or_condition=T.unsafe(nil), &block); end + + def on_sierra(or_condition=T.unsafe(nil), &block); end + + def on_ventura(or_condition=T.unsafe(nil), &block); end end class Resource::Partial
true
Other
Homebrew
brew
3df8b9761402477704de44efae3b4484df01f990.json
sorbet: Update RBI files. Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
Library/Homebrew/sorbet/rbi/parlour.rbi
@@ -129,13 +129,6 @@ module Cask def token_conflicts?; end end - class DSL - class Caveats < Base - sig { returns(T::Boolean) } - def discontinued?; end - end - end - class Installer sig { returns(T::Boolean) } def binaries?; end @@ -170,4 +163,14 @@ module Cask sig { returns(T::Boolean) } def quiet?; end end + + class DSL + class Caveats < Base + sig { returns(T::Boolean) } + def discontinued?; end + end + + sig { returns(T::Boolean) } + def on_system_blocks_exist?; end + end end
true
Other
Homebrew
brew
f22907e3fc5a5a659baedb1b6ec594093add0734.json
Update RBI files for sorbet-static-and-runtime.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -2662,6 +2662,10 @@ module Homebrew::Livecheck::Strategy extend ::T::Private::Methods::SingletonMethodHooks end +class Homebrew::SimulateSystem + extend ::T::Private::Methods::SingletonMethodHooks +end + class Homebrew::Style::LineLocation extend ::T::Private::Methods::MethodHooks extend ::T::Private::Methods::SingletonMethodHooks @@ -3623,7 +3627,7 @@ class Object def self.yaml_tag(url); end end -module OnOS +module OnSystem extend ::T::Private::Methods::MethodHooks extend ::T::Private::Methods::SingletonMethodHooks end @@ -4344,6 +4348,29 @@ end class Resource include ::FileUtils::StreamUtils_ + def on_arm(&block); end + + def on_big_sur(or_condition=T.unsafe(nil), &block); end + + def on_catalina(or_condition=T.unsafe(nil), &block); end + + def on_el_capitan(or_condition=T.unsafe(nil), &block); end + + def on_high_sierra(or_condition=T.unsafe(nil), &block); end + + def on_intel(&block); end + + def on_linux(&block); end + + def on_macos(&block); end + + def on_mojave(or_condition=T.unsafe(nil), &block); end + + def on_monterey(or_condition=T.unsafe(nil), &block); end + + def on_sierra(or_condition=T.unsafe(nil), &block); end + + def on_ventura(or_condition=T.unsafe(nil), &block); end end class Resource::Partial
true
Other
Homebrew
brew
f22907e3fc5a5a659baedb1b6ec594093add0734.json
Update RBI files for sorbet-static-and-runtime.
Library/Homebrew/sorbet/rbi/parlour.rbi
@@ -129,13 +129,6 @@ module Cask def token_conflicts?; end end - class DSL - class Caveats < Base - sig { returns(T::Boolean) } - def discontinued?; end - end - end - class Installer sig { returns(T::Boolean) } def binaries?; end @@ -170,4 +163,14 @@ module Cask sig { returns(T::Boolean) } def quiet?; end end + + class DSL + class Caveats < Base + sig { returns(T::Boolean) } + def discontinued?; end + end + + sig { returns(T::Boolean) } + def on_system_blocks_exist?; end + end end
true
Other
Homebrew
brew
c49e09427bb7d908862774ed66d34a72e438cd2f.json
Update RBI files for sorbet-static-and-runtime.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -2506,8 +2506,6 @@ module Homebrew::EnvConfig def self.force_brewed_git?(); end - def self.force_brewed_ssh?(); end - def self.force_vendor_ruby?(); end def self.ftp_proxy(); end
false
Other
Homebrew
brew
2ba53c4496c1703cf7618cc6802f412d4d3ed756.json
Update RBI files for rubocop-rails.
Library/Homebrew/sorbet/rbi/gems/rubocop-rails@2.15.1.rbi
@@ -53,6 +53,8 @@ module RuboCop::Cop::EnforceSuperclass end end +RuboCop::Cop::IgnoredPattern = RuboCop::Cop::AllowedPattern + module RuboCop::Cop::IndexMethod def on_block(node); end def on_csend(node); end @@ -1902,7 +1904,7 @@ RuboCop::Cop::Rails::TimeZone::TIMEZONE_SPECIFIER = T.let(T.unsafe(nil), Regexp) class RuboCop::Cop::Rails::TimeZoneAssignment < ::RuboCop::Cop::Base def on_send(node); end - def time_zone_assignement?(param0 = T.unsafe(nil)); end + def time_zone_assignment?(param0 = T.unsafe(nil)); end end RuboCop::Cop::Rails::TimeZoneAssignment::MSG = T.let(T.unsafe(nil), String) @@ -1913,6 +1915,7 @@ class RuboCop::Cop::Rails::ToFormattedS < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector extend ::RuboCop::Cop::TargetRailsVersion + def on_csend(node); end def on_send(node); end end @@ -2167,8 +2170,8 @@ end class RuboCop::Rails::SchemaLoader::Schema def initialize(ast); end - def add_indicies; end - def add_indicies_by(table_name:); end + def add_indices; end + def add_indices_by(table_name:); end def table_by(name:); end def tables; end
false
Other
Homebrew
brew
283ff9e3adef34fb8d53063fbd5a3f2e3ac64c92.json
bump-formula-pr: handle url with specs hash The existing `bump-formula-pr` regexes expect a `url` string to only be followed by a newline. However, `url` also accepts a `specs` hash, which can appear after the `url` string. For example: ``` url "https://www.example.com/1.2.3.tar.gz", using: :homebrew_curl ``` This commit modifies the regexes to capture anything after the `url` string and before the newline. This works for the aforementioned example, where the trailing hash is on the same line, but it won't work if the hash appears on a subsequent line. For example: ``` url "https://www.example.com/1.2.3.tar.gz", using: :homebrew_curl ```
Library/Homebrew/dev-cmd/bump-formula-pr.rb
@@ -275,7 +275,7 @@ def bump_formula_pr if new_mirrors.present? replacement_pairs << [ - /^( +)(url "#{Regexp.escape(new_url)}"\n)/m, + /^( +)(url "#{Regexp.escape(new_url)}"[^\n]*?\n)/m, "\\1\\2\\1mirror \"#{new_mirrors.join("\"\n\\1mirror \"")}\"\n", ] end @@ -293,7 +293,7 @@ def bump_formula_pr ] elsif new_url.present? [ - /^( +)(url "#{Regexp.escape(new_url)}"\n)/m, + /^( +)(url "#{Regexp.escape(new_url)}"[^\n]*?\n)/m, "\\1\\2\\1version \"#{new_version}\"\n", ] elsif new_revision.present?
false
Other
Homebrew
brew
d7a26cd6d33163c61cd28ef39bd06a555e7a6c34.json
ExtractPlist: Modify #find_versions url usage
Library/Homebrew/cask/cask.rb
@@ -20,7 +20,7 @@ class Cask attr_reader :token, :sourcefile_path, :source, :config, :default_config - attr_accessor :download + attr_accessor :download, :allow_reassignment def self.all Tap.flat_map(&:cask_files).map do |f| @@ -38,11 +38,12 @@ def tap @tap end - def initialize(token, sourcefile_path: nil, source: nil, tap: nil, config: nil, &block) + def initialize(token, sourcefile_path: nil, source: nil, tap: nil, config: nil, allow_reassignment: false, &block) @token = token @sourcefile_path = sourcefile_path @source = source @tap = tap + @allow_reassignment = allow_reassignment @block = block @default_config = config || Config.new
true
Other
Homebrew
brew
d7a26cd6d33163c61cd28ef39bd06a555e7a6c34.json
ExtractPlist: Modify #find_versions url usage
Library/Homebrew/cask/dsl.rb
@@ -112,7 +112,7 @@ def desc(description = nil) def set_unique_stanza(stanza, should_return) return instance_variable_get("@#{stanza}") if should_return - if instance_variable_defined?("@#{stanza}") + if !@cask.allow_reassignment && instance_variable_defined?("@#{stanza}") raise CaskInvalidError.new(cask, "'#{stanza}' stanza may only appear once.") end @@ -137,7 +137,7 @@ def language(*args, default: false, &block) return unless default - unless @language_blocks.default.nil? + if !@cask.allow_reassignment && @language_blocks.default.present? raise CaskInvalidError.new(cask, "Only one default language may be defined.") end @@ -294,7 +294,9 @@ def livecheck(&block) @livecheck ||= Livecheck.new(self) return @livecheck unless block - raise CaskInvalidError.new(cask, "'livecheck' stanza may only appear once.") if @livecheckable + if !@cask.allow_reassignment && @livecheckable + raise CaskInvalidError.new(cask, "'livecheck' stanza may only appear once.") + end @livecheckable = true @livecheck.instance_eval(&block)
true
Other
Homebrew
brew
d7a26cd6d33163c61cd28ef39bd06a555e7a6c34.json
ExtractPlist: Modify #find_versions url usage
Library/Homebrew/livecheck/strategy/extract_plist.rb
@@ -103,14 +103,14 @@ def self.find_versions(cask:, url: nil, regex: nil, **_unused, &block) match_data = { matches: {}, regex: regex, url: url } - if url && url != cask.url.to_s - cask_object_for_livecheck = Cask::Cask.new("livecheck-cask", config: cask.config) do - url url.to_s - end - - unversioned_cask_checker = UnversionedCaskChecker.new(cask, livecheck_url: cask_object_for_livecheck) + unversioned_cask_checker = if url.present? && url != cask.url.to_s + # Create a copy of the `cask` that uses the `livecheck` block URL + cask_copy = Cask::CaskLoader.load(cask.full_name) + cask_copy.allow_reassignment = true + cask_copy.url { url } + UnversionedCaskChecker.new(cask_copy) else - unversioned_cask_checker = UnversionedCaskChecker.new(cask) + UnversionedCaskChecker.new(cask) end items = unversioned_cask_checker.all_versions.transform_values { |v| Item.new(bundle_version: v) }
true
Other
Homebrew
brew
d7a26cd6d33163c61cd28ef39bd06a555e7a6c34.json
ExtractPlist: Modify #find_versions url usage
Library/Homebrew/unversioned_cask_checker.rb
@@ -15,21 +15,15 @@ class UnversionedCaskChecker sig { returns(Cask::Cask) } attr_reader :cask - attr_reader :livecheck_url - sig { params(cask: Cask::Cask, livecheck_url: T.nilable(Cask::Cask)).void } - def initialize(cask, livecheck_url: nil) + sig { params(cask: Cask::Cask).void } + def initialize(cask) @cask = cask - @livecheck_url = livecheck_url end sig { returns(Cask::Installer) } def installer - @installer ||= if livecheck_url - Cask::Installer.new(livecheck_url, verify_download_integrity: false) - else - Cask::Installer.new(cask, verify_download_integrity: false) - end + @installer ||= Cask::Installer.new(cask, verify_download_integrity: false) end sig { returns(T::Array[Cask::Artifact::App]) }
true
Other
Homebrew
brew
077fb350a5c10aad93c3b01a5406dfdd3ad229ce.json
ExtractPlist: Add url to #find_versions object
Library/Homebrew/livecheck/strategy/extract_plist.rb
@@ -82,6 +82,8 @@ def self.versions_from_items(items, regex = nil, &block) # versions from `plist` files. # # @param cask [Cask::Cask] the cask to check for version information + # @param url [String, nil] an alternative URL to check for version + # information # @param regex [Regexp, nil] a regex for use in a strategy block # @return [Hash] sig { @@ -99,7 +101,7 @@ def self.find_versions(cask:, url: nil, regex: nil, **_unused, &block) end raise ArgumentError, "The #{T.must(name).demodulize} strategy only supports casks." unless T.unsafe(cask) - match_data = { matches: {}, regex: regex } + match_data = { matches: {}, regex: regex, url: url } if url && url != cask.url.to_s cask_object_for_livecheck = Cask::Cask.new("livecheck-cask", config: cask.config) do
false
Other
Homebrew
brew
916c9806768b14a6229c9c9c6bee06f90fbcaab2.json
livecheck: allow custom url in extract_plist strategy
Library/Homebrew/livecheck/strategy/extract_plist.rb
@@ -87,20 +87,30 @@ def self.versions_from_items(items, regex = nil, &block) sig { params( cask: Cask::Cask, + url: T.nilable(String), regex: T.nilable(Regexp), _unused: T.nilable(T::Hash[Symbol, T.untyped]), block: T.untyped, ).returns(T::Hash[Symbol, T.untyped]) } - def self.find_versions(cask:, regex: nil, **_unused, &block) + def self.find_versions(cask:, url: nil, regex: nil, **_unused, &block) if regex.present? && block.blank? raise ArgumentError, "#{T.must(name).demodulize} only supports a regex when using a `strategy` block" end raise ArgumentError, "The #{T.must(name).demodulize} strategy only supports casks." unless T.unsafe(cask) match_data = { matches: {}, regex: regex } - unversioned_cask_checker = UnversionedCaskChecker.new(cask) + if url && url != cask.url.to_s + cask_object_for_livecheck = Cask::Cask.new("livecheck-cask", config: cask.config) do + url url.to_s + end + + unversioned_cask_checker = UnversionedCaskChecker.new(cask, livecheck_url: cask_object_for_livecheck) + else + unversioned_cask_checker = UnversionedCaskChecker.new(cask) + end + items = unversioned_cask_checker.all_versions.transform_values { |v| Item.new(bundle_version: v) } versions_from_items(items, regex, &block).each do |version_text|
true
Other
Homebrew
brew
916c9806768b14a6229c9c9c6bee06f90fbcaab2.json
livecheck: allow custom url in extract_plist strategy
Library/Homebrew/unversioned_cask_checker.rb
@@ -15,15 +15,21 @@ class UnversionedCaskChecker sig { returns(Cask::Cask) } attr_reader :cask + attr_reader :livecheck_url - sig { params(cask: Cask::Cask).void } - def initialize(cask) + sig { params(cask: Cask::Cask, livecheck_url: T.nilable(Cask::Cask)).void } + def initialize(cask, livecheck_url: nil) @cask = cask + @livecheck_url = livecheck_url end sig { returns(Cask::Installer) } def installer - @installer ||= Cask::Installer.new(cask, verify_download_integrity: false) + @installer ||= if livecheck_url + Cask::Installer.new(livecheck_url, verify_download_integrity: false) + else + Cask::Installer.new(cask, verify_download_integrity: false) + end end sig { returns(T::Array[Cask::Artifact::App]) }
true
Other
Homebrew
brew
bc064ccd35e2d4179e3f1737dbedbbf992bd5dfe.json
sorbet: Update RBI files. Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -2506,6 +2506,8 @@ module Homebrew::EnvConfig def self.force_brewed_git?(); end + def self.force_brewed_ssh?(); end + def self.force_vendor_ruby?(); end def self.ftp_proxy(); end
false
Other
Homebrew
brew
3b65ecaf4caa608e4cf31684edc767b2b320ae4b.json
livecheck: fix path to livecheck watchlist
Library/Homebrew/dev-cmd/livecheck.rb
@@ -11,10 +11,7 @@ module Homebrew module_function - WATCHLIST_PATH = ( - Homebrew::EnvConfig.livecheck_watchlist || - "#{Dir.home}/.brew_livecheck_watchlist" - ).freeze + WATCHLIST_PATH = File.expand_path(Homebrew::EnvConfig.livecheck_watchlist).freeze sig { returns(CLI::Parser) } def livecheck_args
true
Other
Homebrew
brew
3b65ecaf4caa608e4cf31684edc767b2b320ae4b.json
livecheck: fix path to livecheck watchlist
Library/Homebrew/env_config.rb
@@ -221,9 +221,10 @@ module EnvConfig boolean: true, }, HOMEBREW_LIVECHECK_WATCHLIST: { - description: "Consult this file for the list of formulae to check by default when no formula argument " \ - "is passed to `brew livecheck`.", - default: "$HOME/.brew_livecheck_watchlist", + description: "Consult this file for the list of formulae to check by default when no formula argument " \ + "is passed to `brew livecheck`.", + default_text: "$HOME/.brew_livecheck_watchlist", + default: "~/.brew_livecheck_watchlist", }, HOMEBREW_LOGS: { description: "Use this directory to store log files.",
true
Other
Homebrew
brew
8f9f18fe59c3e21278935d6b9d47e272fe7d8d63.json
utils/shfmt.sh: allow long shfmt arguments
Library/Homebrew/utils/shfmt.sh
@@ -56,7 +56,7 @@ do shift break fi - if [[ "${arg}" == "-w" ]] + if [[ "${arg}" == "-w" || "${arg}" == "--write" ]] then shift INPLACE=1
false
Other
Homebrew
brew
f804a22dc0ea5f9d5c0fb4a2a337be3060ce0e91.json
style: use new autocorrect flag
Library/Homebrew/style.rb
@@ -97,7 +97,7 @@ def run_rubocop(files, output_type, --force-exclusion ] args << if fix - "--auto-correct-all" + "--autocorrect-all" else "--parallel" end
false
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/brew.rb
@@ -53,8 +53,8 @@ args = Homebrew::CLI::Parser.new.parse(ARGV.dup.freeze, ignore_invalid_options: true) Context.current = args.context - path = PATH.new(ENV["PATH"]) - homebrew_path = PATH.new(ENV["HOMEBREW_PATH"]) + path = PATH.new(ENV.fetch("PATH")) + homebrew_path = PATH.new(ENV.fetch("HOMEBREW_PATH")) # Add shared wrappers. path.prepend(HOMEBREW_SHIMS_PATH/"shared")
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/cask/artifact/installer.rb
@@ -39,7 +39,7 @@ def install_phase(command: nil, **_) executable_path, **args, env: { "PATH" => PATH.new( - HOMEBREW_PREFIX/"bin", HOMEBREW_PREFIX/"sbin", ENV["PATH"] + HOMEBREW_PREFIX/"bin", HOMEBREW_PREFIX/"sbin", ENV.fetch("PATH") ) }, ) end
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/caveats.rb
@@ -78,7 +78,7 @@ def keg_only_text(skip_reason: false) s << " #{Utils::Shell.export_value("CPPFLAGS", "-I#{f.opt_include}")}\n" if f.include.directory? - if which("pkg-config", ENV["HOMEBREW_PATH"]) && + if which("pkg-config", ORIGINAL_PATHS) && ((f.lib/"pkgconfig").directory? || (f.share/"pkgconfig").directory?) s << <<~EOS @@ -109,7 +109,7 @@ def keg def function_completion_caveats(shell) return unless keg - return unless which(shell.to_s, ENV["HOMEBREW_PATH"]) + return unless which(shell.to_s, ORIGINAL_PATHS) completion_installed = keg.completion_installed?(shell) functions_installed = keg.functions_installed?(shell)
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/cleanup.rb
@@ -391,7 +391,7 @@ def cleanup_lockfiles(*lockfiles) end def cleanup_portable_ruby - rubies = [which("ruby"), which("ruby", ENV["HOMEBREW_PATH"])].compact + rubies = [which("ruby"), which("ruby", ORIGINAL_PATHS)].compact system_ruby = Pathname.new("/usr/bin/ruby") rubies << system_ruby if system_ruby.exist?
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/cmd/log.rb
@@ -42,7 +42,7 @@ def log # As this command is simplifying user-run commands then let's just use a # user path, too. - ENV["PATH"] = ENV["HOMEBREW_PATH"] + ENV["PATH"] = PATH.new(ORIGINAL_PATHS).to_s if args.no_named? git_log HOMEBREW_REPOSITORY, args: args
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/commands.rb
@@ -93,11 +93,11 @@ def external_ruby_v2_cmd_path(cmd) # Ruby commands which are run by being `require`d. def external_ruby_cmd_path(cmd) - which("brew-#{cmd}.rb", PATH.new(ENV["PATH"]).append(Tap.cmd_directories)) + which("brew-#{cmd}.rb", PATH.new(ENV.fetch("PATH")).append(Tap.cmd_directories)) end def external_cmd_path(cmd) - which("brew-#{cmd}", PATH.new(ENV["PATH"]).append(Tap.cmd_directories)) + which("brew-#{cmd}", PATH.new(ENV.fetch("PATH")).append(Tap.cmd_directories)) end def path(cmd)
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/dev-cmd/bump-cask-pr.rb
@@ -67,7 +67,7 @@ def bump_cask_pr # As this command is simplifying user-run commands then let's just use a # user path, too. - ENV["PATH"] = ENV["HOMEBREW_PATH"] + ENV["PATH"] = PATH.new(ORIGINAL_PATHS).to_s # Use the user's browser, too. ENV["BROWSER"] = Homebrew::EnvConfig.browser
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/dev-cmd/bump-formula-pr.rb
@@ -108,7 +108,7 @@ def bump_formula_pr # As this command is simplifying user-run commands then let's just use a # user path, too. - ENV["PATH"] = ENV["HOMEBREW_PATH"] + ENV["PATH"] = PATH.new(ORIGINAL_PATHS).to_s # Use the user's browser, too. ENV["BROWSER"] = Homebrew::EnvConfig.browser
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/dev-cmd/bump-revision.rb
@@ -36,7 +36,7 @@ def bump_revision # As this command is simplifying user-run commands then let's just use a # user path, too. - ENV["PATH"] = ENV["HOMEBREW_PATH"] + ENV["PATH"] = PATH.new(ORIGINAL_PATHS).to_s args.named.to_formulae.each do |formula| current_revision = formula.revision
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/dev-cmd/sh.rb
@@ -38,7 +38,7 @@ def sh ENV.setup_build_environment if superenv?(args.env) # superenv stopped adding brew's bin but generally users will want it - ENV["PATH"] = PATH.new(ENV["PATH"]).insert(1, HOMEBREW_PREFIX/"bin") + ENV["PATH"] = PATH.new(ENV.fetch("PATH")).insert(1, HOMEBREW_PREFIX/"bin") end ENV["VERBOSE"] = "1" if args.verbose?
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/dev-cmd/update-test.rb
@@ -123,7 +123,7 @@ def update_test safe_system "git", "reset", "--hard", start_commit # update ENV["PATH"] - ENV["PATH"] = PATH.new(ENV["PATH"]).prepend(curdir/"bin") + ENV["PATH"] = PATH.new(ENV.fetch("PATH")).prepend(curdir/"bin") # run brew help to install portable-ruby (if needed) quiet_system "brew", "help"
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/download_strategy.rb
@@ -1139,7 +1139,7 @@ def source_modified_time private def env - { "PATH" => PATH.new("/usr/bin", Formula["cvs"].opt_bin, ENV["PATH"]) } + { "PATH" => PATH.new("/usr/bin", Formula["cvs"].opt_bin, ENV.fetch("PATH")) } end sig { returns(String) } @@ -1214,7 +1214,7 @@ def last_commit private def env - { "PATH" => PATH.new(Formula["mercurial"].opt_bin, ENV["PATH"]) } + { "PATH" => PATH.new(Formula["mercurial"].opt_bin, ENV.fetch("PATH")) } end sig { returns(String) } @@ -1280,7 +1280,7 @@ def last_commit def env { - "PATH" => PATH.new(Formula["bazaar"].opt_bin, ENV["PATH"]), + "PATH" => PATH.new(Formula["bazaar"].opt_bin, ENV.fetch("PATH")), "BZR_HOME" => HOMEBREW_TEMP, } end @@ -1345,7 +1345,7 @@ def repo_valid? private def env - { "PATH" => PATH.new(Formula["fossil"].opt_bin, ENV["PATH"]) } + { "PATH" => PATH.new(Formula["fossil"].opt_bin, ENV.fetch("PATH")) } end sig { returns(String) }
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/extend/ENV/std.rb
@@ -28,7 +28,7 @@ def setup_build_environment(formula: nil, cc: nil, build_bottle: false, bottle_a self["HOMEBREW_ENV"] = "std" - PATH.new(ENV["HOMEBREW_PATH"]).reverse_each { |p| prepend_path "PATH", p } + ORIGINAL_PATHS.reverse_each { |p| prepend_path "PATH", p } prepend_path "PATH", HOMEBREW_SHIMS_PATH/"shared" # Set the default pkg-config search path, overriding the built-in paths
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/formula.rb
@@ -421,9 +421,9 @@ def update_head_version return unless head.downloader.cached_location.exist? path = if ENV["HOMEBREW_ENV"] - ENV["PATH"] + ENV.fetch("PATH") else - ENV["HOMEBREW_PATH"] + PATH.new(ORIGINAL_PATHS) end with_env(PATH: path) do @@ -1103,7 +1103,7 @@ def run_post_install TMP: HOMEBREW_TEMP, _JAVA_OPTIONS: "-Djava.io.tmpdir=#{HOMEBREW_TEMP}", HOMEBREW_PATH: nil, - PATH: ENV["HOMEBREW_PATH"], + PATH: PATH.new(ORIGINAL_PATHS), } with_env(new_env) do @@ -2077,7 +2077,7 @@ def run_test(keep_tmp: false) TEMP: HOMEBREW_TEMP, TMP: HOMEBREW_TEMP, TERM: "dumb", - PATH: PATH.new(ENV["PATH"], HOMEBREW_PREFIX/"bin"), + PATH: PATH.new(ENV.fetch("PATH"), HOMEBREW_PREFIX/"bin"), HOMEBREW_PATH: nil, }.merge(common_stage_test_env) test_env[:_JAVA_OPTIONS] += " -Djava.io.tmpdir=#{HOMEBREW_TEMP}"
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/formula_cellar_checks.rb
@@ -299,7 +299,7 @@ def check_cpuid_instruction(formula) objdump = Formula["llvm"].opt_bin/"llvm-objdump" if Formula["llvm"].any_version_installed? objdump ||= Formula["binutils"].opt_bin/"objdump" if Formula["binutils"].any_version_installed? objdump ||= which("objdump") - objdump ||= which("objdump", ENV["HOMEBREW_PATH"]) + objdump ||= which("objdump", ORIGINAL_PATHS) unless objdump return <<~EOS
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/global.rb
@@ -119,8 +119,8 @@ def auditing? require "PATH" -ENV["HOMEBREW_PATH"] ||= ENV["PATH"] -ORIGINAL_PATHS = PATH.new(ENV["HOMEBREW_PATH"]).map do |p| +ENV["HOMEBREW_PATH"] ||= ENV.fetch("PATH") +ORIGINAL_PATHS = PATH.new(ENV.fetch("HOMEBREW_PATH")).map do |p| Pathname.new(p).expand_path rescue nil
true
Other
Homebrew
brew
02164a35dbc2320e9f4eb2e27ff952e0a157b6fa.json
Use ORIGINAL_PATHS over envs; reject nil PATH
Library/Homebrew/requirement.rb
@@ -103,7 +103,7 @@ def modify_build_environment(env: nil, cc: nil, build_bottle: false, bottle_arch parent = satisfied_result_parent return unless parent return if ["#{HOMEBREW_PREFIX}/bin", "#{HOMEBREW_PREFIX}/bin"].include?(parent.to_s) - return if PATH.new(ENV["PATH"]).include?(parent.to_s) + return if PATH.new(ENV.fetch("PATH")).include?(parent.to_s) ENV.prepend_path("PATH", parent) end
true