before_code stringlengths 30 149k | reviewer_comment stringlengths 16 20.6k | after_code stringlengths 30 163k | diff_context stringlengths 0 22.4k | file_path stringlengths 6 155 | comment_line int64 0 26 | language stringclasses 19
values | quality_score float64 0.07 1 | comment_type stringclasses 9
values | comment_length int64 16 20.6k | before_lines int64 2 4.61k | after_lines int64 2 4.4k | is_negative bool 2
classes | pr_title stringlengths 7 140 | pr_number int64 18 61.2k | repo_name stringclasses 29
values | repo_stars int64 321 56k | repo_language stringclasses 14
values | reviewer_username stringclasses 378
values | author_username stringclasses 739
values | user stringlengths 361 200k | assistant stringlengths 16 20.6k | system stringclasses 1
value |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
import au.com.shiftyjelly.pocketcasts.utils.featureflag.FeatureFlag
import au.com.shiftyjelly.pocketcasts.utils.log.LogBuffer
import com.automattic.android.experimentation.Experiment
import com.automattic.android.experimentation.VariationsRepository
import com.automattic.android.experimentation.domain.Variation.Control... | `initialize()` calls `accountStatusInfo.getUserIds()` before checking the feature flag. When the EXPLAT flag is disabled this can still generate/persist a new anon ID (and in unit tests it can NPE because a Mockito mock returns null for a non-null Kotlin type). Consider moving the `FeatureFlag.isEnabled(...)` check int... | import au.com.shiftyjelly.pocketcasts.utils.featureflag.FeatureFlag
import au.com.shiftyjelly.pocketcasts.utils.log.LogBuffer
import com.automattic.android.experimentation.Experiment
import com.automattic.android.experimentation.VariationsRepository
import com.automattic.android.experimentation.domain.Variation.Control... | @@ -15,31 +14,30 @@ import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
class ExperimentProvider @Inject constructor(
- private val tracksAnalyticsTracker: TracksAnalyticsTracker,
private val repository: VariationsRepository,
private val accountStatusInfo: AccountStatusInfo,
- ... | modules/services/analytics/src/main/java/au/com/shiftyjelly/pocketcasts/analytics/experiments/ExperimentProvider.kt | 26 | Kotlin | 0.786 | bug | 421 | 51 | 51 | false | Extract user ID tracking from Tracks tracker | 5,010 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/analytics/src/main/java/au/com/shiftyjelly/pocketcasts/analytics/experiments/ExperimentProvider.kt
PR Title: Extract user ID tracking from Tracks tracker
BEFORE CODE: import au.com.shiftyjelly.pocketcasts.utils.featureflag.FeatureFlag
import a... | `initialize()` calls `accountStatusInfo.getUserIds()` before checking the feature flag. When the EXPLAT flag is disabled this can still generate/persist a new anon ID (and in unit tests it can NPE because a Mockito mock returns null for a non-null Kotlin type). Consider moving the `FeatureFlag.isEnabled(...)` check int... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
) {
companion object {
const val TAG = "ExperimentsProvider"
const val PLATFORM = "pocketcasts"
}
fun initialize() {
initialize(accountStatusInfo.getUserIds().id)
}
fun initialize(uuid: String) {
if (FeatureFlag.isEnabled(Feature.EXPLAT_EXPERIMENT)) {
Lo... | `refreshExperiments()` computes `uuid ?: accountStatusInfo.getUserIds().id` unconditionally, so it will still read (and potentially create/persist) user IDs even when EXPLAT is disabled; it can also crash in tests for the same reason as `initialize()`. Recommend returning early when the feature flag is disabled, or onl... | ) {
companion object {
const val TAG = "ExperimentsProvider"
const val PLATFORM = "pocketcasts"
}
fun initialize() {
if (FeatureFlag.isEnabled(Feature.EXPLAT_EXPERIMENT)) {
initialize(accountStatusInfo.getUserIds().id)
}
}
fun initialize(uuid: String) {
... | @@ -15,31 +14,30 @@ import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
class ExperimentProvider @Inject constructor(
- private val tracksAnalyticsTracker: TracksAnalyticsTracker,
private val repository: VariationsRepository,
private val accountStatusInfo: AccountStatusInfo,
- ... | modules/services/analytics/src/main/java/au/com/shiftyjelly/pocketcasts/analytics/experiments/ExperimentProvider.kt | 26 | Kotlin | 0.643 | bug | 389 | 40 | 44 | false | Extract user ID tracking from Tracks tracker | 5,010 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/analytics/src/main/java/au/com/shiftyjelly/pocketcasts/analytics/experiments/ExperimentProvider.kt
PR Title: Extract user ID tracking from Tracks tracker
BEFORE CODE: ) {
companion object {
const val TAG = "ExperimentsProvider"
... | `refreshExperiments()` computes `uuid ?: accountStatusInfo.getUserIds().id` unconditionally, so it will still read (and potentially create/persist) user IDs even when EXPLAT is disabled; it can also crash in tests for the same reason as `initialize()`. Recommend returning early when the feature flag is disabled, or onl... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
import au.com.shiftyjelly.pocketcasts.preferences.AccountConstants
import au.com.shiftyjelly.pocketcasts.utils.extensions.getString
import java.util.UUID
import junit.framework.TestCase.assertEquals
import junit.framework.TestCase.assertFalse
import junit.framework.TestCase.assertNull
import junit.framework.TestCase.as... | `sharedPrefs.edit().clear()` doesn't apply/commit the edit, so preferences may not actually be cleared between tests (leading to order-dependent/flaky behavior). Use the `edit { clear() }` extension or call `apply()`/`commit()` on the editor.
```suggestion
sharedPrefs.edit {
clear()
}
``` | import au.com.shiftyjelly.pocketcasts.preferences.AccountConstants
import au.com.shiftyjelly.pocketcasts.utils.extensions.getString
import java.util.UUID
import junit.framework.TestCase.assertEquals
import junit.framework.TestCase.assertFalse
import junit.framework.TestCase.assertNull
import junit.framework.TestCase.as... | @@ -12,54 +15,77 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.Mockito.mock
-import org.mockito.Mockito.`when`
-import org.mockito.junit.MockitoJUnitRunner
+import org.mockito.kotlin.whenever
+import org.robolectric.RobolectricTestRunner
+import org.robolectric.R... | modules/services/repositories/src/test/java/au/com/shiftyjelly/pocketcasts/repositories/sync/AccountManagerStatusInfoTest.kt | 26 | Kotlin | 0.857 | suggestion | 317 | 51 | 51 | false | Extract user ID tracking from Tracks tracker | 5,010 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/test/java/au/com/shiftyjelly/pocketcasts/repositories/sync/AccountManagerStatusInfoTest.kt
PR Title: Extract user ID tracking from Tracks tracker
BEFORE CODE: import au.com.shiftyjelly.pocketcasts.preferences.AccountConstants
... | `sharedPrefs.edit().clear()` doesn't apply/commit the edit, so preferences may not actually be cleared between tests (leading to order-dependent/flaky behavior). Use the `edit { clear() }` extension or call `apply()`/`commit()` on the editor.
```suggestion
sharedPrefs.edit {
clear()
}
``` | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
userEpisode {
isArchived = true
},
)
upNextEpisodes += upNext
assertProviderEpisodes(upNext.take(3))
}
@Test
fun `ignore played up next episodes`() = runTest {
val upNext = listOf(
podcastEpisode(),
userEpisode... | These new test cases for `ignore archived up next episodes` and `ignore played up next episodes` don't appear to be related to the PR's stated purpose of "extracting user ID tracking from Tracks tracker." These tests seem to verify existing behavior in the auto-download feature. While they're good tests to have, they s... | fun `ignore archived user episodes`() = runTest {
val user = listOf(
userEpisode(),
userEpisode {
isArchived = true
},
)
userEpisodes += user
assertProviderEpisodes(user.take(1))
}
@Test
fun `ignore played user episode... | @@ -196,6 +196,42 @@ class AutoDownloadEpisodeProviderTest {
assertProviderEpisodes(upNext)
}
+ @Test
+ fun `ignore archived up next episodes`() = runTest {
+ val upNext = listOf(
+ podcastEpisode(),
+ userEpisode(),
+ podcastEpisode(),
+ podcastE... | modules/services/repositories/src/test/java/au/com/shiftyjelly/pocketcasts/repositories/download/AutoDownloadEpisodeProviderTest.kt | 26 | Kotlin | 0.643 | refactor | 425 | 51 | 51 | false | Extract user ID tracking from Tracks tracker | 5,010 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/test/java/au/com/shiftyjelly/pocketcasts/repositories/download/AutoDownloadEpisodeProviderTest.kt
PR Title: Extract user ID tracking from Tracks tracker
BEFORE CODE: userEpisode {
isArchived = true
... | These new test cases for `ignore archived up next episodes` and `ignore played up next episodes` don't appear to be related to the PR's stated purpose of "extracting user ID tracking from Tracks tracker." These tests seem to verify existing behavior in the auto-download feature. While they're good tests to have, they s... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
import au.com.shiftyjelly.pocketcasts.analytics.experiments.Experiment
import au.com.shiftyjelly.pocketcasts.analytics.experiments.ExperimentProvider
import au.com.shiftyjelly.pocketcasts.servers.di.Cached
import au.com.shiftyjelly.pocketcasts.utils.log.LogBuffer
import com.automattic.android.experimentation.Experiment... | ```suggestion
// Necessary to satisfy Dagger injection
@Provides
``` | import au.com.shiftyjelly.pocketcasts.analytics.experiments.Experiment
import au.com.shiftyjelly.pocketcasts.analytics.experiments.ExperimentProvider
import au.com.shiftyjelly.pocketcasts.servers.di.Cached
import au.com.shiftyjelly.pocketcasts.utils.log.LogBuffer
import com.automattic.android.experimentation.Experiment... | @@ -24,7 +31,29 @@ import okhttp3.OkHttpClient
@Module
@InstallIn(SingletonComponent::class)
-object ExperimentModule {
+object AnalyticsModule {
+ @Provides | modules/services/analytics/src/main/java/au/com/shiftyjelly/pocketcasts/analytics/di/AnalyticsModule.kt | 26 | Kotlin | 0.714 | security | 76 | 51 | 51 | false | Move trackers to release build | 5,011 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/analytics/src/main/java/au/com/shiftyjelly/pocketcasts/analytics/di/AnalyticsModule.kt
PR Title: Move trackers to release build
BEFORE CODE: import au.com.shiftyjelly.pocketcasts.analytics.experiments.Experiment
import au.com.shiftyjelly.pocke... | ```suggestion
// Necessary to satisfy Dagger injection
@Provides
``` | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
package au.com.shiftyjelly.pocketcasts.analytics
interface Tracker {
val id: String
fun shouldTrack(event: AnalyticsEvent): Boolean
fun track(event: AnalyticsEvent, properties: Map<String, Any> = emptyMap()): TrackedEvent
fun refreshMetadata()
fun flush()
fun clearAllData()
}
| `NoOpTracker` looks to exist solely to support the `@IntoSet` binding in `AnalyticsModule`. If that binding is removed to keep `debug`/`debugProd` free of trackers, `NoOpTracker` will become dead code; consider removing it as well (or moving it to test-only code if it’s needed for testing).
```suggestion
``` | fun track(event: AnalyticsEvent, properties: Map<String, Any> = emptyMap()): TrackedEvent
fun refreshMetadata()
fun flush()
fun clearAllData()
companion object {
const val INVALID_OR_NULL_VALUE = "none"
}
}
internal object NoOpTracker : Tracker {
override val id = "no-op"
o... | @@ -12,4 +12,22 @@ interface Tracker {
fun flush()
fun clearAllData()
+
+ companion object {
+ const val INVALID_OR_NULL_VALUE = "none"
+ }
+}
+
+internal object NoOpTracker : Tracker {
+ override val id = "no-op"
+
+ override fun shouldTrack(event: AnalyticsEvent) = false
+
+ override... | modules/services/analytics/src/main/java/au/com/shiftyjelly/pocketcasts/analytics/Tracker.kt | 16 | Kotlin | 1 | bug | 310 | 16 | 27 | false | Move trackers to release build | 5,011 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/analytics/src/main/java/au/com/shiftyjelly/pocketcasts/analytics/Tracker.kt
PR Title: Move trackers to release build
BEFORE CODE: package au.com.shiftyjelly.pocketcasts.analytics
interface Tracker {
val id: String
fun shouldTrack(eve... | `NoOpTracker` looks to exist solely to support the `@IntoSet` binding in `AnalyticsModule`. If that binding is removed to keep `debug`/`debugProd` free of trackers, `NoOpTracker` will become dead code; consider removing it as well (or moving it to test-only code if it’s needed for testing).
```suggestion
``` | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
podcastDao.updateAutoDownloadStatus(podcastUuids, status)
if (isEnabled) {
settings.autoDownloadNewEpisodes.set(Podcast.AUTO_DOWNLOAD_NEW_EPISODES, updateModifiedAt = false)
} else {
val podcasts = podcastDao.findSubscribedNoOrder()
if (podcasts.none { it.isAu... | Use explicit constant `Podcast.AUTO_DOWNLOAD_OFF` instead of `autoDownloadStatus` for consistency. While the value is correct (both are 0), line 497 in the suspend variant uses the explicit constant, making the intent clearer and the code more maintainable.
```suggestion
settings.autoDownloadNewEpisodes... | podcastDao.updateAutoDownloadStatus(podcastUuids, status)
if (isEnabled) {
settings.autoDownloadNewEpisodes.set(Podcast.AUTO_DOWNLOAD_NEW_EPISODES, updateModifiedAt = true)
} else {
val podcasts = podcastDao.findSubscribedNoOrder()
if (podcasts.none { it.isAut... | @@ -500,6 +508,14 @@ class PodcastManagerImpl @Inject constructor(
override fun updateAutoDownloadStatusBlocking(podcast: Podcast, autoDownloadStatus: Int) {
podcastDao.updateAutoDownloadStatusBlocking(autoDownloadStatus, podcast.uuid)
+ if (autoDownloadStatus == Podcast.AUTO_DOWNLOAD_NEW_EPISODE... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/podcast/PodcastManagerImpl.kt | 26 | Kotlin | 1 | suggestion | 381 | 51 | 51 | false | Fix inconsistent auto-download settings | 5,013 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/podcast/PodcastManagerImpl.kt
PR Title: Fix inconsistent auto-download settings
BEFORE CODE: podcastDao.updateAutoDownloadStatus(podcastUuids, status)
if (i... | Use explicit constant `Podcast.AUTO_DOWNLOAD_OFF` instead of `autoDownloadStatus` for consistency. While the value is correct (both are 0), line 497 in the suspend variant uses the explicit constant, making the intent clearer and the code more maintainable.
```suggestion
settings.autoDownloadNewEpisodes... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
}
override suspend fun updateAutoDownload(podcastUuids: Collection<String>, isEnabled: Boolean) {
val status = if (isEnabled) Podcast.AUTO_DOWNLOAD_NEW_EPISODES else Podcast.AUTO_DOWNLOAD_OFF
podcastDao.updateAutoDownloadStatus(podcastUuids, status)
if (isEnabled) {
settings... | When the global auto-download setting is automatically updated (e.g., when enabling a podcast's auto-download), it uses updateModifiedAt: false, which means this change won't be synced to other devices. However, when the user directly toggles the global setting in AutoDownloadSettingsViewModel.changeNewEpisodesDownload... | }
override suspend fun updateAutoDownload(podcastUuids: Collection<String>, isEnabled: Boolean) {
val status = if (isEnabled) Podcast.AUTO_DOWNLOAD_NEW_EPISODES else Podcast.AUTO_DOWNLOAD_OFF
podcastDao.updateAutoDownloadStatus(podcastUuids, status)
if (isEnabled) {
settings... | @@ -500,6 +508,14 @@ class PodcastManagerImpl @Inject constructor(
override fun updateAutoDownloadStatusBlocking(podcast: Podcast, autoDownloadStatus: Int) {
podcastDao.updateAutoDownloadStatusBlocking(autoDownloadStatus, podcast.uuid)
+ if (autoDownloadStatus == Podcast.AUTO_DOWNLOAD_NEW_EPISODE... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/podcast/PodcastManagerImpl.kt | 26 | Kotlin | 0.643 | suggestion | 628 | 51 | 51 | false | Fix inconsistent auto-download settings | 5,013 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/podcast/PodcastManagerImpl.kt
PR Title: Fix inconsistent auto-download settings
BEFORE CODE: }
override suspend fun updateAutoDownload(podcastUuids: Collection<Str... | When the global auto-download setting is automatically updated (e.g., when enabling a podcast's auto-download), it uses updateModifiedAt: false, which means this change won't be synced to other devices. However, when the user directly toggles the global setting in AutoDownloadSettingsViewModel.changeNewEpisodesDownload... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
podcastDao.updateAutoDownloadStatus(podcastUuids, status)
if (isEnabled) {
settings.autoDownloadNewEpisodes.set(Podcast.AUTO_DOWNLOAD_NEW_EPISODES, updateModifiedAt = false)
} else {
val podcasts = podcastDao.findSubscribedNoOrder()
if (podcasts.none { it.isAu... | When the global auto-download setting is automatically updated (e.g., when disabling the last podcast with auto-download), it uses updateModifiedAt: false, which means this change won't be synced to other devices. However, when the user directly toggles the global setting in AutoDownloadSettingsViewModel.changeNewEpiso... | podcastDao.updateAutoDownloadStatus(podcastUuids, status)
if (isEnabled) {
settings.autoDownloadNewEpisodes.set(Podcast.AUTO_DOWNLOAD_NEW_EPISODES, updateModifiedAt = true)
} else {
val podcasts = podcastDao.findSubscribedNoOrder()
if (podcasts.none { it.isAut... | @@ -500,6 +508,14 @@ class PodcastManagerImpl @Inject constructor(
override fun updateAutoDownloadStatusBlocking(podcast: Podcast, autoDownloadStatus: Int) {
podcastDao.updateAutoDownloadStatusBlocking(autoDownloadStatus, podcast.uuid)
+ if (autoDownloadStatus == Podcast.AUTO_DOWNLOAD_NEW_EPISODE... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/podcast/PodcastManagerImpl.kt | 26 | Kotlin | 0.643 | suggestion | 639 | 51 | 51 | false | Fix inconsistent auto-download settings | 5,013 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/podcast/PodcastManagerImpl.kt
PR Title: Fix inconsistent auto-download settings
BEFORE CODE: podcastDao.updateAutoDownloadStatus(podcastUuids, status)
if (i... | When the global auto-download setting is automatically updated (e.g., when disabling the last podcast with auto-download), it uses updateModifiedAt: false, which means this change won't be synced to other devices. However, when the user directly toggles the global setting in AutoDownloadSettingsViewModel.changeNewEpiso... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
val recurranceCount = (freePricingPhase.schedule.recurrenceMode as RecurrenceMode.Recurring).value
val periodCount = freePricingPhase.schedule.periodCount
val totalCount = recurranceCount * periodCount
return when (freePricingPhase.schedule.period) {
Peri... | The `commitmentPaymentsCount` property only returns a non-zero value when `paidPricingPhase.schedule.period == Period.Monthly`. However, this assumption may not always hold for installment plans. If the paid pricing phase has a different period structure, this will return 0, which will cause the UI string to show "0 mo... | val offerDurationText: String
@Composable get() {
val recurranceCount = (freePricingPhase.schedule.recurrenceMode as RecurrenceMode.Recurring).value
val periodCount = freePricingPhase.schedule.periodCount
val totalCount = recurranceCount * periodCount
return ... | @@ -51,6 +51,39 @@ data class ReferralSubscriptionPlan private constructor(
val priceAfterOffer get() = paidPricingPhase.price
+ val isInstallment get() = key.isInstallment
+
+ val monthlyPaymentAmount: String
+ @Composable get() = if (isInstallment) {
+ paidPricingPhase.price.formatted... | modules/features/referrals/src/main/kotlin/au/com/shiftyjelly/pocketcasts/referrals/ReferralSubscriptionPlan.kt | 26 | Kotlin | 1 | bug | 801 | 51 | 51 | false | [Installments] Referral updates | 5,018 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/referrals/src/main/kotlin/au/com/shiftyjelly/pocketcasts/referrals/ReferralSubscriptionPlan.kt
PR Title: [Installments] Referral updates
BEFORE CODE: val recurranceCount = (freePricingPhase.schedule.recurrenceMode as RecurrenceMode... | The `commitmentPaymentsCount` property only returns a non-zero value when `paidPricingPhase.schedule.period == Period.Monthly`. However, this assumption may not always hold for installment plans. If the paid pricing phase has a different period structure, this will return 0, which will cause the UI string to show "0 mo... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
val monthlyPaymentAmount: String
@Composable get() = if (isInstallment) {
paidPricingPhase.price.formattedPrice
} else {
""
}
val commitmentPaymentsCount: Int
get() = if (isInstallment && paidPricingPhase.schedule.period == Period.Monthly) {
p... | The `totalCommitmentAmount` calculation doesn't guard against the case where `commitmentPaymentsCount` is 0. When `paidPricingPhase.schedule.period` is not `Period.Monthly`, `commitmentPaymentsCount` returns 0, which makes `totalCommitmentAmount` equal to 0. This will then cause `formattedTotalCommitmentAmount` to retu... | val isInstallment get() = key.isInstallment
val monthlyPaymentAmount: String
@Composable get() = if (isInstallment) {
paidPricingPhase.price.formattedPrice
} else {
""
}
val commitmentPaymentsCount: Int
get() = if (isInstallment && paidPricingPhase.s... | @@ -51,6 +51,39 @@ data class ReferralSubscriptionPlan private constructor(
val priceAfterOffer get() = paidPricingPhase.price
+ val isInstallment get() = key.isInstallment
+
+ val monthlyPaymentAmount: String
+ @Composable get() = if (isInstallment) {
+ paidPricingPhase.price.formatted... | modules/features/referrals/src/main/kotlin/au/com/shiftyjelly/pocketcasts/referrals/ReferralSubscriptionPlan.kt | 26 | Kotlin | 0.786 | bug | 600 | 51 | 51 | false | [Installments] Referral updates | 5,018 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/referrals/src/main/kotlin/au/com/shiftyjelly/pocketcasts/referrals/ReferralSubscriptionPlan.kt
PR Title: [Installments] Referral updates
BEFORE CODE: val monthlyPaymentAmount: String
@Composable get() = if (isInstallment) {
... | The `totalCommitmentAmount` calculation doesn't guard against the case where `commitmentPaymentsCount` is 0. When `paidPricingPhase.schedule.period` is not `Period.Monthly`, `commitmentPaymentsCount` returns 0, which makes `totalCommitmentAmount` equal to 0. This will then cause `formattedTotalCommitmentAmount` to retu... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
@Composable get() = if (isInstallment) {
paidPricingPhase.price.formattedPrice
} else {
""
}
val commitmentPaymentsCount: Int
get() = if (isInstallment && paidPricingPhase.schedule.period == Period.Monthly) {
paidPricingPhase.schedule.periodCount
... | The currency formatting here is incorrect. It uses `currencyCode` directly as the currency symbol and doesn't use locale-aware formatting. For example, it would produce "USD100.00" instead of "$100.00" or "€100,00" for EUR. Additionally, the decimal formatting doesn't respect locale conventions (some locales use commas... |
val monthlyPaymentAmount: String
@Composable get() = if (isInstallment) {
paidPricingPhase.price.formattedPrice
} else {
""
}
val commitmentPaymentsCount: Int
get() = if (isInstallment && paidPricingPhase.schedule.period == Period.Monthly) {
... | @@ -51,6 +51,39 @@ data class ReferralSubscriptionPlan private constructor(
val priceAfterOffer get() = paidPricingPhase.price
+ val isInstallment get() = key.isInstallment
+
+ val monthlyPaymentAmount: String
+ @Composable get() = if (isInstallment) {
+ paidPricingPhase.price.formatted... | modules/features/referrals/src/main/kotlin/au/com/shiftyjelly/pocketcasts/referrals/ReferralSubscriptionPlan.kt | 26 | Kotlin | 1 | bug | 1,139 | 51 | 51 | false | [Installments] Referral updates | 5,018 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/referrals/src/main/kotlin/au/com/shiftyjelly/pocketcasts/referrals/ReferralSubscriptionPlan.kt
PR Title: [Installments] Referral updates
BEFORE CODE: @Composable get() = if (isInstallment) {
paidPricingPhase.price.formatted... | The currency formatting here is incorrect. It uses `currencyCode` directly as the currency symbol and doesn't use locale-aware formatting. For example, it would produce "USD100.00" instead of "$100.00" or "€100,00" for EUR. Additionally, the decimal formatting doesn't respect locale conventions (some locales use commas... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
import io.reactivex.Flowable
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.test.runTest
import org.junit.Assert.assertEquals
import org.junit.Assert.assertTrue
import org.junit.Rule
import org.junit.Test
import org.mockito.Mockito.mock
import org.mockito.kotlin.verify
import org.mockito.... | The test creates a referral plan with `isInstallment = true`, but the actual ViewModel checks the `NEW_INSTALLMENT_PLAN` feature flag before loading an installment plan. Since this test doesn't enable the feature flag, the ViewModel will load the regular (non-installment) plan instead, causing a mismatch between the ex... | import io.reactivex.Flowable
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.test.runTest
import org.junit.Assert.assertEquals
import org.junit.Assert.assertTrue
import org.junit.Rule
import org.junit.Test
import org.mockito.Mockito.mock
import org.mockito.kotlin.verify
import org.mockito.... | @@ -50,7 +50,7 @@ class ReferralsClaimGuestPassViewModelTest {
private lateinit var viewModel: ReferralsClaimGuestPassViewModel
private val referralCode = "referral_code"
private val referralPlan = SubscriptionPlans.Preview
- .findOfferPlan(SubscriptionTier.Plus, BillingCycle.Yearly, SubscriptionO... | modules/features/referrals/src/test/kotlin/au/com/shiftyjelly/pocketcasts/referrals/ReferralsClaimGuestPassViewModelTest.kt | 26 | Kotlin | 0.857 | suggestion | 636 | 51 | 51 | false | [Installments] Referral updates | 5,018 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/referrals/src/test/kotlin/au/com/shiftyjelly/pocketcasts/referrals/ReferralsClaimGuestPassViewModelTest.kt
PR Title: [Installments] Referral updates
BEFORE CODE: import io.reactivex.Flowable
import kotlinx.coroutines.ExperimentalCoroutinesApi
... | The test creates a referral plan with `isInstallment = true`, but the actual ViewModel checks the `NEW_INSTALLMENT_PLAN` feature flag before loading an installment plan. Since this test doesn't enable the feature flag, the ViewModel will load the regular (non-installment) plan instead, causing a mismatch between the ex... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
package au.com.shiftyjelly.pocketcasts.utils.extensions
import au.com.shiftyjelly.pocketcasts.payment.BillingCycle
import au.com.shiftyjelly.pocketcasts.payment.SubscriptionPlan
import au.com.shiftyjelly.pocketcasts.payment.SubscriptionPlans
import au.com.shiftyjelly.pocketcasts.payment.SubscriptionTier
import au.com.... | The function name `getYearlyPlanWithFeatureFlag` is now misleading since it no longer checks a feature flag directly. It now accepts a `shouldUseInstallmentPlan` boolean parameter. Consider renaming to something like `getYearlyPlan` or `getYearlyPlanForInstallments` to better reflect its current purpose.
```suggestion
... | package au.com.shiftyjelly.pocketcasts.utils.extensions
import au.com.shiftyjelly.pocketcasts.payment.BillingCycle
import au.com.shiftyjelly.pocketcasts.payment.SubscriptionPlan
import au.com.shiftyjelly.pocketcasts.payment.SubscriptionPlans
import au.com.shiftyjelly.pocketcasts.payment.SubscriptionTier
import au.com.... | @@ -5,24 +5,21 @@ import au.com.shiftyjelly.pocketcasts.payment.SubscriptionPlan
import au.com.shiftyjelly.pocketcasts.payment.SubscriptionPlans
import au.com.shiftyjelly.pocketcasts.payment.SubscriptionTier
import au.com.shiftyjelly.pocketcasts.payment.getOrNull
-import au.com.shiftyjelly.pocketcasts.utils.featuref... | modules/services/utils/src/main/java/au/com/shiftyjelly/pocketcasts/utils/extensions/PaymentExtensions.kt | 18 | Kotlin | 0.857 | suggestion | 360 | 35 | 32 | false | [Installmetns] Add and wire up experiment | 5,029 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | sztomek | Review this pull request change.
Language: Kotlin
File: modules/services/utils/src/main/java/au/com/shiftyjelly/pocketcasts/utils/extensions/PaymentExtensions.kt
PR Title: [Installmetns] Add and wire up experiment
BEFORE CODE: package au.com.shiftyjelly.pocketcasts.utils.extensions
import au.com.shiftyjelly.pocket... | The function name `getYearlyPlanWithFeatureFlag` is now misleading since it no longer checks a feature flag directly. It now accepts a `shouldUseInstallmentPlan` boolean parameter. Consider renaming to something like `getYearlyPlan` or `getYearlyPlanForInstallments` to better reflect its current purpose.
```suggestion
... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
package au.com.shiftyjelly.pocketcasts.profile
import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import au.com.shiftyjelly.pocketcasts.analytics.AnalyticsEvent
import au.com.shiftyjelly.pocketcasts.analytics.SourceView
import au.com.shiftyjelly.pocketcasts.models.to.RefreshState
import au.co... | The import for AnalyticsEvent is no longer used and should be removed since all events have been migrated to EventHorizon.
```suggestion
``` | package au.com.shiftyjelly.pocketcasts.profile
import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import au.com.shiftyjelly.pocketcasts.analytics.SourceView
import au.com.shiftyjelly.pocketcasts.models.to.RefreshState
import au.com.shiftyjelly.pocketcasts.models.type.SignInState
import au.com... | @@ -3,7 +3,6 @@ package au.com.shiftyjelly.pocketcasts.profile
import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import au.com.shiftyjelly.pocketcasts.analytics.AnalyticsEvent | modules/features/profile/src/main/java/au/com/shiftyjelly/pocketcasts/profile/ProfileViewModel.kt | 5 | Kotlin | 0.786 | suggestion | 141 | 30 | 30 | false | Migrate profile events to Event Horizon | 5,032 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/profile/src/main/java/au/com/shiftyjelly/pocketcasts/profile/ProfileViewModel.kt
PR Title: Migrate profile events to Event Horizon
BEFORE CODE: package au.com.shiftyjelly.pocketcasts.profile
import androidx.lifecycle.ViewModel
import androidx... | The import for AnalyticsEvent is no longer used and should be removed since all events have been migrated to EventHorizon.
```suggestion
``` | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
fun onFragmentPause(isChangingConfigurations: Boolean?) {
isFragmentChangingConfigurations = isChangingConfigurations ?: false
}
fun cleanupConfirmationDialog(context: Context) = ManualCleanupConfirmationDialog(context = context, onConfirm = ::onDeleteConfirmed)
private fun Array<EpisodePlayin... | Named argument `inlcudeStarred` appears to be misspelled (likely should be `includeStarred`). If `DownloadsCleanUpCompletedEvent` uses the correctly spelled parameter, this will fail to compile; even if it compiles, the resulting analytics payload field name will be wrong.
```suggestion
includeStarred =... | fun onFragmentPause(isChangingConfigurations: Boolean?) {
isFragmentChangingConfigurations = isChangingConfigurations ?: false
}
fun cleanupConfirmationDialog(context: Context) = ManualCleanupConfirmationDialog(context = context, onConfirm = ::onDeleteConfirmed)
private fun Array<EpisodePlayin... | @@ -182,22 +188,13 @@ class ManualCleanupViewModel
}
private fun trackCleanupCompleted() {
- val properties = HashMap<String, Boolean>()
- state.value.diskSpaceViews.forEach {
- when (it.title) {
- LR.string.unplayed -> properties[UNPLAYED_KEY] = it.isChecked
- ... | modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/viewmodel/ManualCleanupViewModel.kt | 26 | Kotlin | 0.857 | bug | 351 | 31 | 31 | false | Migrate downloads events to Event Horizon | 5,033 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/viewmodel/ManualCleanupViewModel.kt
PR Title: Migrate downloads events to Event Horizon
BEFORE CODE: fun onFragmentPause(isChangingConfigurations: Boolean?) {
isFragmen... | Named argument `inlcudeStarred` appears to be misspelled (likely should be `includeStarred`). If `DownloadsCleanUpCompletedEvent` uses the correctly spelled parameter, this will fail to compile; even if it compiles, the resulting analytics payload field name will be wrong.
```suggestion
includeStarred =... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
}
fun cleanupConfirmationDialog(context: Context) = ManualCleanupConfirmationDialog(context = context, onConfirm = ::onDeleteConfirmed)
private fun Array<EpisodePlayingStatus>.mapToDiskSpaceViewsForEpisodes(
episodes: List<PodcastEpisode>,
) = map { episodePlayingStatus ->
_state.value... | `trackCleanupCompleted()` now builds a structured `DownloadsCleanUpCompletedEvent` from UI selections, but there’s no unit test validating the emitted event fields (unplayed/inProgress/played/includeStarred) or that the event is emitted on delete confirmation. Consider extracting event construction into a testable func... | }
fun cleanupConfirmationDialog(context: Context) = ManualCleanupConfirmationDialog(context = context, onConfirm = ::onDeleteConfirmed)
private fun Array<EpisodePlayingStatus>.mapToDiskSpaceViewsForEpisodes(
episodes: List<PodcastEpisode>,
) = map { episodePlayingStatus ->
_state.value... | @@ -182,22 +188,13 @@ class ManualCleanupViewModel
}
private fun trackCleanupCompleted() {
- val properties = HashMap<String, Boolean>()
- state.value.diskSpaceViews.forEach {
- when (it.title) {
- LR.string.unplayed -> properties[UNPLAYED_KEY] = it.isChecked
- ... | modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/viewmodel/ManualCleanupViewModel.kt | 26 | Kotlin | 0.643 | refactor | 417 | 29 | 29 | false | Migrate downloads events to Event Horizon | 5,033 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/viewmodel/ManualCleanupViewModel.kt
PR Title: Migrate downloads events to Event Horizon
BEFORE CODE: }
fun cleanupConfirmationDialog(context: Context) = ManualCleanupConfi... | `trackCleanupCompleted()` now builds a structured `DownloadsCleanUpCompletedEvent` from UI selections, but there’s no unit test validating the emitted event fields (unplayed/inProgress/played/includeStarred) or that the event is emitted on delete confirmation. Consider extracting event construction into a testable func... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
import org.junit.Test
import org.mockito.kotlin.mock
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever
import au.com.shiftyjelly.pocketcasts.localization.R as LR
@OptIn(ExperimentalCoroutinesApi::class)
class ManualCleanupViewModelTest {
@get:Rule
val coroutineRule = MainCoroutineRule()
p... | ManualCleanupViewModel now tracks cleanup analytics via EventHorizon, but this test suite doesn’t assert that the expected events are emitted (e.g., `DownloadsCleanUpShownEvent` from `setup()` and `DownloadsCleanUpButtonTappedEvent` from `onDeleteButtonClicked()`). Consider keeping a reference to `TestEventSink` and ad... | import org.junit.Rule
import org.junit.Test
import org.mockito.kotlin.mock
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever
import au.com.shiftyjelly.pocketcasts.localization.R as LR
@OptIn(ExperimentalCoroutinesApi::class)
class ManualCleanupViewModelTest {
@get:Rule
val coroutineRule = Mai... | @@ -34,7 +35,7 @@ class ManualCleanupViewModelTest {
episodeManager = mock()
whenever(episodeManager.findDownloadedEpisodesRxFlowable())
.thenReturn(Flowable.generate { listOf(episodes) })
- viewModel = ManualCleanupViewModel(episodeManager, mock(), AnalyticsTracker.test())
+ ... | modules/features/settings/src/test/java/au/com/shiftyjelly/pocketcasts/settings/viewmodel/ManualCleanupViewModelTest.kt | 26 | Kotlin | 0.643 | suggestion | 398 | 51 | 51 | false | Migrate downloads events to Event Horizon | 5,033 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/settings/src/test/java/au/com/shiftyjelly/pocketcasts/settings/viewmodel/ManualCleanupViewModelTest.kt
PR Title: Migrate downloads events to Event Horizon
BEFORE CODE: import org.junit.Test
import org.mockito.kotlin.mock
import org.mockito.kot... | ManualCleanupViewModel now tracks cleanup analytics via EventHorizon, but this test suite doesn’t assert that the expected events are emitted (e.g., `DownloadsCleanUpShownEvent` from `setup()` and `DownloadsCleanUpButtonTappedEvent` from `onDeleteButtonClicked()`). Consider keeping a reference to `TestEventSink` and ad... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
ResponsiveTimeText(
modifier = modifier,
startCurvedContent = if (isConnected) {
null
} else {
{
curvedComposable {
OfflineIcon()
}
}
},
startLinearContent = if (isConnected) {
... | The content description "Offline icon" is hardcoded. According to the coding guidelines, all strings that need to be localized should be in `modules/services/localization/src/main/res/values/strings.xml`. Consider adding a string resource like `offline_indicator` and using `stringResource(LR.string.offline_indicator)` ... | ) {
ResponsiveTimeText(
modifier = modifier,
startCurvedContent = if (isConnected) {
null
} else {
{
curvedComposable {
OfflineIcon()
}
}
},
startLinearContent = if (isConnected) {
... | @@ -0,0 +1,78 @@
+package au.com.shiftyjelly.pocketcasts.wear.ui.component
+
+import androidx.compose.foundation.layout.padding
+import androidx.compose.foundation.layout.size
+import androidx.compose.runtime.Composable
+import androidx.compose.ui.Modifier
+import androidx.compose.ui.res.painterResource
+import android... | wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/component/TimeTextWithConnectivity.kt | 26 | Kotlin | 0.643 | suggestion | 352 | 49 | 49 | false | [Quality Q1] WearOS - Show offline indicator next to time text | 5,036 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | sztomek | Review this pull request change.
Language: Kotlin
File: wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/component/TimeTextWithConnectivity.kt
PR Title: [Quality Q1] WearOS - Show offline indicator next to time text
BEFORE CODE: ResponsiveTimeText(
modifier = modifier,
startCurvedCont... | The content description "Offline icon" is hardcoded. According to the coding guidelines, all strings that need to be localized should be in `modules/services/localization/src/main/res/values/strings.xml`. Consider adding a string resource like `offline_indicator` and using `stringResource(LR.string.offline_indicator)` ... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
onShowLoginScreen: () -> Unit,
onRetrySync: () -> Unit,
signOut: () -> Unit,
showConnectivityNotification: Boolean,
isConnected: Boolean,
dismissConnectivityNotification: () -> Unit,
) {
val navController = rememberSwipeDismissableNavController()
val swipeToDismissState = rememberSwipeTo... | I don't think it's a good idea to remove the time and connection status icons from the Now Playing page. If we remove the “Streaming may be affected” panel, we should ensure the cloud icon is clearly visible on the Now Playing screen so users still have feedback about the streaming status. | val swipeToDismissState = rememberSwipeToDismissBoxState()
val navState = rememberSwipeDismissableNavHostState(swipeToDismissState)
if (showLoggingInScreen) {
navController.navigate(LoggingInScreen.ROUTE_WITH_DELAY)
onShowLoginScreen()
}
val userCanAccessWatch = signInState.isSigne... | @@ -121,259 +126,271 @@ private fun WearApp(
val startDestination = if (userCanAccessWatch) WatchListScreen.ROUTE else RequirePlusScreen.ROUTE
- Box(modifier = Modifier.fillMaxSize()) {
- AppScaffold {
- SwipeDismissableNavHost(
- startDestination = startDestination,
- ... | wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/MainActivity.kt | 26 | Kotlin | 0.5 | suggestion | 290 | 51 | 51 | false | [Quality Q1] WearOS - Show offline indicator next to time text | 5,036 | Automattic/pocket-casts-android | 1,688 | Kotlin | geekygecko | sztomek | Review this pull request change.
Language: Kotlin
File: wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/MainActivity.kt
PR Title: [Quality Q1] WearOS - Show offline indicator next to time text
BEFORE CODE: onShowLoginScreen: () -> Unit,
onRetrySync: () -> Unit,
signOut: () -> Unit,
showConn... | I don't think it's a good idea to remove the time and connection status icons from the Now Playing page. If we remove the “Streaming may be affected” panel, we should ensure the cloud icon is clearly visible on the Now Playing screen so users still have feedback about the streaming status. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
} else {
{
curvedComposable {
OfflineIcon()
}
}
},
startLinearContent = if (isConnected) {
null
} else {
{
OfflineIcon()
}
},
)
}
@Composable
priva... | I don't think this padding is needed as the `ResponsiveTimeText` method adds padding as well. | null
} else {
{
curvedComposable {
OfflineIcon()
}
}
},
startLinearContent = if (isConnected) {
null
} else {
{
OfflineIcon()
}
},
)
}
... | @@ -0,0 +1,78 @@
+package au.com.shiftyjelly.pocketcasts.wear.ui.component
+
+import androidx.compose.foundation.layout.padding
+import androidx.compose.foundation.layout.size
+import androidx.compose.runtime.Composable
+import androidx.compose.ui.Modifier
+import androidx.compose.ui.res.painterResource
+import android... | wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/component/TimeTextWithConnectivity.kt | 26 | Kotlin | 0.357 | suggestion | 94 | 45 | 45 | false | [Quality Q1] WearOS - Show offline indicator next to time text | 5,036 | Automattic/pocket-casts-android | 1,688 | Kotlin | geekygecko | sztomek | Review this pull request change.
Language: Kotlin
File: wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/component/TimeTextWithConnectivity.kt
PR Title: [Quality Q1] WearOS - Show offline indicator next to time text
BEFORE CODE: } else {
{
curvedComposable {
... | I don't think this padding is needed as the `ResponsiveTimeText` method adds padding as well. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
import com.google.android.horologist.annotations.ExperimentalHorologistApi
import com.google.android.horologist.networks.data.NetworkType
import com.google.android.horologist.networks.status.NetworkRepository
import javax.inject.Inject
import javax.inject.Singleton
import kotlinx.coroutines.CoroutineScope
import kotlin... | `initialValue = true` makes `isConnected` emit `true` immediately even when the current `networkStatus` indicates no Wi‑Fi/Cell, which can momentarily show an incorrect “online” state and will break the existing `ConnectivityStateManagerTest` expectations (they currently assert the first emission is `false` when no net... | import com.google.android.horologist.annotations.ExperimentalHorologistApi
import com.google.android.horologist.networks.data.NetworkType
import com.google.android.horologist.networks.status.NetworkRepository
import javax.inject.Inject
import javax.inject.Singleton
import kotlinx.coroutines.CoroutineScope
import kotlin... | @@ -26,6 +26,6 @@ class ConnectivityStateManager @Inject constructor(
.stateIn(
scope = coroutineScope,
started = SharingStarted.Eagerly,
- initialValue = false,
+ initialValue = true, | wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/networking/ConnectivityStateManager.kt | 26 | Kotlin | 0.857 | bug | 530 | 29 | 29 | false | [Quality Q1] WearOS - Show offline indicator next to time text | 5,036 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | sztomek | Review this pull request change.
Language: Kotlin
File: wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/networking/ConnectivityStateManager.kt
PR Title: [Quality Q1] WearOS - Show offline indicator next to time text
BEFORE CODE: import com.google.android.horologist.annotations.ExperimentalHorologistApi
imp... | `initialValue = true` makes `isConnected` emit `true` immediately even when the current `networkStatus` indicates no Wi‑Fi/Cell, which can momentarily show an incorrect “online” state and will break the existing `ConnectivityStateManagerTest` expectations (they currently assert the first emission is `false` when no net... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
modifier = Modifier
.padding(16.dp)
.fillMaxSize(),
) {
CircularProgressIndicator(
indicatorColor = MaterialTheme.colors.onPrimary,
trackColor = MaterialTheme.colors.onBackground.copy(alpha = 0.2f),
strokeWid... | `timeText = {}` hides the time text slot. The inline comment says it’s “using global one”, but this override will suppress the global `AppScaffold` time text for this screen. If the goal is to show the global connectivity time text, remove the override (or use the API’s “use default/global” option); otherwise, update t... | modifier = Modifier
.padding(16.dp)
.fillMaxSize(),
) {
CircularProgressIndicator(
indicatorColor = MaterialTheme.colors.onPrimary,
trackColor = MaterialTheme.colors.onBackground.copy(alpha = 0.2f),
strokeWid... | @@ -150,7 +150,7 @@ private fun SyncingContent(modifier: Modifier = Modifier) {
@Composable
private fun SuccessContent(modifier: Modifier = Modifier) {
ScreenScaffold(
- timeText = null,
+ timeText = {}, // Hide default TimeText, using global one
modifier = modifier,
) { | wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/authentication/LoginWithPhoneScreen.kt | 26 | Kotlin | 0.643 | suggestion | 381 | 51 | 51 | false | [Quality Q1] WearOS - Show offline indicator next to time text | 5,036 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | sztomek | Review this pull request change.
Language: Kotlin
File: wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/authentication/LoginWithPhoneScreen.kt
PR Title: [Quality Q1] WearOS - Show offline indicator next to time text
BEFORE CODE: modifier = Modifier
.padding(16.dp)
... | `timeText = {}` hides the time text slot. The inline comment says it’s “using global one”, but this override will suppress the global `AppScaffold` time text for this screen. If the goal is to show the global connectivity time text, remove the override (or use the API’s “use default/global” option); otherwise, update t... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
val navState = rememberSwipeDismissableNavHostState(swipeToDismissState)
if (showLoggingInScreen) {
navController.navigate(LoggingInScreen.ROUTE_WITH_DELAY)
onShowLoginScreen()
}
val userCanAccessWatch = signInState.isSignedInAsPlusOrPatron
val waitingForSignIn = remember { mutabl... | `AppScaffold` now always shows `TimeTextWithConnectivity`, so the offline indicator/time text will remain visible on all destinations (including Now Playing / Up Next). This doesn’t match the PR description that it should be dismissed when horizontally paging to those screens; you’ll need to make the `timeText` slot co... | ) {
val navController = rememberSwipeDismissableNavController()
val swipeToDismissState = rememberSwipeToDismissBoxState()
val navState = rememberSwipeDismissableNavHostState(swipeToDismissState)
if (showLoggingInScreen) {
navController.navigate(LoggingInScreen.ROUTE_WITH_DELAY)
onShowL... | @@ -118,8 +121,12 @@ private fun WearApp(
val startDestination = if (userCanAccessWatch) WatchListScreen.ROUTE else RequirePlusScreen.ROUTE
- Box(modifier = Modifier.fillMaxSize()) {
- AppScaffold {
+ AppScaffold(
+ timeText = {
+ TimeTextWithConnectivity(isConnected = isConnecte... | wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/MainActivity.kt | 26 | Kotlin | 0.643 | suggestion | 440 | 51 | 51 | false | [Quality Q1] WearOS - Show offline indicator next to time text | 5,036 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | sztomek | Review this pull request change.
Language: Kotlin
File: wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/MainActivity.kt
PR Title: [Quality Q1] WearOS - Show offline indicator next to time text
BEFORE CODE: val navState = rememberSwipeDismissableNavHostState(swipeToDismissState)
if (showLoggingInSc... | `AppScaffold` now always shows `TimeTextWithConnectivity`, so the offline indicator/time text will remain visible on all destinations (including Now Playing / Up Next). This doesn’t match the PR description that it should be dismissed when horizontally paging to those screens; you’ll need to make the `timeText` slot co... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
import au.com.shiftyjelly.pocketcasts.compose.components.TextH50
import au.com.shiftyjelly.pocketcasts.models.to.PlaybackEffectsData
import au.com.shiftyjelly.pocketcasts.models.type.TrimMode
import au.com.shiftyjelly.pocketcasts.ui.theme.Theme
import au.com.shiftyjelly.pocketcasts.wear.ui.component.ScreenHeaderChip
im... | `timeText = {}` replaces the time text slot with an empty composable, which hides the time text entirely. The inline comment says it’s “using global one”, but this override will prevent the global `AppScaffold` time text (and the offline indicator) from showing on this screen. If the intent is to show the global time t... | import au.com.shiftyjelly.pocketcasts.compose.components.TextH50
import au.com.shiftyjelly.pocketcasts.models.to.PlaybackEffectsData
import au.com.shiftyjelly.pocketcasts.models.type.TrimMode
import au.com.shiftyjelly.pocketcasts.ui.theme.Theme
import au.com.shiftyjelly.pocketcasts.wear.ui.component.ScreenHeaderChip
im... | @@ -54,6 +54,7 @@ fun EffectsScreen(
ScreenScaffold(
scrollState = columnState,
+ timeText = {}, // Hide default TimeText, using global one | wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/player/EffectsScreen.kt | 26 | Kotlin | 1 | refactor | 432 | 51 | 51 | false | [Quality Q1] WearOS - Show offline indicator next to time text | 5,036 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | sztomek | Review this pull request change.
Language: Kotlin
File: wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/player/EffectsScreen.kt
PR Title: [Quality Q1] WearOS - Show offline indicator next to time text
BEFORE CODE: import au.com.shiftyjelly.pocketcasts.compose.components.TextH50
import au.com.shiftyjelly... | `timeText = {}` replaces the time text slot with an empty composable, which hides the time text entirely. The inline comment says it’s “using global one”, but this override will prevent the global `AppScaffold` time text (and the offline indicator) from showing on this screen. If the intent is to show the global time t... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
import au.com.shiftyjelly.pocketcasts.compose.components.TextH30
import au.com.shiftyjelly.pocketcasts.wear.theme.WearAppTheme
import au.com.shiftyjelly.pocketcasts.wear.theme.WearColors
import com.google.android.horologist.compose.layout.ScreenScaffold
import kotlin.time.Duration
import kotlin.time.Duration.Companion.... | `timeText = {}` hides the time text slot. The comment says this is “using global one”, but an empty lambda will actually suppress the global `AppScaffold` time text for this screen as well. Either remove/update the comment to reflect that the time text is intentionally hidden, or don’t override `timeText` if you want t... | import au.com.shiftyjelly.pocketcasts.compose.components.TextH30
import au.com.shiftyjelly.pocketcasts.wear.theme.WearAppTheme
import au.com.shiftyjelly.pocketcasts.wear.theme.WearColors
import com.google.android.horologist.compose.layout.ScreenScaffold
import kotlin.time.Duration
import kotlin.time.Duration.Companion.... | @@ -43,7 +43,7 @@ fun NotificationScreen(
},
) {
ScreenScaffold(
- timeText = null,
+ timeText = {}, // Hide default TimeText, using global one | wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/component/NotificationScreen.kt | 26 | Kotlin | 0.857 | suggestion | 481 | 51 | 51 | false | [Quality Q1] WearOS - Show offline indicator next to time text | 5,036 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | sztomek | Review this pull request change.
Language: Kotlin
File: wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/component/NotificationScreen.kt
PR Title: [Quality Q1] WearOS - Show offline indicator next to time text
BEFORE CODE: import au.com.shiftyjelly.pocketcasts.compose.components.TextH30
import au.com.shi... | `timeText = {}` hides the time text slot. The comment says this is “using global one”, but an empty lambda will actually suppress the global `AppScaffold` time text for this screen as well. Either remove/update the comment to reflect that the time text is intentionally hidden, or don’t override `timeText` if you want t... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
item {
Text(
text = "2. ${stringResource(LR.string.log_in_watch_from_phone_instructions_2)}",
textAlign = TextAlign.Center,
style = MaterialTheme.typography.body2,
modifier = Modifier.padding(bottom = 24.dp),
... | `timeText = {}` hides the time text slot. The inline comment says it’s “using global one”, but this override will suppress the global `AppScaffold` time text for this screen. If the goal is to show the global connectivity time text, remove the override (or use the API’s “use default/global” option); otherwise, update t... |
item {
Text(
text = "2. ${stringResource(LR.string.log_in_watch_from_phone_instructions_2)}",
textAlign = TextAlign.Center,
style = MaterialTheme.typography.body2,
modifier = Modifier.padding(bottom = 24.dp),
... | @@ -121,7 +121,7 @@ private fun LoginWithPhoneInstructionsContent(
@Composable
private fun SyncingContent(modifier: Modifier = Modifier) {
ScreenScaffold(
- timeText = null,
+ timeText = {}, // Hide default TimeText, using global one | wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/authentication/LoginWithPhoneScreen.kt | 26 | Kotlin | 0.857 | suggestion | 400 | 51 | 51 | false | [Quality Q1] WearOS - Show offline indicator next to time text | 5,036 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | sztomek | Review this pull request change.
Language: Kotlin
File: wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/authentication/LoginWithPhoneScreen.kt
PR Title: [Quality Q1] WearOS - Show offline indicator next to time text
BEFORE CODE:
item {
Text(
text = "2. ${... | `timeText = {}` hides the time text slot. The inline comment says it’s “using global one”, but this override will suppress the global `AppScaffold` time text for this screen. If the goal is to show the global connectivity time text, remove the override (or use the API’s “use default/global” option); otherwise, update t... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
import com.google.android.horologist.compose.layout.ScalingLazyColumnState
import au.com.shiftyjelly.pocketcasts.images.R as IR
import au.com.shiftyjelly.pocketcasts.localization.R as LR
object WatchListScreen {
const val ROUTE = "watch_list_screen"
}
@Composable
fun WatchListScreen(
columnState: ScalingLazyC... | I wonder if it should only show when the user pulls to fresh, like it does on the mobile device. 🤔 But maybe this is okay for now to be super clear that it's still refreshing. | import com.google.android.horologist.compose.layout.ScalingLazyColumn
import com.google.android.horologist.compose.layout.ScalingLazyColumnState
import au.com.shiftyjelly.pocketcasts.images.R as IR
import au.com.shiftyjelly.pocketcasts.localization.R as LR
object WatchListScreen {
const val ROUTE = "watch_list_scr... | @@ -43,88 +44,94 @@ fun WatchListScreen(
viewModel.onShown()
}
- ScalingLazyColumn(
- columnState = columnState,
- modifier = modifier.fillMaxWidth(),
+ PullToRefresh(
+ state = state.refreshState, | wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/WatchListScreen.kt | 26 | Kotlin | 0.429 | suggestion | 175 | 51 | 51 | false | [Quality Q1] WearOS - Add pull to refresh to main screen | 5,037 | Automattic/pocket-casts-android | 1,688 | Kotlin | geekygecko | sztomek | Review this pull request change.
Language: Kotlin
File: wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/WatchListScreen.kt
PR Title: [Quality Q1] WearOS - Add pull to refresh to main screen
BEFORE CODE: import com.google.android.horologist.compose.layout.ScalingLazyColumnState
import au.com.shiftyjelly.... | I wonder if it should only show when the user pulls to fresh, like it does on the mobile device. 🤔 But maybe this is okay for now to be super clear that it's still refreshing. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
if (existingBookmark != null) {
return existingBookmark
}
val addedAtMs = addedAt.toEpochMilli()
val bookmark = Bookmark(
uuid = UUID.randomUUID().toString(),
episodeUuid = episode.uuid,
podcastUuid = episode.podcastOrSubstituteUuid,
... | This PR’s primary behavior change is migrating analytics to EventHorizon, but the existing BookmarkManager tests don’t assert that `BookmarkCreatedEvent` (and related fields like `source`, `episodeUuid`, `podcastUuid`) is actually emitted. Since `TestEventSink` is already being wired into tests elsewhere, consider exte... | if (existingBookmark != null) {
return existingBookmark
}
val addedAtMs = addedAt.toEpochMilli()
val bookmark = Bookmark(
uuid = UUID.randomUUID().toString(),
episodeUuid = episode.uuid,
podcastUuid = episode.podcastOrSubstituteUuid,
... | @@ -66,13 +68,12 @@ class BookmarkManagerImpl @Inject constructor(
)
bookmarkDao.insert(bookmark)
val podcastUuid = if (episode is PodcastEpisode) episode.podcastOrSubstituteUuid else "user_file"
- analyticsTracker.track(
- AnalyticsEvent.BOOKMARK_CREATED,
- mapOf... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/bookmark/BookmarkManagerImpl.kt | 26 | Kotlin | 0.786 | suggestion | 388 | 51 | 51 | false | Migrate bookmark events to Event Horizon | 5,041 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/bookmark/BookmarkManagerImpl.kt
PR Title: Migrate bookmark events to Event Horizon
BEFORE CODE: if (existingBookmark != null) {
return existingBookmark
... | This PR’s primary behavior change is migrating analytics to EventHorizon, but the existing BookmarkManager tests don’t assert that `BookmarkCreatedEvent` (and related fields like `source`, `episodeUuid`, `podcastUuid`) is actually emitted. Since `TestEventSink` is already being wired into tests elsewhere, consider exte... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
suspend fun getSharedBookmark(): Triple<Podcast, PodcastEpisode, Bookmark>? {
return (_uiState.value as? UiState.Loaded)?.let {
val bookmark = it.bookmarks.firstOrNull { bookmark -> multiSelectHelper.isSelected(bookmark) } ?: return null
val podcast = podcastManager.findPodcastByUui... | `changeSortOrder` now emits a `BookmarksSortByChangedEvent` via EventHorizon, but the existing `BookmarksViewModelTest` suite doesn’t verify that this event is tracked (or that `source`/`sortOrder` are correct). Consider adding a unit test using `TestEventSink` to ensure this migration doesn’t regress analytics. |
suspend fun getSharedBookmark(): Triple<Podcast, PodcastEpisode, Bookmark>? {
return (_uiState.value as? UiState.Loaded)?.let {
val bookmark = it.bookmarks.firstOrNull { bookmark -> multiSelectHelper.isSelected(bookmark) } ?: return null
val podcast = podcastManager.findPodcastByUui... | @@ -280,11 +283,10 @@ class BookmarksViewModel
fun changeSortOrder(order: BookmarksSortType) {
sourceView.mapToBookmarksSortTypeUserSetting().set(order, updateModifiedAt = true)
- analyticsTracker.track(
- AnalyticsEvent.BOOKMARKS_SORT_BY_CHANGED,
- mapOf(
- "... | modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/viewmodel/BookmarksViewModel.kt | 26 | Kotlin | 0.643 | suggestion | 313 | 51 | 51 | false | Migrate bookmark events to Event Horizon | 5,041 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/viewmodel/BookmarksViewModel.kt
PR Title: Migrate bookmark events to Event Horizon
BEFORE CODE:
suspend fun getSharedBookmark(): Triple<Podcast, PodcastEpisode, Bookmark>? {
... | `changeSortOrder` now emits a `BookmarksSortByChangedEvent` via EventHorizon, but the existing `BookmarksViewModelTest` suite doesn’t verify that this event is tracked (or that `source`/`sortOrder` are correct). Consider adding a unit test using `TestEventSink` to ensure this migration doesn’t regress analytics. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
addedAt: Instant,
): Bookmark {
// Prevent adding more than one bookmark at the same place
val existingBookmark = findByEpisodeTime(episode = episode, timeSecs = timeSecs)
if (existingBookmark != null) {
return existingBookmark
}
val addedAtMs = addedAt.to... | I think this is an existing bug but the description of this is "The time in the episode the bookmark was created for" which I read should the episode playback progress time, not the time the bookmark was added.
This is the iOS version https://github.com/Automattic/pocket-casts-ios/blob/f6e337aaab05d9f99fe349d541f82515... | addedAt: Instant,
): Bookmark {
// Prevent adding more than one bookmark at the same place
val existingBookmark = findByEpisodeTime(episode = episode, timeSecs = timeSecs)
if (existingBookmark != null) {
return existingBookmark
}
val addedAtMs = addedAt.to... | @@ -66,13 +68,12 @@ class BookmarkManagerImpl @Inject constructor(
)
bookmarkDao.insert(bookmark)
val podcastUuid = if (episode is PodcastEpisode) episode.podcastOrSubstituteUuid else "user_file"
- analyticsTracker.track(
- AnalyticsEvent.BOOKMARK_CREATED,
- mapOf... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/bookmark/BookmarkManagerImpl.kt | 26 | Kotlin | 0.643 | bug | 366 | 51 | 51 | false | Migrate bookmark events to Event Horizon | 5,041 | Automattic/pocket-casts-android | 1,688 | Kotlin | geekygecko | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/bookmark/BookmarkManagerImpl.kt
PR Title: Migrate bookmark events to Event Horizon
BEFORE CODE: addedAt: Instant,
): Bookmark {
// Prevent adding more t... | I think this is an existing bug but the description of this is "The time in the episode the bookmark was created for" which I read should the episode playback progress time, not the time the bookmark was added.
This is the iOS version https://github.com/Automattic/pocket-casts-ios/blob/f6e337aaab05d9f99fe349d541f82515... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
BookmarksSortByChangedEvent(
source = sourceView.eventHorizonValue,
sortOrder = order.eventHorizonValue,
),
)
}
fun play(bookmark: Bookmark) {
viewModelScope.launch {
val bookmarkEpisode = episodeManager.findEpisodeByUuid(bookm... | This is another existing issue. It's missing podcastUuid.
| BookmarksSortByChangedEvent(
source = sourceView.eventHorizonValue,
sortOrder = order.eventHorizonValue,
),
)
}
fun play(bookmark: Bookmark) {
viewModelScope.launch {
val bookmarkEpisode = episodeManager.findEpisodeByUuid(bookm... | @@ -304,11 +306,10 @@ class BookmarksViewModel
}
_message.emit(BookmarkMessage.PlayingBookmark(bookmark.title))
playbackManager.seekToTimeMs(positionMs = bookmark.timeSecs * 1000)
- analyticsTracker.track(
- AnalyticsEvent.BOOKMARK_PLAY_TAPPED,
- ... | modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/viewmodel/BookmarksViewModel.kt | 26 | Kotlin | 0.357 | suggestion | 58 | 51 | 51 | false | Migrate bookmark events to Event Horizon | 5,041 | Automattic/pocket-casts-android | 1,688 | Kotlin | geekygecko | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/viewmodel/BookmarksViewModel.kt
PR Title: Migrate bookmark events to Event Horizon
BEFORE CODE: BookmarksSortByChangedEvent(
source = sourceView.eventHorizo... | This is another existing issue. It's missing podcastUuid.
| You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
* Display modes:
* - **Very recent** (< 2 minutes): Shows "Just now" for freshly completed refreshes
* - **Same day**: Shows time only (e.g., "3:45 PM" or "15:45") for refreshes earlier today
* - **Different day**: Shows abbreviated date and time (e.g., "Feb 8, 3:45 PM")
*
* Localization:
* - Uses Android's [Dat... | `formatRefreshTime` treats any negative `timeDiff` (e.g., if the device clock is set back after a refresh) as "Just now" because it only checks `timeDiff < 2 * MINUTE_IN_MILLIS`. Consider handling future timestamps explicitly (e.g., clamp `timeDiff` at 0, or only apply the "Just now" branch when `timeDiff` is within `[... | * Display modes:
* - **Very recent** (< 2 minutes): Shows "Just now" for freshly completed refreshes
* - **Same day**: Shows time only (e.g., "3:45 PM" or "15:45") for refreshes earlier today
* - **Different day**: Shows abbreviated date and time (e.g., "Feb 8, 3:45 PM")
*
* Localization:
* - Uses Android's [Dat... | @@ -0,0 +1,61 @@
+package au.com.shiftyjelly.pocketcasts.wear.ui
+
+import android.content.Context
+import android.text.format.DateUtils
+import java.util.Date
+import au.com.shiftyjelly.pocketcasts.localization.R as LR
+
+/**
+ * Formats a refresh timestamp for display in WearOS settings using absolute time.
+ *
+ * T... | wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/TimeFormatUtil.kt | 26 | Kotlin | 0.857 | suggestion | 487 | 47 | 47 | false | [Q1 Quality] WearOS - Show last sync time on settings below Refresh button | 5,044 | Automattic/pocket-casts-android | 1,688 | Kotlin | Copilot | sztomek | Review this pull request change.
Language: Kotlin
File: wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/TimeFormatUtil.kt
PR Title: [Q1 Quality] WearOS - Show last sync time on settings below Refresh button
BEFORE CODE: * Display modes:
* - **Very recent** (< 2 minutes): Shows "Just now" for freshly c... | `formatRefreshTime` treats any negative `timeDiff` (e.g., if the device clock is set back after a refresh) as "Just now" because it only checks `timeDiff < 2 * MINUTE_IN_MILLIS`. Consider handling future timestamps explicitly (e.g., clamp `timeDiff` at 0, or only apply the "Just now" branch when `timeDiff` is within `[... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
private fun bindEpisodeLimitRow(holder: EpisodeLimitViewHolder, position: Int) {
val episodeLimitRow = getItem(position) as? EpisodeLimitRow ?: return
val limit = episodeLimitRow.episodeLimit
holder.lblTitle.text = holder.itemView.resources.getString(LR.string.podcast_episodes_limited, limit... | No issues found. | private fun bindEpisodeLimitRow(holder: EpisodeLimitViewHolder, position: Int) {
val episodeLimitRow = getItem(position) as? EpisodeLimitRow ?: return
val limit = episodeLimitRow.episodeLimit
holder.lblTitle.text = holder.itemView.resources.getString(LR.string.podcast_episodes_limited, limit... | @@ -10,6 +10,7 @@ import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import android.widget.TextView
+import androidx.annotation.DrawableRes
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.WindowInsets
import androidx.compose.... | modules/features/podcasts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcast/PodcastAdapter.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Recommendations: Add similar shows section header when Podroll exists | 3,998 | Automattic/pocket-casts-android | 1,688 | Kotlin | geekygecko | Review this pull request change.
Language: Kotlin
File: modules/features/podcasts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcast/PodcastAdapter.kt
PR Title: Recommendations: Add similar shows section header when Podroll exists
BEFORE CODE: private fun bindEpisodeLimitRow(holder: EpisodeLimit... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
#!/bin/bash -eu
if "$(dirname "${BASH_SOURCE[0]}")/should-skip-job.sh" --job-type validation; then
exit 0
fi
"$(dirname "${BASH_SOURCE[0]}")/restore-cache.sh"
BUILD_VARIANT=$1
echo "--- :rubygems: Setting up Gems"
install_gems
echo "--- :closed_lock_with_key: Installing Secrets"
bundle exec fastlane run configur... | No issues found. | #!/bin/bash -eu
if "$(dirname "${BASH_SOURCE[0]}")/should-skip-job.sh" --job-type validation; then
exit 0
fi
"$(dirname "${BASH_SOURCE[0]}")/restore-cache.sh"
BUILD_VARIANT=$1
echo "--- :rubygems: Setting up Gems"
install_gems
echo "--- :closed_lock_with_key: Installing Secrets"
bundle exec fastlane run configur... | @@ -1,6 +1,8 @@
-#!/bin/bash
+#!/bin/bash -eu
-set -euo pipefail
+if "$(dirname "${BASH_SOURCE[0]}")/should-skip-job.sh" --job-type validation; then
+ exit 0
+fi
"$(dirname "${BASH_SOURCE[0]}")/restore-cache.sh"
| .buildkite/commands/diff-merged-manifest.sh | 0 | Shell | 1 | none | 16 | 25 | 25 | true | [Tooling] Skip jobs if there are no relevant code changes | 4,002 | Automattic/pocket-casts-android | 1,688 | Kotlin | iangmaia | Review this pull request change.
Language: Shell
File: .buildkite/commands/diff-merged-manifest.sh
PR Title: [Tooling] Skip jobs if there are no relevant code changes
BEFORE CODE: #!/bin/bash -eu
if "$(dirname "${BASH_SOURCE[0]}")/should-skip-job.sh" --job-type validation; then
exit 0
fi
"$(dirname "${BASH_SOUR... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
// Ensures that swiping back to page 0 works correctly.
// The RecyclerView was forcing a snap back to page 1
// because podcasts from page 1 are also visible on page 0.
if (position == 0) {
recy... | No issues found. |
// Ensures that swiping back to page 0 works correctly.
// The RecyclerView was forcing a snap back to page 1
// because podcasts from page 1 are also visible on page 0.
if (position == 0) {
recy... | @@ -128,9 +128,9 @@ internal class DiscoverAdapter(
private val analyticsTracker: AnalyticsTracker,
) : ListAdapter<Any, RecyclerView.ViewHolder>(DiscoverRowDiffCallback()) {
interface Listener {
- fun onPodcastClicked(podcast: DiscoverPodcast, listUuid: String?, isFeatured: Boolean = false)
- ... | modules/features/discover/src/main/java/au/com/shiftyjelly/pocketcasts/discover/view/DiscoverAdapter.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Recommendation run analytics | 4,021 | Automattic/pocket-casts-android | 1,688 | Kotlin | geekygecko | Review this pull request change.
Language: Kotlin
File: modules/features/discover/src/main/java/au/com/shiftyjelly/pocketcasts/discover/view/DiscoverAdapter.kt
PR Title: Recommendation run analytics
BEFORE CODE:
// Ensures that swiping back to page 0 works correctly.
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
data object Filters : OnboardingNotificationType(
notificationId = NotificationId.ONBOARDING_FILTERS.value,
subcategory = SUBCATEGORY_FILTERS,
titleRes = LR.string.notification_filters_title,
messageRes = LR.string.notification_filters_message,
dayOffset = 3,
) {
... | No issues found. | data object Filters : OnboardingNotificationType(
notificationId = NotificationId.ONBOARDING_FILTERS.value,
subcategory = SUBCATEGORY_FILTERS,
titleRes = LR.string.notification_filters_title,
messageRes = LR.string.notification_filters_message,
dayOffset = 3,
) {
... | @@ -7,10 +7,12 @@ import androidx.annotation.StringRes
import au.com.shiftyjelly.pocketcasts.deeplink.CreateAccountDeepLink
import au.com.shiftyjelly.pocketcasts.deeplink.DownloadsDeepLink
import au.com.shiftyjelly.pocketcasts.deeplink.ImportDeepLink
+import au.com.shiftyjelly.pocketcasts.deeplink.RecommendationsDee... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/notification/NotificationType.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [Notifications Revamp] Trending and Recommendations | 4,026 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/notification/NotificationType.kt
PR Title: [Notifications Revamp] Trending and Recommendations
BEFORE CODE: data object Filters : OnboardingNotificationType(
no... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
Icon(
painter = icon,
contentDescription = null,
tint = iconTint,
modifier = Modifier.size(24.dp),
)
Spacer(
modifier = Modifier.width(12.dp),
)
Column(
modifier ... | No issues found. | Icon(
painter = icon,
contentDescription = null,
tint = iconTint,
modifier = Modifier.size(24.dp),
)
Spacer(
modifier = Modifier.width(12.dp),
)
Column(
modifier ... | @@ -29,7 +29,6 @@ import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.semantics.contentDescription
-import androidx.compose.ui.semantics.role
import androidx.compose.ui.semantics.semantics
import androidx.... | modules/services/compose/src/main/java/au/com/shiftyjelly/pocketcasts/compose/components/Banner.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [Notifications Revamp] Add settings banner | 4,032 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/services/compose/src/main/java/au/com/shiftyjelly/pocketcasts/compose/components/Banner.kt
PR Title: [Notifications Revamp] Add settings banner
BEFORE CODE: Icon(
painter = icon,
contentDescription = null,
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
viewModel.refreshSuggestedFolders()
}
}
viewLifecycleOwner.lifecycleScope.launch {
viewLifecycleOwner.repeatOnLifecycle(Lifecycle.State.STARTED) {
viewModel.suggestedFoldersState.collect { state ->
when (state) {
... | No issues found. | viewModel.refreshSuggestedFolders()
}
}
viewLifecycleOwner.lifecycleScope.launch {
viewLifecycleOwner.repeatOnLifecycle(Lifecycle.State.STARTED) {
viewModel.suggestedFoldersState.collect { state ->
when (state) {
... | @@ -53,7 +53,7 @@ import au.com.shiftyjelly.pocketcasts.analytics.AnalyticsTracker
import au.com.shiftyjelly.pocketcasts.analytics.SourceView
import au.com.shiftyjelly.pocketcasts.compose.AppTheme
import au.com.shiftyjelly.pocketcasts.compose.CallOnce
-import au.com.shiftyjelly.pocketcasts.compose.components.EmptySt... | modules/features/podcasts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcasts/PodcastsFragment.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Empty state tweaks | 4,037 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/podcasts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcasts/PodcastsFragment.kt
PR Title: Empty state tweaks
BEFORE CODE: viewModel.refreshSuggestedFolders()
}
}
viewLifecycleOwner.... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
title = TextResource.fromStringId(LR.string.settings_notification_advanced),
description = TextResource.fromStringId(LR.string.settings_notification_advanced_summary),
),
)... | No issues found. | title = TextResource.fromStringId(LR.string.settings_notification_advanced),
description = TextResource.fromStringId(LR.string.settings_notification_advanced_summary),
),
)... | @@ -97,7 +97,7 @@ internal class NotificationsPreferencesRepositoryImpl @Inject constructor(
isEnabled = settings.dailyRemindersNotification.value,
),
)
- if (settings.dailyRemindersNotification... | modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/notifications/data/NotificationsPreferencesRepositoryImpl.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [Notifications Revamp] New features and tips | 4,044 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/notifications/data/NotificationsPreferencesRepositoryImpl.kt
PR Title: [Notifications Revamp] New features and tips
BEFORE CODE: title = Tex... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
val t = getFixedTime(2025, Calendar.APRIL, 10, 10, 0)
val calc = calculatorAt(t)
val expected = (24 + 5 * 24) * HOUR_IN_MILLIS
assertEquals(expected, calc.calculateDelayForOnboardingNotification(OnboardingNotificationType.StaffPicks))
}
@Test fun testExact10AM_PlusUpsell() {
... | No issues found. | val t = getFixedTime(2025, Calendar.APRIL, 10, 10, 0)
val calc = calculatorAt(t)
val expected = (24 + 5 * 24) * HOUR_IN_MILLIS
assertEquals(expected, calc.calculateDelayForOnboardingNotification(OnboardingNotificationType.StaffPicks))
}
@Test fun testExact10AM_PlusUpsell() {
... | @@ -240,4 +240,52 @@ class NotificationDelayCalculatorTest {
val expectedRecommendationsTime = getFixedTime(2025, Calendar.MAY, 25, 16, 0)
assertEquals(expectedRecommendationsTime, calculatedRecommendationsTriggerTime)
}
+
+ @Test fun testFeaturesAndTips_Before4PM() {
+ val t = getFixed... | modules/services/repositories/src/test/java/au/com/shiftyjelly/pocketcasts/repositories/notification/NotificationDelayCalculatorTest.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [Notifications Revamp] Offers notifications | 4,047 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/test/java/au/com/shiftyjelly/pocketcasts/repositories/notification/NotificationDelayCalculatorTest.kt
PR Title: [Notifications Revamp] Offers notifications
BEFORE CODE: val t = getFixedTime(2025, Calendar.APRIL, 10, 10... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
package au.com.shiftyjelly.pocketcasts.compose.extensions
import android.content.ClipData
import androidx.compose.ui.platform.Clipboard
import au.com.shiftyjelly.pocketcasts.utils.log.LogBuffer
fun Clipboard.getPrimaryClipText(): String? = try {
nativeClipboard.primaryClip?.getItemAtOrNull(0)?.text?.toString()
} ... | No issues found. | package au.com.shiftyjelly.pocketcasts.compose.extensions
import android.content.ClipData
import androidx.compose.ui.platform.Clipboard
import au.com.shiftyjelly.pocketcasts.utils.log.LogBuffer
fun Clipboard.getPrimaryClipText(): String? = try {
nativeClipboard.primaryClip?.getItemAtOrNull(0)?.text?.toString()
} ... | @@ -0,0 +1,15 @@
+package au.com.shiftyjelly.pocketcasts.compose.extensions
+
+import android.content.ClipData
+import androidx.compose.ui.platform.Clipboard
+import au.com.shiftyjelly.pocketcasts.utils.log.LogBuffer
+
+fun Clipboard.getPrimaryClipText(): String? = try {
+ nativeClipboard.primaryClip?.getItemAtOrNul... | modules/services/compose/src/main/java/au/com/shiftyjelly/pocketcasts/compose/extensions/Clipboard.kt | 0 | Kotlin | 1 | none | 16 | 16 | 16 | true | Upgrade Compose to 2025.05.01 | 4,049 | Automattic/pocket-casts-android | 1,688 | Kotlin | geekygecko | Review this pull request change.
Language: Kotlin
File: modules/services/compose/src/main/java/au/com/shiftyjelly/pocketcasts/compose/extensions/Clipboard.kt
PR Title: Upgrade Compose to 2025.05.01
BEFORE CODE: package au.com.shiftyjelly.pocketcasts.compose.extensions
import android.content.ClipData
import android... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
tier = FeatureTier.Free,
hasFirebaseRemoteFlag = true,
hasDevToggle = true,
),
ENGAGE_SDK(
key = "engage_sdk",
title = "Integrate Pocket Casts with Engage SDK",
defaultValue = true,
tier = FeatureTier.Free,
hasFirebaseRemoteFlag = true,
has... | No issues found. | tier = FeatureTier.Free,
hasFirebaseRemoteFlag = true,
hasDevToggle = true,
),
ENGAGE_SDK(
key = "engage_sdk",
title = "Integrate Pocket Casts with Engage SDK",
defaultValue = true,
tier = FeatureTier.Free,
hasFirebaseRemoteFlag = true,
has... | @@ -50,22 +50,6 @@ enum class Feature(
hasFirebaseRemoteFlag = false,
hasDevToggle = true,
),
- CACHE_ENTIRE_PLAYING_EPISODE(
- key = "cache_entire_playing_episode",
- title = "Cache entire playing episode",
- defaultValue = true,
- tier = FeatureTier.Free,
- ... | modules/services/utils/src/main/java/au/com/shiftyjelly/pocketcasts/utils/featureflag/Feature.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Remove old feature flags | 4,064 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/utils/src/main/java/au/com/shiftyjelly/pocketcasts/utils/featureflag/Feature.kt
PR Title: Remove old feature flags
BEFORE CODE: tier = FeatureTier.Free,
hasFirebaseRemoteFlag = true,
hasDevToggle = true,
),
ENGA... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import au.com.shiftyjelly.pocketcasts.compose.AppTheme
import au.com.shiftyjelly.pocketcasts.compose.ad.AdBanner
import au.com.shiftyjelly.pocketcasts.compose.ad.BlazeAd
import au.com.shiftyjelly.pocketcasts.compose.ad.rememberAdColors
import au.com.shiftyjelly.pocketcasts.ui.theme.Theme
internal class BannerAdAdapter... | No issues found. | import au.com.shiftyjelly.pocketcasts.compose.AppTheme
import au.com.shiftyjelly.pocketcasts.compose.ad.AdBanner
import au.com.shiftyjelly.pocketcasts.compose.ad.BlazeAd
import au.com.shiftyjelly.pocketcasts.compose.ad.rememberAdColors
import au.com.shiftyjelly.pocketcasts.ui.theme.Theme
internal class BannerAdAdapter... | @@ -0,0 +1,66 @@
+package au.com.shiftyjelly.pocketcasts.podcasts.view.podcasts
+
+import android.view.ViewGroup
+import androidx.compose.ui.platform.ComposeView
+import androidx.compose.ui.platform.ViewCompositionStrategy
+import androidx.recyclerview.widget.DiffUtil
+import androidx.recyclerview.widget.ListAdapter
+i... | modules/features/podcasts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcasts/BannerAdAdapter.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Display ads in the podcasts page | 4,076 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/podcasts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcasts/BannerAdAdapter.kt
PR Title: Display ads in the podcasts page
BEFORE CODE: import au.com.shiftyjelly.pocketcasts.compose.AppTheme
import au.com.shiftyjelly.pocketcast... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
class FirebaseRemoteFeatureProvider(
private val firebaseRemoteConfig: FirebaseRemoteConfig,
private val scope: CoroutineScope,
) : FeatureProvider {
@Inject constructor(firebaseRemoteConfig: FirebaseRemoteConfig) : this(
firebaseRemoteConfig,
@Suppress("OPT_IN_USAGE")
// Using Globa... | No issues found. | class FirebaseRemoteFeatureProvider(
private val firebaseRemoteConfig: FirebaseRemoteConfig,
private val scope: CoroutineScope,
) : FeatureProvider {
@Inject constructor(firebaseRemoteConfig: FirebaseRemoteConfig) : this(
firebaseRemoteConfig,
@Suppress("OPT_IN_USAGE")
// Using Globa... | @@ -2,17 +2,52 @@ package au.com.shiftyjelly.pocketcasts.utils.featureflag.providers
import au.com.shiftyjelly.pocketcasts.utils.config.FirebaseConfig
import au.com.shiftyjelly.pocketcasts.utils.featureflag.Feature
+import au.com.shiftyjelly.pocketcasts.utils.featureflag.FeatureFlag
+import au.com.shiftyjelly.pocke... | modules/services/utils/src/main/java/au/com/shiftyjelly/pocketcasts/utils/featureflag/providers/FirebaseRemoteFeatureProvider.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Allow to observe feature flags | 4,082 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/utils/src/main/java/au/com/shiftyjelly/pocketcasts/utils/featureflag/providers/FirebaseRemoteFeatureProvider.kt
PR Title: Allow to observe feature flags
BEFORE CODE: class FirebaseRemoteFeatureProvider(
private val firebaseRemoteConfig: Fi... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
upNextState: UpNextQueue.State,
playbackState: PlaybackState,
skipBackwardInSecs: Int,
skipForwardInSecs: Int,
upNextExpanded: Boolean,
chaptersExpanded: Boolean,
adjustRemainingTimeDuration: Boolean,
artworkConfiguration: ArtworkConfiguration,
sle... | No issues found. | upNextState: UpNextQueue.State,
playbackState: PlaybackState,
skipBackwardInSecs: Int,
skipForwardInSecs: Int,
upNextExpanded: Boolean,
chaptersExpanded: Boolean,
adjustRemainingTimeDuration: Boolean,
artworkConfiguration: ArtworkConfiguration,
sle... | @@ -12,6 +12,7 @@ import au.com.shiftyjelly.pocketcasts.analytics.AnalyticsEvent
import au.com.shiftyjelly.pocketcasts.analytics.AnalyticsTracker
import au.com.shiftyjelly.pocketcasts.analytics.EpisodeAnalytics
import au.com.shiftyjelly.pocketcasts.analytics.SourceView
+import au.com.shiftyjelly.pocketcasts.compose.... | modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/viewmodel/PlayerViewModel.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Display ads in the player | 4,086 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/viewmodel/PlayerViewModel.kt
PR Title: Display ads in the player
BEFORE CODE: upNextState: UpNextQueue.State,
playbackState: PlaybackState,
skipBackwardInSecs: ... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import au.com.shiftyjelly.pocketcasts.compose.ad.BlazeAd
import au.com.shiftyjelly.pocketcasts.compose.ad.rememberAdColors
import au.com.shiftyjelly.pocketcasts.compose.extensions.contentWithoutConsumedInsets
import au.com.shiftyjelly.pocketcasts.settings.onboarding.OnboardingFlow
import au.com.shiftyjelly.pocketcasts.... | No issues found. | import au.com.shiftyjelly.pocketcasts.compose.ad.BlazeAd
import au.com.shiftyjelly.pocketcasts.compose.ad.rememberAdColors
import au.com.shiftyjelly.pocketcasts.compose.extensions.contentWithoutConsumedInsets
import au.com.shiftyjelly.pocketcasts.settings.onboarding.OnboardingFlow
import au.com.shiftyjelly.pocketcasts.... | @@ -1,4 +1,4 @@
-package au.com.shiftyjelly.pocketcasts.views.fragments
+package au.com.shiftyjelly.pocketcasts.ads
import android.content.res.ColorStateList
import android.os.Bundle
@@ -19,6 +19,10 @@ import au.com.shiftyjelly.pocketcasts.compose.ad.AdReportContent
import au.com.shiftyjelly.pocketcasts.compose.ad... | modules/features/ads/src/main/kotlin/au/com/shiftyjelly/pocketcasts/ads/AdReportFragment.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Launch onboarding from ads | 4,089 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/ads/src/main/kotlin/au/com/shiftyjelly/pocketcasts/ads/AdReportFragment.kt
PR Title: Launch onboarding from ads
BEFORE CODE: import au.com.shiftyjelly.pocketcasts.compose.ad.BlazeAd
import au.com.shiftyjelly.pocketcasts.compose.ad.rememberAdCo... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
package au.com.shiftyjelly.pocketcasts.transcripts
data class SearchState(
val searchTerm: String?,
val selectedSearchCoordinates: SearchCoordinates?,
val searchResultIndices: Map<Int, List<Int>>,
)
data class SearchCoordinates(
val lineIndex: Int,
val matchIndex: Int,
)
| No issues found. | package au.com.shiftyjelly.pocketcasts.transcripts
data class SearchState(
val searchTerm: String?,
val selectedSearchCoordinates: SearchCoordinates?,
val searchResultIndices: Map<Int, List<Int>>,
)
data class SearchCoordinates(
val lineIndex: Int,
val matchIndex: Int,
)
| @@ -0,0 +1,12 @@
+package au.com.shiftyjelly.pocketcasts.transcripts
+
+data class SearchState(
+ val searchTerm: String?,
+ val selectedSearchCoordinates: SearchCoordinates?,
+ val searchResultIndices: Map<Int, List<Int>>,
+)
+
+data class SearchCoordinates(
+ val lineIndex: Int,
+ val matchIndex: Int,
... | modules/features/transcripts/src/main/kotlin/au/com/shiftyjelly/pocketcasts/transcripts/SearchState.kt | 0 | Kotlin | 1 | none | 16 | 13 | 13 | true | Add transcripts highlighting to the new UI | 4,118 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/transcripts/src/main/kotlin/au/com/shiftyjelly/pocketcasts/transcripts/SearchState.kt
PR Title: Add transcripts highlighting to the new UI
BEFORE CODE: package au.com.shiftyjelly.pocketcasts.transcripts
data class SearchState(
val searchT... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
output.append("Android version: ").append(Build.VERSION.RELEASE).append(" SDK ").append(Build.VERSION.SDK_INT).append(eol)
output.append(eol)
output.append("Background refresh: ").append(settings.backgroundRefreshPodcasts.value).append(eol)
output.append("Battery restric... | No issues found. | output.append("Android version: ").append(Build.VERSION.RELEASE).append(" SDK ").append(Build.VERSION.SDK_INT).append(eol)
output.append(eol)
output.append("Background refresh: ").append(settings.backgroundRefreshPodcasts.value).append(eol)
output.append("Battery restric... | @@ -246,14 +246,11 @@ class Support @Inject constructor(
val podcastsOutput = StringBuilder()
podcastsOutput.append("Podcasts").append(eol).append("--------").append(eol).append(eol)
- val autoDownloadOn = booleanArrayOf(false)
val uuidToPodcast = HashMap<String, Podc... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/support/Support.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Fix app state after migration | 4,130 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/support/Support.kt
PR Title: Fix app state after migration
BEFORE CODE: output.append("Android version: ").append(Build.VERSION.RELEASE).append(" SDK ").append(... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
get() = Dispatchers.Default
override fun beginMonitoringAccountManager(playbackManager: PlaybackManager) {
val accountListener = OnAccountsUpdateListener {
try {
// Handle sign out from outside of the app
if (!syncManager.isLoggedIn()) {
... | No issues found. | get() = Dispatchers.Default
override fun beginMonitoringAccountManager(playbackManager: PlaybackManager) {
val accountListener = OnAccountsUpdateListener {
try {
// Handle sign out from outside of the app
if (!syncManager.isLoggedIn()) {
... | @@ -12,6 +12,9 @@ import au.com.shiftyjelly.pocketcasts.models.type.SignInState
import au.com.shiftyjelly.pocketcasts.preferences.Settings
import au.com.shiftyjelly.pocketcasts.repositories.di.ApplicationScope
import au.com.shiftyjelly.pocketcasts.repositories.endofyear.EndOfYearSync
+import au.com.shiftyjelly.pocke... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/user/UserManager.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Disable recommendations notifications for users not signed in | 4,133 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/user/UserManager.kt
PR Title: Disable recommendations notifications for users not signed in
BEFORE CODE: get() = Dispatchers.Default
override fun beginMonitori... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
if (episode?.isVideo == true && state.isPlaying) {
if (resources.configuration.orientation == Configuration.ORIENTATION_PORTRAIT) {
binding.playerBottomSheet.openPlayer()
} else {
... | No issues found. | if (episode?.isVideo == true && state.isPlaying) {
if (resources.configuration.orientation == Configuration.ORIENTATION_PORTRAIT) {
binding.playerBottomSheet.openPlayer()
} else {
... | @@ -1337,6 +1337,7 @@ class MainActivity :
closeToRoot()
}
is DownloadsDeepLink -> {
+ closePlayer()
closeToRoot()
addFragment(ProfileEpisodeListFragment.newInstance(ProfileEpisodeListFragment.Mode.Downlo... | app/src/main/java/au/com/shiftyjelly/pocketcasts/ui/MainActivity.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Collapse player when opening a deeplink | 4,150 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: app/src/main/java/au/com/shiftyjelly/pocketcasts/ui/MainActivity.kt
PR Title: Collapse player when opening a deeplink
BEFORE CODE: if (episode?.isVideo == true && state.isPlaying) {
if (resources.configuratio... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
)
AdTitle(
ad = ad,
colors = colors,
)
}
Image(
painter = painterResource(IR.drawable.ic_close),
contentDescription = null,
... | No issues found. | )
AdTitle(
ad = ad,
colors = colors,
)
}
Image(
painter = painterResource(IR.drawable.ic_close),
contentDescription = null,
... | @@ -53,6 +53,7 @@ import au.com.shiftyjelly.pocketcasts.compose.LocalPodcastColors
import au.com.shiftyjelly.pocketcasts.compose.PodcastColors
import au.com.shiftyjelly.pocketcasts.compose.PodcastColorsParameterProvider
import au.com.shiftyjelly.pocketcasts.compose.components.CoilImage
+import au.com.shiftyjelly.poc... | modules/services/compose/src/main/java/au/com/shiftyjelly/pocketcasts/compose/ad/AdBanner.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Imporve vertical player experience on smaller devices | 4,155 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/compose/src/main/java/au/com/shiftyjelly/pocketcasts/compose/ad/AdBanner.kt
PR Title: Imporve vertical player experience on smaller devices
BEFORE CODE: )
AdTitle(
ad = ad,
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
onPodcastSubscribe(bindingAdapterPosition, 0)
}
binding.row1.onSubscribeClicked = {
onPodcastSubscribe(bindingAdapterPosition, 1)
}
}
val rows = listOf(binding.row0, binding.row1)
fun bindPodcasts(podcastSublist: List<Any>) {
... | No issues found. | onPodcastSubscribe(bindingAdapterPosition, 0)
}
binding.row1.onSubscribeClicked = {
onPodcastSubscribe(bindingAdapterPosition, 1)
}
}
val rows = listOf(binding.row0, binding.row1)
fun bindPodcasts(podcastSublist: List<Any>) {
... | @@ -1,7 +1,6 @@
package au.com.shiftyjelly.pocketcasts.discover.view
import android.view.LayoutInflater
-import android.view.View
import android.view.ViewGroup
import androidx.core.view.isVisible
import androidx.recyclerview.widget.DiffUtil
@@ -103,7 +102,7 @@ class CollectionListRowAdapter(
private v... | modules/features/discover/src/main/java/au/com/shiftyjelly/pocketcasts/discover/view/CollectionListRowAdapter.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Fixes Discover collection image scaling | 4,161 | Automattic/pocket-casts-android | 1,688 | Kotlin | geekygecko | Review this pull request change.
Language: Kotlin
File: modules/features/discover/src/main/java/au/com/shiftyjelly/pocketcasts/discover/view/CollectionListRowAdapter.kt
PR Title: Fixes Discover collection image scaling
BEFORE CODE: onPodcastSubscribe(bindingAdapterPosition, 0)
}
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.test.advanceUntilIdle
import kotlinx.coroutines.test.runTest
import org.junit.Test
import org.mockito.Mockito.mock
import org.mockito.kotlin.any
import org.mockito.kotlin.never
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenev... | No issues found. | import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.test.advanceUntilIdle
import kotlinx.coroutines.test.runTest
import org.junit.Test
import org.mockito.Mockito.mock
import org.mockito.kotlin.any
import org.mockito.kotlin.never
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenev... | @@ -8,11 +8,9 @@ import au.com.shiftyjelly.pocketcasts.repositories.download.DownloadManager
import au.com.shiftyjelly.pocketcasts.repositories.notification.NotificationManager
import au.com.shiftyjelly.pocketcasts.repositories.notification.OnboardingNotificationType
import au.com.shiftyjelly.pocketcasts.repositorie... | modules/services/repositories/src/test/java/au/com/shiftyjelly/pocketcasts/repositories/podcast/PlaylistManagerImplTest.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Fix flaky tests in `CategoriesManagerTest` | 4,199 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/test/java/au/com/shiftyjelly/pocketcasts/repositories/podcast/PlaylistManagerImplTest.kt
PR Title: Fix flaky tests in `CategoriesManagerTest`
BEFORE CODE: import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coro... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
ModalBottomSheetValue.Hidden -> {
// Don't fire event when initially loading the screen and both current and target are "Hidden"
if (sheetState.currentValue == ModalBottomSheetValue.Expanded) {
viewModel.onSelectPaymentFrequencyDismissed(flow, source)
... | No issues found. | ModalBottomSheetValue.Hidden -> {
// Don't fire event when initially loading the screen and both current and target are "Hidden"
if (sheetState.currentValue == ModalBottomSheetValue.Expanded) {
viewModel.onSelectPaymentFrequencyDismissed(flow, source)
... | @@ -26,6 +26,8 @@ import au.com.shiftyjelly.pocketcasts.payment.SubscriptionTier
import au.com.shiftyjelly.pocketcasts.settings.onboarding.OnboardingFlow
import au.com.shiftyjelly.pocketcasts.settings.onboarding.OnboardingUpgradeSource
import au.com.shiftyjelly.pocketcasts.utils.extensions.getActivity
+import au.com... | modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/upgrade/OnboardingUpgradeFlow.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [Onboarding] Upgrade Screen skeleton | 4,204 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/upgrade/OnboardingUpgradeFlow.kt
PR Title: [Onboarding] Upgrade Screen skeleton
BEFORE CODE: ModalBottomSheetValue.Hidden -> {
// Don't fire ev... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width
import androidx.compose.... | No issues found. |
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width
import androidx.compose.... | @@ -23,7 +23,8 @@ import au.com.shiftyjelly.pocketcasts.ui.R as UR
fun UpgradeFeatureItem(
item: UpgradeFeatureItem,
modifier: Modifier = Modifier,
- color: Color = Color.Black,
+ iconColor: Color = Color.Black,
+ textColor: Color = Color.Black,
) {
Row(
modifier = modifier
@@ -35,16 ... | modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/components/UpgradeFeatureItem.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [Onboarding] Connect screen content | 4,205 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/components/UpgradeFeatureItem.kt
PR Title: [Onboarding] Connect screen content
BEFORE CODE:
import androidx.compose.foundation.layout.Row
import androidx.compose.foundati... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
horizontalArrangement = Arrangement.SpaceBetween,
verticalAlignment = Alignment.CenterVertically,
) {
SubscriptionBadge(
iconRes = selectedPlan.badgeIconRes,
shortNameRes = selectedPlan.shortNameRes,
backgroundColor = Color.Blac... | No issues found. | horizontalArrangement = Arrangement.SpaceBetween,
verticalAlignment = Alignment.CenterVertically,
) {
SubscriptionBadge(
iconRes = selectedPlan.badgeIconRes,
shortNameRes = selectedPlan.shortNameRes,
backgroundColor = Color.Blac... | @@ -28,11 +28,7 @@ import androidx.compose.material.Icon
import androidx.compose.material.IconButton
import androidx.compose.material.MaterialTheme
import androidx.compose.runtime.Composable
-import androidx.compose.runtime.getValue
-import androidx.compose.runtime.mutableStateOf
-import androidx.compose.runtime.rem... | modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/upgrade/OnboardingUpgradeScreen.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [Onboarding] Wire up read data and logic | 4,240 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/upgrade/OnboardingUpgradeScreen.kt
PR Title: [Onboarding] Wire up read data and logic
BEFORE CODE: horizontalArrangement = Arrangement.SpaceBetween,
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
)
}
}
CallOnce {
settings.showPlaylistsOnboarding.set(false, updateModifiedAt = false)
}
}
}
@Composable
private fun OnboardingContent(
onGotItClick: () -> Unit,
modifier: Modifier = Modifier,
) {
val windowSizeClass = currentWindowAdapti... | No issues found. | )
}
}
CallOnce {
settings.showPlaylistsOnboarding.set(false, updateModifiedAt = false)
}
}
}
@Composable
private fun OnboardingContent(
onGotItClick: () -> Unit,
modifier: Modifier = Modifier,
) {
val windowSizeClass = currentWindowAdapti... | @@ -3,22 +3,57 @@ package au.com.shiftyjelly.pocketcasts.playlists
import android.os.Bundle
import android.view.LayoutInflater
import android.view.ViewGroup
+import androidx.annotation.DrawableRes
+import androidx.compose.foundation.Image
+import androidx.compose.foundation.layout.Arrangement
import androidx.compos... | modules/features/filters/src/main/java/au/com/shiftyjelly/pocketcasts/playlists/PlaylistsOnboardingFragment.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Add Playlists onboarding flow | 4,242 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/filters/src/main/java/au/com/shiftyjelly/pocketcasts/playlists/PlaylistsOnboardingFragment.kt
PR Title: Add Playlists onboarding flow
BEFORE CODE: )
}
}
CallOnce {
settings.showPlaylists... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
// prepare to add to up next
when (podcast.autoAddToUpNext) {
AutoAddUpNext.OFF -> {}
AutoAddUpNext.PLAY_LAST -> episodesToAddToUpNext.addAll(episodes.map { Pair(AutoAddUpNext.PLAY_LAST, it) })
AutoAddUpNext.PLAY_NEXT -> episode... | No issues found. | // prepare to add to up next
when (podcast.autoAddToUpNext) {
AutoAddUpNext.OFF -> {}
AutoAddUpNext.PLAY_LAST -> episodesToAddToUpNext.addAll(episodes.map { Pair(AutoAddUpNext.PLAY_LAST, it) })
AutoAddUpNext.PLAY_NEXT -> episode... | @@ -32,6 +32,7 @@ import au.com.shiftyjelly.pocketcasts.repositories.download.DownloadManager
import au.com.shiftyjelly.pocketcasts.repositories.file.FileStorage
import au.com.shiftyjelly.pocketcasts.repositories.images.PocketCastsImageRequestFactory
import au.com.shiftyjelly.pocketcasts.repositories.notification.No... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/refresh/RefreshPodcastsThread.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Add missing `notification_open` event | 4,261 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/refresh/RefreshPodcastsThread.kt
PR Title: Add missing `notification_open` event
BEFORE CODE: // prepare to add to up next
when (podcast.aut... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
modifier = Modifier
.align(Alignment.CenterEnd)
.background(Color(0xFFFF4539))
.fillMaxHeight()
.clickable(
role = Role.Button,
onClick = onDelete,
enab... | No issues found. | modifier = Modifier
.align(Alignment.CenterEnd)
.background(Color(0xFFFF4539))
.fillMaxHeight()
.clickable(
role = Role.Button,
onClick = onDelete,
enab... | @@ -1,23 +1,52 @@
package au.com.shiftyjelly.pocketcasts.playlists
import androidx.compose.foundation.Image
+import androidx.compose.foundation.background
+import androidx.compose.foundation.clickable
+import androidx.compose.foundation.gestures.AnchoredDraggableState
+import androidx.compose.foundation.gestures.Dr... | modules/features/filters/src/main/java/au/com/shiftyjelly/pocketcasts/playlists/PlaylistPreviewRow.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Add swipe to delete playlists | 4,267 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/filters/src/main/java/au/com/shiftyjelly/pocketcasts/playlists/PlaylistPreviewRow.kt
PR Title: Add swipe to delete playlists
BEFORE CODE: modifier = Modifier
.align(Alignment.CenterEnd)
.... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import au.com.shiftyjelly.pocketcasts.views.fragments.TopScrollable
import dagger.hilt.android.AndroidEntryPoint
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.flow.collectLatest
import kotlinx.coroutines.launch
import timber.log.Timber
@AndroidEntryPoint
class PlaylistsFragment :
BaseF... | No issues found. | import au.com.shiftyjelly.pocketcasts.views.fragments.TopScrollable
import dagger.hilt.android.AndroidEntryPoint
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.flow.collectLatest
import kotlinx.coroutines.launch
import timber.log.Timber
@AndroidEntryPoint
class PlaylistsFragment :
BaseF... | @@ -3,26 +3,25 @@ package au.com.shiftyjelly.pocketcasts.playlists
import android.os.Bundle
import android.view.LayoutInflater
import android.view.ViewGroup
-import androidx.compose.foundation.layout.statusBarsPadding
-import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.LazyLi... | modules/features/filters/src/main/java/au/com/shiftyjelly/pocketcasts/playlists/PlaylistsFragment.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Add playlists page bottom and top content | 4,269 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/filters/src/main/java/au/com/shiftyjelly/pocketcasts/playlists/PlaylistsFragment.kt
PR Title: Add playlists page bottom and top content
BEFORE CODE: import au.com.shiftyjelly.pocketcasts.views.fragments.TopScrollable
import dagger.hilt.android... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
data class NewOnboardingUpgradeState(
val recommendedSubscription: OnboardingSubscriptionPlan,
) : ProfileUpgradeBannerState
data class OldProfileUpgradeBannerState(
val subscriptionPlans: SubscriptionPlans,
val currentSubscription: SubscriptionPlan.Key?,
val isRenewingSubsc... | No issues found. | data class NewOnboardingUpgradeState(
val recommendedSubscription: OnboardingSubscriptionPlan,
) : ProfileUpgradeBannerState
data class OldProfileUpgradeBannerState(
val subscriptionPlans: SubscriptionPlans,
val currentSubscription: SubscriptionPlan.Key?,
val isRenewingSubsc... | @@ -10,61 +10,67 @@ import au.com.shiftyjelly.pocketcasts.payment.getOrNull
import au.com.shiftyjelly.pocketcasts.utils.featureflag.Feature
import au.com.shiftyjelly.pocketcasts.utils.featureflag.FeatureFlag
-data class ProfileUpgradeBannerState(
- val subscriptionPlans: SubscriptionPlans,
- val currentSubscr... | modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/upgrade/ProfileUpgradeBannerState.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [Onboarding] Update Account details page | 4,274 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/upgrade/ProfileUpgradeBannerState.kt
PR Title: [Onboarding] Update Account details page
BEFORE CODE: data class NewOnboardingUpgradeState(
val recommendedSubsc... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
if (includeNavigationBarPadding) {
view.setSystemWindowInsetToPadding(bottom = true)
}
isBeingDragged = false
addDismissCallback()
}
private fun addDismissCallback() {
val dialog = dialog as? BottomSheetDialog
(dialog?.findViewById<View>(com.google.a... | No issues found. | if (includeNavigationBarPadding) {
view.setSystemWindowInsetToPadding(bottom = true)
}
isBeingDragged = false
addDismissCallback()
}
private fun addDismissCallback() {
val dialog = dialog as? BottomSheetDialog
(dialog?.findViewById<View>(com.google.a... | @@ -117,7 +117,7 @@ open class BaseDialogFragment :
bottomSheetView()?.let { bottomSheet ->
val behavior = BottomSheetBehavior.from(bottomSheet)
behavior.state = BottomSheetBehavior.STATE_EXPANDED
- behavior.peekHeight = BottomSheetBehavior.PEEK_HEIGHT_AUTO
+ beh... | modules/services/views/src/main/java/au/com/shiftyjelly/pocketcasts/views/fragments/BaseDialogFragment.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Add resistance to dismissing playlist sheet | 4,297 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/views/src/main/java/au/com/shiftyjelly/pocketcasts/views/fragments/BaseDialogFragment.kt
PR Title: Add resistance to dismissing playlist sheet
BEFORE CODE: if (includeNavigationBarPadding) {
view.setSystemWindowInsetToPaddi... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
Column(
modifier = modifier
.fillMaxSize()
.verticalScroll(rememberScrollState()),
) {
IconButton(
onClick = onClickBack,
) {
Icon(
painter = painterResource(R.drawable.ic_arrow_back),
contentDescription = st... | No issues found. | Column(
modifier = modifier
.fillMaxSize()
.verticalScroll(rememberScrollState()),
) {
IconButton(
onClick = onClickBack,
) {
Icon(
painter = painterResource(R.drawable.ic_arrow_back),
contentDescription = st... | @@ -0,0 +1,154 @@
+package au.com.shiftyjelly.pocketcasts.playlists.create
+
+import androidx.compose.foundation.layout.Column
+import androidx.compose.foundation.layout.Row
+import androidx.compose.foundation.layout.Spacer
+import androidx.compose.foundation.layout.fillMaxSize
+import androidx.compose.foundation.layou... | modules/features/filters/src/main/java/au/com/shiftyjelly/pocketcasts/playlists/create/EpisodeStatusRulePage.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Control episode status rule | 4,302 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/filters/src/main/java/au/com/shiftyjelly/pocketcasts/playlists/create/EpisodeStatusRulePage.kt
PR Title: Control episode status rule
BEFORE CODE: Column(
modifier = modifier
.fillMaxSize()
.verticalScroll(re... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
val drafts = listOf(
SmartPlaylistDraft(
title = "Title",
rules = SmartRules.Default,
),
SmartPlaylistDraft(
title = "Title",
rules = SmartRules.Default.copy(
episodeStatus = EpisodeStatusRule... | No issues found. | val drafts = listOf(
SmartPlaylistDraft(
title = "Title",
rules = SmartRules.Default,
),
SmartPlaylistDraft(
title = "Title",
rules = SmartRules.Default.copy(
episodeStatus = EpisodeStatusRule... | @@ -36,7 +36,9 @@ import au.com.shiftyjelly.pocketcasts.sharedtest.MutableClock
import com.squareup.moshi.Moshi
import java.util.Date
import java.util.UUID
+import kotlin.time.Duration
import kotlin.time.Duration.Companion.minutes
+import kotlin.time.Duration.Companion.seconds
import kotlinx.coroutines.flow.first
... | app/src/androidTest/java/au/com/shiftyjelly/pocketcasts/repositories/playlist/PlaylistManagerTest.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Display playlist's metadata | 4,335 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: app/src/androidTest/java/au/com/shiftyjelly/pocketcasts/repositories/playlist/PlaylistManagerTest.kt
PR Title: Display playlist's metadata
BEFORE CODE: val drafts = listOf(
SmartPlaylistDraft(
title = "Title",
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
)
val density = LocalDensity.current
val iconSizePx = density.run { iconSize.toPx() }
val timelineWidthPx = density.run { timelineWidth.toPx() }
val iconPaddingPx = density.run { iconRightPadding.toPx() }
val iconColor = MaterialTheme.theme.colors.primaryIcon01
val iconCenterYPositions = mu... | No issues found. | )
val density = LocalDensity.current
val iconSizePx = density.run { iconSize.toPx() }
val timelineWidthPx = density.run { timelineWidth.toPx() }
val iconPaddingPx = density.run { iconRightPadding.toPx() }
val iconColor = MaterialTheme.theme.colors.primaryIcon01
val iconCenterYPositions = mu... | @@ -1,5 +1,6 @@
import androidx.annotation.DrawableRes
import androidx.compose.foundation.background
+import androidx.compose.foundation.focusable
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.fillMaxWidth
@@ -21,6 +22,11 @@... | modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/components/UpgradeTrialTimeline.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [Onboarding] Accessibility & Talkback | 4,341 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/components/UpgradeTrialTimeline.kt
PR Title: [Onboarding] Accessibility & Talkback
BEFORE CODE: )
val density = LocalDensity.current
val iconSizePx = density.r... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
add(
UpgradePagerContent.Features(
features = currentPlan.featureItems,
showCta = false,
),
)
}
OnboardingUpgradeSource.UP_NEXT_SHUFFLE -> {
add(UpgradePagerContent.Shuffle)
add(
... | No issues found. | add(
UpgradePagerContent.Features(
features = currentPlan.featureItems,
showCta = false,
),
)
}
OnboardingUpgradeSource.UP_NEXT_SHUFFLE -> {
add(UpgradePagerContent.Shuffle)
add(
... | @@ -8,6 +8,7 @@ import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.BoxWithConstraints
import androidx.compose.foundation.layout.Column
+import androidx.compose.foundation.layout.IntrinsicSize
import androidx.compose.foundatio... | modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/upgrade/OnboardingUpgradeScreen.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [Onboarding] Animation updates | 4,354 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/upgrade/OnboardingUpgradeScreen.kt
PR Title: [Onboarding] Animation updates
BEFORE CODE: add(
UpgradePagerContent.Features(
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import androidx.compose.foundation.layout.padding
import androidx.compose.material.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.platform.ComposeView
import androidx.compose.ui... | No issues found. | import androidx.compose.foundation.layout.padding
import androidx.compose.material.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.platform.ComposeView
import androidx.compose.ui... | @@ -0,0 +1,75 @@
+package au.com.shiftyjelly.pocketcasts
+
+import android.os.Bundle
+import android.view.LayoutInflater
+import android.view.View
+import android.view.ViewGroup
+import androidx.compose.foundation.Image
+import androidx.compose.foundation.layout.Column
+import androidx.compose.foundation.layout.Spacer
... | automotive/src/main/java/au/com/shiftyjelly/pocketcasts/AutomotiveLinkFragment.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Adds Automotive fallback QR code for URL handling | 4,362 | Automattic/pocket-casts-android | 1,688 | Kotlin | geekygecko | Review this pull request change.
Language: Kotlin
File: automotive/src/main/java/au/com/shiftyjelly/pocketcasts/AutomotiveLinkFragment.kt
PR Title: Adds Automotive fallback QR code for URL handling
BEFORE CODE: import androidx.compose.foundation.layout.padding
import androidx.compose.material.Text
import androidx.c... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
val episode = playbackManager.getCurrentEpisode() ?: return
val timeInSecs = playbackManager.getCurrentTimeMs(episode) / 1000
// Load existing bookmark
var bookmark = bookmarkManager.findByEpisodeTime(
episode = episode,
timeSecs = timeIn... | No issues found. |
val episode = playbackManager.getCurrentEpisode() ?: return
val timeInSecs = playbackManager.getCurrentTimeMs(episode) / 1000
// Load existing bookmark
var bookmark = bookmarkManager.findByEpisodeTime(
episode = episode,
timeSecs = timeIn... | @@ -14,7 +14,7 @@ import au.com.shiftyjelly.pocketcasts.deeplink.DeleteBookmarkDeepLink
import au.com.shiftyjelly.pocketcasts.deeplink.ShowBookmarkDeepLink
import au.com.shiftyjelly.pocketcasts.preferences.Settings
import au.com.shiftyjelly.pocketcasts.repositories.R
-import au.com.shiftyjelly.pocketcasts.repositori... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/bookmark/BookmarkHelper.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Fix notifications don't open | 4,365 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/bookmark/BookmarkHelper.kt
PR Title: Fix notifications don't open
BEFORE CODE:
val episode = playbackManager.getCurrentEpisode() ?: return
val time... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
val file = File(context.cacheDir, "file.mp3").also { it.writeBytes(Random.nextBytes(8)) }
testMediaService.audioClip = file
regularPlatforms.forEach { platform ->
val request = SharingRequest.audioClip(
podcast = Podcast(uuid = "podcast-uuid", title = "Podcast Title"... | No issues found. | val file = File(context.cacheDir, "file.mp3").also { it.writeBytes(Random.nextBytes(8)) }
testMediaService.audioClip = file
regularPlatforms.forEach { platform ->
val request = SharingRequest.audioClip(
podcast = Podcast(uuid = "podcast-uuid", title = "Podcast Title"... | @@ -99,7 +99,7 @@ class SharingClientTest {
val response = client.share(request)
assertNull(shareStarter.intent)
- assertFalse(response.isSuccsessful)
+ assertFalse(response.isSuccessful)
assertEquals(context.getString(LR.string.share_error_message), response.feedbackMessage)
... | app/src/androidTest/java/au/com/shiftyjelly/pocketcasts/sharing/SharingClientTest.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Adds transcript sharing | 4,369 | Automattic/pocket-casts-android | 1,688 | Kotlin | geekygecko | Review this pull request change.
Language: Kotlin
File: app/src/androidTest/java/au/com/shiftyjelly/pocketcasts/sharing/SharingClientTest.kt
PR Title: Adds transcript sharing
BEFORE CODE: val file = File(context.cacheDir, "file.mp3").also { it.writeBytes(Random.nextBytes(8)) }
testMediaService.audio... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
APPSFLYER_ANALYTICS(
key = "appsflyer_analytics",
title = "AppsFlyer Analytics",
defaultValue = true,
tier = FeatureTier.Free,
hasFirebaseRemoteFlag = true,
hasDevToggle = true,
),
LIBRO_FM(
key = "libro_fm",
title = "Libro FM in Upsell",
... | No issues found. | APPSFLYER_ANALYTICS(
key = "appsflyer_analytics",
title = "AppsFlyer Analytics",
defaultValue = true,
tier = FeatureTier.Free,
hasFirebaseRemoteFlag = true,
hasDevToggle = true,
),
LIBRO_FM(
key = "libro_fm",
title = "Libro FM in Upsell",
... | @@ -162,6 +162,14 @@ enum class Feature(
hasFirebaseRemoteFlag = false,
hasDevToggle = true,
),
+ SHARE_TRANSCRIPTS(
+ key = "share_transcripts",
+ title = "Share transcripts",
+ defaultValue = true,
+ tier = FeatureTier.Free,
+ hasFirebaseRemoteFlag = true,
... | modules/services/utils/src/main/java/au/com/shiftyjelly/pocketcasts/utils/featureflag/Feature.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Adds a feature flag for share transcripts | 4,373 | Automattic/pocket-casts-android | 1,688 | Kotlin | geekygecko | Review this pull request change.
Language: Kotlin
File: modules/services/utils/src/main/java/au/com/shiftyjelly/pocketcasts/utils/featureflag/Feature.kt
PR Title: Adds a feature flag for share transcripts
BEFORE CODE: APPSFLYER_ANALYTICS(
key = "appsflyer_analytics",
title = "AppsFlyer Analytics... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
suspend fun incrementalData(): List<Record> {
val podcasts = podcastManager.findPodcastsToSync()
return withContext(Dispatchers.Default) {
podcasts.map { localPodcast ->
record {
podcast = syncUserPodcast {
uuid = localPodcast.... | No issues found. |
suspend fun incrementalData(): List<Record> {
val podcasts = podcastManager.findPodcastsToSync()
return withContext(Dispatchers.Default) {
podcasts.map { localPodcast ->
record {
podcast = syncUserPodcast {
uuid = localPodcast.... | @@ -49,9 +49,11 @@ internal class PodcastSync(
coroutineScope {
localMissingUuids.mapNotNull(serverPodcastMap::get).forEach { serverPodcast ->
launch {
- missingPodcastsSemaphore.withPermit {
- syncPodcast(serverPodcast)
- ... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/sync/data/PodcastSync.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Sync episodes using Protobuf | 4,391 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/sync/data/PodcastSync.kt
PR Title: Sync episodes using Protobuf
BEFORE CODE:
suspend fun incrementalData(): List<Record> {
val podcasts = podcastManager.findPo... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
releaseDate = ReleaseDateRule.AnyTime,
),
),
SmartPlaylistDraft(
title = "Title",
rules = SmartRules.Default.copy(
releaseDate = ReleaseDateRule.Last24Hours,
),
),
Smar... | No issues found. | releaseDate = ReleaseDateRule.AnyTime,
),
),
SmartPlaylistDraft(
title = "Title",
rules = SmartRules.Default.copy(
releaseDate = ReleaseDateRule.Last24Hours,
),
),
Smar... | @@ -84,7 +84,7 @@ class PlaylistManagerTest {
manager.observePlaylistsPreview().test {
assertTrue(awaitItem().isEmpty())
- playlistDao.upsertSmartPlaylists(listOf(playlist1, playlist2))
+ playlistDao.upsertAllPlaylists(listOf(playlist1, playlist2))
assertEquals... | app/src/androidTest/java/au/com/shiftyjelly/pocketcasts/repositories/playlist/PlaylistManagerTest.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Sync playlists using Protobuf | 4,393 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: app/src/androidTest/java/au/com/shiftyjelly/pocketcasts/repositories/playlist/PlaylistManagerTest.kt
PR Title: Sync playlists using Protobuf
BEFORE CODE: releaseDate = ReleaseDateRule.AnyTime,
),
),
S... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
val bookmarks = bookmarkDao.getAllUnsynced()
return withContext(Dispatchers.Default) {
bookmarks.map { localBookmark ->
record {
bookmark = syncUserBookmark {
bookmarkUuid = localBookmark.uuid
podcastUuid = l... | No issues found. | val bookmarks = bookmarkDao.getAllUnsynced()
return withContext(Dispatchers.Default) {
bookmarks.map { localBookmark ->
record {
bookmark = syncUserBookmark {
bookmarkUuid = localBookmark.uuid
podcastUuid = l... | @@ -0,0 +1,153 @@
+package au.com.shiftyjelly.pocketcasts.repositories.sync.data
+
+import androidx.room.withTransaction
+import au.com.shiftyjelly.pocketcasts.models.db.AppDatabase
+import au.com.shiftyjelly.pocketcasts.models.entity.Bookmark
+import au.com.shiftyjelly.pocketcasts.models.type.SyncStatus
+import au.com... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/sync/data/BookmarkSync.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Sync bookmarks using Protobuf | 4,394 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/sync/data/BookmarkSync.kt
PR Title: Sync bookmarks using Protobuf
BEFORE CODE: val bookmarks = bookmarkDao.getAllUnsynced()
return withContext(Dispatchers.D... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
fun `should prioritize interest categories when FF is on and interests are set`() = runTest {
FeatureFlag.setEnabled(Feature.NEW_ONBOARDING_RECOMMENDATIONS, true)
whenever(categoriesManager.interestCategories).thenReturn(MutableStateFlow(mockCategories.takeLast(3).toSet()).asStateFlow())
va... | No issues found. | fun `should prioritize interest categories when FF is on and interests are set`() = runTest {
FeatureFlag.setEnabled(Feature.NEW_ONBOARDING_RECOMMENDATIONS, true)
whenever(categoriesManager.interestCategories).thenReturn(MutableStateFlow(mockCategories.takeLast(3).toSet()).asStateFlow())
va... | @@ -0,0 +1,188 @@
+package au.com.shiftyjelly.pocketcasts.account.onboarding.recommendations
+
+import android.app.Application
+import android.content.res.Resources
+import app.cash.turbine.test
+import au.com.shiftyjelly.pocketcasts.account.viewmodel.OnboardingRecommendationsStartPageViewModel
+import au.com.shiftyjel... | modules/features/account/src/test/java/au/com/shiftyjelly/pocketcasts/account/onboarding/recommendations/OnboardingRecommendationsStartPageViewModelTest.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [Onboarding] Respect user's interests on Recommendations | 4,417 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/account/src/test/java/au/com/shiftyjelly/pocketcasts/account/onboarding/recommendations/OnboardingRecommendationsStartPageViewModelTest.kt
PR Title: [Onboarding] Respect user's interests on Recommendations
BEFORE CODE: fun `should prioriti... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
),
SmartPlaylistDraft(
title = "Title",
rules = SmartRules.Default.copy(
mediaType = MediaTypeRule.Any,
),
),
SmartPlaylistDraft(
title = "Title",
rules = SmartRules.Defaul... | No issues found. | ),
SmartPlaylistDraft(
title = "Title",
rules = SmartRules.Default.copy(
mediaType = MediaTypeRule.Any,
),
),
SmartPlaylistDraft(
title = "Title",
rules = SmartRules.Defaul... | @@ -9,6 +9,7 @@ import au.com.shiftyjelly.pocketcasts.models.db.dao.PlaylistDao
import au.com.shiftyjelly.pocketcasts.models.db.dao.PodcastDao
import au.com.shiftyjelly.pocketcasts.models.di.ModelModule
import au.com.shiftyjelly.pocketcasts.models.di.addTypeConverters
+import au.com.shiftyjelly.pocketcasts.models.en... | app/src/androidTest/java/au/com/shiftyjelly/pocketcasts/repositories/playlist/PlaylistManagerTest.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Display manual playlist previews | 4,419 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: app/src/androidTest/java/au/com/shiftyjelly/pocketcasts/repositories/playlist/PlaylistManagerTest.kt
PR Title: Display manual playlist previews
BEFORE CODE: ),
SmartPlaylistDraft(
title = "Title",
rules =... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
header {
Column {
Spacer(Modifier.windowInsetsPadding(WindowInsets.statusBars))
Row(
horizontalArrangement = Arrangement.End,
modifier = Modifier
.fillMaxWidth()
... | No issues found. | header {
Column {
Spacer(Modifier.windowInsetsPadding(WindowInsets.statusBars))
Row(
horizontalArrangement = Arrangement.End,
modifier = Modifier
.fillMaxWidth()
... | @@ -31,6 +31,7 @@ import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.collectAsState
import androidx.compose.runtime.getValue
import androidx.compose.ui.Modifier
+import androidx.compose.ui.graphics.Color
import androidx.compose.ui.platform.LocalConfiguration
import androidx.compose.ui.p... | modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/recommendations/OnboardingRecommendationsStartPage.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [Onboarding] Add `popularity` to categories | 4,425 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/recommendations/OnboardingRecommendationsStartPage.kt
PR Title: [Onboarding] Add `popularity` to categories
BEFORE CODE: header {
Column {
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import timber.log.Timber
import au.com.shiftyjelly.pocketcasts.localization.R as LR
import com.google.android.material.R as MR
@AndroidEntryPoint
class AdReportFragment : BaseDialogFragment() {
@Inject
internal lateinit var analyticsTracker: AnalyticsTracker
companion object {
const val NEW_INSTA... | No issues found. | import timber.log.Timber
import au.com.shiftyjelly.pocketcasts.localization.R as LR
import com.google.android.material.R as MR
@AndroidEntryPoint
class AdReportFragment : BaseDialogFragment() {
@Inject
internal lateinit var analyticsTracker: AnalyticsTracker
companion object {
const val NEW_INSTA... | @@ -12,26 +12,34 @@ import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.toArgb
import androidx.core.os.BundleCompat
import androidx.core.os.bundleOf
+import au.com.shiftyjelly.pocketcasts.analytics.AnalyticsEvent
+import au.com.shiftyjelly.pocketcasts.analytics.AnalyticsTracker
import au.c... | modules/features/ads/src/main/kotlin/au/com/shiftyjelly/pocketcasts/ads/AdReportFragment.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Adds analytics to the promotions | 4,433 | Automattic/pocket-casts-android | 1,688 | Kotlin | geekygecko | Review this pull request change.
Language: Kotlin
File: modules/features/ads/src/main/kotlin/au/com/shiftyjelly/pocketcasts/ads/AdReportFragment.kt
PR Title: Adds analytics to the promotions
BEFORE CODE: import timber.log.Timber
import au.com.shiftyjelly.pocketcasts.localization.R as LR
import com.google.android.ma... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
(dialog?.findViewById<View>(com.google.android.material.R.id.design_bottom_sheet) as? FrameLayout?)?.let { bottomSheet ->
val behavior = BottomSheetBehavior.from(bottomSheet)
behavior.addBottomSheetCallback(dismissCallback)
}
}
private fun removeDismissCallback() {
... | No issues found. | (dialog?.findViewById<View>(com.google.android.material.R.id.design_bottom_sheet) as? FrameLayout?)?.let { bottomSheet ->
val behavior = BottomSheetBehavior.from(bottomSheet)
behavior.addBottomSheetCallback(dismissCallback)
}
}
private fun removeDismissCallback() {
... | @@ -1,6 +1,5 @@
package au.com.shiftyjelly.pocketcasts.views.fragments
-import android.app.Dialog
import android.content.DialogInterface
import android.content.res.ColorStateList
import android.os.Bundle
@@ -27,7 +26,6 @@ import androidx.core.content.ContextCompat
import androidx.core.graphics.ColorUtils
import... | modules/services/views/src/main/java/au/com/shiftyjelly/pocketcasts/views/fragments/BaseDialogFragment.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Support target SDK 36 | 4,444 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/views/src/main/java/au/com/shiftyjelly/pocketcasts/views/fragments/BaseDialogFragment.kt
PR Title: Support target SDK 36
BEFORE CODE: (dialog?.findViewById<View>(com.google.android.material.R.id.design_bottom_sheet) as? FrameLayout?)?.... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
finished = true,
downloaded = true,
notDownloaded = true,
audioVideo = AUDIO_VIDEO_FILTER_ALL,
filterHours = LAST_2_WEEKS,
starred = false,
allPodcasts = true,
podcastUuids = null,
... | No issues found. | finished = true,
downloaded = true,
notDownloaded = true,
audioVideo = AUDIO_VIDEO_FILTER_ALL,
filterHours = LAST_2_WEEKS,
starred = false,
allPodcasts = true,
podcastUuids = null,
... | @@ -29,6 +29,7 @@ import au.com.shiftyjelly.pocketcasts.models.entity.PlaylistEntity.Companion.SYN
import au.com.shiftyjelly.pocketcasts.models.entity.PlaylistEntity.Companion.SYNC_STATUS_SYNCED
import au.com.shiftyjelly.pocketcasts.models.entity.Podcast
import au.com.shiftyjelly.pocketcasts.models.entity.PodcastEpi... | app/src/androidTest/java/au/com/shiftyjelly/pocketcasts/repositories/playlist/PlaylistManagerTest.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Add a query for loading manual playlist episodes | 4,445 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: app/src/androidTest/java/au/com/shiftyjelly/pocketcasts/repositories/playlist/PlaylistManagerTest.kt
PR Title: Add a query for loading manual playlist episodes
BEFORE CODE: finished = true,
downloaded = true,
not... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
existingPodcast.podcastCategory = updatedPodcast.podcastCategory
existingPodcast.podcastDescription = updatedPodcast.podcastDescription
existingPodcast.estimatedNextEpisode = updatedPodcast.estimatedNextEpisode
existingPodcast.episodeFrequency = updatedPodcast.episodeFreq... | No issues found. | existingPodcast.podcastCategory = updatedPodcast.podcastCategory
existingPodcast.podcastDescription = updatedPodcast.podcastDescription
existingPodcast.estimatedNextEpisode = updatedPodcast.estimatedNextEpisode
existingPodcast.episodeFrequency = updatedPodcast.episodeFreq... | @@ -10,6 +10,8 @@ import au.com.shiftyjelly.pocketcasts.repositories.playback.PlaybackManager
import au.com.shiftyjelly.pocketcasts.repositories.podcast.EpisodeManager
import au.com.shiftyjelly.pocketcasts.servers.podcast.PodcastCacheServiceManager
import au.com.shiftyjelly.pocketcasts.utils.DateUtil
+import au.com.... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/sync/PodcastRefresherImpl.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Do not cleanup manual playlists data | 4,475 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/sync/PodcastRefresherImpl.kt
PR Title: Do not cleanup manual playlists data
BEFORE CODE: existingPodcast.podcastCategory = updatedPodcast.podcastCategory
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
)
isEpisodeInUpNext = false
upNextAction = Settings.UpNextAction.PLAY_LAST
assertEquals(
"archived, play last",
SwipeRowActions(
ltr1 = SwipeAction.AddToUpNextBottom,
ltr2 = SwipeAction.AddToUpNextTop,
rtl1 = SwipeA... | No issues found. | )
isEpisodeInUpNext = false
upNextAction = Settings.UpNextAction.PLAY_LAST
assertEquals(
"archived, play last",
SwipeRowActions(
ltr1 = SwipeAction.AddToUpNextBottom,
ltr2 = SwipeAction.AddToUpNextTop,
rtl1 = SwipeA... | @@ -0,0 +1,214 @@
+package au.com.shiftyjelly.pocketcasts.views.swipe
+
+import au.com.shiftyjelly.pocketcasts.models.entity.PodcastEpisode
+import au.com.shiftyjelly.pocketcasts.preferences.Settings
+import au.com.shiftyjelly.pocketcasts.preferences.UserSetting
+import au.com.shiftyjelly.pocketcasts.repositories.playb... | modules/services/views/src/test/java/au/com/shiftyjelly/pocketcasts/views/swipe/SwipeRowActionsFactoryTest.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Encapsulate swipe buttons creation logic | 4,497 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/views/src/test/java/au/com/shiftyjelly/pocketcasts/views/swipe/SwipeRowActionsFactoryTest.kt
PR Title: Encapsulate swipe buttons creation logic
BEFORE CODE: )
isEpisodeInUpNext = false
upNextAction = Settings.UpNextAct... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import au.com.shiftyjelly.pocketcasts.models.to.PlaylistEpisode
import au.com.shiftyjelly.pocketcasts.ui.extensions.getThemeColor
import au.com.shiftyjelly.pocketcasts.images.R as IR
import au.com.shiftyjelly.pocketcasts.localization.R as LR
import au.com.shiftyjelly.pocketcasts.ui.R as UR
enum class SwipeAction(
... | No issues found. | import au.com.shiftyjelly.pocketcasts.models.to.PlaylistEpisode
import au.com.shiftyjelly.pocketcasts.ui.extensions.getThemeColor
import au.com.shiftyjelly.pocketcasts.images.R as IR
import au.com.shiftyjelly.pocketcasts.localization.R as LR
import au.com.shiftyjelly.pocketcasts.ui.R as UR
enum class SwipeAction(
... | @@ -2,19 +2,22 @@ package au.com.shiftyjelly.pocketcasts.views.swipe
import android.content.Context
import android.graphics.Color
+import au.com.shiftyjelly.pocketcasts.models.to.PlaylistEpisode
import au.com.shiftyjelly.pocketcasts.ui.extensions.getThemeColor
import au.com.shiftyjelly.pocketcasts.images.R as IR
... | modules/services/views/src/main/java/au/com/shiftyjelly/pocketcasts/views/swipe/SwipeAction.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Handle playlist swipe actions | 4,498 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/views/src/main/java/au/com/shiftyjelly/pocketcasts/views/swipe/SwipeAction.kt
PR Title: Handle playlist swipe actions
BEFORE CODE: import au.com.shiftyjelly.pocketcasts.models.to.PlaylistEpisode
import au.com.shiftyjelly.pocketcasts.ui.extensi... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
rtl2 = SwipeAction.Archive,
rtl3 = SwipeAction.Share,
),
factory.availablePlaylistEpisode(Playlist.Type.Manual, unarchivedEpisode),
)
isEpisodeInUpNext = false
upNextAction = Settings.UpNextAction.PLAY_LAST
assertEquals(
... | No issues found. | rtl2 = SwipeAction.Archive,
rtl3 = SwipeAction.Share,
),
factory.availablePlaylistEpisode(Playlist.Type.Manual, unarchivedEpisode),
)
isEpisodeInUpNext = false
upNextAction = Settings.UpNextAction.PLAY_LAST
assertEquals(
... | @@ -6,9 +6,14 @@ import au.com.shiftyjelly.pocketcasts.preferences.Settings
import au.com.shiftyjelly.pocketcasts.preferences.UserSetting
import au.com.shiftyjelly.pocketcasts.repositories.playback.UpNextQueue
import au.com.shiftyjelly.pocketcasts.repositories.playlist.Playlist
+import au.com.shiftyjelly.pocketcasts... | modules/services/views/src/test/java/au/com/shiftyjelly/pocketcasts/views/swipe/SwipeRowActionsFactoryTest.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Add swipe to add to playlist action | 4,504 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/views/src/test/java/au/com/shiftyjelly/pocketcasts/views/swipe/SwipeRowActionsFactoryTest.kt
PR Title: Add swipe to add to playlist action
BEFORE CODE: rtl2 = SwipeAction.Archive,
rtl3 = SwipeAction.Share,
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
onClick = onPlayedClick,
)
ShelfItem.Bookmark -> BookmarkButton(
playerColors = playerColors,
onClick = onAddBookmarkClick,
)
ShelfItem.Archive -> ArchiveButton(
isUserEpisod... | No issues found. | onClick = onPlayedClick,
)
ShelfItem.Bookmark -> BookmarkButton(
playerColors = playerColors,
onClick = onAddBookmarkClick,
)
ShelfItem.Archive -> ArchiveButton(
isUserEpisod... | @@ -140,6 +140,10 @@ fun PlayerShelf(
onMoreClick = {
shelfSharedViewModel.onMoreClick()
},
+ onAddToPlaylistClick = {
+ val episodeUuid = playerViewModel.episode?.uuid ?: return@PlayerShelfContent
+ shelfSharedViewModel.onAddToPlaylistClick(episodeUuid, Shelf... | modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/shelf/PlayerShelf.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Add "add to playlist" shelf action | 4,505 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/shelf/PlayerShelf.kt
PR Title: Add "add to playlist" shelf action
BEFORE CODE: onClick = onPlayedClick,
)
ShelfItem.Bookmark -... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import androidx.compose.foundation.text.input.TextFieldState
import androidx.compose.ui.text.TextRange
import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import au.com.shiftyjelly.pocketcasts.repositories.playlist.PlaylistManager
import dagger.assisted.Assisted
import dagger.assisted.AssistedF... | No issues found. | import androidx.compose.foundation.text.input.TextFieldState
import androidx.compose.ui.text.TextRange
import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import au.com.shiftyjelly.pocketcasts.repositories.playlist.PlaylistManager
import dagger.assisted.Assisted
import dagger.assisted.AssistedF... | @@ -0,0 +1,54 @@
+package au.com.shiftyjelly.pocketcasts.playlists.manual
+
+import androidx.compose.foundation.text.input.TextFieldState
+import androidx.compose.ui.text.TextRange
+import androidx.lifecycle.ViewModel
+import androidx.lifecycle.viewModelScope
+import au.com.shiftyjelly.pocketcasts.repositories.playlist... | modules/features/filters/src/main/java/au/com/shiftyjelly/pocketcasts/playlists/manual/AddToPlaylistViewModel.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Add episode playlist creation flow | 4,506 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/filters/src/main/java/au/com/shiftyjelly/pocketcasts/playlists/manual/AddToPlaylistViewModel.kt
PR Title: Add episode playlist creation flow
BEFORE CODE: import androidx.compose.foundation.text.input.TextFieldState
import androidx.compose.ui.t... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
}
isAnyPodcastFollowed = uiState.isAnyPodcastFollowed
val playlistHeaderData = uiState.playlist?.let { playlist ->
PlaylistHeaderData(
title = playlist.title,
metadata = playlist.... | No issues found. | }
isAnyPodcastFollowed = uiState.isAnyPodcastFollowed
val playlistHeaderData = uiState.playlist?.let { playlist ->
PlaylistHeaderData(
title = playlist.title,
metadata = playlist.... | @@ -192,7 +192,14 @@ class PlaylistFragment :
},
),
searchState = viewModel.searchState.textState,
- onShowArchivedToggle = viewModel::toggleShowArchived,
+ onShowArchivedToggle = {
+ viewModel.trackToggleShowArchived()
+ vie... | modules/features/filters/src/main/java/au/com/shiftyjelly/pocketcasts/playlists/PlaylistFragment.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Add manual playlist analytics | 4,509 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/filters/src/main/java/au/com/shiftyjelly/pocketcasts/playlists/PlaylistFragment.kt
PR Title: Add manual playlist analytics
BEFORE CODE: }
isAnyPodcastFollowed = uiState.isAnyPodcastFollowed
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
contentColor = MaterialTheme.theme.colors.primaryText01,
),
includePadding = false,
onClick = onLogIn,
)
}
}
@Composable
private fun BenefitsAdaptiveContent(
noShownBenefit: (AccountBenefit) -> Unit,
modifier: Modifier = Modifier,
) {
Subcompo... | No issues found. | contentColor = MaterialTheme.theme.colors.primaryText01,
),
includePadding = false,
onClick = onLogIn,
)
}
}
@Composable
private fun BenefitsAdaptiveContent(
noShownBenefit: (AccountBenefit) -> Unit,
modifier: Modifier = Modifier,
) {
Subcompo... | @@ -28,6 +28,7 @@ import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.snapshotFlow
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
+import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.ColorFilter
import androidx.compose.ui.layout.Subcomp... | modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/AccountBenefitsPage.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Update account creation encouragement screen | 4,512 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/AccountBenefitsPage.kt
PR Title: Update account creation encouragement screen
BEFORE CODE: contentColor = MaterialTheme.theme.colors.primaryText01,
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
package au.com.shiftyjelly.pocketcasts.utils.config
import au.com.shiftyjelly.pocketcasts.utils.featureflag.Feature
object FirebaseConfig {
const val PERIODIC_SAVE_TIME_MS = "periodic_playback_save_ms"
const val PLAYER_RELEASE_TIME_OUT_MS = "player_release_time_out_ms"
const val PODCAST_SEARCH_DEBOUNCE_MS... | No issues found. | package au.com.shiftyjelly.pocketcasts.utils.config
import au.com.shiftyjelly.pocketcasts.utils.featureflag.Feature
object FirebaseConfig {
const val PERIODIC_SAVE_TIME_MS = "periodic_playback_save_ms"
const val PLAYER_RELEASE_TIME_OUT_MS = "player_release_time_out_ms"
const val PODCAST_SEARCH_DEBOUNCE_MS... | @@ -1,6 +1,5 @@
package au.com.shiftyjelly.pocketcasts.utils.config
-import au.com.shiftyjelly.pocketcasts.helper.BuildConfig
import au.com.shiftyjelly.pocketcasts.utils.featureflag.Feature
object FirebaseConfig {
@@ -12,7 +11,6 @@ object FirebaseConfig {
const val SLUMBER_STUDIOS_YEARLY_PROMO_CODE = "slumb... | modules/services/utils/src/main/java/au/com/shiftyjelly/pocketcasts/utils/config/FirebaseConfig.kt | 0 | Kotlin | 1 | none | 16 | 33 | 33 | true | Add prototype build type | 4,518 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/utils/src/main/java/au/com/shiftyjelly/pocketcasts/utils/config/FirebaseConfig.kt
PR Title: Add prototype build type
BEFORE CODE: package au.com.shiftyjelly.pocketcasts.utils.config
import au.com.shiftyjelly.pocketcasts.utils.featureflag.Feat... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import androidx.hilt.navigation.compose.hiltViewModel
import au.com.shiftyjelly.pocketcasts.account.viewmodel.GoogleSignInButtonViewModel
import au.com.shiftyjelly.pocketcasts.account.viewmodel.GoogleSignInState
import au.com.shiftyjelly.pocketcasts.analytics.AnalyticsEvent
import au.com.shiftyjelly.pocketcasts.compose... | No issues found. | import androidx.hilt.navigation.compose.hiltViewModel
import au.com.shiftyjelly.pocketcasts.account.viewmodel.GoogleSignInButtonViewModel
import au.com.shiftyjelly.pocketcasts.account.viewmodel.GoogleSignInState
import au.com.shiftyjelly.pocketcasts.analytics.AnalyticsEvent
import au.com.shiftyjelly.pocketcasts.compose... | @@ -1,8 +1,6 @@
package au.com.shiftyjelly.pocketcasts.account.onboarding.components
import android.widget.Toast
-import androidx.activity.compose.rememberLauncherForActivityResult
-import androidx.activity.result.contract.ActivityResultContracts
import androidx.compose.foundation.BorderStroke
import androidx.com... | modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/components/ContinueWithGoogleButton.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [CredentialManager Migration] Migrate from GoogleSingIn on phone | 4,523 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/features/account/src/main/java/au/com/shiftyjelly/pocketcasts/account/onboarding/components/ContinueWithGoogleButton.kt
PR Title: [CredentialManager Migration] Migrate from GoogleSingIn on phone
BEFORE CODE: import androidx.hilt.navigation.compose.hilt... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
package au.com.shiftyjelly.pocketcasts.wear.ui.authentication
import androidx.activity.compose.LocalActivity
import androidx.compose.runtime.Composable
import androidx.compose.runtime.collectAsState
import androidx.hilt.navigation.compose.hiltViewModel
import au.com.shiftyjelly.pocketcasts.compose.CallOnce
@Composabl... | No issues found. | package au.com.shiftyjelly.pocketcasts.wear.ui.authentication
import androidx.activity.compose.LocalActivity
import androidx.compose.runtime.Composable
import androidx.compose.runtime.collectAsState
import androidx.hilt.navigation.compose.hiltViewModel
import au.com.shiftyjelly.pocketcasts.compose.CallOnce
@Composabl... | @@ -1,59 +1,33 @@
-@file:Suppress("DEPRECATION")
-
package au.com.shiftyjelly.pocketcasts.wear.ui.authentication
+import androidx.activity.compose.LocalActivity
import androidx.compose.runtime.Composable
import androidx.compose.runtime.collectAsState
-import androidx.compose.runtime.getValue
-import androidx.compo... | wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/authentication/LoginWithGoogleScreen.kt | 0 | Kotlin | 1 | none | 16 | 34 | 34 | true | [CredentialManager] Use Google login on WearOS | 4,528 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/authentication/LoginWithGoogleScreen.kt
PR Title: [CredentialManager] Use Google login on WearOS
BEFORE CODE: package au.com.shiftyjelly.pocketcasts.wear.ui.authentication
import androidx.activity.co... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
IR.drawable.ic_filters_play,
IR.drawable.ic_filters_volume,
IR.drawable.ic_filters_video,
IR.drawable.ic_filters_star,
)
private val shortcutDrawables = listOf(
IR.drawable.shortcut_list,
IR.drawable.shortcut_headphones,
IR.drawable.shortcut_clock,
IR.drawable.shortcut_download,
IR.... | No issues found. | IR.drawable.ic_filters_play,
IR.drawable.ic_filters_volume,
IR.drawable.ic_filters_video,
IR.drawable.ic_filters_star,
)
private val shortcutDrawables = listOf(
IR.drawable.shortcut_list,
IR.drawable.shortcut_headphones,
IR.drawable.shortcut_clock,
IR.drawable.shortcut_download,
IR.... | @@ -1,13 +1,12 @@
package au.com.shiftyjelly.pocketcasts.repositories.extensions
import au.com.shiftyjelly.pocketcasts.models.entity.PlaylistEntity
-import au.com.shiftyjelly.pocketcasts.models.to.PlaylistShortcut
-import au.com.shiftyjelly.pocketcasts.repositories.playlist.SmartPlaylistPreview
+import au.com.shift... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/extensions/Playlist.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Add PlaylistIcon type | 4,529 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/extensions/Playlist.kt
PR Title: Add PlaylistIcon type
BEFORE CODE: IR.drawable.ic_filters_play,
IR.drawable.ic_filters_volume,
IR.drawable.ic_filters_video,
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
titleRes = LR.string.notification_staff_picks_title,
dayOffset = 5,
analyticsType = "onboardingStaffPicks",
) {
override val messageRes get() = LR.string.notification_staff_picks_message
override fun toIntent(context: Context) = StaffPicksDeepLink.toIntent(context)
}
... | No issues found. | titleRes = LR.string.notification_staff_picks_title,
dayOffset = 5,
analyticsType = "onboardingStaffPicks",
) {
override val messageRes get() = LR.string.notification_staff_picks_message
override fun toIntent(context: Context) = StaffPicksDeepLink.toIntent(context)
}
... | @@ -17,6 +17,8 @@ import au.com.shiftyjelly.pocketcasts.deeplink.TrendingDeepLink
import au.com.shiftyjelly.pocketcasts.deeplink.UpsellDeepLink
import au.com.shiftyjelly.pocketcasts.preferences.Settings
import au.com.shiftyjelly.pocketcasts.preferences.Settings.NotificationId
+import au.com.shiftyjelly.pocketcasts.u... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/notification/NotificationType.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Use playlists nomenclature in the whole app | 4,532 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/notification/NotificationType.kt
PR Title: Use playlists nomenclature in the whole app
BEFORE CODE: titleRes = LR.string.notification_staff_picks_title,
day... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
subscription = null,
createdAt = null,
features = listOf(MembershipFeature.NoBannerAds),
)
assertTrue(membership.hasFeature(MembershipFeature.NoBannerAds))
assertFalse(membership.hasFeature(MembershipFeature.NoDiscoverAds))
}
... | No issues found. | subscription = null,
createdAt = null,
features = listOf(MembershipFeature.NoBannerAds),
)
assertTrue(membership.hasFeature(MembershipFeature.NoBannerAds))
assertFalse(membership.hasFeature(MembershipFeature.NoDiscoverAds))
}
... | @@ -0,0 +1,87 @@
+package au.com.shiftyjelly.pocketcasts.models.type
+
+import au.com.shiftyjelly.pocketcasts.payment.BillingCycle
+import au.com.shiftyjelly.pocketcasts.payment.SubscriptionTier
+import java.time.Instant
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertFalse
+import org.junit.Assert... | modules/services/model/src/test/java/au/com/shiftyjelly/pocketcasts/models/type/MembershipTest.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Add user memebership | 4,533 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/model/src/test/java/au/com/shiftyjelly/pocketcasts/models/type/MembershipTest.kt
PR Title: Add user memebership
BEFORE CODE: subscription = null,
createdAt = null,
features = listOf(MembershipFea... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
package au.com.shiftyjelly.pocketcasts.preferences.model
import java.util.UUID
import org.junit.Assert.assertEquals
import org.junit.Test
class AutoPlaySourceTest {
@Test
fun `create PodcastOrFilter from uuid ID`() {
val uuid = UUID.randomUUID().toString()
val source = AutoPlaySource.fromId(u... | No issues found. | package au.com.shiftyjelly.pocketcasts.preferences.model
import java.util.UUID
import org.junit.Assert.assertEquals
import org.junit.Test
class AutoPlaySourceTest {
@Test
fun `create PodcastOrFilter from uuid ID`() {
val uuid = UUID.randomUUID().toString()
val source = AutoPlaySource.fromId(u... | @@ -43,43 +43,4 @@ class AutoPlaySourceTest {
assertEquals(AutoPlaySource.Predefined.Starred, source)
}
-
- @Test
- fun `create PodcastOrFilter from uuid server ID`() {
- val uuid = UUID.randomUUID().toString()
-
- val source = AutoPlaySource.fromServerId(uuid)
-
- assertEqual... | modules/services/preferences/src/test/kotlin/au/com/shiftyjelly/pocketcasts/preferences/model/AutoPlaySourceTest.kt | 0 | Kotlin | 1 | none | 16 | 47 | 47 | true | Add auto play to playlists | 4,534 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/services/preferences/src/test/kotlin/au/com/shiftyjelly/pocketcasts/preferences/model/AutoPlaySourceTest.kt
PR Title: Add auto play to playlists
BEFORE CODE: package au.com.shiftyjelly.pocketcasts.preferences.model
import java.util.UUID
import org.jun... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
uuid = UUID.randomUUID().toString(),
title = "Playlist title",
episodeCount = 0,
artworkPodcastUuids = emptyList(),
settings = Playlist.Settings.ForPreview,
icon = PlaylistIcon(0),
)
val playlistPreviews = listOf(playlistPreview)
... | No issues found. | uuid = UUID.randomUUID().toString(),
title = "Playlist title",
episodeCount = 0,
artworkPodcastUuids = emptyList(),
settings = Playlist.Settings.ForPreview,
icon = PlaylistIcon(0),
)
val playlistPreviews = listOf(playlistPreview)
... | @@ -8,21 +8,27 @@ import androidx.test.core.app.ApplicationProvider
import androidx.test.ext.junit.runners.AndroidJUnit4
import androidx.test.rule.ServiceTestRule
import au.com.shiftyjelly.pocketcasts.PocketCastsApplication
-import au.com.shiftyjelly.pocketcasts.models.entity.PlaylistEntity
import au.com.shiftyjell... | app/src/androidTest/java/au/com/shiftyjelly/pocketcasts/ui/PlaybackServiceTest.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Support playlists in Android Auto and Automotive | 4,535 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: app/src/androidTest/java/au/com/shiftyjelly/pocketcasts/ui/PlaybackServiceTest.kt
PR Title: Support playlists in Android Auto and Automotive
BEFORE CODE: uuid = UUID.randomUUID().toString(),
title = "Playlist title",
episode... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import com.google.android.horologist.compose.layout.ScalingLazyColumn
import com.google.android.horologist.compose.layout.ScalingLazyColumnState
import au.com.shiftyjelly.pocketcasts.localization.R as LR
object PlaylistsScreen {
const val ROUTE = "playlists_screen"
}
@Composable
fun PlaylistsScreen(
columnSta... | No issues found. | import com.google.android.horologist.compose.layout.ScalingLazyColumn
import com.google.android.horologist.compose.layout.ScalingLazyColumnState
import au.com.shiftyjelly.pocketcasts.localization.R as LR
object PlaylistsScreen {
const val ROUTE = "playlists_screen"
}
@Composable
fun PlaylistsScreen(
columnSta... | @@ -0,0 +1,97 @@
+package au.com.shiftyjelly.pocketcasts.wear.ui.playlists
+
+import androidx.compose.foundation.layout.fillMaxWidth
+import androidx.compose.foundation.layout.padding
+import androidx.compose.foundation.layout.size
+import androidx.compose.material.Icon
+import androidx.compose.runtime.Composable
+impo... | wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/playlists/PlaylistsScreen.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Add playlists Wear support | 4,536 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/playlists/PlaylistsScreen.kt
PR Title: Add playlists Wear support
BEFORE CODE: import com.google.android.horologist.compose.layout.ScalingLazyColumn
import com.google.android.horologist.compose.layout... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
package au.com.shiftyjelly.pocketcasts.taskerplugin.base.hilt
import android.content.Context
import au.com.shiftyjelly.pocketcasts.preferences.Settings
import au.com.shiftyjelly.pocketcasts.repositories.playback.PlaybackManager
import au.com.shiftyjelly.pocketcasts.repositories.playlist.PlaylistManager
import au.com.s... | No issues found. | package au.com.shiftyjelly.pocketcasts.taskerplugin.base.hilt
import android.content.Context
import au.com.shiftyjelly.pocketcasts.preferences.Settings
import au.com.shiftyjelly.pocketcasts.repositories.playback.PlaybackManager
import au.com.shiftyjelly.pocketcasts.repositories.playlist.PlaylistManager
import au.com.s... | @@ -2,11 +2,10 @@ package au.com.shiftyjelly.pocketcasts.taskerplugin.base.hilt
import android.content.Context
import au.com.shiftyjelly.pocketcasts.preferences.Settings
-import au.com.shiftyjelly.pocketcasts.repositories.download.DownloadManager
import au.com.shiftyjelly.pocketcasts.repositories.playback.Playback... | modules/features/taskerplugin/src/main/java/au/com/shiftyjelly/pocketcasts/taskerplugin/base/hilt/HiltEntryPoints.kt | 0 | Kotlin | 1 | none | 16 | 32 | 32 | true | Update Tasker to use playlists | 4,546 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/taskerplugin/src/main/java/au/com/shiftyjelly/pocketcasts/taskerplugin/base/hilt/HiltEntryPoints.kt
PR Title: Update Tasker to use playlists
BEFORE CODE: package au.com.shiftyjelly.pocketcasts.taskerplugin.base.hilt
import android.content.Con... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
@Binds
@Singleton
abstract fun bindAutoCompleteSearchManager(impl: SearchAutoCompleteManagerImpl): SearchAutoCompleteManager
@Binds
@Singleton
abstract fun providesSubscriptionManager(subscriptionManagerImpl: SubscriptionManagerImpl): SubscriptionManager
@Binds
@Singleton
abstract... | No issues found. |
@Binds
@Singleton
abstract fun bindAutoCompleteSearchManager(impl: SearchAutoCompleteManagerImpl): SearchAutoCompleteManager
@Binds
@Singleton
abstract fun providesSubscriptionManager(subscriptionManagerImpl: SubscriptionManagerImpl): SubscriptionManager
@Binds
@Singleton
abstract... | @@ -54,6 +54,8 @@ import au.com.shiftyjelly.pocketcasts.repositories.ratings.RatingsManager
import au.com.shiftyjelly.pocketcasts.repositories.ratings.RatingsManagerImpl
import au.com.shiftyjelly.pocketcasts.repositories.referrals.ReferralManager
import au.com.shiftyjelly.pocketcasts.repositories.referrals.ReferralM... | modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/di/RepositoryModule.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | [Improved Search] Implement autocomplete | 4,550 | Automattic/pocket-casts-android | 1,688 | Kotlin | sztomek | Review this pull request change.
Language: Kotlin
File: modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/di/RepositoryModule.kt
PR Title: [Improved Search] Implement autocomplete
BEFORE CODE:
@Binds
@Singleton
abstract fun bindAutoCompleteSearchManager(impl: Searc... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
}
}
}
fun unbind() {
disposable.clear()
binding.episodeRow.handler?.removeCallbacksAndMessages(null)
}
private fun observeRowData() {
disposable.clear()
disposable += rowDataProvider.episodeRowDataObservable(episode.uuid).subscribeBy(onNext = { data ... | No issues found. | }
}
}
fun unbind() {
disposable.clear()
binding.episodeRow.handler?.removeCallbacksAndMessages(null)
}
private fun observeRowData() {
disposable.clear()
disposable += rowDataProvider.episodeRowDataObservable(episode.uuid).subscribeBy(onNext = { data ... | @@ -162,8 +162,6 @@ abstract class BaseEpisodeViewHolder<T : Any>(
binding.imgUpNext.isVisible = data.isInUpNext
binding.imgBookmark.isVisible = data.hasBookmarks
- binding.progressBar.isVisible = false
- binding.progressCircle.isVisible = false
if (data.... | modules/features/podcasts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcast/BaseEpisodeViewHolder.kt | 0 | Kotlin | 1 | none | 16 | 51 | 51 | true | Fix download status updates | 4,552 | Automattic/pocket-casts-android | 1,688 | Kotlin | MiSikora | Review this pull request change.
Language: Kotlin
File: modules/features/podcasts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcast/BaseEpisodeViewHolder.kt
PR Title: Fix download status updates
BEFORE CODE: }
}
}
fun unbind() {
disposable.clear()
bindin... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.