before_code stringlengths 30 149k | reviewer_comment stringlengths 16 20.6k | after_code stringlengths 30 163k | diff_context stringlengths 0 22.4k | file_path stringlengths 6 155 | comment_line int64 0 26 | language stringclasses 19
values | quality_score float64 0.07 1 | comment_type stringclasses 9
values | comment_length int64 16 20.6k | before_lines int64 2 4.61k | after_lines int64 2 4.4k | is_negative bool 2
classes | pr_title stringlengths 7 140 | pr_number int64 18 61.2k | repo_name stringclasses 29
values | repo_stars int64 321 56k | repo_language stringclasses 14
values | reviewer_username stringclasses 378
values | author_username stringclasses 739
values | user stringlengths 361 200k | assistant stringlengths 16 20.6k | system stringclasses 1
value |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
},
inner_properties={
"on_edit": ElementProperty(PropertyType.function, f"{{{__CTX_VAR_NAME}.edit_entity}}"),
"on_submit": ElementProperty(PropertyType.function, f"{{{__CTX_VAR_NAME}.submit_entity}}"),
"on_delete": ElementProperty(PropertyType.func... | No issues found. | },
inner_properties={
"on_edit": ElementProperty(PropertyType.function, f"{{{__CTX_VAR_NAME}.edit_entity}}"),
"on_submit": ElementProperty(PropertyType.function, f"{{{__CTX_VAR_NAME}.submit_entity}}"),
"on_delete": ElementProperty(PropertyType.func... | @@ -75,8 +75,8 @@ class _GuiCore(ElementLibrary):
"show_dialog": ElementProperty(PropertyType.boolean, True),
__SEL_SCENARIOS_PROP: ElementProperty(PropertyType.dynamic_list),
"multiple": ElementProperty(PropertyType.boolean, False),
- "filter": ElementP... | taipy/gui_core/_GuiCoreLib.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | When no cycle are used in the scenario configs ... | 1,360 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: taipy/gui_core/_GuiCoreLib.py
PR Title: When no cycle are used in the scenario configs ...
BEFORE CODE: },
inner_properties={
"on_edit": ElementProperty(PropertyType.function, f"{{{__CTX_VAR_NAME}.edit_entity}}"),
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
socket && socket.connect();
}, 500);
});
// try to reconnect on server disconnection
socket.on("disconnect", (reason, details) => {
console.log("WebSocket disconnected due to: ", reason, details);
if (reason === "io server disconnect") {
socket && socket.conne... | No issues found. | socket && socket.connect();
}, 500);
});
// try to reconnect on server disconnection
socket.on("disconnect", (reason, details) => {
console.log("WebSocket disconnected due to: ", reason, details);
if (reason === "io server disconnect") {
socket && socket.conne... | @@ -17,16 +17,16 @@ interface AlertMessage extends WsMessage {
const initWsMessageTypes = ["ID", "AID", "GMC"];
-export const initSocket = (socket: Socket, appManager: TaipyApp) => {
+export const initSocket = (socket: Socket, taipyApp: TaipyApp) => {
socket.on("connect", () => {
- if (appManager.clien... | frontend/taipy-gui/base/src/utils.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Get Routes with type frontend decouple | 1,370 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/base/src/utils.ts
PR Title: Get Routes with type frontend decouple
BEFORE CODE: socket && socket.connect();
}, 500);
});
// try to reconnect on server disconnection
socket.on("disconnect", (reason, details... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
return False
try:
if col_type == "any":
# when a property is not found, return True only if action is not equals
if not is_dn and not hasattr(ent, "properties") or not ent.properties.get(col_fn or col):
return action == "!="
if op := _operators.get(act... | No issues found. | return False
try:
if col_type == "any":
# when a property is not found, return True only if action is not equals
if not is_dn and not hasattr(ent, "properties") or not ent.properties.get(col_fn or col):
return action == "!="
if op := _operators.get(act... | @@ -401,9 +401,16 @@ def get_col_name(attr: str):
def get_enums(self):
if _GuiCoreScenarioProperties.__ENUMS is None:
_GuiCoreScenarioProperties.__ENUMS = {
- "Config id": [c for c in Config.scenarios.keys() if c != "default"],
- "Tags": list({t for s in Config.s... | taipy/gui_core/_adapters.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | filter UI on boolean col | 1,382 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: taipy/gui_core/_adapters.py
PR Title: filter UI on boolean col
BEFORE CODE: return False
try:
if col_type == "any":
# when a property is not found, return True only if action is not equals
if not is_dn and not hasatt... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
def test_notification_unsubscribe_multi_param():
scenario_config = Config.configure_scenario(
"awesome_scenario",
[
Config.configure_task(
"mult_by_2",
mult_by_2,
[Config.configure_data_node("foo", "in_memory", Scope.SCENARIO, default_data=... | No issues found. | def test_notification_unsubscribe_multi_param():
scenario_config = Config.configure_scenario(
"awesome_scenario",
[
Config.configure_task(
"mult_by_2",
mult_by_2,
[Config.configure_data_node("foo", "in_memory", Scope.SCENARIO, default_data=... | @@ -365,6 +365,33 @@ def test_create_and_delete_scenario():
assert len(_ScenarioManager._get_all()) == 0
+def test_can_create():
+ dn_config = Config.configure_in_memory_data_node("dn", 10)
+ task_config = Config.configure_task("task", print, [dn_config])
+ scenario_config = Config.configure_scenario(... | tests/core/scenario/test_scenario_manager.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Feature/enterprise#362 - Add can_create() api | 1,390 | Avaiga/taipy | 12,680 | Python | trgiangdo | Review this pull request change.
Language: Python
File: tests/core/scenario/test_scenario_manager.py
PR Title: Feature/enterprise#362 - Add can_create() api
BEFORE CODE: def test_notification_unsubscribe_multi_param():
scenario_config = Config.configure_scenario(
"awesome_scenario",
[
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
showDelete
}: JobSelectedTableRowProps) => {
const [id, jobName, , entityId, entityName, submitId, creationDate, status] = row;
return (
<TableRow
hover
role="checkbox"
tabIndex={-1}
key={id}
data-id={id}
onClick={handleSelecti... | No issues found. | showDelete
}: JobSelectedTableRowProps) => {
const [id, jobName, , entityId, entityName, submitId, creationDate, status] = row;
return (
<TableRow
hover
role="checkbox"
tabIndex={-1}
key={id}
data-id={id}
onClick={handleSelecti... | @@ -16,7 +16,6 @@ import { DeleteOutline, StopCircleOutlined, Add, FilterList } from "@mui/icons-m
import Box from "@mui/material/Box";
import Button from "@mui/material/Button";
import Checkbox from "@mui/material/Checkbox";
-import Chip from "@mui/material/Chip";
import FormControl from "@mui/material/FormControl... | frontend/taipy/src/JobSelector.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | add submission indicator to scenario | 1,393 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: TypeScript
File: frontend/taipy/src/JobSelector.tsx
PR Title: add submission indicator to scenario
BEFORE CODE: showDelete
}: JobSelectedTableRowProps) => {
const [id, jobName, , entityId, entityName, submitId, creationDate, status] = row;
return (
<Ta... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
[
("message", PropertyType.dynamic_string),
("on_action", PropertyType.function, "on_login"),
]
),
"menu": lambda gui, control_type, attrs: _Builder(
gui=gui,
control_type=control_type,
element_name="MenuCtl",
... | No issues found. | [
("message", PropertyType.dynamic_string),
("on_action", PropertyType.function, "on_login"),
]
),
"menu": lambda gui, control_type, attrs: _Builder(
gui=gui,
control_type=control_type,
element_name="MenuCtl",
... | @@ -357,6 +357,7 @@ class _Factory:
("show_value", PropertyType.boolean, True),
("format", PropertyType.string),
("delta_format", PropertyType.string),
+ ("color_map", PropertyType.dict),
("hover_text", PropertyType.dynamic_string),
... | taipy/gui/_renderers/factory.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | adding color-map property to Metric | 1,407 | Avaiga/taipy | 12,680 | Python | namnguyen20999 | Review this pull request change.
Language: Python
File: taipy/gui/_renderers/factory.py
PR Title: adding color-map property to Metric
BEFORE CODE: [
("message", PropertyType.dynamic_string),
("on_action", PropertyType.function, "on_login"),
]
),
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
try:
if col_type == "any":
# when a property is not found, return True only if action is not equals
if not is_dn and not hasattr(ent, "properties") or not ent.properties.get(col_fn or col):
return action == "!="
if op := _operators.get(action):
cur... | No issues found. | try:
if col_type == "any":
# when a property is not found, return True only if action is not equals
if not is_dn and not hasattr(ent, "properties") or not ent.properties.get(col_fn or col):
return action == "!="
if op := _operators.get(action):
cur... | @@ -19,7 +19,6 @@
from dataclasses import dataclass
from datetime import date, datetime
from enum import Enum
-from numbers import Number
from operator import attrgetter, contains, eq, ge, gt, le, lt, ne
import pandas as pd
@@ -182,10 +181,8 @@ def __get_data(self, dn: DataNode):
return (Non... | taipy/gui_core/_adapters.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Support for pandas TimeStamp | 1,412 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: taipy/gui_core/_adapters.py
PR Title: Support for pandas TimeStamp
BEFORE CODE: try:
if col_type == "any":
# when a property is not found, return True only if action is not equals
if not is_dn and not hasattr(ent, "propertie... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
expect(getNumberString(1, undefined, getNumberFormatConfig())).toBe("1");
});
it("returns formatted", async () => {
expect(getNumberString(1, "%.1f", getNumberFormatConfig())).toBe("1.0");
});
it("returns formatted float", async () => {
expect(getNumberString(1.0, "%.0f", getNumb... | No issues found. | expect(getNumberString(1, undefined, getNumberFormatConfig())).toBe("1");
});
it("returns formatted", async () => {
expect(getNumberString(1, "%.1f", getNumberFormatConfig())).toBe("1.0");
});
it("returns formatted float", async () => {
expect(getNumberString(1.0, "%.0f", getNumb... | @@ -14,7 +14,7 @@
import "@testing-library/jest-dom";
import { FormatConfig } from "../context/taipyReducers";
-import { getNumberString } from "./index";
+import { getNumberString, getDateTimeString } from "./index";
let myWarn: jest.Mock;
@@ -23,49 +23,88 @@ beforeEach(() => {
console.warn = myWarn;
})... | frontend/taipy-gui/src/utils/index.spec.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Submission status update | 1,434 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/utils/index.spec.ts
PR Title: Submission status update
BEFORE CODE: expect(getNumberString(1, undefined, getNumberFormatConfig())).toBe("1");
});
it("returns formatted", async () => {
expect(getNumberString(1,... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
A custom page for external application that can be added to Taipy GUI"""
def __init__(
self,
resource_handler: ResourceHandler,
binding_variables: t.Optional[t.List[str]] = None,
metadata: t.Optional[t.Dict[str, t.Any]] = None,
**kwargs,
) -> None:
if binding... | No issues found. | A custom page for external application that can be added to Taipy GUI"""
def __init__(
self,
resource_handler: ResourceHandler,
binding_variables: t.Optional[t.List[str]] = None,
metadata: t.Optional[t.Dict[str, t.Any]] = None,
**kwargs,
) -> None:
if binding... | @@ -46,13 +46,13 @@ class ResourceHandler(ABC):
User can implement this class to provide custom resources for the custom pages
"""
- id: str = ""
+ rh_id: str = ""
def __init__(self) -> None:
_ExternalResourceHandlerManager().register(self)
def get_id(self) -> str:
- retu... | taipy/gui/custom/_page.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | root page decouple | 1,443 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: Python
File: taipy/gui/custom/_page.py
PR Title: root page decouple
BEFORE CODE: A custom page for external application that can be added to Taipy GUI"""
def __init__(
self,
resource_handler: ResourceHandler,
binding_variables: t.Optional[t... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
interface NavigateProps {
to?: string;
params?: Record<string, string>;
tab?: string;
force?: boolean;
}
const Navigate = ({ to, params, tab, force }: NavigateProps) => {
const { dispatch, state } = useContext(TaipyContext);
const navigate = useNavigate();
const location = useLocation();
... | No issues found. |
interface NavigateProps {
to?: string;
params?: Record<string, string>;
tab?: string;
force?: boolean;
}
const Navigate = ({ to, params, tab, force }: NavigateProps) => {
const { dispatch, state } = useContext(TaipyContext);
const navigate = useNavigate();
const location = useLocation();
... | @@ -27,7 +27,7 @@ const Navigate = ({ to, params, tab, force }: NavigateProps) => {
const { dispatch, state } = useContext(TaipyContext);
const navigate = useNavigate();
const location = useLocation();
- const SPECIAL_PARAMS = ["tp_reload_all", "tp_reload_same_route_only", "tprh", "tp_cp_meta"];
+ ... | frontend/taipy-gui/src/components/Taipy/Navigate.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | fix decouple metadata | 1,446 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/Navigate.tsx
PR Title: fix decouple metadata
BEFORE CODE:
interface NavigateProps {
to?: string;
params?: Record<string, string>;
tab?: string;
force?: boolean;
}
const Navigate = ({ to, params, tab... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
if data_hash:
cmp_idx = 1
cmp_datas = []
cmp_datas_hash = []
while cmp_data := self.__hashes.get(f"data[{cmp_idx}]"):
cmp_idx += 1
cmp_datas.append(self.__gui._get_real_var_name(cmp_data)[0])
cmp_datas_hash.append(cm... | No issues found. | if data_hash:
cmp_idx = 1
cmp_datas = []
cmp_datas_hash = []
while cmp_data := self.__hashes.get(f"data[{cmp_idx}]"):
cmp_idx += 1
cmp_datas.append(self.__gui._get_real_var_name(cmp_data)[0])
cmp_datas_hash.append(cm... | @@ -191,6 +191,11 @@ def __get_list_of_(self, name: str):
lof = self.__attributes.get(name)
if isinstance(lof, str):
lof = list(lof.split(";"))
+ if not isinstance(lof, list) and hasattr(lof, "tolist"):
+ try:
+ return lof.tolist() # type: ignore[union-at... | taipy/gui/_renderers/builder.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Accept Pandas Series in lov property | 1,447 | Avaiga/taipy | 12,680 | Python | Satoshi-Sh | Review this pull request change.
Language: Python
File: taipy/gui/_renderers/builder.py
PR Title: Accept Pandas Series in lov property
BEFORE CODE: if data_hash:
cmp_idx = 1
cmp_datas = []
cmp_datas_hash = []
while cmp_data := self.__hashes.get(f"data[{cmp_idx... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | No issues found. | # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | @@ -0,0 +1,35 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required b... | tests/gui/gui_specific/test_favicon.py | 0 | Python | 1 | none | 16 | 36 | 36 | true | use taipy-assets favicon | 1,453 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: tests/gui/gui_specific/test_favicon.py
PR Title: use taipy-assets favicon
BEFORE CODE: # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the Li... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
from taipy.core.reason import ReasonCollection
def test_create_reason():
reason_collection = ReasonCollection()
assert reason_collection._reasons == {}
assert reason_collection
assert not reason_collection._entity_id_exists_in_reason("entity_id")
assert reason_collection.reasons == ""
def test_a... | No issues found. | from taipy.core.reason import ReasonCollection
def test_create_reason():
reason_collection = ReasonCollection()
assert reason_collection._reasons == {}
assert reason_collection
assert not reason_collection._entity_id_exists_in_reason("entity_id")
assert reason_collection.reasons == ""
def test_a... | @@ -9,61 +9,63 @@
# an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
# specific language governing permissions and limitations under the License.
-from taipy.core.reason.reason import Reasons
+from taipy.core.reason import ReasonCollection
def t... | tests/core/common/test_reason.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Reason class refactoring | 1,459 | Avaiga/taipy | 12,680 | Python | toan-quach | Review this pull request change.
Language: Python
File: tests/core/common/test_reason.py
PR Title: Reason class refactoring
BEFORE CODE: from taipy.core.reason import ReasonCollection
def test_create_reason():
reason_collection = ReasonCollection()
assert reason_collection._reasons == {}
assert reason... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
name: "varname",
payload: { value: "Valdata" },
propagate: true,
type: "SEND_UPDATE_ACTION",
});
});
it("dispatch a no action message on unsupported key", async () => {
const dispatch = jest.fn();
const state: TaipyState = INITIAL_STATE;
... | No issues found. | name: "varname",
payload: { value: "Valdata" },
propagate: true,
type: "SEND_UPDATE_ACTION",
});
});
it("dispatch a no action message on unsupported key", async () => {
const dispatch = jest.fn();
const state: TaipyState = INITIAL_STATE;
... | @@ -28,14 +28,14 @@ describe("Input Component", () => {
});
it("displays the right info for string", async () => {
const { getByDisplayValue } = render(
- <Input value="toto" type="text" defaultValue="titi" className="taipy-input" />
+ <Input value="toto" type="text" defaultValu... | frontend/taipy-gui/src/components/Taipy/Input.spec.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Feature/#1429 number step attribute | 1,469 | Avaiga/taipy | 12,680 | Python | namnguyen20999 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/Input.spec.tsx
PR Title: Feature/#1429 number step attribute
BEFORE CODE: name: "varname",
payload: { value: "Valdata" },
propagate: true,
type: "SEND_UPDATE_ACTION",
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
| "ID"
| "MS"
| "DF"
| "PR"
| "ACK"
| "GMC"
| "GDT"
| "AID"
| "GR";
export type OnInitHandler = (taipyApp: TaipyApp) => void;
export type OnChangeHandler = (taipyApp: TaipyApp, encodedName: string, value: unknown) => void;
export type OnNotifyHandler = (taipyApp: TaipyApp, type: stri... | No issues found. | | "ID"
| "MS"
| "DF"
| "PR"
| "ACK"
| "GMC"
| "GDT"
| "AID"
| "GR";
export type OnInitHandler = (taipyApp: TaipyApp) => void;
export type OnChangeHandler = (taipyApp: TaipyApp, encodedName: string, value: unknown) => void;
export type OnNotifyHandler = (taipyApp: TaipyApp, type: stri... | @@ -20,22 +20,44 @@ declare class DataManager {
getAllData(): Record<string, unknown>;
update(encodedName: string, value: unknown): void;
}
+export type WsMessageType =
+ | "A"
+ | "U"
+ | "DU"
+ | "MU"
+ | "RU"
+ | "AL"
+ | "BL"
+ | "NA"
+ | "ID"
+ | "MS"
+ | "DF"
+ | "PR... | frontend/taipy-gui/base/src/packaging/taipy-gui-base.d.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Decouple Acknowledgement | 1,477 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/base/src/packaging/taipy-gui-base.d.ts
PR Title: Decouple Acknowledgement
BEFORE CODE: | "ID"
| "MS"
| "DF"
| "PR"
| "ACK"
| "GMC"
| "GDT"
| "AID"
| "GR";
export type OnInitHandler = (taipyApp: TaipyAp... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
assert _Subscriber(notify_multi_param, ["foobar", 123, 0]) not in scenario.subscribers
# If params are passed, find the corresponding pair of callback and params to remove
scenario.unsubscribe(notify_multi_param, ["foobar", 123, 2])
assert len(scenario.subscribers) == 1
assert _Subscriber(notify_mu... | No issues found. | assert _Subscriber(notify_multi_param, ["foobar", 123, 0]) not in scenario.subscribers
# If params are passed, find the corresponding pair of callback and params to remove
scenario.unsubscribe(notify_multi_param, ["foobar", 123, 2])
assert len(scenario.subscribers) == 1
assert _Subscriber(notify_mu... | @@ -13,6 +13,7 @@
from typing import Callable, Iterable, Optional
from unittest.mock import ANY, patch
+import freezegun
import pytest
from taipy.config.common.frequency import Frequency
@@ -1481,3 +1482,55 @@ def test_get_scenarios_by_config_id_in_multiple_versions_environment():
assert len(_ScenarioMan... | tests/core/scenario/test_scenario_manager.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Feature/#393 - Creation time filtering for scenario getters | 1,480 | Avaiga/taipy | 12,680 | Python | trgiangdo | Review this pull request change.
Language: Python
File: tests/core/scenario/test_scenario_manager.py
PR Title: Feature/#393 - Creation time filtering for scenario getters
BEFORE CODE: assert _Subscriber(notify_multi_param, ["foobar", 123, 0]) not in scenario.subscribers
# If params are passed, find the cor... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const formatConfig = useFormatConfig();
const tz = formatConfig.timeZone;
const [value, setValue] = useState(() => getDateTime(props.defaultDate, tz, withTime));
const [startProps, setStartProps] = useState<DateProps>({});
const [endProps, setEndProps] = useState<DateProps>({});
const module = u... | No issues found. | const formatConfig = useFormatConfig();
const tz = formatConfig.timeZone;
const [value, setValue] = useState(() => getDateTime(props.defaultDate, tz, withTime));
const [startProps, setStartProps] = useState<DateProps>({});
const [endProps, setEndProps] = useState<DateProps>({});
const module = u... | @@ -14,14 +14,14 @@
import React, { useState, useEffect, useCallback } from "react";
import Box from "@mui/material/Box";
import Tooltip from "@mui/material/Tooltip";
-import { DatePicker } from "@mui/x-date-pickers/DatePicker";
+import { DatePicker, DatePickerProps } from "@mui/x-date-pickers/DatePicker";
import {... | frontend/taipy-gui/src/components/Taipy/DateSelector.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Feature/#848 adding min max picker for date selector | 1,485 | Avaiga/taipy | 12,680 | Python | namnguyen20999 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/DateSelector.tsx
PR Title: Feature/#848 adding min max picker for date selector
BEFORE CODE: const formatConfig = useFormatConfig();
const tz = formatConfig.timeZone;
const [value, setValue] = useState(()... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
| "GMC"
| "GDT"
| "AID"
| "GR"
| "FV";
export interface WsMessage {
type: WsMessageType | string;
name: string;
payload: Record<string, unknown> | unknown;
propagate: boolean;
client_id: string;
module_context: string;
ack_id?: string;
}
export type OnInitHandler = (taipy... | No issues found. | | "GMC"
| "GDT"
| "AID"
| "GR"
| "FV";
export interface WsMessage {
type: WsMessageType | string;
name: string;
payload: Record<string, unknown> | unknown;
propagate: boolean;
client_id: string;
module_context: string;
ack_id?: string;
}
export type OnInitHandler = (taipy... | @@ -37,11 +37,22 @@ export type WsMessageType =
| "GMC"
| "GDT"
| "AID"
- | "GR";
+ | "GR"
+ | "FV";
+export interface WsMessage {
+ type: WsMessageType | string;
+ name: string;
+ payload: Record<string, unknown> | unknown;
+ propagate: boolean;
+ client_id: string;
+ module_c... | frontend/taipy-gui/base/src/packaging/taipy-gui-base.d.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Expose websocket decouple frontend | 1,501 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/base/src/packaging/taipy-gui-base.d.ts
PR Title: Expose websocket decouple frontend
BEFORE CODE: | "GMC"
| "GDT"
| "AID"
| "GR"
| "FV";
export interface WsMessage {
type: WsMessageType | string;
name: string;
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | No issues found. | # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | @@ -31,3 +31,19 @@ def test_builder_lambda_2(gui: Gui, test_client, helpers):
tgb.text(lambda message: str(message.get(key)), mode=lambda message: "mode " + str(message.get(key))) # type: ignore[attr-defined] # noqa: B023
expected_list = ['defaultValue="value A"', 'defaultValue="value B"', 'mode="mod... | tests/gui/builder/test_lambda.py | 0 | Python | 1 | none | 16 | 50 | 50 | true | support f-strings in lambda | 1,505 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: tests/gui/builder/test_lambda.py
PR Title: support f-strings in lambda
BEFORE CODE: # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the Licen... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const className = useClassNames(props.libClassName, props.dynamicClassName, props.className);
const active = useDynamicProperty(props.active, props.defaultActive, true);
const hover = useDynamicProperty(props.hoverText, props.defaultHoverText, undefined);
const handleFiles = useCallback(
(file... | No issues found. |
const className = useClassNames(props.libClassName, props.dynamicClassName, props.className);
const active = useDynamicProperty(props.active, props.defaultActive, true);
const hover = useDynamicProperty(props.hoverText, props.defaultHoverText, undefined);
const handleFiles = useCallback(
(file... | @@ -76,25 +76,27 @@ const FileSelector = (props: FileSelectorProps) => {
(value) => {
setUpload(false);
onAction && dispatch(createSendActionNameAction(id, module, onAction));
- notify && dispatch(
- ... | frontend/taipy-gui/src/components/Taipy/FileSelector.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | add test cases for FileSelector.tsx | 1,507 | Avaiga/taipy | 12,680 | Python | namnguyen20999 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/FileSelector.tsx
PR Title: add test cases for FileSelector.tsx
BEFORE CODE:
const className = useClassNames(props.libClassName, props.dynamicClassName, props.className);
const active = useDynamicProperty(pro... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
});
it("should parse non-placeholder text", () => {
const result = sprintfParse("Hello, World!");
expect(result).toEqual(["Hello, World!"]);
});
it('should parse the "%%" escape sequence', () => {
const result = sprintfParse("%%");
expect(result).toEqual(["%"]);
});
... | No issues found. | });
it("should parse non-placeholder text", () => {
const result = sprintfParse("Hello, World!");
expect(result).toEqual(["Hello, World!"]);
});
it('should parse the "%%" escape sequence', () => {
const result = sprintfParse("%%");
expect(result).toEqual(["%"]);
});
... | @@ -0,0 +1,109 @@
+/*
+ * Copyright 2021-2024 Avaiga Private Limited
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unle... | frontend/taipy-gui/src/utils/utils.spec.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Unit test for format conversion | 1,514 | Avaiga/taipy | 12,680 | Python | namnguyen20999 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/utils/utils.spec.ts
PR Title: Unit test for format conversion
BEFORE CODE: });
it("should parse non-placeholder text", () => {
const result = sprintfParse("Hello, World!");
expect(result).toEqual(["Hello, Worl... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
defaultContent: string;
}
const Image = (props: ImageProps) => {
const { id, onAction, width = 300, height } = props;
const dispatch = useDispatch();
const divRef = useRef<HTMLDivElement>(null);
const module = useModule();
const className = useClassNames(props.libClassName, props.dynamicClassN... | No issues found. | defaultContent: string;
}
const Image = (props: ImageProps) => {
const { id, onAction, width = 300, height } = props;
const dispatch = useDispatch();
const divRef = useRef<HTMLDivElement>(null);
const module = useModule();
const className = useClassNames(props.libClassName, props.dynamicClassN... | @@ -58,12 +58,15 @@ const Image = (props: ImageProps) => {
return [undefined, undefined, false];
}, [content]);
- const style = useMemo(() => ({
- width: width,
- height: height,
- display: inlineSvg ? "inline-flex" : undefined,
- verticalAlign: inlineSvg ? "middle" : unde... | frontend/taipy-gui/src/components/Taipy/Image.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Unit test for Image.tsx | 1,524 | Avaiga/taipy | 12,680 | Python | namnguyen20999 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/Image.tsx
PR Title: Unit test for Image.tsx
BEFORE CODE: defaultContent: string;
}
const Image = (props: ImageProps) => {
const { id, onAction, width = 300, height } = props;
const dispatch = useDispatch... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const className = useClassNames(props.libClassName, props.dynamicClassName, props.className);
const active = useDynamicProperty(props.active, props.defaultActive, true);
const hover = useDynamicProperty(props.hoverText, props.defaultHoverText, undefined);
const handleFiles = useCallback(
(files... | No issues found. | const className = useClassNames(props.libClassName, props.dynamicClassName, props.className);
const active = useDynamicProperty(props.active, props.defaultActive, true);
const hover = useDynamicProperty(props.hoverText, props.defaultHoverText, undefined);
const handleFiles = useCallback(
(files... | @@ -78,25 +78,25 @@ const FileSelector = (props: FileSelectorProps) => {
onAction && dispatch(createSendActionNameAction(id, module, onAction));
notify &&
dispatch(
- createAlertAction({ atype: "success", messa... | frontend/taipy-gui/src/components/Taipy/FileSelector.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | inactive file selector | 1,533 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/FileSelector.tsx
PR Title: inactive file selector
BEFORE CODE: const className = useClassNames(props.libClassName, props.dynamicClassName, props.className);
const active = useDynamicProperty(props.active, pro... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
helpers.run_e2e(gui)
page.goto("./test")
page.wait_for_selector(".plot-container")
number = page.locator("//*[@class='js-plotly-plot']//*[name()='svg'][2]//*[@class='number']")
assert number.text_content() == "50"
@pytest.mark.teste2e
def test_format_converter_integer_to_signed_decimal_i_type(page... | No issues found. | helpers.run_e2e(gui)
page.goto("./test")
page.wait_for_selector(".plot-container")
number = page.locator("//*[@class='js-plotly-plot']//*[name()='svg'][2]//*[@class='number']")
assert number.text_content() == "50"
@pytest.mark.teste2e
def test_format_converter_integer_to_signed_decimal_i_type(page... | @@ -102,8 +102,7 @@ def test_format_converter_integer_to_binary(page: Page, gui: Gui, helpers):
helpers.run_e2e(gui)
page.goto("./test")
page.wait_for_selector(".plot-container")
- number = page.locator(
- "//*[@class='js-plotly-plot']//*[name()='svg'][2]//*[@class='number']")
+ number = pag... | tests/gui/e2e/test_metric_indicator.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Implement delta_color options | 1,538 | Avaiga/taipy | 12,680 | Python | Satoshi-Sh | Review this pull request change.
Language: Python
File: tests/gui/e2e/test_metric_indicator.py
PR Title: Implement delta_color options
BEFORE CODE: helpers.run_e2e(gui)
page.goto("./test")
page.wait_for_selector(".plot-container")
number = page.locator("//*[@class='js-plotly-plot']//*[name()='svg'][... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
relevant tasks will run even if they are skippable (see the [Task configs page](../../userman/task-orchestration/scenario-config.md#from-task-configurations) for more details).
If *validity_period* is set to None, the data node is always up-to-date.
**properties (dict[str, an... | No issues found. | relevant tasks will run even if they are skippable (see the [Task configs page](../../userman/task-orchestration/scenario-config.md#from-task-configurations) for more details).
If *validity_period* is set to None, the data node is always up-to-date.
**properties (dict[str, an... | @@ -271,14 +271,13 @@ class Config:
The default value is `Scope.SCENARIO`.
validity_period (Optional[timedelta]): The duration since the last edit date for which the data node can be
considered up-to-date. Once the validity period has passed, the data node is considered st... | taipy/config/config.pyi | 0 | Python | 1 | none | 16 | 51 | 51 | true | filter with non identifier property names | 1,551 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: taipy/config/config.pyi
PR Title: filter with non identifier property names
BEFORE CODE: relevant tasks will run even if they are skippable (see the [Task configs page](../../userman/task-orchestration/scenario-config.md#from-task-configuration... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import os
import sys
from importlib.util import find_spec
from taipy._cli._base_cli._taipy_parser import _TaipyParser
from taipy.core._core_cli import _CoreCLI
from taipy.core._entity._migrate_cli import _MigrateCLI
from taipy.core._version._cli._version_cli import _VersionCLI
from taipy.gui._gui_cli import _GuiCLI
f... | No issues found. | import os
import sys
from importlib.util import find_spec
from taipy._cli._base_cli._taipy_parser import _TaipyParser
from taipy.core._core_cli import _CoreCLI
from taipy.core._entity._migrate_cli import _MigrateCLI
from taipy.core._version._cli._version_cli import _VersionCLI
from taipy.gui._gui_cli import _GuiCLI
f... | @@ -19,9 +19,9 @@
from taipy.core._version._cli._version_cli import _VersionCLI
from taipy.gui._gui_cli import _GuiCLI
+from ._cli._create_cli import _CreateCLI
from ._cli._help_cli import _HelpCLI
from ._cli._run_cli import _RunCLI
-from ._cli._scaffold_cli import _ScaffoldCLI
from .version import _get_version
... | taipy/_entrypoint.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Refactor/#1472 - Update create cli command | 1,556 | Avaiga/taipy | 12,680 | Python | trgiangdo | Review this pull request change.
Language: Python
File: taipy/_entrypoint.py
PR Title: Refactor/#1472 - Update create cli command
BEFORE CODE: import os
import sys
from importlib.util import find_spec
from taipy._cli._base_cli._taipy_parser import _TaipyParser
from taipy.core._core_cli import _CoreCLI
from taipy.c... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
var_name: str,
df: pd.DataFrame,
payload: t.Dict[str, t.Any],
data_format: _DataFormat,
col_prefix: t.Optional[str] = "",
) -> t.Dict[str, t.Any]:
columns = payload.get("columns", [])
if col_prefix:
columns = [c[len(col_prefix) :] if c.startswith(c... | No issues found. | var_name: str,
df: pd.DataFrame,
payload: t.Dict[str, t.Any],
data_format: _DataFormat,
col_prefix: t.Optional[str] = "",
) -> t.Dict[str, t.Any]:
columns = payload.get("columns", [])
if col_prefix:
columns = [c[len(col_prefix) :] if c.startswith(c... | @@ -41,7 +41,17 @@ class _PandasDataAccessor(_DataAccessor):
__AGGREGATE_FUNCTIONS: t.List[str] = ["count", "sum", "mean", "median", "min", "max", "std", "first", "last"]
- def _get_dataframe(self, value: t.Any) -> t.Any:
+ def to_pandas(self, value: t.Union[pd.DataFrame, pd.Series]) -> t.Union[t.List[pd... | taipy/gui/data/pandas_data_accessor.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | still preparing for polar in enterprise | 1,583 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: taipy/gui/data/pandas_data_accessor.py
PR Title: still preparing for polar in enterprise
BEFORE CODE: var_name: str,
df: pd.DataFrame,
payload: t.Dict[str, t.Any],
data_format: _DataFormat,
col_prefix: t.Optional[str] = ... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
"on_edit": ElementProperty(PropertyType.function, f"{{{__CTX_VAR_NAME}.edit_entity}}"),
"on_submit": ElementProperty(PropertyType.function, f"{{{__CTX_VAR_NAME}.submit_entity}}"),
"on_delete": ElementProperty(PropertyType.function, f"{{{__CTX_VAR_NAME}.crud_scenario}}"),
... | No issues found. | "on_edit": ElementProperty(PropertyType.function, f"{{{__CTX_VAR_NAME}.edit_entity}}"),
"on_submit": ElementProperty(PropertyType.function, f"{{{__CTX_VAR_NAME}.submit_entity}}"),
"on_delete": ElementProperty(PropertyType.function, f"{{{__CTX_VAR_NAME}.crud_scenario}}"),
... | @@ -87,7 +87,7 @@ class _GuiCore(ElementLibrary):
},
inner_properties={
"inner_scenarios": ElementProperty(
- PropertyType.lov,
+ PropertyType.lov_no_default,
f"{{{__CTX_VAR_NAME}.get_scenarios(<tp:prop:{__SEL_SCENARIO... | taipy/gui_core/_GuiCoreLib.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Improve core selector loading | 1,594 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: taipy/gui_core/_GuiCoreLib.py
PR Title: Improve core selector loading
BEFORE CODE: "on_edit": ElementProperty(PropertyType.function, f"{{{__CTX_VAR_NAME}.edit_entity}}"),
"on_submit": ElementProperty(PropertyType.function, f"{{{... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
# specific language governing permissions and limitations under the License.
import subprocess
import sys
from ._base_cli._abstract_cli import _AbstractCLI
from ._base_cli._taipy_parser import _TaipyPa... | No issues found. | # an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
# specific language governing permissions and limitations under the License.
import subprocess
import sys
from ._base_cli._abstract_cli import _AbstractCLI
from ._base_cli._taipy_parser import _TaipyPa... | @@ -54,10 +54,13 @@ def handle_command(cls):
taipy_args = [f"--taipy-{arg[2:]}" if arg.startswith("--") else arg for arg in all_args]
- subprocess.run(
- [sys.executable, args.application_main_file, *(external_args + taipy_args)],
- stdout=sys.stdout,
- stderr=sys.st... | taipy/_cli/_run_cli.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Shutdown taipy gracefully without long traceback | 1,595 | Avaiga/taipy | 12,680 | Python | PrathamGupta06 | Review this pull request change.
Language: Python
File: taipy/_cli/_run_cli.py
PR Title: Shutdown taipy gracefully without long traceback
BEFORE CODE: # an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
# specific language governing permissions and li... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import typing as t
from taipy.logger._taipy_logger import _TaipyLogger
from .utils.singleton import _Singleton
class Hook:
method_names: t.List[str] = []
class Hooks(object, metaclass=_Singleton):
def __init__(self):
self.__hooks: t.List[Hook] = []
def _register_hook(self, hook: Hook):
... | No issues found. | import typing as t
from taipy.logger._taipy_logger import _TaipyLogger
from .utils.singleton import _Singleton
class Hook:
method_names: t.List[str] = []
class Hooks(object, metaclass=_Singleton):
def __init__(self):
self.__hooks: t.List[Hook] = []
def _register_hook(self, hook: Hook):
... | @@ -0,0 +1,40 @@
+import typing as t
+
+from taipy.logger._taipy_logger import _TaipyLogger
+
+from .utils.singleton import _Singleton
+
+
+class Hook:
+ method_names: t.List[str] = []
+
+
+class Hooks(object, metaclass=_Singleton):
+ def __init__(self):
+ self.__hooks: t.List[Hook] = []
+
+ def _regist... | taipy/gui/hook.py | 0 | Python | 1 | none | 16 | 41 | 41 | true | Feature/gui hooks | 1,599 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: Python
File: taipy/gui/hook.py
PR Title: Feature/gui hooks
BEFORE CODE: import typing as t
from taipy.logger._taipy_logger import _TaipyLogger
from .utils.singleton import _Singleton
class Hook:
method_names: t.List[str] = []
class Hooks(object, metaclass=_Single... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# task output should be locked for edition
assert sc.dn_1.edit_in_progress
assert sc.dn_2.edit_in_progress
assert sc.dn_3.edit_in_progress
# jobs are created in a specific order and are correct
assert len(jobs) == 4
# t1
job_1 = jobs[0]
assert job_1.task == sc.t_1
assert not job... | No issues found. | # task output should be locked for edition
assert sc.dn_1.edit_in_progress
assert sc.dn_2.edit_in_progress
assert sc.dn_3.edit_in_progress
# jobs are created in a specific order and are correct
assert len(jobs) == 4
# t1
job_1 = jobs[0]
assert job_1.task == sc.t_1
assert not job... | @@ -320,7 +320,7 @@ def test_submit_scenario_with_callbacks_and_force_and_wait():
assert jobs[2]._subscribers[0].__code__ == nothing.__code__
assert jobs[2]._subscribers[1].__code__ == _Orchestrator._update_submission_status.__code__
assert jobs[2]._subscribers[2].__code__ == _Orchestrator._o... | tests/core/_orchestrator/test_orchestrator__submit.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Fix/#1602 - Wait with no timeout should wait indefinitely | 1,604 | Avaiga/taipy | 12,680 | Python | trgiangdo | Review this pull request change.
Language: Python
File: tests/core/_orchestrator/test_orchestrator__submit.py
PR Title: Fix/#1602 - Wait with no timeout should wait indefinitely
BEFORE CODE: # task output should be locked for edition
assert sc.dn_1.edit_in_progress
assert sc.dn_2.edit_in_progress
as... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
is_sorted (bool): If True, sort the output list of scenarios using the sorting key.
The default value is False.
descending (bool): If True, sort the output list of scenarios in descending order.
The default value is False.
created_start_time (Optional[datetime]): The opti... | No issues found. | is_sorted (bool): If True, sort the output list of scenarios using the sorting key.
The default value is False.
descending (bool): If True, sort the output list of scenarios in descending order.
The default value is False.
created_start_time (Optional[datetime]): The opti... | @@ -45,7 +45,7 @@
from .job._job_manager_factory import _JobManagerFactory
from .job.job import Job
from .job.job_id import JobId
-from .reason import EntityIsNotSubmittableEntity, ReasonCollection
+from .reason import EntityDoesNotExist, EntityIsNotSubmittableEntity, ReasonCollection
from .scenario._scenario_manag... | taipy/core/taipy.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | feature/#1568 update boolean apis to using reason collection | 1,625 | Avaiga/taipy | 12,680 | Python | toan-quach | Review this pull request change.
Language: Python
File: taipy/core/taipy.py
PR Title: feature/#1568 update boolean apis to using reason collection
BEFORE CODE: is_sorted (bool): If True, sort the output list of scenarios using the sorting key.
The default value is False.
descending (bool... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
A custom page for external application that can be added to Taipy GUI"""
def __init__(
self,
resource_handler: ResourceHandler,
binding_variables: t.Optional[t.List[str]] = None,
metadata: t.Optional[t.Dict[str, t.Any]] = None,
**kwargs,
) -> None:
if binding... | No issues found. | A custom page for external application that can be added to Taipy GUI"""
def __init__(
self,
resource_handler: ResourceHandler,
binding_variables: t.Optional[t.List[str]] = None,
metadata: t.Optional[t.Dict[str, t.Any]] = None,
**kwargs,
) -> None:
if binding... | @@ -55,7 +55,7 @@ def get_id(self) -> str:
return self.rh_id if self.rh_id != "" else str(id(self))
@abstractmethod
- def get_resources(self, path: str, taipy_resource_path: str) -> t.Any:
+ def get_resources(self, path: str, taipy_resource_path: str, base_url: str) -> t.Any:
raise NotImp... | taipy/gui/custom/_page.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Decouple add base url support | 1,635 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: Python
File: taipy/gui/custom/_page.py
PR Title: Decouple add base url support
BEFORE CODE: A custom page for external application that can be added to Taipy GUI"""
def __init__(
self,
resource_handler: ResourceHandler,
binding_variables: t... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
assert not job_2bis.force
assert job_2bis.submit_entity_id == sc.id
assert len(job_2bis._subscribers) == 2 # _Orchestrator._update_submission_status and orchestrator._on_status_change
assert job_2bis._subscribers[1].__code__ == _Orchestrator._on_status_change.__code__
assert job_2bis._subscribers[0... | No issues found. | assert not job_2bis.force
assert job_2bis.submit_entity_id == sc.id
assert len(job_2bis._subscribers) == 2 # _Orchestrator._update_submission_status and orchestrator._on_status_change
assert job_2bis._subscribers[1].__code__ == _Orchestrator._on_status_change.__code__
assert job_2bis._subscribers[0... | @@ -10,14 +10,15 @@
# specific language governing permissions and limitations under the License.
from datetime import datetime, timedelta
+from time import sleep
from unittest import mock
import freezegun
import pytest
from taipy import Scenario, Scope, Task
from taipy.config import Config
-from taipy.core... | tests/core/_orchestrator/test_orchestrator__submit.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | feat: add execution duration as a information field in Job and Submission entities | 1,640 | Avaiga/taipy | 12,680 | Python | trgiangdo | Review this pull request change.
Language: Python
File: tests/core/_orchestrator/test_orchestrator__submit.py
PR Title: feat: add execution duration as a information field in Job and Submission entities
BEFORE CODE: assert not job_2bis.force
assert job_2bis.submit_entity_id == sc.id
assert len(job_2bis.... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
) # ["Sheet1", "Sheet2"]
path_2 = os.path.join(
pathlib.Path(__file__).parent.resolve(), "data_sample/example_2.xlsx"
) # ["Sheet1", "Sheet2", "Sheet3"]
dn = ExcelDataNode(
"foo",
Scope.SCENARIO,
properties={"default_path": path_1, "expo... | No issues found. | ) # ["Sheet1", "Sheet2"]
path_2 = os.path.join(
pathlib.Path(__file__).parent.resolve(), "data_sample/example_2.xlsx"
) # ["Sheet1", "Sheet2", "Sheet3"]
dn = ExcelDataNode(
"foo",
Scope.SCENARIO,
properties={"default_path": path_1, "expo... | @@ -94,17 +94,17 @@ def test_create(self):
assert dn.job_ids == []
assert not dn.is_ready_for_reading
assert dn.path == path
- assert dn.has_header is False
- assert dn.sheet_name == "Sheet1"
+ assert dn.properties["has_header"] is False
+ assert dn.properties["she... | tests/core/data/test_excel_data_node.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | feature/#1572 attempt to Protect scenario custom properties | 1,642 | Avaiga/taipy | 12,680 | Python | toan-quach | Review this pull request change.
Language: Python
File: tests/core/data/test_excel_data_node.py
PR Title: feature/#1572 attempt to Protect scenario custom properties
BEFORE CODE: ) # ["Sheet1", "Sheet2"]
path_2 = os.path.join(
pathlib.Path(__file__).parent.resolve(), "data_sample/exampl... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
console.info(`Error parsing color_map value (metric).\n${(e as Error).message || e}`);
}
return undefined;
}, [props.colorMap, props.max]);
const data = useMemo(() => {
const mode = props.type === "none" ? [] : ["gauge"];
showValue && mode.push("number");
del... | No issues found. | console.info(`Error parsing color_map value (metric).\n${(e as Error).message || e}`);
}
return undefined;
}, [props.colorMap, props.max]);
const data = useMemo(() => {
const mode = props.type === "none" ? [] : ["gauge"];
showValue && mode.push("number");
del... | @@ -11,62 +11,57 @@
* specific language governing permissions and limitations under the License.
*/
-import React, {CSSProperties, lazy, Suspense, useMemo} from 'react';
-import {Data, Delta, Layout} from "plotly.js";
+import React, { CSSProperties, lazy, Suspense, useMemo } from "react";
+import { Data, Delta, L... | frontend/taipy-gui/src/components/Taipy/Metric.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | metric control: Add the bar_color property | 1,645 | Avaiga/taipy | 12,680 | Python | namnguyen20999 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/Metric.tsx
PR Title: metric control: Add the bar_color property
BEFORE CODE: console.info(`Error parsing color_map value (metric).\n${(e as Error).message || e}`);
}
return undefined;
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
expected_error_message = (
"additional_data_nodes field of ScenarioConfig `new` must be populated with a list of"
" DataNodeConfig objects. Current value of property `additional_data_nodes` is ['bar']."
)
assert expected_error_message in caplog.text
assert len(Con... | No issues found. | expected_error_message = (
"additional_data_nodes field of ScenarioConfig `new` must be populated with a list of"
" DataNodeConfig objects. Current value of property `additional_data_nodes` is ['bar']."
)
assert expected_error_message in caplog.text
assert len(Con... | @@ -83,6 +83,47 @@ def test_check_if_entity_property_key_used_is_predefined(self, caplog):
)
assert expected_error_message in caplog.text
+ def test_check_if_children_id_is_used_in_properties(self, caplog):
+ config = Config._applied_config
+ Config._compile_configs()
+ input... | tests/core/config/checkers/test_scenario_config_checker.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Feature/#1566 - Check children config_id to make sure not overlapping the properties | 1,647 | Avaiga/taipy | 12,680 | Python | trgiangdo | Review this pull request change.
Language: Python
File: tests/core/config/checkers/test_scenario_config_checker.py
PR Title: Feature/#1566 - Check children config_id to make sure not overlapping the properties
BEFORE CODE: expected_error_message = (
"additional_data_nodes field of ScenarioConfig... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | No issues found. | # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | @@ -15,23 +15,23 @@
# -----------------------------------------------------------------------------------------
from taipy.gui import Gui
-# color_map = {
-# # 0-20 - Let Taipy decide
-# # 20-40 - red
-# 20: "red",
-# # 40-60 - Let Taipy decide
-# 40: None,
-# # 60-80 - blue
-# 60: "blue... | doc/gui/examples/controls/metric-color-map.py | 0 | Python | 1 | none | 16 | 38 | 38 | true | Improve content of generated pyi for the Page Builder API | 1,653 | Avaiga/taipy | 12,680 | Python | FabienLelaquais | Review this pull request change.
Language: Python
File: doc/gui/examples/controls/metric-color-map.py
PR Title: Improve content of generated pyi for the Page Builder API
BEFORE CODE: # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
dispatch(
createSendActionNameAction(id, module, props.onSubmit, {
id: scId,
sequence: label,
on_submission_change: props.onSubmissionChange,
error_id: getUpdateVar(updateScVars, "error_id... | No issues found. | dispatch(
createSendActionNameAction(id, module, props.onSubmit, {
id: scId,
sequence: label,
on_submission_change: props.onSubmissionChange,
error_id: getUpdateVar(updateScVars, "error_id... | @@ -106,7 +106,7 @@ interface SequencesRowProps {
focusName: string;
setFocusName: (name: string) => void;
notSubmittableReason: string;
- editable: boolean;
+ notEditableReason: string;
isValid: (sLabel: string, label: string) => boolean;
}
@@ -119,12 +119,12 @@ const tagsAutocompleteSx = ... | frontend/taipy/src/ScenarioViewer.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | take into account ReasonCollection | 1,654 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: TypeScript
File: frontend/taipy/src/ScenarioViewer.tsx
PR Title: take into account ReasonCollection
BEFORE CODE: dispatch(
createSendActionNameAction(id, module, props.onSubmit, {
id: scId,
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
]
),
"menu": lambda gui, control_type, attrs: _Builder(
gui=gui,
control_type=control_type,
element_name="MenuCtl",
attributes=attrs,
)
.set_attributes(
[
("active", PropertyType.dynamic_boolean, True... | No issues found. | ]
),
"menu": lambda gui, control_type, attrs: _Builder(
gui=gui,
control_type=control_type,
element_name="MenuCtl",
attributes=attrs,
)
.set_attributes(
[
("active", PropertyType.dynamic_boolean, True... | @@ -608,8 +608,11 @@ class _Factory:
.set_value_and_default(var_type=PropertyType.dynamic_number, native_type=True)
.set_attributes(
[
+ ("color", PropertyType.string),
("linear", PropertyType.boolean, False),
("show_value", PropertyType.bo... | taipy/gui/_renderers/factory.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | New Feature: Enhanced Progress Control | 1,676 | Avaiga/taipy | 12,680 | Python | namnguyen20999 | Review this pull request change.
Language: Python
File: taipy/gui/_renderers/factory.py
PR Title: New Feature: Enhanced Progress Control
BEFORE CODE: ]
),
"menu": lambda gui, control_type, attrs: _Builder(
gui=gui,
control_type=control_type,
element_na... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | No issues found. | # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | @@ -0,0 +1,23 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required b... | tests/gui/builder/test_embed_object.py | 0 | Python | 1 | none | 16 | 24 | 24 | true | Direct object passing for decimator (#1591) | 1,677 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: Python
File: tests/gui/builder/test_embed_object.py
PR Title: Direct object passing for decimator (#1591)
BEFORE CODE: # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compl... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
)
def __init__(self) -> None:
self.pages: t.List[_Page] = []
self.root_page: t.Optional[_Page] = None
self.routes: t.List[str] = []
self.partials: t.List[Partial] = []
self.partial_routes: t.List[str] = []
self.config: Config = {}
def _load(self, config: Con... | No issues found. | )
def __init__(self) -> None:
self.pages: t.List[_Page] = []
self.root_page: t.Optional[_Page] = None
self.routes: t.List[str] = []
self.partials: t.List[Partial] = []
self.partial_routes: t.List[str] = []
self.config: Config = {}
def _load(self, config: Con... | @@ -47,6 +47,7 @@
"notebook_proxy",
"notification_duration",
"port",
+ "port_auto_ranges",
"propagate",
"run_browser",
"run_in_thread",
@@ -119,6 +120,7 @@
"notebook_proxy": bool,
"notification_duration": int,
"port": t.Union[t.Literal["auto"], int],
+ ... | taipy/gui/config.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | port auto ranges (#1519) | 1,679 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: Python
File: taipy/gui/config.py
PR Title: port auto ranges (#1519)
BEFORE CODE: )
def __init__(self) -> None:
self.pages: t.List[_Page] = []
self.root_page: t.Optional[_Page] = None
self.routes: t.List[str] = []
self.partials: t.Li... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
assert isinstance(dn.read(), pd.DataFrame)
def test_raise_error_invalid_exposed_type(self):
path = os.path.join(pathlib.Path(__file__).parent.resolve(), "data_sample/example.csv")
with pytest.raises(InvalidExposedType):
CSVDataNode("foo", Scope.SCENARIO, properties={"path": path... | No issues found. | assert isinstance(dn.read(), pd.DataFrame)
def test_raise_error_invalid_exposed_type(self):
path = os.path.join(pathlib.Path(__file__).parent.resolve(), "data_sample/example.csv")
with pytest.raises(InvalidExposedType):
CSVDataNode("foo", Scope.SCENARIO, properties={"path": path... | @@ -249,6 +249,20 @@ def test_upload(self, csv_file, tmpdir_factory):
assert dn.last_edit_date > old_last_edit_date
assert dn.path == old_csv_path # The path of the dn should not change
+ def test_upload_with_upload_check_with_exception(self, csv_file, tmpdir_factory, caplog):
+ old_csv_p... | tests/core/data/test_csv_data_node.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Feature - Add try catch around the upload_checker call | 1,732 | Avaiga/taipy | 12,680 | Python | trgiangdo | Review this pull request change.
Language: Python
File: tests/core/data/test_csv_data_node.py
PR Title: Feature - Add try catch around the upload_checker call
BEFORE CODE: assert isinstance(dn.read(), pd.DataFrame)
def test_raise_error_invalid_exposed_type(self):
path = os.path.join(pathlib.Pat... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
if sid:
sids.add(sid)
if send_back_only:
return sid
return list(sids)
def __get_sids(self, client_id: str) -> t.Set[str]:
return self.__client_id_2_sid.get(client_id, set())
def __get_message_grouping(self):
return (
_getscope... | No issues found. | if sid:
sids.add(sid)
if send_back_only:
return sid
return list(sids)
def __get_sids(self, client_id: str) -> t.Set[str]:
return self.__client_id_2_sid.get(client_id, set())
def __get_message_grouping(self):
return (
_getscope... | @@ -289,7 +289,7 @@ def __init__(
of the main Python file is allowed.
env_filename (Optional[str]): An optional file from which to load application
configuration variables (see the
- [Configuration](../../userman/configuration/gui-config.md#configuring-the-g... | taipy/gui/gui.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Doc/#1007 improve doc navigability | 1,743 | Avaiga/taipy | 12,680 | Python | FlorianJacta | Review this pull request change.
Language: Python
File: taipy/gui/gui.py
PR Title: Doc/#1007 improve doc navigability
BEFORE CODE: if sid:
sids.add(sid)
if send_back_only:
return sid
return list(sids)
def __get_sids(self, client_id: str) -> t.Set[str]:
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
48.5379,
48.5843,
48.612,
48.6286,
48.6068,
48.4489,
48.6548,
18.5721,
48.3734,
17.6398,
48.5765,
48.4407,
48.2286,
],
"Lon": [
-112.835... | No issues found. | 48.5379,
48.5843,
48.612,
48.6286,
48.6068,
48.4489,
48.6548,
18.5721,
48.3734,
17.6398,
48.5765,
48.4407,
48.2286,
],
"Lon": [
-112.835... | @@ -157,13 +157,13 @@ def test_map_builder(gui: Gui, helpers):
marker = {"color": "fuchsia", "size": 4} # noqa: F841
layout = { # noqa: F841
"dragmode": "zoom",
- "mapbox": {"style": "open-street-map", "center": {"lat": 38, "lon": -90}, "zoom": 3},
+ "map": {"style": "open-street-map"... | tests/gui/builder/control/test_chart.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Chart: support click via on_click property | 1,747 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: tests/gui/builder/control/test_chart.py
PR Title: Chart: support click via on_click property
BEFORE CODE: 48.5379,
48.5843,
48.612,
48.6286,
48.6068,
48.4489,
48.6548,
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const { getByRole } = render(
<HelmetProvider>
<Pane page="page" defaultOpen="true" open={undefined as unknown as boolean} />
</HelmetProvider>
);
expect(getByRole("presentation")).toBeInTheDocument();
});
it("is disabled", async () => {
co... | No issues found. | const { getByRole } = render(
<HelmetProvider>
<Pane page="page" defaultOpen="true" open={undefined as unknown as boolean} />
</HelmetProvider>
);
expect(getByRole("presentation")).toBeInTheDocument();
});
it("is disabled", async () => {
co... | @@ -140,7 +140,7 @@ describe("Pane Component", () => {
it("dispatch a well formed message on close", async () => {
const dispatch = jest.fn();
const state: TaipyState = INITIAL_STATE;
- const { getByText } = render(
+ render(
<TaipyContext.Provider value={{ state, dispa... | frontend/taipy-gui/src/components/Taipy/Pane.spec.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | #1735 pane close button | 1,755 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/Pane.spec.tsx
PR Title: #1735 pane close button
BEFORE CODE: const { getByRole } = render(
<HelmetProvider>
<Pane page="page" defaultOpen="true" open={undefined as unknown as boole... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
if (!(variable in variableModuleData[context])) {
if (!(context in changes)) {
changes[context] = {};
}
changes[context][variable] = this._init_data[context][variable];
}
}
}
i... | No issues found. | if (!(variable in variableModuleData[context])) {
if (!(context in changes)) {
changes[context] = {};
}
changes[context][variable] = this._init_data[context][variable];
}
}
}
i... | @@ -6,18 +6,51 @@ export interface VarData {
type: string;
value: unknown;
encoded_name: string;
+ data_update: boolean;
}
+type ColumnName = string;
+
+export type RequestDataOptions = {
+ columns?: Array<ColumnName>;
+ pagekey?: string;
+ alldata?: boolean;
+ start?: number;
+ end?... | frontend/taipy-gui/base/src/dataManager.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Frontend Decouple | Expose Data Layer | 1,757 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/base/src/dataManager.ts
PR Title: Frontend Decouple | Expose Data Layer
BEFORE CODE: if (!(variable in variableModuleData[context])) {
if (!(context in changes)) {
changes[conte... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
# an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
# specific language governing p... | No issues found. | # http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
# an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
# specific language governing p... | @@ -0,0 +1,59 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required b... | doc/gui/examples/blocks/pane-as-page.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Add pane code samples | 1,759 | Avaiga/taipy | 12,680 | Python | FabienLelaquais | Review this pull request change.
Language: Python
File: doc/gui/examples/blocks/pane-as-page.py
PR Title: Add pane code samples
BEFORE CODE: # http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
# a... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
});
it("displays title to the right of progress", () => {
const { container } = render(<Progress titleAnchor="right" />);
const box = container.querySelector(".MuiBox-root");
expect(box).toHaveStyle("flex-direction: row-reverse");
});
it("displays title at the bottom of progres... | No issues found. | });
it("displays title to the right of progress", () => {
const { container } = render(<Progress titleAnchor="right" />);
const box = container.querySelector(".MuiBox-root");
expect(box).toHaveStyle("flex-direction: row-reverse");
});
it("displays title at the bottom of progres... | @@ -161,6 +161,122 @@ describe("Progress component", () => {
const circularProgressCircle = container.querySelector(".MuiCircularProgress-circle");
expect(circularProgressCircle).not.toHaveStyle("color: blue");
});
+
+ it("applies width to circular progress when width is defined as number", ()... | frontend/taipy-gui/src/components/Taipy/Progress.spec.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Adding width property to linear & circular progress | 1,797 | Avaiga/taipy | 12,680 | Python | namnguyen20999 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/Progress.spec.tsx
PR Title: Adding width property to linear & circular progress
BEFORE CODE: });
it("displays title to the right of progress", () => {
const { container } = render(<Progress titleAnch... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
' Current value of property `storage_type` is "toto".'
)
assert expected_error_message in caplog.text
orchestrator.stop()
def test_run_orchestrator_as_a_service_development_mode(self):
_OrchestratorFactory._dispatcher = None
orchestrator = Orchestrator()
... | No issues found. | ' Current value of property `storage_type` is "toto".'
)
assert expected_error_message in caplog.text
orchestrator.stop()
def test_run_orchestrator_as_a_service_development_mode(self):
_OrchestratorFactory._dispatcher = None
orchestrator = Orchestrator()
... | @@ -0,0 +1,116 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required ... | tests/core/test_orchestrator.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | feature/#1734 Recreate the Core service | 1,799 | Avaiga/taipy | 12,680 | Python | toan-quach | Review this pull request change.
Language: Python
File: tests/core/test_orchestrator.py
PR Title: feature/#1734 Recreate the Core service
BEFORE CODE: ' Current value of property `storage_type` is "toto".'
)
assert expected_error_message in caplog.text
orchestrator.stop()
de... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const input = getByLabelText("message (taipy)");
expect(input.tagName).toBe("INPUT");
});
it("uses the class", async () => {
const { getByText } = render(<Chat messages={messages} className="taipy-chat" defaultKey={valueKey} mode="raw" />);
const elt = getByText(searchMsg);
... | No issues found. | const input = getByLabelText("message (taipy)");
expect(input.tagName).toBe("INPUT");
});
it("uses the class", async () => {
const { getByText } = render(<Chat messages={messages} className="taipy-chat" defaultKey={valueKey} mode="raw" />);
const elt = getByText(searchMsg);
... | @@ -81,14 +81,15 @@ describe("Chat Component", () => {
await waitFor(() => expect(elt?.querySelector("p")).not.toBeNull());
});
it("can render pre", async () => {
- render(<Chat messages={messages} className="taipy-chat" defaultKey={valueKey} mode="pre" />);
- const elt = document.query... | frontend/taipy-gui/src/components/Taipy/Chat.spec.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | chat: add a mode specific class to the messages | 1,812 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/Chat.spec.tsx
PR Title: chat: add a mode specific class to the messages
BEFORE CODE: const input = getByLabelText("message (taipy)");
expect(input.tagName).toBe("INPUT");
});
it("uses the clas... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const onDeleteClick = useCallback(() => setFilter(idx, undefined as unknown as FilterDesc, true), [idx, setFilter]);
const onCheckClick = useCallback(() => {
const fd = getFilterDesc(columns, colId, action, val);
fd && setFilter(idx, fd);
}, [idx, setFilter, columns, colId, action, val]);
... | No issues found. |
const onDeleteClick = useCallback(() => setFilter(idx, undefined as unknown as FilterDesc, true), [idx, setFilter]);
const onCheckClick = useCallback(() => {
const fd = getFilterDesc(columns, colId, action, val);
fd && setFilter(idx, fd);
}, [idx, setFilter, columns, colId, action, val]);
... | @@ -30,7 +30,7 @@ import Tooltip from "@mui/material/Tooltip";
import { DateField, LocalizationProvider } from "@mui/x-date-pickers";
import { AdapterDateFns } from "@mui/x-date-pickers/AdapterDateFnsV3";
-import { ColumnDesc, defaultDateFormat, getsortByIndex, iconInRowSx } from "./tableUtils";
+import { ColumnDes... | frontend/taipy-gui/src/components/Taipy/TableFilter.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | table partial editable should show add and delete action if not false | 1,813 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/TableFilter.tsx
PR Title: table partial editable should show add and delete action if not false
BEFORE CODE:
const onDeleteClick = useCallback(() => setFilter(idx, undefined as unknown as FilterDesc, true), [idx... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
if cmp_datas:
cmp_hash = self.__gui._evaluate_expr(
"{"
+ f"{self.__gui._get_call_method_name('_compare_data')}"
+ f'({self.__gui._get_real_var_name(data_hash)[0]},{",".join(cmp_datas)})'
+ "}"
)
... | No issues found. | if cmp_datas:
cmp_hash = self.__gui._evaluate_expr(
"{"
+ f"{self.__gui._get_call_method_name('_compare_data')}"
+ f'({self.__gui._get_real_var_name(data_hash)[0]},{",".join(cmp_datas)})'
+ "}"
)
... | @@ -154,22 +154,22 @@ def _get_variable_hash_names(
# Bind potential function and expressions in self.attributes
for k, v in attributes.items():
val = v
- hashname = hash_names.get(k)
- if hashname is None:
+ hash_name = hash_names.get(k)
+ if h... | taipy/gui/_renderers/builder.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Table cell bool rendering | 1,825 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: taipy/gui/_renderers/builder.py
PR Title: Table cell bool rendering
BEFORE CODE: if cmp_datas:
cmp_hash = self.__gui._evaluate_expr(
"{"
+ f"{self.__gui._get_call_method_name('_compare_data')}... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software distributed under the... | No issues found. | # Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software distributed under the... | @@ -9,20 +9,25 @@
# an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
# specific language governing permissions and limitations under the License.
-"""# Taipy Core
+"""# Taipy `core` Package
+
+The Taipy `core` package is a Python library designed to ... | taipy/core/__init__.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Improve ref man | 1,827 | Avaiga/taipy | 12,680 | Python | jrobinAV | Review this pull request change.
Language: Python
File: taipy/core/__init__.py
PR Title: Improve ref man
BEFORE CODE: # Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apa... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
Reason.__init__(self, reason)
class NotGlobalScope(Reason):
"""
A data node config does not have a GLOBAL scope, which prevents specific actions from being performed.
Attributes:
config_id (str): The identifier of the config.
"""
def __init__(self, config_id: str):
Reason... | No issues found. | Reason.__init__(self, reason)
class NotGlobalScope(Reason):
"""
A data node config does not have a GLOBAL scope, which prevents specific actions from being performed.
Attributes:
config_id (str): The identifier of the config.
"""
def __init__(self, config_id: str):
Reason... | @@ -151,8 +151,9 @@ class NoFileToDownload(Reason, _DataNodeReasonMixin):
"""
def __init__(self, file_path: str, datanode_id: str):
- Reason.__init__(self, f"Path '{file_path}' from data node '{datanode_id}'"
- f" does not exist and cannot be downloaded.")
+ Reason... | taipy/core/reason/reason.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | feature/#1805 added checking if entity exists | 1,836 | Avaiga/taipy | 12,680 | Python | toan-quach | Review this pull request change.
Language: Python
File: taipy/core/reason/reason.py
PR Title: feature/#1805 added checking if entity exists
BEFORE CODE: Reason.__init__(self, reason)
class NotGlobalScope(Reason):
"""
A data node config does not have a GLOBAL scope, which prevents specific actions ... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
"Another error",
"yet\nAnother\nError",
]
job.stacktrace = fake_stacktraces
assert job.stacktrace == fake_stacktraces
def test_notification_job(task):
subscribe = MagicMock()
submission = _SubmissionManagerFactory._build_manager()._create(task.id, task._ID_PREFIX, task.config_id)
... | No issues found. | "Another error",
"yet\nAnother\nError",
]
job.stacktrace = fake_stacktraces
assert job.stacktrace == fake_stacktraces
def test_notification_job(task):
subscribe = MagicMock()
submission = _SubmissionManagerFactory._build_manager()._create(task.id, task._ID_PREFIX, task.config_id)
... | @@ -9,12 +9,13 @@
# an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
# specific language governing permissions and limitations under the License.
-from datetime import timedelta
+from datetime import datetime, timedelta
from time import sleep
from ... | tests/core/job/test_job.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Feature/#1704 - Store the status changes in a records | 1,837 | Avaiga/taipy | 12,680 | Python | trgiangdo | Review this pull request change.
Language: Python
File: tests/core/job/test_job.py
PR Title: Feature/#1704 - Store the status changes in a records
BEFORE CODE: "Another error",
"yet\nAnother\nError",
]
job.stacktrace = fake_stacktraces
assert job.stacktrace == fake_stacktraces
def tes... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | No issues found. | # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | @@ -0,0 +1,16 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required b... | taipy/gui/utils/_lambda.py | 0 | Python | 1 | none | 16 | 17 | 17 | true | manage lambdas | 1,838 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: taipy/gui/utils/_lambda.py
PR Title: manage lambdas
BEFORE CODE: # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain ... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
[page](../../userman/scenario_features/task-orchestration/scenario-config.md#from-task-configurations)
for more details).
If *validity_period* is set to None, the data node is always up-to-date.
**properties (dict[str, any]): A keyworded variable length list o... | No issues found. | [page](../../userman/scenario_features/task-orchestration/scenario-config.md#from-task-configurations)
for more details).
If *validity_period* is set to None, the data node is always up-to-date.
**properties (dict[str, any]): A keyworded variable length list o... | @@ -36,15 +36,7 @@ class Config:
The Config class provides various methods to configure the application. Each method adds
a specific section to the configuration and returns it.
- Here is a non-exhaustive list of configuration method examples:
-
- - `configure_data_node()`: Configure a... | taipy/config/config.pyi | 0 | Python | 1 | none | 16 | 51 | 51 | true | Improve config doc and remove deprecated function. | 1,839 | Avaiga/taipy | 12,680 | Python | jrobinAV | Review this pull request change.
Language: Python
File: taipy/config/config.pyi
PR Title: Improve config doc and remove deprecated function.
BEFORE CODE: [page](../../userman/scenario_features/task-orchestration/scenario-config.md#from-task-configurations)
for more details).
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
if lambda_fn is None:
return None
args = [arg.arg for arg in lambda_fn.args.args]
targets = [
comprehension.target.id # type: ignore[attr-defined]
for node in ast.walk(lambda_fn.body)
if isinstance(node, ast.ListComp)
... | No issues found. | if lambda_fn is None:
return None
args = [arg.arg for arg in lambda_fn.args.args]
targets = [
comprehension.target.id # type: ignore[attr-defined]
for node in ast.walk(lambda_fn.body)
if isinstance(node, ast.ListComp)
... | @@ -89,7 +89,9 @@ def _parse_property_key(key: str) -> str:
return key
def _is_callable(self, name: str):
- return "callable" in self._TYPES.get(name, "").lower()
+ return (
+ "callable" in self._TYPES.get(f"{parts[0]}__" if len(parts := name.split("__")) > 1 else name, "").lowe... | taipy/gui/builder/_element.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Builder: Detect indexed property as callable | 1,842 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: taipy/gui/builder/_element.py
PR Title: Builder: Detect indexed property as callable
BEFORE CODE: if lambda_fn is None:
return None
args = [arg.arg for arg in lambda_fn.args.args]
targets = [
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | No issues found. | # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | @@ -0,0 +1,37 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required b... | doc/gui/examples/controls/selector_adapter.py | 0 | Python | 1 | none | 16 | 38 | 38 | true | selector example | 1,843 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: doc/gui/examples/controls/selector_adapter.py
PR Title: selector example
BEFORE CODE: # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the Lic... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
},
("--client-url", "-H"): {
"dest": "taipy_client_url",
"metavar": "CLIENT_URL",
"nargs": "?",
"default": "",
"const": "",
"help": "Specify client url",
},
("--ngrok-token",): {
"dest": "taipy_ngrok_toke... | No issues found. | },
("--client-url", "-H"): {
"dest": "taipy_client_url",
"metavar": "CLIENT_URL",
"nargs": "?",
"default": "",
"const": "",
"help": "Specify client url",
},
("--ngrok-token",): {
"dest": "taipy_ngrok_toke... | @@ -35,6 +35,14 @@ class _GuiCLI(_AbstractCLI):
"const": "",
"help": "Specify server host",
},
+ ("--client-url", "-H"): {
+ "dest": "taipy_client_url",
+ "metavar": "CLIENT_URL",
+ "nargs": "?",
+ "default": "",
+ "const":... | taipy/gui/_gui_cli.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | add sso hooks | 1,854 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: Python
File: taipy/gui/_gui_cli.py
PR Title: add sso hooks
BEFORE CODE: },
("--client-url", "-H"): {
"dest": "taipy_client_url",
"metavar": "CLIENT_URL",
"nargs": "?",
"default": "",
"const": "",
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
_orchestrator: Optional[_AbstractOrchestrator] = None
_dispatcher: Optional[_JobDispatcher] = None
@classmethod
def _build_orchestrator(cls) -> Type[_AbstractOrchestrator]:
if cls._orchestrator:
return cls._orchestrator # type: ignore
if EnterpriseEditionUtils._using_enter... | No issues found. |
_orchestrator: Optional[_AbstractOrchestrator] = None
_dispatcher: Optional[_JobDispatcher] = None
@classmethod
def _build_orchestrator(cls) -> Type[_AbstractOrchestrator]:
if cls._orchestrator:
return cls._orchestrator # type: ignore
if EnterpriseEditionUtils._using_enter... | @@ -13,7 +13,7 @@
from taipy.config.config import Config
-from ..common._check_dependencies import _TAIPY_ENTERPRISE_MODULE, _using_enterprise
+from ..common._check_dependencies import EnterpriseEditionUtils
from ..common._utils import _load_fct
from ..exceptions.exceptions import ModeNotAvailable, OrchestratorN... | taipy/core/_orchestrator/_orchestrator_factory.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Bug/Fix failing issue on enterprise due to import manager | 1,865 | Avaiga/taipy | 12,680 | Python | toan-quach | Review this pull request change.
Language: Python
File: taipy/core/_orchestrator/_orchestrator_factory.py
PR Title: Bug/Fix failing issue on enterprise due to import manager
BEFORE CODE:
_orchestrator: Optional[_AbstractOrchestrator] = None
_dispatcher: Optional[_JobDispatcher] = None
@classmethod
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software distributed under the... | No issues found. | # Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software distributed under the... | @@ -0,0 +1,53 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required b... | tests/gui/e2e/page_scopes/test_page_load.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | add on page load (#1883) | 1,884 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: Python
File: tests/gui/e2e/page_scopes/test_page_load.py
PR Title: add on page load (#1883)
BEFORE CODE: # Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the Licens... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
_python_builtins = dir(builtins)
def _get_value_in_frame(frame: FrameType, name: str):
if not frame:
return None
if name in frame.f_locals:
return frame.f_locals.get(name)
return _get_value_in_frame(t.cast(FrameType, frame.f_back), name)
class _TransformVarToValue(ast.NodeTransformer):
... | No issues found. |
_python_builtins = dir(builtins)
def _get_value_in_frame(frame: FrameType, name: str):
if not frame:
return None
if name in frame.f_locals:
return frame.f_locals.get(name)
return _get_value_in_frame(t.cast(FrameType, frame.f_back), name)
class _TransformVarToValue(ast.NodeTransformer):
... | @@ -57,18 +57,28 @@ def __init__(self, element_name: str, lineno: int, lambdas: t.Dict[str, ast.Lamb
def visit_Call(self, node):
if getattr(node.func, "attr", None) == self.element_name:
- if self.lambdas.get(_LambdaByName._DEFAULT_NAME, None) is None:
- self.lambdas[_LambdaByN... | taipy/gui/builder/_utils.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | add context to lambda var | 1,897 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: taipy/gui/builder/_utils.py
PR Title: add context to lambda var
BEFORE CODE:
_python_builtins = dir(builtins)
def _get_value_in_frame(frame: FrameType, name: str):
if not frame:
return None
if name in frame.f_locals:
return frame.f_l... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# This file makes this directory a module on its own, mandatory for mypy.
| No issues found. | # This file makes this directory a module on its own, mandatory for mypy.
| @@ -0,0 +1 @@
+# This file makes this directory a module on its own, mandatory for mypy. | doc/gui/examples/charts/matplotlib/__init__.py | 0 | Python | 1 | none | 16 | 2 | 2 | true | Added an example on how to integrate Matplotlib | 1,930 | Avaiga/taipy | 12,680 | Python | SGCODEX | Review this pull request change.
Language: Python
File: doc/gui/examples/charts/matplotlib/__init__.py
PR Title: Added an example on how to integrate Matplotlib
BEFORE CODE: # This file makes this directory a module on its own, mandatory for mypy.
AFTER CODE: # This file makes this directory a module on its own, ... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
: null}
</Select>
<FormHelperText
error={!!form.errors.config && form.touched.config}
sx={configHelperTe... | No issues found. | : null}
</Select>
<FormHelperText
error={!!form.errors.config && form.touched.config}
sx={configHelperTe... | @@ -28,6 +28,7 @@ import InputLabel from "@mui/material/InputLabel";
import MenuItem from "@mui/material/MenuItem";
import Dialog from "@mui/material/Dialog";
import Select from "@mui/material/Select";
+import Stack from "@mui/material/Stack";
import TextField from "@mui/material/TextField";
import Typography from... | frontend/taipy/src/ScenarioSelector.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | display unsupported data in datanode with error message | 1,951 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: TypeScript
File: frontend/taipy/src/ScenarioSelector.tsx
PR Title: display unsupported data in datanode with error message
BEFORE CODE: : null}
</Select>
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
throw new Error("onReload() requires two parameters");
}
this._onReload = handler;
}
onReloadEvent(removedChanges: ModuleData) {
this.onReload && this.onReload(this, removedChanges);
}
get onWsMessage() {
return this._onWsMessage;
}
set onWsMessage(h... | No issues found. | throw new Error("onReload() requires two parameters");
}
this._onReload = handler;
}
onReloadEvent(removedChanges: ModuleData) {
this.onReload && this.onReload(this, removedChanges);
}
get onWsMessage() {
return this._onWsMessage;
}
set onWsMessage(h... | @@ -9,6 +9,7 @@ import { initSocket } from "./socket";
import { TaipyWsAdapter, WsAdapter } from "./wsAdapter";
import { WsMessageType } from "../../src/context/wsUtils";
import { getBase } from "./utils";
+import { CookieHandler } from "./cookieHandler";
export type OnInitHandler = (taipyApp: TaipyApp) => void;
... | frontend/taipy-gui/base/src/app.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | use taipy resource handler route to resolve cookies | 1,956 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/base/src/app.ts
PR Title: use taipy resource handler route to resolve cookies
BEFORE CODE: throw new Error("onReload() requires two parameters");
}
this._onReload = handler;
}
onReloadEvent(removedCha... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
scenario_id = t.cast(str, data.get(_GuiCoreContext.__PROP_ENTITY_ID))
entity = t.cast(Scenario, core_get(scenario_id))
if sequence := t.cast(str, data.get("sequence")):
entity = t.cast(Sequence, entity.sequences.get(sequence))
if not (reason := is_submitt... | No issues found. | scenario_id = t.cast(str, data.get(_GuiCoreContext.__PROP_ENTITY_ID))
entity = t.cast(Scenario, core_get(scenario_id))
if sequence := t.cast(str, data.get("sequence")):
entity = t.cast(Sequence, entity.sequences.get(sequence))
if not (reason := is_submitt... | @@ -56,7 +56,6 @@
from taipy.core.notification.notifier import Notifier
from taipy.core.reason import ReasonCollection
from taipy.core.submission.submission_status import SubmissionStatus
-from taipy.core.taipy import can_create
from taipy.gui import Gui, State
from taipy.gui._warnings import _warn
from taipy.gui... | taipy/gui_core/_context.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | nullcontext is not always good :-) | 1,972 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: taipy/gui_core/_context.py
PR Title: nullcontext is not always good :-)
BEFORE CODE: scenario_id = t.cast(str, data.get(_GuiCoreContext.__PROP_ENTITY_ID))
entity = t.cast(Scenario, core_get(scenario_id))
if sequence := t.cas... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
describe("Menu Component", () => {
it("renders", async () => {
const { getByText } = render(<Menu lov={lov} />);
const elt = getByText("Item 1");
expect(elt.tagName).toBe("SPAN");
});
it("uses the class", async () => {
const { getByText } = render(<Menu lov={lov} className="... | No issues found. | describe("Menu Component", () => {
it("renders", async () => {
const { getByText } = render(<Menu lov={lov} />);
const elt = getByText("Item 1");
expect(elt.tagName).toBe("SPAN");
});
it("uses the class", async () => {
const { getByText } = render(<Menu lov={lov} className="... | @@ -1,16 +1,3 @@
-/*
- * Copyright 2021-2024 Avaiga Private Limited
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unles... | frontend/taipy-gui/src/components/Taipy/Menu.spec.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Fix current page on menu | 1,974 | Avaiga/taipy | 12,680 | Python | namnguyen20999 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/Menu.spec.tsx
PR Title: Fix current page on menu
BEFORE CODE: describe("Menu Component", () => {
it("renders", async () => {
const { getByText } = render(<Menu lov={lov} />);
const elt = getByText... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
});
});
describe("taipyReducer function", () => {
it("should not change state for SOCKET_CONNECTED action if isSocketConnected is already true", () => {
const action = { type: Types.SocketConnected };
const initialState = { ...INITIAL_STATE, isSocketConnected: true };
const newState = t... | No issues found. | });
});
describe("taipyReducer function", () => {
it("should not change state for SOCKET_CONNECTED action if isSocketConnected is already true", () => {
const action = { type: Types.SocketConnected };
const initialState = { ...INITIAL_STATE, isSocketConnected: true };
const newState = t... | @@ -50,6 +50,7 @@ import { Socket } from "socket.io-client";
import { Dispatch } from "react";
import { parseData } from "../utils/dataFormat";
import * as wsUtils from "./wsUtils";
+import { nanoid } from 'nanoid';
jest.mock("./utils", () => ({
...jest.requireActual("./utils"),
@@ -575,34 +576,56 @@ describ... | frontend/taipy-gui/src/context/taipyReducers.spec.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | #1801 Added close a specific notification feature | 1,985 | Avaiga/taipy | 12,680 | Python | AdeshGhadage | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/context/taipyReducers.spec.ts
PR Title: #1801 Added close a specific notification feature
BEFORE CODE: });
});
describe("taipyReducer function", () => {
it("should not change state for SOCKET_CONNECTED action if isSocketCon... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
# specific language governing permissions and limitations under the License.
import time
import typing as t
from unittest.mock import MagicMock
from taipy.gui import Gui
from taipy.gui._hook import _Hoo... | No issues found. | # an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
# specific language governing permissions and limitations under the License.
import time
import typing as t
from unittest.mock import MagicMock
from taipy.gui import Gui
from taipy.gui._hook import _Hoo... | @@ -0,0 +1,66 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required b... | tests/gui/hooks/test_listener.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Support event listener through Hooks | 1,993 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: tests/gui/hooks/test_listener.py
PR Title: Support event listener through Hooks
BEFORE CODE: # an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
# specific language governing permissions and limi... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
def test_unsupported_data_converter_returns_none():
def convert(value):
return None # Simulates a failed transformation
Gui.set_unsupported_data_converter(convert)
result = Gui._convert_unsupported_data("invalid_data")
assert result is None
# Reset converter
Gui.set_unsupported_data_... | No issues found. | def test_unsupported_data_converter_returns_none():
def convert(value):
return None # Simulates a failed transformation
Gui.set_unsupported_data_converter(convert)
result = Gui._convert_unsupported_data("invalid_data")
assert result is None
# Reset converter
Gui.set_unsupported_data_... | @@ -0,0 +1,73 @@
+import logging
+
+import pytest
+
+from taipy.gui import Gui
+
+
+def test_handle_invalid_data_no_callback():
+ result = Gui._convert_unsupported_data("invalid_data")
+ assert result is None
+
+
+def test_unsupported_data_converter_returns_none():
+ def convert(value):
+ return None #... | tests/gui/data/test_unsupported_data_converter.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Added a function to support data conversion if type is not supported by the taipy.gui.data module | 2,028 | Avaiga/taipy | 12,680 | Python | Ujj1225 | Review this pull request change.
Language: Python
File: tests/gui/data/test_unsupported_data_converter.py
PR Title: Added a function to support data conversion if type is not supported by the taipy.gui.data module
BEFORE CODE: def test_unsupported_data_converter_returns_none():
def convert(value):
retur... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
if util.find_spec("playwright"):
from playwright._impl._page import Page
from taipy.gui import Gui
@pytest.mark.teste2e
def test_input_action(page: "Page", gui: Gui, helpers):
page_md = """
<|{input1_value}|input|on_action=input_action|id=input1|>
<|{input2_value}|input|on_action=input_action|id=input2|actio... | No issues found. | if util.find_spec("playwright"):
from playwright._impl._page import Page
from taipy.gui import Gui
@pytest.mark.teste2e
def test_input_action(page: "Page", gui: Gui, helpers):
page_md = """
<|{input1_value}|input|on_action=input_action|id=input1|>
<|{input2_value}|input|on_action=input_action|id=input2|actio... | @@ -0,0 +1,83 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required b... | tests/gui/e2e/with_action/test_input.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Input control validation on focus out event | 2,036 | Avaiga/taipy | 12,680 | Python | kart2004 | Review this pull request change.
Language: Python
File: tests/gui/e2e/with_action/test_input.py
PR Title: Input control validation on focus out event
BEFORE CODE: if util.find_spec("playwright"):
from playwright._impl._page import Page
from taipy.gui import Gui
@pytest.mark.teste2e
def test_input_action(page... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
entity_id: The entity id, i.e., its primary key.
Returns:
An entity.
"""
raise NotImplementedError
@abstractmethod
def _load_all(self, filters: Optional[List[Dict]] = None) -> List[Entity]:
"""
Retrieve all the entities' data from the repository ... | No issues found. | entity_id: The entity id, i.e., its primary key.
Returns:
An entity.
"""
raise NotImplementedError
@abstractmethod
def _load_all(self, filters: Optional[List[Dict]] = None) -> List[Entity]:
"""
Retrieve all the entities' data from the repository ... | @@ -27,7 +27,7 @@ def _save(self, entity: Entity):
"""
Save an entity in the repository.
- Parameters:
+ Arguments:
entity: The data from an object.
"""
raise NotImplementedError
@@ -36,7 +36,7 @@ def _save(self, entity: Entity):
def _exists(self, en... | taipy/core/_repository/_abstract_repository.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Refactor terminology: Updated 'Parameters' and 'Args' to 'Arguments' for consistency across the codebase. | 2,046 | Avaiga/taipy | 12,680 | Python | DevyManish | Review this pull request change.
Language: Python
File: taipy/core/_repository/_abstract_repository.py
PR Title: Refactor terminology: Updated 'Parameters' and 'Args' to 'Arguments' for consistency across the codebase.
BEFORE CODE: entity_id: The entity id, i.e., its primary key.
Returns:
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | No issues found. | # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | @@ -0,0 +1,46 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required b... | doc/gui/examples/controls/chat_messages.py | 0 | Python | 1 | none | 16 | 47 | 47 | true | Implemented image upload on Chat | 2,078 | Avaiga/taipy | 12,680 | Python | Satoshi-Sh | Review this pull request change.
Language: Python
File: doc/gui/examples/controls/chat_messages.py
PR Title: Implemented image upload on Chat
BEFORE CODE: # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance w... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
"filters": [{"col": "name", "action": "==", "value": ""}],
}
value = accessor.get_data("x", pd, query, _DataFormat.JSON)
assert len(value["value"]["data"]) == 0
query = {
"columns": ["name", "value"],
"start": 0,
"end": -1,
"filters": [{"col": "name", "action": "... | No issues found. | "filters": [{"col": "name", "action": "==", "value": ""}],
}
value = accessor.get_data("x", pd, query, _DataFormat.JSON)
assert len(value["value"]["data"]) == 0
query = {
"columns": ["name", "value"],
"start": 0,
"end": -1,
"filters": [{"col": "name", "action": "... | @@ -13,8 +13,11 @@
import os
from datetime import datetime
from importlib import util
+from unittest.mock import Mock
import pandas
+import pandas as pd
+import pytest
from flask import g
from taipy.gui import Gui
@@ -23,6 +26,26 @@
from taipy.gui.data.pandas_data_accessor import _PandasDataAccessor
+# D... | tests/gui/data/test_pandas_data_accessor.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | #426 case insensitive filtering | 2,087 | Avaiga/taipy | 12,680 | Python | Rishi-0007 | Review this pull request change.
Language: Python
File: tests/gui/data/test_pandas_data_accessor.py
PR Title: #426 case insensitive filtering
BEFORE CODE: "filters": [{"col": "name", "action": "==", "value": ""}],
}
value = accessor.get_data("x", pd, query, _DataFormat.JSON)
assert len(value["va... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
gui = Gui("")
ms = MockState(gui, a=1)
assert ms is not None
assert ms.a == 1
assert ms.b is None
def test_read_context():
ms = MockState(Gui(""), a=1)
assert ms["b"] is not None
assert ms["b"].a == 1
def test_write_attr():
ms = MockState(Gui(""), a=1)
ms.a = 2
assert ms.... | No issues found. | gui = Gui("")
ms = MockState(gui, a=1)
assert ms is not None
assert ms.a == 1
assert ms.b is None
def test_read_context():
ms = MockState(Gui(""), a=1)
assert ms["b"] is not None
assert ms["b"].a == 1
def test_write_attr():
ms = MockState(Gui(""), a=1)
ms.a = 2
assert ms.... | @@ -0,0 +1,102 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required ... | tests/gui/mock/test_mock_state.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Adding a mock State class that can be instantiated and queried while testing | 2,101 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: tests/gui/mock/test_mock_state.py
PR Title: Adding a mock State class that can be instantiated and queried while testing
BEFORE CODE: gui = Gui("")
ms = MockState(gui, a=1)
assert ms is not None
assert ms.a == 1
assert ms.b is None
def te... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
"<DateSelector",
'defaultDate="2020-12-',
'updateVarName="_TpDt_tpec_TpExPr_date_TPMDL_0"',
"date={_TpDt_tpec_TpExPr_date_TPMDL_0}",
]
helpers.test_control_md(gui, md_string, expected_list)
def test_date_md_2(gui: Gui, test_client, helpers):
gui._bind_var_val("date", dateti... | No issues found. | "<DateSelector",
'defaultDate="2020-12-',
'updateVarName="_TpDt_tpec_TpExPr_date_TPMDL_0"',
"date={_TpDt_tpec_TpExPr_date_TPMDL_0}",
]
helpers.test_control_md(gui, md_string, expected_list)
def test_date_md_2(gui: Gui, test_client, helpers):
gui._bind_var_val("date", dateti... | @@ -39,6 +39,19 @@ def test_date_md_2(gui: Gui, test_client, helpers):
]
helpers.test_control_md(gui, md_string, expected_list)
+def test_date_md_3(gui: Gui, test_client, helpers):
+ gui._bind_var_val("date", datetime.strptime("15 Dec 2020", "%d %b %Y"))
+ md_string = "<|{date}|date|with_time|analogic... | tests/gui/control/test_date.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Analogic for date component | 2,115 | Avaiga/taipy | 12,680 | Python | Tryxns | Review this pull request change.
Language: Python
File: tests/gui/control/test_date.py
PR Title: Analogic for date component
BEFORE CODE: "<DateSelector",
'defaultDate="2020-12-',
'updateVarName="_TpDt_tpec_TpExPr_date_TPMDL_0"',
"date={_TpDt_tpec_TpExPr_date_TPMDL_0}",
]
hel... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
def test_date_range_md_2(gui: Gui, test_client, helpers):
gui._bind_var_val(
"dates", [datetime.strptime("15 Dec 2020", "%d %b %Y"), datetime.strptime("31 Dec 2020", "%d %b %Y")]
)
md_string = "<|{dates}|date_range|with_time|label_start=start|label_end=end|>"
expected_list = [
"<DateRa... | No issues found. |
def test_date_range_md_2(gui: Gui, test_client, helpers):
gui._bind_var_val(
"dates", [datetime.strptime("15 Dec 2020", "%d %b %Y"), datetime.strptime("31 Dec 2020", "%d %b %Y")]
)
md_string = "<|{dates}|date_range|with_time|label_start=start|label_end=end|>"
expected_list = [
"<DateRa... | @@ -44,6 +44,22 @@ def test_date_range_md_2(gui: Gui, test_client, helpers):
]
helpers.test_control_md(gui, md_string, expected_list)
+def test_date_range_md_3(gui: Gui, test_client, helpers):
+ gui._bind_var_val(
+ "dates", [datetime.strptime("15 Dec 2020", "%d %b %Y"), datetime.strptime("31 Dec ... | tests/gui/control/test_date_range.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Analogic for daterange | 2,116 | Avaiga/taipy | 12,680 | Python | Tryxns | Review this pull request change.
Language: Python
File: tests/gui/control/test_date_range.py
PR Title: Analogic for daterange
BEFORE CODE:
def test_date_range_md_2(gui: Gui, test_client, helpers):
gui._bind_var_val(
"dates", [datetime.strptime("15 Dec 2020", "%d %b %Y"), datetime.strptime("31 Dec 2020... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
gui.run(run_server=False)
assert gui._config.config.get("host") == "127.0.0.1"
def test_cli_host_1(gui: Gui):
with patch("sys.argv", ["prog", "--host", "localhost"]):
gui.run(run_server=False)
assert gui._config.config.get("host") == "localhost"
def test_cli_host_2(gui: Gui):
... | No issues found. | gui.run(run_server=False)
assert gui._config.config.get("host") == "127.0.0.1"
def test_cli_host_1(gui: Gui):
with patch("sys.argv", ["prog", "--host", "localhost"]):
gui.run(run_server=False)
assert gui._config.config.get("host") == "localhost"
def test_cli_host_2(gui: Gui):
... | @@ -80,6 +80,30 @@ def test_taipy_no_reload(gui: Gui):
assert gui._config.config.get("use_reloader") is False
+def test_taipy_run_browser(gui: Gui):
+ with patch("sys.argv", ["prog", "--run-browser"]):
+ gui.run(run_server=False, use_reloader=False)
+ assert gui._config.config.get("run_bro... | tests/gui/gui_specific/test_cli.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Add command line options for run_browser and dark_mode Gui.run() parameters | 2,128 | Avaiga/taipy | 12,680 | Python | FabienLelaquais | Review this pull request change.
Language: Python
File: tests/gui/gui_specific/test_cli.py
PR Title: Add command line options for run_browser and dark_mode Gui.run() parameters
BEFORE CODE: gui.run(run_server=False)
assert gui._config.config.get("host") == "127.0.0.1"
def test_cli_host_1(gui: Gui)... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
entity = self._get_manager(manager)._get(obj, obj)
if obj._is_in_context and hasattr(entity, "_properties"):
if obj._properties._pending_changes:
entity._properties._pending_changes = obj._properties._pending_changes
if obj._properties._pending_deletions:
... | No issues found. | entity = self._get_manager(manager)._get(obj, obj)
if obj._is_in_context and hasattr(entity, "_properties"):
if obj._properties._pending_changes:
entity._properties._pending_changes = obj._properties._pending_changes
if obj._properties._pending_deletions:
... | @@ -10,28 +10,33 @@
# specific language governing permissions and limitations under the License.
import functools
+from typing import Dict, Type
from .._manager._manager import _Manager
+from ..common._check_dependencies import EnterpriseEditionUtils
+from ..common._utils import _load_fct
from ..notification im... | taipy/core/_entity/_reload.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Refactor - Expand Event and _get_manager() method | 2,137 | Avaiga/taipy | 12,680 | Python | trgiangdo | Review this pull request change.
Language: Python
File: taipy/core/_entity/_reload.py
PR Title: Refactor - Expand Event and _get_manager() method
BEFORE CODE: entity = self._get_manager(manager)._get(obj, obj)
if obj._is_in_context and hasattr(entity, "_properties"):
if obj._properties._... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
def bump_ext_version(self) -> None:
if not self.ext:
return
reg = re.compile(r"[0-9]+$")
num = reg.findall(self.ext)[0]
self.ext = self.ext.replace(num, str(int(num) + 1))
def validate_suffix(self, suffix="dev"):
if suffix not in self.ext:
raise... | No issues found. |
def bump_ext_version(self) -> None:
if not self.ext:
return
reg = re.compile(r"[0-9]+$")
num = reg.findall(self.ext)[0]
self.ext = self.ext.replace(num, str(int(num) + 1))
def validate_suffix(self, suffix="dev"):
if suffix not in self.ext:
raise... | @@ -0,0 +1,97 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required b... | tools/release/bump_version.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Modify Release Action to Bump development versions and create a PR | 2,139 | Avaiga/taipy | 12,680 | Python | joaoandre-avaiga | Review this pull request change.
Language: Python
File: tools/release/bump_version.py
PR Title: Modify Release Action to Bump development versions and create a PR
BEFORE CODE:
def bump_ext_version(self) -> None:
if not self.ext:
return
reg = re.compile(r"[0-9]+$")
num = reg.... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software distributed under the... | No issues found. | # Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software distributed under the... | @@ -0,0 +1,53 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required b... | tests/gui/control/test_metric.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Metric: Add support for None | 2,147 | Avaiga/taipy | 12,680 | Python | codingis4noobs2 | Review this pull request change.
Language: Python
File: tests/gui/control/test_metric.py
PR Title: Metric: Add support for None
BEFORE CODE: # Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | No issues found. | # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agree... | @@ -0,0 +1,23 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required b... | doc/gui/examples/controls/button_size.py | 0 | Python | 1 | none | 16 | 24 | 24 | true | added more mui classes for buttons | 2,159 | Avaiga/taipy | 12,680 | Python | JeevaRamanathan | Review this pull request change.
Language: Python
File: doc/gui/examples/controls/button_size.py
PR Title: added more mui classes for buttons
BEFORE CODE: # Copyright 2021-2024 Avaiga Private Limited
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance w... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
case "success":
return <CheckCircleIcon {...iconProps} />;
case "warning":
return <WarningIcon {...iconProps} />;
case "error":
return <ErrorIcon {...iconProps} />;
default:
re... | No issues found. | case "success":
return <CheckCircleIcon {...iconProps} />;
case "warning":
return <WarningIcon {...iconProps} />;
case "error":
return <ErrorIcon {...iconProps} />;
default:
re... | @@ -11,9 +11,13 @@
* specific language governing permissions and limitations under the License.
*/
-import React, { MouseEvent, ReactNode, useMemo } from "react";
+import React, { MouseEvent, ReactNode, useEffect, useMemo, useRef} from "react";
import Chip from "@mui/material/Chip";
import Avatar from "@mui/mat... | frontend/taipy-gui/src/components/Taipy/Status.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feat: Status controls could have a way to have icons instead of the default letters | 2,177 | Avaiga/taipy | 12,680 | Python | Vaibhav91one | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/Status.tsx
PR Title: feat: Status controls could have a way to have icons instead of the default letters
BEFORE CODE: case "success":
return <CheckCircleIcon {...iconProps} />;
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import matplotlib.pyplot as plt
from taipy.gui import Gui, Markdown
# Generate a scatter plot
x = [1, 2, 3, 4, 5] # x axis values
y = [10, 14, 12, 15, 18] # y axis values
sizes = [100, 100, 100, 100, 100] # Bubble sizes
colors = [30, 40, 50, 60, 70] # Bubble color values that will be mapped to shades of colormap (... | No issues found. | import matplotlib.pyplot as plt
from taipy.gui import Gui, Markdown
# Generate a scatter plot
x = [1, 2, 3, 4, 5] # x axis values
y = [10, 14, 12, 15, 18] # y axis values
sizes = [100, 100, 100, 100, 100] # Bubble sizes
colors = [30, 40, 50, 60, 70] # Bubble color values that will be mapped to shades of colormap (... | @@ -0,0 +1,83 @@
+# Copyright 2021-2024 Avaiga Private Limited
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required b... | doc/gui/examples/charts/matplotlib/image.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Issue #558 add matplotlib example | 2,179 | Avaiga/taipy | 12,680 | Python | AbisoyeOnanuga | Review this pull request change.
Language: Python
File: doc/gui/examples/charts/matplotlib/image.py
PR Title: Issue #558 add matplotlib example
BEFORE CODE: import matplotlib.pyplot as plt
from taipy.gui import Gui, Markdown
# Generate a scatter plot
x = [1, 2, 3, 4, 5] # x axis values
y = [10, 14, 12, 15, 18] #... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const pageKey = "no-page-key";
const GameTable = (props: GameTableProps) => {
const { data, updateVarName = "", updateVars = "", id } = props;
const [value, setValue] = useState<Record<string, Array<RowValue>>>({});
const dispatch = useDispatch();
const module = useModule();
const refresh = data?.... | No issues found. |
const pageKey = "no-page-key";
const GameTable = (props: GameTableProps) => {
const { data, updateVarName = "", updateVars = "", id } = props;
const [value, setValue] = useState<Record<string, Array<RowValue>>>({});
const dispatch = useDispatch();
const module = useModule();
const refresh = data?.... | @@ -0,0 +1,80 @@
+import React, { useEffect, useMemo, useState } from "react";
+import {
+ createRequestDataUpdateAction,
+ useDispatch,
+ useDispatchRequestUpdateOnFirstRender,
+ useModule,
+ TaipyDynamicProps,
+ TableValueType,
+ RowType,
+ RowValue,
+} from "taipy-gui";
+
+interface GameTable... | doc/gui/extension/example_library/front-end/src/GameTable.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Example for tabular data | 2,184 | Avaiga/taipy | 12,680 | Python | namnguyen20999 | Review this pull request change.
Language: TypeScript
File: doc/gui/extension/example_library/front-end/src/GameTable.tsx
PR Title: Example for tabular data
BEFORE CODE:
const pageKey = "no-page-key";
const GameTable = (props: GameTableProps) => {
const { data, updateVarName = "", updateVars = "", id } = prop... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
def _set_context(self, gui: "Gui") -> t.ContextManager[None]:
return nullcontext()
def broadcast(self, name: str, value: t.Any):
"""Update a variable on all clients.
All connected clients will receive an update of the variable called *name* with the
provided value, even if it ... | No issues found. |
def _set_context(self, gui: "Gui") -> t.ContextManager[None]:
return nullcontext()
def broadcast(self, name: str, value: t.Any):
"""Update a variable on all clients.
All connected clients will receive an update of the variable called *name* with the
provided value, even if it ... | @@ -11,11 +11,11 @@
import inspect
import typing as t
-from abc import ABC, abstractmethod
+from abc import abstractmethod
from contextlib import nullcontext
from operator import attrgetter
from pathlib import Path
-from types import FrameType
+from types import FrameType, SimpleNamespace
from flask import ha... | taipy/gui/state.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | file_selector example | 2,194 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: taipy/gui/state.py
PR Title: file_selector example
BEFORE CODE:
def _set_context(self, gui: "Gui") -> t.ContextManager[None]:
return nullcontext()
def broadcast(self, name: str, value: t.Any):
"""Update a variable on all clients.
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
files: [file],
},
});
// Dispatch the mock event
fireEvent(elt, mockEvent);
expect(uploadFile).toHaveBeenCalledTimes(1);
});
it("resets dropLabel and dropSx on drag leave", async () => {
const { getByRole } = render(<FileSelector />);
... | No issues found. | files: [file],
},
});
// Dispatch the mock event
fireEvent(elt, mockEvent);
expect(uploadFile).toHaveBeenCalledTimes(1);
});
it("resets dropLabel and dropSx on drag leave", async () => {
const { getByRole } = render(<FileSelector />);
... | @@ -21,6 +21,7 @@ import { TaipyContext } from "../../context/taipyContext";
import { TaipyState, INITIAL_STATE } from "../../context/taipyReducers";
import { uploadFile } from "../../workers/fileupload";
+
jest.mock("../../workers/fileupload", () => ({
uploadFile: jest.fn().mockResolvedValue("mocked response... | frontend/taipy-gui/src/components/Taipy/FileSelector.spec.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | New feature implementation/#2189 Add support for uploading nested folders | 2,206 | Avaiga/taipy | 12,680 | Python | JosuaCarl | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/FileSelector.spec.tsx
PR Title: New feature implementation/#2189 Add support for uploading nested folders
BEFORE CODE: files: [file],
},
});
// Dispatch the mock event
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const labels = getAllByText("Number");
expect(labels).toHaveLength(2);
const input = labels[0].nextElementSibling?.firstElementChild || labels[0];
await userEvent.click(input);
await userEvent.keyboard("10");
expect(validate).not.toBeDisabled();
});
it("behaves on... | No issues found. | const labels = getAllByText("Number");
expect(labels).toHaveLength(2);
const input = labels[0].nextElementSibling?.firstElementChild || labels[0];
await userEvent.click(input);
await userEvent.keyboard("10");
expect(validate).not.toBeDisabled();
});
it("behaves on... | @@ -70,8 +70,8 @@ describe("Table Filter Component", () => {
expect(getAllByText("Column")).toHaveLength(2);
expect(getAllByText("Action")).toHaveLength(2);
expect(getAllByText("Empty String")).toHaveLength(2);
- const dropdownElts = getAllByTestId("ArrowDropDownIcon");
- expect... | frontend/taipy-gui/src/components/Taipy/TableFilter.spec.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | case sensitive icon in filter | 2,216 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/TableFilter.spec.tsx
PR Title: case sensitive icon in filter
BEFORE CODE: const labels = getAllByText("Number");
expect(labels).toHaveLength(2);
const input = labels[0].nextElementSibling?.fir... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
navigateForce: (action as unknown as TaipyNavigateAction).force,
};
case Types.ClientId:
const id = (action as unknown as TaipyIdAction).id;
storeClientId(id);
return { ...state, id: id };
case Types.Acknowledgement:
const ackLi... | No issues found. | navigateForce: (action as unknown as TaipyNavigateAction).force,
};
case Types.ClientId:
const id = (action as unknown as TaipyIdAction).id;
storeClientId(id);
return { ...state, id: id };
case Types.Acknowledgement:
const ackLi... | @@ -16,7 +16,7 @@ import { createTheme, Theme } from "@mui/material/styles";
import merge from "lodash/merge";
import { Dispatch } from "react";
import { io, Socket } from "socket.io-client";
-import { nanoid } from 'nanoid';
+import { nanoid } from "nanoid";
import { FilterDesc } from "../components/Taipy/tableU... | frontend/taipy-gui/src/context/taipyReducers.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | get localstorage support (#2190) | 2,234 | Avaiga/taipy | 12,680 | Python | dinhlongviolin1 | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/context/taipyReducers.ts
PR Title: get localstorage support (#2190)
BEFORE CODE: navigateForce: (action as unknown as TaipyNavigateAction).force,
};
case Types.ClientId:
const id = (act... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
showSearch,
} = props;
const [selectedItems, setSelectedItems] = useState<string[]>([]);
const [pins, setPins] = useState<[Pinned, Pinned]>([{}, {}]);
const [hideNonPinned, setShowPinned] = useState(false);
const [expandedItems, setExpandedItems] = useState<string[]>([]);
const active ... | No issues found. | showSearch,
} = props;
const [selectedItems, setSelectedItems] = useState<string[]>([]);
const [pins, setPins] = useState<[Pinned, Pinned]>([{}, {}]);
const [hideNonPinned, setShowPinned] = useState(false);
const [expandedItems, setExpandedItems] = useState<string[]>([]);
const active ... | @@ -137,19 +137,19 @@ const CoreItem = (props: {
return !props.displayCycles && nodeType === NodeType.CYCLE ? (
<>
{items
- ? items.filter(v=>v).map((item) => (
- <CoreItem
- key={item[0]}
- item={item}
- ... | frontend/taipy/src/CoreSelector.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Better UI for Core selector elements | 2,237 | Avaiga/taipy | 12,680 | Python | FabienLelaquais | Review this pull request change.
Language: TypeScript
File: frontend/taipy/src/CoreSelector.tsx
PR Title: Better UI for Core selector elements
BEFORE CODE: showSearch,
} = props;
const [selectedItems, setSelectedItems] = useState<string[]>([]);
const [pins, setPins] = useState<[Pinned, Pinned]>... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
assert dn_1_2.is_up_to_date
assert dn_2_2.is_up_to_date
assert not dn_3.is_up_to_date
dn_1_2.last_edit_date = current_datetime + timedelta(6)
assert dn_1_1.is_up_to_date
assert not dn_2_1.is_up_to_date
assert dn_1_2.is_up_to_date
assert not dn_2_2.is_up_t... | No issues found. | assert dn_1_2.is_up_to_date
assert dn_2_2.is_up_to_date
assert not dn_3.is_up_to_date
dn_1_2.last_edit_date = current_datetime + timedelta(6)
assert dn_1_1.is_up_to_date
assert not dn_2_1.is_up_to_date
assert dn_1_2.is_up_to_date
assert not dn_2_2.is_up_t... | @@ -23,7 +23,13 @@
from taipy.core.data._data_manager import _DataManager
from taipy.core.data._data_manager_factory import _DataManagerFactory
from taipy.core.data.data_node import DataNode
-from taipy.core.data.data_node_id import DataNodeId
+from taipy.core.data.data_node_id import (
+ EDIT_COMMENT_KEY,
+ E... | tests/core/data/test_data_node.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | CLean parameters for the datanode track_edit method. | 2,240 | Avaiga/taipy | 12,680 | Python | jrobinAV | Review this pull request change.
Language: Python
File: tests/core/data/test_data_node.py
PR Title: CLean parameters for the datanode track_edit method.
BEFORE CODE: assert dn_1_2.is_up_to_date
assert dn_2_2.is_up_to_date
assert not dn_3.is_up_to_date
dn_1_2.last_edit_date = current... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import React, { useMemo } from "react";
import { LoV, useLovListMemo } from "taipy-gui";
interface VisualLabelListProps {
lov?: LoV;
defaultLov?: string;
sort?: "asc" | "desc";
}
const styles = {
listItem: {
display: "flex",
alignItems: "center",
},
image: {
marginRight... | No issues found. | import React, { useMemo } from "react";
import { LoV, useLovListMemo } from "taipy-gui";
interface VisualLabelListProps {
lov?: LoV;
defaultLov?: string;
sort?: "asc" | "desc";
}
const styles = {
listItem: {
display: "flex",
alignItems: "center",
},
image: {
marginRight... | @@ -0,0 +1,50 @@
+import React, { useMemo } from "react";
+import { LoV, useLovListMemo } from "taipy-gui";
+
+interface VisualLabelListProps {
+ lov?: LoV;
+ defaultLov?: string;
+ sort?: "asc" | "desc";
+}
+
+const styles = {
+ listItem: {
+ display: "flex",
+ alignItems: "center",
+ },
+... | doc/gui/extension/example_library/front-end/src/VisualLabelList.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Example for list of value | 2,249 | Avaiga/taipy | 12,680 | Python | namnguyen20999 | Review this pull request change.
Language: TypeScript
File: doc/gui/extension/example_library/front-end/src/VisualLabelList.tsx
PR Title: Example for list of value
BEFORE CODE: import React, { useMemo } from "react";
import { LoV, useLovListMemo } from "taipy-gui";
interface VisualLabelListProps {
lov?: LoV;
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
# only variables in the main module with be taken into account
if module_name is not None and module_name != gui._get_default_module_name():
continue
if var_name in self.__shared_variable:
self.__shared_variable.append(expr_hash)
return expr_ha... | No issues found. | # only variables in the main module with be taken into account
if module_name is not None and module_name != gui._get_default_module_name():
continue
if var_name in self.__shared_variable:
self.__shared_variable.append(expr_hash)
return expr_ha... | @@ -256,6 +256,8 @@ def evaluate_expr(
# evaluate expressions
ctx: t.Dict[str, t.Any] = {}
ctx.update(self.__global_ctx)
+ if lambda_expr:
+ ctx.update(gui._get_locals_bind())
# entries in var_val are not always seen (NameError) when passed a... | taipy/gui/utils/_evaluator.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | add current scope variables when evaluating an expression | 2,250 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: Python
File: taipy/gui/utils/_evaluator.py
PR Title: add current scope variables when evaluating an expression
BEFORE CODE: # only variables in the main module with be taken into account
if module_name is not None and module_name != gui._get_default... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
// Use useMemo to memoize the iconProps as well
const color = status2Color(status);
// Memoize the iconProps
const iconProps = {
sx: { fontSize: 20, color: `${color}.main` },
};
if (icon) {
switch (color) {
case "success":
return <CheckCircleIcon {..... | No issues found. | // Use useMemo to memoize the iconProps as well
const color = status2Color(status);
// Memoize the iconProps
const iconProps = {
sx: { fontSize: 20, color: `${color}.main` },
};
if (icon) {
switch (color) {
case "success":
return <CheckCircleIcon {..... | @@ -11,7 +11,7 @@
* specific language governing permissions and limitations under the License.
*/
-import React, { MouseEvent, ReactNode, useEffect, useMemo, useRef} from "react";
+import React, { MouseEvent, ReactNode, useEffect, useMemo, useRef } from "react";
import Chip from "@mui/material/Chip";
import Ava... | frontend/taipy-gui/src/components/Taipy/Status.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | handle icons for status | 2,264 | Avaiga/taipy | 12,680 | Python | FredLL-Avaiga | Review this pull request change.
Language: TypeScript
File: frontend/taipy-gui/src/components/Taipy/Status.tsx
PR Title: handle icons for status
BEFORE CODE: // Use useMemo to memoize the iconProps as well
const color = status2Color(status);
// Memoize the iconProps
const iconProps = {
sx: ... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
properties = cls.__serialize_sql_dn_properties(properties)
if data_node.storage_type() == MongoCollectionDataNode.storage_type():
properties = cls.__serialize_mongo_collection_dn_model_properties(properties)
if cls._EXPOSED_TYPE_KEY in properties.keys():
properties ... | No issues found. | properties = cls.__serialize_sql_dn_properties(properties)
if data_node.storage_type() == MongoCollectionDataNode.storage_type():
properties = cls.__serialize_mongo_collection_dn_model_properties(properties)
if cls._EXPOSED_TYPE_KEY in properties.keys():
properties ... | @@ -12,6 +12,7 @@
from copy import copy
from datetime import datetime, timedelta
from pydoc import locate
+from typing import Dict
from .._repository._abstract_converter import _AbstractConverter
from ..common._utils import _load_fct
@@ -120,14 +121,13 @@ def __serialize_exposed_type(properties: dict, exposed_ty... | taipy/core/data/_data_converter.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | Feature/#521 refactor code for databricks integration | 2,284 | Avaiga/taipy | 12,680 | Python | toan-quach | Review this pull request change.
Language: Python
File: taipy/core/data/_data_converter.py
PR Title: Feature/#521 refactor code for databricks integration
BEFORE CODE: properties = cls.__serialize_sql_dn_properties(properties)
if data_node.storage_type() == MongoCollectionDataNode.storage_type(... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
engine: Optional[str] = None,
compression: Optional[str] = None,
read_kwargs: Optional[Dict] = None,
write_kwargs: Optional[Dict] = None,
exposed_type: Optional[str] = None,
scope: Optional[Scope] = None,
validity_period: Optional[timedelta] = None,
**prop... | No issues found. | engine: Optional[str] = None,
compression: Optional[str] = None,
read_kwargs: Optional[Dict] = None,
write_kwargs: Optional[Dict] = None,
exposed_type: Optional[str] = None,
scope: Optional[Scope] = None,
validity_period: Optional[timedelta] = None,
**prop... | @@ -282,7 +282,7 @@ class Config:
corresponds to the data node configuration id. During the scenarios'
comparison, each comparator is applied to all the data nodes instantiated from
the data node configuration attached to the comparator. See
- `(taipy.)c... | taipy/common/config/config.pyi | 0 | Python | 1 | none | 16 | 51 | 51 | true | Implement a draw method in scenario config for debug purpose. | 2,289 | Avaiga/taipy | 12,680 | Python | jrobinAV | Review this pull request change.
Language: Python
File: taipy/common/config/config.pyi
PR Title: Implement a draw method in scenario config for debug purpose.
BEFORE CODE: engine: Optional[str] = None,
compression: Optional[str] = None,
read_kwargs: Optional[Dict] = None,
write_kwar... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
assert isinstance(data, pd.DataFrame)
def test_pandas_dataframe_exposed_type(self):
path = os.path.join(pathlib.Path(__file__).parent.resolve(), "data_sample/example.xlsx")
dn = ExcelDataNode(
"foo",
Scope.SCENARIO,
properties={"default_path": path, "expo... | No issues found. | assert isinstance(data, pd.DataFrame)
def test_pandas_dataframe_exposed_type(self):
path = os.path.join(pathlib.Path(__file__).parent.resolve(), "data_sample/example.xlsx")
dn = ExcelDataNode(
"foo",
Scope.SCENARIO,
properties={"default_path": path, "expo... | @@ -302,6 +302,100 @@ def test_pandas_exposed_type(self):
data = dn.read()
assert isinstance(data, pd.DataFrame)
+ def test_pandas_dataframe_exposed_type(self):
+ path = os.path.join(pathlib.Path(__file__).parent.resolve(), "data_sample/example.xlsx")
+ dn = ExcelDataNode(
+ ... | tests/core/data/test_excel_data_node.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | feature/#398-expand-exposed-type-parameter | 2,296 | Avaiga/taipy | 12,680 | Python | sohamkumar05 | Review this pull request change.
Language: Python
File: tests/core/data/test_excel_data_node.py
PR Title: feature/#398-expand-exposed-type-parameter
BEFORE CODE: assert isinstance(data, pd.DataFrame)
def test_pandas_dataframe_exposed_type(self):
path = os.path.join(pathlib.Path(__file__).paren... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import React from "react";
import { useDynamicProperty } from "taipy-gui";
interface CaptionProps {
text: string;
defaultText: string;
logoPath: string;
}
const styles = {
container: {
display: "flex",
alignItems: "center",
},
logo: {
width: "4em",
height: "4em"... | No issues found. | import React from "react";
import { useDynamicProperty } from "taipy-gui";
interface CaptionProps {
text: string;
defaultText: string;
logoPath: string;
}
const styles = {
container: {
display: "flex",
alignItems: "center",
},
logo: {
width: "4em",
height: "4em"... | @@ -0,0 +1,37 @@
+import React from "react";
+import { useDynamicProperty } from "taipy-gui";
+
+interface CaptionProps {
+ text: string;
+ defaultText: string;
+ logoPath: string;
+}
+
+const styles = {
+ container: {
+ display: "flex",
+ alignItems: "center",
+ },
+ logo: {
+ wi... | doc/gui/extension/example_library/front-end/src/LogoWithText.tsx | 0 | TypeScript | 1 | none | 16 | 38 | 38 | true | Adding example for get_resource for taipy extension | 2,297 | Avaiga/taipy | 12,680 | Python | namnguyen20999 | Review this pull request change.
Language: TypeScript
File: doc/gui/extension/example_library/front-end/src/LogoWithText.tsx
PR Title: Adding example for get_resource for taipy extension
BEFORE CODE: import React from "react";
import { useDynamicProperty } from "taipy-gui";
interface CaptionProps {
text: strin... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.