id
int64
2.74B
3.05B
title
stringlengths
1
255
user
stringlengths
2
26
state
stringclasses
2 values
labels
listlengths
0
24
comments
int64
0
206
author_association
stringclasses
4 values
body
stringlengths
7
62.5k
is_title
bool
1 class
2,921,402,900
[export] fix stft decomp and making it consistent with cpp impl.
ydwu4
closed
[ "fb-exported", "Merged", "ciflow/trunk", "topic: not user facing" ]
8
CONTRIBUTOR
Summary: We change the fake impl of stft to follow more closely with its cpp implementation [here](https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/SpectralOps.cpp#L951-L963) where " n_frames = 1 + (len - n_fft) / hop_length;" is also an integer division. Test Plan: Existing tests and buck2 bui...
true
2,921,385,908
[BE] simplify test_cpp_extensions_aot and .gitignore
janeyx99
closed
[ "Merged", "ciflow/trunk", "topic: not user facing" ]
9
CONTRIBUTOR
It is shady to clean up an install mid-test. So don't do that anymore and use .gitignore instead. Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149231
true
2,921,380,345
[BE] Add STABLE_LIBRARY test for multiple returns
janeyx99
closed
[ "Merged", "ciflow/trunk", "topic: not user facing" ]
6
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149230 * #149052
true
2,921,363,910
[aot] always lower the backward with a deepcopy
xmfan
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
3
MEMBER
FIXES https://github.com/pytorch/pytorch/issues/149105 Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #149651 * #149650 * #149649 * #149647 * __->__ #149229 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipi...
true
2,921,290,026
[dynamo][guards][serialization] Dont use ID_MATCH guard for bool and None
anijain2305
closed
[ "Merged", "Reverted", "ciflow/trunk", "topic: not user facing", "module: dynamo", "ciflow/inductor", "ci-no-td" ]
9
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149228 Doing this removes the need of collecting `id` and therefore facilitates serialization. It also improves readability with recompilations. Earlier, recompile message will just show the `id`. cc @voznesenskym @penguinwu @Eik...
true
2,921,285,274
Unexpected behaviour in using torch.nn.utils.rnn.pack_padded_sequence API
sjh0849
open
[ "module: rnn", "triaged" ]
0
NONE
### 🐛 Describe the bug The test cases test_pack_padded_sequence_empty and test_pack_padded_sequence_zero_length expect a valid PackedSequence output for an empty tensor or a sequence with a zero length. This contradicts the underlying behaviour in the current implementation. ```python from torch.nn.utils.rnn import...
true
2,921,280,571
Ensure conj_physical always does a physical conjugation
amjames
open
[ "open source", "topic: bc breaking", "topic: not user facing" ]
4
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #147231 * __->__ #149226 When the argument tensor has a conj bit set. The conj_physical implementation will do `arg.conj().clone()`. Which is not a physical conjugation but a reversal of the conjugate view state. Instead we should unconditi...
true
2,921,276,261
unexpected results when using torch.all_close API
sjh0849
closed
[]
1
NONE
### 🐛 Describe the bug The test_allclose_zero_toleranceshows unexpected behavior (expecting False, but torch.allclose returns True), showing that the implementation does not follow the documented and expected semantics. ```python def test_allclose_zero_tolerance(self): # Test with zero tolerance ...
true
2,921,271,196
Unexpected results in using torch.save API
sjh0849
open
[ "module: serialization", "triaged" ]
0
NONE
### 🐛 Describe the bug In test_save_with_different_pickle_protocol, the test iterates over all protocols (0 through pickle.HIGHEST_PROTOCOL) and expects that saving and then loading the tensor works correctly with each protocol. However, for protocol 0, torch.load fails with an AssertionError (inside torch.load’s per...
true
2,921,262,423
Inconsistent results in using torch.jit.script API from API documentation.
sjh0849
open
[ "oncall: jit" ]
0
NONE
### 🐛 Describe the bug Expects an AttributeError is raised since the ignored_method is skipped in compiling as per API documentation. ```python def test_script_module_with_ignored_method(self): class IgnoredMethodModule(nn.Module): def forward(self, x): return x * 2 @...
true
2,921,255,893
inconsistent result of torch.equal API from API documentation.
sjh0849
closed
[ "module: docs", "triaged", "module: python frontend" ]
3
NONE
### 🐛 Describe the bug Expect this to assert false, as they are different types (based on the documentation, indicate they should have same elements), but an assertion error is thrown. ```python def test_different_dtypes(self): # Test with tensors of different data types tensor1 = torch.tensor([1...
true
2,921,208,558
[MPS] Add inductor support for `i1e`.
dcci
closed
[ "Merged", "topic: not user facing", "module: mps", "ciflow/mps", "module: inductor", "ciflow/inductor" ]
3
MEMBER
cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov
true
2,921,201,591
Skip some tests not using gradcheck on slowgradcheck
soulitzer
closed
[ "Merged", "ciflow/trunk", "topic: not user facing" ]
6
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149220
true
2,921,188,983
Optimize pack_padded_sequence backward function
abdogad
closed
[]
2
NONE
null
true
2,921,173,356
cd: Add no-cache for test binaries
seemethere
closed
[ "Merged", "ciflow/trunk", "topic: not user facing" ]
3
MEMBER
This is to make it so that we don't experience issues like https://github.com/pytorch/vision/actions/runs/13861462856/job/38795684317#step:13:212 ``` ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the p...
true
2,921,111,952
[EZ] Fix typo in UnaryOps.mm
malfet
closed
[ "Merged", "topic: not user facing", "ciflow/mps" ]
3
CONTRIBUTOR
s/imput/input/
true
2,921,016,360
[MPSInductor] Add support for atan2
malfet
closed
[ "Merged", "topic: not user facing", "ciflow/mps", "module: inductor", "ciflow/inductor" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149216 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov
true
2,921,006,381
[WIP] rewrite should_swap
pianpwk
closed
[ "release notes: fx", "fx", "ciflow/inductor" ]
1
CONTRIBUTOR
Fixes #ISSUE_NUMBER cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv
true
2,920,998,515
BC fix for AOTIModelPackageLoader() constructor defaults
pytorchbot
closed
[ "open source", "ciflow/inductor" ]
2
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149082 The default value for `run_single_threaded` was wrongly specified in the .cpp file instead of the header, breaking C++-side instantiation of `AOTIModelPackageLoader` with no arguments. This PR fixes this and adds a test for t...
true
2,920,967,320
[fbgemm] Update FBGEMM
q10
open
[ "ciflow/trunk", "topic: not user facing" ]
4
CONTRIBUTOR
- Update pinned version of FBGEMM to bring in compilation fixes for https://github.com/pytorch/pytorch/issues/129358 Fixes #129358
true
2,920,911,870
[Bugfix] Skip non-tensor user inputs when calling create_graph_signature with trace_joint=True
bremerm31
closed
[ "fb-exported", "topic: bug fixes", "topic: not user facing", "ciflow/inductor" ]
5
NONE
Summary: # Context Encountered a bug while trying to export the joint graph for a module. # Reproducer ```py class mod(torch.nn.Module): def forward(self, ph: object, t: torch.Tensor): return (t.sum(),) m = mod() t = torch.rand(100, requires_grad=True) g, sig = aot_export_module( ...
true
2,920,893,083
Support windows in C++ shape guards
isuruf
closed
[ "open source", "Merged", "ciflow/trunk", "module: dynamo", "ciflow/inductor", "release notes: dynamo" ]
3
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140756 * __->__ #149211 * #149197 * #149149 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,920,835,826
TEST: ir.py without ir.py
rec
closed
[ "module: rocm", "open source", "module: inductor", "ciflow/inductor", "release notes: export" ]
1
COLLABORATOR
TEST, please ignore. Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149210 cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhao...
true
2,920,819,354
Wrong argument in `CompileCounterWithBackend` when running `torch.utils.benchmark.utils.compile.bench_all`
GdoongMathew
open
[ "triaged", "module: benchmark" ]
0
CONTRIBUTOR
### 🐛 Describe the bug When benchmarking forward speed with different inductor mode, the it raises an exception which causes no benchmarking result. ```python from torchvision.models import resnet18 from torch.utils.benchmark.utils.compile import benchmark_compile import torch x = torch.zeros((1, 3, 64, 64), device...
true
2,920,818,695
op should NOT be static in aoti_torch_call_dispatcher
janeyx99
closed
[ "Merged", "ciflow/trunk", "release notes: cpp", "ciflow/inductor" ]
5
CONTRIBUTOR
aoti_torch_call_dispatcher is meant to call different ops, so the op must not be static. Otherwise, every call to this API will call the first op that was ever called, which is not the intended behavior of any human being. Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #149230 * #14905...
true
2,920,798,329
Cache the get_device_module result
egienvalue
closed
[ "fb-exported", "Merged", "ciflow/trunk", "topic: not user facing" ]
6
CONTRIBUTOR
Summary: As title. Test Plan: OSS CIs. Reviewed By: chaos5958 Differential Revision: D71084180
true
2,920,782,658
debug ival swap
avikchaudhuri
closed
[ "fb-exported", "Merged", "ciflow/trunk", "release notes: export" ]
14
CONTRIBUTOR
Summary: Recall that we use "ivals" to track intermediate values of mutations during unflattening. Previously, for each such intermediate value, we would create a hidden shared attribute that would be updated / read by respective submodules. Unfortunately this scheme doesn't work when some but not all of those submodu...
true
2,920,759,083
Parameter not updating when FSDP2 model is used before optimizre creation
zhoukezi
open
[ "oncall: distributed", "triaged", "module: fsdp" ]
1
NONE
### 🐛 Describe the bug If calculations are performed using a FSDP2 model after calling `fully_shard` and before creating the optimizer, the parameters fail to update correctly. The parameters captured by the optimizer seem to differ from those in the training loop. Non-parallel and DDP are not affected. In larger mul...
true
2,920,736,223
[MPS] Modify a test to test the correct function.
dcci
closed
[ "Merged", "topic: not user facing", "module: mps", "ciflow/mps", "module: inductor", "ciflow/inductor" ]
4
MEMBER
cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov
true
2,920,700,015
[MPS] Add support for `i1e`
malfet
closed
[ "Merged", "topic: improvements", "release notes: mps", "ciflow/mps" ]
4
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149203 Followup after https://github.com/pytorch/pytorch/pull/149174
true
2,920,696,794
[prototype] in memory checkpoint example
H-Huang
open
[ "oncall: distributed", "release notes: distributed (checkpoint)" ]
2
MEMBER
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149202 The problem: Reading from disk / network file system is expensive. If we can read from memory then loading checkpoints is a lot faster and we can do it more frequently. The idea: 1. Keep a process alive which has t...
true
2,920,631,200
Segment fault when used with FAISS on arm
SylviaZiyuZhang
open
[ "module: binaries", "module: crash", "triaged", "module: macos", "module: openmp", "module: arm" ]
5
NONE
### 🐛 Describe the bug TLDR: When `faiss` is imported, construction of `nn` objects yield segmentation faults. ``` thread #4, stop reason = EXC_BAD_ACCESS (code=1, address=0x8) frame #0: 0x00000001015e5828 libomp.dylib`void __kmp_suspend_64<false, true>(int, kmp_flag_64<false, true>*) + 44 libomp.dylib`__kmp_sus...
true
2,920,592,830
broadcast_object_list cast group_src to global_src is not safe when group is not subgroup of global group
zhc7
closed
[ "oncall: distributed", "module: c10d" ]
6
CONTRIBUTOR
### 🐛 Describe the bug In torch distributed environment, it is possible to create a new process group that is larger than the global group. Example: https://github.com/OpenRLHF/OpenRLHF/blob/f9a8fe2d78c31181aa496731a4858a9a95316927/openrlhf/utils/distributed_util.py#L19 this suggests that the group rank may actuall...
true
2,920,587,740
DISABLED test_binary_op_with_scalar_self_support__foreach_pow_is_fastpath_True_cuda_complex64 (__main__.TestForeachCUDA)
pytorch-bot[bot]
open
[ "triaged", "module: flaky-tests", "skipped", "module: mta" ]
7
NONE
Platforms: linux, slow This test was disabled because it is failing in CI. See [recent examples](https://hud.pytorch.org/flakytest?name=test_binary_op_with_scalar_self_support__foreach_pow_is_fastpath_True_cuda_complex64&suite=TestForeachCUDA&limit=100) and the most recent trunk [workflow logs](https://github.com/pyto...
true
2,920,559,770
[export] Update remove runtime asserts pass
angelayi
closed
[ "fb-exported", "Merged", "ciflow/trunk", "ciflow/inductor", "release notes: export" ]
7
CONTRIBUTOR
Test Plan: CI -- Removing asserts should be a noop Differential Revision: D69566851
true
2,920,478,703
use python fallback if there are overflows
isuruf
closed
[ "open source", "Merged", "ciflow/trunk", "module: dynamo", "ciflow/inductor", "release notes: dynamo" ]
3
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140756 * #149211 * __->__ #149197 * #149149 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,920,417,011
(Will PR) Multiprocessing with CUDA_VISIBLE_DEVICES seems to give the wrong device
fzyzcjy
open
[ "module: multiprocessing", "module: cuda", "triaged" ]
10
CONTRIBUTOR
### EDIT: PR to fix this PR is here: https://github.com/pytorch/pytorch/pull/149248 ### 🐛 Describe the bug Hi thanks for the helpful library! When two processes have different CUDA_VISIBLE_DEVICES and pass around tensor between them, it seems the `.device` attribute is incorrect. Example code: ```python import os...
true
2,920,357,260
[ROCm][Windows] Disable hipSPARSE and CK declarations and remove references for Windows
ikalinic
closed
[ "module: rocm", "triaged", "open source", "Merged", "ciflow/trunk", "topic: not user facing", "ciflow/rocm" ]
4
CONTRIBUTOR
This PR removes references to `hipSPARSE` and `ck` functions and disables declarations which are not supported on Windows. cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd
true
2,920,321,709
LSTM slow on PackedSequence
ikamensh
open
[ "module: rnn", "triaged", "topic: performance" ]
0
CONTRIBUTOR
### 🐛 Describe the bug Using LSTM with `PackedSequence` input is very slow. This effect is extreme at high sequence lengths, see tables below. Given that PackedSequence is the only way to get both correct output and state for a sequence with non-homogenious length I think this is a big challenge in usability of RNNs....
true
2,920,310,030
Add .editorconfig
zxiiro
closed
[ "open source", "Merged", "topic: not user facing" ]
3
COLLABORATOR
This adds an .editorconfig file to automatically configure devs local Editors / IDEs with the basic formatting rules of the project. List of supported editors: https://editorconfig.org/#pre-installed
true
2,920,042,428
[CI INFRA TEST] Test experiment for ephemeral runners
jeanschmidt
open
[ "ciflow/binaries", "ciflow/trunk", "topic: not user facing", "ciflow/periodic", "ciflow/nightly", "ciflow/binaries_wheel", "ciflow/inductor", "ciflow/slow", "ciflow/torchao" ]
2
CONTRIBUTOR
Just running the ci with the `ephemeral` experiment defined in https://github.com/pytorch/test-infra/issues/5132 This will run CI in meta's infra, with the ephemeral reuse changes. And force to only use ephemral runners from the autoscaler pool. The goal of this experiment is evaluate queue time and if runners ar...
true
2,919,791,063
[assoc_scan/scan] Added testcase for complex tensors
bohnstingl
open
[ "triaged", "open source", "topic: not user facing" ]
3
COLLABORATOR
We have a user @largraf using associative_scan with complex tensors. Thus, I wanted to add a test case to ensure that a `combine_fn` working on complex tensors is working with `associative_scan` and `scan`. The tests do fail though with `torch.complex32`, potentially due to numerical precision issues? Furthermore, s...
true
2,919,775,726
Super tiny fix typo
fzyzcjy
closed
[ "open source", "Merged", "topic: not user facing" ]
3
CONTRIBUTOR
... when checking the doc to build from source
true
2,919,682,792
Add scripts to generate plots of LRSchedulers
zeshengzong
closed
[ "triaged", "open source", "Merged", "ciflow/trunk", "topic: docs", "release notes: optim" ]
9
CONTRIBUTOR
Fixes #92007 ## Changes - Add script to generate plots for `lr_scheduler` - Add plots to `lr_scheduler` docs - Add example section if it missing in `lr_scheduler` docs ## Test Result ### LambdaLR ![image](https://github.com/user-attachments/assets/37fc0894-e2ec-48f2-a2d6-3514e51e1ea2) ### Multiplica...
true
2,919,648,483
Create devcontainer.json
kvandenheuvel23
closed
[ "triaged", "open source" ]
3
NONE
Fixes #ISSUE_NUMBER
true
2,919,605,063
Issue with Shared CUDA Tensor Reference Counting in Multi-Processing
U-rara
open
[ "module: multiprocessing", "module: cuda", "triaged" ]
4
NONE
### 🐛 Describe the bug When using multi-processing sharing CUDA tensors, I discovered that when process B receives the information from process A's `tensor.untyped_storage()._share_cuda_()`, even if this information is released (without even rebuilding the tensor in process B), it causes the tensor in process A to ha...
true
2,919,584,824
torch.fx.symbolic_trace failed on deepseek-ai/DeepSeek-R1-Distill-Qwen-1.5B
FlintWangacc
open
[ "module: fx", "oncall: pt2", "export-triaged", "oncall: export" ]
7
NONE
### 🐛 Describe the bug I try to compile deepseek-ai/DeepSeek-R1-Distill-Qwen-1.5B to mlir with the following script. ```python # Import necessary libraries import torch from transformers import AutoModelForCausalLM, AutoTokenizer from torch.export import export import onnx from torch_mlir import fx # Load the DeepSee...
true
2,919,395,978
[pt2_provenance_tracking] add support for cpp kernel
YUNQIUGUO
closed
[ "fb-exported", "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
11
CONTRIBUTOR
Summary: As title. Add inductor cpp kernel to post grad graph node mapping & UT. Context: Raised as a feature request for AOTI CPU case. https://fb.workplace.com/groups/1028545332188949/permalink/1169020841474730/ Differential Revision: D71181284 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @Xia...
true
2,919,311,118
[macOS] instantiating optimizer after torch.set_default_device("mps") throws "RuntimeError: Placeholder storage has not been allocated on MPS device!"
AlexPetrusca
open
[ "triaged", "module: mps" ]
3
NONE
### 🐛 Describe the bug When I set "mps" as the default device and then try to instantiate an optimizer, say `torch.optim.SGD`, I get a RuntimeError with message "Placeholder storage has not been allocated on MPS device!". This also happens when instantiating other optimizers, like `torch.optim.Adam` and `torch.optim....
true
2,919,305,220
[regression] Fix pin_memory() when it is called before device lazy initialization.
pytorchbot
closed
[ "open source" ]
2
COLLABORATOR
PR #145752 has added a check in the isPinnedPtr to check if a device is initialized before checking if the tensor is pinned. Also that PR has added a lazy initialization trigger when an at::empty is called with a pinned param set to true. However, when the tensor is firstly created and it is pinned in a separate call b...
true
2,919,280,214
Add test coverage
hl475
closed
[ "fb-exported", "Merged", "ciflow/trunk", "release notes: quantization", "topic: not user facing", "fx" ]
4
CONTRIBUTOR
Summary: Follow up from D71160718 Differential Revision: D71177037 cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv
true
2,919,268,579
Add side_effect to avoid dce custom op in CA graph
zhanglirong1999
closed
[ "module: custom-operators", "open source", "Merged", "ciflow/trunk", "topic: not user facing", "module: dynamo", "module: compiled autograd" ]
7
CONTRIBUTOR
We found that in compiled_autograd, when defining custom op, the custom op will be dce in the backward graph. We added a side effect condition in the dce function to prevent eliminating custom op with side effect in CA graph. cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzhe...
true
2,919,205,616
[MPS] Add inductor support for i0e.
dcci
closed
[ "Merged", "topic: not user facing", "module: mps", "ciflow/mps", "module: inductor", "ciflow/inductor" ]
6
MEMBER
cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov
true
2,919,189,889
[MPSInductor] Add `bessel_[jy][01]` ops
malfet
closed
[ "Merged", "topic: not user facing", "ciflow/mps", "module: inductor", "ciflow/inductor" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149179 * #149123 By simply calling corresponding special functions Followup TODO: tweak bessel_y0 to match CPU implementation for `torch.half` dtype cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSupe...
true
2,919,128,915
[Inductor][Optimus] Add move view after cat aten pattern
mengluy0125
closed
[ "fb-exported", "Merged", "ciflow/trunk", "module: inductor", "ciflow/inductor", "release notes: inductor" ]
9
CONTRIBUTOR
Summary: Add aten pattern to move the view/reshape out of split cat, further reduce the number of kernels. context: https://docs.google.com/document/d/1G2qFcQu1K7VXbz2uPe0CS2aBirnwtwI_B8lxmlBlAPQ/edit?tab=t.0 Test Plan: ### how to enable Add the following patterns to the post grad ``` post_grad_fusion_options...
true
2,919,014,027
[Dist] Async op isend and irecv bug
feifei-111
open
[ "oncall: distributed", "triaged", "module: c10d" ]
2
NONE
### 🐛 Describe the bug ![Image](https://github.com/user-attachments/assets/f37b0180-bb40-4977-9a90-ee1243371994) I write a pp parallel framework for inference (for some reason, i can't post codes in the issue), and i found the time series is not correct, because of isend irecv behavior is a bit weird, just like the ...
true
2,918,858,200
[DO NOT LAND] Try changing the loop order
blaine-rister
closed
[ "module: inductor", "ciflow/inductor" ]
2
CONTRIBUTOR
Testing a possible solution to #148718. It didn't work as well as expected. cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov
true
2,918,798,740
[AOTI][XPU] Fix: model_container_runner_xpu.cpp is not built into libtorch_xpu.so
etaf
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing", "ciflow/xpu" ]
12
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149175 The missing of model_container_runner_xpu.cpp will cause compilation failure when user build CPP inference application on XPU.
true
2,918,736,849
[MPS] Add support for `i0e` in eager.
dcci
closed
[ "Merged", "Reverted", "topic: improvements", "module: mps", "release notes: mps", "ciflow/mps", "ciflow/inductor", "ci-no-td" ]
9
MEMBER
Add `special.i0e` to XFAIL_GRADLIST for now, as its backward op is not yet implemented cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen
true
2,918,731,650
Update clang-format to 19.1.4
cyyever
open
[ "oncall: distributed", "open source", "NNC", "topic: not user facing", "ciflow/mps", "ciflow/inductor" ]
1
COLLABORATOR
To have the same version with clang-tidy used in lintrunner. The changes are all formatting. cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @EikanWang @jgong5
true
2,918,684,341
fix two accuracy regression
shunting314
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
4
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149172 There are 2 accuracy regression in 3/12 nightly perf run. I can not repro them locally thus there is no effective way to bisect. Raise the tolerance to make them pass the accuracy check. - error log for HF MegatronBertForQ...
true
2,918,673,778
Update logic when producing key name for keep_original_weights
hl475
closed
[ "fb-exported", "Merged", "ciflow/trunk", "release notes: quantization", "fx", "release notes: AO frontend" ]
5
CONTRIBUTOR
Differential Revision: D71160718 cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv
true
2,918,673,363
fix two accuracy regression
shunting314
closed
[ "module: dynamo", "ciflow/inductor" ]
2
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149170 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,918,672,008
[RelEng] wheel testing for new arch versions
malfet
open
[ "oncall: releng", "module: ci", "triaged" ]
0
CONTRIBUTOR
Was: [RelEng] s3_management/manage.py does not update indexes for new binaries Discovered by @atalman while working on 2.7.0-RC1, when `https://download.pytorch.org/whl/test/rocm6.3/index.html` were never updated manage.py currently only updated subfolder that contain some `.whl` files inside of it, but before first ...
true
2,918,643,187
Remove some memory overhead in parallel compile workers
masnesral
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
6
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149168 Summary: The parallel compile workers are holding on to more memory than they need to because they're loading the compiled modules into memory. Update the post-fork initializer to record when in a subprocess and skip some of t...
true
2,918,619,019
[AOTInductor] [BE] Add swap_constant_buffer into pybind for tests.
muchulee8
closed
[ "Merged", "Reverted", "topic: not user facing", "module: inductor", "ciflow/inductor", "ci-no-td" ]
6
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149167 Summary: We add swap_constant_buffer in pybind to add tests. Test Plan: python test/inductor/test_aot_inductor.py -k test_update_inactive_constant_buffer Reviewers: Subscribers: Tasks: Tags: cc @voznesenskym @penguinwu @...
true
2,918,614,931
[c10d] Add param recording for uniqueID broadcasting and allgather
fduwjj
closed
[ "oncall: distributed", "Merged", "ciflow/trunk", "release notes: distributed (c10d)" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149166 cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @wz337 @wconstab @d4l3k @c-p-i-o
true
2,918,557,652
Failed to load model in Release but can load in debug
Sanjib-ac
closed
[ "needs reproduction", "oncall: jit" ]
2
NONE
LibTorch 2.6 +cu124 Pytorch 2.6.0 +cu124 Torch::jit::load can load a model in debug but not in release. Getting error "file_name!=nullptr". cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel
true
2,918,556,868
[ATen-CPU] Add `math.h` for Gelu
SS-JIA
closed
[ "module: cpu", "Merged", "ciflow/trunk", "topic: not user facing" ]
10
CONTRIBUTOR
Summary: ## Context This PR is mostly to enable ExecuTorch build for Windows: https://github.com/pytorch/executorch/pull/9198 In ExecuTorch, the optimized GeLU kernel calls the ATen implementation. However, on Windows `math.h` needs to be included with `#define _USE_MATH_DEFINES` in order for math constants to be de...
true
2,918,545,807
Test if ET unit tests are disabled.
shengfukevin
closed
[ "fb-exported", "topic: not user facing", "ci-no-td" ]
8
CONTRIBUTOR
Summary: Test if ET unit tests are disabled. The code change will make all ET unit tests fail. Differential Revision: D71157414
true
2,918,511,036
[AOTInductor] Activate CPU test for update_constant_buffer
muchulee8
closed
[ "Merged", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149162 Summary: Fixed by #145459 Test Plan: Re-activating tests. Reviewers: Subscribers: Tasks: Tags: cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipisz...
true
2,918,500,808
[AOTInductor] Add function to free buffer
muchulee8
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
4
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149161 * #149249 Summary: We add a function that allows users to free the unused buffer. Test Plan: Testing correctness: python test/inductor/test_aot_inductor.py -k free_inactive Testing memory consumption: LD...
true
2,918,470,935
[cherry-pick] Revert #148823 - Make dynamism code robust to NotImplementedException
ZainRizvi
closed
[ "module: rocm", "release notes: releng", "fx", "module: inductor", "ciflow/inductor" ]
1
CONTRIBUTOR
Reverting since it was reverted from the main branch
true
2,918,468,763
Clean up grid in execution trace
shengfukevin
closed
[ "fb-exported", "Merged", "ciflow/trunk", "topic: not user facing" ]
5
CONTRIBUTOR
Summary: This DIFF https://www.internalfb.com/diff/D70471332 removed input "grid" when calling triton kernel. PyTorch execution trace need to make the appropriate change. It includes capturing ET and replay ET. Test Plan: buck2 run mode/opt caffe2/test:test_profiler_cuda -- profiler.test_execution_trace.TestExecution...
true
2,918,466,389
[torch.export] ExportedProgram.module() does not support torch.Size as input
titaiwangms
closed
[ "oncall: pt2", "oncall: export" ]
3
COLLABORATOR
Not sure if this is an expected behavior, so file an issue to understand it. The repro is below: ```python import torch import torch.nn as nn class Model(nn.Module): def __init__(self): super(Model, self).__init__() def forward(self, theta, size): return torch.nn.functional.affine_grid(theta, size, alig...
true
2,918,446,237
Bad index causes segfault instead of IndexError
johnstill
closed
[ "module: binaries" ]
2
NONE
### 🐛 Describe the bug If torch (and dependencies) has been installed from conda-forge, torch tensors fail to properly raise IndexError: Installed from conda-forge (this is unexpected behavior): ``` $ python Python 3.12.9 | packaged by conda-forge | (main, Mar 4 2025, 22:48:41) [GCC 13.3.0] on linux Type "help", "c...
true
2,918,418,704
illegal hardware instruction in `torch.tanh`
johnstill
closed
[ "needs reproduction", "module: binaries", "module: crash", "triaged", "module: intel" ]
3
NONE
### 🐛 Describe the bug Under some circumstances `torch.tanh` crashes with an "illegal hardware instruction" ``` $ python Python 3.12.9 | packaged by conda-forge | (main, Mar 4 2025, 22:48:41) [GCC 13.3....
true
2,918,396,044
torch.multiprocessing.Queue Zeroes Out Tensors on Retrieval
ManuelZ
open
[ "module: windows", "module: multiprocessing", "module: cuda", "triaged" ]
1
NONE
### 🐛 Describe the bug When sending a CUDA tensor through a `torch.multiprocessing.Queue`, the received tensor contains only zeros instead of the expected values. I reproduced it in Windows 10 with Pytorch 2.5.1 and 2.6.0. I couldn't reproduce it in Colab with Pytorch 2.5.1. Minimally reproducible example: ``` # Un...
true
2,918,363,986
allow extra args for parameterization of tests in inductor
isuruf
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
9
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #148209 * __->__ #149154 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov
true
2,918,332,011
ProcessGroupNCCL: ncclCommAbort hangs with NCCL 2.25.1-1
d4l3k
closed
[ "module: dependency bug", "oncall: distributed", "module: nccl", "module: c10d", "bug" ]
8
MEMBER
### 🐛 Describe the bug ncclCommAbort hangs when using NCCL 2.25.1-1 w/ PyTorch nightly. This is fixes with NCCL 2.26.2-1 which released yesterday (2025-03-12). Full details (repro + stack traces) in https://gist.github.com/d4l3k/16a19b475952bc40ddd7f2febcc297b7 Relevant stack traces: ``` thread #16, name = 'pyth...
true
2,918,326,766
[c10d] Make getDefaultBackend more fault tolerant without relying on exceptions
PatriceVignola
closed
[ "oncall: distributed", "fb-exported", "Merged", "ciflow/trunk", "release notes: distributed (c10d)" ]
8
CONTRIBUTOR
Summary: no-except builds are terminating when this exception is thrown. We should proactively check if a backend is available before calling has_hooks, instead of trying and failing. Test Plan: CI Differential Revision: D71144456 cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i...
true
2,918,297,789
[ONNX] Cover dynamic_shapes checks within verify=True
titaiwangms
open
[ "module: onnx", "triaged" ]
3
COLLABORATOR
https://github.com/pytorch/pytorch/blob/38e81a53324146d445a81eb8f80bccebe623eb35/torch/onnx/_internal/exporter/_verification.py#L137 We can try a different set of inputs that has different shape to examine the dynamic_shapes so that users/us can catch the issues before actually applying the model, and save the trouble...
true
2,918,193,958
[fsdp] add an experimental allocator hook for buffers that participate in collective communication
jiayulu
open
[ "oncall: distributed", "fb-exported", "release notes: distributed (fsdp)" ]
7
NONE
Summary: https://github.com/pytorch/pytorch/pull/147146 Test Plan: unit test Differential Revision: D69694585 cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o
true
2,918,187,634
Fix shape guard failure to be valid python
isuruf
closed
[ "open source", "Merged", "ciflow/trunk", "module: dynamo", "ciflow/inductor", "release notes: dynamo" ]
7
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140756 * #149211 * #149197 * __->__ #149149 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,918,187,455
Fix printing INT64_MIN
isuruf
closed
[ "module: cpu", "open source", "Merged", "ciflow/trunk", "module: inductor", "ciflow/inductor", "release notes: dynamo" ]
6
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140756 * #149211 * #149197 * #149149 * __->__ #149148 cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @...
true
2,918,142,688
[MPS] fix attention enable_gqa crash on mps
Isalia20
closed
[ "open source", "Merged", "topic: bug fixes", "module: mps", "release notes: mps", "ciflow/mps" ]
8
COLLABORATOR
Fixes #149132 cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen
true
2,918,134,447
Update as strided doc
albanD
closed
[ "Merged", "ciflow/trunk", "release notes: python_frontend" ]
6
COLLABORATOR
Make it clearer why it is not recommended to use it and when the resulting Tensor will have undefined behavior.
true
2,918,118,576
[ROCm] enable HIPMallocAsyncAllocator
ethanwee1
closed
[ "module: rocm", "triaged", "open source", "Merged", "Reverted", "ciflow/trunk", "release notes: rocm", "ci-no-td" ]
27
CONTRIBUTOR
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd
true
2,918,095,202
[c10d] Fix extra CUDA context created by barrier
kwen2501
closed
[ "oncall: distributed", "Merged", "Reverted", "ciflow/trunk", "release notes: distributed (c10d)", "topic: bug fixes", "ci-no-td" ]
17
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149144 Fixes #149119. In ProcessGroup.hpp, we create a dummy tensor for dispatching. This requires a correct device index. This PR uses `device_id` given by user when calling `init_process_group`. This PR also uses `torch._C._get_a...
true
2,918,093,634
[Easy] update pip sources for CUDA in nightly pull tool
XuehaiPan
open
[ "open source", "topic: not user facing" ]
1
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149143 * #145685
true
2,918,087,968
ci: Update linux.20_04 --> linux.24_04
seemethere
closed
[ "Merged", "ciflow/trunk", "topic: not user facing" ]
6
MEMBER
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149142 Ubuntu 20.04 is getting deprecated soon so we might as well proactively move to the latest LTS which is 24.04 > [!NOTE] > The oldest supported version of python on 24.04 is Python 3.8. Since we test for Python 3.6 compat...
true
2,918,084,254
[ONNX] Set `is_in_onnx_export` for dynamo=True
justinchuby
closed
[ "module: onnx", "triaged" ]
7
COLLABORATOR
Currently `is_in_onnx_export()` is True only for the torchscript exporter. We should set it to true during dynamo export as well to support `torch.onnx.ops.symbolic` usage. Option 1: Users use ``` if torch.onnx.is_in_onnx_export() and torch.compile.is_exporting(): # Do the `torch.onnx.ops.symbolic` thing ``` Opt...
true
2,918,016,530
PaddedTensor Init
alexanderb14
open
[ "open source", "module: dynamo", "ciflow/inductor" ]
3
NONE
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,918,012,698
Gh/alexbrauckmann/paddedtensor init
alexanderb14
closed
[ "module: dynamo", "ciflow/inductor" ]
2
NONE
Fixes #ISSUE_NUMBER cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,917,984,300
FSDP with AveragedModel
nikonikolov
open
[ "oncall: distributed", "triaged", "module: fsdp" ]
3
CONTRIBUTOR
I am trying to use FSDP with `torch.optim.swa_utils.AveragedModel`, but I am getting the error ``` File "/scratch/nikolay_nikolov/.cache/bazel/_bazel_nikolay_nikolov/79bf5e678fbb2019f1e30944a206f079/external/python_runtime_x86_64-unknown-linux-gnu/lib/python3.10/copy.py", line 161, in deepcopy ...
true
2,917,919,812
Add back fake class registration to test_torchbind
yushangdi
closed
[ "fb-exported", "Merged", "ciflow/trunk", "topic: not user facing" ]
4
CONTRIBUTOR
Fixes #149121 Summary: as title, to fix https://github.com/pytorch/pytorch/issues/149121 Test Plan: ``` python test/export/test_torchbind.py ``` Differential Revision: D71129321
true
2,917,898,165
Use TorchVersion for triton version check
atalman
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
7
CONTRIBUTOR
Followup after https://github.com/pytorch/pytorch/pull/149092#issuecomment-2721990321 To use TorchVersion for triton version parsing cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhu...
true
2,917,891,673
[PGNCCL] Fix extra CUDA context created by barrier
kwen2501
closed
[ "oncall: distributed", "release notes: distributed (c10d)" ]
2
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #149135 Fixes #149119. Use correct device to do barrier. cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o
true
2,917,869,344
add keepdim to cosine similarity
Isalia20
open
[ "module: nn", "triaged", "open source", "release notes: onnx", "topic: improvements" ]
9
COLLABORATOR
Fixes #149120 cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki
true
2,917,847,704
Implement einsum backprop rather than decomposing
pgmoka
open
[ "module: autograd", "triaged", "module: python frontend" ]
3
NONE
### 🚀 The feature, motivation and pitch Currently when doing einsum backpropagation, the function decomposes into a series of IRs that achieves the einsum function. This is an issue for TPUs as the decomposition creates a significant performance impact due to the potential reshapes. When looking at IRs for einsum at...
true