id
int64
2.74B
3.05B
title
stringlengths
1
255
user
stringlengths
2
26
state
stringclasses
2 values
labels
listlengths
0
24
comments
int64
0
206
author_association
stringclasses
4 values
body
stringlengths
7
62.5k
is_title
bool
1 class
2,772,853,949
[PrivateUse1] Support parseDispatchKey with modified PrivateUse1
fmo-mt
closed
[ "triaged", "open source", "module: dispatch", "Merged", "ciflow/trunk", "topic: not user facing", "module: PrivateUse1" ]
16
CONTRIBUTOR
PyTorch now support many private1 backend names like `AutogradPrivateUse1` or `QuantizedPrivateUse1`, not mentioned the original `PrivateUse1` backend. However, users that implement `PrivateUse1` funtionalities would modified the backend name by calling `torch.utils.rename_privateuse1_backend("my_backend")`, in tha...
true
2,772,829,610
FSDP: How to support w8a8 quantization?
Lenan22
open
[ "triaged", "module: fsdp", "oncall: pt2" ]
2
NONE
### 🐛 Describe the bug I replaced nn.Linear with QuantLinear, substituting the nn.Linear operator with an int8 quantized operator. act_tensor_int8, pertoken_scale = torch_npu.npu_dynamic_quant(x) quant_out = torch_npu.npu_quant_matmul(act_tensor_int8, self.weight.to(...
true
2,772,653,582
[Easy] Fix linalg.norm hint message typo
zeshengzong
closed
[ "open source", "Merged", "ciflow/trunk", "release notes: linalg_frontend" ]
9
CONTRIBUTOR
Fixes #136454 **Test Result** **Before** ```python >>> import torch >>> from torch import linalg >>> >>> my_tensor = torch.tensor([[[8., -3., 0., 1.]]]) >>> # ↓ ↓ ↓ ↓ ↓ >>> linalg.norm(input=my_tensor, ord='fro', dim=(0, 1, 2)) # Error Traceback (most recent call last): Fi...
true
2,772,627,057
added `__add__` and `__mul__` hints to torch.Size
randolf-scholz
closed
[ "oncall: distributed", "module: typing", "open source", "Merged", "ciflow/trunk", "release notes: python_frontend" ]
9
CONTRIBUTOR
Fixes #144218 `Size` returns `Size`, whereas `tuple` returns `tuple`: https://github.com/python/typeshed/blob/9f28171658b9ca6c32a7cb93fbb99fc92b17858b/stdlib/builtins.pyi#L985-L988 - Use `SupportIndex` instead of `int` in `__getitem__` (supported at runtime) - `Size.__add__` overrides `tuple.__add__`, the latte...
true
2,772,327,034
Mismatch between PyTorch nn.Linear in float16 and equivalent NumPy implementation
AyoubMDL
closed
[]
4
NONE
### 🐛 Describe the bug I’m trying to replicate the behavior of PyTorch’s nn.Linear operation in float16 using NumPy, but I’m unable to get the exact same outputs. Specifically, I’ve implemented two NumPy versions of the linear operation, but neither matches the results produced by PyTorch’s nn.Linear when using torch...
true
2,772,216,474
[AMD] SDPA internal changes
xw285cornell
closed
[ "fb-exported", "Merged", "ciflow/trunk", "topic: not user facing" ]
5
CONTRIBUTOR
Summary: All the internal changes needed to enable flash attention w/ SDPA in fbcode. Test Plan: ``` TORCH_ROCM_FA_PREFER_CK=1 buck run -m rocm621 mode/opt-amd-gpu scripts/xdwang/example:sdpa +--------------+-------------------+---------+------------+-------------------+------------------+----------------------+---...
true
2,772,212,190
[aot] don't dce aten rng nodes
xmfan
closed
[ "Merged", "ciflow/trunk", "release notes: fx", "fx", "module: dynamo", "ciflow/inductor" ]
5
MEMBER
FIXES https://github.com/pytorch/pytorch/issues/143431 For aot_eager backend, we dce twice in aot. The first dce errs on the side of caution and provides a restrictive dce function: https://github.com/pytorch/pytorch/blob/2e1ea8598f477322965c28fb52e6e5f53876d8dd/torch/fx/experimental/proxy_tensor.py#L1173 The sec...
true
2,772,186,843
[Quant][Inductor][X86] Separate binary post op fusion and lowering for qconv
Xia-Weiwen
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing", "intel", "module: inductor", "ciflow/inductor" ]
3
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144318 * #144312 * #144224 **Summary** The current implementation fuses quantized ops and their post ops and lowers the fused the op to cpp backend in the same pass. It is better to separate post op fusion and lowering because - i...
true
2,772,058,095
Move Windows arm64 scripts from pytorch/builder
iremyux
closed
[ "open source", "Merged", "ciflow/trunk", "release notes: build" ]
6
COLLABORATOR
This PR moves the Windows Arm64 scripts from the builder repository to the main repository. The corresponding PR to pytorch/builder that removes them is here : https://github.com/pytorch/builder/pull/2058
true
2,772,054,569
[CD] Enable profiling for XPU Windows nightly wheels
chuanqi129
closed
[ "module: windows", "open source", "Merged", "ciflow/trunk", "release notes: releng", "topic: not user facing", "ciflow/binaries_wheel", "module: xpu" ]
7
COLLABORATOR
PR https://github.com/pytorch/pytorch/pull/144034 added profiling support for torch XPU Windows binary, enable it in PyTorch XPU Windows CD Works for https://github.com/pytorch/pytorch/issues/114850 cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @gujinghui @EikanWang @fengyuan14 @guangyey
true
2,772,049,829
refactor benchmarking to use dynamo_timed
nmacchioni
closed
[ "Merged", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
6
CONTRIBUTOR
use dynamo_timed for all our wrapped calls, instead of our custom timer Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #144507 * #144505 * #144501 * #144353 * #133287 * #144365 * #133121 * #133058 * __->__ #144315 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @Xiaobi...
true
2,772,012,953
[inductor] [dtype propogation] `conv1d,2d,3d` pass the check when handling `uint8,16,32,64` while eager throws the error
shaoyuyoung
open
[ "oncall: pt2", "oncall: cpu inductor" ]
7
CONTRIBUTOR
### 🐛 Describe the bug related to #144310 ```python import torch import torch.nn.functional as F torch._dynamo.config.recompile_limit = 12 def run_test(dim, dtype): input_shape = [1, 8] + [64] * dim input = torch.randn(input_shape).to(dtype).cuda() kernel_size = 4 stride = 4 padd...
true
2,771,995,311
[inductor] [bug fix] align `avg_pool` with eager when handling `uint`
shaoyuyoung
closed
[ "triaged", "open source", "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor" ]
9
CONTRIBUTOR
Fixes #144310 ~~We just need to add a check in lowering~~ updated: we add the error checking in `meta registration` ### UT ``` pytest -s -v test/inductor/test_torchinductor.py -k test_avg_pool_errors_with_uint ``` cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe...
true
2,771,987,829
[Quant][Inductor][X86] Separate unary post op fusion and lowering for qconv
Xia-Weiwen
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing", "intel", "module: inductor", "ciflow/inductor" ]
3
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #144318 * __->__ #144312 * #144224 **Summary** The current implementation fuses quantized ops and their post ops and lowers the fused the op to cpp backend in the same pass. It is better to separate post op fusion and lowering because - i...
true
2,771,974,790
Preload cuda runtime via python import.
oraluben
open
[ "triaged", "open source", "Stale", "release notes: cuda", "topic: bug fixes" ]
10
CONTRIBUTOR
This PR use python's import mechanism to detect and find the cuda runtime installed from pypi, and try to preload them first on supported platform. Fixes https://github.com/pytorch/pytorch/issues/101314 Fixes https://github.com/pytorch/pytorch/issues/121207 There're also recent issues like #138324, #138460, #140...
true
2,771,940,501
[inductor] [dtype propogation] `avg_pool1d,2d,3d` pass the check when handling `uint8,16,32,64` while eager throws the error
shaoyuyoung
closed
[ "oncall: pt2", "oncall: cpu inductor" ]
1
CONTRIBUTOR
### 🐛 Describe the bug When handling uint, CPU inductor passes the check while eager and triton throws the error. **device**: both on CPU and cuda ```python import torch torch._dynamo.config.recompile_limit = 12 def run_test(dim, dtype): x = torch.randn([2] * (dim + 2)).to(dtype) op = eval(f"to...
true
2,771,935,548
[Dynamo] Add functorch C++ bindings as in graph functions
yanboliang
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144309 * #144308 * #144307 * #144306 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,771,935,470
[Dynamo] Inline functions in torch._ops
yanboliang
closed
[ "Merged", "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #144309 * __->__ #144308 * #144307 * #144306 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,771,935,396
[Dynamo] Inline functions in torch._functorch.pyfunctorch
yanboliang
closed
[ "Merged", "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #144309 * #144308 * __->__ #144307 * #144306 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,771,935,348
[Dynamo] Inline functions in torch._functorch.autograd_function
yanboliang
closed
[ "Merged", "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #144309 * #144308 * #144307 * __->__ #144306 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,771,929,300
Set RUNPATH on CUDA and XPU tests
oraluben
closed
[ "triaged", "open source", "Merged", "ciflow/trunk", "topic: not user facing" ]
18
CONTRIBUTOR
#136627 has almost fixed the issue that test binaries' runpath has not been set correctly, with few cases left. This PR fixes the rest. The binaries are found by `auditwheel repair` a wheel built with `BUILD_TEST=1`. @malfet
true
2,771,888,232
Fix PythonMod printing
pytorchbot
closed
[ "module: cpu", "open source", "module: inductor", "ciflow/inductor" ]
7
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144078 cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPepp...
true
2,771,780,136
[WIP][Windows Inductor] Enable Inductor XPU backend on Windows.
etaf
closed
[ "module: cpu", "open source", "release notes: releng", "module: inductor", "module: dynamo", "ciflow/inductor" ]
1
COLLABORATOR
As title. cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @ColinPeppler @desertfire
true
2,771,774,132
Cannot get torch_python symbol
dilililiwhy
closed
[ "module: bc-breaking", "module: cpp", "triaged" ]
5
CONTRIBUTOR
### 🐛 Describe the bug It seems that torch_python symbol is hidden in nightly build of torch 2.7, which could be used in out-of-tree extension. For example, THP_FUNCTION_DEFAULT_PROPERTIES will be involved during code generation if the extension reuse the gen_autograd_functions module. ``` # undefined symbol: ...
true
2,771,732,375
[RFC] Fix CudaEventCache for dangling references
fduwjj
closed
[ "oncall: distributed", "release notes: distributed (c10d)", "topic: bug fixes" ]
5
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144301 Reported in https://github.com/pytorch/pytorch/issues/143470, we have a dangling references in CudaEventCache. So we want to fix it. 1. We add a unit test to repro the issue mentioned in the issue. 2. We tried to convert va...
true
2,771,730,369
[RFC] Fix race for CudaEventCache when launching collective not from main
fduwjj
closed
[ "oncall: distributed", "release notes: distributed (c10d)" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144300 * #144299 cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @wz337 @wconstab @d4l3k @c-p-i-o
true
2,771,730,252
Fix CudaEventCache for dangling references
fduwjj
closed
[ "oncall: distributed", "topic: not user facing" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #144300 * __->__ #144299
true
2,771,715,682
[mps/inductor] Add support for sign().
dcci
closed
[ "Merged", "topic: not user facing", "module: mps", "ciflow/mps", "module: inductor", "ciflow/inductor" ]
3
MEMBER
Drive-by fix of a test name while I was at it. cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhun...
true
2,771,686,992
operator benchmark change parsing from regex based to manual
apakbin
closed
[ "module: rocm", "triaged", "open source", "Merged", "module: benchmark", "ciflow/trunk", "release notes: benchmark" ]
7
CONTRIBUTOR
The regex-based parser would erroneously split on commas in nested brackets, for example, it would do the following parse which is wrong: 'M: [(32, 16), (64, 32)], ZPB: 2' -> ['M: [(32, 16)', ' (64, 32)]', 'ZPB: 2'] The new manual parser handles this situation the right way: 'M: [(32, 16), (64, 32)], ZPB: 2' -> ['...
true
2,771,679,096
Fix lint in `test_provenance_tracing.py`
malfet
closed
[ "Merged", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
6
CONTRIBUTOR
Regression introduced by https://github.com/pytorch/pytorch/pull/143684/ that somehow did not surface on PR CI IMO this also makes two branches of the test(compile vs aoti) more readable cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @y...
true
2,771,676,078
[export] Fix sym_bool serialization
yiming0416
closed
[ "fb-exported", "Merged", "ciflow/trunk", "ciflow/inductor", "release notes: export" ]
10
CONTRIBUTOR
Summary: When there is a `torch._check()` that checks if a sym_int is equal to some constant, it will generate 3 nodes in the graph with target `operation.ge`, `operator.le` and `operator.eq`. These operators belong to `_SYM_BOOL_OPS` but the `meta_val` of these nodes are are `bool` instead of `torch.SymBool`. Sim...
true
2,771,672,323
tuned_addmm: fix CK
coconutruben
closed
[ "module: rocm", "fb-exported", "Stale", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
3
CONTRIBUTOR
Summary: # Background The CK backend on addmm seems to fail because during autotuning we pass in (B, X, W) whereas the kernel is expecting (W,X,B) as its arguments. # What This change fixes that by passing through the modified ordering *for the choices during autotuning only* as the graph already seems to correctly ...
true
2,771,662,179
codecache: Remove cpp_prefix.h duplication per build, then precompile it
benjaminglass1
open
[ "open source", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
8
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #149961 * #148773 * __->__ #144293 Prior to this PR, `_inductor/codegen/cpp_prefix.h` was copied into a new temporary directory on every inductor run utilizing the CPP backend (i.e. CPU-only), then included in the output source code. Instea...
true
2,771,658,994
codecache: Remove cpp_prefix.h duplication per build, then precompile it
benjaminglass1
closed
[ "topic: not user facing", "module: inductor", "ciflow/inductor" ]
3
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144292 * #144002 * #143909 Prior to this PR, `_inductor/codegen/cpp_prefix.h` was copied into a new temporary directory on every inductor run utilizing the CPP backend, then included in the output source code. Instead, this puts it i...
true
2,771,658,186
codecache: Remove cpp_prefix.h duplication per build, then precompile it
benjaminglass1
closed
[ "module: inductor", "ciflow/inductor" ]
1
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * (to be filled) Prior to this PR, `_inductor/codegen/cpp_prefix.h` was copied into a new temporary directory on every inductor run utilizing the CPP backend, then included in the output source code. Instead, this puts it in an appropriate pla...
true
2,771,657,973
codecache: Remove cpp_prefix.h duplication per build, then precompile it
benjaminglass1
closed
[ "module: inductor", "ciflow/inductor" ]
2
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * (to be filled) Prior to this PR, `_inductor/codegen/cpp_prefix.h` was copied into a new temporary directory on every inductor run utilizing the CPP backend, then included in the output source code. Instead, this puts it in an appropriate pla...
true
2,771,656,197
[FSDP2] model weights are not DTensor after forward pass
qsh-zh
closed
[ "triaged", "module: fsdp" ]
5
NONE
### 🐛 Describe the bug When using FSDP2, certain parameters are not DTensor before the backward pass, but appear as DTensor after the backward pass. The inconsistency surprises users. For example, when I need to copy the Exponential Moving Average (EMA) model weights to the regular model after the regular model...
true
2,771,646,530
[inductor] Only call triton.compile in worker processes
jansel
closed
[ "Stale", "module: inductor", "ciflow/inductor", "release notes: inductor" ]
4
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144288 Before this parallel compile would call triton.compile once in a subprocess (to warm the disk cache) then again in the parent to load the result with cache hit. This calls triton.compile once in the subprocess then pickles th...
true
2,771,643,569
[BE] Actually suppress vmap warning from gradcheck
janeyx99
closed
[ "Merged", "ciflow/trunk", "release notes: autograd" ]
8
CONTRIBUTOR
This is the much safer change compared to https://github.com/pytorch/pytorch/pull/144283 Before: ``` PYTORCH_TEST_CUDA_MEM_LEAK_CHECK=1 PYTORCH_TEST_WITH_SLOW_GRADCHECK=1 python test/test_optim.py -k TestDifferentiableOptimizer.test_sgd /data/users/janeyx/pytorch/torch/autograd/gradcheck.py:1156: FutureWarning:...
true
2,771,625,343
[DTensor] Add sharding strategy to aten.view.dtype
cassanof
closed
[ "oncall: distributed", "module: dtensor" ]
1
CONTRIBUTOR
### 🚀 The feature, motivation and pitch Would be great to have a sharding strategy for aten.view.dtype. Currently, when doing .view(dtype) on a DTensor, you get the following error: ``` Operator aten.view.dtype does not have a sharding strategy registered. ``` This has caused issues for FSDP2 + stochastic round...
true
2,771,572,647
[CD] Aarch64 builds should not override `OVERRIDE_PACKAGE_VERSION` envvar
atalman
closed
[ "Merged", "release notes: releng", "topic: binaries" ]
10
CONTRIBUTOR
Currently our nightly aarch64 binaries have correct suffixes +cpu or +cu126. But release binaries are missing these suffixes. Hence to correct this, make sure are nightly and release binaries are consistent, I propose this change. I see that override is already set correctly in release workflow: https://github.com/...
true
2,771,560,932
[reland][export] don't decompose custom triton op when exporting
ydwu4
closed
[ "fb-exported", "Merged", "ciflow/trunk", "release notes: export", "ci-no-td" ]
11
CONTRIBUTOR
Summary: A reland of https://github.com/pytorch/pytorch/pull/142426. Copying the description over here: For torch.export (strict and non-strict), we don't do functional decomposition. Instead, we preserve the custom triton ops as custom ops. This is because we want the exported program to be high-level and serializab...
true
2,771,558,100
[BE] stop using deprecated _vmap in our library
janeyx99
closed
[ "release notes: autograd", "topic: improvements" ]
5
CONTRIBUTOR
This was causing warnings for those using gradcheck among other APIs potentially, thanks @EmmettBicker for raising this to our awareness in https://github.com/pytorch/pytorch/pull/143938! Tests should pass as this should be a functional no-op, and there should be fewer printouts. => I was wrong. Jeffrey is right to ...
true
2,771,445,451
[EZ][BE] Fix E226 flake8 violation
malfet
closed
[ "Merged", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
4
CONTRIBUTOR
Not sure why CI did not complain about it, but it my local runs it clearly says ``` Advice (FLAKE8) E226 missing whitespace around arithmetic operator See https://www.flake8rules.com/rules/E226.html 268 | with code.indent(): 269 | if len(idx_var_names) > 1: ...
true
2,771,443,024
[MPSInductor] Add `nan` constant generation
malfet
closed
[ "Merged", "topic: not user facing", "ciflow/mps", "module: inductor", "ciflow/inductor" ]
3
CONTRIBUTOR
If val is not equal to self, it's a nan (which is spelled as `NAN` in Metal) cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov
true
2,771,366,317
Fix broken links in markdown files
AlexanderDokuchaev
closed
[ "oncall: jit", "module: mkldnn", "open source", "Stale", "topic: not user facing" ]
5
NONE
cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh @mingfeima @ashokei @jingxu10 @min-jean-cho @yanbing-j @Guobing-Chen @Xia-Weiwen @snadampal
true
2,771,339,048
`kl_divergence` can produce incorrect results
randolf-scholz
closed
[ "module: nn", "triaged" ]
0
CONTRIBUTOR
### 🐛 Describe the bug ```python from torch.distributions import * p = Uniform(0,1) q = Beta(1,1) # special case, equal to Uniform(0,1) kl_divergence(p, q) # tensor(nan) ❌ kl_divergence(p, p) # tensor(0) ✅ ``` This is caused by incorrect implementation of the mathematical function $f(x)=x⋅\log(x)$, it s...
true
2,771,336,244
fix non-strict placeholder naming with kwargs
avikchaudhuri
closed
[ "fb-exported", "Merged", "ciflow/trunk", "ciflow/inductor", "release notes: export" ]
10
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144278 Fixes https://github.com/pytorch/pytorch/issues/143732 Differential Revision: [D67872055](https://our.internmc.facebook.com/intern/diff/D67872055/)
true
2,771,334,829
[Inductor] [bc-breaking] Node Level provenance tracking
yushangdi
closed
[ "fb-exported", "Merged", "ciflow/trunk", "release notes: fx", "fx", "module: inductor", "ciflow/inductor", "suppress-bc-linter" ]
6
CONTRIBUTOR
Summary: - use GraphTransformObserver + replace_node hooks to track node sources when they are replaced - add pre_grad_graph tracking to tlparse - add the node provenance information to post_grad_graph tlparse. This is for the frontend to create a mapping between pre_grad and post_grad graph. See an example fronte...
true
2,771,320,134
[functorch] clean up asserts in `test_dims.py`
eqy
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing", "ciflow/periodic", "module: functorch", "module: python version" ]
9
COLLABORATOR
For better debuggability of issues encountered in e.g., #141730 when trying to migrate to python 3.12/3.13 cc @zou3519 @Chillee @samdow @kshitij12345
true
2,771,301,328
Dynamo fails on `types.UnionType`s
ar0ck
open
[ "triaged", "oncall: pt2", "module: dynamo", "oncall: export" ]
2
CONTRIBUTOR
### 🐛 Describe the bug ```python import torch class Mod(torch.nn.Module): def forward(self): int | float torch.export.export(Mod(), ()) ``` ### Error logs ```python Traceback (most recent call last): File "bug.py", line 7, in <module> torch.export.export(Mod(), ()) File "/.../lib/p...
true
2,771,275,741
update expected results
laithsakka
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
8
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144274 this PR https://github.com/pytorch/pytorch/commit/f6488d85a013e0ec9d5415c29d78ec3f93b3c0ec made it +1.3% < 1.5%. once we have the API from dev infra and change the test this wont be happening. <img width="364" alt="Scre...
true
2,771,248,350
The axis name set by `torch.export.Dim` is not in ExportedProgram
titaiwangms
closed
[ "oncall: pt2", "oncall: export" ]
4
COLLABORATOR
### 🐛 Describe the bug ```python import torch class Model(torch.nn.Module): def forward(self, x, y): return x + y dim = torch.export.Dim("batch", min=1, max=6) ep = torch.export.export( Model(), (torch.randn(2, 3), torch.randn(2, 3)), dynamic_shapes=[{0: dim}, {0: dim}], ) ``` ...
true
2,771,238,000
add inductor_triton_kernel_mapping_post_grad.json to tlparse
YUNQIUGUO
closed
[ "fb-exported", "Stale", "ciflow/trunk", "topic: not user facing", "module: inductor", "module: dynamo", "ciflow/inductor" ]
17
CONTRIBUTOR
Summary: Add debug trace artifact to inductor_triton_kernel_mapping_post_grad.json to tlparse as well Test Plan: https://manifold.edge.x2p.facebook.net/v0/read/tree/logs/.tmpvUPL3i/index.html?bucketName=tlparse_reports&apiKey=tlparse_reports-key&withPayload=1&timeoutMsec=100 Differential Revision: D67612181 cc @v...
true
2,771,195,720
fix torch.compile + ddp + non-reentrant AC pack hook firing count
xmfan
closed
[ "module: activation checkpointing", "module: ddp", "Merged", "ciflow/trunk", "release notes: distributed (ddp)", "module: dynamo", "ciflow/inductor", "release notes: dynamo" ]
15
MEMBER
FIXES https://github.com/pytorch/pytorch/issues/144035 In order to preserve hook firing semantics, we disabled pack/unpack hooks for torch.compile: https://github.com/pytorch/pytorch/pull/123196. In DDP under torch.compile, there's this other callsite that we need to disable hooks for Stack from [ghstack](https:/...
true
2,771,159,599
[BE][Ez]: Fix docs recommending inefficient tensor op order
Skylion007
closed
[ "open source", "better-engineering", "Merged", "ciflow/trunk", "topic: not user facing" ]
4
COLLABORATOR
`detach().clone()` is faster than `.clone().detatch()` since the gradients are not cloned. Let's update all the documentation and tests so that users do not use the inefficient op ordering.
true
2,771,145,943
[BE]: Remove redundant copy in torch chunk shard
Skylion007
closed
[ "oncall: distributed", "open source", "better-engineering", "Merged", "ciflow/trunk", "topic: not user facing" ]
3
COLLABORATOR
Fixes an issue noticed in recent all_gather PR. Some parts of the codebase have a double copy with `clone().contiguous()` which could be fused into a single copy op. cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o
true
2,771,141,346
[pytorch][fdx] fix TSAN complains in multi-threaded environment
ms-meta
closed
[ "oncall: jit", "fb-exported", "module: amp (automated mixed precision)", "Stale", "ciflow/trunk", "release notes: jit" ]
5
NONE
TSAN finds that some `pyTorch***` components read & write few global variables from different threads ThreadSanitizer: data race fbcode/caffe2/torch/csrc/jit/passes/autocast.cpp:513 in torch::jit::setAutocastMode(bool) ThreadSanitizer: data race fbcode/caffe2/torch/csrc/jit/operator_upgraders/version_map.cpp:103 in t...
true
2,771,091,212
Make all-reduce input contiguous in `distributed.nn.all_reduce`
awgu
closed
[ "oncall: distributed", "Merged", "ciflow/trunk", "release notes: distributed (c10d)" ]
3
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144267 Fixes https://github.com/pytorch/pytorch/issues/144060 I confirmed that the unit test fails without the `.contiguous()` fix. cc @H-Huang @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o
true
2,771,058,327
Update #graph breaks for moco benchmark
guilhermeleobas
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
3
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144266 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,771,020,351
Migrate from Tuple -> tuple in torch/ao
bobrenjc93
closed
[ "Merged", "ciflow/trunk", "release notes: quantization", "topic: not user facing", "fx", "release notes: AO frontend" ]
9
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144265 cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv
true
2,771,020,218
Migrate from Tuple -> tuple in torch/_inductor
bobrenjc93
closed
[ "module: rocm", "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
11
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144264 cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @j...
true
2,771,020,072
Migrate from Tuple -> tuple in torch/_functorch
bobrenjc93
closed
[ "ciflow/trunk", "topic: not user facing", "ciflow/inductor", "release notes: AO frontend" ]
11
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144263
true
2,771,019,932
Migrate from Tuple -> tuple in torch/_export
bobrenjc93
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "ciflow/inductor", "release notes: export" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #144265 * #144264 * #144263 * __->__ #144262
true
2,771,019,797
Migrate from Tuple -> tuple in torch/_dynamo
bobrenjc93
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: dynamo", "ciflow/inductor", "module: compiled autograd" ]
13
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144261 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @xmfan @yf225
true
2,771,019,681
Migrate from Tuple -> tuple in torch/_decomp
bobrenjc93
closed
[ "Merged", "Reverted", "ciflow/trunk", "topic: not user facing", "ciflow/inductor", "ci-no-td" ]
19
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144260
true
2,771,019,546
Migrate from Tuple -> tuple in benchmarks
bobrenjc93
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
9
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #144265 * #144264 * #144263 * #144262 * #144261 * #144260 * __->__ #144259 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,771,019,430
Migrate from Tuple -> tuple in torch/distributed
bobrenjc93
closed
[ "oncall: distributed", "Merged", "ciflow/trunk", "release notes: distributed (sharded)", "topic: not user facing", "ciflow/inductor" ]
23
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144258 cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @LucasLLC @MeetVadakkanchery @mhorowitz @pradeepfn @ekr0
true
2,771,019,273
Migrate from Tuple -> tuple in torch/profiler
bobrenjc93
closed
[ "Merged", "ciflow/trunk", "topic: not user facing" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #144265 * #144264 * #144263 * #144262 * #144261 * #144260 * #144259 * #144258 * __->__ #144257
true
2,771,019,158
Migrate from Tuple -> tuple in torch/testing
bobrenjc93
closed
[ "oncall: distributed", "oncall: jit", "Merged", "ciflow/trunk", "release notes: distributed (rpc)", "topic: not user facing" ]
12
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144256 cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @EikanWang @jgong5 @wenzhe-nrv @sanchitintel
true
2,771,019,033
Migrate from Tuple -> tuple in torch/utils/data
bobrenjc93
closed
[ "Merged", "ciflow/trunk", "release notes: dataloader", "topic: not user facing" ]
6
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144255
true
2,771,018,912
Migrate from Tuple -> tuple in test/distributed/_composable
bobrenjc93
closed
[ "oncall: distributed", "Merged", "ciflow/trunk", "topic: not user facing" ]
14
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144254 cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o
true
2,771,018,775
Migrate from Tuple -> tuple in benchmarks/instruction_counts/core
bobrenjc93
closed
[ "Merged", "ciflow/trunk", "topic: not user facing" ]
9
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144253
true
2,770,992,888
Update torch to py39 type annotations
aorenste
closed
[ "oncall: distributed", "oncall: jit", "module: rocm", "module: cpu", "module: amp (automated mixed precision)", "release notes: quantization", "release notes: releng", "fx", "module: inductor", "module: dynamo", "ciflow/inductor", "module: compiled autograd" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144252 cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @EikanWang @jgong5 @wenzhe-nrv @sanchitintel @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxi...
true
2,770,958,158
[MPS] Fix bitwise shifts for uint8
malfet
closed
[ "Merged", "topic: bug fixes", "release notes: mps", "ciflow/mps" ]
5
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144251 * #144250 * #144249 Previosly all bitwise operations were aliased to the same type, but this is wrong for shift ops Rather than building an overly complex logic, let's just instantiate using shared `scalarToMetalTypeString` h...
true
2,770,958,039
[BE] Fix + parametrize `test_min_max_nan_propagation`
malfet
closed
[ "Merged", "topic: not user facing", "ciflow/mps" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #144251 * __->__ #144250 * #144249 - `dtype` was not passed as argument to `torch.rand` before - Condition bfloat16 testing on MacOS14+
true
2,770,957,908
[BE] Parametrize `test_min_max`
malfet
closed
[ "Merged", "topic: not user facing", "ciflow/mps" ]
6
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #144251 * #144250 * __->__ #144249 It's better to have one unit test per dtype rather a combined one
true
2,770,800,583
[inductor][cpu] Fix bmm b_index for dynamic expressions in inductor autotuner
pytorchbot
closed
[ "open source", "module: inductor", "ciflow/inductor" ]
2
COLLABORATOR
Fixes #143102 Addresses 2 problems relating to dynamic batch size in BMM autotuner: 1. With dynamic batch size, when the input is a sympy Mult expression, such as `s0*8` which occurs in many dynamo benchmark models. We address this by using `size_hints` to solve for any expressions. This is safe since this section...
true
2,770,643,439
[inductor][cpu] torch.bitwise_and/or/xor incorrectly accepts float32 tensors
maybeLee
open
[ "module: error checking", "oncall: pt2", "oncall: cpu inductor" ]
2
CONTRIBUTOR
### 🐛 Describe the bug It's not a severe problem but I report this issue anyway since the actual behavior deviated from what it is expected in the documentation. According to the documentation (e.g., https://pytorch.org/docs/stable/generated/torch.bitwise_not.html), `torch.bitwise_and/or/xor` only accepts boolean ...
true
2,770,509,828
[Inductor] Unify the data type propagation between Triton and CPP Backend
leslie-fang-intel
closed
[ "oncall: pt2", "oncall: cpu inductor" ]
6
COLLABORATOR
### 🚀 The feature, motivation and pitch Previously, `dtype` is the attr of `CppCSEVariable` but not `CSEVariable`. And thus CPP backend has its data type propagation mechanism in `CppCSEVariable.update_on_args`: https://github.com/pytorch/pytorch/blob/d85ae4be734cfd53f5b893240894381ac65fe8b4/torch/_inductor/codegen...
true
2,770,403,577
F.interpolate returns NAN on MPS if align_corner is True.
benHeid
closed
[ "module: nn", "triaged", "module: correctness (silent)", "module: mps" ]
3
NONE
### 🐛 Describe the bug When using interpolate on MPS with align_corner=True, the result consists only of NaN value, which is inconsistent to the CPU implementation. You can replicate this by the following code snippet: ```python import torch import torch.nn.functional as F test = torch.Tensor([[1],[2],[...
true
2,770,306,177
ImportError: Undefined symbol in libcusparse.so.12 with PyTorch 2.5.1 and CUDA 12.2
Hmiru
closed
[ "module: binaries", "module: cuda" ]
1
NONE
### 🐛 Describe the bug ### Problem Description I encountered an `ImportError` when running a PyTorch script with CUDA 12.2 and PyTorch 2.5.1. The error indicates an undefined symbol in `libcusparse.so.12`. ### Error ```bash python -c "import torch; print('CUDA Available:', torch.cuda.is_available())" Traceback...
true
2,770,295,254
[Inductor][CPP] Fix outer loop fusion buffer removed
leslie-fang-intel
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
6
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144243 **Summary** Fix issue: https://github.com/pytorch/pytorch/issues/144186. For the test case reported in the issue, we have saw some nodes with `LoopNest` - `LoopNest(loops=[LoopLevel(var=x0, size=8, offset=0, tiled_size=0...
true
2,770,268,197
Exporting the operator 'aten::_transformer_encoder_layer_fwd' to ONNX opset version 17 is not supported
jayakommuru
open
[ "module: onnx", "triaged" ]
24
NONE
### 🐛 Describe the bug Using the following code to convert torch model (torch.nn.Module) to onnx but getting `Exporting the operator 'aten::_transformer_encoder_layer_fwd' to ONNX opset version 17 is not supported` ``` input_names = ["input__0", "input__1", "input__2"] output_names = ["output__0"] with torch.n...
true
2,770,237,255
Core dumped happens when avg_pool1d with torch.compile receives uint tensor with specific tensor shape
maybeLee
open
[ "triaged", "oncall: pt2", "module: inductor" ]
7
CONTRIBUTOR
### 🐛 Describe the bug Program crashes when running the following code: ```python # toy.py import torch torch.random.manual_seed(0) input = torch.randn(1,8,1).to(torch.uint8) kernel_size = 4 stride = 46 padding = 2 f = torch.nn.functional.avg_pool1d cf = torch.compile(f) cf(input,kernel_size,stride,pad...
true
2,770,148,047
[Intel GPU] add tf32 support for matmul on XPU
jianyizh
open
[ "module: cpu", "triaged", "open source", "topic: not user facing", "release notes: xpu" ]
32
CONTRIBUTOR
Support xpu tf32 matmul using torch.bachend.mkldnn.allow_tf32, we will discuss in future if we need a new api to control matmul only ~~Support xpu tf32 matmul using torch.set_float32_matmul_precision. For conv, check https://github.com/pytorch/pytorch/pull/137570 We decide not following torch.backends.cuda.matmul.all...
true
2,770,124,096
Integrate ULFM and FTI for OpenMPI (torch.distributed)
Belegkarnil
open
[ "oncall: distributed", "feature" ]
1
NONE
### 🚀 The feature, motivation and pitch I am working on a distributed framework and I want to be able to manage node failures. Is is possible to integrate the use of _User Level Failure Mitigation_ ([ULFM](https://github.com/ICLDisco/ulfm-testing)) and _Fault Tolerance Interface_ ([FTI](https://github.com/leobago/fti...
true
2,770,074,566
[Break XPU][Inductor UT] Remove excepted failure for aoti test_fft_c2c
etaf
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor", "ciflow/xpu" ]
3
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144238 Since #143223 enabled runtime dispatch for fft_c2c in AOTI mod, for XPU, we can fallback fft_c2c which has no XPU implementation to CPU and pass the case now. cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen ...
true
2,770,045,309
[Profiler] Fix device setting error of other backends in torch.profiler
fmo-mt
closed
[ "open source", "oncall: profiler", "Merged", "ciflow/trunk", "release notes: profiler" ]
8
CONTRIBUTOR
In earlier implementation, if `self.use_device != "cuda"` and `device is None`, we would get a `device = "cpu"` from line401, which is not as expected. cc @robieta @chaekit @guotuofeng @guyang3532 @dzhulgakov @davidberard98 @briancoutinho @sraikund16 @sanrise
true
2,770,042,945
Update slow tests
pytorchupdatebot
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing", "ciflow/slow", "ci-no-td" ]
3
COLLABORATOR
This PR is auto-generated weekly by [this action](https://github.com/pytorch/pytorch/blob/main/.github/workflows/weekly.yml). Update the list of slow tests.
true
2,769,996,663
[TreeSpec] Support enum in defaultdict
henryhu6
closed
[ "fb-exported", "Merged", "ciflow/trunk", "topic: not user facing", "module: pytree" ]
8
CONTRIBUTOR
Summary: Followup from D66269157, add support for enum in defaultdict. Test Plan: Added unit test Differential Revision: D67832100 cc @zou3519 @XuehaiPan
true
2,769,883,522
increase max value for triton block check
mengluy0125
closed
[ "fb-exported", "Stale", "module: inductor", "ciflow/inductor", "release notes: inductor" ]
4
CONTRIBUTOR
Differential Revision: D67844450 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov
true
2,769,847,614
remove allow-untyped-defs from torch/_prims/executor.py
bobrenjc93
closed
[ "Merged", "ciflow/trunk", "topic: not user facing" ]
4
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144233
true
2,769,847,557
remove allow-untyped-defs from ao/nn/sparse/quantized/utils.py
bobrenjc93
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "release notes: AO frontend" ]
6
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #144233 * __->__ #144232
true
2,769,847,486
remove allow-untyped-defs from torch/nn/utils/_deprecation_utils.py
bobrenjc93
closed
[ "Merged", "ciflow/trunk", "topic: not user facing" ]
12
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144231
true
2,769,847,424
remove allow-untyped-defs from torch/export/_remove_auto_functionalized_pass.py
bobrenjc93
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "release notes: export" ]
15
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #144230
true
2,769,798,593
Issues with onnx package for pytorch build in WIndows 11
jenetscaria-mcw
open
[ "module: onnx", "module: build", "module: windows", "triaged" ]
2
NONE
### 🐛 Describe the bug Pytorch 2.5.1 build with clang fails in Windows 11 with unknown type name errors for various onnx sub modules. ``` C:/Users/mcw/Documents/Jenet/pytorch/third_party/onnx/onnx/checker.h:148:27: error: unknown type name 'SequenceProto' 148 | void check_sequence(const SequenceProto& sequence...
true
2,769,759,041
grad_fn function disobeys broadcast rules
Girafboy
open
[ "module: autograd", "triaged", "needs research" ]
0
NONE
### grad_fn function disobeys broadcast rules In the following code, `z.grad_fn` is `MulBackward0`. It should be the inverse of multiplication. However, the shapes of `x` and `x_` differ. ``` import torch x = torch.randn(2, 1, requires_grad=True) y = torch.randn(2, 3, requires_grad=True) z = x * y x_, y_ = z...
true
2,769,738,907
[mps/inductor] MPSBasicTests.test_max_min fails on macOS
dcci
closed
[ "needs reproduction", "triaged", "module: mps", "module: inductor" ]
6
MEMBER
### 🐛 Describe the bug Log: ``` % python test/inductor/test_mps_basic.py MPSBasicTests.test_max_min /Users/davidino/pytorch/pytorch/torch/utils/_config_module.py:440: UserWarning: Skipping serialization of skipfiles_inline_module_allowlist value {} warnings.warn( Finline_call [] stats [('calls_captured', 6)...
true
2,769,723,124
Enable bugprone-unchecked-optional-access
cyyever
closed
[ "oncall: distributed", "triaged", "open source", "Merged", "ciflow/trunk", "release notes: cpp" ]
6
COLLABORATOR
We can actually enable bugprone-unchecked-optional-access without the risk of hang. cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o
true