message
stringlengths
13
484
diff
stringlengths
38
4.63k
Fix for tweak SConscript() docstrings a little more Also handle_missing_SConscript(), internal interface added by this patch series.
@@ -156,8 +156,16 @@ stack_bottom = '% Stack boTTom %' # hard to define a variable w/this name :) def handle_missing_SConscript(f, must_exist=None): """Take appropriate action on missing file in SConscript() call. - The action may be to raise an exception, or print a warning. - On first warning, also print a deprecatio...
Putting proto numbers back as they were [skip CI]
@@ -40,7 +40,7 @@ service Requests { } message CreateHostRequestReq { - int64 host_id =5; + int64 host_id =1; // dates as "yyyy-mm-dd", in the timezone of the host string from_date = 2; string to_date = 3; @@ -49,8 +49,8 @@ message CreateHostRequestReq { message HostRequest { int64 host_request_id = 1; - int64 surfer_i...
Remove raw data with invalid committee_id values. Fixes more of
@@ -103,6 +103,14 @@ c.execute("DELETE FROM raw_table WHERE LENGTH(date_recieved) < 10") # set empty, non-zero, strings in date columns to null c.execute("UPDATE raw_table SET report_period_begin = NULL WHERE LENGTH(report_period_begin) < 10") c.execute("UPDATE raw_table SET report_period_end = NULL WHERE LENGTH(report...
Move pip fix to top of test-make-requirements.sh Previously I had put it below `make requirements` which defeats the purpose.
#!/usr/bin/env bash set -e -make requirements -git --no-pager diff -git update-index -q --refresh # 19.3.1 causes locally reproduceable test failure # todo: remove this line once that's no longer a problem pip install 'pip<19.3.0' + +make requirements +git --no-pager diff +git update-index -q --refresh if git diff-inde...
Update Aparecida de Goiania spider Update spider code to follow latest best practices: Set a default `start_date` value Avoid the usage of `dateparser` when built-in `datetime` functions accomplish the same Remove not needed log
-import json - -from dateparser import parse +import datetime from gazette.items import Gazette from gazette.spiders.base import BaseGazetteSpider @@ -11,26 +9,22 @@ class GoAparecidaDeGoianiaSpider(BaseGazetteSpider): name = "go_aparecida_de_goiania" allowed_domains = ["aparecida.go.gov.br"] start_urls = ["https://web...
allow compile_go to execute on windows Does some contortions to allow executing go build while also not blocking the caldera server's event loop.
-import asyncio.subprocess +import asyncio import base64 import copy import os +import subprocess from aiohttp import web from cryptography.fernet import Fernet @@ -159,7 +160,7 @@ class FileSvc(BaseService): return buf async def compile_go(self, platform, output, src_fle, arch='amd64', ldflags='-s -w', cflags='', buil...
Add 'indent' option to CLI commands xml2json/json2xml - Option 'converter' is now case-insensitive
@@ -24,12 +24,12 @@ from xmlschema.etree import etree_tostring PROGRAM_NAME = os.path.basename(sys.argv[0]) CONVERTERS_MAP = { - 'Unordered': xmlschema.UnorderedConverter, - 'Parker': xmlschema.ParkerConverter, - 'BadgerFish': xmlschema.BadgerFishConverter, - 'Abdera': xmlschema.AbderaConverter, - 'JsonML': xmlschema.J...
Fix local `clusterfuzz` server error Fix by upgrading `openjdk-8-jdk` to `openjdk-11-jdk`.
@@ -111,7 +111,7 @@ sudo apt-get update sudo apt-get install -y \ docker-ce \ google-cloud-sdk \ - openjdk-8-jdk \ + openjdk-11-jdk \ liblzma-dev # Install patchelf - latest version not available on some older distros so we
Update of readme_template.md Please note that this patch explitly set which `pip` version to use according to the user Python version.
@@ -43,13 +43,15 @@ To run unit tests, in the top level directory, just run: python testUpdateHostsFile.py -**Note** if you are using Python 2, please install the dependencies with: +**Note** if you are using Python 3, please install the dependencies with: - pip install -r requirements_python2.txt + pip3 install --user...
Add logging filter for AmpConnectionRetry exception We do not need to log exception info about AmpConnectionRetry as this is expected exception, which enables retry process for AmphoraComputeConnectivityWait task. Story:
@@ -21,6 +21,7 @@ from sqlalchemy.orm import exc as db_exceptions from taskflow.listeners import logging as tf_logging import tenacity +from octavia.amphorae.driver_exceptions import exceptions from octavia.api.drivers import utils as provider_utils from octavia.common import base_taskflow from octavia.common import co...
Adds specification of gauge group to make_qutrit_gateset. Previously, make_qutrit_gateset would create a GateSet of fully parameterized gates without specifying a gauge group. Now this function sets a default full-gauge-group as it should.
@@ -151,5 +151,6 @@ def make_qutrit_gateset(errorScale, Xangle = _np.pi/2, Yangle = _np.pi/2, qutritGS['Gy'] = _objs.FullyParameterizedGate(arrType(gateYSOfinal)) qutritGS['Gm'] = _objs.FullyParameterizedGate(arrType(gateMSOfinal)) qutritGS.set_basis(basis,3) + qutritGS.default_gauge_group = _objs.gaugegroup.FullGaugeG...
move git-diff and log commands to subshell this ensures the redirection is made to the correct file closes
@@ -130,10 +130,13 @@ def main() -> None: # it does not matter for git. repodir = os.path.dirname(os.path.realpath(__file__)) - os.system("cd {}/..; git log -1 --format=%H > {}" + # we need to execute the git log command in subshell, because if + # the log file is specified via relative path, we need to do the + # redi...
fix: renamed_argument decorator error Also, I removed hidden mutation of input in _handling function
@@ -102,12 +102,16 @@ def renamed_argument(old_name: str, new_name: str, until_version: str, stackleve is_coroutine = asyncio.iscoroutinefunction(func) def _handling(kwargs): + """ + Returns updated version of kwargs. + """ routine_type = 'coroutine' if is_coroutine else 'function' if old_name in kwargs: warn_deprecate...
Create checksum files with CI archives Create a sha256 file for use with the sha256sum tool to verify the integrity of artifacts created by the CI jobs. Make these files available in both the Jenkins UI alongside the the tarballs, and also upload them over SSH (where applicable).
@@ -362,10 +362,14 @@ parameters = [ 'builder_shell', script='\n'.join([ 'echo "# BEGIN SECTION: Compress install space"', - 'tar -cjf $WORKSPACE/ros%d-%s-linux-%s-%s-ci.tar.bz2 ' % (ros_version, rosdistro_name, os_code_name, arch) + - ' -C $WORKSPACE/ws' + + 'cd $WORKSPACE', + 'tar -cjf ros%d-%s-linux-%s-%s-ci.tar.bz2...
use mimetype to see if it's a GIF thanks to good idea
@@ -938,7 +938,7 @@ class Client(object): return self._doSendRequest(data) - def _uploadImage(self, image_path, data, mimetype, is_gif=False): + def _uploadImage(self, image_path, data, mimetype): """Upload an image and get the image_id for sending in a message""" j = self._postFile(self.req_url.UPLOAD, { @@ -949,7 +94...
website: fixed "Check your credentials" after login the reactContext json content of userdata the tag 'altText' contained a tab char
@@ -164,6 +164,7 @@ def extract_json(content, name): json_str = json_str.replace('\"', '\\"') # Escape double-quotes json_str = json_str.replace('\\s', '\\\\s') # Escape \s json_str = json_str.replace('\\n', '\\\\n') # Escape line feed + json_str = json_str.replace('\\t', '\\\\t') # Escape tab json_str = json_str.decod...
Fix handling of default values of hypervisor. Avoid showing the deprecation warning for libvirt:hypervisor property if the user provided a value to the hypervisor parameter in virt.init.
@@ -1368,7 +1368,7 @@ def init(name, caps = capabilities(**kwargs) os_types = sorted({guest['os_type'] for guest in caps['guests']}) arches = sorted({guest['arch']['name'] for guest in caps['guests']}) - hypervisors = sorted({x for y in [guest['arch']['domains'].keys() for guest in caps['guests']] for x in y}) + if not...
Updating my Bhagavad Gita API `url` : new domain `auth` : apiKey
@@ -124,6 +124,7 @@ API | Description | Auth | HTTPS | CORS | ### Books API | Description | Auth | HTTPS | CORS | |---|---|---|---|---| +| [Bhagavad Gita](https://docs.bhagavadgitaapi.in) | Open Source Shrimad Bhagavad Gita API including 21+ authors translation in Sanskrit/English/Hindi | `apiKey` | Yes | Yes | | [Bhag...
Update main.py documenatation
@@ -45,12 +45,12 @@ def multi_criteria_main(locator, config): generation = config.multi_criteria.generations category = "optimization-detailed" + # TODO: this part is redundant for DH, check if that is true for DC # get path to data of the generation specified # if not os.path.exists(locator.get_address_of_individuals_...
Display classes on home page to learners who can only access assigned content but are not enrolled in any classes.
<div> <YourClasses - v-if="isUserLoggedIn && classes.length" + v-if="displayClasses" class="section" :classes="classes" data-test="classes" ); }); + const displayClasses = computed(() => { + return get(isUserLoggedIn) && (get(classes).length || !get(canAccessUnassignedContent)); + }); + return { isUserLoggedIn, channel...
demos/CMakeLists.txt: make header files belong to their respective demo This enables IDEs to show them as part of the project. The code to do it was already there, but it was broken.
@@ -159,13 +159,13 @@ macro(ie_add_sample) # Create named folders for the sources within the .vcproj # Empty name lists them directly under the .vcproj - source_group("src" FILES ${IE_SAMPLES_SOURCES}) - if(IE_SAMPLES_HEADERS) - source_group("include" FILES ${IE_SAMPLES_HEADERS}) + source_group("src" FILES ${IE_SAMPLE_...
reference: minor reformatting (no-tn-check)
@@ -53,15 +53,14 @@ def reference(nodes, through, transitive=False, visible_to_children=False): :param AbstractExpression nodes: An expression that yields a list of nodes. :param PropertyDef through: A property reference. - :param bool visible_to_children: If true, then the referenced - environment will be visible to t...
add bbknn to scAEspy It's a dimensionality reduction technique that was shown to work with BBKNN, rather than alone
@@ -18,7 +18,7 @@ Tools to be compared include: - [Harmony](https://github.com/immunogenomics/harmony) - [scMerge](https://github.com/SydneyBioX/scMerge) - [scAlign](https://github.com/quon-titative-biology/scAlign) -- [scAEspy](https://gitlab.com/cvejic-group/scaespy) +- BBKNN + [scAEspy](https://gitlab.com/cvejic-gro...
Update Akinator.py This is in reference to issue
@@ -85,7 +85,7 @@ def main_game(jarvis): subprocess.run([imageViewerFromCommandLine, aki.picture]) # display image of answer except Exception: pass - correct = jarvis.input(f"It's {aki.name} ({aki.description})! Was I correct?\n\t") + correct = jarvis.input(f"It's {aki.first_guess['name']} ({aki.first_guess['descriptio...
Also check if if file_writer_config['upto_animation_number'] is not infinity. before not removing files of greater indices.
@@ -441,7 +441,7 @@ class SceneFileWriter(object): } if file_writer_config['from_animation_number'] is not None: kwargs["min_index"] = file_writer_config['from_animation_number'] - if file_writer_config['upto_animation_number'] is not None: + if file_writer_config['upto_animation_number'] not in [None, np.inf]: kwargs[...
(#10167) libbacktrace: Bug when using Conan 2 profile mode * libbacktrace: Bug when using Conan 2 profile mode Make libbacktrace build work in Conan's 2 profile mode (host and build profile). * Removed comments * getattr change
@@ -65,15 +65,19 @@ class LibbacktraceConan(ConanFile): tools.get(**self.conan_data["sources"][self.version], destination=self._source_subfolder, strip_root=True) + @property + def _user_info_build(self): + return getattr(self, "user_info_build", self.deps_user_info) + @contextlib.contextmanager def _build_context(self...
Configure travis pycodestyle to ignore pep8 error E402 Because right now we fixed all the detected pep8 errors, this commit configures codestyle test to ignore pep8 error E402 (module level import not at top of file). So this way the tests should work as expected.
@@ -16,7 +16,7 @@ install: - pip install pylint - pip install -e .[test] script: - - pycodestyle coherence --ignore=E122,E303,E501, + - pycodestyle coherence --ignore=E402 - pylint -E coherence - nosetests --with-coverage --cover-erase --cover-package=coherence --cover-html after_success:
Remove erroneous data keying. Add with_fetch_all to most list endpoint requests.
@@ -141,7 +141,9 @@ def list_files(project_id, branch_id): List all Source Files for a given branch """ with handle_api_exception("Listing files"): - response = crowdin_client.source_files.list_files(project_id, branch_id) + response = crowdin_client.source_files.with_fetch_all().list_files( + project_id, branch_id + )...
[ATen] Exclude CUDA tests when running `basic` under valgrind Summary: Pull Request resolved: Test Plan: CI
@@ -53,7 +53,7 @@ if [[ -x ./cuda_tensor_interop_test ]]; then fi if [ "$VALGRIND" == "ON" ] then - valgrind --suppressions="$VALGRIND_SUP" --error-exitcode=1 ./basic "[cpu]" + valgrind --suppressions="$VALGRIND_SUP" --error-exitcode=1 ./basic --gtest_filter='-*CUDA' valgrind --suppressions="$VALGRIND_SUP" --error-exit...
[benchmark] Expose running benchmarks with lowering [benchmark] Expose running benchmarks with lowering
@@ -79,6 +79,12 @@ if __name__ == '__main__': random.shuffle(task_fs) + benchmark_lower_env_var = '' + if os.environ.get('BENCHMARK_LOWER'): + benchmark_lower_env_var = f'HAIL_DEV_LOWER="1" ' + if os.environ.get('BENCHMARK_LOWER_ONLY'): + benchmark_lower_env_var = f'{benchmark_lower_env_var} HAIL_DEV_LOWER_ONLY="1" ' +...
Update whatsappMessages.py Fixes issue of thumbnail variable
@@ -44,6 +44,7 @@ def get_whatsappMessages(files_found, report_folder, seeker, wrap_text): ''') all_rows = cursor.fetchall() usageentries = len(all_rows) + thumb = '' if usageentries > 0: for row in all_rows:
Fix a crash with calibration missing on OAK-D-xx boards, use defaults for baseline, mono FOV, focal distance
@@ -166,10 +166,18 @@ class PreviewManager: if dai.CameraBoardSocket.LEFT in device.getConnectedCameras(): calib = device.readCalibration() eeprom = calib.getEepromData() - cam_info = eeprom.cameraData[calib.getStereoLeftCameraId()] + left_cam = calib.getStereoLeftCameraId() + if left_cam != dai.CameraBoardSocket.AUTO:...
fix Brocade.ADX.get_arp HG-- branch : feature/microservices
@@ -33,11 +33,11 @@ class Script(BaseScript): "ip": match.group("ip"), "mac": None, "interface": None - }) + }] else: r += [{ "ip": match.group("ip"), "mac": match.group("mac"), "interface": match.group("interface") - }) + }] return r
plugin: removing virtual referencies from meta Remove referencies to "virtual" methods (that no longer exist) from the plugin metaclass.
@@ -252,9 +252,6 @@ class PluginMeta(type): The assumption is that the values of the attributes specified in the class are iterable; if that is not met, Bad Things (tm) will happen. - This also provides virtual method implementation, similar to those in - C-derived OO languages, and alias specifications. - """ to_propa...
update runners * update runners * add SCHEDULER_PARAMETERS which is required to submit job * error in CI file
+variables: + SCHEDULER_PARAMETERS: "-N 1 -M escori -q compile -t 30" + stages: - validate - regression validate_cori_testsuite: - tags: ["cori20-siddiq90"] + tags: ["cori"] stage: validate rules: - if: '$CI_PIPELINE_SOURCE == "push" || $CI_PIPELINE_SOURCE == "web"' @@ -23,7 +26,7 @@ validate_cori_testsuite: - conda en...
restrict Tuple items to instances of Evaluable With the recently added `evaluable.EvaluableConstant` class, it is now possible to pass unevaluable values as evaluable values to `evaluable.Tuple`. This commit removes the (unused) possibility to pass unevaluable values directly to `evaluable.Tuple`, in favor of explicitl...
@@ -526,27 +526,15 @@ class EvaluableConstant(Evaluable): class Tuple(Evaluable): - __slots__ = 'items', 'indices' + __slots__ = 'items' @types.apply_annotations - def __init__(self, items:tuple): # FIXME: shouldn't all items be Evaluable? + def __init__(self, items: types.tuple[strictevaluable]): self.items = items - ...
Interaction.channel can be a PartialMessageable rather than Object This allows it to work just fine in DMs
@@ -31,6 +31,7 @@ import asyncio from . import utils from .enums import try_enum, InteractionType, InteractionResponseType from .errors import InteractionResponded, HTTPException, ClientException +from .channel import PartialMessageable, ChannelType from .user import User from .member import Member @@ -57,10 +58,12 @@ ...
refactor: updated boilerplate moved from regex + ast eval to just using import
@@ -269,17 +269,12 @@ def get_data(): setup_template = """# -*- coding: utf-8 -*- from setuptools import setup, find_packages -import re, ast with open('requirements.txt') as f: install_requires = f.read().strip().split('\\n') # get version from __version__ variable in {app_name}/__init__.py -_version_re = re.compile(r...
preparation for attributes selection with boolean AND work in progress
@@ -1081,6 +1081,7 @@ class DialogReportCodes(QtWidgets.QDialog): self.ui.pushButton_attributeselect.setIcon(QtGui.QIcon(pm)) return self.attributes = ui.parameters + print("Attributes after GUI\n", self.attributes) if not self.attributes: pm = QtGui.QPixmap() pm.loadFromData(QtCore.QByteArray.fromBase64(attributes_ico...
Make small changes to KFP DSL export template Fixes issue where exported generic pipeline file fails during submission due to missing authorization credentials
@@ -5,6 +5,7 @@ import kfp_tekton {% if kf_secured %} import requests import sys +import urllib {% endif %} {% if cos_secret %} from kfp.aws import use_aws_secret @@ -108,7 +109,7 @@ def get_istio_auth_session(url: str, username: str, password: str) -> dict: ################ # Get Dex Login URL (that allows us to POST ...
[Core] [Hotfix] Change "task failed with unretryable exception" log statement to debug-level. Serve relies on being able to do quiet application-level retries, and this info-level logging is resulting in log spam hitting users. This PR demotes this log statement to debug-level to prevent this log spam.
@@ -748,7 +748,7 @@ cdef execute_task( core_worker.get_current_task_id()), exc_info=True) else: - logger.info("Task failed with unretryable exception:" + logger.debug("Task failed with unretryable exception:" " {}.".format( core_worker.get_current_task_id()), exc_info=True)
Use `extrapolation="last_value"` for custom signalflow used by HPA Without this, missing data can cause the signalfx metrics adapter to request 0 instances
@@ -176,8 +176,8 @@ setpoint = {setpoint} moving_average_window = '{moving_average_window_seconds}s' filters = filter('paasta_service', '{paasta_service}') and filter('paasta_instance', '{paasta_instance}') and filter('paasta_cluster', '{paasta_cluster}') -current_replicas = data('kube_hpa_status_current_replicas', fil...
Add link to Contributing landing page to navbar This commit adds a link to the Contributing landing page to the navbar on our website.
<a class="navbar-item" href="{% url 'wiki:get' path="tools/" %}"> Tools </a> + <a class="navbar-item" href="{% url 'wiki:get' path="contributing/" %}"> + Contributing + </a> <a class="navbar-item" href="{% url 'wiki:get' path="frequently-asked-questions/" %}"> FAQ </a>
Update the version of pandas up-to-date for CI As pandas 1.0.3 released, I think It would be better match the version of pandas in our CI.
@@ -94,7 +94,7 @@ jobs: pyarrow-version: 0.14.1 - python-version: 3.7 spark-version: 2.4.5 - pandas-version: 1.0.2 + pandas-version: 1.0.3 pyarrow-version: 0.14.1 env: PYTHON_VERSION: ${{ matrix.python-version }}
Bugfix support SERVER_NAME configuration for the run method This matches Flask's functionality.
@@ -1247,8 +1247,8 @@ class Quart(Scaffold): def run( self, - host: str = "127.0.0.1", - port: int = 5000, + host: Optional[str] = None, + port: Optional[int] = None, debug: Optional[bool] = None, use_reloader: bool = True, loop: Optional[asyncio.AbstractEventLoop] = None, @@ -1308,6 +1308,18 @@ class Quart(Scaffold): ...
Add some types to `equals_tester.py` Adds more type hints to `equal_tester.py`
@@ -22,7 +22,7 @@ equal to each other. It will also check that a==b implies hash(a)==hash(b). import collections -from typing import Any, Callable +from typing import Any, Callable, List, Tuple, Union import itertools @@ -30,8 +30,10 @@ import itertools class EqualsTester: """Tests equality against user-provided disjoi...
html: parsing: set node attributes using Node.attributes Previously Node.__init__ was used to set HTML attributes, but this clashes with keyword arguments like "nodes" or boolean attributes like "disabled"
@@ -108,23 +108,32 @@ class NodeHTMLParser(HTMLParser): return Node def handle_starttag(self, tag, attrs): - node_kwargs = {} - # node attributes + node_attributes = {} + for name, value in attrs: if value is None: - value = 'true' + value = '' - node_kwargs[name] = value + node_attributes[name] = value # tag overrides...
Hotfix: Recompiled TexText <= 0.11.x nodes flip vertically Resolves
@@ -701,14 +701,12 @@ class TexTextElement(inkex.Group): old_transform = Transform(ref_node.transform) - # Account for vertical flipping of pstoedit nodes when recompiled via pdf2svg and vice versa + # Account for vertical flipping of nodes created via pstoedit in TexText <= 0.11.x revert_flip = Transform("scale(1)") -...
Add socketserver.UDPServer.max_packet_size It looks like an int in the source code: Stubtest flagged it as being missing in all supported Python versions, on all platforms:
@@ -55,6 +55,7 @@ class TCPServer(BaseServer): def close_request(self, request: _RequestType) -> None: ... # undocumented class UDPServer(BaseServer): + max_packet_size: ClassVar[int] def __init__( self, server_address: tuple[str, int],
Change cartesian_to_ellipsoidal singularity range Now treats any lat < abs(1e-18) as close to singularity instead of only lat == 0.0 within the cartesian_to_ellipsoidal. This was added since unit tests failed to produce a height of 5 meters when the input latitude was 5e-315.
@@ -191,7 +191,7 @@ def cartesian_to_ellipsoidal(a, c, x, y, z): v = a / np.sqrt(1 - e2 * np.sin(lat) ** 2) h = ( np.sqrt(x**2 + y**2) / np.cos(lat) - v - if lat == 0.0 + if lat < abs(1e-18) else z / np.sin(lat) - (1 - e2) * v )
Python API: wrap null entities as None TN:
@@ -144,6 +144,10 @@ class ${type_name}(${base_cls}): %>${copy}, % endfor ) + % if cls.is_entity_type: + if result.el is None: + return None + % endif if cls._inc_ref and inc_ref: cls._inc_ref(ctypes.byref(c_value)) return result
fixed saving of project settings # Conflicts: # pype/tools/settings/settings/widgets/base.py
@@ -687,8 +687,12 @@ class ProjectWidget(QtWidgets.QWidget): return data = {} + studio_overrides = bool(self.project_name is None) for item in self.input_fields: - value, _is_group = item.overrides() + if studio_overrides: + value, is_group = item.studio_overrides() + else: + value, is_group = item.overrides() if value...
Python3.9: Disable warning given with MSVC in debug mode. * We don't care about deprecation warnings, they still work and so we can continue to use them.
@@ -46,7 +46,6 @@ import re import subprocess import SCons # pylint: disable=import-error -from nuitka.Tracing import my_print, scons_logger from SCons.Script import ( # pylint: disable=import-error ARGUMENTS, CacheDir, @@ -57,6 +56,8 @@ from SCons.Script import ( # pylint: disable=import-error GetOption, ) +from nuitk...
[docs] Add links to v0.8.0 docs This uses the new code from with a link to the v0.8.0 docs. We can update this in the future as we add more releases.
@@ -33,7 +33,7 @@ pip3 install --upgrade \ Pillow==9.1.0 \ psutil \ pytest \ - tlcpack-sphinx-addon==0.2.1 \ + git+https://github.com/tlc-pack/tlcpack-sphinx-addon.git@14906063f938b7569e40f3d47a0ca39c181fb6ea \ pytest-profiling \ pytest-xdist \ requests \
Misc. changes: - compile regex - readability improvements
@@ -226,13 +226,13 @@ def is_generator_with_return_value(callable): return value is None or isinstance(value, ast.NameConstant) and value.value is None if inspect.isgeneratorfunction(callable): - pattern = r"(^[\t ]+)" src = inspect.getsource(callable) - match = re.match(pattern, src) # Find indentation - code = re.sub...
Remove transition on compose box height. The transition "all" by default also affected the transition on the height change of the compose box which ended up making the compose box appear to be laggy and choppy.
@@ -300,7 +300,7 @@ textarea.new_message_textarea, border: 1px solid #ddd; box-shadow: none; -webkit-box-shadow: none; - transition: all 0.2s ease; + transition: border 0.2s ease; } textarea.new_message_textarea:focus,
Added XLPLN25X objective I added in the Olympus objectives the XLPLN25X.
@@ -43,3 +43,18 @@ class MVPlapo2XC(Objective): workingDistance=20, label='MVPlapo2XC', url="") + +class XLPLN25X(Objective): + """ Olympus XLPLN25X 1.05 NA + + Immersion not consided at this point + """ + + def __init__(self): + super(XLPLN25X, self).__init__(f=180/25, + NA=1.05, + focusToFocusLength=75, + backApertur...
change: update tests to version 1.1.0 Added missing test version comment using format for current test cases. Verified test content order and completion. Closes
@@ -2,6 +2,8 @@ import unittest from change import find_minimum_coins +# Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0 + class ChangeTest(unittest.TestCase): def test_single_coin_change(self):
Removes the duplicate entry created by the add() The add() created another entry, we dont want to create a dupe entry, just update the one we have.
@@ -387,7 +387,6 @@ def updatetitle(): job.poster_url_manual = poster_url job.poster_url = poster_url job.hasnicetitle = True - db.session.add(job) db.session.commit() flash('Title: {} ({}) was updated to {} ({})'.format(job.title_auto, job.year_auto, new_title, new_year), category='success') return redirect(url_for('h...
fall back to 'ascii' locale in build (if needed) If locale.getpreferredencoding(False) returns Null, the build fails, since commit This seems to be not really necessary; here we provide a fallback to 'ascii' locale if needed.
@@ -67,8 +67,10 @@ def filepath_from_subprocess_output(output): Inherited from `exec_command`, and possibly incorrect. """ - output = output.decode(locale.getpreferredencoding(False), - errors='replace') + mylocale = locale.getpreferredencoding(False) + if mylocale is None: + mylocale = 'ascii' + output = output.decode...
[lambda] add a newline after each record for Firehose Firehose does not separate each record in the batch in any meaningful way. If you do not append a newline character, all records sent in the batch will appear back to back from eachother.
@@ -195,7 +195,7 @@ class StreamAlert(object): resp = self.firehose_client.put_record_batch( DeliveryStreamName=stream_name, - Records=[{'Data': json.dumps(record, separators=(",", ":"))} + Records=[{'Data': json.dumps(record, separators=(",", ":")) + '\n'} for record in record_batch])
reveal links differently Show download only link if the main view is not visible for user Show main view only if feature flag set for both domain and user
@@ -163,7 +163,9 @@ class ProjectReportsTab(UITab): 'url': reverse(UserConfigReportsHomeView.urlname, args=[self.domain]), 'icon': 'icon-tasks fa fa-wrench', }) - if toggles.LOCATION_REASSIGNMENT.enabled(self.domain, namespace=NAMESPACE_DOMAIN): + # show this link if feature flag enabled for the domain and not set for ...
integ tests: add missing resource dependency in vpc_builder When the route gets created before the VPCGatewayAttachment the stack creation is failing cause the RouteTable is trying to route traffic through a gateway not attached to the VPC.
@@ -77,7 +77,7 @@ class VPCTemplateBuilder: def __build_template(self): vpc = self.__build_vpc() - internet_gateway = self.__build_internet_gateway(vpc) + internet_gateway, internet_gateway_attachment = self.__build_internet_gateway(vpc) nat_gateway = None subnet_refs = [] for subnet in self.__vpc_config.subnets: @@ -8...
ENH: Added sanity check to printoptions See issue
@@ -78,6 +78,7 @@ def _make_options_dict(precision=None, threshold=None, edgeitems=None, if legacy not in [None, False, '1.13']: warnings.warn("legacy printing option can currently only be '1.13' or " "`False`", stacklevel=3) + if threshold is not None: # forbid the bad threshold arg suggested by stack overflow, gh-123...
Update 2.6.0a.rst Announce future dropping of Python 3.3 support too
@@ -13,7 +13,7 @@ Wagtailmenus 2.6.0a release notes .. NOTE :: - Wagtailmenus 2.6 will be the last LTS release to support Python 2. + Wagtailmenus 2.6 will be the last LTS release to support Python 2 or Python 3.3. .. NOTE ::
chore: Update code coverage badge coveralls badge -> codecov badge
<a href='https://www.codetriage.com/frappe/frappe'> <img src='https://www.codetriage.com/frappe/frappe/badges/users.svg'> </a> - <a href='https://coveralls.io/github/frappe/frappe?branch=develop'> - <img src='https://coveralls.io/repos/github/frappe/frappe/badge.svg?branch=develop'> + <a href="https://codecov.io/gh/fra...
Update ua.txt [0] [1]
@@ -520,3 +520,8 @@ zeroup # Reference: https://blog.sucuri.net/2015/12/remote-command-execution-vulnerability-in-joomla.html JDatabaseDriverMysqli + +# Reference: https://twitter.com/Racco42/status/1053336574753148928 +# Reference: https://www.hybrid-analysis.com/sample/f65ba1cc50b29dd05ddaa83242f4b7bd0429841bfc4befa9...
Lexical envs: make implementation of Env_Getter public TN:
@@ -58,7 +58,21 @@ package Langkit_Support.Lexical_Env is type Getter_Fn_T is access function (Elt : Element_T) return Lexical_Env; - type Env_Getter is private; + type Env_Getter (Dynamic : Boolean := False) is record + case Dynamic is + when True => + Elt : Element_T; + Getter_Fn : Getter_Fn_T; + when False => + Is_R...
[mypy][core] decorators/pipeline.py mypy Test Plan: mypy Reviewers: alangenfeld
from functools import update_wrapper +from typing import Any, Callable, Dict, List, Optional, Set, Union from dagster import check from dagster.utils.backcompat import experimental_arg_warning class _Pipeline: def __init__( self, - name=None, - mode_defs=None, - preset_defs=None, - description=None, - tags=None, - hook...
Fix hq commcare names for scheduled reports This test fails without this commit: corehq.apps.reports.tests.test_scheduled_reports:ScheduledReportSendingTest.test_get_scheduled_report_response
@@ -163,7 +163,16 @@ def _get_cc_name(request, var): value = getattr(settings, var) if isinstance(value, six.string_types): return value - return value.get(request.get_host()) or value['default'] + try: + host = request.get_host() + except KeyError: + # In reporting code we create an HttpRequest object inside python wh...
Change test_no_js_console to work in later node versions In the latest node version, `console.log` is defined in `runInThisContext`, so this test would fail
@@ -555,7 +555,8 @@ class TestJsConsole(unittest.TestCase): output = pipe.getvalue() pipe.close() - self.assertIn("ReferenceError: console is not defined", output) + self.assertNotIn("[log] Log message", output) + self.assertNotIn("[err] Error message", output) if __name__ == '__main__': unittest.main()
Fix argument handling in atvremote Passing additional arguments to a command, e.g. command=1,2,3 would drop the first argument. This fixes that.
@@ -351,27 +351,31 @@ def _handle_device_command(args, cmd, atv, loop): cmd, cmd_args = _extract_command_with_args(cmd) if cmd in device: return (yield from _exec_command( - DeviceCommands(atv, loop), cmd, print_result=False, *cmd_args)) + DeviceCommands(atv, loop), cmd, False, *cmd_args)) elif cmd in ctrl: - return (y...
Fix .and_then/.or_else constructors TN:
@@ -11,17 +11,26 @@ from langkit.expressions.base import ( ) -@attr_call('and_then', 'and') -@attr_call('or_else', 'or', - doc='Like :dsl:`and_then`, but for the OR boolean operator or the' - ' logical disjunction.') -class BinaryBooleanOperator(AbstractExpression): +@attr_call('and_then') +def and_then(lhs, rhs): """ ...
Allow scope and colspan Closes
@@ -466,6 +466,9 @@ BLEACH_ALLOWED_ATTRIBUTES = { "height", ], # For continuous registration challenge and google group "img": ["height", "src", "width"], + # For bootstrap tables: https://getbootstrap.com/docs/4.3/content/tables/ + "th": ["scope", "colspan"], + "td": ["colspan"], } BLEACH_ALLOWED_STYLES = ["height", "...
series: support directional limits on the complex plane Closes diofant/diofant#1230
@@ -74,6 +74,16 @@ def test_basic1(): f = Function('f') assert limit(f(x), x, 4) == Limit(f(x), x, 4) + assert limit(exp(x), x, 0, dir=exp(I*pi/3)) == 1 + + assert limit(sqrt(-1 + I*x), x, 0) == +I + assert limit(sqrt(-1 + I*x), x, 0, dir=1) == -I + assert limit(sqrt(-1 + I*x), x, 0, dir=exp(I*pi/3)) == -I + + assert l...
Add missing CAMRY_TSS2 engine & fwdCamera f/w `@Koda(Sleepy)#4682` 2021 Camry LE (ICE) DongleID/route 3653e5d0dbd0d7ed|2022-01-16--21-15-20
@@ -360,12 +360,14 @@ FW_VERSIONS = { b'\x018966306Q5000\x00\x00\x00\x00', b'\x018966306T3100\x00\x00\x00\x00', b'\x018966306T3200\x00\x00\x00\x00', + b'\x018966306T4000\x00\x00\x00\x00', b'\x018966306T4100\x00\x00\x00\x00', ], (Ecu.fwdRadar, 0x750, 0xf): [ b'\x018821F6201200\x00\x00\x00\x00', ], (Ecu.fwdCamera, 0x750,...
runcommands fixed HG-- branch : feature/microservices
@@ -845,7 +845,7 @@ Ext.define("NOC.sa.runcommands.Application", { this.viewModel.set(state, this.viewModel.get(state) + step) }, - sendCommands: function(cfg) { + sendCommands: function(mode, cfg) { var me = this, xhr, params = [], @@ -857,9 +857,28 @@ Ext.define("NOC.sa.runcommands.Application", { me.viewModel.set('p...
Tweak JS so Safari can choose admin actions I noticed that Safari was submitting both the empty option and the selected options back to the server. Digging into it, I was able to get Safari to deselect the option by using '[selected]' as the selector. For
// select the action button from the dropdown container.find('select[name=action]') - .find('op:selected').removeAttr('selected').end() + .find('[selected]').removeAttr('selected').end() .find('[value=' + action_type + ']').attr('selected', 'selected').click() // click submit & replace the archivebox logo with a spinne...
Remove unecessary list-routes command Since this was added, Flask now comes with a build in command to list the routes, `flask routes`, so this is not needed.
@@ -252,13 +252,6 @@ def fix_notification_statuses_not_in_sync(): result = db.session.execute(subq_hist).fetchall() -@notify_command(name='list-routes') -def list_routes(): - """List URLs of all application routes.""" - for rule in sorted(current_app.url_map.iter_rules(), key=lambda r: r.rule): - print("{:10} {}".forma...
Add a is_pingable and device_vendor column in the scuba table Summary: Add an "is_pingable" column in the scuba table so that we can filter out device/network errors when making alerts/troubleshooting. See T47339256 for more context
# This source code is licensed under the MIT license found in the # LICENSE file in the root directory of this source tree. +from typing import TYPE_CHECKING, Union + from .base_service import PeriodicServiceTask from .options import Option +if TYPE_CHECKING: + from .device_info import DeviceIP # noqa: F401 + + class B...
Add support to generate inventory for OSP17 This patch specifies the overcloud_stack_name to generate inventory.
@@ -12,6 +12,7 @@ function usage } user="stack" +overcloud_stack_name=overcloud uncomment_localhost=false tripleo_ip_address= @@ -44,9 +45,9 @@ fi out_file="hosts.yml" if [ $uncomment_localhost ]; then source ~/stackrc - tripleo-ansible-inventory --static-yaml-inventory ${out_file} + tripleo-ansible-inventory --stack $...
settings: Fix code for special case of theme settings subsection. We handle "Theme settings" subsection separately in get_subsection_property_elements as it contains unique radio-button structure for emojiset setting. This should have been fixed while reorganizing the section to have color scheme and emoji related sett...
@@ -215,12 +215,13 @@ export function extract_property_name(elem, for_realm_default_settings) { function get_subsection_property_elements(element) { const subsection = $(element).closest(".org-subsection-parent"); - if (subsection.hasClass("emoji-settings")) { + if (subsection.hasClass("theme-settings")) { // Because t...
Fix typo in consensus message signature verifier The signature is over the message header not the message content.
@@ -123,7 +123,7 @@ def is_valid_consensus_message(message): context = create_context('secp256k1') public_key = Secp256k1PublicKey.from_bytes(header.signer_id) if not context.verify(message.header_signature, - message.content, + message.header, public_key): LOGGER.debug("message signature invalid for message: %s", mess...
[varLib] Minor Part of Part of
@@ -109,7 +109,7 @@ class OnlineVarStoreBuilder(object): # Full array. Start new one. self._set_VarData() return self.storeDeltas(deltas) - VarData_add_item(self._data, deltas) + self._data.add_item(deltas) varIdx = (self._outer << 16) + inner self._cache[deltas] = varIdx @@ -127,10 +127,14 @@ def VarData_add_item(self...
GDB helpers: fix a typo from previous commit TN:
@@ -61,7 +61,7 @@ This command may be followed by a "/X" flag, where X is one or several of: print('Invalid flags: {}'.format(repr(", ".join(invalid_args)))) return - StatePrinter(self.context, 'f' in arg, 's' in arg).run() + StatePrinter(self.context, 'f' not in arg, 's' in arg).run() class StatePrinter(object):
Use MappingProxyType to freeze non-private dictionaries. This is intended to make those mappings safer.
@@ -3,6 +3,7 @@ from collections import defaultdict from functools import reduce from operator import and_, or_ from pathlib import Path +from types import MappingProxyType import yaml from django.conf import settings @@ -16,10 +17,12 @@ Resource = dict[str, t.Union[str, list[dict[str, str]], dict[str, list[str]]]] RES...
bump protobuf version * bump protobuf version Bump protobuf version so users don't face issues if they have an older version already installed on their systems. Ref: Ref: [stackoverflow](https://stackoverflow.com/questions/61922334/how-to-solve-attributeerror-module-google-protobuf-descriptor-has-no-attribu) `pip insta...
@@ -41,7 +41,8 @@ numpy = "*" packaging = "*" pandas = ">=0.21.0" pillow = ">=6.2.0" -protobuf = ">=3.6.0" +# protobuf version 3.11 is incompatible, see https://github.com/streamlit/streamlit/issues/2234 +protobuf = ">=3.6.0, !=3.11" pyarrow = "*" pydeck = ">=0.1.dev5" python-dateutil = "*"
doc: update infra playbooks statements We don't need to copy the infrastructure playbooks in the root ceph-ansible directory.
@@ -4,4 +4,4 @@ Infrastructure playbooks This directory contains a variety of playbooks that can be used independently of the Ceph roles we have. They aim to perform infrastructure related tasks that would help use managing a Ceph cluster or performing certain operational tasks. -To use them, **you must move them to ce...
Build javascript improvements Alter 'no records found' text Reload allocation table on edit or delete
@@ -123,6 +123,7 @@ function fillAllocationTable(table, index, parent_row, parent_table, options) { */ table.bootstrapTable({ + formatNoMatches: function() { return 'No parts allocated for ' + parent_row.sub_part_detail.name; }, columns: [ { field: 'stock_item_detail', @@ -164,6 +165,7 @@ function fillAllocationTable(t...
Simplify logic: just delete the diagram and its elements You can always undo.
@@ -330,27 +330,6 @@ class Namespace(UIComponent, ActionProvider): @action(name="tree-view.delete") def tree_view_delete(self): element = self.get_selected_element() - if isinstance(element, Diagram): - m = Gtk.MessageDialog( - None, - Gtk.DialogFlags.MODAL, - Gtk.MessageType.QUESTION, - Gtk.ButtonsType.YES_NO, - gette...
workloads/hackbench: fix target_binary Set target_binary as a class, rather than instance, attribute. This happens only only once per run, and setting it as instance attribute the first time, makes it unavailable for subsequent instances of the same workload.
@@ -62,7 +62,7 @@ class Hackbench(Workload): @once def initialize(self, context): host_binary = context.resolver.get(Executable(self, self.target.abi, self.binary_name)) - self.target_binary = self.target.install(host_binary) + Hackbench.target_binary = self.target.install(host_binary) def setup(self, context): self.ta...
Reroot_Foreign_Nodes: populate lexical envs after exiled entries strip TN:
@@ -828,23 +828,19 @@ package body ${ada_lib_name}.Analysis is procedure Reroot_Foreign_Nodes (Self : Lex_Env_Data; Root_Scope : Lexical_Env) is - Els : ${root_node_type_name}_Vectors.Elements_Array := + Els : constant ${root_node_type_name}_Vectors.Elements_Array := Self.Foreign_Nodes.To_Array; - Env : Lexical_Env; be...
Adding a bit more about testing to contributing.md let me know what you think of my additions. I think this is good to merge otherwise.
@@ -83,6 +83,12 @@ with this. * :white_check_mark: `:white_check_mark:` when adding tests * :shirt: `:shirt:` when removing linter warnings +### Pull Request Messages + + * Rename the pull request and provide a comment that synthesizes what + the pull request changes or adds. This helps us synthesize what + changes hav...
help_docs: Update image viewer documentation for changes. Updates the list of actions and buttons referenced in the help center documentation for viewing images with lightbox. Also, makes some minor corrections to the keyboard shortcut note. Fixes
@@ -5,10 +5,17 @@ preview. Click on the image preview to open the **image viewer**. In the image viewer, you can: -* View the image at **full size** +* Zoom in and out of the image + +* Click and drag the image + +* **Reset zoom** so that the image is recentered and its original size + +* **Open** the image in a new br...
comment timeline plot Hide timeline plot
</div> </div> - <div class="col-md-12"> + <!--<div class="col-md-12"> <h2>Timeline</h2> <div class="chart" id="timeline"> Plotly.plot('timeline',graphs,{}); </script> </div> - </div> + </div>--> <div class="col-md-12"> <h2>Clients</h2>
Remove use of deprecated Renderer. Warning in the log: "Renderer() deprecated, Please use Scene()instead".
@@ -8,22 +8,20 @@ from dipy.core.graph import Graph from dipy.denoise.enhancement_kernel import EnhancementKernel from dipy.tracking.fbcmeasures import FBCMeasures from dipy.core.sphere import Sphere -from dipy.viz import window -from xvfbwrapper import Xvfb +from dipy.viz import window, actor class TestDipy(unittest.T...
Rename incorrectly named change handler on mixin. Fixes
@@ -626,7 +626,7 @@ class RelationMixin(object): changes_to_return.extend(relation_changes) return errors, changes_to_return - def delete_relation_handler(self, changes): + def delete_relation_from_changes(self, changes): errors = [] changes_to_return = [] for relation in changes:
user_info_popover: Fix status emoji showing even if it's not set. This happened because we had not put a condition in our template to handle the above situation.
<li class="user_info_status_text"> <span id="status_message"> {{status_text}} + {{#if status_emoji_info}} {{#if status_emoji_info.emoji_alt_code}} <div class="emoji_alt_code">&nbsp:{{status_emoji_info.emoji_name}}:</div> {{else}} <div class="emoji status_emoji emoji-{{status_emoji_info.emoji_code}}"></div> {{/if}} {{/i...
Update CHANGES. [skip ci]
@@ -53,6 +53,10 @@ These are all the changes in Lektor since the first public release. - When running `lektor dev new-theme`: fix check for ability to create symlinks under Windows. ([#996][]) +#### Tests + +- Fix for test failures when git is not installed. ([#998][], [#1000][]) + ### Refactorings - Cleaned up `Editor...
Add LONG_BINPUT to unpickler Summary: Pull Request resolved: ghimport-source-id:
@@ -345,6 +345,18 @@ OpCode Unpickler::readInstruction() { } memo_table_.push_back(stack_.back()); } break; + case OpCode::LONG_BINPUT: { + AT_CHECK( + std::numeric_limits<size_t>::max() >= + std::numeric_limits<uint32_t>::max(), + "Found a LONG_BINPUT opcode, but size_t on this system is " + "not big enough to decode ...