message
stringlengths
13
484
diff
stringlengths
38
4.63k
Remove dangling deprecation warning This deprecation is no longer mentioned elsewhere on the page.
@@ -294,10 +294,6 @@ basic slicing that returns a :term:`view`). the former will trigger advanced indexing. Be sure to understand why this occurs. - Also recognize that ``x[[1, 2, 3]]`` will trigger advanced indexing, - whereas due to the deprecated Numeric compatibility mentioned above, - ``x[[1, 2, slice(None)]]`` wi...
Use deepcopy before dumping This commit will avoid changes to the config object when dumping it to upload to S3. (We change the structure of the config in pre_dump of Marshmallow)
import json import logging import time +from copy import deepcopy from enum import Enum from typing import List @@ -394,9 +395,10 @@ class Cluster: ) # Upload config with default values and sections if self.config: + config_copy = deepcopy(self.config) result = AWSApi.instance().s3.put_object( bucket_name=self.bucket.n...
Refactor codebase remove legacy comment
@@ -341,8 +341,6 @@ def _resample_ifg(ifg, cmd, x_looks, y_looks, thresh, md=None): Convenience function to resample data from a given Ifg (more coarse). """ - # Create tmp ifg and extract data array for manual resampling as gdalwarp - # lacks the averaging method fp, tmp_path = mkstemp(suffix='.tif') check_call(cmd + ...
Wait for exit status of watched run The watch commands ends with a message reporting the status of the watched run. It should wait until the exit status is written before checking run status.
@@ -34,6 +34,7 @@ from . import runs_impl log = logging.getLogger("guild") TAIL_BUFFER = 4096 +DEFAULT_EXIT_STATUS_TIMEOUT = 5.0 def main(args, ctx): @@ -172,6 +173,7 @@ def _tail(run): elif proc.is_running(): time.sleep(0.1) else: + _wait_for_exit_status(run) break @@ -213,6 +215,23 @@ def _wait_for_output(proc, outpu...
Add url property to NodeLicenseRecord So that it can be accessed like other fields on NodeLicense like name, text and license_id
@@ -76,6 +76,10 @@ class NodeLicenseRecord(ObjectIDMixin, BaseModel): def license_id(self): return self.node_license.license_id if self.node_license else None + @property + def url(self): + return self.node_license.url if self.node_license else None + def to_json(self): return serialize_node_license_record(self)
Redefining the parameter nnz This is in accordance with pull request
@@ -52,7 +52,7 @@ class csr_matrix(_cs_matrix): ndim : int Number of dimensions (this is always 2) nnz - Number of nonzero elements + Number of stored values, including explicit zeros data CSR format data array of the matrix indices
BUG: fix GEE resid_working to match GLM Note that at the moment, the GEE version is not getting hit in tests.
@@ -1471,7 +1471,7 @@ class GEEResults(base.LikelihoodModelResults): @cache_readonly def resid_working(self): val = self.resid_response - val = val / self.family.link.deriv(self.fittedvalues) + val = val * self.family.link.deriv(self.fittedvalues) return val @cache_readonly
Fix logic for search page exit route Fixes
mixins: [commonCoreStrings, commonLearnStrings, responsiveWindowMixin], data() { return { - lastRoute: null, + searchPageExitRoute: null, demographicInfo: null, }; }, return { appBarTitle: this.coreString('searchLabel'), immersivePage: true, - // Default to the Learn root page if there is no lastRoute to return to. - i...
fix(File): Correct acceptable types in APIs Allow str types for start, page_length in page_length API Allow str, list[dict] file_list in move_file API
@@ -39,7 +39,7 @@ def get_attached_images(doctype: str, names: list[str]) -> frappe._dict: @frappe.whitelist() -def get_files_in_folder(folder: str, start: int = 0, page_length: int = 20) -> dict: +def get_files_in_folder(folder: str, start: int | str = 0, page_length: int | str = 20) -> dict: start = cint(start) page_...
Be less shouty When I type the command name I want to be told what it does, not that I'm doing it wrong. For
dials.goniometer_calibration is a tool to aid calibration of multi-axis goniometers. -The tool takes as input exeriments.expt files for datasets recorded at the +The tool takes as input experiments.expt files for datasets recorded at the goniometer datum setting and for each goniometer axis incremented in turn. It outp...
Increase API image build timeout In CN regions it sporadically takes more than 10 mins
@@ -201,7 +201,7 @@ def _test_docker_image_refresh(image_builder_pipeline, lambda_name): @retry( retry_on_result=lambda result: result["state"]["status"] not in {"AVAILABLE", "CANCELLED", "FAILED", "DELETED"}, wait_fixed=seconds(10), - stop_max_delay=minutes(10), + stop_max_delay=minutes(15), ) def _wait_for_image_buil...
Checking if SafeUUID hack is needed before unpickling datasets. This way we don't run into an issue with pickle's cache.
@@ -1771,9 +1771,9 @@ class DataSet(object): else: f = fileOrFilename - try: + if 'SafeUUID' in dir(_uuid): state_dict = _pickle.load(f) - except AttributeError: + else: # HACK TO ALLOW UUIDs saved on python3.7 work with earlier python versions that don't have uuid.SafeUUID # HACK - maybe move this to leagacyio to deal...
Update pylint run disable C0330 (hanging indents) because of conflicts with Black style formatting
@@ -11,7 +11,7 @@ matrix: - python: 3.6 env: KERAS_BACKEND=tensorflow TENSORFLOW_V=1.15.2 KERAS_V=2.2.5 script: - - (pycodestyle --max-line-length=120 art || exit 0) && (pylint --disable=C0415,E1136 -rn art || exit 0) + - (pycodestyle --max-line-length=120 art || exit 0) && (pylint --disable=C0330,C0415,E1136 -rn art |...
Bump deprecation in win_servermanager state to Neon The original deprecation notice says the "force" option in win_servermanager.installed will be removed in Fluorine. However, this change was recenlty made in 2018.3.0. We need to give 2 feature releases before removal.
@@ -115,10 +115,10 @@ def installed(name, ''' if 'force' in kwargs: salt.utils.versions.warn_until( - 'Fluorine', + 'Neon', 'Parameter \'force\' has been detected in the argument list. This' 'parameter is no longer used and has been replaced by \'recurse\'' - 'as of Salt 2018.3.0. This warning will be removed in Salt F...
Fixed On mobile, the info icon(centered vertically * Fixed On mobile, the info icon(centered vertically Fix * Added the requested changes during reviewing fix
display: none; } .oppia-exploration-footer .oppia-navbar-footer-info-icon { - margin-top: -11px; + margin-top: -3px; } .oppia-exploration-footer .oppia-navbar-footer-info-icon:hover { - margin-top: -11px; + margin-top: -3px; } }
query: do not show duplicates in history ref
@@ -48,12 +48,17 @@ class QueryShell(shell.BQLShell, FavaModule): @staticmethod def get_history(max_entries): - """Get the most recently used shell commands.""" + """Get the most recently used shell commands (removing duplicates).""" num_entries = readline.get_current_history_length() - return [ - readline.get_history_...
Release 4.5.2 this is a bugfix release
@@ -3,6 +3,9 @@ The released versions correspond to PyPi releases. ## Version 4.6.0 (as yet unreleased) +## [Version 4.5.2](https://pypi.python.org/pypi/pyfakefs/4.5.2) (2021-11-07) +This is a bugfix release. + ### Changes * `os.listdir`, `os.scandir` and `pathlib.Path.listdir` now return the directory list in a random...
remove missing_ok in Path.unlink() This parameter was introduced in python 3.8, so it will break in python 3.7. Instead, we simply ignore FileNotFoundError.
@@ -114,7 +114,10 @@ def build_singularity_image( yield str(sif) finally: if remove: - sif.unlink(missing_ok=True) + try: + sif.unlink() + except FileNotFoundError: + pass def run_docker_image(
WL: cache keymaps using variant in key Different keymaps can be generated for different variants so we need to also take those into account when storing keymaps.
@@ -76,8 +76,8 @@ class Keyboard(HasListeners): XKB_DEFAULT_LAYOUT and XKB_DEFAULT_OPTIONS and if not specified are taken from the environment. """ - if (layout, options) in self._keymaps: - keymap = self._keymaps[(layout, options)] + if (layout, options, variant) in self._keymaps: + keymap = self._keymaps[(layout, opt...
Make utility install playbook idempotent To ensure idempotence we do the following: 1. Ensure that the symlinks are only changed if they do not yet exist. 2. Switch the openstack client bash completion to be a handler which is executed whenever the venv changes or the symlinks change.
utility_upper_constraints_url: "{{ requirements_git_url | default('https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h=' ~ requirements_git_install_branch | default('master')) }}" tags: - utility + handlers: + - name: Create openstack client bash_completion script + shell: >- + openstack...
[Metrics] Avoid null value when chain height is 0 Fixed a regression that would cause the ETH remaining height value to be set to None instead of 0.
@@ -168,7 +168,7 @@ async def get_metrics(shared_stats: dict) -> Metrics: else: sync_messages_remaining_total = None - if eth_reference_height and eth_last_committed_height: + if eth_reference_height is not None and eth_last_committed_height is not None: # Some blocks may not contain Aleph messages, and therefore the l...
Update profile-nfts-flow.md (Small tweak)
@@ -5,7 +5,7 @@ SPDX-License-Identifier: Apache-2.0 # Quickstart: Profile NFTs -This is a flow showing: share user profile data privately with dapps, via Ocean Data NFTs. +This is a flow showing how to do "login with Web3" with the help of Ocean data NFTs. In this flow, a dapp is not only connected to the user's wallet...
Update docstring in validate_provider_segment The InvalidInput exception has been moved to neutron_lib.exceptions. TrivialFix
@@ -69,7 +69,7 @@ class _TypeDriverBase(object): """Validate attributes of a provider network segment. :param segment: segment dictionary using keys defined above - :raises: neutron.common.exceptions.InvalidInput if invalid + :raises: neutron_lib.exceptions.InvalidInput if invalid Called outside transaction context to ...
Fix, for debug mode white list new kind of exception expression. * This ought to be optimized, but currently the locals dict nodes do not work well, when an error could happen without fallback, so allow it until this is improved. * This adds a TODO item.
@@ -196,9 +196,13 @@ def generateRaiseExpressionCode(to_name, expression, emit, context): # Missed optimization opportunity, please report it, this should not # normally happen. We are supposed to propagate this upwards. if isDebug(): + # TODO: Need to optimize ExpressionLocalsVariableRefORFallback once we know + # it ...
Update setup.py to include py.typed marker file. To make the aio_pika package compatible, it needs to indicate the presence of the marker file in the setup.py file. This ensures installing the package as a typed package.
@@ -36,6 +36,7 @@ setup( 'Programming Language :: Python :: Implementation :: CPython', ], packages=find_packages(exclude=['tests']), + package_data={'aio_pika': ['py.typed']}, install_requires=[ 'aiormq~=2.1', 'yarl',
Exclude Users - Ignore Case fixes
@@ -495,7 +495,7 @@ class ConfigLoader(object): try: # add "match begin" and "match end" markers to ensure complete match # and compile the patterns because we will use them over and over - exclude_users.append(re.compile(r'\A' + regexp + r'\Z', re.UNICODE)) + exclude_users.append(re.compile(r'\A' + regexp + r'\Z', re....
Additional documentation ... for `Organization.affiliated_organizations`.
@@ -143,7 +143,8 @@ The primary tables used in AMY (that will likely appear in every query) are thos * `fullname` Human friendly name of the organization * `country` Stored as the [two digit country code](https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2) * `latitude` and `longitude` Stored as floating point (decimal) n...
Adalog: remove an obsolete pragma TN:
@@ -19,9 +19,7 @@ package body Langkit_Support.Adalog.Abstract_Relation is procedure Wait is begin - pragma Warnings (Off, "always"); if Debug_State = Step then - pragma Warnings (On, "always"); Put_Line ("Press enter to continue .."); declare Dummy : String := Ada.Text_IO.Get_Line;
[dagit] Flip UTC offset sign in timezone picker Summary: Resolves UTC offsets are intentionally inverted, so we need to flip the sign back to be visually correct. Test Plan: View timezone picker, verify proper sign on timezones. Reviewers: max, prha, alangenfeld
@@ -46,7 +46,8 @@ export const TimezoneProvider: React.FunctionComponent = (props) => { const formatOffset = (mm: number) => { const amm = Math.abs(mm); - return `${mm < 0 ? '-' : '+'}${Math.floor(amm / 60)}:${amm % 60 < 10 ? '0' : ''}${amm % 60}`; + // moment.tz.zone() offsets are inverted: https://momentjs.com/timezo...
ebuild.ebuild_built: remove 'ebuild' from attr map initialization It should already be handled via class property.
@@ -102,7 +102,7 @@ class package(ebuild_src.base): _get_attr.update((x, partial(_chost_fallback, x.upper())) for x in ("cbuild", "chost", "ctarget")) _get_attr.update((x, post_curry(passthrough, x)) - for x in ("contents", "environment", "ebuild")) + for x in ("contents", "environment")) _get_attr.update((x, lambda s,...
Don't generate runtime check for private abstract properties This used to be necessary when private properties were declared in the "private" part of packages in generated code, but now that we have the separate $.Analysis.Implementation package, there is no longer a "private" part and thus this workaround is no longer...
@@ -2631,10 +2631,6 @@ class PropertyDef(AbstractNodeData): scheme with current langkit capabilities in which the parser generate the right types for the functionality you want. - Note that for abstract properties that are private, this is - automatically enabled, as abstract private primitives are not - allowed in Ada...
test_classes.py: Replace markdown_logger mock with assertLogs. Set level to 'ERROR' since exceptions create logs with that level.
@@ -1104,7 +1104,9 @@ Output: """ with self.settings(ERROR_BOT=None), mock.patch( "zerver.lib.markdown.timeout", side_effect=subprocess.CalledProcessError(1, []) - ), mock.patch("zerver.lib.markdown.markdown_logger"): + ), self.assertLogs( + level="ERROR" + ): # For markdown_logger.exception yield def create_default_de...
Fix swagger Don't show limit/offset for endpoints not supporting it
@@ -150,6 +150,7 @@ class AboutEthereumTracingRPCView(AboutEthereumRPCView): class ERC20IndexingView(GenericAPIView): serializer_class = serializers.ERC20IndexingSerializer + pagination_class = None # Don't show limit/offset in swagger def get(self, request): """ @@ -557,6 +558,7 @@ def swagger_safe_balance_schema(seri...
fix page history view on custom user models Username models without username field caused an exception on page history views. This commit fixes
@@ -112,9 +112,10 @@ class LockedPagesReportFilterSet(WagtailFilterSet): def get_requested_by_queryset(request): - return get_user_model().objects.filter( + User = get_user_model() + return User.objects.filter( pk__in=set(WorkflowState.objects.values_list('requested_by__pk', flat=True)) - ).order_by('username') + ).ord...
Remove chmod from test condition chmod() is not fully supported in Windows. Instead, use the '/' directory to trigger a non-EEXIST exception for the test condition
@@ -156,18 +156,19 @@ class TestProject(unittest.TestCase): self.assertTrue(len(project.keys) == 1) self.assertTrue(project.keys[0] == project_key['keyid']) - # Set as readonly and try to write a repo. + # Try to write to an invalid location. The OSError should be re-raised by + # create_new_project(). shutil.rmtree(ta...
Duplicate persons: update form showing up condition The forms for marking people as reviewed will be always shown, whereas forms for merging persons will be only shown, if the number of records in the table is at least 2.
<td>{% if not forloop.first %}<input type="radio" name="person_b" value="{{ person.id }}" form="form_switched_names_merge">{% endif %}</td> </tr> {% endfor %} - {% if switched_persons|length >= 2 %} <tr> <td></td> <td> </form> </td> <td colspan="2"> + {% if switched_persons|length >= 2 %} <form method="GET" action="{% ...
[benchmark] Minor tweaks to `hail-bench compare` Fix up formatting, add harmonic mean.
@@ -2,7 +2,7 @@ import json import os import sys -from scipy.stats.mstats import gmean +from scipy.stats.mstats import gmean, hmean import numpy as np @@ -83,20 +83,21 @@ def compare(args): sys.stderr.write(f"Failed benchmarks in run 2:" + ''.join(f'\n {t}' for t in failed_2) + '\n') comparison = sorted(comparison, key...
minor code style tweaks (closer to pycharm automatic code formatting)
Unit tests specifically for 1.0.0-style DataCube """ -import openeo.metadata import pytest import shapely.geometry + +import openeo.metadata from openeo.internal.graph_building import PGNode from openeo.rest.connection import Connection - from .conftest import API_URL from ... import load_json_resource @@ -97,10 +97,12...
add tutorial for adding a new endpoint walks through the process of adding the new `fluview_meta` endpoint
@@ -7,6 +7,10 @@ This guide describes how to write and test code for the Epidata API. For preliminary steps, [install docker and create a virtual network](https://github.com/cmu-delphi/operations/blob/master/docs/frontend_development.md#setup). +After reading this guide, you may want to visit +[the `fluview_meta` tutor...
Fixes typo nozerconf -> nozeroconf Fixes
@@ -828,7 +828,7 @@ def _parse_network_settings(opts, current): _raise_error_network('hostname', ['server1.example.com']) if 'nozeroconf' in opts: - nozeroconf = salt.utils.dequote(opts['nozerconf']) + nozeroconf = salt.utils.dequote(opts['nozeroconf']) if nozeroconf in valid: if nozeroconf in _CONFIG_TRUE: result['noz...
Refactor EnumNode classes creation Forward fields to the created node class, so that enum nodes can have fields and properties.
@@ -1206,7 +1206,7 @@ class StructMetaclass(CompiledTypeMetaclass): assert sum(1 for b in [is_astnode, is_struct] if b) == 1 assert sum(1 for b in [is_base, is_root_grammar_class] if b) <= 1 - # Get the fields this class define. Remove them as class members: we + # Get the fields this class defines. Remove them as clas...
Add InvalidAMRError exception to amr This allows capturing the exception in containing scopes easily to dump offending sentence action pair into files for debugging
@@ -2,6 +2,10 @@ import sys from transition_amr_parser.utils import print_log +class InvalidAMRError(Exception): + pass + + class AMR: def __init__(self, tokens=None, root='', nodes=None, edges=None, alignments=None, score=0.0): @@ -134,7 +138,7 @@ class AMR: else: if len(completed) < len(self.nodes): - raise Exception...
TST: Add unit test for kwarg of np.einsum Ensure that explicitly stating out=None does not raise an error in np.einsum, see and
@@ -605,6 +605,10 @@ def test_einsum_misc(self): [[[1, 3], [3, 9], [5, 15], [7, 21]], [[8, 16], [16, 32], [24, 48], [32, 64]]]) + # Ensure explicitly setting out=None does not cause an error + # see issue gh-15776 and issue gh-15256 + assert_equal(np.einsum('i,j', [1], [2], out=None), [[2]]) + def test_subscript_range(...
TST: Avoid possible warning from unnecessary cast with uninitialized values This should be fixed in `choose` to not do the unnecessary cast, see
@@ -21,7 +21,7 @@ class SubClass(np.ndarray): ... B1 = np.empty((1,), dtype=np.int32).view(SubClass) B2 = np.empty((1, 1), dtype=np.int32).view(SubClass) C: np.ndarray[Any, np.dtype[np.int32]] = np.array([0, 1, 2], dtype=np.int32) -D = np.empty(3).view(SubClass) +D = np.ones(3).view(SubClass) i4.all() A.all()
Optimization: Also remove assignments to mutable constant values. * These can be removed if they have no references. * Unclear if this happens a lot, but it seemed to be missing. This ought to cover "has side effects" in the future too.
@@ -251,7 +251,7 @@ class StatementAssignmentVariable(StatementChildrenHavingBase): return self.getAssignSource().mayRaiseException(exception_type) def computeStatement(self, trace_collection): - # This is very complex stuff, pylint: disable=too-many-branches + # This is very complex stuff, pylint: disable=too-many-bra...
fix degradation factor for one year was returning 1 for single year degradation
@@ -78,6 +78,8 @@ def annuity(analysis_period, rate_escalation, rate_discount): def degradation_factor(analysis_period, rate_degradation): if analysis_period == 0: return 0 + if analysis_period == 1: + return 1 - rate_degradation factor = 1 factors = [factor] for yr in range(1, int(analysis_period)):
Update gallery.py web trader and live wind on same row
@@ -417,8 +417,7 @@ layout = html.Div(className='gallery', children=[ This app continually queries a SQL database and displays live charts of wind speed and wind direction. In Dash, the [dcc.Interval](https://dash.plot.ly/live-upates) component can be used to update any element on a recurring interval. - ''', - width=1...
css: Fix erroneous `bootstrap-focus-style` ID. The commit added a bug that breaks new user invite. The CSS class ` bootstrap-focus-style` was added to `id`, hence breaking the value extraction. Fixes:
{{> help_link_widget link="/help/roles-and-permissions" }} </label> <div> - <select id="invite_as bootstrap-focus-style" class="invite-as"> + <select id="invite_as" class="invite-as bootstrap-focus-style"> <option name="invite_as" value="{{ invite_as_options.guest.code }}">{{t "Guests" }}</option> <option name="invite_...
Extract .from_fluid_flow method to a class This is more in line with how we have all the Bearing classes, and makes it easier for the user to find it. Closes
"""Bearing Element module. This module defines the BearingElement classes which will be used to represent the rotor -bearings and seals. There're 6 different classes to represent bearings options, +bearings and seals. There are 7 different classes to represent bearings options, and 2 element options with 8 or 12 degree...
Upstream generic device test patch. Summary: So that XLA can run all tests by setting env `PYTORCH_TEST_PATH` instead of patching a diff. :) Pull Request resolved:
+import copy import inspect +import runpy import threading from functools import wraps import unittest @@ -275,6 +277,30 @@ device_type_test_bases.append(CPUTestBase) if torch.cuda.is_available(): device_type_test_bases.append(CUDATestBase) + +# Note [How to extend DeviceTypeTestBase to add new test device] +# The foll...
ENH: added new time function Added a function to calculate decimal year from a datetime object.
@@ -43,6 +43,36 @@ def getyrdoy(date): return date.year, doy +def datetime_to_dec_year(dtime): + """Convert datetime timestamp to a decimal year. + + Parameters + ---------- + dtime : dt.datetime + Datetime timestamp + + Returns + ------- + year : float + Year with decimal containing time incriments of less than a year...
refactor(bump): Remove a redundant join call The list of lines is now joined unconditionally in _bump_with_regex, so there is never a need to join it in update_version_in_files. The removed join was hence a no-op because it was performed on a str.
@@ -158,7 +158,7 @@ def update_version_in_files( # Write the file out again with smart_open(filepath, "w") as file: - file.write("".join(version_file)) + file.write(version_file) def _bump_with_regex(
Fix spelling mistake Crown -> crowd
@@ -27,6 +27,6 @@ Police pepper sprays a young child who is seen crying, while protesters pour mil ### Police initiate violence | June 1 -Police pepper spray peacefully protesting crown +Police pepper spray peacefully protesting crowd * https://www.reddit.com/r/Seattle/comments/gv0ru3/this_is_the_moment_it_all_happened...
Update Changelog For newest Development version
@@ -3,9 +3,22 @@ Changelog All notable changes to this project are documented in this file. -[0.7.4-dev] in progress ------------------------ +[0.7.7-dev] in progress +------------------------ - Add support for Peewee 3.6.4 + + +[0.7.6] 2018-08-02 +------------------ +- Adds ability to attach a fee to a ``send`` transa...
[batch] update cost calculation add 0.004/instance-hr static IP cost add 0.01/core-hr service charge
@@ -8,12 +8,22 @@ log = logging.getLogger('utils') def cost_from_msec_mcpu(app, msec_mcpu): + worker_cores = app['worker_cores'] + # https://cloud.google.com/compute/all-pricing + + # per instance costs # persistent SSD: $0.17 GB/month # average number of days per month = 365.25 / 12 = 30.4375 - avg_n_days_per_month = ...
Fix empty email attribute in LDAP causes exception We were checking to see if the email attribute had no value, but not to see if it had a non-empty value! We were making the same mistake with username.
@@ -269,7 +269,7 @@ class LDAPDirectoryConnector(object): continue email, last_attribute_name = self.user_email_formatter.generate_value(record) - if email is None: + if not email: if last_attribute_name is not None: self.logger.warning('Skipping user with dn %s: empty email attribute (%s)', dn, last_attribute_name) co...
gui_guider_demo: fix pkg version Only one version is supported. Remove the check.
@@ -12,6 +12,6 @@ if PKG_USING_GUI_GUIDER_DEMO config PKG_GUI_GUIDER_DEMO_VER string - default "latest" if PKG_LVGL_VER_NUM = 0x99999 #LVGL latest version + default "latest" endif
uilts/cpustates: Fix inverted `no_idle` check If there is no information about idle states then `no_idle` should be set to `True` instead of `False`.
@@ -151,7 +151,7 @@ class PowerStateProcessor(object): def __init__(self, cpus, wait_for_marker=True, no_idle=None): if no_idle is None: - no_idle = True if cpus[0].cpuidle else False + no_idle = False if cpus[0].cpuidle else True self.power_state = SystemPowerState(len(cpus), no_idle=no_idle) self.requested_states = {...
ebuild.ebd: run_generic_phase(): allow tmpdir param to be explicitly unset Instead of using $T all the time.
@@ -402,7 +402,7 @@ class setup_mixin(object): def run_generic_phase(pkg, phase, env, userpriv, sandbox, fd_pipes=None, - extra_handlers=None, failure_allowed=False, logging=None): + extra_handlers=None, failure_allowed=False, logging=None, **kwargs): """ :param phase: phase to execute :param env: environment mapping f...
PANEL_COOKIE_SECRET not respected Some env variables such as PANEL_COOKIE_SECRET and PANEL_OAUTH_ENCRYPTION are not being verified correctly. This commit fixes that.
@@ -406,7 +406,7 @@ class Serve(_BkServe): "base64-encoded bytes." ) config.oauth_encryption_key = encryption_key - else: + elif not config.oauth_encryption_key: print("WARNING: OAuth has not been configured with an " "encryption key and will potentially leak " "credentials in cookies and a JWT token embedded " @@ -435...
Dont show traceback on 'q' if error view is shown Just exit silently with return code. The useful error will be in ~/.cache/conjure-up/conjure-up.log anyway.
@@ -5,6 +5,7 @@ log output, and where to file a bug. from urwid import (Pile, Text, Filler, WidgetWrap, Divider) from ubuntui.widgets.buttons import cancel_btn from ubuntui.utils import Color, Padding +import sys class ErrorViewException(Exception): @@ -39,4 +40,4 @@ class ErrorView(WidgetWrap): return Pile(buttons) de...
When -vnone is enabled, don't say we stop compilation pipeline TN:
@@ -40,6 +40,7 @@ class PassManager(object): if p.disabled: continue if isinstance(p, StopPipeline): + if context.verbosity.info: printcol('Stopping pipeline execution: {}'.format(p.name), Colors.OKBLUE) return
Fix: avoid windows exe permission errors See:
@@ -9,7 +9,7 @@ install: - ps: appveyor DownloadFile "https://raw.githubusercontent.com/randy3k/UnitTesting/master/sbin/appveyor.ps1" - ps: .\appveyor.ps1 "bootstrap" -verbose - ps: .\appveyor.ps1 "install_package_control" -verbose - - ps: pip install --upgrade pip + - ps: python -m pip install --upgrade pip - ps: pip ...
Update botorch_and_ax.md Summary: Revised documentation / narrative on ax integration. Pull Request resolved:
@@ -3,41 +3,36 @@ id: botorch_and_ax title: Using botorch with Ax --- -[Ax](https://github.com/facebook/Ax) is a platform for optimizing experiments. +[Ax](https://github.com/facebook/Ax) is a platform for sequential +experimentation. It relies on botorch for implementing Bayesian Optimization algorithms, but -provides...
Migrated from list to map for reading examples. I was using a list to store line numbers to read for sequences from text. Migrated to map.
@@ -278,23 +278,24 @@ class LazyNERDataset(Dataset): def __init__(self, data_file, tokenizer, args): self.data_file = data_file self.data_start_line = args.data_start_line if args.data_start_line else 0 - self.example_lines = self._get_examples(self.data_file, self.data_start_line) - self.num_entries = len(self.example...
Light : Drop support for `IECore::Light` We now simply use `IECore::Shader` to represent lights, including their network of input shaders.
#include "IECore/NullObject.h" #include "IECore/Shader.h" -#include "IECore/Light.h" #include "IECore/MessageHandler.h" #include "Gaffer/StringPlug.h" @@ -97,7 +96,6 @@ IECore::ConstObjectPtr Light::computeSource( const Context *context ) const return IECore::NullObject::defaultNullObject(); } - void Light::hashAttribu...
Make running Gloo tests conditional on availability Summary: Pull Request resolved: Test Plan: Imported from OSS
@@ -82,11 +82,7 @@ ROCM_BLACKLIST = [ 'nccl', ] -DISTRIBUTED_TESTS_CONFIG = { - 'gloo': { - 'WORLD_SIZE': '2' if torch.cuda.device_count() == 2 else '3' - }, -} +DISTRIBUTED_TESTS_CONFIG = {} if dist.is_available(): @@ -98,7 +94,10 @@ if dist.is_available(): DISTRIBUTED_TESTS_CONFIG['nccl'] = { 'WORLD_SIZE': '2' if tor...
Fix the Horovod benchmark Update the horovod installation before benchmark. Update openmpi to 4.1.
@@ -156,6 +156,7 @@ def PrepareHorovod(vm): vm.AuthenticateVm() vm.Install('google_cloud_sdk') + vm.Install('openmpi') vm.InstallPackages('wget git unzip') vm.Install('nccl') @@ -179,7 +180,10 @@ def PrepareHorovod(vm): f'sudo {pip} install ' '--extra-index-url https://developer.download.nvidia.com/compute/redist/ ' f'...
fix error when deleting Ipv6. N:Ipv6Equipament:3839 , MSG:Failure to remove the Ipv6Equipament
@@ -3627,7 +3627,7 @@ class Ipv6(BaseModel): data_to_queue = serializer.data # Deletes Obj IP - super(Ip, self).delete() + super(Ipv6, self).delete() # Sends to Queue queue_manager = QueueManager()
If already-loaded object is a Node, no need to look it up again. This will be the case most of the time. (An example of where this isn't true is the Node Files endpoint).
@@ -76,6 +76,9 @@ class AdminOrPublic(permissions.BasePermission): class ExcludeWithdrawals(permissions.BasePermission): def has_object_permission(self, request, view, obj): + if obj.__class__.__name__ == 'Node': + node = obj + else: context = request.parser_context['kwargs'] node = AbstractNode.load(context[view.node_...
DEV: change default stack level for discontinued and deprecated [CHANGED] now set at 3. level 1 just shows the call within cogent3.util.warning, level 2 shows where the function is used, level 3 shows where the user called it from.
@@ -13,7 +13,7 @@ __email__ = "gavin.huttley@anu.edu.au" __status__ = "Production" -def deprecated(_type, old, new, version, reason=None, stack_level=2): +def deprecated(_type, old, new, version, reason=None, stack_level=3): """a convenience function for deprecating classes, functions, arguments. Parameters @@ -39,10 +...
Update v_get_tbl_priv_by_group.sql added DROP and REFERENCES
@@ -10,6 +10,8 @@ select , decode(charindex('w',split_part(split_part(array_to_string(t.relacl, '|'),pu.groname,2 ) ,'/',1)),0,false,true) as upd , decode(charindex('a',split_part(split_part(array_to_string(t.relacl, '|'),pu.groname,2 ) ,'/',1)),0,false,true) as ins , decode(charindex('d',split_part(split_part(array_to...
Update test_custom_rates.py test case with custom tou energy rate only (override urdb)
@@ -270,10 +270,10 @@ class TestBlendedRate(ResourceTestCaseMixin, TestCase): post["Scenario"]["Site"]["ElectricTariff"]["tou_energy_rates_us_dollars_per_kwh"] = [.1] * 8760 post["Scenario"]["Site"]["ElectricTariff"]["add_tou_energy_rates_to_urdb_rate"] = False - # response = self.get_response(post) - # tariff = ClassA...
fix the problem when some weights are zero and the required number of poitns can't be selected
@@ -1056,7 +1056,7 @@ class DynamicSampler(object): # in that case the sample technically won't be # uniform subset = self.rstate.choice(np.nonzero(subset)[0], - size=min(nblive, subset.sum()), + size=min(nblive, (cur_wt > 0).sum()), p=cur_wt, replace=False) cur_nblive = len(subset)
add crude GPIO read support bin/run.sh --dest \!2462abf84098 --gpiord 16
@@ -142,6 +142,9 @@ def onConnected(interface): interface.sendText(args.sendtext, args.destOrAll, wantAck=True, wantResponse=True) + if args.gpiowrb or args.gpiord: + rhc = remote_hardware.RemoteHardwareClient(interface) + if args.gpiowrb: bitmask = 0 bitval = 0 @@ -149,9 +152,13 @@ def onConnected(interface): bitmask ...
Add .get_participants() convenience method Closes and
@@ -56,7 +56,7 @@ from .tl.functions.messages import ( GetDialogsRequest, GetHistoryRequest, SendMediaRequest, SendMessageRequest, GetChatsRequest, GetAllDraftsRequest, CheckChatInviteRequest, ReadMentionsRequest, SendMultiMediaRequest, - UploadMediaRequest, EditMessageRequest + UploadMediaRequest, EditMessageRequest, ...
fix execution URL upon run start Summary: We now namespace all pipelines runs with `/p/:pipeline/` in the URL Fixes Test Plan: grepped for all Link, Route, window.open, and window.location.href references Clicked on Execute button Reviewers: schrockn
@@ -26,7 +26,7 @@ export function handleStartExecutionResult( const obj = result.data.startPipelineExecution; if (obj.__typename === "StartPipelineExecutionSuccess") { - const url = `/${obj.run.pipeline.name}/runs/${obj.run.runId}`; + const url = `/p/${obj.run.pipeline.name}/runs/${obj.run.runId}`; if (opts.openInNewWi...
Fix py38 warnings in unit tests Fixes
@@ -922,7 +922,7 @@ def test_can_base64_encode_binary_multiple_media_types( def index_view(): return app.Response( status_code=200, - body=b'\u2713', + body=u'\u2713'.encode('utf-8'), headers={'Content-Type': content_type}) event = create_event('/index', 'GET', {}) @@ -930,7 +930,7 @@ def test_can_base64_encode_binary_...
Removes Gunicorn Import In Debug mode Moves the gunicorn import below the start server command for debug mode to ensure it isn't imported if it isn't used. This solves issues with manage.py being unable to start on windows.
@@ -7,7 +7,6 @@ import time from typing import List import django -import gunicorn.app.wsgiapp from django.contrib.auth import get_user_model from django.core.management import call_command, execute_from_command_line @@ -156,6 +155,9 @@ class SiteManager: call_command("runserver", "0.0.0.0:8000") return + # Import guni...
Fix error in max_blur_pool.py The example code as is, would cause an error
@@ -37,7 +37,7 @@ class MaxBlurPool2d(nn.Module): Examples: >>> input = torch.rand(1, 4, 4, 8) - >>> pool = kornia.contrib.MaxblurPool2d(kernel_size=3) + >>> pool = kornia.contrib.MaxBlurPool2d(kernel_size=3) >>> output = pool(input) # 1x4x2x4 """
Fix for printing multiple reports at once (bug introduced in 79434bb)
@@ -257,7 +257,6 @@ class ReportPrintMixin: pages = [] try: - pdf = outputs[0].get_document().copy(pages).write_pdf() if len(outputs) > 1: # If more than one output is generated, merge them into a single file @@ -265,6 +264,8 @@ class ReportPrintMixin: doc = output.get_document() for page in doc.pages: pages.append(pag...
Ignore error attempting to deploy unknown application Fixes
@@ -228,6 +228,10 @@ class DeployController: async def _do_deploy(self, application, msg_cb): "launches deploy in background for application" + if application not in self.undeployed_applications: + app.log.error('Skipping attempt to deploy unavailable ' + '{}'.format(application)) + return self.undeployed_applications....
Release udiskie 1.7.6 add russian translations (thanks fixed deprecation warnings in setup.py (thanks
CHANGELOG --------- +1.7.6 +~~~~~ +Date: 17.02.2019 + +- add russian translations (thanks @mr-GreyWolf) +- fixed deprecation warnings in setup.py (thanks @sealj553) + 1.7.5 ~~~~~ Date: 24.05.2018
Adding the ability to write an .proj file Adding some spaces re pep8 Adding some comments and changing naming of file opening section for clarity.
@@ -336,12 +336,30 @@ def _read_projection_information(asc_file): with open(proj_file, 'r') as f: projection_data_structure = f.readlines() - return projection_data_structure + return ''.join(projection_data_structure) else: return None +def _write_projection_information(asc_file, projection_string): + """Write .proj f...
tests: update collect-logs.yml playbook change `ceph -s` output to json-pretty. gather rgw logs add `health detail` command
failed_when: false changed_when: false with_items: - - "-s -f json" + - "-s -f json-pretty" - "osd tree" - "osd dump" - "pg dump" - "versions" + - "health detail -f json-pretty" - name: save ceph status to file copy: or (groups.get(mgr_group_name, []) | length == 0 and inventory_hostname in groups.get(mon_group_name, [...
Update test_fetchers_data_ftp.py Try to skip ftp/data fetcher to check if CI tests take shorter time !
@@ -31,6 +31,7 @@ import logging log = logging.getLogger("argopy.tests.data.ftp") +skip_for_debug = pytest.mark.skipif(True, reason="Taking too long !") """ List ftp hosts to be tested. @@ -92,6 +93,7 @@ def assert_fetcher(this_fetcher, cachable=False): assert is_list_of_strings(this_fetcher.cachepath) +@skip_for_debug...
docs: Change 'loose' to 'lose' in tutorial 'loose' is often confused with 'lose'. This is a minor fix to the documentation.
@@ -251,5 +251,5 @@ First, we setup the solver and the data iterator for the training: Comparing the two processing times, we can observe that both schemes ("static" and "dynamic") takes the same executation time, i.e., although -we created the computation graph dynamically, we did not loose +we created the computation...
plugins: Fix daal4py Add daal4py back to the list of all plugins. It had been removed mistakenly. Make dependency check for daal4py apply to all Python versions, not just 3.8. It is currently only available from conda. There is no PyPi release yet.
@@ -37,6 +37,7 @@ CORE_PLUGINS = [ ("model", "xgboost"), ("model", "pytorch"), ("model", "spacy"), + ("model", "daal4py"), ] # Models which currently don't support Windows or MacOS @@ -79,8 +80,6 @@ CORE_PLUGIN_DEPS = { else {}, } -# Plugins which currently don't support Python 3.8 -if sys.version_info.major == 3 and s...
Minor doc updates in c10/core/Allocator.h Summary: Pull Request resolved:
@@ -169,7 +169,16 @@ struct C10_API Allocator { } }; -// Question: is this still needed? +// This context is used to generate DataPtr which have arbitrary +// std::function deleters associated with them. In some user facing +// functions, we give a (user-friendly) interface for constructing +// tensors from external da...
Tweaked language Per
@@ -165,9 +165,9 @@ id: mi-grandrapids-2 ### Police assault peaceful protesters, among them Breonna Taylor's family members | July 12th -City of Grand Rapids Police Department officers seen pre-emptively pushing, pulling, and shoving peaceful protesters, as they circle around an officer arresting or detaining a man. +C...
Update Nucleus pip package to rely on the same version of TensorFlow (1.11.0) as install.sh uses.
@@ -105,7 +105,7 @@ TensorFlow tfrecords file may be substituted. # redacted # these install_requires. install_requires=['contextlib2', 'intervaltree', 'absl-py', - 'mock', 'numpy', 'six', 'tensorflow>=1.7.0'], + 'mock', 'numpy', 'six', 'tensorflow>=1.11.0'], headers=headers,
Updates contributor details in README This commit updates the contributor email details in the README.
@@ -410,7 +410,7 @@ compliance-checker -t ncei-grid -f json -o ~/Documents/sample_grid_report.json ~ - [Dave Foster](https://github.com/daf) &lt;dave@axiomdatascience.com&gt; - [Dan Maher](https://github.com/danieljmaher) &lt;daniel.maher@gdit.com&gt; -- [Luke Campbell](https://github.com/lukecampbell) &lt;luke.campbel...
Generate InChannelCheckFailure's message inside the exception The exception now expects channel IDs to be passed to it.
@@ -18,7 +18,11 @@ log = logging.getLogger(__name__) class InChannelCheckFailure(CheckFailure): - pass + def __init__(self, *channels: int): + self.channels = channels + channels_str = ', '.join(f"<#{c_id}>" for c_id in channels) + + super().__init__(f"Sorry, but you may only use this command within {channels_str}.") d...
Corrected link to Ubuntu docs removed the docs/ to make the link correct
@@ -19,4 +19,4 @@ see worked example [here](venv.md) `sudo pip install -e "git+https://github.com/jblance/mpp-solar.git#egg=mppsolar"` ### Ubuntu Install example ### -[Documented Ubuntu Install](docs/ubuntu_install.md) +[Documented Ubuntu Install](ubuntu_install.md)
Fix multiprocessing.DictProxy.values() Fixes
@@ -82,8 +82,8 @@ class DictProxy(BaseProxy, MutableMapping[_KT, _VT]): @overload def pop(self, __key: _KT, __default: _VT | _T) -> _VT | _T: ... def keys(self) -> list[_KT]: ... # type: ignore[override] - def values(self) -> list[tuple[_KT, _VT]]: ... # type: ignore[override] - def items(self) -> list[_VT]: ... # type...
indices corrected indices in array_element are counted from 0.
@@ -344,8 +344,8 @@ or normal Python functions: from openeo.processes import array_element def my_bandmath(data): - band1 = array_element(data, index=1) - band2 = array_element(data, index=2) + band1 = array_element(data, index=0) + band2 = array_element(data, index=1) return band1 + 1.2 * band2
Calibration proto fixes Fix a comment noted by wcourtney on design document Fix cut-and-paster java outer classname.
@@ -6,7 +6,7 @@ import "cirq/google/api/v2/program.proto"; package cirq.google.api.v2; option java_package = "com.google.cirq.google.api.v2"; -option java_outer_classname = "BatchProto"; +option java_outer_classname = "FocusedCalibrationProto"; option java_multiple_files = true; // This message represents a request to ...
Only vectorize xmap axes that have only one element per resource To make the jaxpr much less noisy. size-1 vmaps are quite pointless.
@@ -562,10 +562,9 @@ def make_xmap_callable(fun: lu.WrappedFun, class EvaluationPlan(NamedTuple): """Encapsulates preprocessing common to top-level xmap invocations and its translation rule.""" - resource_env: ResourceEnv - axis_sizes: Dict[AxisName, int] physical_axis_resources: Dict[AxisName, Tuple[ResourceAxisName, ...
[swarming] log as info when old style properties is used I'm reaching out to clients still using it, but keeping the log level as error makes the logs unusable to diagnose real failures.
@@ -250,7 +250,7 @@ def new_task_request_from_rpc(msg, now): raise ValueError('Specify one of properties or task_slices, not both') if msg.properties: - logging.error('Properties is still used') + logging.info('Properties is still used') if not msg.expiration_secs: raise ValueError('missing expiration_secs') props, sec...
Order columns in mysql get_columns() implementation. Fixes
@@ -4194,7 +4194,8 @@ class MySQLDatabase(Database): sql = """ SELECT column_name, is_nullable, data_type, column_default FROM information_schema.columns - WHERE table_name = %s AND table_schema = DATABASE()""" + WHERE table_name = %s AND table_schema = DATABASE() + ORDER BY ordinal_position""" cursor = self.execute_sq...