message
stringlengths
13
484
diff
stringlengths
38
4.63k
Fix ONNX Interpolate Summary: Pull Request resolved:
@@ -48,7 +48,8 @@ def _interpolate(name, dim, interpolate_mode): align_corners = sym_help._maybe_get_scalar(align_corners) output_size = sym_help._maybe_get_const(output_size, 'is') if sym_help._is_value(output_size): - offsets = g.op("Constant", value_t=torch.ones(offset, dtype=torch.int64)) + offsets = g.op("Constant...
Fix loop examples after Accelerator API removals Summary: ### New commit log messages Fix loop examples after Accelerator API removals
@@ -26,7 +26,7 @@ install_requires = petastorm>=0.9.0 parameterized>=0.7.4 pyspark==3.1.1 - pytorch-lightning @ git+https://github.com/PyTorchLightning/pytorch-lightning@fa0ed17f8 + pytorch-lightning @ git+https://github.com/PyTorchLightning/pytorch-lightning@98de69b14 ruamel.yaml>=0.15.99 scipy>=1.3.1 tensorboard>=1.1...
add releaseNotes to TC add releaseNotes to TC
@@ -296,3 +296,4 @@ script: description: confidence in indicator, in scale of 1-100 description: Add a new indicator to ThreatConnect dockerimage: demisto/threatconnect-sdk +releaseNotes: "Fix proxy condition in TC"
Rewrite function comparison paragraph It isn't about modules.
@@ -53,9 +53,10 @@ Parsl determines app equivalence by storing the a hash of the app function. Thus, any changes to the app code (e.g., its signature, its body, or even the docstring within the body) will invalidate cached values. -Further, Parsl does not traverse imported modules, and thus -changes to modules used by ...
[cleanup] remove dontTouchRegexes dontTouchRegexes points to result. The code is more ugly keeping this double access to result than having a single line from 2008 unchanged.
@@ -310,8 +310,6 @@ def _get_regexes(keys, site): _create_default_regexes() result = [] - # 'dontTouchRegexes' exist to reduce git blame only. - dontTouchRegexes = result for exc in keys: if isinstance(exc, UnicodeType): @@ -342,10 +340,10 @@ def _get_regexes(keys, site): result.append(_regex_cache[exc]) # handle alias...
list_types_ada.mako: use unchecked convs. not to rely on tagged types TN:
Or_Null : Boolean := False) return ${element_type.name} is function Absolute_Get - (L : ${type_name}; Index : Integer) - return ${element_type.name} - is - (${element_type.name} (L.Nodes (Index + 1))); + (L : ${type_name}; Index : Integer) return ${element_type.name}; -- L.Nodes is 1-based but Index is 0-based - functi...
Convert the teardown functions to async This supports the existing synchronous usage, whilst also supporting async teardown functions. It follows the same pattern elsewhere in Quart and was missed originally in an oversight.
@@ -1159,7 +1159,8 @@ class Quart(PackageStatic): func: The teardown request function itself. name: Optional blueprint key name. """ - self.teardown_request_funcs[name].append(func) + handler = ensure_coroutine(func) + self.teardown_request_funcs[name].append(handler) return func def teardown_websocket(self, func: Call...
Repair Nuke-integration Regression from
@@ -243,8 +243,8 @@ def _install_menu(): creator, # publish, workfiles, - cbloader, - cbsceneinventory, + loader, + sceneinventory, contextmanager ) # for now we are using `lite` version @@ -263,9 +263,9 @@ def _install_menu(): menu.addSeparator() menu.addCommand("Create...", creator.show) - menu.addCommand("Load...", ...
Update avemaria.txt Nanocore instead.
@@ -215,13 +215,6 @@ craftedfollowing.duckdns.org ventm.warzonedns.com -# Reference: https://www.virustotal.com/gui/file/883562a2a36809c07e2368a7d0fd47e8e8fc23a839837f1ebe64b86dcc3209d5/detection - -79.134.225.74:2404 -79.134.225.89:2404 -behco.duckdns.org -paris4real111.ddnsfree.com - # Reference: https://www.virustot...
fix: Direct3D includes are not exposed The include paths for the D3D11 and D3D12 backends were not exposed. As a result, consumers of the recipes could not use the D3D11/12 backends. The fix is to simply add the missing include paths to `self.cpp_info` in `package_info()`. Fixes
@@ -184,6 +184,8 @@ class DiligentCoreConan(ConanFile): self.cpp_info.includedirs.append(os.path.join("include", "DiligentCore", "Platforms", "Basic", "interface")) self.cpp_info.includedirs.append(os.path.join("include", "DiligentCore", "Platforms", "Linux", "interface")) self.cpp_info.includedirs.append(os.path.join(...
[easy] fix windows scheduler tests Summary: Cron is not a thing on windows Test Plan: BK + Azure Reviewers: johann, alangenfeld, prha
pipeline, repository, schedule, + seven, solid, ) from dagster.core.definitions.job import RunRequest @@ -1301,6 +1302,7 @@ def test_multi_runs_missing_run_key(external_repo_context, capfd): ) +@pytest.mark.skipif(seven.IS_WINDOWS, reason="Cron doesn't work on windows") def test_run_with_hanging_cron_schedules(): # Ver...
quote NUMPY_INCLUDE_DIR Summary: when NUMPY_INCLUDE_DIR contains space character (e.g. "C:\Program Files (x86)\Microsoft Visual Studio\..."), cmake cannot receive correct path name. Pull Request resolved:
@@ -227,7 +227,7 @@ goto:eof -DUSE_DISTRIBUTED=%USE_DISTRIBUTED% ^ -DUSE_FBGEMM=%USE_FBGEMM% ^ -DUSE_NUMPY=%USE_NUMPY% ^ - -DNUMPY_INCLUDE_DIR=%NUMPY_INCLUDE_DIR% ^ + -DNUMPY_INCLUDE_DIR="%NUMPY_INCLUDE_DIR%" ^ -DUSE_NNPACK=%USE_NNPACK% ^ -DUSE_LEVELDB=%USE_LEVELDB% ^ -DUSE_LMDB=%USE_LMDB% ^
Add try/catch and Promise resolve/reject to js sdk This handles cases when the apply method doesn't return a promise, or apply throws an exception.
@@ -103,8 +103,13 @@ class TransactionProcessor { candidate.versions.includes(txnHeader.familyVersion)) if (handler) { - handler - .apply(request, context) + let applyPromise + try { + applyPromise = Promise.resolve(handler.apply(request, context)) + } catch(err) { + applyPromise = Promise.reject(err) + } + applyPromis...
Texas: added video evidence Only articles were submitted so I have added the video itself.
@@ -6,6 +6,7 @@ A 20-year-old black man is hospitalized in critical condition after police shot **Links** +* https://www.reddit.com/r/Bad_Cop_No_Donut/comments/gwd37n/a_black_20yearold_student_justin_howell_is_in/ * https://www.texastribune.org/2020/06/01/austin-police-george-floyd-mike-ramos/ * https://www.kvue.com/ar...
Support (and prefer) per-controller macaroon files Juju 2.2-beta4 moved to per-controller macaroon files, which breaks auth. Fixes
@@ -11,6 +11,7 @@ import subprocess import websockets from concurrent.futures import CancelledError from http.client import HTTPSConnection +from pathlib import Path import asyncio import yaml @@ -436,7 +437,7 @@ class Connection: accounts = jujudata.accounts()[controller_name] username = accounts['user'] password = ac...
Fix link to CommCare Cloud docs (Also, "setup" is a noun. The verb is "set up" / "setting up".)
@@ -22,8 +22,8 @@ bundled [web application platform](https://github.com/dimagi/formplayer). ### More Information + To try CommCare you can use [this production instance of hosted CommCare](https://www.commcarehq.org/). -+ To setup a local CommCare HQ developer environment, see [Setting up CommCare HQ for Developers](ht...
Update amazon.py Fix a typo for the amazon instant video dataset
@@ -176,7 +176,7 @@ class AmazonInstantVideo(AmazonDataset): def __init__(self, min_u_c=0, min_i_c=3, root_dir=None): r"""Init AmazonInstantVideo Class.""" super().__init__( - dataset_name="amazon-amazon-instant-video", + dataset_name="amazon-instant-video", min_u_c=min_u_c, min_i_c=min_i_c, root_dir=root_dir,
Update settings.py Some additional ```.%{suffix}%``` types, that were met ITW.
@@ -100,7 +100,7 @@ SUSPICIOUS_HTTP_PATH_REGEXES = ( ("potential web scan", r"inexistent_file_name\.inexistent|test-for-some-inexistent-file|long_inexistent_path|some-inexistent-website\.acu") ) SUSPICIOUS_HTTP_REQUEST_PRE_CONDITION = ("?", "..", ".ht", "=", " ", "'") -SUSPICIOUS_DIRECT_IP_URL_REGEX = r"\A[\w./-]*/[\w....
Add set_issue_status_by_id It is better to close the task by ID, the status name can be changed :(
@@ -841,6 +841,15 @@ class Jira(AtlassianRestAPI): transition_id = self.get_transition_id_to_status_name(issue_key, status_name) return self.post(url, data={'transition': {'id': transition_id}}) + def set_issue_status_by_id(self, issue_key, transition_id): + """ + Setting status by transition_id + :param issue_key: str...
Add logging showing BotInfo before and after update in bot_management.bot_event Review-Url:
import datetime import hashlib +import logging from google.appengine.ext import ndb @@ -354,7 +355,12 @@ def bot_event( # Retrieve the previous BotInfo and update it. info_key = get_info_key(bot_id) - bot_info = info_key.get() or BotInfo(key=info_key) + bot_info = info_key.get() + if bot_info: + logging.info('Updating ...
Visual Code: Handle pylint warning only given when running per file. * That is how they do it, which makes pylint give this. Still we want to be clean, so lets try to avoid it.
@@ -401,7 +401,7 @@ class TraceCollectionBase(CollectionTracingMixin): @staticmethod def signalChange(tags, source_ref, message): - # This is monkey patched from another module. + # This is monkey patched from another module. pylint: disable=I0021,not-callable signalChange(tags, source_ref, message) def onUsedModule(se...
ec2: Move key file path and mode validation into separate function Move the key file existence and mode validation from create() into a separate function, so we can write unit tests for it and make create() simpler.
@@ -2481,6 +2481,31 @@ def wait_for_instance( return vm_ +def _validate_key_path_and_mode(key_filename): + if key_filename is None: + raise SaltCloudSystemExit( + 'The required \'private_key\' configuration setting is missing from the ' + '\'ec2\' driver.' + ) + + if not os.path.exists(key_filename): + raise SaltCloudS...
GDB helpers: fix generation when library short name is missing TN:
@@ -1179,7 +1179,8 @@ class CompileCtx(object): lib_name=lib_name, astnode_names={node.name().lower for node in self.astnode_types}, - prefix=self.short_name.lower or self.lib_name, + prefix=(self.short_name.lower + if self.short_name else lib_name), )) # Add any sources in $lang_path/extensions/support if it exists
Fix errors property in Writer It needs to return serializable object.
import abc import itertools from collections import defaultdict -from typing import List +from typing import Any, Dict, List from django.conf import settings @@ -17,6 +17,10 @@ class Writer(abc.ABC): """Save the read contents to DB.""" raise NotImplementedError('Please implement this method in the subclass.') + def err...
Specify the package name in setup.py This should fix GitHub's issue with finding dependents for this project.
@@ -28,7 +28,6 @@ extras_require = { } metadata = { - "name": "uplink", "author": "P. Raj Kumar", "author_email": "raj.pritvi.kumar@gmail.com", "url": "https://uplink.readthedocs.io/", @@ -58,4 +57,4 @@ metadata = { metadata = dict(metadata, **about) if __name__ == "__main__": - setup(**metadata) + setup(name="uplink",...
Trivial change to IdleTomographyObservedRatesTable. Shifts of "X below threshold" message left to the figure column since that one is typically wider (make the table look a little nicer).
@@ -135,7 +135,7 @@ class IdleTomographyObservedRatesTable(_ws.WorkspaceTable): table.addrow(row_data, row_formatters) if nBelowThreshold > 0: - table.addrow( ["", "%d observed rates below %g" % (nBelowThreshold,rate_threshold)], + table.addrow( ["%d observed rates below %g" % (nBelowThreshold,rate_threshold), ""], [No...
Do not use len to assert existance of attempts It forces unnecessary evaluation of the length of attemps.
@@ -62,7 +62,7 @@ def log_user_login_failed(sender, credentials, request, **kwargs): get_axes_cache().set(cache_hash_key, failures, cache_timeout) # has already attempted, update the info - if len(attempts): + if attempts: for attempt in attempts: attempt.get_data = '%s\n---------\n%s' % ( attempt.get_data,
Fix a failing test for row selection in `_get_selected_cells()`. Rename auxiliary `find()` params: `row` -> `in_row` `col` -> `in_column` Add `in_row` and `in_column` params to `findall()`. Add param specs.
@@ -1703,7 +1703,7 @@ class Worksheet(object): absolute_range_name(self.title) ) - def _finder(self, func, query, col, row): + def _finder(self, func, query, in_row=None, in_column=None): data = self.spreadsheet.values_get(absolute_range_name(self.title)) try: @@ -1711,7 +1711,7 @@ class Worksheet(object): except KeyEr...
catch exception when parsing score breakdown json I see some cases where CachedQueryResult returns `'None'` as the value. The old app just wraps the `json.loads` in a try/catch, so I'll do the same thing here. Fixes
@@ -197,7 +197,10 @@ class Match(CachedModel): Lazy load score_breakdown_json """ if self._score_breakdown is None and self.score_breakdown_json is not None: + try: score_breakdown = json.loads(none_throws(self.score_breakdown_json)) + except json.decoder.JSONDecodeError: + return None if self.has_been_played: # Add in...
Update ryuk.txt Root form of domains only. Subs will be detected automatically.
@@ -186,3 +186,19 @@ zsplace.com climinus.com hayridumanli.com mysocialsoftware.com + +# Reference: https://community.riskiq.com/article/0bcefe76 + +balanarr.com +bukaguka.com +daemon-update.com +hotlable.com +hunbabe.com +myobtain.com +nasmasterservice.com +primeviref.com +raingamess.com +servicemusthave.com +starcycl...
Update Pytorch to version 1.12.0 and TorchVision to 0.13.0 update Pytorch to version 1.12.0 and TorchVision to 0.13.0
@@ -36,6 +36,6 @@ pip3 install \ pip3 install future pip3 install \ - torch==1.11.0 \ - torchvision==0.12.0 \ + torch==1.12.0 \ + torchvision==0.13.0 \ --extra-index-url https://download.pytorch.org/whl/cpu
Refactor tests for monthly usage API These are now consistent with the yearly usage API tests.
@@ -150,11 +150,12 @@ def test_get_yearly_usage_by_monthly_from_ft_billing_populates_deltas(admin_requ assert fact_billing[0].notification_type == 'sms' -def test_get_yearly_usage_by_monthly_from_ft_billing(admin_request, notify_db_session): +def set_up_monthly_data(): service = create_service() sms_template = create_t...
Calculate sha256sum for release assets And include .sha256 files to the assets as well
@@ -22,6 +22,9 @@ assets_dir=$TEMPDIR/assets nix-build -A release -o "$TEMPDIR"/"$project" --arg timestamp "$(date +\"%Y%m%d%H%M\")" \ --arg docker-binaries ./binaries/docker --arg docker-arm-binaries ./arm-binaries/docker mkdir -p "$assets_dir" +for asset in "$assets_dir"/*; do + sha256sum "$asset" > "$asset.sha256" +...
[recipes] Fix compilation for regex recipe The error was: build/other_builds/hostpython3/desktop/hostpython3/Include/Python.h:39:19: fatal error: crypt.h: No such file or directory
@@ -7,6 +7,7 @@ class RegexRecipe(CompiledComponentsPythonRecipe): url = 'https://pypi.python.org/packages/d1/23/5fa829706ee1d4452552eb32e0bfc1039553e01f50a8754c6f7152e85c1b/regex-{version}.tar.gz' depends = ['setuptools'] + call_hostpython_via_targetpython = False recipe = RegexRecipe()
Quick fix for inline JS at Django template level. Ideal case would be to include this in a bundle.
var fastclick = require('fastclick'); +window.$ = $; // side effect: binds handlebars helpers to our handlebars instance require('../handlebars/helpers.js');
Update command-line-tools.rst Updated code block to be more specific that the entry is a username not a name of a user.
@@ -2081,8 +2081,8 @@ mattermost user migrate_auth .. code-block:: json { - "user1@email.com": "user.one", - "user2@email.com": "user.two" + "user1@email.com": "username.one", + "user2@email.com": "username.two" } Users file generation
[modules/brightness] Fix return format What: Fixes the return format in `brightness` module Why: To remove the initial zero in the brightness indicator when below hundred.
@@ -29,7 +29,7 @@ class Module(bumblebee.engine.Module): def brightness(self, widget): if isinstance(self._brightness, float): - return "{:03.0f}%".format(self._brightness) + return "{:3.0f}%".format(self._brightness).strip() else: return "n/a"
Why do you hate functional programming, Python? The whole string module is deprecated - you're supposed to use methods now :(
@@ -10,7 +10,6 @@ from __future__ import unicode_literals import copy from collections import Counter, defaultdict from decimal import Decimal, InvalidOperation -from string import strip from attr import attrs, attrib from django.core.exceptions import ValidationError @@ -52,6 +51,10 @@ def to_boolean(val): return Fals...
Fix f string error I apologize
@@ -11332,7 +11332,7 @@ and follow recommend steps to authorize GAM for Drive access.''') else: mimeType = MIMETYPE_GA_SPREADSHEET body = {'description': QuotedArgumentList(sys.argv), - f'name': '{GC_Values[GC_DOMAIN]} - {list_type}', + 'name': f'{GC_Values[GC_DOMAIN]} - {list_type}', 'mimeType': mimeType} result = gap...
upgrade lexical-core to fix a bug in recent rustc version Upgrade the `lexical-core` crate to version v0.7.6 (from v0.7.4) so we get the fix from v0.7.5 that is blocking the upgrade to Rust v1.53.0. See for the particular error. [ci skip-build-wheels]
@@ -1452,13 +1452,13 @@ checksum = "830d08ce1d1d941e6b30645f1a0eb5643013d835ce3779a5fc208261dbe10f55" [[package]] name = "lexical-core" -version = "0.7.4" +version = "0.7.6" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "db65c6da02e61f55dae90a0ae427b2a5f6b3e8db09f58d10efab23af92592616" +c...
upload: Use URL manipulation for get_public_upload_url logic. This is much faster than calling generate_presigned_url each time. ``` In [3]: t = time.time() ...: for i in range(250): ...: x = u.get_public_upload_url("foo") ...: print(time.time()-t) 0.0010945796966552734 ```
@@ -387,12 +387,10 @@ class S3UploadBackend(ZulipUploadBackend): self.uploads_bucket = get_bucket(settings.S3_AUTH_UPLOADS_BUCKET, self.session) self._boto_client = None + self.public_upload_url_pattern = self.construct_public_upload_url_pattern() - def get_public_upload_url( - self, - key: str, - ) -> str: - # Return ...
langkit.compile_context: re-order imports TN:
@@ -24,9 +24,8 @@ from langkit.ada_api import AdaAPISettings from langkit.c_api import CAPISettings from langkit.diagnostics import (Context, Severity, WarningSet, check_source_language) -from langkit.utils import ( - TopologicalSortError, topological_sort, memoized, memoized_with_default -) +from langkit.utils import ...
chore: add new spec.json file in accord to the changes of the docstrings. chore: correctly add the spec json file
"module": "vaex.ml.lightgbm", "snake_name": "lightgbm_model", "traits": [ - { - "default": false, - "has_default": false, - "help": "Copy data or use the modified xgboost library for efficient transfer.", - "name": "copy", - "type": "Bool" - }, { "default": null, "has_default": true,
Added a simple install command To install locally, call: python ABCD.py install You will then be able to use it in scripts from any directory
@@ -726,11 +726,13 @@ class OpticalPath(object): return (x,y) import os +import subprocess def installModule(): + directory = subprocess.check_output('python -m site --user-site', shell=True) os.system('mkdir -p "`python -m site --user-site`"') os.system('cp ABCD.py "`python -m site --user-site`/"') os.system('cp Axico...
Update `.conf` locations Configuration files for pgsql 9.4 on CentOS7.3 are now located in `/var/lib/pgsql/9.4/data/`
@@ -62,7 +62,7 @@ Installing PostgreSQL Database 15. Allow Postgres to listen on all assigned IP Addresses. - a. Open ``/etc/postgresql/9.4/main/postgresql.conf`` as root in a text editor. + a. Open ``/var/lib/pgsql/9.4/data/postgresql.conf`` as root in a text editor. b. Find the following line: @@ -76,7 +76,7 @@ Insta...
[bugfix] Fix category tidy error when not using custom summary edit_summary has to be instantiated before we call if edit_summary later in the script as it throws an error otherwise.
@@ -987,9 +987,8 @@ class CategoryTidyRobot(Bot, CategoryPreprocess): """Initializer.""" self.cat_title = cat_title self.cat_db = cat_db - if comment: self.edit_summary = comment - else: + if not comment: self.template_vars = {'oldcat': cat_title} site = pywikibot.Site()
DOC: add 2 projects using sphinx gallery These are: * *
@@ -25,4 +25,6 @@ Here is a list of projects using `sphinx-gallery`. * `Fury <http://fury.gl/latest/auto_examples/index.html>`_ * `NetworkX <https://networkx.github.io/documentation/stable/auto_examples/index.html>`_ * `Optuna <https://optuna.readthedocs.io/en/stable/tutorial/index.html>`_ +* `Auto-sklearn <https://aut...
Clarify that there is only one polling agent Mention in install/get_started.rst that the compute polling agent and the central polling agent are actually the same program, running in different polling namespaces. Closes-Bug:
@@ -16,12 +16,15 @@ The Telemetry service consists of the following components: A compute agent (``ceilometer-agent-compute``) Runs on each compute node and polls for resource utilization - statistics. + statistics. This is actually the polling agent ``ceilometer-polling`` + running with parameter ``--polling-namespace...
Update required Keras version to 2.3.0 In accordance to
@@ -251,7 +251,7 @@ Example output images using `keras-retinanet` are shown below. If you have a project based on `keras-retinanet` and would like to have it published here, shoot me a message on Slack. ### Notes -* This repository requires Keras 2.2.4 or higher. +* This repository requires Keras 2.3.0 or higher. * Thi...
[IMPR] Skip PageSaveRelatedError and ServerError in checkimages skip PageSaveRelatedError when putting talk page if CheckImagesBot.ignore_save_related_errors is True (default: True) skip ServerError when putting talk page if CheckImagesBot.ignore_server_errors is True (default: False)
@@ -99,6 +99,8 @@ from pywikibot.exceptions import ( NoPageError, NotEmailableError, PageRelatedError, + PageSaveRelatedError, + ServerError, TranslationError, ) from pywikibot.family import Family @@ -501,6 +503,9 @@ class CheckImagesBot: """A robot to check recently uploaded files.""" + ignore_save_related_errors = T...
Documantation to chek synapse version I've added some Documentation, how to get the running Version of a Synapse homeserver. This should help the HS-Owners to check whether the Upgrade was successful.
@@ -29,6 +29,15 @@ running: # Update the versions of synapse's python dependencies. python synapse/python_dependencies.py | xargs -n1 pip install --upgrade +To check whether your update was sucessfull, run: + +.. code:: bash + + # replace your.server.domain with ther domain of your synaspe homeserver + curl https://<yo...
Fix test_ir_type. * The void return type is not None/nullptr, it's VoidType or TupleType([]).
@@ -72,7 +72,7 @@ def test_func_type(): def test_tuple_type(): tp = tvm.ir.TypeVar('tp', tvm.ir.TypeKind.Type) - tf = tvm.ir.FuncType([], None, [], []) + tf = tvm.ir.FuncType([], tvm.ir.TupleType([]), [], []) tt = tvm.ir.TensorType(tvm.runtime.convert([1, 2, 3]), 'float32') fields = tvm.runtime.convert([tp, tf, tt])
Fix networks in IP setter Match new networks format.
@@ -40,9 +40,9 @@ def update_provider_context(args): raise ValueError('Cannot change network {0} address' .format(network_name)) else: - agent_dict['networks'][network_name] = address + agent_dict['networks'][network_name]['manager'] = address agent_dict['broker_ip'] = args.manager_ip - agent_dict['networks']['default'...
MAINT: made doc fixes Fixed issues with wording and formatting.
@@ -15,7 +15,7 @@ Sample Period Mean Function The code below creates a function called ``periodic_mean`` that takes either a pysat Instrument or Orbits object connected to an Instrument and calculates -the mean every daily or every orbit over the period of time supplied by +the mean every day or every orbit over the pe...
Fix XLA fallback to avoid checking the mesh conditions The warning about not using the full mesh manually is mainly to improve error messages (otherwise an XLA error is generated). But the MLIR lowering fallback uses axis_env unconditionally, so we have to go around that check.
@@ -364,6 +364,10 @@ class SPMDAxisContext: "Collectives in manually partitioned computations are only supported " "when all mesh axes are partitioned manually (no partial automatic sharding). " "Make sure that you mention all mesh axes in axis_resources!") + return self.unsafe_axis_env + + @property + def unsafe_axis_...
Add additional logging for termination tasks TBR=maruel Review-Url:
@@ -559,6 +559,12 @@ def associate_termination_task(key, hostname, task_id): if machine_lease.termination_task: return + logging.info( + 'Associating termination task\nKey: %s\nHostname: %s\nTask ID: %s', + key, + machine_lease.hostname, + machine_lease.termination_task, + ) machine_lease.termination_task = task_id mac...
ArrayType.array_type_name: add missing rtype in docstring TN:
@@ -2234,6 +2234,8 @@ class ArrayType(CompiledType): def array_type_name(self): """ Name of the Ada array type. + + :rtype: names.Name """ return self.element_type.name + names.Name('Array')
Adjust find_token_in_message tests for the recent cog changes It now supports the changes that switched to finditer, added match groups, and added the Token NamedTuple. It also accounts for the is_maybe_token function being removed. For the sake of simplicity, call assertions on is_valid_user_id and is_valid_timestamp ...
import unittest +from re import Match from unittest import mock from unittest.mock import MagicMock @@ -130,9 +131,8 @@ class TokenRemoverTests(unittest.IsolatedAsyncioTestCase): self.assertIsNone(return_value) token_re.finditer.assert_not_called() - @autospec(TokenRemover, "is_maybe_token") @autospec("bot.cogs.token_r...
(more-config-work-4) Rename Dict Api object to DagsterDictApi Summary: Trivial. Just renaming this as it's own PR Test Plan: BK Reviewers: max, alangenfeld
@@ -100,7 +100,7 @@ def __getitem__(self, inner_type): return WrappingSetType(inner_type) -class DictTypeApi(object): +class DagsterDictApi(object): def __call__(self, fields): from dagster.core.types.config.field_utils import build_config_dict @@ -121,4 +121,4 @@ def __getitem__(self, *args): Tuple = DagsterTupleApi()...
Show permission failure message based on passed user only if user passed is equal to session user or if no user is passed
@@ -24,8 +24,10 @@ def print_has_permission_check_logs(func): def inner(*args, **kwargs): frappe.flags['has_permission_check_logs'] = [] result = func(*args, **kwargs) + self_perm_check = True if not kwargs['user'] else kwargs['user'] == frappe.session.user # print only if access denied - if not result: + # and if user...
Move circleci cache save until after tests That way the minorminer cache is also saved.
@@ -12,7 +12,7 @@ jobs: - restore_cache: &restore-cache-template keys: - - v1-dependencies-{{ checksum "requirements.txt" }}-{{ checksum "tests/requirements.txt" }}-{{ .Environment.CIRCLE_JOB }} + - v2-dependencies-{{ checksum "requirements.txt" }}-{{ checksum "tests/requirements.txt" }}-{{ .Environment.CIRCLE_JOB }} -...
pywinusb backend: raise DeviceError on timeout while opening device. DeviceError is raised instead of a forced assertion failure.
@@ -83,13 +83,14 @@ class PyWinUSB(Interface): # If the device could not be opened in read only mode # Then it either has been disconnected or is in use # by another thread/process - raise six.raise_from(DAPAccessIntf.DeviceError("Unable to open device"), exc) + raise six.raise_from(DAPAccessIntf.DeviceError("Unable to...
Update CHANGES.rst Fixed triple quotes to double quotes
@@ -26,7 +26,7 @@ New Features - ``combine`` now accepts ``numpy.ndarray`` as the input ``img_list``. [#493, #503] -- Added ```sum``` option in method for ```combime```. [#500, #508] +- Added ``sum`` option in method for ``combime``. [#500, #508] Other Changes and Additions
SConstruct : Remove FaceAreaOp stub This op has been removed in Cortex 10.
@@ -844,7 +844,6 @@ libraries = { # meshes ( "TriangulateOp", "ops/mesh/triangulate" ), - ( "FaceAreaOp", "ops/mesh/faceArea" ), ( "MeshMergeOp", "ops/mesh/merge" ), ( "MeshNormalsOp", "ops/mesh/normals" ),
Apply suggestions from code review changes error ts arg/var name explicitly uses runtime.cwd instead of tmpdir
@@ -135,7 +135,7 @@ def get_parser(): g_other.add_argument("--estimator", action="store", type=str, help="estimator to use to fit the model", default="nistats", choices=["nistats", "afni"]) - g_other.add_argument("--errorts", action='store_true', default=False, + g_other.add_argument("--error-ts", action='store_true', ...
ci: print deployment command This commit prints the command that will deploy the CI Job.
@@ -406,7 +406,9 @@ def run_e2e_job(distro, driver, masters, workers, str(hypervisors), str(job_type), str(launch_from)) + print("'launch_e2e.py' ==> The deployment command is:") print(deployment_command) + launch_output = subprocess.run(deployment_command, shell=True, check=True) print("'launch_e2e.py' ==> ./ci/launch...
don't rely on SIP to check if Qt object exists sip import may fail on some installations, see
@@ -18,7 +18,7 @@ from subprocess import Popen import click import keyring from keyring.errors import KeyringLocked -from PyQt5 import QtCore, QtWidgets, sip +from PyQt5 import QtCore, QtWidgets # maestral modules from maestral.config.main import CONF @@ -629,11 +629,14 @@ def _is_linked(): def _is_pyqt_obj(obj): """Ch...
chore: escape regex correctly why codacy?
@@ -264,7 +264,7 @@ frappe.utils.sanitise_redirect = (url) => { const is_external = (() => { return (url) => { function domain(url) { - let base_domain = /^(?:https?://)?(?:[^@\n]+@)?(?:www\.)?([^:\/\n?]+)/img.exec(url); + let base_domain = /^(?:https?:\/\/)?(?:[^@\n]+@)?(?:www\.)?([^:\/\n?]+)/img.exec(url); return bas...
update read bitalino to select channels correctly channels information in the metadata is not the column index but rather the port index (e.g. A1, A2, A6 => 1, 2, 6)
@@ -47,7 +47,7 @@ def read_bitalino(filename): list(metadata.keys())[0] ] # convert json header to dict (only select first device / MAC address) sampling_rate = metadata["sampling rate"] - channels = np.array(metadata["channels"]) + 5 # analog channels start from column 5 + channels = np.arange(len(metadata["channels"]...
Update example run command in tutorial It is not recommended to run `mlflow ui` from the root directory of MLFlow. As a result, the tutorial is updated to use `examples` directory as the working directory. The two example commands are however not updated accordingly.
@@ -78,13 +78,15 @@ First, train a linear regression model that takes two hyperparameters: ``alpha`` .. code-block:: py - python examples/sklearn_elasticnet_wine/train.py + # Make sure the current working directory is 'examples' + python sklearn_elasticnet_wine/train.py Try out some other values for ``alpha`` and ``l1_...
Fixup api doc. Replaces
@@ -1570,9 +1570,10 @@ Query-builder # Get user and a list of their tweet IDs. The tweet IDs are # returned as a comma-separated string by the db, so we'll split # the result string and convert the values to python ints. + convert_ids = lambda s: [int(i) for i in (s or '').split(',')] tweet_ids = (fn .GROUP_CONCAT(Twee...
Add instruction of Azure test case Azure test case development steps
@@ -113,6 +113,20 @@ This XML file defines the regions per Category. It may require specific region o Per Category, each XML file has VM name, Resource Group name, etc. We do not recommend to make change of the file. +## Add test case in Azure + + 1. Design test case and its configuration. + 2. Create a new test case x...
remove superfluous flake8 rule ignores because some linting violations have been fixed in the meantime
@@ -47,15 +47,11 @@ extend-ignore = # Allow certain violations in certain files: per-file-ignores = - # FIXME: D100 Missing docstring in public module - # FIXME: D101 Missing docstring in public class # FIXME: D102 Missing docstring in public method - # FIXME: drop these once they're made simpler - # Ref: https://githu...
Fix variable declaration In plain old C, variables shall be declared above Fix
@@ -1120,7 +1120,7 @@ psutil_net_connections(PyObject *self, PyObject *args) { mib2_udp6Entry_t ude6; #endif char buf[512]; - int i, flags, getcode, num_ent, state; + int i, flags, getcode, num_ent, state, ret; char lip[INET6_ADDRSTRLEN], rip[INET6_ADDRSTRLEN]; int lport, rport; int processed_pid; @@ -1147,7 +1147,7 @@...
Update new endpoint tutorial Remove remaining outdated materials
@@ -12,7 +12,7 @@ In this tutorial we'll create a brand new endpoint for the Epidata API: `fluview_meta`. At a high level, we'll do the following steps: 1. understand the data that we want to surface -2. add the new endpoint to `api.php` +2. add the new endpoint to the API server 3. add the new endpoint to the various ...
Update core-base.vue whitespace
}, navOpenStyle() { if (this.navShown) { - return { - marginLeft: `${this.paddingForNav}px`, - }; + return { marginLeft: `${this.paddingForNav}px` }; } return ''; },
Update 01_reachability_map.rst small typo in reuleaux link
@@ -14,7 +14,7 @@ available robots. Links ===== -* `Realuex (ROS's reachability map) <http://wiki.ros.org/reuleaux>`_ +* `Reuleaux (ROS's reachability map) <http://wiki.ros.org/reuleaux>`_ Example 01: reachability map 1D
Code block: fix formatting of the additional message The newlines should be replaced with a space rather than with 1 newline. To separate the two issues, a double newline is prepended to the entire additional message.
@@ -34,10 +34,10 @@ def get_bad_ticks_message(code_block: parsing.CodeBlock) -> Optional[str]: # already have an example code block. if addition_msg: # The first line has a double line break which is not desirable when appending the msg. - addition_msg = addition_msg.replace("\n\n", "\n", 1) + addition_msg = addition_m...
Fixing NullPointerException Summary: The previous diff missed the other usage
@@ -40,14 +40,15 @@ object Helper { def getDataTypes(sqlContext: SQLContext, tableName: String, columnNames: List[String]): Map[String, String] = { + // null check is required because jackson doesn't care about default values + val notNullColumnNames = Option(columnNames).getOrElse(List[String]()) val dt = sqlContext.s...
support build Boost with Emscripten This changes the Boost conanfile to not fail if the "arch" profile setting is "asm.js" and to explicitly use the "emscripten" Boost Build toolchain if the "os" profile setting is "Emscripten".
@@ -619,6 +619,8 @@ class BoostConan(ConanFile): pass elif arch.startswith("mips"): pass + elif arch.startswith("asm.js"): + pass else: raise Exception("I'm so sorry! I don't know the appropriate ABI for " "your architecture. :'(") @@ -732,6 +734,8 @@ class BoostConan(ConanFile): return "msvc", _msvc_version, "" elif s...
Add operationId properties to endpoints This enables client SDK generators to create nicer names for the functions Otherwise auto generated names are used, which are mostly suboptimal
@@ -16,6 +16,7 @@ paths: tags: - Server Information summary: Health endpoint of Rasa Server + operationId: getHealth description: >- This URL can be used as an endpoint to run health checks against. When the server is running @@ -35,6 +36,7 @@ paths: get: tags: - Server Information + operationId: getVersion summary: Ve...
BUG: separate data objects Copy the data object when writing xarray netCDF data files.
@@ -1125,8 +1125,9 @@ def inst_to_netcdf(inst, fname, base_instrument=None, epoch_name='Epoch', # Attach attributes out_data.setncatts(attrb_dict) else: - # Attach the metadata to the xarray.Dataset - xr_data = inst.data + # Attach the metadata to a separate xarray.Dataset object, ensuring + # the Instrument data objec...
Add extra new line The markdown parser for the website requires a new line here to create bullet points.
@@ -7,5 +7,6 @@ category: upgrade # TiDB Development Release Upgrade Guide Please see the upgrade guides from the following earlier releases: + - [Upgrading to TiDB 2.1](https://pingcap.com/docs/v2.1/how-to/upgrade/from-previous-version/) - [Upgrading to TiDB 3.0](https://pingcap.com/docs/v3.0/how-to/upgrade/from-previ...
right-sidebar: Fix menu icon hover color. This will fix the menu icon hover effect for the day mode.
&:hover { display: inline; cursor: pointer; - color: hsl(0, 0%, 0%); + color: hsl(0, 0%, 0%) !important; } }
DOC: optimize: fix doc that `curve_fit` xdata should be float convertible [skip azp] [skip actions]
@@ -545,10 +545,11 @@ def curve_fit(f, xdata, ydata, p0=None, sigma=None, absolute_sigma=False, The model function, f(x, ...). It must take the independent variable as the first argument and the parameters to fit as separate remaining arguments. - xdata : array_like or object + xdata : array_like The independent variab...
Update lax.py Use the accurate mathematical description to avoid confusion. We may want to say the dimension of the array rather than the rank of the tensor array.
@@ -635,8 +635,8 @@ def dot(lhs: Array, rhs: Array, precision: PrecisionLike = None, For more general contraction, see the `dot_general` operator. Args: - lhs: an array of rank 1 or 2. - rhs: an array of rank 1 or 2. + lhs: an array of dimension 1 or 2. + rhs: an array of dimension 1 or 2. precision: Optional. Either `...
{AppService} make webapp name local context value readable for cupertino * {AppService} make webapp name local context value readable for cupertino * temp add * add cupertino for webapp up * Revert "temp add" This reverts commit
@@ -126,7 +126,7 @@ def load_arguments(self, _): c.argument('name', options_list=['--name', '-n'], help='name of the new web app', validator=validate_site_create, local_context_attribute=LocalContextAttribute(name='web_name', actions=[LocalContextAction.SET], - scopes=['webapp'])) + scopes=['webapp', 'cupertino'])) c.a...
fix(context): do not set type on class attribute Otherwise dataclasses transforms it to an instance attribute.
@@ -100,7 +100,7 @@ class Installation: ) return self._user_tokens - USER_ID_MAPPING_CACHE_KEY: str = "user-id-mapping" + USER_ID_MAPPING_CACHE_KEY = "user-id-mapping" async def get_user( self, login: github_types.GitHubLogin
Corrected vec2d cross documentation Documentation had incorrect cross product formula (function was correct)
@@ -463,7 +463,7 @@ class Vec2d(object): def cross(self, other): """The cross product between the vector and other vector - v1.cross(v2) -> v1.x*v2.y - v2.y*v1.x + v1.cross(v2) -> v1.x*v2.y - v1.y*v2.x :return: The cross product """
Add Python version to README.md Make it clear which version of Python we support
[![Build Status](https://travis-ci.org/metoppv/improver.svg?branch=master)](https://travis-ci.org/metoppv/improver) [![Codacy Badge](https://api.codacy.com/project/badge/Grade/f7dcb46e8e1b4110b3d194dba03fe526)](https://www.codacy.com/app/metoppv_tech/improver?utm_source=github.com&amp;utm_medium=referral&amp;utm_conten...
TST: Simple tests for `from_euler` Initial tests. More to be added.
@@ -63,7 +63,7 @@ def test_zero_norms_from_quaternion(): [5, 0, 12, 0] ]) with pytest.raises(ValueError): - r = Rotation.from_quaternion(x) + Rotation.from_quaternion(x) def test_as_dcm_single_1d_quaternion(): @@ -314,3 +314,15 @@ def test_rotvec_calc_pipeline(): [-3e-4, 3.5e-4, 7.5e-5] ]) assert_allclose(Rotation.from...
Fix the enigmatic scale case There seem to be a mistake in the enigmatic scale: enigmatic = Scale('G', 'enigmatic', 'mAMMMmM') Semitone, Tone and a half, Tone, Tone, Tone, Semitone, Semitone. Should be enigmatic = Scale('G', 'enigmatic', 'mAMMMmm')
@@ -110,7 +110,7 @@ class ScaleGeneratorTest(unittest.TestCase): self.assertEqual(expected, actual) def test_enigmatic(self): - enigmatic = Scale('G', 'enigmatic', 'mAMMMmM') + enigmatic = Scale('G', 'enigmatic', 'mAMMMmm') expected = ['G', 'G#', 'B', 'C#', 'D#', 'F', 'F#'] actual = enigmatic.pitches self.assertEqual(e...
[flake8] Ignore B028 bugbear checks The bugbear B028 is wrong if the variable is not a string, see
@@ -109,6 +109,7 @@ deps = [flake8] # The following are intentionally ignored, possibly pending consensus +# B028: False positive, see https://github.com/PyCQA/flake8-bugbear/issues/329 # D105: Missing docstring in magic method # D211: No blank lines allowed before class docstring # FI1: __future__ import "x" missing @...
[skip ci][ci] Mark more ethosu tests with xfail See for context. Since more parameterizations are popping up as failed, this disables whole tests rather than specific combinations of parameters.
@@ -347,9 +347,7 @@ def test_ethosu_binary_elementwise( ([1, 4, 4], [4, 1]), ], ) -@tvm.testing.xfail_parameterizations( - "ifm_shape0-ifm2_shape0-ethos-u55-64", reason="See https://github.com/apache/tvm/issues/12511" -) +@pytest.mark.xfail(reason="See https://github.com/apache/tvm/issues/12511") def test_binary_add_wi...
make scheduled reports return 400 not 500 when encountering a report the user may not edit
@@ -189,6 +189,7 @@ from corehq.apps.hqwebapp.decorators import ( ) import six from six.moves import range +from no_exceptions.exceptions import Http400 # Number of columns in case property history popup @@ -994,7 +995,7 @@ class ScheduledReportsView(BaseProjectReportSectionView): instance.day = calculate_day(instance....
Fix build_ext interaction with non numpy extensions Numpy extensions define the extra_cxx_compile_args and extra_c_compile_args filed, but distutils extensions don't. Take that into account when populating build_extension. Should fix
@@ -393,8 +393,8 @@ def build_extension(self, ext): log.info("building '%s' extension", ext.name) extra_args = ext.extra_compile_args or [] - extra_cflags = ext.extra_c_compile_args or [] - extra_cxxflags = ext.extra_cxx_compile_args or [] + extra_cflags = getattr(ext, 'extra_c_compile_args', None) or [] + extra_cxxfla...
model: transformers: Set version range to >=2.5.1,<2.9.0 Temporaray fix for issue with new TensorFlow release Related:
@@ -24,7 +24,7 @@ INSTALL_REQUIRES = [ "numpy>=1.16.4", "seqeval>=0.0.12", "fastprogress>=0.2.2", - "transformers>=2.5.1", + "transformers>=2.5.1,<2.9.0", ] + ( ["dffml>=0.3.7"] if not any(
Update training.rst Fixed broken link
@@ -545,7 +545,7 @@ To advanced the skills of senior and functional leaders we bring in experts to a - As an example, `Jono Bacon <http://www.jonobacon.org/about/>`_--a leading author, speaker and consultant on open source community advocacy--meets with our community team regularly to refine our processes and understan...
change: [cli] utilize metavar instead of actual choices utilize metavar instead of candidate values to shorten help text.
@@ -157,13 +157,14 @@ def make_parser(defaults=None): gspog.add_argument("--set", help=_SET_HELP) parser.add_argument("-o", "--output", help="Output file path") - parser.add_argument("-I", "--itype", choices=ctypes, + parser.add_argument("-I", "--itype", choices=ctypes, metavar="ITYPE", help=(type_help % "Input")) - pa...
fix: mport module from line N shadowed by loop variable Flake8 F402 reported by sider
@@ -181,11 +181,11 @@ class Query: warn("'filters_config' hook is not completely implemented yet in frappe.db.query engine") - for operator, function in additional_filters_config.items(): + for _operator, function in additional_filters_config.items(): if callable(function): - all_operators.update({operator.casefold(): ...