owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 734,734,102 | 2,677 | posva | The attribute should be removed with nullish values. This would also make it consistent with Vue 2 | 2020-11-27T09:20:55 | 2020-11-27T09:20:55 | {} | MEMBER |
vuejs | core | 735,405,716 | 2,686 | Alanscut | this is duplicated with #2652 , and fixed by #2648 | 2020-11-29T14:46:17 | 2020-11-29T14:46:17 | {} | CONTRIBUTOR |
vuejs | core | 731,193,946 | 2,649 | ludofischer | Notice that currently [postcss-modules](https://github.com/css-modules/postcss-modules) still depends on PostCSS 7, so with this change installing the Vue compiler will install PostCSS 8 AND 7, unless postcss-modules is ported first. | 2020-11-20T14:13:33 | 2020-11-20T14:13:33 | {
"+1": 3
} | NONE |
vuejs | core | 731,587,107 | 2,648 | yassilah | @posva what do you mean? i think this should work both if the target has an SVG tag or if the destination is an SVG element, or did i misunderstand how the `Teleport.process` method works? | 2020-11-21T14:29:47 | 2020-11-21T14:29:47 | {} | CONTRIBUTOR |
vuejs | core | 731,779,145 | 2,655 | JensDll | Yes, this would not work in a version smaller 4.0. In previous versions, there is nothing similar that I know of at least. However, there are [discussions like this one](https://github.com/microsoft/TypeScript/issues/30680) that make me believe, that there is not really a straightforward solution. I guess this can be k... | 2020-11-22T17:13:11 | 2020-11-22T17:13:11 | {} | CONTRIBUTOR |
vuejs | core | 734,322,959 | 1,600 | martinbean | 
Could we get a response? People have been asking about this for literally _months_ now… | 2020-11-26T14:17:56 | 2020-11-26T14:17:56 | {
"confused": 3,
"laugh": 4
} | NONE |
vuejs | core | 734,324,645 | 1,600 | nfplee | @martinbean same. I ended up applying this pull request to my local build just so I could continue to use Vue 3. | 2020-11-26T14:21:07 | 2020-11-26T14:21:07 | {} | NONE |
vuejs | core | 734,823,344 | 2,675 | ChanningHan | > VueDX requires `defineComponent()` for prop type checking.
I have used defineComponent() in my local project now, but it still don't work. | 2020-11-27T12:57:58 | 2020-11-27T12:57:58 | {} | NONE |
vuejs | core | 735,300,797 | 2,685 | posva | Please read the warning in the console, it explains why this doesn't work. | 2020-11-28T22:51:02 | 2020-11-28T22:51:02 | {} | MEMBER |
vuejs | core | 735,434,158 | 803 | aztalbot | It's not a bug. I believe the decision to only unwrap refs at the root level of the returned object from `setup()` was made and implemented [here](https://github.com/vuejs/vue-next/pull/1682). The docs could probably be more clear and specific about this, though, particularly since the behavior changed multiple times d... | 2020-11-29T18:17:20 | 2020-11-29T18:17:20 | {} | CONTRIBUTOR |
vuejs | core | 731,093,555 | 2,649 | edison1105 | > > I'm not sure whether to do this.
>
> I'm not sure if it makes sense adding it to both 🤔
The purpose of the two dependencies is different. In theory it is needed. | 2020-11-20T10:45:13 | 2020-11-20T10:45:13 | {} | MEMBER |
vuejs | core | 730,806,486 | 2,642 | emfax | +1 for this. | 2020-11-20T02:33:07 | 2020-11-20T17:42:19 | {} | NONE |
vuejs | core | 731,484,865 | 2,621 | edison1105 | > Can you add a test?
Done. | 2020-11-21T01:30:19 | 2020-11-21T01:30:19 | {} | MEMBER |
vuejs | core | 731,571,567 | 2,648 | posva | One thing to note is that this only work if the target is an `svg` but not if the target is inside the SVG | 2020-11-21T12:20:13 | 2020-11-21T12:20:13 | {} | MEMBER |
vuejs | core | 734,205,645 | 2,649 | songololo | For those waiting for official v8 support for the purpose of `tailwindcss`, an FYI that v2 of tailwind currently has a bridging compatibility version per `tailwindcss@compat`, useful until above issues are resolved... | 2020-11-26T10:11:27 | 2020-11-26T14:51:18 | {} | NONE |
vuejs | core | 735,030,772 | 2,683 | Justineo | Issue 仅接受 bug 报告与新特性请求，不负责解决用法的问题，有疑问请前往[论坛](https://forum.vuejs.org/)、[StackOverflow](https://stackoverflow.com/questions/tagged/vue.js) 或者 [Discord 聊天室](https://chat.vuejs.org/) 请求帮助，谢谢。 | 2020-11-28T02:43:05 | 2020-11-28T02:43:05 | {} | MEMBER |
vuejs | core | 731,089,480 | 2,649 | edison1105 | > @edison1105 It seems like moving to peerDependencies does not work properly. I'll move it back to devDependencies later while keeping the `module.exports.postcss = true`
both in `peerDependencies` and `devDependencies`.
```javascript
"peerDependencies": {
...
"postcss": "^8.1.8"
},
```
```ja... | 2020-11-20T10:36:33 | 2020-11-20T10:37:40 | {} | MEMBER |
vuejs | core | 731,894,476 | 2,657 | aztalbot | I believe this is intended, based on the [docs](https://v3.vuejs.org/guide/composition-api-setup.html#context).
From the docs:
> The context object is a normal JavaScript object, i.e., it is not reactive [...] [a]lso note that unlike props, attrs and slots are not reactive | 2020-11-23T02:18:09 | 2020-11-23T02:18:09 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 732,706,144 | 2,666 | Justineo | As @edison1105 said. | 2020-11-24T07:20:06 | 2020-11-24T07:20:06 | {} | MEMBER |
vuejs | core | 732,791,017 | 2,448 | Shouhua | Sorry for this closed issue, I think the problem still exists.
`yarn build reactivity -f cjs,esm-bundler` will execute `build.js` file, and create rollup environment dynamically, for example, `rollup -c --environment TARGET:reactivity,EVNIRONMENT:cjs,esm-bundle`, so far so good, next rollup resolved the environment sp... | 2020-11-24T10:02:31 | 2020-11-24T10:02:31 | {} | NONE |
vuejs | core | 734,750,333 | 2,675 | ChanningHan | 
It seems like missing the type-checking of props？ | 2020-11-27T09:56:48 | 2020-11-27T09:56:48 | {} | NONE |
vuejs | core | 735,410,297 | 2,686 | lchrennew | > this is duplicated with #2652 , and fixed by #2648
No, they are not same! In my case, the target is not SVG. Re-check this, please. | 2020-11-29T15:20:32 | 2020-11-29T15:20:32 | {} | NONE |
vuejs | core | 735,410,901 | 2,686 | lchrennew | @Alanscut @posva Please recheck.
| 2020-11-29T15:24:57 | 2020-11-29T15:24:57 | {} | NONE |
vuejs | core | 735,492,673 | 2,687 | edison1105 | 8e2037537219219d5ab6456e8a29bd0235eac311
breaking change in this commit. | 2020-11-30T01:10:06 | 2020-11-30T01:10:06 | {
"+1": 1
} | MEMBER |
vuejs | core | 731,958,723 | 2,555 | dependabot-preview[bot] | Superseded by #2660. | 2020-11-23T06:38:08 | 2020-11-23T06:38:08 | {} | CONTRIBUTOR |
vuejs | core | 732,736,959 | 2,661 | lchrennew | OK, let's discuss this in an RFC, thanks @posva . | 2020-11-24T08:25:07 | 2020-11-24T08:25:07 | {} | NONE |
vuejs | core | 734,705,265 | 1,553 | caohuatao | ```typescript
interface IntrinsicAttributes extends ReservedProps {
[emit: string]: any
}
``` | 2020-11-27T08:13:50 | 2020-11-27T08:13:50 | {} | NONE |
vuejs | core | 734,751,121 | 2,676 | HcySunYang | yeah added | 2020-11-27T09:58:38 | 2020-11-27T09:58:38 | {} | MEMBER |
vuejs | core | 734,868,669 | 2,675 | ChanningHan | Thanks🙏🏻I will do it later.
Btw, I love everything of Vue soooo much🤩So, fighting 😄😄😄 | 2020-11-27T14:45:35 | 2020-11-27T14:45:35 | {} | NONE |
vuejs | core | 735,230,391 | 2,675 | LinusBorg | Closing as it's not related directly to core. | 2020-11-28T13:20:05 | 2020-11-28T13:20:05 | {} | MEMBER |
vuejs | core | 733,924,405 | 2,064 | kris-ellery | @lukef have you ever figured it out? @skyweaver213 the `globals: { vue: 'Vue' }` does not work for ESM output.
I have the same issue, a UI library with multiple parent/child components. when I install it directly from NPM, everything works, but when working with `npm link`, or even relative path, it throws `resolve... | 2020-11-25T20:10:54 | 2020-11-29T21:27:23 | {
"+1": 1
} | NONE |
vuejs | core | 731,094,450 | 2,649 | lstoeferle | Okay thanks for the hint 👍 I'll add it quickly to peerDependencies again. Actually it's not devDependencies 🤦 Sorry for confusion 🙃 | 2020-11-20T10:46:49 | 2020-11-20T10:50:55 | {} | NONE |
vuejs | core | 731,368,711 | 2,645 | LinusBorg | A normal for loop is faster than forEach.
So I don't think this change is beneficial, it would degrade performance in a performance-sensitive spot. | 2020-11-20T19:37:20 | 2020-11-20T19:37:20 | {} | MEMBER |
vuejs | core | 732,241,320 | 2,540 | jw-foss | Check this out. [Codesandbox](https://codesandbox.io/s/cranky-goodall-rqr1g?file=/src/App.vue), I have attached a link to a reproducible demo indicates the breaking change of event names had impact on my project.
Steps to reproduce.
First of all open the console tab on codesandbox.
1. Adjust the dependency versio... | 2020-11-23T15:42:34 | 2020-11-23T15:42:34 | {} | NONE |
vuejs | core | 732,681,082 | 2,664 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.39 KB (0%) |
| runtime-dom.global.prod.js | 26.5 KB (0%) |
| size-check.global.prod.js | 16.08 KB (0%) | | 2020-11-24T06:24:22 | 2020-11-24T06:24:22 | {} | NONE |
vuejs | core | 732,886,315 | 2,667 | posva | See https://github.com/vuejs/vue-next/issues/1989
You still need to pass the correct attributes and event listeners based on your inner component that receives the v-model. In your case, add a prop `modelValue`, bind it with `:value="modelValue"` and add the emit `@change="$emit('modelValue:update', $event.target.va... | 2020-11-24T11:41:44 | 2020-11-24T11:41:44 | {} | MEMBER |
vuejs | core | 734,122,406 | 2,673 | antfu | They are [`@vue/compiler-*`](https://github.com/vuejs/vue-next/tree/master/packages) for Vue 3. | 2020-11-26T07:20:27 | 2020-11-26T07:20:27 | {} | MEMBER |
vuejs | core | 734,340,290 | 2,642 | songololo | For those waiting for official v8 support for the purpose of `tailwindcss`, an FYI that v2 of tailwind currently has a bridging compatibility version per `tailwindcss@compat`, useful until above issues are resolved...
| 2020-11-26T14:51:34 | 2020-11-26T14:51:53 | {
"rocket": 5
} | NONE |
vuejs | core | 734,434,188 | 2,669 | 07akioni | Not only fragment-rooted component has no `data-v`, but also teleport-rooted component doesn't.
https://codesandbox.io/s/laughing-gagarin-4mlln?file=/src/components/CompB.vue
Since Teleport & Fragment can be nested for many levels. I think there should be a traversal to make sure the real outer-most html element... | 2020-11-26T18:21:24 | 2020-11-26T18:24:58 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 476,582,107 | 24 | posva | One thing we left behind is 2.x support. If `@vue/observer` uses proxies, it won't be compatible with Vue 2, would it? | 2019-03-26T11:17:42 | 2019-03-26T11:17:42 | {} | MEMBER |
vuejs | core | 499,492,122 | 35 | yyx990803 | > @shentao Vue.observable – do we want to use the name observable? As it was already pointed out somewhere else, it might be misleading as it is in 2.6 and might not be a good idea to keep it.
Yes, this should be one of the unresolved questions. I was thinking between `state` and `value.raw`.
- Technically `state... | 2019-06-06T13:24:27 | 2019-06-06T13:24:27 | {} | MEMBER |
vuejs | core | 499,495,956 | 35 | shentao | > With component options, your code only seem to be organized - in a complex component, logic related to a specific task is often split up between multiple options. Separation of options vs. setup() is like sticking to the separation of HTML/CSS/JS vs. Single File Components. If you put all the logic of your app in a s... | 2019-06-06T13:34:42 | 2019-06-06T13:34:42 | {} | MEMBER |
vuejs | core | 505,366,255 | 37 | yyx990803 | Well, now that we are (for now) no longer doing the lean build, I think we can close this 😅
The lean build can probably be a compile-time flag (e.g. `process.env.LEAN_MODE`) preserved in the `esm-bundler` build. | 2019-06-25T09:32:44 | 2019-06-25T09:32:44 | {} | MEMBER |
vuejs | core | 527,588,305 | 44 | dependabot-preview[bot] | OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`.
If you change your mind, just re-... | 2019-09-03T18:46:32 | 2019-09-03T18:46:32 | {} | CONTRIBUTOR |
vuejs | core | 480,740,596 | 26 | yyx990803 | Published: https://github.com/vuejs/rfcs/pull/25 | 2019-04-08T08:42:41 | 2019-04-08T08:42:41 | {} | MEMBER |
vuejs | core | 481,080,629 | 30 | yyx990803 | Published: https://github.com/vuejs/rfcs/blob/global-api-change/active-rfcs/0000-global-api-change.md
@LinusBorg I think a middle ground (as included in the public RFC) is to provide stubs that emit warnings for these moved methods. For example if a plugin calls `Vue.use()`, it will be a noop and emit a warning that... | 2019-04-09T02:48:00 | 2019-04-09T02:48:00 | {} | MEMBER |
vuejs | core | 481,669,399 | 33 | posva | > making the first argument Element | Array<Element> is still a breaking change, in fact it requires heavier refactoring to make sure existing directives work properly
True, but it isn't much for existing directives to just extract the first element and throw if there are more (thinking of a possible codemod)
```... | 2019-04-10T12:27:06 | 2019-04-10T12:27:06 | {} | MEMBER |
vuejs | core | 515,147,358 | 41 | LinusBorg | I waited a bit before commenting because I wanted to let it sink in a bit.
Right now I'm pretty much in Evan's boat.
The killer for me is that we simply *can not, in any way* touch the 2.x API for now. People will lose their shit otherwise. And introducing a 3rd way of doing things would be equally bad.
So whi... | 2019-07-25T17:53:27 | 2019-07-25T17:53:27 | {
"+1": 4
} | MEMBER |
vuejs | core | 481,940,905 | 33 | yyx990803 | @posva I just realized in v3 directives are in fact implemented as special VNode data hooks - that is to say in render functions you can do this:
``` js
h('div', {
vnodeMounted() { ... },
vnodeUpdated() { ... }
})
```
And for template `<div v-foo/>`, it will take the `mounted` hook of `v-foo` and merge ... | 2019-04-11T02:28:53 | 2019-04-11T02:38:53 | {
"+1": 3
} | MEMBER |
vuejs | core | 499,451,174 | 35 | posva | Thinking about vue router navigation guards. Since properties returned in `setup` are not accessible through `this`, we will need to provide a function-based api as well for in-component guards like `onBeforeRouteEnter`, `onBeforeRouteUpdate` and `onBeforeRouteLeave` but at the same time, it's impossible from the route... | 2019-06-06T11:08:56 | 2019-06-06T11:08:56 | {} | MEMBER |
vuejs | core | 499,453,270 | 35 | nekosaur | I am also worried that having everything defined in `setup` might very well lead to spaghetti code for developers who are unfamiliar with any best practices for using this new API.
With regard to being able to mutate unwrapped values in template, as shown:
```js
const MyComponent = {
setup() {
return {
... | 2019-06-06T11:16:35 | 2019-06-06T11:16:35 | {} | CONTRIBUTOR |
vuejs | core | 504,007,841 | 38 | yyx990803 | Good question - I haven't included compilation examples yet, but with the new strategy, `v-if` branches will have auto-generated different keys so they will always replace each other. (This also fixes a number of edge cases due to node reuse between `v-if` branches) | 2019-06-20T12:33:07 | 2019-06-20T12:33:07 | {} | MEMBER |
vuejs | core | 476,580,410 | 24 | yyx990803 | Published: https://github.com/vuejs/rfcs/pull/22 | 2019-03-26T11:12:01 | 2019-03-26T11:12:01 | {} | MEMBER |
vuejs | core | 480,385,200 | 30 | Jinjiang | And currently `Vue.extend({})` seems able to solve the same problem as an app instance does. As I remember it works well in an earlier version of Weex. So I think the current design is also fine if we want to keep auto-installation supported. | 2019-04-05T18:53:04 | 2019-04-05T18:53:04 | {} | MEMBER |
vuejs | core | 480,710,410 | 30 | LinusBorg | Couldn't we try and find some middle ground for 3.0 and just deprecate it and then drop this in 4.0?
Maybe something like this:
1. `Vue.use()` adds plugins it recieves to some cache
2. A deprecation warning is logged during development.
3. When running `createApp()`, these plugins are applied to the app instan... | 2019-04-08T07:07:25 | 2019-04-08T07:08:49 | {} | MEMBER |
vuejs | core | 499,517,820 | 35 | LinusBorg | > * **Compatibility build**: supports both the new function-based APIs AND all the 2.x options.
Does that mean that it's possible to mix the two?
```
export default {
setup() {
return {
count: value(0)
}
},
computed: {
plusOne() {
return this.count + 1
}
}
}
```
Not... | 2019-06-06T14:27:28 | 2019-06-06T14:27:28 | {} | MEMBER |
vuejs | core | 505,366,859 | 21 | yyx990803 | Closing this since we are no longer touching 2.x options, and `Vue.observable` renaming should now be part of the function-based API discussion. | 2019-06-25T09:34:29 | 2019-06-25T09:34:29 | {} | MEMBER |
vuejs | core | 514,667,260 | 41 | chrisvfritz | > I feel like advanced users will prefer having the variables without the $ because it's unnecessary prefixing.
@posva The more I think about it, the more I think the `$` prefix is good even for advanced users, because it not only provides consistency, but also important information that this API is from the framewo... | 2019-07-24T14:55:42 | 2019-07-24T14:57:27 | {} | CONTRIBUTOR |
vuejs | core | 515,227,256 | 41 | Akryum | @chrisvfritz Maybe we can postpone this plan for Vue 4? 😅 | 2019-07-25T21:47:46 | 2019-07-25T21:47:46 | {} | MEMBER |
vuejs | core | 476,145,206 | 24 | yyx990803 | @posva ah that's right. I guess we do need an option for it then. | 2019-03-25T10:53:13 | 2019-03-25T10:53:13 | {} | MEMBER |
vuejs | core | 476,585,015 | 24 | LinusBorg | Don't think so. `state` and `value` could just as well return objects that have Vue2 style getters and setters. People would just have to import a different build. | 2019-03-26T11:27:15 | 2019-03-26T11:27:53 | {} | MEMBER |
vuejs | core | 481,146,522 | 12 | yyx990803 | Closing in favor of the newer RFCs (https://github.com/vuejs/rfcs/pull/22, https://github.com/vuejs/rfcs/pull/23) | 2019-04-09T08:03:31 | 2019-04-09T08:03:31 | {} | MEMBER |
vuejs | core | 481,498,646 | 32 | yyx990803 | Published: https://github.com/vuejs/rfcs/pull/31 | 2019-04-10T01:30:33 | 2019-04-10T01:30:33 | {} | MEMBER |
vuejs | core | 514,406,341 | 41 | johnleider | Absolute fan of this. | 2019-07-23T22:25:42 | 2019-07-23T22:25:42 | {} | NONE |
vuejs | core | 478,509,593 | 31 | LinusBorg | I see. I'm a little suprised (positively!) that this behaviour can in fact be polyfilled, good to know.
So we would require some polyfills for the compatibility build, for Set, Map, WeakMap etc. Seems fair in order to drag ppl into the future :-P.
| 2019-04-01T09:40:39 | 2019-04-01T09:40:39 | {} | MEMBER |
vuejs | core | 480,741,889 | 28 | yyx990803 | Published: https://github.com/vuejs/rfcs/pull/27 | 2019-04-08T08:46:28 | 2019-04-08T08:46:28 | {} | MEMBER |
vuejs | core | 481,147,002 | 8 | yyx990803 | Closing in favor of the public RFC. | 2019-04-09T08:04:58 | 2019-04-09T08:04:58 | {} | MEMBER |
vuejs | core | 481,675,921 | 33 | LinusBorg | Just thinking out loud: Would this be achievable? And if so, would it make any sense? Would make the implementation treeshakable, right?
```javascript
import {
beforeMount,
mounted,
beforeUpdate,
update,
beforeUnmount,
unmounted,
} from 'vue/directives'
export default () => {
mounted((el, bin... | 2019-04-10T12:46:53 | 2019-04-10T12:46:53 | {} | MEMBER |
vuejs | core | 529,449,829 | 53 | znck | Duplicate of #52 | 2019-09-09T12:29:26 | 2019-09-09T12:29:26 | {} | MEMBER |
vuejs | core | 478,506,868 | 31 | Justineo | `core-js` has a built-in `WeakMap` polyfill: https://github.com/zloirock/core-js/blob/master/packages/core-js/modules/es.weak-map.js | 2019-04-01T09:32:11 | 2019-04-01T09:32:11 | {} | MEMBER |
vuejs | core | 480,461,181 | 30 | yyx990803 | @Jinjiang yes, this is a breaking change and it will break auto installation. If we still allow implicit global installation it would make this change pointless. | 2019-04-06T01:01:01 | 2019-04-06T01:01:01 | {} | MEMBER |
vuejs | core | 480,740,436 | 27 | yyx990803 | Published: https://github.com/vuejs/rfcs/pull/26 | 2019-04-08T08:42:12 | 2019-04-08T08:42:12 | {} | MEMBER |
vuejs | core | 499,427,351 | 35 | shentao | 😍
`Vue.observable` – do we want to use the name `observable`? As it was already pointed out somewhere else, it might be misleading as it is in 2.6 and might not be a good idea to keep it.
> All current lifecycle hooks will have an equivalent useXXX function that can be used inside setup():
`onXXX` typo
>... | 2019-06-06T09:48:18 | 2019-06-06T09:48:36 | {} | MEMBER |
vuejs | core | 514,523,604 | 41 | posva | I think the reasoning behind create naming is smart and I like it.
Prepending `on` is fine as long as we provide code transform and provide tools to use them (online, cli) and encourage its use so they appear high in search results.
`create` as an object for `new Vue` seems reasonable too
> Avoids a significan... | 2019-07-24T07:57:37 | 2019-07-24T07:57:37 | {} | MEMBER |
vuejs | core | 514,639,462 | 41 | posva | > I don't think we can rely on tooling alone to solve any problems.
Absolutely. The idea just crossed my mind and I thought I would share
> Either way, it's a documentation problem: we help users understand that this === context, or we can help them understand function bindings. I think teaching this === context ... | 2019-07-24T13:47:36 | 2019-07-24T13:47:36 | {} | MEMBER |
vuejs | core | 514,702,497 | 41 | shentao | 1) I like the change. `create` just makes a bit more sense, especially in the context of lifecycle hooks that help position it in the timeline.
2) Same here. Should help keep things cleaner.
3) I have very mixed feelings about this. Especially in examples like this:
```js
const state = {
count: props.initialCoun... | 2019-07-24T16:23:03 | 2019-07-24T16:23:03 | {
"+1": 1
} | MEMBER |
vuejs | core | 476,114,636 | 27 | posva | I also prefer explicit. I think the implicit behaviour here is something a lot of users like, so I want to be able to explain correctly.
> v-on:click is compiled to onClick
I meant that if `$attrs` contains `onListeners`, if you do `<div v-bind="$attrs"/>`, we are binding a dom property `onClick` (which doesn't e... | 2019-03-25T09:22:20 | 2019-03-25T09:22:20 | {} | MEMBER |
vuejs | core | 476,168,693 | 29 | LinusBorg | Concerning Event liisteners:
* we use the `on*` prefix to differentiate between events and props/attributes, but
* all of them will end up in $attrs so we can do `v-bind="$attrs"`
So what does that mean for events in templates on their own? Will all of these work?
```html
<button v-on:click="handleClick">
... | 2019-03-25T12:08:48 | 2019-03-25T12:08:48 | {} | MEMBER |
vuejs | core | 480,488,845 | 30 | LinusBorg | Hm.
Would the Plugin API (install function receiving the/a Vue constructor) be the same though?
I don't want to break *every plugin in the whole ecosystem* :( | 2019-04-06T09:17:28 | 2019-04-06T09:17:28 | {} | MEMBER |
vuejs | core | 514,427,331 | 41 | chrisvfritz | @gustojs The two core concerns I've seen about the new API are:
- it's too complex and especially won't be friendly to beginners
- it will cause a schism
So I think as long as we address both of those concerns, people will be happy in the long run.
But either way, I think some people will be upset in the shor... | 2019-07-24T00:04:48 | 2019-07-24T00:17:49 | {
"+1": 3
} | CONTRIBUTOR |
vuejs | core | 514,476,589 | 41 | NataliaTepluhina | Thank you, Chris, I think it's a brilliant proposal. I really like all renaming ideas, it seems very logical to me.
While I can understand @gustojs concerns about point 3), I think it's a typical 'lesser evil' choice. Obviously, there _will be_ users complaining about the change but in fact, part of the user base _w... | 2019-07-24T04:39:32 | 2019-07-24T04:39:32 | {} | MEMBER |
vuejs | core | 514,658,854 | 41 | posva | I think it's because we want to avoid the common pitfall of
```js
create() {
function onClick() {
this // not the `this` you'd expect!
}
}
```
(taken from https://github.com/vuejs/rfcs/blob/function-apis/active-rfcs/0000-function-api.md#the-setup-function) | 2019-07-24T14:35:44 | 2019-07-24T14:37:27 | {
"+1": 1
} | MEMBER |
vuejs | core | 516,601,165 | 41 | chrisvfritz | @shentao
> I feel like putting computed (derived state) and methods (not state at all) into the same object makes it a bit confusing to be honest.
I got that feedback in some very brief user testing too. I'm very open to a different name for this variable, like `scope`, `self`, etc.
> I do feel like this woul... | 2019-07-30T21:23:03 | 2019-07-30T21:26:41 | {} | CONTRIBUTOR |
vuejs | core | 476,174,480 | 29 | yyx990803 | `v-bind:onClick` does work, but is not recommended. I think it's ok since most users would just `@click` shorthand. | 2019-03-25T12:27:34 | 2019-03-25T12:27:34 | {} | MEMBER |
vuejs | core | 478,502,494 | 31 | LinusBorg | As a sidenote, I realized that we also use WeakMaps in a couple of places outside of the `observer` package.
Since WeakMap can't be properly polyfilled(?), should we choose a different implementation or am I missing something` | 2019-04-01T09:20:03 | 2019-04-01T09:20:03 | {} | MEMBER |
vuejs | core | 496,051,876 | 3 | yyx990803 | Closing since we are dropping the Class API. | 2019-05-27T01:47:52 | 2019-05-27T01:47:52 | {} | MEMBER |
vuejs | core | 503,613,491 | 37 | yyx990803 | I was thinking about dropping the runtime vs. full build dimension and distributing the compiler in a separate package altogether. So the `vue` package would be only the runtime. This allows us to drop a dimension but you'd have to do something like this to get on-the-fly compilation:
``` html
<script src="https://... | 2019-06-19T15:36:17 | 2019-06-19T15:37:46 | {
"+1": 2
} | MEMBER |
vuejs | core | 514,747,379 | 41 | yyx990803 | First, some context - Chris and I have discussed part of this proposal in a call previously and I am not really a fan of this for the following reasons:
1. **Renaming is not cost-free.**
It's not just about a codemod that upgrades existing code.
- It makes almost all existing educational content "out o... | 2019-07-24T18:29:59 | 2019-07-24T18:29:59 | {
"+1": 15
} | MEMBER |
vuejs | core | 515,782,725 | 41 | sdras | I'm late to this party, I know, but I'm pretty relieved to see @yyx990803 's response. I quite like 1 and 2, though, if it's overly difficult to change, probably not necessary.
**I'd be pretty concerned about 3, re:data, computed and watchers.** I've seen a few people talk about "beginners" in this thread, but it's ... | 2019-07-28T18:03:36 | 2019-07-28T18:03:36 | {
"+1": 2
} | MEMBER |
vuejs | core | 476,138,432 | 24 | posva | How would you write that?
If we do
```js
watch(() => obj.a, value => {
nextTick(() => {
console.log(`obj.a is: ${value}`)
})
})
```
and then `obj.a = 4; obj.a = 3`, wouldn't that console.log 4 and 3? | 2019-03-25T10:34:26 | 2019-03-25T10:34:26 | {} | MEMBER |
vuejs | core | 480,700,888 | 31 | yyx990803 | @LinusBorg we will fallback to actually defining everything on the instance, but only when we detect the runtime doesn't support native Proxies. That logic will live in `runtime-core` and be included/excluded via a build time flag. | 2019-04-08T06:29:43 | 2019-04-08T06:29:43 | {
"+1": 1
} | MEMBER |
vuejs | core | 481,494,949 | 32 | yyx990803 | @posva
> Regarding the default value modelValue, is there a reason not to keep the default prop to value?
Because the idea is to move element/input type specific handling to the runtime, so the `v-model` output must be something special for the runtime to pick up and transform. If we use the default `value` and ... | 2019-04-10T01:09:18 | 2019-04-10T01:09:18 | {} | MEMBER |
vuejs | core | 499,436,745 | 35 | Akryum | > Where should we $emit events?
I agree this is quite unclear in the current RFC. Maybe something like this:
```js
import { emit } from 'vue'
export function myComposition () {
emit('change', 42)
}
``` | 2019-06-06T10:17:30 | 2019-06-06T10:17:30 | {} | MEMBER |
vuejs | core | 499,454,765 | 35 | shentao | What also worries me that this will most likely break plugins like Vuelidate, that rely on component options and `this` context. I imagine it could be rewritten to become a composition function
```
const validatedState = vuelidate(state, validationSchema)
```
I like the idea personally, but I fear this will make t... | 2019-06-06T11:22:08 | 2019-06-06T11:22:08 | {} | MEMBER |
vuejs | core | 499,788,620 | 35 | yyx990803 | > @LinusBorg Does that mean that it's possible to mix the two?
Yes. There might be some edge cases (I haven't fully implemented 2.x compat support yet) but theoretically it should work. | 2019-06-07T07:37:00 | 2019-06-07T07:37:36 | {} | MEMBER |
vuejs | core | 514,423,762 | 41 | gustojs | What I like about 3) is that it offers a good middle step for those who want to rewrite their components from Object API to Composition API.
I also like 1) a lot. | 2019-07-23T23:47:08 | 2019-07-23T23:49:34 | {} | MEMBER |
vuejs | core | 514,654,381 | 41 | posva | It's clear now!
There is something that doesn't feel completely right to me, not completely sure of what it is though.
I feel like advanced users will prefer having the variables without the `$` because it's unnecessary prefixing.
Is it that much of a big deal to have the `$` in front when accessing through `this`... | 2019-07-24T14:24:52 | 2019-07-24T14:24:52 | {} | MEMBER |
vuejs | core | 514,672,116 | 41 | posva | > but also important information that this API is from the framework (or a plugin), rather than defined by the user themselves
But if the user cannot inject anything into the parameter, they already know it comes from the API
---
I do think it's the best option we got yet as well | 2019-07-24T15:07:17 | 2019-07-24T15:07:17 | {} | MEMBER |
vuejs | core | 476,597,918 | 24 | posva | would still dependency tracking work? | 2019-03-26T12:10:49 | 2019-03-26T12:10:49 | {} | MEMBER |
vuejs | core | 481,187,530 | 32 | posva | Regarding the `type="checkbox"`, I was thinking we could add some modifier to handle it (not sure about the naming) `.checkbox`, `.number`. That way it doesn't collide with props, although it looks less similar to regular inputs.
Regarding the default value `modelValue`, is there a reason not to keep the default pro... | 2019-04-09T10:03:19 | 2019-04-09T10:03:19 | {} | MEMBER |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.