owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 696,056,185 | 2,185 | unbyte | @ZhangJian-3ti you are right 😁 | 2020-09-21T11:28:05 | 2020-09-21T11:28:05 | {} | CONTRIBUTOR |
vuejs | core | 695,779,101 | 2,173 | 07akioni | <del>Reproduction 2 is not fixed by this PR.</del> | 2020-09-20T12:00:35 | 2020-09-22T06:31:46 | {} | CONTRIBUTOR |
vuejs | core | 695,370,287 | 2,145 | shrink | Hi @antfu! I'm working through an issue that has appeared when upgrading from a release candidate (8) to the release of Version 3.0.0. As far as I can tell, I've tracked down the issue to this PR: I'm using the `HelloWorld` component favoured in many of the VueJS examples:
```html
<template>
<div class="hello">
... | 2020-09-20T00:18:08 | 2020-09-20T00:23:34 | {} | NONE |
vuejs | core | 695,794,524 | 2,138 | yangmingshan | It's not about pushing itself, pushing will works as it should be, push a new item to an array will still trigger effect run no matter inside effect or not. It's about unexpected tracking.
```js
const arr = reactive([])
watchEffect(() => {
arr.push(1) // this effect will run whenever the length of arr changes... | 2020-09-20T14:37:07 | 2020-09-20T14:38:29 | {} | CONTRIBUTOR |
vuejs | core | 695,794,849 | 2,138 | CyberAP | Why else it would have to trigger then? The code itself is recursive: an effect that mutates its own dependency. It is recursive in Vue 2 and I don't see any reason why it shouldn't be that way in Vue 3. | 2020-09-20T14:40:31 | 2020-09-20T14:40:31 | {
"+1": 4
} | CONTRIBUTOR |
vuejs | core | 695,943,548 | 2,181 | posva | @muyangAisha do tests in your own repos or we will have to block you. | 2020-09-21T07:13:05 | 2020-09-21T07:13:05 | {} | MEMBER |
vuejs | core | 696,956,837 | 2,142 | yaadata | I think setting a timeout to encourage users is the better alternative because it gives more clarity about the code should behave | 2020-09-22T20:19:07 | 2020-09-22T20:19:07 | {} | NONE |
vuejs | core | 697,203,337 | 1,378 | LinusBorg | was fixed in rc.12 | 2020-09-23T08:03:21 | 2020-09-23T08:03:21 | {} | MEMBER |
vuejs | core | 697,303,469 | 2,192 | Jokcy | Ah, why don't you just say `type A = DefineComponent<typeof FiledPropsDefine, {}, {}>` will solve this problem... | 2020-09-23T11:28:56 | 2020-09-23T11:29:15 | {} | CONTRIBUTOR |
vuejs | core | 695,783,028 | 2,138 | yangmingshan | @CyberAP I don't think your issue is related to this PR.
For JSFiddle example, it looks like a bug, and it also existed in previous RC versions.
For watchEffect example, it is expected behavior, since you only accessed `value` field, so Vue will only track `value` field changes, you may want write like this:
`... | 2020-09-20T12:43:18 | 2020-09-20T12:43:18 | {} | CONTRIBUTOR |
vuejs | core | 695,783,158 | 2,138 | unbyte | @yangmingshan It's not a bug cuz these platforms rewrite `console.log` so `.length` is accessed inside | 2020-09-20T12:44:49 | 2020-09-20T12:44:58 | {} | CONTRIBUTOR |
vuejs | core | 696,230,965 | 2,193 | posva | I think there is a mistake in the docs (https://v3.vuejs.org/api/application-config.html#devtools) This property isn't used in the source code. We have a different env variable to be able to leave devtools in production | 2020-09-21T16:36:31 | 2020-09-21T16:36:31 | {} | MEMBER |
vuejs | core | 696,596,457 | 2,134 | underfin | https://github.com/vuejs/vue-next/issues/2134#issuecomment-695332849 caused by use `@compiler-core` dev bundler compiler template with production. https://github.com/vitejs/vite/pull/732 is already fixed this. | 2020-09-22T09:00:14 | 2020-09-22T09:00:53 | {} | MEMBER |
vuejs | core | 695,691,393 | 2,163 | unbyte | @glitchboyl do you mean https://codepen.io/unbyte/pen/JjXmxpG ? stoping an effect manually also triggers `onInvalidate` so just stop it in `onUnmounted` hook. | 2020-09-20T04:22:45 | 2020-09-20T04:22:45 | {} | CONTRIBUTOR |
vuejs | core | 695,785,188 | 2,138 | yangmingshan | @CyberAP For `ref` you can write like this:
```js
const arr = ref([])
watch(
arr,
() => {
console.log('Array: ', arr) // it will log after ref value changed or array changed.
},
{ deep: true }
)
``` | 2020-09-20T13:06:14 | 2020-09-20T13:09:52 | {} | CONTRIBUTOR |
vuejs | core | 695,785,896 | 2,138 | unbyte | @CyberAP could you please check again? if you try old version on online js runner such as codepen, they rewrite `console.log` so keys of array are depended internally.
that means it's not related to this PR but reactivity of vue 3 | 2020-09-20T13:13:47 | 2020-09-20T13:13:47 | {} | CONTRIBUTOR |
vuejs | core | 696,603,763 | 2,197 | akai007 | > Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.com/tags/vue.js).
>
> https://github.com/vuejs/rfcs/blob/sfc-improvemen... | 2020-09-22T09:15:16 | 2020-09-22T09:16:53 | {} | NONE |
vuejs | core | 697,100,114 | 2,208 | unbyte | is this feature about IDEs or editors ? | 2020-09-23T02:53:03 | 2020-09-23T02:53:03 | {} | CONTRIBUTOR |
vuejs | core | 695,218,493 | 2,171 | LinusBorg | This has nothing to do with it being a class property.
It is a result of using proxies for the reactivity. You change the original instance directly with that timer in screen.js, you don't do it through the proxy (this.classInstance).
Consequently, the change is not detected.
This *is* a general restriction wi... | 2020-09-19T14:14:15 | 2020-09-19T14:26:58 | {} | MEMBER |
vuejs | core | 695,332,849 | 2,134 | lovetingyuan | Excuse me, but I found the bug still occurs when built in production mode.
Run `yarn build` and use `dist` as http server root dir. The issue mentioned above is still there.
```bash
index.5a30f16e.js:1 TypeError: Failed to execute 'insertBefore' on 'Node': parameter 1 is not of type 'Node'.
at insert (index... | 2020-09-19T17:06:18 | 2020-09-19T17:06:18 | {} | NONE |
vuejs | core | 695,788,349 | 2,138 | unbyte | @CyberAP I've mistakenly thought you were testing the old version of vue 3 with platforms like codepen and latest version locally, so I said that. Anyway, what I mean is that it has nothing to do with this PR. Furthermore, I think this inconsistency is caused by the new reactivity system. | 2020-09-20T13:38:38 | 2020-09-20T13:38:38 | {} | CONTRIBUTOR |
vuejs | core | 695,789,929 | 2,145 | shrink | @pikax Thank you very much -- that was the issue! I'll check out Discord if I encounter any further issues.
@antfu Thank you for the prompt response, apologies for incorrectly identifying this PR as the source of the issue :) | 2020-09-20T13:53:55 | 2020-09-20T13:53:55 | {
"+1": 1
} | NONE |
vuejs | core | 695,932,073 | 2,180 | muyangAisha | test update 3.0, 2 | 2020-09-21T06:43:22 | 2020-09-21T06:43:22 | {} | NONE |
vuejs | core | 697,354,318 | 2,212 | Picknight | > I think @posva means the value.get(key) in the loop there was for trigger the customized getter.
@ZhangJian-3ti Why do we need to trigger customized `getter` in `forEach`? | 2020-09-23T13:10:56 | 2020-09-23T13:10:56 | {} | CONTRIBUTOR |
vuejs | core | 695,328,144 | 2,170 | amrnn90 | Here's a minimal reproduction:
https://codesandbox.io/s/vigorous-nash-8lxt8?file=/src/Child.vue
Click the increment button and open the console:
`this.$el` is null inside the `Child` component watcher. | 2020-09-19T16:24:38 | 2020-09-19T16:24:38 | {} | NONE |
vuejs | core | 695,346,597 | 1,802 | pearofducks | I [made a module](https://github.com/pearofducks/mount-vue-component) based on the discussion here for anyone who should find this in the future | 2020-09-19T19:18:06 | 2020-09-19T19:18:06 | {
"heart": 7,
"rocket": 3
} | NONE |
vuejs | core | 695,784,265 | 2,138 | unbyte | @CyberAP IMO it's expected cuz only `arr.value` doesn't declare any key of array as dep explicitly | 2020-09-20T12:56:02 | 2020-09-20T12:56:09 | {} | CONTRIBUTOR |
vuejs | core | 695,786,135 | 2,138 | CyberAP | > @CyberAP could you please check again? if you try old version on online js runner such as codepen, they rewrite `console.log` so keys of array are depended internally.
>
> that means it's not related to this PR but reactivity of vue 3
For the option breaking change I've made a separate issue: https://github.com... | 2020-09-20T13:16:12 | 2020-09-20T13:16:12 | {} | CONTRIBUTOR |
vuejs | core | 695,790,330 | 2,138 | edison1105 | > and also I've already tested this on versions from `beta` to `one piece`, and they all failed as I've alrady said
你俩都比较轴，不是提了新的PR了嘛，尤大肯定会处理的。耐心等待。哈哈😊 | 2020-09-20T13:58:35 | 2020-09-20T13:59:02 | {} | MEMBER |
vuejs | core | 696,489,802 | 2,097 | hzyhbk | I've meet same issue here when I try to upgrade my vue plugin libriary to vue3. It seems like there is no better way except **create a factory function** or **hoc**, but the usage is too complicate for a component library user.
Hope the vue team can porvide some other ways to slove this problem. | 2020-09-22T03:29:10 | 2020-09-22T03:29:10 | {} | NONE |
vuejs | core | 696,660,794 | 2,200 | LinusBorg | But then the question remains why do we need to choose `flush: post` here, while Vue 2 - as explained in the linked changelog issue - is `flush: pre` and it works as it is in Vue 2 whereas in Vue 3, we now have to choose flush post? It doesn't seem like an intentional behaviour to me.
And if this is indeed a new beh... | 2020-09-22T11:25:14 | 2020-09-22T11:27:21 | {
"+1": 1
} | MEMBER |
vuejs | core | 697,137,410 | 2,200 | skirtles-code | This looks like a re-occurrence of #1801.
If you explicitly set `flush: 'pre'` (so that the change in default value is not a factor) it works fine up until rc.11. It stopped working in rc.12. | 2020-09-23T05:09:55 | 2020-09-23T05:09:55 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 695,198,939 | 2,165 | LinusBorg | Please open an issue for discussing this in the docs-next repo. | 2020-09-19T10:57:50 | 2020-09-19T10:57:50 | {
"+1": 1
} | MEMBER |
vuejs | core | 695,784,525 | 2,138 | CyberAP | > For watchEffect example, it is expected behavior, since you only accessed value field, so Vue will only track value field changes, you may want write like this:
It is not the expected behaviour. When I am logging `array.value` I want this effect to be run every time the value of `array` changes. When I push into `... | 2020-09-20T12:59:11 | 2020-09-20T12:59:11 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 696,262,210 | 2,190 | dsonet | This decreased the code readability A LOT. | 2020-09-21T17:34:55 | 2020-09-21T17:34:55 | {} | CONTRIBUTOR |
vuejs | core | 696,264,860 | 2,194 | mya-ake | Oh... The test has failed.
I rethink. | 2020-09-21T17:39:54 | 2020-09-21T17:39:54 | {} | NONE |
vuejs | core | 696,655,474 | 2,200 | posva | This probably related to recent changes in the watch mechanism defaults. Using `flush: 'post'` fixes the problem:
```js
watch: {
setit: {
handler: 'tellParent',
flush: 'post'
}
},
```
It's [in the changelog](https://github.com/vuejs/vue-next/blob/master/CHANG... | 2020-09-22T11:13:09 | 2020-09-22T11:13:09 | {} | MEMBER |
vuejs | core | 697,027,473 | 2,170 | sixthgear | I can confirm a similar issue while trying to migrate a v2 codebase to v3. Inside of a component watcher I expect this.$el to be set, but it is null. | 2020-09-22T23:04:15 | 2020-09-22T23:04:15 | {} | NONE |
vuejs | core | 697,273,182 | 2,201 | posva | You need your studio_route component to have one single element at the root and to remove the `div` that wraps `component` in App.vue (https://github.com/vuejs/vue-next/issues/2143#issuecomment-694640896). Note Suspense is still experimental, its API and the way it's used to build apps is meant to adapt before we can d... | 2020-09-23T10:20:42 | 2020-09-23T10:20:42 | {} | MEMBER |
vuejs | core | 538,682,305 | 109 | yyx990803 | It's redundant but I kept it for human readability. Otherwise you'd have to do a manual lookbehind to make sure it's not a literal. | 2019-10-05T19:40:47 | 2019-10-05T19:40:47 | {} | MEMBER |
vuejs | core | 538,683,010 | 99 | himself65 | WIP, i need some time to sort out the complex typing relationship | 2019-10-05T19:51:18 | 2019-10-05T19:51:18 | {} | CONTRIBUTOR |
vuejs | core | 538,683,944 | 115 | kyle-hall | I found I could fake the Record here: https://github.com/vuejs/vue-next/blob/caa9297da6ce828e62a17b07303cd761632a5074/packages/compiler-core/src/transforms/transformElement.ts#L365
But, I still don't understand how to set up a Slot to return a VNodeChildren object. | 2019-10-05T20:04:28 | 2019-10-05T20:04:28 | {} | CONTRIBUTOR |
vuejs | core | 538,693,640 | 99 | znck | I suggest you convert this PR to a draft PR. | 2019-10-05T22:17:58 | 2019-10-05T22:17:58 | {} | MEMBER |
vuejs | core | 538,757,780 | 126 | vue-bot | Hey @pikax, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-06T15:27:34 | 2019-10-06T15:27:34 | {} | CONTRIBUTOR |
vuejs | core | 538,760,869 | 128 | vue-bot | Hey @CodeDaraW, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-06T16:00:24 | 2019-10-06T16:00:24 | {} | CONTRIBUTOR |
vuejs | core | 538,803,871 | 140 | vue-bot | Hey @alexander-zibert, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-07T00:23:48 | 2019-10-07T00:23:48 | {} | CONTRIBUTOR |
vuejs | core | 538,803,954 | 119 | vue-bot | Hey @kyle-hall, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-07T00:24:46 | 2019-10-07T00:24:46 | {
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 538,884,143 | 143 | vue-bot | Hey @dependabot-preview[bot], thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-07T08:02:25 | 2019-10-07T08:02:25 | {} | CONTRIBUTOR |
vuejs | core | 533,520,832 | 52 | haoqunjiang | @yyx990803 Ready for review. | 2019-09-20T11:49:03 | 2019-09-20T11:49:03 | {} | MEMBER |
vuejs | core | 538,652,370 | 102 | yyx990803 | Thanks, we are not including hello-world level examples for now since they'd be identical to Vue 2. | 2019-10-05T14:01:28 | 2019-10-05T14:01:28 | {
"+1": 2
} | MEMBER |
vuejs | core | 538,655,575 | 94 | vue-bot | Hey @pikax, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-05T14:40:20 | 2019-10-05T14:40:20 | {} | CONTRIBUTOR |
vuejs | core | 538,666,949 | 107 | laquasicinque | This is true, it definitely used to always be the case where object maps were faster for large switch statements not sure these days. | 2019-10-05T16:47:29 | 2019-10-05T16:47:29 | {} | CONTRIBUTOR |
vuejs | core | 538,754,460 | 137 | pikax | can you add some tests please? | 2019-10-06T14:51:14 | 2019-10-06T14:51:14 | {} | MEMBER |
vuejs | core | 538,270,340 | 79 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: build](https://circleci.com/gh/vuejs/vue-next/209?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your test... | 2019-10-04T07:00:30 | 2019-10-04T07:00:30 | {} | CONTRIBUTOR |
vuejs | core | 538,627,049 | 90 | znck | This is intentionally written like this to utilise tree-shaking abilities of Rollup in production build. | 2019-10-05T07:51:35 | 2019-10-05T07:51:35 | {} | MEMBER |
vuejs | core | 538,654,521 | 84 | vue-bot | Hey @benmccallum, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-05T14:28:06 | 2019-10-05T14:28:06 | {} | CONTRIBUTOR |
vuejs | core | 538,655,761 | 93 | vue-bot | Hey @pikax, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-05T14:43:04 | 2019-10-05T14:43:04 | {} | CONTRIBUTOR |
vuejs | core | 538,655,889 | 96 | vue-bot | Hey @pikax, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-05T14:44:42 | 2019-10-05T14:44:42 | {} | CONTRIBUTOR |
vuejs | core | 538,683,202 | 106 | znck | Thanks for the PR, but we want the keys typed with union `undefined` to exist so that every instance of the interface has the same shape. By having the same shape, the JavaScript runtime can optimize (using a concept called [monomorphism](https://mrale.ph/blog/2015/01/11/whats-up-with-monomorphism.html)) the functions ... | 2019-10-05T19:54:24 | 2019-10-05T19:56:04 | {} | MEMBER |
vuejs | core | 538,685,814 | 87 | thecrypticace | Thanks for that! 1:30am brain doesn't write test names well. :D | 2019-10-05T20:26:02 | 2019-10-05T20:26:02 | {} | CONTRIBUTOR |
vuejs | core | 538,708,424 | 87 | vue-bot | Hey @thecrypticace, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-06T03:27:44 | 2019-10-06T03:27:44 | {} | CONTRIBUTOR |
vuejs | core | 538,758,246 | 134 | vue-bot | Hey @Himself65, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-06T15:32:11 | 2019-10-06T15:32:11 | {} | CONTRIBUTOR |
vuejs | core | 538,758,308 | 133 | pikax | How about the implementation?
I placed it in the `nodeTransforms`, not sure if should be in the `directiveTransforms` since you have a comment for DOM specific transformations, is `nodeTransforms` the right place? | 2019-10-06T15:32:45 | 2019-10-06T15:32:45 | {} | MEMBER |
vuejs | core | 538,759,306 | 120 | vue-bot | Hey @CyberAP, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-06T15:43:07 | 2019-10-06T15:43:07 | {} | CONTRIBUTOR |
vuejs | core | 538,646,373 | 81 | ant1m4tt3r | Agreed. Do you have any idea of how can I get this data? Can you guide me through it? | 2019-10-05T12:39:46 | 2019-10-07T13:04:11 | {} | NONE |
vuejs | core | 539,386,467 | 148 | pikax | I think it will be better `v-pre` to be on the parser since we can actually make the parser ignore the content instead of doing at the later stage.
The only issue of having it at the compiler is to parse the children.
Also should this stay at `compiler-dom` or be moved to `compiler-core`? | 2019-10-08T07:35:14 | 2019-10-08T07:35:14 | {} | MEMBER |
vuejs | core | 538,270,515 | 80 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [deploy/netlify](https://app.netlify.com/sites/vue-next-coverage/deploys/5d96edd785f41700091886f9)
- [Mixed content](https://app.netlify.com/sites/vue-next-coverage/deploys/5d96edd785f41700091886f9)
- [Redirect rules](https://app.netlify.... | 2019-10-04T07:00:56 | 2019-10-04T07:00:56 | {} | CONTRIBUTOR |
vuejs | core | 538,653,363 | 104 | vue-bot | Hey @CodeDaraW, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-05T14:14:36 | 2019-10-05T14:14:36 | {} | CONTRIBUTOR |
vuejs | core | 538,655,809 | 95 | vue-bot | Hey @swapagarwal, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-05T14:43:43 | 2019-10-05T14:43:43 | {
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 538,718,613 | 125 | dsseng | ahh, I see, that broke everything | 2019-10-06T07:10:21 | 2019-10-06T07:10:21 | {} | CONTRIBUTOR |
vuejs | core | 538,764,905 | 82 | znck | Let's add tests here. | 2019-10-06T16:43:54 | 2019-10-06T16:43:54 | {} | MEMBER |
vuejs | core | 539,007,234 | 117 | CyberAP | Ok, so the problem was indeed in a wrong scope for a value. It gets updated correctly but in the handler itself is taken from a function argument, instead of from an invoker. | 2019-10-07T13:20:26 | 2019-10-07T13:20:26 | {} | CONTRIBUTOR |
vuejs | core | 538,655,100 | 92 | vue-bot | Hey @zrh122, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-05T14:34:51 | 2019-10-05T14:34:51 | {} | CONTRIBUTOR |
vuejs | core | 538,682,586 | 108 | vue-bot | Hey @Himself65, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-05T19:44:49 | 2019-10-05T19:44:49 | {} | CONTRIBUTOR |
vuejs | core | 538,691,057 | 115 | znck | Thanks for starting a PR, but I am closing this PR as it's incomplete.
You should create a [draft PR](https://github.blog/2019-02-14-introducing-draft-pull-requests/), so we can discuss changes first. | 2019-10-05T21:41:36 | 2019-10-05T21:41:36 | {} | MEMBER |
vuejs | core | 538,736,712 | 135 | znck | Thanks for the PR. However, I think the word registrator makes more sense here. | 2019-10-06T11:12:24 | 2019-10-06T11:12:24 | {} | MEMBER |
vuejs | core | 538,884,225 | 144 | vue-bot | Hey @dependabot-preview[bot], thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-07T08:02:40 | 2019-10-07T08:02:40 | {} | CONTRIBUTOR |
vuejs | core | 538,924,438 | 82 | znck | I'll try to write some tests. | 2019-10-07T09:48:31 | 2019-10-07T09:48:31 | {} | MEMBER |
vuejs | core | 538,991,628 | 147 | posva | ie 11 will be supported | 2019-10-07T12:42:47 | 2019-10-07T12:42:47 | {
"+1": 2
} | MEMBER |
vuejs | core | 538,270,522 | 80 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [deploy/netlify](https://app.netlify.com/sites/vue-next-coverage/deploys/5d96edd785f41700091886f9)
- [Mixed content](https://app.netlify.com/sites/vue-next-coverage/deploys/5d96edd785f41700091886f9)
- [Redirect rules](https://app.netlify.... | 2019-10-04T07:00:57 | 2019-10-04T07:00:57 | {} | CONTRIBUTOR |
vuejs | core | 538,634,613 | 98 | jesusantguerrero | I hosted the code here: https://jesusantguerrero.github.io/test-vue3/test.html | 2019-10-05T09:43:10 | 2019-10-05T09:43:10 | {} | NONE |
vuejs | core | 538,665,789 | 107 | thecrypticace | I would definitely challenge the idea that an object map is _faster_ than a switch. Compiler's often generate jump tables for switch statements with constant cases. Object maps require indirection through a hash table. The switch is almost certainly faster especially if this ends up being a hot code path. | 2019-10-05T16:36:03 | 2019-10-05T16:36:40 | {} | CONTRIBUTOR |
vuejs | core | 538,691,086 | 115 | kyle-hall | Okay, thanks. I created https://github.com/vuejs/vue-next/pull/119 for that purpose. | 2019-10-05T21:41:55 | 2019-10-05T21:46:32 | {} | CONTRIBUTOR |
vuejs | core | 539,051,750 | 141 | laquasicinque | Just seen the comment on #132 about the transform, will be changing to hopefully use the right transform | 2019-10-07T14:54:48 | 2019-10-07T14:54:48 | {} | CONTRIBUTOR |
vuejs | core | 539,267,210 | 89 | thecrypticace | Updated. This the kind of approach you were looking for? | 2019-10-08T00:58:57 | 2019-10-08T00:58:57 | {} | CONTRIBUTOR |
vuejs | core | 539,294,960 | 99 | himself65 | updated | 2019-10-08T03:13:38 | 2019-10-08T03:13:38 | {} | CONTRIBUTOR |
vuejs | core | 539,297,783 | 150 | himself65 | Incidentally add '.idea' for WebStorm? | 2019-10-08T03:27:37 | 2019-10-08T03:27:37 | {} | CONTRIBUTOR |
vuejs | core | 537,534,967 | 78 | dependabot-preview[bot] | OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`.
If you change your mind, just re-... | 2019-10-02T15:01:09 | 2019-10-02T15:01:09 | {} | CONTRIBUTOR |
vuejs | core | 538,388,078 | 80 | yyx990803 | @dependabot rebase | 2019-10-04T13:04:45 | 2019-10-04T13:04:45 | {
"+1": 1
} | MEMBER |
vuejs | core | 538,731,051 | 131 | himself65 | same problem with #106 #113 :) | 2019-10-06T10:14:31 | 2019-10-06T10:14:31 | {} | CONTRIBUTOR |
vuejs | core | 538,832,920 | 139 | CodeDaraW | I have updated the code, please review again. | 2019-10-07T04:13:25 | 2019-10-07T04:13:25 | {} | CONTRIBUTOR |
vuejs | core | 538,942,246 | 130 | pikax | @znck should this be an `DirectiveTransform` or an `NodeTransform`?
EDIT: I converted to `DirectiveTransform` and that's why is the tests are failing, will fix the tests as soon as I know it should be `DirectiveTransform` or an `NodeTransform` | 2019-10-07T10:33:53 | 2019-10-07T13:54:28 | {} | MEMBER |
vuejs | core | 539,055,025 | 117 | vue-bot | Hey @CyberAP, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-07T15:01:26 | 2019-10-07T15:01:26 | {} | CONTRIBUTOR |
vuejs | core | 538,608,127 | 83 | vue-bot | Hey @shmarts, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-05T02:17:53 | 2019-10-05T02:17:53 | {
"hooray": 1
} | CONTRIBUTOR |
vuejs | core | 538,684,994 | 117 | znck | The `clicked` property returned from the `setup` function is not reactive, hence updating this property would not re-render the component.
From what I understand, you want to create a [`ref`](https://vue-composition-api-rfc.netlify.com/api.html#ref) for `clicked` property.
```diff
+ import { ref } from 'vue'
... | 2019-10-05T20:16:02 | 2019-10-05T20:16:02 | {} | MEMBER |
vuejs | core | 538,794,760 | 137 | kana-sama | > can you add some tests please?
There is a test for this:
https://github.com/vuejs/vue-next/blob/f0b32e7c2966f3fe956d5b0ad6d2ef28f8b37ef7/packages/reactivity/__tests__/ref.spec.ts#L66-L74
I can write a type-level assertion for this type-level function (because it is content of PR, sorry, I don't know domain of ... | 2019-10-06T22:33:59 | 2019-10-06T22:35:55 | {} | NONE |
vuejs | core | 532,720,533 | 65 | znck | I ported `parseFor` from 2.x to `v-for` transform:
https://github.com/vuejs/vue/blob/95d8afa07c4a84d6c178e220913cec4b1afcf21d/packages/vue-template-compiler/browser.js#L3210-L3227 | 2019-09-18T14:50:33 | 2019-09-18T14:50:33 | {} | MEMBER |
vuejs | core | 538,654,559 | 88 | vue-bot | Hey @yeyan1996, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-05T14:28:27 | 2019-10-05T14:28:27 | {} | CONTRIBUTOR |
vuejs | core | 538,654,721 | 85 | yyx990803 | This file is autogenerated and style is not relevant. Thanks. | 2019-10-05T14:30:31 | 2019-10-05T14:30:31 | {} | MEMBER |
vuejs | core | 538,654,819 | 91 | vue-bot | Hey @taiyop, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚
| 2019-10-05T14:31:33 | 2019-10-05T14:31:33 | {} | CONTRIBUTOR |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.