owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 721,065,869 | 2,540 | shadowings-zy | > > `@test-change="(evt) => console.log(evt.target.value)"` is recommended
>
> When I use "@test-change" it does not log the evt. [Example](https://codesandbox.io/s/vue-event-warning-bug-forked-zexgn?file=/src/components/input.js)
>
> > emits: ['testChange']
>
> I use the default eslint preset and this tells m... | 2020-11-03T11:40:52 | 2020-11-03T11:40:52 | {} | CONTRIBUTOR |
vuejs | core | 718,611,058 | 2,116 | LinusBorg | Nope. For that, we have `deep: true` or, as mentioned, this:
```js
watch(() => [...state.items], callback)
``` | 2020-10-29T10:28:26 | 2020-10-29T10:31:03 | {
"+1": 1
} | MEMBER |
vuejs | core | 718,000,215 | 2,483 | KaelWD | Another way to test it is
```ts
type NoNullableFields<T> = { [P in keyof T]-?: NonNullable<T[P]> }
type Expected = { foo: boolean }
type Result = ExtractPropTypes<NoNullableFields<ComponentObjectPropsOptions<Expected>>>
expectType<{ foo: boolean }>({} as Result)
```
Basically making it possible to convert... | 2020-10-28T15:12:06 | 2020-10-30T11:29:09 | {} | CONTRIBUTOR |
vuejs | core | 719,621,233 | 2,526 | 69hunter | Hi @boussadjra I just peeked into the `package-lock.json` in your reproduction link. It seems that the `@vue/compiler-sfc` is at version 3.0.0. If you can try to upgrade the module to 3.0.2, it should work.
![Screenshot 2020-10-30 at 11 26 35 PM](https://user-images.githubusercontent.com/16277948/97724200-985ec200-1... | 2020-10-30T15:28:52 | 2020-10-30T15:28:52 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 720,106,245 | 2,497 | fimion | so based on my quick search, it looks like this error is happening here ish (as of 11/01/2020):
https://github.com/vuejs/vue-next/blob/fff62e2ee8accf31bb5ac5abdb4c0636216cfd0e/packages/runtime-core/src/renderer.ts#L549
I can take a crack at this if no one objects?
| 2020-11-01T15:30:20 | 2020-11-01T15:30:20 | {} | NONE |
vuejs | core | 720,955,060 | 2,540 | LinusBorg | @shadowings-zy In DOM, attribute names are always interpreted as lowercase by the browser. So in DOM hyphenized event names have to be used. This has always been a caveat in Vue and there's no good way to "fix" without making event names too imprecise, so you can leave that be. | 2020-11-03T07:40:17 | 2020-11-03T13:03:04 | {
"+1": 1
} | MEMBER |
vuejs | core | 718,398,971 | 2,514 | edison1105 | You should do that in other options API because `setup()` is called before other component options are resolved. | 2020-10-29T06:47:56 | 2020-10-29T06:47:56 | {} | MEMBER |
vuejs | core | 718,830,310 | 2,516 | LinusBorg | @cathrinevaage is one the right track but this is unrelated to "runtime compiled templates".
The point is that you essentially made the content of `#app` to be the template of the (unnamed) root component that you passed to `createApp` (let's call this component `App`) for better reference).
`App` passes the slo... | 2020-10-29T15:29:15 | 2020-10-29T15:29:48 | {} | MEMBER |
vuejs | core | 720,267,988 | 2,537 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.15 KB (0%) |
| runtime-dom.global.prod.js | 26.43 KB (0%) |
| size-check.global.prod.js | 15.95 KB (0%) | | 2020-11-02T06:33:30 | 2020-11-02T06:33:30 | {} | NONE |
vuejs | core | 720,663,783 | 2,540 | LinusBorg | this function doesn't take into account events defined in kebap-case:
https://github.com/vuejs/vue-next/blob/749dd54706c5090d171edde9a80d6527670ee0e1/packages/runtime-core/src/componentEmits.ts#L197-L209
| 2020-11-02T19:00:39 | 2020-11-02T19:02:32 | {} | MEMBER |
vuejs | core | 720,928,099 | 2,544 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.15 KB (0%) |
| runtime-dom.global.prod.js | 26.43 KB (0%) |
| size-check.global.prod.js | 15.95 KB (0%) | | 2020-11-03T06:21:45 | 2020-11-03T06:21:45 | {} | NONE |
vuejs | core | 721,405,243 | 2,549 | LinusBorg | I'd rather say that the dev behaviour is wrong.
* slots return a fragment,
* and as the component has the slot as it's root node, it returns a fragment
* and attribute inheritance is not supported on fragments.
However in dev, components can "accidentally return a fragment if they have one root node but also o... | 2020-11-03T22:23:05 | 2020-11-03T22:25:26 | {
"+1": 3,
"confused": 1
} | MEMBER |
vuejs | core | 718,766,194 | 1,409 | somodevo | @AlexandreBonaventure I guess @icehaunter and my use case is more closely to #1826 which got closed as a duplicate of this issue. However, I'll provide an example as mentioned earlier when I continue working on evaluating Vue for our SPA rewrite. | 2020-10-29T13:51:03 | 2020-10-29T13:51:03 | {
"+1": 4,
"eyes": 2
} | NONE |
vuejs | core | 719,603,044 | 2,526 | vhoyer | 
it doesn't raise a warning for me :thinking: | 2020-10-30T14:58:24 | 2020-10-30T14:58:24 | {} | NONE |
vuejs | core | 720,928,003 | 2,543 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.15 KB (0%) |
| runtime-dom.global.prod.js | 26.43 KB (0%) |
| size-check.global.prod.js | 15.95 KB (0%) | | 2020-11-03T06:21:25 | 2020-11-03T06:21:25 | {} | NONE |
vuejs | core | 719,341,310 | 1,409 | KaelWD | If vue-router provided `'vue-router'` instead of a symbol and had `router.useRouter` you could do `inject('vue-router')?.useRoute()` without importing anything. | 2020-10-30T07:22:17 | 2020-10-30T07:22:17 | {} | CONTRIBUTOR |
vuejs | core | 719,704,604 | 2,518 | dependabot-preview[bot] | Superseded by #2528. | 2020-10-30T17:52:15 | 2020-10-30T17:52:15 | {} | CONTRIBUTOR |
vuejs | core | 720,956,892 | 2,540 | milleniumfrog | > `@test-change="(evt) => console.log(evt.target.value)"` is recommended
When I use "@test-change" it does not log the evt. [Example](https://codesandbox.io/s/vue-event-warning-bug-forked-zexgn?file=/src/components/input.js)
> emits: ['testChange']
I use the default eslint preset and this tells me, that custom... | 2020-11-03T07:45:37 | 2020-11-03T07:45:37 | {} | NONE |
vuejs | core | 721,242,358 | 2,551 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | -------------------- |
| vue.global.prod.js | 40.15 KB (-0.01% 🔽) |
| runtime-dom.global.prod.js | 26.43 KB (-0.02% 🔽) |
| size-check.global.prod.js | 15.95 KB (0%) | | 2020-11-03T16:39:37 | 2020-11-03T16:39:37 | {} | NONE |
vuejs | core | 719,001,049 | 1,553 | yyx990803 | We don't have this implemented for typing yet, since it actually relies on the [template literal types](https://github.com/microsoft/TypeScript/pull/40336) feature which (I think) is going to be part of TS 4.1. | 2020-10-29T20:25:29 | 2020-10-29T20:25:41 | {} | MEMBER |
vuejs | core | 719,607,887 | 2,524 | HcySunYang | > The second problem is not fixed.
I don't think the second problem is a bug or something that needs improvement. When the props change, the component does need to be updated, and I think the **update** is not equivalent to re-rendering, of course, it **includes** re-rendering.
> Yep. It seems we also need to pau... | 2020-10-30T15:06:31 | 2020-10-30T15:06:31 | {} | MEMBER |
vuejs | core | 719,777,269 | 1,347 | jods4 | @yyx990803 can you give a signal regarding Suspense?
Now that Vue 3 is out, do you have an idea what's gonna happen with it? Are you working on making this stable, an outlook on the timeframe for that?
Not pressuring you, I'd just like some info to take decision on our future developments here.
Suspense is a nice... | 2020-10-30T20:19:29 | 2020-10-30T20:19:29 | {
"+1": 3
} | CONTRIBUTOR |
vuejs | core | 720,928,815 | 2,540 | edison1105 | here is my code, is there something wrong ?😭
```javascript
<script src="../../dist/vue.global.js"></script>
<div id="app">
<Comp msg="string input" @testChange="(evt) => console.log(evt.target.value)"></Comp>
</div>
<script>
const { createApp, defineComponent,h } = Vue
const Comp = defineComponen... | 2020-11-03T06:24:08 | 2020-11-03T06:30:11 | {} | MEMBER |
vuejs | core | 721,231,687 | 2,463 | haoqunjiang | Another edge case as brought up by @znck: no `<template>`, no root level `render`, but the `setup` function returns a render function. In this case the omission of `<template>` is intentional. | 2020-11-03T16:21:42 | 2020-11-03T16:21:42 | {} | MEMBER |
vuejs | core | 721,464,348 | 2,553 | edison1105 | @posva I clone your repo but it works correctly, could not reproduce.
| 2020-11-04T01:38:55 | 2020-11-04T01:38:55 | {} | MEMBER |
vuejs | core | 721,487,097 | 2,532 | dajpes | How Can I use this new syntax in a new vue project? | 2020-11-04T03:10:17 | 2020-11-04T03:10:17 | {
"+1": 1
} | NONE |
vuejs | core | 718,487,855 | 2,375 | ljwrer | ```typescript
import { reactive, defineComponent } from 'vue'
class CounterStore {
count = 0
add () {
this.count++
}
}
const store = reactive(new CounterStore())
export default defineComponent({
setup () {
return () => <button onClick={() => store.add()}>{store.count}</button>
}
})
... | 2020-10-29T08:47:17 | 2020-10-29T08:47:17 | {
"+1": 1
} | NONE |
vuejs | core | 718,588,577 | 2,116 | LinusBorg | I get your argument about differences in main use cases. At he same time, I also think when designing an API, providing consistent behaviors and and avoiding surprises should be an important factor as well.
If feel like watching a ref should *only* trigger when the ref's value changes - not matter what kind the valu... | 2020-10-29T10:13:06 | 2020-10-29T10:13:06 | {
"+1": 1
} | MEMBER |
vuejs | core | 718,667,557 | 2,116 | LinusBorg | anyway, the behaviour is consistent with objects and arrays, at least:
```js
/* REACTIVE */
const obj = reactive({})
const array = reactive([])
watch(obj, cb) // implicit deep: true
watch(array, cb) // implicit deep: true
obj.newProp = 'foo' // => triggers cb
array.push('foo') // => triggers cb
/* RE... | 2020-10-29T11:06:57 | 2020-10-29T12:31:37 | {
"+1": 7
} | MEMBER |
vuejs | core | 718,760,368 | 2,510 | LinusBorg | https://github.com/vuejs/vue-next/blob/829b35e4260181b6d01e0f598a469750a64ed0ea/packages/compiler-ssr/src/transforms/ssrTransformComponent.ts#L181
Indeed in the compiler-ssr, we render transition-groups as fragments (4th argument). But I think the skip of the root node happens earlier / somewhere else, looking.... | 2020-10-29T13:41:43 | 2020-10-29T13:43:40 | {} | MEMBER |
vuejs | core | 718,779,242 | 1,356 | znck | Template is converted to TSX so `h` is not required for type checking. | 2020-10-29T14:11:35 | 2020-10-29T14:11:35 | {
"+1": 1
} | MEMBER |
vuejs | core | 719,606,948 | 2,526 | boussadjra | @edison1105 i updated that module to the version `3.0.2` but it's still not working | 2020-10-30T15:04:57 | 2020-10-30T15:04:57 | {} | NONE |
vuejs | core | 719,705,798 | 2,528 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.15 KB (0%) |
| runtime-dom.global.prod.js | 26.43 KB (0%) |
| size-check.global.prod.js | 15.95 KB (0%) | | 2020-10-30T17:54:29 | 2020-10-30T17:54:29 | {} | NONE |
vuejs | core | 719,942,103 | 2,534 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | -------------------- |
| vue.global.prod.js | 40.15 KB (+0.02% 🔺) |
| runtime-dom.global.prod.js | 26.43 KB (+0.02% 🔺) |
| size-check.global.prod.js | 15.95 KB (+0.03% 🔺) | | 2020-10-31T14:33:45 | 2020-10-31T14:33:45 | {} | NONE |
vuejs | core | 720,651,015 | 2,540 | LinusBorg | Seems to be related to `camelCase` - `kebap-case` event name conversions. Both are allowed but this check seems to only verify the on it gets from the parent.
defining it in camelCase works:
```js
emits: ['testChange']
```
...but both should work ideally. | 2020-11-02T18:35:31 | 2020-11-02T18:58:48 | {
"+1": 1
} | MEMBER |
vuejs | core | 720,770,146 | 1,136 | internettrans | I help maintain systemjs, and we are discussing this in https://github.com/systemjs/systemjs/issues/2272. One thing to note is that SystemJS can't even load Vue as a global variable, since the vue library creates multiple global variables (`Vue`, `devtoolsFormatters`, `__VUE__`, `__VUE_HMR_RUNTIME__`), so SystemJS cann... | 2020-11-02T22:52:45 | 2020-11-02T23:04:27 | {} | NONE |
vuejs | core | 719,619,427 | 2,524 | skirtles-code | I'm unclear what people mean when they say 'the second problem'. In my original bug report I mentioned two problems, in bullet points 1 and 3. The contents of bullet point 2 were a necessary step in reproducing the problem in bullet point 3.
While it could be argued that the behaviour in bullet point 2 is also a bug... | 2020-10-30T15:25:41 | 2020-10-30T15:25:41 | {} | CONTRIBUTOR |
vuejs | core | 720,935,195 | 2,540 | edison1105 | I found this reason and I don't know how to fix this.😆 | 2020-11-03T06:43:02 | 2020-11-03T06:43:02 | {} | MEMBER |
vuejs | core | 720,941,999 | 1,870 | kleinfreund | > This is somewhat expected because a plugin should never list `vue` as its direct dependency, because it must always use whatever version of Vue that the consuming application is using. A plugin should list `vue` as a dev/peer dependency and externalize it (if there is a build step).
While this is reasonable for th... | 2020-11-03T07:01:40 | 2020-11-03T07:01:40 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 700,535,505 | 629 | LinusBorg | 1. Define the component
2. Mount it with createApp
Does that do what you need? | 2020-09-29T08:25:23 | 2020-09-29T08:25:23 | {
"+1": 2
} | MEMBER |
vuejs | core | 700,600,448 | 2,250 | posva | What does this solve? | 2020-09-29T10:00:21 | 2020-09-29T10:00:21 | {} | MEMBER |
vuejs | core | 701,197,194 | 2,277 | edison1105 | modify your code:
`emits: ['myclick']`
and
`emit('myclick', e)`
worked. | 2020-09-30T06:54:30 | 2020-09-30T06:54:30 | {} | MEMBER |
vuejs | core | 701,424,756 | 2,281 | RobbinBaauw | This is because you are mixing the VCA and Options API, by using `methods`. This uses the internal proxy, which makes this non-reactive state reactive as well.
It will work as expected if you only use VCA:
```js
setup() {
const count = ref(0);
let nonReactiveCount = 0;
function increment() {
... | 2020-09-30T14:23:55 | 2020-09-30T14:23:55 | {} | CONTRIBUTOR |
vuejs | core | 701,873,333 | 2,278 | shadowings-zy | @LinusBorg Hello, I updated my test case. I think the new test case will meet our expectations.
: ) | 2020-10-01T04:17:24 | 2020-10-01T04:17:24 | {} | CONTRIBUTOR |
vuejs | core | 700,524,627 | 629 | seanlandsman | @backbone87 thanks, but that still doesn't achieve was `Vue.extend` used to provide - `defineComponent` doesn't in itself do anything but provide typescript support for IDEs etc (as per the docs).
What I currently use `Vue.extend` for is to dynamically create Vue components and then instantiate them - `defineCompone... | 2020-09-29T08:04:24 | 2020-09-29T08:07:38 | {} | NONE |
vuejs | core | 700,768,968 | 2,268 | sumerokr | reserved for future notes | 2020-09-29T15:05:26 | 2020-09-29T15:05:26 | {} | NONE |
vuejs | core | 701,225,888 | 2,277 | edison1105 | because we must use the converted event name in render function. | 2020-09-30T07:52:39 | 2020-09-30T08:39:20 | {} | MEMBER |
vuejs | core | 701,446,823 | 2,281 | smilingkite | This is very educational. Thanks everybody. But not a bug, I guess. | 2020-09-30T14:59:22 | 2020-09-30T14:59:22 | {} | NONE |
vuejs | core | 701,510,761 | 2,269 | posva | Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.com/tags/vue.js).
If you did find a bug, please, open a new issue with a ... | 2020-09-30T16:46:16 | 2020-09-30T16:46:16 | {} | MEMBER |
vuejs | core | 701,541,795 | 2,283 | 07akioni | > doesn't happen when using actual `ref()`s for the template refs:
>
> https://codesandbox.io/s/vue-ref-bug-issue-2283-jrdvs
>
> I assume it's caused in part by the slot optimizations - when App.vue re-renders, $refs is cleared and all refs are updated. but the slot content sent to `<lazy-teleport>` doesn't need ... | 2020-09-30T17:44:12 | 2020-10-01T08:37:11 | {} | CONTRIBUTOR |
vuejs | core | 701,542,405 | 2,283 | LinusBorg | in this case I looked up the section that updated refs in Vue's source and then set a breakpoint at that line in the devtool's sources tab. | 2020-09-30T17:45:27 | 2020-10-01T08:37:17 | {} | MEMBER |
vuejs | core | 703,097,408 | 2,288 | HcySunYang | This is a duplicate of https://github.com/vuejs/vue-next/issues/2169 | 2020-10-03T12:40:19 | 2020-10-03T12:40:19 | {} | MEMBER |
vuejs | core | 700,593,174 | 2,264 | edison1105 | 最好的翻译就是不翻译 | 2020-09-29T09:45:50 | 2020-09-29T09:45:50 | {} | MEMBER |
vuejs | core | 700,601,988 | 2,263 | RobbinBaauw | It may be worthwhile to add a test which checks that removed computeds aren't in the `depsMap` anymore after triggering, since it is easy to accidentally create a regression which breaks this fix. | 2020-09-29T10:03:15 | 2020-09-29T10:03:15 | {} | CONTRIBUTOR |
vuejs | core | 700,699,827 | 2,264 | jacekkarczmarczyk | @sodatea i think he meant translating the "Composition API" phrase, not translating the docs | 2020-09-29T13:23:40 | 2020-09-29T13:23:40 | {} | CONTRIBUTOR |
vuejs | core | 700,428,649 | 1,600 | antoniandre | @yyx990803,
> > In my project, I used the parser of vue compiler to do some template conversion work
>
> Can you be more specific? Are you converting legacy HTML to Vue templates or doing transforms on Vue templates? Why would you need the whitespace to be preserved?
In my case, I need whitespaces to be pres... | 2020-09-29T05:05:20 | 2020-09-30T03:29:54 | {
"+1": 2
} | NONE |
vuejs | core | 701,136,867 | 2,175 | CyanSalt | I think it is different with #2116 . Use `{ flush: 'post' }` in Composition API could solve it. It might be caused by the broken change of [`3.0.0-rc.13`](https://github.com/vuejs/vue-next/blob/master/CHANGELOG.md#breaking-changes). | 2020-09-30T03:34:21 | 2020-09-30T03:34:21 | {} | NONE |
vuejs | core | 701,357,189 | 2,267 | LinusBorg | See here:
https://github.com/vuejs/vue-next/blob/5d825f318f1c3467dd530e43b09040d9f8793cce/packages/runtime-core/src/errorHandling.ts#L116 | 2020-09-30T12:26:35 | 2020-09-30T12:26:35 | {} | MEMBER |
vuejs | core | 701,369,224 | 2,280 | LinusBorg | yes that's fine and works right now | 2020-09-30T12:49:55 | 2020-09-30T12:49:55 | {} | MEMBER |
vuejs | core | 701,444,783 | 2,281 | smilingkite | But then why is nonReactiveCount changing? You can create some very funky stuff this way. | 2020-09-30T14:56:01 | 2020-09-30T14:56:45 | {} | NONE |
vuejs | core | 699,926,627 | 2,231 | LinusBorg | with watchEffect() it's expected. Since computed properties are evaluated lazily(*), the effect has to run in order to determine whether or not the value of `isZero` did change.
However for the watch(), we could check that the old & the new value are in fact different before calling the callback function.
----
... | 2020-09-28T10:37:28 | 2020-09-30T15:03:41 | {
"+1": 2
} | MEMBER |
vuejs | core | 703,298,386 | 2,296 | posva | Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.com/tags/vue.js).
---
See https://github.com/vuejs/rfcs/pull/117 | 2020-10-04T18:45:41 | 2020-10-04T18:45:41 | {} | MEMBER |
vuejs | core | 700,761,364 | 2,267 | sumerokr | Interesting. Changing the return value from `false` to `true` makes the thing work.
And this is exactly the opposite of what documentation says (and how Vue 2 works). | 2020-09-29T14:54:22 | 2020-09-29T14:57:42 | {} | NONE |
vuejs | core | 701,209,386 | 2,277 | edison1105 | 
Maybe it's a bug.`props` key is `onMyclick` and `handlerName` is `onMyClick`.they do not match. I think we should use same way to convert them to keep them matched. @posva | 2020-09-30T07:20:04 | 2020-09-30T07:20:04 | {} | MEMBER |
vuejs | core | 700,533,256 | 2,258 | lmiller1990 | Yes, that's the one. No esm build for babel/parser. | 2020-09-29T08:21:01 | 2020-09-29T08:21:01 | {} | MEMBER |
vuejs | core | 700,604,584 | 2,265 | vue-bot | Hello, thank you for taking time filling this issue!
However, we kindly ask you to use our [Issue Helper](https://new-issue.vuejs.org/?repo=vuejs/vue-next) when creating new issues, in order to ensure every issue provides the necessary information for us to investigate. This explains why your issue has been automatic... | 2020-09-29T10:08:11 | 2020-09-29T10:08:11 | {} | CONTRIBUTOR |
vuejs | core | 700,690,755 | 2,264 | haoqunjiang | 已经有中文翻译了：https://vue-composition-api-rfc.netlify.app/zh/ | 2020-09-29T13:08:50 | 2020-09-29T13:08:50 | {} | MEMBER |
vuejs | core | 701,444,242 | 2,281 | LinusBorg | You're on the wrong track. comment out `this.count++` in the codesandbox and you will see that nothing is reactive anymore.
So no, nothing is being "made" reactive by using methods. | 2020-09-30T14:55:07 | 2020-09-30T14:55:16 | {} | MEMBER |
vuejs | core | 701,446,485 | 2,281 | smilingkite | Maybe, but in vue 2 you'd never find out, because it's difficult to do non-reactive stuff. | 2020-09-30T14:58:47 | 2020-09-30T14:58:47 | {} | NONE |
vuejs | core | 701,453,426 | 2,231 | LinusBorg | https://github.com/vuejs/vue-next/blob/5d825f318f1c3467dd530e43b09040d9f8793cce/packages/runtime-core/src/apiWatch.ts#L245
Here we basically assume that if it's a ref, the value definitely has changed and we can call the callback.
The issue is that a computed ref also counts as a ref, but it doesn't neccessarily ... | 2020-09-30T15:09:54 | 2020-09-30T15:10:37 | {} | MEMBER |
vuejs | core | 702,220,049 | 1,532 | antfu | [RFC #212](https://github.com/vuejs/rfcs/pull/212) provides a solution for this. | 2020-10-01T15:37:07 | 2020-10-01T15:37:07 | {} | MEMBER |
vuejs | core | 702,469,239 | 2,201 | yeikiu | I've been tracking down this issue and I can confirm that sticking to `vue@3.0.0-rc.5` version under yarn.lock fixes my issues with Suspense and router-views. You need to install dependencies with `yarn --frozen-lock-file`.
```
vue@^3.0.0-0:
version "3.0.0-rc.5"
resolved "https://registry.yarnpkg.com/vue/-/v... | 2020-10-02T00:46:38 | 2020-10-02T01:01:24 | {} | NONE |
vuejs | core | 702,517,674 | 2,278 | shadowings-zy | > @shadowings-zy That's not the warning, if you run the reproduction on the comment you will see it
@posva Hello, the reproduction on the comment has nothing but an empty Vue2 project......
<img width="1471" alt="截屏2020-10-02 12 16 58" src="https://user-images.githubusercontent.com/29225966/94887595-52332600-04a9-1... | 2020-10-02T04:22:58 | 2020-10-02T04:22:58 | {} | CONTRIBUTOR |
vuejs | core | 703,073,332 | 2,293 | 7revor | > This is expected, it did update. It wouldn't trigger with **nested** components though
> This is expected, it did update. It wouldn't trigger with **nested** components though
This is actually a breaking change from v2.
In the process of migration, the resulting performance loss makes me very confused.
... | 2020-10-03T09:09:52 | 2020-10-03T09:24:49 | {} | NONE |
vuejs | core | 701,191,171 | 2,097 | jw-foss | > If you want your library to render elements, give the user a component to put in their app where you pass the messages. The solution with a hoc by @lawvs also works
>
> Remember to use the [forum](http://forum.vuejs.org/) or the [Discord chat](https://vue-land.js.org/) to ask questions!
Indeed @lawvs's solution... | 2020-09-30T06:40:56 | 2020-09-30T06:40:56 | {
"rocket": 1
} | NONE |
vuejs | core | 701,278,586 | 2,277 | posva | See https://github.com/vuejs/vue-next/issues/2249 | 2020-09-30T09:33:49 | 2020-09-30T09:33:49 | {} | MEMBER |
vuejs | core | 702,156,019 | 2,278 | shadowings-zy | > I think this will break in-browser templates:
>
> ```
> <the-component v-on:test-event="handler">
> ```
>
> results in this render function:
>
> ```js
> return (_openBlock(), _createBlock(_component_Mycomponent, { "onTest-event": _ctx.handler }, null, 8 /* PROPS */, ["onTest-event"]))
> ```
>
> [Examp... | 2020-10-01T14:00:07 | 2020-10-01T14:00:07 | {} | CONTRIBUTOR |
vuejs | core | 702,159,792 | 2,278 | shadowings-zy | > Can you add dev warning like in vue 2 ([#2249 (comment)](https://github.com/vuejs/vue-next/issues/2249#issuecomment-699892517))
@posva Ok, I can add dev warning for in-DOM templates. But I want to make sure that is the warning context is the same as Vue2?
The warning you mentioned in issue #2278 is :
```
You ... | 2020-10-01T14:05:38 | 2020-10-01T14:05:38 | {} | CONTRIBUTOR |
vuejs | core | 702,566,832 | 2,278 | posva | Yeah, it's the second one (https://github.com/vuejs/vue/blob/dev/src/core/instance/events.js#L123). Weird the jsfiddle wasn't what I had, probably forgot to press fork 😓 | 2020-10-02T07:09:47 | 2020-10-02T07:09:47 | {} | MEMBER |
vuejs | core | 702,678,139 | 2,291 | posva | This is a regression of https://github.com/vuejs/vue-next/issues/1603 | 2020-10-02T11:23:16 | 2020-10-02T11:23:16 | {} | MEMBER |
vuejs | core | 700,594,503 | 2,261 | posva | You are right, it's worth cleaning up the held reference if possible. Thanks for the PR! | 2020-09-29T09:48:22 | 2020-09-29T09:48:22 | {} | MEMBER |
vuejs | core | 700,606,771 | 2,248 | posva | I don't think there is a way, only using types, that allows both, to hint the user about removed attributes and, to allow users to use their own props on the new flattened structure. I think it's worth updating the docs so I opened a PR there | 2020-09-29T10:12:37 | 2020-09-29T10:12:37 | {} | MEMBER |
vuejs | core | 700,871,230 | 2,269 | FrankFang | You'd better provide a link to minimal reproduction. Your repo is too complex. | 2020-09-29T17:39:24 | 2020-09-29T17:39:24 | {} | NONE |
vuejs | core | 701,438,736 | 2,281 | KaelWD | It isn't even reactive, you're just triggering a rerender by updating `count` | 2020-09-30T14:46:14 | 2020-09-30T14:46:14 | {} | CONTRIBUTOR |
vuejs | core | 702,124,468 | 2,286 | posva | https://github.com/vuejs/rfcs/issues/216#issuecomment-702049684 | 2020-10-01T13:11:52 | 2020-10-01T13:11:52 | {} | MEMBER |
vuejs | core | 703,070,077 | 2,281 | LinusBorg | The difference you describe there in the last example is rooters in Javascript itself. Changing the let variable will not update the property if the same name that you returned from setup.
Not because of Vue or reactivity. It's because in Javascript,, primitive values can't be referenced, so when you returned it fr... | 2020-10-03T08:44:00 | 2020-10-03T08:59:43 | {
"+1": 1,
"eyes": 1
} | MEMBER |
vuejs | core | 700,562,610 | 2,261 | posva | Thank you for the boiled down and detailed report. This is a part of the problem related to the fact that reactive properties are only automatically cleaned and must be attached to a component instance to be cleared (called inside of `setup`). As pointed out, https://github.com/vuejs/rfcs/pull/212 is meant to tackle th... | 2020-09-29T08:54:11 | 2020-09-29T08:54:11 | {} | MEMBER |
vuejs | core | 701,334,345 | 2,280 | HcySunYang | test with:
```html
<!-- only is -->
<component is="h1">Hello World</component>
<!-- v-bind -->
<component v-bind="{ is: 'h1'}">Hello World</component>
<!-- is and v-bind -->
<component is="h1" v-bind="{ is: 'p'}">Hello World</component>
<component v-bind="{ is: 'h1'}" is="p">Hello World</component>
``` | 2020-09-30T11:35:58 | 2020-09-30T11:35:58 | {} | MEMBER |
vuejs | core | 701,356,459 | 2,268 | LinusBorg | `beforeCreate` and `created` hooks in VOA are treated a bit differently since they don't have an equivalent in VCA, and that special treatment is missing the error handling:
https://github.com/vuejs/vue-next/blob/5d825f318f1c3467dd530e43b09040d9f8793cce/packages/runtime-core/src/componentOptions.ts#L665
| 2020-09-30T12:25:09 | 2020-09-30T12:25:09 | {} | MEMBER |
vuejs | core | 701,357,122 | 2,280 | HcySunYang | This can also work fine:
```html
<component v-bind="obj" is="p">Hello World</component>
``` | 2020-09-30T12:26:28 | 2020-09-30T12:26:28 | {} | MEMBER |
vuejs | core | 701,431,417 | 2,281 | smilingkite | Is this expected to be fixed? I was expecting to be able to create non-reactive state this way (you know, save a bit of computing power etc). But if it's reactive (or becomes reactive?) when using methods, I guess that's off the table.
So best practices is to not mix the two?
This is going to trip a lot of peop... | 2020-09-30T14:34:30 | 2020-09-30T14:39:12 | {} | NONE |
vuejs | core | 702,192,582 | 2,278 | posva | @shadowings-zy That's not the warning, if you run the reproduction on the comment you will see it | 2020-10-01T14:55:48 | 2020-10-01T14:55:48 | {
"eyes": 1
} | MEMBER |
vuejs | core | 703,080,447 | 2,293 | 7revor | > It's true the behavior is [different from Vue 2](https://jsfiddle.net/z8w0u5b2/) and I'm not even sure it makes sense for it to call the `updated` hook
In v2, it seems that component would not update even the v-show changed (update display:none only). But in v3, no matter the v-show changes or not, as long as the ... | 2020-10-03T10:12:30 | 2020-10-03T10:17:26 | {} | NONE |
vuejs | core | 703,071,922 | 2,170 | kleinfreund | In my naïve hopes to possibly fix this myself, I wrote a two test cases which — as far as I understand — should both pass:
- setting an instance’s watched data property
- rendering an instance’s watched prop
Both should have access to the instance’s `$el` property. I wrote them in [`packages/runtime-core/__tests... | 2020-10-03T08:58:54 | 2020-10-03T12:58:16 | {} | CONTRIBUTOR |
vuejs | core | 700,579,774 | 2,261 | basvanmeurs | Thanks @posva
The workaround is not really useful for our situation, in which we have a class-based model using reactivity. We want parts to be cleaned up, not the full app.
The propasal seems good for more advanced use cases, but it seems a bit overcomplicated for simple use cases. I don't want to have to create ... | 2020-09-29T09:21:14 | 2020-09-29T09:21:14 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 701,207,037 | 2,277 | xuliangzhan | > modify your code:
> `emits: ['myclick']`
> and
> `emit('myclick', e)`
>
> worked.
Because ```Props``` can support the camelCased & kebab-case.
```props:{ showContent: String }```
```emits: ['myClick']```
```emit('myClick', e)```
and
```:show-content="xxx"```
```@my-click="xx"```
It would be great... | 2020-09-30T07:15:31 | 2020-09-30T07:15:31 | {} | NONE |
vuejs | core | 701,391,683 | 2,170 | LinusBorg | https://github.com/vuejs/vue-next/blob/5d825f318f1c3467dd530e43b09040d9f8793cce/packages/runtime-core/src/renderer.ts#L1427-L1432
* `updateComponentPreRender()` sets the instance.vnode to the next vnode, and then calls all queued effects.
* at that moment, the new vnode doesn't have an element assigned
* only afte... | 2020-09-30T13:30:06 | 2020-09-30T13:30:06 | {
"+1": 1
} | MEMBER |
vuejs | core | 701,439,850 | 2,281 | smilingkite | @KaelWD Yes, it was. The code-example just wasn't showing correctly (it is in the code-sandbox). I edited it to show my intent. | 2020-09-30T14:47:55 | 2020-09-30T14:48:43 | {} | NONE |
vuejs | core | 701,447,032 | 2,281 | LinusBorg | ```javascript
created() {
this.nonReactiveCount = 0
}
```
not really difficult, I saw countless instances of things like this | 2020-09-30T14:59:39 | 2020-09-30T14:59:39 | {
"eyes": 1
} | MEMBER |
vuejs | core | 701,542,801 | 2,283 | 07akioni | > in this case I looked up the section that updated refs in Vue's source and then set a breakpoint at that line in the devtool's sources tab.
Inside codesandbox? | 2020-09-30T17:46:04 | 2020-10-01T08:07:24 | {} | CONTRIBUTOR |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.