owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 739,441,560 | 2,735 | stephanedemotte | <img width="933" alt="Screen Shot 2020-12-05 at 8 36 38 PM" src="https://user-images.githubusercontent.com/2158130/101269162-a1ac0180-3739-11eb-8838-916074a1be74.png">
Yep, i've tested after the fix | 2020-12-06T01:37:53 | 2020-12-06T01:38:27 | {} | NONE |
vuejs | core | 739,938,839 | 2,755 | posva | You cannot create an app inside of the setup of another other app. It changes the current instance and that's why you see no instance after `Toast()` | 2020-12-07T14:05:51 | 2020-12-07T14:05:51 | {} | MEMBER |
vuejs | core | 740,172,142 | 2,756 | leopiccionia | I think that using a closure, as suggested by Eduardo in #2749, is the most elegant solution.
Depending on your specific case, using [`shallowReactive`](https://v3.vuejs.org/api/basic-reactivity.html#shallowreactive) instead of `reactive` can do the trick. | 2020-12-07T20:49:46 | 2020-12-07T20:49:46 | {} | CONTRIBUTOR |
vuejs | core | 740,570,643 | 2,763 | posva | This is a feature: the point is to read from reactive data and return a value, but the value returned could be a primitive like:
```js
watch(
() => 'n:' + obj.count + `(${count})`,
(countSentence, oldCountSentence) => {
console.log(countSentence);
}
);
```
Yet this will trigge... | 2020-12-08T11:44:20 | 2020-12-08T11:44:20 | {} | MEMBER |
vuejs | core | 741,583,843 | 2,771 | Zcating | try `<script lang="jsx">...</script>` | 2020-12-09T07:15:56 | 2020-12-09T07:15:56 | {} | CONTRIBUTOR |
vuejs | core | 738,617,404 | 2,722 | edison1105 | I uploaded the code of my local build.see my demo https://codesandbox.io/s/vue3-transition-group-q71ff-forked-8jbkb?file=/index.html
Note: my local code is latest master branch.It's different from version 3.0.4.
Maybe the next release it will be fixed. | 2020-12-04T07:27:34 | 2020-12-04T07:33:06 | {
"+1": 1
} | MEMBER |
vuejs | core | 739,038,898 | 2,439 | yyx990803 | Thanks for the PR, but I think this is better tested together with `transformExpression` - see 338d869c | 2020-12-04T21:47:47 | 2020-12-04T21:47:47 | {} | MEMBER |
vuejs | core | 739,421,658 | 2,735 | posva | But wasn't 085bbd5fe07c52056e9f7151fbaed8f6a2e442b3 included in v3.0.4?
The problem here only appears after bundling for prod | 2020-12-05T21:58:44 | 2020-12-05T21:58:44 | {} | MEMBER |
vuejs | core | 740,582,398 | 2,735 | stephanedemotte | @CHOYSEN thanks a lot, and very sorry for the noise :) | 2020-12-08T12:11:03 | 2020-12-08T12:11:03 | {} | NONE |
vuejs | core | 741,396,832 | 2,765 | edison1105 | I think this should also be handled
https://github.com/vuejs/vue-next/blob/8936e53b10a507b80ffc5b0ecaa6a1a0322f46cc/packages/runtime-core/src/apiWatch.ts#L230-L241 | 2020-12-09T01:28:13 | 2020-12-09T01:28:13 | {} | MEMBER |
vuejs | core | 739,415,855 | 2,734 | yyx990803 | This is an intended breaking change in v3: https://v3.vuejs.org/guide/migration/attribute-coercion.html#overview | 2020-12-05T21:03:54 | 2020-12-05T21:03:54 | {} | MEMBER |
vuejs | core | 739,686,806 | 2,743 | ht-sauce | Thank you. I think the official document should provide a description of this. Or explain the API that getcurrentinstance can use. Avoid low-level problems
> 您应该这样做：
>
> ```js
> const { proxy } = getCurrentInstance （）
> 控制台。日志（代理。$ store ）
> ```
>
> 不建议使用，`const {ctx} = getCurrentInstance()`因为生产环境和开发环境`c... | 2020-12-07T05:59:56 | 2020-12-07T05:59:56 | {} | NONE |
vuejs | core | 739,777,181 | 2,733 | posva | Since you could define a component with as many generics as you want, you will have to use a function like proposed above:
```ts
function defineGenericComponent<T, D>() {
return defineComponent({ ... })
}
```
---
Remember to use the [forum](http://forum.vuejs.org/) or the [Discord chat](https://vue-land.... | 2020-12-07T08:59:39 | 2020-12-07T08:59:39 | {
"+1": 1
} | MEMBER |
vuejs | core | 739,780,910 | 2,749 | posva | This is inherent to how `this` works on JS and the fact that `reactive` unwraps refs, which is intended. You can either remove the usage of `ref` inside class if you wrap it later with reactive
```js
class Foo {
name = 'Homer'
greet() {
console.log('Hello ' + this.name);
}
}
```
or use a functi... | 2020-12-07T09:06:00 | 2020-12-07T09:06:00 | {
"+1": 1
} | MEMBER |
vuejs | core | 739,790,963 | 2,711 | posva | The `to` has to be present at the moment the component renders, so as explained, using an unitialized `ref` won't work. In general, it's better to have the teleport target outside of the component where `teleport` is used: https://v3.vuejs.org/api/built-in-components.html#teleport. Because of this you cannot use the `r... | 2020-12-07T09:23:54 | 2020-12-07T09:23:54 | {} | MEMBER |
vuejs | core | 739,954,193 | 2,755 | sakura-flutter | > You cannot create an app inside of the setup of another other app. It changes the current instance and that's why you see no instance after `Toast()`
Thanks~
But the documentation has no description, can it be added to the documentation?
https://v3.vuejs.org/api/composition-api.html#getcurrentinstance | 2020-12-07T14:31:12 | 2020-12-07T14:33:03 | {} | NONE |
vuejs | core | 740,613,732 | 2,751 | sapphi-red | I think this behavior is correct because this `update:modelValue` indicates that it does not receive any parameters.
https://github.com/vuejs/rfcs/blob/master/active-rfcs/0030-emits-option.md#type-inference
```ts
emits: {
'update:modelValue': function works() { return true; },
},
```
I think this shoul... | 2020-12-08T13:18:01 | 2020-12-08T13:18:01 | {} | CONTRIBUTOR |
vuejs | core | 737,776,508 | 2,715 | web-97 | > Then provide a valid reproduction, it's still the same code:
>
> 
Sorry, just debugging the code. I have updated the code https://codesandbox.io/s/nice-shaw-8b9cv on this lin... | 2020-12-03T09:23:55 | 2020-12-03T09:25:22 | {} | NONE |
vuejs | core | 739,050,991 | 2,655 | JensDll | closing this because of #2425 | 2020-12-04T22:11:31 | 2020-12-04T22:11:31 | {} | CONTRIBUTOR |
vuejs | core | 739,501,005 | 2,710 | kdankert | Is there any estimate on when this is going to be released? | 2020-12-06T13:14:07 | 2020-12-06T13:14:07 | {
"+1": 13,
"eyes": 6
} | NONE |
vuejs | core | 739,926,341 | 2,735 | CHOYSEN | > Yep, i've tested after the fix
It work fine for me after the fix whether it's dev or build...
| 2020-12-07T13:43:17 | 2020-12-07T13:43:17 | {} | CONTRIBUTOR |
vuejs | core | 741,385,353 | 2,767 | AlexVipond | Thanks, that's definitely a viable solution. I think for now I'll just use `el => els.value.push(el)` plus an `onBeforeUpdate` hook to reset `els.value` to an empty array as shown in the Vue docs.
I'll close this issue since both of these proposed solutions work well. | 2020-12-09T01:19:52 | 2020-12-09T01:19:52 | {} | NONE |
vuejs | core | 739,415,760 | 2,735 | yyx990803 | Duplicate of #2699 and already fixed by 085bbd5fe07c52056e9f7151fbaed8f6a2e442b3 (not released yet) | 2020-12-05T21:02:54 | 2020-12-05T21:02:54 | {} | MEMBER |
vuejs | core | 739,703,279 | 2,745 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.51 KB (0%) |
| runtime-dom.global.prod.js | 26.83 KB (0%) |
| size-check.global.prod.js | 16.21 KB (0%) | | 2020-12-07T06:37:14 | 2020-12-07T06:37:14 | {} | NONE |
vuejs | core | 740,683,487 | 2,766 | posva | you can with a `v-bind="tag === 'input' ? { input: 'text' } : {}"` | 2020-12-08T15:19:55 | 2020-12-08T15:19:55 | {
"hooray": 2
} | MEMBER |
vuejs | core | 741,375,297 | 2,769 | edison1105 | same as #2715 and closed by #2717
It's not release yet. | 2020-12-09T01:12:40 | 2020-12-09T01:12:40 | {} | MEMBER |
vuejs | core | 738,692,371 | 2,725 | posva | Read https://new-issue.vuejs.org/?repo=vuejs/vue-next&lang=zh-cn#why-repro and provide a working reproduction
And open issues in English, thank you. | 2020-12-04T10:02:07 | 2020-12-04T10:02:07 | {} | MEMBER |
vuejs | core | 738,807,489 | 2,727 | yyx990803 | First, you need to understand Vue template is not JSX. By default components are resolved at runtime using their tag names from a registry (the `components` option) instead of compiled into JavaScript expressions.
Directly using imported components is strictly a feature of `<script setup>`. **Returning the component... | 2020-12-04T14:16:29 | 2020-12-04T14:16:29 | {
"heart": 1
} | MEMBER |
vuejs | core | 739,068,231 | 2,459 | yyx990803 | Thanks for the PR, sorry for taking so long to merge! | 2020-12-04T23:03:21 | 2020-12-04T23:03:21 | {} | MEMBER |
vuejs | core | 739,773,503 | 2,748 | posva | Should have been fixed by https://github.com/vuejs/vue-next/commit/e315d84936c82bee8f2cf2369c61b5aaec38f328 but confirmed locally that the error still exists | 2020-12-07T08:52:34 | 2020-12-07T08:52:34 | {} | MEMBER |
vuejs | core | 740,656,355 | 2,766 | posva | You cannot set the `type` of a textarea: https://html.spec.whatwg.org/multipage/form-elements.html#the-textarea-element. It's a readonly property.
Maybe the attribute shouldn't be set if the value is null or undefined | 2020-12-08T14:35:12 | 2020-12-08T14:35:12 | {} | MEMBER |
vuejs | core | 741,358,611 | 2,767 | Zcating | Because the `els` is a ref, and could trigger the view update when `els` value changing. When view updating, all of nodes will rebuild.
Maybe just create a ref map.
```
const refMap = {};
Object.keys(bar).forEach(({id}) => refMap[id] = ref(null));
// in template
<div
v-for="({ foo, id }) in bar"
:key="i... | 2020-12-09T01:00:49 | 2020-12-09T01:00:49 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 737,726,889 | 2,712 | edison1105 | caused by this commit e2618a632d4add2819ffb8b575af0da189dc3204 in this PR #2597.
| 2020-12-03T07:44:04 | 2020-12-03T08:04:41 | {} | MEMBER |
vuejs | core | 737,755,112 | 2,715 | posva | I don't get an error (could be a cache problem of Codesandbox) but you are using the same `key` for all of your todos, they must be different. | 2020-12-03T08:44:25 | 2020-12-03T08:44:25 | {} | MEMBER |
vuejs | core | 739,693,990 | 2,733 | Zcating |
As work around, You can do this to provide a generic type.
```
const GenericComponent = <T>() => defineComponent({
// add your defination.
});
```
Also you can declare a class component
```
export declare class GenericComponent<T> {
// add your defination
}
```
| 2020-12-07T06:16:26 | 2020-12-07T06:16:26 | {
"+1": 5
} | CONTRIBUTOR |
vuejs | core | 740,322,391 | 2,735 | stephanedemotte | @CHOYSEN It's crazy you don't have
```
{ "_rawValue": false, "_shallow": false, "__v_isRef": true, "_value": false }
```
After the build ?
I cannot believe it :/ Can you share a screen please ?
I've tried again from scratch, and i've got the same result
`App [{{ isActive }}]` should return `App[true]` but... | 2020-12-08T02:38:03 | 2020-12-08T02:40:58 | {} | NONE |
vuejs | core | 741,585,012 | 2,775 | Zcating | You should use arrow function while using validator or default attr. #2474 | 2020-12-09T07:18:36 | 2020-12-09T07:19:18 | {
"+1": 6
} | CONTRIBUTOR |
vuejs | core | 737,761,492 | 2,712 | luwuer | It happend because `transition-property: none` will be added to el as inline style on the first frame, so a workaround way is using `transition-property: all !important;` to cover it. | 2020-12-03T08:56:48 | 2020-12-03T08:56:48 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 738,588,761 | 2,723 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.51 KB (0%) |
| runtime-dom.global.prod.js | 26.82 KB (0%) |
| size-check.global.prod.js | 16.19 KB (0%) | | 2020-12-04T06:12:49 | 2020-12-04T06:12:49 | {} | NONE |
vuejs | core | 769,710,270 | 2,943 | mattelen | Hi everyone, any thoughts on when this will be merged in master? Quite keen for this bugfix. TIA | 2021-01-29T10:08:33 | 2021-01-29T10:08:33 | {} | NONE |
vuejs | core | 770,617,204 | 3,138 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.51 KB (0%) |
| runtime-dom.global.prod.js | 26.83 KB (0%) |
| size-check.global.prod.js | 16.21 KB (0%) | | 2021-02-01T06:51:15 | 2021-02-01T06:51:15 | {} | NONE |
vuejs | core | 770,798,948 | 3,102 | pikax | Vue handles props differently from react, in vue a prop can have runtime validation.
I have this https://github.com/vuejs/vue-next/pull/3049 PR to introduce a similar way to pass the type to props, but this will still require you to define the props object.
I might misunderstand your issue, please clarify | 2021-02-01T11:49:35 | 2021-02-01T11:49:35 | {} | MEMBER |
vuejs | core | 770,824,299 | 3,070 | LinusBorg | Would we technically consider this a new feature, requiring a minor release?
We're putting together 3.0.6, if we include this, we'd have to go to 3.1 instead.
Just mentioning as we had other features, not coming right now, labelled for 3.1. so we would have to relabel them for 3.2 | 2021-02-01T12:35:06 | 2021-02-01T12:36:56 | {} | MEMBER |
vuejs | core | 769,156,290 | 3,117 | HcySunYang | you can also do this:
```ts
import { FunctionalComponent } from 'vue'
const MyInput: FunctionalComponent<InputHTMLAttributes & { foo?: string}> = (props) => {
return <input {...props}/>
}
const el = <MyInput foo="str" autofocus />
``` | 2021-01-28T15:18:05 | 2021-01-28T15:18:05 | {} | MEMBER |
vuejs | core | 769,161,557 | 3,117 | rainmanhhh | > you can also do this:
>
> ```ts
> import { FunctionalComponent } from 'vue'
>
> const MyInput: FunctionalComponent<InputHTMLAttributes & { foo?: string}> = (props) => {
> return <input {...props}/>
> }
>
> const el = <MyInput foo="str" autofocus />
> ```
FunctionalComponent is exactly what I need! ... | 2021-01-28T15:25:16 | 2021-01-28T15:25:16 | {} | NONE |
vuejs | core | 770,064,319 | 3,124 | TheDutchCoder | By the way: casting the values `as const` works, but that seems like a bit of an escape hatch?
```js
watch([foo, bar] as const, ([newFoo, newBar], [oldFoo, oldBar]) => {
```
| 2021-01-29T21:38:30 | 2021-01-29T21:38:30 | {} | NONE |
vuejs | core | 770,451,637 | 3,128 | posva | Closing as this is not a valid repro. Please read https://new-issue.vuejs.org/?repo=vuejs/vue#why-repro
---
Please, next time consider using the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.com/tags/vue.js) for questions first. But feel f... | 2021-01-31T21:11:43 | 2021-01-31T21:11:43 | {} | MEMBER |
vuejs | core | 770,486,898 | 3,110 | Akryum | I think this is fixed by https://github.com/vuejs/vue-next/commit/4fecb27f8696fdb8f681948543ea81ea62fe43bf | 2021-02-01T00:44:17 | 2021-02-01T00:44:17 | {} | MEMBER |
vuejs | core | 770,722,315 | 2,621 | LinusBorg | @HcySunYang Do I read your last comment correctly: Are we stuck here? | 2021-02-01T09:43:55 | 2021-02-01T09:43:55 | {} | MEMBER |
vuejs | core | 770,843,047 | 3,003 | HcySunYang | If we `squash and merge`, we can reset the commit message, right? | 2021-02-01T13:06:06 | 2021-02-01T13:06:06 | {} | MEMBER |
vuejs | core | 771,331,749 | 3,131 | HcySunYang | @posva Should we need to close this one and put it in the RFC for discussion? | 2021-02-02T03:39:37 | 2021-02-02T03:39:37 | {} | MEMBER |
vuejs | core | 771,721,395 | 2,892 | HcySunYang | @edison1105 Your fix does not solve the real cause. And there are problems according to your changes, let's say if the `Transition` has an `out-in` mode, then the `subtree` may be `undefined`. I made another PR, see https://github.com/vuejs/vue-next/pull/3150 | 2021-02-02T15:36:00 | 2021-02-02T15:36:00 | {} | MEMBER |
vuejs | core | 768,838,484 | 3,112 | HcySunYang | Please provide minimal repro | 2021-01-28T06:46:55 | 2021-01-28T06:46:55 | {} | MEMBER |
vuejs | core | 769,132,452 | 3,117 | rainmanhhh | by the way, I can use Omit<React.HTMLProps<HTMLInputElement>, 'value', 'placeholder'> to filter out props
> > You can use `$attrs` to passthrough, for example, https://codepen.io/hcysunyang/pen/abBoRpQ, also check out https://v3.vuejs.org/guide/component-attrs.html#attribute-inheritance
>
> checked the example bu... | 2021-01-28T14:50:57 | 2021-01-28T14:50:57 | {} | NONE |
vuejs | core | 769,145,799 | 3,117 | HcySunYang | So, what are you really asking? is it about the pass-through props? or about TS type? | 2021-01-28T15:03:42 | 2021-01-28T15:03:42 | {} | MEMBER |
vuejs | core | 769,837,855 | 3,122 | jesusgn90 | +1 | 2021-01-29T14:29:28 | 2021-01-29T14:29:28 | {} | NONE |
vuejs | core | 770,068,855 | 3,124 | TheDutchCoder | This seems to work as intended with how TS unions arrays | 2021-01-29T21:49:42 | 2021-01-29T21:49:42 | {} | NONE |
vuejs | core | 770,522,601 | 3,126 | HcySunYang | yes, #2362 can also be fixed in #2164 | 2021-02-01T02:32:28 | 2021-02-01T02:32:28 | {} | MEMBER |
vuejs | core | 771,500,995 | 3,147 | showyoulove |
```
<router-view v-slot="{ Component }">
<keep-alive>
<component :is="Component"/>
</keep-alive>
</router-view>
APP.vue
```
```
<div id="_layout">
<el-affix>
<nav-bar></nav-bar>
</el-affix>
<div class="main-section">
<router-view v-slot="{ Component }">
... | 2021-02-02T09:34:22 | 2021-02-02T09:34:22 | {} | NONE |
vuejs | core | 771,562,547 | 3,131 | posva | I think this one is worth having open because it really shows a case that can be improved and how to implement it, but that's my just opinion.
@eli-crow do you feel like opening an RFC at https://github.com/vuejs/rfcs? You seem to have a lot of content already, the idea would be to be more problem-centric to make su... | 2021-02-02T11:14:29 | 2021-02-02T11:14:29 | {} | MEMBER |
vuejs | core | 768,771,490 | 3,112 | edison1105 | see #2999 | 2021-01-28T03:24:12 | 2021-01-28T03:24:12 | {} | MEMBER |
vuejs | core | 769,127,228 | 3,117 | rainmanhhh | > You can use `$attrs` to passthrough, for example, https://codepen.io/hcysunyang/pen/abBoRpQ, also check out https://v3.vuejs.org/guide/component-attrs.html#attribute-inheritance
checked the example but it's not written by typescript and MyInput is a plan object without props type definition... | 2021-01-28T14:47:47 | 2021-01-28T14:47:47 | {} | NONE |
vuejs | core | 770,234,144 | 3,126 | HcySunYang | I believe that will be fixed in https://github.com/vuejs/vue-next/pull/2164 | 2021-01-30T16:04:48 | 2021-01-30T16:04:48 | {
"+1": 1
} | MEMBER |
vuejs | core | 770,450,542 | 3,130 | posva | @susnux you need the shims and I think it's valuable to add to https://v3.vuejs.org/guide/typescript-support.htmlin the docs-next repository | 2021-01-31T21:03:49 | 2021-01-31T21:03:58 | {} | MEMBER |
vuejs | core | 768,422,548 | 3,088 | leopiccionia | Seems to be a duplicate of #2740. | 2021-01-27T16:54:02 | 2021-01-27T16:54:02 | {} | CONTRIBUTOR |
vuejs | core | 769,793,565 | 3,121 | HcySunYang | Yes, you should specify slots explicitly in the child component, and strictly speaking, your usage is wrong, so I close this. | 2021-01-29T13:05:18 | 2021-01-29T13:05:18 | {
"+1": 1
} | MEMBER |
vuejs | core | 770,332,693 | 3,130 | HcySunYang | You need to add a declaration file:
```ts
// shims.d.ts
declare module '*.vue' {
import { ComponentOptions } from 'vue'
const component: ComponentOptions
export default component
}
``` | 2021-01-31T06:01:31 | 2021-01-31T06:01:31 | {
"+1": 2
} | MEMBER |
vuejs | core | 770,458,661 | 3,131 | eli-crow | This has to do with the reference point on the measured ClientRect used to calculate the translation delta between the start and end states of the F.L.I.P. animation. Measuring from the top-left is not appropriate for lists whose "gravity" tends to the right or downward, such as in chat applications or horizontal lists... | 2021-01-31T22:02:41 | 2021-01-31T22:08:07 | {} | NONE |
vuejs | core | 771,622,124 | 3,132 | posva | A new test that checks the generated srcset would be better to avoid a regression | 2021-02-02T13:07:35 | 2021-02-02T13:07:35 | {} | MEMBER |
vuejs | core | 768,687,701 | 3,088 | HcySunYang | Yes, close this. | 2021-01-28T01:19:14 | 2021-01-28T01:19:14 | {} | MEMBER |
vuejs | core | 769,080,414 | 2,834 | hgm-gx | 临时解决方法：
```
watch:{
'targetValue':function(val){
this.refreshTarget = false
this.$nextTick(function(){
this.refreshTarget = true
})
},
},
```
| 2021-01-28T14:12:43 | 2021-01-28T14:14:25 | {} | NONE |
vuejs | core | 769,147,126 | 3,117 | rainmanhhh | > So, what are you really asking? is it about the pass-through props? or about TS type?
with ts I can get both type definition(for auto completion) and props inherition | 2021-01-28T15:05:28 | 2021-01-28T15:05:28 | {} | NONE |
vuejs | core | 770,167,617 | 3,125 | HcySunYang | CI failure is irrelevant | 2021-01-30T06:40:28 | 2021-01-30T06:40:28 | {} | MEMBER |
vuejs | core | 770,354,512 | 2,907 | danielgindi | "According to doc"... The migration guide does not state that `unmount()` is a replacement, just that `$destroy` has been removed, and that Vue instances should not be managed manually. Which is weird, because sometimes you need to. | 2021-01-31T09:41:41 | 2021-01-31T09:41:41 | {} | NONE |
vuejs | core | 770,378,346 | 3,135 | Ryan2128 | > You should test in incognito mode in order to eliminate the interference of browser extensions. In addition, you should also click the **collect garbage** button every time you take a snapshot. And finally, I did some tests and found no memory leaks
Sorry, thanks for your explanation, this is my mistake. | 2021-01-31T12:55:28 | 2021-01-31T12:55:28 | {} | NONE |
vuejs | core | 770,789,292 | 3,125 | 07akioni | https://github.com/vuejs/vue-next/issues/3122#issuecomment-770789043 | 2021-02-01T11:32:16 | 2021-02-01T11:32:16 | {} | CONTRIBUTOR |
vuejs | core | 770,799,311 | 3,125 | HcySunYang | I read the comments, but this PR did not introduce any breaking changes, it just allows the user to do it with the way they want, just a utility for types | 2021-02-01T11:50:13 | 2021-02-01T11:50:13 | {} | MEMBER |
vuejs | core | 770,925,395 | 3,125 | 07akioni | It may cause breaking changes.
```
{
props: {
foo: {
type: Object as PropType<{ key: string }>,
default: () => ({ key: 'bar' })
}
},
setup (props) {
function f (x: string) {}
// If props.foo is optional, then break
f(props.foo.key)
}
}
```
I think if you did wan... | 2021-02-01T15:08:42 | 2021-02-01T15:16:59 | {} | CONTRIBUTOR |
vuejs | core | 771,545,924 | 3,147 | posva | @showyoulove please read https://new-issue.vuejs.org/?repo=vuejs/vue#why-repro
To control scroll behavior you should use https://next.router.vuejs.org/guide/advanced/scroll-behavior.html#scroll-behavior
---
Please, next time consider using the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-la... | 2021-02-02T10:45:50 | 2021-02-02T10:45:50 | {} | MEMBER |
vuejs | core | 771,551,033 | 3,148 | posva | It works in a vite app and on a CLI app so it should be a bug on Codesandbox or a misconfiguration on the template.The setup syntax requires to use the compiler. | 2021-02-02T10:55:06 | 2021-02-02T10:55:06 | {} | MEMBER |
vuejs | core | 768,690,520 | 2,740 | HcySunYang | I did not notice that https://github.com/vuejs/vue-next/issues/3088 is a duplicate of this issue, and I submitted a fix there. So I also linked my PR here, because there are some differences between my PR and https://github.com/vuejs/vue-next/pull/2729 | 2021-01-28T01:24:26 | 2021-01-28T01:24:26 | {} | MEMBER |
vuejs | core | 770,959,103 | 3,125 | HcySunYang | @07akioni did not break that, you should notice that `MakeDefaultsOptional` is `false` by default, which is the original behavior | 2021-02-01T15:55:43 | 2021-02-01T15:55:43 | {
"+1": 1
} | MEMBER |
vuejs | core | 771,476,761 | 3,147 | HcySunYang | Minimum reproduction please. | 2021-02-02T08:55:44 | 2021-02-02T08:55:44 | {} | MEMBER |
vuejs | core | 771,478,870 | 3,147 | showyoulove | > Minimum reproduction please.
How? Single page can not reflect the problem | 2021-02-02T08:59:29 | 2021-02-02T08:59:29 | {} | NONE |
vuejs | core | 771,748,814 | 3,151 | posva | You should avoid prefixing your variables with `$` or `_`:
See https://v3.vuejs.org/guide/data-methods.html#data-properties
When defined in data, you get a warning about it but I'm not sure if the same should apply here | 2021-02-02T16:11:59 | 2021-02-02T16:11:59 | {} | MEMBER |
vuejs | core | 768,893,016 | 3,112 | edison1105 | I debugged your project and found that the warning was generated because `value` is the `window` when traverse
```javascript
function traverse(value: unknown, seen: Set<unknown> = new Set()) {
if (!isObject(value) || seen.has(value)) {
return value
}
seen.add(value)
if (isRef(value)) {
travers... | 2021-01-28T08:40:09 | 2021-01-28T08:43:23 | {
"+1": 6
} | MEMBER |
vuejs | core | 769,189,120 | 3,116 | posva | You can use a shallowRef to keep underlying `refs` types untouched: `const arr = shallowRef<ItemInstance[]>([]);` as a workaround but it could have other impacts (see docs for more information)
| 2021-01-28T16:04:33 | 2021-01-28T16:04:33 | {} | MEMBER |
vuejs | core | 770,522,916 | 2,362 | HcySunYang | I believe this will be fixed in #2164 | 2021-02-01T02:33:37 | 2021-02-01T02:33:37 | {} | MEMBER |
vuejs | core | 770,617,555 | 3,139 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.51 KB (0%) |
| runtime-dom.global.prod.js | 26.83 KB (0%) |
| size-check.global.prod.js | 16.21 KB (0%) | | 2021-02-01T06:51:56 | 2021-02-01T06:51:56 | {} | NONE |
vuejs | core | 770,618,195 | 3,141 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.51 KB (0%) |
| runtime-dom.global.prod.js | 26.83 KB (0%) |
| size-check.global.prod.js | 16.21 KB (0%) | | 2021-02-01T06:53:13 | 2021-02-01T06:53:13 | {} | NONE |
vuejs | core | 770,624,211 | 3,142 | HcySunYang | Should be the same as https://github.com/vuejs/vue-next/issues/2015, tracked there. | 2021-02-01T07:05:07 | 2021-02-01T07:05:07 | {} | MEMBER |
vuejs | core | 770,698,291 | 3,131 | posva | Oh, so you are changing the size of an element inside of the `transition-group` and you want it to stay where it was independently of what changed inside?
Thanks for the clear reproduction with the actual desired behavior 🙌
I'm not sure if this should and could work out of the box, otherwise, the idea of adding... | 2021-02-01T09:07:26 | 2021-02-01T09:07:26 | {} | MEMBER |
vuejs | core | 770,809,460 | 3,132 | JonasKruckenberg | > Can you add a test case?
It is somewhat hard to test this explicitly, but I changed to snapshot to expect a whitespace between the import URL and the descriptor. This makes the tests pass + reflects how the srcset works.
@posva Please let me know if you expect more concrete tests or if this works for you | 2021-02-01T12:07:55 | 2021-02-01T12:07:55 | {} | CONTRIBUTOR |
vuejs | core | 771,921,378 | 3,151 | davy-tw | @posva good point!
With vue-loader, it allows css modules inject as custom name like `$globalStyle` and it works with old-style component definition.
But with `setup()`-style definition, we have to assign `useCSSModule('custom-name')` to some variable and export from `setup()`, thus, I cannot export custom names li... | 2021-02-02T19:37:13 | 2021-02-02T19:37:13 | {} | NONE |
vuejs | core | 768,779,996 | 2,999 | Shameless-Lip | > ### Version
> 3.0.0
>
> ### Reproduction link
> https://github.com/vuejs/vue-next
>
> ### Steps to reproduce
> 正常环境下不会重现，打包之后会出现这个错误
> vue-router-----const router = createRouter({
> history: createWebHistory(process.env.BASE_URL),
> routes,
> });
>
> package.json
> {
> "name": "----",
> "version": ... | 2021-01-28T03:48:09 | 2021-01-28T03:48:09 | {} | NONE |
vuejs | core | 768,938,945 | 3,114 | HcySunYang | Please provide a minimum repro, which includes the minimum code and steps to reproduce that problem, rather than just a link. | 2021-01-28T09:59:01 | 2021-01-28T09:59:01 | {} | MEMBER |
vuejs | core | 769,025,821 | 3,115 | jonaskuske | According to https://blog.vuejs.org/posts/hello-2021.html: estimate is Q2, but we'll see | 2021-01-28T12:39:09 | 2021-01-28T12:39:09 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 769,171,052 | 3,117 | rainmanhhh | > import it from vue:
>
> ```ts
> import { InputHTMLAttributes } from 'vue
> ```
it works! thank you | 2021-01-28T15:38:40 | 2021-01-28T15:38:40 | {} | NONE |
vuejs | core | 769,511,880 | 2,841 | recamshak | As a workaround you can replace `<sl-form @sl-submit="submit">` with `<sl-form v-on="{ 'sl-submit': submit }">`. Here is a fix of @devmount example: https://jsfiddle.net/faqp40th/
| 2021-01-29T01:31:08 | 2021-01-29T05:04:05 | {
"+1": 1
} | NONE |
vuejs | core | 770,166,380 | 3,122 | HcySunYang | You really misunderstood the purpose of `ExtractPropTypes`, but I think it is valuable if `ExtractPropTypes` is allowed to make props with default values optional. | 2021-01-30T06:27:07 | 2021-01-30T06:27:07 | {} | MEMBER |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.