owner
stringclasses
14 values
repo
stringclasses
14 values
id
int64
116k
4.61B
issue_number
int32
1
181k
author
stringlengths
1
39
body
stringlengths
1
262k
created_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:16:18
updated_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:22:56
reactions
unknown
author_association
stringclasses
5 values
vuejs
core
814,737,465
3,552
posva
You need to key the `li`, not the `template`. You should get a warning in your IDE.
2021-04-07T08:59:30
2021-04-07T08:59:30
{}
MEMBER
vuejs
core
815,433,711
3,562
HcySunYang
Should be `queuePostFlushCb`: ```js import { queuePostFlushCb } from 'vue' ``` I don’t recommend this, but it seems to be the only workaround at the moment
2021-04-08T04:19:02
2021-04-08T04:19:02
{ "+1": 1 }
MEMBER
vuejs
core
815,425,048
3,562
HcySunYang
This is indeed a lack of the Composition API, but you can easily use the existing API to make workarounds: ```js import { queueJob } from 'vue' const Comp = { setup() { const instance = getCurrentInstance() const $forceUpdate = () => queueJob(instance.update) } } ``` Maybe we need an impleme...
2021-04-08T03:50:10
2021-04-08T07:52:28
{ "+1": 9 }
MEMBER
vuejs
core
816,478,619
3,562
posva
I think we should avoid exposing a low level utility like `forceUpdate()` in such a visible place like the context. I personally think we should document this rather than add `useForceUpdate()` because it shouldn't be used most of the time and people should search for this method and inform themselves of what it is int...
2021-04-09T07:31:46
2021-04-09T07:31:46
{ "+1": 4 }
MEMBER
vuejs
core
816,552,200
3,573
HcySunYang
This PR is best to cooperate with https://github.com/vuejs/vue-next/pull/3554
2021-04-09T09:27:39
2021-04-09T09:27:39
{}
MEMBER
vuejs
core
817,078,872
3,580
mannok
Thanks @edison1105, but I think it is not only related to template ref. The case is that "mutations' sideEffect inside `onBeforeUpdate` delayed for 1 tick". No matter the case is `ref` or not, mutations in `onBeforeUpdate` delayed. Is this by design? Please take the following code to test. ``` <template> <labe...
2021-04-10T05:01:24
2021-04-10T05:09:46
{}
NONE
vuejs
core
817,084,883
3,580
edison1105
I want to say that it has something to do with the execution timing of the `watch` - flush: 'pre': this is the default, in the scheduler and the effect will be called synchronously before the component mount. - flush: 'sync': out of the scheduler and the effect will be called synchronously - flush: 'post': in the ...
2021-04-10T05:59:58
2021-04-10T05:59:58
{}
MEMBER
vuejs
core
817,601,715
3,588
LinusBorg
You have a ciruclar dependency between two ES module imports. Here's workarounds from the Vue 2 docs, that appy similarly to Vue 3: https://vuejs.org/v2/guide/components-edge-cases.html#Circular-References-Between-Components Thew noteworthy difference is that for the dynamic import variant of the solution you hav...
2021-04-12T08:25:43
2021-04-12T09:47:47
{ "heart": 1 }
MEMBER
vuejs
core
817,776,540
3,590
LinusBorg
On second though, we might want to consider making this more robust in Vue core. I'll reopen for further evalution.
2021-04-12T12:39:51
2021-04-12T12:39:51
{}
MEMBER
vuejs
core
817,966,280
3,591
LinusBorg
you don't. If you want to render components outside of the app's context, create a new app and register the necessary components "globally" in that app, or locally in the MsgBox - that's your own responsibility now. A more idiomatic approach would be to actually render your `<MSgBox>`component(s) in App.vue and have...
2021-04-12T16:51:02
2021-04-12T16:51:20
{}
MEMBER
vuejs
core
818,297,938
3,588
Guervyl
Thanks for your quick answer and resolving my problem. Your example returned an error. The correct way is: ``` components: { TreeFolderContents: defineAsyncComponent(() => import("./tree-folder-contents.vue")) } ```
2021-04-12T23:02:06
2021-04-12T23:02:06
{ "heart": 1 }
NONE
vuejs
core
815,426,192
3,562
mannok
> This is indeed a lack of the Composition API, but you can easily use the existing API to make workarounds: > > ```js > import { queueJob } from 'vue' > > const Comp = { > setup() { > const instance = getCurrentInstance() > const $forceUpdate = () => queueJob(i.update) > } > } > ``` > > May...
2021-04-08T03:54:15
2021-04-08T03:54:15
{}
NONE
vuejs
core
816,445,945
3,571
HcySunYang
@johnsoncodehk you need to specify the `lang` attribute? ```js <script setup lang="ts"> enum Foo { bar } </script> ```
2021-04-09T06:31:57
2021-04-09T06:31:57
{}
MEMBER
vuejs
core
817,073,272
3,561
yyx990803
Closing as expected behavior.
2021-04-10T03:58:54
2021-04-10T03:58:54
{}
MEMBER
vuejs
core
817,160,827
3,585
07akioni
> need `required:true` option ? In runtime it can't be `undefined` or just not in the keys, so I think `required: true` is just a workaround. Also it may cause runtime warning. ![image](https://user-images.githubusercontent.com/18677354/114277174-ade3fa80-9a5c-11eb-8424-7b8f082a38cb.png)
2021-04-10T16:16:14
2021-04-10T16:27:26
{}
CONTRIBUTOR
vuejs
core
817,440,996
3,587
HcySunYang
According to the reproduction you gave, this is expected behavior. When `Module`'s constructor is executed, everything is not reactive, so you bind the original instance of `ModuleChild` as the context object instead of the reactive version of ModuleChild's instance. This is why the execution of `setNewItemMediatorProb...
2021-04-12T02:44:21
2021-04-12T02:44:21
{}
MEMBER
vuejs
core
817,461,974
3,573
HcySunYang
Move this to #3554
2021-04-12T04:01:12
2021-04-12T04:01:12
{}
MEMBER
vuejs
core
814,756,972
3,550
posva
Thanks for the PR but please don't duplicate issues and PRs
2021-04-07T09:22:22
2021-04-07T09:22:22
{}
MEMBER
vuejs
core
814,888,152
3,557
posva
Please open the bug in Quasar first or open a bug report here without Quasar.
2021-04-07T12:51:47
2021-04-07T12:51:47
{}
MEMBER
vuejs
core
817,100,304
3,583
johnsoncodehk
Duplicate of #3238
2021-04-10T08:28:28
2021-04-10T08:28:28
{}
MEMBER
vuejs
core
814,692,083
3,551
HcySunYang
Please submit the issue in the correct repo (vitepress or element-plus). Writing in English will allow more people to help you. Also, you can ask questions on the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.com/tags/vue.js) first.
2021-04-07T07:55:07
2021-04-07T07:55:24
{}
MEMBER
vuejs
core
815,439,734
3,562
HcySunYang
The `queueJob` will put the update task in the async queue, and can de-duplicate the update task
2021-04-08T04:38:15
2021-04-08T04:38:15
{}
MEMBER
vuejs
core
816,661,210
3,561
recovery-alt
I've already known what the exact problem is. Thanks.
2021-04-09T12:54:27
2021-04-09T12:54:27
{}
NONE
vuejs
core
817,189,843
3,562
mannok
@yyx990803 I used to develop geographical map with ([ArcGIS JSAPI](https://developers.arcgis.com/javascript/latest/)) and using Vue as my web framework. ArcGIS JSAPI has its own reactive system and seems to be implemented by getter/setter (like Vue2). However, I should avoid Vue3 to make it as `reactive` so that I alwa...
2021-04-10T19:16:49
2021-04-10T19:16:49
{}
NONE
vuejs
core
817,239,895
3,585
edison1105
`defualt` => `default` your spelling is incorrect.
2021-04-11T03:14:19
2021-04-11T04:37:32
{}
MEMBER
vuejs
core
818,387,729
3,327
HcySunYang
Closed due to the info given by @LinusBorg
2021-04-13T02:36:21
2021-04-13T02:36:21
{}
MEMBER
vuejs
core
815,435,144
3,562
mannok
@HcySunYang May I know what is the difference between `queuePostFlushCb ` and `nextTick`? Also, why should I put the update function inside `queuePostFlushCb `? Can I call `instance.update()` instead? Thanks in advance.
2021-04-08T04:23:20
2021-04-08T04:23:20
{}
NONE
vuejs
core
816,524,756
3,576
ota-meshi
Hi @edison1105. That issue looked to me like `<input :size="0">` issue. This issue is `<input :size="null">` issue. How do I remove the size attribute?
2021-04-09T08:42:27
2021-04-09T08:42:59
{}
MEMBER
vuejs
core
817,116,297
3,580
edison1105
this is expected. because `:ref="(el) => (divs[i] = el)"` will be called 4 times in `setRef` during `patch`. In other words, the watch callback will be called synchronously 4 times. and if change to this: ```javascript watch( () => vm.divs.length, (to) => { console.log(`there are ${to} div`); }, {flu...
2021-04-10T10:46:51
2021-04-10T11:56:52
{}
MEMBER
vuejs
core
817,133,207
3,580
edison1105
they are different. executing `vm.divs.push('a');` in the console will trigger the update logic of the component. before start update the component, the `flushPreFlushCbs` will be executed, and the jobs in the queue will be deduplicated. So only `there are 8 div` is output. If you are interested, you can add a breakp...
2021-04-10T13:01:11
2021-04-10T13:03:47
{}
MEMBER
vuejs
core
817,156,496
3,585
edison1105
need `required:true` option ?
2021-04-10T15:46:30
2021-04-10T15:46:30
{}
MEMBER
vuejs
core
818,392,515
2,246
HcySunYang
This issue has been fixed in the latest version
2021-04-13T02:50:50
2021-04-13T02:50:50
{}
MEMBER
vuejs
core
815,440,706
3,562
mannok
Thanks @HcySunYang
2021-04-08T04:41:25
2021-04-08T04:41:25
{}
NONE
vuejs
core
815,597,737
3,562
LinusBorg
FWIW, I think it's still worthwhile to provide a bette way to force an update than to go through the internal component instance. We do want people to rely on this as little as possible, which is also why we don't document anything about it's APIs - it's considered internal and more of an escape hatch for lib autho...
2021-04-08T09:14:45
2021-04-08T09:15:43
{}
MEMBER
vuejs
core
816,456,244
3,571
johnsoncodehk
@HcySunYang Yes we need it and I'm updated, thanks.
2021-04-09T06:52:28
2021-04-09T07:20:06
{}
MEMBER
vuejs
core
816,537,041
3,576
posva
maybe we should remove the `size` attribute if it's set to `null` (like with other attributes). You should also be able to use an object with `v-bind` and remove the size property from that object
2021-04-09T09:02:48
2021-04-09T09:03:22
{ "+1": 2 }
MEMBER
vuejs
core
817,103,067
3,581
edison1105
Oh~~ I did see @HcySunYang 's PR.
2021-04-10T08:51:30
2021-04-10T08:51:30
{}
MEMBER
vuejs
core
817,775,588
3,590
LinusBorg
https://github.com/vuejs/vue-cli/pull/6400 Will be fixed in the next version of the mocha vue cli plugin.
2021-04-12T12:38:23
2021-04-12T12:38:23
{}
MEMBER
vuejs
core
818,397,153
1,532
HcySunYang
Closed, track this in https://github.com/vuejs/rfcs/pull/212
2021-04-13T03:06:22
2021-04-13T03:06:22
{}
MEMBER
vuejs
core
774,679,524
2,625
posva
You still haven't explained with a proper use case what can't be done currently and **requires** the exposing of an internal variable to do so.
2021-02-07T14:03:31
2021-02-07T14:03:31
{}
MEMBER
vuejs
core
774,684,011
3,153
HcySunYang
I close this one because it cannot be reproduced and is not active. If there is still a problem, you can open another issue
2021-02-07T14:34:00
2021-02-07T14:34:00
{}
MEMBER
vuejs
core
774,840,928
3,189
HcySunYang
Are you sure the code you provided can reproduce the problem? I still can’t reproduce it using the demo you provided. I get the same result in `dev/prod` mode.
2021-02-08T03:28:15
2021-02-08T03:28:15
{}
MEMBER
vuejs
core
774,846,407
3,187
HcySunYang
You should submit the issue to Vite, `@vite/plugin-vue` injects modules into ssr context by wrapping user setup, see https://github.com/vitejs/vite/blob/main/packages/plugin-vue/src/main.ts#L133. I think the `@vite/plugin-vue-jsx` needs to do the same thing.
2021-02-08T03:48:35
2021-02-08T03:48:35
{ "+1": 1 }
MEMBER
vuejs
core
778,004,864
3,225
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.33 KB (0%) |
2021-02-12T06:26:57
2021-02-12T06:26:57
{}
NONE
vuejs
core
774,800,569
3,188
posva
Note you should be using `flush: 'post'` in your watcher (https://v3.vuejs.org/guide/reactivity-computed-watchers.html#effect-flush-timing) which makes the thing consistently fail
2021-02-08T00:39:03
2021-02-08T00:39:03
{}
MEMBER
vuejs
core
775,731,158
3,199
knerok
And we did not have this problem with vue 2
2021-02-09T07:25:03
2021-02-09T07:25:03
{}
NONE
vuejs
core
776,471,133
3,212
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.33 KB (0%) |
2021-02-10T06:11:57
2021-02-10T06:11:57
{}
NONE
vuejs
core
778,004,035
3,167
dependabot-preview[bot]
Superseded by #3225.
2021-02-12T06:24:48
2021-02-12T06:24:48
{}
CONTRIBUTOR
vuejs
core
775,641,043
3,201
HcySunYang
This is intentional, see https://github.com/vuejs/vue-next/commit/8084156f4d0b572716a685a561d5087cddceab2c
2021-02-09T03:51:17
2021-02-09T03:51:17
{}
MEMBER
vuejs
core
775,696,710
3,204
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.32 KB (0%) |
2021-02-09T06:12:20
2021-02-09T06:12:20
{}
NONE
vuejs
core
775,728,201
3,189
huxianc
I cloned from my git repository, `yarn` and `yarn build` ,eveything was normal. Then I deleted `node_modules` in my local file, `yarn` and `yarn build`,got the same result. I should have checked more,sorry for opened this issue.
2021-02-09T07:18:54
2021-02-09T07:18:54
{}
NONE
vuejs
core
775,730,478
3,199
knerok
@HcySunYang Thank you! But unfortunately we need described behavoure. We have pretty big app with tons of legacy code, so then we mount vue into our main wrapper, it breaks all `<select multiple >` everywhere in the legacy part
2021-02-09T07:23:35
2021-02-10T07:34:12
{}
NONE
vuejs
core
777,439,188
3,220
posva
You shouldn't be using those functions manually. In general, if it doesn't appear in the documentation, you should avoid it
2021-02-11T13:01:18
2021-02-11T13:01:18
{}
MEMBER
vuejs
core
778,004,759
3,226
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.33 KB (0%) |
2021-02-12T06:26:39
2021-02-12T06:26:39
{}
NONE
vuejs
core
778,617,793
3,229
wvffle
Then what in case I have a component that has two `v-model`s but sometimes I only care about one value? If I don't pass the second `v-model`, the component wouldn't work internally. And creating a data value for every value I don't care of every instance of this component seems like a big overhead to me.
2021-02-13T13:15:54
2021-02-13T13:16:37
{}
NONE
vuejs
core
778,776,389
2,764
HcySunYang
This make https://github.com/vuejs/vue-next/issues/2583 happen again.
2021-02-14T13:14:26
2021-02-14T13:14:26
{}
MEMBER
vuejs
core
778,985,201
3,166
dependabot-preview[bot]
Superseded by #3234.
2021-02-15T06:36:39
2021-02-15T06:36:39
{}
CONTRIBUTOR
vuejs
core
775,353,339
1,600
hawkeye64
I have the exact same issue trying to upgrade to Vue 3 a component of mine that that does inline markdown. Because I can't get at the carriage returns the markdown can't work properly.
2021-02-08T18:33:05
2021-02-08T18:33:05
{}
NONE
vuejs
core
776,393,962
3,183
zhenzhenChange
see - https://github.com/vitejs/vite/issues/731 - https://github.com/evanw/esbuild/issues/341#issuecomment-678661170 - https://github.com/evanw/esbuild/issues/314#issuecomment-668401819
2021-02-10T02:28:39
2021-02-10T02:28:56
{}
NONE
vuejs
core
777,224,805
3,194
dependabot-preview[bot]
Superseded by #3221.
2021-02-11T06:12:34
2021-02-11T06:12:34
{}
CONTRIBUTOR
vuejs
core
777,711,378
2,613
LeBenLeBen
It works with an array of slots instead of an object if you use the default slot only.
2021-02-11T18:52:15
2021-02-11T18:52:15
{}
NONE
vuejs
core
774,680,067
2,975
posva
I'm not sure we should allow injecting numerical keys because they are very likely to collision and hard to debug. So overall a bad practice that is better not to be supported. Like you said, the `number` was added to `inject` to make it pass typings but I wonder if we shouldn't even remove that instead
2021-02-07T14:07:20
2021-02-07T14:07:20
{}
MEMBER
vuejs
core
774,713,926
3,170
posva
It was added at 38f2d23 for vue-router but at the end we can directly pass vnodes (result of `h()`) to `<copmonent :is="vnodes" />` so we don't need this api.
2021-02-07T17:27:58
2021-02-07T17:27:58
{}
MEMBER
vuejs
core
774,740,926
3,184
LinusBorg
For reference: This is the previous PR by @edison1105 that attempts to solve this problem as well: #2834 @yyx990803 your input here would be welcome as it's a very complex issue touching the scheduler internals.
2021-02-07T19:16:54
2021-02-07T19:16:54
{}
MEMBER
vuejs
core
774,855,027
2,732
HcySunYang
Re-review this, I think it is unreasonable.
2021-02-08T04:18:42
2021-02-08T04:18:42
{}
MEMBER
vuejs
core
775,695,770
3,146
dependabot-preview[bot]
Superseded by #3204.
2021-02-09T06:10:19
2021-02-09T06:10:19
{}
CONTRIBUTOR
vuejs
core
775,696,984
3,198
HcySunYang
Due to https://github.com/vuejs/vue-next/pull/3039
2021-02-09T06:12:57
2021-02-09T06:12:57
{}
MEMBER
vuejs
core
775,716,813
3,077
HcySunYang
I voted to support the `default` value must obey the restriction of the `type` field, thus the type of props is always determined by the type field, and the `default` field is only used to give a default value for that type, which can avoid accidentally giving wrong default values.
2021-02-09T06:55:50
2021-02-09T06:55:50
{ "+1": 8 }
MEMBER
vuejs
core
776,687,055
3,006
HcySunYang
see comments in code for more details
2021-02-10T12:55:03
2021-02-10T12:55:03
{}
MEMBER
vuejs
core
778,468,657
3,220
jsbroks
@posva How would you suggest rendering a component to an HTML element? (use case is for golden layout)
2021-02-12T21:37:21
2021-02-12T21:37:21
{ "+1": 2 }
NONE
vuejs
core
778,588,538
3,157
LinusBorg
@HcySunYang There's an older PR #2870 which changes the behavior of `remove()` which you now don't use anymore in favor of `unmount()`. Does this change solve the issue of #2870 as well? Do you see any conflict?
2021-02-13T09:16:33
2021-02-13T09:16:33
{}
MEMBER
vuejs
core
775,400,905
3,070
tabjy
Sorry I've been a bit busy recently. > I've taken some parts of #2902 to make it work like a lifecycle hook. Do we merge this PR into @tabjy's PR to give him credits? That sounds like a lot of work. Alternatively, maybe you can [add me as a co-author](https://docs.github.com/en/github/committing-changes-to-your-...
2021-02-08T19:52:08
2021-02-08T19:52:08
{ "+1": 1 }
NONE
vuejs
core
775,401,537
2,902
tabjy
Note: this pr is obsoleted by #3070. It will be closed once #3070 is merged.
2021-02-08T19:53:11
2021-02-08T19:53:11
{}
NONE
vuejs
core
775,509,935
2,064
tomhrtly
@kris-ellery I'm having the same issue as you, any chance you've managed to find a fix?
2021-02-08T22:36:20
2021-02-08T22:36:20
{}
NONE
vuejs
core
776,275,785
2,386
rstoenescu
This can also be reproduced by compiling a simple template (for SSR): ```html <div> <img src="./logo.png"> <img src="./logo.png"> </div> ``` ``` SyntaxError: /Users/Razvan/work/test/v2/src/pages/Index.vue: Identifier '_imports_0' has already been declared (4:7) 2 | import { ssrRenderComponent as _s...
2021-02-09T22:05:49
2021-02-09T22:06:41
{}
NONE
vuejs
core
777,683,969
2,781
songololo
The same issue is happening with latex markdown plugins for `vitepress`. See: https://github.com/vuejs/vitepress/issues/229
2021-02-11T18:05:30
2021-02-11T18:05:30
{}
NONE
vuejs
core
777,694,269
2,781
songololo
For others running into the same issues when using markdown with latex: it appears that the original poster found a workaround per the above [linked blog](https://github.com/Maorey/Blog/blob/ac5ced6deb3bbec689c672ec425640a0fba598f3/docs/.vitepress/config.js#L51)
2021-02-11T18:22:33
2021-02-11T18:22:33
{}
NONE
vuejs
core
774,892,292
2,625
yangmingshan
@posva I appreciate your help, but I really try my best 😅, if you still don't get it, maybe we can ask another one to review this PR?
2021-02-08T06:01:46
2021-02-08T06:01:46
{}
CONTRIBUTOR
vuejs
core
778,587,688
3,066
LinusBorg
@HcySunYang Can you have another look here? seems your requested changes were adressed`
2021-02-13T09:08:56
2021-02-13T09:08:56
{}
MEMBER
vuejs
core
778,985,596
3,232
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.33 KB (0%) |
2021-02-15T06:37:23
2021-02-15T06:37:23
{}
NONE
vuejs
core
774,808,349
3,189
huxianc
dev mode: ![dev](https://user-images.githubusercontent.com/47603705/107165462-f3992e00-69ed-11eb-81e4-cba7ae7df137.jpg) production mode: ![production](https://user-images.githubusercontent.com/47603705/107165503-1f1c1880-69ee-11eb-9379-c9bd7c3c7b78.jpg)
2021-02-08T01:15:29
2021-02-08T01:15:29
{}
NONE
vuejs
core
774,889,845
2,625
yangmingshan
Thinking in this way, `@vue/reactivity` is a library can be used standalone, I'm using it to build a mini fork Vue for real word use case in China. `_shallow` is internal for `Vue` not `@vue/reactivity`, it should be public for `@vue/reactivity`, because `@vue/runtime-core` is using it. And in my mini fork Vue's runtim...
2021-02-08T05:56:50
2021-02-08T05:56:50
{}
CONTRIBUTOR
vuejs
core
774,911,706
3,193
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.32 KB (0%) |
2021-02-08T06:42:30
2021-02-08T06:42:30
{}
NONE
vuejs
core
775,184,229
3,039
HcySunYang
I did some exploration https://github.com/vuejs/vue-next/pull/3198
2021-02-08T14:22:54
2021-02-08T14:22:54
{}
MEMBER
vuejs
core
775,696,845
3,039
HcySunYang
@07akioni Great, I will close my PR
2021-02-09T06:12:40
2021-02-09T06:12:40
{}
MEMBER
vuejs
core
775,856,284
2,982
HcySunYang
Thanks to your PR, but see this https://github.com/vuejs/vue-next/pull/3184
2021-02-09T11:00:22
2021-02-09T11:00:22
{}
MEMBER
vuejs
core
776,470,997
3,213
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.33 KB (0%) |
2021-02-10T06:11:41
2021-02-10T06:11:41
{}
NONE
vuejs
core
777,225,466
3,221
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.33 KB (0%) |
2021-02-11T06:14:42
2021-02-11T06:14:42
{}
NONE
vuejs
core
778,574,072
3,224
KaelWD
It's a component passed in to a function from the user. The `DefineComponent` type mangles required prop types by passing them through `ExtractPropTypes` again. `Component` uses `ComponentPublicInstanceConstructor` which isn't exported. I basically need `FunctionalComponent<Props> | ComponentPublicInstanceConstructor<P...
2021-02-13T06:58:51
2021-02-13T07:00:46
{}
CONTRIBUTOR
vuejs
core
778,650,178
2,764
LinusBorg
@posva Think this is ready?
2021-02-13T17:32:22
2021-02-13T17:32:22
{}
MEMBER
vuejs
core
778,948,149
2,764
HcySunYang
You can try this in your local with your PR https://codepen.io/hcysunyang/pen/YzpZyQW I found a better way https://github.com/vuejs/vue-next/pull/3230
2021-02-15T05:21:45
2021-02-15T05:24:42
{}
MEMBER
vuejs
core
774,681,198
3,132
posva
@JonasKruckenberg In this scenario, a more reliable test would be testing the output html rather than the AST to ensure there is only one space. For instance, having the snapshot completely overlooked the problem you reported. So I think a nonregression test case inside of vue's index.spec.ts file would help avoiding i...
2021-02-07T14:14:55
2021-02-07T14:14:55
{}
MEMBER
vuejs
core
774,902,795
3,071
HcySunYang
```html <Comp> <tempplate v-slot /> </Comp> ``` In the above case, the directive(`v-slot`)'s arg is `undefined`, so the `slotName` will be `undefined`. So we can't remove the `default` assignment.
2021-02-08T06:24:18
2021-02-08T06:24:18
{}
MEMBER
vuejs
core
777,070,941
3,188
gaborfeher
@HcySunYang I've pulled your branch into my project and it seems to be fixing my original issue.
2021-02-10T22:12:54
2021-02-10T22:12:54
{}
NONE
vuejs
core
778,030,083
3,224
HcySunYang
Why not use `defineComponent`?
2021-02-12T07:30:44
2021-02-12T07:30:44
{}
MEMBER
vuejs
core
778,595,163
3,066
HcySunYang
@LinusBorg I'm not sure if [this](https://github.com/vuejs/vue-next/pull/3066/files#diff-59e3ee98b310f26c42283eaed3c0d4b53eee884d097d9fa89b7e1b546453b411R184) is really reasonable, even if it works correctly.
2021-02-13T10:17:13
2021-02-13T10:17:13
{}
MEMBER
vuejs
core
774,809,196
3,190
posva
Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.com/tags/vue.js).
2021-02-08T01:18:57
2021-02-08T01:18:57
{}
MEMBER
vuejs
core
774,910,966
3,168
dependabot-preview[bot]
Superseded by #3194.
2021-02-08T06:41:09
2021-02-08T06:41:09
{}
CONTRIBUTOR
vuejs
core
774,923,309
3,195
dependabot-preview[bot]
One of your CI runs failed on this pull request, so Dependabot won't merge it. - [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/12171?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) Dependabot will still automatically merge this pull request if you amend it and your tes...
2021-02-08T07:05:10
2021-02-08T07:05:10
{}
CONTRIBUTOR
vuejs
core
775,671,266
3,039
07akioni
I've done some simplification from #3198. (And as mentioned in 3198 prettier doesn't work due to template literal.) Thanks to @HcySunYang 's idea.
2021-02-09T05:18:24
2021-02-09T05:18:24
{}
CONTRIBUTOR