owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 730,378,657 | 892 | saddam1234567 | "export 'inject' was not found in 'vue' | 2020-11-19T13:36:25 | 2020-11-19T13:36:25 | {} | NONE |
vuejs | core | 730,826,588 | 1,473 | Cosen95 | I also encountered the same problem. What is the specific reason for this error?
| 2020-11-20T03:46:11 | 2020-11-20T03:46:11 | {
"+1": 1
} | NONE |
vuejs | core | 731,053,147 | 2,649 | edison1105 | I am also working on #2642.😭
I read this [postcss8 migration article](https://evilmartians.com/chronicles/postcss-8-plugin-migration).
should we move PostCSS 8 to `peerDependencies` and set `module.exports.postcss = true` ?
| 2020-11-20T09:27:18 | 2020-11-20T09:27:18 | {
"+1": 1
} | MEMBER |
vuejs | core | 726,679,161 | 2,599 | jods4 | Follow-up on that issue from my real project:
It was indeed just a typo in `emits` that I did not notice.
TS was not kicking in because if you don't declare any `emits` at all, then `emit()` is typed to accept any string, so it worked. I believe there is no runtime warning for the same reason.
eslint-vue-plugin ... | 2020-11-13T10:18:00 | 2020-11-13T10:18:00 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 726,868,403 | 2,602 | ferencbeutel4711 | Hi, thanks for your swift response. I am not sure if I understand the context of your linked PR & issue, but to me it sounds like only useful in a situation where I am using the parse() function of vue/compiler-core. In my scenario, I am creating a new instance of a vue component inside of a sfc file. In vue2, the comm... | 2020-11-13T16:42:46 | 2020-11-13T16:43:32 | {} | NONE |
vuejs | core | 727,238,740 | 2,598 | LinusBorg | > From what I read, the main argument against filters is that they may create instable loops when a value changes between reading and writing it.
@jods4 That's not really the reason I am aware of. What little value the one-way filters that we had them in Vue 2 added did not justify the compiler-problems that this c... | 2020-11-14T17:25:25 | 2020-11-14T17:25:25 | {} | MEMBER |
vuejs | core | 727,706,978 | 1,553 | caohuatao | ```vue
<FlowNode
key={node.id}
node={node}
onMessage={message}
v-slots={ {default: slots.default}}
/>
```
```shell
Error:(103, 11) TS2322: Type '{ key: string | number; node: NodeItem; onMessage: () => void; "v-slots": { default: Slot | undefined; }; }' is not assignable to type 'IntrinsicAttri... | 2020-11-16T03:02:32 | 2020-11-16T07:17:55 | {} | NONE |
vuejs | core | 729,456,598 | 2,631 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.39 KB (0%) |
| runtime-dom.global.prod.js | 26.5 KB (0%) |
| size-check.global.prod.js | 16.08 KB (0%) | | 2020-11-18T06:15:57 | 2020-11-18T06:15:57 | {} | NONE |
vuejs | core | 729,502,721 | 2,625 | posva | You are only saying it _I need it so I can omit a ts-expect-error in my own code_ but you should explain why accessing this internal property is necessary and why you can't do otherwise | 2020-11-18T07:52:27 | 2020-11-18T07:52:35 | {} | MEMBER |
vuejs | core | 729,649,555 | 2,632 | luwuer | I thought about this PR when I was having dinner, i find that this is not a good solution because of below:
1. Increased pack(compiled) size, lots of redundant code.
2. No consistent experience when expression is not instance member, such as inline or function.
- `@blur="test(123, $event)"`
- `@blur="() => ... | 2020-11-18T12:36:08 | 2020-11-19T01:01:19 | {} | CONTRIBUTOR |
vuejs | core | 730,629,667 | 2,515 | gearboxdesign | Watching this one keenly, for a project I am conducting we have no choice but to compile some templates on the fly. I'm aware there was an entire re-write between Vue 2 and Vue 3 but using the equivalent version of Vue does not drag in the entire babel parser library so I'm hopeful a resolution can be found for Vue 3..... | 2020-11-19T20:50:47 | 2020-11-20T07:28:59 | {} | NONE |
vuejs | core | 726,323,579 | 2,571 | mischnic | One solution would be adding `typeof process !== "undefined"` when the env variables are checked. | 2020-11-12T20:28:25 | 2020-11-12T20:28:25 | {} | NONE |
vuejs | core | 726,328,856 | 2,596 | LinusBorg | I can't run your code right now, but presumably, you have a second copy of Vue bundled within the tests umd file. | 2020-11-12T20:38:19 | 2020-11-12T20:38:19 | {} | MEMBER |
vuejs | core | 726,372,302 | 2,599 | jods4 | @skirtles-code Thank you and that seems to fix the repro!
I'll check tomorrow in my real app if that was the issue after all.
Although if that is, I'm surprised everything was ok with TS and there was nothing on the console in dev mode. Are you not supposed to get some kind of warnings if you raise undeclared event... | 2020-11-12T22:14:50 | 2020-11-12T22:15:10 | {} | CONTRIBUTOR |
vuejs | core | 727,145,589 | 2,598 | stmtk1 | This behavior causes bug. But compatibility is important. So I suggest adding this feature request as a option. | 2020-11-14T04:59:26 | 2020-11-14T04:59:26 | {} | NONE |
vuejs | core | 729,949,228 | 2,623 | posva | You have to dispose the chart when the component is destroyed
```js
onUnmounted(() => {
myChart.dispose();
});
``` | 2020-11-18T20:57:44 | 2020-11-18T20:57:44 | {
"+1": 2,
"heart": 1
} | MEMBER |
vuejs | core | 730,285,607 | 2,220 | dev-itsheng | Hello, I realized a similar problem, and then tried to come to GitHub Issue to find a solution. I found it here, but it was not resolved. Finally, I figured out a way to solve this problem by myself, which is to customize the declaration file through the [module augmentation](https://www.typescriptlang.org/docs/handboo... | 2020-11-19T10:40:44 | 2020-11-19T10:40:44 | {
"+1": 5,
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 726,336,594 | 2,598 | skirtles-code | > That's where pipes shined, but they were removed from Vue 3.
I assume you're referring to filters. Anything you used to do with filters you should now be able to do with methods instead. See:
https://v3.vuejs.org/guide/migration/filters.html#migration-strategy
> Could you please tell me more about custom `v-... | 2020-11-12T20:53:49 | 2020-11-12T20:53:49 | {} | CONTRIBUTOR |
vuejs | core | 726,893,046 | 2,602 | ferencbeutel4711 | hi vhoyer, I have just tried that and sadly, it did not preserve my comments. ty for the input though | 2020-11-13T17:22:59 | 2020-11-13T17:22:59 | {
"+1": 1
} | NONE |
vuejs | core | 727,006,934 | 2,604 | dsonet | Do not think `toNumber `should return a value other than a number, it should be a number or NaN. | 2020-11-13T20:09:47 | 2020-11-13T20:09:47 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 727,766,714 | 2,545 | dependabot-preview[bot] | Superseded by #2617. | 2020-11-16T06:30:56 | 2020-11-16T06:30:56 | {} | CONTRIBUTOR |
vuejs | core | 728,964,789 | 2,621 | skirtles-code | Correct me if I'm wrong but doesn't this fix assume that `hasOwnProperty` is being read off the reactive object itself?
If someone did something equivalent to this:
```js
Object.prototype.hasOwnProperty.call(obj, 'a')
```
then the reactivity still wouldn't be tracked?
While it's unlikely that someone woul... | 2020-11-17T14:29:16 | 2020-11-17T14:29:16 | {} | CONTRIBUTOR |
vuejs | core | 729,212,437 | 2,625 | posva | you are not explaining why you need that... | 2020-11-17T21:03:42 | 2020-11-17T21:03:42 | {} | MEMBER |
vuejs | core | 729,948,976 | 2,626 | arpowers | @posva wouldn't be tough... would the warning exist in vue-router or vue? | 2020-11-18T20:57:12 | 2020-11-18T20:57:12 | {} | NONE |
vuejs | core | 731,012,456 | 2,648 | yassilah | PS: I don't know if it's necessary to add a test or even how I could test that, since the element is in fact added to the DOM, it is simply not being rendered. | 2020-11-20T08:08:54 | 2020-11-20T08:08:54 | {} | CONTRIBUTOR |
vuejs | core | 726,748,463 | 2,598 | leopiccionia | > They are not usable in (two-way) `v-model`, though and that's really where their power was lost.
In fact, Vue 2 supports filters only inside mustache expressions (`{{ ... }}`).
The last Vue version that supports filters inside `v-bind`, `v-model`, `v-for`, etc. was v1. As per [migration guide](https://vuejs.org/v2/... | 2020-11-13T12:53:43 | 2020-11-13T14:47:09 | {} | CONTRIBUTOR |
vuejs | core | 726,871,412 | 2,602 | vhoyer | try `<template comments>`, this is the syntax for vue 2, haven't really tried this with vue 3 | 2020-11-13T16:48:13 | 2020-11-13T16:48:13 | {} | NONE |
vuejs | core | 727,520,490 | 2,610 | edison1105 | > bug the vue3 do not support
but the vue3 do not support?
I don’t understand the point from your reproduction link, but `$forceUpdate` is also supported in Vue3.
| 2020-11-15T05:58:35 | 2020-11-15T05:58:35 | {} | MEMBER |
vuejs | core | 727,800,043 | 2,605 | luwuer | It seems like there has no non-null assetions when compiling `v-on` directive. | 2020-11-16T07:47:05 | 2020-11-16T07:47:36 | {} | CONTRIBUTOR |
vuejs | core | 727,898,076 | 2,345 | basvanmeurs | Hi @jods4
Thanks for your review and feedback!
I also realized the importance of improving the performance on this, as in my own app I found that too much time was spent in triggering and tracking stuff.
Let me first respond to your first idea (effect ids).
> During a run, the dependency tracking logic is ... | 2020-11-16T10:46:08 | 2020-11-16T11:28:07 | {
"+1": 7
} | CONTRIBUTOR |
vuejs | core | 728,646,619 | 2,618 | HcySunYang | I think it is the same as this issue: https://github.com/vuejs/vue-next/issues/2564 | 2020-11-17T02:31:54 | 2020-11-17T02:31:54 | {
"+1": 1
} | MEMBER |
vuejs | core | 731,068,890 | 2,649 | lstoeferle | @edison1105 It seems like moving to peerDependencies does not work properly. I'll move it back to devDependencies later while keeping the `module.exports.postcss = true` | 2020-11-20T09:57:12 | 2020-11-20T09:57:33 | {} | NONE |
vuejs | core | 726,390,001 | 2,598 | jods4 | @skirtles-code Thanks for the pointers, much appreciated!
> I assume you're referring to filters. Anything you used to do with filters you should now be able to do with methods instead.
Yes, I'm referring to filters. Sorry for the confusion, they are called pipes in Angular; Value Converters in Aurelia.
Functi... | 2020-11-12T22:52:18 | 2020-11-12T22:52:18 | {} | CONTRIBUTOR |
vuejs | core | 726,519,439 | 2,600 | KaelWD | https://github.com/vuejs/vue-next/issues/2108#issuecomment-691655133
https://github.com/vuejs/vue-next/issues/2423#issuecomment-712171182 | 2020-11-13T05:14:20 | 2020-11-13T05:14:20 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 729,237,131 | 2,626 | arpowers | Note in the example that `router.ready()` is awaited at which point all async components should be resolved. | 2020-11-17T21:54:41 | 2020-11-17T21:54:41 | {} | NONE |
vuejs | core | 729,336,521 | 2,625 | yangmingshan | @posva I think I did, but never mind. I use `@vue/reactivity` to build my own `watch`, so I need `_shallow` type, check the link above ([Vue Mini](https://github.com/vue-mini/vue-mini) is library base on Vue 3 for [mini program](https://developers.weixin.qq.com/miniprogram/dev/framework)). | 2020-11-18T02:31:15 | 2020-11-18T02:31:15 | {} | CONTRIBUTOR |
vuejs | core | 729,456,047 | 2,629 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.39 KB (0%) |
| runtime-dom.global.prod.js | 26.5 KB (0%) |
| size-check.global.prod.js | 16.08 KB (0%) | | 2020-11-18T06:14:31 | 2020-11-18T06:14:31 | {} | NONE |
vuejs | core | 729,972,722 | 2,608 | posva | The template compiler [does give you an error](https://vue-next-template-explorer.netlify.app/#%7B%22src%22%3A%22%3Cdiv%20id%3D%5C%22app%5C%22%3E%5Cn%20%20%20%20%20%20%3Cheader%3E%5Cn%20%20%20%20%20%20%20%20%3Csvg%20xmlns%3D%5C%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%5C%22%20xmlns%3Axlink%3D%5C%22http%3A%2F%2Fwww.w3.org... | 2020-11-18T21:39:22 | 2020-11-18T21:39:22 | {} | MEMBER |
vuejs | core | 730,000,457 | 2,608 | jakedohm | @posva so you're saying the **correct** behavior in Vue 3 is for this to error, in production, and the template will fail to compile? This seems like it's going to cause _lots_ of problems for Vue 2 users who are migrating... in Vue 2 the behavior was to just ignore the script/style not to fail the template compilation... | 2020-11-18T22:35:16 | 2020-11-18T22:35:16 | {} | NONE |
vuejs | core | 890,415,607 | 4,220 | posva | This is already described in the docs. If you have suggestions, open a PR ain't he docs repo.
You can find the full explanation in the RFC if you want to understand why but it is not necessary in order to use them
The change you are proposing would forbid adding a property named value in a reactive object | 2021-07-31T23:17:16 | 2021-07-31T23:17:16 | {} | MEMBER |
vuejs | core | 891,128,098 | 4,220 | posva | https://v3.vuejs.org/guide/composition-api-introduction.html. You can find the RFC in the rfcs repo | 2021-08-02T15:41:13 | 2021-08-02T15:41:13 | {} | MEMBER |
vuejs | core | 894,587,038 | 4,270 | yyx990803 | 👍 | 2021-08-07T01:44:52 | 2021-08-07T01:44:52 | {} | MEMBER |
vuejs | core | 891,002,301 | 4,225 | yyx990803 | @dependabot ignore this dependency | 2021-08-02T12:56:21 | 2021-08-02T12:56:21 | {} | MEMBER |
vuejs | core | 892,207,802 | 4,243 | Cherry | I tried something like that as per [example 2](https://github.com/Cherry/workers-vue-ssr-example#via-transformstream), and https://github.com/Cherry/workers-vue-ssr-example/blob/c195fea2404e4cfd3b02c763ab483877ae1f185e/src/index.mjs#L23-L29. Is this not the correct way to do this?
| 2021-08-03T22:28:26 | 2021-08-03T22:31:15 | {} | CONTRIBUTOR |
vuejs | core | 893,281,049 | 3,414 | hezhongfeng | Is there any progress? | 2021-08-05T08:45:50 | 2021-08-05T08:45:50 | {} | NONE |
vuejs | core | 893,730,552 | 4,255 | lidlanca | I understand your rational, having dynamic size memo should be considered experimental, we might not be able to predict its impact without some more community feedback.
we don't have to support this use case officially until further feedback, in the meantime there are plenty of ways
to introduce dynamic array to ... | 2021-08-05T19:35:40 | 2021-08-05T19:35:40 | {} | CONTRIBUTOR |
vuejs | core | 893,755,352 | 4,260 | LinusBorg | Your problem is with bootstrap-vue-3. have a look at it in your node_modules folder. it has its own node_modules subfolder, containing Vue 3.1.5
The reason for this is, as far as I can tell, that this package declares Vue as a `dependency` (which should rather be an optional `peerDependency`) combined with the fact ... | 2021-08-05T19:54:46 | 2021-08-05T20:04:30 | {} | MEMBER |
vuejs | core | 893,873,279 | 4,262 | lidlanca | in the example the `count` increment is what triggers the component update.
forcing the reevaluation of the memo to check if the value changes since last render
https://github.com/vuejs/docs/blob/55505e758466a43e7e9c6e406dc2be4632604f71/src/api/directives.md#v-memo-
> Memoize a sub-tree of the template. Can b... | 2021-08-05T22:59:18 | 2021-08-05T22:59:18 | {} | CONTRIBUTOR |
vuejs | core | 890,040,148 | 4,212 | lidlanca | created a discussion in the rfc repo
https://github.com/vuejs/rfcs/discussions/366 | 2021-07-30T17:21:21 | 2021-07-30T17:21:21 | {} | CONTRIBUTOR |
vuejs | core | 890,594,224 | 4,224 | posva | Tested on a project and it doesn't fail. So it might be a problem with vue-dts-gen. Open an issue there or open a PR here with a failing test to fix (equivalent of reproduction) | 2021-08-01T22:07:36 | 2021-08-01T22:07:36 | {} | MEMBER |
vuejs | core | 890,753,731 | 4,236 | LinusBorg | This error is specific to the router, as it initialized asychronously, which leads to this error when unmounting synchronously.
There's no plugin lifecycle in Vue itself that could be responsible.
> I would love to see that the .unmount() would like force unmount the app
the router monkey-patches `app.unmou... | 2021-08-02T06:18:57 | 2021-08-02T06:21:58 | {
"+1": 1
} | MEMBER |
vuejs | core | 890,812,725 | 4,236 | posva | You already opened an issue in the router. Don't duplicate issues please | 2021-08-02T08:04:06 | 2021-08-02T08:04:06 | {} | MEMBER |
vuejs | core | 891,113,056 | 4,222 | Borrus-sudo | That is a good point that stuff can get out of date pretty fast. But I guess all that need to be done is to re run the vs code command to generate a new graph before every commit. But it is an interesting perspective for me to think how to automate the command firing before every commit.
Thank for the feedback.
Cheer... | 2021-08-02T15:19:45 | 2021-08-02T15:19:45 | {} | NONE |
vuejs | core | 893,077,719 | 4,244 | edison1105 | case by 68365b9b2bc2ccef93e88475c4f15e7cfb4f2497
works fine in v3.1.4
use a regular `ref` is works weird when patch. you'll notice that it doesn't patch in the order of the child nodes when you debugging
So I think if `dynamicChildren` is empty should not take the fast path.
![image](https://user-images.githubuse... | 2021-08-05T00:49:41 | 2021-08-05T00:57:16 | {} | MEMBER |
vuejs | core | 893,831,206 | 4,262 | posva | This is not correct usage:
- flip is not even reactive
- flip isn't used in the subtree where memo is placed
It's great you're playing around with the API and trying to report back bugs but as said in the PR, if you think memo could be used in other scenarios, described those scenarios first instead of showing abstra... | 2021-08-05T21:50:44 | 2021-08-05T21:50:44 | {} | MEMBER |
vuejs | core | 894,091,033 | 4,263 | posva | You are not supposed to add a property named `__v_isRef` to your object. It's also completely unrealistic use case | 2021-08-06T08:19:03 | 2021-08-06T08:19:03 | {} | MEMBER |
vuejs | core | 889,952,103 | 3,031 | dospunk | Yeah this would be really useful, its pretty frustrating to not be able to use inject, options API, and TypeScript together | 2021-07-30T15:01:43 | 2021-07-30T15:01:43 | {
"+1": 1
} | NONE |
vuejs | core | 890,373,425 | 4,211 | lidlanca | I agree, this change at the current state of markRaw() is "abusing" the skip flag, and for the most part doesn't solve for any useful use case. ( it would have been more useful if it actually unwrapped the ref and treated as raw value without effects)
but that use case from what I understand can be solved with... | 2021-07-31T16:41:13 | 2021-07-31T16:41:13 | {} | CONTRIBUTOR |
vuejs | core | 890,753,825 | 4,236 | LinusBorg | @posva agree? | 2021-08-02T06:19:05 | 2021-08-02T06:19:05 | {} | MEMBER |
vuejs | core | 892,654,596 | 4,245 | posva | I think we could generate the same code for custom and native events:
```js
onClick: _cache[0] || (_cache[0] = (...args) => ($data.foo.trigger && $data.foo.trigger(...args)))
``` | 2021-08-04T13:22:56 | 2021-08-04T13:22:56 | {} | MEMBER |
vuejs | core | 894,264,087 | 4,253 | lidlanca | it will be interesting to see if this also related to this root cause https://github.com/vuejs/vue-next/issues/4262
| 2021-08-06T13:33:48 | 2021-08-06T13:33:48 | {} | CONTRIBUTOR |
vuejs | core | 890,489,144 | 3,460 | ferdinando-ferreira | Thanks! | 2021-08-01T10:09:14 | 2021-08-01T10:09:14 | {} | NONE |
vuejs | core | 891,022,374 | 4,222 | yyx990803 | Thanks for the PR - it's an interesting project but I don't think we need a graph here. Also the import relationships may change anytime so it gets out of date pretty fast. | 2021-08-02T13:21:09 | 2021-08-02T13:21:09 | {} | MEMBER |
vuejs | core | 890,852,687 | 4,235 | lidlanca | RFC discussion https://github.com/vuejs/rfcs/discussions/367 | 2021-08-02T08:57:38 | 2021-08-02T08:57:38 | {} | CONTRIBUTOR |
vuejs | core | 890,908,604 | 2,280 | HuRuilin | When can the conflict be resolved and merged? This is a very practical way of writing, and it is also supported in vue2 | 2021-08-02T10:19:12 | 2021-08-02T10:19:12 | {} | NONE |
vuejs | core | 892,277,905 | 4,243 | lidlanca | This is very specific to cloudflare web workers and their non smooth integration with the polyfill
in my opinion if this is a common use case for cloudflare web workers, it should be documented somewhere
to save people some time, may be in the readme, or maybe in the v3 docs / guide.
or just this issue.
| 2021-08-04T01:02:44 | 2021-08-04T01:02:44 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 893,017,784 | 4,246 | sqal | oh good catch 😂 | 2021-08-04T22:31:44 | 2021-08-04T22:31:44 | {} | CONTRIBUTOR |
vuejs | core | 894,090,517 | 4,264 | posva | Thank you but `isRef` already works when it should | 2021-08-06T08:18:06 | 2021-08-06T08:18:06 | {} | MEMBER |
vuejs | core | 894,392,939 | 4,257 | yyx990803 | Sorry I didn't see this one when working on 865b84bf - this PR does cover a case I missed so I included the test case from this PR in 1994f120.
Note the compiler doesn't need to strip the TS syntax as that is the job of dedicated TS transpilers. | 2021-08-06T17:03:22 | 2021-08-06T17:03:22 | {} | MEMBER |
vuejs | core | 889,910,858 | 4,214 | posva | > It looks like every time I think there couldn't be "more" to the issue, every time I'm wrong and it's dependent on weird conditions I couldn't even imagine 😓
I've been there too, it's sometimes frustrating 😅
> BTW I wanted to create a repro in the SFC explorer first (link in issue), but as I mentioned you can... | 2021-07-30T13:57:33 | 2021-07-30T13:57:33 | {} | MEMBER |
vuejs | core | 891,278,290 | 4,010 | DV8FromTheWorld | Bump | 2021-08-02T19:31:55 | 2021-08-02T19:31:55 | {} | CONTRIBUTOR |
vuejs | core | 891,602,438 | 4,215 | cexbrayat | Sounds good. I opened https://github.com/facebook/jest/pull/11721 in Jest itself
Let's see if that lands
| 2021-08-03T07:21:45 | 2021-08-03T07:21:45 | {} | MEMBER |
vuejs | core | 892,233,630 | 4,243 | Cherry | Thanks for the additional insight. Unfortunately that appears to result in the same error as described in example 2, with `The script will never generate a response.`. Specifically with:
```js
async function pipeReaderToWriter(reader, writer){
for(;;){
const {value, done} = await reader.read();
console.log(... | 2021-08-03T23:30:34 | 2021-08-03T23:30:34 | {} | CONTRIBUTOR |
vuejs | core | 893,014,323 | 4,246 | lidlanca | this seem to be a problem with iterating over a number
```js
v-for="(id, index) in 3"
```
if you iterate over array the v-memo seem to work
```js
v-for="(id, index) in items"
```
https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHRlbXBsYXRlPlxuICA8YnV0dG9uIEBjbGljaz1cImNvdW50KytcIj5cbiAgICBpbmMge3sgY291bnQgfX1cbiA... | 2021-08-04T22:23:19 | 2021-08-04T22:28:44 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 893,019,114 | 4,246 | lidlanca | some what related issue https://github.com/vuejs/vue-next/issues/4253
| 2021-08-04T22:35:09 | 2021-08-04T22:35:09 | {} | CONTRIBUTOR |
vuejs | core | 893,329,159 | 4,255 | posva | The array should not be dynamic. It should be fixed length.
What are some the realistic complex use cases you thinking about? The one with ternaires doesn't seem realistic
Have you read the PR in the docs repo containing docs for v-memo? | 2021-08-05T10:00:40 | 2021-08-05T10:00:40 | {} | MEMBER |
vuejs | core | 893,656,307 | 4,255 | posva | I didn't say it was blocking only asked what are the real use cases.
Note that widening an api can make it easier to mess up for the user and harder to debug. On the other hand, limiting its usage makes it easier to detect errors and point the user in the right direction.
Real use cases are also interesting for docum... | 2021-08-05T17:39:55 | 2021-08-05T17:39:55 | {} | MEMBER |
vuejs | core | 894,591,823 | 4,270 | edison1105 | @yyx990803
I just wrote a test case and found that this PR has been merged. should I need to submit the test cases? | 2021-08-07T02:19:46 | 2021-08-07T02:19:46 | {
"+1": 1
} | MEMBER |
vuejs | core | 892,207,162 | 4,243 | lidlanca | cloudflare web worker does not implement `ReadableStream` instead they provide `TransformStream`
https://developers.cloudflare.com/workers/runtime-apis/streams/transformstream
you can use a **ponyfills** of `ReadableStream`, and then
read the stream, and "pipe" the values yourself to the writer of `TransformSt... | 2021-08-03T22:26:48 | 2021-08-03T22:26:48 | {} | CONTRIBUTOR |
vuejs | core | 892,789,076 | 4,246 | posva | you added `count` back 😆
I'm also confused, this seems like a bug | 2021-08-04T16:13:33 | 2021-08-04T16:13:33 | {} | MEMBER |
vuejs | core | 893,021,928 | 4,251 | posva | Related issue in vue 2 https://github.com/vuejs/vue/issues/12113 | 2021-08-04T22:42:35 | 2021-08-04T22:42:35 | {} | MEMBER |
vuejs | core | 893,219,657 | 4,255 | posva | In what case will this be useful? If the array is external, it's much easier to make it not-fixed size and break it. The utility of `v-memo` is to base itself on things used to render, it should not be able to use properties that might not be used during rendering. Allowing this approach will make it much harder to deb... | 2021-08-05T07:06:08 | 2021-08-05T07:06:08 | {} | MEMBER |
vuejs | core | 893,833,625 | 4,255 | posva | We haven't even discussed anything yet 😅
The first and most important question of any feature request remains: what is the use case? This is what we always ask, it's nothing personal. Maybe reading the rfcs repo readme gives you a more detailed explanation of why we do this... | 2021-08-05T21:56:30 | 2021-08-05T21:56:30 | {} | MEMBER |
vuejs | core | 894,260,285 | 4,253 | edison1105 | the root cause is:
```diff
return (_ctx, _cache) => {
return (_openBlock(), _createElementBlock(_Fragment, null, [
_createElementVNode("button", {
onClick: _cache[0] || (_cache[0] = $event => (count.value++))
}, " inc " + _toDisplayString(count.value), 1 /* TEXT */),
(_openBlock(), _createEle... | 2021-08-06T13:27:34 | 2021-08-06T13:27:34 | {} | MEMBER |
vuejs | core | 894,330,676 | 4,248 | yyx990803 | This is... somewhat intended. Opening it up too much essentially allows you to not just **extend** the Vue template, but create your own **dialect**. For example a custom `v-if` is definitely something I do not want to support.
The compiler API serves primarily for Vue internal uses - it is exposed for simple single... | 2021-08-06T15:15:57 | 2021-08-06T15:15:57 | {} | MEMBER |
vuejs | core | 894,382,314 | 4,243 | yyx990803 | I adjusted the streaming API in 86d78d10 and added `pipeToWebWritable` which should be more flexible in such scenarios:
```js
const { readable, writable } = new TransformStream()
pipeToWebWritable(app, {}, writable)
return new Response(readable)
```
Will release a beta today so you can test it out. | 2021-08-06T16:43:06 | 2021-08-06T16:43:06 | {
"hooray": 2
} | MEMBER |
vuejs | core | 890,345,615 | 4,211 | posva | I see, I'm not sure this is the correct usage of `markRaw()`. You use it on raw object to prevent them from being proxified when being passed to `reactive()` and `ref`. e.g. you mark an `Element` instance as raw if you pass it to `ref` or `reactive` | 2021-07-31T13:04:26 | 2021-07-31T13:04:26 | {} | MEMBER |
vuejs | core | 893,214,658 | 4,256 | posva | Using a stateful component could be intentional. Just export a function explicitely. | 2021-08-05T06:57:09 | 2021-08-05T06:57:09 | {} | MEMBER |
vuejs | core | 893,258,271 | 4,255 | lidlanca | memoization logic is not dependent or restricted by what is rendering nor should it be.
and complex non debuggable logic already possible in template.
```js
<div v-memo="[count < 3 ? a : b , count >=3 && < 3 && b ? b : 0 ]"></div>
```
having logic in code is arguably more debuggable and testable then b... | 2021-08-05T08:11:13 | 2021-08-05T08:11:13 | {} | CONTRIBUTOR |
vuejs | core | 894,270,174 | 4,253 | edison1105 | @lidlanca
`withMemo` works fine because it catches the block tree.
see :
```javascript
export function withMemo(
memo: any[],
render: () => VNode<any, any>,
cache: any[],
index: number
) {
const cached = cache[index] as VNode | undefined
if (cached && isMemoSame(cached.memo!, memo)) {
/... | 2021-08-06T13:43:09 | 2021-08-06T13:45:07 | {} | MEMBER |
vuejs | core | 894,383,536 | 4,243 | Cherry | This is fantastic, thanks! | 2021-08-06T16:45:21 | 2021-08-06T16:45:21 | {} | CONTRIBUTOR |
vuejs | core | 894,819,552 | 4,245 | posva | Ah i see! Then maybe, if there is a place where documenting this makes sense, it could be added there. | 2021-08-08T16:10:13 | 2021-08-08T16:10:13 | {} | MEMBER |
vuejs | core | 894,845,386 | 4,275 | LinusBorg | Your webpack config is missing an alias to pont to the right build of Vue - one that includes a runtime-compiler for string templates:
https://v3.vuejs.org/guide/installation.html#with-a-bundler
| 2021-08-08T19:41:27 | 2021-08-08T19:41:27 | {} | MEMBER |
vuejs | core | 894,853,636 | 4,275 | ffigari | Hi @LinusBorg, is there some basic example of a webpack configuration that allows this to work? I'm fairly new to bundling in general and the provided link is not clear enough to me. | 2021-08-08T20:52:04 | 2021-08-08T20:52:04 | {} | NONE |
vuejs | core | 890,759,924 | 3,972 | HuRuilin | > @posva Can you edit the link?
>
> https://codesandbox.io/s/bold-rgb-c8pf6?file=/src/main.js
>
> I can't solve the problem if I add vue-router@4
I have a same problem like this. now,dou you know how to solve it?
| 2021-08-02T06:30:59 | 2021-08-02T06:30:59 | {} | NONE |
vuejs | core | 891,002,321 | 4,225 | dependabot[bot] | OK, I won't notify you about chalk again, unless you re-open this PR or update it yourself. 😢 | 2021-08-02T12:56:22 | 2021-08-02T12:56:22 | {} | CONTRIBUTOR |
vuejs | core | 891,033,132 | 4,215 | yyx990803 | I feel this is something that should be fixed in Jest - its usage of `hasOwnProperty` would break on any object that has `null` as prototype, or any other proxies that filters allowed keys.
Instead it should use `Object.prototype.hasOwnProperty.call(...)`. | 2021-08-02T13:35:21 | 2021-08-02T13:35:21 | {} | MEMBER |
vuejs | core | 892,708,234 | 4,246 | posva | I don't think v-memo is supposed to work like v-once. Since you are passing `:count="count"`, the component still needs to update. Take a look [at this example without `count`](https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHRlbXBsYXRlPlxuICA8YnV0dG9uIEBjbGljaz1cImNvdW50KytcIj5cbiAgICBpbmMge3sgY291bnQgfX1cbiAgPC9idXR0b24+XG4g... | 2021-08-04T14:30:29 | 2021-08-04T14:30:29 | {} | MEMBER |
vuejs | core | 893,223,854 | 4,257 | edison1105 | > Thanks! This seems to only handle the `!` operator but not casting `a as number`/`<number>a`
oh~ Thanks for your reminder. | 2021-08-05T07:13:21 | 2021-08-05T07:13:21 | {} | MEMBER |
vuejs | core | 893,287,919 | 4,253 | sqal | ahh yes, it shows up on 4th click, nevermind then | 2021-08-05T08:56:59 | 2021-08-05T08:56:59 | {} | CONTRIBUTOR |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.