owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 927,167,189 | 1,359 | yyx990803 | I just realized I can close this :D | 2021-09-25T18:50:27 | 2021-09-25T18:50:27 | {
"laugh": 1
} | MEMBER |
vuejs | core | 927,551,646 | 4,668 | LinusBorg | Ah, so it is a problem with Vue's codegen in the sense that it generates unused parameters sometimes - which previously wasn't an issue as the generated render function wasn't actually typechecked, but vue-tsc now does that.
so there's little for you to do, we'll have to research if/how we can improve this. | 2021-09-27T05:51:27 | 2021-09-27T05:52:24 | {
"+1": 9
} | MEMBER |
vuejs | core | 927,786,897 | 4,684 | lgl017 | Ok, I will try another way. | 2021-09-27T11:34:12 | 2021-09-27T11:34:12 | {} | NONE |
vuejs | core | 925,768,262 | 4,654 | epaezrubio | When is a vue-loader version bump in @vue/cli-service expected @yyx990803 ? I'm afraid that there's no straightforward solution for npm as for yarn (except downgrading) | 2021-09-23T12:34:51 | 2021-09-23T12:34:51 | {} | NONE |
vuejs | core | 926,769,943 | 4,670 | yyx990803 | Thanks, I think it's better to cast at the export location. See 7b7e28ad | 2021-09-24T16:37:53 | 2021-09-24T16:37:53 | {} | MEMBER |
vuejs | core | 926,934,558 | 2,860 | yyx990803 | Should be fixed by https://github.com/vitejs/vite/commit/06d86e4a2e90ca916a43d450bca1e6c28bc4bfe2 | 2021-09-24T21:41:04 | 2021-09-24T21:41:04 | {} | MEMBER |
vuejs | core | 926,981,206 | 4,648 | skirtles-code | There is some overlap with #4631 here. | 2021-09-25T00:29:56 | 2021-09-25T00:29:56 | {} | CONTRIBUTOR |
vuejs | core | 927,092,805 | 4,676 | LinusBorg | Maybe something like:
```js
function build(option, parentData, formData) {
// parentData is reactive(formData[anyname]) , formData is reactivity
parentData[option.prop] = option.initalValue
const disabledRef = ref(!option.disabled)
if (typeof option.disabled === 'function') {
onBeforeMount(() =... | 2021-09-25T09:12:21 | 2021-09-25T09:14:14 | {} | MEMBER |
vuejs | core | 927,163,546 | 4,676 | yyx990803 | `watchEffect` can be called inside `onBeforeMount` or `onMounted` if needed (it will still be tracked by the component's effect scope), you have full control over when to set it up. | 2021-09-25T18:23:16 | 2021-09-25T18:23:38 | {
"+1": 1
} | MEMBER |
vuejs | core | 927,607,386 | 4,685 | posva | Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.com/tags/vue.js).
---
This is likely to be a configuration issue on ... | 2021-09-27T07:31:29 | 2021-09-27T07:31:29 | {} | MEMBER |
vuejs | core | 927,993,002 | 4,662 | raffobaffo | I see 👁️ . My changes are very similar, just its more recursive, meaning also components at any level are interested. | 2021-09-27T15:37:08 | 2021-09-27T15:37:08 | {} | NONE |
vuejs | core | 925,697,054 | 4,247 | cyfung1031 | @Bigfish8 Why dont just use {...objectA, ...objectB, ...objectC}
Don't give some options to let the people make wrong coding.
they will just use ['xxx', 'bbb']
And it has to check the array contents whether they are all objects.
I don't think array would be a popular option for most people for most cases.
But... | 2021-09-23T10:41:34 | 2021-09-23T10:41:34 | {} | NONE |
vuejs | core | 926,920,878 | 4,673 | yyx990803 | If you are using Vite, this is fixed in `@vitejs/plugin-vue` 1.9.2.
`vue-loader` does not suffer from this issue AFAIK. | 2021-09-24T21:09:26 | 2021-09-24T21:09:26 | {
"heart": 1,
"hooray": 1
} | MEMBER |
vuejs | core | 927,103,869 | 4,678 | LinusBorg | You are essentially updating the original non-reactive object (outside Vuejs) and expect Vue's reactive proxy for that object to update. That doesn't work, Vue doesn't get informed about changes to the *nonreactive* original opject.
https://v3.vuejs.org/guide/reactivity.html#proxy-vs-original-identity
Consequentl... | 2021-09-25T10:54:20 | 2021-09-25T10:55:07 | {
"+1": 1
} | MEMBER |
vuejs | core | 927,166,733 | 4,680 | yyx990803 | This is a bit similar to how `value` must be set after `min/max` on `<input type="range">`... we special-cased that in ff0c8103 - although I'm not sure if we want to do it for `crossorigin` since it's Safari only (not sure if it should be considered a bug in Safari) | 2021-09-25T18:47:18 | 2021-09-25T18:47:18 | {
"+1": 1
} | MEMBER |
vuejs | core | 927,603,300 | 4,687 | posva | This is expected, you even have a warning in the console.
---
Please, next time consider using the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.com/tags/vue.js) for questions first. But feel free to come back and open an issue if it turns... | 2021-09-27T07:24:47 | 2021-09-27T07:24:47 | {} | MEMBER |
vuejs | core | 927,614,838 | 4,679 | ygj6 | It seems that delete the comments could work fine.
index.html:
```
<div id="app"><!--[--><div>Hover me</div><!--[--><!--]--><!--]--></div> ==> <div id="app"><div>Hover me</div></div>
```
| 2021-09-27T07:44:12 | 2021-09-27T07:44:12 | {} | MEMBER |
vuejs | core | 928,145,180 | 1,359 | chojnicki | > Hey @yyx990803 is there a way to annotate a prop with a generic so that the types get carried over through scoped slots?
>
> CompA
>
> ```
> <script lang ="ts">
> import { defineComponent, PropType } from 'vue';
>
> defineComponent({
> props: {
> items: {
> type: Array as PropType<T[]>,
> ... | 2021-09-27T18:08:50 | 2021-09-27T18:08:50 | {} | NONE |
vuejs | core | 928,515,641 | 4,686 | LogicAndTrick | Thank you, the workaround is suitable for my use case. I understand the need for the optimisation, but the behaviour seems unintuitive to me - it looks like the component is being updated (ref callbacks are being called in the component's scope), and yet the update hooks aren't called on that component. In my mind the ... | 2021-09-28T00:37:02 | 2021-09-28T00:37:02 | {} | NONE |
vuejs | core | 925,684,852 | 4,661 | FoxDaxian | May be can support api `defineReturn` like `defineExpose`? | 2021-09-23T10:22:44 | 2021-09-23T10:22:44 | {} | NONE |
vuejs | core | 927,087,026 | 4,676 | nicefan | first run in the onBeforeUpdate , Still can be collect dependencies
Running twice of create stage doesn't make sense | 2021-09-25T08:20:18 | 2021-09-25T08:24:22 | {} | NONE |
vuejs | core | 927,329,772 | 1,558 | zangtian2 | oh, thank u very much | 2021-09-26T16:06:46 | 2021-09-26T16:06:46 | {} | NONE |
vuejs | core | 927,676,594 | 3,874 | lukewarlow | I hate leaving comments like this but this bug is blocking me migrating a few sites over to SSR. I see there's a PR that's been open a while to address this issue, is there anything I can do to get that reviewed? | 2021-09-27T09:09:53 | 2021-09-27T09:09:53 | {} | NONE |
vuejs | core | 927,879,963 | 4,662 | gnuletik | I just realized there is already an open PR about this : https://github.com/vuejs/vue-next/pull/4309 | 2021-09-27T13:33:03 | 2021-09-27T13:33:03 | {} | NONE |
vuejs | core | 928,880,710 | 4,692 | edison1105 | 我感觉你理解错了。如果修改了 toRawTest.a, reactiveTest.a 也会改变，但不会触发副作用。setTimeout 中修改了reactiveTest.a会触发视图渲染。所以展示出来的数据都是修改之后的。
| 2021-09-28T06:03:22 | 2021-09-28T06:03:22 | {} | MEMBER |
vuejs | core | 925,405,045 | 4,656 | posva | You need to pass the relevant information to the slot, in this case `item`:
```js
useSlots().default({ item })
``` | 2021-09-22T23:41:41 | 2021-09-22T23:41:41 | {} | MEMBER |
vuejs | core | 925,443,779 | 4,616 | ygj6 | > > ```ts
> > import type { ComponentPublicInstance } from 'vue'
> > function setItemRef(ref: Element | ComponentPublicInstance ) {
> > if(ref) {
> > liRefs.push(ref)
> > }
> > }
> > ```
>
> Yes, i know that ,just i think it's too verbose.
setItemRef ( ref : Element | {} ) {
} | 2021-09-23T01:24:00 | 2021-09-23T01:24:00 | {} | MEMBER |
vuejs | core | 926,214,487 | 4,656 | chojnicki | > You need to pass the relevant information to the slot, in this case `item`:
>
> ```js
> useSlots().default({ item })
> ```
`default({})` is working just fine, thanks! | 2021-09-23T22:41:34 | 2021-09-23T22:41:34 | {} | NONE |
vuejs | core | 927,164,166 | 4,678 | yyx990803 | For Vue 3, reactivity works through proxies. So essentially: Do NOT set an external object on `this` then expect the original object to become "reactive". This worked in Vue 2 but won't in Vue 3 - Vue 3 will no longer modify the original object. You can only work through the reactive proxy of the object (through `this.... | 2021-09-25T18:27:49 | 2021-09-25T18:28:11 | {
"+1": 1
} | MEMBER |
vuejs | core | 927,262,027 | 4,668 | iraklisg | @LinusBorg oh, I haven't noticed this strange behavior... Since the problem emerged when I upgraded my node modules (including `laravel-mix` package) I opened an issue to [laravel-mix](https://github.com/laravel-mix/laravel-mix) and I will report back when I have an update. | 2021-09-26T08:48:03 | 2021-09-26T08:48:03 | {} | NONE |
vuejs | core | 927,299,856 | 4,681 | zyyv | ```
const test = () => {
const a :any= {
time: 0,
setValue(){
this.time += 1
}
}
return a
}
```
尝试这么写呢？ | 2021-09-26T12:40:30 | 2021-09-26T12:40:30 | {} | NONE |
vuejs | core | 928,134,580 | 1,359 | Spittal | Oh just saw this issue: https://github.com/vuejs/vue-next/issues/3102 | 2021-09-27T18:04:25 | 2021-09-27T18:04:25 | {} | NONE |
vuejs | core | 928,241,809 | 4,651 | posva | By repro I mean following this: https://new-issue.vuejs.org/?repo=vuejs/vue-next | 2021-09-27T20:22:51 | 2021-09-27T20:22:51 | {} | MEMBER |
vuejs | core | 925,868,225 | 4,664 | leno23 | got it wrong | 2021-09-23T14:28:00 | 2021-09-23T14:28:00 | {} | CONTRIBUTOR |
vuejs | core | 926,352,668 | 4,667 | bundlejs | > 这是因为 style 被 parse 成了对象，为的是处理 auto-prefixing。直接写 `background: #18191c url('http://abc.bcd.com/efg.jpeg');` 就可以避免了。
我也是这样处理的，但这样合理么 | 2021-09-24T05:14:26 | 2021-09-24T05:14:26 | {} | NONE |
vuejs | core | 927,083,570 | 4,676 | LinusBorg | It runs immediately once because it needs to collect reactive dependencies. then it will adhere to the `flush` setting.
The "double run" is the intended behavior by our design. | 2021-09-25T08:09:09 | 2021-09-25T08:09:46 | {} | MEMBER |
vuejs | core | 927,815,002 | 4,689 | danranVm | ```ts
const Comp = defineComponent({
props,
setup() {
return <div></div>
},
}) as unknown as DefineComponent<HTMLAttributes & ExtractPropTypes<typeof props>>
```
~~Using 'ExtractPropTypes' to wrap props makes it work, is there a better solution?~~
Then I had a new problem, when I changed 'required... | 2021-09-27T12:14:20 | 2021-09-27T12:38:13 | {} | NONE |
vuejs | core | 928,546,419 | 4,687 | yangyangcq | the warning is "Component inside <Transition> renders non-element root node that cannot be animated.",but shouldn't be render error,only when transition has mode= out-in | 2021-09-28T01:03:49 | 2021-09-28T01:03:49 | {} | NONE |
vuejs | core | 846,507,226 | 3,818 | HcySunYang | Do you mean this [sfc playground](https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHRlbXBsYXRlPlxuICA8U2xpZGVyPlxuICBcdDx0ZW1wbGF0ZSAjc2xpZGU9XCJ7Y3VycmVudFNsaWRlfVwiPlxuICAgICAgPGRpdiBcbiAgICAgICAgICB2LWlmPVwiY3VycmVudFNsaWRlICE9IG51bGxcIlxuICAgICAgICAgIGNsYXNzPVwic2xpZGUtYm94XCJcbiAgICAgID5cbiAgICAgICAge3tjdXJyZW50U2xpZGV9fVx... | 2021-05-23T05:40:35 | 2021-05-23T05:40:35 | {} | MEMBER |
vuejs | core | 846,510,976 | 3,695 | HcySunYang | Mark this as p4 | 2021-05-23T06:17:17 | 2021-05-23T06:17:17 | {
"+1": 2
} | MEMBER |
vuejs | core | 847,850,757 | 3,827 | yyx990803 | If you are using JSX, you should just handle key events yourself. Exposing `withKeys` locks us into how it works and prevents potential future changes in internal implementations. | 2021-05-25T13:03:26 | 2021-05-25T13:03:26 | {} | MEMBER |
vuejs | core | 850,693,267 | 2,116 | Shinigami92 | > `[...array]` approach is working for me. I'd suggest adding a note about this in the docs. It was definitely not obvious that watching an array does not watch adds/removes.
Yeah, took me around 20min to find out how I can workaround that
A note here https://v3.vuejs.org/guide/migration/watch.html would be nice :s... | 2021-05-28T21:51:20 | 2021-05-28T21:51:20 | {} | CONTRIBUTOR |
vuejs | core | 848,408,920 | 906 | dacxjo | After a while researching, i have found this URL, [https://v3.vuejs.org/guide/migration/suspense.html#combining-with-other-components](https://v3.vuejs.org/guide/migration/suspense.html#combining-with-other-components), where i have learned about the exprimental component Supense
At the end, there's this code block... | 2021-05-26T02:30:39 | 2021-05-26T02:30:39 | {} | NONE |
vuejs | core | 848,424,516 | 3,829 | JasonMgz0411 | @edison1105
if it resolved after timeout, it still work, what is the meaning of the timeout?
The above code rendering process is as follows:
```html
<!--start-->
loading......
<!--500ms-->
Error load comp
<!--1000ms-->
async comp load complete
```
This makes me feel that the timeout just triggers the erro... | 2021-05-26T03:20:47 | 2021-05-26T03:20:47 | {} | NONE |
vuejs | core | 848,631,319 | 3,833 | yaquawa | @LinusBorg
I could go with a workaround by doing this:
https://codesandbox.io/s/stupefied-wave-ti0bb?file=/src/index.ts
but this time, the typing of `reactive` won't work properly in ts... | 2021-05-26T09:48:10 | 2021-05-26T09:48:39 | {} | NONE |
vuejs | core | 849,924,327 | 3,834 | yyx990803 | `setInterval` is not tied to Vue component lifecycles, you need to `clearInterval` yourself in Alert's `unmounted` hook. | 2021-05-27T20:36:23 | 2021-05-27T20:36:23 | {} | MEMBER |
vuejs | core | 850,055,687 | 3,835 | yyx990803 | The return value from `computed` is a computed ref. It's not the object your returned.
It is unwrapped automatically when you access it as a property of a `reactive` object, but you can't spread it. | 2021-05-28T01:56:48 | 2021-05-28T01:56:48 | {} | MEMBER |
vuejs | core | 850,772,506 | 3,843 | HcySunYang | 你得让数据是响应式的才行啊，看这里：[sfc playground](https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHRlbXBsYXRlPlxuICA8aDE+e3sgbXNnIH19PC9oMT5cbiAgPGlucHV0IEBpbnB1dD0nZmlsdGVySGFuZGxlJyAvPlxuICA8dWw+XG4gICAgPGxpIHYtZm9yPScoaXRlbSwgaW5kZXgpIGluIG5ld0RhdGEnIDprZXk9J2l0ZW0nIEBjbGljaz0nKCkgPT4gZGVsZXRlSGFuZGxlKGluZGV4KSc+e3tpdGVtfX08L2xpPlxuICA8L3... | 2021-05-29T05:16:44 | 2021-05-29T05:16:44 | {} | MEMBER |
vuejs | core | 846,508,563 | 3,818 | HcySunYang | I mean it works correctly, see that playground I provided. | 2021-05-23T05:52:58 | 2021-05-23T05:52:58 | {} | MEMBER |
vuejs | core | 848,646,490 | 3,833 | yaquawa | well, this works too, but you know how dirt it is..
```ts
const foo = new Foo
const fooReactive = reactive(foo)
fooReactive.initUrl()
``` | 2021-05-26T10:11:21 | 2021-05-26T10:11:21 | {} | NONE |
vuejs | core | 848,725,414 | 3,797 | hyf0 | @yaquawa Oh, I get it. #3791 may be helpful and it should work with typescript4.3 well. I'm not sure if it is recommended, but I would suggest only using plain object in `reactive` or `ref` and `markRaw` for non-plain-object.
The reflection won't be easy or is even impossible. I play around it and find out that type... | 2021-05-26T12:25:10 | 2021-05-26T12:25:10 | {} | CONTRIBUTOR |
vuejs | core | 850,083,658 | 1,056 | RexHung0302 | @johnsoncodehk Object is possibly 'null'. How to solve this? | 2021-05-28T03:25:19 | 2021-05-28T03:25:19 | {} | NONE |
vuejs | core | 850,608,817 | 3,079 | yyx990803 | https://github.com/vuejs/vue-next/issues/3082#issuecomment-850608712 | 2021-05-28T19:01:20 | 2021-05-28T19:01:20 | {} | MEMBER |
vuejs | core | 850,707,619 | 3,690 | yyx990803 | This would actually disable binding optimizations for non-script-setup SFCs (e.g. optimizing `_ctx.foo` to `$data.foo`).
The proper fix should be in the css vars codegen - see 8b94464a | 2021-05-28T22:41:41 | 2021-05-28T22:41:41 | {} | MEMBER |
vuejs | core | 846,502,171 | 3,813 | HcySunYang | Since this is an undocumented feature, I will not mark it as a bug, and @edison1105's PR can fix it, let’s wait for @yyx990803 ’s input. | 2021-05-23T04:57:52 | 2021-05-23T04:57:52 | {} | MEMBER |
vuejs | core | 846,509,874 | 3,695 | arthur-0595 | This is quite annoying, please fix this ASAP 🙏. | 2021-05-23T06:06:00 | 2021-05-24T22:10:53 | {} | NONE |
vuejs | core | 847,480,202 | 2,557 | hyf0 | Will be fixed in #3791. Duplicate of #2981. May close this one? @HcySunYang | 2021-05-25T02:19:32 | 2021-05-25T02:19:32 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 847,675,033 | 2,732 | gzzhanghao | Is it better to queue a flush after flushJobs?
```ts
if (pendingPreFlushCbs.length) {
queueFlush()
} else if (queue.length || pendingPostFlushCbs.length) {
flushJobs(seen)
}
``` | 2021-05-25T08:40:29 | 2021-05-25T08:40:29 | {} | CONTRIBUTOR |
vuejs | core | 848,412,665 | 3,829 | edison1105 | I looked into the code, this is expected. if it resolved after timeout, should still work | 2021-05-26T02:42:58 | 2021-05-26T02:42:58 | {} | MEMBER |
vuejs | core | 848,716,899 | 3,797 | yaquawa | @iheyunfei kind of similar issue, but not exactly I think. | 2021-05-26T12:11:19 | 2021-05-26T12:11:19 | {} | NONE |
vuejs | core | 850,617,920 | 3,566 | yyx990803 | Yeah currently `resolveMergedOptions` intentionally does not account for built-in options like `computed` because it's somewhat wasteful (one of the perf bottlenecks in v2).
What I'm suggesting is for devtools to also check `mixins` and `extends` when resolving computed/provide/inject state for an instance. | 2021-05-28T19:10:57 | 2021-05-28T19:10:57 | {
"+1": 1
} | MEMBER |
vuejs | core | 850,656,509 | 3,090 | yyx990803 | Investigated a bit and turns out the perf bottleneck is due to static content insertion. The component is largely static so it compiles into a single static node with an HTML string. When mounting such a node, we are currently setting it as `innerHTML` of a temp container and then move the created nodes into the mount ... | 2021-05-28T20:33:41 | 2021-05-28T20:33:41 | {
"heart": 2
} | MEMBER |
vuejs | core | 848,378,791 | 3,827 | wenfangdu | For anyone who comes to this, you can write a util function for this need.
```ts
export const withEnter = (fn: (...args: any[]) => any) => ({
key,
}: {
key: string
}): any => key === 'Enter' && fn()
```
| 2021-05-26T00:57:18 | 2021-05-26T00:57:18 | {} | NONE |
vuejs | core | 850,032,967 | 3,808 | wenfangdu | Can anyone reopen this 🙏? | 2021-05-28T00:42:17 | 2021-05-28T00:42:17 | {} | NONE |
vuejs | core | 850,580,470 | 3,536 | lukewarlow | I've updated my test case to Vue 3.1.0-beta5 (https://github.com/lukewarlow/vue-server-render-bug) but I still experience the issue with incorrect srcset in the SSR output. Is there some change I need to make to my SSR code?
| 2021-05-28T18:00:08 | 2021-05-28T18:00:08 | {} | NONE |
vuejs | core | 850,666,849 | 3,639 | yyx990803 | should already been fixed by 62b8f4a39ca56b48a8c8fdf7e200cb80735e16ae (which is more strict since it excludes all browser native objects) | 2021-05-28T20:59:06 | 2021-05-28T20:59:06 | {} | MEMBER |
vuejs | core | 850,813,677 | 3,844 | posva | As a workaround you can isolate the select in a component | 2021-05-29T10:55:57 | 2021-05-29T10:55:57 | {} | MEMBER |
vuejs | core | 846,954,621 | 3,824 | jacekkarczmarczyk | `import type { State } from './types'` | 2021-05-24T10:43:04 | 2021-05-24T10:43:04 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 848,075,405 | 3,569 | yyx990803 | 201060717d4498b4b7933bf8a8513866ab9347e4 is a partial fix which does not fix the [`<slot/>` variant](https://jsfiddle.net/Lrnebjuv/25/) | 2021-05-25T17:34:30 | 2021-05-25T17:34:30 | {} | MEMBER |
vuejs | core | 849,280,539 | 2,730 | HcySunYang | Fixed in https://github.com/vuejs/vue-next/commit/b57e995edd29eff685aeaf40712e0e029073d1cb | 2021-05-27T03:00:24 | 2021-05-27T03:00:24 | {} | MEMBER |
vuejs | core | 850,760,354 | 3,559 | JayFate | > Seems ~fine~ great to me, but I'm not really qualified to review it. Maybe try to get someone's attention in the Vue discord? I'm not sure which channel is best unfortunately...
Got it~ | 2021-05-29T03:18:30 | 2021-05-29T03:18:30 | {} | CONTRIBUTOR |
vuejs | core | 847,483,993 | 3,791 | HcySunYang | Has conflicts 😁 | 2021-05-25T02:31:20 | 2021-05-25T02:31:20 | {
"+1": 1
} | MEMBER |
vuejs | core | 848,629,066 | 3,478 | yaquawa | I have the similar typing issue here with the setter.
https://codesandbox.io/s/stupefied-wave-ti0bb?file=/src/index.ts | 2021-05-26T09:44:48 | 2021-05-26T09:47:38 | {} | NONE |
vuejs | core | 849,001,660 | 1,600 | areve | I have it working on all components in my app, my vite.config.js says
```ts
import { defineConfig } from "vite";
import vue from "@vitejs/plugin-vue";
export default defineConfig({
plugins: [
vue({
template: {
compilerOptions: {
whitespace: "preserve",
} as unknown,
... | 2021-05-26T18:04:35 | 2021-05-26T18:05:31 | {
"rocket": 1
} | NONE |
vuejs | core | 849,923,009 | 3,831 | yyx990803 | The root cause is that suspense slots are not rendered as normal slots with `renderSlot`. Normal slots are wrapped with a fragment block, but suspense slots are not (so the dynamic children tracking are lost).
See 9f24195d | 2021-05-27T20:34:07 | 2021-05-27T20:34:07 | {} | MEMBER |
vuejs | core | 850,071,074 | 3,808 | HcySunYang | @wenfangdu Can't reproduce, maybe you need to reinstall the deps to make sure you really update the deps | 2021-05-28T02:46:08 | 2021-05-28T02:46:08 | {} | MEMBER |
vuejs | core | 850,223,904 | 3,808 | edison1105 | @wenfangdu
you should also update @vue/compiler-sfc
| 2021-05-28T07:49:26 | 2021-05-28T07:49:26 | {} | MEMBER |
vuejs | core | 850,225,916 | 3,559 | tjk | Seems ~fine~ great to me, but I'm not really qualified to review it. Maybe try to get someone's attention in the Vue discord? I'm not sure which channel is best unfortunately... | 2021-05-28T07:52:49 | 2021-05-28T07:53:30 | {} | CONTRIBUTOR |
vuejs | core | 850,666,660 | 3,638 | yyx990803 | This should've been fixed by 62b8f4a39ca56b48a8c8fdf7e200cb80735e16ae | 2021-05-28T20:58:35 | 2021-05-28T20:58:35 | {
"+1": 1
} | MEMBER |
vuejs | core | 850,771,402 | 3,843 | jsliu27 | > 重新给一个重现的链接，你这个链接不好使
https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHRlbXBsYXRlPlxuICA8aDE+e3sgbXNnIH19PC9oMT5cbiAgPGlucHV0IEBpbnB1dD0nZmlsdGVySGFuZGxlJyAvPlxuICA8dWw+XG4gICAgPGxpIHYtZm9yPScoaXRlbSwgaW5kZXgpIGluIG5ld0RhdGEnIDprZXk9J2l0ZW0nIEBjbGljaz0nKCkgPT4gZGVsZXRlSGFuZGxlKGluZGV4KSc+e3tpdGVtfX08L2xpPlxuICA8L3VsPlxuPC90... | 2021-05-29T05:07:17 | 2021-05-29T05:07:17 | {} | NONE |
vuejs | core | 846,576,577 | 3,818 | LinusBorg | See also: https://v3.vuejs.org/guide/migration/transition.html | 2021-05-23T14:59:39 | 2021-05-23T14:59:39 | {} | MEMBER |
vuejs | core | 847,383,921 | 3,635 | yyx990803 | https://github.com/vuejs/vue-next/issues/3627#issuecomment-847383599 | 2021-05-24T22:09:44 | 2021-05-24T22:09:44 | {} | MEMBER |
vuejs | core | 847,470,340 | 3,031 | hyf0 | Im not familar with `inject`. If it only accepets string or symbol, best we can do is infering `this.map` as a `unkown` or `any`.
| 2021-05-25T01:51:23 | 2021-05-25T01:51:23 | {} | CONTRIBUTOR |
vuejs | core | 848,451,470 | 3,829 | edison1105 | @JasonMgz0411
see this test case: https://github.com/vuejs/vue-next/blob/master/packages/runtime-core/__tests__/apiAsyncComponent.spec.ts#L343 | 2021-05-26T04:52:28 | 2021-05-26T04:52:28 | {
"+1": 1
} | MEMBER |
vuejs | core | 849,262,037 | 2,732 | skirtles-code | I believe this has now been implemented: https://github.com/vuejs/vue-next/commit/b57e995edd29eff685aeaf40712e0e029073d1cb. | 2021-05-27T02:10:33 | 2021-05-27T02:10:33 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 849,953,120 | 3,002 | yyx990803 | Thanks for the PR - the root cause is that the browser decoder is not properly differentiating HTML strings vs. attribute values. See 66903727 (used tests from this PR) | 2021-05-27T21:26:15 | 2021-05-27T21:26:15 | {} | MEMBER |
vuejs | core | 850,047,894 | 3,808 | HcySunYang | I will check it later | 2021-05-28T01:31:19 | 2021-05-28T01:31:19 | {} | MEMBER |
vuejs | core | 850,217,525 | 3,808 | wenfangdu | @HcySunYang I've tried deleting node_modules and package.json and updated vue to `v3.1.0-beta.5`, still reproducible.
I've updated [repro](https://github.com/wenfangdu/vue-3-style-vars-tsx-repro) to reflect this:
```html
<!-- 👇 works -->
<script lang="ts">
import { defineComponent, h } from 'vue'
expor... | 2021-05-28T07:38:28 | 2021-05-28T07:47:41 | {} | NONE |
vuejs | core | 846,694,264 | 3,811 | HcySunYang | @hearsay316 我仍然无法复现问题，你看看你安装的 Vue 是什么版本的，可以更新到最新版本，我这边在 3.0.11 和 3.1.0-beta.3 下都没问题 | 2021-05-24T02:48:34 | 2021-05-24T02:48:34 | {} | MEMBER |
vuejs | core | 847,346,498 | 3,637 | yyx990803 | Not sure if this is the right fix, since if the `h` call returns a plain element they won't be tracked/updated anymore.
The original use case also seems very weird and there should be other ways to achieve the same end result without putting `h` calls inside computed properties. | 2021-05-24T21:24:37 | 2021-05-24T21:24:37 | {} | MEMBER |
vuejs | core | 846,798,607 | 3,695 | hzy-6 | This is quite annoying, please fix this ASAP 🙏. | 2021-05-24T06:44:17 | 2021-05-24T22:10:59 | {} | NONE |
vuejs | core | 847,462,658 | 3,797 | hyf0 | duplicate of #3478 | 2021-05-25T01:27:47 | 2021-05-25T01:27:47 | {} | CONTRIBUTOR |
vuejs | core | 848,641,897 | 3,833 | yaquawa | @LinusBorg
> why would you make the instance reactive() if it already uses ref() internally (which are reactive)?
oh, because we could have any other public properties on the class instance (I have edited the example code a bit).
> Just don't replace the refs, just set their value:
Because I want to init t... | 2021-05-26T10:04:09 | 2021-05-26T10:31:38 | {} | NONE |
vuejs | core | 849,259,242 | 1,600 | antoniandre | @areve, it's great to see you got it working, thanks for sharing your config! 👍
I still can't make it work with slots though.
I've created a reproduction on CodeSandbox where I demo exactly the problem: https://codesandbox.io/s/interesting-cookies-dy7wn?file=/src/App.vue
The whitespaces (new lines in particul... | 2021-05-27T02:03:44 | 2021-05-27T02:03:44 | {} | NONE |
vuejs | core | 849,373,105 | 1,600 | areve | I had a play with your CodeSandbox and I agree there does appear to be a problem here. The whitespace in slots is not preserved as I would expect. I suggest this is an oversight and should be logged as a new bug. The lack of documentation is also an issue, I'm not sure how/who/when this may get changed. | 2021-05-27T06:42:09 | 2021-05-27T06:42:09 | {
"+1": 4
} | NONE |
vuejs | core | 849,257,656 | 3,242 | skirtles-code | If I've understood correctly, then I don't think flushing the `post` jobs would be what we'd want. If a `post` job is triggered by another `post` job then it needs to wait until after the next rendering run. Recursive flushing would potentially cause the new job to run before the relevant DOM updates are performed. | 2021-05-27T02:00:06 | 2021-05-27T02:00:06 | {} | CONTRIBUTOR |
vuejs | core | 850,497,411 | 3,837 | SeregPie | Why not just use `Object.is`?
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is | 2021-05-28T15:26:59 | 2021-05-28T15:26:59 | {
"+1": 2
} | NONE |
vuejs | core | 847,484,346 | 2,557 | HcySunYang | Duplicate of #2981 | 2021-05-25T02:32:22 | 2021-05-25T02:32:22 | {} | MEMBER |
vuejs | core | 847,952,479 | 3,603 | yyx990803 | Simpler fix in 1526f94e - thanks for the test case! | 2021-05-25T15:10:36 | 2021-05-25T15:10:36 | {} | MEMBER |
vuejs | core | 850,070,771 | 3,566 | yyx990803 | Currently devtools for Vue 3 only handles computed/inject keys on the component's base definition, so even if we expose `$options` like in Vue 2 it still doesn't work.
It's trivial for devtools to account for mixins though, we just need to do a merge on the devtools side for computed/provide/inject [here](https://gi... | 2021-05-28T02:45:04 | 2021-05-28T02:45:04 | {} | MEMBER |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.