owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 1,310,314,141 | 7,038 | productdevbook | 
I guess this is not the same problem? | 2022-11-10T13:53:44 | 2022-11-10T13:53:44 | {} | CONTRIBUTOR |
vuejs | core | 1,310,339,003 | 7,094 | 1593292349 | > I'm not sure what behavior you are expecting or what you mean by "scoped slot was not used".
>
> slots are functions. passing a prop to a slot will call that function, regardless of wether or not use actually make use of the passed argument in it.
组件内容-{{Date.now()}} Is static, does not have any reactive variab... | 2022-11-10T14:13:17 | 2022-11-10T14:13:17 | {} | NONE |
vuejs | core | 1,308,093,390 | 7,041 | sxzz | I just updated the regexp, maybe you can try it. | 2022-11-09T02:01:16 | 2022-11-09T02:01:21 | {} | MEMBER |
vuejs | core | 1,308,477,730 | 7,071 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vuejs-coverage* failed.
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 6982ba423829979ed94e36808250eb0028d388c3 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https:/... | 2022-11-09T09:40:43 | 2022-11-09T09:40:43 | {} | NONE |
vuejs | core | 1,309,883,640 | 6,990 | JayFate | @sxzz Any other suggestions? | 2022-11-10T07:32:21 | 2022-11-10T07:32:21 | {} | CONTRIBUTOR |
vuejs | core | 1,309,914,585 | 6,677 | yyx990803 | Actually, this *should* work as intended. The root cause of the problem is that the codegen for `v-model` was incorrectly assuming the computed property is a binding defined in `<script setup>`.
This is now fixed via 15e889af | 2022-11-10T08:06:32 | 2022-11-10T08:06:32 | {
"+1": 1,
"heart": 1,
"hooray": 1,
"rocket": 2
} | MEMBER |
vuejs | core | 1,310,167,448 | 7,049 | shengxinjing | > > 有道理，不过位运算的清理用-=不太稳妥，用 a &= ~b 会好一些
>
> 我是参考的这里的代码：
>
> https://github.com/vuejs/core/blob/b8891ec86b2227f77e016d4f83bb182fbe4c633d/packages/runtime-core/src/components/KeepAlive.ts#L426-L435
我去PR优化一下下 | 2022-11-10T11:48:42 | 2022-11-10T11:48:42 | {
"laugh": 1
} | CONTRIBUTOR |
vuejs | core | 1,308,852,235 | 7,073 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed.
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 23ac44bbe04775f38d08b2735340534b70b43fbf |
|<span aria-hidden="true">🔍</span> Latest deploy log | htt... | 2022-11-09T14:30:26 | 2022-11-09T14:30:26 | {} | NONE |
vuejs | core | 1,310,377,235 | 7,094 | 1593292349 | @LinusBorg And I think it can be done. It's like computed. The responsive variable is tracked the first time it is run, and then re-run when the dependency is updated, otherwise it is returned directly to the cache
| 2022-11-10T14:32:09 | 2022-11-10T14:32:09 | {} | NONE |
vuejs | core | 1,310,388,566 | 7,094 | LinusBorg | > a more complex function was very time consuming
That doesn't belong into the template, plain and simple. | 2022-11-10T14:37:34 | 2022-11-10T14:37:34 | {} | MEMBER |
vuejs | core | 1,310,900,119 | 6,978 | javascript-senior | Same issue here 🤐 | 2022-11-10T21:15:23 | 2022-11-10T21:15:23 | {} | NONE |
vuejs | core | 1,305,998,209 | 7,041 | sxzz | Questions:
- `(?:expr)` is really necessary? It's just used to test here `namedDefaultExportRE.test()`
- `(?:as)?` why `as` optional? Is that really a valid syntax without `as`?
- I think there are only two types of named default export: `export { foo as default }` and plus `from 'xxx'`
- `default` is a keywor... | 2022-11-07T18:09:32 | 2022-11-09T02:50:42 | {} | MEMBER |
vuejs | core | 1,309,873,980 | 6,242 | yyx990803 | This is fixed by 2c27556f | 2022-11-10T07:24:28 | 2022-11-10T07:24:28 | {
"hooray": 1
} | MEMBER |
vuejs | core | 1,308,091,591 | 6,944 | tuchg | @yyx990803 hi, the code-style issues and conflict has been solved | 2022-11-09T01:58:29 | 2022-11-09T01:58:29 | {} | NONE |
vuejs | core | 1,308,630,060 | 7,041 | sxzz | @klyuevtech
Missing the case: `export { a, a as default, c }`
Matched the case but shouldn't `export { somedefault }`. | 2022-11-09T11:46:21 | 2022-11-09T11:46:21 | {} | MEMBER |
vuejs | core | 1,309,728,150 | 7,049 | zhangzhonghe | > 有道理，不过位运算的清理用-=不太稳妥，用 a &= ~b 会好一些
我是参考的这里的代码：
https://github.com/vuejs/core/blob/b8891ec86b2227f77e016d4f83bb182fbe4c633d/packages/runtime-core/src/components/KeepAlive.ts#L426-L435 | 2022-11-10T03:44:22 | 2022-11-10T03:44:22 | {} | MEMBER |
vuejs | core | 1,309,865,910 | 7,081 | yyx990803 | Not a valid reproduction. Assuming duplicate of https://github.com/vuejs/core/issues/6677 | 2022-11-10T07:14:24 | 2022-11-10T07:14:24 | {} | MEMBER |
vuejs | core | 1,310,042,137 | 7,049 | yyx990803 | 确实，保证 unmount 是必要的 | 2022-11-10T10:01:49 | 2022-11-10T10:01:49 | {} | MEMBER |
vuejs | core | 1,310,133,102 | 7,092 | shengxinjing | I'm not sure why the e2e-test is reporting an error | 2022-11-10T11:18:46 | 2022-11-10T11:18:46 | {} | CONTRIBUTOR |
vuejs | core | 1,310,321,630 | 7,093 | eltorio | The main problem is that the compiler treat main.ts as a SFC but it is not.
The problem is definitely a parsing problem because this code is working !!!!!
```ts
const baseUrl = import.meta.url
const useImage = (url: string) => {
return new URL(`/src/${url}`, baseUrl).href;
};
```
this is my current work... | 2022-11-10T13:59:46 | 2022-11-10T13:59:46 | {
"+1": 1
} | NONE |
vuejs | core | 1,310,359,459 | 7,094 | LinusBorg | Talking about the first, original example:
* `<Comp> />` can't know the content of the slot until it has *run* the slot function.
* and it needs to re-run the slot function over and over because `<Comp >` re-renders over and over
* because you change reactive state over and over with the timeout.
You can see in... | 2022-11-10T14:24:43 | 2022-11-10T14:25:37 | {} | MEMBER |
vuejs | core | 1,310,387,266 | 7,094 | 1593292349 | @LinusBorg You can't just think about the performance of creating vnodes. You can imagine if it wasn't Date.now and a more complex function was very time consuming. The performance bottleneck here is this function, so the performance gap between vue2 and vue3 is huge | 2022-11-10T14:36:40 | 2022-11-10T14:36:40 | {} | NONE |
vuejs | core | 1,310,513,104 | 7,094 | 1593292349 | @LinusBorg https://gitee.com/tangguoxiong/powerful-ui/tree/test/
1. Download the project
2. Switch to the test branch
3. npm i
4. npm run serve
5. You can see that the page has a list of 500,000 data
6. Punch in the console and scroll through the list a little
7. You find that the slot is rendered hu... | 2022-11-10T15:57:29 | 2022-11-10T15:57:29 | {} | NONE |
vuejs | core | 1,308,058,768 | 6,913 | moushicheng | further investigate.
The dynamicChildrens amount are different In two updates,this will cause bug.
the main reason is computed will cache node, computed gets called the first time, but not the second time.so dynamicChildren will just collect HelloWorld in the first Time | 2022-11-09T01:12:47 | 2022-11-09T01:12:47 | {} | CONTRIBUTOR |
vuejs | core | 1,308,262,935 | 7,041 | klyuevtech | Hi gays! This new regexp ((^|\n|;)\s*export\s*{.*(\s*[\w_$]+\s+as\s+)?default) could give false positive on a line like this one:
`export { foo as bar }; const baz = "default";
`
Probably we should close the braces?
`(^|\n|;)\s*export\s*{.*(\s*[\w_$]+\s+as\s+)?default\s*}` | 2022-11-09T06:12:23 | 2022-11-09T06:12:23 | {} | NONE |
vuejs | core | 1,310,363,235 | 7,093 | btea | It seems to be related to the code here
https://github.com/vitejs/vite/blob/9c808cdec89b807bff33eef37dfbb03557291ec1/packages/vite/src/node/plugins/assetImportMetaUrl.ts#L40-L41 | 2022-11-10T14:26:41 | 2022-11-10T14:26:41 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 1,310,397,276 | 7,093 | LinusBorg | Thanks for the detective work!
Closing this as it needs to be adressed in the Vite repo, not here. If you haven't already, please open an issue there. | 2022-11-10T14:43:17 | 2022-11-10T14:43:17 | {} | MEMBER |
vuejs | core | 1,310,401,187 | 7,094 | LinusBorg | There should be no heavy logic executed in templates, slots or not. As long as you don't do that, running a slot function again vs. cloning the slots old vnodes will be practically the same, maybe even faster due to Vue's optimized render functions.
If you can share a practical example that has a noticeable performa... | 2022-11-10T14:45:50 | 2022-11-10T14:45:59 | {} | MEMBER |
vuejs | core | 1,310,986,985 | 6,095 | ml1nk | We are using vuetify 3.0.1 and vue 3.2.44 together with some async components and suspense. We are also seeing the second picture (readind 'parentNode') randomly on navigation.
Is there progress on resolving this or is there some way to help? | 2022-11-10T22:33:20 | 2022-11-10T22:33:20 | {} | NONE |
vuejs | core | 1,310,449,543 | 7,094 | LinusBorg | Depends on how big it is. It should be reasonably focussed on the problem to demonstrate. But yeah, let's try, I'm curious. | 2022-11-10T15:19:59 | 2022-11-10T15:19:59 | {} | MEMBER |
vuejs | core | 1,308,118,873 | 7,041 | btea | It looks great, but the `s` flag doesn't seem to be needed. | 2022-11-09T02:34:11 | 2022-11-09T02:34:11 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 1,308,660,609 | 7,071 | KaelWD | Looks good, I wonder if there's a way to do `const INITIAL_WATCHER_VALUE_ARRAY = []` though instead of all the extra conditions and new arrays. Before #5033 it was `expect(oldVal).toMatchObject([])` which would also be fine unless someone cares about `.length` of that array. | 2022-11-09T12:12:24 | 2022-11-09T12:16:01 | {} | CONTRIBUTOR |
vuejs | core | 1,308,849,238 | 7,041 | btea | @klyuevtech
It doesn't seem to match the following
https://github.com/vuejs/core/blob/7663a79a295800da7c889fcd2e8e1e6d775263db/packages/compiler-sfc/__tests__/rewriteDefault.spec.ts#L112-L115 | 2022-11-09T14:28:15 | 2022-11-09T14:28:15 | {} | CONTRIBUTOR |
vuejs | core | 1,309,655,962 | 5,767 | yyx990803 | This has been fixed by #4077 (>=3.2.38) | 2022-11-10T01:47:39 | 2022-11-10T01:47:39 | {
"heart": 3
} | MEMBER |
vuejs | core | 1,309,656,016 | 5,781 | yyx990803 | This has been fixed by #4077 (>=3.2.38) | 2022-11-10T01:47:45 | 2022-11-10T01:47:45 | {} | MEMBER |
vuejs | core | 1,309,694,870 | 5,584 | yyx990803 | Summary:
- Using `v-model` on a prop is incorrect usage: a prop's local binding is not writable, so the reverse update never worked as intended. For correct component `v-model` usage, consult the [relevant section in docs](https://vuejs.org/guide/components/events.html#usage-with-v-model). Note the docs never showed... | 2022-11-10T02:48:24 | 2022-11-10T02:48:24 | {
"+1": 9,
"rocket": 1
} | MEMBER |
vuejs | core | 1,310,279,668 | 7,094 | 1593292349 | With the same render target as in the above example, I encapsulated comp1 and the slot was rerendered for no reason
https://sfc.vuejs.org/#eNp9kcFuwjAMhl8lyoUiIEFIu3QFadouu+6cSwdhFLVJlLjlEOXd5yQtGxNDaqXY/vPZ+e3pizFs6CUtaeX2tjFAnITe7IQipOmMtkBedWfI0eqOzBiPQbwwe/6j2NxINpOm4hmLQAxAdqatQSZ8lcDDyrUatoL6Qw11EDTVsHpohnwUgJ/P... | 2022-11-10T13:25:50 | 2022-11-10T13:25:50 | {} | NONE |
vuejs | core | 1,310,264,541 | 7,094 | 1593292349 | This is another example closer to my work. I usually write a lot of nested components and pass the slots step by step, which causes the slots to be rendered repeatedly and has a performance impact. But in theory, those slots don't need to be rerendered
https://sfc.vuejs.org/#eNqFUrFuwjAQ/RXLC0FADEhd0oBUtUuXqursJRCnBCW... | 2022-11-10T13:13:42 | 2022-11-10T13:27:55 | {} | NONE |
vuejs | core | 1,127,496,824 | 5,928 | liulinboyi | > > It will change in the [example](https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHNjcmlwdCBzZXR1cD5cbmltcG9ydCB7IHJlZiwgcmVhY3RpdmUsIHdhdGNoRWZmZWN0IH0gZnJvbSAndnVlJ1xuXG5jb25zdCBhcnIgPSByZWFjdGl2ZShbXSlcbndhdGNoRWZmZWN0KCgpID0+IHtcbiAgZGVidWdnZXJcbiAgY29uc29sZS5sb2coYXJyLmluZGV4T2YoJzEyMzQ1NicpKVxufSlcblxuY29uc3QgY2xpY2sgP... | 2022-05-16T10:26:57 | 2022-05-16T10:26:57 | {} | MEMBER |
vuejs | core | 1,128,480,363 | 5,412 | yyx990803 | https://github.com/vuejs/repl/pull/24 | 2022-05-17T06:49:26 | 2022-05-17T06:49:26 | {} | MEMBER |
vuejs | core | 1,128,709,014 | 5,937 | liulinboyi | Already tick the "allow edits from maintainer". | 2022-05-17T10:39:37 | 2022-05-17T10:39:37 | {} | MEMBER |
vuejs | core | 1,129,512,789 | 5,636 | yyx990803 | Thanks for the PR! Manually picked in 0841b9b5 - in the future when submitting PRs, make sure to do it from a separate branch and enable edits by maintainer. | 2022-05-18T02:52:38 | 2022-05-18T02:52:38 | {} | MEMBER |
vuejs | core | 1,131,542,386 | 5,937 | jineshjin | https://github.com/vuejs/core/blob/523f6aa363334eade6316b55340656eac35c5c64/packages/compiler-sfc/src/rewriteDefault.ts#L69
This is breaking with depcheck
<img width="615" alt="image" src="https://user-images.githubusercontent.com/34294346/169277705-1db7ae8b-4eed-43ce-8216-9ab46bbe79cc.png">
@yyx990803 @liulinboyi | 2022-05-19T10:55:39 | 2022-05-19T10:55:39 | {} | CONTRIBUTOR |
vuejs | core | 1,131,623,756 | 5,958 | jineshjin | Already checking here https://github.com/vuejs/core/blob/main/packages/compiler-sfc/src/rewriteDefault.ts#L54
so is that needed? | 2022-05-19T12:28:04 | 2022-05-19T12:28:04 | {} | CONTRIBUTOR |
vuejs | core | 1,128,308,253 | 5,809 | yyx990803 | #5810 | 2022-05-17T01:36:18 | 2022-05-17T01:36:18 | {
"heart": 1,
"hooray": 1
} | MEMBER |
vuejs | core | 1,087,128,017 | 4,294 | Miofly | any update? | 2022-04-04T05:19:20 | 2022-05-17T13:09:28 | {
"-1": 1
} | NONE |
vuejs | core | 1,129,072,850 | 5,693 | liulinboyi | > 我也遇到了相同的问题，请问有什么合适的解决方案吗
可以试一下这个[beta版本](https://www.npmjs.com/package/vue/v/3.2.34-beta.1)😉。 | 2022-05-17T16:24:27 | 2022-05-17T16:24:27 | {} | MEMBER |
vuejs | core | 1,129,727,174 | 5,946 | edison1105 | caused by https://github.com/vuejs/core/commit/2bab63968355995a4026cf5cd1ccad7c79e8d89c | 2022-05-18T08:32:44 | 2022-05-18T08:32:44 | {} | MEMBER |
vuejs | core | 1,131,602,974 | 5,958 | netlify[bot] | ### <span aria-hidden="true">👷</span> Deploy request for *vue-next-template-explorer* pending review.
[Visit the deploys page to approve it](https://app.netlify.com/sites/vue-next-template-explorer/deploys)
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</spa... | 2022-05-19T12:04:43 | 2022-05-19T12:04:43 | {} | NONE |
vuejs | core | 1,131,726,956 | 5,957 | mbrodala | Hm, but we _do_ use Node 14 already:
```
$ node --version
v14.18.2
```
Is there a specific minor/patch version required for this? | 2022-05-19T13:57:23 | 2022-05-19T13:57:23 | {} | NONE |
vuejs | core | 1,131,752,078 | 5,957 | snvtac | > 我看了看，是因为这个[build: output es2020 (target node 14+) for cjs/server builds](https://github.com/vuejs/core/commit/cbeb9f2d7859edbaceee0c73d2b33c578a1ffb58)，从[v3.2.34-beta.1](https://github.com/vuejs/core/releases/tag/v3.2.34-beta.1)开始，编译产物就是`es2020`了，需要`node`版本`node 14+`。
但是 官方是 >=12 就可以噻 | 2022-05-19T14:13:35 | 2022-05-19T14:13:35 | {
"confused": 1
} | NONE |
vuejs | core | 1,127,326,183 | 5,927 | liulinboyi | Already tick the "allow edits from maintainer". | 2022-05-16T07:31:20 | 2022-05-16T07:31:20 | {} | MEMBER |
vuejs | core | 1,128,501,515 | 4,440 | yyx990803 | closed by #5187 | 2022-05-17T07:15:35 | 2022-05-17T07:15:35 | {} | MEMBER |
vuejs | core | 1,129,043,316 | 5,940 | liulinboyi | Already tick the "allow edits from maintainer". | 2022-05-17T15:55:48 | 2022-05-17T15:55:48 | {} | MEMBER |
vuejs | core | 1,129,219,874 | 5,844 | andysay | any update? | 2022-05-17T19:06:49 | 2022-05-17T19:06:49 | {
"+1": 27
} | NONE |
vuejs | core | 1,129,551,606 | 5,126 | yyx990803 | The repro is a bit convoluted, but I can no longer reproduce this locally after b60cff05 - they are likely the same issue (Teleport used as component root) | 2022-05-18T04:24:08 | 2022-05-18T04:24:08 | {} | MEMBER |
vuejs | core | 1,129,553,533 | 5,653 | yyx990803 | Fixed via b60cff05 | 2022-05-18T04:28:11 | 2022-05-18T04:28:11 | {} | MEMBER |
vuejs | core | 1,131,073,187 | 5,939 | PatrickChen928 | I'm confused, why not use
`declare type InferDefault<P, T> = T | ((props: P) => T) `
instead of
`declare type InferDefault<P, T> = T extends null | number | string | boolean | symbol | Function ? T | ((props: P) => T) : (props: P) => T;`.
because of `never`? | 2022-05-19T02:55:41 | 2022-05-19T02:55:41 | {} | NONE |
vuejs | core | 1,129,829,701 | 5,242 | yyx990803 | General note: avoid targeting `body` with Teleport during SSR, because this makes it impossible for the Teleport to locate the correct starting location for hydration with other potential content. Instead, use a dedicated element:
```html
<body>
<div id="app">...</div>
<div id="teleports"><!-- target teleport... | 2022-05-18T10:15:47 | 2022-05-18T10:16:09 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,131,630,328 | 5,958 | liulinboyi | > Already checking here [https://github.com/vuejs/core/blob/main/packages/compiler-sfc/src/rewriteDefault.ts#L54](https://github.com/vuejs/core/blob/main/packages/compiler-sfc/src/rewriteDefault.ts?rgh-link-date=2022-05-19T12%3A28%3A04Z#L54) so is that needed?
You are right, it is not necessary. | 2022-05-19T12:34:52 | 2022-05-19T12:34:52 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,125,787,536 | 5,911 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vuejs-coverage* failed.
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 2a3d487d0b928c349fea60c5f92e4cb8c22d31ed |
|<span aria-hidden="true">🔍</span> Latest deploy log | https:/... | 2022-05-13T08:25:27 | 2022-05-17T07:02:31 | {} | NONE |
vuejs | core | 1,128,625,406 | 5,693 | qyqiang | 我也遇到了相同的问题，请问有什么合适的解决方案吗 | 2022-05-17T09:16:37 | 2022-05-17T09:16:37 | {} | NONE |
vuejs | core | 1,128,657,899 | 5,824 | yyx990803 | I don't think this is the right fix - see 847d7f78 | 2022-05-17T09:47:32 | 2022-05-17T09:47:32 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,129,433,047 | 5,937 | yyx990803 | Also need a test case | 2022-05-18T00:05:57 | 2022-05-18T00:05:57 | {} | MEMBER |
vuejs | core | 1,129,872,552 | 5,940 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vuejs-coverage* failed.
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 96f08547b8389eed21323c8405b3b0a2313fb085 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https:/... | 2022-05-18T11:05:59 | 2022-05-18T11:10:02 | {} | NONE |
vuejs | core | 1,131,156,081 | 5,933 | SunnyCrypto | @ChpShy
aware of this way, just want to avoid some unnecessary DOM nodes. | 2022-05-19T03:32:29 | 2022-05-19T03:32:29 | {} | NONE |
vuejs | core | 1,131,416,435 | 5,956 | liulinboyi | Use the `import * as imageToDisplay from 'image.jpg'`
The img path is in `default` property.
You can use like this:
```
import { default as imageToDisplay} from 'image.jpg'
``` | 2022-05-19T08:44:57 | 2022-05-19T08:44:57 | {
"heart": 1
} | MEMBER |
vuejs | core | 1,128,302,094 | 5,929 | yyx990803 | This is going to be a huge breaking change - while I understand why you may want it, it's impractical to change. | 2022-05-17T01:27:37 | 2022-05-17T01:27:37 | {} | MEMBER |
vuejs | core | 1,101,556,059 | 4,294 | brolnickij | any news..? | 2022-04-18T16:45:00 | 2022-05-17T13:09:12 | {
"-1": 1,
"confused": 2,
"eyes": 17
} | NONE |
vuejs | core | 1,131,176,117 | 4,972 | yyx990803 | Can no longer reproduce as of latest `main` | 2022-05-19T04:01:08 | 2022-05-19T04:01:08 | {} | MEMBER |
vuejs | core | 1,131,328,172 | 5,954 | liulinboyi | > @liulinboyi objects in reactive Maps will be reactive as well, and thus refs inside of them will be unwrapped, but the type doesn't reflect that - that's the problem.
You are right, the type doesn't reflect that😉. | 2022-05-19T07:26:40 | 2022-05-19T07:26:40 | {} | MEMBER |
vuejs | core | 1,131,578,131 | 5,957 | liulinboyi | 请提供更详细的信息。 | 2022-05-19T11:36:22 | 2022-05-19T11:36:22 | {} | MEMBER |
vuejs | core | 1,127,680,606 | 5,250 | volarname | same issue here: https://stackblitz.com/edit/vite-vq9eyz when i am using this prop type: `IItem | number | null`
interesting is when I use: `IItem | null | undefined` it works, but when I add any other additional primitive type like `number`, it shows warning
+1 for fix
| 2022-05-16T13:32:14 | 2022-05-16T13:32:14 | {} | NONE |
vuejs | core | 1,128,591,625 | 5,928 | DingpingZhang | > This is expected behavior - `watchEffect` always runs whenever any of its dependencies change.
>
> If you want to avoid running an effect when a certain condition doesn't change, use `watch`:
>
> ```js
> watch(() => arr.indexOf('123456'), index => {
> // only runs if index changes
> })
> ```
@yyx990803... | 2022-05-17T08:43:29 | 2022-05-17T08:43:29 | {} | NONE |
vuejs | core | 1,128,612,492 | 4,294 | ghost | Any news？ | 2022-05-17T09:04:48 | 2022-05-17T13:08:31 | {
"-1": 1,
"eyes": 1
} | NONE |
vuejs | core | 1,131,261,413 | 5,939 | PatrickChen928 |
>
> > I'm confused, why not use `declare type InferDefault<P, T> = T | ((props: P) => T) ` instead of `declare type InferDefault<P, T> = T extends null | number | string | boolean | symbol | Function ? T | ((props: P) => T) : (props: P) => T;`. because of `never`?
>
> According to [docs](https://vuejs.org/guide/... | 2022-05-19T06:18:00 | 2022-05-19T06:18:00 | {} | NONE |
vuejs | core | 1,131,724,753 | 5,957 | liulinboyi | > Can you please keep everything in English so that others also understand what is discussed here?
>
> In any case I can confirm the issue.
Starting with `v3.2.34-beta.1`, the compiled product is es2020, which requires node version node 14+ and uses new javascript features such as `?.`.
The solution is to upgr... | 2022-05-19T13:55:29 | 2022-05-19T13:55:29 | {} | MEMBER |
vuejs | core | 1,127,476,616 | 5,928 | liulinboyi | It will change in the [example](https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHNjcmlwdCBzZXR1cD5cbmltcG9ydCB7IHJlZiwgcmVhY3RpdmUsIHdhdGNoRWZmZWN0IH0gZnJvbSAndnVlJ1xuXG5jb25zdCBhcnIgPSByZWFjdGl2ZShbXSlcbndhdGNoRWZmZWN0KCgpID0+IHtcbiAgZGVidWdnZXJcbiAgY29uc29sZS5sb2coYXJyLmluZGV4T2YoJzEyMzQ1NicpKVxufSlcblxuY29uc3QgY2xpY2sgPSAoK... | 2022-05-16T10:06:28 | 2022-05-16T10:11:01 | {} | MEMBER |
vuejs | core | 1,128,304,017 | 5,926 | yyx990803 | If this CSS module needs to be accessible to external code, why place it in the component? You can just move it to an external `*.module.css` file which can then be imported anywhere.
I think this use case is to niche to warrant a dedicated API, and there is an obvious workaround. | 2022-05-17T01:31:04 | 2022-05-17T01:31:04 | {} | MEMBER |
vuejs | core | 1,129,514,024 | 5,182 | yyx990803 | See aed10c50 - the idea is correct, but it's safer to build the props during the actual transform phase. | 2022-05-18T02:55:54 | 2022-05-18T02:55:54 | {} | MEMBER |
vuejs | core | 1,131,683,323 | 5,899 | DrJume | I made a POC in Stackblitz, showing that it technically works.
https://stackblitz.com/edit/vue3-vmodel-with-slot?file=src%2FApp.vue | 2022-05-19T13:23:09 | 2022-05-19T13:23:09 | {} | CONTRIBUTOR |
vuejs | core | 1,127,522,930 | 5,928 | DingpingZhang | > About this issue, in fact Vue can't predict the result.
Yes, to be honest, I found this issue because I was writing a similar reactivity component for WPF (C#) and when I started to implement support for list, I ran into this issue. Unlike properties, read members and write members in collections are completely di... | 2022-05-16T10:56:52 | 2022-05-16T10:56:52 | {} | NONE |
vuejs | core | 1,128,328,528 | 4,294 | zhouhuiquan | Any news？ | 2022-05-17T02:16:09 | 2022-05-17T13:08:18 | {
"-1": 1
} | NONE |
vuejs | core | 1,129,538,765 | 5,940 | liulinboyi | No problem.
---Original---
From: "Evan ***@***.***>
Date: Wed, May 18, 2022 08:05 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [vuejs/core] feat: support undefined type validate in prop (PR#5940)
Can you please add a test case for this in componentProps.spec.ts?
—
... | 2022-05-18T03:56:00 | 2022-05-18T03:56:00 | {} | MEMBER |
vuejs | core | 1,130,410,861 | 5,952 | liulinboyi | [Preview](https://deploy-preview-5952--vue-sfc-playground.netlify.app/#__DEV__eyJBcHAudnVlIjoiPHNjcmlwdCBzZXR1cD5cbmltcG9ydCB7IHNoYWxsb3dSZWYgfSBmcm9tICd2dWUnO1xuaW1wb3J0IEhvbWUgZnJvbSAnLi9Ib21lLnZ1ZSc7XG5pbXBvcnQgQWJvdXQgZnJvbSAnLi9BYm91dC52dWUnO1xuY29uc3QgQ29tcG9uZW50ID0gc2hhbGxvd1JlZihIb21lKTtcbmxldCBpID0gMTtcbmNvbn... | 2022-05-18T19:16:41 | 2022-05-18T19:16:41 | {} | MEMBER |
vuejs | core | 1,131,058,733 | 5,940 | liulinboyi | > Can you please add a test case for this in `componentProps.spec.ts`?
Test has been added, All done👌. | 2022-05-19T02:45:57 | 2022-05-19T02:45:57 | {} | MEMBER |
vuejs | core | 1,131,399,606 | 5,956 | miguelliar | It appears that the problem occurs when using
`Import * as imageToDisplay`
instead of
`Import imageToDisplay` | 2022-05-19T08:30:46 | 2022-05-19T08:31:03 | {} | NONE |
vuejs | core | 1,131,611,952 | 5,957 | liulinboyi | 我看了看，是因为这个[build: output es2020 (target node 14+) for cjs/server builds](https://github.com/vuejs/core/commit/cbeb9f2d7859edbaceee0c73d2b33c578a1ffb58)，从[v3.2.34-beta.1](https://github.com/vuejs/core/releases/tag/v3.2.34-beta.1)开始，编译产物就是`es2020`了，需要`node`版本`node 14+`。 | 2022-05-19T12:14:45 | 2022-05-19T12:14:45 | {} | MEMBER |
vuejs | core | 1,131,712,559 | 5,957 | mbrodala | Can you please keep everything in English so that others also understand what is discussed here?
In any case I can confirm the issue. | 2022-05-19T13:45:21 | 2022-05-19T13:45:21 | {
"+1": 2
} | NONE |
vuejs | core | 1,127,662,271 | 5,928 | liulinboyi | You can process in you source code, like [example](https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHNjcmlwdCBzZXR1cD5cbmltcG9ydCB7IHJlZiwgcmVhY3RpdmUsIHdhdGNoRWZmZWN0LCBjb21wdXRlZCB9IGZyb20gJ3Z1ZSdcblxuY29uc3QgYXJyID0gcmVhY3RpdmUoW10pXG5jb25zdCByZXMgPSByZWFjdGl2ZShbXSlcbmxldCBvbGRWYWwgPSBudWxsXG53YXRjaEVmZmVjdCgoKSA9PiB7XG4gIG... | 2022-05-16T13:17:30 | 2022-05-16T13:39:11 | {} | MEMBER |
vuejs | core | 1,128,313,856 | 4,866 | yyx990803 | This is a design flaw in the way dynamic refs are handled in `<script setup>` - we may need to rethink the syntax in the future.
For now, the workaround is to create a plain object to hold the refs:
[Workaround 1](https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHRlbXBsYXRlPlxuICA8ZGl2IGlkPVwiZHluYW1pYy1jb21wb25lbnQtZGVtb... | 2022-05-17T01:45:38 | 2022-05-17T01:45:38 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,128,349,251 | 4,294 | Benbinbin | It's painful to reuse the props interface :weary: any satisfied solution? | 2022-05-17T02:49:14 | 2022-05-17T13:08:25 | {
"+1": 1
} | NONE |
vuejs | core | 1,103,414,675 | 4,294 | xiziliang | Is this issue still resolved? | 2022-04-20T02:44:58 | 2022-05-17T13:09:07 | {
"-1": 1,
"eyes": 6
} | NONE |
vuejs | core | 1,129,439,216 | 5,939 | yyx990803 | I don't think this fix is right - the resulting inferred type of `id` will be `() => string` instead of `string`: https://www.typescriptlang.org/play?#code/CYUwxgNghgTiAEAXAngBwQOQPaIKoDtQAzAS3xGAB4AVAPngF55r4QAPREQgZ3gFdCIUuWDwA-PHIA3EDHgAuZgG4AsACh160JFgIU6eAEl8RWQBEhUPhESUACgBpm9Ji3acek6xHgAfLwC2AEayfvDciDBkAOZhQVhY... | 2022-05-18T00:18:27 | 2022-05-18T00:18:27 | {} | MEMBER |
vuejs | core | 1,130,045,387 | 5,540 | m-ghaoui | Oh I get it now. `defineExpose()` only exposes properties. Exposing a method is a new feature.
Okay 🙂 I stand corrected. | 2022-05-18T13:52:07 | 2022-05-18T13:53:31 | {} | NONE |
vuejs | core | 1,129,042,869 | 5,940 | liulinboyi | [Preview](https://deploy-preview-5940--vue-sfc-playground.netlify.app/#eyJBcHAudnVlIjoiPHNjcmlwdCBsYW5nPVwidHNcIiBzZXR1cD5cbmltcG9ydCB7IHJlZiB9IGZyb20gJ3Z1ZSc7XG5pbXBvcnQgQ29tcCBmcm9tICcuL0NvbXAudnVlJztcblxuY29uc3QgY291bnQgPSByZWYodW5kZWZpbmVkKVxuPC9zY3JpcHQ+XG5cbjx0ZW1wbGF0ZT5cbiAgPGgxPkNvdW50ZXI6PC9oMT5cbiAgPENvbXAgO... | 2022-05-17T15:55:29 | 2022-05-19T02:48:48 | {} | MEMBER |
vuejs | core | 1,131,255,335 | 5,939 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vuejs-coverage* failed.
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | dfaeca11b3ee4475849f79db4c789ea421cf4681 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https:/... | 2022-05-19T06:08:28 | 2022-05-19T06:08:28 | {} | NONE |
vuejs | core | 1,131,586,075 | 5,957 | snvtac | > 请提供更详细的信息。
使用nvm切换node版本，12.22.8，然后请顺序执行
npm init vite@latest my-vue-app --template vue
cd my-vue-app
npm install
npm run build | 2022-05-19T11:45:24 | 2022-05-19T11:45:24 | {} | NONE |
vuejs | core | 1,131,602,965 | 5,958 | netlify[bot] | ### <span aria-hidden="true">👷</span> Deploy request for *vuejs-coverage* pending review.
[Visit the deploys page to approve it](https://app.netlify.com/sites/vuejs-coverage/deploys)
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | b7191... | 2022-05-19T12:04:43 | 2022-05-19T12:04:43 | {} | NONE |
vuejs | core | 1,129,502,055 | 5,942 | axelthat | https://github.com/vuejs/core/issues/4285 | 2022-05-18T02:28:31 | 2022-05-18T02:28:31 | {} | NONE |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.