owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 1,458,409,070 | 7,842 | LinusBorg | > I thought the slots would act like child-components. If a child-component props changes then I don't expect their "siblings" to re-render as well.
That's a misconception. they are part of the component's template, they don't act as their own components. Any reactive data accessed in the slot's content will be coll... | 2023-03-07T15:54:35 | 2023-03-07T15:54:35 | {} | MEMBER |
vuejs | core | 1,460,565,104 | 7,854 | andrei-gheorghiu | Pretty cool workaround/syntax, pointed out by [Moritz Ringler](https://stackoverflow.com/users/4883195/moritz-ringler), digged from [docs](https://vuejs.org/guide/essentials/component-basics.html#element-placement-restrictions):
```vue
<tr
is="vue:driver"
v-for="driver in drivers"
:key="driver.position"
v... | 2023-03-08T17:40:01 | 2023-03-08T17:40:01 | {} | NONE |
vuejs | core | 1,466,386,558 | 7,883 | LinusBorg | duplicate: #7329 | 2023-03-13T15:39:16 | 2023-03-13T15:39:16 | {} | MEMBER |
vuejs | core | 1,459,678,521 | 7,857 | LinusBorg | also this is not a minimial reproduction | 2023-03-08T07:49:46 | 2023-03-08T07:49:46 | {} | MEMBER |
vuejs | core | 1,459,655,419 | 7,825 | LinusBorg | Please provide a reproduction in a new issue | 2023-03-08T07:24:28 | 2023-03-08T08:05:35 | {} | MEMBER |
vuejs | core | 1,464,118,126 | 7,875 | sxzz | /ecosystem-ci run | 2023-03-10T17:15:16 | 2023-03-10T17:15:16 | {} | MEMBER |
vuejs | core | 1,464,916,264 | 7,880 | yangxiuxiu1115 | sry, i will close this pr. | 2023-03-11T13:50:55 | 2023-03-11T13:50:55 | {} | CONTRIBUTOR |
vuejs | core | 1,465,066,772 | 5,318 | yonathan9669 | Hello, I have basically the same problem as @paul-thebaud, I've been trying several workarounds by now but haven't gotten a real solution yet.
Does any of you have at least a suggestion?
My particular problem is that I'm referencing back the "parent" entity I'm dealing with in order to compute things based on its... | 2023-03-12T01:34:28 | 2023-03-12T01:35:51 | {} | NONE |
vuejs | core | 1,467,918,446 | 7,280 | daisybaicai | > > @daisybaicai
> > 改写一下index.vue :3-16 代码 就不会打印l两次
> > ```
> > <router-view v-slot="{ Component }">
> > <keep-alive v-if="$route.meta.keepAlive">
> > <component :is="Component" :key="$route.name" />
> > </keep-alive>
> > <component :is="Component" v-else :key="$route.name" />
... | 2023-03-14T11:23:51 | 2023-03-14T11:23:51 | {} | NONE |
vuejs | core | 1,468,069,274 | 7,280 | joker77877 | > > > @daisybaicai
> > > 改写一下index.vue :3-16 代码就不会打印l两次
> > > ```
> > > <router-view v-slot="{ Component }">
> > > <keep-alive v-if="$route.meta.keepAlive">
> > > <component :is="Component" :key="$route.name" />
> > > </keep-alive>
> > > <component :is="Component" v-else :key="$... | 2023-03-14T13:04:47 | 2023-03-14T13:04:47 | {
"+1": 1
} | NONE |
vuejs | core | 1,471,267,358 | 7,879 | haoqunjiang | Duplicate of https://github.com/vuejs/core/issues/7342 | 2023-03-16T04:01:17 | 2023-03-16T04:01:17 | {} | MEMBER |
vuejs | core | 1,458,896,236 | 4,404 | retail-robot | Hi all - are there any specific blockers to moving forward with incorporating this change (aside from resolving the branch conflicts?) I notice this PR hasn't received any updates since last year and was wondering if there's anything I can do to help it along? | 2023-03-07T21:26:02 | 2023-03-07T21:26:02 | {
"+1": 2
} | NONE |
vuejs | core | 1,459,125,870 | 7,854 | skirtles-code | I believe this is a consequence of using an in-DOM template, as documented at <https://vuejs.org/guide/essentials/component-basics.html#element-placement-restrictions>.
The HTML in the template gets processed by the browser before Vue gets access to it. Consider the following example, which doesn't involve Vue:
<... | 2023-03-08T01:27:36 | 2023-03-08T01:27:36 | {
"+1": 1,
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 1,459,146,597 | 7,854 | andrei-gheorghiu | Interesting. Thanks for the explanation. Makes perfect sense.
Coincidental or not, using `<template />` as the vessel for Vue templates therefore allowing them anywhere, even in elements with a very short list of allowed children, was a smart choice, to say the least.
I guess that settles this issue, then.
Th... | 2023-03-08T01:56:01 | 2023-03-08T01:56:23 | {} | NONE |
vuejs | core | 1,463,080,616 | 7,872 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/4380468731)
| suite | result |
|-------|--------|
| [naive-ui](https://github.com/vuejs/ecosystem-ci/actions/runs/4380468731/jobs/7667572105) | :x: failure |
| [nuxt](https://github.com/vuejs/ecosystem-ci/actions/runs/4380468731/jobs/7667... | 2023-03-10T01:39:26 | 2023-03-10T01:45:27 | {} | CONTRIBUTOR |
vuejs | core | 1,463,361,538 | 7,853 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/4382128640)
| suite | result |
|-------|--------|
| [naive-ui](https://github.com/vuejs/ecosystem-ci/actions/runs/4382128640/jobs/7670867814) | :x: failure |
| [nuxt](https://github.com/vuejs/ecosystem-ci/actions/runs/4382128640/jobs/7670... | 2023-03-10T07:01:14 | 2023-03-10T07:07:28 | {} | CONTRIBUTOR |
vuejs | core | 1,464,915,453 | 7,880 | skirtles-code | I think this may be a duplicate of #7341. | 2023-03-11T13:46:35 | 2023-03-11T13:46:35 | {} | CONTRIBUTOR |
vuejs | core | 1,471,689,430 | 7,875 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/4436021966)
| suite | result |
|-------|--------|
| [naive-ui](https://github.com/vuejs/ecosystem-ci/actions/runs/4436021966/jobs/7783926371) | :x: failure |
| [nuxt](https://github.com/vuejs/ecosystem-ci/actions/runs/4436021966/jobs/7783... | 2023-03-16T10:28:50 | 2023-03-16T10:35:08 | {} | CONTRIBUTOR |
vuejs | core | 1,461,411,591 | 7,864 | LinusBorg | Ricardo is right `shapeFlag` is not a unique value, so it does not work as a key. | 2023-03-09T06:50:18 | 2023-03-09T06:50:18 | {} | MEMBER |
vuejs | core | 1,462,788,031 | 3,948 | dreadkopp | bump | 2023-03-09T20:50:56 | 2023-03-09T20:50:56 | {
"-1": 4
} | NONE |
vuejs | core | 1,463,850,581 | 7,871 | d-ryabtsev | > The prefix 'on' is considered an event. It is not recommended to use the 'on' prefix as a boolean attribute.
I appreciate that but this is not obvious from the docs and it is something that is difficult to change in large applications when moving from Vue 2 to Vue 3. | 2023-03-10T14:04:29 | 2023-03-10T14:04:29 | {} | NONE |
vuejs | core | 1,465,186,977 | 7,882 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-next-template-explorer* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 6456ba1764b9832f4fb1a028cba68a3c3904303e |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/s... | 2023-03-12T12:40:57 | 2023-03-12T12:40:57 | {} | NONE |
vuejs | core | 1,465,127,782 | 7,818 | wenfangdu | @LinusBorg `satisfies` works in this case:
```ts
interface A {
a: string
}
const a1: A = {
a: 'a',
b: '', // 👈 thrown
}
const a2 = reactive({
a: 'a',
b: '', // 👈 thrown
} satisfies A)
```
But it doesn't work in this case:
```ts
interface A {
a(): void
}
const a1: A = reactive({
... | 2023-03-12T08:45:31 | 2023-03-12T12:44:00 | {} | NONE |
vuejs | core | 1,468,206,352 | 7,894 | skirtles-code | This appears to be working correctly to me.
`msg.value` and `props.updateFileData` are the same object. This is creating a shallow copy of that object:
```js
const formData = reactive({
...props.updateFileData
});
```
So `formData` is a different object. But the nested object in `msg.value.test` and `pro... | 2023-03-14T14:29:16 | 2023-03-14T14:29:16 | {} | CONTRIBUTOR |
vuejs | core | 1,459,745,239 | 4,404 | gnuletik | @retail-robot we are waiting for maintainers feedback. | 2023-03-08T08:39:42 | 2023-03-08T08:39:42 | {
"+1": 4
} | NONE |
vuejs | core | 1,461,666,822 | 4,836 | defaude | Hey @posva 👋 Anything else I should do or could/should this be merged now? 🦄 | 2023-03-09T09:38:41 | 2023-03-09T09:38:41 | {} | CONTRIBUTOR |
vuejs | core | 1,465,173,158 | 7,818 | wenfangdu | Related: https://github.com/microsoft/TypeScript/issues/53212 | 2023-03-12T11:48:09 | 2023-03-12T11:48:09 | {} | NONE |
vuejs | core | 1,462,028,612 | 7,868 | yangxiuxiu1115 | When you use `defineProps<Type>()`, you should give `trueValue `and `falseValue ` a default value. [playground](https://sfc.vuejs.org/#eNrtVkuP2jAQ/itWDhAkSKQeA0vVxx7aw7bSVntZ9hCSAbJN7Mh29iHKf+/4lcSBpWqrSlVVpF3seXk8881n9sGbuo4eGgiSYCGhqstUwnJFCX4WMl2XQNaM58CtTEm7tdrly5uUFymVixjXvuYDrZtT8pu0bMCT4+bcETlsCgqfOatFOCqzZj0fc... | 2023-03-09T13:02:42 | 2023-03-09T13:02:42 | {} | CONTRIBUTOR |
vuejs | core | 1,462,372,878 | 7,824 | LinusBorg | We are aware that the forum has been down and up again for the last few weeks. Unfortunately, the problem proves not to be easily resolved. We will continue working on it, but it might take some time to gett stable again.
Unfortunately none of us is very proficient in running and optimizing a Discourse Forum.
PS... | 2023-03-09T16:33:15 | 2023-03-09T16:33:15 | {} | MEMBER |
vuejs | core | 1,463,068,443 | 7,871 | edison1105 | The prefix 'on' is considered an event. It is not recommended to use the 'on' prefix as a boolean attribute. | 2023-03-10T01:21:04 | 2023-03-10T01:21:04 | {} | MEMBER |
vuejs | core | 1,466,903,251 | 7,889 | LinusBorg | I get your point, at least to an extent, but would like to understand the provided example better.
What would have been your *expected* behavior? Should it be ignored or somehow still passed down as an attribute?
* The former would be technically feasable (yet a breaking change without using `inheritAttrs: false... | 2023-03-13T20:21:37 | 2023-03-13T20:23:24 | {} | MEMBER |
vuejs | core | 1,461,553,466 | 7,864 | eloen1998 | > Ricardo is right `shapeFlag` is not a unique value, so it does not work as a key.
thx.
At first,i just want to set a key to test, but then i forget to correct it, and only think its a bug with computed and slots.
Sorry to interrupt. | 2023-03-09T08:28:12 | 2023-03-14T09:03:55 | {} | NONE |
vuejs | core | 1,469,545,758 | 4,737 | wcycode | I have same error，is there any progress?
| 2023-03-15T08:15:30 | 2023-03-15T08:15:30 | {} | NONE |
vuejs | core | 1,458,841,778 | 7,843 | LinusBorg | The Custom Elements standard does have slots, but the work differently than Vue slots. To receive content passed into the slots of a custom element, we have to mount an actual `<slot></slot>` element in the DOM.
If you choose to write your own render function, you need to do that yourself:
```js
customElements.d... | 2023-03-07T20:38:57 | 2023-03-07T20:39:24 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,460,067,753 | 7,851 | edison1105 | Currently, TS 4.9 is not supported yet.
Maybe we should fix this issue after merging https://github.com/vuejs/core/pull/7141. | 2023-03-08T12:15:08 | 2023-03-08T12:15:08 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,460,706,624 | 7,853 | simlevesque | Done. | 2023-03-08T19:01:07 | 2023-03-08T19:01:07 | {} | CONTRIBUTOR |
vuejs | core | 1,462,299,180 | 7,868 | LinusBorg | Hi Chris, good to see you! 😀
Ricardo is right here - the issue is that in the TS example you did not provide default values. | 2023-03-09T15:51:50 | 2023-03-09T15:51:50 | {} | MEMBER |
vuejs | core | 1,467,308,980 | 1,102 | haoqunjiang | Seems you are using Storybook. According to this issue in the Storybook repository: https://github.com/storybookjs/storybook/issues/17290, it's already fixed in Storybook 7.0.
If you are still experiencing this issue after updating the dependencies, please open a new issue with an updated reproduction. Thanks for repo... | 2023-03-14T03:50:17 | 2023-03-14T03:50:17 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,490,511,982 | 4,064 | bchazelle-ubitransport | I also encountered this problem after a rollup build using `@vue/compiler-dom`, and I solved it by redefining the `decodeEntities` option with the default implementation provided by https://github.com/vuejs/core/blob/main/packages/compiler-core/src/parse.ts#L77
```
const decodeRE = /&(gt|lt|amp|apos|quot);/g
... | 2023-03-30T15:32:59 | 2023-03-30T15:40:38 | {} | NONE |
vuejs | core | 1,491,415,299 | 6,370 | Autumn-one | I had the same problem. I expected to completely destroy the vnode in the beforeMount in directive, but I didn't find a way to do it @yyx990803 | 2023-03-31T07:06:00 | 2023-03-31T07:06:00 | {} | NONE |
vuejs | core | 1,491,587,464 | 4,836 | yyx990803 | @defaude Thanks for your hard work and patience! This is great. | 2023-03-31T09:05:56 | 2023-03-31T09:05:56 | {
"heart": 4
} | MEMBER |
vuejs | core | 1,491,590,946 | 7,661 | nestle49 | 
| 2023-03-31T09:07:25 | 2023-03-31T09:21:18 | {} | NONE |
vuejs | core | 1,493,201,517 | 7,997 | yyx990803 | @skirtles-code great review, fixed!
@jods4 getters only happen at the boundaries between component setup code and composables. There is no need to unwrap them in templates. Always forcing refs creates inefficiency by allocating extra one-off refs and syntax fluff. Passing getters and normalizing into values at the e... | 2023-04-02T02:13:37 | 2023-04-02T02:17:31 | {
"+1": 6
} | MEMBER |
vuejs | core | 1,495,294,580 | 8,020 | yanyunwu | 求求 | 2023-04-04T03:29:33 | 2023-04-04T03:29:33 | {} | NONE |
vuejs | core | 1,484,630,670 | 7,921 | wwereal | Does also not work on Windows+Chrome | 2023-03-27T07:18:56 | 2023-04-05T09:43:55 | {} | NONE |
vuejs | core | 1,491,153,382 | 6,459 | yyx990803 | Landed in fe619443 | 2023-03-31T01:09:04 | 2023-03-31T01:09:04 | {
"confused": 1
} | MEMBER |
vuejs | core | 1,492,920,885 | 7,982 | sxzz | /ecosystem-ci run | 2023-04-01T10:43:44 | 2023-04-01T10:43:44 | {} | MEMBER |
vuejs | core | 1,493,391,791 | 8,004 | LinusBorg | Components with an async setup only work when they are descendants of a Suspense component, because that Suspense component essentially awaits the async setup | 2023-04-02T17:01:38 | 2023-04-02T17:01:38 | {} | MEMBER |
vuejs | core | 1,493,923,997 | 7,982 | yyx990803 | Update: added support so that `SlotsType` and `defineSlots` also support using direct function types to declare slots. This may be needed if Volar supports strict children type checks in the future, or in cases where some component libraries internally use multiple arguments for slots.
```vue
<script setup lang="ts... | 2023-04-03T08:48:27 | 2023-04-03T08:48:27 | {
"+1": 12,
"hooray": 3
} | MEMBER |
vuejs | core | 1,494,060,198 | 8,008 | LinusBorg | You example fels very i complete, also your stackoverflow question has an accepted answer so i dont really get what you are asking for.
One thing i can tell you is that we will definitely not put anything on `window`. | 2023-04-03T10:18:42 | 2023-04-03T10:19:24 | {} | MEMBER |
vuejs | core | 1,495,710,298 | 8,020 | yyx990803 | 分支切换问题，自己切完跑下 `git clean -f` | 2023-04-04T10:17:25 | 2023-04-04T10:17:25 | {} | MEMBER |
vuejs | core | 1,495,767,202 | 4,314 | luckylooke | This feature would really help for migrations of legacy projects to Vue, not every Vue app is build from scratch 😞 | 2023-04-04T10:59:26 | 2023-04-04T10:59:26 | {
"+1": 8
} | NONE |
vuejs | core | 1,497,194,656 | 8,025 | yyx990803 | This *happens to work* at runtime, but should be considered undocumented behavior that may change in the future. It is safer to not allow this at the type level. You should also just wrap your own functions together. | 2023-04-05T09:32:45 | 2023-04-05T09:32:45 | {} | MEMBER |
vuejs | core | 1,490,697,542 | 7,982 | pikax | @sxzz the second case is not possible, the object keys can be optional, but the first argument will always be present(as soon as you don't call it manually, which is not advised if you don't know what you're doing) | 2023-03-30T17:52:12 | 2023-03-30T17:52:12 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,491,735,609 | 7,661 | LinusBorg | Can you provide any more info about your use case? | 2023-03-31T10:53:37 | 2023-03-31T10:53:43 | {} | MEMBER |
vuejs | core | 1,493,385,598 | 8,004 | leejaypower | I removed async from the setup function and created a separate function, and it works fine. It's resolved!
```typescript
export default {
setup() { // remove async
...
const loadData = async () => {
await fetchSomething();
};
loadData();
}
...
};
```
But I want to know why(I'd like... | 2023-04-02T16:31:02 | 2023-04-02T16:42:12 | {} | NONE |
vuejs | core | 1,493,880,406 | 6,219 | msojocs | > @msojocs 抱歉这个我不是很清楚，我只是用vue有提供的api来包个壳，没有使用过这种方式。 你用的这个方式，如果vue组件内部的构成变更了，可能就不能正常使用了。
感谢，确实发生发一些问题。（scoped css 出现了问题。。）
编辑：
用 `Object.keys(component)` 暂时解决了 | 2023-04-03T08:15:21 | 2023-04-03T08:21:19 | {} | NONE |
vuejs | core | 1,492,012,606 | 7,997 | jods4 | @yyx990803 why introduce yet another way to transport a single value when we already have one?
I understand you're providing new helper functions to handle all 3 cases, but do we need them and the added complexity?
Are you gonna auto "un-wrap" getters in templates?
I think 2 cases is enough, what would be wrong w... | 2023-03-31T14:29:04 | 2023-03-31T14:29:04 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 1,489,905,974 | 7,661 | nestle49 | This is bad april joke? Should we take a few years off the project until this is fixed?
@yyx990803 @LinusBorg | 2023-03-30T08:30:41 | 2023-04-02T13:25:32 | {} | NONE |
vuejs | core | 1,495,440,935 | 8,023 | baiwusanyu-c | it not a bug, you should use `onContextmenu`
````
import { defineComponent, h, withModifiers } from 'vue'
export default defineComponent({
name: 'Comp',
setup() {
return () => h('div', {
onContextmenu: withModifiers(() => {
alert(1)
}, ['right', 'prevent']),
}, '哈哈哈')
}
}... | 2023-04-04T06:52:26 | 2023-04-04T06:52:26 | {} | MEMBER |
vuejs | core | 1,496,409,454 | 5,767 | VamoCodar | he same problem with Hot reload not updating
It happened to me
vue 3.2.45
quasar/app-vite: 1.2.1,
quasar: 2.11.10,
I changed the vue to version 3.2.38 and it solved | 2023-04-04T18:23:19 | 2023-04-04T18:23:19 | {} | NONE |
vuejs | core | 1,497,216,867 | 7,300 | steveworkman | Superceeded by #8035 | 2023-04-05T09:50:35 | 2023-04-05T09:50:35 | {} | NONE |
vuejs | core | 1,497,420,676 | 5,165 | cn-2k | still getting this error on ^3.2.47 | 2023-04-05T12:39:44 | 2023-04-05T12:39:44 | {} | NONE |
vuejs | core | 1,491,153,666 | 7,113 | yyx990803 | Landed in 482f2e34 | 2023-03-31T01:09:28 | 2023-03-31T01:09:28 | {
"confused": 1
} | MEMBER |
vuejs | core | 1,491,605,895 | 7,997 | Akryum | I like this! I guess we will be able to write:
```js
export function useQuery (variables) {
watch(toRef(variables), (value) => {})
}
useQuery(() => props.foo)
```
? | 2023-03-31T09:14:08 | 2023-03-31T09:15:35 | {} | MEMBER |
vuejs | core | 1,491,987,859 | 1,366 | skirtles-code | Evan has opened a PR that, among other things, adds `MaybeRef`: #7997. | 2023-03-31T14:11:25 | 2023-03-31T14:11:25 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 1,493,595,355 | 1,330 | smallnine9 | @sodatea we can add --sourcemap or -s to build with source maps, dose it satisfy demmand? | 2023-04-03T03:35:38 | 2023-04-03T03:35:38 | {
"rocket": 1
} | CONTRIBUTOR |
vuejs | core | 1,493,989,301 | 7,761 | JayFate | @yyx990803 @sxzz @Justineo Updated.
Is this commit necessary any more ? | 2023-04-03T09:30:36 | 2023-04-03T09:30:36 | {} | CONTRIBUTOR |
vuejs | core | 1,496,866,872 | 8,031 | yu5056561661 | > 组件上面的ref不能省略。InstanceType只是为了让你拿到子组件的类型，调用子组件方法的时候有类型提示。
我理解的，是拿到实例。然后我又去看了下文档，是拿到实例类型，我两个概念混合了 | 2023-04-05T03:19:16 | 2023-04-05T03:19:16 | {} | NONE |
vuejs | core | 1,496,923,763 | 7,525 | baiwusanyu-c | Are v-models for custom elements planned? | 2023-04-05T05:07:08 | 2023-04-05T05:07:08 | {} | MEMBER |
vuejs | core | 1,497,443,287 | 6,463 | aKzenT | Same issue here. | 2023-04-05T12:57:47 | 2023-04-05T12:57:47 | {} | NONE |
vuejs | core | 1,486,146,105 | 6,459 | yyx990803 | ~~We are deprecating `withDefaults()` in favor of reactive props destructure, so let's avoid complicating the codebase for it.~~ | 2023-03-28T03:20:11 | 2023-03-31T01:08:55 | {} | MEMBER |
vuejs | core | 1,491,633,359 | 7,661 | LinusBorg | This user has now been blocked for 7 days.
We will still investigate and fix this issue once we have the capacity for it.
As a workaround for other people, consider conditionally adding this callback on on the client.
If you need it on the server, please describe the specific use case.
| 2023-03-31T09:35:41 | 2023-03-31T10:53:02 | {} | MEMBER |
vuejs | core | 1,493,962,062 | 7,781 | ur92 | Thank for this fix, can you proceed to merge it?
We have a large Vue2/TS application that we want to migrate but currently we're stuck.
Thanks | 2023-04-03T09:12:26 | 2023-04-03T09:12:26 | {
"+1": 4
} | NONE |
vuejs | core | 1,494,770,522 | 8,015 | sxzz | This is an issue that requires consideration. In my opinion, using `v-generic` (in line with `<script setup lang="ts" generic="T">`) would be preferable. It's not feasible to add generics to the element tag as we need to maintain compatibility with native HTML code.
For slots, see https://github.com/vuejs/core/pull/... | 2023-04-03T18:17:12 | 2023-04-03T18:25:05 | {
"+1": 4
} | MEMBER |
vuejs | core | 1,491,542,245 | 7,997 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/4573234579)
| suite | result |
|-------|--------|
| [naive-ui](https://github.com/vuejs/ecosystem-ci/actions/runs/4573234579/jobs/8073420146) | :white_check_mark: success |
| [nuxt](https://github.com/vuejs/ecosystem-ci/actions/runs/45732... | 2023-03-31T08:44:19 | 2023-03-31T09:09:12 | {} | CONTRIBUTOR |
vuejs | core | 1,493,804,233 | 6,219 | chenhaihong | @msojocs 抱歉这个我不是很清楚，我只是用vue有提供的api来包个壳，没有使用过这种方式。
你用的这个方式，如果vue组件内部的构成变更了，可能就不能正常使用了。 | 2023-04-03T07:15:56 | 2023-04-03T07:15:56 | {} | NONE |
vuejs | core | 1,493,862,521 | 8,009 | JayFate | @sxzz Do you have a minute to review this PR ? THX | 2023-04-03T08:03:52 | 2023-04-03T08:03:52 | {} | CONTRIBUTOR |
vuejs | core | 1,494,702,224 | 8,014 | leopiccionia | If a key is not present on the map, it'd return `undefined` instead of `false`. So the conversion seems necessary. | 2023-04-03T17:22:14 | 2023-04-03T17:22:14 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 1,494,777,171 | 4,092 | sxzz | Done in #7982 | 2023-04-03T18:22:54 | 2023-04-03T18:22:54 | {
"hooray": 1
} | MEMBER |
vuejs | core | 1,496,864,552 | 7,645 | yyx990803 | This isn't the right fix, since `_cache` isn't actually passed to `ssrRender` in `server-renderer`. The better fix is disabling `v-once` transform which is unnecessary during SSR anyway. See 05f94cf7 | 2023-04-05T03:15:52 | 2023-04-05T03:15:52 | {} | MEMBER |
vuejs | core | 1,497,008,231 | 7,645 | yyx990803 | @danielroe I discovered those were additional arguments originally passed for an optimization attempt, but were accidentally left when I abandoned that attempt. They are now removed in 2a9e3796 | 2023-04-05T06:56:13 | 2023-04-05T06:56:13 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,491,541,802 | 7,997 | yyx990803 | /ecosystem-ci run | 2023-03-31T08:43:56 | 2023-03-31T08:43:56 | {} | MEMBER |
vuejs | core | 1,494,311,634 | 8,016 | LinusBorg | This does not seem to be related to Vue core. If it is, please provide a minimal production without these huge dependencies. | 2023-04-03T13:18:08 | 2023-04-03T13:18:08 | {} | MEMBER |
vuejs | core | 1,495,190,644 | 8,017 | FliPPeDround | According to the **@vue/compiler-sfc** error message, you can use it like this
```
const { error } = useRequest();
watch(() => error, () => {
});
``` | 2023-04-04T00:55:02 | 2023-04-04T00:55:02 | {} | NONE |
vuejs | core | 1,496,861,598 | 8,031 | edison1105 | 组件上面的 ref 不能省略。InstanceType 只是为了让你拿到子组件的类型，调用子组件方法的时候有类型提示。 | 2023-04-05T03:09:57 | 2023-04-05T03:09:57 | {} | MEMBER |
vuejs | core | 1,497,462,509 | 8,025 | KaelWD | I ran into this because we're passing through events that are defined as props so we can check if they're set. Vue already merges inherited events into an array so we either get a runtime warning from only allowing a function or a typescript error trying to bind the prop to an element.
https://sfc.vuejs.org/#eNqdUs... | 2023-04-05T13:10:53 | 2023-04-05T13:10:53 | {} | CONTRIBUTOR |
vuejs | core | 1,490,384,767 | 7,268 | stondbringa | Safari on iOS < 12 also impacted | 2023-03-30T14:14:53 | 2023-03-30T14:14:53 | {
"+1": 1
} | NONE |
vuejs | core | 1,491,463,203 | 7,982 | pikax | > I think there's a safer way to mark scope as optional
>
> ```ts
> const slots = defineSlots<{
> default: { foo: string; bar: number }
> optionalSlot?: string // it's an optional slot, but the scope is always present
> optionalScope: undefined | string // it's a required slot, but the scope is optional (c... | 2023-03-31T07:48:50 | 2023-03-31T07:48:50 | {} | MEMBER |
vuejs | core | 1,491,599,305 | 7,661 | nestle49 | 
| 2023-03-31T09:11:06 | 2023-03-31T09:20:49 | {} | NONE |
vuejs | core | 1,495,407,765 | 8,017 | baiwusanyu-c | I think maybe this is a bug. When the compiler checks `watch` and `toRef`, it also checks variables that are not props destructured, but these variables should not be checked. And the behavior it exhibits is inconsistent with previous versions, which is enough to show that it is a bug
wdyt? @sxzz 👀 | 2023-04-04T06:14:30 | 2023-04-04T06:20:35 | {
"+1": 2
} | MEMBER |
vuejs | core | 1,491,614,088 | 7,997 | yyx990803 | Yes - although I'd write:
```js
export function useQuery (variables) {
watch(() => toValue(variables), (value) => {})
}
```
which would be more efficient as it doesn't create an intermediate ref. | 2023-03-31T09:20:25 | 2023-03-31T09:20:25 | {
"+1": 15,
"heart": 2
} | MEMBER |
vuejs | core | 1,493,938,153 | 8,012 | yyx990803 | Can you also add type-related test cases here? https://github.com/vuejs/core/blob/main/packages/dts-test/tsx.test-d.tsx | 2023-04-03T08:58:23 | 2023-04-03T08:58:23 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,493,975,949 | 8,009 | JayFate | @sxzz Updated | 2023-04-03T09:21:20 | 2023-04-03T09:21:20 | {} | CONTRIBUTOR |
vuejs | core | 1,493,977,679 | 8,012 | basil-gor | > Can you also add type-related test cases here? https://github.com/vuejs/core/blob/main/packages/dts-test/tsx.test-d.tsx
Sure. Done ✅ | 2023-04-03T09:22:30 | 2023-04-03T09:22:30 | {} | CONTRIBUTOR |
vuejs | core | 1,494,777,662 | 2,693 | sxzz | Very grateful for your PR. I didn't even notice this PR before #7982. So I close this. | 2023-04-03T18:23:21 | 2023-04-03T18:23:21 | {} | MEMBER |
vuejs | core | 1,495,470,723 | 8,023 | gumingWu | > it not a bug, you should use `onContextmenu`
>
> ```
> import { defineComponent, h, withModifiers } from 'vue'
>
> export default defineComponent({
> name: 'Comp',
> setup() {
> return () => h('div', {
> onContextmenu: withModifiers(() => {
> alert(1)
> }, ['right', 'prevent']... | 2023-04-04T07:19:49 | 2023-04-04T07:19:49 | {} | NONE |
vuejs | core | 1,495,721,600 | 7,837 | baiwusanyu-c | cc @yyx990803 👀 | 2023-04-04T10:26:24 | 2023-04-04T10:26:24 | {} | MEMBER |
vuejs | core | 1,496,971,245 | 7,645 | danielroe | Thank you!
In local testing I found that an empty object was being passed in the `_cache` slot - what was that? | 2023-04-05T06:13:50 | 2023-04-05T06:13:50 | {} | MEMBER |
vuejs | core | 1,490,376,414 | 7,267 | stondbringa | Safari on iOS < 12 also impacted | 2023-03-30T14:10:28 | 2023-03-30T14:10:28 | {} | NONE |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.