Datasets:
open-index
/
open-github-issues

Dataset card Data Studio Files
xet
 Community
1
owner
stringclasses
14 values
repo
stringclasses
14 values
id
int64
116k
4.61B
issue_number
int32
1
181k
author
stringlengths
1
39
body
stringlengths
1
262k
created_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:16:18
updated_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:22:56
reactions
unknown
author_association
stringclasses
5 values
vuejs
core
1,845,623,483
8,987
SavkaTaras
Hello @LinusBorg , @sxzz , @baiwusanyu-c , I hope you are well. I'm still getting the issue after updating "@vitejs/plugin-vue": "^4.5.2". Please let me know if you guys can reproduce. I pushed updated package versions into the repo. Thank you, Taras
2023-12-07T16:09:12
2023-12-07T16:09:12
{}
NONE
vuejs
core
1,847,284,028
8,374
codspeed-hq[bot]
## [CodSpeed Performance Report](https://codspeed.io/vuejs/core/branches/types_support_generic_slots_based_on_keys) ### Merging #8374 will **not alter performance** <sub>Comparing <code>types_support_generic_slots_based_on_keys</code> (1f4b0b2) with <code>main</code> (0d61b42)</sub> ### Summary `✅ 53` untouched b...
2023-12-08T14:32:24
2023-12-08T14:32:24
{}
NONE
vuejs
core
1,772,036,299
7,188
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------ | ------- | ------------------- | | runtime-dom.global.prod.js | 87 kB | 33.1 kB | 29.9 kB (**-7 B**) | | vue.global.prod.js | 133 kB | 49.9 kB | 44.7 kB (**-49 B**) | #...
2023-10-20T03:53:01
2023-12-08T15:05:27
{}
NONE
vuejs
core
1,847,810,334
9,786
prashantpalikhe
Noticed initially when using `v-show` on a child component of a Nuxt component `<NuxtClientFallback />` as reported [here](https://github.com/nuxt/nuxt/issues/24650)
2023-12-08T20:33:15
2023-12-08T20:34:24
{}
NONE
vuejs
core
1,842,120,118
9,741
baiwusanyu-c
https://play.vuejs.org/#__DEV__eNp9Uk1v1DAQ/SvGl2SlJRH0FrIrKKoESEDFhzise4iSSXDXsS3bWRZF+e/MOM2ytKWXxOP3ZuaN5438jbXZYQBe8NLXTtrAPITBboWWvTUusJE5aNnEWmd6liA1OUFvTW/v7rOcAqqUvBJa6NpoH1jvO7ah/DR5B0oZ9sM41TxLVgtBSfzMjF3yMlmz5EVyg2iZz2JQBgYBequqABgxVjbywF7XStb7jeB3BXaUJ3gkICUKOzxvjUNKKjF/zaRu4LjCX2wqOCt01QPiBFO4h98UEU3wfO6VY...
2023-12-06T05:35:34
2023-12-06T05:35:34
{ "+1": 1 }
MEMBER
vuejs
core
1,843,966,788
8,780
zh-lx
> This patch breaks everything. > > I am using custom components: > > ``` > <ext-dialog width="500" height="90%"> > ``` > > No `width` / `height` passwd to the component. I don't think it was caused by this change, but was caused by https://github.com/vuejs/core/commit/9845f1d2a1ea8df7ae6db7ac3e012d1989fb...
2023-12-07T01:06:02
2023-12-07T01:34:51
{}
CONTRIBUTOR
vuejs
core
1,844,077,433
9,698
Alfred-Skyblue
https://github.com/vuejs/core/issues/9697#issuecomment-1844065579
2023-12-07T02:09:05
2023-12-07T02:09:05
{}
MEMBER
vuejs
core
1,845,231,269
9,772
alpalex
i mean now i have to somehow (lol) make sure, no component uses the same class for their root node, if they include the other, which is hard to guarantee when you have hundreds of components. I would rather turn off that feature (and use `:deep()`) instead of having to spend hours debugging non obvious behavior ...
2023-12-07T12:10:17
2023-12-07T12:10:17
{}
NONE
vuejs
core
1,846,742,662
8,354
baiwusanyu-c
``` import { h, defineComponent } from "vue"; import "./index.less"; export default defineComponent({ name: "JinkeButton", props: {}, emits: ['testClick'], setup(props, { attrs, slots, emit, expose }) { return () => h( "button", { onClick: (e) => { ...
2023-12-08T08:15:02
2023-12-08T08:15:31
{}
MEMBER
vuejs
core
1,848,971,465
9,676
michealroberts
@LinusBorg I have changed the repository where this is to public: the corresponding PR for replication is found here: https://github.com/observerly/observerly/pull/1032 I have removed all usage of the focus-trap functionality ...
2023-12-10T13:51:59
2023-12-10T13:51:59
{}
NONE
vuejs
core
1,843,965,969
9,762
zh-lx
> I think it is related to this update: #8781 This update only has an impact on emmed tag such as `<img />`、`<video />`、`<canvas />`，it won't affect custom element. For a custom element, browser doesn't support set width and height by `<ext-dialog width="100" height="100" >`, instead, you should set width and height...
2023-12-07T01:05:01
2023-12-07T01:05:01
{}
CONTRIBUTOR
vuejs
core
1,844,124,986
9,766
yyx990803
This just happens to work in Vue 2 (unfortunately), but is not expected behavior in Vue 3. Either refactor to use destructuring, or prefix your template expressions with `state.`.
2023-12-07T02:44:43
2023-12-07T02:44:43
{}
MEMBER
vuejs
core
1,844,197,771
9,767
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 86.9 kB | 33 kB | 29.8 kB | | vue.global.prod.js | 133 kB | 49.9 kB | 44.7 kB | ### Usages | Name | Size |...
2023-12-07T03:30:17
2023-12-07T03:30:17
{}
NONE
vuejs
core
1,844,935,193
9,770
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------------------ | ------- | ------------------- | | runtime-dom.global.prod.js | 86.9 kB (**+4 B**) | 33 kB | 29.8 kB (**+11 B**) | | vue.global.prod.js | 133 kB (...
2023-12-07T08:55:09
2023-12-07T08:55:09
{}
NONE
vuejs
core
1,818,282,861
9,638
codspeed-hq[bot]
## [CodSpeed Performance Report](https://codspeed.io/vuejs/core/branches/sxzz:benchmark) ### Congrats! CodSpeed is installed 🎉 `🆕` **53 new benchmarks were detected.** You will start to see performance impacts in the reports once the benchmarks are run from your default branch. <details> <summary><h3>Detected ...
2023-11-20T06:06:20
2023-12-08T10:18:52
{}
NONE
vuejs
core
1,849,139,328
9,799
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------ | ------- | ------- | | runtime-dom.global.prod.js | 87 kB | 33.1 kB | 29.9 kB | | vue.global.prod.js | 133 kB | 49.9 kB | 44.7 kB | ### Usages | Name | Size | Gzi...
2023-12-11T00:10:34
2023-12-11T00:10:34
{}
NONE
vuejs
core
1,279,964,253
6,851
baiwusanyu-c
As @zhangzhonghe said, when fixing bug #6591 , @yyx990803 removed the reference to the dom on the hoisted vnodes to avoid memory leaks, you can bind a key to avoid hoisted ```` <template> <Comp><div key='wqewqewq'> wqewqewq </div></Comp> </template> ````
2022-10-16T12:55:17
2023-12-06T08:54:54
{}
MEMBER
vuejs
core
1,843,830,182
9,762
zdm
Also I am using this settings in my webpack config ``` { "loader": "vue-loader", "options": { "compilerOptions": { "isCustomElement": tag => tag.startsWith( "ext-" ), ...
2023-12-06T23:05:10
2023-12-06T23:05:10
{}
NONE
vuejs
core
1,844,859,883
9,756
vue-bot
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/7125357841) | suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/7110372372) | |-------|--------|----------------| | language-tools | :x: [failure](https://github.com/vuejs/ecosystem-ci/actions/runs/712...
2023-12-07T08:10:39
2023-12-07T08:10:39
{}
CONTRIBUTOR
vuejs
core
1,845,195,210
9,771
Alfred-Skyblue
Values of object types are recursively unwrapped. Due to TypeScriptinability to recognize whether the values in your generic type include the Ref type, it recursively unwraps the values of the object. As a result, an `UnwrapRefSimple<T>` type is obtained. You can try handling this issue as follows: ```ts const re...
2023-12-07T11:42:55
2023-12-07T11:42:55
{}
MEMBER
vuejs
core
1,846,636,840
8,987
sxzz
`vue@3.3.11` is released now.
2023-12-08T06:54:55
2023-12-08T06:54:55
{ "+1": 2 }
MEMBER
vuejs
core
1,847,460,741
8,532
codspeed-hq[bot]
## [CodSpeed Performance Report](https://codspeed.io/vuejs/core/branches/feat/expose-DefineProps) ### Merging #8532 will **not alter performance** <sub>Comparing <code>feat/expose-DefineProps</code> (0307abf) with <code>main</code> (60415b5)</sub> ### Summary `✅ 53` untouched benchmarks
2023-12-08T16:12:10
2023-12-08T16:12:10
{}
NONE
vuejs
core
1,849,088,136
9,676
LinusBorg
Sure, I would - I haven't received an invite, though. And your last comment sounded like it should be public now.
2023-12-10T21:18:51
2023-12-10T21:19:20
{}
MEMBER
vuejs
core
1,849,139,294
9,800
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------ | ------- | ------- | | runtime-dom.global.prod.js | 87 kB | 33.1 kB | 29.9 kB | | vue.global.prod.js | 133 kB | 49.9 kB | 44.7 kB | ### Usages | Name | Size | Gzi...
2023-12-11T00:10:29
2023-12-11T00:10:29
{}
NONE
vuejs
core
1,842,448,636
7,821
baiwusanyu-c
completed [4162311](https://github.com/vuejs/core/commit/4162311efdb0db5ca458542e1604b19efa2fae0e)
2023-12-06T08:51:14
2023-12-06T08:51:14
{}
MEMBER
vuejs
core
1,842,689,960
6,435
oppianmatt
Not that hard to make your own v-html directive that works SSR. Here is mine: ``` nuxtApp.vueApp.directive('thtml', { mounted: (el: HTMLElement, binding: any, vnode: any) => { el.innerHTML = binding.value; }, getSSRProps(binding: any) { return { innerHTML: binding.value ...
2023-12-06T11:30:26
2023-12-06T11:30:26
{}
NONE
vuejs
core
1,843,309,629
8,780
zdm
This patch breaks everything. I am using custom components: ``` <ext-dialog width="500" height="90%"> ``` No `width` / `height` passwd to the component.
2023-12-06T17:08:04
2023-12-06T17:20:03
{}
NONE
vuejs
core
1,844,850,574
9,756
haoqunjiang
/ecosystem-ci run
2023-12-07T08:03:16
2023-12-07T08:03:16
{ "+1": 1 }
MEMBER
vuejs
core
1,844,873,128
9,733
DragonnZhang
@baiwusanyu-c Hi, could you please take a look if you have spare time? Thanks a lot!
2023-12-07T08:21:05
2023-12-07T08:21:05
{}
NONE
vuejs
core
1,845,211,753
9,772
Alfred-Skyblue
See https://vuejs.org/api/sfc-css-features.html#child-component-root-elements [Playground](https://play.vuejs.org/#eNqNU8tugzAQ/BXLl14iUJUbpZHaikN7aKs2Ry7EbMCJsZFtUqoo/961IQkhaRQJCTz78MzusKVPdR1sGqARjQ3TvLbEgG3qWSp5VSttyYvCtwRpEwEVvshSq4rcBeE44NrcpTIOuz7YAQ8WqlpkFvBESFzez5I2QwTiEL89Nm7jUcRzvpnNS24IPrYEYoSycehQX3Z2Pc...
2023-12-07T11:55:57
2023-12-07T11:56:43
{}
MEMBER
vuejs
core
1,845,424,426
9,771
pikax
@sinkersan the current type is correct, @Alfred-Skyblue is correct on the explanation. the same issue is/was present since a long time ago: ```ts function test<T>(): Ref<T> { const r = ref<T>(null) return r; } ``` ![image](https://github.com/vuejs/core/assets/4620458/b065c242-f0e9-42cd-b0ef-738bc3af19f0)...
2023-12-07T14:19:03
2023-12-07T14:19:03
{ "+1": 2 }
MEMBER
vuejs
core
1,846,716,812
7,108
baiwusanyu-c
/ecosystem-ci run
2023-12-08T07:51:35
2023-12-08T07:51:35
{ "+1": 1 }
MEMBER
vuejs
core
1,846,779,520
9,550
yyx990803
Note: feature flag added in `@vitejs/plugin-vue` and `@vitejs/plugin-vue-jsx` in https://github.com/vitejs/vite-plugin-vue/commit/0fbc4a4f8a9bfb193a28a02ef9e25a06631426a9
2023-12-08T08:44:32
2023-12-08T08:44:32
{ "+1": 1 }
MEMBER
vuejs
core
1,845,020,227
9,769
edison1105
@1337huania > Removing timeout property from Suspense gives weird delay but footer stays in place. This is expected behavior. see https://vuejs.org/guide/built-ins/suspense.html#loading-state
2023-12-07T09:48:15
2023-12-07T09:48:15
{ "+1": 1 }
MEMBER
vuejs
core
1,845,160,953
9,762
zdm
Yhank you very much. When we can experct for the patch release?
2023-12-07T11:18:58
2023-12-07T11:18:58
{}
NONE
vuejs
core
1,846,684,506
8,657
baiwusanyu-c
/ecosystem-ci run
2023-12-08T07:30:17
2023-12-08T07:30:17
{ "+1": 1 }
MEMBER
vuejs
core
1,847,538,881
9,135
DragonnZhang
I think the bug is caused by innerHtml rather than key. [In this example](https://play.vuejs.org/#eNqNU01v2zAM/SucL26BxD50JyPtum4FtmFf2LqbL47NJGplSZPoNIOR/z5Kclwv7YoeDFPk44f4nvrkrTHZtsOkSBaErZEV4UWpABbLjkgr2M61Kmop6rvzMmlQwjm84l+ZXPQ9+PMbSH8pNpAwhQLS94O53y/yWCPWe6dbw9WWQjUFw2M1LrPIfYQxi3wyAB9dbYUhtkVrtCUIBVZWt5BmIcfPnX...
2023-12-08T17:08:24
2023-12-08T17:08:24
{}
NONE
vuejs
core
1,835,883,827
1,147
pikax
Closing this, since this has a work around on the tool side.
2023-12-01T10:54:15
2023-12-01T10:54:15
{}
MEMBER
vuejs
core
1,837,753,242
9,744
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 86.7 kB | 33 kB | 29.8 kB | | vue.global.prod.js | 133 kB | 49.8 kB | 44.6 kB | ### Usages | Name | Size |...
2023-12-04T02:46:29
2023-12-04T02:46:29
{}
NONE
vuejs
core
1,841,665,149
9,757
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 86.7 kB | 33 kB | 29.8 kB | | vue.global.prod.js | 133 kB | 49.8 kB | 44.7 kB | ### Usages | Name | Size |...
2023-12-05T21:45:19
2023-12-05T21:45:19
{}
NONE
vuejs
core
1,835,701,043
3,842
yyx990803
See 634519720
2023-12-01T08:47:27
2023-12-01T08:47:27
{ "heart": 3 }
MEMBER
vuejs
core
1,836,289,744
9,734
vue-bot
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/7061735936) | suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/7055965873) | |-------|--------|----------------| | language-tools | :x: [failure](https://github.com/vuejs/ecosystem-ci/actions/runs/706...
2023-12-01T15:16:28
2023-12-01T15:16:28
{}
CONTRIBUTOR
vuejs
core
1,838,381,503
9,335
pikax
@andredewaard `defineModel` is a macro to simplify the `model` manipulation, you won't be able to discriminate the type in your example, since those are two completely different types. As an exercise I would recommend trying to achieve that in plain Typescript :)
2023-12-04T10:53:31
2023-12-04T10:53:31
{}
MEMBER
vuejs
core
1,838,680,746
8,105
bgrand-ch
Thank you to everyone involved in resolving this problem 🙏
2023-12-04T13:49:27
2023-12-04T13:49:27
{}
NONE
vuejs
core
1,685,699,158
8,989
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 86.7 kB | 33 kB | 29.8 kB | | vue.global.prod.js | 133 kB | 49.8 kB | 44.7 kB | ### Usages | Name | Size |...
2023-08-21T05:59:01
2023-12-05T01:05:27
{}
NONE
vuejs
core
1,833,496,457
9,660
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 86.7 kB | 33 kB | 29.8 kB | | vue.global.prod.js | 133 kB | 49.8 kB | 44.6 kB | ### Usages | Name | Size |...
2023-11-30T10:34:18
2023-11-30T15:17:40
{}
NONE
vuejs
core
1,834,492,440
5,502
sxzz
Fixed in #8704
2023-11-30T20:21:45
2023-11-30T20:21:45
{}
MEMBER
vuejs
core
1,830,110,663
9,701
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 86.7 kB | 33 kB | 29.8 kB | | vue.global.prod.js | 133 kB | 49.8 kB | 44.6 kB | ### Usages | Name | Size |...
2023-11-28T15:37:57
2023-12-01T13:31:25
{}
NONE
vuejs
core
1,836,278,720
9,734
pikax
/ecosystem-ci run
2023-12-01T15:09:09
2023-12-01T15:09:09
{ "+1": 1 }
MEMBER
vuejs
core
1,837,434,040
9,733
DragonnZhang
Test added.
2023-12-03T10:18:12
2023-12-03T10:18:12
{}
NONE
vuejs
core
1,838,093,345
9,735
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 86.7 kB | 33 kB | 29.8 kB | | vue.global.prod.js | 133 kB | 49.8 kB | 44.7 kB | ### Usages | Name | Size |...
2023-12-04T08:52:43
2023-12-04T08:52:43
{}
NONE
vuejs
core
1,838,100,330
8,482
Trandx
Hello !! I have done `pnpm update` after your update but, i always have the same error. this is my code `export default interface IDynamicSelectInput<E, K, L>{ //props: PropsType<K> & L; props: PropsType<K> & L emits: EmitsType<E>; }` this is error `[plugin:vite:vue] [@vue/compiler-sfc] Unres...
2023-12-04T08:57:11
2023-12-04T08:57:11
{}
NONE
vuejs
core
1,838,146,743
8,592
mosinve
Hi, @zqran is this PR planning to merge? Looks like i need it very much)
2023-12-04T09:25:46
2023-12-04T09:25:46
{}
NONE
vuejs
core
1,839,219,920
8,482
amritk
Yep I also tested the latest version (3.3.10) and still have the same issue.
2023-12-04T18:22:57
2023-12-04T18:22:57
{}
NONE
vuejs
core
1,841,803,350
9,758
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 86.7 kB | 33 kB | 29.8 kB | | vue.global.prod.js | 133 kB | 49.8 kB | 44.7 kB | ### Usages | Name | Size |...
2023-12-05T23:39:30
2023-12-05T23:39:30
{}
NONE
vuejs
core
1,833,919,661
9,639
pikax
I debugged this and it seems to be caused by non strict null check, please update `tsconfig.json` to at the very least have `strictNullChecks`, that should prevent typescript from resolving the type to `unknown`. This PR https://github.com/vuejs/core/pull/9652 seems to fix this issue even with `strictNullChecks:fals...
2023-11-30T14:45:47
2023-11-30T14:49:11
{}
MEMBER
vuejs
core
1,803,724,837
8,998
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 86.7 kB | 33 kB | 29.8 kB | | vue.global.prod.js | 133 kB | 49.8 kB | 44.6 kB | ### Usages | Name | Size |...
2023-11-09T12:17:44
2023-12-01T01:01:02
{}
NONE
vuejs
core
1,837,193,221
9,439
pikax
We have 2 solutions, either support number or drop number support from provide/inject. For me either would be alright
2023-12-02T16:15:15
2023-12-02T16:15:15
{ "+1": 3 }
MEMBER
vuejs
core
1,837,753,501
9,745
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 86.7 kB | 33 kB | 29.8 kB | | vue.global.prod.js | 133 kB | 49.8 kB | 44.6 kB | ### Usages | Name | Size |...
2023-12-04T02:46:52
2023-12-04T02:46:52
{}
NONE
vuejs
core
1,841,688,322
8,486
DrJume
tests for this were added in #9757
2023-12-05T22:00:53
2023-12-05T23:57:51
{}
CONTRIBUTOR
vuejs
core
1,833,483,524
9,680
pikax
@Doctor-wu thank you for the PR, as Skirtles said, in the minor that lines no longer exists. There was a big refactoring on the reactivity https://github.com/vuejs/core/pull/5912
2023-11-30T10:25:50
2023-11-30T10:25:50
{}
MEMBER
vuejs
core
1,835,703,534
9,439
xiaoxiangmoe
I think provide should not accept `number` as key. If we should type convert is acceptable. How about allow bigint, Array of number, Array of int and so on?
2023-12-01T08:49:16
2023-12-01T08:49:16
{}
CONTRIBUTOR
vuejs
core
1,837,220,403
9,691
GabrielHangor
@pikax Hey Carlos, My example is working since i casted the type of the custom element to the original vue component and declared it globally (in components.d.ts). This way typechecking and hints are working exactly as expected. But the problem is that if you cast the custom element to the custom element in GlobalCo...
2023-12-02T18:16:48
2023-12-02T18:21:32
{}
NONE
vuejs
core
1,837,948,211
9,748
LinusBorg
This is how it's designed. > The actual value will be compiled into a hashed CSS custom property, so the CSS is still static. **The custom property will be applied to the component's root element** via inline styles and reactively updated if the source value changes. https://vuejs.org/api/sfc-css-features.html#v-...
2023-12-04T06:59:20
2023-12-04T06:59:20
{}
MEMBER
vuejs
core
1,838,825,630
8,989
SavkaTaras
Hello @baiwusanyu-c @sxzz @LinusBorg @edison1105 , Can you please merge this and release when possible? Thank you
2023-12-04T14:59:14
2023-12-04T14:59:14
{}
NONE
vuejs
core
1,834,052,941
9,724
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------------------ | ------------------- | ------------------- | | runtime-dom.global.prod.js | 86.7 kB | 33 kB | 29.8 kB | | v...
2023-11-30T15:57:28
2023-11-30T15:57:28
{}
NONE
vuejs
core
1,834,140,424
9,725
netlify[bot]
### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed. | Name | Link | |:-:|------------------------| |<span aria-hidden="true">🔨</span> Latest commit | 1b4b2a4f2766a319be86689451483e37531f879d | |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue...
2023-11-30T16:42:25
2023-11-30T16:42:25
{}
NONE
vuejs
core
1,835,716,197
9,728
pikax
Sorry I still don't understand what's the issue, `null` should not have any check done.
2023-12-01T08:58:14
2023-12-01T08:58:14
{}
MEMBER
vuejs
core
1,837,093,832
9,731
pikax
@jairoblatt you right, thank you :) > Maybe this could be better: > > ```js > entries[`${isSymbol(key) ? key.description ? `Symbol(${key.description})` /* or key.toString() */ : `Symbol(${i})` : key} =>`] = val > ``` > > Or just > > ```js > `Symbol(${key.description || i})` > ``` I think the late...
2023-12-02T09:02:04
2023-12-02T09:02:04
{ "heart": 1 }
MEMBER
vuejs
core
1,837,104,677
9,739
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------------------- | ------------------- | ------------------- | | runtime-dom.global.prod.js | 86.8 kB (**+70 B**) | 33 kB (**+12 B**) | 29.8 kB (**+18 B**) | ...
2023-12-02T09:40:24
2023-12-02T09:40:24
{}
NONE
vuejs
core
1,838,683,168
9,134
pikax
@TomasSestak can you confirm if the issue is still present on 3.3.10, my playground example seems to be working as expected with this fix https://github.com/vuejs/core/pull/9309
2023-12-04T13:50:50
2023-12-04T13:50:50
{}
MEMBER
vuejs
core
1,840,903,412
9,755
skywalker512
Thank you for your answer.
2023-12-05T14:29:13
2023-12-05T14:29:13
{}
NONE
vuejs
core
1,833,507,495
8,883
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 86.7 kB | 33 kB | 29.7 kB | | vue.global.prod.js | 133 kB | 49.8 kB | 44.6 kB | ### Usages | Name | Size |...
2023-11-30T10:41:41
2023-11-30T10:41:41
{}
NONE
vuejs
core
1,835,679,388
9,726
pikax
Please provide a minimal reproduction, currently there's many pieces, such a UI Library, etc. From the video the first error seems to be shown because the teleport element does not exist: ![image](https://github.com/vuejs/core/assets/4620458/d16c83d8-262e-47e8-9f5f-f19b3c5eb94d) Which is more likely to be caused...
2023-12-01T08:29:59
2023-12-01T08:29:59
{}
MEMBER
vuejs
core
1,835,712,151
9,728
Dunqing
> Not sure what you mean by this, where would `skipCheck` come from? You can see https://play.vuejs.org/#__DEV__eNp9kU1PAjEQhv/KpJeFhEAMN1zWqOGgByXKsZd1GZZid9r0g4/g/nenS0AO6m1m3nfSZ/oexb21w21EMRG5r5yyATyGaEGXVE+lCF6KQpJqrHEBjvBouCKkAC2snGkg4+VM0hJXinDujPX5URKU/m5yZf4CH5yimguKzQc6Lnq9PkwLyEo6ZP1bSW3R60vKRycMfpSbgI3VZU...
2023-12-01T08:55:11
2023-12-01T08:55:11
{}
CONTRIBUTOR
vuejs
core
1,835,887,165
9,733
DragonnZhang
[playground](https://sfc-playground-nnjtwnu1t-vuejs.vercel.app/#eNp9U11v0zAU/SsXS2itlCah015CNvGhCcEDINgDqM6DSW+KV8eObCfrVPW/c+20JaBpfanvOce+5x47e/a269KhR1aw0tVWdh4c+r4DJfTmmjPvOLvhWradsR72YLGBAzTWtHBB2y5ec811bbTzIKyF6yCYrfIEXiWwrOaBbXpde2k0uAfRzeaw5xpgRep0EKrHVV4lYe+xWlYVnTKhl//QeVVRywPXZTbaJXNUeGw7JTxSBVCu5QDOPyoMA1ih...
2023-12-01T10:56:43
2023-12-01T10:56:43
{}
NONE
vuejs
core
1,835,701,885
9,731
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------------------- | ------------------- | ------------------- | | runtime-dom.global.prod.js | 86.8 kB (**+61 B**) | 33 kB (**+31 B**) | 29.8 kB (**+16 B**) | ...
2023-12-01T08:48:05
2023-12-02T08:56:49
{}
NONE
vuejs
core
1,838,709,777
9,134
Alfred-Skyblue
I'm not sure if I need to close this PR, but in some cases, acquiring the anchor may, for some reason, lead to its removal, causing a failure in `insertBefore`. Perhaps we should consider directly inserting the child when there are no child elements in the parentNode. If we believe that parent-child relationship checks...
2023-12-04T14:05:42
2023-12-04T14:05:42
{}
MEMBER
vuejs
core
1,838,751,181
8,105
dargmuesli
When I opened my notifications today ![Alt Text](https://media2.giphy.com/media/5VKbvrjxpVJCM/giphy.gif) Thanks a lot everyone and thank you @yyx990803 for getting the merge train rolling!
2023-12-04T14:28:25
2023-12-04T14:28:25
{ "hooray": 7 }
NONE
vuejs
core
1,839,897,261
9,751
starcsb
This implementation method seems incompatible with [this test case](https://github.com/vuejs/core/blob/main/packages/reactivity/__tests__/reactive.spec.ts#L168-L174)(if replacing `{}` with `[]` in [this test case](https://github.com/vuejs/core/blob/main/packages/reactivity/__tests__/reactive.spec.ts#L168-L174))
2023-12-05T02:32:59
2023-12-05T02:32:59
{ "+1": 1 }
NONE
vuejs
core
1,833,536,405
8,896
yyx990803
I think it's more straightforward to cache directly on the wrapped function: da4a4fb5e
2023-11-30T11:01:33
2023-11-30T11:01:33
{}
MEMBER
vuejs
core
1,836,319,224
9,732
LinusBorg
This is expected behaviour. While the ref is being triggered, the child component doesn't receive the ref, it only receives its *value* - and if that value itself is still the same, the child has no reason to update.
2023-12-01T15:36:11
2023-12-01T15:36:11
{}
MEMBER
vuejs
core
1,833,938,327
9,719
pikax
Please provide a minimal reproduction link, ideally using https://play.vuejs.org/. Reopen this or create a new issue with minimal reproduction. For questions please use forums or discord.
2023-11-30T14:53:58
2023-11-30T14:53:58
{}
MEMBER
vuejs
core
1,836,341,394
7,893
LinusBorg
I'll close this as inactive. Please open a new issue if you can provide a boiled-down reproduction.
2023-12-01T15:50:40
2023-12-01T15:50:40
{}
MEMBER
vuejs
core
1,836,353,326
9,731
jairoblatt
@pikax I think this is not the best approach, since symbols accepts a description, replacing it with the map index may cause some misunderstandings. Maybe this could be better: ```javascript entries[`${isSymbol(key) ? key.description ? `Symbol(${key.description})` /* or key.toString() */ : `Symbol(${i})` : key}...
2023-12-01T15:57:41
2023-12-01T15:57:41
{}
NONE
vuejs
core
1,836,527,752
9,726
guillaumebriday
Thank you for the feedback, I did new tests and the problem seems to be on the element-plus side Without it I successfully mount and unmount the vue App Element-plus does not unmount correctly because of the Teleport stuff, I will dive into it https://github.com/vuejs/core/assets/8252238/a7dec45f-fef5-404a-9...
2023-12-01T17:45:08
2023-12-01T17:45:08
{}
NONE
vuejs
core
1,838,046,474
9,335
andredewaard
Looks good! Question, how can we use this in combination with defineModel? So have `mode: multiple` on the defineProps type and `modelValue: T[]` on defineModel. ```ts interface BaseProps { label: string } interface PropsMulti extends BaseProps { mode: 'multiple' modelValue: T[] } interface PropsS...
2023-12-04T08:21:04
2023-12-04T08:21:11
{}
NONE
vuejs
core
1,738,615,665
9,309
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------------------ | ------------------ | ------------------- | | runtime-dom.global.prod.js | 86.7 kB (**-1 B**) | 33 kB (**+4 B**) | 29.8 kB (**+18 B**) | | vue....
2023-09-28T07:22:54
2023-12-04T08:40:42
{}
NONE
vuejs
core
1,838,086,056
9,739
yyx990803
Do you have an example repro for me to further investigate this? > Side note, is there a reason normalizePropsOptions is called for every vnode instead of just once in defineComponent? Even for the same component, `normalizePropsOptions` may have different result based on the app context the component is rendered...
2023-12-04T08:48:01
2023-12-04T08:48:01
{}
MEMBER
vuejs
core
1,838,580,101
9,418
davidmatter
Closing because https://github.com/vuejs/core/pull/9652 has a better solution. https://github.com/vuejs/core/pull/9652#pullrequestreview-1757157291 is going to be hard though.
2023-12-04T12:56:56
2023-12-04T12:56:56
{}
CONTRIBUTOR
vuejs
core
1,838,676,185
8,105
vanling
🎉 Thank you @edison1105
2023-12-04T13:46:50
2023-12-04T13:46:50
{}
NONE
vuejs
core
1,838,583,132
9,651
Alfred-Skyblue
@johnsoncodehk Special thanks for the simplified ideas, I've noticed that if we use `active` to manage the paused state of an effect, it will result in a failure when calling `stop`. This seems unexpected, as we are only pausing the `effect` and not actually stopping it. In my modification to your code in https://githu...
2023-12-04T12:58:50
2023-12-04T13:52:25
{}
MEMBER
vuejs
core
1,838,475,227
9,751
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------------------- | ------------------ | ------------------- | | runtime-dom.global.prod.js | 86.8 kB (**+35 B**) | 33 kB (**+8 B**) | 29.8 kB (**+4 B**) | | v...
2023-12-04T11:50:48
2023-12-05T08:48:11
{}
NONE
vuejs
core
1,834,470,576
8,989
LinusBorg
@edison1105 This is technically pending your review. Can you have a look or cancel your review? I think this is good to go.
2023-11-30T20:08:31
2023-11-30T20:08:31
{}
MEMBER
vuejs
core
1,835,719,753
9,728
Dunqing
> Sorry I still don't understand what's the issue, `null` should not have any check done. Thank you I understand. At first I thought the null type was incorrect. cc @zernonia
2023-12-01T09:00:40
2023-12-01T09:02:02
{}
CONTRIBUTOR
vuejs
core
1,835,724,562
9,728
pikax
Just to confirm, here's an example of `null` without any warning or error [playground](https://play.vuejs.org/#eNp9UsFuwjAM/RUrF5iEWk3cqoK0TRy2w4bGjrl0rQtlaRIlKTBV/fc5KWVM6lAuyXvP9nPslj1oHR0aZAlLbW4q7cCia/SSy6rWyjhowWAJHZRG1TAh6eRCPalan/Eo9g+fiWh/ciUt5YIFbL7rTyWmdwOWEybxCLnIrKX0nZencV+d6tLDYa1F5pBeAGlfRqkFZ/ecQXyFJj...
2023-12-01T09:04:15
2023-12-01T09:04:15
{ "+1": 1 }
MEMBER
vuejs
core
1,837,182,876
6,497
sxzz
Reopen this since we have a discussion on #9439
2023-12-02T15:31:12
2023-12-02T15:31:12
{}
MEMBER
vuejs
core
1,839,273,121
8,482
yyx990803
@Trandx your code doesn't show how the interface is used in the component. @amritk If you are still having the same error, make sure to provide **the exact and complete code** that is causing the error because there can be many different ways of using generics.
2023-12-04T18:54:58
2023-12-04T18:54:58
{}
MEMBER
vuejs
core
1,840,167,087
8,592
zqran
> Hi, @zqran is this PR planning to merge? Looks like i need it very much) @mosinve It may not work now. For specific reasons, please see the explanation of @sxzz above. https://github.com/vuejs/core/pull/8592#issuecomment-1676434451
2023-12-05T07:40:34
2023-12-05T07:40:34
{}
CONTRIBUTOR
vuejs
core
1,840,833,165
9,755
pikax
This is expected, we either have unwrapped or the original types on collections, to better reflect the code at runtime the #8960 is correct. ```ts for (const c of a.value) { console.log('ref has', a.value.has(ref(o).value), a.value.has(ref(c).value)); } for (const c of b) { console.log('reactive has', b....
2023-12-05T13:51:08
2023-12-05T13:51:08
{ "heart": 1 }
MEMBER