owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 2,185,079,119 | 8,497 | GalacticHypernova | Hey! Thanks for the feedback!
> 1. The type of `dir`. If we're going to handle `undefined`, shouldn't `dir: Directive` be updated to reflect that?
In this case, is there a reason to update it? This PR is made to handle edge cases, that given the lack of issues reported around it are not that frequent. I think i... | 2024-06-23T15:53:02 | 2024-06-23T15:56:03 | {} | CONTRIBUTOR |
vuejs | core | 2,191,550,360 | 11,234 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/9679396735)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/9673807636) |
|-------|--------|----------------|
| language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a... | 2024-06-26T12:20:03 | 2024-06-26T12:20:03 | {} | CONTRIBUTOR |
vuejs | core | 2,193,458,707 | 11,236 | phk422 | > cc @Doctor-wu
I've noticed this bug since version 3.4.29
| 2024-06-27T03:52:50 | 2024-06-27T03:53:01 | {} | CONTRIBUTOR |
vuejs | core | 2,194,332,845 | 11,232 | yangxiuxiu1115 | You should not manually change the value of slot.default, this will cause problems with some of the compilation optimization strategies that vue does internally. For example, in app.vue the default slot will have the identifier STABLE added to it, and when you change slot.default the identifier will cause it to go into... | 2024-06-27T10:26:46 | 2024-06-27T10:26:46 | {} | CONTRIBUTOR |
vuejs | core | 2,195,940,286 | 11,223 | yyx990803 | /cc @sxzz | 2024-06-28T01:35:34 | 2024-06-28T01:35:34 | {} | MEMBER |
vuejs | core | 2,183,963,541 | 11,190 | yyx990803 | FYI the original implementation only accounted for the direct parent but not possible multiple-level-nested components.
I refactored the logic to a recursive function and also removed the eslint ignores (hydration code paths do run in the browser so optional chaining should be avoided) in [ce4b9f2](https://github.co... | 2024-06-22T09:49:14 | 2024-06-22T09:49:14 | {
"rocket": 1
} | MEMBER |
vuejs | core | 2,185,471,932 | 11,209 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 89.6 kB | 34.2 kB | 30.9 kB |
| vue.global.prod.js | 146 kB | 53.6 kB | 47.8 kB |
### Usages
| Name | Size |... | 2024-06-24T02:28:21 | 2024-06-24T02:28:21 | {} | NONE |
vuejs | core | 2,191,077,808 | 11,229 | Doctor-wu | /ecosystem-ci run | 2024-06-26T08:07:13 | 2024-06-26T08:07:13 | {
"+1": 1
} | MEMBER |
vuejs | core | 2,191,406,344 | 11,229 | Doctor-wu | something wrong in vueuse case | 2024-06-26T10:55:08 | 2024-06-26T10:55:08 | {} | MEMBER |
vuejs | core | 2,191,583,065 | 11,223 | ferferga | [This](https://github.com/orgs/community/discussions/25220#discussioncomment-9170862) is another approach that we could attempt, imo even better because that way, in runs logs, they're grouped and it's easier to know the general flow of what's happening. | 2024-06-26T12:34:52 | 2024-06-26T12:34:52 | {} | CONTRIBUTOR |
vuejs | core | 2,194,484,273 | 11,239 | Simon-He95 | [I provided a demo without introducing unocss](https://stackblitz.com/edit/vitejs-vite-aayewb?file=vite.config.ts) | 2024-06-27T11:55:08 | 2024-06-27T11:55:08 | {} | CONTRIBUTOR |
vuejs | core | 2,183,691,636 | 9,213 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/9621890643)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/9608518200) |
|-------|--------|----------------|
| language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a... | 2024-06-22T01:48:18 | 2024-06-22T01:48:18 | {} | CONTRIBUTOR |
vuejs | core | 2,189,700,797 | 11,220 | skirtles-code | This seems similar to #8505, which wasn't merged due to https://github.com/vuejs/core/pull/8505#issuecomment-2139233216. | 2024-06-25T18:34:45 | 2024-06-25T18:34:45 | {} | CONTRIBUTOR |
vuejs | core | 2,191,538,070 | 11,234 | Doctor-wu | /ecosystem-ci run | 2024-06-26T12:13:20 | 2024-06-26T12:13:20 | {
"+1": 1
} | MEMBER |
vuejs | core | 2,194,523,924 | 11,240 | linzhe141 | > However, it is reactive when used in a template?
The componentUpdateFn of the component will update the slots and execute the render function when it is re-executed, so the slots in the render function are the updated slots.
![image](https://github.com/vuejs/core/assets/40790268/82fb2986-7940-43ee-a59a-0bbfd966... | 2024-06-27T12:11:35 | 2024-06-27T12:11:35 | {
"+1": 1
} | MEMBER |
vuejs | core | 2,184,018,455 | 9,232 | edison1105 | > > > Any reason not to include test cases for the change to `hydration.ts`?
> >
> >
> > It seems that `jsdom's innerHTML` does not normalize `\r\n` into `\n`. I did not figure out a way to test it.
>
> But can't you create a node that has the relevant content directly, rather than relying on jsdom to normalize... | 2024-06-22T12:42:27 | 2024-06-22T12:42:27 | {} | MEMBER |
vuejs | core | 2,184,311,887 | 11,196 | yyx990803 | Likely related to #11150
/cc @KermanX @johnsoncodehk | 2024-06-23T01:33:05 | 2024-06-23T01:33:05 | {
"eyes": 1
} | MEMBER |
vuejs | core | 2,185,639,962 | 11,208 | TurbMZ | > > > 应该使用`Telport` 如果使用render，是不会关联main.js里面的rootApp的，  {
> pauseScheduleStack--
> if (schedulerFlag) {
> return
> }
>
> try {
> schedulerFlag = true
> ... | 2024-06-26T07:37:18 | 2024-06-26T07:37:18 | {
"+1": 1
} | MEMBER |
vuejs | core | 2,194,520,454 | 11,240 | geiregjo | Ok, I'll use onBeforeUpdate to detect slot changes then.
Just wondering, is this worth a feature request? | 2024-06-27T12:09:46 | 2024-06-27T12:09:46 | {} | NONE |
vuejs | core | 2,185,531,014 | 11,208 | TurbMZ |
> 应该使用`Telport` 如果使用render，是不会关联main.js里面的rootApp的， ![image](https://private-user-images.githubusercontent.com/40790268/342193155-804180b3-9a32-4b9a-886f-978d5f6ad6fc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3... | 2024-06-24T03:49:21 | 2024-06-24T03:49:21 | {} | NONE |
vuejs | core | 2,188,592,689 | 8,503 | liuseen-l | @skirtles-code @jacekkarczmarczyk thanks for your suggestions. The test case for set has been added. | 2024-06-25T10:51:21 | 2024-06-25T10:51:21 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 2,190,901,232 | 11,225 | cc-hearts | Whether or not it is possible to control queueEffectSchedulers not to be called recursively.🤔
For example:
```ts
let schedulerFlag = false
// ...
function resetScheduling() {
pauseScheduleStack--
if (schedulerFlag) {
return
}
try {
schedulerFlag = true
while (!pauseScheduleStack && ... | 2024-06-26T06:31:03 | 2024-06-26T06:31:03 | {
"+1": 1
} | NONE |
vuejs | core | 2,185,309,400 | 11,204 | sxzz | Seems like `github.event.workflow_run.pull_requests[0].number` requires write permission of the repo | 2024-06-23T20:04:52 | 2024-06-23T20:04:52 | {} | MEMBER |
vuejs | core | 2,185,529,295 | 11,212 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 89.6 kB | 34.2 kB | 30.9 kB |
| vue.global.prod.js | 146 kB | 53.6 kB | 47.8 kB |
### Usages
| Name | Size |... | 2024-06-24T03:46:46 | 2024-06-24T03:46:46 | {} | NONE |
vuejs | core | 2,189,271,245 | 11,220 | ferferga | There are other typeof instances across the codebase, why not do this in all of them? | 2024-06-25T15:31:33 | 2024-06-25T15:31:33 | {} | CONTRIBUTOR |
vuejs | core | 2,191,604,582 | 11,225 | Doctor-wu | `3.5.0-alpha.2` had refactored reactivity system, I tried this case in `3.5.0-alpha.2` and it works well, so this error won't occur after that | 2024-06-26T12:46:15 | 2024-06-26T12:46:15 | {} | MEMBER |
vuejs | core | 2,194,113,815 | 11,237 | hickiy | > Ref are unwrapped in templates so `{{ isRef(ss) }}` is passing string, not ref
you are right | 2024-06-27T08:36:58 | 2024-06-27T08:36:58 | {} | NONE |
vuejs | core | 2,194,283,240 | 11,240 | linzhe141 | Because instance's slots is not a reactive object, but a normal object
| 2024-06-27T10:00:50 | 2024-06-27T11:17:56 | {} | MEMBER |
vuejs | core | 2,194,517,509 | 11,240 | LinusBorg | > However, it is reactive when used in a template?
It's not, actually. When the parent changes the number of slots it passes down, it tells that child component "hey, you need to re-render". And during that re-render, triggered by the parent component, not by the slots object, you read the sot object's properties ag... | 2024-06-27T12:08:11 | 2024-06-27T12:08:11 | {} | MEMBER |
vuejs | core | 2,183,915,612 | 11,169 | yyx990803 | closed via #11183 | 2024-06-22T08:27:53 | 2024-06-22T08:27:53 | {} | MEMBER |
vuejs | core | 2,184,094,174 | 9,579 | LinusBorg | That example works as expected.
Triggering the `obj` ref makes the computed re-evaluate, but since it returns the same value, that will not trigger a rerender of the template.
If you access the `obj` ref in the template, then it re-renders because it's now a direct dependency of the template | 2024-06-22T16:42:05 | 2024-06-22T16:42:05 | {
"confused": 1
} | MEMBER |
vuejs | core | 2,191,551,263 | 11,225 | cc-hearts | You're right. My program failed. 🤔 | 2024-06-26T12:20:30 | 2024-06-26T12:20:30 | {} | NONE |
vuejs | core | 2,191,856,906 | 11,225 | cc-hearts | ok, thanks | 2024-06-26T14:28:19 | 2024-06-26T14:28:19 | {} | NONE |
vuejs | core | 2,194,417,042 | 11,239 | hickiy | I think this is a normally problem, comB isn't to been resolve by unocss plugin, so its class haven't to been transifer and insert, so that is a compatbility problem between unocss and vite | 2024-06-27T11:16:46 | 2024-06-27T11:16:46 | {} | NONE |
vuejs | core | 2,194,925,254 | 11,242 | Doctor-wu | /ecosystem-ci run | 2024-06-27T14:46:40 | 2024-06-27T14:46:40 | {
"+1": 1
} | MEMBER |
vuejs | core | 2,195,937,131 | 11,121 | yyx990803 | Note: #11135 has been reverted to avoid introducing regressions in the 3.4 line - the original issue is fixed in 3.5 already, so we will keep this one closed as we know it's fixed in a future release. | 2024-06-28T01:33:14 | 2024-06-28T01:33:14 | {} | MEMBER |
vuejs | core | 2,285,400,606 | 11,597 | edison1105 | /ecosystem-ci run | 2024-08-13T06:02:40 | 2024-08-13T06:02:40 | {
"+1": 1
} | MEMBER |
vuejs | core | 2,287,785,483 | 11,600 | edison1105 | Is there any benchmark to show that it performs better? | 2024-08-14T03:46:59 | 2024-08-14T03:46:59 | {
"heart": 1
} | MEMBER |
vuejs | core | 2,288,129,467 | 9,159 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/10383862265)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/10381674293) |
|-------|--------|----------------|
| language-tools | :x: [failure](https://github.com/vuejs/ecosystem-ci/actions/runs/1... | 2024-08-14T08:18:22 | 2024-08-14T08:18:22 | {} | CONTRIBUTOR |
vuejs | core | 2,288,158,539 | 10,927 | edison1105 | Similar to #4831 | 2024-08-14T08:30:37 | 2024-08-14T08:30:37 | {} | MEMBER |
vuejs | core | 2,288,404,887 | 11,613 | malte-laukoetter | Thanks for having a look and mentioning `lightningcss`, it does indeed seem to be a problem with `esbuild`
With `lightningcss` the expected css is generated
```
[data-v-f41b19b6] :is([data-v-f41b19b6] .foo:has(>span)) span{background-color:green}
```
Disabling the css minification is not an option as then the ... | 2024-08-14T10:33:57 | 2024-08-14T10:33:57 | {} | NONE |
vuejs | core | 2,290,960,542 | 11,624 | edison1105 | It seems never worked. see [Playground with v3.4.16](https://play.vuejs.org/#eNrdU02P0zAQ/SuDL02lkogPcViyFbDqASQWxPYYCWXTyceuY0e2k1aq8t8Z20kbSrsgjivl4Lx5M34znrdnH5sm7FpkVyzWmaoaAxpN2ywTUdWNVAZupblJG9Mq3ECuZA2zMJpgNnn2/sD+g3qBtweF+QKkWCkl1SGrH/IGciIyKbQBVAqubUYgWs7nLnKSGgREkmoO10vYJwLAZkqOIZdFMPOsShS2lFQzWwLsOexS3iIVd7h... | 2024-08-15T09:25:47 | 2024-08-15T09:25:47 | {} | MEMBER |
vuejs | core | 2,291,057,864 | 10,948 | Reaper88 | I will try but I doubt as the html spec requires it to be a form-associated element using that static property within the class and having the _internals property accessible | 2024-08-15T10:46:17 | 2024-08-15T10:46:17 | {} | NONE |
vuejs | core | 2,292,658,100 | 9,998 | edison1105 | Could you please resolve the conflicts? | 2024-08-16T03:20:17 | 2024-08-16T03:20:17 | {} | MEMBER |
vuejs | core | 2,289,990,423 | 10,948 | MichaelHeydon | Does https://github.com/vuejs/core/commit/37d2ce5d8e0fac4a00064f02b05f91f69b2d5d5e help at all? I would have assumed not using the Shadow DOM should allow the `<form>` to pick up the input elements as usual. | 2024-08-14T21:57:48 | 2024-08-14T21:57:48 | {} | NONE |
vuejs | core | 1,772,041,031 | 5,806 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------ | ------------------ | -------------------- |
| runtime-dom.global.prod.js | 98.7 kB (**+5 B**) | 37.4 kB (**+8 B**) | 33.7 kB (**+17 B**) |
| v... | 2023-10-20T04:00:28 | 2024-08-15T01:37:05 | {} | NONE |
vuejs | core | 2,285,434,589 | 11,598 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 98.8 kB | 37.4 kB | 33.7 kB |
| vue.global.prod.js | 156 kB | 57.2 kB | 50.8 kB |
### Usages
| Name | Size |... | 2024-08-13T06:28:30 | 2024-08-13T06:28:30 | {} | NONE |
vuejs | core | 2,286,881,803 | 11,603 | yashjainyj | Thanks for your response.
Since I didn't declare the entities in package.json, and Vue is internally using vue/compiler-core which relies on entities, I'm unable to update the path for these dependencies.
As a temporary fix, I've set the Vue version to 3.4.27 without the caret (^) to prevent automatic updates.
... | 2024-08-13T18:36:55 | 2024-08-13T18:38:13 | {} | NONE |
vuejs | core | 2,287,831,654 | 11,608 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/10381375874)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/10346145552) |
|-------|--------|----------------|
| language-tools | :x: [failure](https://github.com/vuejs/ecosystem-ci/actions/runs/1... | 2024-08-14T04:29:07 | 2024-08-14T04:29:07 | {} | CONTRIBUTOR |
vuejs | core | 2,286,291,215 | 11,604 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------- | ------------------- | ------------------- |
| runtime-dom.global.prod.js | 98.8 kB (**+32 B**) | 37.4 kB (**+12 B**) | 33.7 kB (**+2 B**) |
... | 2024-08-13T13:43:35 | 2024-08-14T04:36:24 | {} | NONE |
vuejs | core | 2,289,097,154 | 10,893 | deleteme | Hi @sodatea, is there anything else you need from me for this PR to merge? | 2024-08-14T15:19:48 | 2024-08-14T15:19:48 | {} | CONTRIBUTOR |
vuejs | core | 2,282,182,527 | 11,579 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 98.7 kB | 37.4 kB | 33.7 kB |
| vue.global.prod.js | 156 kB | 57.2 kB | 50.9 kB |
### Usages
| Name | Size |... | 2024-08-10T15:12:01 | 2024-08-15T08:11:44 | {} | NONE |
vuejs | core | 2,285,250,762 | 5,872 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------- | ------------------- | ------------------- |
| runtime-dom.global.prod.js | 98.7 kB (**+13 B**) | 37.4 kB (**+12 B**) | 33.7 kB (**-41 B**) |
... | 2024-08-13T03:00:03 | 2024-08-16T02:25:45 | {} | NONE |
vuejs | core | 2,292,669,931 | 9,998 | edison1105 | /ecosystem-ci run | 2024-08-16T03:37:24 | 2024-08-16T03:37:24 | {
"+1": 1
} | MEMBER |
vuejs | core | 2,284,074,670 | 11,594 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------- | ------------------ | ------------------- |
| runtime-dom.global.prod.js | 98.7 kB (**-19 B**) | 37.4 kB (**-5 B**) | 33.7 kB (**+11 B**) |
| v... | 2024-08-12T14:01:48 | 2024-08-12T14:01:48 | {} | NONE |
vuejs | core | 2,285,250,983 | 10,880 | wjx25zj | same problem and "generics" don't work | 2024-08-13T03:00:20 | 2024-08-13T03:00:20 | {} | NONE |
vuejs | core | 2,285,300,164 | 11,596 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 98.8 kB | 37.4 kB | 33.7 kB |
| vue.global.prod.js | 156 kB | 57.2 kB | 50.8 kB |
### Usages
| Name | Size |... | 2024-08-13T04:05:57 | 2024-08-13T04:05:57 | {} | NONE |
vuejs | core | 2,286,343,536 | 11,602 | Gianthard-cyh | You are correct that this issue is indeed related to #11502, but I believe the reproduction you provided demonstrates the expected behavior outlined in the Vue and Pinia documentation.
In the [Pinia documentation](https://pinia.vuejs.org/core-concepts/#Setup-Stores), it states:
>Setup stores are also able to rely... | 2024-08-13T14:04:50 | 2024-08-13T14:13:02 | {
"+1": 5
} | CONTRIBUTOR |
vuejs | core | 2,287,826,733 | 11,608 | jh-leong | /ecosystem-ci run | 2024-08-14T04:23:08 | 2024-08-14T04:23:08 | {
"+1": 1
} | MEMBER |
vuejs | core | 2,290,380,008 | 11,600 | yyx990803 | Using `for...in` to iterate over arrays is **bad practice**. | 2024-08-15T02:25:22 | 2024-08-15T02:25:22 | {
"heart": 1
} | MEMBER |
vuejs | core | 2,290,875,740 | 11,622 | yangxiuxiu1115 | maybe `queueJob(() => update())` is better.
It looks like calling update multiple times is due to an event loop problem. instance.asyncDep.catch().thent() will execute after two ticks, while instance.then() has only one tick | 2024-08-15T08:22:01 | 2024-08-15T08:22:01 | {} | CONTRIBUTOR |
vuejs | core | 1,709,365,770 | 9,159 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 98.7 kB | 37.4 kB | 33.7 kB |
| vue.global.prod.js | 156 kB | 57.2 kB | 50.8 kB |
### Usages
| Name | Size |... | 2023-09-07T02:07:00 | 2024-08-14T08:09:56 | {} | NONE |
vuejs | core | 2,288,711,446 | 10,948 | Reaper88 | Any news as to what might happen with this request? | 2024-08-14T13:15:22 | 2024-08-14T13:15:22 | {} | NONE |
vuejs | core | 2,290,678,063 | 11,619 | edison1105 | Thank you for addressing the issue.
Could you please add a test case? | 2024-08-15T05:36:06 | 2024-08-15T05:36:06 | {} | MEMBER |
vuejs | core | 2,290,924,696 | 11,579 | edison1105 | /ecosystem-ci run | 2024-08-15T08:58:47 | 2024-08-15T08:58:47 | {
"+1": 1
} | MEMBER |
vuejs | core | 2,290,981,844 | 11,487 | kcmeven | https://play.vuejs.org/#eNrdU01v2zAM/SuELm6BIMbW7eK5HfZRDNthK7Zgl6oYDIdx1dmSIMlOhiL/faTkpM7QFgN668ki+UjwPT7finfWzoceRSFKXztlA3gMvYW20s2pFMFLcSa16qxxAT6hRqdqWDnTQTbPx5gHZHvQB9PZPYKDsSx1bbQPYGxQ9IBTuLyVGkBXHRaQfYtpeJHNODlUbc9Zo7l1O4N7oC8PoWFtGHoldZknKrQ4BQE721YBKQIodxSKcQ3iOL6kAMgTKFJ4GFHmk5liRiIRs5Vq5jfeaFIy7ipFTVNUiy6t... | 2024-08-15T09:42:41 | 2024-08-15T09:51:28 | {} | NONE |
vuejs | core | 2,292,185,732 | 11,628 | Disservin | mh all of these types don't really make sense when one is extending the js array
https://github.com/vuejs/core/blob/main/packages/reactivity/src/arrayInstrumentations.ts#L60
in your case `fn` will be of type number | 2024-08-15T20:32:01 | 2024-08-15T20:32:01 | {} | CONTRIBUTOR |
vuejs | core | 2,284,242,660 | 11,595 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------- | ------------------ | ------------------- |
| runtime-dom.global.prod.js | 98.8 kB (**+16 B**) | 37.4 kB (**+4 B**) | 33.7 kB (**-19 B**) |
| v... | 2024-08-12T15:10:21 | 2024-08-12T15:10:21 | {} | NONE |
vuejs | core | 2,285,408,389 | 11,597 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/10364444701)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/10346145552) |
|-------|--------|----------------|
| language-tools | :x: [failure](https://github.com/vuejs/ecosystem-ci/actions/runs/1... | 2024-08-13T06:08:47 | 2024-08-13T06:08:47 | {} | CONTRIBUTOR |
vuejs | core | 2,287,781,801 | 11,604 | edison1105 | @Gianthard-cyh
<s>this PR did not fix #11602.
It will fix another scene, but I don't know if this is needed.</s>
Misunderstood. | 2024-08-14T03:43:18 | 2024-08-14T04:51:25 | {} | MEMBER |
vuejs | core | 2,287,981,912 | 11,610 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 98.7 kB | 37.4 kB | 33.7 kB |
| vue.global.prod.js | 156 kB | 57.2 kB | 50.8 kB |
### Usages
| Name | Size |... | 2024-08-14T06:50:01 | 2024-08-14T06:50:01 | {} | NONE |
vuejs | core | 2,288,512,722 | 11,602 | Anoesj | Fantastic, thanks for the quick assistance! Would it be a good idea to make a note of this in [the changelog](https://github.com/vuejs/core/blob/main/changelogs/CHANGELOG-3.4.md#3437-2024-08-08)? While I understand you've actually fixed a problem with #11502, it can be perceived as a breaking change as well. | 2024-08-14T11:37:02 | 2024-08-14T11:37:02 | {} | NONE |
vuejs | core | 2,292,341,424 | 11,478 | Pentadome | Oh nice job 👍 | 2024-08-15T21:53:16 | 2024-08-15T21:53:16 | {
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 2,283,494,300 | 11,369 | dddssw | Thank | 2024-08-12T09:28:07 | 2024-08-12T09:28:07 | {} | NONE |
vuejs | core | 2,283,049,482 | 11,589 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------- | ------------------- | ------------------- |
| runtime-dom.global.prod.js | 98.7 kB (**-58 B**) | 37.4 kB (**-16 B**) | 33.7 kB (**+22 B**) |
... | 2024-08-12T03:21:42 | 2024-08-13T14:52:27 | {} | NONE |
vuejs | core | 2,287,580,638 | 11,605 | edison1105 | @romansp
The JSDoc should align with the docs.
PR welcome. | 2024-08-14T01:05:34 | 2024-08-14T01:05:34 | {} | MEMBER |
vuejs | core | 2,288,659,950 | 11,616 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------ | ------------------ | ------------------- |
| runtime-dom.global.prod.js | 98.7 kB | 37.4 kB | 33.7 kB |
| vue.... | 2024-08-14T12:52:34 | 2024-08-14T12:52:34 | {} | NONE |
vuejs | core | 2,289,421,678 | 11,603 | p3k | No, did not try this but I am sure it works – I am getting the error in a MR for a dependency upgrade, the error is not in our production branch. | 2024-08-14T17:36:23 | 2024-08-14T17:36:23 | {} | NONE |
vuejs | core | 2,289,670,358 | 5,806 | skirtles-code | I still think there's a problem with the testing here.
The test confirms that stopping the `effectScope` doesn't throw an error, but it doesn't confirm that the watchers actually get stopped.
The current code in this PR is:
```ts
const effectsToStop = this.effects.slice()
for (i = 0, l = effectsToStop.length... | 2024-08-14T19:19:49 | 2024-08-14T19:19:49 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 2,290,295,277 | 5,806 | edison1105 | @skirtles-code
Thank you so much. | 2024-08-15T01:37:10 | 2024-08-15T01:37:10 | {} | MEMBER |
vuejs | core | 2,290,799,514 | 11,619 | linzhe141 | @edison1105 I tried to fix it again, maybe it should be handled like this
> I'm pretty sure the previous fix is proper.我很确定之前的修复是正确的。 Is there any reason why you changed it?你有什么理由改变它吗？
You are right! I was wrong. I thought that when patching suspense, I had to confirm which component was pending, but this has not... | 2024-08-15T07:16:31 | 2024-08-15T07:16:31 | {} | MEMBER |
vuejs | core | 2,286,483,348 | 11,603 | yyx990803 | It was updated in https://github.com/vuejs/core/commit/ea190f24e4b92526da80e405be47d5aab90ab80c and the paths are updated accordingly. The file also can be correctly resolved from `dist/compiler-core.cjs.js` when required from plain Node.js. It seems this is an issue with Jest's resolver rather than a Vue issue. | 2024-08-13T15:05:17 | 2024-08-13T15:07:17 | {} | MEMBER |
vuejs | core | 2,287,832,447 | 11,604 | linzhe141 | @Gianthard-cyh Thank you for your review, but I don’t know how to cancel the associated issue.
| 2024-08-14T04:30:07 | 2024-08-14T04:30:07 | {} | MEMBER |
vuejs | core | 2,287,819,156 | 11,604 | Gianthard-cyh | > @Gianthard-cyh this PR did not fix #11602. It will fix another scene, but I don't know if this is needed.
Yes, I think this PR is actually doing this: fall back to the component's provides if there is a currentApp but key is not found in its provides.
Also, this will affect the behavior of pinia when injecting ... | 2024-08-14T04:14:28 | 2024-08-14T04:34:47 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 2,288,204,328 | 6,260 | edison1105 | Closing as it can not reproduce anymore with the latest version.
Maybe fixed via https://github.com/vuejs/core/pull/9370 | 2024-08-14T08:48:46 | 2024-08-14T08:48:46 | {} | MEMBER |
vuejs | core | 2,290,169,203 | 11,617 | edison1105 | duplicate of #11611
a workaround
```diff
<template>
+ <div>
<Child :is-loading="isLoading" />
+ </div>
</template>
``` | 2024-08-15T00:47:25 | 2024-08-15T00:47:25 | {
"confused": 1,
"laugh": 1
} | MEMBER |
vuejs | core | 2,290,381,343 | 11,579 | yyx990803 | @KazariEX can you resolve the conflicts since we've pointed `main` to the 3.5 beta now? | 2024-08-15T02:26:22 | 2024-08-15T02:26:22 | {} | MEMBER |
vuejs | core | 2,290,797,548 | 11,611 | edison1105 | Let's track it in #11617 since it has a minimal reproduction without any 3rd party libs. | 2024-08-15T07:14:47 | 2024-08-15T07:14:47 | {
"+1": 1
} | MEMBER |
vuejs | core | 2,291,029,690 | 11,624 | jak-ch-ll | @edison1105 Ah it seems we had the same idea, our fixes are identically. I added a test as well, which you can steal for your PR if you want, since yours was first | 2024-08-15T10:21:35 | 2024-08-15T10:21:35 | {} | CONTRIBUTOR |
vuejs | core | 2,285,445,251 | 11,599 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------ | ------------------ | ------------------- |
| runtime-dom.global.prod.js | 98.8 kB (**-3 B**) | 37.4 kB (**-5 B**) | 33.7 kB (**+27 B**) |
| vue.... | 2024-08-13T06:35:51 | 2024-08-13T06:35:51 | {} | NONE |
vuejs | core | 2,287,728,875 | 11,606 | SeanSelene | > a workaround
>
> ```js
> const label = ()=> h('span', { class: ['cell-auth', info.value.cls] }, info.value.text)
> return () => label()
> ```
>
> or
>
> ```js
> return () => h('span', { class: ['cell-auth', info.value.cls] }, info.value.text)
> ```
It works, Thank You. This means I should create VNod... | 2024-08-14T02:44:09 | 2024-08-14T02:44:09 | {} | NONE |
vuejs | core | 2,288,111,969 | 9,159 | edison1105 | /ecosystem-ci run | 2024-08-14T08:09:10 | 2024-08-14T08:09:10 | {
"+1": 1
} | MEMBER |
vuejs | core | 2,272,798,090 | 11,369 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------- | ------------------- | ------------------- |
| runtime-dom.global.prod.js | 98.8 kB (**+59 B**) | 37.4 kB (**+15 B**) | 33.7 kB (**-45 B**) |
... | 2024-08-07T07:23:46 | 2024-08-15T08:42:02 | {} | NONE |
vuejs | core | 2,291,039,112 | 11,624 | edison1105 | @Jak-Ch-ll
Even though I submitted it first, it's not important. Keep your PR. Thank you for your PR, and feel free to contribute more. | 2024-08-15T10:29:58 | 2024-08-15T10:29:58 | {
"+1": 2
} | MEMBER |
vuejs | core | 2,283,505,035 | 5,680 | edison1105 | Closing as it can not reproduce anymore.
see [playground](https://play.vuejs.org/#eNrVVUtu2zAQvcpAGzuALTtpu3HltI6QRYv+kGYXZcHQI4cJTQoipTpwDHTXdpFL9CC9TXqODqmPHSfuujUMSJzPm3nDmdEymGRZWBYYjILI8FxkFgzaIjtMlJhnOrewhBzTHphLJqX+coIprCDN9Rw65NZpzSZxJU2CcBDreTZxqEmQKKgNjrYMjloDaEziLZN4wyRRXCtjgTN+ie8EvY3hrMN4pwedC945JwOJBEFup... | 2024-08-12T09:33:50 | 2024-08-12T09:33:50 | {} | MEMBER |
vuejs | core | 2,286,459,135 | 11,593 | yyx990803 | Thanks, merging #11589 which was submitted first | 2024-08-13T14:54:31 | 2024-08-13T14:54:31 | {
"heart": 1
} | MEMBER |
vuejs | core | 2,287,725,882 | 11,606 | edison1105 | a workaround
```js
const label = ()=> h('span', { class: ['cell-auth', info.value.cls] }, info.value.text)
return () => label()
```
or
```js
return () => h('span', { class: ['cell-auth', info.value.cls] }, info.value.text)
``` | 2024-08-14T02:40:21 | 2024-08-14T02:40:21 | {
"+1": 1
} | MEMBER |
vuejs | core | 2,290,839,624 | 11,622 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------ | ------------------ | ------------------- |
| runtime-dom.global.prod.js | 98.7 kB (**-1 B**) | 37.4 kB (**-1 B**) | 33.7 kB (**-55 B**) |
| vue.... | 2024-08-15T07:52:35 | 2024-08-15T07:55:24 | {} | NONE |
vuejs | core | 2,292,609,276 | 11,611 | rizypb | Already added the feedback @Disservin | 2024-08-16T02:16:19 | 2024-08-16T02:16:19 | {} | NONE |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.