owner
stringclasses
14 values
repo
stringclasses
14 values
id
int64
116k
4.61B
issue_number
int32
1
181k
author
stringlengths
1
39
body
stringlengths
1
262k
created_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:16:18
updated_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:22:56
reactions
unknown
author_association
stringclasses
5 values
vuejs
core
4,542,400,546
14,871
tiagoroldao
Sounds great, @edison1105 - I'll see about proposing a fix to primevue based on this. It would be nice to document slot forwarding, though, absolutely - it is an advanced topic but one that comes up very frequently.
2026-05-26T08:53:10
2026-05-26T08:53:10
{}
NONE
vuejs
core
4,417,016,952
14,799
pkg-pr-new[bot]
[Open in StackBlitz](https://pkg.pr.new/template/02813eaf-e9f5-4d3c-954b-f2b1acd4616a) <details><summary><b>@vue/compiler-core</b></summary><p> ``` pnpm add https://pkg.pr.new/@vue/compiler-core@14799 ``` ``` npm i https://pkg.pr.new/@vue/compiler-core@14799 ``` ``` yarn add https://pkg.pr.n...
2026-05-11T01:56:17
2026-05-26T09:10:23
{}
NONE
vuejs
core
4,458,654,822
14,825
coderabbitai[bot]
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- pre_merge_checks_walkthrough_start --> <details> <summary>🚥 Pre-merge checks | ✅ 4 | ❌ 1</summary> ### ❌ Failed checks (1 warning) | Check name | Status | Explanation ...
2026-05-15T09:33:05
2026-05-21T02:25:45
{}
NONE
vuejs
core
4,516,238,119
14,875
pkg-pr-new[bot]
[Open in StackBlitz](https://pkg.pr.new/template/701281b8-c778-4afe-aa48-caf7ce582682) <details><summary><b>@vue/compiler-core</b></summary><p> ``` pnpm add https://pkg.pr.new/@vue/compiler-core@14875 ``` ``` npm i https://pkg.pr.new/@vue/compiler-core@14875 ``` ``` yarn add https://pkg.pr.n...
2026-05-22T07:15:16
2026-05-22T10:07:03
{}
NONE
vuejs
core
4,531,082,764
14,880
pkg-pr-new[bot]
[Open in StackBlitz](https://pkg.pr.new/template/04366e1e-05d6-468e-a325-1d790d13b612) <details><summary><b>@vue/compiler-core</b></summary><p> ``` pnpm add https://pkg.pr.new/@vue/compiler-core@14880 ``` ``` npm i https://pkg.pr.new/@vue/compiler-core@14880 ``` ``` yarn add https://pkg.pr.n...
2026-05-25T02:35:07
2026-05-25T02:35:07
{}
NONE
vuejs
core
4,465,671,719
14,828
pkg-pr-new[bot]
[Open in StackBlitz](https://pkg.pr.new/template/162f9b22-3f3b-42cb-96ca-54bf7ad24d47) <details><summary><b>@vue/compiler-core</b></summary><p> ``` pnpm add https://pkg.pr.new/@vue/compiler-core@14828 ``` ``` npm i https://pkg.pr.new/@vue/compiler-core@14828 ``` ``` yarn add https://pkg.pr.n...
2026-05-16T04:54:53
2026-05-26T09:03:10
{}
NONE
vuejs
core
4,485,010,994
14,856
coderabbitai[bot]
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: skip review by coderabbit.ai --> > [!IMPORTANT] > ## Review skipped > > Auto reviews are disabled on base/target branches other than the default branch. > > > > Please check the settings in the CodeRabbit...
2026-05-19T06:29:09
2026-05-19T08:01:24
{}
NONE
vuejs
core
4,514,244,162
14,872
coderabbitai[bot]
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- pre_merge_checks_walkthrough_start --> <details> <summary>🚥 Pre-merge checks | ✅ 4 | ❌ 1</summary> ### ❌ Failed checks (1 warning) | Check name | Status | Explanation ...
2026-05-22T01:49:08
2026-05-25T01:22:25
{}
NONE
vuejs
docs
572,010,147
2
bencodezen
We are considering a new design for the site, so closing this issue to prevent accidental work.
2020-01-08T11:33:44
2020-01-08T11:33:44
{}
MEMBER
vuejs
docs
572,612,367
4
NataliaTepluhina
Proposed structure (currently implemented on Vuepress): - [ ] Docs - [ ] Guide - [ ] Style Guide - [ ] Tooling (core libraries + tooling, could be renamed to `Ecosystem` maybe?) - [ ] API Reference - [ ] Examples - [ ] Examples (should find better name for current examples maybe) - [ ] Cookbook - [...
2020-01-09T15:28:36
2020-01-09T15:28:36
{}
MEMBER
vuejs
docs
573,101,733
33
NataliaTepluhina
@bencodezen @phanan thanks for your comments 🙇‍♀ I've addressed them, could you please take a second look?
2020-01-10T16:17:58
2020-01-10T16:17:58
{}
MEMBER
vuejs
docs
575,984,523
31
phanan
I think our current focus should be migration. Rewrites/improvements can go next, to not complicate the process. Rahul Kadyan <notifications@github.com> schrieb am So. 19. Jan. 2020 um 10:24: > *@znck* commented on this pull request. > > Is the purpose of this PR is only migration or we are considering possible > rew...
2020-01-19T09:28:17
2020-01-19T09:28:17
{}
MEMBER
vuejs
docs
576,023,744
31
NataliaTepluhina
I agree with @phanan, let's follow the idea of small iterations. However, I agree with @znck too on simplifying the example. I created a follow-up issue to prevent losing Rahul's comments while PR will get merged: https://github.com/vuejs/docs-next/issues/38
2020-01-19T16:52:01
2020-01-19T16:52:01
{ "+1": 1 }
MEMBER
vuejs
docs
577,162,090
31
bencodezen
Sorry for the delay @NataliaTepluhina. Thanks for your work on this!
2020-01-22T12:40:32
2020-01-22T12:40:32
{}
MEMBER
vuejs
docs
577,162,608
33
bencodezen
@NataliaTepluhina Small merge conflict. I believe you want what's on this branch over `master`, but didn't want to assume.
2020-01-22T12:42:04
2020-01-22T12:42:04
{}
MEMBER
vuejs
docs
577,307,807
33
NataliaTepluhina
@bencodezen conflicts resolved, merging :)
2020-01-22T17:55:13
2020-01-22T17:55:13
{}
MEMBER
vuejs
docs
577,496,223
35
bencodezen
Oh no! More merge conflicts :(
2020-01-23T04:14:41
2020-01-23T04:14:41
{}
MEMBER
vuejs
docs
578,554,869
40
bencodezen
@NataliaTepluhina Ready to merge!
2020-01-26T23:35:49
2020-01-26T23:35:49
{}
MEMBER
vuejs
docs
578,612,857
40
bencodezen
Great point @phanan! I've created a new issue here https://github.com/vuejs/docs-next/issues/41 so that we don't lose track of that effort. For the purposes of iterating on the content and making progress, I'm going to merge for now since none of this is public at the moment. Hope that's okay!
2020-01-27T06:45:24
2020-01-27T06:45:24
{}
MEMBER
vuejs
docs
579,357,431
39
NataliaTepluhina
@znck added an explanation of case-insensitiveness and using kebab-cased names
2020-01-28T17:13:59
2020-01-28T17:13:59
{}
MEMBER
vuejs
docs
579,832,474
43
bencodezen
Change was made in https://github.com/vuejs/docs-next/commit/41284fef90db3796308c847ae36c546c298d32e6, but it does not live in the cookbook yet
2020-01-29T16:11:24
2020-01-29T16:11:24
{}
MEMBER
vuejs
docs
592,551,358
47
NataliaTepluhina
@bencodezen I've responded to some of your comments, back to you for the discussion!
2020-02-28T15:01:33
2020-02-28T15:01:33
{}
MEMBER
vuejs
docs
596,455,820
51
phanan
The page should be ready for review and [previewing](https://deploy-preview-51--vue-next.netlify.com/community/team.html) now.
2020-03-09T10:49:45
2020-03-09T10:49:45
{}
MEMBER
vuejs
docs
597,763,796
55
phanan
Page can now be previewed at https://deploy-preview-55--vue-next.netlify.com/community/themes.html.
2020-03-11T17:25:01
2020-03-11T17:25:01
{}
MEMBER
vuejs
docs
598,466,464
50
sdras
> @sdras should we mention changes to mounting app? I.e. `new Vue().$mount` -> `Vue.createApp({}).mount('#app')?` Yep, that's to come! As mentioned in the details of this PR, I'm not doing it all at once, so that it's easier to see what changed. Big honking PRs are often harder to review and merge. :)
2020-03-12T22:50:35
2020-03-12T22:50:35
{}
MEMBER
vuejs
docs
598,995,835
50
sdras
Ok, put in a more healthy `.gitignore`, and fixed up the merge conflicts, let me know what you think :) if it's ready to keep working on, I'll keep adding more of the migration guide from here
2020-03-14T01:53:31
2020-03-14T01:53:31
{}
MEMBER
vuejs
docs
599,121,574
56
phanan
Page ready for review: https://deploy-preview-56--vue-next.netlify.com/style-guide/.
2020-03-14T18:59:37
2020-03-14T18:59:37
{}
MEMBER
vuejs
docs
599,221,668
57
NataliaTepluhina
Codepens style is a subject to discuss of course 😅 If we decide to use codepens, I will continue migration in this PR
2020-03-15T15:01:21
2020-03-15T15:01:21
{}
MEMBER
vuejs
docs
602,195,172
57
NataliaTepluhina
@sdras @znck @bencodezen @phanan @shentao could you please review this one? I've just resolved `WIP` status 😅
2020-03-22T12:48:46
2020-03-22T12:48:46
{}
MEMBER
vuejs
docs
603,437,259
10
NataliaTepluhina
As we've moved to codepens in https://github.com/vuejs/docs-next/pull/57 and https://github.com/vuejs/docs-next/pull/60, I will go ahead and close this issue. If we decide to change our code widget strategy, we can reopen it.
2020-03-24T18:40:59
2020-03-24T18:40:59
{}
MEMBER
vuejs
docs
603,438,941
26
NataliaTepluhina
I don't think we need `Cookbook` ready by docs alpha so I am changing a milestone to `release`
2020-03-24T18:44:18
2020-03-24T18:44:18
{}
MEMBER
vuejs
docs
609,084,575
62
sdras
Forgot to mention, as per our earlier conversations, I added a small thing into the writing guide about how scoping down PRs. The irony does not escape me.
2020-04-04T20:26:05
2020-04-04T20:26:05
{}
MEMBER
vuejs
docs
609,460,327
49
NataliaTepluhina
I've updated the description with alpha-11 syntax 🎉 A PR is ready for review now
2020-04-05T18:24:28
2020-04-05T18:24:28
{}
MEMBER
vuejs
docs
610,558,166
49
NataliaTepluhina
@znck As for codepens: I don't think we can make them resizeable 🤔
2020-04-07T18:47:44
2020-04-07T18:47:44
{}
MEMBER
vuejs
docs
610,609,467
49
phanan
@NataliaTepluhina Pens can be resizable, like this: ```css .cp_embed_wrapper { overflow: hidden; resize: both; } .cp_embed_wrapper iframe { height: 100% !important; } ```
2020-04-07T20:41:10
2020-04-07T20:41:10
{ "heart": 1 }
MEMBER
vuejs
docs
610,757,697
64
sdras
looks good, thanks :)
2020-04-08T05:23:07
2020-04-08T05:23:07
{}
MEMBER
vuejs
docs
613,430,216
49
NataliaTepluhina
@znck Added more requested changes, back to you ⚽
2020-04-14T13:04:43
2020-04-14T13:04:43
{ "laugh": 1 }
MEMBER
vuejs
docs
613,627,117
67
NataliaTepluhina
Great work @shentao! As I was doing a (p)review of the Notion doc, I don't have any additional comments 😅
2020-04-14T19:06:49
2020-04-14T19:06:49
{ "heart": 2 }
MEMBER
vuejs
docs
613,628,905
67
shentao
Thanks @NataliaTepluhina! Let me know if there is any other way I could help out!
2020-04-14T19:10:15
2020-04-14T19:10:15
{}
MEMBER
vuejs
docs
613,949,591
67
znck
@shentao You can use grammarly.com to catch issues like "color" instead of "colour" and there's a [vscode extension too](https://marketplace.visualstudio.com/items?itemName=znck.grammarly) (_shameless plug_).
2020-04-15T10:14:04
2020-04-15T10:14:04
{}
MEMBER
vuejs
docs
617,997,151
21
Jinjiang
Hi @bencodezen please allow me ask a stupid question 😅: do we plan to keep the 2.0 docs in the original repo and deploy it to another domain like v2.vuejs.org? Or would that also be here? If I didn't misunderstand, our plan is: - vuejs.org: for 3.0 docs - v2.vuejs.org: for our current website, about 2.0 docs S...
2020-04-22T19:47:34
2020-04-22T19:48:12
{}
MEMBER
vuejs
docs
619,423,775
68
Jinjiang
I probably prefer the title "Application Config" and "Application API" respectively. Because in v3 it's possible to create more than one applications in the same page. So we could customize them separately. That's more like an application-level thing.
2020-04-25T18:44:20
2020-04-25T18:44:20
{}
MEMBER
vuejs
docs
619,550,978
71
NataliaTepluhina
Wow, @phanan, this is super impressive work! 🙇 Will need a day to give it a proper review A small visual bug I've found just now (buttons are misaligned): <img width="674" alt="Screenshot 2020-04-26 at 16 34 58" src="https://user-images.githubusercontent.com/18719025/80309203-2ade7b80-87dc-11ea-84fd-4989344f8621.p...
2020-04-26T13:37:26
2020-04-26T13:37:26
{}
MEMBER
vuejs
docs
619,556,692
71
phanan
> A small visual bug I've found just now (buttons are misaligned) Yeah, the reason is we don't have enough OpenCollective to fill (3 platinum and 10 gold spots). We have the same issue on the current homepage.
2020-04-26T14:10:28
2020-04-26T14:10:28
{}
MEMBER
vuejs
docs
619,558,424
12
phanan
Closing as duplicate of #3.
2020-04-26T14:18:48
2020-04-26T14:18:48
{}
MEMBER
vuejs
docs
619,572,363
68
NataliaTepluhina
Thank you so much for the thorough review @Jinjiang! I've applied all the suggestions besides `app.component` argument - you can check this [sandbox](https://codesandbox.io/s/async-components-zbnke?file=/index.html) - if we remove the second parameter, `app.component` will return `undefined`. Could you please give ...
2020-04-26T15:43:33
2020-04-26T15:43:33
{}
MEMBER
vuejs
docs
619,600,652
62
sdras
Thanks for the feedback! Ok, this should be in a better state now for merging. In subsequent PRs, we will address: - change detection caveats section - moving codepens to Vue account and click to load functionality Let me know if you need further changes on this that don't apply to those two pieces! Thanks!
2020-04-26T18:25:17
2020-04-26T18:25:17
{}
MEMBER
vuejs
docs
623,117,029
67
NataliaTepluhina
As we have no further comments, I'm merging this PR 🎉
2020-05-03T14:18:27
2020-05-03T14:18:27
{}
MEMBER
vuejs
docs
623,125,919
1
phanan
I think this can be closed now, no?
2020-05-03T15:19:17
2020-05-03T15:19:17
{}
MEMBER
vuejs
docs
623,126,146
27
NataliaTepluhina
Looks like it does! <img width="396" alt="Screenshot 2020-05-03 at 18 20 38" src="https://user-images.githubusercontent.com/18719025/80917946-d18dc380-8d6a-11ea-919c-76137c337e60.png">
2020-05-03T15:20:55
2020-05-03T15:20:55
{}
MEMBER
vuejs
docs
623,126,701
4
NataliaTepluhina
@Jinjiang I like this proposal! We could put GitHub links to docs repo in the footer of every single page (via `Edit this page on GitHub` link) and we have GH link to core repo on the homepage. Rest are 5 links in navbar and I believe we can survive this amount 😅
2020-05-03T15:24:32
2020-05-03T15:25:03
{}
MEMBER
vuejs
docs
623,126,930
11
NataliaTepluhina
Resolved: we handle sidebars with VuePress successfully
2020-05-03T15:25:48
2020-05-03T15:25:48
{}
MEMBER
vuejs
docs
623,271,222
77
phanan
> But as far as I remember, we had a discussion with @phanan in January on Discord and he had many arguments against it. I only use shorthands myself 😅. AFAIR my main argument against using shorthands in docs is if we use them everywhere it would make it harder to reorder the content. For example, if in A.md we int...
2020-05-04T05:54:01
2020-05-04T05:54:01
{}
MEMBER
vuejs
docs
623,356,851
29
phanan
We have several different types of sponsors at the moment: - Patreon - OpenCollective - Special Sponsor(s?) - Special Sponsor(s?) China For OpenCollective it's straightforward: We only need to print a series of `<a><img>` tags. For Patreon, according to Evan this information is handled by vue-bot with his pers...
2020-05-04T09:27:11
2020-05-04T09:27:11
{}
MEMBER
vuejs
docs
625,003,089
81
sdras
Also to mention, since we all chatted offline, @mlama007 should own this section moving forward :)
2020-05-07T03:08:15
2020-05-07T03:08:15
{ "+1": 2 }
MEMBER
vuejs
docs
625,539,615
81
sdras
Talked to Maria, merged so she could get started on her version :)
2020-05-07T23:01:56
2020-05-07T23:01:56
{}
MEMBER
vuejs
docs
625,547,350
81
sdras
@phanan also just invited her to the docs meetings :)
2020-05-07T23:28:11
2020-05-07T23:28:11
{}
MEMBER
vuejs
docs
626,129,310
66
bencodezen
Due to progress on the Home Page, this PR needs to be broken out into smaller features since the merge conflicts is kind of hard to process. Keeping this PR open to ensure feedback is accounted for in the subsequent PRs.
2020-05-09T08:34:20
2020-05-09T08:34:20
{}
MEMBER
vuejs
docs
626,143,749
85
bencodezen
Waiting for new custom containers (#86) to be merged before creating the design style for different blocks people can use for documentation
2020-05-09T10:21:08
2020-05-09T10:21:08
{}
MEMBER
vuejs
docs
626,150,290
90
phanan
Hmm… To be honest, I'd prefer to keep the current style as-is, as it already has two elements to explain the intention: color and text/label. The icons don't add anything new IMHO, and instead are prone to unnecessary aesthetical discussions/bikeshedding.
2020-05-09T11:05:15
2020-05-09T11:05:15
{}
MEMBER
vuejs
docs
572,653,655
11
NataliaTepluhina
Partly resolved in https://github.com/vuejs/docs-next/pull/33
2020-01-09T16:55:25
2020-01-09T16:55:25
{}
MEMBER
vuejs
docs
578,555,564
40
phanan
Folks, per Vue’s coding style there should always be a space after function names e.g. `data ()` instead of `data()`. We kind of miss this entirely in the PRs so far. Ben Hong <notifications@github.com> schrieb am Mo. 27. Jan. 2020 um 06:35: > @NataliaTepluhina <https://github.com/NataliaTepluhina> Ready to merge! > ...
2020-01-26T23:44:33
2020-01-26T23:44:33
{ "+1": 1 }
MEMBER
vuejs
docs
578,596,843
40
NataliaTepluhina
@phanan maybe should we switch to ESLint for the docs? From what I can see it allows to set up a rule for space before parentheses while Prettier deprecated this rule.
2020-01-27T05:26:33
2020-01-27T05:26:33
{}
MEMBER
vuejs
docs
578,769,427
39
NataliaTepluhina
@znck changed back to camelCased names after the issue fix. The only kebab-cased thing is a `:model-value` prop due to [our styleguide](https://vuejs.org/v2/style-guide/#Prop-name-casing-strongly-recommended) Could you please give it the last (I hope so!) look?
2020-01-27T14:20:58
2020-01-27T14:20:58
{}
MEMBER
vuejs
docs
578,773,956
41
yyx990803
In v3 we are adopting prettier, so maybe we should just use that (minimal config to worry about and just auto-format on commit)
2020-01-27T14:29:28
2020-01-27T14:29:28
{}
MEMBER
vuejs
docs
578,941,847
41
bencodezen
@yyx990803 Agreed on it taking minimal config to worry about. This was originally filed as a result of: > Per Vue’s coding style there should always be a space after function names e.g. `data ()` instead of `data()`. since Prettier doesn't allow us to configure for this style. @NataliaTepluhina @phanan @sdra...
2020-01-27T20:39:40
2020-01-27T20:39:40
{ "heart": 1 }
MEMBER
vuejs
docs
579,382,601
14
NataliaTepluhina
Closing an issue as all mentioned sections were migrated
2020-01-28T18:12:12
2020-01-28T18:12:12
{}
MEMBER
vuejs
docs
591,039,469
48
NataliaTepluhina
@znck could you please take an early look at this? Any changes / additions are much appreciated!
2020-02-25T19:56:46
2020-02-25T19:56:46
{}
MEMBER
vuejs
docs
591,041,212
47
NataliaTepluhina
@phanan @bencodezen @znck could you please review this one as well?
2020-02-25T20:00:50
2020-02-25T20:00:50
{}
MEMBER
vuejs
docs
592,560,287
47
NataliaTepluhina
@bencodezen thank you so much for the thorough review! I've added some fixes (I removed the `default` slot not wrapped in the `template` after the discussion with Rahul as this behavior is discouraged in Vue 3). I would be happy if we continue the discussion on a few points here. I agree scoped slots are the main pa...
2020-02-28T15:21:49
2020-02-28T15:21:49
{}
MEMBER
vuejs
docs
593,109,111
47
NataliaTepluhina
@bencodezen @znck I've changed an example for scoped slots to be more real-life and added some poor-quality diagrams 😅 Please disregard my poor drawing skills for now but do you think they're descriptive enough?
2020-03-01T15:22:34
2020-03-01T15:22:34
{}
MEMBER
vuejs
docs
593,893,284
47
znck
I like the new examples.
2020-03-03T11:02:37
2020-03-03T11:02:37
{}
MEMBER
vuejs
docs
594,534,499
47
NataliaTepluhina
@znck @LinusBorg @bencodezen @phanan I am merging this MR but images are intended to be improved (they're kinda ugly right now but leaving them there to have an idea of what do we want to show)
2020-03-04T13:51:09
2020-03-04T13:51:09
{ "+1": 1 }
MEMBER
vuejs
docs
596,241,385
50
sdras
Looks like I need to add in a `.gitignore` for those DS_store files
2020-03-08T19:18:34
2020-03-08T19:18:34
{}
MEMBER
vuejs
docs
596,257,008
50
phanan
> Looks like I need to add in a `.gitignore` for those DS_store files They should go into your global ignore file :)
2020-03-08T21:50:58
2020-03-08T21:50:58
{}
MEMBER
vuejs
docs
596,349,838
48
NataliaTepluhina
@znck I've done some fixes, could you please give it another round of review?
2020-03-09T06:18:26
2020-03-09T06:18:26
{}
MEMBER
vuejs
docs
596,507,849
22
phanan
"Meet the Team" has been handled by #13.
2020-03-09T12:54:54
2020-03-09T12:54:54
{}
MEMBER
vuejs
docs
597,066,608
50
NataliaTepluhina
@sdras should we mention changes to mounting app? I.e. `new Vue().$mount` -> `Vue.createApp({}).mount('#app')?`
2020-03-10T12:46:19
2020-03-10T12:46:30
{}
MEMBER
vuejs
docs
597,067,106
51
NataliaTepluhina
@phanan wow, this looks great! 👍
2020-03-10T12:47:33
2020-03-10T12:47:33
{}
MEMBER
vuejs
docs
597,495,160
53
phanan
The page can now be previewed at: https://deploy-preview-53--vue-next.netlify.com/community/partners.html Changes (actually, no changes) to the Team page: https://deploy-preview-53--vue-next.netlify.com/community/team.html
2020-03-11T08:02:42
2020-03-11T08:02:42
{}
MEMBER
vuejs
docs
597,705,305
53
NataliaTepluhina
@phanan looks good to me! 👍
2020-03-11T15:37:59
2020-03-11T15:37:59
{}
MEMBER
vuejs
docs
598,466,217
50
sdras
> > Looks like I need to add in a `.gitignore` for those DS_store files > > They should go into your global ignore file :) I actually keep it this way so I can notice which repos are not .gitignoring properly, such as ours :) I'll put in a good one in the next commit.
2020-03-12T22:49:42
2020-03-12T22:49:42
{}
MEMBER
vuejs
docs
599,229,189
57
phanan
Great work! Should we take this chance to "rename" the apps to something other than the meaningless `App(n)`? I'm thinking about more declarative names (and with them, corresponding DOM ID's) like `HelloVueApp` or `ElementBindingApp` etc.
2020-03-15T16:01:52
2020-03-15T16:02:23
{ "+1": 2 }
MEMBER
vuejs
docs
599,250,182
57
NataliaTepluhina
@phanan omg that's a great idea! 👍 I am all up for it
2020-03-15T18:58:07
2020-03-15T18:58:07
{}
MEMBER
vuejs
docs
603,438,602
25
NataliaTepluhina
I don't think we need `Examples` ready for docs alpha so I am changing a milestone to `release`
2020-03-24T18:43:39
2020-03-24T18:43:39
{}
MEMBER
vuejs
docs
609,364,144
49
NataliaTepluhina
Removing `blocked` label as Async Components PR was merged 🎉 Will update it to the new syntax and resolve a WIP status today
2020-04-05T05:59:50
2020-04-05T05:59:50
{}
MEMBER
vuejs
docs
612,426,830
61
NataliaTepluhina
@znck thank you so much for awesome suggestions! I've applied most of them and done some rewrites accordingly. Could you please give it a second round of review?
2020-04-11T13:55:18
2020-04-11T13:55:18
{}
MEMBER
vuejs
docs
612,754,840
49
NataliaTepluhina
@znck implemented all the required changes, could you please take a second look?
2020-04-13T05:19:21
2020-04-13T05:19:21
{}
MEMBER
vuejs
docs
613,822,501
49
znck
👏 Looks great, nothing more from my side.
2020-04-15T05:20:27
2020-04-15T05:20:27
{}
MEMBER
vuejs
docs
613,836,872
67
phanan
One thing I forgot to mention: Let’s all use American English (IIRC this is mentioned somewhere in our writing guide) for our docs, so “color” instead of “colour” ;) On Wed, 15 Apr 2020 at 07:57, Rahul Kadyan <notifications@github.com> wrote: > *@znck* commented on this pull request. > > Very long PR, I will continue...
2020-04-15T06:09:15
2020-04-15T06:09:15
{}
MEMBER
vuejs
docs
613,951,244
67
shentao
Thanks for the reviews @znck and @phanan (again!). Yeah, I do use Grammarly quite often. I think my system is just set to British English (gotta change that). I’m not using VS Code!
2020-04-15T10:18:03
2020-04-15T10:18:33
{}
MEMBER
vuejs
docs
614,097,350
15
NataliaTepluhina
Closing the issue as we're migrated the Components in depth section
2020-04-15T15:09:33
2020-04-15T15:09:33
{}
MEMBER
vuejs
docs
617,984,930
4
Jinjiang
I think there are 2 types of links: internal links and external links. For our main navigation, it's better to expand internal links more and fold up external links a little bit relatively, because we could assume users come here more like find out something inside I guess. So my idea is: - Docs (priority: 1) ...
2020-04-22T19:31:06
2020-04-22T19:32:02
{}
MEMBER
vuejs
docs
619,685,957
73
bencodezen
@NataliaTepluhina Saw that you marked it as WIP so I converted the PR to Draft so it didn't accidentally get merged before you are ready. Missing GitLab's feature of detecting WIP and automatically doing this for me already. 😆
2020-04-27T03:09:34
2020-04-27T03:09:34
{ "laugh": 1 }
MEMBER
vuejs
docs
623,204,698
77
sdras
Oh, also updated the writing guide to allow companies to use their proper spelling
2020-05-03T23:55:14
2020-05-03T23:55:14
{}
MEMBER
vuejs
docs
623,245,473
77
NataliaTepluhina
I'm supporting shorthands in docs with all my heart 😅 But as far as I remember, we had a discussion with @phanan in January on Discord and he had many arguments against it. However, I am totally open to discussing in one more time and I'd be happy to see shorthand in docs.
2020-05-04T03:56:18
2020-05-04T03:56:18
{}
MEMBER
vuejs
docs
623,791,849
77
sdras
@phanan, that's fair, and a good argument. I don't think it would be a problem, though. If you look through the PR, you'll see there's a clear division here. Directives are first introduced, we introduce shortcuts at the same time, from then on we only use shortcuts (adding reference to the full directive when it's use...
2020-05-05T01:29:26
2020-05-05T01:29:26
{}
MEMBER
vuejs
docs
624,218,613
77
NataliaTepluhina
Side note: if/when this PR is merged, we need to go through codepens to fix directives syntax there as well.
2020-05-05T18:09:13
2020-05-05T18:09:13
{}
MEMBER
vuejs
docs
624,277,952
79
phanan
Repository conversion is done for both `master` and `pagejs`: https://github.com/phanan/vue-3.0-simple-routing-example/compare/master..pagejs.
2020-05-05T20:05:46
2020-05-05T20:05:46
{}
MEMBER
vuejs
docs
625,184,270
81
Jinjiang
Hi @sdras really nice article. I have some ideas: 1. I'm not 100% sure that's true, but currently most frontend development is based on components system. So I think we could divide a11y issues into several parts: - An inclusive component like checkbox, menu, modal, etc. That could be directly target to our com...
2020-05-07T11:01:02
2020-05-07T11:05:36
{}
MEMBER