owner
stringclasses
14 values
repo
stringclasses
14 values
id
int64
116k
4.61B
issue_number
int32
1
181k
author
stringlengths
1
39
body
stringlengths
1
262k
created_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:16:18
updated_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:22:56
reactions
unknown
author_association
stringclasses
5 values
vuejs
docs
956,042,113
1,308
skirtles-code
Thanks for the report. I'll create a PR for this. There are a couple of other problems with the `key` section that I'd also like to resolve.
2021-11-01T08:43:13
2021-11-01T08:43:13
{}
CONTRIBUTOR
vuejs
docs
944,901,433
694
NataliaTepluhina
I believe that non-reactive properties (in Options API) should not be declared in `mounted` hook but rather explicitly added via `$options` ```js export default defineComponent({ // this can be accessed via this.$options.myProperty myProperty: 'test' }); ``` However, the type of it will be `any` even if ...
2021-10-16T11:31:15
2021-10-16T11:31:15
{}
MEMBER
vuejs
docs
955,627,551
1,306
skirtles-code
My theory was that it was originally hidden and it was revealed later due to upgrading VuePress. However, I just checked the original test deployment at https://deploy-preview-864--vue-docs-v3-legacy.netlify.app/guide/ssr/introduction.html#about-this-guide and that doesn't appear to be the case. It has, indeed, been th...
2021-10-31T02:54:34
2021-10-31T02:54:34
{}
CONTRIBUTOR
vuejs
docs
966,797,482
1,321
skirtles-code
Thanks for the PR! In my opinion, trying to be more precise just makes it more difficult to follow. I don't know whether it's worth making a distinction between 'preventing a click' and 'preventing a click's default behavior' in the context of this sentence. It's a pretty subtle distinction and I don't think the rea...
2021-11-12T03:47:23
2021-11-12T03:47:23
{}
CONTRIBUTOR
vuejs
docs
936,216,806
1,273
stafyniaksacha
Hello ! Do you think we can add vuero to your list ? We try to follow all good practices from vue 3 (We can send invitation to check if you need) https://vuero.cssninja.io/ Edit: we got free template too, and we are working on an open-source component library
2021-10-06T13:15:01
2021-10-06T13:16:51
{ "+1": 1, "heart": 1 }
NONE
vuejs
docs
944,898,101
1,200
NataliaTepluhina
@skirtles-code I believe we should add a note to the TS guide rather than to the default (as default works in the non-TS environment). Alternatively, we can change all examples to use arrow functions from the starts - this will resolve the concern without adding anything to TS guide
2021-10-16T11:02:26
2021-10-16T11:02:26
{}
MEMBER
vuejs
docs
952,619,007
1,291
NataliaTepluhina
This is planned for when docs refactoring is finished (you can track the progress on the `next` branch of the current repo). I'll keep the issue open till then
2021-10-27T07:29:46
2021-10-27T07:29:46
{}
MEMBER
vuejs
docs
955,478,623
1,294
skirtles-code
@Miguel-Bento-Github Thanks for the report. Did you want to put in a PR for this yourself? There's an edit link at the bottom of the deployed page if you don't fancy cloning the repo locally. I can do it if you prefer.
2021-10-30T16:57:28
2021-10-30T16:57:28
{}
CONTRIBUTOR
vuejs
docs
657,371,259
143
phanan
No please don't merge. I'll be that guy here again. Let's discuss the "Critical" part first.
2020-07-13T05:44:46
2020-07-13T05:44:46
{}
MEMBER
vuejs
docs
658,531,022
182
bencodezen
Love the nitpicky bracket police! Thanks for all the suggestions. Made it really easy to commit it all!
2020-07-15T03:56:55
2020-07-15T03:56:55
{}
MEMBER
vuejs
docs
660,459,017
219
NataliaTepluhina
@umutbozdag thank you! It was misspelled indeed, fixed via https://github.com/vuejs/docs-next/commit/a0250c2c667a6d5cee7c1cca3a32d60461651c8c
2020-07-18T09:56:41
2020-07-18T09:56:41
{}
MEMBER
vuejs
docs
660,584,789
245
sdras
Good shout! The line highlighting isn't showing up locally so trying a few things here, one sec
2020-07-19T04:24:55
2020-07-19T04:24:55
{}
MEMBER
vuejs
docs
660,585,695
230
NataliaTepluhina
@robokozo yes, I believe so! I will add a brief installation instruction and will remove it when CLI is ready 👍🏻
2020-07-19T04:35:16
2020-07-19T04:35:16
{}
MEMBER
vuejs
docs
660,861,009
16
NataliaTepluhina
Closing this issue as transitions content is migrated. We can cover smaller fixes with additional issues if necessary
2020-07-20T07:42:06
2020-07-20T07:42:06
{}
MEMBER
vuejs
docs
658,530,492
183
bencodezen
@NataliaTepluhina Great finds. Committed both changes!
2020-07-15T03:54:38
2020-07-15T03:54:38
{}
MEMBER
vuejs
docs
660,427,818
213
NataliaTepluhina
@manuelojeda thank you so much for spotting it 🙇
2020-07-18T05:14:28
2020-07-18T05:14:28
{}
MEMBER
vuejs
docs
660,556,233
237
bencodezen
Hi @acidiney. Thanks for the PR. We're still in the process of working on some information architecture changes, so at this time we're not ready for PRs on this part yet. To keep track of this, I would definitely like to give you credit for pointing this out by having you create a separate issue regarding a path fo...
2020-07-18T23:18:01
2020-07-18T23:18:01
{ "+1": 1 }
MEMBER
vuejs
docs
660,579,890
241
sdras
Nice catch, thank you!
2020-07-19T03:28:17
2020-07-19T03:28:17
{}
MEMBER
vuejs
docs
660,584,628
240
NataliaTepluhina
Closing an issue as related PR was merged
2020-07-19T04:22:57
2020-07-19T04:22:57
{}
MEMBER
vuejs
docs
660,716,983
268
sdras
Thank you An! This was bugging me 😅
2020-07-19T22:08:50
2020-07-19T22:08:50
{}
MEMBER
vuejs
docs
660,735,116
270
sdras
Nice, thanks!
2020-07-20T00:25:15
2020-07-20T00:25:15
{}
MEMBER
vuejs
docs
660,779,734
263
NataliaTepluhina
@CyberAP it's a good point! However, it does require adding a point about multiple expressions to `v-on` directive description. Would you prefer to add it to this PR? (non-mandatory, I can create a follow-up for this)
2020-07-20T03:21:53
2020-07-20T03:21:53
{}
MEMBER
vuejs
docs
657,572,448
146
bencodezen
Thanks for the review @NataliaTepluhina! I fixed up the parts you commented. Let me know if you see anything else!
2020-07-13T13:48:59
2020-07-13T13:48:59
{}
MEMBER
vuejs
docs
658,091,739
161
NataliaTepluhina
@bencodezen looks good to me! One question: should we mention `Suspense` or leave it as it's still experimental now? 🤔
2020-07-14T10:01:46
2020-07-14T10:01:46
{}
MEMBER
vuejs
docs
658,577,737
184
ota-meshi
@NataliaTepluhina Thank you very much! I will open PR.
2020-07-15T06:42:19
2020-07-15T06:42:19
{ "rocket": 1 }
MEMBER
vuejs
docs
660,306,766
181
phanan
The Netlify preview is gone for some reason. @bencodezen maybe a rebuild?
2020-07-17T19:48:52
2020-07-17T19:48:52
{}
MEMBER
vuejs
docs
660,524,333
233
phanan
I'd vote for a pre-commit hook. Husky and lint-staged work pretty well for me.
2020-07-18T18:44:36
2020-07-18T18:44:44
{ "+1": 2 }
MEMBER
vuejs
docs
660,574,991
32
beetaa
Hi Natalia, how about the translation plan? If I want to tranlate, how can I begin with vue3's new doc? thanks. @NataliaTepluhina
2020-07-19T02:30:48
2020-07-19T02:30:48
{}
NONE
vuejs
docs
660,677,205
251
CyberAP
> @CyberAP Since this is a temporary feature, I'd like to keep the component as self-contained as possible. You can achieve the same thing if you put `v-if` on a root element of `<BetaBanner>` component. It is actually present in the current edit, so there's no much need for `this.$el.remove()`, `shouldShow` just ha...
2020-07-19T17:07:10
2020-07-19T17:09:24
{}
CONTRIBUTOR
vuejs
docs
656,273,114
131
NataliaTepluhina
@bencodezen @phanan @sdras I did a refactoring for `Advanced` section as we've discussed on the Docs meeting. Could you please review the changes? 🙏
2020-07-09T18:07:11
2020-07-09T18:07:11
{}
MEMBER
vuejs
docs
658,350,298
175
bencodezen
> @bencodezen added a minor nitpick 😅 Good nitpick @NataliaTepluhina! Committed the change!
2020-07-14T18:49:07
2020-07-14T18:49:07
{}
MEMBER
vuejs
docs
658,526,334
173
NataliaTepluhina
@bencodezen Agreedm I believe badges will help people to see whether the change is breaking
2020-07-15T03:36:54
2020-07-15T03:36:54
{}
MEMBER
vuejs
docs
660,499,553
214
yyyanghj
> Thanks for the catch on the `key`, `prop` typo! However, we want to keep the spread operator. Can you please remove those changes? Then we can merge. Sure. It's done.
2020-07-18T15:33:42
2020-07-18T15:33:42
{}
CONTRIBUTOR
vuejs
docs
660,504,505
214
sdras
Thank you!
2020-07-18T16:12:13
2020-07-18T16:12:13
{}
MEMBER
vuejs
docs
660,662,798
243
sdras
Thank for all the edits @NataliaTepluhina! They should be all resolved now :)
2020-07-19T15:24:34
2020-07-19T15:24:34
{}
MEMBER
vuejs
docs
660,952,916
277
davidbernegger
@marina-mosti / @NataliaTepluhina thanks - also thanks back to you with your amazing contributions to the docs! :D
2020-07-20T10:47:34
2020-07-20T10:47:34
{}
CONTRIBUTOR
vuejs
docs
656,162,895
141
bencodezen
> Just a few minor typo fixes 😅 That's what happens when you write docs at like 6am and try to get a PR out before heading out to an appointment. 😆 Thanks for catching them!
2020-07-09T14:31:07
2020-07-09T14:31:07
{}
MEMBER
vuejs
docs
658,733,284
183
bencodezen
@NataliaTepluhina Just fixed merge conflicts. Let me know if you think anything else needs changing!
2020-07-15T12:16:49
2020-07-15T12:16:49
{}
MEMBER
vuejs
docs
659,394,936
189
NataliaTepluhina
@Justineo valid arguments! Point proved 😅 I've updated the description with these two points
2020-07-16T13:00:33
2020-07-16T13:00:33
{}
MEMBER
vuejs
docs
660,518,058
231
NataliaTepluhina
@klausXR thank you so much for catching it! Fixed via https://github.com/vuejs/docs-next/commit/a1d118383e8bb5883c10d1f4504b094856e8bcf2
2020-07-18T17:54:52
2020-07-18T17:54:52
{}
MEMBER
vuejs
docs
660,541,265
233
sdras
Agree with @phanan :)
2020-07-18T20:55:22
2020-07-18T20:55:22
{}
MEMBER
vuejs
docs
660,580,145
181
sdras
Looks like there are some merge conflicts and then we're good to go, @bencodezen
2020-07-19T03:31:23
2020-07-19T03:31:23
{ "+1": 1 }
MEMBER
vuejs
docs
660,584,590
244
NataliaTepluhina
@liulinboyi thank you for reporting it! I believe it's worth open an issue on [VuePress repo](https://github.com/vuejs/vuepress) as we use it and I can spot the same behavior on [VueApollo](https://apollo.vuejs.org/) website (also built with VuePress). 🙏🏻 Unfortunately, we can't fix it on our side, so I'm closing...
2020-07-19T04:22:27
2020-07-19T04:22:27
{}
MEMBER
vuejs
docs
660,685,055
258
CyberAP
It is a deployment-dependent thing. Current deployment destroys links to previous chunks making them unreachable.
2020-07-19T18:08:23
2020-07-19T18:08:23
{}
CONTRIBUTOR
vuejs
docs
657,554,011
139
NataliaTepluhina
@bencodezen would you mind resolving conflicts here so we could merge? 😅
2020-07-13T13:15:49
2020-07-13T13:15:49
{ "+1": 1 }
MEMBER
vuejs
docs
657,651,631
144
NataliaTepluhina
@phanan thanks for the fixes! Changes look good to me now 👍
2020-07-13T16:11:43
2020-07-13T16:11:43
{}
MEMBER
vuejs
docs
660,512,198
227
Rolanddoda
Oops, didn't see the note about no additional contributions. Used the github UI to update the change so I just clicked around.
2020-07-18T17:08:34
2020-07-18T17:11:19
{}
CONTRIBUTOR
vuejs
docs
660,676,976
251
phanan
@CyberAP Since this is a temporary feature, I'd like to keep the component as self-contained as possible.
2020-07-19T17:05:35
2020-07-19T17:05:42
{}
MEMBER
vuejs
docs
660,703,701
265
CyberAP
I understand the best intent here, but for a novice Vue learner it is unclear why `Date.now()` is not reactive, since it's not mentioned before how a value becomes reactive. It's a very common issue among developers at start to not being able to distinguish between reactive and non-reactive values. I think it is benefi...
2020-07-19T20:27:15
2020-07-19T20:27:15
{}
CONTRIBUTOR
vuejs
docs
656,164,635
141
NataliaTepluhina
@bencodezen thanks for fixing them! PR looks good to me now 👍
2020-07-09T14:34:09
2020-07-09T14:34:09
{}
MEMBER
vuejs
docs
657,544,543
143
NataliaTepluhina
@phanan @bencodezen I've removed the 'categorization' to `Critical`/`High`/etc and refactored `v-model` changes a bit to include @sdras previous work on Migration guide. Could you please take a second look? 🙏
2020-07-13T12:57:24
2020-07-13T12:57:24
{}
MEMBER
vuejs
docs
658,355,624
171
bencodezen
@phanan @NataliaTepluhina @sdras At first, I thought maybe we'd put this message somewhere on the site, but maybe it'd be best just to add it as a PR template? Or maybe we should add some messaging somewhere that's like: "Feedback welcome via GitHub issues, but please hold off on any pull requests as the docs ar...
2020-07-14T19:00:06
2020-07-14T19:00:06
{}
MEMBER
vuejs
docs
659,779,610
203
bencodezen
@phanan @NataliaTepluhina Since this is a broken link on production, going to go ahead and merge since I just tested the Netlify preview and it works. Hope it's okay I'm merging without approval! 🙇
2020-07-17T01:42:18
2020-07-17T01:42:18
{}
MEMBER
vuejs
docs
660,507,982
224
bencodezen
@NataliaTepluhina Do we have this function documented somewhere in the API? Can't seem to find it, but if not, happy to create an issue for it.
2020-07-18T16:36:28
2020-07-18T16:36:28
{}
MEMBER
vuejs
docs
660,652,551
251
NataliaTepluhina
@phanan Netlify build produces an error: ``` ReferenceError: localStorage is not defined ```
2020-07-19T14:27:33
2020-07-19T14:27:33
{}
MEMBER
vuejs
docs
660,688,819
259
NataliaTepluhina
Duplicate of https://github.com/vuejs/docs-next/issues/244 I don't think this issue is specific to the documentation repository. Would you mind opening an issue on VuePress repo instead?
2020-07-19T18:38:44
2020-07-19T18:38:44
{}
MEMBER
vuejs
docs
660,702,808
265
sdras
Sorry, we don't cover absolutely all use cases in the Guide, it breaks up the flow of reading. Tips are meant to be used sparingly as well, you can see the Writing Guide for more detail as to why.
2020-07-19T20:21:28
2020-07-19T20:21:28
{}
MEMBER
vuejs
docs
659,645,078
198
bencodezen
Thanks for the quick review @phanan! 🙌
2020-07-16T20:11:09
2020-07-16T20:11:09
{}
MEMBER
vuejs
docs
660,182,683
202
bencodezen
@yyx990803 Ah rats. Missed that exception clause in your sentence. Thanks for pushing that!
2020-07-17T15:50:03
2020-07-17T15:50:03
{}
MEMBER
vuejs
docs
660,520,207
233
NataliaTepluhina
@bencodezen up for both options 👍🏻
2020-07-18T18:11:25
2020-07-18T18:11:25
{ "hooray": 1 }
MEMBER
vuejs
docs
660,561,606
240
edimitchel
Yes, I can do it now ! I create this issue because the PR template invites to do it ;)
2020-07-19T00:15:18
2020-07-19T00:15:18
{}
CONTRIBUTOR
vuejs
docs
656,145,114
123
NataliaTepluhina
Unfortunately, this would require us to fix up all `TODO`s as Algolia considers our preview not being `production ready` and thus not giving is an API key
2020-07-09T14:00:20
2020-07-09T14:00:20
{ "+1": 1 }
MEMBER
vuejs
docs
659,622,023
197
phanan
That's super fast! Thanks Natalia!
2020-07-16T19:28:33
2020-07-16T19:28:33
{}
MEMBER
vuejs
docs
660,678,000
251
phanan
@CyberAP I think I know I can achieve the same thing with other approaches, thank you :) This is the approach I've chosen though, and I don't think it's worth it to do otherwise.
2020-07-19T17:13:00
2020-07-19T17:13:00
{ "confused": 1 }
MEMBER
vuejs
docs
660,701,740
266
phanan
[Rendered](https://deploy-preview-266--vue-docs-next-preview.netlify.app/guide/migration/global-api.html#a-new-global-api-createapp).
2020-07-19T20:13:45
2020-07-19T20:13:45
{}
MEMBER
vuejs
docs
660,862,348
122
NataliaTepluhina
@jacekkarczmarczyk we will change the link to new migration helper as soon as we have it 😄
2020-07-20T07:45:11
2020-07-20T07:45:11
{}
MEMBER
vuejs
docs
660,177,433
202
bencodezen
@yyx990803 I've updated all changes. Gonna go ahead and merge so this can be published, but let me know if you think of anything else and I'll submit another PR! Thanks for the review @sdras!
2020-07-17T15:40:47
2020-07-17T15:40:47
{}
MEMBER
vuejs
docs
660,517,381
224
NataliaTepluhina
@bencodezen yes, we should add it to the API reference too
2020-07-18T17:49:25
2020-07-18T17:49:25
{}
MEMBER
vuejs
docs
660,553,828
235
marina-mosti
Thanks for the review @bencodezen , I've applied the requested changes. It does look better with the file living in its own separate space, I was just afraid that it would introduce a foreign concept due to the way it was phrased earlier. But I also agree that probably it would be a best practice to place plugins in a ...
2020-07-18T22:53:40
2020-07-18T22:53:40
{ "+1": 1 }
COLLABORATOR
vuejs
docs
660,588,798
242
sdras
Absolutely, done! Thank @NataliaTepluhina :)
2020-07-19T05:12:41
2020-07-19T05:12:41
{}
MEMBER
vuejs
docs
660,663,143
251
phanan
Yeah, I requested reviews from Ben & Sarah as well.
2020-07-19T15:26:40
2020-07-19T15:26:40
{}
MEMBER
vuejs
docs
660,702,931
264
sdras
Looks good, thank you!
2020-07-19T20:22:11
2020-07-19T20:22:11
{}
MEMBER
vuejs
docs
660,938,901
122
ota-meshi
Hi! Not included in the RFC, but need to write a migration guide for lifecycle hook changes? - Removed `beforeDestroy` and `destroyed` - Added `beforeUnmount` and `unmounted`
2020-07-20T10:15:43
2020-07-20T10:15:43
{}
MEMBER
vuejs
docs
655,937,312
125
phanan
I'm merging this PR to move to the next (Global API Treeshaking). For the remaining issues, we can revise in beta.
2020-07-09T06:51:47
2020-07-09T06:51:47
{}
MEMBER
vuejs
docs
658,577,027
184
NataliaTepluhina
@ota-meshi thank you for making these changes! 🙇 I've given you the `Write` access to the repo so now you can create a PR with the changes
2020-07-15T06:40:26
2020-07-15T06:40:26
{}
MEMBER
vuejs
docs
659,768,717
191
bencodezen
Pushing live from approval in #docs channel in Discord. Will issue another PR for another design iteration
2020-07-17T01:12:19
2020-07-17T01:12:19
{}
MEMBER
vuejs
docs
660,684,882
258
NataliaTepluhina
Hmmm, should we file an issue on VuePress repository? I don't think it's a docs-specific thing 🤔
2020-07-19T18:07:06
2020-07-19T18:07:06
{}
MEMBER
vuejs
docs
660,693,045
255
marina-mosti
Thanks for the review @NataliaTepluhina I opted for adding a few more code examples to the `withDirectives` arg `directives` since it didn't seem to be too clear now that I took a second look at it. Indentation is looking homogenous: <img width="304" alt="image" src="https://user-images.githubusercontent.com/14...
2020-07-19T19:10:36
2020-07-19T19:10:36
{}
COLLABORATOR
vuejs
docs
658,386,620
105
bencodezen
It seems like we're okay on this, so closing this issue unless we run into problems with outdated content.
2020-07-14T20:06:33
2020-07-14T20:06:33
{}
MEMBER
vuejs
docs
658,416,321
173
phanan
I’m of the same mind. On Tue 14. Jul 2020 at 22:05 Ben Hong <notifications@github.com> wrote: > Originally there was a plan to categorize them by type of change, but this > would be very long and a little confusing since some sections contain > multiple types of changes. > > I'm thinking for the beta release, we just...
2020-07-14T21:12:36
2020-07-14T21:12:36
{ "+1": 1 }
MEMBER
vuejs
docs
658,527,604
171
NataliaTepluhina
@bencodezen I would add this to `Contributing to docs` section, PR template and also I would remove `Edit on GitHub` link for now from the Vuepress site
2020-07-15T03:42:22
2020-07-15T03:42:22
{ "+1": 1 }
MEMBER
vuejs
docs
658,528,772
172
NataliaTepluhina
@bencodezen I believe I'll add inline template migration today, so maybe let's change/close this issue? For changing, We could add placeholder pages to the documentation itself with RFC links?
2020-07-15T03:47:18
2020-07-15T03:47:18
{}
MEMBER
vuejs
docs
658,529,380
172
bencodezen
@NataliaTepluhina Agreed. Closing this out
2020-07-15T03:49:47
2020-07-15T03:49:47
{}
MEMBER
vuejs
docs
658,575,119
184
ota-meshi
I did this locally but after working I realized I don't have permission to this repository. I paste the changed markdown here. <details><summary>src/style-guide/README.md - # Component/instance options order</summary> ### Component/instance options order <sup data-p="c">recommended</sup> **Component/instanc...
2020-07-15T06:35:01
2020-07-15T06:35:01
{}
MEMBER
vuejs
docs
659,327,425
189
Justineo
> * slots unification happened on 2.6 so I haven't added it to `breaking` According to the [*Adoption strategy*](https://github.com/vuejs/rfcs/blob/slots-unification/active-rfcs/0006-slots-unification.md#adoption-strategy), `$scopedSlots` will be removed in 3.0 and users need to use `$slots` instead. > * attribut...
2020-07-16T10:37:36
2020-07-16T10:37:36
{ "+1": 1 }
MEMBER
vuejs
docs
660,558,597
240
bencodezen
Good catch! Do you mind submitting a PR @edimitchel? Would love to give you credit for finding the issue and solving it!
2020-07-18T23:43:34
2020-07-18T23:43:34
{}
MEMBER
vuejs
docs
658,232,072
150
NataliaTepluhina
This one will also include adding `v-is` to API reference and Guide
2020-07-14T15:02:04
2020-07-14T15:02:04
{}
MEMBER
vuejs
docs
658,386,053
173
bencodezen
Originally there was a plan to categorize them by type of change, but this would be very long and a little confusing since some sections contain multiple types of changes. I'm thinking for the beta release, we just order if alphabetically. What do people think? @sdras @phanan @NataliaTepluhina
2020-07-14T20:05:26
2020-07-14T20:05:26
{}
MEMBER
vuejs
docs
658,968,277
107
bencodezen
@znck Just wanted to check in and see if you needed me to do anything else for this PR. Let me know whenever you have a chance. No rush. Thanks!
2020-07-15T19:40:55
2020-07-15T19:40:55
{}
MEMBER
vuejs
docs
660,437,301
209
liulinboyi
![image](https://user-images.githubusercontent.com/41336612/87846571-684a3500-c903-11ea-86e9-39357239ad2f.png) ![image](https://user-images.githubusercontent.com/41336612/87846599-9465b600-c903-11ea-945a-526be9f0befc.png) Font-family name is error.
2020-07-18T06:34:23
2020-07-18T06:34:23
{}
MEMBER
vuejs
docs
660,446,845
217
NataliaTepluhina
@wanmaoor thank you for spotting this! Fixed in https://github.com/vuejs/docs-next/commit/43a819bf9943103cdd37460eaf0a44e46e47b3a0 🎉
2020-07-18T08:04:09
2020-07-18T08:05:33
{}
MEMBER
vuejs
docs
660,558,694
238
bencodezen
Thanks for opening an issue @acidiney. To give you some context, we are still considering whether to use a redirect rather than the `index.md` route of implementation. Appreciate you taking an initiative on this! 👍
2020-07-18T23:44:40
2020-07-18T23:44:40
{}
MEMBER
vuejs
docs
658,965,333
181
bencodezen
> @bencodezen just my chaotic thoughs > > * badges look cool! I'm not sure about the placement - should it be above title, inline or under > * `core`, `directives` etc is a bit confusing to me as tbh as it's hard to define the finite list of such categories > * AsyncComponents are breaking too! (current async impo...
2020-07-15T19:35:01
2020-07-15T19:35:01
{ "+1": 1 }
MEMBER
vuejs
docs
660,683,667
251
sdras
Thank you An! Looks great!
2020-07-19T17:57:25
2020-07-19T17:57:25
{}
MEMBER
vuejs
docs
660,862,651
208
NataliaTepluhina
Closing this issue as related PR was merged
2020-07-20T07:45:51
2020-07-20T07:45:51
{}
MEMBER
vuejs
docs
658,529,662
80
bencodezen
Thanks to @mlama007 for taking this issue and completing it with flying colors! Going to close this out now until we have other things to address!
2020-07-15T03:51:00
2020-07-15T03:51:00
{}
MEMBER
vuejs
docs
660,349,861
122
jacekkarczmarczyk
Not sure if this is the best place to comment but [FAQ](https://v3.vuejs.org/guide/migration/introduction.html#where-should-i-start-in-a-migration) links to [migration helper](https://github.com/vuejs/vue-migration-helper) which looks quite outdated
2020-07-17T21:43:32
2020-07-17T21:43:32
{}
CONTRIBUTOR
vuejs
docs
660,571,698
236
sdras
Yep exactly, otherwise it looks broken in the meantime. Thanks!
2020-07-19T01:51:24
2020-07-19T01:51:24
{}
MEMBER
vuejs
docs
660,572,556
230
robokozo
Would it be possible to add instructions to get it working with https://github.com/vuejs/vue-cli-plugin-vue-next ?
2020-07-19T02:01:47
2020-07-19T02:01:47
{}
NONE
vuejs
docs
660,583,846
245
NataliaTepluhina
@sdras it looks nice! The only thing is line numbers are very contrasting comparing to the code itself: ![Screenshot_7](https://user-images.githubusercontent.com/18719025/87866871-6cbc2f80-c98f-11ea-9ed4-edb16e97e8c5.png)
2020-07-19T04:14:17
2020-07-19T04:14:17
{}
MEMBER