owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | docs | 1,153,155,584 | 1,765 | NataliaTepluhina | @mordechairoth @skirtles-code I believe you both are right about replacing `a11y` with accessibility here! I've added this change to the PR | 2022-06-12T12:48:03 | 2022-06-12T12:48:03 | {} | MEMBER |
vuejs | docs | 1,154,687,562 | 1,774 | netlify[bot] | ### <span aria-hidden="true">✅</span> Deploy Preview for *vuejs* ready!
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 242fb62e78332d302f015053d1430b4efca4c252 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netli... | 2022-06-14T04:11:34 | 2022-06-14T04:13:13 | {} | NONE |
vuejs | docs | 1,157,419,774 | 1,714 | skirtles-code | The docs REPL got updated to the same version as the SFC Playground a few days ago, which may have fixed this. | 2022-06-16T09:07:56 | 2022-06-16T09:07:56 | {} | CONTRIBUTOR |
vuejs | docs | 1,159,354,109 | 1,783 | netlify[bot] | ### <span aria-hidden="true">✅</span> Deploy Preview for *vuejs* ready!
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 2a569b08cb4c5e24c8ca08bb445ac7fb18128975 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netli... | 2022-06-18T03:48:00 | 2022-06-19T00:30:34 | {} | NONE |
vuejs | docs | 1,161,624,192 | 1,788 | netlify[bot] | ### <span aria-hidden="true">✅</span> Deploy Preview for *vuejs* ready!
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 3a6e6003dabfb6837a39ac6320695689bb5e8be8 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netli... | 2022-06-21T11:33:01 | 2022-06-21T11:34:34 | {} | NONE |
vuejs | docs | 1,162,894,684 | 1,790 | netlify[bot] | ### <span aria-hidden="true">✅</span> Deploy Preview for *vuejs* ready!
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 60fe8f51c647b9addc653edd9a3ce5ce2eb3f6bb |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netli... | 2022-06-22T09:55:36 | 2022-06-22T09:57:16 | {} | NONE |
vuejs | docs | 1,166,738,652 | 1,804 | netlify[bot] | ### <span aria-hidden="true">✅</span> Deploy Preview for *vuejs* ready!
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | c96b4c06f9d25c04da647bbe661e59e76c431375 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netli... | 2022-06-27T01:55:57 | 2022-06-27T01:57:38 | {} | NONE |
vuejs | docs | 1,167,363,126 | 1,805 | skirtles-code | The relevant bit in the documentation is this:
<https://vuejs.org/guide/built-ins/transition.html#the-transition-component>
However, I'm unclear from your description whether this is the problem you'... | 2022-06-27T13:36:12 | 2022-06-27T13:36:12 | {} | CONTRIBUTOR |
vuejs | docs | 626,648,205 | 90 | phanan | Yeah I’m not sure about availability of current components, but Info
definitely is missing there. I would still follow the current vuejs.org
color palette and remove the icons though.
On Mon 11. May 2020 at 12:45 Ben Hong <notifications@github.com> wrote:
> Unless I'm mistaken, the existing docs we have the tip and d... | 2020-05-11T11:35:40 | 2020-05-11T11:35:40 | {} | MEMBER |
vuejs | docs | 632,805,432 | 89 | phanan | Sorry late to this. Should the Netlify link be marked with the "external" icon similar to others e.g.
? | 2020-05-22T17:00:09 | 2020-05-22T17:00:09 | {} | MEMBER |
vuejs | docs | 633,191,075 | 97 | NataliaTepluhina | @Jinjiang I still ended up dividing it onto 3 pages just for the sake of the effective sidebar usage: if we place them to the same page, some sections will go to `h4` and they won't be shown on the sidebar. To improve UX with better navigation, I've done this splitting and added lots of cross-links between sections. Co... | 2020-05-24T07:19:05 | 2020-05-24T07:19:19 | {} | MEMBER |
vuejs | docs | 635,380,463 | 109 | NataliaTepluhina | @phanan I disagree with `as well as very similar topics like Security and TypeScript` - they are not similar. `Security` section focuses on security related to Vue very tightly - we don't explain what is XSS there, we just say 'what Vue does for you'. Same to TS: we don't explain what interface is, we focus on how TS i... | 2020-05-28T14:21:30 | 2020-05-28T14:21:30 | {} | MEMBER |
vuejs | docs | 652,599,779 | 124 | LinusBorg | Sure! Will put it at the top of my list. | 2020-07-01T19:16:39 | 2020-07-01T19:17:07 | {} | MEMBER |
vuejs | docs | 653,245,296 | 125 | phanan | Preview is now available at https://deploy-preview-125--vue-next.netlify.app/guide/migration/global-api.html. | 2020-07-02T22:27:50 | 2020-07-02T22:27:50 | {} | MEMBER |
vuejs | docs | 653,919,790 | 125 | NataliaTepluhina | @phanan I really like the flow too! My question rather is: will we have a short changelog/reference for those who don't need the explanation? So they could simply check syntax without diving into details?
However, this is not a blocking concern so feel free to ignore it 😅 | 2020-07-05T18:03:31 | 2020-07-05T18:03:31 | {} | MEMBER |
vuejs | docs | 654,295,191 | 125 | bencodezen | > Hmm, I see your point. However, this also means we'd need to agree on this new format (of having a short leading summary) and apply it to all other migration pages.
Agreed. Maybe what we need is like a:
## Quick Overview
Here's the basic run down of the changes...
## Introduction
And now we explain ev... | 2020-07-06T15:06:49 | 2020-07-06T15:06:49 | {} | MEMBER |
vuejs | docs | 633,109,286 | 97 | NataliaTepluhina | @Jinjiang What if we place them on the same page (`Reactivity API`) but group them with subsections you mentioned? | 2020-05-23T18:13:29 | 2020-05-23T18:13:29 | {} | MEMBER |
vuejs | docs | 633,146,547 | 97 | Jinjiang | I personally think that’s great 🙂 @NataliaTepluhina | 2020-05-23T22:05:31 | 2020-05-23T22:05:31 | {} | MEMBER |
vuejs | docs | 647,041,734 | 65 | bencodezen | PR is here: https://github.com/vuejs/docs-next/pull/98 | 2020-06-20T20:23:43 | 2020-06-20T20:23:43 | {} | MEMBER |
vuejs | docs | 654,984,034 | 41 | NataliaTepluhina | @bencodezen I believe we could change our docs styles to Prettier ones (i.e. change `data ()` to `data()` as I believe the latter is more common. I might be wrong with this assumption though :) | 2020-07-07T16:38:37 | 2020-07-07T16:38:37 | {} | MEMBER |
vuejs | docs | 655,232,228 | 109 | mlama007 | > I think it's worth mentioning that in Vue 2, something like `v-bind:aria-checked="false"` will produce nothing instead of `aria-checked="false"`, which actually changes the semantics of the attribute. We should suggest developers always stringify boolean values when using `aria-*` attributes, like `v-bind:aria-checke... | 2020-07-08T01:50:48 | 2020-07-08T01:50:48 | {} | COLLABORATOR |
vuejs | docs | 626,507,205 | 90 | phanan | I'm not sure I follow. We already have these components right? | 2020-05-11T06:50:37 | 2020-05-11T06:50:37 | {} | MEMBER |
vuejs | docs | 626,841,551 | 93 | Jinjiang | @phanan +1 | 2020-05-11T17:27:11 | 2020-05-11T17:27:11 | {} | MEMBER |
vuejs | docs | 640,616,044 | 21 | bencodezen | @Jinjiang Oops. So sorry for missing the notification on this one.
You both are right in what we are trying to do in terms of this issue being only scoped to v2 to v3. Thanks for asking for clarification! | 2020-06-08T13:51:02 | 2020-06-08T13:51:02 | {
"heart": 1
} | MEMBER |
vuejs | docs | 645,232,296 | 119 | NataliaTepluhina | @kiaking thanks! Lifecycle hooks added
Utilities and Advanced APIs mentioned in the [API Reference](https://vue-docs-next-preview.netlify.app/api/basic-reactivity.html#reactive) . Do you think it's worth adding a section covering `Advanced use-cases` to guide too? | 2020-06-17T08:26:42 | 2020-06-17T08:26:42 | {
"+1": 1
} | MEMBER |
vuejs | docs | 653,751,088 | 125 | phanan | You mean this one?
| 2020-07-04T10:53:43 | 2020-07-04T10:53:43 | {} | MEMBER |
vuejs | docs | 633,072,246 | 97 | NataliaTepluhina | @pikax sorry, I failed to add you to reviewers list on the 1st review 🤦♀️
Would be happy if you could take a look! | 2020-05-23T15:06:49 | 2020-05-23T15:06:49 | {} | MEMBER |
vuejs | docs | 645,216,993 | 119 | kiaking | #### Lifecycle Hooks
I think it's worth mentioning about lifecycle hook usage, and describe how magically it works inside `setup` hook. The name are bit different than option API too.
---
#### Reactivity Utilities
I think it would be nice to have section for [Reactivity Utilities](https://composition-api.vuej... | 2020-06-17T07:56:46 | 2020-06-17T07:56:46 | {} | MEMBER |
vuejs | docs | 651,866,129 | 122 | haoqunjiang | https://github.com/vuejs/vue-codemod#migrating-from-vue-2-to-vue-3 can be used as a starting point. | 2020-06-30T15:25:44 | 2020-06-30T15:25:44 | {
"+1": 1
} | MEMBER |
vuejs | docs | 633,072,567 | 17 | NataliaTepluhina | Closing this as we've migrated Plugins | 2020-05-23T15:08:13 | 2020-05-23T15:08:13 | {} | MEMBER |
vuejs | docs | 635,188,876 | 109 | phanan | On this front btw, I really like how React [tackles the topic](https://reactjs.org/docs/accessibility.html): keeping everything on one page with focus on React-related techniques but still providing other general information (though mostly as external resources). Maybe we should get some inspiration from that? | 2020-05-28T08:11:38 | 2020-05-28T08:11:38 | {} | MEMBER |
vuejs | docs | 652,549,604 | 124 | NataliaTepluhina | @LinusBorg may I ask for your review in particular as an author of `portal-vue` and `teleport`? | 2020-07-01T17:24:46 | 2020-07-01T17:24:46 | {} | MEMBER |
vuejs | docs | 654,312,265 | 131 | NataliaTepluhina | @bencodezen yup! Notion guide was super helpful!
Will rename a section 👌 | 2020-07-06T15:37:30 | 2020-07-06T15:37:30 | {} | MEMBER |
vuejs | docs | 633,346,698 | 97 | Jinjiang | @NataliaTepluhina that looks much better to me :-) Just one more little struggled idea: how about change the title "Proxy-related APIs" to "Basic" directly? Because:
1. People may not know the Proxy things behind these APIs before them deeply look into it.
2. This part is more like inherited + extended from the "tr... | 2020-05-25T02:33:39 | 2020-05-25T02:33:39 | {} | MEMBER |
vuejs | docs | 653,750,910 | 132 | phanan | Previews:
- [Lifecycle diagram](https://deploy-preview-132--vue-docs-next-preview.netlify.app/guide/instance.html#lifecycle-diagram)
- [Slot](https://deploy-preview-132--vue-docs-next-preview.netlify.app/guide/component-slots.html#render-scope)
- [Scoped Slot](https://deploy-preview-132--vue-docs-next-preview.netl... | 2020-07-04T10:51:27 | 2020-07-04T10:51:27 | {} | MEMBER |
vuejs | docs | 632,320,316 | 89 | sdras | Thanks Ben! | 2020-05-21T20:16:33 | 2020-05-21T20:16:33 | {} | MEMBER |
vuejs | docs | 639,071,543 | 112 | JessicaSachs | @bencodezen I remember we were considering having the 3rd party tool authors provide the blurbs for accuracy. Was that done? | 2020-06-04T19:33:35 | 2020-06-04T19:33:35 | {} | CONTRIBUTOR |
vuejs | docs | 639,102,133 | 112 | bencodezen | > @bencodezen I remember we were considering having the 3rd party tool authors provide the blurbs for accuracy. Was that done?
@JessicaSachs Not yet. The descriptions from the 3rd party tools currently come from their website / own marketing with some editing (i.e., Jest's description is "Jest is a delightful JavaSc... | 2020-06-04T20:35:22 | 2020-06-04T20:35:22 | {} | MEMBER |
vuejs | docs | 640,699,811 | 105 | phanan | Not that I'm aware of TBH — @NataliaTepluhina might know better. Even if it's the case, we should "upgrade" those content instead. | 2020-06-08T15:25:02 | 2020-06-08T15:25:02 | {} | MEMBER |
vuejs | docs | 653,425,072 | 124 | NataliaTepluhina | @LinusBorg thank you for such a detailed and well-thought review! 🙇
I've applied all the requested fixes and suggestions, could you please take a second look to ensure I don't miss anything? | 2020-07-03T08:33:18 | 2020-07-03T08:33:18 | {} | MEMBER |
vuejs | docs | 654,985,191 | 85 | NataliaTepluhina | Closing as related MR was merged | 2020-07-07T16:40:36 | 2020-07-07T16:40:36 | {} | MEMBER |
vuejs | docs | 627,470,736 | 90 | bencodezen | @phanan Icons have been removed except for the danger to maintain consistency. The styles will update accordingly once I've migrated the existing site's CSS over to an atomic VuePress theme. | 2020-05-12T17:02:33 | 2020-05-12T17:02:33 | {} | MEMBER |
vuejs | docs | 635,388,187 | 109 | phanan | @bencodezen I believe that if we really dig deep, whatever you said about a11y applies to the other topics I mentioned (Security and TS) as well. That said, your proposal for the time being:
1. Provide a page dedicated to Accessibility under "Scaling Up" that provides a short introduction to the topic.
2. Point the... | 2020-05-28T14:35:03 | 2020-05-28T14:35:17 | {
"+1": 2
} | MEMBER |
vuejs | docs | 645,209,970 | 119 | NataliaTepluhina | cc @bencodezen @shentao | 2020-06-17T07:42:31 | 2020-06-17T07:42:31 | {} | MEMBER |
vuejs | docs | 654,296,009 | 125 | bencodezen | Great job on this @phanan! Do you plan on adding the Global Treeshaking section to this PR too? Or will that be a separate one? | 2020-07-06T15:08:21 | 2020-07-06T15:08:21 | {} | MEMBER |
vuejs | docs | 626,765,729 | 92 | NataliaTepluhina | Pinging @shentao here as he has a good experience with plugins 😅 | 2020-05-11T15:12:02 | 2020-05-11T15:12:02 | {} | MEMBER |
vuejs | docs | 634,182,513 | 97 | NataliaTepluhina | @pikax thank you for the detailed review! I've addressed your comments, would you mind taking a look again? 😅 | 2020-05-26T17:59:51 | 2020-05-26T17:59:51 | {
"+1": 1
} | MEMBER |
vuejs | docs | 634,602,265 | 108 | phanan | > These claims need to be thoroughly researched to ensure statements can be properly supported and essentially look at with an objective perspective
>
> The wording and verbiage chosen to represent these thoughts must be given lots of care and attention given in order to avoid misunderstandings and conflict.
I'm n... | 2020-05-27T11:36:11 | 2020-05-27T11:37:57 | {} | MEMBER |
vuejs | docs | 635,119,667 | 109 | NataliaTepluhina | @bencodezen this would be great! | 2020-05-28T05:51:02 | 2020-05-28T05:51:02 | {} | MEMBER |
vuejs | docs | 643,608,839 | 20 | NataliaTepluhina | Closing this issue as we've migrated Reactivity in Depth | 2020-06-13T11:13:53 | 2020-06-13T11:13:53 | {} | MEMBER |
vuejs | docs | 645,293,635 | 119 | shentao | The outline looks good to me! Will try to contribute to at least a few points.
I think that some of the Reactivity Utilities could be incorporated into the in-depth Composition API guide, but the Advanced Reactivity APIs are likely too niche to add them smoothly. Instead, I think we should just have a note in the gu... | 2020-06-17T10:32:40 | 2020-06-17T10:32:40 | {
"+1": 1
} | MEMBER |
vuejs | docs | 654,300,910 | 127 | bencodezen | Vue 3 Migration table can be found here: https://www.notion.so/vueteam/b66ec08c08be4dbdac600d0b355a7a17?v=37373ca1680640aaa529eacb6d1330f5 | 2020-07-06T15:17:07 | 2020-07-06T15:17:07 | {} | MEMBER |
vuejs | docs | 654,906,993 | 120 | bencodezen | <img width="635" alt="Screen Shot 2020-07-07 at 10 33 41 AM" src="https://user-images.githubusercontent.com/4836334/86797239-6fd52880-c03d-11ea-9b96-b8223bd4146b.png">
@phanan Updated to have consistent colors! | 2020-07-07T14:34:41 | 2020-07-07T14:34:41 | {} | MEMBER |
vuejs | docs | 632,803,490 | 105 | phanan | My impression was we'd have a dedicated site (e.g. v2.vuejs.org) for Vue 2 content. Is it not true? | 2020-05-22T16:57:07 | 2020-05-22T16:57:07 | {} | MEMBER |
vuejs | docs | 634,591,206 | 108 | bencodezen | Hey @phanan. Thanks for your work on this. At this time, I'm thinking we should take these changes and move them into Notion right now for discussion after the v3 docs are on solid footing. There are a couple reasons for this:
1. These claims need to be thoroughly researched to ensure statements can be properly supp... | 2020-05-27T11:11:07 | 2020-05-27T11:11:07 | {} | MEMBER |
vuejs | docs | 635,180,709 | 109 | phanan | > What do you think if we created an in-depth guide similar to ssr.vuejs.org at a11y.vuejs.org instead? This way we can provide both beginner and advanced guidance to creating accessible applications with Vue.
Personally I'm not sure about this. One of the problems we have to deal with at the moment is how fragmente... | 2020-05-28T07:57:12 | 2020-05-28T07:59:24 | {} | MEMBER |
vuejs | docs | 636,579,837 | 109 | Jinjiang | > However, I have a major concern: this guide here is very general and not Vue-specific.
I have the similar concern here. I'm not sure we have some good enough code samples about like gathering Vue input/output components together as a form for the "Semantics" page. But honestly, in my opinion, the true reason is we... | 2020-06-01T02:28:41 | 2020-06-01T02:29:29 | {
"+1": 2
} | MEMBER |
vuejs | docs | 643,334,987 | 113 | NataliaTepluhina | Closing as related PR was merged 🎉 | 2020-06-12T15:27:48 | 2020-06-12T15:27:48 | {} | MEMBER |
vuejs | docs | 653,757,439 | 125 | NataliaTepluhina | @phanan yup! WDYT about moving it to the very top, like a table of reference?
No strong opinions here, I'm rather thinking out loud | 2020-07-04T12:02:52 | 2020-07-04T12:02:52 | {} | MEMBER |
vuejs | docs | 654,749,779 | 134 | NataliaTepluhina | Closing this issue as related PR was merged | 2020-07-07T10:11:58 | 2020-07-07T10:11:58 | {} | MEMBER |
vuejs | docs | 633,098,075 | 97 | Jinjiang | @NataliaTepluhina for Reactivity APIs I have some further ideas. When I'm trying to find the usage of these APIs for a special purpose like read-only data, I need to know `readonly`, `isReadonly`, and `shallowReadonly`, `markRaw` at the same time. But they are in 3 different sub pages. It feels like a little bit inconv... | 2020-05-23T17:13:28 | 2020-05-23T17:13:28 | {} | MEMBER |
vuejs | docs | 634,828,147 | 108 | phanan | > In addition, I changed the milestone to release and will go through issues now to update milestones to prevent confusion.
SGTM 👍 | 2020-05-27T17:42:46 | 2020-05-27T17:42:46 | {} | MEMBER |
vuejs | docs | 635,366,293 | 109 | phanan | @NataliaTepluhina
> I don't think covering all-and-everything in the core docs is a good idea.
And it's not what I suggested, either. It's an extreme case that I have no intention to suggest. I'm suggesting a balance (only "remarkably different system," to quote myself). Honestly, I do think some of the current... | 2020-05-28T13:56:51 | 2020-05-28T14:01:06 | {} | MEMBER |
vuejs | docs | 635,378,283 | 109 | phanan | > Correct me if I'm wrong, but you seem to be proposing that it should house all things Vue.js related and go beyond it (to even provide explicit guidance on application topics beyond Vue.js that are arguably simply good practices to have as a developer regardless of framework).
> I appreciate your suggestion at a n... | 2020-05-28T14:17:35 | 2020-05-28T14:17:57 | {} | MEMBER |
vuejs | docs | 635,383,974 | 109 | phanan | @NataliaTepluhina I agree, if we put Security and A11y under the light in your argument they're very different: Security is tightly related to Vue, and a11y is not. The question then would be: Why should a11y not be? Why is it so different from Security, i.e. why shouldn't Security be treated the same (focuses on thing... | 2020-05-28T14:27:40 | 2020-05-28T14:27:40 | {} | MEMBER |
vuejs | docs | 635,386,433 | 109 | bencodezen | > Why should a11y not be?
It's not that it "shouldn't be." It's more on the objective analysis that the best practices for a11y are not specific to Vue core. It's not like we have specific directives that help you be more accessible. These best practices would largely apply to React and Angular as well. That's why p... | 2020-05-28T14:32:04 | 2020-05-28T14:32:04 | {} | MEMBER |
vuejs | docs | 643,334,719 | 114 | NataliaTepluhina | @pikax yay! Happy to merge 🎉 | 2020-06-12T15:27:20 | 2020-06-12T15:27:20 | {
"hooray": 1
} | MEMBER |
vuejs | docs | 645,978,522 | 96 | NataliaTepluhina | Also, this PR lacks `<teleport>` API (to be added in the next iteration) | 2020-06-18T12:13:01 | 2020-06-18T12:13:01 | {} | MEMBER |
vuejs | docs | 653,758,617 | 125 | phanan | I'm not sure TBH. Right now it kind of has a "flow" with it: We start with a current limitation, then move on to introduce the "fix" (`createApp`), and only then do we extend it with additional related changes (the table). IMHO this reads more like a guide and less like a "changelog." WDYT? | 2020-07-04T12:16:05 | 2020-07-04T12:16:05 | {} | MEMBER |
vuejs | docs | 654,985,248 | 86 | NataliaTepluhina | Closing as related MR was merged | 2020-07-07T16:40:42 | 2020-07-07T16:40:42 | {} | MEMBER |
vuejs | docs | 627,488,370 | 91 | NataliaTepluhina | **update**: this PR now contains also `Special attributes API` changes (already reviewed).
If you're reviewing this, please focus on `directives.md` | 2020-05-12T17:36:07 | 2020-05-12T17:36:07 | {} | MEMBER |
vuejs | docs | 629,680,094 | 90 | phanan | Sure, I'll try to attend the next meetings. Re: the icons, I do agree that icons can help with cognitive leaks. In this case, however, I'd argue that it's superfluous for the same reason above: labels and colors. Having three elements to convey one message to me is an overkill. | 2020-05-16T17:27:22 | 2020-05-16T17:27:22 | {} | MEMBER |
vuejs | docs | 629,681,986 | 90 | sdras | Just so I understand, are you proposing to kill the warning one and keep the others? That's the only one I see that's repetition. The other labels we decided to add. | 2020-05-16T17:42:53 | 2020-05-16T17:42:53 | {} | MEMBER |
vuejs | docs | 639,692,605 | 112 | JessicaSachs | I had the same thought and was going to write something like "The unit test
runner and the component test runner can be the same tool' and then I felt
like it was too in the weeds.
On Fri, Jun 5, 2020 at 4:08 AM Adrià Fontcuberta <notifications@github.com>
wrote:
> Thanks for this! It looks great :) I've added severa... | 2020-06-05T18:31:40 | 2020-06-05T18:31:40 | {} | CONTRIBUTOR |
vuejs | docs | 640,617,739 | 107 | bencodezen | @znck Thanks for this PR! As far as your question, I'm thinking it will useful to scope out these labels in case we have other flags we want to check for in the future in docs. So I'm proposing we prefix these flags with `review-`:
So for this one:
`review-alert-box`
And then if we want to check for code sampl... | 2020-06-08T13:53:56 | 2020-06-08T13:53:56 | {
"+1": 1
} | MEMBER |
vuejs | docs | 643,333,274 | 114 | pikax | Much better 🙏 | 2020-06-12T15:24:29 | 2020-06-12T15:24:29 | {} | MEMBER |
vuejs | docs | 647,041,639 | 85 | bencodezen | PR is here: https://github.com/vuejs/docs-next/pull/100 | 2020-06-20T20:22:45 | 2020-06-20T20:22:45 | {} | MEMBER |
vuejs | docs | 654,587,866 | 135 | NataliaTepluhina | Merging this one as we already have 2 approvals 👍 | 2020-07-07T04:13:39 | 2020-07-07T04:13:39 | {} | MEMBER |
vuejs | docs | 633,071,400 | 97 | NataliaTepluhina | @znck @phanan @Jinjiang thank you all for all the awesome fixes and suggestions! I've changed the PR accordingly, please take a second look whenever you have a chance 🙏 | 2020-05-23T15:02:22 | 2020-05-23T15:02:22 | {
"eyes": 1
} | MEMBER |
vuejs | docs | 634,822,464 | 21 | NataliaTepluhina | @Jinjiang I've updated the description 😉 | 2020-05-27T17:32:46 | 2020-05-27T17:32:46 | {} | MEMBER |
vuejs | docs | 634,956,787 | 109 | bencodezen | > Thanks, @mlama007, this is a great write-up!
>
> However, I have a major concern: this guide here is very general and not Vue-specific. The main part touching Vue is about `vue-router` and Vue Router doesn't belong to the core docs area as well. I am not sure how to deal with this, the best idea I have is to place... | 2020-05-27T21:40:35 | 2020-05-27T21:40:35 | {
"+1": 1
} | MEMBER |
vuejs | docs | 639,326,777 | 112 | afontcu | Thanks for this! It looks great :) I've added several suggestions here and there, but I love the general tone.
---
The only thing I feel this docs are missing is mentioning that Vue Testing Library and Vue Test Utils run on top of a test runner such as Jest. I'm not entirely sure this is understandable right now,... | 2020-06-05T08:07:55 | 2020-06-05T08:07:55 | {} | MEMBER |
vuejs | docs | 653,629,293 | 129 | phanan | I can handle this. | 2020-07-03T17:23:06 | 2020-07-03T17:23:06 | {} | MEMBER |
vuejs | docs | 653,722,402 | 63 | Jinjiang | @NataliaTepluhina Sorry for being late. But I feel we should introduce more details about `VNode`. I found myself stuck on this when I'm writing something special. | 2020-07-04T05:07:00 | 2020-07-04T05:07:00 | {} | MEMBER |
vuejs | docs | 654,309,063 | 125 | phanan | @bencodezen I plan to add Treeshaking in another PR after this, if everyone's OK with it 😬 | 2020-07-06T15:31:27 | 2020-07-06T15:31:27 | {
"+1": 1
} | MEMBER |
vuejs | docs | 654,981,781 | 21 | NataliaTepluhina | Closing this in favor of https://github.com/vuejs/docs-next/issues/122 | 2020-07-07T16:34:14 | 2020-07-07T16:34:14 | {} | MEMBER |
vuejs | docs | 633,072,890 | 23 | NataliaTepluhina | All existing APIs are migrated. I am closing this in favor of new issue for adding Global APIs (like `h`, `defineComponent` etc) to the API reference section | 2020-05-23T15:10:03 | 2020-05-23T15:10:03 | {} | MEMBER |
vuejs | docs | 635,290,819 | 109 | phanan | The whole argument of having a dedicated site being a better dev resource is based on the assumption that we'll have lots to put there along with the resource to maintain it. However, at least for the time being, there's no premise to this assumption. It might very well be just another fragment with little content, add... | 2020-05-28T11:49:08 | 2020-05-28T11:50:10 | {} | MEMBER |
vuejs | docs | 635,385,231 | 109 | bencodezen | > Do I think a11y (as well as very similar topics like Security and TypeScript) should have its own dedicated site? — No, I don't think so, for the reasons in my above comments, again.
I agree that we should limit the number of subdomains we are creating; but a11y is a section that really does deserve its own subdom... | 2020-05-28T14:29:53 | 2020-05-28T14:29:53 | {} | MEMBER |
vuejs | docs | 640,729,582 | 105 | phanan | All content migrated by me (which is much less than @NataliaTepluhina's 😬) should be in Vue 3. [SSR](https://vue-next.netlify.app/guide/ssr.html) needs to be catered later on in deed, but only for the external content at https://ssr.vuejs.org, not the vuejs.org part. @NataliaTepluhina how about yours? | 2020-06-08T16:17:35 | 2020-06-08T16:17:35 | {} | MEMBER |
vuejs | docs | 653,921,490 | 125 | phanan | Hmm, I see your point. However, this also means we'd need to agree on this new format (of having a short leading summary) and apply it to all other migration pages. | 2020-07-05T18:19:06 | 2020-07-05T18:19:06 | {} | MEMBER |
vuejs | docs | 626,625,802 | 90 | bencodezen | Unless I'm mistaken, the existing docs we have the tip and danger container equivalents, but don't have the other ones.
As far as the types go, the naming / color association with the custom containers tend to imply certain things:
- Tip (Green): This is something good to do and basically recommended
- Info (Bl... | 2020-05-11T10:45:21 | 2020-05-11T10:47:56 | {} | MEMBER |
vuejs | docs | 635,355,473 | 109 | bencodezen | > The whole argument of having a dedicated site being a better dev resource is based on the assumption that we'll have lots to put there along with the resource to maintain it. However, at least for the time being, there's no premise to this assumption.
I disagree. Unlike other efforts, I am confident in @mlama007's... | 2020-05-28T13:37:53 | 2020-05-28T13:37:53 | {} | MEMBER |
vuejs | docs | 635,519,541 | 97 | NataliaTepluhina | Thanks everyone for the review! I am merging this beast so if we have any fixes, let's handle them in the follow-up PRs | 2020-05-28T18:27:54 | 2020-05-28T18:27:54 | {} | MEMBER |
vuejs | docs | 645,234,895 | 119 | kiaking | Roger about APIs mentioned in API Reference.
> Do you think it's worth adding a section covering Advanced use-cases to guide too?
I think it would be nice to have. But not sure if we should add those at this stage. It might also suit more at examples or cookbook. So, my opinion is not to add advanced use-cases at... | 2020-06-17T08:32:03 | 2020-06-17T08:32:03 | {
"+1": 1
} | MEMBER |
vuejs | docs | 645,363,232 | 119 | bencodezen | Thanks so much for outlining this @NataliaTepluhina. I'll take the lead on this one and let everyone know when we have a draft to review.
For anyone else who sees anything we can add to the guide, please comment on the issue and I'll be sure to track it! | 2020-06-17T13:09:41 | 2020-06-17T13:09:41 | {
"heart": 3
} | MEMBER |
vuejs | docs | 655,914,029 | 109 | Justineo | @mlama007 Oh, you are right, I totally forgot this is for Vue 3! :laughing: | 2020-07-09T05:43:51 | 2020-07-09T05:43:51 | {
"+1": 1
} | MEMBER |
vuejs | docs | 626,788,853 | 93 | phanan | Is it just me or there's somehow no build for this PR?
Edit: I think I know why. This PR is for a dev branch, not the mainline `master`. | 2020-05-11T15:51:37 | 2020-05-11T18:36:22 | {} | MEMBER |
vuejs | docs | 629,675,936 | 90 | sdras | I'm sorry I'm late to the party here, I disagree with removing the icons. We talked through in a few meetings and with Evan that we needed more than one style for information, danger and the like.
- Icons can help with cognitive leaks because the user can immediately identify what kind of information they're seeing,... | 2020-05-16T16:58:39 | 2020-05-16T16:58:39 | {} | MEMBER |
vuejs | docs | 633,389,725 | 97 | NataliaTepluhina | @Jinjiang done! 😅 | 2020-05-25T05:51:09 | 2020-05-25T05:51:09 | {} | MEMBER |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.