prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: The implementation must be trusted
### Description
The implementation variable is used to delegatecall the calls received by the proxy to the implementation. This pattern is a pretty common pattern used in upgradeable contracts, where a proxy contract (usually called a storage) uses an implementation (usually ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `public` functions not called by the contract should be declared `external` instead
### Description
Contracts [are allowed](https://docs.soliditylang.org/en/latest/contracts.html#function-overriding) to override their parents' functions and change the visibility from `external` to `public`.
*There are 13 inst... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Price calculations may experience precision loss due to division before multiplication
### Description
There are several places across the codebase in which intermediate results that depend on a division are then used as part of calculations that involve a multiple.
For example, in `requestWithdraw()` the cal... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | EIP-712 | true | false | ## Severity: Medium Risk
## Context
SeaDrop.sol#L308
## Description
The `mintParams` in the calculation of the digest in `mintSigned` is of struct type, so we would need to calculate and use its `hashStruct`, not the actual variable on its own.
## Recommendation
According to EIP-712, the correct digest would be:
``... | Spearbit | 5 | SeaDrop |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Function selectors between VaultCore and VaultAdmin could collide
### Description
Instead of inheriting from the `VaultAdmin` to access to its functionality, the [`VaultCore` contract](https://github.com/OriginProtocol/origin-dollar/blob/bf4ff28d5944ecc277e66294fd2c702fee5cd58b/contracts/contracts/vault/VaultC... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Memory Allocated by `_allocateTempKeyBuffer` Is Fragile and Could Be Overwritten
### Description
**Update**
Alchemy has acknowledged this issue and added to the document of risks.
**File(s) affected:**`libraries/AssociatedLinkedListSetLib.sol`
**Description:** The `AssociatedLinkedListSetLib` hashes a compos... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Use `assembly` to write _address storage values_
### Description
2 results - 4 files:
https://github.com/code-423n4/2023-03-canto-identity/blob/main/canto-namespace-protocol/src/Namespace.sol#L80
https://github.com/code-423n4/2023-03-canto-identity/blob/main/canto-namespace-protocol/src/Tray.sol#L107
### R... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Wrong/misleading comments
### Description
**Description:** In multiple locations, comments are wrong or misleading. These wrong/misleading comments can lead to unexpected interpretation of the contract and potential security issues. We recommend fix these wrong or misleading comments.
**Securitize:** Fixed i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: Missing check for supported asset
### Description
**Severity**
**Impact:** Low
**Likelihood:** High
**Description**
The `depositAndBridge` function currently lacks the necessary validation to verify that the deposit asset is supported by the Vault. This omission could allow an attacker to use a custom t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: `CHANGE_REWARD_LIMIT` Is Not Enforced For The First Rate Change
### Description
**Update**
The client fixed the issue in commit `d59a595fe94f9e7d537b2a7df854eab0b90c860d` and provided the following explanation:
> The initial value of the _artistReward.start parameter has been changed to the block.timestamp.
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: spotPriceOHM is vulnerable to manipulation
### Description
The `OHM_AMO` contract uses the Uniswap V2 spot price to calculate the value of the collateral that it holds. This price can be manipulated by making a large trade through the OHM-FRAX pool. An attacker can manipulate the apparent value of collateral ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Ambiguous Access Control Boundaries
### Description
## Role Boundary of traderAdmin
The role boundary of `traderAdmin` is blurred by the presence of `processTradeDispute`. The `overrideOraclePrice` is only callable by `cegaAdmin`, but this restriction may be bypassed via taking a path in `processTradeDispute`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: DAO Pausable Logic
### Description
**Update**
The client acknowledged the issue and provided the following explanation:
> DAO will be used for advisory purposes only; logic to pause the contract will be added in the future if needed.
**File(s) affected:**`Web3MusicNativeTokenDAO.sol`
**Description:** At the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: pledgeRate setup not checked
### Description
`pledgeRate` setup accepts any number without checks in `updateConfig()`.
Consider adding sanity checks for setup. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Code structure is messed up.
### Description
**Description**
StakingB_1.sol Line 524
Storage and events must be separated in order to make code structure more readable.
**Recommendation**:
Move the “amountOfUser” variable to the other variables. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: CEI not followed in `VotingEscrowMainchain`
### Description
**Severity**: Low
**Status**: Acknowledged
**Description**:
In `VotingEscrowMainchain.sol`, the Checks-Effects-Interactions pattern has not been followed in `increaseLockPosition()` function. It is always a best practice to follow checks effects i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Missing deadline for signatures
### Description
**Severity**: Informational
**Status**: Acknowledged
**Location**: Airdrop.sol
**Description**
The signature is missing a deadline parameter. If there is no deadline provided for a signature, it can lead to the signature being valid for an indefinite amount o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | cross-chain | true | false | ## High: The communication channel for `HoneyJarONFT` can be blocked
### Description
**Severity**
**Impact:** High
**Likelihood:** High
**Description**
`HoneyJarONFT` inherits from LayerZero's `NonblockingLzApp` to manage the cross-chain NFT transfers.
Let's break down how the flow of receiving a cross-chain mess... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | false | false | ## Low: Anyone can self burn lp token of the AMM
### Description
When providing liquidity into the AMM pool, users receive LP tokens. Users can redeem their shares of the liquidity by redeeming LP tokens to the AMM pool.
The current LPToken contract inherits OpenZeppelin’s `ERC20BurnableUpgradeable`. Users can burn t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Usage of direct approve calls leads to several issues
### Description
The `distributeRewards` function in the **EvenSplitGroupPool** contract calls the approve method on tokens intended for reward distribution:
```
function distributeRewards(
address groupId,
address token,
address[] calldata ipIds
) e... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | front-running | true | false | ## High: Profit distribution from reserve sales during swapRaforDs is susceptible to MEV attacks
### Description
The `swapRaforDs` function of `FlashSwapRouter.sol` allows users to swap their RA (Redemption Asset) for Debt Swap (DS) tokens. During this swap, if there are enough resources in the module core, they are ut... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: vars.THUSDFee does not have any effect and could be removed
### Description
## Code Review Feedback
**Context:** BorrowerOperations.sol#L185
**Description:** `vars.THUSDFee` does not have any impact and could be removed from BorrowerOperations.sol.
**Recommendation:** Consider removing `vars.THUSDFee` fro... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Incorrectly Hardcoded `_INIT_CODE_HASH` Parameter Will Lead to Wrong/Inability to Perform Appraisals
### Description
The `Uniswap.sol` incorrectly stores the `_INIT_CODE_HASH` as `0xe34f199b19b2b4f47f68442619d555527d244f78a3297ea89325f843f87b8b54`. This is incorrect as the protocol integrates with KodiakV3 ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Unverified timeDelta Leading to Transaction Panic
### Description
The `timeDelta` parameter is not properly verified to ensure it is different from zero before proceeding with the division. This oversight can lead to scenarios where the transaction unexpectedly panics. It is recommended that a validation check... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: `tokenBalanceOfAddress` of `nftOwner` becomes permanently incorrect after `arbRestake`
### Description
_Submitted by hyh, also found by GreyArt and hack3r-0m_
Successful `arbRestake` performs `_redeemShares` for `arbRewardShares` amount to extract the arbitrager reward. This effectively reduces shares acco... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Potential L1->L2 `ERC20` decimal inconsistency can result in loss of user bridged tokens
### Description
**Description:** The first time a new ERC20 token is bridged, `TokenBridge::bridgeToken` uses the `IERC20MetadataUpgradeable` interface to fetch the token's name, symbol and decimals in order to create a br... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Input validation lacking in `_remove`
### Description
**Severity**: Informational
**Status**: Unresolved
**Location**: _remove
**Description**
Input addresses from and to are not asserted to be different addresses.
The expected side effect after executing this function is to have zero balance for the from... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: VaultFactoryV2#changeTreasury misconfigures the vault
### Description
VaultFactoryV2#changeTreasury misconfigures the vault because the setTreasury subcall uses the wrong variable
### Impact
Valid depegs may be missed due to misconfiguration
### Recommendation
Set to _treasury rather than treasury. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Remove `amountToClaim > 0` check in `DropBox::claimDropBoxes` as previously reverted if `amountToClaim == 0`
### Description
**Description:** Remove `amountToClaim > 0` check in `DropBox::claimDropBoxes` as previously reverted if `amountToClaim == 0`:
**Mode:**
Fixed in commit [e6231a7](https://github.com/Ea... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: A cache that times out can be recovered
### Description
Recover a cached value that has timed out, and a malicious user or contract can exploit this bug to fool other users or cause other unknown problems.
### Proof of Concept
The `LocalCache#set_expire` function does not check whether the key has expired... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Database has no access controls
### Description
The keystore SQLite database is stored unencrypted. No permission-based access controls are present. An attacker with even temporary filesystem access can add, modify, or delete entries at will.
### Recommendation
Explicitly ensure that file permissions on the d... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | true | ## High: Return value missing in wrapUnderlying() WstETHAdapter
### Description
## High Risk Severity Report
## Context
1. `WstETHAdapter.sol#L136-142`
2. `CAdapter.sol#L130-154`
3. `Periphery.sol#L253-272`
## Situation
The function `wrapUnderlying()` of `WstETHAdapter` does not return any value, which means it retu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: Accounts contains expensive looping
### Description
`Accounts.getBorrowETH` performs multiple external calls to `GlobalConfig` and `TokenRegistry` within a for loop:
**code/contracts/Accounts.sol:L381-L397**
```
function getBorrowETH(
address \_accountAddr
) public view returns (uint256 borrowETH) {
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | false | false | ## High: Reply Can Get Stuck In Consensus
### Description
The functions `HandleReply` in both the `signEarlyUnbondController` and `signTimelockWithdrawController` handle incoming reply messages related to the early unbonding and timelock withdrawal processes, respectively. In these functions, there are several scenari... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: evm_hooks ignores some important errors
### Description
### Impact
Some contracts and some Turnstile tokens (NFTs) will not be able to receive CSR fees forever.
### Proof of Concept
In evm_hooks.go, the [PostTxProcessing](https://github.com/code-423n4/2022-11-canto/blob/2733fdd1bee73a6871c6243f92a007a0b8... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: No withdrawal possible for ETH TOKE pool
### Description
_Submitted by Lambda_
The `withdraw` function of the ETH Tokemak pool has an additional parameter `asEth`. This can be seen in the Tokemak [Github repository](https://github.com/Tokemak/tokemak-smart-contracts-public/blob/2f54689d5d16ddfd1751493b161a04... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | other | true | false | Source: https://github.com/sherlock-audit/2023-02-carapace-judging/issues/230
## Found by
Jeiwan, rvierdiiev
## Summary
Lending pool state transition will be broken when pool is expired in late state
## Vulnerability Detail
Each lending pool has its state. State is calculated inside `ReferenceLendingPools._getLendi... | Sherlock | 5 | Carapace |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Removal of try/catch could allow the recipient to make cancelable streams uncancelable
### Description
The removal of the `try/catch` has given the recipient the ability to put their NFT in the allowlisted DeFi project and create a situation (e.g., lend against it beyond the current streamed amount or similar)... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: Manipulation for High Rewards
### Description
**Update**
The recent design change on the commit `bda7234` seems less related to the main issue, as the original concern focuses more on the gas price and the fix here is for the gas amount. However, it's important to note that these changes serve a valid purpose ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: Exiting a farm on mainnet assumes a peg of `1:1` when swapping stETH for ETH
### Description
When stETH depegs from ETH, the swaps on Curve will revert due to requesting a higher `amountOut` than what the curves pool will give.
### Proof of Concept
When exiting a farm on mainnet, the requested `tokensOut... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: The `addBlacklistAddress` and `addWhitelistAddress` functions do not check whether the user has opposite role
### Description
The [`addBlacklistAddress`](https://github.com/code-423n4/2024-11-ethena-labs/blob/main/contracts/ustb/UStb.sol#L73) function does not check whether the user has `WHITELISTED_ROLE`
Th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: Improper Indexing in claimReward in Allocator . . . . . . . .
### Description
## Allocator Contract Vulnerability
The Allocator contract uses `listOfEpochs` to store the epochs in which the user has allocated the `AbcTokens` (as we can’t get a list of keys from a mapping in Solidity).
## Code Snippet
Wh... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Missing post-migration check in PoolManager.sol could result in lost funds
### Description
The protocol employs an upgradeable/migrateable system that includes upgradeable initializers for factory created contracts. For the most part, a storage value that was left uninitialized due to an erroneous initializer ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Anyone can make new bids always revert after a window expires
### Description
**Impact:**
High, as all new bidding will revert until auction ends
**Likelihood:**
High, as anyone can execute the attack without rare preconditions
**Description**
The `fulfillWindow` method is a `public` method that is also ca... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Rebasing tokens can lead to bad accountability of the positions
### Description
Rebasing tokens change the `balanceOf` value of the accounts that hold their tokens.
Using rebasing tokens as collateral for positions can lead to positions minting more tokens than expected, or challenges created, averted or won ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: avgBorrowRate can blow-up for small linearVariation
### Description
For small values of `linearVariation`, the average borrow rate calculated has a significant error which causes the result to deviate from the expected value. These errors stem from amplified division errors when divided by `linearVariation`.
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Token transfer to address(0) should be avoided
### Description
The internal function `_beforeTokenTransfer` ignores the use of address(0).
As how it is now the two if statements won't be triggered on address(0) and the function will finish successfully.
Consider applying a check, which will revert if the "fr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Use of outdated dependencies
### Description
We used `pip audit` to detect the use of outdated dependencies in the Python codebases, which identified a number of vulnerable packages referenced by the `pyproject.toml` and `poetry.lock` files. The following is a list of the vulnerable dependencies used in the co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | true | ## Medium: Mini pool reserves for unique tokens can be reinitialised
### Description
Mini pool reserves can be reinitialized. This is due to the following factors:
1. For unique tokens, one can add them to `ATokenERC6909` multiple times but with different incremental IDs.
2. In `MiniPoolReserveLogic`, we have:
```s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Principal payout wallet can be set to zero address causing permanent fund loss in `DIAStakingCommons`
### Description
The `updatePrincipalPayoutWallet()` function in `DIAStakingCommons` lacks validation to prevent setting the principal payout wallet to the zero address (0x0). When a `principalUnstaker` sets th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [08] Rename `dendroidBool` to `isDendroid`
### Description
Variable containing its type is redundant in statically typed languages. `is` prefix is common convention for boolean values.
Alternatively, replace the value with `uint8 fighterType`. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Entities Write Policies at a Collateralized Ratio
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation: This is by design, we want this to be doable.
**Description:** Capital Providers in the system should be aware that the amount of insurance polici... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `constant`s should be defined rather than using magic numbers
### Description
Even [assembly](https://github.com/code-423n4/2022-05-opensea-seaport/blob/9d7ce4d08bf3c3010304a0476a785c70c0e90ae7/contracts/lib/TokenTransferrer.sol#L35-L39) can benefit from using readable constants instead of hex/numeric literals... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Attackers can prevent new challenges/listings/backends, parameter changes, and stake retrievals
### Description
Candidate creation allows attackers to block essential operations performed by other users.
The computable contracts allow candidates to propose new challenges, listings, or Backend and paramete... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `removeCalldataCheckDatahash` could mistakenly remove a wildcard check if the wildcard check is added with an empty `dataHash`
### Description
**Impact**
`_addCalldataCheck` doesn't enforce that a wildcard check has no `dataHashes`
https://github.com/solidity-labs-io/kleidi/blob/1a06ac16bc99d0b4081281329d030... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Yul call return value not checked
### Description
## Lines of code
https://github.com/code-423n4/2022-11-non-fungible/blob/323b7cbf607425dd81da96c0777c8b12e800305d/contracts/Exchange.sol#L212-L227
## Vulnerability details
### Author: rotcivegaf
### Impact
The Yul `call` return value on function `_retu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Duplicate interactions
### Description
The `validateInteractions()` function in the [`Signing.sol` contract](https://github.com/Liquorice-HQ/contracts/blob/a5b4c6a56df589b8ea4f6c7b8cb028b1723ad479/src/contracts/settlement/Signing.sol#L109) is designed to verify the validity of `_interactions` before execution... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Public functions not called by the contract should be declared external instead
### Description
Contracts are allowed to override their parents’ functions and change the visibility from external to public and can save gas by doing so.
`withdraw`
- [Pool.sol#L44](https://github.com/code-423n4/2022-11-non-fung... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `getWorkerFraction` is not needed
### Description
Public attributes already have getters
https://github.com/nucypher/nucypher/blob/main/nucypher/blockchain/eth/sol/source/contracts/staking_contracts/PoolingStakingContractV2.sol#L91
### Recommendation
Remove the method `getWorkerFraction`. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: User Can Deny Opponent NFT Rewards By Marking Safe Post-Battle
### Description
The `markBeetleSafe()` function allows a user to designate one of their staked NFTs as the safe beetle at any time. The function only verifies that the caller is the staker of the token, but does not validate the timing or context ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: BondCallback, Operator: upon module's upgrade, the token approval should be revoked
### Description
*
*
The `BondCallback` and `Operator` approves ohm to the `MINTR` module in the `configureDependencies`. However, there is no logic to revoke those approvals (e.i. approve to zero). In the case of the `MINT... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Closing netted, non-matured shorts can lead to insolvency
### Description
Closing netted shorts can increase the long exposure in case the now non-netted longs are not also closed. This occurs when calling `closeShort` before maturity. As the long exposure increases, a solvency check is required so that all o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Code Refactoring
### Description
## Vault Rebalancing Guidelines
## 1. Immutable References
`vault::check_rebalance` and `vault::check_rebalance_loop` should avoid utilizing mutable references (`&mut`) for its input parameters to ensure there will be no changes to these objects in these functions.
## 2. Thre... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Duplicated Checks on createProposal() and endProposal()
### Description
The `createProposal()` function conducts sanity checks on input parameters, i.e., making sure `totalActions > 0` and the inputs have the same length. However, the same action is also done on `super.createProposal()` which is called at the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missing events in `endMultipleRounds`
### Description
_Resolved_
The endRound function emits RoundEnded and FeeTransferred events, which are crucial for off-chain services track contract activity. The batch function endMultipleRounds performs the same logic but does not emit these events. This creates an inco... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: LlamaPolicy.revokePolicy cannot be called repeatedly and may result in burned tokens retaining active roles
### Description
Llama has two distinct `revokePolicy` functions.
The first `revokePolicy` function removes all roles of a policyholder and burns the associated token. This function iterates over all... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Dust | false | false | Source: https://github.com/sherlock-audit/2022-11-dodo-judging/issues/45
## Found by
TrungOre
## Summary
The calculation of the proportion when do the split swap in function `_multiSwap` doesn't care about the rounding error
## Vulnerability Detail
The amount of `midToken` will be transfered to the each adapter c... | Sherlock | 4 | DODO |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: Missing reentrancy guard in EmergencyWithdraw / WithdrawEscrow
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
By adding the nonreentrant modifier, you can help ensure that the function is not vulnerable to reentrancy attacks, especially when interacting with external contracts. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `StakingContract` refunds are affected by global parameter updates
### Description
**Description:** When [`StakingContract::refundStakedAmount`](https://code.zeeve.net/zeeve-endeavors/benqi_smartcontract/-/blob/b63336201f50f9a67451bf5c7b32ddcc4a847ce2/contracts/staking.sol#L691-741) is called by the BENQI admi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Incorrect performance fee calculation in `FeeManager`
### Description
The performance fee calculation in `FeeManager.calculateFee` uses an incorrect formula that doesn't properly convert price differences to share amounts. The current implementation leads to incorrect fee calculations.
### Impact
Incorrect p... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: LP tokens can be minted disproportionately
### Description
In the `initialize` instruction of the `gorples-ido` program, there is no enforcement of a reasonable value for the `lp_amount` parameter. This non-validated `lp_amount` is then utilized in the `withdraw` instruction to execute a CPI (Cross-Program Inv... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | high | other | true | true | ## High: Attacker can use delegation to bypass voting restriction to vote on proposals they are restricted from voting on
### Description
Attacker can use delegation to bypass voting restriction to vote on proposals they are restricted from voting on.
### Impact
Attacker can vote on proposals they are restricted from... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: YAxisVotePower.balanceOf can be manipulated
### Description
## Handle
cmichel
## Vulnerability details
The `YAxisVotePower.balanceOf` contract uses the Uniswap pool reserves to compute a `_lpStakingYax` reward:
The pool can be temporarily manipulated to increase the `_yaxReserves` amount.
## Impact
I... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: optimization.
### Description
**Severity**: Low
**Status**: Resolved
**Description**
ERC20Distribution.sol - In the claimFiatToken, The result of the transfering _fiat_token is boolean. So there is no need to compare with true, It will cause more gas consumption.
.
**Recommendation**: | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: permitBatchAndCall will revert when non-payable functions are called with value
### Description
The `permitBatchAndCall` function of the `RouterCommon` contract will revert if a value is attached to the call, for example, in cases where payable and non-payable functions are batched together.
The `permitBatch... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Infinite Permit2 approval is not recommended
### Description
**Description:** When creating a rebalance order in `RebalanceLogic::_createRebalanceOrder`, the `BunniHook` approves tokens to be spent by the Permit2 contract. Specifically, if the order input amount exceeds the existing allowance, the Permit2 cont... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Risk of Unfair Order Execution Price in `_validateOrdersAndDetermineFillPrice` Function
### Description
While the system seems to have appropriate checks in place for order matching, a potential risk exists around the order execution pricing logic, specifically when the orders are placed in the same block. ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: permits are vulnerable to griefing via frontrunning
### Description
The usages of the `permit` ERC20 extension in the code can be frontrun by any party that witnesses transactions prior to block inclusion. This is a griefing vector that will cause user transactions to fail if the associated `permit` has alread... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | true | ## High: ATokenERC6909.totalSupply for debt tokens uses the liquidity index
### Description
The `totalSupply` function is defined as:
```solidity
function totalSupply(uint256 id) public view override returns (uint256) {
uint256 currentSupplyScaled = super.totalSupply(id);
if (currentSupplyScaled == 0) {
return ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | logic-error | true | false | ## Low: am-AMM fee validation can be simplified
### Description
When charging the swap fee, `BunniHookLogic::beforeSwap` checks whether the am-AMM fee should be used by validating whether it is enabled and whether there is an active top bid:
```solidity
// update am-AMM state
uint24 amAmmSwapFee;
@> ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Account tag collision
### Description
## AccountTag Enum in Aob and Dex
Aob uses the `AccountTag` enum to distinguish between account types.
However, Dex also employs this strategy.
Since the crates use overlapping integer values during serialization, this results in possible type confusion between:
-... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | false | false | ## Medium: Growing of totalSupply after successive lock/unlockCapital can freeze protection pools by uint overflow
### Description
In a protection pool, after enough cycles of locking capital/depositing, totalSupply can grow to overflow uint256.
### Impact
Protocol can come to a halt if totalSupply reaches `type(uint... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: SpendingLimitPolicy doesn't clear previous data
### Description
When a policy is disabled in the SmartSession system, there is no logic that is executed to clean up the policy's storage. To avoid issues if a policy is re-enabled with the same `configId`, policies are supposed to clear any existing storage dur... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: ANDROID - TRANSACTION DATA EXPOSED IN LOGS
### Description
The application logs sensitive information, including wallet metadata and push notification tokens, in plaintext within the device logs. Logging such information introduces a potential security risk, particularly in shared or compromised environments. ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: Oracle's two-day feature can be gamed
### Description
[Oracle.sol#L124](https://github.com/code-423n4/2022-10-inverse/blob/main/src/Oracle.sol#L124)
The two-day feature of the oracle can be gamed where you only have to manipulate the oracle for \~2 blocks.
### Proof of Concept
The oracle computes the day... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: uniswapV3TwapSecondsAgo may result in AMM manipulation in pound()
### Description
The lower the value of `uniswapV3TwapSecondsAgo` is set at construction time, the easier it becomes for an attacker to manipulate the results of the `pound()` function.
It becomes easier for attackers to manipulate automated ma... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | overflow | true | false | ## Gas: Miscellaneous
### Description
### Don't call a function when initializing an immutable variable
Saves a little bit of deployment gas
### Use a mapping type of a struct directly instead of assigning it to another storage variable
- [Drips.sol#L246-L254](https://github.com/code-423n4/2023-01-drips/blob/main/src... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: If a borrower or lender got blacklisted by asset contract, their collateral or loan funds can be permanently frozen with the pool
### Description
It's impossible for borrower or lender to transfer their otherwise withdraw-able funds to another address. If for some reason borrower or kicker got blacklisted b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Missing Input Validation
### Description
**Update**
Addressed in: `8a255bf16ae3930d0542e75c9d0267d8e88ffd3d`. The client added the recommended additional checks
**File(s) affected:**`Marketplace.sol`, `Utils.sol`, `Listings.sol`
**Description:** It is important to validate inputs, even if they only come from... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Minor Optimizations
### Description
## Recommendations
1. Because proof is specified as calldata, consider using `MerkleProof::verifyCalldata` instead of `verify`.
2. In `transferOwnership`, consider using a two-step process to transfer ownership to avoid transferring ownership to an inaccessible address.
##... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | access-control | true | false | ## Gas: Functions guaranteed to revert_ when callled by normal users can be marked `payable`
### Description
If a function modifier or require such as onlyOwner-admin is used, the function will revert if a normal user tries to pay the function. Marking the function as payable will lower the gas cost for legitimate cal... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Admin | true | true | ## Handle
cmichel
## Vulnerability details
The `Vault.withdrawRedundant` has wrong logic that allows the admins to steal the underlying vault token.
```solidity
function withdrawRedundant(address _token, address _to)
external
override
onlyOwner
{
if (
_token == address(token) &&
... | Code4rena | 3 | InsureDAO |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | true | ## Medium: `ClaimFees` steals staking rewards
### Description
The `_claimFees` function is designed to collect accrued trading fees from the underlying concentrated liquidity pool and transfer them to a designated `internal_bribe` contract. The function determines the amount of fees to transfer by checking the gauge's... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: [Oval] Attempts to Push Price to the CoinbaseOracle Will Always Fail
### Description
The [`CoinbaseOracle` contract](https://github.com/UMAprotocol/oval-contracts/blob/297ab25a914171aedaeb01dabf4a829a304cce08/src/oracles/CoinbaseOracle.sol#L10-L116) serves as an oracle for price data reported and signed by ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: [03] Unsupported exact-out BASE swaps are not rejected early, causing wasted gas (`ValidationLogic`, `LatentSwapLogic`, `Covenant`)
### Description
`Covenant.swap()` validates inputs via `ValidationLogic.checkSwapParams()` but does not proactively forbid unsupported swap modes where `assetOut == BASE` with `is... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: A risk of admin rights revocation due to an incorrect `LRTConfig` address update
### Description
The issue is identified in the[`LRTConfigRoleChecker.updateLRTConfig`](https://github.com/Kelp-DAO/KelpDAO-contracts/blob/8c62af6057402f4616cc2a1d3218a277a864ee2c/contracts/utils/LRTConfigRoleChecker.sol#L61) func... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Emit event when creating a new bribe.
### Description
**Description**
BribeFactory.sol: function createBribe().
In order to keep track of all created bribes, emit an event, so that an address can always be
recovered.
**Recommendation**:
Emit event with an address of newly created bribe.
**Post-audit**.
Cl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: Lack of Upgradeability Storage Gaps
### Description
Throughout the codebase, these base contracts are inherited into upgradeable contracts:
* [`ScrollMessengerBase`](https://github.com/scroll-tech/scroll/blob/3bc8a3f5c6ac816ddffadca41024331dcf4d3064/contracts/src/libraries/ScrollMessengerBase.sol)
* [`Scr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | false | ## Low: `InitBip9` incorrectly references BIP-8 in the contract NatSpec | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | true | true | ## Low: `GovValidators` can transfer non-transferable `GovValidatorToken` to non-validators making them validators
### Description
`GovValidators` can transfer non-transferable `GovValidatorToken` to non-validators making them validators.
### Impact
Non-transferable tokens can be transferred making non-validators int... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.