prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: [G‑17] Usage of `uints`/`ints` smaller than 32 bytes (256 bits) incurs overhead
### Description
> When using elements that are smaller than 32 bytes, your contract’s gas usage may be higher. This is because the EVM operates on 32 bytes at a time. Therefore, if the element is smaller than that, the EVM must us... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Lack of Price Freshness Verification in Oracle Price Data
### Description
**Severity**
**Impact:** Medium
**Likelihood:** Medium
**Description**
The `getOraclePrice` and `getCollateralExchangeInfo` functions retrieve `NodeOutput.Data` containing price information and a timestamp indicating the freshness... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Checks-Effects-Interactions Pattern Violation
### Description
**Update**
The issue has been fixed by modifying the code to follow the checks-effects-interactions pattern.
**File(s) affected:**`rewards/AbstractReward.sol`
**Description:** The [Checks-Effects-Interactions](https://solidity.readthedocs.io/en/la... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | onlyInitializing modifier | true | false | ## Lines of code
https://github.com/code-423n4/2022-03-rolla/blob/efe4a3c1af8d77c5dfb5ba110c3507e67a061bdd/quant-protocol/contracts/utils/EIP712MetaTransaction.sol#L102-L114
## Vulnerability details
1. `EIP712MetaTransaction` is a utils contract that intended to be inherited by concrete (actual) contracts, therefor... | Code4rena | 5 | Rolla |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: tokens cannot be withdrawn from Treasury contract
### Description
The Treasury contract currently lacks functionality for withdrawing ERC-20 tokens; any such tokens sent to the treasury would be permanently locked in the contract. The Otim protocol allows users to pay fees with either native ETH or any ERC-20... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: `Pool.getMinTimeBetweenWithdrawalQueues` current calculations may not be sufficient
### Description
`getMinTimeBetweenWithdrawalQueues` is very important for `Pool`. If `getMinTimeBetweenWithdrawalQueues` is too small, `pendingQueues` will be overwritten too early, and when `Loan` pays off, it won't be able... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Malicious router can block cross-chain-transfers
### Description
_Submitted by 0xRajeev, also found by cmichel and shw_
The agreement between the `user` and the `router` seems to already happen off-chain because all the fields are required for the initial `In variantTransactionData` call already. A router ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: A borrower can list their collateral on Seaport and receive almost all the listing price without paying back their liens
### Description
When the collateral is listed on SeaPort by the borrower using `listForSaleOnSeaport`, `s.auctionData` is not populated. Thus, if that order gets fulfilled/matched and `Clea... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Storage cheaper than memory
### Description
Reference types cached in memory cost more gas than using storage, as new memory is allocated for these variables, copying data from storage to memory.
### Proof of Concept
Instances:
##### src/VaultRegistry.sol
* original gas costs with these `VaultInfo memory... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Under-funded eth distribution proposals can be created causing claiming rewards to revert
### Description
**Description:** It is possible to create under-funded eth distribution proposals as `DistributionProposal::execute()` [L62-63](https://github.com/dexe-network/DeXe-Protocol/tree/f2fe12eeac0c4c63ac3967091... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Centralized registry is not adopted in the whole code base
### Description
Having the `Registry` contract allows the protocol to have a unique source of information of the key components of the system.
Coupled together with the fact that the `Registry` contract is triggered by the governance, this should ens... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Lines are too long
### Description
Usually lines in source code are limited to [80](https://softwareengineering.stackexchange.com/questions/148677/why-is-80-characters-the-standard-limit-for-code-width) characters. Today's screens are much larger so it's reasonable to stretch this in some cases. Since the file... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Multiple Requests Can Produce Identical Outcomes Within a Short Window
### Description
The contract derives all wave results from the VRF-provided `randomNumber`:
```solidity
uint256 state = randomNumber; //@audit [L] - risk of repeatable outcome
```
The PoP VRF returns the same `randomNumber` for multiple ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Incorrect logic in the `onlyAdminOrOperator()` modifier
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
`onlyAdminOrOperator()` modifier in the `TokenPrice` contract is intended to be only passed when the caller has either `DEFAULT_ADMIN_ROLE` or `OPERATOR_ROLE`.
But the current... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Base rate may decay at a slower rate than expected
### Description
The base rate is used to calculate fees for redemptions and new issuances of debt, and its value decays over time and increases based on redemption volume.
On redemption, the decay on the base rate is calculated based on the number of minut... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Event Management Could Be Improved
### Description
**Update**
11 additional operations are logged (details in `constants/logs.fc`).
**Update**
Marked as "Fixed" by the client. Addressed in: `ee06ab7aa984bc704426ad011c46de73ea1375b5`.
**Description:** Only three operations are logged: supply, withdrawal, and... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missing NatSpec `@param` from error declaration
### Description
Some errors have an incomplete NatSpec: add a `@param` notation to describe the error parameters to improve the code documentation.
*There are 34 instances of this issue.*
--- | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Users with large `cooldown`s can grief other users
### Description
_Submitted by IllIllI, also found by 0xDjango and csanuragjain_
If an account has a large cooldown, that account can grief other accounts that are waiting for their own cooldowns, by sending small amounts to them.
### Proof of Concept
Eve... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: User withdrawals can fail if Morpho position is close to liquidation
### Description
When trying to withdraw funds from Morpho as a P2P supplier, the last step of the withdrawal algorithm borrows an amount from the pool ("hard withdraw"). If the Morpho position on Aave's debt/collateral value is higher than... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: ShareToken whitelist cannot be initialized
### Description
The `ShareToken` inherits from the `WhitelistToken` contract, but there is currently no function to set the `whitelist`. This renders whitelist protection useless, as there is no code to add users to the whitelist.
```solidity
contract WhitelistToken... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: There is no slippage check in the `nuke()` function
### Description
NFT owners may receive significantly less nuke funds than they expected.
### Proof of Concept
In the `nuke()` function, there is no minimum claim amount check. Consider the following scenario:
1. The `fund` value of the `NukeFund` contra... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: Omnichain Stakers can permanently lose access to their funds
### Description
Report type: Smart Contract
Target: https://github.com/zerolend/governance
Impacts:
- Permanent freezing of funds
## Description
## Brief/Intro
The OmnichainStaking faciliates staking of Locker NFTs. When Locker NFT arrive to Sta... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Missing EIP-165 Interface Compliance Checks
### Description
This issue has been identified in functions that accept addresses of external contracts—such as `setOracle(address newOracle)` and `supportMarket(IPToken pToken)` — without verifying EIP-165 interface support.
EIP-165 allows a contract to declare whi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Unclean code
### Description
In the [`lockTokens` function](https://github.com/graphprotocol/contracts/blob/01c891829d39e1d6adc30bf13a2c8bf64504f808/contracts/staking/libs/Stakes.sol#L76) of the `Stakes` contract the [`weightedAverage` function](https://github.com/graphprotocol/contracts/blob/01c891829d39e1d6a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Provided ticks will not work with all pool fees
### Description
Uniswap v3 pools have different tick spacing sets depending on the fee used. For a fee of `10000` which is the initial value used in `GroupcoinFactory`, we have a tick spacing of 200, which means that the provided ticks used must be a multiple of ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | token | true | false | ## Gas: [G‑09] Internal functions only called once can be inlined to save gas
### Description
https://github.com/ERC725Alliance/ERC725/blob/v5.1.0/implementations/contracts/ERC725XCore.sol#L131
https://github.com/code-423n4/2023-06-lukso/tree/main/contracts/LSP0ERC725Account/LSP0ERC725AccountCore.sol#L796
https://... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Confusing Function Name And Comments
### Description
**Severity**: Informational
**Status**: Resolved
**description**
The function `takeUSDBRaised()` in the contract `TokenSaleETH.sol` does not take the USDB
raised in the epoch rather it’s the ETH that was deposited in the round , it should be named
accordi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Simplify unpacking expression in `fixedReward`
### Description
https://github.com/code-423n4/2023-03-wenwin/blob/main/src/LotterySetup.sol#L126-L127
The following calculation:
Can be simplified using a single shift as: | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: Faulty Scale Update
### Description
## Issue with `set_scale` in Utils
The `set_scale` function in `utils` fails to modify the original decimal value; instead, it returns a new decimal with the updated scale. This behavior is problematic as the result of `set_scale` is not captured, which causes the conver... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: Use of `.send()` May Revert if The Recipient's Fallback Function Consumes More Than 2300 Gas
### Description
_Submitted by leastwood, also found by 0xliumin, berndartmueller, cccz, Czar102, gzeon, hickuphh3, horsefacts, ilan, IllIllI, joestakey, m9800, p4st13r4, peritoflores, reassor, rfa, robee, sorrynotso... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Multiple initialization in `NoteInterest`
### Description
_Submitted by 0x1f8b, also found by oyc_109_
The `initialize` method of the contract `NoteInterest` can be initialized multiple times.
### Proof of Concept
The method `initialize` of the contract `NoteInterest` looks like this:
Nothing prev... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | false | false | ## High: Rebasing rewards will get stuck on the contract
### Description
The main problem here is that `stored_balances` does not account for rewards for rebaseable tokens (e.g. stETH):
https://github.com/curvefi/stableswap-ng/blob/8c78731ed43c22e6bcdcb5d39b0a7d02f8cb0386/contracts/main/CurveStableSwapNG.vy#L380
https... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | initialization | true | false | ## Low: `ComplianceServiceRegulated` and its parent `ComplianceServiceWhitelisted` uses a chain of `initializer` modifiers when calling the `initialize`
### Description
`ComplianceServiceRegulated` is the child contract inheriting from `ComplianceServiceWhitelisted`.
The `ComplianceServiceRegulated::initialize()` uses... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | false | false | ## High: SwapUtils.sol Wrong implementation
### Description
## Handle
WatchPug
## Vulnerability details
Based on the context, the `tokenPrecisionMultipliers` used in price calculation should be calculated in realtime based on `initialTargetPrice`, `futureTargetPrice`, `futureTargetPriceTime` and current time, just... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: Division by Zero Not Prevented
### Description
In `CoreVault`, the `_exchangeDualCore()` function performs a division without validating that denominators is non-zero. This unchecked divisions could lead to unexpected reverts and denial of service in edge cases.
```
function _exchangeDualCore(uint256 core) pr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: chainalysisOracleEnabled() function logic inverted
### Description
The view function chainalysissOracleEnabled() returns true when the oracle is unset (i.e., disabled), and false when the oracle is actually configured. This behavior contradicts the function name, which suggests it should return true when the o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | true | false | ## Medium: Replenishing gas is missing in `_payFallbackGas` of `RootBridgeAgent`
### Description
The call `_payFallbackGas` is used to update the user deposit with the amount of gas needed to pay for the `fallback` function execution. However, it doesn't replenish gas. In other words, it doesn't deposit the `execution... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Controller.sol::lockwithdraw() - it's impossible to withdraw of fsof = 0
### Description
When withdrawing, we use `withdraw`:
```solidity
function _withdraw(
address account_,
address poolOwner_,
address dest_,
uint amount_,
bool isForced_
) internal {
bytes32 lockId = LLocker.getLockId(account... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: State variables should be cached in stack variables rather than re-reading them from storage
### Description
The instances below point to the second+ access of a state variable within a function. Caching of a state variable replaces each Gwarmaccess (**100 gas**) with a much cheaper stack read. Other less obvi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: diamondCut() allows re-execution of old updates
### Description
When `diamondCut()` is executed, `ds.acceptanceTimes[keccak256(abi.encode(_diamondCut, _init, _calldata))]` is not reset to zero. This means the contract owner can rerun the old updates again without any delay by executing the `diamondCut()` fu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Data Used for Events Should Be Clarified
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> Fixed in a branch for next phase. And the fix is not included in current release as it is just for off-chain usage.
**File(s) affected:**`user_fund_supp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: Use assembly to perform efficient back-to-back calls
### Description
If a similar external call is performed back-to-back, we can use assembly to reuse any function signatures and function parameters that stay the same. In addition, we can also reuse the same memory space for each function call (`scratch space... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | overflow | true | false | ## Gas: Redundant `require` in `BaseZkSyncUpgradeGenesis`
### Description
**File:** `BaseZkSyncUpgradeGenesis.sol`
[File: code/contracts/ethereum/contracts/upgrades/BaseZkSyncUpgradeGenesis.sol](https://github.com/code-423n4/2024-03-zksync/blob/main/code/contracts/ethereum/contracts/upgrades/BaseZkSyncUpgradeGenesis.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | cross-chain | false | false | ## High: Routers can sybil attack the sponsor vault to drain funds
### Description
When funds are bridged from source to destination chain, messages must first go through optimistic verification before being executed on the destination BridgeFacet.sol contract. Upon transfer processing, the contract checks if the doma... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: Malicious tokens can be deployed at deterministic addresses on other chains to steal funds
### Description
When sending an ERC20 across the SuperchainTokenBridge, we assume that the token has the same address on both chains. In `sendERC20()`, we encode the sent token address in the relay call:
```solidity
by... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Spelling mistakes
### Description
Some texts have spelling mistakes:
1) `balanceAdderess` -> `balanceAddress`
https://github.com/EnsoFinance/shortcuts-contracts/blob/4902e55608f975f73772310955444110b1cfc4fc/contracts/helpers/EnsoShortcutsHelpers.sol#L14
2) `renounes` -> `renouns`
https://github.com/EnsoFin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: centralization risk in `STBL_USST::bridgeBurn`
### Description
**Description:** Current implementation of `STBL_USST::bridgeBurn` allows `BRIDGE_ROLE` to burn tokens from any arbitrary address without user approval. This creates unnecessary centralization risk when a safer approach is already demonstrated i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | token | true | false | ## Medium: `SDLVesting::stakeReleasableTokens` gas optimization by caching variables
### Description
```solidity
function stakeReleasableTokens() external {
uint256 amount = releasable();
if (amount == 0) revert NoTokensReleasable();
released += amount;
sdlToken.transferAndCall(
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: Structs can be packed into fewer storage slots
### Description
Each slot saved can avoid an extra Gsset (**20000 gas**) for the first setting of the struct. Subsequent reads as well as writes have smaller gas savings
*There are 2 instances of this issue:*
`Delta.sol#L5-L20`
`Pool.sol#L363-L375` | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Project Upgrade and Stop Scenario should be
### Description
At the start of the project, the system may need to be stopped or upgraded, I suggest you have a script beforehand and add it to the documentation.
This can also be called an " EMERGENCY STOP (CIRCUIT BREAKER) PATTERN ".
https://github.com/maxwoe/sol... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: Rounding down of snapAccumulator might influence calculations
### Description
The function `transform()` lowers `snapAccumulator` with the following equation:
```
snapAccumulator * int256(dt) / int256(snapWindow)
```
During the time that `snapAccumulator * dt` is smaller than `snapWindow`, this will be r... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Centralization Risk for trusted organizers
### Description
According to the provided link on "[Centralization Risk for trusted owners](https://github.com/Cyfrin/2023-08-sparkn/issues/1)", I believe that the `Organizer` also carries a centralization risk. As described in the documentation, "[The sponsor `Sponso... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Add a timelock to `BaseStrategy:setPerfFeePct`
### Description
_Submitted by Dravee_
To give more trust to users: functions that set key/critical variables should be put behind a timelock.
#### Proof of Concept
#### Tools Used
VS Code
#### Recommended Mitigation Steps
Add a timelock to setter functio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | false | false | ## High: Insufficient Src Validation allows Malicious Users To Steal WSHIDO From Users With Zero Allowance
### Description
**Severity**: Critical
**Status**: Resolved
**Description**
The WSHIDO token is forked from the WETH contract on the Ethereum Mainnet and is intended to allow users to wrap SHIDO to be used in ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Incorrect EIP-2612 deadline check
### Description
> allow `transferFrom` to occur while `expiry >= block.timestamp`.
The current code should change to use `<=`
1. File: src/ERC20Permit.sol (line [43](https://github.com/code-423n4/2022-04-axelar/blob/dee2f2d352e8f20f20027977d511b19bfcca23a3/src/ERC20Permit.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | access-control | false | true | ## Medium: Access-controlled functions cannot be called when L2 sequencers are down
### Description
Given that rollups such as [Optimism](https://docs.optimism.io/chain/differences#address-aliasing) and [Arbitrum](https://docs.arbitrum.io/arbos/l1-to-l2-messaging#address-aliasing) offer methods for forced transaction ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: previewWithdraw calculates shares wrongly
### Description
_Submitted by kenzo, also found by PP1004, pedroais, and CertoraInc_
The fee is wrongly accounted for in `previewWithdraw`.
### Impact
Function returns wrong result;
Additionally, `withdraw(assets,to,from)` will always revert. (The user can still... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Business Logic | true | true | ## Severity
**Medium Risk**
## Context
- Swapper.sol#L22-L38
- Swapper.sol#L83-L96
- SwapperV2.sol#L22-L39
- SwapperV2.sol#L86-L93
- Executor.sol#L143-L149
- Executor.sol#L191-L199
- Executor.sol#L242-L249
- Executor.sol#L338-L345
- XChainExecFacet.sol#L30-L38
## Description
The LiFi code bases contain two similar so... | Spearbit | 5 | LI.FI |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Owner can renounce Ownership
### Description
Typically, the contract’s owner is the account that deploys the contract. As a result, the owner is able to perform certain privileged activities.
The non-fungible Ownable used in this project contract implements `renounceOwnership` . This can represent a certain r... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Naming
### Description
**Occurs**:
Basilisk-node/pallets/lbp/src/lib.rs:778
Misleading method names can lead to errors during further development.
**Recommendation**:
Use names that reflect method implementation. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Opcode is Incompatible with some Chains
### Description
**Severity**: Low
**Status**: Acknowledged
**Description**
The `CyberFinance` contract is written using Solidity version 0.8.21, which introduces the push0 opcode. This opcode is not supported by all chains, especially those not compatible with the Sha... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Reinvest will return sub-optimal return if the pool is imbalanced
### Description
Reinvesting only allows proportional deposit. If the pool is imbalanced due to unexpected circumstances, performing a proportional deposit is not optimal. This result in fewer pool tokens in return due to sub-optimal trade, even... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | true | false | ## Medium: Contracts Not Well Designed for Upgrades
### Description
1. **Inconsistent Storage Layout**
The Contracts introduce some buffer space in the storage layout to cope with the scenarios where new storage variables can be added if a need exists to upgrade the contracts to a newer version. This helps in reduci... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: User can pass auction recovery health check easily with flashloan
### Description
ParaSpace features an auction mechanism to liquidate user's NFT holdings and receive fair value. User has the option, before liquidation actually happens but after auction started, to top up their account to above recovery facto... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | false | false | ## Low: Pool data cannot be relied upon off-chain or by external integrators
### Description
Axelar does not enforce message ordering because it opens up the message bridge to DoS attacks. Since this order is not enforced, the execution of these messages cannot be expected to be processed in order.
There are several... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Lack of Input Validation for `setTokenPriceInUSD` Function
### Description
**Severity** : Informational
**Status** : Resolved
**Description** :
The `setTokenPriceInUSD` function in the `IDOPoolAbstract` contract lacks input validation, allowing for the setting of an IDO price to any value without restrictio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: [02] `renounceOwnership()` can't be done via controller
### Description
The functions `renounceOwnership()` or `LSP0ERC725AccountCore` can be called by a controller and the permissions of the controller are then checked via `_verifyCall`. This calls `_verifyPermissions()`, which allows for `transferOwnership()... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: Unspent allowance may break functionality in AMO
### Description
An unspent allowance may cause a denial of service during the calls to `safeApprove()` in the AMO contract.
The AMO contract uses the `safeApprove()` function to grant the Curve pool permission to spend funds while adding liquidity. When addi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: Reverse market is not supported due to improper escalations
### Description
The current development of Size protocol is designed to operate with USDC as the borrow token and WETH as collateral. The Size team also intends to deploy a reverse market version of the protocol with WETH as the borrow token and USDC... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Update to `managerFeeBPS` applied to pending tokens yet to be claimed
### Description
A manager (malicious or not) can update the `managerFeeBPS` by calling `ArrakisV2.setManagerFeeBPS()`. The newly-updated `managerFeeBPS` will be retroactively applied to the pending fees yet to be claimed by the `ArrakisV2... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: SignatureCheckerLib does not implement ERC-6492 verification
### Description
## ERC-6492 Verification Procedure
## Context
(No context files were provided by the reviewer)
ERC-6492 mandates the following verification procedure:
- Check if the signature ends with magic bytes. In this case, do an `eth_call` to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: The approval value obtained in the `_initialize()` function may not be enough for the long term of the smart contract
### Description
Smart contracts call `safeApprove()` function for different tokens. But in the process of work, the obtained value will only decrease. If this value decreases to zero, then ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: File Name Mismatch
### Description
Contracts [`LOB`](https://github.com/longgammalabs/hanji-contracts/blob/09b6188e028650b9c1758010846080c5f8c80f8e/src/OnchainLOB.sol) and [`Trie`](https://github.com/longgammalabs/hanji-contracts/blob/09b6188e028650b9c1758010846080c5f8c80f8e/src/TrieLib.sol) do not match the f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: inefficiencies
### Description
There are many instances throughout the codebase where changes can be made to improve gas consumption. For example:
* `public` functions might consume more gas than external functions. This is because with public functions, the EVM copies inputs (especially dynamic-sized arrays... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | false | false | ## Low: CloneFactory Front-Running
### Description
`ERC4337CloneFactory.deploy()` and `delegateDeploy()` can be front-run, causing the user’s contract to be deployed prematurely and their original deployment transaction to revert.
### Recommendation
We recommend either documenting this as expected behavior or checkin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Excess Gas Consumption Due to Redundant Token Transfers
### Description
In logic of function implemented on `SEND_THROUGH` modality on some user blueprints, redundant token transfers are made by first withdrawing tokens to the contract and then transferring them to the user. This leads to unnecessary gas costs... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Overwriting cash balance
### Description
The [`setCashBalance` function](https://github.com/mcdexio/mai-protocol-v2/blob/4b198083ec4ae2d6851e101fc44ea333eaa3cd92/contracts/perpetual/Perpetual.sol#L44) can be used to manually adjust a trader’s cash balance during the `SETTLING` phase. However, if a separate bal... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Protocol will miss part of it's fee
### Description
**Severity**
**Impact:** Medium, part of the protocol fee would missed
**Likelihood:** High, each user that will claim his earnings in ongoing vault more than ones would pay less fees
**Description**
Vault allows variable stakers to claim earnings during... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: WooFi oracle can fail to validate its price with Chainlink price feed
### Description
The price precision that the WooOracle uses is 8. However, if the quote token is an expensive token or the base token is a very cheap token, then the price will be too less in decimals and even "0" in some cases. This will... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Reverts occur when `staticcall` is used on non-view/non-pure functions
### Description
The `staticcall` may revert because `cachePeriodEarned()` is not marked as view or pure. The EVM enforces that only read-only functions can be called via `staticcall`.
As per [docs](https://github.com/ethereum/EIPs/blob/ma... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: Lack of incentives for users to call LendingPool::initiateLiquidation allows extensive delay between when health factor dropped below threshold and when grace period starts
### Description
In the liquidation system of the RAAC Lending Protocol, it allows users to delay liquidation due to lack of incentives for... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Typos in Function Name and Comment
### Description
Two typographical errors were found in a function name and a comment:
* On `ChestManager.sol`:
```
function entriesLenghtInChest(uint256 id) public view returns (uint256) {
```
`entriesLenghtInChest()` should be `entriesLengthInChest()`.
* On `YieldBoo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: IdleProvider overstates balanceUnderlying() and understates calcShares()
### Description
IdleProvider's exchangeRate() use Idle's tokenPrice() which doesn't include performance based fees, so balanceUnderlying() and calcShares() report figures that may not match with what Vault will effectively obtain on in... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: 2-STEP TRANSFER OWNERSHIP MISSING
### Description
The code does not implement a two-step ownership transfer pattern. This practice is recommended when admin users have heavy responsibilities, such as the ability to mint tokens, freeze or unfreeze user accounts and set system configurations. It may happen that ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: USE 1E18 CONSTANT FOR GAS OPTIMIZATION
### Description
In Solidiy, the exponentiation operation (`**`) costs up to 10 gas. It is possible to consume less gas to calculate the prices of the tokens if DECIMAL variable is fixed.
Code Location
-------------
### Recommendation
**SOLVED**: The issue was solved in ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Lack of Two-Step Ownership Transfer
### Description
**Severity**: Low
**Status**: Acknowledged
**Description**
The Geyser contract does not implement a two-step process for transferring ownership. In its current state, ownership can be transferred in a single step, which can be risky as it could lead to acc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [33] Wrong `debugLog` call
### Description
In [bootloader, line 1110](https://github.com/code-423n4/2023-10-zksync/blob/1fb4649b612fac7b4ee613df6f6b7d921ddd6b0d/code/system-contracts/bootloader/bootloader.yul#L1110), you "log" that the refund is `0` when it may be not be: | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Basket.sol#auctionBurn calculates ibRatio wrong
### Description
## Handle
0x0x0x
## Vulnerability details
The function is implemented as follows:
When `handleFees` is called, `totalSupply` and `ibRatio` changes accordingly, but for `newIbRatio` calculation tokens minted in `handleFees` is not included... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Misleading comments related with ERC20Wrapper and ERC20WrapperBundler inside the Wrap- per
### Description
Throughout the Wrapper contract, there are two instances where the comments are misleading:
1. The Wrapper contains two functions, `withdrawTo` and `depositFor`, which are compliant with the `ERC20Wrappe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | true | ## High: Invariant.getX computation is wrong
### Description
The protocol makes use of a solstat library to compute the off-chain swap amounts. The solstat’s `Invariant.getX` function documentation states:
> Computes xinx = 1 - Φ(Φ¹( (y + k) / K ) + στ).
However, the `y + k` term should be `y - k`. The off-chain swa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | false | false | ## Low: Withdrawals Temporarily Blocked By Incorrect Accounting
### Description
System withdrawals can become blocked by a stale record of insolvent auction balances. This happens because of `totalInsolventMM`, which records the initial minimum margin of each account with an insolvent liquidation, and is only decrease... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: The Solidity version is not up to date
### Description
The modern major version of the Solidity compiler is 0.8, but most of the codebase uses version 0.6.12.
### Recommendation
We recommend using the up to date Solidity version. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Party B liquidation can expire, causing the liquidation to be stuck
### Description
The liquidation of Party B can get stuck if the liquidation timeout is reached and the positions are not liquidated within the timeout period.
### Impact
Party A's [locked balance is not decremented by the liquidatable posi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Single-Step Ownership Transfer Process
### Description
The `Atlas` smart contract defines two roles, **admin** and **owner**, and in both cases, the transfer of ownership is performed in a single step, which introduces a security risk.
This issue is present in multiple instances throughout the contract, w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Use
### Description
[L-09] Use safeTransferOwnership instead of transferOwnership function
Context::br
LiquidStakingManager.sol#L6:br
Syndicate.sol#L8
contracts/smart-wallet/OwnableSmartWallet.sol:
93 /// @inheritdoc IOwnableSmartWallet
94: function transferOwnership(address newOwner)
95: public
96:... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | true | false | ## Medium: Integer Overflow in Default Guardian Confirmations Calculation
### Description
An integer overflow can occur when computing the default number of confirmations required for guardian votes. The code unconditionally casts the length of the guardian set (a `uint256`) to `uint8` before passing it into `LibSafeM... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | false | false | ## Low: [10] All the four functions `buy()`, `sell()`, `mintNFT()` and `burnNFT()` call `_splitFees()` to split the fees, but when `shareData[_id].tokensInCirculation ==0`, `shareHolderFee` will be added to `plantformFee`.
### Description
[Market.sol#L280-L296](https://github.com/code-423n4/2023-11-canto/blob/335930cd... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | true | false | ## High: Improper use of ecrecover weakens the bridge’s security
### Description
The bridge contract fails to check whether the address returned by the `ecrecover` function is the null address. An attacker could leverage this deficiency to reduce the number of valid signatures required to execute administrative operat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: MultiSig can transfer all tokens to it’s address with function kill() at CoiinVault.sol
### Description
**Description**
Function kill allows the multisig address to transfer all deposited tokens to its address.
**Recommendation**:
Remove token transfer from function or share additional information on why t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | other | true | true | ## Medium: Manual/Instant `fulfillRedeemRequest` doesn’t reserve liquidity
### Description
`AccountableAsyncRedeemVault` account for reserved liquidity only when processing the queue through (`AccountableWithdrawalQueue::processUpToShares` / `AccountableWithdrawalQueue::processUpToRequestId`).
However, the manual fulf... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.