prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: _removeStackPosition() always reverts
### Description
The function `removeStackPosition()` always reverts since it calls the stack array for an index beyond its length:
```solidity
for (i; i < length; ) {
unchecked {
newStack[i] = stack[i + 1];
++i;
}
}
```
Notice that for `i == length - 1`, `stack[length]`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Panic in runtime (affect further development)
### Description
**Occurs**:
Basilisk-node/pallets/asset-registry/src/lib.rs:107
Basilisk-node/pallets/exchange/src/lib.rs:606,615,637,647
Basilisk-node/pallets/exchange/src/direct.rs:101,102,234
Basilisk-node/runtime/src/lib.rs:1107,1114,1034
HydraDX-math/src/lbp/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: ROYALTY's are hardcoded
### Description
**Description:**
The percentage of royalty or service fee is hardcoded. In future,if the developers or the community decide to update the percentage via governance etc.,it will be not be possible.
**Recommendations:**
Add a function to update the percentage of fe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | true | false | ## Medium: TRST-M-2 Attacker can force partial withdrawals to fail
### Description
**Description:**
In Ninja vaults, users call `withdraw()` to take back their deposited tokens. There is
bookkeeping on remaining amount:
If the withdraw is partial (some tokens are left), user.amount is decremented by r.
Above, r i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Incomplete Implementation of getAssetAum Function
### Description
The provided code snippet contains a function named `getAssetAum` that is intended to calculate the Assets Under Management (AUM) for a specific token in a pool. However, the implementation of the function is incomplete and currently returns a h... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | true | true | ## High: Accepting duplicate signatures from one signer
### Description
The `validateMessage` function in `SubstrateSignatureValidator` is designed to verify that a message has been signed by a threshold of attestors. However, the function does not account for duplicate signatures from the same attestor. It simply cou... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Missing domain checks in the initialization
### Description
The initialization scripts add minters for various CCTP domains but there is no check that those domains are valid.
```solidity
for (uint256 i = 0; i < mintRecipients.length; i++) {
controller.setMintRecipient(mintRecipients[i].domain, mintRecipien... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: `_depositable` and `_withdrawable` return if paused
### Description
**Severity**
**Impact:** Medium
**Likelihood:** Medium
**Description**
The Vault operates by using deposit and withdrawal queues. It starts from the first pool in the queue and checks the amount of assets available to process. If the am... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: `CurveStableSwapNG` and `CurveStableSwapMetaNG` DOS by manual token sent
### Description
In `CurveStableSwapNG` and `CurveStableSwapMetaNG` if 1 wei of any token is sent to an empty pool, `get_D()` fails. Consequently, `add_liquidity()` also fails. This situation can be resolved manually by sending 1 wei of... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Potentially unsafe cast from negative `int96` values
### Description
**Description:** Where calculations are performed on `int96` values, for example when manipulating stems in [`LibSilo::stalkReward`](https://github.com/BeanstalkFarms/Beanstalk/blob/dfb418d185cd93eef08168ccaffe9de86bc1f062/protocol/contracts/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | true | false | ## Low: Commented-Out Code
### Description
In `ProxyAdmin.sol`, the `constructor` function includes commented-out lines of code. While these comments may have been added during development or testing, leaving them in production code creates ambiguity and potential risks:
```
constructor(address _logicAddress) payable... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | false | false | ## Low: Risk of transaction pool admission denial of service
### Description
l2geth’s changes to the transaction pool include an ECDSA recovery operation at the beginning of the pool’s transaction validation logic, introducing a denial-of-service vector: an attacker could generate invalid transactions to exhaust the s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Unreachable Branch
### Description
**Description**
In the function_internalDeposit in the contract Vesting.sol the condition if (receiver_ == address(0)) revert ZeroAddress() is unnecessary since at L114 ERC20's mint is called which reverts on 0 address mint, therefore checking the condition again is not need... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: Function `executeMintToTreasury` will incorrectly reduce the `supplyShares`, therefore prevent the last users from withdrawing
### Description
The incorrect reduction in `PoolLogic::executeMintToTreasury` will cause failure of some (likely to be the last) user's withdrawal, and the fund will be locked.
### ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Race condition in broker.Broker results in panic
### Description
The `broker.Broker` struct includes the following map: `subscriptions map[chan T]struct{}`. This map acts as a list of all of the subscribed channels. You can add and remove channels from this map by using the `Subscribe` and `Unsubscribe` functi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Late checkpoints will use higher share price, influencing traders' PnL
### Description
Calling the `checkpoint(_checkpointTime)` function for a checkpoint in the past will look for the next checkpoint higher than `_checkpointTime`, then retroactively apply the later checkpoint's share price to it:
- Under ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Wrong Emergency Stop pattern usage
### Description
**Severity:** Medium
**Path:** Crate.sol
**Description:** The contract `Crate.sol` provides an Emergency Stop pattern, but some functions don’t have any checks to halt their usage, so users can withdraw or redeem after the owner has paused the contract. ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: Unclaimed rewards when emergency withdrawing are not redistributed in `MasterChef` and `MlumStaking`
### Description
Unclaimed rewards when emergency withdrawing are not redistributed in `MasterChef` and `MlumStaking`.
### Impact
Unclaimed rewards when emergency withdrawing in `MasterChef` and `MlumStakin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: swapTokens may return false swapped amounts
### Description
The swapped amount returned by the `swapTokens()` function is calculated as follows:
```
return (payerBalanceBefore + routerBalanceBefore) - (payerBalanceAfter + routerBalanceAfter);
```
Where `payerBalanceBefore - payerBalanceAfter` is simply the a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: `MembershipERC1155` should use OpenZeppelin upgradeable base contracts
### Description
**Description:** `MembershipERC1155` is an implementation contract intended for use with `TransparentUpgradeableProxy`, controlled via an instance of `ProxyAdmin`; however, it does not utilize the OpenZeppelin upgradeable co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Hardcoded Constants as Governance Parameters
### Description
In the provided keeper code for the regulation module, two important constants are hardcoded:
`1. MIN_AMOUNT = 20000 * 10`
`2. VOTING_PERIOD = 86400 * 14 (14 days in seconds)`
These values are likely intended to be governance parameters that could... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: risk of griefing attack during settlement period in Protected mode
### Description
In Protected Mode, higher-ranked traders in the settlement process can delay their point settlements until the end of the settlement period, preventing subsequent traders from settling their points, and leading to forced collate... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Missing Zero Address Validation
### Description
The contracts were found to be setting immutable addresses without proper validations for zero addresses.
### Impact
If address type parameters do not include a zero-address check, contract functionality may become unavailable.
### Recommendation
Add a zero add... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | false | false | ## High: Lack of timely update borrowing fee when update position's margin
### Description
The borrow fee is related with initialMargin and leverage. When initialMargin/leverage changes, we need to update borrow fees.
### Impact
Traders can pay less borrowing fees than they should.
### Recommendation
Timely update b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Use `mintedVotingPower_` instead of `mintedVotingPower`
### Description
Gas saved: 114 per tx per instance
**[0xble (Party) confirmed](https://github.com/code-423n4/2023-04-party-findings/issues/23#issuecomment-1513577421)**
*** | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Loop in `_commitBatchesWithSystemContractsUpgrade()` in `Executor.sol` can be optimized
### Description
[File: ethereum/contracts/zksync/facets/Executor.sol](https://github.com/code-423n4/2023-10-zksync/blob/1fb4649b612fac7b4ee613df6f6b7d921ddd6b0d/code/contracts/ethereum/contracts/zksync/facets/Executor.sol#L... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: User-Provided Deposit and Withdraw IDs Can Cause Collisions
### Description
The [`Bridge`](https://github.com/Fantom-foundation/Bridge/blob/558465d3aba2ffae1a4436a2fc14c723b82926df/contracts/Bridge.sol#L13) and [`TokenDeposit`](https://github.com/Fantom-foundation/Bridge/blob/558465d3aba2ffae1a4436a2fc14c72... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [02] Transferring ownership may result in fees being unintentionally paid to the previous owner
### Description
### Finding description and impact
In the protocol, the `tokenizeFeeDestinationAddress` is a configurable parameter that determines where tokenization fees are sent when the fee system is enabled. T... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Misplaced punctuation
### Description
There's an extra comma - it looks like a find-and-replace error.
*There is 1 instance of this issue:*
https://github.com/code-423n4/2022-12-gogopool/blob/aec9928d8bdce8a5a4efe45f54c39d4fc7313731/contracts/contract/Vault.sol#L154-L160 | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Inconsistent Oracle Price Update
### Description
## OraclePrices Structure Inconsistency
There is a potential inconsistency in the `OraclePrices` structure when the `UpdateOracleMapping` instruction updates the oracle mappings, particularly when updating the source for an existing token. Without an immediate ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: Spoofing Stake Information
### Description
## CVGT Staking Vulnerability Report
In `cvgt_staking::stake`, the `staking_info` account is initialized based on the user account’s public key and is associated with a staking operation. The vulnerability lies in the fact that `staking_info` may be spoofed under a ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Code quality could be improved
### Description
Some minor code quality improvements are recommended to improve readability.
**Explicitly set the visibility for of variables:**
**code/contracts/tokenization/StableDebtToken.sol:L23-L24**
**code/contracts/configuration/LendingPoolAddressesProviderRegistry.s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Removal Of Unused Code
### Description
## Deprecated Fields
The following fields are never set or used and should be removed from the code base:
1. **wallet_info** field in `Session account` is never set or used.
2. **associated_signer** field in `Session account` is never used.
3. **payer account** in `set_... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Shadowed Variable in Fee Estimation Functions
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In both the estimateBrc20TotalFee and estimateRunesTotalFee functions, the variables brc20TransferFee and runesTransferFee are being used as parameters in the getBitcoinTransferFeeI... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | true | false | ## Low: Order cancellation event spam in orderMixin
### Description
The 1inch Limit Order protocol’s contracts utilize mechanisms to allow creation of orders without posting the orders on chain. Indeed, the orders are created by signing `Order` struct hashes off-chain by the maker, and then having takers pass the sign... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Method could return 0 based on oracles returned decimals feeds
### Description
**Severity**: Low
**Status**: Resolved
**Description**
In contract BobaDepositPaymaster, function “getTokenValueOfEth” is translating a given value amount of ethereum into the underlying token amount, for that the business logic ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: L02] The AccountBalanceGenerationUpdate event is missing relevant data
### Description
###### Low
Component: [`currency`](https://github.com/BeamNetwork/currency/blob/af3428020545e3f3ae2f3567b94e1fbc5e5bdb4c/contracts/currency/)
In the `EcoBalanceStore` contract, the [`AccountBalanceGenerationUpdate` event... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missing Sanity checks in multiple functions at Vesting
### Description
**Severity**: Low
**Status**: Acknowledged
**Description**
It was identified that multiple functions in Vesting.sol smart contract does not include checks to validate the provided parameters are not zero. Although this is not critical, f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Built-in `shift()` function will fail if passed a negative integer at compile time
### Description
The built-in `shift()` function accepts an `INT256` as an input, which are accounted for and work fine at runtime. However, there is a compile time check that causes a revert if a negative literal is passed to th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | false | false | ## High: User can mint any amount of stable coins
### Description
The `mint_stable_coin` function allows to mint a certain amount of stable coins depending on the amount of collateral deposited by the user. The validations are performed by the **Custody** contract, verifying that the user has already deposited the cor... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Naming inconsistency
### Description
There are some inconsistencies in the naming of some functions with what they do.
### Recommendation
Review the code for the naming inconsistencies. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: ERC20 return values not checked
### Description
Source: https://github.com/sherlock-audit/2023-01-derby-judging/issues/10
## Found by
gmx, Bnke0x0, PRAISE, tsvetanovv, Met, 8olidity, Saeedalipoor01988, Avci, hyh, oot2k, R-Nemes, SunSec
## Summary
## Vulnerability Detail
Some tokens (like USDT) don't corre... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: distribute() won’t update epoch[tigAsset] when totalShares[tigAsset]==0 which can cause later created bond for this tigAsset to have wrong mint epoch
### Description
## Lines of code
https://github.com/code-423n4/2022-12-tigris/blob/588c84b7bb354d20cbca6034544c4faa46e6a80e/contracts/BondNFT.sol#L206-L228
h... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Missing validations when initializing CasimirRegistry
### Description
**Description:** During Beacon Proxy deployment, CasimirRegistry can be deployed with 0 cluster size and 0 collateral.
**Recommended Mitigation:** Consider validating inputs for cluster size and collateral.
**Casimir:**
Mitigated in [37f3d... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: query 's returned price is not accurate
### Description
The `query(uint256 period)` function is supposed to return "the average price between the last recorded timestamp looking a user-determined time into the past". The user-determined time is the `period` parameter.
However, the code looks for the next ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | true | false | ## Low: Incorrect comment regarding the configuration of `DebtToken::FLASH_LOAN_FEE` parameter
### Description
`DebtToken::_flashFee` divides by `10000`, hence if `FLASH_LOAN_FEE = 1` then:
```solidity
1/10000 = 0.0001
0.0001 * 100 = 0.01%
```
So the comment indicating that 1 = 0.0001% is incorrect:
```diff
File: De... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Sandwich attack for `turnEmpirePointPriceDown()`
### Description
Admins call `turnEmpirePointPriceDown()` and reduce the price of an empire's points:
```solidity
function turnEmpirePointPriceDown(EEmpire _empire) internal {
P_PointConfigData memory config = P_PointConfig.get();
uint256 newPointPrice ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: A router 's liquidity might get trapped if the router is removed
### Description
## Security Advisory
**Severity:** Low Risk
## Context:
- RoutersFacet.sol#L297
- RoutersFacet.sol#L518
- RoutersFacet.sol#L498
- RoutersFacet.sol#L581
## Description:
If the owner or a user with `Role.RouterRole` removes a rou... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Parameters not checked
### Description
Input parameters values are not checked:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/pool/LinearInterestRateModel.sol#L46
### Recommendation
We recommend adding allowable range for each parameter. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Fund intent allows creation with invalid or incorrect route parameters
### Description
The `fundIntent()` function in the IntentSource contract accepts a `routeHash` parameter without validating the underlying route components. This allows intents to be funded with routes that contain invalid parameters or ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | logic | true | false | ## Low: Use of incorrect mask to clear higher bits of the protocolFee value
### Description
The `calculateSwapFee` function of the `ProtocolFeeLibrary` contract uses an incorrect mask of `0xffff` to clear higher bits of the `protocolFee` value, which is a 12-bit value. The `swap` function of the `Pool` library contrac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: `UniV3LiquidityAMO::recoverERC721` will cause `ERC721` tokens to be permanently locked in `rdpxV2Core`
### Description
`UniV3LiquidityAMO::recoverERC721` is a function created in order to be able to recover `ERC721` tokens from the `UniV3LiquidityAMO` contract. It can only be called by admin and will transfer... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Use existing stack cache variable rather than re-fetching state variable
### Description
Using `auctionStartTimestamp` defined above will save a Gwarmaccess (100 gas). Since this is in one of the two frequently-called functions, it'll save a lot of gas
*There is 1 instance of this issue:*
https://github.com/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | access-control | false | false | ## Low: Hard-coded pause collateral fee not appropriate for multi-chain usage
### Description
As Solidly aims to be multi-chain in the future, [hard-coding](https://github.com/SolidlyV3/v3-rewards/blob/6dfb435392ffa64652c8f88c98698756ca80cf28/contracts/RewardsDistributor.sol#L553) a pause collateral fee of 5 ether in ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Unchecked launch time in registrar
### Description
In the **RegistrarController** contract, specifically within the `setLaunchTime`function, the `launchTime_`parameter is updated directly without validation against the current block timestamp. This absence of a check means that the `launchTime_`can be mistaken... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Enforce UpdateVoterWeight signer
### Description
## Update Voter Weight Record
`UpdateVoterWeightRecord` is an unprivileged instruction which allows any user to update a `VoterWeightRecord`.
## Code Snippet
This could be used to clear the voter weight of otherwise valid `VoterWeightRecords`, making it diff... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Additional checks are required for function setMultiSig() at CoiinMinter.sol
### Description
**Description**
There is no verification for the zero address for the multiSig address.
**Recommendation**:
Add additional check:
require(_multiSig != address(0), "Wrong multiSig address"); | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | flash-loan | true | false | ## Medium: `BalancerFlashLender#receiveFlashLoan` does not validate the `originalCallData`
### Description
### Impact
`receiveFlashLoan` does not validate the `originalCallData`. The attacker can pass any parameters into the `receiveFlashLoan` function and execute any Strategy instruction :`_supplyBorrow` `_repayAndW... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | flash-loan | true | false | ## High: `_removeLeverage()` provides incorrect amounts when swapping pods
### Description
When `_removeLeverage` is triggered, if `_pairedAmtReceived` is lower than `_repayAmount`, it triggers `_acquireBorrowTokenForRepayment`.
```solidity
function _removeLeverage(bytes memory _userData)
internal
returns (uint... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: Liquidity pool interest accrual can be manipulated
### Description
**Severity**
**Impact:** Medium
**Likelihood:** Medium
**Description**
On each call to the `borrow` method of the `LiquidityPool` contract, the subsequent `_fixAccruedInterest` method is invoked which updates the `totalBorrowsSnapshotTim... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | false | false | ## Medium: USDC Depeg Risk in USDX Bridge
### Description
The following issue has been identified within the `bridge` function of the `USDXBridge` contract. Specifically, this involves a potential instant arbitrage risk in cases where USDC or other assets lose their peg. In such cases, the market price of USDX may dep... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | flash-loan | true | false | ## High: TRST-H-2 A malicious operator can steal all user deposits
### Description
**Description:**
In the Orbital architecture, each Vault user has a numerator which represents their share of
the vault holdings. The denominator is by design the sum of all numerators of users, an
invariant kept at deposits and withd... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: UNDERUSED PROTOCOL INACTIVE STATE
### Description
The **staking** contract implemented a switch to go into a pause-like state called “Protocol Inactive” by using the `config.active` setting. This check was not implemented consistently across all the functions accessible for unprivileged users, but only on the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: `SimplePriceManager.onUpdate()` lack of forward execution fee leads dependent functions to revert
### Description
`SimplePriceManager.onUpdate()` wraps its work in `gateway.withBatch()` but does not forward any native token as the execution fee. In practice, partial path that relies on `onUpdate()` will con... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Unsafe usage of transfer/transferFrom in EncryptedERC deposit/withdraw methods
### Description
**Severity:** Medium
**Description:** The `EncryptedERC` token enables private transfers by utilizing partially homomorphic encryption, ensuring confidentiality during transactions. Moreover, it provides an oppor... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: An attacker can make users unable to cancel their L1 calls on Ethereum To Arbitrum
### Description
[EthereumToArbitrumRelayer.sol#L118-#L127](https://github.com/pooltogether/ERC5164/blob/5647bd84f2a6d1a37f41394874d567e45a97bf48/src/ethereum-arbitrum/EthereumToArbitrumRelayer.sol#L118-#L127)
When someone wa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Incomplete Validation In Multiple State Changing Functions
### Description
1. Missing zero-address checks
It has been detected that almost all functions of the smart contracts are missing address validation. Every input address should be checked not to be zero, especially the ones that could lead to rendering... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Application Monitoring Can Be Improved by Emitting More Events
### Description
**Update**
The client provided the following explanation:
> acknowledged
**File(s) affected:**`isolated_lending/sources/isolated_lending.move`, `isolated_lending/sources/farming.move`, `lending_core/sources/farming.move`, `lending... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: VaderPoolV2.rescue results in loss of funds rather than recoverability
### Description
_Submitted by TomFrenchBlockchain_
#### Impact
Any unaccounted for tokens on `VaderPoolV2` can be siphoned off by anyone
#### Proof of Concept
`VaderPoolV2` has a `rescue` function which allows any unaccounted for tok... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: NodeRegistry - removeNode unnecessarily casts the nodeIndex to uint64 potentially truncating its value ✓ Fixed
### Description
`removeNode` removes a node from the Nodes array. This is done by copying the last node of the array to the `_nodeIndex` of the node that is to be removed. Finally the node array size ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Delayed staking transaction will not be unbondable, letting staker 's funds locked for a long period
### Description
The Babylon system relies on specific configuration for a given number of blocks. For example, the minimum and maximum staking amounts are defined by this configuration and can change. A stak... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `ApprovalFollowModule.sol` lack of transfer check make it possible for anyone to become follower without approved by the profile owner
### Description
Per the comment in `ApprovalFollowModule`, it aims to create a whitelist system:
> This follow module only allows addresses that are approved for a profile by ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | reentrancy | true | false | Source: https://github.com/sherlock-audit/2024-01-napier-judging/issues/105
## Found by
AuditorPraise, xiaoming90
## Summary
Minting of PT and YT is the core feature of the protocol. Without the ability to mint PT and YT, the protocol would not operate.
The user cannot deposit into the Tranche to issue new PT + Y... | Sherlock | 5 | Napier |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Code Redundancy In ditto_config
### Description
## DittoConfig Module
The `ditto_config` module manages the `DittoConfig` struct and provides getters and setters for the various properties. However, the object’s accessors impose a verbose API:
Usage example:
## Remediation
Consider consolidating these re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Unused Imports Partially Addressed
### Description
The following source units are imported but not referenced in the importing source unit:
**code/contracts/contract/rewards/RocketMerkleDistributorMainnet.sol:L11**
```
import "../../interface/rewards/RocketSmoothingPoolInterface.sol";
```
**code/contract... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: The SpendPermissionManger Fails To Handle The Case When It Is Removed From Wallet Owner List, Causing DoS For Dapps
### Description
The `isApproved` function checks if a spend permission for an account is still valid by determining whether it has been approved and not revoked. It is primarily used within `_use... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Front-Running | false | true | _Submitted by hickuphh3_
##### Impact
Let us assume either of the following cases:
1. The vault / protocol is to be winded down or migrated, where either the protocol is halted and `withdrawAll()` has been called on all active strategies to transfer funds into the vault.
2. There are 0 strategies. Specifically, `_c... | Code4rena | 5 | yAxis |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Missing Duplicate Key Check in `setMultipleValues`
### Description
This issue has been identified within the `setMultipleValues` function of the `DIAOracleV2` contract.
Currently, the function does not check for duplicate keys in the `keys` array. If duplicate keys are passed, the later values will overwrite ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Function not used
### Description
Function `max()` is not used in the contract:
https://github.com/keep3r-network/StakingRewardsV3/tree/13ecc6966ae1a413f62224382bfd4d64b1a22351/contracts/StakingRewardsV3-1.sol#L9
### Recommendation
We recommend to remove this function. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unnecessary slippage loss due to AutoCompounder sellingVELO
### Description
AutoCompounder allows every address to help claim the rewards and compound to the locked VELO position. The AutoCompounder will `sell_tokensToSwap` into VELO. By setting VELO as `tokensToSwap`, the AutoCompounder would do unnecessary s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Potentially Stuck Funds
### Description
The users interacting with the protocol are able to call the `depositReward()` function by mistake and lose their funds forever. The function is specifically designated for use by the protocol team or sponsors for supplementing rewards or making donations. Restricting ac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: If pool owner withdraws 100% of earnings, poolusers will be permanently blocked from withdrawing staked funds
### Description
If a pool owner withdraws 100% of earnings, pool users will be permanently blocked from withdrawing staked funds, due to division by zero. The root cause is explained better in a seque... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | true | false | ## Low: Missing ETH swap slippage
### Description
The `releaseFundsAndInvest()` function in `Gateway` provides a `minAmountOut` of zero ETH on swaps. This can lead to the user receiving less ETH than they expected.
Note: This has been mentioned in a previous audit, but it was acknowledged considering non-profitable ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | liquidation | false | false | ## Severity: High Risk
## Context
PositionsManagerForAaveGettersSetters.sol#L208-L219
## Description
Morpho has a single position on Aave that encompasses all of Morpho’s individual user positions that are on the pool. When this Aave Morpho position is liquidated, the user position state tracked in Morpho desynchroni... | Spearbit | 4 | Morpho |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Insecure Encryption
### Description
## EthSign Security Vulnerabilities
EthSign utilizes the CryptoJS library’s encryption method in its default mode to safeguard sensitive information. Notably, there is no specification of the cipher mode and the initialization vector inside `getEncryptedStringFromBuffer`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unnecessary update of `stakingStartTime` after full principal withdrawal in `unstakePrincipal()` and `unstake()`
### Description
Both the `unstakePrincipal()` function in `DIAWhitelistedStaking` and the `unstake()` function in `DIAExternalStaking` unconditionally update the `stakingStartTime` to `uint64(block.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | true | false | ## Low: Fee minimum value can get bypassed
### Description
**Severity**: Low
**Status**: Acknowledged
**Description**
The function `setFee()` in the `StableSwapPool.sol` and `XYKPool.sol` contracts allows certain addresses to set a new value for the `fee1e9` variable. This function implements a require statement fo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: Use the correct function "State Mutability" when needed
### Description
Here's the list of the functions that could be declared with a more specific and restrictive "State Mutability":
- `LeverageMacroBase.decodeFLData` can be declared as **pure**.
- `LeverageMacroBase._doSwapChecks` can be declared as **view*... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | dos | false | false | ## High: TRST-H-4 It’s possible to DOS the distribution of weekly emissions, and as a consequence the whole protocol
### Description
**Description:**
The function `updatePeriod()`, responsible for the weekly distribution of emissions, internally
calls `distributeAll()` on SatinVoter.sol which loops over all of the ex... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | true | false | ## Medium: Unclaimed rewards are lost if user deposits before claiming rewards
### Description
In the `StrategyWrapper` contract, when a user deposits, the rewardVault shares are transferred to the wrapper, and the `_deposit()` function is invoked to checkpoint the user’s balance and `rewardPerTokenPaid`:
```solidity... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | false | false | ## High: Usage of `slot0` is extremely easy to manipulate
### Description
Usage of `slot0` is extremely easy to manipulate
### Impact
Pool lp value can be manipulated and cause other users to receive less lp tokens.
### Recommendation
To make any calculation use a TWAP instead of slot0. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | access-control | true | false | ## Gas: `vault` cannot realistically be `address(0)`
### Description
`vault` is set in the constructor as `msg.sender`:
And then, `setVaultAddress()` can only be called by the owner:
It seems extremely unlikely that the `owner` (who is, by the way, also the `vault`) would just happen to set `vault` to `address(0)`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: The withdrawal queue is only updated when the liquidity is added ✓ Fixed
### Description
Sometimes when the amount of liquidity is not much higher than the number of tokens locked for the collateral, it’s impossible to withdraw liquidity. For a user that wants to withdraw liquidity, a withdrawal request is ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: _deposit resetting user rewards can be used to grief them and make them loose rewards via `depositForMember`
### Description
_Submitted by GalloDaSballo_
The function `_deposit` sets `mapMemberSynth_lastTime` to a date in the future in `synthVault.sol` [L107](https://github.com/code-423n4/2021-07-spartan/b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | logic | false | false | ## High: CVX/AURA distribution calculation is incorrect and will lead to loss of rewards at the end of each cliff
### Description
Source: https://github.com/sherlock-audit/2023-07-blueberry-judging/issues/109
## Found by
0x52
When calculating the amount of pending AURA owed to a user _getAuraPendingReward uses the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: User would liquidate his account to sidestep `takerInvariant` modifier
### Description
A single user could open a massive maker position, using the maximum leverage possible(and possibly reach the maker limit), and when a lot of takers open take positions, maker would liquidate his position, effectively byp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Attacker can utilize bear market conditions to profit from forking the Nouns DAO
### Description
An economic attack vector has been identified that could potentially compromise the integrity of the Nouns DAO treasury, specifically due to the introduction of forking functionality. Currently, the treasury holds ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Inability to claim tokens if `totalAmount < numOfSteps`
### Description
If the grantor transfer an amount that make `totalAmount 0` | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | false | ## Low: Use of Deprecated and Vulnerable Solidity Version 0.5.17
### Description
The **AgentKey.sol** contract is compiled using Solidity version `0.5.17`:
```
// SPDX-License-Identifier: UNLICENSED
pragma solidity 0.5.17;
```
This version contains multiple known vulnerabilities including:
1. `AbiReencodingHead... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | logic | false | false | ## Low: No pending income in functions
### Description
`getTotalAmounts` and `getBasePosition` are `external view` functions and may be externally dependent. Neither of them calculates the pending income in the uniswap pool, which may lead to incorrect calculations in external logic that relies on these two functions.... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.