prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Mixed `msg.sender` and `_msgSender()`
### Description
In some contracts used directly `msg.sender` instead of `_msgSender()`:
- https://github.com/bondappetit/bondappetit-protocol/blob/88680691fe8d872c5fc26e9500d19cf7caaa9861/contracts/Staking.sol#L173
- https://github.com/bondappetit/bondappetit-protocol/b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Unnecessary copying in memory
### Description
In functions `V1LBRouter.marginalV1SwapCallback()`, `V1LBRouter.exactInputInternal()`, and `V1LBRouter.exactOutputInternal`, the calldata arguments `data.tokenIn` and `data.tokenOut` are unnecessarily copied to variables `tokenIn` and `tokenOut`, which consumes gas... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Key voting functionalities are exposed to access control risk outside governance control
### Description
Infrared's voting contracts are derived from Velodrome, retaining the team address configuration set to the deployer (originally meant to be the address of the Velodrome Team multisig) of the VotingEscro... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | false | false | ## Low: Lack of Checks-effects-interactions pattern
### Description
**Severity**: Low
**Status**: Resolved
**Description**
The Checks-Effects-Interactions (CEI) pattern is not followed in some parts of the smart contract. The CEI pattern is a well-known best practice in smart contract development that helps to prev... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: No check for Arbitrum Sequencer when handling prices
### Description
Contracts will be deployed on Arbitrum but AggregatedChainlinkOracle.sol doesn't check if Arbitrum Sequencer is down. If it goes down, oracle data will not be kept up to date, and thus could become stale. However, users are able to continue t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Astaria's Seaport orders may not be listed on OpenSea
### Description
To list Seaport orders on OpenSea, the order should pass certain validations as described [here](OpenSea Order Validation). Currently, Astaria orders will fail this validation. For instance, `zone` and `zoneHash` values are not set as sugges... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Using explicit unsigned integer sizing instead of `uint`
### Description
**Description:** In Solidity `uint` automatically maps to `uint256` but it is considered good practice to specify the exact size when declaring variables:
**Remora:** Fixed in commit [6602423](https://github.com/remora-projects/remora-s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Pool Token Value Is Not Checked Against Total Short Size when Withdrawing, Potentially Resulting in Widespread Protocol Error
### Description
**Update**
Fixed by implementing `_validateGlobalShortSize()`. Total short size cannot exceed the value of the pool amount minus the reserved amount.
**File(s) affecte... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Form::_directDepositIntoVault vars.chainId is never initialized
### Description
IBridgeValidator implementations use three chain ID values to determine if an action is valid: `srcChainId`, `dstChainId`, and `liqDstChainId`. In the case of a direct deposit, all three of these values must be equal to the current... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Redundant/unnecessary named/explicit returns in functions
### Description
Although named returns allow functions to explicitly declare return variables, enhancing readability and self-documentation, several functions within `LiquityBase.sol` employ them without a genuine need, adding unnecessary complexity and... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Optimizing check order for cost efficient function execution
### Description
Checks that involve constants should come before checks that involve state variables, function calls, and calculations. By doing these checks first, the function is able to revert before wasting a Gcoldsload (2100 gas) in a function t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Pre-Solidity `0.8.13`: `> 0` is less efficient than `!= 0` for unsigned integers (with proof)
### Description
Up until Solidity `0.8.13`: `!= 0` costs less gas compared to `> 0` for unsigned integers in `require` statements with the optimizer enabled (6 gas)
Proof: While it may seem that `> 0` is cheaper than... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Notes & Additional Information:
### Description
* `Controller.sol`, `MintController.sol` and `MasterMinter.sol` are using an outdated Solidity release: `v0.4.24`. Consider using the latest version of the Solidity compiler ([`v0.5.2`](https://solidity.readthedocs.io/en/v0.5.2/) at the time of writing) throughou... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Incomplete Docstrings
### Description
Throughout the [codebase](https://github.com/mantlenetworkio/mantle-v2/blob/e29d360904db5e5ec81888885f7b7250f8255895/), there are several parts that have a incomplete docstring:
* In the [relayMessage](https://github.com/mantlenetworkio/mantle-v2/blob/e29d360904db5e5ec81... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: GoBuildTag (rpc/namespaces/ethereum/debug/trace.go: 18)
### Description
**Severity**: Low
**Status**: Acknowledged
**Description**:
Build tag // +build go1.5 can be removed.
**Recommendation**:
Remove the build tag as it is no longer necessary. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | logic | false | false | ## Low: Wrong Formula In Function Comment
### Description
**Update**
Addressed in: `6ce3df0c95363a991389c4d6e53069f28d0b9a32`.
**File(s) affected:**`DepositManagementLogic.sol`
**Description:** In `DepositManagementLogic.getWithdrawableCollateral()` the formula defined in the comment does not match the formula imple... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Require statements with multiple conditions
### Description
Throughout the [codebase](https://github.com/matter-labs/zksync-2-dev/tree/c05b49d7e303996f60a0e35f18ef224e45ee19f5/contracts/ethereum/contracts/) there are `require` statements that require multiple conditions to be satisfied. For instance:
* The `... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Manipulation Of Auction Metrics
### Description
## Protocol Overview
Within the protocol, the `usdc_per_token` metric is calculated by taking Comet’s USD balance, multiplying it by a constant (`SCALAR_7`), and then dividing by Comet’s total supply. This determines bid or lot sizes for bad debt and interest au... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | dos | true | false | ## High: It is possible to DoS batch auctions by submitting invalid AltBn128 points when bidding
### Description
Bidders can submit invalid points for the AltBn128 elliptic curve. The invalid points will make the decrypting process always revert, effectively DoSing the auction process, and locking funds forever in the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: TransmuterBuffer's _alchemistWithdraw use hard coded slippage that can lead to user losses
### Description
_Submitted by hyh_
exchange() -> \_exchange() -> \_alchemistWithdraw() is user funds utilizing call sequence and the slippage hard coded to 1% there can cause a range of issues.
For example, if there... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Unused mapping
### Description
**Description**
flaggedNFTS (contracts/MGD.sol#19)
The mapping is never used, though is kept on the contract and can be set through the setter.
The comment states, that the mapping is used by the frontend app, though its usage should
be verified.
**Recommendation**:
Verify ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Incorrect variable used to check order status
### Description
As you can see status of order is checked against offer's variable. Now they are the same, but mistakes can have an impact in the future | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `_bytes_to_num()` skips `ensure_in_memory()` check, which can lead to compilation failure
### Description
The `_bytes_to_num()` function used in conversion assumes that any bytestring types are in memory. If they are declared from within the expression, it will try to load them from memory and panic.
### Impa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: | Unclear Naming
### Description
**Description**
Although `_poolBalance’s` notice states that it returns "The total deposits of the pool's token”, it weighs the balance of each level of the pool by its corresponding allocation. Because it doesn’t simply sum up the balance of each level, it doesn’t reflect the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: Missing error messages in require statements
### Description
In the code base there are many places where `require` statements are correctly followed by their error messages, clarifying what was the triggered exception. However, there are places in the code where `require` statements are not followed by the co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: LegacyReputationToken’s decimals public getter does not return uint8
### Description
The [ERC20](https://eips.ethereum.org/EIPS/eip-20#decimals) specification specifies an optional getter for the token’s `decimals`, which must return a `uint8` type. While the [`LegacyReputationToken`](https://github.com/AugurP... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | overflow | false | false | ## Gas: Lien id can be safely incremented using unchecked math
### Description
The `_nextRecordId` variable works as a counter that is incremented by one every time a new position is created. It would be impossible in practice for this variable to overflow. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | false | false | ## Low: Don't allow pausing for LayerZero receive, only send
### Description
`MTokenMessagerLZ` has the `onlyLZNotPaused` modifier on both the receiving function `_lzReceive` and the two sending functions `lzSendTokenToChain` / `lzSendMintBudgetToChain`.
Consider removing the `onlyLZNotPaused` modifier from `_lzRecei... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: eth_getTransactionReceipt silently fails for raw transaction
### Description
The `eth_getTransactionReceipt` JSON RPC call will return an invalid result. For example, a Pantheon instance was started using the following command:
```bash
./gradlew run -Ppantheon.run.args="--no-discovery --datadir=/tmp/pantheont... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | true | false | ## High: Share rate can be negatively influenced due to shares burn limit
### Description
**Severity:** High
**Path:** PositiveTokenRebaseLimiter.sol:getSharesToBurnLimit#L119-L136
**Description:**
The PositiveTokenRebaseLimiter is responsible for limiting the increase of the StETH share rate in the positive direct... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | false | false | ## High: Quoter uniswap integration.
### Description
**Severity**: High
**Status**: Resolved
**description**
AirPuffHandlerM._uniswapExecution().
The function uses a quoter for getting the expected amount out without executing the swap
and uses this value as `amountOutMinimum` as a parameter for the swap. However,... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | true | true | ## High: ETH gets locked in the `GroupcoinFactory` contract
### Description
When we launch a Groupcoin to Uniswap v3, we intend to provide all the ETH received from sales as liquidity in the newly created Uniswap v3 pool. However, as we will see below, some ETH may not get wrapped and added to the liquidity position, ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Convex_AMO_V2 custodian can withdraw rewards
### Description
The `Convex_AMO_V2` custodian can withdraw rewards. This violates conventions established by other Frax Solidity contracts in which the custodian is only able to pause operations.
The relevant code appears in figure 15.1. The `withdrawRewards` fu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Protocol will not Work on Most of the Supported Blockchains due to hardcoded `DEPOSIT_CONTRACT` Address
### Description
This vulnerability has the potential to affect smart contracts that depend on hardcoded addresses for external contracts, particularly in multi-chain deployments. In situations where the addr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Refund Block via `extendTime()` Function in `DaosLive`
### Description
The `DaosLive` contract allows the owner to **arbitrarily block refunds** by repeatedly extending the `endTime` of the DAO using the `extendTime()` function. Since refunds are only available after `endTime`, this introduces a **centraliz... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | false | false | ## High: Operations can be injected by a Tezos node before signing
### Description
A compromised or malicious Tezos node can imperceptibly inject operations which will be signed along with other operations. The value of `blockHead.hash` received from the remote node is not validated and is used to construct operations... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Once `start` Is Set to `true`, It Cannot Be Changed Back to `false`
### Description
The `setStart()` function in the smart contract permanently sets `start = true` without any mechanism to reverse or pause the contract's operational state. Once this is set, the contract remains in a "started" state indefinitel... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: A revoked schedule might be able to be fully released before the 2year global lock period
### Description
The `unlockedAmount` calculated in `_computeGlobalUnlocked(...)` is based on the original `scheduledAmount`. If a creator revokes their revocable vesting schedule and changes the end time to a new earlier ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: syncWithOmni() Can Surpass XMsg Max Gas Limit
### Description
In `OmniPortalConstants`, the max gas limit for XMsg (`XMSG_MAX_GAS_LIMIT`) is set to 5 million gas units. In `OmniAVS`, the base gas limit and gas limit per operator is initialized as 75,000 and 50,000 respectively. This means that the max number o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Incorrect withdraw queue balance in TVL calculation
### Description
When calculating TVL it iterates over all the operator delegators and inside it iterates over all the collateral tokens.
However, the balance of `withdrawQueue` is incorrectly fetched, specifically this line:
It uses an incorrect index o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Missing packet type validation in `addCardBundlesToPacketPool()`
### Description
_Resolved_
In the `CardAllocationPool.addCardBundlesToPacketPool()` function, the function is designed to be called by the redeem manager to add cards to a specific packet type's pool as a bundle. However, it does not validate if... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Function `rebase()` apply wrong APR in RivusTAO
### Description
The function `rebase()` is supposed to apply daily APR to the share price by decreasing the total share amount. The issue is that the code uses `totalSharesAmount * apr` to calculate `burnAmount` so the burned amount would be bigger than what it ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Require array to be sorted and use `sortedAndAllUnique` at `BackingManager.forwardRevenue()`
### Description
Estimated savings: `~n^2*10` where n is the length of the asset.
For example for 20 assets that would save ~4K. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | front-running | true | false | ## Low: `StandardToken::transferWithPermit` can be DoS attacked by front-running to directly call `ERC20PermitMixin::permit`
### Description
`StandardToken::transferWithPermit` contains two calls:
* first to `ERC20PermitMixin::permit`
* second to the `StandardToken::transferFrom`
### Impact
Since the permit signature... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | logic | false | false | ## Medium: LockPositionService::increaseLockTime Incorrect Calculation Extends Lock Duration Beyond Intended Period
### Description
`LockPositionService::increaseLockTime` uses `block.timestamp` for locking tokens, resulting in potential over-extension of the lock period. Specifically, if a user locks tokens near the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: Not Checking for Sequencer Down for L2 Networks like Arbitrum
### Description
The Current system is designed to work in different chains, and A lot of L2 networks are supported, including Arbitrum.
In Arbitrum L2, there is a sequencer that manages transaction ordering, execution, etc... But this sequencer can... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: Missing Input Validation
### Description
Several functions in both `SwapManager` and `CurveSwapper` lack proper input validation, relying on assumptions about parameters that may not always hold true. This oversight introduces potential vulnerabilities and operational risks.
Examples:
* **SwapManager's**... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Connected pair of parameters (staking_status and merchant_statusParameters
### Description
**Description**
staking_status and merchant_status are set together in constructor and can be changed only
together in enablePhase2() and burnContract() methods. There is no way to change them
separately, and these two p... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: POSSIBILITY TO CREATE POOLS WITH THE SAME PAIR
### Description
The AMM module allow users to create pairs (called **exchanges**) from native or custom assets by calling `create_exchange` function on **factory** contract. It relies on the `token_type` `PartialEq` implementation, that allows users to pair the s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: Blacklisted Operators Can Not Be Revoked from Being an Operator
### Description
NFTs can be stolen by the blacklisted operators. They can then burn/sell afterwards.
Impact is high, as the victim NFT owner cannot revoke the approval from this balcaklisted operator because of this line below
Root cause :
- `s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Excessive resource consumption in validateUnstakingOutputs
### Description
In `validateUnstakingOutputs`, we iterate over every output in the Bitcoin transaction:
```go
// Ignore the last output because it's the change output
for i, out := range outputs[:len(outputs)-1] {
err := c.validateUnstakingOutput(ct... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: Commented-out blacklist check allows restricted transfers
### Description
**Description:** In [`PerpetualBond::_update`](https://github.com/YieldFiLabs/contracts/blob/40caad6c60625d750cc5c3a5a7df92b96a93a2fb/contracts/core/PerpetualBond.sol#L508-L510), the line intended to restrict transfers between non-bla... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Missing validation of proxy admin indices
### Description
Multiple functions of the `ProxyController` contract take an index as an input. The index determines which proxy (managed by the controller) is being targeted. However, the index is never validated, which means that the function will be executed even if... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | false | false | ## Medium: Affiliate keys can be reused
### Description
The [`addKey` function of the `AffiliateValidator` contract](https://github.com/AugurProject/augur/blob/67c0fec95e65fca8d27751f28a6c06e5247978c6/packages/augur-core/source/contracts/AffiliateValidator.sol#L23) is used to associate a `key` with a user account. The... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Variable not needed
### Description
[crv-locker.sol#L87](https://github.com/pickle-finance/protocol/blob/9b0f330a16bc35c964211feae3b335ab398c01b6/src/strategies/curve/crv-locker.sol#L87)
The variable `success` will always be true.
We recommend removing this variable.
Status: *Fixed at https://github.com/pick... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Out-of-Gas Errors Can Occur if Too Many Markets Are Supported or Entered
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> We understand and appreciate the concern raised in the audit report regarding potential Out-of-Gas errors. However, we... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | token | true | false | ##### Description
- https://gitlab.ubertech.dev/blockchainlaboratory/eywa-dao/-/blob/29465033f28c8d3f09cbc6722e08e44f443bd3b2/contracts/EscrowVoteManagerV1.sol#L136
It was discovered that the `s_emissionManager` contract does not handle ERC20 tokens. However, the following code attempts to transfer ERC20 tokens to th... | MixBytes | 5 | EYWA |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Report's validatorsCount 's historical non-decreseness does not get checked
### Description
Once the Oracle members come to a quorum for a selected report variant, the validators count is stored in the storage. Note that `validatorsCount` is supposed to represent the total cumulative number of validators ever ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: `MultiInvoker`, `Manager` and `Account` unexpected reverts in certain conditions due to AAVE reverting on deposits and withdrawals with 0 amount
### Description
Source: https://github.com/sherlock-audit/2024-08-perennial-v2-update-3-judging/issues/18
## Found by
panprog
**Summary**
AAVE v3 pool implement... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Market order borrows may revert due to missing edge case
### Description
When a borrower attempts to execute a market order against a specific lender, the borrower can opt to borrow from their existing credit positions that will expire before the due date of the new debt position being created. This maintains ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Improper RLP Encoding Validation in The `RLPReader` Library
### Description
The `EthereumDecoder.sol` contract relies on the external `RLPReader` dependency to decode `RLP-encoded` nodes within the Ethereum state trie. When it processes a byte string as an `RLPItem`, the library does not verify whether the enc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Revert reason in transferValueAndprocessRoute() is bubbled up incorrectly
### Description
The `transferValueAndprocessRoute()` function performs a call to the `transferValueTo` address to transfer native tokens. If the call fails, the revert reason in `returnBytes` is bubbled up incorrectly using `string(abi.e... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Incorrect number of seconds in `ONE_YEAR` variable
### Description
_Submitted by jayjonah8_
In `HolyPaladinToken.sol` the `ONE_YEAR` variable claims that there are `31557600` seconds in a year when this is incorrect. The `ONE_YEAR` variable is used in the `getCurrentVotes()` function as well as the `getPa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Missing or incomplete events
### Description
It was found that the **SwapModule** contract does not emit events when updating its variables (`setModuleAddr`, `setApprovedCaller`), and that the CommonPool's `updateProtocolAddresses` function may update the `_eventEmitter` but does not reflect it in the emitted ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: When retain4626 is false , the superposition may be minted to an incorrect address
### Description
When depositing to the vault, users can make deposits on behalf of other users by specifying the receiver address. If the user doesn't retain 4626, the function will mint super positions at the end of the depo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | upgrade | false | false | ## Low: Redundant Flag `READY_TO_DRV_UPGRADE` Appears Unused
### Description
The `READY_TO_DRV_UPGRADE` flag appears to be redundant and potentially dead code. It is always set together with `READY_TO_PERP_UPGRADE`, but there is no separate DRV upgrade functionality in the codebase. The flag is never independently che... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | true | false | ## High: precision loss in slippage protection calculation
### Description
The ULTI contract contains a precision error in its slippage protection mechanism during token swaps (using 18 instead of 1e18). In the `_swapInputTokenForUlti` function, the calculation of `expectedUltiAmountWithoutSlippage` uses an incorrect ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: When using BaseBranchRouter as a router on the 'Arbitrum' branch, we are unable to invoke the 'callOutAndBridge' function.
### Description
All branches have one core router and several subsidiary branches. The core branches handle system calls, and users can create deposits using subsidiary branches. The fu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: LACK OF PAUSABILITY OF SMART CONTRACTS
### Description
The project lacks ability to pause contracts. It is advised that in case of unexpected events temporarily disable some important functions to prevent further damage.
### Recommendation
**SOLVED**: The `Octopus Network` team solved the issue by adding the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | true | false | ## Medium: `validateFeeLimit` does not properly limit the transaction fee
### Description
`validateFeeLimit` will be called within `SessionKeyValidator`'s `validationHook` to ensure that the caller's provided `maxFeePerGas` and `gasLimit` is within the usage limit.
```solidity
function validationHook(bytes32 signed... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | false | ## Low: Consider adding share-based sell function to avoid dust shares
### Description
**Description:** The current interface requires users to specify the desired amount out (tokens) when selling shares, rather than the amount in (shares to sell). This makes it difficult for users or integrators to accurately sell al... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: False Accounting in Position Due to Downcasting `int256` to `int64`
### Description
**Update**
Marked as "Fixed" by the client. The issue is fixed by using `int256` across the project. Addressed in: `ae69c230605e4548746e843ac032e75d1f59fa97`.
**File(s) affected:**`contracts/ledger/Ledger.sol`
**Description:... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: Wrong `calcAsymmetricShare` calculation
### Description
The inline-comment defines the number of asymmetric shares as `(u * U * (2 * A^2 - 2 * U * u + U^2))/U^3` but the `Utils.calcAsymmetricShare` function computes `(uA * 2U^2 - 2uU + u^2) / U^3` which is not equivalent as can be seen from the `A^2` term in ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Entities are not required to be initiated
### Description
Every entity (Planet, Comet, Operator) has a 3-step creation process:
* Creation of the proposal.
* Approval of the proposal.
* Initiation of the entity.
The last step is crucial, but it is never explicitly checked that the entity is initialized.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: Incorrect decimal handling in `Auction::buy()` leads to massive overpayment for ZENO tokens
### Description
The `buy()` function in the `Auction` contract fails to account for the decimal difference between `USDC` (6 decimals) and `ZENO` (18 decimals), causing users to overpay by a factor of `10^18` when purc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Intentional secret reuse can block borrower and lender from accepting liquidation payment ✓ Fixed
### Description
For Dave (the liquidator) to claim the collateral he’s purchasing, he must reveal secret D. Once that secret is revealed, Alice and Bob (the borrower and lender) can claim the payment.
Secrets m... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Missing revert message in `setMarginAllowed` function of UniMexFactory.sol
### Description
**Description**
In contract UniMexFactory.sol in function setMarginAllowed at line 40 there's no revert message in the require check.
**Recommendation**
Add a revert message.
**Re-audit comment**
Unresolved | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Insecure storage of price-feeder keyring passwords
### Description
Users can store oracle keyring passwords in the `price-feeder` configuration file. However, the `price-feeder` stores these passwords in plaintext and does not provide a warning if the configuration file has overly broad permissions (like th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Implicit loss calculation
### Description
`_reportLoss` function defined [here](https://github.com/iearn-finance/yearn-vaults/blob/054034304c7912d227d460feadc23177103de0b9/contracts/Vault.vy#L1191) implicitly changes the passed value of the loss tokens amount. Implicit behavior might be wrongly missed and the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Collaterals and markets can be updated after being deactivated
### Description
The [`HoldefiSettings` contract](https://github.com/holdefi/Holdefi/blob/f4df394d7cf6df347b1f1e9af8e2676c5933c2c9/contracts/HoldefiSettings.sol) defines a mapping of [`collateralAssets`](https://github.com/holdefi/Holdefi/blob/f4df3... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: Incorrect Accounting of currentWithheldETHinInstantWithdrawals
### Description
In the withdraw(address recipient) function, when the withdrawal amount is less than
or equal to currentWithheldETH, the function enters the instant withdrawal path. In this case, the
contract does not call plumeStaking.withdraw(),... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Empty note and fact labels can be created
### Description
The `isNote` and `isFact` modifier only check that the label's first character is the correct identifier (`~` or `!`). They then call `_isValidName(label, 1)`, which only checks that the length of `label` isn't 0. However, that's always the case for not... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: [44] Double addressed tokens can be stolen from the bridge
### Description
### Proof of Concept
While depositing the contract calls to see if the deposits have been cleared with token addresses, case here is that in most of the logic, it doesn't consider that a user can just specify the second address if the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Return data from the external call not verified during deposit and redemption
### Description
The [deposit](https://github.com/sherlock-audit/2023-03-notional/blob/main/contracts-v2/contracts/external/actions/TreasuryAction.sol#L318) and [redemption](https://github.com/sherlock-audit/2023-03-notional/blob/m... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Replay Attack | false | false | ## Risk Assessment
## Severity
**Medium Risk**
## Context
BridgeFacet.sol#L476-496
## Description
Connext bridge supports near-instant transfers by allowing users to pay a small fee to routers for providing them with liquidity. Gelato relayers are tasked with taking in bids from liquidity providers who sign a messag... | Spearbit | 5 | Connext |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: Caching storage values in memory
### Description
The code can be optimized by minimizing the number of SLOADs.
SLOADs are expensive (100 gas after the 1st one) compared to MLOADs/MSTOREs (3 gas each). Storage values read multiple times should instead be cached in memory the first time (costing 1 SLOAD) and th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Method convert(...) does not validate parameter `_mode`
### Description
**Severity**: Low
**Status**: Acknowledged
**Description**
In contract mPendleConverter.sol, the method `convert(uint _amount, uint _mode)` has a comment mentioning _mode can be 0 or 1. It should be validated in the method logic as well... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Insufficient Protection for Uninitialized Contracts
### Description
Several state changing functions defined in `Lido.sol` and `StETH.sol` are not protected by the `isInitialized` modifier. Prior to v0.2.0-rc.0 this was not a problem, as they all performed external function calls that would revert when uniniti... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | initialization | false | false | ## Gas: It costs more gas to initialize non-`constant`/non-`immutable` variables to zero than to let the default of zero be applied
### Description
Not overwriting the default for [stack variables](https://gist.github.com/IllIllI000/e075d189c1b23dce256cd166e28f3397) saves **8 gas**. Storage and memory variables have l... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | logic | false | false | ## Low: Price transferred in Dutch auction is calculated price, not bid amount.
### Description
**Description**
In the Auction House contract, in a Dutch auction, if the user places a bid, then the current calculated price is transferred, not their bid.
programs/auction_house/src/methods/make_bid.rs
**Recommendation... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: distributeRewards() and claimRewards() may revert.
### Description
**Description**
Lines 65, 70. There is no restriction in the constructor on rewardToken to be a zero address. In
this case, both functions distributeRewards() and claimRewards() will always revert.
This can also cause a denial of service du... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Migrating with "migratePartnerVault()" may result in a loss of user funds
### Description
The `ERC4626PartnerManager.migratePartnerVault()` function defines the new vault contract in case vaults are migrated.
However, it has some design vulnerabilities:
1. For best practice, many projects use an upgradable ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Not enough TAP tokens to exercise if a user participates and exercises in the same epoch
### Description
Users were unable to purchase their deserved amount of TAPs
### Proof of Concept
During each `epoch` and for a specific `sglAssetID`, there is a fixed amount of TAP tokens that will be minted and stored ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: The RdpxV2Core contract allows anyone to call redeem tokens even if the contract is paused
### Description
When the admin pauses the contract RdpxV3core locks anyone to use this contract such as a bond, bondWithDelegate, and withdraw. But a function redeem is still available to use.
Any situations that occu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Missing Constraints for`maPeriod`Settings
### Description
**Update**
**Quantstamp:** The Sperax team implemented mechanisms recommended by the Quantstamp team.
**Update**
Marked as "Fixed" by the client. Addressed in: `943b95d752f95e20e137d0a797bb9d332fba8179`. The client provided the following explanation:
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | true | false | ## Low: Burn RedeemManager 's share first before calling its reportWithdraw endpoint
### Description
The current implementation of `_reportWithdrawToRedeemManager` calls RedeemManager's `reportWithdraw` and then burns the corresponding shares for the RedeemManager.
```solidity
// perform a report withdraw call to th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: The extra data (encoded stack ) provided to advanced orders to Seaport are not validated properly by the CollateralToken upon callback
### Description
## Severity: Critical Risk
## Context:
- `CollateralToken.sol#L125`
- `CollateralToken.sol#L145-L148`
- `CollateralToken.sol#L150-L152`
- `CollateralToken.sol... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [08] Lack of setter functions for third party integrations
### Description
Misdeployed values can cause failure of integrations. One addition that can be made is to add setter functions for the owner to update these addresses if necessary.
https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/Sa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Taker Can Confirm Cancelled RFQs
### Description
## Access Control Issue in Confirm Instruction
In the access control function for the Confirm instruction, it is not checking whether the RFQ is cancelled or not. This allows a taker to confirm a cancelled RFQ, which leads to the locking of funds for both the t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: Missing duplicate Incentive Logic can result in Incentive System accounting being broken
### Description
**Description:** `IncentiveManager::addIncentiveLogic` allows the owner to add a new Incentive Logic to the list of Incentive Systems:
Once added by the owner, an Incentive Logic can call `IncentiveMan... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.