prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Wrong computation of the amountToSellUnit variable
### Description
The variable `amountToSellUnits` is computed wrongly in the code which will lead to an incorrect amount of collateral to be sold.
### Impact
The contract will sell an incorrect amount of collateral during a peg-down recovery event.
### Recom... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missing error messages in require statements
### Description
Within [`Executor.sol`](https://github.com/matter-labs/zksync-2-dev/tree/534dc37c7b86753803a31b836f78896d18372e7e/contracts/ethereum/contracts/zksync/facets/Executor.sol) there are multiple `require` statements that lack error messages. For instance:... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Remaining Tokens Should Be Sent to `_swap.recevier()` Instead of `msg.sender` in `swapOneInch()` Function
### Description
When calling `swapOneInch()` we specify `swapData()` and `_forLiquidity()`. Inside `swapData()` we specify a `receiver` who will receive the tokens.
There is a case when if `_forLiquidity ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Config param sanity check for `_srcAddress` in LzApp setTrustedRemote.
### Description
**Description**
In contract LzApp.sol, in the function set Trusted Remote, there's no sanity check for the _srcAddress parameter. This can generate a wrong assignment even if the route can only be accessed by the owner of t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Compiled opcodes will return wrong values for PUSH instructions due to incorrect padding
### Description
When the compiler is run in `-f opcodes` or `-f opcodes_runtime` mode, it translates the final bytecode into opcodes. However, due to incorrect padding placed on `PUSH` values, the return values will be inc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Not Suitable CPRNG Used To Generate Salt
### Description
## Pontem Encryptor Class Security Issue
The **Pontem Encryptor** class uses the `crypto.getRandomValues` function to generate salt. This function is not guaranteed to run in a secure context and is not recommended for generating encryption keys.
## So... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: Chainlink Oracle Misconfiguration
### Description
Chainlink price feeds exhibit varying update frequencies, also known as 'heartbeats.' For instance, **USDC/USD** and **USDT/USD** price feeds have an update frequency of 24 hours (**86400** seconds), while **ETH/USD** updates every hour (**3600** seconds).
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: Array Length Gas Dos in Asset Management
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `6208764719f726142cb37aa2763d7bf1c3bb0841`. The client provided the following explanation:
> Fixed
**File(s) affected:**`src/DepositVault.sol`
**Description:** The `removeUnderlyingAsset` funct... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: CallRequestPreauthorization additional checks
### Description
`PreauthorizedCalls.preauthorizeCall()` accepts `CallRequestPreauthorization` as input.
Now only .maxCalls checked
Consider additionally checking that `lastCallTimestamp != 0` because it is an expected condition for further usage of `preauthorizedCa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: TroveManager does not work with non-18 decimal tokens
### Description
The `_redeemCollateralFromTrove()` function, used internally by `redeemCollateral()`, assumes all collateral tokens have 18 decimals, matching the debt token. However, when handling tokens with different precisions, incorrect calculations... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Inconsistency in maximum number of owners
### Description
## Multisig Wallet Owner Limitations
It was noticed that in the `create_multisig` instruction, the `u8` type is used for `max_owners`. This limits the number of maximum owners to **256** during wallet creation.
### Code Snippet
However, no such limi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | signature | false | false | ## Low: No deadline for user signatures
### Description
Signatures signed by users should always have an [expiration or timestamp deadline](https://dacian.me/signature-replay-attacks#heading-no-expiration), such that after that time the signature is no longer valid.
When users sign a transaction they should sign usin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Malicious user may frontrun `GoodDollarExpansionController::mintUBIFromReserveBalance()` to make protocol funds stuck
### Description
[GoodDollarExpansionController::mintUBIFromReserveBalance()](https://github.com/sherlock-audit/2024-10-mento-update/blob/main/mento-core/contracts/goodDollar/GoodDollarExpans... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | access-control | false | false | ## Low: Missing Two Step Ownership And Authority Transfer Validation
### Description
Both `change_admin_handler` and `change_liquidity_withdraw_authority_handler` directly reassign critical control fields (`off_ramp_state.admin` and `off_ramp_state.liquidity_withdraw_authority`) in a single transaction without requiri... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Missing slippage protection in `liquidity_lockbox::withdraw`
### Description
Vanilla example of missing slippage protection.
### Proof of Concept
As any AMM, Orca implements slippage protections by letting the caller specify the minimum amount of input and output tokens to be used in a given operation, so... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Don't call `_tickDistance` twice in `StrategyPassiveManagerUniswap::_setMainTick`
### Description
**Description:** `StrategyPassiveManagerUniswap::_setMainTick` calls `_tickDistance` twice even though there is no need since the exact same value will be returned; replace the second call with the `distance` vari... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Unrestricted Vault Creation in Factory Contract
### Description
The Factory.sol contract allows unrestricted vault creation, [contradicting the documented requirement for Liquidity Providers (LPs)](https://prodigyfi.gitbook.io/dual-investment/guides/vault-creation-guide/creating-a-vault). The createVault() fun... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: Rounding error in `WUSDA` can result in loss of user funds, especially when manipulated by an attacker
### Description
Due to floor rounding in Solidity, it is possible for rounding errors to affect functions in the `WUSDA` contract.
Specifically, when `WUSDA::_usdaToWUSDA` is invoked internally, if `_usdaAm... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Failure To Trigger Fee Increase
### Description
## Current Implementation of High Confidence Value Protection Logic
The current implementation of the `high_confidence_value_protection_activated` logic in the `add_liquidity` instruction has an inconsistency when handling scenarios with low base fees and high c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | true | false | ## Low: [03] First depositor attack is possible
### Description
After a vault is deployed, an attacker can call the following `Vault.deposit(uint256 assets, address to)` function to deposit 1 wei of the vault's underlying token. Afterwards, a staker also calls the `Vault.deposit(uint256 assets, address to)` function t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | false | false | ## Medium: `decode_legacy_tx` allows validation of signatures with `chain_id` that are larger than felt, and overflows
### Description
In `decode_legacy_tx`, `data_len` for `chain_id` is not constrained to be `31`, because current would have been shifted `2^(8\*32)` times, which overflows the max felt value of `2^252`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Incomplete Docstrings
### Description
Throughout the codebase, multiple instances of incomplete docstrings were identified:
* In `BTCDerivativeOracleBase.sol`, the `isRedeem` parameter of the [`getBTCDerivativeUSDAnchorPrice`](https://github.com/AladdinDAO/fx-protocol-contracts/blob/56a47eab8d10334e479df83a2b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | token | true | false | Source: https://github.com/sherlock-audit/2023-01-ajna-judging/issues/34
## Found by
ctf\_sec
## Summary
CryptoKitty and CryptoFighter NFT can be paused, which block borrowing / repaying / liquidating action in the ERC721Pool
## Vulnerability Detail
In the current implementation in the factory contract and the p... | Sherlock | 5 | Ajna |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unclaimable Reward Tokens
### Description
**Update**
Fixed in `201269dfd4bb3be75e27c8c1f22d87ad1bc2684e`. The client addressed this issue as recommended. There is a new function that requires the amount of rewards to claim: `claimRewards(uint256 amount)`.
**File(s) affected:**`contracts/Staking.sol`
**Descri... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | reentrancy | false | false | ## High: It is possible to create fake ERC1155 `NameWrapper` token for subdomain, which is not owned by `NameWrapper`
### Description
[NameWrapper.sol#L820-L821](https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/wrapper/NameWrapper.sol#L820-L821)
[NameWrapper.sol#L524](h... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: Missing Validations
### Description
## Findings
1. In `place_market_order` and `place_limit_order` within `orderbook`, there is an absence of validation for the price and size parameters, allowing these parameters to take on zero values, which is nonsensical, particularly in the context of a market order.
2.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | false | false | ## Low: Checks Effects Interactions Pattern Violation
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `6ddfe2d1015a91e2e8c48eef0f069e0c04af1a02`.
The OasisSwap team revised the code to align with Check-Effect-Interact pattern.
**File(s) affected:**`OasisSwapPair.sol`
**Description:** The [... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: During oracle outages or feeder outages/disagreement, the `ParaSpaceFallbackOracle` is not used
### Description
If the feeders haven't updated their prices within the default six-hour time window, the floor oracle will revert when requests are made to get the current price, and these reverts are not caught ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: Rounding Error
### Description
## Compute Fee Earned
`compute_fee_earned` calculates the earned fee for a user based on their balance and specific fee per share values. The current implementation utilizes `fixed_mul_ceil` for multiplying the fee difference by the user’s balance. The ceil rounding method roun... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: If the borrower enters token blacklist, LP may never be able to retrieve Liquidity
### Description
Currently, there are two ways to retrieve `Liquidity`
1. `borrower` actively close position : call `closePosition()`
2. be forced liquidation leads to close position : `liquidatePosition()` -> `_closePosit... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: Token Wrapped Creation Code Is Not Deterministic
### Description
The creation code for the smart contract `TokenWrapped` will change when using a new compiler or modifying any metadata associated with the contract. The variable `type(TokenWrapped).creationCode` is used to deterministically calculate the add... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Vesting Could Transfer Tokens to the Original Gnosis Safe
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> The entities will have separate safe addresses on mainnet
**Update**
Marked as "Acknowledged" by the client. The client provided the f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Zero amount.
### Description
**Description**
TokensFarm Factory.sol, function withdraw TokenslfStuck On Farm, _fundInternalFarm
In this functions you have that requirement.
require(
);
_amount $>=0$
"Amount must be over or equal to 0"
But after that, there are calls for approval and transfer. It turns ou... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: User is unable to claim their reward for the expanded epochs if farm is expanded
### Description
[/contracts/farm-manager/src/manager/commands.rs# L240-L243](https://github.com/code-423n4/2024-11-mantra-dex/blob/main/contracts/farm-manager/src/manager/commands.rs# L240-L243)
### Finding description and Imp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Due to excessive HTP check moveQuoteToken can be unavailable for big deposits
### Description
moveQuoteToken() will revert if deposit removal causes LUP to be less than HTP, while the whole operation being the *removal and addition* to another index, so the check structured this way is excessive and prohibi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Replay Attack | false | false | Source: https://github.com/sherlock-audit/2022-09-harpie-judging/tree/main/004-M
## Found by
minhquanym, JohnSmith, IllIllI
## Summary
Mistakes made on one chain can be re-applied to a new chain
## Vulnerability Detail
There is no `chain.id` in the signed data
## Impact
If a user does a `changeRecipientAddress()`... | Sherlock | 5 | Harpie |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: [FIXED] Redundant asserts in `AllowedRecipientsBuilder`
### Description
In the function [`deployAllowedTokensRegistry`](https://github.com/lidofinance/easy-track/blob/425f4a254ceb2be389f669580b9dc76618e92756/contracts/AllowedRecipientsBuilder.sol#L219-L220) of the `AllowedRecipientsBuilder` contract the follow... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | false | ## Low: Panicking checked arithmetic may prevent deposits and withdraws to rebalance pool
### Description
The rebalance pool’s deposit and withdraw functionality computes the latest balance of a user’s account at each interaction. This calculation strictly assumes that the `_newBalance` amount is less than the old, bu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Do not repeat `if` checks in `_constructContract()`
### Description
**File:** `ContractDeployer.sol`
Function `_constructContract()` performs the same conditional `if` check twice. This is a waste of gas:
[File: code/system-contracts/contracts/ContractDeployer.sol](https://github.com/code-423n4/2024-03-zksyn... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Hardcoding deadline for `permit()` will mess up the `structHash` leading to an invalid signature
### Description
**Description:** Functions allowing users to grant ERC20 approvals via Permit incorrectly hardcode the deadline passed to permit().
The problem is that the recovered signature will be invalid be... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: PegStabilityModule should change sanity checks from >to >=
### Description
`toUnderlyingFeeBPS` and `toSynthFeeBPS` must be `< BPS_SCALE` otherwise `quoteToUnderlying-GivenOut` and `quoteToSynthGivenOut` will revert because of division by zero. Also, when they are equal to `BPS_SCALE`, the user would get nothi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Fund Lock | true | false | **Description:**
The Vault sets the LayerZero fee refund address to itself:
```solidity
/// @notice Report snapshot of the vault to the controller.
function reportSnapshot() public onlyBridge {
MozBridge.Snapshot memory _snapshot = _takeSnapshot();
MozBridge(mozBridge).repo... | Trust Security | 3 | Mozaic Archimedes |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | true | false | ## Low: The visibility for constructor is ignored
### Description
**[m19 (Mimo DeFi) commented](https://github.com/code-423n4/2022-04-mimo-findings/issues/153#issuecomment-1120354471):**
> Very clear and well structured QA report
**[gzeoneth (judge) commented](https://github.com/code-423n4/2022-04-mimo-findings/issu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Bootloader Uses Incorrect Value for System Contract Upgrade Log Key
### Description
The [`SystemLogKey` enum](https://github.com/matter-labs/era-contracts/blob/abcbaf390a30c09eb53ae83d84bebab95a8003f7/l1-contracts/contracts/zksync/interfaces/IExecutor.sol#L8-L19) is employed by the L2 system contracts to di... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Signature Malleability
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> Since the signature is not included in the quote's digest, processes should use the quote's digest as a unique identifier
**File(s) affected:**`SignatureSafeguard.sol`
*... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | other | false | true |
[contracts/lib/ConsiderationEncoder.sol#L569-L574](https://github.com/ProjectOpenSea/seaport/blob/5de7302bc773d9821ba4759e47fc981680911ea0/contracts/lib/ConsiderationEncoder.sol#L569-L574)
The order hashes are incorrectly encoded during the `_encodeOrderHashes` mechanism, causing functions such as `_encodeRatifyOrder... | Code4rena | 5 | OpenSea |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Wrong `avgDepositPrice` calculated
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
In Contract VaultETH_V2, the method Request_BuyETH(...) allows users to buy ETH using ZeUSD tokens.
In the method, the epoch’s average deposit price is calculated as follows:
`tempEpochInfo.avgD... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Redundant condition check
### Description
The `_scaleToSpotDecimals()` function in `HyperliquidEscrow` contains a redundant condition check for decimal scaling between perpetual and spot markets. The function checks if `USDC_PERP_DECIMALS > USDC_SPOT_DECIMALS`, but this condition will never be true since `USDC... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: fallback Function Could Potentially Cause Unintended Side-Effects
### Description
The _addModule() function will add any function signature, even if it is not present on a module contract. If a module contract is added which contains a fallback function, that is what will be called when the nonexistent functio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Missing Event Emission
### Description
**Severity**: Low
**Status**: Resolved
**Description**
functions in the SymbiosisMiddleware contract do not emit events to log state changes. This omission reduces the transparency and traceability of these operations, which can hinder off-chain monitoring.
**Recommen... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Failed Token Transfers Will DoS Withdrawals
### Description
As the withdrawal requests are processed in the queue, it is possible that a single withdrawal in the queue gets stuck, preventing all other requests from processing. The token transfer can fail for several reasons. If this happens, all requests th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: You can grief migrations by sending SCX to the UniswapHelper
### Description
_Submitted by camden, also found by robee_
The attack here allows the attacker to prevent migrations.
The attack here is recoverable because we can just call `buyFlanAndBurn` (f it worked as expected) with SCX as the input token ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | integer-overflow | true | false | ## Low: Accumulation of dust amounts due to rounding in `_tokenDistribution()`
### Description
`_tokenDistribution()` computes each share independently with integer division:
```solidity
function _tokenDistribution(uint256 amount) internal view returns (uint256, uint256, uint256) {
uint256 beneficiaryAmount = (am... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: COMMENTED TRANSACTION MESSAGE
### Description
The `claim_rewards` function in the **krp-market-contracts/market** contract could be called by any user in order to get back the rewards generated by their deposits. Currently, this operation will not work since the message which contains the information on the tr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | true | false | ## Medium: The user is enforced to overpay for the `fallback` gas when calling `retryDeposit`
### Description
`BranchBridgeAgent.retryDeposit` is used to top up a previous deposit and perform a call afterward. The modifier `requiresFallbackGas` is added to the method to verify that enough gas is deposited to pay for a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [04] ERRONEOUS NATSPEC COMMENTS SHOULD BE CORRECTED
### Description
@param px_final The final price at the `y axis`
Above comment should be corrected as follows:
@param px_final The final price at the `x axis`
https://github.com/code-423n4/2023-08-shell/blob/main/src/proteus/EvolvingProteus.sol#L240
Th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Multiple flaws in the gate reset logic in `Gatekeeper`
### Description
**Impact:**
Medium, as no value will be lost but the contract state will be incorrect
**Likelihood:**
Medium, as it is not expected to happen every time, but there are multiple attack paths here
**Description**
The `resetAllGates` met... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | other | true | false | ## Medium: Referral discount is not applied when `fees_prepayment` is zero in `PerpEngine::fill`
### Description
In `PerpEngine::fill`, when `fees_prepayment` is zero we do not apply the referral discount even though we still send `ref_payment` to `ref_address`.
```rust
if *fees_prepayment == 0 {
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | false | ## Low: Reducing allocation after partial claim can brick user accounts
### Description
In the UsualSP contract, the `allocate()` function allows the UsualSP operator to update existing allocations for recipients. However, reducing an allocation after a user has partially claimed their tokens can lead to accounting is... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: (HAL-04) LACK OF RESOURCES AND RATE LIMITING
### Description
API requests consume resources such as network, CPU, memory, storage, and budget. This vulnerability occurs when too many requests arrive simultaneously, and the API does not have enough compute resources to handle those requests or increases the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Funding values not updated before calling withdrawFundingFeeSurplus()
### Description
In `withdrawFundingFeeSurplus()`, a calculation of the surplus funding fee is done, which depends on each market's `accumFundingLong` and `accumFundingShort` values. These values change every second (based on funding rate vel... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: `VE3DRewardPool` and `VE3DLocker` adds to an unbounded array which may potentially lock all rewards in the contract
### Description
_Submitted by kirk-baird, also found by csanuragjain, Dravee, gzeon, IllIllI, Koustre, Ruhum, unforgiven, VAD37, and xiaoming90_
### Impact
The function `addReward()` allows... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | oracle | true | false | ## High Risk Vulnerability Report
## Severity
**High Risk**
## Context
**File:** PoolKeeper.sol
**Line:** L73
## Description
When a pool is deployed, the initial `executionPrice` is calculated as `firstPrice * 1e18`, where `firstPrice` is retrieved using the `ILeveragedPool(_poolAddress).getOraclePrice()`:
```sol... | Spearbit | 5 | Tracer |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Snapshot taken after expiration time should reset cum_size to zero
### Description
A snapshot is taken if one of two conditions is met:
- No action was received within 10 seconds (MAX_WAIT timeout), or
- The accumulated size of executed payloads (named `cap_size`) is greater than the `MAX_PAYLOADS_SIZE`.
Wh... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Decrease position's `updateTradeSuccess` will use wrong `availableCollateralInDiamond`
### Description
Inside the Decrease Position's `updateTradeSuccess`, the closing fee is deducted from the user. However, it is not considered when providing `_values.availableCollateralInDiamond` to the `handleTradeValueTra... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Mismatch between interface and contract
### Description
The [`removeBroker` function](https://github.com/mcdexio/mai-fund-protocol/blob/98af0d1d7e9872ba2b5e734e2a43c161ef635608/contracts/interface/IGlobalConfig.sol#L11) in the [`IGlobalConfig` interface](https://github.com/mcdexio/mai-fund-protocol/blob/98af0d... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | reentrancy | true | false | ## Low: Calling `StakingVault::notifyRewardAmount` on empty vault leaves ILV stuck
### Description
`StakingVault::notifyRewardAmount` is the vault’s reward hook that updates the rewards-per-share accumulator (`accIlvPerShare`) so stakers can later claim ILV. It is called by [`L2RevenueDistributorV3::_applyAllocation`]... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: TRST-M-8 Calculation of the new emissions amount is not 75%/25%/5%
### Description
**Description:**
The calculations of the emissions directed to SatinVoter.sol, VeDist.sol, and the treasury are
done on top of the weekly emissions instead as part of it, resulting in a different percentage
distribution. Th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Incorrect comment at Smart contract UnmarshalToken
### Description
**Description**
Comment states that `MAX_CAP` is equal to 125mln instead of 100mln.
**Snippet**:
uint256 public constant MAX_CAP = 100 * (10**6) * (10**18); // 125 million
**Recommendation**:
Remove comment or change it to point to the cor... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: Trade instructions do not require a dtf_pogram_signer account
### Description
The Solana implementation uses a `dtf_program_signer` account (figure 6.1) to prove that the dtfs program is calling the folio program. However, none of the trade instructions require this account. An attacker could call folio progr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Votes for cancelled protocols are lost
### Description
- https://github.com/yearn/yETH-bootstrap/blob/2dd219d3af49952275934638e8c9d50d0fef0d8f/contracts/Bootstrap.vy#L453
If the management calls `undo_whitelist()` for a protocol in `Bootstrap.vy` that users have already voted for, these users will not be a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Veto renouncing in the original DAO or rage quit blocking in a forked DAO as a result of any future proposals will open up the way for 51% attacks
### Description
It is possible to renounce veto power in V1, V2, and V3 versions of the protocol or upgrade forked V1 to block or remove rage quit. While it is a pa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Finalize-window vote-changing vulnerability: auto-voters can alter choices post-epoch to manipulate results
### Description
Missing freeze or snapshot of auto-vote choices at epoch end allows attackers to manipulate the voting process. Since auto-voters can enable or change their option after the epoch has en... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Inadequate validation of UTF-8 encoding in character length calculation
### Description
The `strlen` function in the **StringUtils** library relies on `_charLength` to determine the byte length of each character. However, `_charLength` does not adequately validate whether the bytes conform to the UTF-8 standar... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Inconsistent decimal treatment for token amounts across codebase increases security risks for users interacting with Dexe DAO contracts
### Description
**Description:** Inconsistencies have been identified within the codebase regarding the assumed decimal format for token amounts. Some sections of the codeb... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: Anyone can pass any proposal alone before first `VOTES` are minted
### Description
_Submitted by Bahurum, also found by bin2chen and cryptphi_
Before any `VOTES` are minted anyone can activate and execute an arbitrary proposal even with 0 votes cast. So an attacker can pass any proposal (i.e. change the `ex... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: In the event of yield loss, yield will be double counted leading to excess fees
### Description
**Details**
[StUsdc.sol#L171-L181](https://github.com/stakeup-protocol/stakeup-contracts/blob/b4d8a83e9455efb8c7543a0fc62b5aea598c7f49/src/token/StUsdc.sol#L171-L181)
if (newUsdPerShare > lastUsdPerShare) {
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Not synced with Epochs
### Description
If there's enough delays in calling the `notifyRewardAmount()` function, a full desync can happen.
### Recommendation
It may be ideal to queue rewards to the next epoch to avoid any form of grief/race condition. That said, this may create negative externalities. So perha... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Contracts used as dependencies do not track upstream changes Difficulty: Low
### Description
BokkyPooBahsDateTimeLibrary and several OpenZeppelin contracts have been copied and pasted into the repositories under review. The code documentation does not specify the exact revision that was made or whether it was mo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: Positions cannot be liquidated once the oracle prices are zero
### Description
In the unlikely event that the price of an asset reaches zero, there is no way to liquidate the position, because both usages of oracles will revert.
### Impact
Positions won't be liquidatable, at an extremely critical moment th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Players may not get paid if liquidity is less than winnings
### Description
When `flip()` is called, the function checks whether there is available liquidity to pay the potential winnings of a game:
```
// require staked amount > maximum payout using calculatePayout
(uint256 grossPayout, uint256 netPay... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: `_lend()`: Copying in memory can be more expensive than using the `storage` keyword
### Description
In this function, I suggest replacing `TokenLoan memory loan = tokenLoan[tokenId];` with `TokenLoan storage loan = tokenLoan[tokenId];`. Only 2 SLOADs are made (`loan.status` and `loan.borrower`) and the functio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Partial liquidations are not possible
### Description
Due to an incorrect implementation of `VaultValuation.getLiquidationFactors()`, Notional requires that a liquidator reduces an account's debt below `minBorrowSize`. This does not allow liquidators to partially liquidate a vault account into a healthy posit... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: Possible Reentrancy Attacks
### Description
**Update**
The client implemented the checks-effects-interaction pattern in all the listed functions. One inconsistency remains in the `remove()` function.
**Update**
In the second fix review, the client has implemented the CEI pattern in the `remove()` function... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | initialization | true | false | ## Gas: Don't initialize to default values
### Description
**Description:** Don't initialize to default values:
**Bima:**
Fixed in commit [3639347](https://github.com/Bima-Labs/bima-v1-core/commit/3639347f7d7808f1ca1e37d90b398bb1b68bfd34).
**Cyfrin:** Verified. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | false | false | ## Medium: `rejectDepositor` can be front-run
### Description
`rejectDepositor` can be front-run by the `buyer`, so the `seller` tx will revert: https://github.com/MetaLex-Tech/LeXscrow/blob/94ca277528bb25b8421dc127941c18915144eb29/src/TokenLexscrow.sol#L455-L473, https://github.com/MetaLex-Tech/LeXscrow/blob/94ca2775... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [11] Slippage of stETH swap could make `validateOffer()` revert
### Description
The `MultiSourceLoan` contract calls the `validateOffer()` function to verify that the loan term has been approved by the Pool contract. This function also draws the necessary capital from the base interest allocator to ensure a su... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | false | ## Low: Potential underflow when withdrawing from strategies
### Description
When a withdrawal needs to withdraw from a strategy, a `withdrawAmount` is computed and the strategy's allocated amount is reduced by it:
```solidity
uint256 underlyingBalance = strategy.maxWithdraw(address(this));
uint256 desiredAssets = _a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | true | false | ## Low: Missing Explicit Zero-Value Checks for G2 Public Key and G1 Signature
### Description
**Description:** The BLS12381 verification logic explicitly rejects a zero G1 public key, but does not explicitly reject
1) a zero G2 public key, or
2) a zero G1 signature.
While these cases are not exploitable in practice ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Wrong collateral refund in liquidation when `liqPrice == priceAfterImpact`
### Description
When a liquidation is triggered and the Oracle price used results in `liqPrice == priceAfterImpact` during the execution of `executeAutomationCloseOrderCallback()`, the system may incorrectly refund a portion of the u... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | overflow | true | false | ## High: Checkpoints are almost always outdated due to missing `_update` override
### Description
Strategy tokens are used as collateral token in Morpho Blue markets. It's crucial to update checkpoints in case of transfers because checkpoints are always handled with `msg.sender`. Currently, `_update` function is not o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Key State Changes Are Missing Events
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `0ab860ad36245964c06a9dd7f8ed75f9619246f4`, `5076f137e6bc0a446c2df7a8f5f190da9815cf64`.
**File(s) affected:**`naym-coin/LibACL.sol, contracts-v3/LibAdmin.sol, contracts-v3/LibFeeRouter.sol`
**Descri... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Inability to batch router operations involving native funds
### Description
Severity: Low Risk
Context: RouterCommon.sol#L157, Router.sol#L107-L108, Router.sol#L307-L308, Router.sol#L611-L614
Description: Multiple native operations cannot be batched because excess ETH is forcibly refunded at the end of
each op... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | initialization | true | false | ## Gas: `address(this)` should be cached
### Description
Caching saves gas when compared to repeating the calculation at each point it is used in the contract.
[321](https://github.com/code-423n4/2024-05-loop/blob/0dc8467ccff27230e7c0530b619524cc8401e22a/./src/PrelaunchPoints.sol#L321-L321), [503](https://github.com... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: `masterCreditAccount` remains uninitialized
### Description
`masterCreditAccount` remains uninitialized, so anybody can initialize it:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/core/AccountFactory.sol#L90
### Recommendation
We recommend to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: [02]
### Description
Better to have also `approveEmergencyDiamondCutAsSecurityCouncilMemberBySignature`, in case the security council members do not have access to ethereum blockchain or in case it is needed to approve just in one transaction by batch of signatures (to bypass the notice period). | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | true | false | ## Low: Missing `receive` function to reject direct ETH transfers in messager contracts
### Description
The messager contracts (`MTokenMessager`, `MTokenMessagerLZ`, `MTokenMessagerV2`) are designed to receive the bridging fee in native token but none of them implemented a `receive()` function to handle direct ETH tra... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: `onERC721Received` missing blocks safe NFT transfers and mints
### Description
_Resolved_
The `SpinLottery` contract requires NFTs to be transferred or minted to it to be used as prizes, as verified by the ownership check.
However, the contract lacks the `onERC721Received` implementation required by safe fu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: OETH Strategy Broken as Rebasing Not Enabled
### Description
The Yield Strategy using Origin ETH is not functioning as intended due to a design flaw. It utilizes Origin ETH with rebasing turned off. Since rebasing is required to receive ETH yield rewards, the strategy fails to generate yield. The Notional P... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: User will lose funds
### Description
Report type: Smart Contract
Target: https://etherscan.io/address/0xd9a442856c234a39a81a089c06451ebaa4306a72
Impacts:
- Direct theft of any user funds, whether at-rest or in-motion, other than unclaimed yield
## Description
## Brief/Intro
In case of slashing, Lido `cl... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.