id
int64
599M
3.26B
title
stringlengths
1
290
body
stringlengths
0
228k
state
stringclasses
2 values
number
int64
1
7.7k
comments
listlengths
0
30
locked
bool
1 class
created_at
stringdate
2020-04-14 10:18:02
2025-07-24 19:46:28
updated_at
stringdate
2020-04-27 16:04:17
2025-07-25 11:56:51
author_association
stringclasses
4 values
user_login
stringlengths
3
26
user_id
int64
3.5k
219M
user_type
stringclasses
1 value
labels
stringclasses
81 values
reactions
stringlengths
191
197
url
stringlengths
58
61
html_url
stringlengths
46
51
pull_request
stringlengths
289
315
is_pull_request
bool
2 classes
684,825,612
use ragged tensor by default
I think it's better if it's clear whether the returned tensor is ragged or not when the type is set to tensorflow. Previously it was a tensor (not ragged) if numpy could stack the output (which can change depending on the batch of example you take), which make things difficult to handle, as it may sometimes return a r...
closed
530
[ "Yes I agree. Maybe something that lets specify different format depending on the column ? Especially to better control dtype and shape (and ragged for tf)\r\n\r\nOh and I forgot: this one should also fix the second issue found in #477 for the next release", "I am running into the same issue with the error messag...
false
2020-08-24 17:06:15
2021-10-22 19:38:40
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/530/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/530
https://github.com/huggingface/datasets/pull/530
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/530", "html_url": "https://github.com/huggingface/datasets/pull/530", "diff_url": "https://github.com/huggingface/datasets/pull/530.diff", "patch_url": "https://github.com/huggingface/datasets/pull/530.patch", "merged_at": "2020-08-24T19:22:25Z"}
true
684,797,157
Add MLSUM
Hello (again :) !), So, I started a new branch because of a [rebase issue](https://github.com/huggingface/nlp/pull/463), sorry for the mess. However, the command `pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_real_dataset_mlsum` still fails because there is no default language dataset : the s...
closed
529
[ "Could you test to run the test using the changes in #527 and let me know if it fixes the issue ? If so I'll merge it and we'll be good to go :)", "Hello, it does work on the fixing real dataset branch. Merci Quentin :)", "Nice, glad to hear that :)\r\nde rien !" ]
false
2020-08-24 16:18:35
2020-08-26 08:04:11
CONTRIBUTOR
RachelKer
36,986,299
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/529/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/529
https://github.com/huggingface/datasets/pull/529
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/529", "html_url": "https://github.com/huggingface/datasets/pull/529", "diff_url": "https://github.com/huggingface/datasets/pull/529.diff", "patch_url": "https://github.com/huggingface/datasets/pull/529.patch", "merged_at": "2020-08-26T08:04:10Z"}
true
684,673,673
fix missing variable names in docs
fix #524
closed
528
[ "The problem came from `default: ` that is rendered differently and hides the parameter names. I changed `default: ...` to `defaults to ...`" ]
false
2020-08-24 13:31:48
2020-08-25 09:04:04
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/528/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/528
https://github.com/huggingface/datasets/pull/528
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/528", "html_url": "https://github.com/huggingface/datasets/pull/528", "diff_url": "https://github.com/huggingface/datasets/pull/528.diff", "patch_url": "https://github.com/huggingface/datasets/pull/528.patch", "merged_at": "2020-08-25T09:04:03Z"}
true
684,632,930
Fix config used for slow test on real dataset
As noticed in #470, #474, #476, #504 , the slow test `test_load_real_dataset` couldn't run on datasets that require config parameters. To fix that I replaced it with one test with the first config of BUILDER_CONFIGS `test_load_real_dataset`, and another test that runs all of the configs in BUILDER_CONFIGS `test_load...
closed
527
[]
false
2020-08-24 12:39:34
2020-08-25 09:20:45
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/527/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/527
https://github.com/huggingface/datasets/pull/527
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/527", "html_url": "https://github.com/huggingface/datasets/pull/527", "diff_url": "https://github.com/huggingface/datasets/pull/527.diff", "patch_url": "https://github.com/huggingface/datasets/pull/527.patch", "merged_at": "2020-08-25T09:20:44Z"}
true
684,615,455
Returning None instead of "python" if dataset is unformatted
Following the discussion on Slack, this small fix ensures that calling `dataset.set_format(type=dataset.format["type"])` works properly. Slightly breaking as calling `dataset.format` when the dataset is unformatted will return `None` instead of `python`.
closed
526
[ "We have to change the tests to expect `None` instead of `python` then", "Merging!" ]
false
2020-08-24 12:10:35
2020-08-24 12:50:43
CONTRIBUTOR
TevenLeScao
26,709,476
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/526/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/526
https://github.com/huggingface/datasets/pull/526
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/526", "html_url": "https://github.com/huggingface/datasets/pull/526", "diff_url": "https://github.com/huggingface/datasets/pull/526.diff", "patch_url": "https://github.com/huggingface/datasets/pull/526.patch", "merged_at": "2020-08-24T12:50:42Z"}
true
683,875,483
wmt download speed example
Continuing from the slack 1.0 roadmap thread w @lhoestq , I realized the slow downloads is only a thing sometimes. Here are a few examples, I suspect there are multiple issues. All commands were run from the same gcp us-central-1f machine. ``` import nlp nlp.load_dataset('wmt16', 'de-en') ``` Downloads at 49.1 K...
closed
525
[ "Thanks for creating the issue :)\r\nThe download link for wmt-en-de raw looks like a mirror. We should use that instead of the current url.\r\nIs this mirror official ?\r\n\r\nAlso it looks like for `ro-en` it tried to download other languages. If we manage to only download the one that is asked it'd be cool\r\n\r...
false
2020-08-21 23:29:06
2022-10-04 17:45:39
CONTRIBUTOR
sshleifer
6,045,025
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/525/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/525
https://github.com/huggingface/datasets/issues/525
null
false
683,686,359
Some docs are missing parameter names
See https://huggingface.co/nlp/master/package_reference/main_classes.html#nlp.Dataset.map. I believe this is because the parameter names are enclosed in backticks in the docstrings, maybe it's an old docstring format that doesn't work with the current Sphinx version.
closed
524
[ "Indeed, good catch!" ]
false
2020-08-21 16:47:34
2020-08-25 09:04:03
CONTRIBUTOR
jarednielsen
4,564,897
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/524/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/524
https://github.com/huggingface/datasets/issues/524
null
false
682,573,232
Speed up Tokenization by optimizing cast_to_python_objects
I changed how `cast_to_python_objects` works to make it faster. It is used to cast numpy/pytorch/tensorflow/pandas objects to python lists, and it works recursively. To avoid iterating over possibly long lists, it first checks if the first element that is not None has to be casted. If the first element needs to be...
closed
523
[ "I took your comments into account and added tests for `cast_to_python_objects`" ]
false
2020-08-20 09:42:02
2020-08-24 08:54:15
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/523/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/523
https://github.com/huggingface/datasets/pull/523
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/523", "html_url": "https://github.com/huggingface/datasets/pull/523", "diff_url": "https://github.com/huggingface/datasets/pull/523.diff", "patch_url": "https://github.com/huggingface/datasets/pull/523.patch", "merged_at": "2020-08-24T08:54:14Z"}
true
682,478,833
dictionnary typo in docs
Many places dictionary is spelled dictionnary, not sure if its on purpose or not. Fixed in this pr: https://github.com/huggingface/nlp/pull/521
closed
522
[ "Thanks!" ]
false
2020-08-20 07:11:05
2020-08-20 07:52:14
CONTRIBUTOR
yonigottesman
4,004,127
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/522/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/522
https://github.com/huggingface/datasets/issues/522
null
false
682,477,648
Fix dictionnary (dictionary) typo
This error happens many times I'm thinking maybe its spelled like this on purpose?
closed
521
[ "Hahah thanks Yonatan. It was not on purpose, we are just not very good at spelling :)" ]
false
2020-08-20 07:09:02
2020-08-20 07:52:04
CONTRIBUTOR
yonigottesman
4,004,127
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/521/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/521
https://github.com/huggingface/datasets/pull/521
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/521", "html_url": "https://github.com/huggingface/datasets/pull/521", "diff_url": "https://github.com/huggingface/datasets/pull/521.diff", "patch_url": "https://github.com/huggingface/datasets/pull/521.patch", "merged_at": "2020-08-20T07:52:04Z"}
true
682,264,839
Transform references for sacrebleu
Currently it is impossible to use sacrebleu when len(predictions) != the number of references per prediction (very uncommon), due to a strange format expected by sacrebleu. If one passes in the data to `nlp.metric.compute()` in sacrebleu format, `nlp` throws an error due to mismatching lengths between predictions and r...
closed
520
[ "I think I agree @lhoestq so I pushed a change.\r\nThanks for your work on the library!" ]
false
2020-08-20 00:26:55
2020-08-20 09:30:54
CONTRIBUTOR
jbragg
2,238,344
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/520/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/520
https://github.com/huggingface/datasets/pull/520
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/520", "html_url": "https://github.com/huggingface/datasets/pull/520", "diff_url": "https://github.com/huggingface/datasets/pull/520.diff", "patch_url": "https://github.com/huggingface/datasets/pull/520.patch", "merged_at": "2020-08-20T09:30:53Z"}
true
682,193,882
[BUG] Metrics throwing new error on master since 0.4.0
The following error occurs when passing in references of type `List[List[str]]` to metrics like bleu. Wasn't happening on 0.4.0 but happening now on master. ``` File "/usr/local/lib/python3.7/site-packages/nlp/metric.py", line 226, in compute self.add_batch(predictions=predictions, references=references) ...
closed
519
[ "Update - maybe this is only failing on bleu because I was not tokenizing inputs to the metric", "Closing - seems to be just forgetting to tokenize. And found the helpful discussion in huggingface/evaluate#105 " ]
false
2020-08-19 21:29:15
2022-06-02 16:41:01
CONTRIBUTOR
jbragg
2,238,344
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/519/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/519
https://github.com/huggingface/datasets/issues/519
null
false
682,131,165
[METRICS, breaking] Refactor caching behavior, pickle/cloudpickle metrics and dataset, add tests on metrics
Move the acquisition of the filelock at a later stage during metrics processing so it can be pickled/cloudpickled after instantiation. Also add some tests on pickling, concurrent but separate metric instances and concurrent and distributed metric instances. Changes significantly the caching behavior for the metri...
closed
518
[ "(test failure is unrelated)", "As discussed with @thomwolf merging since the hyperparameter-search has been merged in transformers." ]
false
2020-08-19 19:43:08
2020-08-24 16:01:40
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/518/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/518
https://github.com/huggingface/datasets/pull/518
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/518", "html_url": "https://github.com/huggingface/datasets/pull/518", "diff_url": "https://github.com/huggingface/datasets/pull/518.diff", "patch_url": "https://github.com/huggingface/datasets/pull/518.patch", "merged_at": "2020-08-24T16:01:39Z"}
true
681,896,944
add MLDoc dataset
Hi, I am recommending that someone add MLDoc, a multilingual news topic classification dataset. - Here's a link to the Github: https://github.com/facebookresearch/MLDoc - and the paper: http://www.lrec-conf.org/proceedings/lrec2018/pdf/658.pdf Looks like the dataset contains news stories in multiple languages...
open
517
[ "Any updates on this?", "This request is still an open issue waiting to be addressed by any community member, @GuillemGSubies." ]
false
2020-08-19 14:41:59
2021-08-03 05:59:33
CONTRIBUTOR
jxmorris12
13,238,952
User
[{"id": 2067376369, "node_id": "MDU6TGFiZWwyMDY3Mzc2MzY5", "url": "https://api.github.com/repos/huggingface/datasets/labels/dataset%20request", "name": "dataset request", "color": "e99695", "default": false, "description": "Requesting to add a new dataset"}]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/517/reactions", "total_count": 4, "+1": 4, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/517
https://github.com/huggingface/datasets/issues/517
null
false
681,846,032
[Breaking] Rename formated to formatted
`formated` is not correct but `formatted` is
closed
516
[]
false
2020-08-19 13:35:23
2020-08-20 08:41:17
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/516/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/516
https://github.com/huggingface/datasets/pull/516
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/516", "html_url": "https://github.com/huggingface/datasets/pull/516", "diff_url": "https://github.com/huggingface/datasets/pull/516.diff", "patch_url": "https://github.com/huggingface/datasets/pull/516.patch", "merged_at": "2020-08-20T08:41:16Z"}
true
681,845,619
Fix batched map for formatted dataset
If you had a dataset formatted as numpy for example, and tried to do a batched map, then it would crash because one of the elements from the inputs was missing for unchanged columns (ex: batch of length 999 instead of 1000). The happened during the creation of the `pa.Table`, since columns had different lengths.
closed
515
[]
false
2020-08-19 13:34:50
2020-08-20 20:30:43
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/515/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/515
https://github.com/huggingface/datasets/pull/515
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/515", "html_url": "https://github.com/huggingface/datasets/pull/515", "diff_url": "https://github.com/huggingface/datasets/pull/515.diff", "patch_url": "https://github.com/huggingface/datasets/pull/515.patch", "merged_at": "2020-08-20T20:30:42Z"}
true
681,256,348
dataset.shuffle(keep_in_memory=True) is never allowed
As of commit ef4aac2, the usage of the parameter `keep_in_memory=True` is never possible: `dataset.select(keep_in_memory=True)` The commit added the lines ```python # lines 994-996 in src/nlp/arrow_dataset.py assert ( not keep_in_memory or cache_file_name is None ), "Please use either...
closed
514
[ "This seems to be fixed in #513 for the filter function, replacing `cache_file_name` with `indices_cache_file_name` in the assert. Although not for the `map()` function @thomwolf ", "Maybe I'm a bit tired but I fail to see the issue here.\r\n\r\nSince `cache_file_name` is `None` by default, if you set `keep_in_me...
false
2020-08-18 18:47:40
2022-10-10 12:21:58
CONTRIBUTOR
vegarab
24,683,907
User
[{"id": 1935892877, "node_id": "MDU6TGFiZWwxOTM1ODkyODc3", "url": "https://api.github.com/repos/huggingface/datasets/labels/good%20first%20issue", "name": "good first issue", "color": "7057ff", "default": true, "description": "Good for newcomers"}, {"id": 4614514401, "node_id": "LA_kwDODunzps8AAAABEwvm4Q", "url": "http...
{"url": "https://api.github.com/repos/huggingface/datasets/issues/514/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/514
https://github.com/huggingface/datasets/issues/514
null
false
681,215,612
[speedup] Use indices mappings instead of deepcopy for all the samples reordering methods
Use an indices mapping instead of rewriting the dataset for all the samples re-ordering/selection methods (`select`, `sort`, `shuffle`, `shard`, `train_test_split`). Added a `flatten_indices` method which copy the dataset to a new table to remove the indices mapping with tests. All the samples re-ordering/selecti...
closed
513
[ "Ok I fixed `concatenate_datasets` and added tests\r\nFeel free to merge if it's good for you @thomwolf ", "Ok, adding some benchmarks for map/filters and then I'll merge", "Warning from pytorch that we should maybe consider at some point @lhoestq:\r\n```\r\n/__w/nlp/nlp/src/nlp/arrow_dataset.py:648: UserWarnin...
false
2020-08-18 17:36:02
2020-08-28 08:41:51
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/513/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 1, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/513
https://github.com/huggingface/datasets/pull/513
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/513", "html_url": "https://github.com/huggingface/datasets/pull/513", "diff_url": "https://github.com/huggingface/datasets/pull/513.diff", "patch_url": "https://github.com/huggingface/datasets/pull/513.patch", "merged_at": "2020-08-28T08:41:50Z"}
true
681,137,164
Delete CONTRIBUTING.md
closed
512
[ "😱", "Yeah, this is spammy behavior. I've reported the user handle." ]
false
2020-08-18 15:33:25
2020-08-18 15:48:21
NONE
ChenZehong13
56,394,989
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/512/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/512
https://github.com/huggingface/datasets/pull/512
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/512", "html_url": "https://github.com/huggingface/datasets/pull/512", "diff_url": "https://github.com/huggingface/datasets/pull/512.diff", "patch_url": "https://github.com/huggingface/datasets/pull/512.patch", "merged_at": null}
true
681,055,553
dataset.shuffle() and select() resets format. Intended?
Calling `dataset.shuffle()` or `dataset.select()` on a dataset resets its format set by `dataset.set_format()`. Is this intended or an oversight? When working on quite large datasets that require a lot of preprocessing I find it convenient to save the processed dataset to file using `torch.save("dataset.pt")`. Later...
closed
511
[ "Hi @vegarab yes feel free to open a discussion here.\r\n\r\nThis design choice was not very much thought about.\r\n\r\nSince `dataset.select()` (like all the method without a trailing underscore) is non-destructive and returns a new dataset it has most of its properties initialized from scratch (except the table a...
false
2020-08-18 13:46:01
2020-09-14 08:45:38
CONTRIBUTOR
vegarab
24,683,907
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/511/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/511
https://github.com/huggingface/datasets/issues/511
null
false
680,823,644
Version of numpy to use the library
Thank you so much for your excellent work! I would like to use nlp library in my project. While importing nlp, I am receiving the following error `AttributeError: module 'numpy.random' has no attribute 'Generator'` Numpy version in my project is 1.16.0. May I learn which numpy version is used for the nlp library. Th...
closed
510
[ "Seems like this method was added in 1.17. I'll add a requirement on this.", "Thank you so much. After upgrading the numpy library, it worked." ]
false
2020-08-18 08:59:13
2020-08-19 18:35:56
NONE
isspek
6,966,175
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/510/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/510
https://github.com/huggingface/datasets/issues/510
null
false
679,711,585
Converting TensorFlow dataset example
Hi, I want to use TensorFlow datasets with this repo, I noticed you made some conversion script, can you give a simple example of using it? Thanks
closed
509
[ "Do you want to convert a dataset script to the tfds format ?\r\nIf so, we currently have a comversion script nlp/commands/convert.py but it is a conversion script that goes from tfds to nlp.\r\nI think it shouldn't be too hard to do the changes in reverse (at some manual adjustments).\r\nIf you manage to make it w...
false
2020-08-16 08:05:20
2021-08-03 06:01:18
NONE
saareliad
22,762,845
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/509/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/509
https://github.com/huggingface/datasets/issues/509
null
false
679,705,734
TypeError: Receiver() takes no arguments
I am trying to load a wikipedia data set ``` import nlp from nlp import load_dataset dataset = load_dataset("wikipedia", "20200501.en", split="train", cache_dir=data_path, beam_runner='DirectRunner') #dataset = load_dataset('wikipedia', '20200501.sv', cache_dir=data_path, beam_runner='DirectRunner') ``` Th...
closed
508
[ "Which version of Apache Beam do you have (can you copy your full environment info here)?", "apache-beam==2.23.0\r\nnlp==0.4.0\r\n\r\nFor me this was resolved by running the same python script on Linux (or really WSL). ", "Do you manage to run a dummy beam pipeline with python on windows ? \r\nYou can test a du...
false
2020-08-16 07:18:16
2020-09-01 14:53:33
NONE
sebastiantomac
1,225,851
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/508/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/508
https://github.com/huggingface/datasets/issues/508
null
false
679,400,683
Errors when I use
I tried the following example code from https://huggingface.co/deepset/roberta-base-squad2 and got errors I am using **transformers 3.0.2** code . from transformers.pipelines import pipeline from transformers.modeling_auto import AutoModelForQuestionAnswering from transformers.tokenization_auto import AutoToke...
closed
507
[ "Looks like an issue with 3.0.2 transformers version. Works fine when I use \"master\" version of transformers." ]
false
2020-08-14 21:03:57
2020-08-14 21:39:10
NONE
mchari
30,506,151
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/507/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/507
https://github.com/huggingface/datasets/issues/507
null
false
679,164,788
fix dataset.map for function without outputs
As noticed in #505 , giving a function that doesn't return anything in `.map` raises an error because of an unreferenced variable. I fixed that and added tests. Thanks @avloss for reporting
closed
506
[]
false
2020-08-14 13:40:22
2020-08-17 11:24:39
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/506/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/506
https://github.com/huggingface/datasets/pull/506
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/506", "html_url": "https://github.com/huggingface/datasets/pull/506", "diff_url": "https://github.com/huggingface/datasets/pull/506.diff", "patch_url": "https://github.com/huggingface/datasets/pull/506.patch", "merged_at": "2020-08-17T11:24:38Z"}
true
678,791,400
tmp_file referenced before assignment
Just learning about this library - so might've not set up all the flags correctly, but was getting this error about "tmp_file".
closed
505
[ "Thanks for reporting the issue ! I'm creating a new PR to fix it and add tests.\r\n(I'm doing a new PR because I know there's some other place where it needs to be fixed)", "I'm closing this one as I created the other PR." ]
false
2020-08-13 23:27:33
2020-08-14 13:42:46
NONE
avloss
17,853,685
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/505/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/505
https://github.com/huggingface/datasets/pull/505
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/505", "html_url": "https://github.com/huggingface/datasets/pull/505", "diff_url": "https://github.com/huggingface/datasets/pull/505.diff", "patch_url": "https://github.com/huggingface/datasets/pull/505.patch", "merged_at": null}
true
678,756,211
Added downloading to Hyperpartisan news detection
Following the discussion on Slack and #349, I've updated the hyperpartisan dataset to pull directly from Zenodo rather than manual install, which should make this dataset much more accessible. Many thanks to @johanneskiesel ! Currently doesn't pass `test_load_real_dataset` - I'm using `self.config.name` which is `de...
closed
504
[ "Thank you @ghomasHudson for making our dataset available! This is great!", "The test passes since #527 :)" ]
false
2020-08-13 21:53:46
2020-08-27 08:18:41
CONTRIBUTOR
ghomasHudson
13,795,113
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/504/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/504
https://github.com/huggingface/datasets/pull/504
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/504", "html_url": "https://github.com/huggingface/datasets/pull/504", "diff_url": "https://github.com/huggingface/datasets/pull/504.diff", "patch_url": "https://github.com/huggingface/datasets/pull/504.patch", "merged_at": "2020-08-27T08:18:41Z"}
true
678,726,538
CompGuessWhat?! 0.2.0
We updated some metadata information associated with the dataset. In addition, we've updated the `create_dummy_data.py` script to generate data samples for the dataset.
closed
503
[ "I don't see any significant change in the dataset script (except the version value update), can you check that again please ?", "Hi @aleSuglia , can you check that all the changes you wanted to do are in the dataset script ?", "Hey sorry but I'm in the middle of a conference deadline. I'll let you know asap!",...
false
2020-08-13 20:51:26
2020-10-21 06:54:29
CONTRIBUTOR
aleSuglia
1,479,733
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/503/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/503
https://github.com/huggingface/datasets/pull/503
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/503", "html_url": "https://github.com/huggingface/datasets/pull/503", "diff_url": "https://github.com/huggingface/datasets/pull/503.diff", "patch_url": "https://github.com/huggingface/datasets/pull/503.patch", "merged_at": null}
true
678,546,070
Fix tokenizers caching
I've found some cases where the caching didn't work properly for tokenizers: 1. if a tokenizer has a regex pattern, then the caching would be inconsistent across sessions 2. if a tokenizer has a cache attribute that changes after some calls, the the caching would not work after cache updates 3. if a tokenizer is u...
closed
502
[ "This should fix #501 and also the issue you sent me on slack @sgugger ." ]
false
2020-08-13 15:53:37
2020-08-19 13:37:19
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/502/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/502
https://github.com/huggingface/datasets/pull/502
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/502", "html_url": "https://github.com/huggingface/datasets/pull/502", "diff_url": "https://github.com/huggingface/datasets/pull/502.diff", "patch_url": "https://github.com/huggingface/datasets/pull/502.patch", "merged_at": "2020-08-19T13:37:17Z"}
true
677,952,893
Caching doesn't work for map (non-deterministic)
The caching functionality doesn't work reliably when tokenizing a dataset. Here's a small example to reproduce it. ```python import nlp import transformers def main(): ds = nlp.load_dataset("reddit", split="train[:500]") tokenizer = transformers.AutoTokenizer.from_pretrained("gpt2") def conv...
closed
501
[ "Thanks for reporting !\r\n\r\nTo store the cache file, we compute a hash of the function given in `.map`, using our own hashing function.\r\nThe hash doesn't seem to stay the same over sessions for the tokenizer.\r\nApparently this is because of the regex at `tokenizer.pat` is not well supported by our hashing fun...
false
2020-08-12 20:20:07
2022-08-08 11:02:23
NONE
wulu473
8,149,933
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/501/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/501
https://github.com/huggingface/datasets/issues/501
null
false
677,841,708
Use hnsw in wiki_dpr
The HNSW faiss index is much faster that regular Flat index.
closed
500
[]
false
2020-08-12 16:58:07
2020-08-20 07:59:19
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/500/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/500
https://github.com/huggingface/datasets/pull/500
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/500", "html_url": "https://github.com/huggingface/datasets/pull/500", "diff_url": "https://github.com/huggingface/datasets/pull/500.diff", "patch_url": "https://github.com/huggingface/datasets/pull/500.patch", "merged_at": "2020-08-20T07:59:18Z"}
true
677,709,938
Narrativeqa (with full text)
Following the uploading of the full text data in #309, I've added the full text to the narrativeqa dataset. Few notes: - Had some encoding issues using the default `open` so am using `open(encoding="latin-1"...` which seems to fix it. Looks fine. - Can't get the dummy data to work. Currently putting stuff at: ...
closed
499
[ "I took a look at the dummy data creation for this dataset.\r\n\r\nMaybe it didn't work on your side might be because `master.zip` and `narrativeqa_full_text.zip` are supposed to be directories and not acutal zip files in the dummy data folder.\r\n\r\nI managed to make it work with this `dummy_data.zip` file:\r\nht...
false
2020-08-12 13:49:43
2020-12-09 11:21:02
CONTRIBUTOR
ghomasHudson
13,795,113
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/499/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/499
https://github.com/huggingface/datasets/pull/499
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/499", "html_url": "https://github.com/huggingface/datasets/pull/499", "diff_url": "https://github.com/huggingface/datasets/pull/499.diff", "patch_url": "https://github.com/huggingface/datasets/pull/499.patch", "merged_at": null}
true
677,597,479
dont use beam fs to save info for local cache dir
If the cache dir is local, then we shouldn't use beam's filesystem to save the dataset info Fix #490
closed
498
[]
false
2020-08-12 11:00:00
2020-08-14 13:17:21
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/498/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/498
https://github.com/huggingface/datasets/pull/498
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/498", "html_url": "https://github.com/huggingface/datasets/pull/498", "diff_url": "https://github.com/huggingface/datasets/pull/498.diff", "patch_url": "https://github.com/huggingface/datasets/pull/498.patch", "merged_at": "2020-08-14T13:17:20Z"}
true
677,057,116
skip header in PAWS-X
This should fix #485 I also updated the `dataset_infos.json` file that is used to verify the integrity of the generated splits (the number of examples was reduced by one). Note that there are new fields in `dataset_infos.json` introduced in the latest release 0.4.0 corresponding to post processing info. I remove...
closed
497
[]
false
2020-08-11 17:26:25
2020-08-19 09:50:02
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/497/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/497
https://github.com/huggingface/datasets/pull/497
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/497", "html_url": "https://github.com/huggingface/datasets/pull/497", "diff_url": "https://github.com/huggingface/datasets/pull/497.diff", "patch_url": "https://github.com/huggingface/datasets/pull/497.patch", "merged_at": "2020-08-19T09:50:01Z"}
true
677,016,998
fix bad type in overflow check
When writing an arrow file and inferring the features, the overflow check could fail if the first example had a `null` field. This is because we were not using the inferred features to do this check, and we could end up with arrays that don't match because of a type mismatch (`null` vs `string` for example). This s...
closed
496
[]
false
2020-08-11 16:24:58
2020-08-14 13:29:35
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/496/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/496
https://github.com/huggingface/datasets/pull/496
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/496", "html_url": "https://github.com/huggingface/datasets/pull/496", "diff_url": "https://github.com/huggingface/datasets/pull/496.diff", "patch_url": "https://github.com/huggingface/datasets/pull/496.patch", "merged_at": "2020-08-14T13:29:34Z"}
true
676,959,289
stack vectors in pytorch and tensorflow
When the format of a dataset is set to pytorch or tensorflow, and if the dataset has vectors in it, they were not stacked together as tensors when calling `dataset[i:i + batch_size][column]` or `dataset[column]`. I added support for stacked tensors for both pytorch and tensorflow. For ragged tensors, they are stack...
closed
495
[]
false
2020-08-11 15:12:53
2020-08-12 09:30:49
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/495/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/495
https://github.com/huggingface/datasets/pull/495
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/495", "html_url": "https://github.com/huggingface/datasets/pull/495", "diff_url": "https://github.com/huggingface/datasets/pull/495.diff", "patch_url": "https://github.com/huggingface/datasets/pull/495.patch", "merged_at": "2020-08-12T09:30:48Z"}
true
676,886,955
Fix numpy stacking
When getting items using a column name as a key, numpy arrays were not stacked. I fixed that and added some tests. There is another issue that still needs to be fixed though: when getting items using a column name as a key, pytorch tensors are not stacked (it outputs a list of tensors). This PR should help with the...
closed
494
[ "This PR also fixed a bug where numpy arrays were returned instead of pytorch tensors when getting with a clumn as a key." ]
false
2020-08-11 13:40:30
2020-08-11 14:56:50
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/494/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/494
https://github.com/huggingface/datasets/pull/494
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/494", "html_url": "https://github.com/huggingface/datasets/pull/494", "diff_url": "https://github.com/huggingface/datasets/pull/494.diff", "patch_url": "https://github.com/huggingface/datasets/pull/494.patch", "merged_at": "2020-08-11T13:49:52Z"}
true
676,527,351
Fix wmt zh-en url
I verified that ``` wget https://stuncorpusprod.blob.core.windows.net/corpusfiles/UNv1.0.en-zh.tar.gz.00 ``` runs in 2 minutes.
closed
493
[ "this doesn't work. I can decompress the file after download locally." ]
false
2020-08-11 02:14:52
2020-08-11 02:22:28
CONTRIBUTOR
sshleifer
6,045,025
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/493/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/493
https://github.com/huggingface/datasets/pull/493
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/493", "html_url": "https://github.com/huggingface/datasets/pull/493", "diff_url": "https://github.com/huggingface/datasets/pull/493.diff", "patch_url": "https://github.com/huggingface/datasets/pull/493.patch", "merged_at": null}
true
676,495,064
nlp.Features does not distinguish between nullable and non-nullable types in PyArrow schema
Here's the code I'm trying to run: ```python dset_wikipedia = nlp.load_dataset("wikipedia", "20200501.en", split="train", cache_dir=args.cache_dir) dset_wikipedia.drop(columns=["title"]) dset_wikipedia.features.pop("title") dset_books = nlp.load_dataset("bookcorpus", split="train", cache_dir=args.cache_dir) dse...
closed
492
[ "In 0.4.0, the assertion in `concatenate_datasets ` is on the features, and not the schema.\r\nCould you try to update `nlp` ?\r\n\r\nAlso, since 0.4.0, you can use `dset_wikipedia.cast_(dset_books.features)` to avoid the schema cast hack.", "Or maybe the assertion comes from elsewhere ?", "I'm using the master...
false
2020-08-11 00:27:46
2020-08-26 16:17:19
CONTRIBUTOR
jarednielsen
4,564,897
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/492/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/492
https://github.com/huggingface/datasets/issues/492
null
false
676,486,275
No 0.4.0 release on GitHub
0.4.0 was released on PyPi, but not on GitHub. This means [the documentation](https://huggingface.co/nlp/) is still displaying from 0.3.0, and that there's no tag to easily clone the 0.4.0 version of the repo.
closed
491
[ "I did the release on github, and updated the doc :)\r\nSorry for the delay", "Thanks!" ]
false
2020-08-10 23:59:57
2020-08-11 16:50:07
CONTRIBUTOR
jarednielsen
4,564,897
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/491/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/491
https://github.com/huggingface/datasets/issues/491
null
false
676,482,242
Loading preprocessed Wikipedia dataset requires apache_beam
Running `nlp.load_dataset("wikipedia", "20200501.en", split="train", dir="/tmp/wikipedia")` gives an error if apache_beam is not installed, stemming from https://github.com/huggingface/nlp/blob/38eb2413de54ee804b0be81781bd65ac4a748ced/src/nlp/builder.py#L981-L988 This succeeded without the dependency in ve...
closed
490
[]
false
2020-08-10 23:46:50
2020-08-14 13:17:20
CONTRIBUTOR
jarednielsen
4,564,897
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/490/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/490
https://github.com/huggingface/datasets/issues/490
null
false
676,456,257
ug
closed
489
[ "whoops", "please delete this" ]
false
2020-08-10 22:33:03
2020-08-10 22:55:14
NONE
timothyjlaurent
2,000,204
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/489/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/489
https://github.com/huggingface/datasets/issues/489
null
false
676,299,993
issues with downloading datasets for wmt16 and wmt19
I have encountered multiple issues while trying to: ``` import nlp dataset = nlp.load_dataset('wmt16', 'ru-en') metric = nlp.load_metric('wmt16') ``` 1. I had to do `pip install -e ".[dev]" ` on master, currently released nlp didn't work (sorry, didn't save the error) - I went back to the released version and no...
closed
488
[ "I found `UNv1.0.en-ru.tar.gz` here: https://conferences.unite.un.org/uncorpus/en/downloadoverview, so it can be reconstructed with:\r\n```\r\nwget -c https://stuncorpusprod.blob.core.windows.net/corpusfiles/UNv1.0.en-ru.tar.gz.00\r\nwget -c https://stuncorpusprod.blob.core.windows.net/corpusfiles/UNv1.0.en-ru.tar....
false
2020-08-10 17:32:51
2022-10-04 17:46:59
CONTRIBUTOR
stas00
10,676,103
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/488/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/488
https://github.com/huggingface/datasets/issues/488
null
false
676,143,029
Fix elasticsearch result ids returning as strings
I am using the latest elasticsearch binary and master of nlp. For me elasticsearch searches failed because the resultant "id_" returned for searches are strings, but our library assumes them to be integers.
closed
487
[ "It looks like you need to rebase from master to fix the CI. Could you do that please ?" ]
false
2020-08-10 13:37:11
2020-08-31 10:42:46
CONTRIBUTOR
sai-prasanna
3,595,526
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/487/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/487
https://github.com/huggingface/datasets/pull/487
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/487", "html_url": "https://github.com/huggingface/datasets/pull/487", "diff_url": "https://github.com/huggingface/datasets/pull/487.diff", "patch_url": "https://github.com/huggingface/datasets/pull/487.patch", "merged_at": "2020-08-31T10:42:46Z"}
true
675,649,034
Bookcorpus data contains pretokenized text
It seem that the bookcoprus data downloaded through the library was pretokenized with NLTK's Treebank tokenizer, which changes the text in incompatible ways to how, for instance, BERT's wordpiece tokenizer works. For example, "didn't" becomes "did" + "n't", and double quotes are changed to `` and '' for start and end q...
closed
486
[ "Yes indeed it looks like some `'` and spaces are missing (for example in `dont` or `didnt`).\r\nDo you know if there exist some copies without this issue ?\r\nHow would you fix this issue on the current data exactly ? I can see that the data is raw text (not tokenized) so I'm not sure I understand how you would do...
false
2020-08-09 06:53:24
2022-10-04 17:44:33
CONTRIBUTOR
orsharir
99,543
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/486/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/486
https://github.com/huggingface/datasets/issues/486
null
false
675,595,393
PAWS dataset first item is header
``` import nlp dataset = nlp.load_dataset('xtreme', 'PAWS-X.en') dataset['test'][0] ``` prints the following ``` {'label': 'label', 'sentence1': 'sentence1', 'sentence2': 'sentence2'} ``` dataset['test'][0] should probably be the first item in the dataset, not just a dictionary mapping the column names t...
closed
485
[]
false
2020-08-08 22:05:25
2020-08-19 09:50:01
CONTRIBUTOR
jxmorris12
13,238,952
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/485/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/485
https://github.com/huggingface/datasets/issues/485
null
false
675,088,983
update mirror for RT dataset
closed
484
[ "Thanks for adding this mirror link :)\r\n\r\nCould you run the following command to update the json file `dataset_infos.json` used to verify the integrity of the downloaded file ?\r\n\r\n```\r\nnlp-cli test ./datasets/rotten_tomatoes --save_infos --ignore_verifications\r\n```", "done! @lhoestq ", "the build_do...
false
2020-08-07 15:25:45
2020-08-24 13:33:37
CONTRIBUTOR
jxmorris12
13,238,952
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/484/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/484
https://github.com/huggingface/datasets/pull/484
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/484", "html_url": "https://github.com/huggingface/datasets/pull/484", "diff_url": "https://github.com/huggingface/datasets/pull/484.diff", "patch_url": "https://github.com/huggingface/datasets/pull/484.patch", "merged_at": "2020-08-24T13:33:37Z"}
true
675,080,694
rotten tomatoes movie review dataset taken down
In an interesting twist of events, the individual who created the movie review seems to have left Cornell, and their webpage has been removed, along with the movie review dataset (http://www.cs.cornell.edu/people/pabo/movie-review-data/rt-polaritydata.tar.gz). It's not downloadable anymore.
closed
483
[ "found a mirror: https://storage.googleapis.com/seldon-datasets/sentence_polarity_v1/rt-polaritydata.tar.gz", "fixed in #484 ", "Closing this one. Thanks again @jxmorris12 for taking care of this :)" ]
false
2020-08-07 15:12:01
2020-09-08 09:36:34
CONTRIBUTOR
jxmorris12
13,238,952
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/483/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/483
https://github.com/huggingface/datasets/issues/483
null
false
674,851,147
Bugs : dataset.map() is frozen on ELI5
Hi Huggingface Team! Thank you guys once again for this amazing repo. I have tried to prepare ELI5 to train with T5, based on [this wonderful notebook of Suraj Patil](https://github.com/patil-suraj/exploring-T5/blob/master/T5_on_TPU.ipynb) However, when I run `dataset.map()` on ELI5 to prepare `input_text, ta...
closed
482
[ "This comes from an overflow in pyarrow's array.\r\nIt is stuck inside the loop that reduces the batch size to avoid the overflow.\r\nI'll take a look", "I created a PR to fix the issue.\r\nIt was due to an overflow check that handled badly an empty list.\r\n\r\nYou can try the changes by using \r\n```\r\n!pip in...
false
2020-08-07 08:23:35
2023-04-06 09:39:59
NONE
ratthachat
56,621,342
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/482/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/482
https://github.com/huggingface/datasets/issues/482
null
false
674,567,389
Apply utf-8 encoding to all datasets
## Description This PR applies utf-8 encoding for all instances of `with open(...) as f` to all Python files in `datasets/`. As suggested by @thomwolf in #468 , we use regular expressions and the following function ```python def apply_encoding_on_file_open(filepath: str): """Apply UTF-8 encoding for all insta...
closed
481
[ "Not sure why the AWS test is failing - perhaps I made too many concurrent CI builds 😢. Can someone please rerun the CI to check the error is not on my end?", "I pushed an improved docstring and the unit tests now pass, which suggests the previous failure on AWS was simply a timeout error. \r\n\r\nFor some reaso...
false
2020-08-06 20:02:09
2020-08-20 08:16:08
MEMBER
lewtun
26,859,204
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/481/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/481
https://github.com/huggingface/datasets/pull/481
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/481", "html_url": "https://github.com/huggingface/datasets/pull/481", "diff_url": "https://github.com/huggingface/datasets/pull/481.diff", "patch_url": "https://github.com/huggingface/datasets/pull/481.patch", "merged_at": "2020-08-20T08:16:08Z"}
true
674,245,959
Column indexing hotfix
As observed for example in #469 , currently `__getitem__` does not convert the data to the dataset format when indexing by column. This is a hotfix that imitates functional 0.3.0. code. In the future it'd probably be nice to have a test there.
closed
480
[ "Looks good to me as well but we'll want to add a test indeed.\r\nYou can add one if you have time @TevenLeScao.\r\nOtherwise, we'll do it when we are back with Quentin. ", "I fixed it in #494 " ]
false
2020-08-06 11:37:05
2023-09-24 09:49:33
CONTRIBUTOR
TevenLeScao
26,709,476
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/480/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/480
https://github.com/huggingface/datasets/pull/480
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/480", "html_url": "https://github.com/huggingface/datasets/pull/480", "diff_url": "https://github.com/huggingface/datasets/pull/480.diff", "patch_url": "https://github.com/huggingface/datasets/pull/480.patch", "merged_at": null}
true
673,905,407
add METEOR metric
Added the METEOR metric. Can be used like this: ```python import nlp meteor = nlp.load_metric('metrics/meteor') meteor.compute(["some string", "some string"], ["some string", "some similar string"]) # {'meteor': 0.6411637931034483} meteor.add("some string", "some string") meteor.add('some string", "some simila...
closed
479
[ "Really nice !\r\nThanks for adding this one.\r\n\r\nI noticed that there are some '-' that are left in the description in the middle of some workds. It migh come from copy-pasting the pdf paper. ex: `im-provement`. Could you fix that please ?", "@lhoestq \r\nLinebreaks have been removed! Note that there are stil...
false
2020-08-05 23:13:00
2020-08-19 13:39:09
CONTRIBUTOR
vegarab
24,683,907
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/479/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/479
https://github.com/huggingface/datasets/pull/479
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/479", "html_url": "https://github.com/huggingface/datasets/pull/479", "diff_url": "https://github.com/huggingface/datasets/pull/479.diff", "patch_url": "https://github.com/huggingface/datasets/pull/479.patch", "merged_at": "2020-08-19T13:39:09Z"}
true
673,178,317
Export TFRecord to GCP bucket
Previously, I was writing TFRecords manually to GCP bucket with : `with tf.io.TFRecordWriter('gs://my_bucket/x.tfrecord')` Since `0.4.0` is out with the `export()` function, I tried it. But it seems TFRecords cannot be directly written to GCP bucket. `dataset.export('local.tfrecord')` works fine, but `dataset....
closed
478
[ "Nevermind, I restarted my python session and it worked fine...\r\n\r\n---\r\n\r\nI had an authentification error, and I authenticated from another terminal. After that, no more error but it was not working. Restarting the sessions makes it work :)" ]
false
2020-08-05 01:08:32
2020-08-05 01:21:37
NONE
astariul
43,774,355
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/478/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/478
https://github.com/huggingface/datasets/issues/478
null
false
673,142,143
Overview.ipynb throws exceptions with nlp 0.4.0
with nlp 0.4.0, the TensorFlow example in Overview.ipynb throws the following exceptions: --------------------------------------------------------------------------- AttributeError Traceback (most recent call last) <ipython-input-5-48907f2ad433> in <module> ----> 1 features = {x: trai...
closed
477
[ "Thanks for reporting this issue\r\n\r\nThere was a bug where numpy arrays would get returned instead of tensorflow tensors.\r\nThis is fixed on master.\r\n\r\nI tried to re-run the colab and encountered this error instead:\r\n\r\n```\r\nAttributeError: 'tensorflow.python.framework.ops.EagerTensor' object has no at...
false
2020-08-04 23:18:15
2021-08-03 06:02:15
NONE
mandy-li
23,109,219
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/477/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/477
https://github.com/huggingface/datasets/issues/477
null
false
672,991,854
CheckList
Sorry for the large pull request. - Added checklists as datasets. I can't run `test_load_real_dataset` (see #474), but I can load the datasets successfully as shown in the example notebook - Added a checklist wrapper
closed
476
[ "> Also, a little out of my depth there, but would there be a way to have the default pip install checklist command not require mysql and mariadb to be installed? Feels like that might be a source of confusion for users.\r\n\r\nI removed the pattern dependency, mysql is not a requirement anymore. I'm not sure where...
false
2020-08-04 18:32:05
2022-10-03 09:43:37
NONE
marcotcr
698,010
User
[{"id": 4564477500, "node_id": "LA_kwDODunzps8AAAABEBBmPA", "url": "https://api.github.com/repos/huggingface/datasets/labels/dataset%20contribution", "name": "dataset contribution", "color": "0e8a16", "default": false, "description": "Contribution to a dataset script"}]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/476/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/476
https://github.com/huggingface/datasets/pull/476
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/476", "html_url": "https://github.com/huggingface/datasets/pull/476", "diff_url": "https://github.com/huggingface/datasets/pull/476.diff", "patch_url": "https://github.com/huggingface/datasets/pull/476.patch", "merged_at": null}
true
672,884,595
misc. bugs and quality of life
A few misc. bugs and QOL improvements that I've come across in using the library. Let me know if you don't like any of them and I can adjust/remove them. 1. Printing datasets without a description field throws an error when formatting the `single_line_description`. This fixes that, and also adds some formatting to t...
closed
475
[ "Cool thanks, I made those changes. LMK if you think it's ready for merge.", "Ok to merge for me" ]
false
2020-08-04 15:32:29
2020-08-17 21:14:08
CONTRIBUTOR
joeddav
9,353,833
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/475/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/475
https://github.com/huggingface/datasets/pull/475
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/475", "html_url": "https://github.com/huggingface/datasets/pull/475", "diff_url": "https://github.com/huggingface/datasets/pull/475.diff", "patch_url": "https://github.com/huggingface/datasets/pull/475.patch", "merged_at": "2020-08-17T21:14:07Z"}
true
672,407,330
test_load_real_dataset when config has BUILDER_CONFIGS that matter
It a dataset has custom `BUILDER_CONFIGS` with non-keyword arguments (or keyword arguments with non default values), the config is not loaded during the test and causes an error. I think the problem is that `test_load_real_dataset` calls `load_dataset` with `data_dir=temp_data_dir` ([here](https://github.com/huggingfa...
closed
474
[ "The `data_dir` parameter has been removed. Now the error is `ValueError: Config name is missing`\r\n\r\nAs mentioned in #470 I think we can have one test with the first config of BUILDER_CONFIGS, and another test that runs all of the configs in BUILDER_CONFIGS", "This was fixed in #527 \r\n\r\nClosing this one, ...
false
2020-08-03 23:46:36
2020-09-07 14:53:13
NONE
marcotcr
698,010
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/474/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/474
https://github.com/huggingface/datasets/issues/474
null
false
672,007,247
add DoQA dataset (ACL 2020)
add DoQA dataset (ACL 2020) http://ixa.eus/node/12931
closed
473
[]
false
2020-08-03 11:26:52
2020-09-10 17:19:11
CONTRIBUTOR
mariamabarham
38,249,783
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/473/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/473
https://github.com/huggingface/datasets/pull/473
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/473", "html_url": "https://github.com/huggingface/datasets/pull/473", "diff_url": "https://github.com/huggingface/datasets/pull/473.diff", "patch_url": "https://github.com/huggingface/datasets/pull/473.patch", "merged_at": "2020-09-03T11:44:14Z"}
true
672,000,745
add crd3 dataset
opening new PR for CRD3 dataset (ACL2020) to fix the circle CI problems
closed
472
[ "This PR was already approved by @lhoestq in #456 . This one just make style to remove some typos" ]
false
2020-08-03 11:15:02
2020-08-03 11:22:10
CONTRIBUTOR
mariamabarham
38,249,783
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/472/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/472
https://github.com/huggingface/datasets/pull/472
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/472", "html_url": "https://github.com/huggingface/datasets/pull/472", "diff_url": "https://github.com/huggingface/datasets/pull/472.diff", "patch_url": "https://github.com/huggingface/datasets/pull/472.patch", "merged_at": "2020-08-03T11:22:09Z"}
true
671,996,423
add reuters21578 dataset
new PR to add the reuters21578 dataset and fix the circle CI problems. Fix partially: - #353 Subsequent PR after: - #449
closed
471
[]
false
2020-08-03 11:07:14
2022-08-04 08:39:11
CONTRIBUTOR
mariamabarham
38,249,783
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/471/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/471
https://github.com/huggingface/datasets/pull/471
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/471", "html_url": "https://github.com/huggingface/datasets/pull/471", "diff_url": "https://github.com/huggingface/datasets/pull/471.diff", "patch_url": "https://github.com/huggingface/datasets/pull/471.patch", "merged_at": "2020-09-03T09:58:50Z"}
true
671,952,276
Adding IWSLT 2017 dataset.
Created a [IWSLT 2017](https://sites.google.com/site/iwsltevaluation2017/TED-tasks) dataset script for the *multilingual data*. ``` Bilingual data: {Arabic, German, French, Japanese, Korean, Chinese} <-> English Multilingual data: German, English, Italian, Dutch, Romanian. (Any pair) ``` I'm unsure how to h...
closed
470
[ "Ok I tried to add the dummy dataset (I actually modified the dummy_data command to generate them for me because it was too painful to do that manually).\r\n\r\nThe dummy_data test seems to work:\r\n```bash\r\nRUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_iwslt2017\...
false
2020-08-03 09:52:39
2020-09-07 12:33:30
CONTRIBUTOR
Narsil
204,321
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/470/reactions", "total_count": 2, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 2, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/470
https://github.com/huggingface/datasets/pull/470
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/470", "html_url": "https://github.com/huggingface/datasets/pull/470", "diff_url": "https://github.com/huggingface/datasets/pull/470.diff", "patch_url": "https://github.com/huggingface/datasets/pull/470.patch", "merged_at": "2020-09-07T12:33:30Z"}
true
671,876,963
invalid data type 'str' at _convert_outputs in arrow_dataset.py
I trying to build multi label text classifier model using Transformers lib. I'm using Transformers NLP to load the data set, while calling trainer.train() method. It throws the following error File "C:\***\arrow_dataset.py", line 343, in _convert_outputs v = command(v) TypeError: new(): invalid data type ...
closed
469
[ "Hi ! Did you try to set the output format to pytorch ? (or tensorflow if you're using tensorflow)\r\nIt can be done with `dataset.set_format(\"torch\", columns=columns)` (or \"tensorflow\").\r\n\r\nNote that for pytorch, string columns can't be converted to `torch.Tensor`, so you have to specify in `columns=` the...
false
2020-08-03 07:48:29
2023-07-20 15:54:17
NONE
Murgates
30,617,486
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/469/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/469
https://github.com/huggingface/datasets/issues/469
null
false
671,622,441
UnicodeDecodeError while loading PAN-X task of XTREME dataset
Hi 🤗 team! ## Description of the problem I'm running into a `UnicodeDecodeError` while trying to load the PAN-X subset the XTREME dataset: ``` --------------------------------------------------------------------------- UnicodeDecodeError Traceback (most recent call last) <ipython-inp...
closed
468
[ "Indeed. Solution 1 is the simplest.\r\n\r\nThis is actually a recurring problem.\r\nI think we should scan all the datasets with regexpr to fix the use of `open()` without encodings.\r\nAnd probably add a test in the CI to forbid using this in the future.", "I'm happy to tackle the broader problem - will open a ...
false
2020-08-02 14:05:10
2020-08-20 08:16:08
MEMBER
lewtun
26,859,204
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/468/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/468
https://github.com/huggingface/datasets/issues/468
null
false
671,580,010
DOCS: Fix typo
Fix typo from dictionnary -> dictionary
closed
467
[ "Thanks!" ]
false
2020-08-02 08:59:37
2020-08-02 13:52:27
CONTRIBUTOR
bharatr21
13,381,361
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/467/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/467
https://github.com/huggingface/datasets/pull/467
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/467", "html_url": "https://github.com/huggingface/datasets/pull/467", "diff_url": "https://github.com/huggingface/datasets/pull/467.diff", "patch_url": "https://github.com/huggingface/datasets/pull/467.patch", "merged_at": "2020-08-02T09:18:54Z"}
true
670,766,891
[METRICS] Various improvements on metrics
- Disallow the use of positional arguments to avoid `predictions` vs `references` mistakes - Allow to directly feed numpy/pytorch/tensorflow/pandas objects in metrics
closed
466
[ "The cast function is now called inside `features.encode_example`.\r\nI also added `encode_batch` that was missing.\r\n\r\nMoreover I used the cast function in `Dataset.map` to support torch/tensorflow tensors or numpy arrays inputs.\r\n\r\nThere are tests for tensors inputs in metrics and in .map", "I think we c...
false
2020-08-01 11:03:45
2020-08-17 15:15:00
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/466/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/466
https://github.com/huggingface/datasets/pull/466
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/466", "html_url": "https://github.com/huggingface/datasets/pull/466", "diff_url": "https://github.com/huggingface/datasets/pull/466.diff", "patch_url": "https://github.com/huggingface/datasets/pull/466.patch", "merged_at": "2020-08-17T15:14:59Z"}
true
669,889,779
Keep features after transform
When applying a transform like `map`, some features were lost (and inferred features were used). It was the case for ClassLabel, Translation, etc. To fix that, I did some modifications in the `ArrowWriter`: - added the `update_features` parameter. When it's `True`, then the features specified by the user (if any...
closed
465
[ "One note on features inference:\r\n\r\nif an arrow type is `struct of items` where each item is a `list`, then we return a `dict` in which each item is a `Sequence`.\r\nIt means that we don't use the Sequence <-> dict swap when we infer features.\r\n\r\nIt's fine because the swap is generally used in dataset scrip...
false
2020-07-31 14:43:21
2020-07-31 18:27:33
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/465/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/465
https://github.com/huggingface/datasets/pull/465
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/465", "html_url": "https://github.com/huggingface/datasets/pull/465", "diff_url": "https://github.com/huggingface/datasets/pull/465.diff", "patch_url": "https://github.com/huggingface/datasets/pull/465.patch", "merged_at": "2020-07-31T18:27:32Z"}
true
669,767,381
Add rename, remove and cast in-place operations
Add a bunch of in-place operation leveraging the Arrow back-end to rename and remove columns and cast to new features without using the more expensive `map` method. These methods are added to `Dataset` as well as `DatasetDict`. Added tests for these new methods and add the methods to the doc. Naming follows th...
closed
464
[]
false
2020-07-31 12:30:21
2020-07-31 15:50:02
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/464/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/464
https://github.com/huggingface/datasets/pull/464
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/464", "html_url": "https://github.com/huggingface/datasets/pull/464", "diff_url": "https://github.com/huggingface/datasets/pull/464.diff", "patch_url": "https://github.com/huggingface/datasets/pull/464.patch", "merged_at": "2020-07-31T15:50:00Z"}
true
669,735,455
Add dataset/mlsum
New pull request that should correct the previous errors. The load_real_data stills fails because it is looking for a default dataset URL that does not exists, this does not happen when loading the dataset with load_dataset
closed
463
[ "I think the problem is related to `wiki_dpr` dataset which is making the circle CI failed as you can see:\r\n```\r\nFAILED tests/test_dataset_common.py::AWSDatasetTest::test_load_dataset_wiki_dpr\r\nFAILED tests/test_hf_gcp.py::TestDatasetOnHfGcp::test_script_synced_with_s3_wiki_dpr/dummy_psgs_w100_no_embeddings\r...
false
2020-07-31 11:50:52
2020-08-24 14:54:42
CONTRIBUTOR
RachelKer
36,986,299
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/463/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/463
https://github.com/huggingface/datasets/pull/463
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/463", "html_url": "https://github.com/huggingface/datasets/pull/463", "diff_url": "https://github.com/huggingface/datasets/pull/463.diff", "patch_url": "https://github.com/huggingface/datasets/pull/463.patch", "merged_at": null}
true
669,715,547
add DoQA (ACL 2020) dataset
adds DoQA (ACL 2020) dataset
closed
462
[]
false
2020-07-31 11:25:56
2023-09-24 09:48:42
CONTRIBUTOR
mariamabarham
38,249,783
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/462/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/462
https://github.com/huggingface/datasets/pull/462
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/462", "html_url": "https://github.com/huggingface/datasets/pull/462", "diff_url": "https://github.com/huggingface/datasets/pull/462.diff", "patch_url": "https://github.com/huggingface/datasets/pull/462.patch", "merged_at": null}
true
669,703,508
Doqa
add DoQA (ACL 2020) dataset
closed
461
[]
false
2020-07-31 11:11:12
2023-09-24 09:48:40
CONTRIBUTOR
mariamabarham
38,249,783
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/461/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/461
https://github.com/huggingface/datasets/pull/461
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/461", "html_url": "https://github.com/huggingface/datasets/pull/461", "diff_url": "https://github.com/huggingface/datasets/pull/461.diff", "patch_url": "https://github.com/huggingface/datasets/pull/461.patch", "merged_at": null}
true
669,585,256
Fix KeyboardInterrupt in map and bad indices in select
If you interrupted a map function while it was writing, the cached file was not discarded. Therefore the next time you called map, it was loading an incomplete arrow file. We had the same issue with select if there was a bad indice at one point. To fix that I used temporary files that are renamed once everything...
closed
460
[ "Thanks @TevenLeScao for finding this issue", "Thanks @lhoestq for catching this ❤️" ]
false
2020-07-31 08:57:15
2020-07-31 11:32:19
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/460/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/460
https://github.com/huggingface/datasets/pull/460
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/460", "html_url": "https://github.com/huggingface/datasets/pull/460", "diff_url": "https://github.com/huggingface/datasets/pull/460.diff", "patch_url": "https://github.com/huggingface/datasets/pull/460.patch", "merged_at": "2020-07-31T11:32:18Z"}
true
669,545,437
[Breaking] Update Dataset and DatasetDict API
This PR contains a few breaking changes so it's probably good to keep it for the next (major) release: - rename the `flatten`, `drop` and `dictionary_encode_column` methods in `flatten_`, `drop_` and `dictionary_encode_column_` to indicate that these methods have in-place effects as discussed in #166. From now on we s...
closed
459
[]
false
2020-07-31 08:11:33
2020-08-26 08:28:36
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/459/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/459
https://github.com/huggingface/datasets/pull/459
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/459", "html_url": "https://github.com/huggingface/datasets/pull/459", "diff_url": "https://github.com/huggingface/datasets/pull/459.diff", "patch_url": "https://github.com/huggingface/datasets/pull/459.patch", "merged_at": "2020-08-26T08:28:35Z"}
true
668,972,666
Install CoVal metric from github
Changed the import statements in `coval.py` to direct the user to install the original package from github if it's not already installed (the warning will only display properly after merging [PR455](https://github.com/huggingface/nlp/pull/455)) Also changed the function call to use named rather than positional argum...
closed
458
[]
false
2020-07-30 16:59:25
2020-07-31 13:56:33
MEMBER
yjernite
10,469,459
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/458/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/458
https://github.com/huggingface/datasets/pull/458
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/458", "html_url": "https://github.com/huggingface/datasets/pull/458", "diff_url": "https://github.com/huggingface/datasets/pull/458.diff", "patch_url": "https://github.com/huggingface/datasets/pull/458.patch", "merged_at": "2020-07-31T13:56:33Z"}
true
668,898,386
add set_format to DatasetDict + tests
Add the `set_format` and `formated_as` and `reset_format` to `DatasetDict`. Add tests to these for `Dataset` and `DatasetDict`. Fix some bugs uncovered by the tests for `pandas` formating.
closed
457
[]
false
2020-07-30 15:53:20
2020-07-30 17:34:36
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/457/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/457
https://github.com/huggingface/datasets/pull/457
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/457", "html_url": "https://github.com/huggingface/datasets/pull/457", "diff_url": "https://github.com/huggingface/datasets/pull/457.diff", "patch_url": "https://github.com/huggingface/datasets/pull/457.patch", "merged_at": "2020-07-30T17:34:34Z"}
true
668,723,785
add crd3(ACL 2020) dataset
This PR adds the **Critical Role Dungeons and Dragons Dataset** published at ACL 2020
closed
456
[]
false
2020-07-30 13:28:35
2023-09-24 09:48:47
CONTRIBUTOR
mariamabarham
38,249,783
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/456/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/456
https://github.com/huggingface/datasets/pull/456
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/456", "html_url": "https://github.com/huggingface/datasets/pull/456", "diff_url": "https://github.com/huggingface/datasets/pull/456.diff", "patch_url": "https://github.com/huggingface/datasets/pull/456.patch", "merged_at": null}
true
668,037,965
Add bleurt
This PR adds the BLEURT metric to the library. The BLEURT `Metric` downloads a TF checkpoint corresponding to its `config_name` at creation (in the `_info` function). Default is set to `bleurt-base-128`. Note that the default in the original package is `bleurt-tiny-128`, but they throw a warning and recommend usi...
closed
455
[ "Sorry one nit: Could we use named arguments for the call to BLEURT?\r\n\r\ni.e. \r\n scores = self.scorer.score(references=references, candidates=predictions)\r\n\r\n(i.e. so it is less bug prone)\r\n", "Following up on Ankur's comment---we are going to drop support for\npositional (not named) arguments i...
false
2020-07-29 18:08:32
2020-07-31 13:56:14
MEMBER
yjernite
10,469,459
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/455/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/455
https://github.com/huggingface/datasets/pull/455
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/455", "html_url": "https://github.com/huggingface/datasets/pull/455", "diff_url": "https://github.com/huggingface/datasets/pull/455.diff", "patch_url": "https://github.com/huggingface/datasets/pull/455.patch", "merged_at": "2020-07-31T13:56:14Z"}
true
668,011,577
Create SECURITY.md
closed
454
[]
false
2020-07-29 17:23:34
2020-07-29 21:45:52
NONE
ChenZehong13
56,394,989
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/454/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/454
https://github.com/huggingface/datasets/pull/454
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/454", "html_url": "https://github.com/huggingface/datasets/pull/454", "diff_url": "https://github.com/huggingface/datasets/pull/454.diff", "patch_url": "https://github.com/huggingface/datasets/pull/454.patch", "merged_at": null}
true
667,728,247
add builder tests
I added `as_dataset` and `download_and_prepare` to the tests
closed
453
[]
false
2020-07-29 10:22:07
2020-07-29 11:14:06
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/453/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/453
https://github.com/huggingface/datasets/pull/453
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/453", "html_url": "https://github.com/huggingface/datasets/pull/453", "diff_url": "https://github.com/huggingface/datasets/pull/453.diff", "patch_url": "https://github.com/huggingface/datasets/pull/453.patch", "merged_at": "2020-07-29T11:14:05Z"}
true
667,498,295
Guardian authorship dataset
A new dataset: Guardian news articles for authorship attribution **tests passed:** python nlp-cli dummy_data datasets/guardian_authorship --save_infos --all_configs RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_guardian_authorship **Tests failed:** Real data:...
closed
452
[ "Hi ! Glad you managed to fix the version issue.\r\n\r\nThe command `\r\npython nlp-cli dummy_data datasets/guardian_authorship --save_infos --all_configs` is supposed to generate a json file `dataset_infos.json` next to your dataset script, but I can't see it in the PR.\r\nCan you make sure you have the json file ...
false
2020-07-29 02:23:57
2020-08-20 15:09:57
CONTRIBUTOR
malikaltakrori
25,109,412
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/452/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/452
https://github.com/huggingface/datasets/pull/452
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/452", "html_url": "https://github.com/huggingface/datasets/pull/452", "diff_url": "https://github.com/huggingface/datasets/pull/452.diff", "patch_url": "https://github.com/huggingface/datasets/pull/452.patch", "merged_at": "2020-08-20T15:07:55Z"}
true
667,210,468
Fix csv/json/txt cache dir
The cache dir for csv/json/txt datasets was always the same. This is an issue because it should be different depending on the data files provided by the user. To fix that, I added a line that use the hash of the data files provided by the user to define the cache dir. This should fix #444
closed
451
[ "I think this is the way to go but I’m afraid this might be a little slow. I was thinking that we could use a high quality very fast non crypto hash like xxhash for these stuff (hashing data files)", "Yep good idea, I'll take a look", "I tested the hashing speed [here](https://colab.research.google.com/drive/1h...
false
2020-07-28 16:30:51
2020-07-29 13:57:23
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/451/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/451
https://github.com/huggingface/datasets/pull/451
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/451", "html_url": "https://github.com/huggingface/datasets/pull/451", "diff_url": "https://github.com/huggingface/datasets/pull/451.diff", "patch_url": "https://github.com/huggingface/datasets/pull/451.patch", "merged_at": "2020-07-29T13:57:22Z"}
true
667,074,120
add sogou_news
This PR adds the sogou news dataset #353
closed
450
[]
false
2020-07-28 13:29:10
2020-07-29 13:30:18
CONTRIBUTOR
mariamabarham
38,249,783
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/450/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/450
https://github.com/huggingface/datasets/pull/450
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/450", "html_url": "https://github.com/huggingface/datasets/pull/450", "diff_url": "https://github.com/huggingface/datasets/pull/450.diff", "patch_url": "https://github.com/huggingface/datasets/pull/450.patch", "merged_at": "2020-07-29T13:30:17Z"}
true
666,898,923
add reuters21578 dataset
This PR adds the `Reuters_21578` dataset https://kdd.ics.uci.edu/databases/reuters21578/reuters21578.html #353 The datasets is a lit of `.sgm` files which are a bit different from xml file indeed `xml.etree` couldn't be used to read files. I consider them as text file (to avoid using external library) and read ...
closed
449
[ "> Awesome !\r\n> Good job on parsing these files :O\r\n> \r\n> Do you think it would be hard to get the two other split configurations ?\r\n\r\nIt shouldn't be that hard, I think I can consider different config names for each split ", "> > Awesome !\r\n> > Good job on parsing these files :O\r\n> > Do you think i...
false
2020-07-28 08:58:12
2023-09-24 09:49:28
CONTRIBUTOR
mariamabarham
38,249,783
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/449/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/449
https://github.com/huggingface/datasets/pull/449
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/449", "html_url": "https://github.com/huggingface/datasets/pull/449", "diff_url": "https://github.com/huggingface/datasets/pull/449.diff", "patch_url": "https://github.com/huggingface/datasets/pull/449.patch", "merged_at": null}
true
666,893,443
add aws load metric test
Following issue #445 Added a test to recognize import errors of all metrics
closed
448
[ "Could you run `make style` to fix the code_quality fail ?\r\nYou'll need `black` and `isort` that you can install by doing `pip install -e .[quality]`", "Thanks @lhoestq\r\nI fixed the styling", "Thank you :)" ]
false
2020-07-28 08:50:22
2020-07-28 15:02:27
CONTRIBUTOR
idoh
5,303,103
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/448/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/448
https://github.com/huggingface/datasets/pull/448
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/448", "html_url": "https://github.com/huggingface/datasets/pull/448", "diff_url": "https://github.com/huggingface/datasets/pull/448.diff", "patch_url": "https://github.com/huggingface/datasets/pull/448.patch", "merged_at": "2020-07-28T15:02:26Z"}
true
666,842,115
[BugFix] fix wrong import of DEFAULT_TOKENIZER
Fixed the path to `DEFAULT_TOKENIZER` #445
closed
447
[]
false
2020-07-28 07:41:10
2020-07-28 12:58:01
CONTRIBUTOR
idoh
5,303,103
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/447/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/447
https://github.com/huggingface/datasets/pull/447
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/447", "html_url": "https://github.com/huggingface/datasets/pull/447", "diff_url": "https://github.com/huggingface/datasets/pull/447.diff", "patch_url": "https://github.com/huggingface/datasets/pull/447.patch", "merged_at": "2020-07-28T12:52:05Z"}
true
666,837,351
[BugFix] fix wrong import of DEFAULT_TOKENIZER
Fixed the path to `DEFAULT_TOKENIZER` #445
closed
446
[]
false
2020-07-28 07:32:47
2020-07-28 07:34:46
CONTRIBUTOR
idoh
5,303,103
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/446/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/446
https://github.com/huggingface/datasets/pull/446
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/446", "html_url": "https://github.com/huggingface/datasets/pull/446", "diff_url": "https://github.com/huggingface/datasets/pull/446.diff", "patch_url": "https://github.com/huggingface/datasets/pull/446.patch", "merged_at": null}
true
666,836,658
DEFAULT_TOKENIZER import error in sacrebleu
Latest Version 0.3.0 When loading the metric "sacrebleu" there is an import error due to the wrong path ![image](https://user-images.githubusercontent.com/5303103/88633063-2c5e5f00-d0bd-11ea-8ca8-4704dc975433.png)
closed
445
[ "This issue was resolved by #447 " ]
false
2020-07-28 07:31:30
2020-07-28 12:58:56
CONTRIBUTOR
idoh
5,303,103
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/445/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/445
https://github.com/huggingface/datasets/issues/445
null
false
666,280,842
Keep loading old file even I specify a new file in load_dataset
I used load a file called 'a.csv' by ``` dataset = load_dataset('csv', data_file='./a.csv') ``` And after a while, I tried to load another csv called 'b.csv' ``` dataset = load_dataset('csv', data_file='./b.csv') ``` However, the new dataset seems to remain the old 'a.csv' and not loading new csv file. Even...
closed
444
[ "Same here !", "This is the only fix I could come up with without touching the repo's code.\r\n```python\r\nfrom nlp.builder import FORCE_REDOWNLOAD\r\ndataset = load_dataset('csv', data_file='./a.csv', download_mode=FORCE_REDOWNLOAD, version='0.0.1')\r\n```\r\nYou'll have to change the version each time you want...
false
2020-07-27 13:08:06
2020-07-29 13:57:22
NONE
joshhu
10,594,453
User
[{"id": 2067388877, "node_id": "MDU6TGFiZWwyMDY3Mzg4ODc3", "url": "https://api.github.com/repos/huggingface/datasets/labels/dataset%20bug", "name": "dataset bug", "color": "2edb81", "default": false, "description": "A bug in a dataset script provided in the library"}]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/444/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/444
https://github.com/huggingface/datasets/issues/444
null
false
666,246,716
Cannot unpickle saved .pt dataset with torch.save()/load()
Saving a formatted torch dataset to file using `torch.save()`. Loading the same file fails during unpickling: ```python >>> import torch >>> import nlp >>> squad = nlp.load_dataset("squad.py", split="train") >>> squad Dataset(features: {'source_text': Value(dtype='string', id=None), 'target_text': Value(dtype...
closed
443
[ "This seems to be fixed in a non-released version. \r\n\r\nInstalling nlp from source\r\n```\r\ngit clone https://github.com/huggingface/nlp\r\ncd nlp\r\npip install .\r\n```\r\nsolves the issue. " ]
false
2020-07-27 12:13:37
2020-07-27 13:05:11
CONTRIBUTOR
vegarab
24,683,907
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/443/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/443
https://github.com/huggingface/datasets/issues/443
null
false
666,201,810
[Suggestion] Glue Diagnostic Data with Labels
Hello! First of all, thanks for setting up this useful project! I've just realised you provide the the [Glue Diagnostics Data](https://huggingface.co/nlp/viewer/?dataset=glue&config=ax) without labels, indicating in the `GlueConfig` that you've only a test set. Yet, the data with labels is available, too (see als...
open
442
[]
false
2020-07-27 10:59:58
2020-08-24 15:13:20
NONE
ggbetz
3,662,782
User
[{"id": 2067401494, "node_id": "MDU6TGFiZWwyMDY3NDAxNDk0", "url": "https://api.github.com/repos/huggingface/datasets/labels/Dataset%20discussion", "name": "Dataset discussion", "color": "72f99f", "default": false, "description": "Discussions on the datasets"}]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/442/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/442
https://github.com/huggingface/datasets/issues/442
null
false
666,148,413
Add features parameter in load dataset
Added `features` argument in `nlp.load_dataset`. If they don't match the data type, it raises a `ValueError`. It's a draft PR because #440 needs to be merged first.
closed
441
[ "This one is ready for review now", "I changed to using features only, instead of info.\r\nLet mw know if it sounds good to you now @thomwolf " ]
false
2020-07-27 09:50:01
2020-07-30 12:51:17
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/441/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/441
https://github.com/huggingface/datasets/pull/441
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/441", "html_url": "https://github.com/huggingface/datasets/pull/441", "diff_url": "https://github.com/huggingface/datasets/pull/441.diff", "patch_url": "https://github.com/huggingface/datasets/pull/441.patch", "merged_at": "2020-07-30T12:51:16Z"}
true
666,116,823
Fix user specified features in map
`.map` didn't keep the user specified features because of an issue in the writer. The writer used to overwrite the user specified features with inferred features. I also added tests to make sure it doesn't happen again.
closed
440
[]
false
2020-07-27 09:04:26
2020-07-28 09:25:23
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/440/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/440
https://github.com/huggingface/datasets/pull/440
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/440", "html_url": "https://github.com/huggingface/datasets/pull/440", "diff_url": "https://github.com/huggingface/datasets/pull/440.diff", "patch_url": "https://github.com/huggingface/datasets/pull/440.patch", "merged_at": "2020-07-28T09:25:22Z"}
true
665,964,673
Issues: Adding a FAISS or Elastic Search index to a Dataset
It seems the DPRContextEncoder, DPRContextEncoderTokenizer cited[ in this documentation](https://huggingface.co/nlp/faiss_and_ea.html) is not implemented ? It didnot work with the standard nlp installation . Also, I couldn't find or use it with the latest nlp install from github in Colab. Is there any dependency on t...
closed
439
[ "`DPRContextEncoder` and `DPRContextEncoderTokenizer` will be available in the next release of `transformers`.\r\n\r\nRight now you can experiment with it by installing `transformers` from the master branch.\r\nYou can also check the docs of DPR [here](https://huggingface.co/transformers/master/model_doc/dpr.html)....
false
2020-07-27 04:25:17
2020-10-28 01:46:24
NONE
nsankar
431,890
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/439/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/439
https://github.com/huggingface/datasets/issues/439
null
false
665,865,490
New Datasets: IWSLT15+, ITTB
**Links:** [iwslt](https://pytorchnlp.readthedocs.io/en/latest/_modules/torchnlp/datasets/iwslt.html) Don't know if that link is up to date. [ittb](http://www.cfilt.iitb.ac.in/iitb_parallel/) **Motivation**: replicate mbart finetuning results (table below) ![image](https://user-images.githubusercontent.com/60450...
open
438
[ "Thanks Sam, we now have a very detailed tutorial and template on how to add a new dataset to the library. It typically take 1-2 hours to add one. Do you want to give it a try ?\r\nThe tutorial on writing a new dataset loading script is here: https://huggingface.co/nlp/add_dataset.html\r\nAnd the part on how to sha...
false
2020-07-26 21:43:04
2020-08-24 15:12:15
CONTRIBUTOR
sshleifer
6,045,025
User
[{"id": 2067376369, "node_id": "MDU6TGFiZWwyMDY3Mzc2MzY5", "url": "https://api.github.com/repos/huggingface/datasets/labels/dataset%20request", "name": "dataset request", "color": "e99695", "default": false, "description": "Requesting to add a new dataset"}]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/438/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/438
https://github.com/huggingface/datasets/issues/438
null
false
665,597,176
Fix XTREME PAN-X loading
Hi 🤗 In response to the discussion in #425 @lewtun and I made some fixes to the repo. In the original XTREME implementation the PAN-X dataset for named entity recognition loaded each word/tag pair as a single row and the sentence relation was lost. With the fix each row contains the list of all words in a single sen...
closed
437
[ "There is an interesting design question here (cc @lhoestq).\r\n\r\nI guess the labels form a closed set so we could also use a [nlp.ClassLabel](https://huggingface.co/nlp/package_reference/main_classes.html#nlp.ClassLabel) instead of a string. The differences will be mainly that:\r\n- the labels are stored as inte...
false
2020-07-25 14:44:57
2020-07-30 08:28:15
MEMBER
lvwerra
8,264,887
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/437/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/437
https://github.com/huggingface/datasets/pull/437
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/437", "html_url": "https://github.com/huggingface/datasets/pull/437", "diff_url": "https://github.com/huggingface/datasets/pull/437.diff", "patch_url": "https://github.com/huggingface/datasets/pull/437.patch", "merged_at": "2020-07-30T08:28:15Z"}
true
665,582,167
Google Colab - load_dataset - PyArrow exception
With latest PyArrow 1.0.0 installed, I get the following exception . Restarting colab has the same issue ImportWarning: To use `nlp`, the module `pyarrow>=0.16.0` is required, and the current version of `pyarrow` doesn't match this condition. If you are running this in a Google Colab, you should probably just rest...
closed
436
[ "Indeed, we’ll make a new PyPi release next week to solve this. Cc @lhoestq ", "+1! this is the reason our tests are failing at [TextAttack](https://github.com/QData/TextAttack) \r\n\r\n(Though it's worth noting if we fixed the version number of pyarrow to 0.16.0 that would fix our problem too. But in this case w...
false
2020-07-25 13:05:20
2020-08-20 08:08:18
NONE
nsankar
431,890
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/436/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/436
https://github.com/huggingface/datasets/issues/436
null
false
665,507,141
ImportWarning for pyarrow 1.0.0
The following PR raised ImportWarning at `pyarrow ==1.0.0` https://github.com/huggingface/nlp/pull/265/files
closed
435
[ "This was fixed in #434 \r\nWe'll do a release later this week to include this fix.\r\nThanks for reporting", "I dont know if the fix was made but the problem is still present : \r\nInstaled with pip : NLP 0.3.0 // pyarrow 1.0.0 \r\nOS : archlinux with kernel zen 5.8.5", "Yes it was fixed in `nlp>=0.4.0`\r\nYou...
false
2020-07-25 03:44:39
2020-09-08 17:57:15
NONE
HanGuo97
18,187,806
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/435/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/435
https://github.com/huggingface/datasets/issues/435
null
false
665,477,638
Fixed check for pyarrow
Fix check for pyarrow in __init__.py. Previously would raise an error for pyarrow >= 1.0.0
closed
434
[ "Great, thanks!" ]
false
2020-07-25 00:16:53
2020-07-25 06:36:34
CONTRIBUTOR
nadahlberg
58,701,810
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/434/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/434
https://github.com/huggingface/datasets/pull/434
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/434", "html_url": "https://github.com/huggingface/datasets/pull/434", "diff_url": "https://github.com/huggingface/datasets/pull/434.diff", "patch_url": "https://github.com/huggingface/datasets/pull/434.patch", "merged_at": "2020-07-25T06:36:34Z"}
true
665,311,025
How to reuse functionality of a (generic) dataset?
I have written a generic dataset for corpora created with the Brat annotation tool ([specification](https://brat.nlplab.org/standoff.html), [dataset code](https://github.com/ArneBinder/nlp/blob/brat/datasets/brat/brat.py)). Now I wonder how to use that to create specific dataset instances. What's the recommended way to...
closed
433
[ "Hi @ArneBinder, we have a few \"generic\" datasets which are intended to load data files with a predefined format:\r\n- csv: https://github.com/huggingface/nlp/tree/master/datasets/csv\r\n- json: https://github.com/huggingface/nlp/tree/master/datasets/json\r\n- text: https://github.com/huggingface/nlp/tree/master/...
false
2020-07-24 17:27:37
2022-10-04 17:59:34
NONE
ArneBinder
3,375,489
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/433/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/433
https://github.com/huggingface/datasets/issues/433
null
false
665,234,340
Fix handling of config files while loading datasets from multiple processes
When loading shards on several processes, each process upon loading the dataset will overwrite dataset_infos.json in <package path>/datasets/<dataset name>/<hash>/dataset_infos.json. It does so every time, even when the target file already exists and is identical. Because multiple processes rewrite the same file in par...
closed
432
[ "Ok for this but I think we may want to use the general `filelock` method we are using at other places in the library instead of filecmp (in particular `filelock` take care of being an atomic operation which is safer for concurrent processes)", "Ok I see.\r\nWhy not use filelock in this case then ?", "I think w...
false
2020-07-24 15:10:57
2020-08-01 17:11:42
CONTRIBUTOR
orsharir
99,543
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/432/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/432
https://github.com/huggingface/datasets/pull/432
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/432", "html_url": "https://github.com/huggingface/datasets/pull/432", "diff_url": "https://github.com/huggingface/datasets/pull/432.diff", "patch_url": "https://github.com/huggingface/datasets/pull/432.patch", "merged_at": "2020-07-30T08:25:28Z"}
true
665,044,416
Specify split post processing + Add post processing resources downloading
Previously if you tried to do ```python from nlp import load_dataset wiki = load_dataset("wiki_dpr", "psgs_w100_with_nq_embeddings", split="train[:100]", with_index=True) ``` Then you'd get an error `Index size should match Dataset size...` This was because it was trying to use the full index (21M elements). ...
closed
431
[ "I was using a hack in `wiki_dpr` to download the index from GCS even for the configurations without the embeddings.\r\nHowever as GCS is something internal, I changed the logic to add a download step for indexes directly in the dataset script, using the `DownloadManager`.\r\n\r\nThis change was directly linked to ...
false
2020-07-24 09:29:19
2020-07-31 09:05:04
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/431/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/431
https://github.com/huggingface/datasets/pull/431
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/431", "html_url": "https://github.com/huggingface/datasets/pull/431", "diff_url": "https://github.com/huggingface/datasets/pull/431.diff", "patch_url": "https://github.com/huggingface/datasets/pull/431.patch", "merged_at": "2020-07-31T09:05:03Z"}
true