id
int64
599M
3.26B
title
stringlengths
1
290
body
stringlengths
0
228k
state
stringclasses
2 values
number
int64
1
7.7k
comments
listlengths
0
30
locked
bool
1 class
created_at
stringdate
2020-04-14 10:18:02
2025-07-24 19:46:28
updated_at
stringdate
2020-04-27 16:04:17
2025-07-25 11:56:51
author_association
stringclasses
4 values
user_login
stringlengths
3
26
user_id
int64
3.5k
219M
user_type
stringclasses
1 value
labels
stringclasses
81 values
reactions
stringlengths
191
197
url
stringlengths
58
61
html_url
stringlengths
46
51
pull_request
stringlengths
289
315
is_pull_request
bool
2 classes
618,869,048
[Newsroom] add newsroom
I checked it with the data link of the mail you forwarded @thomwolf => works well!
closed
125
[]
false
2020-05-15 10:34:34
2020-05-15 10:37:07
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/125/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/125
https://github.com/huggingface/datasets/pull/125
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/125", "html_url": "https://github.com/huggingface/datasets/pull/125", "diff_url": "https://github.com/huggingface/datasets/pull/125.diff", "patch_url": "https://github.com/huggingface/datasets/pull/125.patch", "merged_at": "2020-05-15T10:37:02Z"}
true
618,864,284
Xsum, require manual download of some files
closed
124
[]
false
2020-05-15 10:26:13
2020-05-15 11:04:48
CONTRIBUTOR
mariamabarham
38,249,783
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/124/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/124
https://github.com/huggingface/datasets/pull/124
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/124", "html_url": "https://github.com/huggingface/datasets/pull/124", "diff_url": "https://github.com/huggingface/datasets/pull/124.diff", "patch_url": "https://github.com/huggingface/datasets/pull/124.patch", "merged_at": "2020-05-15T11:04:46Z"}
true
618,820,140
[Tests] Local => aws
## Change default Test from local => aws As a default we set` aws=True`, `Local=False`, `slow=False` ### 1. RUN_AWS=1 (default) This runs 4 tests per dataset script. a) Does the dataset script have a valid etag / Can it be reached on AWS? b) Can we load its `builder_class`? c) Can we load **all** dataset c...
closed
123
[ "For each dataset, If there exist a `dataset_info.json`, then the command `nlp-cli test path/to/my/dataset --al_configs` is successful only if the `dataset_infos.json` is correct. The infos are correct if the size and checksums of the downloaded file are correct, and if the number of examples in each split are corr...
false
2020-05-15 09:12:25
2020-05-15 10:06:12
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/123/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/123
https://github.com/huggingface/datasets/pull/123
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/123", "html_url": "https://github.com/huggingface/datasets/pull/123", "diff_url": "https://github.com/huggingface/datasets/pull/123.diff", "patch_url": "https://github.com/huggingface/datasets/pull/123.patch", "merged_at": "2020-05-15T10:03:26Z"}
true
618,813,182
Final cleanup of readme and metrics
closed
122
[]
false
2020-05-15 09:00:52
2021-09-03 19:40:09
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/122/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/122
https://github.com/huggingface/datasets/pull/122
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/122", "html_url": "https://github.com/huggingface/datasets/pull/122", "diff_url": "https://github.com/huggingface/datasets/pull/122.diff", "patch_url": "https://github.com/huggingface/datasets/pull/122.patch", "merged_at": "2020-05-15T09:02:22Z"}
true
618,790,040
make style
closed
121
[]
false
2020-05-15 08:23:36
2020-05-15 08:25:39
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/121/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/121
https://github.com/huggingface/datasets/pull/121
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/121", "html_url": "https://github.com/huggingface/datasets/pull/121", "diff_url": "https://github.com/huggingface/datasets/pull/121.diff", "patch_url": "https://github.com/huggingface/datasets/pull/121.patch", "merged_at": "2020-05-15T08:25:38Z"}
true
618,737,783
🐛 `map` not working
I'm trying to run a basic example (mapping function to add a prefix). [Here is the colab notebook I'm using.](https://colab.research.google.com/drive/1YH4JCAy0R1MMSc-k_Vlik_s1LEzP_t1h?usp=sharing) ```python import nlp dataset = nlp.load_dataset('squad', split='validation[:10%]') def test(sample): samp...
closed
120
[ "I didn't assign the output 🤦‍♂️\r\n\r\n```python\r\ndataset.map(test)\r\n```\r\n\r\nshould be :\r\n\r\n```python\r\ndataset = dataset.map(test)\r\n```" ]
false
2020-05-15 06:43:08
2020-05-15 07:02:38
NONE
astariul
43,774,355
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/120/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/120
https://github.com/huggingface/datasets/issues/120
null
false
618,652,145
🐛 Colab : type object 'pyarrow.lib.RecordBatch' has no attribute 'from_struct_array'
I'm trying to load CNN/DM dataset on Colab. [Colab notebook](https://colab.research.google.com/drive/11Mf7iNhIyt6GpgA1dBEtg3cyMHmMhtZS?usp=sharing) But I meet this error : > AttributeError: type object 'pyarrow.lib.RecordBatch' has no attribute 'from_struct_array'
closed
119
[ "It's strange, after installing `nlp` on Colab, the `pyarrow` version seems fine from `pip` but not from python :\r\n\r\n```python\r\nimport pyarrow\r\n\r\n!pip show pyarrow\r\nprint(\"version = {}\".format(pyarrow.__version__))\r\n```\r\n\r\n> Name: pyarrow\r\nVersion: 0.17.0\r\nSummary: Python library for Apache ...
false
2020-05-15 02:27:26
2020-05-15 05:11:22
NONE
astariul
43,774,355
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/119/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/119
https://github.com/huggingface/datasets/issues/119
null
false
618,643,088
❓ How to apply a map to all subsets ?
I'm working with CNN/DM dataset, where I have 3 subsets : `train`, `test`, `validation`. Should I apply my map function on the subsets one by one ? ```python import nlp cnn_dm = nlp.load_dataset('cnn_dailymail') for corpus in ['train', 'test', 'validation']: cnn_dm[corpus] = cnn_dm[corpus].map(my_f...
closed
118
[ "That's the way!" ]
false
2020-05-15 01:58:52
2020-05-15 07:05:49
NONE
astariul
43,774,355
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/118/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/118
https://github.com/huggingface/datasets/issues/118
null
false
618,632,573
❓ How to remove specific rows of a dataset ?
I saw on the [example notebook](https://colab.research.google.com/github/huggingface/nlp/blob/master/notebooks/Overview.ipynb#scrollTo=efFhDWhlvSVC) how to remove a specific column : ```python dataset.drop('id') ``` But I didn't find how to remove a specific row. **For example, how can I remove all sample w...
closed
117
[ "Hi, you can't do that at the moment.", "Can you do it by now? Coz it would be awfully helpful!", "you can convert dataset object to pandas and remove a feature and convert back to dataset .", "That's what I ended up doing too. but it feels like a workaround to a feature that should be added to the datasets c...
false
2020-05-15 01:25:06
2022-07-15 08:36:44
NONE
astariul
43,774,355
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/117/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/117
https://github.com/huggingface/datasets/issues/117
null
false
618,628,264
🐛 Trying to use ROUGE metric : pyarrow.lib.ArrowInvalid: Column 1 named references expected length 534 but got length 323
I'm trying to use rouge metric. I have to files : `test.pred.tokenized` and `test.gold.tokenized` with each line containing a sentence. I tried : ```python import nlp rouge = nlp.load_metric('rouge') with open("test.pred.tokenized") as p, open("test.gold.tokenized") as g: for lp, lg in zip(p, g): ...
closed
116
[ "Can you share your data files or a minimally reproducible example?", "Sure, [here is a Colab notebook](https://colab.research.google.com/drive/1uiS89fnHMG7HV_cYxp3r-_LqJQvNNKs9?usp=sharing) reproducing the error.\r\n\r\n> ArrowInvalid: Column 1 named references expected length 36 but got length 56", "This is b...
false
2020-05-15 01:12:06
2020-05-28 23:43:07
NONE
astariul
43,774,355
User
[{"id": 2067393914, "node_id": "MDU6TGFiZWwyMDY3MzkzOTE0", "url": "https://api.github.com/repos/huggingface/datasets/labels/metric%20bug", "name": "metric bug", "color": "25b21e", "default": false, "description": "A bug in a metric script"}]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/116/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/116
https://github.com/huggingface/datasets/issues/116
null
false
618,615,855
AttributeError: 'dict' object has no attribute 'info'
I'm trying to access the information of CNN/DM dataset : ```python cnn_dm = nlp.load_dataset('cnn_dailymail') print(cnn_dm.info) ``` returns : > AttributeError: 'dict' object has no attribute 'info'
closed
115
[ "I could access the info by first accessing the different splits :\r\n\r\n```python\r\nimport nlp\r\n\r\ncnn_dm = nlp.load_dataset('cnn_dailymail')\r\nprint(cnn_dm['train'].info)\r\n```\r\n\r\nInformation seems to be duplicated between the subsets :\r\n\r\n```python\r\nprint(cnn_dm[\"train\"].info == cnn_dm[\"test\...
false
2020-05-15 00:29:47
2020-05-17 13:11:00
NONE
astariul
43,774,355
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/115/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/115
https://github.com/huggingface/datasets/issues/115
null
false
618,611,310
Couldn't reach CNN/DM dataset
I can't get CNN / DailyMail dataset. ```python import nlp assert "cnn_dailymail" in [dataset.id for dataset in nlp.list_datasets()] cnn_dm = nlp.load_dataset('cnn_dailymail') ``` [Colab notebook](https://colab.research.google.com/drive/1zQ3bYAVzm1h0mw0yWPqKAg_4EUlSx5Ex?usp=sharing) gives following error ...
closed
114
[ "Installing from source (instead of Pypi package) solved the problem." ]
false
2020-05-15 00:16:17
2020-05-15 00:19:52
NONE
astariul
43,774,355
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/114/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/114
https://github.com/huggingface/datasets/issues/114
null
false
618,590,562
Adding docstrings and some doc
Some doc
closed
113
[]
false
2020-05-14 23:14:41
2020-05-14 23:22:45
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/113/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/113
https://github.com/huggingface/datasets/pull/113
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/113", "html_url": "https://github.com/huggingface/datasets/pull/113", "diff_url": "https://github.com/huggingface/datasets/pull/113.diff", "patch_url": "https://github.com/huggingface/datasets/pull/113.patch", "merged_at": "2020-05-14T23:22:44Z"}
true
618,569,195
Qa4mre - add dataset
Added dummy data test only for the first config. Will do the rest later. I had to do add some minor hacks to an important function to make it work. There might be a cleaner way to handle it - can you take a look @thomwolf ?
closed
112
[]
false
2020-05-14 22:17:51
2020-05-15 09:16:43
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/112/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/112
https://github.com/huggingface/datasets/pull/112
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/112", "html_url": "https://github.com/huggingface/datasets/pull/112", "diff_url": "https://github.com/huggingface/datasets/pull/112.diff", "patch_url": "https://github.com/huggingface/datasets/pull/112.patch", "merged_at": "2020-05-15T09:16:42Z"}
true
618,528,060
[Clean-up] remove under construction datastes
closed
111
[]
false
2020-05-14 20:52:13
2020-05-14 20:52:23
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/111/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/111
https://github.com/huggingface/datasets/pull/111
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/111", "html_url": "https://github.com/huggingface/datasets/pull/111", "diff_url": "https://github.com/huggingface/datasets/pull/111.diff", "patch_url": "https://github.com/huggingface/datasets/pull/111.patch", "merged_at": "2020-05-14T20:52:22Z"}
true
618,520,325
fix reddit tifu dummy data
closed
110
[]
false
2020-05-14 20:37:37
2020-05-14 20:40:14
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/110/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/110
https://github.com/huggingface/datasets/pull/110
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/110", "html_url": "https://github.com/huggingface/datasets/pull/110", "diff_url": "https://github.com/huggingface/datasets/pull/110.diff", "patch_url": "https://github.com/huggingface/datasets/pull/110.patch", "merged_at": "2020-05-14T20:40:13Z"}
true
618,508,359
[Reclor] fix reclor
- That's probably one me. Could have made the manual data test more flexible. @mariamabarham
closed
109
[]
false
2020-05-14 20:16:26
2020-05-14 20:19:09
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/109/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/109
https://github.com/huggingface/datasets/pull/109
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/109", "html_url": "https://github.com/huggingface/datasets/pull/109", "diff_url": "https://github.com/huggingface/datasets/pull/109.diff", "patch_url": "https://github.com/huggingface/datasets/pull/109.patch", "merged_at": "2020-05-14T20:19:08Z"}
true
618,386,394
convert can use manual dir as second argument
@mariamabarham
closed
108
[]
false
2020-05-14 16:52:32
2020-05-14 16:52:43
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/108/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/108
https://github.com/huggingface/datasets/pull/108
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/108", "html_url": "https://github.com/huggingface/datasets/pull/108", "diff_url": "https://github.com/huggingface/datasets/pull/108.diff", "patch_url": "https://github.com/huggingface/datasets/pull/108.patch", "merged_at": "2020-05-14T16:52:42Z"}
true
618,373,045
add writer_batch_size to GeneratorBasedBuilder
You can now specify `writer_batch_size` in the builder arguments or directly in `load_dataset`
closed
107
[ "Awesome that's great!" ]
false
2020-05-14 16:35:39
2020-05-14 16:50:30
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/107/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/107
https://github.com/huggingface/datasets/pull/107
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/107", "html_url": "https://github.com/huggingface/datasets/pull/107", "diff_url": "https://github.com/huggingface/datasets/pull/107.diff", "patch_url": "https://github.com/huggingface/datasets/pull/107.patch", "merged_at": "2020-05-14T16:50:29Z"}
true
618,361,418
Add data dir test command
closed
106
[ "Nice - I think we can merge this. I will update the checksums for `wikihow` then as well" ]
false
2020-05-14 16:18:39
2020-05-14 16:49:11
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/106/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/106
https://github.com/huggingface/datasets/pull/106
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/106", "html_url": "https://github.com/huggingface/datasets/pull/106", "diff_url": "https://github.com/huggingface/datasets/pull/106.diff", "patch_url": "https://github.com/huggingface/datasets/pull/106.patch", "merged_at": "2020-05-14T16:49:10Z"}
true
618,345,191
[New structure on AWS] Adapt paths
Some small changes so that we have the correct paths. @julien-c
closed
105
[]
false
2020-05-14 15:55:57
2020-05-14 15:56:28
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/105/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/105
https://github.com/huggingface/datasets/pull/105
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/105", "html_url": "https://github.com/huggingface/datasets/pull/105", "diff_url": "https://github.com/huggingface/datasets/pull/105.diff", "patch_url": "https://github.com/huggingface/datasets/pull/105.patch", "merged_at": "2020-05-14T15:56:27Z"}
true
618,277,081
Add trivia_q
Currently tested only for one config to pass tests. Needs to add more dummy data later.
closed
104
[]
false
2020-05-14 14:27:19
2020-07-12 05:34:20
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/104/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/104
https://github.com/huggingface/datasets/pull/104
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/104", "html_url": "https://github.com/huggingface/datasets/pull/104", "diff_url": "https://github.com/huggingface/datasets/pull/104.diff", "patch_url": "https://github.com/huggingface/datasets/pull/104.patch", "merged_at": "2020-05-14T20:23:32Z"}
true
618,233,637
[Manual downloads] add logic proposal for manual downloads and add wikihow
Wikihow is an example that needs to manually download two files as stated in: https://github.com/mahnazkoupaee/WikiHow-Dataset. The user can then store these files under a hard-coded name: `wikihowAll.csv` and `wikihowSep.csv` in this case in a directory of his choice, e.g. `~/wikihow/manual_dir`. The dataset ca...
closed
103
[ "> Wikihow is an example that needs to manually download two files as stated in: https://github.com/mahnazkoupaee/WikiHow-Dataset.\r\n> \r\n> The user can then store these files under a hard-coded name: `wikihowAll.csv` and `wikihowSep.csv` in this case in a directory of his choice, e.g. `~/wikihow/manual_dir`.\r\n...
false
2020-05-14 13:30:36
2020-05-14 14:27:41
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/103/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/103
https://github.com/huggingface/datasets/pull/103
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/103", "html_url": "https://github.com/huggingface/datasets/pull/103", "diff_url": "https://github.com/huggingface/datasets/pull/103.diff", "patch_url": "https://github.com/huggingface/datasets/pull/103.patch", "merged_at": "2020-05-14T14:27:40Z"}
true
618,231,216
Run save infos
I replaced the old checksum file with the new `dataset_infos.json` by running the script on almost all the datasets we have. The only one that is still running on my side is the cornell dialog
closed
102
[ "Haha that cornell dialogue dataset - that ran for 3h on my computer as well. The `generate_examples` method in this script is one of the most inefficient code samples I've ever seen :D ", "Indeed it's been 3 hours already\r\n```73111 examples [3:07:48, 2.40 examples/s]```" ]
false
2020-05-14 13:27:26
2020-05-14 15:43:04
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/102/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/102
https://github.com/huggingface/datasets/pull/102
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/102", "html_url": "https://github.com/huggingface/datasets/pull/102", "diff_url": "https://github.com/huggingface/datasets/pull/102.diff", "patch_url": "https://github.com/huggingface/datasets/pull/102.patch", "merged_at": "2020-05-14T15:43:03Z"}
true
618,111,651
[Reddit] add reddit
- Everything worked fine @mariamabarham. Made my computer nearly crash, but all seems to be working :-)
closed
101
[]
false
2020-05-14 10:25:02
2020-05-14 10:27:25
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/101/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/101
https://github.com/huggingface/datasets/pull/101
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/101", "html_url": "https://github.com/huggingface/datasets/pull/101", "diff_url": "https://github.com/huggingface/datasets/pull/101.diff", "patch_url": "https://github.com/huggingface/datasets/pull/101.patch", "merged_at": "2020-05-14T10:27:24Z"}
true
618,081,602
Add per type scores in seqeval metric
This PR add a bit more detail in the seqeval metric. Now the usage and output are: ```python import nlp met = nlp.load_metric('metrics/seqeval') references = [['O', 'O', 'O', 'B-MISC', 'I-MISC', 'I-MISC', 'O'], ['B-PER', 'I-PER', 'O']] predictions = [['O', 'O', 'B-MISC', 'I-MISC', 'I-MISC', 'I-MISC', 'O'], ['B-...
closed
100
[ "LGTM :-) Some small suggestions to shorten the code a bit :-) ", "Can you put the kwargs as normal kwargs instead of a dict? (And add them to the kwargs description As well)", "@thom Is-it what you meant?", "Yes and there is a dynamically generated doc string in the metric script KWARGS DESCRIPTION" ]
false
2020-05-14 09:37:52
2020-05-14 23:21:35
CONTRIBUTOR
jplu
959,590
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/100/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/100
https://github.com/huggingface/datasets/pull/100
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/100", "html_url": "https://github.com/huggingface/datasets/pull/100", "diff_url": "https://github.com/huggingface/datasets/pull/100.diff", "patch_url": "https://github.com/huggingface/datasets/pull/100.patch", "merged_at": "2020-05-14T23:21:34Z"}
true
618,026,700
[Cmrc 2018] fix cmrc2018
closed
99
[]
false
2020-05-14 08:22:03
2020-05-14 08:49:42
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/99/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/99
https://github.com/huggingface/datasets/pull/99
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/99", "html_url": "https://github.com/huggingface/datasets/pull/99", "diff_url": "https://github.com/huggingface/datasets/pull/99.diff", "patch_url": "https://github.com/huggingface/datasets/pull/99.patch", "merged_at": "2020-05-14T08:49:41Z"}
true
617,957,739
Webis tl-dr
Add the Webid TL:DR dataset.
closed
98
[ "Should that rather be in an organization scope, @thomwolf @patrickvonplaten ?", "> Should that rather be in an organization scope, @thomwolf @patrickvonplaten ?\r\n\r\nI'm a bit indifferent - both would be fine for me!", "@jplu - if creating the dummy_data is too tedious, I can do it as well :-) ", "There is...
false
2020-05-14 06:22:18
2020-09-03 10:00:21
CONTRIBUTOR
jplu
959,590
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/98/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/98
https://github.com/huggingface/datasets/pull/98
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/98", "html_url": "https://github.com/huggingface/datasets/pull/98", "diff_url": "https://github.com/huggingface/datasets/pull/98.diff", "patch_url": "https://github.com/huggingface/datasets/pull/98.patch", "merged_at": "2020-05-14T20:54:15Z"}
true
617,809,431
[Csv] add tests for csv dataset script
Adds dummy data tests for csv.
closed
97
[ "@thomwolf - can you check and merge if ok? " ]
false
2020-05-13 23:06:11
2020-05-13 23:23:16
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/97/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/97
https://github.com/huggingface/datasets/pull/97
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/97", "html_url": "https://github.com/huggingface/datasets/pull/97", "diff_url": "https://github.com/huggingface/datasets/pull/97.diff", "patch_url": "https://github.com/huggingface/datasets/pull/97.patch", "merged_at": "2020-05-13T23:23:15Z"}
true
617,739,521
lm1b
Add lm1b dataset.
closed
96
[ "I might have a different version of `isort` than others. It seems like I'm always reordering the imports of others. But isn't really a problem..." ]
false
2020-05-13 20:38:44
2020-05-14 14:13:30
CONTRIBUTOR
jplu
959,590
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/96/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/96
https://github.com/huggingface/datasets/pull/96
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/96", "html_url": "https://github.com/huggingface/datasets/pull/96", "diff_url": "https://github.com/huggingface/datasets/pull/96.diff", "patch_url": "https://github.com/huggingface/datasets/pull/96.patch", "merged_at": "2020-05-14T14:13:29Z"}
true
617,703,037
Replace checksums files by Dataset infos json
### Better verifications when loading a dataset I replaced the `urls_checksums` directory that used to contain `checksums.txt` and `cached_sizes.txt`, by a single file `dataset_infos.json`. It's just a dict `config_name` -> `DatasetInfo`. It simplifies and improves how verifications of checksums and splits sizes ...
closed
95
[ "Great! LGTM :-) ", "> Ok, really clean!\r\n> I like the logic (not a huge fan of using `_asdict_inner` but it makes sense).\r\n> I think it's a nice improvement!\r\n> \r\n> How should we update the files in the repo? Run a big job on a server or on somebody's computer who has most of the datasets already downloa...
false
2020-05-13 19:36:16
2020-05-14 08:58:43
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/95/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/95
https://github.com/huggingface/datasets/pull/95
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/95", "html_url": "https://github.com/huggingface/datasets/pull/95", "diff_url": "https://github.com/huggingface/datasets/pull/95.diff", "patch_url": "https://github.com/huggingface/datasets/pull/95.patch", "merged_at": "2020-05-14T08:58:42Z"}
true
617,571,340
Librispeech
Add librispeech dataset and remove some useless content.
closed
94
[ "@jplu - I changed this weird archieve - iter method to something simpler. It's only one file to download anyways so I don't see the point of using weird iter methods...It's a huge file though :D 30 million lines of text. Took me quite some time to download :D " ]
false
2020-05-13 16:04:14
2020-05-13 21:29:03
CONTRIBUTOR
jplu
959,590
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/94/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/94
https://github.com/huggingface/datasets/pull/94
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/94", "html_url": "https://github.com/huggingface/datasets/pull/94", "diff_url": "https://github.com/huggingface/datasets/pull/94.diff", "patch_url": "https://github.com/huggingface/datasets/pull/94.patch", "merged_at": "2020-05-13T21:29:02Z"}
true
617,522,029
Cleanup notebooks and various fixes
Fixes on dataset (more flexible) metrics (fix) and general clean ups
closed
93
[]
false
2020-05-13 14:58:58
2020-05-13 15:01:48
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/93/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/93
https://github.com/huggingface/datasets/pull/93
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/93", "html_url": "https://github.com/huggingface/datasets/pull/93", "diff_url": "https://github.com/huggingface/datasets/pull/93.diff", "patch_url": "https://github.com/huggingface/datasets/pull/93.patch", "merged_at": "2020-05-13T15:01:47Z"}
true
617,341,505
[WIP] add wmt14
WMT14 takes forever to download :-/ - WMT is the first dataset that uses an abstract class IMO, so I had to modify the `load_dataset_module` a bit.
closed
92
[]
false
2020-05-13 10:42:03
2020-05-16 11:17:38
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/92/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/92
https://github.com/huggingface/datasets/pull/92
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/92", "html_url": "https://github.com/huggingface/datasets/pull/92", "diff_url": "https://github.com/huggingface/datasets/pull/92.diff", "patch_url": "https://github.com/huggingface/datasets/pull/92.patch", "merged_at": "2020-05-16T11:17:37Z"}
true
617,339,484
[Paracrawl] add paracrawl
- Huge dataset - took ~1h to download - Also this PR reformats all dataset scripts and adds `datasets` to `make style`
closed
91
[]
false
2020-05-13 10:39:00
2020-05-13 10:40:15
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/91/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/91
https://github.com/huggingface/datasets/pull/91
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/91", "html_url": "https://github.com/huggingface/datasets/pull/91", "diff_url": "https://github.com/huggingface/datasets/pull/91.diff", "patch_url": "https://github.com/huggingface/datasets/pull/91.patch", "merged_at": "2020-05-13T10:40:14Z"}
true
617,311,877
Add download gg drive
We can now add datasets that download from google drive
closed
90
[ "awesome - so no manual downloaded needed here? ", "Yes exactly. It works like a standard download" ]
false
2020-05-13 09:56:02
2020-05-13 12:46:28
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/90/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/90
https://github.com/huggingface/datasets/pull/90
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/90", "html_url": "https://github.com/huggingface/datasets/pull/90", "diff_url": "https://github.com/huggingface/datasets/pull/90.diff", "patch_url": "https://github.com/huggingface/datasets/pull/90.patch", "merged_at": "2020-05-13T10:05:31Z"}
true
617,295,069
Add list and inspect methods - cleanup hf_api
Add a bunch of methods to easily list and inspect the processing scripts up-loaded on S3: ```python nlp.list_datasets() nlp.list_metrics() # Copy and prepare the scripts at `local_path` for easy inspection/modification. nlp.inspect_dataset(path, local_path) # Copy and prepare the scripts at `local_path` for easy...
closed
89
[]
false
2020-05-13 09:30:15
2020-05-13 14:05:00
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/89/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/89
https://github.com/huggingface/datasets/pull/89
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/89", "html_url": "https://github.com/huggingface/datasets/pull/89", "diff_url": "https://github.com/huggingface/datasets/pull/89.diff", "patch_url": "https://github.com/huggingface/datasets/pull/89.patch", "merged_at": "2020-05-13T09:33:10Z"}
true
617,284,664
Add wiki40b
This one is a beam dataset that downloads files using tensorflow. I tested it on a small config and it works fine
closed
88
[ "Looks good to me. I have not really looked too much into the Beam Datasets yet though - so I think you can merge whenever you think is good for Beam datasets :-) " ]
false
2020-05-13 09:16:01
2020-05-13 12:31:55
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/88/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/88
https://github.com/huggingface/datasets/pull/88
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/88", "html_url": "https://github.com/huggingface/datasets/pull/88", "diff_url": "https://github.com/huggingface/datasets/pull/88.diff", "patch_url": "https://github.com/huggingface/datasets/pull/88.patch", "merged_at": "2020-05-13T12:31:54Z"}
true
617,267,118
Add Flores
Beautiful language for sure!
closed
87
[]
false
2020-05-13 08:51:29
2020-05-13 09:23:34
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/87/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/87
https://github.com/huggingface/datasets/pull/87
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/87", "html_url": "https://github.com/huggingface/datasets/pull/87", "diff_url": "https://github.com/huggingface/datasets/pull/87.diff", "patch_url": "https://github.com/huggingface/datasets/pull/87.patch", "merged_at": "2020-05-13T09:23:33Z"}
true
617,260,972
[Load => load_dataset] change naming
Rename leftovers @thomwolf
closed
86
[]
false
2020-05-13 08:43:00
2020-05-13 08:50:58
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/86/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/86
https://github.com/huggingface/datasets/pull/86
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/86", "html_url": "https://github.com/huggingface/datasets/pull/86", "diff_url": "https://github.com/huggingface/datasets/pull/86.diff", "patch_url": "https://github.com/huggingface/datasets/pull/86.patch", "merged_at": "2020-05-13T08:50:57Z"}
true
617,253,428
Add boolq
I just added the dummy data for this dataset. This one was uses `tf.io.gfile.copy` to download the data but I added the support for custom download in the mock_download_manager. I also had to add a `tensorflow` dependency for tests.
closed
85
[ "Awesome :-) Thanks for adding the function to the Mock DL Manager" ]
false
2020-05-13 08:32:27
2020-05-13 09:09:39
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/85/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/85
https://github.com/huggingface/datasets/pull/85
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/85", "html_url": "https://github.com/huggingface/datasets/pull/85", "diff_url": "https://github.com/huggingface/datasets/pull/85.diff", "patch_url": "https://github.com/huggingface/datasets/pull/85.patch", "merged_at": "2020-05-13T09:09:38Z"}
true
617,249,815
[TedHrLr] add left dummy data
closed
84
[]
false
2020-05-13 08:27:20
2020-05-13 08:29:22
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/84/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/84
https://github.com/huggingface/datasets/pull/84
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/84", "html_url": "https://github.com/huggingface/datasets/pull/84", "diff_url": "https://github.com/huggingface/datasets/pull/84.diff", "patch_url": "https://github.com/huggingface/datasets/pull/84.patch", "merged_at": "2020-05-13T08:29:21Z"}
true
616,863,601
New datasets
closed
83
[]
false
2020-05-12 18:22:27
2020-05-12 18:22:47
CONTRIBUTOR
mariamabarham
38,249,783
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/83/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/83
https://github.com/huggingface/datasets/pull/83
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/83", "html_url": "https://github.com/huggingface/datasets/pull/83", "diff_url": "https://github.com/huggingface/datasets/pull/83.diff", "patch_url": "https://github.com/huggingface/datasets/pull/83.patch", "merged_at": "2020-05-12T18:22:45Z"}
true
616,805,194
[Datasets] add ted_hrlr
@thomwolf - After looking at `xnli` I think it's better to leave the translation features and add a `translation` key to make them work in our framework. The result looks like this: ![Screenshot from 2020-05-12 18-34-43](https://user-images.githubusercontent.com/23423619/81721933-ee1faf00-9480-11ea-9e95-d6557cbd0c...
closed
82
[]
false
2020-05-12 16:46:50
2020-05-13 07:52:54
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/82/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/82
https://github.com/huggingface/datasets/pull/82
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/82", "html_url": "https://github.com/huggingface/datasets/pull/82", "diff_url": "https://github.com/huggingface/datasets/pull/82.diff", "patch_url": "https://github.com/huggingface/datasets/pull/82.patch", "merged_at": "2020-05-13T07:52:52Z"}
true
616,793,010
add tests
Tests for py_utils functions and for the BaseReader used to read from arrow and parquet. I also removed unused utils functions.
closed
81
[]
false
2020-05-12 16:28:19
2020-05-13 07:43:57
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/81/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/81
https://github.com/huggingface/datasets/pull/81
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/81", "html_url": "https://github.com/huggingface/datasets/pull/81", "diff_url": "https://github.com/huggingface/datasets/pull/81.diff", "patch_url": "https://github.com/huggingface/datasets/pull/81.patch", "merged_at": "2020-05-13T07:43:56Z"}
true
616,786,803
Add nbytes + nexamples check
### Save size and number of examples Now when you do `save_checksums`, it also create `cached_sizes.txt` right next to the checksum file. This new file stores the bytes sizes and the number of examples of each split that has been prepared and stored in the cache. Example: ``` # Cached sizes: <full_config_name> <n...
closed
80
[ "Looks good to me! Should we hard code those numbers in the config classes and make sure that when loading a dataset that the numbers match? " ]
false
2020-05-12 16:18:43
2020-05-13 07:52:34
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/80/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/80
https://github.com/huggingface/datasets/pull/80
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/80", "html_url": "https://github.com/huggingface/datasets/pull/80", "diff_url": "https://github.com/huggingface/datasets/pull/80.diff", "patch_url": "https://github.com/huggingface/datasets/pull/80.patch", "merged_at": "2020-05-13T07:52:33Z"}
true
616,785,613
[Convert] add new pattern
closed
79
[]
false
2020-05-12 16:16:51
2020-05-12 16:17:10
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/79/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/79
https://github.com/huggingface/datasets/pull/79
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/79", "html_url": "https://github.com/huggingface/datasets/pull/79", "diff_url": "https://github.com/huggingface/datasets/pull/79.diff", "patch_url": "https://github.com/huggingface/datasets/pull/79.patch", "merged_at": "2020-05-12T16:17:09Z"}
true
616,774,275
[Tests] skip beam dataset tests for now
For now we will skip tests for Beam Datasets
closed
78
[ "@lhoestq - I moved the wkipedia file to the \"correct\" folder. ", "Nice thanks !" ]
false
2020-05-12 16:00:58
2020-05-12 16:16:24
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/78/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/78
https://github.com/huggingface/datasets/pull/78
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/78", "html_url": "https://github.com/huggingface/datasets/pull/78", "diff_url": "https://github.com/huggingface/datasets/pull/78.diff", "patch_url": "https://github.com/huggingface/datasets/pull/78.patch", "merged_at": "2020-05-12T16:16:22Z"}
true
616,674,601
New datasets
closed
77
[]
false
2020-05-12 13:51:59
2020-05-12 14:02:16
CONTRIBUTOR
mariamabarham
38,249,783
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/77/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/77
https://github.com/huggingface/datasets/pull/77
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/77", "html_url": "https://github.com/huggingface/datasets/pull/77", "diff_url": "https://github.com/huggingface/datasets/pull/77.diff", "patch_url": "https://github.com/huggingface/datasets/pull/77.patch", "merged_at": "2020-05-12T14:02:15Z"}
true
616,579,228
pin flake 8
Flake 8's new version does not like our format. Pinning the version for now.
closed
76
[]
false
2020-05-12 11:25:29
2020-05-12 11:27:35
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/76/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/76
https://github.com/huggingface/datasets/pull/76
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/76", "html_url": "https://github.com/huggingface/datasets/pull/76", "diff_url": "https://github.com/huggingface/datasets/pull/76.diff", "patch_url": "https://github.com/huggingface/datasets/pull/76.patch", "merged_at": "2020-05-12T11:27:34Z"}
true
616,520,163
WIP adding metrics
Adding the following metrics as identified by @mariamabarham: 1. BLEU: BiLingual Evaluation Understudy: https://github.com/tensorflow/nmt/blob/master/nmt/scripts/bleu.py, https://github.com/chakki-works/sumeval/blob/master/sumeval/metrics/bleu.py (multilingual) 2. GLEU: Google-BLEU: https://github.com/cnap/gec-...
closed
75
[ "It's all about my metric stuff so I'll probably merge it unless you want to have a look.\r\n\r\nTook the occasion to remove the old doc and requirements.txt" ]
false
2020-05-12 09:52:00
2020-05-13 07:44:12
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/75/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/75
https://github.com/huggingface/datasets/pull/75
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/75", "html_url": "https://github.com/huggingface/datasets/pull/75", "diff_url": "https://github.com/huggingface/datasets/pull/75.diff", "patch_url": "https://github.com/huggingface/datasets/pull/75.patch", "merged_at": "2020-05-13T07:44:10Z"}
true
616,511,101
fix overflow check
I did some tests and unfortunately the test ``` pa_array.nbytes > MAX_BATCH_BYTES ``` doesn't work. Indeed for a StructArray, `nbytes` can be less 2GB even if there is an overflow (it loops...). I don't think we can do a proper overflow test for the limit of 2GB... For now I replaced it with a sanity check on...
closed
74
[]
false
2020-05-12 09:38:01
2020-05-12 10:04:39
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/74/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/74
https://github.com/huggingface/datasets/pull/74
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/74", "html_url": "https://github.com/huggingface/datasets/pull/74", "diff_url": "https://github.com/huggingface/datasets/pull/74.diff", "patch_url": "https://github.com/huggingface/datasets/pull/74.patch", "merged_at": "2020-05-12T10:04:37Z"}
true
616,417,845
JSON script
Add a JSONS script to read JSON datasets from files.
closed
73
[ "The tests for the Wikipedia dataset do not pass anymore with the error:\r\n```\r\nTo be able to use this dataset, you need to install the following dependencies ['mwparserfromhell'] using 'pip install mwparserfromhell' for instance'\r\n```", "This was an issue on master. You can just rebase from master.", "Per...
false
2020-05-12 07:11:22
2020-05-18 06:50:37
CONTRIBUTOR
jplu
959,590
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/73/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/73
https://github.com/huggingface/datasets/pull/73
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/73", "html_url": "https://github.com/huggingface/datasets/pull/73", "diff_url": "https://github.com/huggingface/datasets/pull/73.diff", "patch_url": "https://github.com/huggingface/datasets/pull/73.patch", "merged_at": "2020-05-18T06:50:36Z"}
true
616,225,010
[README dummy data tests] README to better understand how the dummy data structure works
In this PR a README.md is added to tests to shine more light on how the dummy data structure works. I try to explain the different possible cases. IMO the best way to understand the logic is to checkout the dummy data structure of the different datasets I mention in the README.md since those are the "edge cases". @...
closed
72
[]
false
2020-05-11 22:19:03
2020-05-11 22:26:03
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/72/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/72
https://github.com/huggingface/datasets/pull/72
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/72", "html_url": "https://github.com/huggingface/datasets/pull/72", "diff_url": "https://github.com/huggingface/datasets/pull/72.diff", "patch_url": "https://github.com/huggingface/datasets/pull/72.patch", "merged_at": "2020-05-11T22:26:01Z"}
true
615,942,180
Fix arrow writer for big datasets using writer_batch_size
This PR fixes Yacine's bug. According to [this](https://github.com/apache/arrow/blob/master/docs/source/cpp/arrays.rst#size-limitations-and-recommendations), it is not recommended to have pyarrow arrays bigger than 2Go. Therefore I set a default batch size of 100 000 examples per batch. In general it shouldn't exce...
closed
71
[ "After a quick chat with Yacine : the 2Go test may not be sufficient actually, as I'm looking at the size of the array and not the size of the current_rows. If the test doesn't do the job I think I'll remove it and lower the batch size a bit to be sure that it never exceeds 2Go. I'll do more tests later" ]
false
2020-05-11 14:45:36
2020-05-11 20:09:47
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/71/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/71
https://github.com/huggingface/datasets/pull/71
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/71", "html_url": "https://github.com/huggingface/datasets/pull/71", "diff_url": "https://github.com/huggingface/datasets/pull/71.diff", "patch_url": "https://github.com/huggingface/datasets/pull/71.patch", "merged_at": "2020-05-11T20:00:38Z"}
true
615,679,102
adding RACE, QASC, Super_glue and Tiny_shakespear datasets
closed
70
[ "I think rebasing to master will solve the quality test and the datasets that don't have a testing structure yet because of the manual download - maybe you can put them in `datasets under construction`? Then would also make it easier for me to see how to add tests for them :-) " ]
false
2020-05-11 08:07:49
2020-05-12 13:21:52
CONTRIBUTOR
mariamabarham
38,249,783
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/70/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/70
https://github.com/huggingface/datasets/pull/70
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/70", "html_url": "https://github.com/huggingface/datasets/pull/70", "diff_url": "https://github.com/huggingface/datasets/pull/70.diff", "patch_url": "https://github.com/huggingface/datasets/pull/70.patch", "merged_at": "2020-05-12T13:21:51Z"}
true
615,450,534
fix cache dir in builder tests
minor fix
closed
69
[ "Nice, is that the reason one cannot rerun the tests without deleting the cache? \r\n", "Yes exactly. It was not using the temporary dir for tests." ]
false
2020-05-10 18:39:21
2020-05-11 07:19:30
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/69/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/69
https://github.com/huggingface/datasets/pull/69
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/69", "html_url": "https://github.com/huggingface/datasets/pull/69", "diff_url": "https://github.com/huggingface/datasets/pull/69.diff", "patch_url": "https://github.com/huggingface/datasets/pull/69.patch", "merged_at": "2020-05-11T07:19:28Z"}
true
614,882,655
[CSV] re-add csv
Re-adding csv under the datasets under construction to keep circle ci happy - will have to see how to include it in the tests. @lhoestq noticed that I accidently deleted it in https://github.com/huggingface/nlp/pull/63#discussion_r422263729.
closed
68
[]
false
2020-05-08 17:38:29
2020-05-08 17:40:48
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/68/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/68
https://github.com/huggingface/datasets/pull/68
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/68", "html_url": "https://github.com/huggingface/datasets/pull/68", "diff_url": "https://github.com/huggingface/datasets/pull/68.diff", "patch_url": "https://github.com/huggingface/datasets/pull/68.patch", "merged_at": "2020-05-08T17:40:46Z"}
true
614,798,483
[Tests] Test files locally
This PR adds a `aws` and a `local` decorator to the tests so that tests now run on the local datasets. By default, the `aws` is deactivated and `local` is activated and `slow` is deactivated, so that only 1 test per dataset runs on circle ci. **When local is activated all folders in `./datasets` are tested.** ...
closed
67
[ "Super nice, good job @patrickvonplaten!" ]
false
2020-05-08 15:02:43
2020-05-08 19:50:47
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/67/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/67
https://github.com/huggingface/datasets/pull/67
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/67", "html_url": "https://github.com/huggingface/datasets/pull/67", "diff_url": "https://github.com/huggingface/datasets/pull/67.diff", "patch_url": "https://github.com/huggingface/datasets/pull/67.patch", "merged_at": "2020-05-08T15:17:00Z"}
true
614,748,552
[Datasets] ReadME
closed
66
[]
false
2020-05-08 13:37:43
2020-05-08 13:39:23
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/66/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/66
https://github.com/huggingface/datasets/pull/66
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/66", "html_url": "https://github.com/huggingface/datasets/pull/66", "diff_url": "https://github.com/huggingface/datasets/pull/66.diff", "patch_url": "https://github.com/huggingface/datasets/pull/66.patch", "merged_at": "2020-05-08T13:39:22Z"}
true
614,746,516
fix math dataset and xcopa
- fixes math dataset and xcopa, uploaded both of the to S3
closed
65
[]
false
2020-05-08 13:33:55
2020-05-08 13:35:41
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/65/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/65
https://github.com/huggingface/datasets/pull/65
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/65", "html_url": "https://github.com/huggingface/datasets/pull/65", "diff_url": "https://github.com/huggingface/datasets/pull/65.diff", "patch_url": "https://github.com/huggingface/datasets/pull/65.patch", "merged_at": "2020-05-08T13:35:40Z"}
true
614,737,057
[Datasets] Make master ready for datasets adding
Add all relevant files so that datasets can now be added on master
closed
64
[]
false
2020-05-08 13:17:00
2020-05-08 13:17:31
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/64/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/64
https://github.com/huggingface/datasets/pull/64
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/64", "html_url": "https://github.com/huggingface/datasets/pull/64", "diff_url": "https://github.com/huggingface/datasets/pull/64.diff", "patch_url": "https://github.com/huggingface/datasets/pull/64.patch", "merged_at": "2020-05-08T13:17:30Z"}
true
614,666,365
[Dataset scripts] add all datasets scripts
As mentioned, we can have the canonical datasets in the master. For now I also want to include all the data as present on S3 to make the synchronization easier when uploading new datastes. @mariamabarham @lhoestq @thomwolf - what do you think? If this is ok for you, I can sync up the master with the `add_datase...
closed
63
[]
false
2020-05-08 10:50:15
2020-05-08 17:39:22
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/63/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/63
https://github.com/huggingface/datasets/pull/63
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/63", "html_url": "https://github.com/huggingface/datasets/pull/63", "diff_url": "https://github.com/huggingface/datasets/pull/63.diff", "patch_url": "https://github.com/huggingface/datasets/pull/63.patch", "merged_at": "2020-05-08T11:34:00Z"}
true
614,630,830
[Cached Path] Better error message
IMO returning `None` in this function only leads to confusion and is never helpful.
closed
62
[]
false
2020-05-08 09:39:47
2020-05-08 09:45:47
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/62/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/62
https://github.com/huggingface/datasets/pull/62
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/62", "html_url": "https://github.com/huggingface/datasets/pull/62", "diff_url": "https://github.com/huggingface/datasets/pull/62.diff", "patch_url": "https://github.com/huggingface/datasets/pull/62.patch", "merged_at": null}
true
614,607,474
[Load] rename setup_module to prepare_module
rename setup_module to prepare_module due to issues with pytests `setup_module` function. See: PR #59.
closed
61
[]
false
2020-05-08 08:54:22
2020-05-08 08:56:32
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/61/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/61
https://github.com/huggingface/datasets/pull/61
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/61", "html_url": "https://github.com/huggingface/datasets/pull/61", "diff_url": "https://github.com/huggingface/datasets/pull/61.diff", "patch_url": "https://github.com/huggingface/datasets/pull/61.patch", "merged_at": "2020-05-08T08:56:16Z"}
true
614,372,553
Update to simplify some datasets conversion
This PR updates the encoding of `Values` like `integers`, `boolean` and `float` to use python casting and avoid having to cast in the dataset scripts, as mentioned here: https://github.com/huggingface/nlp/pull/37#discussion_r420176626 We could also change (not included in this PR yet): - `supervized_keys` to make t...
closed
60
[ "Awesome! ", "Also we should convert `tf.io.gfile.exists` into `os.path.exists` , `tf.io.gfile.listdir`into `os.listdir` and `tf.io.gfile.glob` into `glob.glob` (will need to add `import glob`)", "> Also we should convert `tf.io.gfile.exists` into `os.path.exists` , `tf.io.gfile.listdir`into `os.listdir` and `...
false
2020-05-07 22:02:24
2020-05-08 10:38:32
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/60/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/60
https://github.com/huggingface/datasets/pull/60
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/60", "html_url": "https://github.com/huggingface/datasets/pull/60", "diff_url": "https://github.com/huggingface/datasets/pull/60.diff", "patch_url": "https://github.com/huggingface/datasets/pull/60.patch", "merged_at": "2020-05-08T10:18:24Z"}
true
614,366,045
Fix tests
@patrickvonplaten I've broken a bit the tests with #25 while simplifying and re-organizing the `load.py` and `download_manager.py` scripts. I'm trying to fix them here but I have a weird error, do you think you can have a look? ```bash (datasets) MacBook-Pro-de-Thomas:datasets thomwolf$ python -m pytest -sv ./test...
closed
59
[ "I can fix the tests tomorrow :-) ", "Very weird bug indeed! I think the problem was that when importing `setup_module` we overwrote `pytest's` setup_module function. I think this is the relevant code in pytest: https://github.com/pytest-dev/pytest/blob/9d2eabb397b059b75b746259daeb20ee5588f559/src/_pytest/python....
false
2020-05-07 21:48:09
2020-05-08 10:57:57
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/59/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/59
https://github.com/huggingface/datasets/pull/59
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/59", "html_url": "https://github.com/huggingface/datasets/pull/59", "diff_url": "https://github.com/huggingface/datasets/pull/59.diff", "patch_url": "https://github.com/huggingface/datasets/pull/59.patch", "merged_at": "2020-05-08T10:46:51Z"}
true
614,362,308
Aborted PR - Fix tests
@patrickvonplaten I've broken a bit the tests with #25 while simplifying and re-organizing the `load.py` and `download_manager.py` scripts. I'm trying to fix them here but I have a weird error, do you think you can have a look? ```bash (datasets) MacBook-Pro-de-Thomas:datasets thomwolf$ python -m pytest -sv ./test...
closed
58
[ "Wait I messed up my branch, let me clean this." ]
false
2020-05-07 21:40:19
2020-05-07 21:48:01
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/58/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/58
https://github.com/huggingface/datasets/pull/58
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/58", "html_url": "https://github.com/huggingface/datasets/pull/58", "diff_url": "https://github.com/huggingface/datasets/pull/58.diff", "patch_url": "https://github.com/huggingface/datasets/pull/58.patch", "merged_at": null}
true
614,261,638
Better cached path
### Changes: - The `cached_path` no longer returns None if the file is missing/the url doesn't work. Instead, it can raise `FileNotFoundError` (missing file), `ConnectionError` (no cache and unreachable url) or `ValueError` (parsing error) - Fix requests to firebase API that doesn't handle HEAD requests... - Allow c...
closed
57
[ "I should have read this PR before doing my own: https://github.com/huggingface/nlp/pull/62 :D \r\nwill close mine. Looks great :-) ", "> Awesome, this is really nice!\r\n> \r\n> By the way, we should improve the `cached_path` method of the `transformers` repo similarly, don't you think (@patrickvonplaten in part...
false
2020-05-07 18:36:00
2020-05-08 13:20:30
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/57/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/57
https://github.com/huggingface/datasets/pull/57
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/57", "html_url": "https://github.com/huggingface/datasets/pull/57", "diff_url": "https://github.com/huggingface/datasets/pull/57.diff", "patch_url": "https://github.com/huggingface/datasets/pull/57.patch", "merged_at": "2020-05-08T13:20:28Z"}
true
614,236,869
[Dataset] Tester add mock function
need to add an empty `extract()` function to make `hansard` dataset test work.
closed
56
[]
false
2020-05-07 17:51:37
2020-05-07 17:52:51
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/56/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/56
https://github.com/huggingface/datasets/pull/56
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/56", "html_url": "https://github.com/huggingface/datasets/pull/56", "diff_url": "https://github.com/huggingface/datasets/pull/56.diff", "patch_url": "https://github.com/huggingface/datasets/pull/56.patch", "merged_at": "2020-05-07T17:52:50Z"}
true
613,968,072
Beam datasets
# Beam datasets ## Intro Beam Datasets are using beam pipelines for preprocessing (basically lots of `.map` over objects called PCollections). The advantage of apache beam is that you can choose which type of runner you want to use to preprocess your data. The main runners are: - the `DirectRunner` to run the p...
closed
55
[ "Right now the changes are a bit hard to read as the one from #25 are also included. You can wait until #25 is merged before looking at the implementation details", "Nice!! I tested it a bit and works quite well. I will do a my review once the #25 will be merged because there are several overlaps.\r\n\r\nAt least...
false
2020-05-07 11:04:32
2020-05-11 07:20:02
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/55/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/55
https://github.com/huggingface/datasets/pull/55
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/55", "html_url": "https://github.com/huggingface/datasets/pull/55", "diff_url": "https://github.com/huggingface/datasets/pull/55.diff", "patch_url": "https://github.com/huggingface/datasets/pull/55.patch", "merged_at": "2020-05-11T07:20:00Z"}
true
613,513,348
[Tests] Improved Error message for dummy folder structure
Improved Error message
closed
54
[]
false
2020-05-06 18:11:48
2020-05-06 18:13:00
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/54/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/54
https://github.com/huggingface/datasets/pull/54
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/54", "html_url": "https://github.com/huggingface/datasets/pull/54", "diff_url": "https://github.com/huggingface/datasets/pull/54.diff", "patch_url": "https://github.com/huggingface/datasets/pull/54.patch", "merged_at": "2020-05-06T18:12:59Z"}
true
613,436,158
[Features] Typo in generate_from_dict
Change `isinstance` test in features when generating features from dict.
closed
53
[]
false
2020-05-06 16:05:23
2020-05-07 15:28:46
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/53/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/53
https://github.com/huggingface/datasets/pull/53
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/53", "html_url": "https://github.com/huggingface/datasets/pull/53", "diff_url": "https://github.com/huggingface/datasets/pull/53.diff", "patch_url": "https://github.com/huggingface/datasets/pull/53.patch", "merged_at": "2020-05-07T15:28:45Z"}
true
613,339,071
allow dummy folder structure to handle dict of lists
`esnli.py` needs that extension of the dummy data testing.
closed
52
[]
false
2020-05-06 13:54:35
2020-05-06 13:55:19
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/52/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/52
https://github.com/huggingface/datasets/pull/52
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/52", "html_url": "https://github.com/huggingface/datasets/pull/52", "diff_url": "https://github.com/huggingface/datasets/pull/52.diff", "patch_url": "https://github.com/huggingface/datasets/pull/52.patch", "merged_at": "2020-05-06T13:55:18Z"}
true
613,266,668
[Testing] Improved testing structure
This PR refactors the test design a bit and puts the mock download manager in the `utils` files as it is just a test helper class. as @mariamabarham pointed out, creating a dummy folder structure can be quite hard to grasp. This PR tries to change that to some extent. It follows the following logic for the `dumm...
closed
51
[ "Awesome!\r\nLet's have this in the doc at the end :-)" ]
false
2020-05-06 12:03:07
2020-05-07 22:07:19
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/51/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/51
https://github.com/huggingface/datasets/pull/51
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/51", "html_url": "https://github.com/huggingface/datasets/pull/51", "diff_url": "https://github.com/huggingface/datasets/pull/51.diff", "patch_url": "https://github.com/huggingface/datasets/pull/51.patch", "merged_at": "2020-05-06T13:20:17Z"}
true
612,583,126
[Tests] test only for fast test as a default
Test only for one config on circle ci to speed up testing. Add all config test as a slow test. @mariamabarham @thomwolf
closed
50
[ "Test failure is not related to change in test file.\r\n" ]
false
2020-05-05 12:59:22
2020-05-05 13:02:18
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/50/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/50
https://github.com/huggingface/datasets/pull/50
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/50", "html_url": "https://github.com/huggingface/datasets/pull/50", "diff_url": "https://github.com/huggingface/datasets/pull/50.diff", "patch_url": "https://github.com/huggingface/datasets/pull/50.patch", "merged_at": "2020-05-05T13:02:16Z"}
true
612,545,483
fix flatten nested
closed
49
[]
false
2020-05-05 11:55:13
2020-05-05 13:59:26
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/49/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/49
https://github.com/huggingface/datasets/pull/49
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/49", "html_url": "https://github.com/huggingface/datasets/pull/49", "diff_url": "https://github.com/huggingface/datasets/pull/49.diff", "patch_url": "https://github.com/huggingface/datasets/pull/49.patch", "merged_at": "2020-05-05T13:59:25Z"}
true
612,504,687
[Command Convert] remove tensorflow import
Remove all tensorflow import statements.
closed
48
[]
false
2020-05-05 10:41:00
2020-05-05 11:13:58
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/48/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/48
https://github.com/huggingface/datasets/pull/48
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/48", "html_url": "https://github.com/huggingface/datasets/pull/48", "diff_url": "https://github.com/huggingface/datasets/pull/48.diff", "patch_url": "https://github.com/huggingface/datasets/pull/48.patch", "merged_at": "2020-05-05T11:13:56Z"}
true
612,446,493
[PyArrow Feature] fix py arrow bool
To me it seems that `bool` can only be accessed with `bool_` when looking at the pyarrow types: https://arrow.apache.org/docs/python/api/datatypes.html.
closed
47
[]
false
2020-05-05 08:56:28
2020-05-05 10:40:28
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/47/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/47
https://github.com/huggingface/datasets/pull/47
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/47", "html_url": "https://github.com/huggingface/datasets/pull/47", "diff_url": "https://github.com/huggingface/datasets/pull/47.diff", "patch_url": "https://github.com/huggingface/datasets/pull/47.patch", "merged_at": "2020-05-05T10:40:27Z"}
true
612,398,190
[Features] Strip str key before dict look-up
The dataset `anli.py` currently fails because it tries to look up a key `1\n` in a dict that only has the key `1`. Added an if statement to strip key if it cannot be found in dict.
closed
46
[]
false
2020-05-05 07:31:45
2020-05-05 08:37:45
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/46/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/46
https://github.com/huggingface/datasets/pull/46
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/46", "html_url": "https://github.com/huggingface/datasets/pull/46", "diff_url": "https://github.com/huggingface/datasets/pull/46.diff", "patch_url": "https://github.com/huggingface/datasets/pull/46.patch", "merged_at": "2020-05-05T08:37:44Z"}
true
612,386,583
[Load] Separate Module kwargs and builder kwargs.
Kwargs for the `load_module` fn should be passed with `module_xxxx` to `builder_kwargs` of `load` fn. This is a follow-up PR of: https://github.com/huggingface/nlp/pull/41
closed
45
[]
false
2020-05-05 07:09:54
2022-10-04 09:32:11
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/45/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/45
https://github.com/huggingface/datasets/pull/45
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/45", "html_url": "https://github.com/huggingface/datasets/pull/45", "diff_url": "https://github.com/huggingface/datasets/pull/45.diff", "patch_url": "https://github.com/huggingface/datasets/pull/45.patch", "merged_at": null}
true
611,873,486
[Tests] Fix tests for datasets with no config
Forgot to fix `None` problem for datasets that have no config this in PR: https://github.com/huggingface/nlp/pull/42
closed
44
[]
false
2020-05-04 13:25:38
2020-05-04 13:28:04
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/44/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/44
https://github.com/huggingface/datasets/pull/44
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/44", "html_url": "https://github.com/huggingface/datasets/pull/44", "diff_url": "https://github.com/huggingface/datasets/pull/44.diff", "patch_url": "https://github.com/huggingface/datasets/pull/44.patch", "merged_at": "2020-05-04T13:28:03Z"}
true
611,773,279
[Checksums] If no configs exist prevent to run over empty list
`movie_rationales` e.g. has no configs.
closed
43
[ "Whoops I fixed it directly on master before checking that you have done it in this PR. We may close it", "Yeah, I saw :-) But I think we should add this as well since some datasets have an empty list of configs and then as the code is now it would fail. \r\n\r\nIn this PR, I just make sure that the code jumps in...
false
2020-05-04 10:39:42
2022-10-04 09:32:02
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/43/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/43
https://github.com/huggingface/datasets/pull/43
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/43", "html_url": "https://github.com/huggingface/datasets/pull/43", "diff_url": "https://github.com/huggingface/datasets/pull/43.diff", "patch_url": "https://github.com/huggingface/datasets/pull/43.patch", "merged_at": null}
true
611,754,343
[Tests] allow tests for builders without config
Some dataset scripts have no configs - the tests have to be adapted for this case. In this case the dummy data will be saved as: - natural_questions -> dummy -> -> 1.0.0 (version num) -> -> -> dummy_data.zip
closed
42
[]
false
2020-05-04 10:06:22
2020-05-04 13:10:50
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/42/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/42
https://github.com/huggingface/datasets/pull/42
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/42", "html_url": "https://github.com/huggingface/datasets/pull/42", "diff_url": "https://github.com/huggingface/datasets/pull/42.diff", "patch_url": "https://github.com/huggingface/datasets/pull/42.patch", "merged_at": "2020-05-04T13:10:48Z"}
true
611,739,219
[Load module] allow kwargs into load module
Currenly it is not possible to force a re-download of the dataset script. This simple change allows to pass ``force_reload=True`` as ``builder_kwargs`` in the ``load.py`` function.
closed
41
[]
false
2020-05-04 09:42:11
2020-05-04 19:39:07
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/41/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/41
https://github.com/huggingface/datasets/pull/41
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/41", "html_url": "https://github.com/huggingface/datasets/pull/41", "diff_url": "https://github.com/huggingface/datasets/pull/41.diff", "patch_url": "https://github.com/huggingface/datasets/pull/41.patch", "merged_at": "2020-05-04T19:39:06Z"}
true
611,721,308
Update remote checksums instead of overwrite
When the user uploads a dataset on S3, checksums are also uploaded with the `--upload_checksums` parameter. If the user uploads the dataset in several steps, then the remote checksums file was previously overwritten. Now it's going to be updated with the new checksums.
closed
40
[]
false
2020-05-04 09:13:14
2020-05-04 11:51:51
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/40/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/40
https://github.com/huggingface/datasets/pull/40
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/40", "html_url": "https://github.com/huggingface/datasets/pull/40", "diff_url": "https://github.com/huggingface/datasets/pull/40.diff", "patch_url": "https://github.com/huggingface/datasets/pull/40.patch", "merged_at": "2020-05-04T11:51:49Z"}
true
611,712,135
[Test] improve slow testing
closed
39
[]
false
2020-05-04 08:58:33
2020-05-04 08:59:50
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/39/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/39
https://github.com/huggingface/datasets/pull/39
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/39", "html_url": "https://github.com/huggingface/datasets/pull/39", "diff_url": "https://github.com/huggingface/datasets/pull/39.diff", "patch_url": "https://github.com/huggingface/datasets/pull/39.patch", "merged_at": "2020-05-04T08:59:49Z"}
true
611,677,656
[Checksums] Error for some datasets
The checksums command works very nicely for `squad`. But for `crime_and_punish` and `xnli`, the same bug happens: When running: ``` python nlp-cli nlp-cli test xnli --save_checksums ``` leads to: ``` File "nlp-cli", line 33, in <module> service.run() File "/home/patrick/python_bin/nlp/commands...
closed
38
[ "@lhoestq - could you take a look? It's not very urgent though!", "Fixed with 06882b4\r\n\r\nNow your command works :)\r\nNote that you can also do\r\n```\r\nnlp-cli test datasets/nlp/xnli --save_checksums\r\n```\r\nSo that it will save the checksums directly in the right directory.", "Awesome!" ]
false
2020-05-04 08:00:16
2020-05-04 09:48:20
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/38/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/38
https://github.com/huggingface/datasets/issues/38
null
false
611,670,295
[Datasets ToDo-List] add datasets
## Description This PR acts as a dashboard to see which datasets are added to the library and work. Cicle-ci should always be green so that we can be sure that newly added datasets are functional. This PR should not be merged. ## Progress **For the following datasets the test commands**: ``` RUN_SLOW...
closed
37
[ "Note:\r\n```\r\nnlp-cli test datasets/nlp/<your-dataset-folder> --save_checksums --all_configs\r\n```\r\ndirectly saves the checksums in the right place, and runs for all the dataset configurations.", "@patrickvonplaten can you provide the add the link to the PR for the dummy data? ", "https://github.com/huggi...
false
2020-05-04 07:47:39
2022-10-04 09:32:17
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/37/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/37
https://github.com/huggingface/datasets/pull/37
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/37", "html_url": "https://github.com/huggingface/datasets/pull/37", "diff_url": "https://github.com/huggingface/datasets/pull/37.diff", "patch_url": "https://github.com/huggingface/datasets/pull/37.patch", "merged_at": null}
true
611,528,349
Metrics - refactoring, adding support for download and distributed metrics
Refactoring metrics to have a similar loading API than the datasets and improving the import system. # Import system The import system has ben upgraded. There are now three types of imports allowed: 1. `library` imports (identified as "absolute imports") ```python import seqeval ``` => we'll test all the impor...
closed
36
[ "Ok, this one seems to be ready to merge.", "> Really cool, I love it! I would just raise a tiny point, the distributive version of the metrics might not work properly with TF because it is a different way to do, why not to add a \"framework\" detection and raise warning when TF is used, saying something like \"n...
false
2020-05-03 23:00:17
2020-05-11 08:16:02
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/36/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/36
https://github.com/huggingface/datasets/pull/36
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/36", "html_url": "https://github.com/huggingface/datasets/pull/36", "diff_url": "https://github.com/huggingface/datasets/pull/36.diff", "patch_url": "https://github.com/huggingface/datasets/pull/36.patch", "merged_at": "2020-05-11T08:16:00Z"}
true
611,413,731
[Tests] fix typo
@lhoestq - currently the slow test fail with: ``` _____________________________________________________________________________________ DatasetTest.test_load_real_dataset_xnli _____________________________________________________________________________________ ...
closed
35
[]
false
2020-05-03 13:23:49
2020-05-03 13:24:21
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/35/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 1}
https://api.github.com/repos/huggingface/datasets/issues/35
https://github.com/huggingface/datasets/pull/35
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/35", "html_url": "https://github.com/huggingface/datasets/pull/35", "diff_url": "https://github.com/huggingface/datasets/pull/35.diff", "patch_url": "https://github.com/huggingface/datasets/pull/35.patch", "merged_at": "2020-05-03T13:24:20Z"}
true
611,385,516
[Tests] add slow tests
This PR adds a slow test that downloads the "real" dataset. The test is decorated as "slow" so that it will not automatically run on circle ci. Before uploading a dataset, one should test that this test passes, manually by running ``` RUN_SLOW=1 pytest tests/test_dataset_common.py::DatasetTest::test_load_real_d...
closed
34
[]
false
2020-05-03 11:01:22
2020-05-03 12:18:30
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/34/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/34
https://github.com/huggingface/datasets/pull/34
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/34", "html_url": "https://github.com/huggingface/datasets/pull/34", "diff_url": "https://github.com/huggingface/datasets/pull/34.diff", "patch_url": "https://github.com/huggingface/datasets/pull/34.patch", "merged_at": "2020-05-03T12:18:29Z"}
true
611,052,081
Big cleanup/refactoring for clean serialization
This PR cleans many base classes to re-build them as `dataclasses`. We can thus use a simple serialization workflow for `DatasetInfo`, including it's `Features` and `SplitDict` based on `dataclasses` `asdict()`. The resulting code is a lot shorter, can be easily serialized/deserialized, dataset info are human-readab...
closed
33
[ "Great! I think when this merged, we can merge sure that Circle Ci stays happy when uploading new datasets. " ]
false
2020-05-01 23:45:57
2020-05-03 12:17:34
MEMBER
thomwolf
7,353,373
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/33/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/33
https://github.com/huggingface/datasets/pull/33
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/33", "html_url": "https://github.com/huggingface/datasets/pull/33", "diff_url": "https://github.com/huggingface/datasets/pull/33.diff", "patch_url": "https://github.com/huggingface/datasets/pull/33.patch", "merged_at": "2020-05-03T12:17:33Z"}
true
610,715,580
Fix map caching notebooks
Previously, caching results with `.map()` didn't work in notebooks. To reuse a result, `.map()` serializes the functions with `dill.dumps` and then it hashes it. The problem is that when using `dill.dumps` to serialize a function, it also saves its origin (filename + line no.) and the origin of all the `globals` th...
closed
32
[]
false
2020-05-01 11:55:26
2020-05-03 12:15:58
MEMBER
lhoestq
42,851,186
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/32/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/32
https://github.com/huggingface/datasets/pull/32
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/32", "html_url": "https://github.com/huggingface/datasets/pull/32", "diff_url": "https://github.com/huggingface/datasets/pull/32.diff", "patch_url": "https://github.com/huggingface/datasets/pull/32.patch", "merged_at": "2020-05-03T12:15:57Z"}
true
610,677,641
[Circle ci] Install a virtual env before running tests
Install a virtual env before running tests to not running into sudo issues when dynamically downloading files. Same number of tests now pass / fail as on my local computer: ![Screenshot from 2020-05-01 12-14-44](https://user-images.githubusercontent.com/23423619/80798814-8a0a0a80-8ba5-11ea-8db8-599d33bbfccd.png) ...
closed
31
[]
false
2020-05-01 10:11:17
2020-05-01 22:06:16
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/31/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/31
https://github.com/huggingface/datasets/pull/31
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/31", "html_url": "https://github.com/huggingface/datasets/pull/31", "diff_url": "https://github.com/huggingface/datasets/pull/31.diff", "patch_url": "https://github.com/huggingface/datasets/pull/31.patch", "merged_at": "2020-05-01T22:06:15Z"}
true
610,549,072
add metrics which require download files from github
To download files from github, I copied the `load_dataset_module` and its dependencies (without the builder) in `load.py` to `metrics/metric_utils.py`. I made the following changes: - copy the needed files in a folder`metric_name` - delete all other files that are not needed For metrics that require an external...
closed
30
[]
false
2020-05-01 04:13:22
2022-10-04 09:31:58
CONTRIBUTOR
mariamabarham
38,249,783
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/30/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/30
https://github.com/huggingface/datasets/pull/30
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/30", "html_url": "https://github.com/huggingface/datasets/pull/30", "diff_url": "https://github.com/huggingface/datasets/pull/30.diff", "patch_url": "https://github.com/huggingface/datasets/pull/30.patch", "merged_at": null}
true
610,243,997
Hf_api small changes
From Patrick: ```python from nlp import hf_api api = hf_api.HfApi() api.dataset_list() ``` works :-)
closed
29
[ "Ok merging! I think it's good now" ]
false
2020-04-30 17:06:43
2020-04-30 19:51:45
MEMBER
julien-c
326,577
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/29/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/29
https://github.com/huggingface/datasets/pull/29
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/29", "html_url": "https://github.com/huggingface/datasets/pull/29", "diff_url": "https://github.com/huggingface/datasets/pull/29.diff", "patch_url": "https://github.com/huggingface/datasets/pull/29.patch", "merged_at": "2020-04-30T19:51:44Z"}
true
610,241,907
[Circle ci] Adds circle ci config
@thomwolf can you take a look and set up circle ci on: https://app.circleci.com/projects/project-dashboard/github/huggingface I think for `nlp` only admins can set it up, which I guess is you :-)
closed
28
[]
false
2020-04-30 17:03:35
2020-04-30 19:51:09
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/28/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/28
https://github.com/huggingface/datasets/pull/28
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/28", "html_url": "https://github.com/huggingface/datasets/pull/28", "diff_url": "https://github.com/huggingface/datasets/pull/28.diff", "patch_url": "https://github.com/huggingface/datasets/pull/28.patch", "merged_at": "2020-04-30T19:51:08Z"}
true
610,230,476
[Cleanup] Removes all files in testing except test_dataset_common
As far as I know, all files in `tests` were old `tfds test files` so I removed them. We can still look them up on the other library.
closed
27
[]
false
2020-04-30 16:45:21
2020-04-30 17:39:25
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/27/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/27
https://github.com/huggingface/datasets/pull/27
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/27", "html_url": "https://github.com/huggingface/datasets/pull/27", "diff_url": "https://github.com/huggingface/datasets/pull/27.diff", "patch_url": "https://github.com/huggingface/datasets/pull/27.patch", "merged_at": "2020-04-30T17:39:23Z"}
true
610,226,047
[Tests] Clean tests
the abseil testing library (https://abseil.io/docs/python/quickstart.html) is better than the one I had before, so I decided to switch to that and changed the `setup.py` config file. Abseil has more support and a cleaner API for parametrized testing I think. I added a list of all dataset scripts that are currentl...
closed
26
[]
false
2020-04-30 16:38:29
2020-04-30 20:12:04
CONTRIBUTOR
patrickvonplaten
23,423,619
User
[]
{"url": "https://api.github.com/repos/huggingface/datasets/issues/26/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}
https://api.github.com/repos/huggingface/datasets/issues/26
https://github.com/huggingface/datasets/pull/26
{"url": "https://api.github.com/repos/huggingface/datasets/pulls/26", "html_url": "https://github.com/huggingface/datasets/pull/26", "diff_url": "https://github.com/huggingface/datasets/pull/26.diff", "patch_url": "https://github.com/huggingface/datasets/pull/26.patch", "merged_at": "2020-04-30T20:12:03Z"}
true