number
int64
1
3.63k
content
stringlengths
4
240k
comments
list
3,627
Wrong colors on Cairo renderer : ## Description of bug / unexpected behavior <!-- Add a clear and concise description of the problem you encountered. --> Running the quickstart example in the wiki generates wrong colors (using Cairo renderer) ## Expected behavior <!-- Add a clear and concise description of what y...
[ "I cannot reproduce your problem... you should not need to use `renderer=cairo` since this is the default setting, but with and without everything renders just fine on my system... On the other hand I don't know your operating system, but if this was a general problem in Manim it would have been reported a long tim...
3,626
Bump cryptography from 42.0.0 to 42.0.2 : Bumps [cryptography](https://github.com/pyca/cryptography) from 42.0.0 to 42.0.2. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst">cryptography's changelog</a>.</em></p> <blockquote> <p>42.0.2 - 20...
[ "Superseded by #3629." ]
3,623
Ipython notebook mime type media embed changes : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? <!-- If there is more information than the PR title th...
[ "duplicate of #3618?" ]
3,621
Run `poetry lock --no-update` : After the merging of #3524 running `poetry install` I get a warning about `poetry.lock` being out of sync with `pyproject.toml`. The root cause stems from `mapbox-earcut` being removed in the PR mentioned above. This PR is basically just running `poetry lock --no-update`.
[]
3,617
"AttributeError: 'list' object has no attribute 'reshape'" when use OpenGL renderer to transform a math LaTeX formula to another : ## Description of bug / unexpected behavior <!-- Add a clear and concise description of the problem you encountered. --> My manim version is 0.18.0. I got `AttributeError: 'list' object ...
[ "I came here to look if anyone else has posted thisโ€”I found #3278 as the same thing as well. It prevents being able to use `Transform` on text Mobjects.\r\n\r\n@behackl put up a review that covers the same fix as you mention." ]
3,613
fix type hint of indication.py : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? <!-- If there is more information than the PR title that should be add...
[]
3,611
Fix error in Windows CI pipeline : see title. problem appears in recent runs, e.g. https://github.com/ManimCommunity/manim/actions/runs/7749104954/job/21132994064?pr=3429
[]
3,610
Problems with preparing metadata for skia-pathops : #### Preliminaries - [x] I have followed the latest version of the [installation instructions](https://docs.manim.community/en/stable/installation.html). - [x] I have checked the [installation FAQ](https://docs.manim.community/en/stable/faq/installation.htm...
[ "This is not an issue with manim itself, but with installing one of its dependencies, `skia-pathops`. There are prebuilt wheels for most OS/architecture combinations (see https://pypi.org/project/skia-pathops/0.7.4/#files), but it seems none are provided for your platform.\r\n\r\nYou can try and `pip install skia-p...
3,605
IndexError: list index out of range : from manim import * class GaussianElimination(Scene): def construct(self): # Define the augmented matrix matrix = [[1, 3, -2, 0, 2, 0], [2, 6, -5, -2, 4, -3], [0, 0, 5, 10, 0, 15], [2, 6, 0, 8, 4, 18...
[ "without analyzing your weirdly formatted code deeper (after putting it into executable form) I would say that something must be wrong in your Gauss elimination function:\r\n\r\n![image](https://github.com/ManimCommunity/manim/assets/8582807/483364d1-480b-4219-b45b-225ea428d407)\r\n", "Indeed, this tries to acces...
3,603
`align_to` misbehavior after `move_to` : If I align an object to another with `align_to`, then move it somewhere else with `move_to`, and finally re-align it to the same initial object with `align_to`, the last call has no effect. ```python a = Square() b = Circle().move_to(RIGHT*3) # so they're not on top of eac...
[ "I believe you need to supply us with more context, because the following code just works fine:\r\n\r\n```py\r\nclass align(Scene):\r\n def construct(self):\r\n a = Square()\r\n b = Circle().move_to(RIGHT*3) # so they're not on top of each other\r\n self.add(a,b)\r\n self.wait()\r\n ...
3,602
Getting error for dvisvgm : Hi everybody. ## Description of bug / unexpected behavior I just installed manim and tried making a little scene with it. It doesn't render. Here is my dvisvgm -l ```shell dvisvgm -l bgcolor background color special color complete support of color specials dvisvgm ...
[ "There have been issues with some previous versions of dvisvgm which are not caused by manim, since this is an external tool. Try to follow the suggestion and update your dvisvgm - I have version 3.1.2 and it works.\r\n\r\nhttps://dvisvgm.de/\r\n\r\nOn the other hand I have no experience with TiniTex either and wou...
3,601
The line of NumberLine disappears when applying a LaggedStart on its components : ## Description of bug / unexpected behavior When trying to use a LaggedStart animation - or Succession - to make a sequential rotation on the labels of a NumberLine, the drawn line of the NumberLine is - I guess visually - removed. ...
[ "yes, both `NumberLine()` and `Axes()` behave weirdly sometimes. There is something wrong with the organization of the submobjects.\r\nFor an animation like yours I anyway would recommend to use your own compound object rather than the `NumberLine`, and for the rotation of the whole structure I would use an updater...
3,599
Fix `get_arc_center()` returning reference of point : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? <!-- If there is more information than the PR tit...
[]
3,598
Add ref_class for `BooleanOperations` in Example Gallery : Adds the ref class `Difference` for the Boolean Operation in Example Scenes [https://manimce--3598.org.readthedocs.build/en/3598/examples.html#booleanoperations](https://manimce--3598.org.readthedocs.build/en/3598/examples.html#booleanoperations)
[]
3,596
Cannot render text normally : ## Description unexpected behavior Do not render text normally. ## Expected behavior Text is rendered normally. ## How to reproduce the issue ```py from manim import * class Video(Scene): def construct(self): text = Text("Some text here") self.play(Wr...
[ "can you try to render the scene without caching?\r\n`manim -pql --disable_caching filename.py scenename`", "No, it still does not work.\r\n\r\nHere's the output:\r\n```\r\nManim Community v0.18.0\r\n\r\n[01/28/24 09:52:48] INFO Caching disabled. ...
3,595
Revert vector type aliases to NumPy ndarrays : In the typing update #3484, the vector type aliases were redefined as unions between NumPy ndarrays and tuples, in an attempt to make them more consistent with the point type aliases. However, this caused the issue #3563. After some discussion, it was clarified that ...
[]
3,594
fix typo in value_tracker.py : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? <!-- If there is more information than the PR title that should be added...
[]
3,593
updated several packages (pillow, jupyterlab, notebook, jupyterlab-lsp, jinja2, gitpython) : Supersedes #3575, #3576, #3583, #3586, #3587, #3591.
[]
3,592
Fix typehint of :attr:`InternalPoint2D_Array` : Fix some typos in the docstring of `InternalPoint2D_Array`
[]
3,591
Bump pillow from 10.1.0 to 10.2.0 : Bumps [pillow](https://github.com/python-pillow/Pillow) from 10.1.0 to 10.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/python-pillow/Pillow/releases">pillow's releases</a>.</em></p> <blockquote> <h2>10.2.0</h2> <p><a href="https://pi...
[ "Looks like pillow is up-to-date now, so this is no longer needed." ]
3,587
Bump jupyterlab from 4.0.9 to 4.0.11 : Bumps [jupyterlab](https://github.com/jupyterlab/jupyterlab) from 4.0.9 to 4.0.11. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/jupyterlab/jupyterlab/releases">jupyterlab's releases</a>.</em></p> <blockquote> <h2>v4.0.11</h2> <h2>4.0.1...
[ "Looks like jupyterlab is up-to-date now, so this is no longer needed." ]
3,586
Bump notebook from 7.0.6 to 7.0.7 : Bumps [notebook](https://github.com/jupyter/notebook) from 7.0.6 to 7.0.7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/jupyter/notebook/releases">notebook's releases</a>.</em></p> <blockquote> <h2>v7.0.7</h2> <h2>7.0.7</h2> <p>(<a href="...
[ "Looks like notebook is up-to-date now, so this is no longer needed." ]
3,583
Bump jupyter-lsp from 2.2.1 to 2.2.2 : Bumps [jupyter-lsp](https://github.com/jupyter-lsp/jupyterlab-lsp) from 2.2.1 to 2.2.2. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/jupyter-lsp/jupyterlab-lsp/blob/main/CHANGELOG.md">jupyter-lsp's changelog</a>.</em></p> <blockquote> <h3>...
[ "Looks like jupyter-lsp is up-to-date now, so this is no longer needed." ]
3,582
Update docker.rst to use bash from the PATH in docker run command : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? The docker docs use a `docker run` ...
[ "Is there any reason that this is better? If `/bin/bash` works and it's more explicit why not stick with it?", "If the explicit way is better then I suggest making this choice consistent across the document, in all invocations of a command inside a container:\r\n\r\n```diff\r\ndiff --git a/docs/source/installatio...
3,576
Bump jinja2 from 3.1.2 to 3.1.3 : Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pallets/jinja/releases">jinja2's releases</a>.</em></p> <blockquote> <h2>3.1.3</h2> <p>This is a fix release for the 3.1.x fe...
[ "Looks like jinja2 is up-to-date now, so this is no longer needed." ]
3,575
Bump gitpython from 3.1.40 to 3.1.41 : Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.40 to 3.1.41. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/gitpython-developers/GitPython/releases">gitpython's releases</a>.</em></p> <blockquote> <h2>3.1.4...
[ "Looks like gitpython is up-to-date now, so this is no longer needed." ]
3,574
exception add if new_rings is none : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? I've changed the way new_rins is written so that it returns a defa...
[]
3,572
Sector.get_arc_center() return a reference but not a copy, cause rotate unexpected behavior. : - ## Description of bug / unexpected behavior manim version: `0.18.0` ```python class SectorArcCenterRotate(Scene): def construct(self): self.add(NumberPlane()) sector = Sector(outer_radius=2, start_angle...
[]
3,568
Fix typing of `Animation` : `FunctionOverride` was being typed as returning `None` whereas it in fact returns `Animation`. This was resulting in the result of `Animation(...)` being inferred as `Animation | None` (by Pyright, at least). This PR addresses this by casting to the true type at the call site in `Animatio...
[ "Before accepting this change, I would like to look into if there's any way to fix the `FunctionOverride` type alias. It might be worth looking into whether `import manim.animation.animation as anim;anim.Animation` works, or some other workaround. In my view, this should be considered a last resort.", "> I would ...
3,567
Bump github/codeql-action from 2 to 3 : Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p> <blockquote> <h2>CodeQL Bundl...
[]
3,566
Bump actions/upload-artifact from 3 to 4 : [//]: # (dependabot-start) โš ๏ธ **Dependabot is rebasing this PR** โš ๏ธ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) ...
[]
3,565
Bump actions/setup-python from 4 to 5 : Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p> <blockquote> <h2>v5.0.0</h2> ...
[]
3,563
Multiplication of e.g. DOWN by a scalar is a type error on unreleased main branch : ## Description of bug / unexpected behavior Multiplication of `DOWN` by a float is a type error on `main` ![image](https://github.com/ManimCommunity/manim/assets/52205/37cc592e-e257-4f50-8d46-754fd76978f2) This is because `DOWN` ...
[ "Hello, I made that change in an attempt to make vector type aliases more consistent with point type aliases, which were also an union between NumPy ndarrays and tuples of floats.\r\nHowever, I see that this was not the correct move, so I just reverted that in a PR.\r\nThanks for submitting this issue!" ]
3,561
Add helpful hints to `VGroup.add()` error message : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? Changes the error message to explicitly state wha...
[]
3,557
:meth:`.Scene.add` and :meth:`Scene.play` should also allow iterables : Basically the same thing as #3540 and #3365
[]
3,556
Allow :meth:`.VGroup.add` to use iterables of VMobjects : Closes #3540 Allows for statements like: ```py VGroup( Square(), [Circle()], (x.shift(RIGHT) for x in [Star(), Triangle()]) ) ``` Also added a test for this. As MrDiver said, it's annoying to have to unpack iterables with the `*` opera...
[ "Closing this as the performance hit for checking if an object is not a VMobject is a bit excessive." ]
3,555
Improve documentation section about contributing to docs : ## Overview: What does this pull request change? - Added new entry "Adding Documentation" under the "Contributing" section in the Manim docs - Grouped the 5 "Adding Admonitions/Docstrings/Examples/References/Typings" entries under "Adding Documentation" - ...
[]
3,554
Add note in docstring of `ManimColor` about class constructors : Closes #3472 Also fixes a typo in the docstring.
[]
3,553
Add 'to be used in the future' TODOs to `ManimFrame` : Related PR: #620 I added TODOs to `ManimFrame` in `manim._config.utils` and `frame = ManimFrame(config)` in `manim._config.__init__` indicating that these shall be used in the future, as a note of caution to prevent future developers from "deleting unused code fo...
[]
3,552
Brace get_text() and get_tex() does not support Chinese : ![image](https://github.com/ManimCommunity/manim/assets/30149424/18b48a0f-2652-41fe-9b31-c408dd07dcdc) ![image](https://github.com/ManimCommunity/manim/assets/30149424/7cab721c-0568-4fb0-815e-712e9aec58ac)
[ "![image](https://github.com/ManimCommunity/manim/assets/30149424/4d5b7619-2871-4cd3-a966-50a27d3186f4)" ]
3,551
Rectangular Hyperbola is getting plotted with its asymptotes : ## Description of bug / unexpected behavior <!-- Add a clear and concise description of the problem you encountered. --> When trying to plot a rectangular hyperbola, along with the hyperbola its asymptotes are also getting plotted and this happens in both...
[ "Those extra 'lines' are not a buggy appearance of the asymptotes but a drawing feature due to using curves too close to discontinuities. Just pass `dt=0.1` to `ParametricPlot`. [RTFM](https://docs.manim.community/en/stable/reference/manim.mobject.graphing.functions.ParametricFunction.html?highlight=ParametricFunct...
3,549
Fix use of `Mobject`'s deprecated `get_*()` and `set_*()` methods in Cairo tests : Fix deprecation warnings for setters and getters. Most were from `Mobject.set_*`, and I changed them to `Mobject.set(xyz=`. For `Mobject.get_*`, I changed them to `Mobject.xyz`. Related: #3524
[]
3,547
fix typo of get_y_axis_label : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? <!-- If there is more information than the PR title that should be added...
[ "Thanks!" ]
3,546
fix write_subcaption_file error when using opengl renderer : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? <!-- If there is more information than the...
[]
3,545
Finish TODO's in ``contributing/typings.rst`` : Just some minor improvements, completing todo's etc. Related: #3375 CC @Viicos > https://manimce--3545.org.readthedocs.build/en/3545/contributing/typings.html
[ "This is all I can do for now, if I find time later I'll finish up the `TODO`'s", "I don't think I'll have time to work on this for a while. If there are no other comments and nobody wants to finish the ``TODO``s, Iets merge this in a day or two." ]
3,543
Fixed :attr:`.Mobject.animate` type-hint to allow LSP autocomplete : Pretty self-explanatory. The function definition was missing a `self: T` which meant that LSP's weren't working. Before: ![image](https://github.com/ManimCommunity/manim/assets/110117391/9caed8ad-e43f-465e-aeb3-8d92118f348c) After: ![image](ht...
[]
3,541
Fix formatting of ``MoveAlongPath`` docs : Closes #3537 -> https://manimce--3541.org.readthedocs.build/en/3541/reference/manim.animation.movement.MoveAlongPath.html
[]
3,539
Remove meth:``.Mobject.wag`` : This method seemed like a remnant from Grant's original code, so I removed it.
[]
3,537
reST in ``MoveAlongPath`` not correct : [https://docs.manim.community/en/stable/reference/manim.animation.movement.MoveAlongPath.html](https://docs.manim.community/en/stable/reference/manim.animation.movement.MoveAlongPath.html) ![image](https://github.com/ManimCommunity/manim/assets/110117391/cb0a1d4a-a766-486b-998...
[]
3,536
Succession does not work as expected : ```python class Test(Scene): def construct(self): txt1 = Text("1", color=BLACK) txt2 = Text("2", color=BLACK) self.play( Succession( FadeIn(txt1, shift=UP), FadeOut(txt1, shift=DOWN), ...
[ "It works as intended but using it on 2 different mobjects will not work as you want it to.\n\nWhat you want to have is S(S(t1), S(t2))\ni.e. two different successions un succession" ]
3,530
chore(docs): add some words about Cairo 1.18 : Rendered docs: ![image](https://github.com/ManimCommunity/manim/assets/27275099/65ef5962-6a51-489c-9530-05291fe0b9bf) Closes #3521
[ "Nice catch @chopan050, thanks!" ]
3,528
Removed -s / --save_last_frame flag from CLI arguments : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? <!-- If there is more information than the PR ...
[ "Hey there! Thank you very much for your efforts!\r\n\r\nRegrettably, I realized that the way I wrote the comment on #3174 leaves little room for understanding it in the way I meant it. I actually did not mean that the functionality and general use of the `-s` / `--save_last_frame` CLI flag should be removed (and p...
3,527
Additional Suggestions to #3491 : _Originally posted by @behackl in https://github.com/ManimCommunity/manim/pull/3491#discussion_r1423971353_ ](https://github.com/ManimCommunity/manim/pull/3491#discussion_r1423972234)](https://github.com/ManimCommunity/manim/pull/3491#discussion_r1423972234)
[]
3,524
Remove support for dynamic plugin imports : This seems to be a blocker for Manim to work under 3.12. This PR only focuses on fixing the issue with `pkg_resources`, but is this feature really wanted? It seems to achieve the following: https://github.com/ManimCommunity/manim/pull/967#issuecomment-769026805 Honestly...
[ "> Honestly, I don't see how this is beneficial: IDEs/linters are not aware of the import (see screenshot). I'm in favor of removing this dynamic import (plus having these exec calls is scary, seems like you can have arbitrary code execution by crafting a specific module name).\r\n\r\nOn the one hand, I agree.. the...
3,523
Full Latex Compiler inside manim : ## Description of proposed feature Adding full latex compiler capabilities into manim. In that way you could simply import your latex code and for example create static figures with tikzpicture. I would imaging that manim then could be a superset of latex beamer. Where you both have ...
[ "LaTeX is a very large thing to add into manim. If there were any python bindings to it, then it might be worth considering - for now it is a very large task that is mostly out of the scope for manim." ]
3,521
Dev Install Issue: Cairo must be installed from source to match CI version (1.18) : #### Preliminaries - [x] I have followed the latest version of the [installation instructions](https://docs.manim.community/en/stable/installation.html). - [x] I have checked the [installation FAQ](https://docs.manim.communit...
[ "Adding a remark about this to the developer installation guide is probably a good idea. The restriction was -- unfortunately -- necessary as the new cairo version introduced some minor changes to the graphical output which resulted in failed tests. You can find the corresponding issues / PRs by checking the latest...
3,520
Refactor `TexTemplate` : Relates to https://github.com/ManimCommunity/manim/pull/3473 I hopes this doesn't bring to many breaking changes: - Use dataclasses to reduce code overhead. - Remove `TexTemplateFromFile`, add a `from_file` classmethod instead. The `body` can be set manually here, but we face limitations a...
[]
3,519
Added radial gradient feature to Manim `VMobject` : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? I've added this new feature and edited `set_style` ...
[ "Just to leave a comment here so that we remember when we come back to this in the future:\r\n\r\nIn terms of the general architecture, it should not be the responsibility of the mobject to know all of these details; in an ideal world you'd just attach a color or material and the rest is handled by the renderer. Th...
3,516
Added `cap_style` feature to `VMobject` : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? Added `cap_style` to have multiple kinds of strokes in `VMobj...
[ "LGTM!" ]
3,515
Fix formatting building blocks : fixes #3369
[]
3,513
Fix rectangle grid properties (#3082) : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? <!-- If there is more information than the PR title that should...
[ "Off the top of my head, everything seems reasonable!\r\n\r\nThanks for your contribution! ๐ŸŽ‰ ", "Might I add #3428 if I see that correctly then it already solves the issue for the gridline styling so maybe we can revert it in this PR and just fix the 0 problem ?", "I updated the branch and PR message to exclud...
3,512
Removed deprecated `manim new` command : Self-explanatory. Related: #2695 <!-- Thank you again for contributing! Do not modify the lines below, they are for reviewers. --> ## Reviewer Checklist - [ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly - [ ] If applicable: newly...
[]
3,511
latex error converting to dvi. : Hi, guys! When I try to colorize my latex equation, the fowlling happens: latex error converting to dvi. See log output above or the log file: media/Tex/1b397957b87f17df.log what's going on? thank you!
[ "Can you please provide more information for your Problem, and look at the template that is provided for how to create an issue.\r\n\r\nBecause the only information you gave is that you tried to render an illegal latex snippet.\r\n\r\nI will close this for now until more information is provided, or try asking on th...
3,510
fix line_join to joint_type in example_scenes/basic.py : ## Overview: What does this pull request change? Resolve #3371 <!-- Thank you again for contributing! Do not modify the lines below, they are for reviewers. --> ## Reviewer Checklist - [ ] The PR title is descriptive enough for the changelog, and the PR i...
[]
3,509
fix typo in mobject docstring: line -> square : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? <!-- If there is more information than the PR title tha...
[]
3,503
chore(lib): use PyAV instead of FFMPEG : Draft implementation of #442. The goals are to: - avoid calling FFMPEG each time using subprocesses; - mitigate the FFMPEG installation issues by providing direct binding (to check) The current PR seems to improve rendering time by a factor close to 1.5 ~ 2.0, but I shou...
[ "I've been working on that too in #3501, with the difference that I have a working documentation build and fewer failing tests ;-)\r\n\r\nYou managed to pass a few more of the current options though, it might make sense to join forces.", "I've now absorbed your changes in #3501, except for the change to `write_fr...
3,500
Explain ``.Transform`` vs ``.ReplacementTransform`` in quickstart examples : Resolves Issue #3139 ## Changed Documentation https://manimce--3500.org.readthedocs.build/en/3500/tutorials/quickstart.html
[ "Hmm, that seems like a better idea. I'll update this PR.", "```\r\nFor the a->b, a->c part it follows more of a foldl pattern in that sense so you can apply a list of functions to one mobject and it still work, so it enables you to write for loops without having to switch between different references.\r\nWhereas...
3,499
Reformatting the `--save_sections` output to have the format `<Scene>_<SecNum>_<SecName><extension>` : ## Overview: What does this pull request change? <!--changelog-start--> Fixes the rendered file names to inherit section name. The PR has been created as part of a University course and it is not a bug but it helps ...
[ "Hello, thanks for your contribution!\r\nI edited your post to link the affected issue.\r\n\r\nWe (the developer team) were discussing that it should, at least, be better to have **both** the number and the name.\r\nThe issue with getting rid of the section number is that the files become unorganized in the folder,...
3,498
fix 360ยฐ to 180ยฐ in quickstart tutorial : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? Refer to [Issue 2080](https://github.com/3b1b/manim/issues/20...
[]
3,497
Bump jupyter-server from 2.9.1 to 2.11.2 : Bumps [jupyter-server](https://github.com/jupyter-server/jupyter_server) from 2.9.1 to 2.11.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/jupyter-server/jupyter_server/releases">jupyter-server's releases</a>.</em></p> <blockquote...
[]
3,494
Optimized `get_unit_normal()` and replaced `np.cross()` with custom `cross()` in `manim.utils.space_ops` : ## Overview: What does this pull request change? The title's self-explanatory. ## Motivation and Explanation: Why and how do your changes improve the library? Consider this simple scene: ```py class Simple(...
[]
3,493
Account for dtype in the pixel array so the maximum value stays correct in the invert function : This fixes an issue where the `invert` argument would only work for `uint8` dtypes. Now the `max` value is updated according to the pixel array dtype. Maybe we should add unit tests for that, but haven't found an obvious p...
[ "Yes please, just create a new file `tests/module/mobject/test_image.py` or so. Thanks!", "> Yes please, just create a new file `tests/module/mobject/test_image.py` or so. Thanks!\r\n\r\nWill do that in the following days :-)", "@behackl done :-)" ]
3,491
Fix animations with zero runtime length to give a useful error instead of a broken pipe : Throwing an error when an animation group is instantiated with an empty list.
[ "The issue actually sits a bit deeper. This happens for *any* animation as soon as the `run_time` is set to 0:\r\n\r\n```py\r\nanim = Animation(None, run_time=0)\r\nself.play(anim)\r\nself.wait()\r\n```\r\n\r\nalso breaks rendering.\r\n\r\nI think it is fine that we raise an error in this case (I can't really think...
3,490
The brightness of the video changes when the program moves on to the next "play(animations)" : # If the background is "NumberPlane", the flickering will be noticeable ![test](https://github.com/ManimCommunity/manim/assets/25880096/bcceadd7-dac0-4b5d-8920-0c2590ba6e0d) from manim import * class test01(Scene): ...
[ "I have never seen anything like this before... I'll have to have a look at your code...", "What are your render settings? \r\nWhich version of Python, ffmpeg, Manim etc are you using?\r\n(essentially all the questions which you chose to not answer from the template)\r\n\r\nBecause on my system I cannot reproduce...
3,484
Added support for Manim type aliases in Sphinx docs + Added new TypeAliases : ## Overview: What does this pull request change? Added Manim type aliases to Sphinx Autodoc: - _**[v0.2]** Custom parser which reads ~the `manim/typing.py` file~ **[v2.0] ALL the modules inside the Manim tree**, generates an Abstract Syntax...
[ "Current state, the typing module is now added to the documentation but it's contents are not shown because the module members are not written in caps", "_**[UPDATE v0.1]**_\r\n\r\n- **Thanks to MrDiver for including all the missing `__all__` exports in Manim!**\r\n- I marked this as a draft, as there's still a l...
3,477
indication.py documentation typo : reading the docs, im sure oppising isnt a word so i fixed it
[]
3,476
Bump cryptography from 41.0.5 to 41.0.6 : Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.5 to 41.0.6. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst">cryptography's changelog</a>.</em></p> <blockquote> <p>41.0.6 - 20...
[ "Looks like cryptography is up-to-date now, so this is no longer needed." ]
3,475
Disable rendering doc examples for experimental branch : The `MANIM_SKIP_EXAMPLES` env variable might be a nicer approach than the usual `O=-tskip-manim make html` for skipping the examples when rendering. We'll see whether this works as intended for this branch.
[ "โค๏ธ THANK YOU SO MUCH โค๏ธ " ]
3,474
[EXPERIMENTAL] Mobject shader cleanup + Scene changes + Undo orientation input in vertex shader + Transparency Fix : - Removed shader wrapper from OpenGL(V)Mobject - Removed shader related methods and decorators from OpenGL(V)Mobject (only the methods in OpenGLRenderer and GLVMobjectManager are being used) - Modified...
[]
3,472
ManimColor: Adding documentation and examples for creating colors : Time to work with colours! :D ``` BG_rgb = (40, 85, 120) hsv = ManimColor().from_rgb(color).to_hsv() ``` will return `TypeError: ManimColor.__init__() missing 1 required positional argument: 'value'`, whereas the docs say ``` class ManimC...
[ "That None is indeed not a bug and currently just for not needing to rewrite the whole library it just returns BLACK if you give it `None`\r\n\r\nThe reason for you needing to convert to hsv before you can access the values is that the internal representation is now in rgba of floats which is more in line of how th...
3,471
When rendering with option --save_section the rendered file names are appended with 0001, 0002, 0003 instead of the "name" attribute. : I am not sure if this shall be categorized as a bug, so let me know if I have to move it elsewhere. As per title, when rendering with option `--save_section `the rendered file names...
[ "Not sure I agree. The name could perhaps appear somewhere in the filename, but replacing the numbering completely leads to unsorted files in the file explorer.", "> The name could perhaps appear somewhere in the filename\r\n\r\nThat could be an idea! \r\nBut I am wondering, why it would be a problem to have unso...
3,469
what about adding blending modes? : ## Description of proposed feature Given that you touched colours, I have a provoking thought: what about adding blending modes in the future? At first glance the VMObject class shall be modified such that it takes an additional parameter "blending_mode=" that can take values i...
[ "I mean it general it sounds like a nice idea but i am not sure how well that would go with the mobject system, because normally how the blend mode works is that it Acts on the last layer and the mobject rendering only has an order and not really a notion of layer which would result it somewhat undefined behavior, ...
3,468
[EXPERIMENTAL] Update Scene's remove & replace - Undo "orientation" in vertex shader which replaced "unit_normal" : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull requ...
[]
3,467
Is there any way to make a long division in Maim? : That's all. Thanks
[ "Why would it not be possible? GitHub issues are not the correct place to discuss how such an animation would look like though -- please see the [corresponding section about getting help in our documentation](https://docs.manim.community/en/stable/faq/help.html).\r\n\r\nClosing this issue." ]
3,465
Can not find the file manim.py : In Windows When I was trying to execute ``` python -m manim.py ``` But there was a mistake called ``` No module named manim.py ``` I am so sorry and I don't know how to solve it. Had I downloaded a wrong version, but I didn't realise it? I hope __This issue__ won't offend any...
[ "Why do you want to run `python -m manim.py`, is that from some tutorial or so?\r\n\r\nThe command you should use is either just `manim`, or if that does not work you can replace it with `python -m manim` (without the .py). See https://docs.manim.community/en/stable/tutorials/quickstart.html for more information." ...
3,464
Last frame of animation is not rendered into video file unless a `wait()` is added : ## Description of bug / unexpected behavior Consider the following, which I expect to print a number animation from `-1.00000 ... 1.00000` ```Python class PrintValue(Scene): def construct(self): k = ValueTracker(-1...
[ "Thanks for your report! This is a problem that is rooted quite deeply, and I do not think that we will change this behavior any time soon. Essentially, this is because\r\n\r\n- we want the animation completion rate to progress nicely in steps proportional to the frame rate,\r\n- and we want the produced video to h...
3,461
Fix Indicate docstring typo : Fixed a small typo for the Indicate animation. ## Reviewer Checklist - [ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly - [ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETE...
[]
3,459
Update Docker base image to python3.12-slim (#3458) : ## Overview: What does this pull request change? Simply updating the Docker base image from python 3.8 -> 3.12. This lets users of the Docker distribution of `manim` take advantage of lots of new Python features (especially type hints). This should not cause ...
[ "Did you build and try manim with these changes?", "Thank you for progressing the PR! I've been trying and failing to find the time myself. Cheers!" ]
3,458
chore(docker): upgrade base image to python3.12-slim : ## Description of proposed feature Currently, the manim [docker image](https://github.com/ManimCommunity/manim/blob/main/docker/Dockerfile) uses `python3.8-slim`. With the recent [update to python3.12](https://github.com/ManimCommunity/manim/pull/3395) in the main...
[]
3,456
Boolean operations: "Requested capacity is too large" on MacOs Sonoma. : ## Description of bug `../../../../../../src/cpp/skia-builder/skia/src/base/SkContainers.cpp:106: fatal error: "Requested capacity is too large." zsh: trace trap manim discord.py -pql --disable_caching -v WARNING` ## How to reproduce the ...
[ "Can't reproduce on MacOS 12.3 / Monterey. Might be a Sonoma-specific issue.\r\n\r\n\r\n> RAM: 1TB\r\n\r\nAre you sure? What sort of machine are you working on? ๐Ÿ˜ฑ ", "Damn. I cannot downgrade to Monterey (and to be honest I don't even want to do that! :D). \r\nLet's wait if someone has Sonoma and can tackle this...
3,454
Fix squashed axes labels : ## Overview: What does this pull request change? This pull request changes the default initialization of the font size of the x-axis labels to be smaller if the distance between tick marks is too small. ## Motivation and Explanation: Why and how do your changes improve the library? This ...
[]
3,453
Table not working? : It looks like that `Table` class is not working, see below. ## Example ```py import manim as mn class TableExamples(mn.Scene): def construct(self): t0 = mn.Table([["This", "is a"], ["simple", "Table in \n Manim."]]) self.add(t0) ``` ## Comamnd used `manim myfi...
[ "Can you post the full error message - the code renders just fine on my computer.\r\n\r\nDo you possibly have an issue with the Pango library on your system? Does the following code work for you? If not then that's your problem, since `Table()` uses the `Text()` object.\r\n\r\n```py\r\nimport manim as mn\r\n\r\ncla...
3,452
fixed labels with small unit size on number line to be smaller : ## Overview: What does this pull request change? This change improves the <!--changelog-end--> ## Motivation and Explanation: Why and how do your changes improve the library? <!-- Optional for bugfixes, small enhancements, and documentation-relat...
[]
3,451
Fixing labels on the number line for small unit sizes to be not squashed : ## Overview: What does this pull request change? This PR changes the default initialization of the font size of the axes labels to be smaller if the distance between tick marks is too small. ## Motivation and Explanation: Why and how do your...
[]
3,450
Fixed wrong path in action building downloadable docs : See title.
[]
3,449
Text issue : ## Description of bug / unexpected behavior I installed manim via instructions on https://docs.manim.community/en/stable/installation/conda.html and while much of it works, anything using ```Text()```, including using ```Table```, fails. For example: ```py from manim import * Text(1) ``` -----...
[ "This is apparently a duplicate of [https://github.com/ManimCommunity/ManimPango/issues/106](https://github.com/ManimCommunity/ManimPango/issues/106) and #3403 \r\n\r\nTry if `pip install manimpango --force` helps.", "Indeed, this has been fixed in today's release of `v0.18.0` -- which should also be available na...
3,448
Bug when adding a tip to an arc : ## Description of bug / unexpected behavior <!-- Add a clear and concise description of the problem you encountered. --> When adding a tip to an arc, the latter get its center and radius changed. ## Expected behavior <!-- Add a clear and concise description of what you expecte...
[ "I think this is a duplicate of #3099, closing this in favor of the older issue with a bit more debugging info. Thanks for the report!" ]
3,445
Unsuccessful use of First Steps with Manim notebook : #### Preliminaries - I have followed the latest version of the [installation instructions](https://docs.manim.community/en/stable/installation.html). - I have checked the [installation FAQ](https://docs.manim.community/en/stable/faq/installation.html) and...
[ "The link https://try.manim.community/ has absolutely nothing to do with your own local installation of Manim. It uses an online cloud service called Binder, which is sadly running out of resources because of a lack of commercial funding.", "Not sure I really understand what happens when you say\r\n\r\n> The Note...
3,443
Add separate thread to writes files : <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? <!-- If there is more information than the PR title that should b...
[ "@MrDiver Apologies for the multiple PR requests. I closed out the previous PR, #3270 when I synced my fork with the main repo. I will continue to work on that PR here.\r\n\r\nThank you!", "@smu160, just to clarify: are you still working on this PR, or is this ready to be looked at? I'll convert it to a draft if ...
3,442
Error rendering Text mobject on certain Macs - Argument 'size' has incorrect type (expected int, got float) : ## Description of bug / unexpected behavior Error rendering Text mobject on certain Mac models. ## Expected behavior Can render a text mobject ## How to reproduce the issue Install manim using con...
[ "Duplicate of https://github.com/ManimCommunity/manim/issues/3403, running `pip install -U --force manimpango` should fix the issue. Will also be fixed with the upcoming release.", "I tried that and it complains about \r\n```\r\nmanim 0.17.3 requires manimpango<0.5.0,>=0.4.0.post0, but you have manimpango 0.5.0 w...