Update hebrew_projectbenyehuda.py

hebrew_projectbenyehuda.py

@@ -1,10 +1,12 @@
 """Public domain texts from Project Ben-Yehuda- a set of books extracted from the Project BenYehuda library"""
 
-
 import csv
+csv.field_size_limit(1000000000)
 
-import datasets
+from pathlib import Path
 
+import datasets
+import logging
 
 _CITATION = """\
 @article{,
@@ -14,7 +16,6 @@ _CITATION = """\
   url = {https://github.com/projectbenyehuda/public_domain_dump},
   year = {2020},
 }
-
 """
 
 _DESCRIPTION = """\
@@ -23,28 +24,26 @@ All these works are in the public domain, so you are free to make any use of the
 There are 10078 files, 3181136 lines
 """
 
-_ASSET_ROOT_URL = "https://raw.githubusercontent.com/projectbenyehuda/public_domain_dump/master/"
-_STORAGE_API_ROOT_URL = "https://raw.githubusercontent.com/projectbenyehuda/public_domain_dump/master/txt/"
-
-# download one by one file from github is too slow
+logger = logging.getLogger(__name__)
 
-_METADATA_URL = _ASSET_ROOT_URL + "pseudocatalogue.csv"
+URLS = dict(
+    html="https://github.com/projectbenyehuda/public_domain_dump/releases/download/2022-12/html.zip",
+    catalogue="https://github.com/projectbenyehuda/public_domain_dump/releases/download/2022-12/pseudocatalogue.csv",
+    txt="https://github.com/projectbenyehuda/public_domain_dump/releases/download/2022-12/txt.zip",
+    txt_stripped="https://github.com/projectbenyehuda/public_domain_dump/releases/download/2022-12/txt_stripped.zip",
+)
 
 
 class HebrewProjectbenyehuda(datasets.GeneratorBasedBuilder):
-    """Project Ben Yehuda dataset - books as plain text extracted from the Project Project Ben Yehuda library"""
-
-    VERSION = datasets.Version("0.1.0")
+    VERSION = datasets.Version("0.2.0")
 
     def _info(self):
         return datasets.DatasetInfo(
-            # This is the description that will appear on the datasets page.
             description=_DESCRIPTION,
-            # datasets.features.FeatureConnectors
             features=datasets.Features(
                 {
                     "id": datasets.Value("int32"),
-                    "url": datasets.Value("string"),
+                    "path": datasets.Value("string"),
                     "title": datasets.Value("string"),
                     "authors": datasets.Value("string"),
                     "translators": datasets.Value("string"),
@@ -52,49 +51,38 @@ class HebrewProjectbenyehuda(datasets.GeneratorBasedBuilder):
                     "genre": datasets.Value("string"),
                     "source_edition": datasets.Value("string"),
                     "text": datasets.Value("string"),
-                    # These are the features of your dataset like images, labels ...
+                    "txt_stripped": datasets.Value("string"),
+                    "html": datasets.Value("string"),
                 }
             ),
-            # If there's a common (input, target) tuple from the features,
-            # specify them here. They'll be used if as_supervised=True in
-            # builder.as_dataset.
             supervised_keys=None,
-            # Homepage of the dataset for documentation
             homepage="https://github.com/projectbenyehuda/public_domain_dump",
             citation=_CITATION,
         )
 
     def _split_generators(self, dl_manager):
-        """Returns SplitGenerators."""
-
-        # dl_manager is a datasets.download.DownloadManager that can be used to
-        # download and extract URLs
-
-        metadata = dl_manager.download({"metadata": _METADATA_URL})
 
-        urls_to_download = dict()
-        ids = list()
-        with open(metadata["metadata"], encoding="utf-8") as csv_file:
-            for row in csv.DictReader(csv_file):
-                ids.append(row["ID"])
-                urls_to_download[row["ID"]] = _STORAGE_API_ROOT_URL + row["path"].strip("/") + ".txt"
+        paths = {}
+        for key, url in URLS.items():
+            logger.info("Downloading %s", url)
+            paths[key] = dl_manager.download_and_extract(url)
 
-        downloaded_files = dl_manager.download(urls_to_download)
         return [
             datasets.SplitGenerator(
                 name=datasets.Split.TRAIN,
                 gen_kwargs={
-                    "ids": ids,
-                    "metadata_filepath": metadata["metadata"],
-                    "filepaths": downloaded_files,
+                    "filepaths": paths,
                 },
             )
         ]
 
-    def _generate_examples(self, ids, metadata_filepath, filepaths):
-        """Yields examples."""
+    def _generate_examples(self, filepaths):
+        catalogue_path = filepaths["catalogue"]
+        html_path = Path(filepaths["html"]) / "html"
+        txt_path = Path(filepaths["txt"]) / "txt"
+        txt_stripped_path = Path(filepaths["txt_stripped"]) / "txt_stripped"
 
-        with open(metadata_filepath, encoding="utf-8") as f:
+        with open(catalogue_path, encoding="utf-8") as f:
             metadata_dict = csv.DictReader(
                 f,
                 fieldnames=[
@@ -108,33 +96,30 @@ class HebrewProjectbenyehuda(datasets.GeneratorBasedBuilder):
                     "source_edition",
                 ],
             )
-            indexed_metadata = {str(row["_id"]): row for row in metadata_dict}
-
-        for _id in ids:
-            data = indexed_metadata[_id]
-            filepath = filepaths[_id]
+            for data in metadata_dict:
+                if data["path"] == "path":
+                    continue
+
+                yield data["_id"], {
+                    "id": data["_id"],
+                    "title": data["title"],
+                    "path": data["path"],
+                    "authors": data["authors"],
+                    "translators": data["translators"],
+                    "original_language": data["original_language"],
+                    "genre": data["genre"],
+                    "source_edition": data["source_edition"],
+                    "text": self.read_file(txt_path / f"{data['path'].strip('/')}.txt"),
+                    "txt_stripped": self.read_file(
+                        txt_stripped_path / f"{data['path'].strip('/')}.txt"
+                    ),
+                    "html": self.read_file(html_path / f"{data['path'].strip('/')}.html"),
+                }
 
+    def read_file(self, filepath):
+        filepath = Path(filepath)
+        if filepath.exists():
             with open(filepath, encoding="utf-8") as f:
-                text = f.read()
-
-            _id = data["_id"]
-            title = data["title"]
-            url = data["path"].strip("/")
-            url = _STORAGE_API_ROOT_URL + url + ".txt"
-            authors = data["authors"]
-            translators = data["translators"]
-            original_language = data["original_language"]
-            genre = data["genre"]
-            source_edition = data["source_edition"]
-
-            yield _id, {
-                "id": _id,
-                "title": title,
-                "url": url,
-                "authors": authors,
-                "translators": translators,
-                "original_language": original_language,
-                "genre": genre,
-                "source_edition": source_edition,
-                "text": text,
-            }
+                return f.read()
+        else:
+            return None