Datasets:
r1v3r
/
auto_validated

Dataset card Data Studio Files
xet
 Community
1
base_commit
stringlengths
40
40
patch
stringlengths
274
280k
instance_id
stringlengths
15
36
pull_number
int64
31
15.2k
hints_text
stringlengths
0
33.6k
issue_numbers
listlengths
1
3
version
stringlengths
3
5
repo
stringclasses
52 values
created_at
stringlengths
20
20
test_patch
stringlengths
377
210k
problem_statement
stringlengths
34
44.3k
environment_setup_commit
stringlengths
40
40
FAIL_TO_PASS
listlengths
1
172
PASS_TO_PASS
listlengths
0
1.78k
FAIL_TO_FAIL
listlengths
0
231
PASS_TO_FAIL
listlengths
0
6
1beea8c3df2e44f6fa17b8f21ad57bf5a6e8b620
diff --git a/Cargo.toml b/Cargo.toml --- a/Cargo.toml +++ b/Cargo.toml @@ -13,7 +13,7 @@ categories = ["algorithms", "database-implementations"] [dependencies] log = "0.4.1" -protobuf = "1.2" +protobuf = "~1.5" quick-error = "1.2.1" rand = "0.4" fxhash = "0.2.1" diff --git a/src/raft.rs b/src/raft.rs --- a/src/r...
tikv__raft-rs-58
58
PTAL @xiang90 @Hoverbear
[ "57" ]
0.1
tikv/raft-rs
2018-05-09T08:12:10Z
diff --git a/tests/cases/test_raft.rs b/tests/cases/test_raft.rs --- a/tests/cases/test_raft.rs +++ b/tests/cases/test_raft.rs @@ -3784,21 +3784,6 @@ fn test_learner_promotion() { assert_eq!(network.peers[&2].state, StateRole::Leader); } -// TestLearnerCannotVote checks that a learner can't vote even it receive...
Learner should respond to request vote but don't accept votes Consider following case, a cluster has three nodes A, B, C, and A is Leader. And then add learner D, E to the cluster. D, E is promoted to voter then, but D is isolated from A, so D doesn't know himself is promoted. When A, B both crash, the cluster still ha...
1beea8c3df2e44f6fa17b8f21ad57bf5a6e8b620
[ "cases::test_raft::test_learner_respond_vote" ]
[ "errors::tests::test_error_equal", "log_unstable::test::test_maybe_first_index", "log_unstable::test::test_maybe_last_index", "log_unstable::test::test_maybe_term", "errors::tests::test_storage_error_equal", "log_unstable::test::test_restore", "log_unstable::test::test_stable_to", "log_unstable::test:...
[]
[]
94f4ad731ffae32474ae4362c5f74507a86b564e
diff --git a/path/src/path.rs b/path/src/path.rs --- a/path/src/path.rs +++ b/path/src/path.rs @@ -140,10 +140,7 @@ impl Path { /// Reversed version of this path with edge loops are specified in the opposite /// order. pub fn reversed(&self) -> Self { - let mut builder = Path::builder(); - ...
nical__lyon-503
503
[ "501" ]
0.14
nical/lyon
2019-12-25T11:52:19Z
diff --git a/path/src/path.rs b/path/src/path.rs --- a/path/src/path.rs +++ b/path/src/path.rs @@ -1041,49 +1059,60 @@ fn n_stored_points(verb: Verb, attrib_stride: usize) -> usize { #[test] fn test_reverse_path() { - let mut builder = Path::builder(); - builder.move_to(point(0.0, 0.0)); - builder.line_to(...
Path::reversed should preserve custom attributes Currently the custom attributes aren't in the output path.
94f4ad731ffae32474ae4362c5f74507a86b564e
[ "path::test_reverse_path" ]
[ "commands::simple_path", "commands::next_event", "iterator::test_from_polyline_open", "path::test_merge_paths", "iterator::test_from_polyline_closed", "path::test_path_builder_empty", "path::test_path_builder_1", "path::test_reverse_empty_path", "path::test_reverse_path_no_close", "path::test_path...
[]
[]
525037751f50afd145131feded64156e79dfaaa9
diff --git a/tessellation/src/event_queue.rs b/tessellation/src/event_queue.rs --- a/tessellation/src/event_queue.rs +++ b/tessellation/src/event_queue.rs @@ -184,7 +184,7 @@ impl EventQueue { after: TessEventId, ) -> TessEventId { debug_assert!(self.sorted); - debug_assert!(is_after(data....
nical__lyon-570
570
Thanks for filing this, I'll have a look shortly. @yanchith I made a testcase from the one you provided, unfortunately it doesn't reproduce, which probably means the defaut formatting parameters arent printing enough decimals to represent the problematic case. could you copy-pase this code somehwere where you know t...
[ "562" ]
0.15
nical/lyon
2020-04-23T21:45:52Z
diff --git a/tessellation/src/fill_tests.rs b/tessellation/src/fill_tests.rs --- a/tessellation/src/fill_tests.rs +++ b/tessellation/src/fill_tests.rs @@ -135,7 +135,7 @@ fn test_path_with_rotations(path: Path, step: f32, expected_triangle_count: Opti let mut angle = Angle::radians(0.0); while angle.radians...
FillTessellator with non-zero fill rule panics with 'assertion failed: self.fill.spans.is_empty()' Hello, First of all, really sorry that the bug reproduction is not as minimal as it could be (see attached `Path`). I can spend some more time on this later, if it helps. Version: `0.15.6` The panic is a `debug_a...
08cd4c3d8c1ef53fbbb1b702f655e26c6bd5cc03
[ "earcut_tests::self_touching", "fill_tests::issue_562_1", "fill_tests::issue_562_5", "earcut_tests::eberly_6", "fill_tests::issue_562_6", "fill_tests::issue_481_reduced", "fill_tests::issue_481_original", "fill_tests::issue_562_7", "fuzz_tests::fuzzing_test_case_16", "fuzz_tests::fuzzing_test_case...
[ "earcut_tests::bad_diagonal", "earcut_tests::building", "earcut_tests::degenerate", "earcut_tests::bad_hole", "earcut_tests::empty_square", "earcut_tests::eberly_3", "earcut_tests::dude", "earcut_tests::issue_16", "earcut_tests::hole_touching_outer", "earcut_tests::issue_17", "earcut_tests::issu...
[]
[]
122ee5f0077fcf363745cb6ab1c4641545029efc
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -432,7 +432,7 @@ name = "geom_bench" version = "0.0.1" dependencies = [ "bencher 0.1.5 (registry+https://github.com/rust-lang/crates.io-index)", - "lyon 0.15.3", + "lyon 0.15.5", ] [[package]] diff --git a/Cargo.lock b/Cargo.lock --- a/Ca...
nical__lyon-530
530
Thanks for the report, unless the input data contains broken floats like NaNs or inifinity, and has fewer than u32::MAX vertices, it should definitely be considered as a bug in the tessellator which is the case here. I was able to reproduce this and reduce it to a small testcase. I'll look into it soon.
[ "529" ]
0.15
nical/lyon
2020-01-12T20:48:35Z
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -882,7 +882,7 @@ dependencies = [ name = "lyon_wasm_test" version = "0.11.0" dependencies = [ - "lyon 0.15.3", + "lyon 0.15.5", ] [[package]] diff --git a/tessellation/src/fill_tests.rs b/tessellation/src/fill_tests.rs --- a/tessellation/s...
Fill tessellation failure in 0.15.3 I'm tesselating a svg file that I simply pass from usvg to lyon fill tesselator. The svg file can be found at [0], I used `CNTR_RG_03M_2016_4326.svg` which used to work with 0.14, (but `CNTR_RG_01M_2016_4326.svg` did not). The error is simply `Internal(IncorrectActiveEdgeOrder(3)...
08cd4c3d8c1ef53fbbb1b702f655e26c6bd5cc03
[ "fill_tests::issue_529" ]
[ "basic_shapes::issue_366", "earcut_tests::bad_diagonal", "earcut_tests::bad_hole", "earcut_tests::building", "earcut_tests::degenerate", "earcut_tests::dude", "earcut_tests::eberly_3", "earcut_tests::empty_square", "earcut_tests::hole_touching_outer", "earcut_tests::issue_16", "earcut_tests::iss...
[]
[]
4429c2aad3f900fd33a8a64e62e8e9da97ffaf1e
diff --git a/tessellation/src/stroke.rs b/tessellation/src/stroke.rs --- a/tessellation/src/stroke.rs +++ b/tessellation/src/stroke.rs @@ -7,7 +7,7 @@ use crate::path::builder::{Build, PathBuilder}; use crate::path::private::DebugValidator; use crate::path::{AttributeStore, EndpointId, IdEvent, PathEvent, PathSlice, ...
nical__lyon-579
579
I certainly am! Was it the stroke or fill tessellator? Pretty sure it was the stroke tesselator. It may be useful to know that there were only bezier curves imitating lines (i.e. the control points were identical to the corners) in the builder. There may however have been duplicate points in it. Some more info. I think...
[ "545" ]
0.15
nical/lyon
2020-04-27T22:00:28Z
diff --git a/tessellation/src/stroke.rs b/tessellation/src/stroke.rs --- a/tessellation/src/stroke.rs +++ b/tessellation/src/stroke.rs @@ -1665,12 +1711,14 @@ fn test_too_many_vertices() { } impl GeometryBuilder for Builder { fn begin_geometry(&mut self) {} - fn add_triangle(&mut self, _a: Ver...
The stroke tessellator does not propagate errors I cannot replicate this, but you might be interested in a panic that i found ``` thread 'main' panicked at 'assertion failed: b != c', tessellation/src/geometry_builder.rs:510:9 ```
08cd4c3d8c1ef53fbbb1b702f655e26c6bd5cc03
[ "stroke::test_too_many_vertices" ]
[ "earcut_tests::bad_diagonal", "earcut_tests::building", "earcut_tests::degenerate", "earcut_tests::bad_hole", "earcut_tests::empty_square", "earcut_tests::eberly_3", "earcut_tests::dude", "earcut_tests::issue_17", "earcut_tests::issue_16", "earcut_tests::hole_touching_outer", "earcut_tests::issu...
[]
[]
4651f1b20b508aeb3cd79e0d9252803e7325afa8
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -432,7 +432,7 @@ name = "geom_bench" version = "0.0.1" dependencies = [ "bencher 0.1.5 (registry+https://github.com/rust-lang/crates.io-index)", - "lyon 0.15.1", + "lyon 0.15.3", ] [[package]] diff --git a/Cargo.lock b/Cargo.lock --- a/Ca...
nical__lyon-520
520
[ "517" ]
0.15
nical/lyon
2019-12-28T12:17:48Z
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -882,7 +882,7 @@ dependencies = [ name = "lyon_wasm_test" version = "0.11.0" dependencies = [ - "lyon 0.15.1", + "lyon 0.15.3", ] [[package]] diff --git a/tessellation/src/fill.rs b/tessellation/src/fill.rs --- a/tessellation/src/fill.rs +...
The vertex source iterator can visit the same endpoint twice in some cases. For start events for example, it can happen for the endpoint to be visited once for each of its edges.
08cd4c3d8c1ef53fbbb1b702f655e26c6bd5cc03
[ "fill::fill_vertex_source_03" ]
[ "basic_shapes::issue_366", "earcut_tests::bad_diagonal", "earcut_tests::building", "earcut_tests::degenerate", "earcut_tests::bad_hole", "earcut_tests::eberly_3", "earcut_tests::dude", "earcut_tests::empty_square", "earcut_tests::hole_touching_outer", "earcut_tests::issue_16", "earcut_tests::iss...
[]
[]
17b0ce8c74a2bb917de85f99428886ca8445ac3b
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -787,7 +787,7 @@ dependencies = [ "lyon_extra 0.15.0", "lyon_svg 0.15.0", "lyon_tess2 0.15.0", - "lyon_tessellation 0.15.1", + "lyon_tessellation 0.15.2", ] [[package]] diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.l...
nical__lyon-519
519
The above example will work successfully if I omit the last `line_to` and let it close via `close`, but here's another example where omitting it has no effect: ``` let mut builder = Path::builder(); builder.move_to(Point::new(-69.1f32, -465.5f32)); builder.line_to(Point::new(-69.1f32, -461.65f32)); ...
[ "518" ]
0.15
nical/lyon
2019-12-27T22:28:12Z
diff --git a/tessellation/src/fill_tests.rs b/tessellation/src/fill_tests.rs --- a/tessellation/src/fill_tests.rs +++ b/tessellation/src/fill_tests.rs @@ -2055,6 +2055,70 @@ fn issue_500() { ).unwrap(); } +#[test] +fn issue_518_1() { + let mut builder = Path::builder(); + builder.move_to(point(-76.95, -46...
Path hits `is_after(to, self.current_position)` assert The following path hit an assert in the fill tessellator in both debug and release: ``` let mut builder = Path::builder(); builder.move_to(Point::new(-76.95f32, -461.8f32)); builder.quadratic_bezier_to( Point::new(-75.95f32, -462.6f32), ...
08cd4c3d8c1ef53fbbb1b702f655e26c6bd5cc03
[ "fill_tests::issue_518_2", "fill_tests::issue_518_1" ]
[ "basic_shapes::issue_366", "earcut_tests::bad_diagonal", "earcut_tests::bad_hole", "earcut_tests::eberly_3", "earcut_tests::empty_square", "earcut_tests::dude", "earcut_tests::building", "earcut_tests::degenerate", "earcut_tests::issue_16", "earcut_tests::issue_17", "earcut_tests::hole_touching_...
[]
[]
fcb9841a744543b993eb1645db35dbda541e9a30
diff --git a/strum_macros/src/helpers/type_props.rs b/strum_macros/src/helpers/type_props.rs --- a/strum_macros/src/helpers/type_props.rs +++ b/strum_macros/src/helpers/type_props.rs @@ -21,6 +21,7 @@ pub struct StrumTypeProperties { pub discriminant_others: Vec<TokenStream>, pub discriminant_vis: Option<Visi...
Peternator7__strum-288
288
It's a breaking change, but I agree it's certainly more inline with what would be expected. Happy to take a PR if you're interested.
[ "283" ]
0.25
Peternator7/strum
2023-08-01T22:43:37Z
diff --git a/strum_tests/tests/enum_discriminants.rs b/strum_tests/tests/enum_discriminants.rs --- a/strum_tests/tests/enum_discriminants.rs +++ b/strum_tests/tests/enum_discriminants.rs @@ -1,6 +1,9 @@ -use enum_variant_type::EnumVariantType; -use strum::{Display, EnumDiscriminants, EnumIter, EnumMessage, EnumString, ...
EnumDiscriminants should inherit the repr of the enum they are derived from The below example code will generate `VehicleDiscriminants` enum with `Car` and `Truck` variants but it will be `repr(usize)` instead of inheriting the `u8` repr of `Vehicle` additionally they will have the default enum representations (`Car = ...
597f8e941fb9dec5603f6892df4109b50f615160
[ "with_explicit_discriminant_value", "with_repr_align", "with_repr_uint" ]
[ "arbitrary_attributes_pass_through", "complicated_test", "crate_module_path_test", "fields_test", "filter_variant_attributes_pass_through", "from_ref_test", "from_ref_test_complex", "from_test", "from_test_complex", "override_visibility", "renamed_test", "simple_test", "split_attributes_test...
[]
[]
025b1b5687d061bc4116f77578fa9fc2b3fc1f26
diff --git a/strum_macros/src/macros/enum_count.rs b/strum_macros/src/macros/enum_count.rs --- a/strum_macros/src/macros/enum_count.rs +++ b/strum_macros/src/macros/enum_count.rs @@ -2,11 +2,18 @@ use proc_macro2::TokenStream; use quote::quote; use syn::{Data, DeriveInput}; +use crate::helpers::variant_props::HasSt...
Peternator7__strum-268
268
[ "267" ]
0.24
Peternator7/strum
2023-04-26T18:46:25Z
diff --git a/strum_tests/tests/enum_count.rs b/strum_tests/tests/enum_count.rs --- a/strum_tests/tests/enum_count.rs +++ b/strum_tests/tests/enum_count.rs @@ -11,12 +11,29 @@ enum Week { Saturday, } +#[allow(dead_code)] +#[derive(Debug, EnumCount, EnumIter)] +enum Pets { + Dog, + Cat, + Fish, + Bird...
Disabled variant still included in Count The [additional attributes docs](https://docs.rs/strum/latest/strum/additional_attributes/index.html#attributes-on-variants) define the `disabled` attribute as: > `disabled`: removes variant from generated code. However, when deriving the `EnumCount` trait, the disabled va...
025b1b5687d061bc4116f77578fa9fc2b3fc1f26
[ "disabled_test" ]
[ "crate_module_path_test", "simple_test" ]
[]
[]
c6c78a16c59af13a6bf6d35ed859618033a61768
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -277,6 +277,15 @@ dependencies = [ "unicode-width", ] +[[package]] +name = "content_inspector" +version = "0.2.4" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "b7bda66e858c683005a53a9a60c69a4aca7eeaa45d124526...
sigoden__dufs-179
179
[ "172" ]
0.31
sigoden/dufs
2023-02-20T14:35:53Z
diff --git a/tests/fixtures.rs b/tests/fixtures.rs --- a/tests/fixtures.rs +++ b/tests/fixtures.rs @@ -11,9 +11,12 @@ use std::time::{Duration, Instant}; #[allow(dead_code)] pub type Error = Box<dyn std::error::Error>; +#[allow(dead_code)] +pub const BIN_FILE: &str = "😀.bin"; + /// File names for testing purpose ...
[Feature Request] Edit files The ability to edit and save files on the server. txt, yaml, php etc.
a61fda6e80d70e5cd7ded9a9b33a9ca373c2b239
[ "get_file_edit_bin", "get_file_edit" ]
[ "utils::test_glob_key", "default_not_exist_dir", "allow_delete_no_override", "allow_upload_no_override", "allow_archive", "default_not_allow_upload", "default_not_allow_archive", "default_not_allow_delete", "allow_search", "allow_upload_not_exist_dir", "allow_upload_delete_can_override", "path...
[ "bind_ipv4_ipv6::case_2", "validate_printed_urls::case_2", "validate_printed_urls::case_1" ]
[]
c6dcaf95d4ccdcfe2af81d7dff43a5c440eca7da
diff --git a/README.md b/README.md --- a/README.md +++ b/README.md @@ -171,6 +171,16 @@ Delete a file/folder curl -X DELETE http://127.0.0.1:5000/path-to-file-or-folder ``` +List/search directory contents + +``` +curl http://127.0.0.1:5000?simple # output pathname only, just like `ls -1` + +curl htt...
sigoden__dufs-177
177
What scenarios need this kind of API ? Abstractly, a list directory API would allow end users to build file system abstractions around a given dufs server. For my use case, I'm building a GUI that when provided a URL to a `dufs` server, a file tree would be displayed. imagine something like https://doc.qt.io/qt-6/q...
[ "166" ]
0.31
sigoden/dufs
2023-02-20T02:46:30Z
diff --git a/tests/assets.rs b/tests/assets.rs --- a/tests/assets.rs +++ b/tests/assets.rs @@ -11,13 +11,13 @@ use std::process::{Command, Stdio}; fn assets(server: TestServer) -> Result<(), Error> { let ver = env!("CARGO_PKG_VERSION"); let resp = reqwest::blocking::get(server.url())?; - let index_js = fo...
[Feature request] API to search and list directories ## Specific Demand An API to search for a file and show contents of a directory. ### list directory API curl http://127.0.0.1:5000/path-to-directory?list_contents=true to return a list of this files contents, analogous to running the linux command `ls /pat...
a61fda6e80d70e5cd7ded9a9b33a9ca373c2b239
[ "get_dir_json", "get_dir_simple", "get_dir_search3" ]
[ "utils::test_glob_key", "default_not_exist_dir", "allow_upload_not_exist_dir", "allow_upload_no_override", "default_not_allow_upload", "allow_search", "allow_archive", "allow_delete_no_override", "default_not_allow_delete", "default_not_allow_archive", "allow_upload_delete_can_override", "path...
[ "bind_ipv4_ipv6::case_2", "validate_printed_urls::case_2", "validate_printed_urls::case_1" ]
[]
8f5aba5cfcf4d845035aab7cb4255dbea0e2573d
diff --git /dev/null b/changelog.d/2576.added.md new file mode 100644 --- /dev/null +++ b/changelog.d/2576.added.md @@ -0,0 +1,1 @@ +Added experimental.trust_any_certificate to enable making app trust any certificate on macOS \ No newline at end of file diff --git a/mirrord-schema.json b/mirrord-schema.json --- a/mirro...
metalbear-co__mirrord-2589
2,589
[ "2576" ]
3.109
metalbear-co/mirrord
2024-07-11T11:32:23Z
diff --git a/mirrord/config/src/experimental.rs b/mirrord/config/src/experimental.rs --- a/mirrord/config/src/experimental.rs +++ b/mirrord/config/src/experimental.rs @@ -10,22 +10,29 @@ use crate::config::source::MirrordConfigSource; #[config(map_to = "ExperimentalFileConfig", derive = "JsonSchema")] #[cfg_attr(test...
Add function detour for FN__SEC_TRUST_EVALUATE_WITH_ERROR Closes #2569
8f5aba5cfcf4d845035aab7cb4255dbea0e2573d
[ "tests::schema_file_is_up_to_date" ]
[ "agent::tests::default::log_level_1__None___info___::namespace_1__None_None_::image_1__None_None_::image_pull_policy_1__None___IfNotPresent___::ttl_1__None_1_::ephemeral_1__None_false_::communication_timeout_1__None_None_::startup_timeout_2__Some___30____30_", "agent::tests::default::log_level_1__None___info___::...
[]
[]
2f78dd8e7c5746e0c4b6edcb9fbf59c1bc9f0067
diff --git /dev/null b/changelog.d/2164.internal.md new file mode 100644 --- /dev/null +++ b/changelog.d/2164.internal.md @@ -0,0 +1,1 @@ +Moved the docs from `CopyTargetFileConfig` to `CopyTargetConfig` so that medschool reads them. diff --git a/mirrord-schema.json b/mirrord-schema.json --- a/mirrord-schema.json +++ b...
metalbear-co__mirrord-2165
2,165
[ "2164" ]
3.82
metalbear-co/mirrord
2024-01-10T10:40:35Z
diff --git a/mirrord/config/src/feature/copy_target.rs b/mirrord/config/src/feature/copy_target.rs --- a/mirrord/config/src/feature/copy_target.rs +++ b/mirrord/config/src/feature/copy_target.rs @@ -10,40 +10,12 @@ use serde::Deserialize; use crate::config::{ConfigContext, FromMirrordConfig, MirrordConfig, Result}; ...
Fix copy_target config docs The docs from the code do not appear in the generated docs.
2f78dd8e7c5746e0c4b6edcb9fbf59c1bc9f0067
[ "tests::schema_file_is_up_to_date" ]
[ "agent::tests::default::log_level_1__None___info___::namespace_1__None_None_::image_1__None_None_::image_pull_policy_1__None___IfNotPresent___::ttl_1__None_1_::ephemeral_1__None_false_::communication_timeout_1__None_None_::startup_timeout_1__None_60_", "agent::tests::default::log_level_1__None___info___::namespac...
[]
[]
879fd097bd5949bf694f8f6610900139323e1f33
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -2698,8 +2698,7 @@ dependencies = [ [[package]] name = "iptables" version = "0.5.1" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "d39f0d72d0feb83c9b7f4e1fbde2b4a629886f30841127b3f86383831dba2629" +source = "git...
metalbear-co__mirrord-2273
2,273
[ "2272" ]
3.89
metalbear-co/mirrord
2024-02-26T15:50:26Z
diff --git a/mirrord/config/src/agent.rs b/mirrord/config/src/agent.rs --- a/mirrord/config/src/agent.rs +++ b/mirrord/config/src/agent.rs @@ -253,6 +253,15 @@ pub struct AgentConfig { #[config(default = false)] pub privileged: bool, + /// ### agent.nftables {#agent-nftables} + /// + /// Use iptabl...
Support for Istio Mesh + nft When users use Istio Mesh + nftables (not iptables legacy) our rules run before mesh, leading to undefined behavior. We probably should have a flag - iptables_mode which can be either legacy or nft then we use the appropriate and all should work the same (in theory). Need to manually test...
879fd097bd5949bf694f8f6610900139323e1f33
[ "tests::schema_file_is_up_to_date", "api::container::job::test::targetless", "api::container::job::test::targeted" ]
[ "agent::tests::default::log_level_1__None___info___::namespace_1__None_None_::image_1__None_None_::image_pull_policy_1__None___IfNotPresent___::ttl_1__None_1_::ephemeral_1__None_false_::communication_timeout_1__None_None_::startup_timeout_1__None_60_", "agent::tests::default::log_level_1__None___info___::namespac...
[]
[]
8d19bf67acb88006f0f42744c4537bcc7b77039d
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -1221,6 +1221,15 @@ dependencies = [ "cfg-if", ] +[[package]] +name = "crossbeam-channel" +version = "0.5.11" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "176dc175b78f56c0f321911d9c8eb2b77a78a4860b9c19db8383...
metalbear-co__mirrord-2247
2,247
[ "2246" ]
3.87
metalbear-co/mirrord
2024-02-18T14:20:27Z
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -3502,7 +3512,7 @@ dependencies = [ "mirrord-protocol", "rand", "regex", - "rstest 0.17.0", + "rstest 0.18.2", "serde", "serde_json", "shellexpand", diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -3551,7 +35...
Allow for dumping intproxy logs to files Currently, whenever the internal proxy dies, the user is left only with some communication error. Having logs from the proxy would allow us to find the root of the problem
8d19bf67acb88006f0f42744c4537bcc7b77039d
[ "tests::schema_file_is_up_to_date" ]
[ "agent::tests::default::log_level_1__None___info___::namespace_1__None_None_::image_1__None_None_::image_pull_policy_1__None___IfNotPresent___::ttl_2__Some___30____30_::ephemeral_1__None_false_::communication_timeout_2__Some___30____Some_30__::startup_timeout_1__None_60_", "agent::tests::default::log_level_1__Non...
[]
[]
2df1a30c473926ead9ab883b61b1878cd69d63e8
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -4060,7 +4060,7 @@ dependencies = [ [[package]] name = "mirrord-protocol" -version = "1.10.0" +version = "1.11.0" dependencies = [ "actix-codec", "bincode", diff --git /dev/null b/changelog.d/2699.added.md new file mode 100644 --- /dev/n...
metalbear-co__mirrord-2699
2,699
I agree technically, but from UX side we wouldn't want too complex configuration Currently the config looks like: ```json { "http_filter": { "header_filter": "user: me" } } ``` or ```json { "http_filter": { "path_filter": "/api/v1/my-route.*" } } ``` I'd allow for thir...
[ "2683" ]
3.115
metalbear-co/mirrord
2024-08-23T16:44:18Z
diff --git a/mirrord-schema.json b/mirrord-schema.json --- a/mirrord-schema.json +++ b/mirrord-schema.json @@ -987,6 +987,28 @@ "description": "Filter configuration for the HTTP traffic stealer feature.\n\nAllows the user to set a filter (regex) for the HTTP headers, so that the stealer traffic feature only capt...
Support specifying both header and path filter for stealing HTTP IMO we should probably just allow for any set/combination of filters. Remember to verify config after fetching `mirrord-protocol` version used by agent/operator
866664165f21460504794672bb680257e090cfaa
[ "tests::schema_file_is_up_to_date" ]
[ "agent::tests::default::log_level_1__None___info___::namespace_1__None_None_::image_1__None_None_::image_pull_policy_1__None___IfNotPresent___::ttl_1__None_1_::ephemeral_1__None_false_::communication_timeout_1__None_None_::startup_timeout_2__Some___30____30_", "agent::tests::default::log_level_1__None___info___::...
[]
[]
7a2dd1b8b246dfc700a38b8ddb7ba244babf1272
diff --git /dev/null b/changelog.d/2641.fixed.md new file mode 100644 --- /dev/null +++ b/changelog.d/2641.fixed.md @@ -0,0 +1,1 @@ +Specify that `mirrord container` is an unstable feature. diff --git a/mirrord-schema.json b/mirrord-schema.json --- a/mirrord-schema.json +++ b/mirrord-schema.json @@ -527,7 +527,7 @@ ...
metalbear-co__mirrord-2668
2,668
[ "2641" ]
3.113
metalbear-co/mirrord
2024-08-15T15:12:18Z
diff --git a/mirrord/config/configuration.md b/mirrord/config/configuration.md --- a/mirrord/config/configuration.md +++ b/mirrord/config/configuration.md @@ -384,7 +384,7 @@ IP:PORT to connect to instead of using k8s api, for testing purposes. ## container {#root-container} -`mirrord container` command specific c...
Mark `mirrord container ...` as unstable 1. Mark `mirrord container ...` subcommand as unstable. 2. Maybe push this info to CLI progress as well? 3. ~~Add new session type field to analytics reports. Should allow for differentiating regular runs from container runs~~ done in #2643
7a2dd1b8b246dfc700a38b8ddb7ba244babf1272
[ "tests::schema_file_is_up_to_date" ]
[ "agent::tests::default::log_level_1__None___info___::namespace_1__None_None_::image_1__None_None_::image_pull_policy_1__None___IfNotPresent___::ttl_1__None_1_::ephemeral_1__None_false_::communication_timeout_2__Some___30____Some_30__::startup_timeout_1__None_60_", "agent::tests::default::log_level_1__None___info_...
[]
[]
bf3c0297895b85d87993ff54b62806e90b59f318
diff --git /dev/null b/changelog.d/2662.fixed.md new file mode 100644 --- /dev/null +++ b/changelog.d/2662.fixed.md @@ -0,0 +1,1 @@ +Fix IncomingConfig json schema regression. diff --git a/mirrord-schema.json b/mirrord-schema.json --- a/mirrord-schema.json +++ b/mirrord-schema.json @@ -1137,37 +1137,19 @@ "Incomin...
metalbear-co__mirrord-2665
2,665
I need to take a closer look but I think it should be contained to incoming because of how schemars parses serde macro and I added manual parsing logic to it
[ "2662" ]
3.113
metalbear-co/mirrord
2024-08-15T09:24:18Z
diff --git a/mirrord/config/src/feature/network/incoming.rs b/mirrord/config/src/feature/network/incoming.rs --- a/mirrord/config/src/feature/network/incoming.rs +++ b/mirrord/config/src/feature/network/incoming.rs @@ -67,6 +67,7 @@ use http_filter::*; /// ``` #[derive(Clone, Debug, JsonSchema)] #[cfg_attr(test, der...
schema issue on "incoming" (and probably others) <img width="570" alt="image" src="https://github.com/user-attachments/assets/b2232ec4-66e2-4670-85a2-c7d1b97c00f9"> I assume it's part of the refactor that @DmitryDodzin did
7a2dd1b8b246dfc700a38b8ddb7ba244babf1272
[ "tests::schema_file_is_up_to_date" ]
[ "agent::tests::default::log_level_1__None___info___::namespace_1__None_None_::image_1__None_None_::image_pull_policy_1__None___IfNotPresent___::ttl_1__None_1_::ephemeral_1__None_false_::communication_timeout_1__None_None_::startup_timeout_1__None_60_", "agent::tests::default::log_level_1__None___info___::namespac...
[]
[]
53c9db608c12f50fe5de647f7acfbc822d425d4c
diff --git /dev/null b/changelog.d/1479.fixed.md new file mode 100644 --- /dev/null +++ b/changelog.d/1479.fixed.md @@ -0,0 +1,1 @@ +Add new rule to the OUTPUT chain of iptables in agent to support kubectl port-forward diff --git a/mirrord/agent/src/main.rs b/mirrord/agent/src/main.rs --- a/mirrord/agent/src/main.rs ++...
metalbear-co__mirrord-1527
1,527
managed to reproduce it ill run wireshark/tcpdump in the pod to see where the forwarded traffic is actually going with steal on and sending request to the nodeport: ``` 15:38:32.077374 IP 192-168-65-4.kubernetes.default.svc.cluster.local.60460 > py-serv-deployment-ff89b5974-dhl2q.http: Flags [S], seq 439708412, win 6...
[ "1479" ]
3.47
metalbear-co/mirrord
2023-06-09T03:29:59Z
diff --git a/mirrord/agent/src/steal/ip_tables.rs b/mirrord/agent/src/steal/ip_tables.rs --- a/mirrord/agent/src/steal/ip_tables.rs +++ b/mirrord/agent/src/steal/ip_tables.rs @@ -38,6 +40,16 @@ pub static IPTABLE_MESH: LazyLock<String> = LazyLock::new(|| { }) }); +pub static IPTABLE_STANDARD_ENV: &str = "MIRROR...
request through `kubectl port forward` doesn't get stolen When stealing pod requests, if one uses `kubectl port forward deploy/deploymentname 8080` those requests still get answered by the remote.
dfab96e405bf4b195117700926bc15352d57f069
[ "steal::ip_tables::tests::default" ]
[ "env::tests::default", "env::tests::default_exclude", "env::tests::include", "util::indexallocator_tests::check_max", "steal::ip_tables::redirect::tests::add_redirect_twice", "steal::ip_tables::redirect::tests::add_redirect", "util::indexallocator_tests::sanity", "steal::ip_tables::redirect::tests::re...
[]
[ "tests::sanity" ]
e9dd388116c77eba1cee287db2ba27a0d63487d7
diff --git /dev/null b/changelog.d/+remove-capture-error-trace.removed.md new file mode 100644 --- /dev/null +++ b/changelog.d/+remove-capture-error-trace.removed.md @@ -0,0 +1,1 @@ +Removed error capture error trace feature \ No newline at end of file diff --git a/mirrord-schema.json b/mirrord-schema.json --- a/mirror...
metalbear-co__mirrord-1623
1,623
[ "744" ]
3.49
metalbear-co/mirrord
2023-07-06T06:58:19Z
diff --git a/mirrord-schema.json b/mirrord-schema.json --- a/mirrord-schema.json +++ b/mirrord-schema.json @@ -1,7 +1,7 @@ { "$schema": "http://json-schema.org/draft-07/schema#", "title": "LayerFileConfig", - "description": "mirrord allows for a high degree of customization when it comes to which features you w...
Capture log clashes with install script ### Bug Description The capture log feature creates a folder called /tmp/mirrord. The install.sh tries to create a file called /tmp/mirrord, and if the folder exists it crashes. Need to add a GUID to the filename. ### Steps to Reproduce Run mirrord with capture log, then run t...
e9dd388116c77eba1cee287db2ba27a0d63487d7
[ "tests::schema_file_is_up_to_date" ]
[ "agent::tests::default::log_level_1__None___info___::namespace_1__None_None_::image_1__None_None_::image_pull_policy_1__None___IfNotPresent___::ttl_1__None_1_::ephemeral_1__None_false_::communication_timeout_1__None_None_::startup_timeout_1__None_60_", "agent::tests::default::log_level_1__None___info___::namespac...
[]
[]
da95b6d28bfe6cf94586a5e916c97c81ab6bdac0
diff --git a/crates/compiler/load_internal/src/file.rs b/crates/compiler/load_internal/src/file.rs --- a/crates/compiler/load_internal/src/file.rs +++ b/crates/compiler/load_internal/src/file.rs @@ -6593,6 +6593,8 @@ fn to_incorrect_module_name_report<'a>( expected, } = problem; + let severity = Seve...
roc-lang__roc-6794
6,794
Extra warning: it does look like this change [requires changing many lines of code](https://roc.zulipchat.com/#narrow/stream/316715-contributing/topic/Use.20yellow.20underline.20in.20warnings.20.236771/near/442066162).
[ "6771" ]
0.0
roc-lang/roc
2024-06-09T17:29:24Z
diff --git a/crates/compiler/load/tests/test_reporting.rs b/crates/compiler/load/tests/test_reporting.rs --- a/crates/compiler/load/tests/test_reporting.rs +++ b/crates/compiler/load/tests/test_reporting.rs @@ -4772,7 +4772,7 @@ mod test_reporting { // TODO investigate this test. It was disabled in https://github....
Use yellow underline in warnings We currently use `^^^^^^` in red to underline both in errors and warnings, we should use yellow (the same we use for the warning counter) in warnings. I believe changes to be made mainly in crates/reporting. I think this is feasible as good first issue, but talk to us on [zulip](https:/...
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::crash_overapplied" ]
[ "test_reporting::ability_demand_value_has_args", "test_reporting::ability_non_signature_expression", "test_reporting::ability_demands_not_indented_with_first", "test_reporting::ability_first_demand_not_indented_enough", "test_reporting::argument_without_space", "test_reporting::always_function", "test_r...
[]
[]
db94b555ab1946ad6bfdb5314a11ba67d9b1d1da
diff --git a/crates/compiler/can/src/suffixed.rs b/crates/compiler/can/src/suffixed.rs --- a/crates/compiler/can/src/suffixed.rs +++ b/crates/compiler/can/src/suffixed.rs @@ -576,6 +576,8 @@ pub fn unwrap_suffixed_expression_when_help<'a>( Err(..) => return Err(EUnwrapped::Malformed), ...
roc-lang__roc-6786
6,786
``` roc nightly pre-release, built from commit 33075285b72 on Wed May 22 09:12:12 UTC 2024 ``` Mac Silicon Thanks for the bug report! @Anton-4 please assign it to me
[ "6778" ]
0.0
roc-lang/roc
2024-06-03T21:04:43Z
diff --git a/crates/compiler/can/tests/test_suffixed.rs b/crates/compiler/can/tests/test_suffixed.rs --- a/crates/compiler/can/tests/test_suffixed.rs +++ b/crates/compiler/can/tests/test_suffixed.rs @@ -865,6 +865,21 @@ mod suffixed_tests { r#"Defs { tags: [Index(2147483648)], regions: [@0-55], space_befor...
An internal compiler expectation was broken Code ```roc app [main] { pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.10.0/vNe6s9hWzoTZtFmNkvEICPErI9ptji_ySjicO6CkucY.tar.br" } import pf.Stdout import pf.Task import pf.Http main = request = { method: Get, headers:...
e819c954d393eb3223dd5961556d07ce21b29831
[ "suffixed_tests::deep_when" ]
[ "suffixed_tests::apply_argument_multiple", "suffixed_tests::apply_argument_single", "suffixed_tests::apply_argument_suffixed", "suffixed_tests::defs_suffixed_middle", "suffixed_tests::apply_function_suffixed", "suffixed_tests::closure_with_defs", "suffixed_tests::bang_in_pipe_root", "suffixed_tests::s...
[]
[]
674b9348215118a7c977d0685979d850d3a5f649
diff --git a/crates/compiler/can/src/expr.rs b/crates/compiler/can/src/expr.rs --- a/crates/compiler/can/src/expr.rs +++ b/crates/compiler/can/src/expr.rs @@ -1127,7 +1127,7 @@ pub fn canonicalize_expr<'a>( output, ) } - ast::Expr::TaskAwaitBang(..) => internal_error!("a Ex...
roc-lang__roc-6785
6,785
Thank you for logging this bug. @kdziamura Found the root cause. Please assign it to me
[ "6784" ]
0.0
roc-lang/roc
2024-06-03T15:07:40Z
diff --git a/crates/compiler/can/tests/test_suffixed.rs b/crates/compiler/can/tests/test_suffixed.rs --- a/crates/compiler/can/tests/test_suffixed.rs +++ b/crates/compiler/can/tests/test_suffixed.rs @@ -853,6 +853,18 @@ mod suffixed_tests { r##"Defs { tags: [Index(2147483648)], regions: [@0-52], space_befo...
Expect statements breaks with "a Expr::TaskAwaitBang expression was not completed removed in desugar_value_def_suffixed" I'm just doing what the error told me and reporting the issue :smile: I added `expect 1 == 2` to the first line of the my main function and got the following error when running `roc dev` ```sh...
e819c954d393eb3223dd5961556d07ce21b29831
[ "suffixed_tests::expect_then_bang" ]
[ "suffixed_tests::dbg_simple", "suffixed_tests::closure_simple", "suffixed_tests::apply_argument_multiple", "suffixed_tests::multiple_def_first_suffixed", "suffixed_tests::multiple_suffix", "suffixed_tests::last_suffixed_multiple", "suffixed_tests::multi_defs_stmts", "suffixed_tests::nested_complex", ...
[]
[]
8818b37fa256ed7508f024761af595c7722e45fe
diff --git a/crates/compiler/can/src/suffixed.rs b/crates/compiler/can/src/suffixed.rs --- a/crates/compiler/can/src/suffixed.rs +++ b/crates/compiler/can/src/suffixed.rs @@ -122,11 +122,52 @@ pub fn unwrap_suffixed_expression<'a>( Expr::SpaceBefore(..) | Expr::SpaceAfter(..) => { internal...
roc-lang__roc-6712
6,712
[ "6672" ]
0.0
roc-lang/roc
2024-05-04T19:40:33Z
diff --git a/crates/compiler/can/tests/test_suffixed.rs b/crates/compiler/can/tests/test_suffixed.rs --- a/crates/compiler/can/tests/test_suffixed.rs +++ b/crates/compiler/can/tests/test_suffixed.rs @@ -775,6 +775,35 @@ mod suffixed_tests { r#"Defs { tags: [Index(2147483648)], regions: [@0-226], space_befo...
`!` and `dbg` statements interfere with each other Needs further investigation. When using multiple `dbg` and `!` statements in a def, they can interfere with each other.
e819c954d393eb3223dd5961556d07ce21b29831
[ "suffixed_tests::dbg_simple" ]
[ "suffixed_tests::body_parens_apply", "suffixed_tests::basic", "suffixed_tests::closure_simple", "suffixed_tests::if_simple", "suffixed_tests::apply_argument_suffixed", "suffixed_tests::multiple_def_first_suffixed", "suffixed_tests::nested_complex", "suffixed_tests::defs_suffixed_middle", "suffixed_t...
[]
[]
05823cd1a03ac3ce0d39706dfd77b7a7b8a8c908
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -2196,6 +2196,7 @@ version = "0.0.1" dependencies = [ "bumpalo", "indoc", + "regex", "roc_build", "roc_cli", "roc_repl_cli", diff --git a/crates/cli/src/main.rs b/crates/cli/src/main.rs --- a/crates/cli/src/main.rs +++ b/crates/cli/src...
roc-lang__roc-6525
6,525
I would like to take a look at this. It looks like we can use brighter colors out of 256 colors if terminal supports them (otherwise fallbacks to ansi colors). Oh so we can't simply check environment variables as `STYLE_CODES` is a global variable. Let's change colors in the variable into something brighter from 256 co...
[ "6512" ]
0.0
roc-lang/roc
2024-02-14T17:05:12Z
diff --git a/crates/cli/src/lib.rs b/crates/cli/src/lib.rs --- a/crates/cli/src/lib.rs +++ b/crates/cli/src/lib.rs @@ -440,6 +440,7 @@ pub fn test(matches: &ArgMatches, triple: Triple) -> io::Result<i32> { use roc_build::program::report_problems_monomorphized; use roc_load::{ExecutionMode, FunctionKind, LoadC...
Improve repl contrast on (very) dark terminal background ![PXL_20240207_110908757.MP.jpg](https://github.com/roc-lang/roc/assets/17049058/91545af3-b1bd-44e8-b777-f738e6d52443) In real life the contrast is worse than in the photo. The blue text is unreadable and the pink colon's visibility is not good enough.
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::report_value_color" ]
[ "test_reporting::ability_first_demand_not_indented_enough", "test_reporting::ability_demands_not_indented_with_first", "test_reporting::ability_demand_value_has_args", "test_reporting::ability_non_signature_expression", "test_reporting::ability_specialization_is_unused", "test_reporting::apply_unary_negat...
[]
[]
b22f7939677de4e4e66dfc3b72afbbb7e16f1702
diff --git a/crates/compiler/load_internal/src/file.rs b/crates/compiler/load_internal/src/file.rs --- a/crates/compiler/load_internal/src/file.rs +++ b/crates/compiler/load_internal/src/file.rs @@ -3838,6 +3838,35 @@ struct HeaderOutput<'a> { opt_platform_shorthand: Option<&'a str>, } +fn ensure_roc_file<'a>(f...
roc-lang__roc-6506
6,506
[ "6418" ]
0.0
roc-lang/roc
2024-02-05T19:44:01Z
diff --git a/crates/compiler/load_internal/tests/test_load.rs b/crates/compiler/load_internal/tests/test_load.rs --- a/crates/compiler/load_internal/tests/test_load.rs +++ b/crates/compiler/load_internal/tests/test_load.rs @@ -323,7 +323,7 @@ fn import_transitive_alias() { // with variables in the importee le...
Roc should error for non-roc files [zulip discussion](https://roc.zulipchat.com/#narrow/stream/304641-ideas/topic/Handle.20non.20roc.20files/near/417371854) ## Current Behaviour Currently `roc run` on an exectutable non-`.roc` file gives the following error. ``` $ roc run examples/movies.csv ── MISSING HEADER...
e819c954d393eb3223dd5961556d07ce21b29831
[ "non_roc_file_extension", "roc_file_no_extension" ]
[ "file_not_found - should panic", "ingested_file_not_found - should panic", "module_doesnt_match_file_path", "imported_file_not_found - should panic", "platform_parse_error", "test_load_and_typecheck", "app_quicksort", "imported_dep_regression", "load_principal_types", "import_alias", "ingested_f...
[]
[]
26846e14aa0a06baa8cd4017abfc60c15ff359df
diff --git a/crates/compiler/constrain/src/expr.rs b/crates/compiler/constrain/src/expr.rs --- a/crates/compiler/constrain/src/expr.rs +++ b/crates/compiler/constrain/src/expr.rs @@ -1782,7 +1782,7 @@ fn constrain_function_def( let signature_index = constraints.push_type(types, signature); - ...
roc-lang__roc-5287
5,287
ROC_CHECK_MONO_IR fails here, this is a layout bug.
[ "5264" ]
0.0
roc-lang/roc
2023-04-12T20:36:24Z
diff --git a/crates/reporting/tests/test_reporting.rs b/crates/reporting/tests/test_reporting.rs --- a/crates/reporting/tests/test_reporting.rs +++ b/crates/reporting/tests/test_reporting.rs @@ -2615,6 +2615,27 @@ mod test_reporting { I would have to crash if I saw one of those! So rather than pattern matchin...
roc build panics with Invalid InsertValueInst operands when importing an interface This is similar to my previous issue #5212 that was fixed, but I find I only get this error when I import LinkedList from another file. Putting all the definitions in a single file compiles and run successfully. Using MacOS 13.1 with Int...
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::function_arity_mismatch_too_few", "test_reporting::function_arity_mismatch_too_many", "test_reporting::function_arity_mismatch_nested_too_few", "test_reporting::function_arity_mismatch_nested_too_many", "test_reporting::patterns_fn_not_exhaustive" ]
[ "test_reporting::ability_demand_value_has_args", "test_reporting::ability_demands_not_indented_with_first", "test_reporting::ability_first_demand_not_indented_enough", "test_reporting::ability_non_signature_expression", "test_reporting::ability_member_does_not_bind_ability", "test_reporting::alias_using_a...
[]
[]
191d8a74086267b102bb2a388dbd37f5b814b6e8
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -5084,8 +5084,12 @@ dependencies = [ "pretty_assertions", "regex", "roc_builtins", + "roc_collections", "roc_derive", "roc_load", + "roc_module", + "roc_mono", + "roc_packaging", "roc_parse", "roc_problem", "roc_reporting", diff -...
roc-lang__roc-5284
5,284
This issue was originally reported [here](https://github.com/roc-lang/basic-cli/issues/23).
[ "5131" ]
0.0
roc-lang/roc
2023-04-12T16:41:00Z
diff --git a/crates/compiler/solve/tests/solve_expr.rs b/crates/compiler/solve/tests/solve_expr.rs --- a/crates/compiler/solve/tests/solve_expr.rs +++ b/crates/compiler/solve/tests/solve_expr.rs @@ -31,7 +31,7 @@ mod solve_expr { .. }, src, - ) = run_load_and_infer(src,...
Record update with `&` fails on imported record This is similar to https://github.com/roc-lang/roc/issues/3908 which has been resolved, I think the issue may be caused by the fact that `defaultRequest` is imported. ``` app "temptest" packages { pf: "cli-platform/main.roc" } imports [pf.Stdout, pf.Http.{de...
e819c954d393eb3223dd5961556d07ce21b29831
[ "tests/lambda_set/disjoint_nested_lambdas_result_in_disjoint_parents_issue_4712.txt " ]
[ "solve_expr::annotated_using_i16", "solve_expr::annotation_f64", "solve_expr::annotated_f32", "solve_expr::annotated_using_i64", "solve_expr::ability_constrained_in_non_member_infer", "solve_expr::annotated_using_u8", "solve_expr::annotated_using_u16", "solve_expr::annotated_using_u64", "solve_expr:...
[]
[ "tests/specialize/record_update_between_modules.txt " ]
191d8a74086267b102bb2a388dbd37f5b814b6e8
diff --git a/crates/reporting/src/error/type.rs b/crates/reporting/src/error/type.rs --- a/crates/reporting/src/error/type.rs +++ b/crates/reporting/src/error/type.rs @@ -1138,8 +1138,8 @@ fn to_expr_report<'b>( ), } } - Reason::FnCall { name, arity } => mat...
roc-lang__roc-5280
5,280
[ "5094" ]
0.0
roc-lang/roc
2023-04-12T15:06:58Z
diff --git a/crates/reporting/tests/test_reporting.rs b/crates/reporting/tests/test_reporting.rs --- a/crates/reporting/tests/test_reporting.rs +++ b/crates/reporting/tests/test_reporting.rs @@ -13381,4 +13381,33 @@ I recommend using camelCase. It's the standard style in Roc code! "# ) ); + +...
Confusing error message when forgetting to unwrap function from opaque type The following code tries to apply a function wrapped in an opaque type without unwrapping it first: ``` interface Package exposes [] imports [] Parser a := Str -> a parser : Parser Str parser = @Parser \s -> Str.concat s "a...
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::apply_opaque_as_function" ]
[ "test_reporting::ability_demand_value_has_args", "test_reporting::ability_first_demand_not_indented_enough", "test_reporting::ability_non_signature_expression", "test_reporting::ability_demands_not_indented_with_first", "test_reporting::backpassing_type_error", "test_reporting::ability_value_annotations_a...
[]
[]
41d7ade5a363f3c6d1512409b328404501e14940
diff --git a/crates/compiler/solve/src/solve.rs b/crates/compiler/solve/src/solve.rs --- a/crates/compiler/solve/src/solve.rs +++ b/crates/compiler/solve/src/solve.rs @@ -1847,6 +1847,11 @@ fn open_tag_union(subs: &mut Subs, var: Variable) { stack.extend(subs.get_subs_slice(fields.variables())); ...
roc-lang__roc-5188
5,188
[ "5177" ]
0.0
roc-lang/roc
2023-03-24T19:13:24Z
diff --git a/crates/reporting/tests/test_reporting.rs b/crates/reporting/tests/test_reporting.rs --- a/crates/reporting/tests/test_reporting.rs +++ b/crates/reporting/tests/test_reporting.rs @@ -13170,4 +13170,17 @@ I recommend using camelCase. It's the standard style in Roc code! I would have to crash if I saw on...
Wildcard in when expression does not open tag unions inside tuples ``` interface B exposes [] imports [] expect x : [A, B, C] when (x, 1u8) is (A, _) -> Bool.true (B, _) -> Bool.true _ -> Bool.true ``` should not error but it does ``` ── TYPE MISMATCH ───────────────────────────────────...
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::openness_constraint_opens_under_tuple" ]
[ "test_reporting::ability_specialization_is_unused", "test_reporting::ability_specialization_is_duplicated_with_type_mismatch", "test_reporting::anonymous_function_does_not_use_param", "test_reporting::ability_demands_not_indented_with_first", "test_reporting::ability_non_signature_expression", "test_repor...
[]
[]
bf41570648d99822a2f6591615c507038d3a26cc
diff --git a/crates/compiler/builtins/roc/Decode.roc b/crates/compiler/builtins/roc/Decode.roc --- a/crates/compiler/builtins/roc/Decode.roc +++ b/crates/compiler/builtins/roc/Decode.roc @@ -23,6 +23,7 @@ interface Decode string, list, record, + tuple, custom, decodeW...
roc-lang__roc-5179
5,179
Yes, they should - just like records! This is a bug.
[ "5143" ]
0.0
roc-lang/roc
2023-03-22T21:57:07Z
diff --git a/crates/compiler/derive/src/util.rs b/crates/compiler/derive/src/util.rs --- a/crates/compiler/derive/src/util.rs +++ b/crates/compiler/derive/src/util.rs @@ -18,19 +18,20 @@ pub(crate) struct Env<'a> { } impl Env<'_> { - pub fn new_symbol(&mut self, name_hint: &str) -> Symbol { + pub fn new_symbo...
Tuples don't implement `Eq` even if all of their elements do The following code errors, however each of the elements implement the `Eq` abiliity. ```elixir interface Blah exposes [] imports [] expect (0.0, 2, "x") == (0.0, 2, "x") ``` ``` % roc test Blah.roc ── TYPE MISMATCH ─────────────────────...
e819c954d393eb3223dd5961556d07ce21b29831
[ "decoding::different_tuple_arities", "decoding::same_tuple", "decoding::same_tuple_fields_diff_types", "encoding::different_tuple_arities", "encoding::same_tuple_fields_diff_types", "encoding::same_tuple", "hash::different_tuple_arities", "hash::same_tuple", "hash::same_tuple_fields_diff_types", "...
[ "decoding::derivable_record_ext_flex_able_var", "decoding::derivable_record_ext_flex_var", "decoding::derivable_record_with_record_ext", "decoding::different_record_fields", "decoding::optional_record_field_derive_error", "decoding::same_record_fields_any_order", "decoding::explicit_empty_record_and_imp...
[]
[]
d66f581eeb21ba7028b2e2f33af9f99974d2c3b6
diff --git a/crates/compiler/fmt/src/expr.rs b/crates/compiler/fmt/src/expr.rs --- a/crates/compiler/fmt/src/expr.rs +++ b/crates/compiler/fmt/src/expr.rs @@ -624,6 +624,22 @@ fn starts_with_newline(expr: &Expr) -> bool { } } +fn fmt_str_body(body: &str, buf: &mut Buf) { + for c in body.chars() { + ma...
roc-lang__roc-7004
7,004
@lukewilliamboswell I started looking into this one and I think I have a solution: https://github.com/roc-lang/roc/compare/main...a-lavis:roc:format-invisible-chars However, there's one thing I'm not sure how to deal with - the formatter checks to make sure that the AST before formatting matches the AST after f...
[ "6927" ]
0.0
roc-lang/roc
2024-08-17T05:31:53Z
diff --git a/crates/compiler/test_syntax/tests/test_fmt.rs b/crates/compiler/test_syntax/tests/test_fmt.rs --- a/crates/compiler/test_syntax/tests/test_fmt.rs +++ b/crates/compiler/test_syntax/tests/test_fmt.rs @@ -6333,6 +6333,83 @@ mod test_fmt { ); } + #[test] + fn keep_explicit_blank_chars() {...
Format invisible unicode as a literal Have the formatter swap invisible unicode in Str with the literal See [zulip discussion for more context](https://roc.zulipchat.com/#narrow/stream/304641-ideas/topic/Non-printable.20characters.20in.20.60Str.60/near/454529871) ## example module ```roc module [] # this str...
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_fmt::make_blank_chars_explicit", "test_fmt::make_blank_chars_explicit_in_multiline_string", "test_fmt::make_blank_chars_explicit_when_interpolating" ]
[ "test_fmt::accessor", "test_fmt::basic_block_string", "test_fmt::apply_lambda", "test_fmt::ability_member_doc_comments", "test_fmt::backpassing_apply_tag", "test_fmt::backpassing_body_on_newline", "test_fmt::basic_string", "test_fmt::binary_op", "test_fmt::binary_op_with_spaces", "test_fmt::backpa...
[ "test_fmt::test_fmt_examples" ]
[]
e10448e92caf53e136cf1ab8257cfb5bf0e11ec6
diff --git a/crates/compiler/can/src/def.rs b/crates/compiler/can/src/def.rs --- a/crates/compiler/can/src/def.rs +++ b/crates/compiler/can/src/def.rs @@ -2969,7 +2969,7 @@ fn to_pending_value_def<'a>( AnnotatedBody { ann_pattern, ann_type, - comment: _, + lines_...
roc-lang__roc-6926
6,926
[ "6896" ]
0.0
roc-lang/roc
2024-07-27T21:32:48Z
diff --git a/crates/compiler/can/tests/snapshots/test_suffixed__suffixed_tests__basic.snap b/crates/compiler/can/tests/snapshots/test_suffixed__suffixed_tests__basic.snap --- a/crates/compiler/can/tests/snapshots/test_suffixed__suffixed_tests__basic.snap +++ b/crates/compiler/can/tests/snapshots/test_suffixed__suffixed...
Formatter deletes comments between annotation and body Roc formatter deletes comments that are between annotation and body Repro: `Bug.roc` ```roc app [main] { pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.10.0/vNe6s9hWzoTZtFmNkvEICPErI9ptji_ySjicO6CkucY.tar.br", } import pf.T...
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_fmt::preserve_annotated_body_blank_comment", "test_fmt::preserve_annotated_body_comments", "test_fmt::preserve_annotated_body_comments_without_newlines" ]
[ "test_fmt::basic_string", "test_fmt::basic_block_string", "test_fmt::apply_lambda", "test_fmt::backpassing_body_on_newline", "test_fmt::accessor", "test_fmt::binary_op_with_spaces", "test_fmt::backpassing_simple", "test_fmt::ability_member_doc_comments", "test_fmt::binary_op", "test_fmt::closure_m...
[ "test_fmt::test_fmt_examples" ]
[]
05ab0183805907c3042e9f946a08b793ea75c038
diff --git a/crates/compiler/can/src/desugar.rs b/crates/compiler/can/src/desugar.rs --- a/crates/compiler/can/src/desugar.rs +++ b/crates/compiler/can/src/desugar.rs @@ -755,28 +755,6 @@ pub fn desugar_expr<'a>( }) } - // Replace an empty final def with a `Task.ok {}` - EmptyDefsF...
roc-lang__roc-6851
6,851
Update - as a workaround in bocci-bird I've pull the closure out into a helper and that has resolved the issue. But this still seems like an interesting edge case. I ran into what I think is this same issue, and came up with a simpler reproduction: ```roc app [main] { cli: platform "https://github.com/roc-lang...
[ "6656" ]
0.0
roc-lang/roc
2024-06-28T23:40:47Z
diff --git a/crates/compiler/can/tests/test_suffixed.rs b/crates/compiler/can/tests/test_suffixed.rs --- a/crates/compiler/can/tests/test_suffixed.rs +++ b/crates/compiler/can/tests/test_suffixed.rs @@ -1,3 +1,6 @@ +#[macro_use] +extern crate indoc; + #[cfg(test)] mod suffixed_tests { diff --git a/crates/compiler/c...
Investigate `Task.await` behaviour in rocci-bird Investigate why the two below are not equal. The only change is the line `collided <- collidedTask |> Task.await` to `Task.await collidedTask \collided ->` ```roc List.walk collisionPoints (Task.ok Bool.false) \collidedTask, { x, y } -> collided <- co...
e819c954d393eb3223dd5961556d07ce21b29831
[ "suffixed_tests::dbg_stmt_arg", "suffixed_tests::deep_when", "suffixed_tests::closure_with_annotations", "suffixed_tests::last_stmt_not_top_level_suffixed", "suffixed_tests::if_simple", "suffixed_tests::expect_then_bang", "suffixed_tests::deps_final_expr", "suffixed_tests::multiple_def_first_suffixed"...
[ "suffixed_tests::apply_argument_single", "suffixed_tests::basic", "suffixed_tests::apply_argument_multiple", "suffixed_tests::bang_in_pipe_root", "suffixed_tests::apply_argument_suffixed", "suffixed_tests::apply_function_suffixed", "suffixed_tests::body_parens_apply", "suffixed_tests::closure_simple",...
[]
[]
44d76d78a13e6b6b4adea075a93b3b46989704f2
diff --git a/crates/compiler/can/src/suffixed.rs b/crates/compiler/can/src/suffixed.rs --- a/crates/compiler/can/src/suffixed.rs +++ b/crates/compiler/can/src/suffixed.rs @@ -129,46 +129,7 @@ pub fn unwrap_suffixed_expression<'a>( internal_error!("BinOps should have been desugared in desugar_expr"); ...
roc-lang__roc-6847
6,847
Thanks for reporting this @fwgreen! In case it may help, this is a workaround: ```roc dbg List.len results end = Utc.toMillisSinceEpoch Utc.now! dbg end - start ``` Minimal reproduction for future debugging: ```roc app [main] { pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.10.0/v...
[ "6838" ]
0.0
roc-lang/roc
2024-06-28T11:09:13Z
diff --git a/crates/compiler/can/tests/test_suffixed.rs b/crates/compiler/can/tests/test_suffixed.rs --- a/crates/compiler/can/tests/test_suffixed.rs +++ b/crates/compiler/can/tests/test_suffixed.rs @@ -900,6 +900,19 @@ mod suffixed_tests { r#"Defs { tags: [Index(2147483648)], regions: [@0-266], space_befo...
Crashed with Malformed Suffix ```roc app [main] { pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.10.0/vNe6s9hWzoTZtFmNkvEICPErI9ptji_ySjicO6CkucY.tar.br", } import pf.Stdout import pf.Task import pf.Utc Option a : [Some a, None] main = start = Utc.toMillisSinceEpoch Utc.n...
e819c954d393eb3223dd5961556d07ce21b29831
[ "suffixed_tests::dbg_stmt_arg" ]
[ "suffixed_tests::apply_argument_suffixed", "suffixed_tests::apply_function_suffixed", "suffixed_tests::apply_argument_single", "suffixed_tests::basic", "suffixed_tests::bang_in_pipe_root", "suffixed_tests::apply_argument_multiple", "suffixed_tests::closure_simple", "suffixed_tests::defs_suffixed_middl...
[]
[]
1b10772bcbbdb91f6b1b67d986c392caae7732b9
diff --git a/crates/compiler/parse/src/ast.rs b/crates/compiler/parse/src/ast.rs --- a/crates/compiler/parse/src/ast.rs +++ b/crates/compiler/parse/src/ast.rs @@ -575,8 +575,7 @@ pub fn is_expr_suffixed(expr: &Expr) -> bool { Expr::Closure(_, sub_loc_expr) => is_expr_suffixed(&sub_loc_expr.value), /...
roc-lang__roc-6837
6,837
@Anton-4 please assign to me Done, thanks for helping out @kdziamura :heart:
[ "6800" ]
0.0
roc-lang/roc
2024-06-25T12:57:37Z
diff --git a/crates/compiler/can/tests/test_suffixed.rs b/crates/compiler/can/tests/test_suffixed.rs --- a/crates/compiler/can/tests/test_suffixed.rs +++ b/crates/compiler/can/tests/test_suffixed.rs @@ -610,7 +610,7 @@ mod suffixed_tests { else line "fail" "#, - ...
Compiler panic from `Expr::TaskAwaitBang` desugaring ...or something like that. I built Roc from source with Nix at db94b555ab1946ad6bfdb5314a11ba67d9b1d1da. ```roc app [main] { pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.10.0/vNe6s9hWzoTZtFmNkvEICPErI9ptji_ySjicO6CkucY.tar.br", ...
e819c954d393eb3223dd5961556d07ce21b29831
[ "suffixed_tests::deps_final_expr", "suffixed_tests::if_simple", "suffixed_tests::trailing_binops" ]
[ "suffixed_tests::basic", "suffixed_tests::bang_in_pipe_root", "suffixed_tests::apply_argument_multiple", "suffixed_tests::apply_argument_single", "suffixed_tests::body_parens_apply", "suffixed_tests::closure_simple", "suffixed_tests::apply_argument_suffixed", "suffixed_tests::dbg_simple", "suffixed_...
[]
[]
31b62e929c879a9c8b2b775642545a707a09bd0d
diff --git a/crates/reporting/src/error/canonicalize.rs b/crates/reporting/src/error/canonicalize.rs --- a/crates/reporting/src/error/canonicalize.rs +++ b/crates/reporting/src/error/canonicalize.rs @@ -1177,7 +1177,7 @@ fn to_bad_ident_expr_report<'b>( let region = LineColumnRegion::from_pos(lines.convert...
roc-lang__roc-6057
6,057
[ "6056" ]
0.0
roc-lang/roc
2023-11-21T22:38:50Z
diff --git a/crates/compiler/load/tests/test_reporting.rs b/crates/compiler/load/tests/test_reporting.rs --- a/crates/compiler/load/tests/test_reporting.rs +++ b/crates/compiler/load/tests/test_reporting.rs @@ -4269,7 +4269,7 @@ mod test_reporting { @r###" ── SYNTAX PROBLEM ───────────────────────────────...
Error message: SYNTAX PROBLEM trying to parse record error typo There is a typo in the error message when a record name is expected but not found, example: ```shell $ roc repl The rockin' roc repl ──────────────────────── Enter an expression, or :help, or :q to quit. » y. ── SYNTAX PROBLEM ────────────...
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::record_access_ends_with_dot", "test_reporting::stray_dot_expr" ]
[ "test_reporting::ability_first_demand_not_indented_enough", "test_reporting::argument_without_space", "test_reporting::annotation_newline_body_is_fine", "test_reporting::ability_shadows_ability", "test_reporting::ability_not_on_toplevel", "test_reporting::alias_using_alias", "test_reporting::ability_spe...
[]
[]
31b62e929c879a9c8b2b775642545a707a09bd0d
diff --git a/crates/compiler/parse/src/expr.rs b/crates/compiler/parse/src/expr.rs --- a/crates/compiler/parse/src/expr.rs +++ b/crates/compiler/parse/src/expr.rs @@ -549,6 +549,9 @@ pub fn parse_single_def<'a>( let spaces_before_current_start = state.pos(); let state = match space0_e(EExpr::IndentStart).pa...
roc-lang__roc-6054
6,054
[ "5939" ]
0.0
roc-lang/roc
2023-11-21T21:16:43Z
diff --git a/crates/compiler/load/tests/test_reporting.rs b/crates/compiler/load/tests/test_reporting.rs --- a/crates/compiler/load/tests/test_reporting.rs +++ b/crates/compiler/load/tests/test_reporting.rs @@ -4563,7 +4563,7 @@ mod test_reporting { comment_with_control_character, "# comment with a \x...
Parser bug with unicode characters in comment The code sample below will give a `MISSING FINAL EXPRESSION` error which is not correct. This is a bug in the parser which is caused by the presence of unicode characters in a comment somehow. ``` % roc test Broken.roc ── MISSING FINAL EXPRESSION ─────────────────────...
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::comment_with_control_character" ]
[ "test_reporting::ability_first_demand_not_indented_enough", "test_reporting::ability_demand_value_has_args", "test_reporting::ability_demands_not_indented_with_first", "test_reporting::ability_non_signature_expression", "test_reporting::applied_tag_function", "test_reporting::argument_without_space", "t...
[]
[]
a3e9f06241f397a907c8a2c81f0ad2800fcaedc5
diff --git a/crates/compiler/constrain/src/expr.rs b/crates/compiler/constrain/src/expr.rs --- a/crates/compiler/constrain/src/expr.rs +++ b/crates/compiler/constrain/src/expr.rs @@ -502,6 +502,7 @@ pub fn constrain_expr( let reason = Reason::FnArg { name: opt_symbol, ...
roc-lang__roc-5994
5,994
We now have the infrastructure in place to make this a relatively straightforward change! If you are interested and want some guidance, lmk smaller repro: ``` » A == A "" ── TYPE MISMATCH ─────────────────────────────────────────────────────────────── This 2nd argument to isEq has an unexpected type: 4│ ...
[ "1668" ]
0.0
roc-lang/roc
2023-11-16T16:06:08Z
diff --git a/crates/compiler/load/tests/test_reporting.rs b/crates/compiler/load/tests/test_reporting.rs --- a/crates/compiler/load/tests/test_reporting.rs +++ b/crates/compiler/load/tests/test_reporting.rs @@ -2447,7 +2447,7 @@ mod test_reporting { @r###" ── TYPE MISMATCH ────────────────────────────────...
Mismatch involving == reported as "isEq" ``` ── TYPE MISMATCH ─────────────────────────────────────────────────────────────── The 2nd argument to isEq is not what I expect: 416│ if kristy.rightHand == Ok (Jan (@JanId (@EntityId entityId))) then ...
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::boolean_tag", "test_reporting::int_frac", "test_reporting::int_literals_cannot_fit_in_same_type", "test_reporting::integer_out_of_range", "test_reporting::num_literals_cannot_fit_in_same_type", "test_reporting::num_too_general_wildcard", "test_reporting::num_too_general_named", "test_...
[ "test_reporting::ability_non_signature_expression", "test_reporting::ability_demand_value_has_args", "test_reporting::ability_first_demand_not_indented_enough", "test_reporting::ability_demands_not_indented_with_first", "test_reporting::ability_member_binds_parent_twice", "test_reporting::argument_without...
[]
[]
73909f2e201824d730aa088e7e96820f6e951f0b
diff --git a/martin/src/srv/tiles.rs b/martin/src/srv/tiles.rs --- a/martin/src/srv/tiles.rs +++ b/martin/src/srv/tiles.rs @@ -1,5 +1,6 @@ +use actix_http::header::Quality; use actix_http::ContentEncoding; -use actix_web::error::{ErrorBadRequest, ErrorNotFound}; +use actix_web::error::{ErrorBadRequest, ErrorNotAccepta...
maplibre__martin-1355
1,355
Hi @pcace Have you run the `select query_tile(10,544,339)` (without explain) directly? How many seconds it takes? Hi @sharkAndshark, I am in a similar situation. In my case running the query directly (without _EXPLAIN ANALYZE_) from postgres takes **~400ms**: ` select tiles(14,8176,6234)` <img width="413" al...
[ "1315" ]
0.2
maplibre/martin
2024-05-29T00:24:10Z
diff --git a/martin/src/srv/tiles.rs b/martin/src/srv/tiles.rs --- a/martin/src/srv/tiles.rs +++ b/martin/src/srv/tiles.rs @@ -270,6 +302,11 @@ mod tests { use super::*; use crate::srv::server::tests::TestSource; + #[actix_rt::test] + async fn test_deleteme() { + test_enc_preference(&["gzip", "...
very slow queries through martin Hi there, i am trying to find out why martin is so much slower then a direct query to the db. this: http://localhost:3000/query_tile/10/544/339 takes >13s to get the tile from the server via martin. the martin log looks like this: ``` [2024-04-24T07:43:12Z DEBUG marti...
09535cf917708d2d8e60099c516f6ff45f9efdd8
[ "srv::tiles::tests::test_deleteme", "srv::tiles::tests::test_enc_preference::case_3", "srv::tiles::tests::test_enc_preference::case_4", "srv::tiles::tests::test_enc_preference::case_1", "mbt_get_raster", "mbt_get_raw_mvt", "mbt_get_tilejson", "mbt_get_mvt_gzip", "mbt_get_tilejson_gzip", "mbt_get_m...
[ "args::pg::tests::test_extract_conn_strings", "args::pg::tests::test_merge_into_config", "args::pg::tests::test_extract_conn_strings_from_env", "args::pg::tests::test_merge_into_config2", "args::pg::tests::test_merge_into_config3", "args::root::tests::cli_bad_parsed_arguments", "args::root::tests::cli_n...
[ "function_source_schemas", "function_source_tilejson", "function_source_tile", "pg_get_composite_source_tile_minmax_zoom_ok", "pg_get_function_source_tile_ok", "pg_get_function_source_tile_minmax_zoom_ok", "pg_get_function_source_ok", "pg_get_function_source_query_params_ok", "pg_get_function_source...
[]
2391bc915b556c7dd4230dc1e61585220d2d2075
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -2,6 +2,7 @@ use std::borrow::Cow; use std::default::Default; use std::mem; + use tuikit::prelude::*; use vte::Perform; diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -69,60 +70,88 @@ impl Perform for ANS...
skim-rs__skim-198
198
Confirmed. Will fix when I got time.
[ "194" ]
0.6
skim-rs/skim
2019-07-14T00:11:14Z
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -301,4 +330,20 @@ mod tests { assert_eq!("ab", ansistring.into_inner()) } + + #[test] + fn test_multiple_attributes() { + let input = "\x1B[1;31mhi"; + let ansistring = ANSIParser::default().parse_ansi(inpu...
Color not working with `ag` When using silver searcher, coloring of file path and line numbers aren't working. Used the following command: ``` $ sk --ansi -i -c 'ag --color "{}"' ```
11c80768e0664878fc6fada1a31e7c9d0dfa8590
[ "ansi::tests::test_multiple_attributes" ]
[ "ansi::tests::test_normal_string", "ansi::tests::test_ansi_iterator", "field::test::test_parse_field_range", "field::test::test_parse_matching_fields", "field::test::test_parse_transform_fields", "field::test::test_get_string_by_field", "query::test::test_add_char", "query::test::test_backward_delete_...
[]
[]
817b75c09663bf57888bee1ae08bd820dc4d7414
diff --git a/shell/key-bindings.bash b/shell/key-bindings.bash --- a/shell/key-bindings.bash +++ b/shell/key-bindings.bash @@ -58,7 +58,7 @@ __skim_history__() ( shopt -u nocaseglob nocasematch line=$( HISTTIMEFORMAT= history | - SKIM_DEFAULT_OPTIONS="--height ${SKIM_TMUX_HEIGHT:-40%} $SKIM_DEFAULT_OPTION...
skim-rs__skim-105
105
[ "104" ]
0.5
skim-rs/skim
2018-11-10T01:56:39Z
diff --git a/src/field.rs b/src/field.rs --- a/src/field.rs +++ b/src/field.rs @@ -251,7 +244,7 @@ mod test { #[test] fn test_parse_transform_fields() { // delimiter is "," - let re = Regex::new(".*?,").unwrap(); + let re = Regex::new(",").unwrap(); assert_eq!( s...
zsh history binding malfunctional? Perhaps I am missing something, but when using the zsh history binding, it doesn't work as before. A couple things I've tried that don't work: `^r` doesn't rotate the mode and `prefix-exact-match`. The search syntax isn't completely broken, as at least the `exact-match` type works. ...
a33fe3635b080be7ccfcd7468a457db01fec05bb
[ "field::test::test_parse_matching_fields", "field::test::test_parse_transform_fields" ]
[ "field::test::test_parse_field_range", "field::test::test_get_string_by_field", "model::tests::test_reshape_string", "model::tests::test_accumulate_text_width", "query::test::test_add_char", "orderedvec::test::test_push_get", "query::test::test_backward_delete_char", "query::test::test_new_query", "...
[]
[]
1f723d31d965824fb50aea12a346bdceb032db7b
diff --git a/src/engine.rs b/src/engine.rs --- a/src/engine.rs +++ b/src/engine.rs @@ -10,15 +10,6 @@ lazy_static! { static ref RE_OR: Regex = Regex::new(r" +\| +").unwrap(); } -#[derive(Clone, Copy, Debug)] -enum Algorithm { - PrefixExact, - SuffixExact, - Exact, - InverseExact, - InverseSuffixE...
skim-rs__skim-264
264
[ "226" ]
0.7
skim-rs/skim
2020-02-03T12:33:27Z
diff --git a/src/engine.rs b/src/engine.rs --- a/src/engine.rs +++ b/src/engine.rs @@ -453,22 +520,47 @@ mod test { #[test] fn test_engine_factory() { - let x1 = EngineFactory::build( + let x = EngineFactory::build("'abc", MatcherMode::Fuzzy, FuzzyAlgorithm::default()); + assert_eq!(x.d...
Exact exact match When matching a short string, the exact match can get lost in results. For example, I use `skim` to select packages to install on Arch. If the name is extremely short (`lf`), the wanted result gets lost beneath results which contain the searched string. `^` nor `$` were able to narrow the search to w...
29239ba9276d5bd39bc84740374d66c1fe180981
[ "engine::test::test_engine_factory" ]
[ "ansi::tests::test_multiple_attributes", "ansi::tests::test_ansi_iterator", "ansi::tests::test_normal_string", "ansi::tests::test_reset", "field::test::test_parse_field_range", "field::test::test_get_string_by_field", "field::test::test_parse_matching_fields", "query::test::test_add_char", "field::t...
[]
[]
8a579837daaeb71938c635aa5352cbde9669d5f8
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -75,7 +75,7 @@ impl Perform for ANSIParser { match code[0] { 0 => attr = Attr::default(), 1 => attr.effect |= Effect::BOLD, - 2 => attr.effect |= !Effect::BOLD, + 2 ...
skim-rs__skim-563
563
Confirmed. Will fix when I got time.
[ "194", "495" ]
0.10
skim-rs/skim
2024-04-02T16:37:59Z
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -606,4 +606,21 @@ mod tests { assert_eq!(Some(('a', highlight)), it.next()); assert_eq!(None, it.next()); } + + #[test] + fn test_ansi_dim() { + // https://github.com/lotabout/skim/issues/495 + let i...
Color not working with `ag` When using silver searcher, coloring of file path and line numbers aren't working. Used the following command: ``` $ sk --ansi -i -c 'ag --color "{}"' ``` Dimmed colors not properly displayed Whenever an item in the list of entries passed to `skim` is _dimmed_, `skim` does not prop...
8a579837daaeb71938c635aa5352cbde9669d5f8
[ "ansi::tests::test_ansi_dim" ]
[ "ansi::tests::test_ansi_iterator", "ansi::tests::test_highlight_indices", "ansi::tests::test_merge_fragments", "ansi::tests::test_multi_byte_359", "ansi::tests::test_multi_bytes", "ansi::tests::test_multiple_attributes", "ansi::tests::test_normal_string", "ansi::tests::test_reset", "field::test::tes...
[]
[]
dade97c7247eb971d7e4dda8d8f648d8c143aa7f
diff --git a/src/util.rs b/src/util.rs --- a/src/util.rs +++ b/src/util.rs @@ -10,8 +10,18 @@ use crate::field::get_string_by_range; use crate::item::ItemWrapper; use crate::SkimItem; +lazy_static! { + static ref RE_ESCAPE: Regex = Regex::new(r"['\U{00}]").unwrap(); +} + pub fn escape_single_quote(text: &str) -...
skim-rs__skim-282
282
[ "278" ]
0.8
skim-rs/skim
2020-03-01T06:58:58Z
diff --git a/src/util.rs b/src/util.rs --- a/src/util.rs +++ b/src/util.rs @@ -413,4 +423,9 @@ mod tests { assert_eq!("'cmd_query'", inject_command("{cq}", default_context)); assert_eq!("'a,b,c' 'x,y,z'", inject_command("{+}", default_context)); } + + #[test] + fn test_escape_single_quote()...
Can't preview string with nul byte ```zsh > sk --preview-window=down --preview='echo {}' <<<$'abc\0cba' ``` Got an error: ![图片](https://user-images.githubusercontent.com/17017672/75601906-e8a9fe00-5afa-11ea-9fdb-9e6e7e45c9fe.png)
da913fb9de587a75158fe67b3756574dbd5e5efb
[ "util::tests::test_escape_single_quote" ]
[ "ansi::tests::test_ansi_iterator", "ansi::tests::test_multiple_attributes", "ansi::tests::test_reset", "ansi::tests::test_normal_string", "field::test::test_parse_field_range", "field::test::test_get_string_by_field", "field::test::test_parse_matching_fields", "field::test::test_parse_transform_fields...
[]
[]
bedadf1a37d50a56a2cf279b7289cbef5b3ca206
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -337,7 +337,7 @@ impl<'a> From<(&'a str, &'a [usize], Attr)> for AnsiString<'a> { pub struct AnsiStringIterator<'a> { fragments: &'a [(Attr, (u32, u32))], fragment_idx: usize, - chars_iter: std::str::CharIndices<'a>, + chars_...
skim-rs__skim-362
362
[ "359" ]
0.9
skim-rs/skim
2020-10-21T14:25:28Z
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -581,4 +581,16 @@ mod tests { vec![(ao, (1, 2)), (an, (2, 6)), (ao, (6, 7)), (ao, (9, 11))] ); } + + #[test] + fn test_multi_byte_359() { + // https://github.com/lotabout/skim/issues/359 + let hi...
Crashes with multi-byte characters input and --regex After update to 0.9.1, I'm having trouble with sk. ```shell-session $ sk --version 0.9.1 $ echo $SKIM_DEFAULT_OPTIONS $ echo $LANG ja_JP.UTF-8 $ od -tx1z <<< 'ああa' 0000000 e3 81 82 e3 81 82 61 0a >......a.< 0000010 $ echo 'ああa' ...
2ad92dfc3d0f9f6b172e1c6659a235ff13fe0f64
[ "ansi::tests::test_multi_byte_359" ]
[ "ansi::tests::test_ansi_iterator", "ansi::tests::test_highlight_indices", "ansi::tests::test_merge_fragments", "ansi::tests::test_multiple_attributes", "ansi::tests::test_normal_string", "ansi::tests::test_reset", "field::test::test_parse_field_range", "field::test::test_get_string_by_field", "field...
[]
[]
11c80768e0664878fc6fada1a31e7c9d0dfa8590
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -69,9 +69,14 @@ impl Perform for ANSIParser { return; } - let mut attr = self.last_attr; - let mut iter = params.into_iter(); + // \[[m => means reset + let mut attr = if params.is_empty() {...
skim-rs__skim-239
239
Should be fixed? Tested on MacOS + current master. ![image](https://user-images.githubusercontent.com/1527040/70593585-91417380-1c18-11ea-8e81-22106a753304.png)
[ "231", "220" ]
0.6
skim-rs/skim
2019-12-11T15:58:55Z
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -349,4 +355,11 @@ mod tests { assert_eq!(Some(('i', attr)), it.next()); assert_eq!(None, it.next()); } + + #[test] + fn test_reset() { + let input = "\x1B[35mA\x1B[mB"; + let ansistring = ANSIParser:...
ANSI colors are ignored in some cases I can reproduce it by: ```sh /usr/bin/ls -1 --color | sk --ansi ``` Or... ```sh e=$(echo -ne '\e') sk --ansi <<EOF $e[34mno $e[36mno$e[0m $e[36mno$e[0m ABC$e[34myes $e[36myes$e[39mABC ABC$e[36myes$e[0m ABC$e[36myes$e[0mABC EOF ``` bat highlight-line not working pro...
11c80768e0664878fc6fada1a31e7c9d0dfa8590
[ "ansi::tests::test_reset" ]
[ "ansi::tests::test_ansi_iterator", "ansi::tests::test_multiple_attributes", "ansi::tests::test_normal_string", "field::test::test_parse_field_range", "field::test::test_get_string_by_field", "field::test::test_parse_matching_fields", "field::test::test_parse_transform_fields", "query::test::test_add_c...
[]
[]
65aad287f5a2e96fd1bdec63a8cd4bf301112d2e
diff --git a/src/input.rs b/src/input.rs --- a/src/input.rs +++ b/src/input.rs @@ -82,7 +82,9 @@ impl Input { // key_action is comma separated: 'ctrl-j:accept,ctrl-k:kill-line' pub fn parse_keymap(&mut self, key_action: &str) { + debug!("got key_action: {:?}", key_action); for (key, action_c...
skim-rs__skim-199
199
I tried escaping with `\` with no success
[ "196" ]
0.6
skim-rs/skim
2019-07-14T00:59:12Z
diff --git a/src/input.rs b/src/input.rs --- a/src/input.rs +++ b/src/input.rs @@ -224,6 +236,14 @@ mod test { ("ctrl-y", vec![("execute-silent", Some("echo {} | pbcopy".to_string()))]), key_action[1] ); + + // #196 + let key_action_str = "enter:execute($EDITOR +{2} {1})...
Passing an explicit + to execute() I'm trying to pass line number and filename to vim with: `sk --ansi -i -c 'rg --color=always --line-number "{}"' --preview 'preview.sh {}' -d':' --bind 'enter:execute($EDITOR +{2} {1})'` but the `+` gets swallowed by the skim parser instead of getting passed the command.
11c80768e0664878fc6fada1a31e7c9d0dfa8590
[ "input::test::execute_should_be_parsed_correctly" ]
[ "ansi::tests::test_ansi_iterator", "ansi::tests::test_multiple_attributes", "ansi::tests::test_normal_string", "field::test::test_parse_field_range", "field::test::test_get_string_by_field", "field::test::test_parse_matching_fields", "field::test::test_parse_transform_fields", "query::test::test_add_c...
[]
[]
42b8ef23ee00ffdfdd01ce774e96033fea90c2f1
diff --git a/quadratic-core/src/formulas/functions/lookup.rs b/quadratic-core/src/formulas/functions/lookup.rs --- a/quadratic-core/src/formulas/functions/lookup.rs +++ b/quadratic-core/src/formulas/functions/lookup.rs @@ -461,21 +461,24 @@ fn lookup<V: ToString + AsRef<CellValue>>( LookupMatchMode::Exact => s...
quadratichq__quadratic-1939
1,939
[ "1916" ]
0.5
quadratichq/quadratic
2024-10-01T20:58:11Z
diff --git a/quadratic-core/src/formulas/functions/lookup.rs b/quadratic-core/src/formulas/functions/lookup.rs --- a/quadratic-core/src/formulas/functions/lookup.rs +++ b/quadratic-core/src/formulas/functions/lookup.rs @@ -1297,6 +1300,15 @@ mod tests { ); assert_eq!("1", eval_to_string(&g, &make_matc...
Match formula not working Not sure cause, but replicating in other sheets returns results correctly. See sheet in Slack for recreation.
ba07e0c13859c2f461ee2d528c59e58773df4f6c
[ "formulas::functions::lookup::tests::test_match" ]
[ "color::tests::new", "color::tests::test_from_str", "color::tests::test_size", "color::tests::test_from_css_str", "controller::active_transactions::pending_transaction::tests::is_user", "controller::active_transactions::pending_transaction::tests::test_add_html_cell", "controller::active_transactions::p...
[]
[]
13b8f4201b41e1566bba1ec0e13c7c90d3da757a
diff --git a/quadratic-client/src/dashboard/components/DashboardSidebar.tsx b/quadratic-client/src/dashboard/components/DashboardSidebar.tsx --- a/quadratic-client/src/dashboard/components/DashboardSidebar.tsx +++ b/quadratic-client/src/dashboard/components/DashboardSidebar.tsx @@ -1,4 +1,3 @@ -import { colors } from '...
quadratichq__quadratic-1923
1,923
[ "1924" ]
0.5
quadratichq/quadratic
2024-09-26T16:10:30Z
diff --git a/quadratic-core/src/date_time.rs b/quadratic-core/src/date_time.rs --- a/quadratic-core/src/date_time.rs +++ b/quadratic-core/src/date_time.rs @@ -319,8 +319,7 @@ mod tests { #[test] #[parallel] fn test_parse_date() { - let date = "12/23/2024".to_string(); - let parsed_date = pa...
Spill error auto fix Being worked on in #1725
ba07e0c13859c2f461ee2d528c59e58773df4f6c
[ "date_time::tests::test_parse_date_time" ]
[ "color::tests::new", "color::tests::test_size", "color::tests::test_from_str", "controller::active_transactions::pending_transaction::tests::is_user", "color::tests::test_from_css_str", "controller::active_transactions::pending_transaction::tests::test_add_code_cell", "controller::active_transactions::p...
[]
[]
8dc49a8a4dd2108ba11291b68e1abb24d9fe42a7
diff --git a/quadratic-client/src/app/web-workers/renderWebWorker/worker/cellsLabel/convertNumber.ts b/quadratic-client/src/app/web-workers/renderWebWorker/worker/cellsLabel/convertNumber.ts --- a/quadratic-client/src/app/web-workers/renderWebWorker/worker/cellsLabel/convertNumber.ts +++ b/quadratic-client/src/app/web-...
quadratichq__quadratic-1883
1,883
[ "1881" ]
0.5
quadratichq/quadratic
2024-09-18T21:06:45Z
diff --git a/quadratic-client/src/app/web-workers/renderWebWorker/worker/cellsLabel/convertNumber.test.ts b/quadratic-client/src/app/web-workers/renderWebWorker/worker/cellsLabel/convertNumber.test.ts --- a/quadratic-client/src/app/web-workers/renderWebWorker/worker/cellsLabel/convertNumber.test.ts +++ b/quadratic-clie...
bug: decimal precision with percentages 1. Add =1/3 in a cell 2. Format as a percent truncate to fewer decimals so it fits ![CleanShot 2024-09-18 at 10 50 54@2x](https://github.com/user-attachments/assets/1830aa59-5929-4786-88eb-e880919dcd01)
ba07e0c13859c2f461ee2d528c59e58773df4f6c
[ "grid::sheet::test::test_current_decimal_places_value" ]
[ "color::tests::test_size", "color::tests::test_from_str", "color::tests::test_from_css_str", "controller::active_transactions::pending_transaction::tests::is_user", "controller::active_transactions::pending_transaction::tests::test_to_transaction", "controller::active_transactions::unsaved_transactions::t...
[]
[]
ccca1fa5b9c65bceecffdcae588c3f6afce3cb76
diff --git a/quadratic-core/src/date_time.rs b/quadratic-core/src/date_time.rs --- a/quadratic-core/src/date_time.rs +++ b/quadratic-core/src/date_time.rs @@ -225,7 +225,7 @@ pub fn parse_date(value: &str) -> Option<NaiveDate> { "%d.%m.%Y", "%Y %m %d", "%m %d %Y", - "%d %m %Y", + ...
quadratichq__quadratic-2012
2,012
[ "2011" ]
0.5
quadratichq/quadratic
2024-11-01T11:57:03Z
diff --git a/quadratic-core/src/date_time.rs b/quadratic-core/src/date_time.rs --- a/quadratic-core/src/date_time.rs +++ b/quadratic-core/src/date_time.rs @@ -319,8 +319,7 @@ mod tests { #[test] #[parallel] fn test_parse_date() { - let date = "12/23/2024".to_string(); - let parsed_date = pa...
Quadratic parses the dates in this CSV incorrectly [StnData.csv](https://github.com/user-attachments/files/17594099/StnData.csv) Quadratic ![CleanShot 2024-10-31 at 17 01 48@2x](https://github.com/user-attachments/assets/cfe11333-12c0-4b3d-8d82-ebda8b90fd61) Numbers Mac ![CleanShot 2024-10-31 at 17 02 30@2x](ht...
ba07e0c13859c2f461ee2d528c59e58773df4f6c
[ "date_time::tests::test_parse_date_time" ]
[ "color::tests::new", "color::tests::test_size", "color::tests::test_from_str", "color::tests::test_from_css_str", "controller::active_transactions::pending_transaction::tests::is_user", "controller::active_transactions::pending_transaction::tests::test_add_code_cell", "controller::active_transactions::p...
[]
[]
9c64d1fbd17e99bbb8db1479492d88ba7578acc9
diff --git a/crates/bindings-macro/src/lib.rs b/crates/bindings-macro/src/lib.rs --- a/crates/bindings-macro/src/lib.rs +++ b/crates/bindings-macro/src/lib.rs @@ -45,6 +45,7 @@ mod sym { symbol!(public); symbol!(sats); symbol!(scheduled); + symbol!(scheduled_at); symbol!(unique); symbol!(upd...
clockworklabs__SpacetimeDB-1894
1,894
[ "1818" ]
1.78
clockworklabs/SpacetimeDB
2024-10-23T18:23:38Z
diff --git a/crates/bindings/tests/ui/reducers.rs b/crates/bindings/tests/ui/reducers.rs --- a/crates/bindings/tests/ui/reducers.rs +++ b/crates/bindings/tests/ui/reducers.rs @@ -25,8 +25,22 @@ fn missing_ctx(_a: u8) {} #[spacetimedb::reducer] fn ctx_by_val(_ctx: ReducerContext, _a: u8) {} +#[spacetimedb::table(nam...
`#[spacetimedb::table(scheduled())]` should probably not autogen the scheduled_id/at fields for you - should just require they already be present UX story: > Someone new comes to the codebase and wants to insert a row into the table. the compiler complains "missing fields scheduled_id and schedule_at" and so they go t...
8075567da42408ecf53146fb3f72832e41d8a956
[ "ui" ]
[ "deptree_snapshot", "tests/ui/tables.rs", "crates/bindings/src/rng.rs - rng::ReducerContext::rng (line 30)" ]
[]
[]
058c0db72f43fbe1574d0db654560e693755cd7e
diff --git /dev/null b/.changes/use_https_windows-and-android-config.md new file mode 100644 --- /dev/null +++ b/.changes/use_https_windows-and-android-config.md @@ -0,0 +1,6 @@ +--- +"tauri": "minor:feat" +"tauri-utils": "minor:feat" +--- + +Add `app > windows > useHttpsScheme` config option to choose whether the cust...
tauri-apps__tauri-11477
11,477
[ "11252" ]
1.77
tauri-apps/tauri
2024-10-24T08:00:11Z
diff --git a/crates/tauri-cli/src/migrate/migrations/v1/config.rs b/crates/tauri-cli/src/migrate/migrations/v1/config.rs --- a/crates/tauri-cli/src/migrate/migrations/v1/config.rs +++ b/crates/tauri-cli/src/migrate/migrations/v1/config.rs @@ -802,7 +824,8 @@ mod test { "pattern": { "use": "brownfield" }, ...
[bug] [v2] IndexedDB path changed after upgrading to tauri 2 ### Describe the bug After upgrading from tauri 1 to tauri 2, the IndexedDB directory changed from `https_tauri.localhost_0.indexeddb.leveldb` to `http_tauri.localhost_0.indexeddb.leveldb`. Since my app stores all data in IndexedDB, this will cause "data ...
17bcec8abe827c8a9eaa9bebf01bf5da87e92ed2
[ "migrate::migrations::v1::config::test::migrate_dangerous_use_http_scheme", "migrate::migrations::v1::config::test::migrate_full" ]
[ "interface::rust::tests::parse_cargo_option", "interface::rust::tests::parse_profile_from_opts", "interface::rust::manifest::tests::inject_features_string", "interface::rust::manifest::tests::inject_features_table", "interface::rust::manifest::tests::inject_features_inline_table", "migrate::migrations::v1...
[]
[]
7bfd47eb8130f02f2a8f695c255df2f5302636b4
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ All notable changes to eww will be listed here, starting at changes since versio ### Fixes - The `shell-completions` subcommand is now run before anything is set up - Fix nix flake +- Fix `jq` (By: w-lfchen) ## [0.5.0] ...
elkowar__eww-1044
1,044
For an easy bisect it would be nice to know which version/commit you were previously on, would you mind adding that? Yeah, sorry about the bad bug report. I'm not sure exactly which version I was on before upgrading since it was built from git, but it was 0.4.0 something. I've now tested various revisions, and 4...
[ "1039" ]
0.1
elkowar/eww
2024-03-02T22:40:51Z
diff --git a/crates/simplexpr/src/eval.rs b/crates/simplexpr/src/eval.rs --- a/crates/simplexpr/src/eval.rs +++ b/crates/simplexpr/src/eval.rs @@ -544,5 +545,6 @@ mod tests { lazy_evaluation_and(r#"false && "null".test"#) => Ok(DynVal::from(false)), lazy_evaluation_or(r#"true || "null".test"#) => Ok(D...
[BUG] jq broken in 5.0.0 ### Checklist before submitting an issue - [X] I have searched through the existing [closed and open issues](https://github.com/elkowar/eww/issues?q=is%3Aissue) for eww and made sure this is not a duplicate - [X] I have specifically verified that this bug is not a common [user error](https://g...
8661abf2bf07f5a809fc995233d93810cc1ac871
[ "eval::tests::jq_basic_index" ]
[ "eval::tests::string_to_string", "eval::tests::lazy_evaluation_or", "eval::tests::lazy_evaluation_elvis", "eval::tests::safe_access_index_to_non_indexable", "eval::tests::safe_access_index_to_missing", "eval::tests::lazy_evaluation_and", "eval::tests::normal_access_to_existing", "eval::tests::safe_acc...
[]
[]
8801fa36a057b0c1d2d57585673496f0bc4240d2
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ All notable changes to eww will be listed here, starting at changes since versio ## Unreleased +### BREAKING CHANGES +- [#1176](https://github.com/elkowar/eww/pull/1176) changed safe access (`?.`) behavior: + Attemptin...
elkowar__eww-1176
1,176
[ "1209" ]
0.1
elkowar/eww
2024-08-27T15:32:03Z
diff --git a/crates/simplexpr/src/eval.rs b/crates/simplexpr/src/eval.rs --- a/crates/simplexpr/src/eval.rs +++ b/crates/simplexpr/src/eval.rs @@ -564,6 +565,8 @@ mod tests { string_to_string(r#""Hello""#) => Ok(DynVal::from("Hello".to_string())), safe_access_to_existing(r#"{ "a": { "b": 2 } }.a?.b"#)...
[BUG] Incorrect handling of an empty string by the safe access operator ### Checklist before submitting an issue - [X] I have searched through the existing [closed and open issues](https://github.com/elkowar/eww/issues?q=is%3Aissue) for eww and made sure this is not a duplicate - [X] I have specifically verified that ...
8661abf2bf07f5a809fc995233d93810cc1ac871
[ "eval::tests::safe_access_to_empty", "eval::tests::safe_access_to_empty_json_string" ]
[ "eval::tests::string_to_string", "eval::tests::safe_access_index_to_missing", "eval::tests::lazy_evaluation_elvis", "eval::tests::lazy_evaluation_and", "eval::tests::lazy_evaluation_or", "eval::tests::safe_access_index_to_non_indexable", "eval::tests::safe_access_index_to_existing", "eval::tests::safe...
[]
[]
78ec3a4d75075c8dff0cb543cd5fc797b7f15132
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,8 @@ +# 2.6.1 + +## Fixed + * gzip: examine Content-Length header before removing (#578) + # 2.6.0 ## Added diff --git a/Cargo.toml b/Cargo.toml --- a/Cargo.toml +++ b/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "ureq" -vers...
algesten__ureq-578
578
Please add `env_logger` to your Cargo.toml, add `env_logger::int()` to your `fn main`, and run your program with `RUST_LOG=debug cargo run`, then paste the full debug output here. Also, please post a full copy of your program and any parameters you are invoking it with (like URLs or hostnames). I'm running into the sam...
[ "575" ]
2.6
algesten/ureq
2023-01-03T02:49:21Z
diff --git a/src/response.rs b/src/response.rs --- a/src/response.rs +++ b/src/response.rs @@ -1183,4 +1184,37 @@ mod tests { .unwrap(); assert_eq!(agent2.state.pool.len(), 1); } + + #[test] + #[cfg(feature = "gzip")] + fn gzip_content_length() { + use std::io::Cursor; + le...
Reading a gzipped response hangs forever upon reaching the end of the response Hello, i use the actual git version (that solves a problem with the cookiestore for me) and rust compiles without an error but the code hang on every function call like: ``` let test = httpreq.into_string().unwrap(); or let json: s...
905bf8f0b2d22f95b2d61884591197f24cea4218
[ "response::tests::gzip_content_length", "test::agent_test::connection_reuse_with_408" ]
[ "chunked::decoder::test::test_read_chunk_size", "chunked::decoder::test::invalid_input2", "header::tests::test_valid_value", "header::tests::test_iso8859_utf8_mixup", "error::tests::ensure_error_size", "pool::tests::pool_per_host_connections_limit", "pool::tests::poolkey_new", "header::tests::test_val...
[ "test::range::read_range_rustls", "tests::connect_http_google", "tests::connect_https_google_rustls", "test::range::read_range_native_tls", "tests::connect_https_google_native_tls" ]
[ "test::timeout::read_timeout_during_body" ]
641eb3df10decef45df1fcad9d985fdec484e429
diff --git a/src/proxy.rs b/src/proxy.rs --- a/src/proxy.rs +++ b/src/proxy.rs @@ -79,11 +79,13 @@ impl Proxy { /// * `john:smith@socks.google.com:8000` /// * `localhost` pub fn new<S: AsRef<str>>(proxy: S) -> Result<Self, Error> { - let mut proxy_parts = proxy - .as_ref() - ...
algesten__ureq-408
408
[ "402" ]
2.1
algesten/ureq
2021-08-12T10:49:17Z
diff --git a/src/proxy.rs b/src/proxy.rs --- a/src/proxy.rs +++ b/src/proxy.rs @@ -196,6 +198,16 @@ mod tests { assert_eq!(proxy.proto, Proto::HTTPConnect); } + #[test] + fn parse_proxy_http_user_pass_server_port_trailing_slash() { + let proxy = Proxy::new("http://user:p@ssw0rd@localhost:99...
Parsing proxy with trailing slash results in wrong port When proxy url is set to `http://127.0.0.1:3128/` (with trailing slash), port is resolved to `8080`: ```plain with https_proxy (http://127.0.0.1:3128/): AgentBuilder { config: AgentConfig { proxy: Some( Proxy { serve...
30f0ec01e74cc6dc2dd342616c16a1d735f0170d
[ "proxy::tests::parse_proxy_http_user_pass_server_port_trailing_slash", "test::timeout::read_timeout_during_body" ]
[ "proxy::tests::parse_proxy_socks4_user_pass_server_port", "proxy::tests::parse_proxy_socks4a_user_pass_server_port", "proxy::tests::parse_proxy_fakeproto", "header::tests::test_parse_invalid_name", "pool::tests::poolkey_new", "pool::tests::pool_per_host_connections_limit", "pool::tests::pool_connections...
[ "test::timeout::overall_timeout_reading_json", "test::range::read_range", "tests::connect_https_google", "tests::connect_http_google", "tls_client_certificate" ]
[]
c833acfe5cd8e6f6bb01bde4ca71681873e8bdf9
diff --git a/src/response.rs b/src/response.rs --- a/src/response.rs +++ b/src/response.rs @@ -469,7 +469,12 @@ fn parse_status_line(line: &str) -> Result<(ResponseStatusIndex, u16), Error> { } // https://tools.ietf.org/html/rfc7230#section-3.1.2 // status-line = HTTP-version SP status-code SP reaso...
algesten__ureq-327
327
Thanks for the report. We recently added some stricter parsing of the status line. Per spec, [reason-phrase can be empty](https://tools.ietf.org/html/rfc7230#section-3.1.2), but the space after the status code is mandatory. hack.pl omits the space. Still, perhaps this is a place to be a little lenient and allow an omit...
[ "316" ]
2.0
algesten/ureq
2021-02-21T10:23:31Z
diff --git a/src/response.rs b/src/response.rs --- a/src/response.rs +++ b/src/response.rs @@ -747,6 +752,13 @@ mod tests { assert_eq!(err.kind(), BadStatus); } + #[test] + fn parse_header_without_reason() { + let s = "HTTP/1.1 302\r\n\r\n".to_string(); + let resp = s.parse::<Respons...
"Bad Status: Wrong number of tokens in status line" error on some websites On some websites, e.g. http://hack.pl, ureq fails with the following error: > Bad Status: Wrong number of tokens in status line However, curl and Firefox work fine. There's 296 such websites in the top million (I'm using [Tranco list g...
9ec4e7192aa80d38d968e5989742ba10fbbbe575
[ "response::tests::parse_header_without_reason" ]
[ "agent::tests::agent_implements_send_and_sync", "proxy::tests::parse_proxy_socks_user_pass_server_port", "proxy::tests::parse_proxy_socks5_user_pass_server_port", "header::test_valid_name", "body::test_copy_chunked", "error::error_is_send_and_sync", "proxy::tests::parse_proxy_server", "pool::poolkey_n...
[ "test::timeout::overall_timeout_reading_json", "test::range::read_range", "tests::connect_http_google", "tests::connect_https_google", "tls_client_certificate" ]
[ "test::timeout::read_timeout_during_body" ]
b246f0a9d2e6150b29b5504924edc090d2bf9168
diff --git a/src/response.rs b/src/response.rs --- a/src/response.rs +++ b/src/response.rs @@ -537,14 +537,16 @@ fn read_next_line(reader: &mut impl BufRead) -> io::Result<String> { )); } - if !s.ends_with("\r\n") { + if !s.ends_with("\n") { return Err(io::Error::new( io::Err...
algesten__ureq-324
324
This is per spec: https://tools.ietf.org/html/rfc7230#section-3.1.2 > The first line of a response message is the status-line, consisting > of the protocol version, a space (SP), the status code, another > space, a possibly empty textual phrase describing the status code, > and ending with CRLF. > >...
[ "321" ]
2.0
algesten/ureq
2021-02-15T20:59:07Z
diff --git a/src/response.rs b/src/response.rs --- a/src/response.rs +++ b/src/response.rs @@ -644,6 +646,16 @@ mod tests { assert_eq!("application/json", resp.content_type()); } + #[test] + fn content_type_without_cr() { + let s = "HTTP/1.1 200 OK\r\n\ + Content-Type: appli...
"Header field didn't end with \r" error on some websites On some websites, e.g. etihad.com, ureq fails with the following error: > Header field didn't end with \r Firefox and curl work fine. There's 295 such websites in the top million (I'm using [Tranco list generated on the 3rd of February](https://tranco-li...
9ec4e7192aa80d38d968e5989742ba10fbbbe575
[ "response::tests::content_type_without_cr", "test::timeout::read_timeout_during_body" ]
[ "proxy::tests::parse_proxy_http_user_pass_server_port", "request::request_implements_send_and_sync", "proxy::tests::parse_proxy_server", "response::short_read", "response::tests::charset", "header::name_and_value", "error::error_is_send_and_sync", "proxy::tests::parse_proxy_socks_user_pass_server_port...
[ "test::timeout::overall_timeout_reading_json", "test::range::read_range", "tests::connect_http_google", "tests::connect_https_google", "tls_client_certificate" ]
[]
96f6ed15d7d0d2d6e2fefe6b8ffc98b9efb20e71
diff --git a/src/error.rs b/src/error.rs --- a/src/error.rs +++ b/src/error.rs @@ -83,7 +83,7 @@ impl Error { Some(e) => e, None => return false, }; - let ioe: &Box<io::Error> = match source.downcast_ref() { + let ioe: &io::Error = match source.downcast_ref() { ...
algesten__ureq-238
238
[ "237" ]
1.5
algesten/ureq
2020-11-22T05:24:05Z
diff --git a/src/error.rs b/src/error.rs --- a/src/error.rs +++ b/src/error.rs @@ -183,6 +183,17 @@ fn io_error() { assert_eq!(err.to_string(), "http://example.com/: Io: oops: too slow"); } +#[test] +fn connection_closed() { + let ioe = io::Error::new(io::ErrorKind::ConnectionReset, "connection reset"); + ...
Intermittent test error since #234 landed I'm getting this test error approximately 1 out of 2 test runs. I checked out the prior commit and ran the tests a bunch of time without reproducing, so it's probably something in #234. I'll investigate. ``` ---- test::agent_test::dirty_streams_not_returned stdout ---- Err...
62cf25fd3575be0652a6766670e6dab2739d6c55
[ "error::connection_closed", "test::agent_test::dirty_streams_not_returned" ]
[ "response::tests::charset", "body::test_copy_chunked", "header::test_parse_invalid_name", "agent::tests::agent_implements_send_and_sync", "header::test_valid_name", "proxy::tests::parse_proxy_http_user_pass_server_port", "proxy::tests::parse_proxy_fakeproto", "header::test_valid_value", "proxy::test...
[ "test::timeout::overall_timeout_reading_json", "test::range::read_range", "tests::connect_http_google", "tests::connect_https_google", "tls_client_certificate" ]
[ "test::timeout::read_timeout_during_body" ]
652500f5a84461f793a05c4c1039cf7b279294b5
diff --git a/src/stream.rs b/src/stream.rs --- a/src/stream.rs +++ b/src/stream.rs @@ -147,7 +147,8 @@ pub(crate) fn connect_https(unit: &Unit) -> Result<Stream, Error> { let hostname = unit.url.host_str().unwrap(); let port = unit.url.port().unwrap_or(443); - let sni = webpki::DNSNameRef::try_from_ascii...
algesten__ureq-50
50
Thanks! I'll follow the bug in ring and update when I can. I'm not sure if I made it clear, so just in case: there are two distinct panics, one in ring (assertion failure) and another one in ureq (unwrap). Ah. Yes. The unwrap in ureq we should fix!
[ "24" ]
0.12
algesten/ureq
2020-04-12T02:04:22Z
diff --git a/src/lib.rs b/src/lib.rs --- a/src/lib.rs +++ b/src/lib.rs @@ -202,4 +202,12 @@ mod tests { ); assert_eq!("text/html", resp.content_type()); } + + #[test] + #[cfg(feature = "tls")] + fn connect_https_invalid_name() { + let resp = get("https://example.com{REQUEST_URI}/"...
Panic in ureq::stream::connect_https on some websites I've tested `ureq` by downloading homepages of the [top million websites](https://blog.majestic.com/development/majestic-million-csv-daily/) with it. I've found [a panic](https://github.com/briansmith/ring/issues/929) in `ring`, and 13 out of 1,000,000 websites trig...
652500f5a84461f793a05c4c1039cf7b279294b5
[ "tests::connect_https_invalid_name" ]
[ "agent::tests::agent_implements_send", "test::body_send::str_with_encoding", "test::body_send::user_set_content_length_on_str", "agent::tests::request_implements_send", "test::query_string::query_in_path_and_req", "test::redirect::redirect_get", "test::redirect::redirect_head", "test::redirect::redire...
[ "tests::connect_http_google", "tests::connect_https_google", "test::range::agent_pool", "test::range::read_range", "src/response.rs - response::Response::into_string (line 336)", "src/agent.rs - agent::Agent::cookie (line 173)", "src/response.rs - response::Response::content_type (line 217)", "src/res...
[]
89f237be86163f36fdfda87fe3d1ef0a83139f1c
diff --git a/linkerd/app/outbound/src/http/concrete.rs b/linkerd/app/outbound/src/http/concrete.rs --- a/linkerd/app/outbound/src/http/concrete.rs +++ b/linkerd/app/outbound/src/http/concrete.rs @@ -408,13 +408,22 @@ where match self.param() { http::Version::H2 => client::Settings::H2, ...
linkerd__linkerd2-proxy-2237
2,237
> For instance, there's a lot of test infra change in this PR that i haven't really parsed. We can remove the integration test changes if we don't care about having integration tests for this case; I wrote that initially while trying to reproduce the issue. If it's more desirable to have a smaller branch, I can back...
[ "2209" ]
0.1
linkerd/linkerd2-proxy
2023-02-15T22:54:58Z
diff --git a/linkerd/app/integration/src/tests.rs b/linkerd/app/integration/src/tests.rs --- a/linkerd/app/integration/src/tests.rs +++ b/linkerd/app/integration/src/tests.rs @@ -1,4 +1,5 @@ mod client_policy; +mod direct; mod discovery; mod identity; mod orig_proto; diff --git a/linkerd/app/integration/src/tests/d...
handle `Opaque` protocol hints on endpoints Currently, when the outbound proxy makes a direct connection prefixed with a `TransportHeader` in order to send HTTP traffic, it will always send a `SessionProtocol` hint with the HTTP version as part of the header. This instructs the inbound proxy to use that protocol, ev...
89f237be86163f36fdfda87fe3d1ef0a83139f1c
[ "tests::telemetry::transport::outbound_tcp_open_connections", "tests::telemetry::tcp_errors::inbound_multi" ]
[ "test_assert_eventually - should panic", "tests::client_policy::empty_http2_route", "tests::discovery::http1::absolute_uris::outbound_reconnects_if_controller_stream_ends", "tests::discovery::http1::absolute_uris::outbound_falls_back_to_orig_dst_after_invalid_argument", "tests::client_policy::default_http1_...
[ "tests::telemetry::tcp_errors::inbound_direct_multi" ]
[ "tests::telemetry::log_stream::multi_filter", "tests::telemetry::tcp_errors::inbound_invalid_ip", "tests::transparency::tcp_server_first" ]
38172469151f21bae1ec868c548f2ca537146dad
diff --git a/common/src/format.rs b/common/src/format.rs --- a/common/src/format.rs +++ b/common/src/format.rs @@ -335,10 +335,11 @@ impl FormatSpec { let offset = (disp_digit_cnt % (inter + 1) == 0) as i32; let disp_digit_cnt = disp_digit_cnt + offset; let pad_cnt = disp_digit_cnt - magnitud...
RustPython__RustPython-4711
4,711
not reproducible not reproducible
[ "4588", "4593", "4588" ]
0.2
RustPython/RustPython
2023-03-18T04:44:26Z
diff --git a/Lib/test/test_types.py b/Lib/test/test_types.py --- a/Lib/test/test_types.py +++ b/Lib/test/test_types.py @@ -403,7 +403,6 @@ def test_float__format__locale(self): self.assertEqual(locale.format_string('%g', x, grouping=True), format(x, 'n')) self.assertEqual(locale.format_string(...
Format panic in test_int__format__locale ## Issues In `Lib/test/test_types.py``test_int__format__locale`, if you change from `format(x, 'n')` to `format(x, ',')` and run the test, RustPython will panic! It doesn't crash in CPython! See #4593 for test case broken test case of FormatSpec::format_int test case of ...
7e66db0d43b6fd93bc114773ac8e896b7eda62c9
[ "format::tests::test_format_int_sep" ]
[ "cformat::tests::test_fill_and_align", "cformat::tests::test_format_parse", "cformat::tests::test_format_parse_key_fail", "cformat::tests::test_format_parse_type_fail", "cformat::tests::test_incomplete_format_fail", "cformat::tests::test_parse_and_format_float", "cformat::tests::test_parse_and_format_nu...
[]
[]
c3d24feebef4c605535a6661ddfeaa18b9bde60c
diff --git a/src/address.rs b/src/address.rs --- a/src/address.rs +++ b/src/address.rs @@ -1,4 +1,5 @@ //! Provides functions to parse input IP addresses, CIDRs or files. +use std::collections::BTreeSet; use std::fs::{self, File}; use std::io::{prelude::*, BufReader}; use std::net::{IpAddr, SocketAddr, ToSocketAddr...
RustScan__RustScan-660
660
I suspect that when we got 79.98.104.0/21 79.98.104.0/24 dublication comes from this
[ "651" ]
2.3
RustScan/RustScan
2024-09-18T16:46:28Z
diff --git a/src/address.rs b/src/address.rs --- a/src/address.rs +++ b/src/address.rs @@ -256,6 +262,16 @@ mod tests { assert_eq!(ips.len(), 0); } + #[test] + fn parse_duplicate_cidrs() { + let mut opts = Opts::default(); + opts.addresses = vec!["79.98.104.0/21".to_owned(), "79.98.1...
Dublication of ports in output rustscan.exe -a tmp/asns_prefixes_specific.txt -p 80,443,8443,8080,8006 --scripts none <img width="365" alt="Screenshot_2" src="https://github.com/user-attachments/assets/ef874b42-60b5-4260-bc67-dd7abe6dbfce"> tmp/asns_prefixes_specific.txt `185.52.205.0/24 79.98.109.0/24 185.239....
c3d24feebef4c605535a6661ddfeaa18b9bde60c
[ "address::tests::parse_duplicate_cidrs" ]
[ "address::tests::parse_correct_addresses", "address::tests::parse_naughty_host_file", "address::tests::parse_empty_hosts_file", "input::tests::opts_no_merge_when_config_is_ignored", "input::tests::opts_merge_required_arguments", "input::tests::opts_merge_optional_arguments", "input::tests::parse_trailin...
[]
[]
7dd9352baee3b467b4c55c95edf4de8494ca8a40
diff --git a/src/port_strategy/mod.rs b/src/port_strategy/mod.rs --- a/src/port_strategy/mod.rs +++ b/src/port_strategy/mod.rs @@ -67,7 +67,7 @@ pub struct SerialRange { impl RangeOrder for SerialRange { fn generate(&self) -> Vec<u16> { - (self.start..self.end).collect() + (self.start..=self.end)....
RustScan__RustScan-518
518
[ "515" ]
2.1
RustScan/RustScan
2023-05-25T20:18:08Z
diff --git a/src/port_strategy/mod.rs b/src/port_strategy/mod.rs --- a/src/port_strategy/mod.rs +++ b/src/port_strategy/mod.rs @@ -104,7 +104,7 @@ mod tests { let range = PortRange { start: 1, end: 100 }; let strategy = PortStrategy::pick(&Some(range), None, ScanOrder::Serial); let result = s...
--range <start-end>, only contain start, But not end port In nmap run：**nmap 192.168.1.2 -p 1-65535** ,nmap scan port range is 1-65535. But in RustScan run：**rustscan 192.168.1.2 --range 1-65535** (or directly execute **rustscan 192.168.1.2**) by wireshark verification, the scan range is 1-65534, does not contain 6553...
2ab7191a659e4e431098d530b6376c753b8616dd
[ "port_strategy::tests::serial_strategy_with_range", "port_strategy::tests::random_strategy_with_range", "port_strategy::range_iterator::tests::range_iterator_iterates_through_the_entire_range" ]
[ "input::tests::opts_merge_optional_arguments", "input::tests::opts_merge_required_arguments", "input::tests::opts_no_merge_when_config_is_ignored", "port_strategy::tests::serial_strategy_with_ports", "port_strategy::tests::random_strategy_with_ports", "scanner::socket_iterator::tests::goes_through_every_i...
[]
[]
d67c77b6f73ccab63d544adffe9cf3d859e71fa4
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Fixed + +- Fixed regression where configuration present in current working directory not used when formatting from st...
JohnnyMorganz__StyLua-931
931
Looks like a mistake in https://github.com/JohnnyMorganz/StyLua/blob/1daf4c18fb6baf687cc41082f1cc6905ced226a4/src/cli/config.rs#L96, we forget to check the current directory if stdin file path was not provided. Thanks for reporting! As a work around, you can use `--stdin-filepath` to specify the file path for the file...
[ "928" ]
2.0
JohnnyMorganz/StyLua
2024-11-30T12:21:18Z
diff --git a/src/cli/main.rs b/src/cli/main.rs --- a/src/cli/main.rs +++ b/src/cli/main.rs @@ -810,6 +810,24 @@ mod tests { cwd.close().unwrap(); } + #[test] + fn test_cwd_configuration_respected_when_formatting_from_stdin() { + let cwd = construct_tree!({ + "stylua.toml": "quote...
after new release stdin does not repsect .stylua.toml by default unless must set config-path .. before no need ![image](https://github.com/user-attachments/assets/22c7f2c4-60d4-478c-bc21-cd0593252d23)
f581279895a7040a36abaea4a6c8a6f50f112cd7
[ "tests::test_cwd_configuration_respected_when_formatting_from_stdin" ]
[ "editorconfig::tests::test_call_parentheses_no_single_string", "editorconfig::tests::test_call_parentheses_always", "editorconfig::tests::test_call_parentheses_none", "editorconfig::tests::test_call_parentheses_no_single_table", "editorconfig::tests::test_collapse_simple_statement_always", "editorconfig::...
[]
[]
08e536f3a02d9a07b0991726897e0013ff78dd21
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Fixed + +- Fixed CLI overrides not applying on top of a resolved `stylua.toml` file ([#925](https://github.com/Johnny...
JohnnyMorganz__StyLua-926
926
Hm, this does look like line endings changing for some reason. Which is weird, since I don't think we touched that at all. Do you by any chance have an example file I can test this with? Either in a public repo, or attaching a code file here (not in a code block since we need to preserve the line endings) Yes, sure ...
[ "925" ]
2.0
JohnnyMorganz/StyLua
2024-11-17T21:01:53Z
diff --git a/src/cli/main.rs b/src/cli/main.rs --- a/src/cli/main.rs +++ b/src/cli/main.rs @@ -953,4 +950,74 @@ mod tests { cwd.close().unwrap(); } + + #[test] + fn test_uses_cli_overrides_instead_of_default_configuration() { + let cwd = construct_tree!({ + "foo.lua": "local x = ...
CLI overrides not applied when formatting files in v2.0.0 I tried to run it both from Windows and from Docker for Windows `stylua.exe --line-endings Windows --check .` `stylua.exe --line-endings Unix --check .` The result is the same, it gives errors in all files. Example of the first two files ``` Diff i...
f581279895a7040a36abaea4a6c8a6f50f112cd7
[ "tests::test_uses_cli_overrides_instead_of_found_configuration" ]
[ "editorconfig::tests::test_call_parentheses_always", "editorconfig::tests::test_call_parentheses_no_single_table", "editorconfig::tests::test_call_parentheses_none", "editorconfig::tests::test_collapse_simple_statement_always", "editorconfig::tests::test_call_parentheses_no_single_string", "editorconfig::...
[]
[]
bc3ce881eaaee46e8eb851366d33cba808d2a1f7
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - The CLI tool will now only write files if the contents differ, and not modify if no change ([#827](https://github.com/JohnnyMorganz/StyLua/...
JohnnyMorganz__StyLua-852
852
We use the ignore crate to provide gitignore-style ignores: https://docs.rs/ignore/latest/ignore/. This may actually be an issue upstream, but I will verify it myself first (Ignore my previous response - I did not read your issue properly!) Yes, I find that ignoring a (sub)directory works when scanning, i.e., "stylua ...
[ "845" ]
0.19
JohnnyMorganz/StyLua
2024-01-20T12:13:59Z
diff --git a/src/cli/main.rs b/src/cli/main.rs --- a/src/cli/main.rs +++ b/src/cli/main.rs @@ -769,4 +769,21 @@ mod tests { cwd.close().unwrap(); } + + #[test] + fn test_respect_ignores_directory_no_glob() { + // https://github.com/JohnnyMorganz/StyLua/issues/845 + let cwd = construc...
`--respect-ignores`: does not correctly ignore folders without the globbing pattern Problem: `.styluaignore` does not ignore **folders** or **directories** like `.gitignore`, `.rgignore`, etc. do. Instead, full globbing patterns (`*.lua` or `**/*.lua`) would be needed to ignore all files under a directory. EDIT: Th...
bc3ce881eaaee46e8eb851366d33cba808d2a1f7
[ "tests::test_respect_ignores_directory_no_glob" ]
[ "editorconfig::tests::test_call_parentheses_always", "editorconfig::tests::test_call_parentheses_none", "editorconfig::tests::test_call_parentheses_no_single_string", "editorconfig::tests::test_call_parentheses_no_single_table", "editorconfig::tests::test_collapse_simple_statement_conditional_only", "edit...
[]
[]
46457ad4e4130d07ee0f9a5cf95ac10023c8ceeb
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Bumped internal parser dependency which should fix parsing problems for comments with Chinese characters, and multiline string escapes -...
JohnnyMorganz__StyLua-666
666
Definitely unintended, let me take a look. Thanks for the report!
[ "665" ]
0.17
JohnnyMorganz/StyLua
2023-03-30T15:38:41Z
diff --git a/tests/tests.rs b/tests/tests.rs --- a/tests/tests.rs +++ b/tests/tests.rs @@ -127,3 +127,40 @@ fn test_sort_requires() { .unwrap()); }) } + +#[test] +fn test_crlf_in_multiline_comments() { + // We need to do this outside of insta since it normalises line endings to LF + let code = r###...
Line endings appear to not be converted when they occur in multiline comments (?) Heyo, we've run into an odd formatting glitch that causes huge git diffs in combination with VS Code's LF/CRLF setting. In this example file, we have CRLFs present in the comment but LFs everywhere else (as created by StyLua, using the...
5c6d59135f419274121349799a5227be467358b1
[ "test_crlf_in_multiline_strings", "test_crlf_in_multiline_comments" ]
[ "editorconfig::tests::test_call_parentheses_always", "editorconfig::tests::test_call_parentheses_no_single_string", "editorconfig::tests::test_call_parentheses_no_single_table", "editorconfig::tests::test_call_parentheses_none", "editorconfig::tests::test_collapse_simple_statement_conditional_only", "edit...
[]
[]
3699358f0ceebe6651789cff25f289d3ac84c937
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Added - Unnecessary parentheses around Luau types will now be removed ([#611](https://github.com/JohnnyMorganz/StyLua/issues/611)) +- ...
JohnnyMorganz__StyLua-631
631
[ "618" ]
0.15
JohnnyMorganz/StyLua
2022-12-18T14:08:23Z
diff --git a/tests/tests.rs b/tests/tests.rs --- a/tests/tests.rs +++ b/tests/tests.rs @@ -89,3 +89,25 @@ fn test_collapse_single_statement() { .unwrap()); }) } + +// Collapse simple statement for goto +#[test] +#[cfg(feature = "lua52")] +fn test_collapse_single_statement_lua_52() { + insta::assert_sn...
`collapse_simple_statement` for goto using `collapse_simple_statement = "Always"`: ```lua -- won't collapse if key == "s" then goto continue end -- on the other hand something like this does collapse local modes = { "n", "v" } if key == "p" then modes = { "n" } end -- ... ```
540ecfb832e3bccf86e0e037b9c855aa464fc4e7
[ "test_collapse_single_statement_lua_52" ]
[ "formatters::trivia_util::tests::test_token_contains_no_singleline_comments_2", "formatters::trivia_util::tests::test_token_contains_no_singleline_comments", "formatters::trivia_util::tests::test_token_contains_singleline_comments", "tests::test_config_call_parentheses", "tests::test_config_column_width", ...
[]
[]
c6eba2da9b6ead6112433f7d2aaa1f2d19a22395
diff --git a/actix-http/CHANGES.md b/actix-http/CHANGES.md --- a/actix-http/CHANGES.md +++ b/actix-http/CHANGES.md @@ -1,6 +1,10 @@ # Changes ## Unreleased - 2022-xx-xx +### Fixed +- Fix parsing ambiguity in Transfer-Encoding and Content-Length headers for HTTP/1.0 requests. [#2794] + +[#2794]: https://github.com/a...
actix__actix-web-2794
2,794
yea `actix-http` is very bad at this. Instead of naively use boolean and options for tracking payload decoder spec it should just take a mutable referenced decoder type with fallible method on mutation. Would there be any fix for this , accepting multiple content-length headers and parsing the body might lead to HT...
[ "2767" ]
4.1
actix/actix-web
2022-06-27T02:48:53Z
diff --git a/actix-http/src/h1/decoder.rs b/actix-http/src/h1/decoder.rs --- a/actix-http/src/h1/decoder.rs +++ b/actix-http/src/h1/decoder.rs @@ -606,14 +655,40 @@ mod tests { } #[test] - fn test_parse_post() { - let mut buf = BytesMut::from("POST /test2 HTTP/1.0\r\n\r\n"); + fn parse_h10_post...
Parsing ambiguity in transfer-encoding and content length headers ## Expected Behavior 1. There is no transfer-encoding: chunked header in HTTP/1.0 acccording to RFC spec , so the content-length header should get interpreted 2. According to [RFC message body length](https://datatracker.ietf.org/doc/html/rfc72...
6408291ab00ed4244ceaa4081315691156d66011
[ "h1::decoder::tests::hrs_multiple_transfer_encoding", "h1::decoder::tests::parse_h10_post", "h1::decoder::tests::hrs_te_http10" ]
[ "body::body_stream::tests::read_to_bytes", "body::body_stream::tests::stream_boxed_error", "body::sized_stream::tests::read_to_bytes", "body::message_body::tests::complete_body_combinators", "body::message_body::tests::test_bytes_mut", "body::message_body::tests::test_vec", "body::body_stream::tests::st...
[]
[ "h1_service_error", "h1_body_chunked_explicit", "h1_head_binary", "h1_body_length", "h1_response_http_error_handling", "h1_body_chunked_implicit" ]
85c9b1a263366d279d544cddf407d00989372269
diff --git a/actix-router/CHANGES.md b/actix-router/CHANGES.md --- a/actix-router/CHANGES.md +++ b/actix-router/CHANGES.md @@ -1,8 +1,11 @@ # Changes ## Unreleased - 2021-xx-xx +- `PathDeserializer` now decodes all percent encoded characters in dynamic segments. [#2566] - Minimum supported Rust version (MSRV) is n...
actix__actix-web-2566
2,566
[ "2248" ]
3.0
actix/actix-web
2022-01-04T13:10:51Z
diff --git a/actix-router/src/de.rs b/actix-router/src/de.rs --- a/actix-router/src/de.rs +++ b/actix-router/src/de.rs @@ -497,6 +489,7 @@ mod tests { use super::*; use crate::path::Path; use crate::router::Router; + use crate::ResourceDef; #[derive(Deserialize)] struct MyStruct { diff --g...
[RFC] percent-encoding in URL path paramters # The problem When extracting URL path parameters from `Path` extractor, the user is expected to be aware of percent-encoding because he would get some encoded characters. To date, all chars are decoded except for `/`, `+`, `%`. This behavior is quite surprising for the ...
b3e84b5c4bf32fd8aeac8c938f9906ce730a7458
[ "de::tests::deserialize_path_decode_string", "de::tests::deserialize_path_decode_map", "de::tests::deserialize_path_decode_seq" ]
[ "de::tests::test_extract_enum_value", "de::tests::test_extract_enum", "resource::tests::build_path_tail", "resource::tests::duplicate_segment_name - should panic", "resource::tests::invalid_dynamic_segment_delimiter - should panic", "resource::tests::multi_pattern_capture_segment_values", "de::tests::te...
[ "app::tests::test_router_wrap_fn", "app::tests::test_external_resource", "app::tests::test_extension", "app::tests::test_router_wrap", "app::tests::test_wrap_fn", "app::tests::test_data_factory", "app::tests::test_default_resource", "app::tests::test_data_factory_errors", "app_service::tests::test_d...
[]
9d1f75d349dd6ad8451b8d2dbc619561868dba4d
diff --git a/actix-web/CHANGES.md b/actix-web/CHANGES.md --- a/actix-web/CHANGES.md +++ b/actix-web/CHANGES.md @@ -5,6 +5,7 @@ ### Changed - Updated `zstd` dependency to `0.13`. +- Compression middleware now prefers brotli over zstd over gzip. ### Fixed diff --git a/actix-web/src/http/header/accept_encoding.rs...
actix__actix-web-3189
3,189
Since equally weighted q-values are not discriminated according to order (it's left up to the origin), I do think we should preference brotli if it is enabled 👍🏻
[ "3187" ]
4.4
actix/actix-web
2023-11-15T08:24:32Z
diff --git a/actix-web/src/http/header/accept_encoding.rs b/actix-web/src/http/header/accept_encoding.rs --- a/actix-web/src/http/header/accept_encoding.rs +++ b/actix-web/src/http/header/accept_encoding.rs @@ -377,11 +407,11 @@ mod tests { ); assert_eq!( test.negotiate([Encoding::gzip(),...
`.negotiate()` prefers `gzip` over `brotli` If I enable `actix_web::middleware::Compress` middleware, it's serving `gzip`, even though `brotli` feature is on. ## Expected Behavior I am expecting it to pick the best compression method supported by Browser, and between brotli and gzip, brotli is better (my site ...
561cc440b2405746d3de01f6983c9c8616a370fb
[ "http::header::accept_encoding::tests::ranking_precedence", "http::header::accept_encoding::tests::preference_selection", "http::header::accept_encoding::tests::encoding_negotiation" ]
[ "error::response_error::tests::test_error_casting", "error::tests::test_urlencoded_error", "error::tests::test_readlines_error", "error::tests::test_json_payload_error", "error::tests::test_query_payload_error", "error::internal::tests::test_internal_error", "error::internal::tests::test_error_helpers",...
[ "data::tests::test_override_data", "data::tests::test_data_extractor", "config::tests::nested_service_configure", "data::tests::test_get_ref_from_dyn_data", "data::tests::test_dyn_data_into_arc", "data::tests::test_app_data_extractor", "app::tests::test_data_factory", "config::tests::registers_default...
[]
87f627cd5d33fe71833c24803174dcec5806fea2
diff --git a/actix-http/CHANGES.md b/actix-http/CHANGES.md --- a/actix-http/CHANGES.md +++ b/actix-http/CHANGES.md @@ -3,6 +3,13 @@ ## Unreleased - 2021-xx-xx +## 3.0.3 - 2022-03-08 +### Fixed +- Allow spaces between header name and colon when parsing responses. [#2684] + +[#2684]: https://github.com/actix/actix-w...
actix__actix-web-2684
2,684
This issue is caused by redirect service does not proper fall through when Location header value does not contain full length uri. (with sheme and authority) I did not test all the 1700 websites provided by issue but from testing a couple of hundreds of it there is no `Invalid URL: URL parse error: invalid format` e...
[ "2102", "2514" ]
4.0
actix/actix-web
2022-03-07T23:43:39Z
diff --git a/actix-http-test/Cargo.toml b/actix-http-test/Cargo.toml --- a/actix-http-test/Cargo.toml +++ b/actix-http-test/Cargo.toml @@ -29,13 +29,13 @@ default = [] openssl = ["tls-openssl", "awc/openssl"] [dependencies] -actix-service = "2.0.0" +actix-service = "2" actix-codec = "0.5" actix-tls = "3" -actix-u...
awc: "Invalid URL: URL parse error: invalid format" error on some websites ## Expected Behavior awc being able to successfully download the websites that work with curl and Firefox. ## Current Behavior On some websites, e.g. http://viralnugget.com, awc fails with the following error: > Invalid URL: URL parse er...
8e76a1c77588c4a8214838c7248e7167b13508b1
[ "middleware::redirect::tests::redirect_relative_without_leading_slash", "middleware::redirect::tests::redirect_without_location", "client_brotli_encoding", "client_gzip_encoding_large", "client_brotli_encoding_large_random", "client_gzip_encoding", "client_gzip_encoding_large_random" ]
[ "client::pool::test::test_pool_authority_key", "request::tests::client_query", "middleware::redirect::tests::test_remove_sensitive_headers", "responses::response_body::tests::read_body", "responses::json_body::tests::read_json_body", "builder::tests::client_bearer_auth", "client::pool::test::test_pool_l...
[]
[]
da4c849f6221be0c3a551da6a4a7570ef693b0f3
diff --git a/actix-http/CHANGES.md b/actix-http/CHANGES.md --- a/actix-http/CHANGES.md +++ b/actix-http/CHANGES.md @@ -1,6 +1,10 @@ # Changes ## Unreleased - 2021-xx-xx +### Fixed +- Encode correctly camel case header with n+2 hyphens [#2683] + +[#2683]: https://github.com/actix/actix-web/issues/2683 ## 3.0.1 ...
actix__actix-web-2683
2,683
I'm gonna try to work on this, just to be clear, the correct ways should be: A-B-C becomes A-B-C, A-B-C-D becomes A-B-C-D right? so, they remain the same as the original values
[ "2674" ]
4.0
actix/actix-web
2022-03-05T12:02:02Z
diff --git a/actix-http/src/h1/encoder.rs b/actix-http/src/h1/encoder.rs --- a/actix-http/src/h1/encoder.rs +++ b/actix-http/src/h1/encoder.rs @@ -528,7 +529,7 @@ mod tests { use std::rc::Rc; use bytes::Bytes; - use http::header::AUTHORIZATION; + use http::header::{AUTHORIZATION, UPGRADE_INSECURE_REQU...
AWC camel cases headers with more than one hyphen incorrectly ## Expected Behavior The headers should be camel cased correctly ## Current Behavior The headers are not camel cased correctly (`A-B-C` becomes `A-BCc`, `A-B-C-D` becomes `A-BCD-d`). ## Possible Solution https://github.com/actix/actix-web/blob/e7a05...
8e76a1c77588c4a8214838c7248e7167b13508b1
[ "h1::encoder::tests::test_camel_case" ]
[ "body::sized_stream::tests::stream_string_error", "body::either::tests::type_parameter_inference", "body::body_stream::tests::stream_delayed_error", "body::message_body::tests::boxing_equivalence", "body::body_stream::tests::skips_empty_chunks", "body::message_body::tests::none_body_combinators", "body:...
[]
[]
d57f11445da31eb1183c34d78a93f8b601c2333e
diff --git a/src/config/mod.rs b/src/config/mod.rs --- a/src/config/mod.rs +++ b/src/config/mod.rs @@ -796,6 +796,9 @@ impl Config { }, None => bail!("No role"), }; + if role_name.contains('#') { + bail!("Unable to save role with arguments") + } if ro...
sigoden__aichat-830
830
[ "828" ]
0.21
sigoden/aichat
2024-09-03T22:14:13Z
diff --git a/src/config/role.rs b/src/config/role.rs --- a/src/config/role.rs +++ b/src/config/role.rs @@ -407,11 +407,11 @@ mod tests { #[test] fn test_merge_prompt_name() { assert_eq!( - complete_prompt_args("convert __ARG1__", "convert:foo"), + complete_prompt_args("convert _...
`:` in `roles/convert:json:toml.md` is invalid file identifier On Windows and the finder app on macOS, `:` is not a valid name. Suggestion: use valid identifiers that can be used on both macOS and windows, for example `{}`
d57f11445da31eb1183c34d78a93f8b601c2333e
[ "config::role::tests::test_merge_prompt_name", "config::role::tests::test_match_name" ]
[ "config::role::tests::test_parse_structure_prompt1", "config::role::tests::test_parse_structure_prompt2", "config::role::tests::test_parse_structure_prompt3", "client::stream::tests::test_json_stream_ndjson", "client::stream::tests::test_json_stream_array", "rag::bm25::tests::test_tokenize", "rag::split...
[]
[]
737580bb87f3b1d2f040dd7a4ddacca3595915a0
diff --git a/src/cli.rs b/src/cli.rs --- a/src/cli.rs +++ b/src/cli.rs @@ -73,12 +73,7 @@ pub struct Cli { impl Cli { pub fn text(&self) -> Option<String> { - let text = self - .text - .iter() - .map(|x| x.trim().to_string()) - .collect::<Vec<String>>() - ...
sigoden__aichat-1056
1,056
[ "1055" ]
0.25
sigoden/aichat
2024-12-13T22:50:17Z
diff --git a/src/repl/mod.rs b/src/repl/mod.rs --- a/src/repl/mod.rs +++ b/src/repl/mod.rs @@ -807,6 +811,10 @@ mod tests { split_files_text("file.txt -- hello", false), (vec!["file.txt".into()], "hello") ); + assert_eq!( + split_files_text("file.txt -- \thello", fal...
Unable to define a grammar check that keeps indentation. **Describe the bug** When passing a string via argument, or STDIN, whitespace is trimmed in my role. **To Reproduce** I edited the grammar role example, and tried to make it work with code comments and indentation (I pipe strings from my editor to aichat...
737580bb87f3b1d2f040dd7a4ddacca3595915a0
[ "repl::tests::test_split_files_text" ]
[ "config::role::tests::test_match_name", "config::role::tests::test_parse_structure_prompt2", "config::role::tests::test_parse_structure_prompt3", "config::role::tests::test_merge_prompt_name", "rag::splitter::tests::test_chunk_header", "client::stream::tests::test_json_stream_ndjson", "client::stream::t...
[]
[]
927b864844fa70a33a9abf557f9f813f831c54e1
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ## 0.14.0-dev +### Fixed + +- Vi inline search/semantic selection expanding across newlines + ## 0.13.1 ### Added diff --git a/alacrit...
alacritty__alacritty-7600
7,600
Seems like somehow 845a5d8a8d47c233c4ed8177ecbb20b05b22118b broke this.
[ "7587" ]
1.70
alacritty/alacritty
2024-01-09T23:39:16Z
diff --git a/alacritty_terminal/src/term/search.rs b/alacritty_terminal/src/term/search.rs --- a/alacritty_terminal/src/term/search.rs +++ b/alacritty_terminal/src/term/search.rs @@ -1129,4 +1134,25 @@ mod tests { let end = Point::new(Line(0), Column(3)); assert_eq!(term.regex_search_right(&mut regex,...
Spurious char from previous line in double click selection Since alacritty `0.13.0` selecting a word / line with a double click will also select the last character of the previous line if it is non-whitespace. ![image](https://github.com/alacritty/alacritty/assets/1280142/098351c6-5b78-4838-ac40-0231990f7cf5) (do...
5e6b92db85b3ea7ffd06a7a5ae0d2d62ad5946a6
[ "term::search::tests::newline_breaking_semantic" ]
[ "grid::storage::tests::grow_after_zero", "grid::storage::tests::grow_before_zero", "grid::storage::tests::indexing", "grid::storage::tests::indexing_above_inner_len - should panic", "grid::storage::tests::initialize", "grid::storage::tests::rotate", "grid::storage::tests::rotate_wrap_zero", "grid::tes...
[]
[]
e07bf6f24a7fa7438dd757d6e761c100dd920d68
diff --git a/alacritty_terminal/src/term/search.rs b/alacritty_terminal/src/term/search.rs --- a/alacritty_terminal/src/term/search.rs +++ b/alacritty_terminal/src/term/search.rs @@ -43,35 +43,36 @@ impl RegexSearch { let max_size = config.get_cache_capacity(); let thompson_config = ThompsonConfig::ne...
alacritty__alacritty-7281
7,281
This is likely due to the leftmost search for the pattern causing `;*` to match empty strings and ending in a dead state thereafter. I'm not sure if this can be solved without switching to a backtracking regex parser, but since users can relatively easily work around this, I don't think it's a big issue.
[ "7276" ]
1.70
alacritty/alacritty
2023-10-09T06:38:32Z
diff --git a/alacritty_terminal/src/term/search.rs b/alacritty_terminal/src/term/search.rs --- a/alacritty_terminal/src/term/search.rs +++ b/alacritty_terminal/src/term/search.rs @@ -1109,4 +1099,16 @@ mod tests { let end = Point::new(Line(0), Column(17)); assert_eq!(term.regex_search_right(&mut regex...
Regex `;*|rust` doesn't match anything in `rustfmt` string The bug is present on master and on v0.12.3. It's enough to search for the following regex. The `;+|rust` works just fine.
5e6b92db85b3ea7ffd06a7a5ae0d2d62ad5946a6
[ "term::search::tests::anchored_empty" ]
[ "grid::storage::tests::grow_after_zero", "grid::storage::tests::grow_before_zero", "grid::storage::tests::indexing", "grid::storage::tests::indexing_above_inner_len - should panic", "grid::storage::tests::rotate", "grid::storage::tests::rotate_wrap_zero", "grid::storage::tests::shrink_after_zero", "gr...
[]
[]
77aa9f42bac4377efe26512d71098d21b9b547fd
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -49,6 +49,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - Cut off wide characters in preedit string - Scrolling on touchscreens - Double clicking on CSD titlebar not always maximizing a window on...
alacritty__alacritty-7204
7,204
Going to remove high priority from this since it shouldn't cause complete destruction anymore. But I still think we can probably do better. Potentially a lazily evaluated regex might perform more reasonably.
[ "7097" ]
1.65
alacritty/alacritty
2023-09-08T21:15:52Z
diff --git a/alacritty/src/config/ui_config.rs b/alacritty/src/config/ui_config.rs --- a/alacritty/src/config/ui_config.rs +++ b/alacritty/src/config/ui_config.rs @@ -578,8 +578,8 @@ mod tests { "ftp://ftp.example.org", ] { let term = mock_term(regular_url); - let regex = R...
Hint regex with large chars amount. Hanging and continues memory consumption ### Problem With the `Qm[0-9A-Za-z]{44}` as a hint regex pattern, Alacritty hangs upon activating Hints and memory consumption starts to growth continuously. ```yml # ... rest of the config hints: enabled: - regex: 'Qm[0-9A-Za...
77aa9f42bac4377efe26512d71098d21b9b547fd
[ "term::search::tests::runtime_cache_error" ]
[ "grid::storage::tests::indexing", "grid::storage::tests::grow_after_zero", "grid::storage::tests::grow_before_zero", "grid::storage::tests::rotate_wrap_zero", "grid::storage::tests::indexing_above_inner_len - should panic", "grid::storage::tests::shrink_after_zero", "grid::storage::tests::shrink_before_...
[]
[]
437f42f8d30fb6d4843738fbd46bb801679443a7
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - Strip trailing whitespaces when yanking from a block selection - Display area keeps history position when viewport is cleared - Commands ...
alacritty__alacritty-5722
5,722
It does not, please provide more information on how to reproduce this. see https://www.loom.com/share/79882dd3fbc241ff9ac41fa3b922fcdc when the url length same as screen width , the "%A" will add Interesting, that's kinda what I suspected but I'm not able to reproduce it. Which version of Alacritty are you using? ...
[ "5697" ]
1.56
alacritty/alacritty
2021-12-27T13:59:53Z
diff --git a/alacritty_terminal/src/term/mod.rs b/alacritty_terminal/src/term/mod.rs --- a/alacritty_terminal/src/term/mod.rs +++ b/alacritty_terminal/src/term/mod.rs @@ -2103,7 +2109,7 @@ mod tests { ); selection.update(Point { line: Line(2), column: Column(2) }, Side::Right); term.selection...
macos click url add "%0A" (newline) macos click url add "%0A" (newline) ![image](https://user-images.githubusercontent.com/69608605/146624855-028d482f-d02c-46f4-8794-776925c62dd8.png) ![image](https://user-images.githubusercontent.com/69608605/146624863-084a3886-cbce-4dff-bd71-61af8150a8ca.png) click this add ...
589c1e9c6b8830625162af14a9a7aee32c7aade0
[ "term::tests::selecting_empty_line" ]
[ "ansi::tests::parse_designate_g0_as_line_drawing", "ansi::tests::parse_invalid_legacy_rgb_colors", "ansi::tests::parse_control_attribute", "ansi::tests::parse_designate_g1_as_line_drawing_and_invoke", "ansi::tests::parse_invalid_number", "ansi::tests::parse_invalid_rgb_colors", "ansi::tests::parse_numbe...
[]
[]
7e736c00f68ca133ca3380c1ddd78ba61ced1f8e
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - Crash when hovering over a match emptied by post-processing - Crash when the vi cursor is on the scrollback and viewport clear is invoked ...
alacritty__alacritty-5653
5,653
[ "5652" ]
0.1
alacritty/alacritty
2021-12-02T19:38:28Z
diff --git a/alacritty_terminal/src/term/mod.rs b/alacritty_terminal/src/term/mod.rs --- a/alacritty_terminal/src/term/mod.rs +++ b/alacritty_terminal/src/term/mod.rs @@ -2190,6 +2189,26 @@ mod tests { assert_eq!(term.grid, scrolled_grid); } + #[test] + fn vi_cursor_keep_pos_on_scrollback_buffer()...
Vi cursor on topmost of the display moves downward when scrolled into history with active output ### Reproduction steps 1. Create a scrollback buffer(history). ```sh $ seq $LINES ``` 2. Run a repeated output command. ```sh $ ( declare -i n=0; while (( 1 )); do echo "$n"; n+=1; sleep 1; done ) ``` 3. ...
2c78d216ca2934595b0b56464fb84048cd979c8d
[ "term::tests::vi_cursor_keep_pos_on_scrollback_buffer" ]
[ "ansi::tests::parse_invalid_legacy_rgb_colors", "ansi::tests::parse_control_attribute", "ansi::tests::parse_designate_g1_as_line_drawing_and_invoke", "ansi::tests::parse_designate_g0_as_line_drawing", "ansi::tests::parse_invalid_number", "ansi::tests::parse_invalid_rgb_colors", "ansi::tests::parse_numbe...
[]
[]
4c6a763850a5dec0fa34d15e356dcba19875690a
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - Vi mode search starting in the line below the vi cursor - Invisible cursor with matching foreground/background colors - Crash when hoveri...
alacritty__alacritty-5607
5,607
[ "5544" ]
0.1
alacritty/alacritty
2021-11-13T04:20:57Z
diff --git a/alacritty_terminal/src/grid/mod.rs b/alacritty_terminal/src/grid/mod.rs --- a/alacritty_terminal/src/grid/mod.rs +++ b/alacritty_terminal/src/grid/mod.rs @@ -376,6 +376,9 @@ impl<T> Grid<T> { pub fn clear_history(&mut self) { // Explicitly purge all lines from history. self.raw.shrin...
Alacritty crashes when in vi mode and terminal clears Alacritty panics when receiving any clear ansi escape code (tested with `^[[2J` and `^[c`) when in vi mode near the top of a long buffer with the following message: ``` thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', alacritty/src/display/...
2c78d216ca2934595b0b56464fb84048cd979c8d
[ "term::tests::clear_scrollback_set_vi_cursor_into_viewport", "term::tests::clear_viewport_set_vi_cursor_into_viewport" ]
[ "ansi::tests::parse_control_attribute", "ansi::tests::parse_designate_g1_as_line_drawing_and_invoke", "ansi::tests::parse_designate_g0_as_line_drawing", "ansi::tests::parse_invalid_legacy_rgb_colors", "ansi::tests::parse_invalid_number", "ansi::tests::parse_invalid_rgb_colors", "ansi::tests::parse_numbe...
[]
[]
40bbdce6de8775b7bbc3f9a5731337d1dd05d195
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,10 +34,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - `SpawnNewInstance` no longer inherits initial `--command` - Blinking cursor will timeout after `5` seconds by default - Deprecated `col...
alacritty__alacritty-6186
6,186
What's the output of `alacritty -v`? Unfortunately, it doesn't provide more information: ``` [0.000636401s] [INFO ] [alacritty] Welcome to Alacritty [0.002597571s] [INFO ] [alacritty] Version 0.10.1 (2844606) [0.006755700s] [INFO ] [alacritty_config_derive] No config file found; using default thread 'main' panic...
[ "6108" ]
1.57
alacritty/alacritty
2022-07-06T17:33:14Z
diff --git a/alacritty_config_derive/tests/config.rs b/alacritty_config_derive/tests/config.rs --- a/alacritty_config_derive/tests/config.rs +++ b/alacritty_config_derive/tests/config.rs @@ -35,6 +35,8 @@ struct Test { enom_big: TestEnum, #[config(deprecated)] enom_error: TestEnum, + #[config(removed ...
Crash on startup (macOS): 'A font must have a non-null family name.' Alacritty crashes on macOS on startup. No custom `alacritty.yml` is defined. ### System OS: macOS BigSur 11.6.6 (20G624) Version: alacritty 0.10.1 (2844606) ### Logs Crashes: ``` $ alacritty thread 'main' panicked at 'A font must have...
578e08486dfcdee0b2cd0e7a66752ff50edc46b8
[ "config_deserialize" ]
[]
[]
[]
8a26dee0a9167777709935789b95758e36885617
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,27 @@ The sections should follow the order `Packaging`, `Added`, `Changed`, `Fixed` an The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). +## 0.10.1-rc1 + +### Added + + - Option `font.builtin_bo...
alacritty__alacritty-5870
5,870
[ "5840" ]
0.10
alacritty/alacritty
2022-02-09T17:07:06Z
diff --git a/.builds/freebsd.yml b/.builds/freebsd.yml --- a/.builds/freebsd.yml +++ b/.builds/freebsd.yml @@ -33,7 +33,7 @@ tasks: cargo clippy --all-targets - feature-wayland: | cd alacritty/alacritty - cargo test --no-default-features --features=wayland + RUSTFLAGS="-D warnings" cargo test...
Alacritty keeps asking for permissions ### System OS: MacOS 12.0.1 Version: 0.10.0 ### Expected Behavior Alacritty asks for permissions to access folders once and remembers. ### Actual Behavior Every keystroke in a protected MacOS folder (i.e. Desktop, Downloads, Documents) I get a prompt to give it access....
8a26dee0a9167777709935789b95758e36885617
[ "ansi::tests::parse_osc104_reset_all_colors" ]
[ "ansi::tests::parse_control_attribute", "ansi::tests::parse_designate_g0_as_line_drawing", "ansi::tests::parse_invalid_legacy_rgb_colors", "ansi::tests::parse_designate_g1_as_line_drawing_and_invoke", "ansi::tests::parse_invalid_number", "ansi::tests::parse_invalid_rgb_colors", "ansi::tests::parse_numbe...
[]
[]
60ef17e8e98b0ed219a145881d10ecd6b9f26e85
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - OSC 4 not handling `?` - `?` in OSC strings reporting default colors instead of modified ones +- OSC 104 not clearing colors when second...
alacritty__alacritty-5788
5,788
Querying the current value with `?` simply isn't implemented, should be trivial to do though if someone is interested. I would also like support for this. An additional problem is that the colors currently reported by `\e]11;?\a` are the original term colors rather than the (potentially) modified ones. I'm looking int...
[ "5542" ]
1.56
alacritty/alacritty
2022-01-15T22:10:04Z
diff --git a/alacritty_terminal/src/ansi.rs b/alacritty_terminal/src/ansi.rs --- a/alacritty_terminal/src/ansi.rs +++ b/alacritty_terminal/src/ansi.rs @@ -1506,6 +1506,7 @@ mod tests { attr: Option<Attr>, identity_reported: bool, color: Option<Rgb>, + reset_colors: Vec<usize>, } ...
problems with OSC 4 and 104 [Documentation claims that OSC 4 and OSC 104 are supported](https://github.com/alacritty/alacritty/blob/master/docs/escape_support.md). However, testing reveals some issues. If the OSC is fully supported, we should be able to query the state of colors. Here's a working query using OSC 11:...
589c1e9c6b8830625162af14a9a7aee32c7aade0
[ "ansi::tests::parse_osc104_reset_all_colors" ]
[ "ansi::tests::parse_control_attribute", "ansi::tests::parse_designate_g0_as_line_drawing", "ansi::tests::parse_invalid_legacy_rgb_colors", "ansi::tests::parse_number_too_large", "ansi::tests::parse_invalid_rgb_colors", "ansi::tests::parse_designate_g1_as_line_drawing_and_invoke", "ansi::tests::parse_inv...
[]
[]
22a447573bbd67c0a5d3946d58d6d61bac3b4ad2
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,22 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). Notable changes to the `alacritty_terminal` crate are documented in its [CHANGELOG](./alacritty_terminal/CHANGELOG.md). +## 0.14.1-rc1 + +#...
alacritty__alacritty-8356
8,356
[ "8314", "8268" ]
0.14
alacritty/alacritty
2024-12-14T01:10:33Z
diff --git a/alacritty/src/input/mod.rs b/alacritty/src/input/mod.rs --- a/alacritty/src/input/mod.rs +++ b/alacritty/src/input/mod.rs @@ -1136,7 +1136,7 @@ mod tests { inline_search_state: &'a mut InlineSearchState, } - impl<'a, T: EventListener> super::ActionContext<T> for ActionContext<'a, T> { + ...
Semantic characters in Vi Mode and moving left ### System OS: Linux 6.11.9 (arch) Version: alacritty 0.14.0 (22a44757) Sway 1:1.10-1 ``` [0.000000942s] [INFO ] [alacritty] Welcome to Alacritty [0.000051958s] [INFO ] [alacritty] Version 0.14.0 (22a44757) [0.000061095s] [INFO ] [alacritty] Running on Wayland...
22a447573bbd67c0a5d3946d58d6d61bac3b4ad2
[ "vi_mode::tests::wide_semantic_char" ]
[ "grid::storage::tests::indexing", "grid::storage::tests::grow_after_zero", "grid::storage::tests::indexing_above_inner_len - should panic", "grid::storage::tests::rotate", "grid::storage::tests::grow_before_zero", "grid::storage::tests::shrink_after_zero", "grid::storage::tests::rotate_wrap_zero", "gr...
[]
[]
4f739a7e2b933f6828ebf64654c8a8c573bf0ec1
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ Notable changes to the `alacritty_terminal` crate are documented in its - Mouse/Vi cursor hint highlighting broken on the terminal cursor line - Hint launcher opening arbitrary text, when terminal content changed while ...
alacritty__alacritty-8315
8,315
I'd assume that you have those wide chars in semantic chars specified, since wide chars are not there by default. Yes. `[selection] semantic_escape_chars = ",│`|:\"' ()[]{}<>\t•-—－．" ` It seems like `b` isn't the only binding affected. The `w` binding also does not work correctly.
[ "8314" ]
1.74
alacritty/alacritty
2024-11-20T01:21:31Z
diff --git a/alacritty_terminal/src/term/mod.rs b/alacritty_terminal/src/term/mod.rs --- a/alacritty_terminal/src/term/mod.rs +++ b/alacritty_terminal/src/term/mod.rs @@ -930,6 +930,11 @@ impl<T> Term<T> { &self.config.semantic_escape_chars } + #[cfg(test)] + pub(crate) fn set_semantic_escape_char...
Semantic characters in Vi Mode and moving left ### System OS: Linux 6.11.9 (arch) Version: alacritty 0.14.0 (22a44757) Sway 1:1.10-1 ``` [0.000000942s] [INFO ] [alacritty] Welcome to Alacritty [0.000051958s] [INFO ] [alacritty] Version 0.14.0 (22a44757) [0.000061095s] [INFO ] [alacritty] Running on Wayland...
4f739a7e2b933f6828ebf64654c8a8c573bf0ec1
[ "vi_mode::tests::wide_semantic_char" ]
[ "grid::storage::tests::indexing", "grid::storage::tests::indexing_above_inner_len - should panic", "grid::storage::tests::grow_after_zero", "grid::storage::tests::rotate_wrap_zero", "grid::storage::tests::rotate", "grid::storage::tests::shrink_after_zero", "grid::storage::tests::shrink_before_zero", "...
[]
[]
c74b5fa857a133298f0207c499c47cb95b27c78c
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,6 +38,7 @@ Notable changes to the `alacritty_terminal` crate are documented in its - Broken search with words broken across line boundary on the first character - Config import changes not being live reloaded - Cursor color request...
alacritty__alacritty-8190
8,190
You can just comment under existing issues, there's no need to create new ones. I've checked out the characters you mention specifically and it seems like fullwidth characters can't be used as semantic escape chars. Thanks for clearing that up. Many thanks for an exceptional piece of software.
[ "8188" ]
1.74
alacritty/alacritty
2024-09-21T21:00:01Z
diff --git a/alacritty_terminal/src/term/search.rs b/alacritty_terminal/src/term/search.rs --- a/alacritty_terminal/src/term/search.rs +++ b/alacritty_terminal/src/term/search.rs @@ -1171,4 +1178,16 @@ mod tests { let match_end = Point::new(Line(1), Column(2)); assert_eq!(term.regex_search_left(&mut r...
alacritty not honouring [semantic_escape_chars] setting I hope I am not over-stepping any github/alacritty rules. My previous ticket has been closed, and I cannot find a way to reopen it (just joined yesterday). Please feel free to delete this ticket if need be. `semantic_escape_chars = ",│`|:\"' ()[]{}<>\t•-—－．...
4f739a7e2b933f6828ebf64654c8a8c573bf0ec1
[ "term::search::tests::fullwidth_semantic" ]
[ "grid::storage::tests::indexing", "grid::storage::tests::indexing_above_inner_len - should panic", "grid::storage::tests::rotate_wrap_zero", "grid::storage::tests::grow_after_zero", "grid::storage::tests::shrink_after_zero", "grid::storage::tests::rotate", "grid::storage::tests::grow_before_zero", "gr...
[]
[]
5e6b92db85b3ea7ffd06a7a5ae0d2d62ad5946a6
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,6 +31,7 @@ Notable changes to the `alacritty_terminal` crate are documented in its - Leaking FDs when closing windows on Unix systems - Config emitting errors for nonexistent import paths - Kitty keyboard protocol reporting shifted...
alacritty__alacritty-8069
8,069
The provided video cannot be played back. @chrisduerr , I can play it back. Do you use firefox? If so, videos in github with firefox is a known bug. Try downloading video or using another browser :shrug: Even without video, try to create a long line with like 30 or 40 entries of the same word and try backward-searchin...
[ "8060" ]
1.70
alacritty/alacritty
2024-06-28T23:36:44Z
diff --git a/alacritty_terminal/src/term/search.rs b/alacritty_terminal/src/term/search.rs --- a/alacritty_terminal/src/term/search.rs +++ b/alacritty_terminal/src/term/search.rs @@ -1155,4 +1155,20 @@ mod tests { assert_eq!(start, Point::new(Line(1), Column(0))); assert_eq!(end, Point::new(Line(1), C...
Bug: backward search on single line goes in cycles When using backward search, it sometimes goes in cycles without moving a cursor to some search result. In example video, before resizing, everything works fine, but after resizing, it cycles only on several last elements on the line, instead of cycling through all occu...
5e6b92db85b3ea7ffd06a7a5ae0d2d62ad5946a6
[ "term::search::tests::inline_word_search" ]
[ "grid::storage::tests::indexing", "grid::storage::tests::rotate", "grid::storage::tests::shrink_after_zero", "grid::storage::tests::shrink_before_and_after_zero", "grid::storage::tests::indexing_above_inner_len - should panic", "grid::storage::tests::shrink_before_zero", "grid::storage::tests::rotate_wr...
[]
[]
c354f58f421c267cc1472414eaaa9f738509ede0
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,6 +28,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - Autokey no longer working with alacritty on X11 - Freeze when moving window between monitors on Xfwm - Mouse cursor not changing on Wayla...
alacritty__alacritty-7729
7,729
The problem is [here](https://github.com/alacritty/alacritty/blob/master/alacritty_config_derive/src/serde_replace.rs#L51). This is what's generated when I look with `cargo expand`: ```rust #[allow(clippy::extra_unused_lifetimes)] impl<'de> alacritty_config::SerdeReplace for InvertedCellColors { fn...
[ "7720" ]
1.72
alacritty/alacritty
2024-02-13T19:46:11Z
diff --git a/alacritty_config_derive/tests/config.rs b/alacritty_config_derive/tests/config.rs --- a/alacritty_config_derive/tests/config.rs +++ b/alacritty_config_derive/tests/config.rs @@ -23,7 +23,7 @@ impl Default for TestEnum { #[derive(ConfigDeserialize)] struct Test { - #[config(alias = "noalias")] + #...
CLI -o config overrides should accept aliases as documented ### Expected behavior As indicated by `man alacritty`, the `-o` option can be used to override configuration from the `alacritty.toml` config file with the properties specified by `man 5 alacritty`. One would therefore expect that ```alacritty -o 'colors.cur...
41d2f1df4509148a6f1ffb3de59c2389a3a93283
[ "replace_derive_using_alias", "replace_derive_using_multiple_aliases", "replace_flatten_using_alias" ]
[ "replace_derive", "config_deserialize", "field_replacement", "replace_flatten" ]
[]
[]
839fd7bc8bcafd73aac0259d2efdc273486c6a98
diff --git a/rslib/i18n/src/lib.rs b/rslib/i18n/src/lib.rs --- a/rslib/i18n/src/lib.rs +++ b/rslib/i18n/src/lib.rs @@ -22,13 +22,46 @@ type FluentBundle<T> = FluentBundleOrig<T, intl_memoizer::concurrent::IntlLangMe pub use fluent::fluent_args as tr_args; -pub trait Number: Into<FluentNumber> {} -impl Number for i...
ankitects__anki-3162
3,162
Hi! I realise this is a very trivial thing, but would it not be possible to display all of the numbers in decimal format (including 1, 2, 3, etc.)? Numbers expressed in the decimal format use the noun's plural form. Showing "1.00" will not only guarantee formatting consistency between the whole hours and the p...
[ "3102" ]
0.0
ankitects/anki
2024-04-23T03:09:35Z
diff --git a/rslib/i18n/src/lib.rs b/rslib/i18n/src/lib.rs --- a/rslib/i18n/src/lib.rs +++ b/rslib/i18n/src/lib.rs @@ -446,6 +479,14 @@ mod test { assert!(want_comma_as_decimal_separator(&[langid!("pl-PL")])); } + #[test] + fn decimal_rounding() { + let tr = I18n::new(&["en"]); + + a...
“1 hours today” > I’ve noticed that if you study for exactly one hour, you’re told “Studied n cards in 1 hours today (_m_s/card).” > This is an incredibly minor point, but ideally it would say “1 hour” instead of “1 hours” (but be plural again for “1.1 hours”, “1.2 hours”, etc.). Originally reported on https://foru...
4d20945319c3e68c4a8d10ad9c6d6eb9b985f16c
[ "test::decimal_rounding" ]
[ "test::i18n", "test::numbers" ]
[]
[]
5e04e776efae33b311a850a0b6bae3104b90e1d4
diff --git a/src/error.rs b/src/error.rs --- a/src/error.rs +++ b/src/error.rs @@ -5,7 +5,7 @@ use std::error::Error as StdError; use std::fmt::{self, Debug, Display}; use std::mem::{self, ManuallyDrop}; use std::ops::{Deref, DerefMut}; -use std::ptr; +use std::ptr::{self, NonNull}; impl Error { /// Create a...
dtolnay__anyhow-34
34
For that matter, should `e.downcast_ref::<io::Error>()` succeed?
[ "32" ]
1.0
dtolnay/anyhow
2019-10-28T04:27:06Z
diff --git a/tests/test_context.rs b/tests/test_context.rs --- a/tests/test_context.rs +++ b/tests/test_context.rs @@ -1,4 +1,9 @@ -use anyhow::{Context, Result}; +mod drop; + +use crate::drop::{DetectDrop, Flag}; +use anyhow::{Context, Error, Result}; +use std::fmt::{self, Display}; +use thiserror::Error; // https:...
Figure out how context should interact with downcasting For example if we have: ```rust let e = fs::read("/...").context(ReadFailed).unwrap_err(); match e.downcast_ref::<ReadFailed>() { ``` should this downcast succeed or fail?
2737bbeb59f50651ff54ca3d879a3f5d659a98ab
[ "test_downcast_low", "test_downcast_high", "test_downcast_mid" ]
[ "test_downcast_ref", "test_inference", "test_unsuccessful_downcast", "test_convert", "test_question_mark", "test_drop", "test_downcast", "test_large_alignment", "test_downcast_mut", "test_display", "test_messages", "test_ensure", "test_autotraits", "test_error_size", "test_null_pointer_o...
[]
[]
6088b60791fc063f35183df8a4706a8723a8568a
diff --git a/src/kind.rs b/src/kind.rs --- a/src/kind.rs +++ b/src/kind.rs @@ -45,7 +45,6 @@ // (&error).anyhow_kind().new(error) use crate::Error; -use std::error::Error as StdError; use std::fmt::{Debug, Display}; #[cfg(backtrace)] diff --git a/src/kind.rs b/src/kind.rs --- a/src/kind.rs +++ b/src/kind.rs...
dtolnay__anyhow-47
47
[ "46" ]
1.0
dtolnay/anyhow
2019-11-18T19:43:20Z
diff --git a/tests/test_source.rs b/tests/test_source.rs --- a/tests/test_source.rs +++ b/tests/test_source.rs @@ -53,3 +53,10 @@ fn test_io_source() { let error = anyhow!(TestError::Io(io)); assert_eq!("oh no!", error.source().unwrap().to_string()); } + +#[test] +fn test_anyhow_from_anyhow() { + let erro...
Usage of `bail!(error)` loses the context of `error` I was in a situation recently where I was doing: ```rust match some_result { Ok(()) => {} Err(e) => { if !err_is_ok(e) { bail!(e); } } } ``` in this case `e` was actually of type `anyhow::Error` so a `return Err(...
2737bbeb59f50651ff54ca3d879a3f5d659a98ab
[ "test_anyhow_from_anyhow" ]
[ "test_send", "test_sync", "test_iter", "test_len", "test_rev", "test_downcast_high", "test_downcast_low", "test_downcast_mid", "test_downcast_ref", "test_inference", "test_unsuccessful_downcast", "test_convert", "test_question_mark", "test_downcast", "test_downcast_mut", "test_large_al...
[]
[]
2246959a46f627a455a1dc5ca0fff0d5c5f795e9
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -748,7 +748,7 @@ dependencies = [ [[package]] name = "spinoso-time" -version = "0.7.0" +version = "0.7.1" dependencies = [ "once_cell", "regex", diff --git a/artichoke-backend/Cargo.toml b/artichoke-backend/Cargo.toml --- a/artichoke-bac...
artichoke__artichoke-2416
2,416
I've put up a stabilization PR for this feature in Rust `std` here: https://github.com/rust-lang/rust/pull/102271. These functions were stabilized and released today in Rust 1.66.0: - https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.try_from_secs_f32 - https://blog.rust-lang.org/2022/12/15/Rust...
[ "2194" ]
4.1
artichoke/artichoke
2023-02-19T19:20:14Z
diff --git a/spinoso-time/src/time/tzrs/math.rs b/spinoso-time/src/time/tzrs/math.rs --- a/spinoso-time/src/time/tzrs/math.rs +++ b/spinoso-time/src/time/tzrs/math.rs @@ -304,6 +304,15 @@ mod tests { } } + #[test] + fn add_out_of_fixnum_range_float_sec() { + let dt = datetime(); + dt...
`Time::checked_add_f64` and `Time::checked_sub_f64` panic on too large input ```rust use core::time::Duration; fn main() { dbg!(Duration::from_secs_f64(f64::MAX)); } ``` Output: ``` Compiling playground v0.0.1 (/playground) Finished dev [unoptimized + debuginfo] target(s) in 0.58s Running `...
2246959a46f627a455a1dc5ca0fff0d5c5f795e9
[ "time::tzrs::math::tests::sub_out_of_fixnum_range_float_sec", "time::tzrs::math::tests::add_out_of_fixnum_range_float_sec" ]
[ "time::tzrs::math::tests::add_float_to_time", "time::tzrs::math::tests::rounding", "time::tzrs::offset::tests::fixed_zero_is_not_utc", "time::tzrs::offset::tests::from_str_hh_mm", "time::tzrs::offset::tests::from_str_hh_colon_mm", "time::tzrs::offset::tests::from_str_non_ascii_numeral_fixed_strings", "t...
[]
[]
c29ecd68714bddf5e27a9e347c902faa23b2a545
diff --git a/askama_shared/src/parser.rs b/askama_shared/src/parser.rs --- a/askama_shared/src/parser.rs +++ b/askama_shared/src/parser.rs @@ -539,7 +539,7 @@ fn filter(i: &[u8]) -> IResult<&[u8], (&str, Option<Vec<Expr>>)> { } fn expr_filtered(i: &[u8]) -> IResult<&[u8], Expr> { - let (i, (obj, filters)) = tupl...
rinja-rs__askama-426
426
Oops -- we should fix that! Oops -- we should fix that!
[ "424", "424" ]
0.10
rinja-rs/askama
2021-01-05T14:44:35Z
diff --git a/askama_shared/src/parser.rs b/askama_shared/src/parser.rs --- a/askama_shared/src/parser.rs +++ b/askama_shared/src/parser.rs @@ -1126,7 +1126,41 @@ mod tests { #[test] fn test_parse_filter() { - super::parse("{{ strvar|e }}", &Syntax::default()).unwrap(); + use Expr::*; + ...
Filters have precedence over unary operators Performing e.g. `{{ -2|abs }}` is parsed as `{{ -(2|abs) }}` resulting in `-2` being rendered. Filters have precedence over unary operators Performing e.g. `{{ -2|abs }}` is parsed as `{{ -(2|abs) }}` resulting in `-2` being rendered.
49252d2457f280026c020d0df46733578eb959a5
[ "parser::tests::test_parse_filter" ]
[ "filters::json::tests::test_json", "filters::tests::test_capitalize", "filters::tests::test_into_isize", "filters::tests::test_linebreaks", "parser::tests::change_delimiters_parse_filter", "parser::tests::test_associativity", "tests::find_absolute", "filters::tests::test_indent", "filters::tests::te...
[ "filters::yaml::tests::test_yaml" ]
[]
43e92aa3b6b9cd967a70bd0fd54d1f087d6ed76b
diff --git a/askama_parser/src/expr.rs b/askama_parser/src/expr.rs --- a/askama_parser/src/expr.rs +++ b/askama_parser/src/expr.rs @@ -248,15 +248,15 @@ impl<'a> Suffix<'a> { } fn r#macro(i: &'a str) -> IResult<&'a str, Self> { - fn nested_parenthesis(i: &str) -> IResult<&str, ()> { + fn neste...
rinja-rs__askama-861
861
[ "860" ]
0.12
rinja-rs/askama
2023-09-11T09:42:00Z
diff --git a/askama_parser/src/tests.rs b/askama_parser/src/tests.rs --- a/askama_parser/src/tests.rs +++ b/askama_parser/src/tests.rs @@ -788,3 +788,10 @@ fn test_parse_array() { )], ); } + +#[test] +fn fuzzed_unicode_slice() { + let d = "{eeuuu{b&{!!&{!!11{{ + 0!(!1q҄א!)!!!!!!n!"; + as...
Fuzzing askama_parser results in panic Hi, fuzzing `askama_parser` resulted in panic at following line. https://github.com/djc/askama/blob/43e92aa3b6b9cd967a70bd0fd54d1f087d6ed76b/askama_parser/src/expr.rs#L290 I suppose it happens because crash input contains Cyrillic letters which are multi-byte and we need exact b...
4dab5f91ba15e7c238ddf6223ec7b45eef32cab4
[ "tests::fuzzed_unicode_slice" ]
[ "tests::change_delimiters_parse_filter", "tests::test_parse_const", "tests::test_parse_var_call", "tests::test_parse_path_call", "tests::test_ws_splitter", "tests::test_parse_numbers", "tests::test_associativity", "tests::test_parse_var", "tests::test_parse_comments", "tests::test_parse_root_path"...
[]
[]
96a4a46586aa10f2bebc6b892e7dc43d764a9999
diff --git a/askama_derive/Cargo.toml b/askama_derive/Cargo.toml --- a/askama_derive/Cargo.toml +++ b/askama_derive/Cargo.toml @@ -25,7 +25,7 @@ with-rocket = [] with-warp = [] [dependencies] -parser = { package = "askama_parser", version = "0.3", path = "../askama_parser" } +parser = { package = "askama_parser", v...
rinja-rs__askama-1095
1,095
[ "1081" ]
0.13
rinja-rs/askama
2024-09-19T08:12:12Z
diff --git a/askama_derive/src/config.rs b/askama_derive/src/config.rs --- a/askama_derive/src/config.rs +++ b/askama_derive/src/config.rs @@ -486,7 +490,7 @@ mod tests { let config = Config::new(raw_config, None); assert_eq!( config.unwrap_err().msg, - r#"delimiters must be at...
Template parsing issues when using double angle brackets as delimiters With `expr` delimiters `<<` and `>>`, trying to use the template `<<a>> and <<b>>` complains about `and` not being a field. Here is a full example that produces the error "no field `and` on type `&HelloTemplate`": ```toml [[syntax]] name = "mwe" ...
53b4b518f9a230665029560df038c318b2e55458
[ "config::tests::illegal_delimiters" ]
[ "config::tests::add_syntax_two", "config::tests::add_syntax", "config::tests::duplicated_syntax_name_on_list - should panic", "config::tests::find_absolute", "config::tests::find_relative", "config::tests::find_relative_nonexistent - should panic", "config::tests::find_relative_sub", "config::tests::g...
[ "config::tests::escape_modes", "tests::check_if_let" ]
[]
b14982f97ffd20039286171d56e6fcfab21f56bc
diff --git a/askama_shared/src/filters/mod.rs b/askama_shared/src/filters/mod.rs --- a/askama_shared/src/filters/mod.rs +++ b/askama_shared/src/filters/mod.rs @@ -330,20 +330,14 @@ where /// Capitalize a value. The first character will be uppercase, all others lowercase. pub fn capitalize<T: fmt::Display>(s: T) -> ...
rinja-rs__askama-652
652
This custom filter does what i expected capitalize to do. ```rust mod filters { pub fn cap(s: &str) -> ::askama::Result<String> { match s.chars().next() { Some(c) => { if c.is_lowercase() { let mut replacement: String = c.to_uppercase().collect(); ...
[ "651" ]
0.11
rinja-rs/askama
2022-03-26T15:32:24Z
diff --git a/askama_shared/src/filters/mod.rs b/askama_shared/src/filters/mod.rs --- a/askama_shared/src/filters/mod.rs +++ b/askama_shared/src/filters/mod.rs @@ -655,6 +649,9 @@ mod tests { assert_eq!(capitalize(&"").unwrap(), "".to_string()); assert_eq!(capitalize(&"FoO").unwrap(), "Foo".to_string()...
Capitalize does not work with non ascii chars Capitalize filter only works with ascii chars not chars like å, ä and ö.
7b6f1df433a7f11612608644342b898cd6be8ff5
[ "filters::tests::test_capitalize" ]
[ "filters::tests::test_abs", "filters::json::tests::test_json", "filters::tests::test_center", "filters::tests::test_filesizeformat", "filters::tests::test_into_f64", "filters::tests::test_indent", "filters::tests::test_into_isize", "filters::tests::test_join", "filters::tests::test_linebreaks", "f...
[ "filters::yaml::tests::test_yaml" ]
[]