repo string | pull_number int64 | instance_id string | issue_numbers list | base_commit string | patch string | test_patch string | problem_statement string | hints_text string | created_at string | version string | updated_at string | environment_setup_commit string | FAIL_TO_PASS list | PASS_TO_PASS list | FAIL_TO_FAIL list | PASS_TO_FAIL list | source_dir string |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
dtolnay/async-trait | 90 | dtolnay__async-trait-90 | [
"89"
] | 05c24928d08c46ee1a916b1dff7f6dd389b21c94 | diff --git a/src/expand.rs b/src/expand.rs
--- a/src/expand.rs
+++ b/src/expand.rs
@@ -342,8 +342,17 @@ fn transform_block(
};
}
Context::Impl { receiver, .. } => {
+ let mut ty = quote!(#receiver);
+ if let Type::TraitObject(t... | diff --git a/tests/test.rs b/tests/test.rs
--- a/tests/test.rs
+++ b/tests/test.rs
@@ -622,3 +622,30 @@ pub mod issue87 {
}
}
}
+
+// https://github.com/dtolnay/async-trait/issues/89
+pub mod issue89 {
+ #![allow(bare_trait_objects)]
+
+ use async_trait::async_trait;
+
+ #[async_trait]
+ trai... | Forgetting "dyn" before Fn() + Trait causes panic
In non-async-trait code, this is currently legal, though it emits a warning that it should have the `dyn` keyword:
```
impl<F> Foo for Fn(i8) -> F + Send + Sync
where F: ... {}
```
In async-trait code, this causes a panic:
```
#[async_trait::async_trait]
i... | 2020-04-07T03:09:00Z | 0.1 | 2020-04-07T03:12:34Z | f8e5bb43181450a17068f160e8a51d410ede1705 | [
"src/lib.rs - (line 10)",
"src/lib.rs - (line 160)",
"src/lib.rs - (line 121)",
"src/lib.rs - (line 281)",
"src/lib.rs - (line 181)",
"src/lib.rs - (line 260)",
"src/lib.rs - (line 42)",
"src/lib.rs - (line 206)"
] | [] | [] | [] | auto_2025-06-06 | |
dtolnay/async-trait | 160 | dtolnay__async-trait-160 | [
"158"
] | 6bff4e0c5935b30b4d5af42bb06d9972866c752d | diff --git a/src/receiver.rs b/src/receiver.rs
--- a/src/receiver.rs
+++ b/src/receiver.rs
@@ -2,7 +2,7 @@ use proc_macro2::{Group, Span, TokenStream, TokenTree};
use std::iter::FromIterator;
use syn::visit_mut::{self, VisitMut};
use syn::{
- Block, ExprPath, Ident, Item, Macro, Pat, PatIdent, PatPath, Receiver, ... | diff --git a/tests/test.rs b/tests/test.rs
--- a/tests/test.rs
+++ b/tests/test.rs
@@ -1321,3 +1321,17 @@ pub mod issue154 {
}
}
}
+
+// https://github.com/dtolnay/async-trait/issues/158
+pub mod issue158 {
+ use async_trait::async_trait;
+
+ fn f() {}
+
+ #[async_trait]
+ pub trait Trait {
+... | Failed to resolve `self` in path
Macro doesn't handle when `self` is used as path.
```rust
use async_trait::async_trait; // 0.1.48
fn bar() {}
#[async_trait]
trait Foo {
async fn bar(&self) {
self::bar()
}
}
```
```rust
error[E0433]: failed to resolve: use of undeclared crate or module `... | 2021-04-14T06:06:02Z | 0.1 | 2021-04-14T06:09:19Z | f8e5bb43181450a17068f160e8a51d410ede1705 | [
"drop_order::test_drop_order",
"issue45::tracing",
"src/lib.rs - (line 15)",
"src/lib.rs - (line 165)",
"src/lib.rs - (line 126)",
"src/lib.rs - (line 186)",
"src/lib.rs - (line 286)",
"src/lib.rs - (line 265)",
"src/lib.rs - (line 47)",
"src/lib.rs - (line 211)"
] | [] | [] | [] | auto_2025-06-06 | |
dtolnay/async-trait | 150 | dtolnay__async-trait-150 | [
"149"
] | 2c4cde7ce826c77fe08a8f67d6fdc47b023adf0f | diff --git a/src/expand.rs b/src/expand.rs
--- a/src/expand.rs
+++ b/src/expand.rs
@@ -350,6 +350,9 @@ fn transform_block(sig: &mut Signature, block: &mut Block) {
let _: () = { #(#decls)* #(#stmts)* };
},
ReturnType::Type(_, ret) => quote_spanned! {block.brace_token.span=>
+ i... | diff --git a/tests/test.rs b/tests/test.rs
--- a/tests/test.rs
+++ b/tests/test.rs
@@ -1258,3 +1258,23 @@ pub mod issue147 {
}
}
}
+
+// https://github.com/dtolnay/async-trait/issues/149
+pub mod issue149 {
+ use async_trait::async_trait;
+
+ pub struct Thing;
+ pub trait Ret {}
+ impl Ret fo... | Unsize coercion fails if end of method is unreachable
The following async trait fails to compile. Notice that the same method body is fine in an ordinary async fn outside of an async trait.
This worked prior to #143.
```rust
use async_trait::async_trait;
struct Thing;
trait Ret {}
impl Ret for Thing {}
a... | 2021-03-07T05:06:30Z | 0.1 | 2021-03-07T05:12:13Z | f8e5bb43181450a17068f160e8a51d410ede1705 | [
"issue45::tracing",
"drop_order::test_drop_order",
"src/lib.rs - (line 15)",
"src/lib.rs - (line 165)",
"src/lib.rs - (line 286)",
"src/lib.rs - (line 211)",
"src/lib.rs - (line 186)",
"src/lib.rs - (line 47)",
"src/lib.rs - (line 265)",
"src/lib.rs - (line 126)"
] | [] | [] | [] | auto_2025-06-06 | |
dtolnay/async-trait | 227 | dtolnay__async-trait-227 | [
"226"
] | 6050c94ca7be287be1657fcefd299165e39c7ef2 | diff --git a/src/expand.rs b/src/expand.rs
--- a/src/expand.rs
+++ b/src/expand.rs
@@ -362,6 +362,12 @@ fn transform_block(context: Context, sig: &mut Signature, block: &mut Block) {
quote!(let #mutability #ident = #self_token;)
}
FnArg::Typed(arg) => {
+ // If ... | diff --git a/tests/test.rs b/tests/test.rs
--- a/tests/test.rs
+++ b/tests/test.rs
@@ -54,6 +54,10 @@ trait Trait {
async fn calls_mut(&mut self) {
self.selfmut().await;
}
+
+ async fn cfg_param(&self, param: u8);
+ async fn cfg_param_wildcard(&self, _: u8);
+ async fn cfg_param_tuple(&self,... | Attributes on impl parameters are not forwarded to body
Heya, I was implementing a trait function with `#[cfg(..)]` in its parameters, and encountered the following error:
```rust
// within trait impl
async fn cfg_param(
&self,
#[cfg(not(feature = "something"))] param: u8,
#[cfg(feature = "something... | 2023-01-06T01:44:31Z | 0.1 | 2023-01-06T22:57:17Z | f8e5bb43181450a17068f160e8a51d410ede1705 | [
"drop_order::test_drop_order",
"issue199::test",
"issue45::tracing",
"src/lib.rs - (line 15) - compile fail",
"src/lib.rs - (line 165) - compile fail",
"src/lib.rs - (line 126)",
"src/lib.rs - (line 186)",
"src/lib.rs - (line 265)",
"src/lib.rs - (line 286)",
"src/lib.rs - (line 47)",
"src/lib.r... | [] | [] | [] | auto_2025-06-06 | |
dtolnay/async-trait | 223 | dtolnay__async-trait-223 | [
"210"
] | 9ed6489ee0cedf31fef8a06a1dcd1f18b4afdd39 | diff --git a/src/expand.rs b/src/expand.rs
--- a/src/expand.rs
+++ b/src/expand.rs
@@ -9,9 +9,9 @@ use std::mem;
use syn::punctuated::Punctuated;
use syn::visit_mut::{self, VisitMut};
use syn::{
- parse_quote, parse_quote_spanned, Attribute, Block, FnArg, GenericParam, Generics, Ident,
- ImplItem, Lifetime, Li... | diff --git a/tests/test.rs b/tests/test.rs
--- a/tests/test.rs
+++ b/tests/test.rs
@@ -1450,3 +1450,14 @@ pub mod issue204 {
async fn g(arg: *const impl Trait);
}
}
+
+// https://github.com/dtolnay/async-trait/issues/210
+pub mod issue210 {
+ use async_trait::async_trait;
+ use std::sync::Arc;
+
+ ... | Defaulted method with `self: Arc<Self>` doesn't work
`Arc` generates a `where Self: Send` bound, but for `Arc` it is not enough - it requires also `T: Sync` to be `Send`. This make the following code failing to compile:
```rust
#[async_trait]
trait Trait {
async fn foo(self: Arc<Self>) {}
}
```
https://play... | 2022-11-29T08:05:19Z | 0.1 | 2022-11-29T08:11:36Z | f8e5bb43181450a17068f160e8a51d410ede1705 | [
"drop_order::test_drop_order",
"issue199::test",
"issue45::tracing",
"src/lib.rs - (line 165) - compile fail",
"src/lib.rs - (line 15) - compile fail",
"src/lib.rs - (line 126)",
"src/lib.rs - (line 286)",
"src/lib.rs - (line 265)",
"src/lib.rs - (line 186)",
"src/lib.rs - (line 47)",
"src/lib.r... | [] | [] | [] | auto_2025-06-06 | |
dtolnay/async-trait | 201 | dtolnay__async-trait-201 | [
"177"
] | 9a323ed6dad1dfc651147814d4d418cf09d6e17b | diff --git a/Cargo.toml b/Cargo.toml
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -17,7 +17,7 @@ proc-macro = true
[dependencies]
proc-macro2 = "1.0"
quote = "1.0"
-syn = { version = "1.0.84", features = ["full", "visit-mut"] }
+syn = { version = "1.0.96", features = ["full", "visit-mut"] }
[dev-dependencies]
futures = ... | diff --git a/tests/test.rs b/tests/test.rs
--- a/tests/test.rs
+++ b/tests/test.rs
@@ -1374,6 +1374,23 @@ pub mod issue169 {
pub fn test(_t: &dyn Trait) {}
}
+// https://github.com/dtolnay/async-trait/issues/177
+pub mod issue177 {
+ use async_trait::async_trait;
+
+ #[async_trait]
+ pub trait Trait {
... | Lifetime issue when using "impl FnMut" as argument type
**Case 1:**
```rust
async fn foo(&self, mut callback: impl FnMut(&str) + Send)
```
expands to:
```rust
fn foo<'life0, 'life1, 'async_trait>(
&'life0 self,
callback: impl FnMut(&'life1 str) + Send,
) -> ::core::pin::Pin<
B... | I would accept a PR to support this as suggested in the forum thread (`callback: impl 'async_trait + FnMut(&str) + Send`). | 2022-06-02T20:27:22Z | 0.1 | 2022-06-02T20:33:38Z | f8e5bb43181450a17068f160e8a51d410ede1705 | [
"drop_order::test_drop_order",
"issue45::tracing",
"src/lib.rs - (line 15) - compile fail",
"src/lib.rs - (line 165) - compile fail",
"src/lib.rs - (line 126)",
"src/lib.rs - (line 186)",
"src/lib.rs - (line 286)",
"src/lib.rs - (line 265)",
"src/lib.rs - (line 47)",
"src/lib.rs - (line 211)"
] | [] | [] | [] | auto_2025-06-06 |
dtolnay/async-trait | 143 | dtolnay__async-trait-143 | [
"126"
] | c490ccdd4d81ea19523f47bd48f8a384f3026375 | diff --git a/Cargo.toml b/Cargo.toml
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -24,5 +24,8 @@ tracing-attributes = "0.1.8"
tracing-futures = "0.2"
trybuild = { version = "1.0.19", features = ["diff"] }
+[build-dependencies]
+version_check = "0.9"
+
[package.metadata.docs.rs]
targets = ["x86_64-unknown-linux-gnu"]
diff... | diff --git a/tests/executor/mod.rs b/tests/executor/mod.rs
--- a/tests/executor/mod.rs
+++ b/tests/executor/mod.rs
@@ -4,6 +4,7 @@ use std::ptr;
use std::task::{Context, Poll, RawWaker, RawWakerVTable, Waker};
// Executor for a future that resolves immediately (test only).
+#[allow(clippy::missing_panics_doc)]
pub... | default impl for methods with `impl trait` arguments?
Given the code:
```
use async_trait::async_trait; // 0.1.36
use tokio; // 0.2.21
#[async_trait]
trait MyTrait {
async fn blah(&self, values: impl Iterator<Item = i32> + Send + 'async_trait) {
println!("this is the default");
}
}
struct ... | Looks like the expanded code is: (cleaned up a little)
```
trait MyTrait {
#[must_use]
fn blah<'life0, 'async_trait>(&'life0 self, values: impl Iterator<Item = i32> + Send + 'async_trait)
-> Pin<Box<dyn Future<Output = ()> + Send + 'async_trait>>
where 'life0: 'async_trait,
... | 2021-02-03T06:12:37Z | 0.1 | 2021-03-05T05:09:49Z | f8e5bb43181450a17068f160e8a51d410ede1705 | [
"issue45::tracing"
] | [
"drop_order::test_drop_order",
"src/lib.rs - (line 15)",
"src/lib.rs - (line 165)",
"src/lib.rs - (line 186)",
"src/lib.rs - (line 286)",
"src/lib.rs - (line 126)",
"src/lib.rs - (line 211)",
"src/lib.rs - (line 47)",
"src/lib.rs - (line 265)"
] | [] | [] | auto_2025-06-06 |
atuinsh/atuin | 71 | atuinsh__atuin-71 | [
"66"
] | 725ea9b16b1e3596b394fa7e47e02a9331de10cf | diff --git a/atuin-client/src/import/bash.rs b/atuin-client/src/import/bash.rs
--- a/atuin-client/src/import/bash.rs
+++ b/atuin-client/src/import/bash.rs
@@ -1,63 +1,77 @@
-use std::io::{BufRead, BufReader};
-use std::{fs::File, path::Path};
+use std::{
+ fs::File,
+ io::{BufRead, BufReader, Read, Seek},
+ pa... | diff --git a/atuin-client/src/import/bash.rs b/atuin-client/src/import/bash.rs
--- a/atuin-client/src/import/bash.rs
+++ b/atuin-client/src/import/bash.rs
@@ -76,4 +90,45 @@ impl Iterator for Bash {
None,
)))
}
+
+ fn size_hint(&self) -> (usize, Option<usize>) {
+ (0, Some(self.loc)... | Very long history import time with 132k line zsh history file
About 17 hours ago (!), I ran `atuin import zsh`, with `$HISTFILE` set to `$HOME/.zshrc`. My history file has 132,450 raw lines (115,029 actual entries, because of multiline commands). Each command has the timestamp (e.g. 1600602281) and the run duration i... | Wow I hadn't tested on anything quite that large :O Though I have about 15k and it's done in a few seconds, so it shouldn't be taking that long :thinking:
Firstly, you have the ZSH extended history format. It has to be parsed, but that shouldn't be slowing things down in an actually noticeable way. The "strange text... | 2021-05-08T17:42:54Z | 0.6 | 2021-05-09T17:34:55Z | 725ea9b16b1e3596b394fa7e47e02a9331de10cf | [
"encryption::test::test_encrypt_decrypt",
"import::zsh::test::test_parse_extended_simple"
] | [] | [] | [] | auto_2025-06-06 |
atuinsh/atuin | 747 | atuinsh__atuin-747 | [
"745"
] | d46e3ad47d03e53232269973806fb9da2248ba19 | diff --git a/atuin-client/src/import/bash.rs b/atuin-client/src/import/bash.rs
--- a/atuin-client/src/import/bash.rs
+++ b/atuin-client/src/import/bash.rs
@@ -1,8 +1,10 @@
-use std::{fs::File, io::Read, path::PathBuf};
+use std::{fs::File, io::Read, path::PathBuf, str};
use async_trait::async_trait;
+use chrono::{Da... | diff --git a/atuin-client/src/import/bash.rs b/atuin-client/src/import/bash.rs
--- a/atuin-client/src/import/bash.rs
+++ b/atuin-client/src/import/bash.rs
@@ -70,18 +89,47 @@ impl Importer for Bash {
}
}
+#[derive(Debug, Clone)]
+enum LineType<'a> {
+ NotUtf8,
+ /// A timestamp line start with a '#', foll... | Bash history import issues
I spotted two issues while trying to import my Bash history:
1. Import ordering is incorrectly reversed.
2. `.bash_history` can be configured to store timestamps, a case not handled.
---
## Ordering
In the following snippet, lines from the top of the file will receive the newest ... | 2023-03-01T16:30:56Z | 13.0 | 2023-04-05T15:22:17Z | edcd477153d00944c5dae16ec3ba69e339e1450c | [
"encryption::test::test_encrypt_decrypt",
"import::zsh::test::test_parse_extended_simple",
"import::zsh::test::test_parse_file",
"import::fish::test::parse_complex",
"import::zsh_histdb::test::test_env_vars",
"import::zsh_histdb::test::test_import",
"database::test::test_search_prefix",
"database::tes... | [] | [] | [] | auto_2025-06-06 | |
atuinsh/atuin | 1,238 | atuinsh__atuin-1238 | [
"691"
] | 15abf429842969e56598b1922a21693a7253f117 | diff --git a/atuin-client/src/api_client.rs b/atuin-client/src/api_client.rs
--- a/atuin-client/src/api_client.rs
+++ b/atuin-client/src/api_client.rs
@@ -1,5 +1,6 @@
use std::collections::HashMap;
use std::env;
+use std::time::Duration;
use eyre::{bail, Result};
use reqwest::{
diff --git a/atuin-client/src/api_c... | diff --git a/atuin-client/src/api_client.rs b/atuin-client/src/api_client.rs
--- a/atuin-client/src/api_client.rs
+++ b/atuin-client/src/api_client.rs
@@ -106,7 +107,12 @@ pub async fn latest_version() -> Result<Version> {
}
impl<'a> Client<'a> {
- pub fn new(sync_addr: &'a str, session_token: &'a str) -> Result... | atuin hangs at first start in bad network environments
This issue can be reproduced with the following preconditions:
- a really (as in awfully) bad network environment with a rather large-ish (>=98%) packet loss rate
- using atuin to browse the history the first time after boot
Atuin hangs for an indefinite amo... | Thanks for the report. I reckon I can rewrite this part to get the version lazily
https://user-images.githubusercontent.com/6625462/216926816-fd536a1c-8f35-4a89-b097-8224638960bd.mov
There we go :)
This issue is sort of fixed but there's a related problem. There were 2 issues here:
1. Atuin _was_ blocking on that... | 2023-09-17T17:26:20Z | 16.0 | 2023-09-18T07:39:20Z | 1735be05d71ec21ffb8648866fca83e210cfe31a | [
"encryption::test::test_decode_old",
"encryption::test::test_decode",
"encryption::test::key_encodings",
"encryption::test::test_decode_deleted",
"encryption::test::test_encrypt_decrypt",
"kv::tests::encode_decode",
"import::zsh::test::test_parse_extended_simple",
"import::bash::test::parse_with_parti... | [] | [] | [] | auto_2025-06-06 |
atuinsh/atuin | 2,200 | atuinsh__atuin-2200 | [
"2199"
] | a223fcb718101ad10d54ce92857472b2a88a8c48 | diff --git a/CHANGELOG.md b/CHANGELOG.md
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,6 +18,7 @@ All notable changes to this project will be documented in this file.
### Features
+- *(client)* Identify several other GitHub token types as secrets
- *(daemon)* Follow XDG_RUNTIME_DIR if set ([#2171](https://github.... | diff --git a/crates/atuin-client/src/secrets.rs b/crates/atuin-client/src/secrets.rs
--- a/crates/atuin-client/src/secrets.rs
+++ b/crates/atuin-client/src/secrets.rs
@@ -1,76 +1,109 @@
// This file will probably trigger a lot of scanners. Sorry.
+pub enum TestValue<'a> {
+ Single(&'a str),
+ Multiple(&'a [&'a... | Expand on the set of GitHub tokens that Atuin will consider secrets
GitHub has multiple token types, not just PATs. It'd be a good idea to filter those out, as well.
| 2024-06-25T17:57:31Z | 0.3 | 2024-06-25T20:24:32Z | 6e15286f0c94b89d4c5f9b8fa1e9a72cd209017c | [
"record::sqlite_store::tests::create_db",
"kv::tests::build_kv",
"record::sqlite_store::tests::len_tag",
"record::sqlite_store::tests::push_record",
"record::sqlite_store::tests::len",
"record::sqlite_store::tests::get_record",
"record::sqlite_store::tests::first",
"record::sqlite_store::tests::len_di... | [
"encryption::test::test_decode",
"encryption::test::test_decode_deleted",
"encryption::test::key_encodings",
"encryption::test::test_decode_old",
"history::store::tests::test_serialize_deserialize_delete",
"history::store::tests::test_serialize_deserialize_create",
"history::tests::test_serialize_deseri... | [] | [] | auto_2025-06-06 | |
atuinsh/atuin | 1,590 | atuinsh__atuin-1590 | [
"1503"
] | 10f465da8ff113819d435b0f8e5066783c5100af | diff --git a/atuin-client/config.toml b/atuin-client/config.toml
--- a/atuin-client/config.toml
+++ b/atuin-client/config.toml
@@ -134,6 +134,12 @@ enter_accept = true
## the specified one.
# keymap_mode = "auto"
+# network_connect_timeout = 5
+# network_timeout = 5
+
+## Timeout (in seconds) for acquiring a local ... | diff --git a/atuin-client/src/database.rs b/atuin-client/src/database.rs
--- a/atuin-client/src/database.rs
+++ b/atuin-client/src/database.rs
@@ -786,7 +790,7 @@ mod test {
#[tokio::test(flavor = "multi_thread")]
async fn test_search_prefix() {
- let mut db = Sqlite::new("sqlite::memory:").await.unw... | atuin makes the shell unresponsive under high I/O pressure
Hi!
Under high I/O pressure on my system, atuin makes my shell hang for a long period, then fail with this error:
```
Error: pool timed out while waiting for an open connection
Location:
atuin/src/command/client.rs:50:22
```
or
```
Error: error r... | Sure that makes sense to me! We'd have to ensure that `atuin history end` doesn't break after an aborted `atuin history start`, but otherwise sounds good
Just a small question, did you find a way to "unlock" the shell ? After it's locked, how do you restore the system to a state where it responds to terminal comman... | 2024-01-19T15:34:48Z | 17.2 | 2024-01-21T13:24:00Z | 4b20544474088259c580faa015876cb535dbff36 | [
"encryption::test::key_encodings",
"encryption::test::test_decode_old",
"history::store::tests::test_serialize_deserialize_delete",
"encryption::test::test_decode",
"encryption::test::test_decode_deleted",
"history::store::tests::test_serialize_deserialize_create",
"history::tests::test_serialize_deseri... | [] | [] | [] | auto_2025-06-06 |
atuinsh/atuin | 1,296 | atuinsh__atuin-1296 | [
"854"
] | a60d8934c5dfcf0679dfa5f4de5c2080dfd32a5f | diff --git a/atuin-client/src/database.rs b/atuin-client/src/database.rs
--- a/atuin-client/src/database.rs
+++ b/atuin-client/src/database.rs
@@ -18,6 +18,8 @@ use sqlx::{
};
use time::OffsetDateTime;
+use crate::history::HistoryStats;
+
use super::{
history::History,
ordering,
diff --git a/atuin-client... | diff --git a/atuin-client/src/database.rs b/atuin-client/src/database.rs
--- a/atuin-client/src/database.rs
+++ b/atuin-client/src/database.rs
@@ -562,6 +566,123 @@ impl Database for Sqlite {
Ok(())
}
+
+ async fn stats(&self, h: &History) -> Result<HistoryStats> {
+ // We select the previous ... | Interactive deletion
``atuin search --delete -i`` should work as an interactive deletion.
Right now the ``--delete`` argument is ingored.
| From my user's point of view: As it was a bit complicated to implement the deletion feature (because atuin can sync the history over systems) it was very important to implement it at all and thus to be able to use it from the command line.
So, I guess that interactive deletion will be implemented finally but it may ... | 2023-10-08T19:14:21Z | 17.2 | 2024-01-12T16:02:09Z | 4b20544474088259c580faa015876cb535dbff36 | [
"encryption::test::key_encodings",
"encryption::test::test_decode_old",
"encryption::test::test_decode",
"history::store::tests::test_serialize_deserialize_create",
"encryption::test::test_decode_deleted",
"history::store::tests::test_serialize_deserialize_delete",
"history::tests::test_serialize_deseri... | [] | [] | [] | auto_2025-06-06 |
atuinsh/atuin | 2,058 | atuinsh__atuin-2058 | [
"1882"
] | 4d74e38a515bc14381e1342afdf5ee2ec345f589 | diff --git a/crates/atuin-history/src/stats.rs b/crates/atuin-history/src/stats.rs
--- a/crates/atuin-history/src/stats.rs
+++ b/crates/atuin-history/src/stats.rs
@@ -92,7 +92,7 @@ fn split_at_pipe(command: &str) -> Vec<&str> {
"\\" => if graphemes.next().is_some() {},
"|" => {
... | diff --git a/crates/atuin-history/src/stats.rs b/crates/atuin-history/src/stats.rs
--- a/crates/atuin-history/src/stats.rs
+++ b/crates/atuin-history/src/stats.rs
@@ -396,4 +396,20 @@ mod tests {
["git commit -m \"🚀\""]
);
}
+
+ #[test]
+ fn starts_with_pipe() {
+ assert_eq!(
+ ... | [Bug]: atuin stats panics when faced with unusual string in history
### What did you expect to happen?
No panic! ;]
### What happened?
When running `atuin stats` it panics with:
```
❯ RUST_BACKTRACE=1 atuin stats
thread 'main' panicked at atuin/src/command/client/stats.rs:56:41:
begin <= end (1 <= 0) when slic... | seconding this- here's another fun string this happens with.
```console
$ RUST_BACKTRACE=1 atuin stats
thread 'main' panicked at atuin/src/command/client/stats.rs:56:41:
begin <= end (1 <= 0) when slicing `|_| |____||___||_| |_| |___||_|_`
stack backtrace:
0: 0x1054a29d0 - <std::sys_common::backtrace... | 2024-05-30T14:26:22Z | 18.2 | 2024-05-30T14:58:06Z | 4d74e38a515bc14381e1342afdf5ee2ec345f589 | [
"stats::tests::starts_with_pipe"
] | [
"stats::tests::escaped_pipes",
"stats::tests::interesting_commands_spaces",
"stats::tests::split_multi_quoted",
"stats::tests::starts_with_spaces_and_pipe",
"stats::tests::interesting_commands",
"stats::tests::split_simple_quoted",
"stats::tests::split_multi",
"stats::tests::split_simple",
"stats::t... | [] | [] | auto_2025-06-06 |
atuinsh/atuin | 1,739 | atuinsh__atuin-1739 | [
"1054"
] | 2a65f89cd54b8b8187240a1fdc288867b35f6b01 | diff --git a/Cargo.lock b/Cargo.lock
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -217,6 +217,7 @@ dependencies = [
"tracing",
"tracing-subscriber",
"tracing-tree",
+ "unicode-segmentation",
"unicode-width",
"uuid",
"whoami",
diff --git a/Cargo.lock b/Cargo.lock
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3937,9 +3938,9 ... | diff --git a/atuin/src/command/client/stats.rs b/atuin/src/command/client/stats.rs
--- a/atuin/src/command/client/stats.rs
+++ b/atuin/src/command/client/stats.rs
@@ -189,7 +266,7 @@ mod tests {
use time::OffsetDateTime;
use super::compute_stats;
- use super::interesting_command;
+ use super::{interes... | Enable multiple command stats to be shown
These changes extend the `stats` subcommand with an `--ngram-size` argument, which supports providing statistics for combinations of commands. I have found this useful for identifying the most common combinations of commands as candidates for further automation.
| 2024-02-20T05:51:10Z | 18.0 | 2024-02-27T19:41:41Z | 2a65f89cd54b8b8187240a1fdc288867b35f6b01 | [
"command::client::search::cursor::cursor_tests::back",
"command::client::search::cursor::cursor_tests::left",
"command::client::search::cursor::cursor_tests::pop",
"command::client::stats::tests::interesting_commands",
"command::client::search::cursor::cursor_tests::test_emacs_get_prev_word_pos",
"command... | [] | [] | [] | auto_2025-06-06 | |
atuinsh/atuin | 1,722 | atuinsh__atuin-1722 | [
"1714"
] | 063d9054d74c0c44781507eed27378415ab9fef5 | diff --git a/atuin-client/config.toml b/atuin-client/config.toml
--- a/atuin-client/config.toml
+++ b/atuin-client/config.toml
@@ -171,3 +171,6 @@ enter_accept = true
## Set commands that should be totally stripped and ignored from stats
#common_prefix = ["sudo"]
+
+## Set commands that will be completely ignored f... | diff --git a/atuin/src/command/client/stats.rs b/atuin/src/command/client/stats.rs
--- a/atuin/src/command/client/stats.rs
+++ b/atuin/src/command/client/stats.rs
@@ -176,10 +184,36 @@ fn interesting_command<'a>(settings: &Settings, mut command: &'a str) -> &'a str
#[cfg(test)]
mod tests {
+ use atuin_client::hi... | `ignore_commands` option for stats
Would you be open to having an `ignore_commands` option for `atuin stats`? `cd`, `ls`, and `vi` are my three top commands by nearly an order of and I don't find this particularly informative; I'd be interested in filtering these out entirely from my stats.
If you're interested in... | I'd be interested!
Otherwise, you can see more commands with the -c arg, if you find them a waste of space
eg
`atuin stats -c 100` will show the top 100, rather than top 10
OK I will see how hard this is and take a stab at a PR.
The issue is not so much a waste of space, but that it makes the histogram kin... | 2024-02-14T17:42:21Z | 18.0 | 2024-02-15T18:52:19Z | 2a65f89cd54b8b8187240a1fdc288867b35f6b01 | [
"command::client::search::cursor::cursor_tests::test_emacs_get_next_word_pos",
"command::client::search::cursor::cursor_tests::test_subl_get_prev_word_pos",
"command::client::search::cursor::cursor_tests::right",
"command::client::search::cursor::cursor_tests::pop",
"command::client::search::cursor::cursor_... | [] | [] | [] | auto_2025-06-06 |
atuinsh/atuin | 791 | atuinsh__atuin-791 | [
"592"
] | edcd477153d00944c5dae16ec3ba69e339e1450c | diff --git a/.mailmap b/.mailmap
--- a/.mailmap
+++ b/.mailmap
@@ -1,1 +1,2 @@
networkException <git@nwex.de> <github@nwex.de>
+Violet Shreve <github@shreve.io> <jacob@shreve.io>
diff --git /dev/null b/atuin-client/migrations/20230315220114_drop-events.sql
new file mode 100644
--- /dev/null
+++ b/atuin-client/migratio... | diff --git a/atuin-client/src/database.rs b/atuin-client/src/database.rs
--- a/atuin-client/src/database.rs
+++ b/atuin-client/src/database.rs
@@ -528,6 +473,18 @@ impl Database for Sqlite {
Ok(res)
}
+
+ // deleted_at doesn't mean the actual time that the user deleted it,
+ // but the time that t... | Deleting history
So this has been proposed for a [super long time](https://github.com/ellie/atuin/issues/70).
It's taken a while, partly because deletion with sync is difficult. Deleting on one machine would result in it coming back the next time a sync happens, so we need to ensure deletion across all machines
I... | Just merged the first part of this!
https://github.com/ellie/atuin/pull/390
You _should_ see a new table created locally + tracking events
> I'd like this to be smooth, obvious, and not some arbitrary key combination. But also not easy to do by accident!
I'd personally love it if I could just highlight the ent... | 2023-03-19T20:49:53Z | 13.0 | 2023-03-20T09:26:56Z | edcd477153d00944c5dae16ec3ba69e339e1450c | [
"import::bash::test::parse_no_timestamps",
"import::bash::test::parse_with_timestamps",
"import::zsh::test::test_parse_extended_simple",
"import::fish::test::parse_complex",
"encryption::test::test_encrypt_decrypt",
"import::zsh::test::test_parse_file",
"import::bash::test::parse_with_partial_timestamps... | [] | [] | [] | auto_2025-06-06 |
atuinsh/atuin | 770 | atuinsh__atuin-770 | [
"768"
] | afd1113b3b0301795f3557feb94f7d7f953c5f9c | diff --git a/atuin-client/src/database.rs b/atuin-client/src/database.rs
--- a/atuin-client/src/database.rs
+++ b/atuin-client/src/database.rs
@@ -71,13 +71,19 @@ pub trait Database: Send + Sync {
async fn last(&self) -> Result<History>;
async fn before(&self, timestamp: chrono::DateTime<Utc>, count: i64) -> ... | diff --git a/atuin-client/src/database.rs b/atuin-client/src/database.rs
--- a/atuin-client/src/database.rs
+++ b/atuin-client/src/database.rs
@@ -498,7 +514,9 @@ mod test {
cwd: "/home/ellie".to_string(),
};
- let results = db.search(None, mode, filter_mode, &context, query).await?;
+ ... | bug(search): `limit` cant be used with `before` to search for results before a timestamp
`limit` is passed directly to `db.search` and `before` is applied in a `filter` after the results are fetched from the `db`.
I was trying to get the latest command run before a certain time, but I ended up getting 0 results back... | 2023-03-08T22:34:07Z | 13.0 | 2023-03-08T23:45:16Z | edcd477153d00944c5dae16ec3ba69e339e1450c | [
"encryption::test::test_encrypt_decrypt",
"import::zsh::test::test_parse_extended_simple",
"import::bash::test::parse_with_partial_timestamps",
"import::bash::test::parse_no_timestamps",
"import::bash::test::parse_with_timestamps",
"import::zsh::test::test_parse_file",
"import::fish::test::parse_complex... | [] | [] | [] | auto_2025-06-06 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.