repo stringclasses 1
value | pull_number int64 70 619 | instance_id stringlengths 17 18 | issue_numbers sequencelengths 1 1 | base_commit stringlengths 40 40 | patch stringlengths 341 89.2k | test_patch stringlengths 548 5.67k | problem_statement stringlengths 67 4.82k | hints_text stringlengths 0 4.86k | created_at stringlengths 20 20 | version stringclasses 2
values | environment_setup_commit stringclasses 2
values |
|---|---|---|---|---|---|---|---|---|---|---|---|
rust-lang/log | 619 | rust-lang__log-619 | [
"601"
] | 06c306fa8f4d41a722f8759f03effd4185eee3ee | diff --git a/Cargo.toml b/Cargo.toml
index c0ea52a77..72fcdb0e4 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -20,8 +20,8 @@ edition = "2021"
features = ["std", "serde", "kv_std", "kv_sval", "kv_serde"]
[[test]]
-name = "filters"
-path = "tests/filters.rs"
+name = "integration"
+path = "tests/integration.rs"
harness... | diff --git a/tests/filters.rs b/tests/integration.rs
similarity index 56%
rename from tests/filters.rs
rename to tests/integration.rs
index 3e0810d07..7bf456e02 100644
--- a/tests/filters.rs
+++ b/tests/integration.rs
@@ -12,7 +12,8 @@ fn set_boxed_logger(logger: Box<dyn Log>) -> Result<(), log::SetLoggerError> {
}
... | Add tests that check the line numbers
We currently don't have any.
| Im pretty new to contributing, but I would love to contribute to this repo. Would this be a good issue to start with?
> Im pretty new to contributing, but I would love to contribute to this repo. Would this be a good issue to start with?
Hey @DIvkov575 sorry for the delayed response, I've been traveling.
I think ... | 2024-03-16T14:49:52Z | 0.4 | 06c306fa8f4d41a722f8759f03effd4185eee3ee |
rust-lang/log | 613 | rust-lang__log-613 | [
"584"
] | 7cb6a01dff9157f3f3dca36aa0152f144023ff60 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 3fc335e73..3c263a434 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -44,10 +44,10 @@ jobs:
- run: cargo test --verbose --all-features
- run: cargo test --verbose --features serde
- run: cargo test --ve... | diff --git a/tests/Cargo.toml b/tests/Cargo.toml
index 88f37b5d4..8754bb16a 100644
--- a/tests/Cargo.toml
+++ b/tests/Cargo.toml
@@ -7,6 +7,10 @@ build = "src/build.rs"
[features]
std = ["log/std"]
+kv = ["log/kv"]
+kv_std = ["log/kv_std"]
+kv_sval = ["log/kv_sval"]
+kv_serde = ["log/kv_serde"]
[dependencies.log... | Review of key-value feature
Discussion for https://github.com/rust-lang/log/issues/328.
| Thanks for all the time you've spent digging through this so far @Thomasdezeeuw! I think we're getting towards something that feels appropriate for the `log` crate without losing capability.
Just checking back in on this, is the main blocker we've got deciding whether to default to capturing using `ToValue` and suppor... | 2024-01-26T08:08:39Z | 0.4 | 06c306fa8f4d41a722f8759f03effd4185eee3ee |
rust-lang/log | 495 | rust-lang__log-495 | [
"494"
] | bc181df9fbb1ad40abcae41ae2dd53b3652b50bc | diff --git a/src/macros.rs b/src/macros.rs
index ec2f4200c..a4fe6803b 100644
--- a/src/macros.rs
+++ b/src/macros.rs
@@ -37,7 +37,7 @@ macro_rules! log {
__log_format_args!($($arg)+),
lvl,
&($target, __log_module_path!(), __log_file!(), __log_line!()),
- ... | diff --git a/tests/macros.rs b/tests/macros.rs
index 7b2483ceb..fcd8556a3 100644
--- a/tests/macros.rs
+++ b/tests/macros.rs
@@ -215,3 +215,16 @@ fn kv_string_keys() {
all_log_macros!(target: "my_target", "also dogs" = "Fílos", "key/that-can't/be/an/ident" = "hi"; "hello {world}", world = "world");
}
+
+/// Som... | regression: enum variant named None fails to compile in 0.4.15
I have written some poker software where it makes sense (at least to me!) to have a `None` variant. When I upgraded to log 0.4.15, my code stopped compiling. Here's a short illustration:
```
#[derive(Debug)]
pub enum Limit {
None,
}
pub struct M... | It looks like this `None` (and the `Some` above it) needs to be fully qualified: https://github.com/rust-lang/log/blob/master/src/macros.rs#L53
@sfackler can you make a pr or want me to do it?
I can make one later today, but go for it if you have the time earlier. | 2022-03-22T13:01:36Z | 0.4 | 06c306fa8f4d41a722f8759f03effd4185eee3ee |
rust-lang/log | 470 | rust-lang__log-470 | [
"381"
] | 525336f364fb80b63d910e783884b14be71814c5 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index d90d48baa..855a2d965 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -37,6 +37,8 @@ jobs:
rustup update ${{ matrix.rust }} --no-self-update
rustup default ${{ matrix.rust }}
- run: cargo test --... | diff --git a/tests/filters.rs b/tests/filters.rs
index de6bd189f..f37751c24 100644
--- a/tests/filters.rs
+++ b/tests/filters.rs
@@ -1,3 +1,5 @@
+#![allow(dead_code, unused_imports)]
+
#[cfg(not(lib_build))]
#[macro_use]
extern crate log;
@@ -32,18 +34,36 @@ impl Log for Logger {
#[cfg_attr(lib_build, test)]
fn ... | `cargo test --all-features` fails
from git master, if i run `cargo test --all-features`, i see:
```
Finished dev [unoptimized + debuginfo] target(s) in 0.01s
Running target/debug/deps/log-7d6eb7ffa43b7118
running 45 tests
test kv::key::tests::key_from_string ... ok
test kv::source::std_support::tests... | Ah, unfortunately `log`'s features are set up in such a way that running with `--all-features` doesn't really make sense (it uses features to set minimum levels at compile-time). It's unfortunate for tests to fail though since `--all-features` should be a perfectly legitimate flag so we should do something about the fi... | 2021-11-15T06:58:10Z | 0.4 | 06c306fa8f4d41a722f8759f03effd4185eee3ee |
rust-lang/log | 423 | rust-lang__log-423 | [
"408"
] | cb0b8c4f93758531ef3eada40da2642e9ed0d616 | diff --git a/Cargo.toml b/Cargo.toml
index 69fe79d25..299937c3e 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -16,7 +16,7 @@ exclude = ["rfcs/**/*", "/.travis.yml", "/appveyor.yml"]
build = "build.rs"
[package.metadata.docs.rs]
-features = ["std", "serde", "kv_unstable_sval"]
+features = ["std", "serde", "kv_unstable... | diff --git a/src/kv/value/test.rs b/src/kv/value/test.rs
deleted file mode 100644
index ab5f8075e..000000000
--- a/src/kv/value/test.rs
+++ /dev/null
@@ -1,81 +0,0 @@
-// Test support for inspecting Values
-
-use std::fmt;
-use std::str;
-
-use super::internal;
-use super::{Error, Value};
-
-#[derive(Debug, PartialEq)]... | Support converting Errors into Values
There are some design decisions to make around `dyn Error` vs `dyn Error + 'static`, but I've been looking at providing a proper downcasting API too.
| 2020-11-11T03:25:19Z | 0.4 | 06c306fa8f4d41a722f8759f03effd4185eee3ee | |
rust-lang/log | 370 | rust-lang__log-370 | [
"369"
] | 87fc152d40f06623e109ead03cba0431da0e7f73 | "diff --git a/src/macros.rs b/src/macros.rs\nindex 23378fc5e..f628664b7 100644\n--- a/src/macros.rs\(...TRUNCATED) | "diff --git a/tests/macros.rs b/tests/macros.rs\nindex f41c52ed3..34c89811f 100644\n--- a/tests/macr(...TRUNCATED) | "0.4.9 release seems to break tokio (which depends on log)\nYou can see an example of this here: htt(...TRUNCATED) | "I am receiving similar errors trying to install cargo-make.\r\n\r\n```\r\n Compiling cargo-make v(...TRUNCATED) | 2019-12-16T00:11:28Z | 0.4 | 06c306fa8f4d41a722f8759f03effd4185eee3ee |
rust-lang/log | 245 | rust-lang__log-245 | [
"243"
] | 1e12cfa3b3ba2a1f1ed80588fd9ebfc3ba46065d | "diff --git a/src/lib.rs b/src/lib.rs\nindex feea3d326..50423604a 100644\n--- a/src/lib.rs\n+++ b/sr(...TRUNCATED) | "diff --git a/tests/filters.rs b/tests/filters.rs\nindex d28fa004e..84449ccfe 100644\n--- a/tests/fi(...TRUNCATED) | "Possibly removing closures from `set_*_logger` functions?\nAre the closures still needed any more? (...TRUNCATED) | "The closure-based indirection is there to make sure the active logger is the only thing that can me(...TRUNCATED) | 2017-12-06T04:54:16Z | 0.3 | 1e12cfa3b3ba2a1f1ed80588fd9ebfc3ba46065d |
rust-lang/log | 224 | rust-lang__log-224 | [
"145"
] | 8af5f3c688461a166a5097c395a5deb6c99a70ed | "diff --git a/.travis.yml b/.travis.yml\nindex 226c591c8..6bc0aa9ed 100644\n--- a/.travis.yml\n+++ b(...TRUNCATED) | "diff --git a/env/tests/regexp_filter.rs b/env/tests/regexp_filter.rs\ndeleted file mode 100644\nind(...TRUNCATED) | "Remove env_logger from this repository\nLet's find a suitable maintainer and move it out of the `lo(...TRUNCATED) | "Hey @alexcrichton, I've started to work on this split at [sebasmagri/env_logger](https://github.com(...TRUNCATED) | 2017-09-17T05:41:09Z | 0.3 | 1e12cfa3b3ba2a1f1ed80588fd9ebfc3ba46065d |
rust-lang/log | 217 | rust-lang__log-217 | [
"148"
] | 25e349c7389ab63a9f5303a9a6183aa9d723b0a0 | "diff --git a/.travis.yml b/.travis.yml\nindex 1b82ecd3a..479981582 100644\n--- a/.travis.yml\n+++ b(...TRUNCATED) | "diff --git a/log-test/Cargo.toml b/log-test/Cargo.toml\nnew file mode 100644\nindex 000000000..82ea(...TRUNCATED) | "Ensure 0.3 works with the next major release\nWe'll want to publish a version of 0.3 that works as (...TRUNCATED) | "If it's alright and no one else has started, I can start working on a shared backend crate for this(...TRUNCATED) | 2017-08-13T23:43:25Z | 0.3 | 1e12cfa3b3ba2a1f1ed80588fd9ebfc3ba46065d |
rust-lang/log | 208 | rust-lang__log-208 | [
"204"
] | 8af5f3c688461a166a5097c395a5deb6c99a70ed | "diff --git a/src/lib.rs b/src/lib.rs\nindex 50479f619..e31451324 100644\n--- a/src/lib.rs\n+++ b/sr(...TRUNCATED) | "diff --git a/tests/filters.rs b/tests/filters.rs\nindex 5fc55b2d4..4b4d09050 100644\n--- a/tests/fi(...TRUNCATED) | "Rename set_logger_raw to try_set_logger_raw\nWith respect to the changes made in #187, it makes sen(...TRUNCATED) | "The rationale to change `set_logger` to panic-on-error was that most libraries would transitively c(...TRUNCATED) | 2017-07-16T17:18:17Z | 0.3 | 1e12cfa3b3ba2a1f1ed80588fd9ebfc3ba46065d |
End of preview. Expand in Data Studio
README.md exists but content is empty.
- Downloads last month
- 5