pull_number int64 64 2.85k | test_patch stringlengths 303 98.3k | issue_numbers sequencelengths 1 2 | instance_id stringlengths 18 20 | problem_statement stringlengths 24 6.49k | version stringclasses 19
values | base_commit stringlengths 40 40 | patch stringlengths 372 188k | repo stringclasses 1
value | created_at stringlengths 20 20 | hints_text stringlengths 0 6.32k | environment_setup_commit stringclasses 20
values |
|---|---|---|---|---|---|---|---|---|---|---|---|
1,363 | diff --git a/test_suite/tests/test_unstable.rs b/test_suite/tests/test_unstable.rs
new file mode 100644
index 000000000..ccc68c822
--- /dev/null
+++ b/test_suite/tests/test_unstable.rs
@@ -0,0 +1,27 @@
+// Copyright 2018 Serde Developers
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http... | [
"1362"
] | serde-rs__serde-1363 | Raw identifier keywords
Right now, `serde_derive` passes through the `r#` on [raw identifiers](https://rust-lang-nursery.github.io/edition-guide/rust-2018/module-system/raw-identifiers.html) when the identifier is a keyword.
For example ([playground link](https://play.rust-lang.org/?gist=0492ec75839fb4634b7a9ee6e9a1... | 1.0 | c69a3e083fa865b7801a80db498e4fdc87435aad | diff --git a/serde_derive/src/de.rs b/serde_derive/src/de.rs
index e2ddfee1e..af5d5b0ca 100644
--- a/serde_derive/src/de.rs
+++ b/serde_derive/src/de.rs
@@ -30,8 +30,9 @@ pub fn expand_derive_deserialize(input: &syn::DeriveInput) -> Result<TokenStream
let ident = &cont.ident;
let params = Parameters::new(&con... | serde-rs/serde | 2018-08-23T01:10:37Z | Interesting! This is a bug. That program should be printing `"type": 3` instead of `"r#type": 3`.
Would you be interested in tracking down where this is going wrong and sending a PR? Otherwise I should be able to take a look later this week.
As a workaround, at least `serde(rename = "...")` seems to work but this... | 4cea81f93f12473e0ccbdad2ddecff1f7ea85402 |
1,323 | diff --git a/test_suite/tests/test_ser.rs b/test_suite/tests/test_ser.rs
index cd4ce6bf4..eff19069c 100644
--- a/test_suite/tests/test_ser.rs
+++ b/test_suite/tests/test_ser.rs
@@ -462,6 +462,11 @@ declare_tests! {
Token::SeqEnd,
],
}
+ test_fmt_arguments {
+ format_args!("{}{}", 1,... | [
"1319"
] | serde-rs__serde-1323 | impl<'a> Serialize for fmt::Arguments<'a>
Would it make sense to impl<'a> Serialize for fmt::Arguments<'a> ?
It's a very handy type, and available in `core` library. Though I guess for best support, the `Serializer` would have to get a `serialize_fmt` method, so it is possible to write it out without allocating temp... | 1.0 | d827b101d9a5896071013bc70f88be172cf0a550 | diff --git a/serde/src/ser/impls.rs b/serde/src/ser/impls.rs
index 0b21e5414..cb2739820 100644
--- a/serde/src/ser/impls.rs
+++ b/serde/src/ser/impls.rs
@@ -69,6 +69,15 @@ impl Serialize for String {
}
}
+impl<'a> Serialize for fmt::Arguments<'a> {
+ fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::... | serde-rs/serde | 2018-06-27T06:31:00Z | Well... We could add an impl of [`std::fmt::Write`](https://doc.rust-lang.org/std/fmt/trait.Write.html) for all `Serializer`s. I guess the `write_str` method could just forward to `serialize_str`:
DISCLAIMER: all the code below is entirely untested and probably will not compile without some adjustments
```rust
i... | 4cea81f93f12473e0ccbdad2ddecff1f7ea85402 |
1,302 | diff --git a/test_suite/tests/test_de.rs b/test_suite/tests/test_de.rs
index 6c1f3d82f..b4ca2e198 100644
--- a/test_suite/tests/test_de.rs
+++ b/test_suite/tests/test_de.rs
@@ -7,6 +7,7 @@
// except according to those terms.
#![cfg_attr(feature = "cargo-clippy", allow(decimal_literal_representation))]
+#![cfg_attr(... | [
"544"
] | serde-rs__serde-1302 | Impl Serialize/Deserialize for !
`Serialize` is straightforward. As for `Deserialize`, I guess it would just panic? This is useful for me when serializing and deserializing types like `Result<T, !>`.
| 1.0 | 0a71fe329c8898a28d03ddfb746707cf958c21e8 | diff --git a/serde/src/de/impls.rs b/serde/src/de/impls.rs
index 342ca3bea..579ee594e 100644
--- a/serde/src/de/impls.rs
+++ b/serde/src/de/impls.rs
@@ -49,6 +49,16 @@ impl<'de> Deserialize<'de> for () {
}
}
+#[cfg(feature = "unstable")]
+impl<'de> Deserialize<'de> for ! {
+ fn deserialize<D>(_deserializer: ... | serde-rs/serde | 2018-06-03T07:23:07Z | If we do `Deserialize for !` it should error, not panic.
Is `Result<T, !>` the only instance where you need this? Would it make more sense to specialize De/Serialize for `Result<T, !>` instead of implementing them for `!`? `Result<T, !>` is equivalent to T so we might as well serialize it the same way.
The `Result<T,... | 4cea81f93f12473e0ccbdad2ddecff1f7ea85402 |
1,297 | diff --git a/test_suite/tests/compile-fail/borrow/bad_lifetimes.rs b/test_suite/tests/compile-fail/borrow/bad_lifetimes.rs
index a33968f37..f2ab9de07 100644
--- a/test_suite/tests/compile-fail/borrow/bad_lifetimes.rs
+++ b/test_suite/tests/compile-fail/borrow/bad_lifetimes.rs
@@ -9,9 +9,9 @@
#[macro_use]
extern crate... | [
"1168"
] | serde-rs__serde-1297 | Use compile_error macro to report invalid attribute errors
Currently we use [`Ctxt`](https://github.com/serde-rs/serde/blob/v1.0.27/serde_derive_internals/src/ctxt.rs) in `serde_derive_internals` to batch up errors detected during the attribute parsing step of `serde_derive`, then panic with the resulting message in [`... | 1.0 | dbaf2893e32a72f9564757b0f95bf9f7869bd900 | diff --git a/serde_derive/src/lib.rs b/serde_derive/src/lib.rs
index 708f3bf46..65886bf1e 100644
--- a/serde_derive/src/lib.rs
+++ b/serde_derive/src/lib.rs
@@ -53,6 +53,7 @@ extern crate proc_macro2;
mod internals;
+use std::str::FromStr;
use proc_macro::TokenStream;
use syn::DeriveInput;
@@ -71,7 +72,7 @@ pu... | serde-rs/serde | 2018-06-01T03:19:31Z | 4cea81f93f12473e0ccbdad2ddecff1f7ea85402 | |
1,288 | diff --git a/test_suite/tests/test_value.rs b/test_suite/tests/test_value.rs
index 80554663c..d2d9e67c0 100644
--- a/test_suite/tests/test_value.rs
+++ b/test_suite/tests/test_value.rs
@@ -32,14 +32,14 @@ fn test_integer128() {
let de_i128 = IntoDeserializer::<value::Error>::into_deserializer(1i128);
// u12... | [
"1287"
] | serde-rs__serde-1288 | Implement Copy for the primitive value deserializers
https://docs.serde.rs/serde/de/value/index.html
The primitive deserializers (I8Deserializer, I16Deserializer, etc) only wrap only wrap a value of their primitive type and a phantom data for the error type, so it should be fine to allow copying.
| 1.0 | cd0b2d312c00dd9763aa62062180e3fba2a74b9d | diff --git a/serde/src/de/value.rs b/serde/src/de/value.rs
index d08bae3b2..56ed7c57f 100644
--- a/serde/src/de/value.rs
+++ b/serde/src/de/value.rs
@@ -44,6 +44,22 @@ use ser;
////////////////////////////////////////////////////////////////////////////////
+// For structs that contain a PhantomData. We do not wan... | serde-rs/serde | 2018-05-26T22:49:24Z | 4cea81f93f12473e0ccbdad2ddecff1f7ea85402 | |
1,286 | diff --git a/test_suite/tests/test_value.rs b/test_suite/tests/test_value.rs
index acd3ddd6c..80554663c 100644
--- a/test_suite/tests/test_value.rs
+++ b/test_suite/tests/test_value.rs
@@ -25,3 +25,21 @@ fn test_u32_to_enum() {
let e: E = E::deserialize(deserializer).unwrap();
assert_eq!(E::B, e);
}
+
+#[tes... | [
"1280"
] | serde-rs__serde-1286 | Implement IntoDeserializer for i128 and u128
| 1.0 | 7407d71417bc7a72c0a61f2c2f595db517457de9 | diff --git a/serde/src/de/value.rs b/serde/src/de/value.rs
index 101531b3d..d08bae3b2 100644
--- a/serde/src/de/value.rs
+++ b/serde/src/de/value.rs
@@ -218,6 +218,11 @@ primitive_deserializer!(f32, "an `f32`.", F32Deserializer, visit_f32);
primitive_deserializer!(f64, "an `f64`.", F64Deserializer, visit_f64);
primit... | serde-rs/serde | 2018-05-26T22:22:38Z | 4cea81f93f12473e0ccbdad2ddecff1f7ea85402 | |
1,270 | diff --git a/test_suite/tests/compile-fail/transparent/at_most_one.rs b/test_suite/tests/compile-fail/transparent/at_most_one.rs
new file mode 100644
index 000000000..d5b7dae89
--- /dev/null
+++ b/test_suite/tests/compile-fail/transparent/at_most_one.rs
@@ -0,0 +1,20 @@
+// Copyright 2018 Serde Developers
+//
+// Licen... | [
"1054"
] | serde-rs__serde-1270 | Attribute to specify that type representation is the same as its only field
By analogy with [`#[repr(transparent)]`](https://github.com/rust-lang/rfcs/blob/master/text/1758-repr-transparent.md).
```rust
// This should serialize and deserialize directly as String, rather than as newtype.
#[derive(Serialize, Deseria... | 1.0 | 320897679b3bff07d2e54aa96525422237b6e832 | diff --git a/serde_derive/src/de.rs b/serde_derive/src/de.rs
index 875c941a7..ad105398d 100644
--- a/serde_derive/src/de.rs
+++ b/serde_derive/src/de.rs
@@ -15,7 +15,7 @@ use syn::{self, Ident, Index, Member};
use bound;
use fragment::{Expr, Fragment, Match, Stmts};
use internals::ast::{Container, Data, Field, Style... | serde-rs/serde | 2018-05-20T20:54:37Z | Can this attribute also be used to inline the fields of a struct member type into the parent struct for the purpose of (de)serialization?
Like this:
```rust
#[derive(Serialize, Deserialize)]
struct Common {
a: i32,
}
#[derive(Serialize, Deserialize)]
struct Foo {
#[serde(transparent)]
common: ... | 4cea81f93f12473e0ccbdad2ddecff1f7ea85402 |
1,269 | diff --git a/test_suite/tests/test_gen.rs b/test_suite/tests/test_gen.rs
index 7888f2d82..ffb73210a 100644
--- a/test_suite/tests/test_gen.rs
+++ b/test_suite/tests/test_gen.rs
@@ -643,6 +643,16 @@ fn test_gen() {
struct ImpliciltyBorrowedOption<'a> {
option: std::option::Option<&'a str>,
}
+
+ #[... | [
"1268"
] | serde-rs__serde-1269 | serde_derive deserialize_with untagged enum regression
I still need to create a simple reproduction for the issue, and not sure if this is covered by another issue report, but effectively...
```rust
#[derive(Deserialize)]
#[serde(untagged)]
enum E {
Variant(
#[serde(deserialize_with="...")]
... | 1.0 | f09320b2932972e55317bf2899f69cab038f4377 | diff --git a/serde_derive/src/de.rs b/serde_derive/src/de.rs
index 40a5d1050..3cce5f071 100644
--- a/serde_derive/src/de.rs
+++ b/serde_derive/src/de.rs
@@ -1802,10 +1802,8 @@ fn deserialize_untagged_newtype_variant(
}
Some(path) => {
quote_block! {
- let __value: #field_ty... | serde-rs/serde | 2018-05-20T00:21:09Z | 4cea81f93f12473e0ccbdad2ddecff1f7ea85402 | |
1,256 | diff --git a/test_suite/tests/test_annotations.rs b/test_suite/tests/test_annotations.rs
index 248e42118..7aaa97d5b 100644
--- a/test_suite/tests/test_annotations.rs
+++ b/test_suite/tests/test_annotations.rs
@@ -2095,3 +2095,84 @@ fn test_flatten_untagged_enum() {
],
);
}
+
+#[test]
+fn test_flatten_opt... | [
"1255"
] | serde-rs__serde-1256 | Allow flattened untagged Options in struct fields
I have a small use case for `#[serde(flatten)]` that did not work as I expected due to the intermediary presence of an `Option` type. Here's what I mean:
```
#[derive(Serialize, Deserialize)]
enum Quux {
A,
B,
C,
}
#[derive(Serialize, Deserialize... | 1.0 | 35aae92b5609dc0707bea73a890ed0beb5c8cac0 | diff --git a/serde/src/de/impls.rs b/serde/src/de/impls.rs
index b13800dca..59f667ed7 100644
--- a/serde/src/de/impls.rs
+++ b/serde/src/de/impls.rs
@@ -529,6 +529,14 @@ where
{
T::deserialize(deserializer).map(Some)
}
+
+ #[doc(hidden)]
+ fn __private_visit_untagged_option<D>(self, deserialize... | serde-rs/serde | 2018-05-12T05:14:42Z | 4cea81f93f12473e0ccbdad2ddecff1f7ea85402 | |
1,252 | diff --git a/test_suite/tests/compile-fail/precondition/deserialize_dst.rs b/test_suite/tests/compile-fail/precondition/deserialize_dst.rs
new file mode 100644
index 000000000..243b998d7
--- /dev/null
+++ b/test_suite/tests/compile-fail/precondition/deserialize_dst.rs
@@ -0,0 +1,16 @@
+// Copyright 2018 Serde Developer... | [
"830"
] | serde-rs__serde-1252 | Deserialize for dynamically sized struct generates invalid code
```rust
extern crate serde;
#[macro_use]
extern crate serde_derive;
#[derive(Deserialize)]
struct S {
last: [u8],
}
```
```
error[E0277]: the trait bound `[u8]: std::marker::Sized` is not satisfied in `S`
--> src/main.rs:6:10
|
6 ... | 1.0 | 536bdd77a0725fff5ae4e55e1c4905d957c5eb94 | diff --git a/serde_derive/src/de.rs b/serde_derive/src/de.rs
index 42dbe3860..b0953450b 100644
--- a/serde_derive/src/de.rs
+++ b/serde_derive/src/de.rs
@@ -15,15 +15,16 @@ use syn::{self, Ident, Index, Member};
use bound;
use fragment::{Expr, Fragment, Match, Stmts};
use internals::ast::{Container, Data, Field, Sty... | serde-rs/serde | 2018-05-07T18:28:17Z | There is no way to implement a working Deserialize for this type because Deserialize requires Self: Sized, but it would be nice to at least detect the case of dynamically sized slice as the last field and fail with a message rather than generating broken code. | 4cea81f93f12473e0ccbdad2ddecff1f7ea85402 |
1,961 | diff --git a/test_suite/tests/ui/rename/container_unknown_rename_rule.stderr b/test_suite/tests/ui/rename/container_unknown_rename_rule.stderr
index 728d71ca2..3fd68f3f3 100644
--- a/test_suite/tests/ui/rename/container_unknown_rename_rule.stderr
+++ b/test_suite/tests/ui/rename/container_unknown_rename_rule.stderr
@@ ... | [
"1928"
] | serde-rs__serde-1961 | add a list of possible rename rules upon an error
An implementation of https://github.com/serde-rs/serde/issues/1923
| 1.12 | eaccae2c464eb096c115be38a1930539f5698ce3 | diff --git a/serde_derive/src/internals/case.rs b/serde_derive/src/internals/case.rs
index 199fd4bcb..554505160 100644
--- a/serde_derive/src/internals/case.rs
+++ b/serde_derive/src/internals/case.rs
@@ -5,7 +5,7 @@
#[allow(deprecated, unused_imports)]
use std::ascii::AsciiExt;
-use std::fmt::{self, Display};
+use... | serde-rs/serde | 2021-01-23T22:42:17Z | 55fdbea20bbcb0f0fa7e9545ec0ea10c87a6643d | |
1,958 | diff --git a/test_suite/tests/test_de.rs b/test_suite/tests/test_de.rs
index 025d87b09..a0261bd35 100644
--- a/test_suite/tests/test_de.rs
+++ b/test_suite/tests/test_de.rs
@@ -1452,4 +1452,25 @@ declare_error_tests! {
],
"invalid value: integer `65536`, expected u16",
}
+ test_duration_overfl... | [
"1933"
] | serde-rs__serde-1958 | Serde panics when deserializing malformed Duration
The documentation for `std::time::Duration::new` states that it panics if `nanos` overflows and causes `secs` to overflow.
This should cause a deserialization error instead of causing the application to panic.
| 1.12 | 398fba9b1ee6d27a2e556f8d6cd6d1a82315ee9a | diff --git a/serde/src/de/impls.rs b/serde/src/de/impls.rs
index fd77ddf1f..7f0b5d907 100644
--- a/serde/src/de/impls.rs
+++ b/serde/src/de/impls.rs
@@ -1849,6 +1849,17 @@ impl<'de> Deserialize<'de> for Duration {
}
}
+ fn check_overflow<E>(secs: u64, nanos: u32) -> Result<(), E>
+ ... | serde-rs/serde | 2021-01-20T19:48:24Z | 55fdbea20bbcb0f0fa7e9545ec0ea10c87a6643d | |
1,916 | diff --git a/serde_test/src/de.rs b/serde_test/src/de.rs
index c9bcee5b3..a1d62758e 100644
--- a/serde_test/src/de.rs
+++ b/serde_test/src/de.rs
@@ -250,9 +250,7 @@ impl<'de, 'a> de::Deserializer<'de> for &'a mut Deserializer<'de> {
{
visitor.visit_enum(DeserializerEnumVisitor { de: self }... | [
"1883"
] | serde-rs__serde-1916 | Provide an easy way to customize only the error message
**EDIT** After thinking about it some more, I feel it would be better to improve this error message rather than add API surface area. #1544 gets close, but I believe those errors are still too opaque for Cargo's purposes, and it's hidden behind a flag. Anyway, my ... | 1.11 | 8084258a3edc1dc4007e8df7f24b022d015b5fb0 | diff --git a/serde/src/private/de.rs b/serde/src/private/de.rs
index bcb964a9c..e3b685e88 100644
--- a/serde/src/private/de.rs
+++ b/serde/src/private/de.rs
@@ -824,15 +824,17 @@ mod content {
/// Not public API.
pub struct TaggedContentVisitor<'de, T> {
tag_name: &'static str,
+ expecting: &'... | serde-rs/serde | 2020-10-22T20:11:56Z | 8084258a3edc1dc4007e8df7f24b022d015b5fb0 | |
1,874 | diff --git a/test_suite/tests/test_annotations.rs b/test_suite/tests/test_annotations.rs
index 06c485dff..7604fe031 100644
--- a/test_suite/tests/test_annotations.rs
+++ b/test_suite/tests/test_annotations.rs
@@ -1967,6 +1967,29 @@ fn test_flatten_map_twice() {
);
}
+#[test]
+fn test_flatten_unit() {
+ #[der... | [
"1873"
] | serde-rs__serde-1874 | Flattening a Unit aka () should produce no extra fields
I'm designing an http api where every response is json and has diffferent fields depending on the api call, but always has a status and code field. I am acomplishing this through the Response struct:
```rust
#[derive(Debug, Serialize)]
pub struct Response<T> {
... | 1.11 | 53b9871b172c1c29a16e66138f108bf4155444fe | diff --git a/serde/src/private/de.rs b/serde/src/private/de.rs
index eb5424cc8..bcb964a9c 100644
--- a/serde/src/private/de.rs
+++ b/serde/src/private/de.rs
@@ -2763,6 +2763,13 @@ where
}
}
+ fn deserialize_unit<V>(self, visitor: V) -> Result<V::Value, Self::Error>
+ where
+ V: Visitor<'de>... | serde-rs/serde | 2020-08-10T22:07:47Z | 8084258a3edc1dc4007e8df7f24b022d015b5fb0 | |
1,831 | diff --git a/test_suite/tests/test_gen.rs b/test_suite/tests/test_gen.rs
index d8def742b..73f7fa50f 100644
--- a/test_suite/tests/test_gen.rs
+++ b/test_suite/tests/test_gen.rs
@@ -723,6 +723,18 @@ fn test_gen() {
}
deriving!(&'a str);
+
+ macro_rules! mac {
+ ($($tt:tt)*) => {
+ $($tt)... | [
"1562"
] | serde-rs__serde-1831 | Error: "field has no lifetimes to borrow" if type is behind a macro
```Rust
use serde::Deserialize;
use std::borrow::Cow;
macro_rules! t {
($t:ty) => { $t }
}
#[derive(Deserialize)]
struct B<'a> {
#[serde(borrow="'a")]
f: t!(Cow<'a , str>)
}
```
This generates error:
```
error: field `f`... | 1.11 | 8084258a3edc1dc4007e8df7f24b022d015b5fb0 | diff --git a/serde_derive/src/internals/attr.rs b/serde_derive/src/internals/attr.rs
index e6f72dfe7..d59e681a0 100644
--- a/serde_derive/src/internals/attr.rs
+++ b/serde_derive/src/internals/attr.rs
@@ -1,6 +1,6 @@
use internals::symbol::*;
use internals::{ungroup, Ctxt};
-use proc_macro2::{Group, Span, TokenStream... | serde-rs/serde | 2020-06-07T11:15:57Z | Thanks! I would accept a PR to fix this. | 8084258a3edc1dc4007e8df7f24b022d015b5fb0 |
1,830 | diff --git a/test_suite/tests/test_self.rs b/test_suite/tests/test_self.rs
new file mode 100644
index 000000000..d2241749c
--- /dev/null
+++ b/test_suite/tests/test_self.rs
@@ -0,0 +1,101 @@
+use serde::{Deserialize, Serialize};
+
+#[test]
+fn test_self() {
+ macro_rules! mac {
+ ($($tt:tt)*) => {
+ ... | [
"1565"
] | serde-rs__serde-1830 | Derive Deserialize: Self in recursive type is not supported
As the code and errors below show, deriving `Deserialize` on a recursive enum with a `Self` reference does not work.
Note: `Serialize` works fine.
```rust
// Works fine:
#[derive(serde_derive::Deserialize)]
enum E {
Nested(Vec<E>),
}
// F... | 1.12 | f6e7366b46f767c427ca0423ae4cc69531213498 | diff --git a/serde_derive/Cargo.toml b/serde_derive/Cargo.toml
index 185fe9787..5b6fa4344 100644
--- a/serde_derive/Cargo.toml
+++ b/serde_derive/Cargo.toml
@@ -22,7 +22,7 @@ proc-macro = true
[dependencies]
proc-macro2 = "1.0"
quote = "1.0"
-syn = { version = "1.0.58", features = ["visit"] }
+syn = { version = "1.0... | serde-rs/serde | 2020-06-07T09:37:23Z | Thanks! This is a bug. I would accept a PR to fix this.
I assume this just boils down to special casing `Self` in the derive code?
I'll take a look.
Yeah, I imagine what happens is that the field type is referred to from somewhere outside of the Deserialize impl itself, such as from a Visitor impl where Self would r... | 55fdbea20bbcb0f0fa7e9545ec0ea10c87a6643d |
1,827 | diff --git a/test_suite/tests/expand/de_enum.expanded.rs b/test_suite/tests/expand/de_enum.expanded.rs
index 58d40459b..a4ba24911 100644
--- a/test_suite/tests/expand/de_enum.expanded.rs
+++ b/test_suite/tests/expand/de_enum.expanded.rs
@@ -9,7 +9,7 @@ enum DeEnum<B, C, D> {
}
#[doc(hidden)]
#[allow(non_upper_case_g... | [
"1683"
] | serde-rs__serde-1827 | Use underscore consts on rustc 1.37+
https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html#using-unnamed-const-items-for-macros
This would tend to produce more readable error messages, because the paths currently emitted by rustc in error messages are silly (https://github.com/rust-lang/rust/issues/46991).
It wi... | 1.11 | 6980727d74e1b4fd0f2bff85e824e2c47ca08ba3 | diff --git a/serde_derive/Cargo.toml b/serde_derive/Cargo.toml
index 879a65199..2e90c0b91 100644
--- a/serde_derive/Cargo.toml
+++ b/serde_derive/Cargo.toml
@@ -9,7 +9,7 @@ repository = "https://github.com/serde-rs/serde"
documentation = "https://serde.rs/derive.html"
keywords = ["serde", "serialization", "no_std"]
... | serde-rs/serde | 2020-06-07T00:17:10Z | 8084258a3edc1dc4007e8df7f24b022d015b5fb0 | |
1,805 | diff --git a/test_suite/tests/test_gen.rs b/test_suite/tests/test_gen.rs
index 92bb0ae1f..c429500c1 100644
--- a/test_suite/tests/test_gen.rs
+++ b/test_suite/tests/test_gen.rs
@@ -691,6 +691,16 @@ fn test_gen() {
#[serde(flatten, skip_deserializing)]
flat: T,
}
+
+ // https://github.com/serde... | [
"1804"
] | serde-rs__serde-1805 | derive(Deserialize) panics with index out of bounds for `#[serde(skip)]`
Observed in this commit
https://github.com/matklad/cargo_metadata/commit/0b1c8d85c860fe9fb3488fea5990d659780065fc
```
Compiling cargo_metadata v0.9.1 (/home/matklad/projects/cargo_metadata)
error: proc-macro derive panicked
--> src/m... | 1.10 | 099fa25b86524f07d86852ea2de071e8dd2a653f | diff --git a/serde_derive/src/de.rs b/serde_derive/src/de.rs
index 5ccd38a8f..74df11df7 100644
--- a/serde_derive/src/de.rs
+++ b/serde_derive/src/de.rs
@@ -1153,10 +1153,13 @@ fn prepare_enum_variant_enum(
variants: &[Variant],
cattrs: &attr::Container,
) -> (TokenStream, Stmts) {
- let variant_names_ide... | serde-rs/serde | 2020-05-08T22:40:13Z | 099fa25b86524f07d86852ea2de071e8dd2a653f | |
1,706 | diff --git a/test_suite/tests/test_macros.rs b/test_suite/tests/test_macros.rs
index d4456bed7..c0c807ec7 100644
--- a/test_suite/tests/test_macros.rs
+++ b/test_suite/tests/test_macros.rs
@@ -1145,6 +1145,20 @@ fn test_adjacently_tagged_enum() {
],
);
+ // optional newtype with no content field
+ ... | [
"1553"
] | serde-rs__serde-1706 | Optional content for enum variants?
Hi!
I need to de/serialize JSON messages such as the following:
```javascript
{ ..., "command": "cmd1", "arguments": { <command-dependent> } }
```
So far so good, this fits the adjacently tagged enum representation.
The wrinkle is that for some commands the `arguments` fiel... | 1.10 | a81968af3caea9528e8e935a9a19ccad19a16778 | diff --git a/serde_derive/src/de.rs b/serde_derive/src/de.rs
index 64113a603..c3b779bf9 100644
--- a/serde_derive/src/de.rs
+++ b/serde_derive/src/de.rs
@@ -1379,42 +1379,37 @@ fn deserialize_adjacently_tagged_enum(
}
};
- fn is_unit(variant: &Variant) -> bool {
- match variant.style {
- ... | serde-rs/serde | 2020-01-06T21:07:44Z | 099fa25b86524f07d86852ea2de071e8dd2a653f | |
1,695 | diff --git a/test_suite/tests/test_macros.rs b/test_suite/tests/test_macros.rs
index 0594d8d45..d95fa928f 100644
--- a/test_suite/tests/test_macros.rs
+++ b/test_suite/tests/test_macros.rs
@@ -1924,6 +1924,62 @@ fn test_rename_all() {
);
}
+#[test]
+fn test_rename_all_fields() {
+ #[derive(Serialize, Deseria... | [
"1061"
] | serde-rs__serde-1695 | Apply rename_all to enum member "fields"
When using enums with struct-like members it would be useful if `rename_all` on the enclosing enum could apply to the members, too. For example:
```rust
#[serde(untagged, rename_all = "camelCase" )]
pub enum Value {
Null { null_value: () },
String { string_value: Stri... | 1.17 | ad94aed75398d43d174368aa8c4869332bb94e33 | diff --git a/serde_derive/src/internals/ast.rs b/serde_derive/src/internals/ast.rs
index 8bcb0ecd1..75b28c969 100644
--- a/serde_derive/src/internals/ast.rs
+++ b/serde_derive/src/internals/ast.rs
@@ -88,9 +88,12 @@ impl<'a> Container<'a> {
if field.attrs.flatten() {
... | serde-rs/serde | 2019-12-15T18:14:14Z | Seems reasonable. Do you have a suggestion for how this should work? Simplify changing the meaning of `rename_all` would be a breaking change.
Side note: representing the datastore value the following way may be more convenient. This avoids restating the type twice in Rust code -- <code>Value::<b>Boolean</b>(true)</... | ad94aed75398d43d174368aa8c4869332bb94e33 |
End of preview. Expand in Data Studio
README.md exists but content is empty.
- Downloads last month
- 4