url stringlengths 52 53 | repository_url stringclasses 1 value | labels_url stringlengths 66 67 | comments_url stringlengths 61 62 | events_url stringlengths 59 60 | html_url stringlengths 40 43 | id int64 719M 2.8B | node_id stringlengths 18 32 | number int64 1.28k 11.9k | title stringlengths 1 350 | user dict | labels listlengths 0 10 | state stringclasses 2 values | locked bool 2 classes | assignee dict | assignees listlengths 0 3 | milestone null | comments listlengths 0 30 ⌀ | created_at timestamp[s] | updated_at timestamp[s] | closed_at timestamp[s] | author_association stringclasses 4 values | sub_issues_summary dict | active_lock_reason stringclasses 1 value | draft bool 2 classes | pull_request dict | body stringlengths 0 73.4k ⌀ | closed_by dict | reactions dict | timeline_url stringlengths 61 62 | performed_via_github_app null | state_reason stringclasses 3 values | is_pull_request bool 2 classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/9647 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9647/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9647/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9647/events | https://github.com/NVIDIA/NeMo/pull/9647 | 2,397,073,442 | PR_kwDOC_bI7s50xbDw | 9,647 | [NeMo-UX] Fix when optimizers are setup for PEFT | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
... | closed | false | null | [] | null | [] | 2024-07-09T04:16:25 | 2024-07-15T16:18:50 | 2024-07-15T16:18:48 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9647",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9647",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9647.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9647.patch",
"merged_at": "2024-07-15T16:18:48"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9647/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9647/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9646 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9646/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9646/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9646/events | https://github.com/NVIDIA/NeMo/pull/9646 | 2,396,827,149 | PR_kwDOC_bI7s50wmJD | 9,646 | Adding mamba embedding model | {
"login": "adityavavre",
"id": 43115743,
"node_id": "MDQ6VXNlcjQzMTE1NzQz",
"avatar_url": "https://avatars.githubusercontent.com/u/43115743?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adityavavre",
"html_url": "https://github.com/adityavavre",
"followers_url": "https://api.github.com/users/adityavavre/followers",
"following_url": "https://api.github.com/users/adityavavre/following{/other_user}",
"gists_url": "https://api.github.com/users/adityavavre/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adityavavre/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adityavavre/subscriptions",
"organizations_url": "https://api.github.com/users/adityavavre/orgs",
"repos_url": "https://api.github.com/users/adityavavre/repos",
"events_url": "https://api.github.com/users/adityavavre/events{/privacy}",
"received_events_url": "https://api.github.com/users/adityavavre/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "htt... | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-09T00:24:14 | 2024-08-24T01:50:39 | 2024-08-24T01:50:39 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9646",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9646",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9646.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9646.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9646/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9646/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9645 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9645/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9645/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9645/events | https://github.com/NVIDIA/NeMo/issues/9645 | 2,396,639,482 | I_kwDOC_bI7s6O2dD6 | 9,645 | More complete example of using S3CheckpointIO | {
"login": "dementrock",
"id": 784063,
"node_id": "MDQ6VXNlcjc4NDA2Mw==",
"avatar_url": "https://avatars.githubusercontent.com/u/784063?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dementrock",
"html_url": "https://github.com/dementrock",
"followers_url": "https://api.github.com/users/dementrock/followers",
"following_url": "https://api.github.com/users/dementrock/following{/other_user}",
"gists_url": "https://api.github.com/users/dementrock/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dementrock/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dementrock/subscriptions",
"organizations_url": "https://api.github.com/users/dementrock/orgs",
"repos_url": "https://api.github.com/users/dementrock/repos",
"events_url": "https://api.github.com/users/dementrock/events{/privacy}",
"received_events_url": "https://api.github.com/users/dementrock/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://... | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale.",
"Review seemed closed but can use it as reference if still needing help.\nht... | 2024-07-08T21:51:15 | 2024-08-29T19:19:04 | 2024-08-22T01:52:54 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null |
The existing doc on S3CheckpointIO is pretty sparse. Can there be a more complete example of using it within a script like https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/megatron_gpt_pretraining.py?
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9645/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9645/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9644 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9644/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9644/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9644/events | https://github.com/NVIDIA/NeMo/pull/9644 | 2,396,626,459 | PR_kwDOC_bI7s50v6J- | 9,644 | [Cherrypick] support lora when kv_channel != hidden_size / num_heads | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-07-08T21:41:08 | 2024-07-08T23:37:22 | 2024-07-08T23:37:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9644",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9644",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9644.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9644.patch",
"merged_at": "2024-07-08T23:37:20"
} | # What does this PR do ?
Cherrypick #9636
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9644/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9644/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9643 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9643/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9643/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9643/events | https://github.com/NVIDIA/NeMo/pull/9643 | 2,396,567,325 | PR_kwDOC_bI7s50vtAq | 9,643 | Cherry-pick megatron export fix from main | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-08T21:03:51 | 2024-07-10T23:00:59 | 2024-07-10T23:00:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9643",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9643",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9643.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9643.patch",
"merged_at": "2024-07-10T23:00:59"
} | # What does this PR do ?
Cherry-pick megatron export fix from main
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9643/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9643/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9642 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9642/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9642/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9642/events | https://github.com/NVIDIA/NeMo/pull/9642 | 2,396,401,288 | PR_kwDOC_bI7s50vIFW | 9,642 | [Nemo CICD] Docker temp files auto-cleanup | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api... | closed | false | null | [] | null | [] | 2024-07-08T19:32:44 | 2024-07-09T15:24:03 | 2024-07-09T15:24:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9642",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9642",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9642.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9642.patch",
"merged_at": "2024-07-09T15:24:01"
} | [Nemo CICD] Docker cleanup | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9642/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9642/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9641 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9641/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9641/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9641/events | https://github.com/NVIDIA/NeMo/pull/9641 | 2,396,291,585 | PR_kwDOC_bI7s50uv6G | 9,641 | enables default data step in megatron parallel to operate on a wider variety of tensors | {
"login": "jomitchellnv",
"id": 148147880,
"node_id": "U_kgDOCNSOqA",
"avatar_url": "https://avatars.githubusercontent.com/u/148147880?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jomitchellnv",
"html_url": "https://github.com/jomitchellnv",
"followers_url": "https://api.github.com/users/jomitchellnv/followers",
"following_url": "https://api.github.com/users/jomitchellnv/following{/other_user}",
"gists_url": "https://api.github.com/users/jomitchellnv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jomitchellnv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jomitchellnv/subscriptions",
"organizations_url": "https://api.github.com/users/jomitchellnv/orgs",
"repos_url": "https://api.github.com/users/jomitchellnv/repos",
"events_url": "https://api.github.com/users/jomitchellnv/events{/privacy}",
"received_events_url": "https://api.github.com/users/jomitchellnv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-08T18:35:20 | 2024-07-10T08:19:42 | 2024-07-10T08:19:42 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9641",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9641",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9641.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9641.patch",
"merged_at": "2024-07-10T08:19:42"
} | …variety of tensors coming out of the dataloader
Add more flexibility to the default data step inside megatron parallel.
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Megatron parallel's default data step can operate on wrapped tuples and unwrapped items coming directly out of the dataloader
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9641/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9641/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9640 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9640/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9640/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9640/events | https://github.com/NVIDIA/NeMo/pull/9640 | 2,396,276,224 | PR_kwDOC_bI7s50usle | 9,640 | Enables megatron parallel move to device inside datastep | {
"login": "jomitchellnv",
"id": 148147880,
"node_id": "U_kgDOCNSOqA",
"avatar_url": "https://avatars.githubusercontent.com/u/148147880?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jomitchellnv",
"html_url": "https://github.com/jomitchellnv",
"followers_url": "https://api.github.com/users/jomitchellnv/followers",
"following_url": "https://api.github.com/users/jomitchellnv/following{/other_user}",
"gists_url": "https://api.github.com/users/jomitchellnv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jomitchellnv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jomitchellnv/subscriptions",
"organizations_url": "https://api.github.com/users/jomitchellnv/orgs",
"repos_url": "https://api.github.com/users/jomitchellnv/repos",
"events_url": "https://api.github.com/users/jomitchellnv/events{/privacy}",
"received_events_url": "https://api.github.com/users/jomitchellnv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-07-08T18:26:01 | 2024-07-08T18:34:32 | 2024-07-08T18:32:00 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9640",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9640",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9640.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9640.patch",
"merged_at": null
} | # What does this PR do ?
We enable the default data step to operate on a wider variety of outputs from the dataloader.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Enables the dataloader to pass a wrapped tuple to the default data step in megatron parallel
- Enables the dataloader to pass any unwrapped item to the default data step
# Usage
* You can potentially add a usage example below
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jomitchellnv",
"id": 148147880,
"node_id": "U_kgDOCNSOqA",
"avatar_url": "https://avatars.githubusercontent.com/u/148147880?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jomitchellnv",
"html_url": "https://github.com/jomitchellnv",
"followers_url": "https://api.github.com/users/jomitchellnv/followers",
"following_url": "https://api.github.com/users/jomitchellnv/following{/other_user}",
"gists_url": "https://api.github.com/users/jomitchellnv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jomitchellnv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jomitchellnv/subscriptions",
"organizations_url": "https://api.github.com/users/jomitchellnv/orgs",
"repos_url": "https://api.github.com/users/jomitchellnv/repos",
"events_url": "https://api.github.com/users/jomitchellnv/events{/privacy}",
"received_events_url": "https://api.github.com/users/jomitchellnv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9640/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9640/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9639 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9639/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9639/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9639/events | https://github.com/NVIDIA/NeMo/pull/9639 | 2,396,166,766 | PR_kwDOC_bI7s50uUqF | 9,639 | add documentation for reset_lr feature | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-07-08T17:22:24 | 2024-07-11T18:44:09 | 2024-07-11T18:44:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9639",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9639",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9639.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9639.patch",
"merged_at": "2024-07-11T18:44:07"
} | # What does this PR do ?
Adds a doc file for reset_lr feature.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9639/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9639/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9638 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9638/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9638/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9638/events | https://github.com/NVIDIA/NeMo/pull/9638 | 2,396,000,451 | PR_kwDOC_bI7s50twYt | 9,638 | Improve error messaging during trt-llm export | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-07-08T15:54:03 | 2024-07-08T17:31:25 | 2024-07-08T17:31:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9638",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9638",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9638.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9638.patch",
"merged_at": "2024-07-08T17:31:24"
} | # What does this PR do ?
Improves the error messaging during the trt-llm export | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9638/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9638/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9637 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9637/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9637/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9637/events | https://github.com/NVIDIA/NeMo/pull/9637 | 2,395,991,492 | PR_kwDOC_bI7s50tuYy | 9,637 | [NeMo-UX] Fix pipeline parallel bug | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-08T15:49:58 | 2024-07-09T20:35:08 | 2024-07-09T20:35:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9637",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9637",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9637.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9637.patch",
"merged_at": "2024-07-09T20:35:07"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9637/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9637/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9636 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9636/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9636/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9636/events | https://github.com/NVIDIA/NeMo/pull/9636 | 2,395,886,589 | PR_kwDOC_bI7s50tXZ4 | 9,636 | Support LoRA when kv_channel != hidden_size / num_heads | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-07-08T15:01:13 | 2024-07-08T21:40:01 | 2024-07-08T21:13:55 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9636",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9636",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9636.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9636.patch",
"merged_at": "2024-07-08T21:13:55"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9636/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9636/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9635 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9635/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9635/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9635/events | https://github.com/NVIDIA/NeMo/pull/9635 | 2,395,591,839 | PR_kwDOC_bI7s50sWi_ | 9,635 | ci: Timeout per step, not job | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api... | closed | false | null | [] | null | [] | 2024-07-08T13:04:59 | 2024-07-08T16:49:12 | 2024-07-08T16:49:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9635",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9635",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9635.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9635.patch",
"merged_at": "2024-07-08T16:49:09"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9635/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9635/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9634 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9634/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9634/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9634/events | https://github.com/NVIDIA/NeMo/pull/9634 | 2,395,235,348 | PR_kwDOC_bI7s50rIaK | 9,634 | Unwrap ckpt_io for model opt (async save) (#9622) | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https... | null | [] | 2024-07-08T10:18:40 | 2024-07-08T11:39:56 | 2024-07-08T11:39:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9634",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9634",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9634.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9634.patch",
"merged_at": "2024-07-08T11:39:53"
} | # What does this PR do ?
Cherry-pick of https://github.com/NVIDIA/NeMo/pull/9622
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9634/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9634/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9633 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9633/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9633/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9633/events | https://github.com/NVIDIA/NeMo/pull/9633 | 2,395,111,138 | PR_kwDOC_bI7s50qtYW | 9,633 | Change default parallel_save to False | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https... | null | [] | 2024-07-08T09:21:40 | 2024-07-08T11:12:26 | 2024-07-08T11:12:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9633",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9633",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9633.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9633.patch",
"merged_at": "2024-07-08T11:12:24"
} | # What does this PR do ?
Cheery-pick of https://github.com/NVIDIA/NeMo/pull/9632 to r2.0 branch
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9633/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9633/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9632 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9632/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9632/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9632/events | https://github.com/NVIDIA/NeMo/pull/9632 | 2,395,077,247 | PR_kwDOC_bI7s50qmCR | 9,632 | Change default parallel_save to False | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https... | null | [] | 2024-07-08T09:06:57 | 2024-07-08T10:16:28 | 2024-07-08T10:16:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9632",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9632",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9632.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9632.patch",
"merged_at": "2024-07-08T10:16:26"
} | # What does this PR do ?
Parallel save is set to False in the GPT config, but not in the DistributedCheckpointIO constructor. This PR fixes that
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9632/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9632/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9631 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9631/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9631/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9631/events | https://github.com/NVIDIA/NeMo/pull/9631 | 2,394,234,324 | PR_kwDOC_bI7s50nx5c | 9,631 | Release `2.0.0rc1` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"# Highlights\r\n_<here-goes-the-summary...>_",
"# Detailed Changelogs\r\n"
] | 2024-07-07T21:48:29 | 2024-07-11T17:15:43 | 2024-07-11T17:15:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9631",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9631",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9631.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9631.patch",
"merged_at": "2024-07-11T17:15:41"
} | 🚀 PR to release NeMo `2.0.0rc1`.
📝 Please remember the following to-do's before merge:
- [ ] Fill-in the comment `Highlights`
- [ ] Review the comment `Detailed Changelogs`
🚨 Please also keep in mind to _not_ delete the headings of the task commits. They are required by the post-merge automation.
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9631/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9631/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9630 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9630/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9630/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9630/events | https://github.com/NVIDIA/NeMo/issues/9630 | 2,394,106,911 | I_kwDOC_bI7s6Osywf | 9,630 | How to adapt myself speaker model into the diarization pipeline? | {
"login": "SoundingSilence",
"id": 38876180,
"node_id": "MDQ6VXNlcjM4ODc2MTgw",
"avatar_url": "https://avatars.githubusercontent.com/u/38876180?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SoundingSilence",
"html_url": "https://github.com/SoundingSilence",
"followers_url": "https://api.github.com/users/SoundingSilence/followers",
"following_url": "https://api.github.com/users/SoundingSilence/following{/other_user}",
"gists_url": "https://api.github.com/users/SoundingSilence/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SoundingSilence/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SoundingSilence/subscriptions",
"organizations_url": "https://api.github.com/users/SoundingSilence/orgs",
"repos_url": "https://api.github.com/users/SoundingSilence/repos",
"events_url": "https://api.github.com/users/SoundingSilence/events{/privacy}",
"received_events_url": "https://api.github.com/users/SoundingSilence/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
... | closed | false | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https:... | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-07T15:45:18 | 2024-08-22T01:52:56 | 2024-08-22T01:52:55 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Thank you for your contribution for the Nemo framework, it is an awesome work.
I use the Diarization pipeline, which is vad -> spk_emb -> clustering(nmesc+kmeans). When I use myself speaker model, I found the diarization performance is even worse than the open-source titanet-large model on my own test dataset.
Note that in the aspect of the speaker recognition performance, my speaker model is better than the provided titanet-large on my own test set. However, the diarization equipped with my speaker model cannot get good performance (better eer can not get better der?).
Is there any hyper-parameters in clustering need to be tuned for different speaker model and test set (such as the self.nme_mat_size, self.max_rp_thershold, self.sparse_search_volume, etc.)
Hope for your valuable suggestion, thanks ! | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9630/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9630/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9629 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9629/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9629/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9629/events | https://github.com/NVIDIA/NeMo/pull/9629 | 2,393,876,193 | PR_kwDOC_bI7s50mrJu | 9,629 | nemo gemma to hf conversion | {
"login": "krishnacpuvvada",
"id": 93558329,
"node_id": "U_kgDOBZOWOQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93558329?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/krishnacpuvvada",
"html_url": "https://github.com/krishnacpuvvada",
"followers_url": "https://api.github.com/users/krishnacpuvvada/followers",
"following_url": "https://api.github.com/users/krishnacpuvvada/following{/other_user}",
"gists_url": "https://api.github.com/users/krishnacpuvvada/gists{/gist_id}",
"starred_url": "https://api.github.com/users/krishnacpuvvada/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/krishnacpuvvada/subscriptions",
"organizations_url": "https://api.github.com/users/krishnacpuvvada/orgs",
"repos_url": "https://api.github.com/users/krishnacpuvvada/repos",
"events_url": "https://api.github.com/users/krishnacpuvvada/events{/privacy}",
"received_events_url": "https://api.github.com/users/krishnacpuvvada/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-07-07T03:30:42 | 2024-07-07T04:00:06 | 2024-07-07T03:41:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9629",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9629",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9629.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9629.patch",
"merged_at": "2024-07-07T03:41:27"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "krishnacpuvvada",
"id": 93558329,
"node_id": "U_kgDOBZOWOQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93558329?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/krishnacpuvvada",
"html_url": "https://github.com/krishnacpuvvada",
"followers_url": "https://api.github.com/users/krishnacpuvvada/followers",
"following_url": "https://api.github.com/users/krishnacpuvvada/following{/other_user}",
"gists_url": "https://api.github.com/users/krishnacpuvvada/gists{/gist_id}",
"starred_url": "https://api.github.com/users/krishnacpuvvada/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/krishnacpuvvada/subscriptions",
"organizations_url": "https://api.github.com/users/krishnacpuvvada/orgs",
"repos_url": "https://api.github.com/users/krishnacpuvvada/repos",
"events_url": "https://api.github.com/users/krishnacpuvvada/events{/privacy}",
"received_events_url": "https://api.github.com/users/krishnacpuvvada/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9629/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9629/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9628 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9628/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9628/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9628/events | https://github.com/NVIDIA/NeMo/pull/9628 | 2,393,226,509 | PR_kwDOC_bI7s50kjdl | 9,628 | Fix the names of two sets of weight and bias in mcore_to_nemo_mapping of scripts/convert_gpt_nemo_to_mcore.py | {
"login": "renweizhukov",
"id": 11728435,
"node_id": "MDQ6VXNlcjExNzI4NDM1",
"avatar_url": "https://avatars.githubusercontent.com/u/11728435?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/renweizhukov",
"html_url": "https://github.com/renweizhukov",
"followers_url": "https://api.github.com/users/renweizhukov/followers",
"following_url": "https://api.github.com/users/renweizhukov/following{/other_user}",
"gists_url": "https://api.github.com/users/renweizhukov/gists{/gist_id}",
"starred_url": "https://api.github.com/users/renweizhukov/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/renweizhukov/subscriptions",
"organizations_url": "https://api.github.com/users/renweizhukov/orgs",
"repos_url": "https://api.github.com/users/renweizhukov/repos",
"events_url": "https://api.github.com/users/renweizhukov/events{/privacy}",
"received_events_url": "https://api.github.com/users/renweizhukov/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-07-05T23:17:50 | 2024-08-15T16:39:24 | 2024-08-15T16:39:24 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9628",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9628",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9628.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9628.patch",
"merged_at": "2024-08-15T16:39:24"
} | These two sets of weight and bias have been renamed according to the `module_name_rewrite_list` given in https://github.com/NVIDIA/Megatron-LM/blob/e33c8f78a35765d5aa37475a144da60e8a2349d1/megatron/core/inference/gpt/state_dict_hooks.py#L116-L119
Also change the underscores in the two command-line options to hyphens to follow the convention of using hyphens in command-line options. Note that `argparse` automatically converts hyphens in argument names to underscores in the attributes of the namespace returned by `parse_args()`.
# What does this PR do ?
Update the names of the two sets of weight and bias according to latest Megatron-LM.
**Collection**: NLP
# Changelog
- Update the names of the two sets of weight and bias according to latest Megatron-LM.
- Change the underscores in the two command-line options to hyphens to follow the convention of using hyphens in command-line options.
# Usage
https://docs.nvidia.com/nemo-framework/user-guide/latest/modelalignment/dpo.html
```
python convert_gpt_nemo_to_mcore.py --input-name-or-path ./model_checkpoint --output-path ./mcore_gpt.nemo
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests? The model conversion script does not have any unit test.
- [x] Did you add or update any necessary documentation? Update the comment in the script.
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #9626
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9628/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9628/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9627 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9627/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9627/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9627/events | https://github.com/NVIDIA/NeMo/pull/9627 | 2,393,212,538 | PR_kwDOC_bI7s50kggz | 9,627 | [NeMo-UX] fix pretrianing data sizes and weights | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-05T22:50:08 | 2024-07-06T04:46:54 | 2024-07-06T04:46:52 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9627",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9627",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9627.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9627.patch",
"merged_at": "2024-07-06T04:46:52"
} | # What does this PR do ?
Fix NeMo 2 pretraining with different data split sizes and dataset weights
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9627/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9627/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9626 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9626/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9626/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9626/events | https://github.com/NVIDIA/NeMo/issues/9626 | 2,393,210,481 | I_kwDOC_bI7s6OpX5x | 9,626 | RuntimeError "Unexpected key" when running checkpoint_converters script convert_got_nemo_to_mcore.py | {
"login": "renweizhukov",
"id": 11728435,
"node_id": "MDQ6VXNlcjExNzI4NDM1",
"avatar_url": "https://avatars.githubusercontent.com/u/11728435?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/renweizhukov",
"html_url": "https://github.com/renweizhukov",
"followers_url": "https://api.github.com/users/renweizhukov/followers",
"following_url": "https://api.github.com/users/renweizhukov/following{/other_user}",
"gists_url": "https://api.github.com/users/renweizhukov/gists{/gist_id}",
"starred_url": "https://api.github.com/users/renweizhukov/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/renweizhukov/subscriptions",
"organizations_url": "https://api.github.com/users/renweizhukov/orgs",
"repos_url": "https://api.github.com/users/renweizhukov/repos",
"events_url": "https://api.github.com/users/renweizhukov/events{/privacy}",
"received_events_url": "https://api.github.com/users/renweizhukov/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
... | closed | false | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.... | null | [
"Hi, try to follow up here: I think we have few different version of NeMo checkpoints at the moment. The current script works for more recent nemo checkpoints but maybe not 2B.",
"The error is not caused by the input NeMo checkpoint. It is caused by this change in the output mcore checkpoint, i.e., these two sets... | 2024-07-05T22:46:36 | 2024-08-17T05:46:30 | 2024-08-15T16:39:53 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
RuntimeError "Unexpected key" when running checkpoint_converters script convert_got_nemo_to_mcore.py
**Steps/Code to reproduce bug**
Follow the instructions given in https://docs.nvidia.com/nemo-framework/user-guide/latest/modelalignment/dpo.html to convert a GPT-2B checkpoint to Megatron-Core checkpoint.
1. Download the 2B checkpoint.
```
wget https://huggingface.co/nvidia/GPT-2B-001/resolve/main/GPT-2B-001_bf16_tp1.nemo
```
2. Extract the NeMo file to a folder.
```
mkdir model_checkpoint && tar -xvf GPT-2B-001_bf16_tp1.nemo -C model_checkpoint
```
3. Run the script to convert from old NeMo checkpoint to Megatron-Core checkpoint. The original linked script [convert_nemo_gpt_to_mcore.py](https://github.com/NVIDIA/NeMo/blob/86b198ff93438d454f9c7f3550bcfb7d4e59feab/scripts/nlp_language_modeling/convert_nemo_gpt_to_mcore.py) has been replaced with [convert_gpt_nemo_to_mcore.py](https://github.com/renweizhukov/NeMo/blob/main/scripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py).
```
python convert_gpt_nemo_to_mcore.py --input_name_or_path ./model_checkpoint --output_path ./mcore_gpt.nemo
```
4. Hit the following `RuntimeError`.
```
[NeMo W 2024-06-29 08:37:13 megatron_gpt_model:327] megatron_amp_O2 is enabled but transformer-engine is not.
Traceback (most recent call last):
File "/workspace/src/3rdparty/NeMo/scripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py", line 323, in <module>
convert(
File "/workspace/src/3rdparty/NeMo/scripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py", line 244, in convert
mcore_model = load_model(mcore_model, mcore_state_dict, ignore_if_missing=ignore_if_missing)
File "/workspace/src/3rdparty/NeMo/scripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py", line 172, in load_model
raise RuntimeError(f"Unexpected key: {name} not in state_dict but in model.")
RuntimeError: Unexpected key: model.module.decoder.layers.0.input_layernorm.weight not in state_dict but in model.
```
**Expected behavior**
The script should write the converted checkpoint under the given `output_path`.
**Environment overview (please complete the following information)**
- Environment location: Docker
- Method of NeMo install: from source
```
# Checked out at commit e33c8f7
uv pip install --system --no-build-isolation --no-deps -e /workspace/src/3rdparty/Megatron-LM
# Checked out at commit f1062b7
uv pip install --system --no-build-isolation --no-deps -e "/workspace/src/3rdparty/NeMo[nlp]" && cd /workspace/src/3rdparty/NeMo/nemo/collections/nlp/data/language_modeling/megatron && make
```
- If method of install is [Docker], provide `docker pull` & `docker run` commands used
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version: Ubuntu 22.04.4 LTS
- PyTorch version: 2.3.0a0+6ddf5cf85e.nv24.04
- Python version: Python 3.10.12
**Additional context**
Add any other context about the problem here.
GPU model: NVIDIA A100-SXM4-80GB
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9626/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 1
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9626/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9625 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9625/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9625/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9625/events | https://github.com/NVIDIA/NeMo/pull/9625 | 2,393,205,617 | PR_kwDOC_bI7s50kfDn | 9,625 | Nemotron export - fixing megatron_export.py | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-05T22:37:18 | 2024-07-08T20:50:47 | 2024-07-08T20:50:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9625",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9625",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9625.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9625.patch",
"merged_at": "2024-07-08T20:50:47"
} | # What does this PR do ?
Updates Apex module replacements we do inside export() with Megatron Core modules replacement.
**Collection**: [Note which collection this PR will affect]
NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
```python
python3 examples/nlp/language_modeling/megatron_export.py model_type=gpt gpt_model_file=Nemotron-3-8B-Base-4k.nemo onnx_model=Nemotron-3-8B-Base-4k.nemo
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9625/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9625/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9624 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9624/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9624/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9624/events | https://github.com/NVIDIA/NeMo/pull/9624 | 2,393,203,724 | PR_kwDOC_bI7s50kepI | 9,624 | Fix the arguments of forward_for_export function in msdd_models | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | {
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.... | null | [] | 2024-07-05T22:34:27 | 2024-07-08T02:38:57 | 2024-07-08T02:38:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9624",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9624",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9624.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9624.patch",
"merged_at": "2024-07-08T02:38:57"
} | # What does this PR do ?
The refactoring PR [#9147](https://github.com/NVIDIA/NeMo/pull/9147) in missed a line that should have been refactored too.
Adding the necessary change to prevent errors in this PR
**Collection**: [Note which collection this PR will affect]
ASR/speaker_tasks
# Changelog
```python3
logits, embs_a = self.msdd._speaker_model.forward_for_export(
processed_signal=audio_signal[detach_ids[0]], processed_signal_len=audio_signal_len[detach_ids[0]]
)
```
to
```python3
logits, embs_a = self.msdd._speaker_model.forward_for_export(
audio_signal=audio_signal[detach_ids[0]], length=audio_signal_len[detach_ids[0]]
)
```
# Usage
```python
python ./multiscale_diar_decoder.py --config-path='../conf/neural_diarizer' --config-name='msdd_5scl_15_05_50Povl_256x3x32x2.yaml' \
trainer.devices=1 \
model.base.diarizer.speaker_embeddings.model_path="titanet_large" \
model.train_ds.manifest_filepath="<train_manifest_path>" \
model.validation_ds.manifest_filepath="<dev_manifest_path>" \
model.train_ds.emb_dir="<train_temp_dir>" \
model.validation_ds.emb_dir="<dev_temp_dir>" \
exp_manager.name='sample_train' \
exp_manager.exp_dir='./msdd_exp'
"""
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in NeMo ASR
| {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9624/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9624/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9623 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9623/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9623/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9623/events | https://github.com/NVIDIA/NeMo/pull/9623 | 2,392,982,987 | PR_kwDOC_bI7s50juxV | 9,623 | Add long context recipe | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-05T18:13:00 | 2024-07-27T01:49:04 | 2024-07-27T01:49:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9623",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9623",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9623.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9623.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9623/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9623/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9622 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9622/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9622/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9622/events | https://github.com/NVIDIA/NeMo/pull/9622 | 2,392,922,277 | PR_kwDOC_bI7s50jhvb | 9,622 | Unwrap ckpt_io for model opt (async save) | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https... | null | [] | 2024-07-05T17:09:24 | 2024-07-08T10:16:56 | 2024-07-08T10:16:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9622",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9622",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9622.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9622.patch",
"merged_at": "2024-07-08T10:16:54"
} | # What does this PR do ?
Fix model_opt path with async save, where `strategy.checkpoint_io` is a wrapper around the base strategy.
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9622/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9622/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9621 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9621/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9621/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9621/events | https://github.com/NVIDIA/NeMo/pull/9621 | 2,392,840,724 | PR_kwDOC_bI7s50jQH_ | 9,621 | fix ckpt load bug | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-07-05T15:53:05 | 2024-07-06T00:05:06 | 2024-07-06T00:05:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9621",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9621",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9621.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9621.patch",
"merged_at": "2024-07-06T00:05:04"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9621/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9621/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9620 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9620/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9620/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9620/events | https://github.com/NVIDIA/NeMo/pull/9620 | 2,392,703,352 | PR_kwDOC_bI7s50iyXS | 9,620 | Change mixtral moe key name for trt-llm | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-07-05T14:20:47 | 2024-07-05T21:51:02 | 2024-07-05T21:51:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9620",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9620",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9620.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9620.patch",
"merged_at": "2024-07-05T21:51:02"
} | # What does this PR do ?
Fixing an issue related to trt-llm 0.10. | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9620/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9620/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9619 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9619/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9619/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9619/events | https://github.com/NVIDIA/NeMo/pull/9619 | 2,392,564,728 | PR_kwDOC_bI7s50iT_T | 9,619 | [NeMo-UX] Fix when optimizers are setup for PEFT | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-05T12:58:20 | 2024-07-09T04:16:05 | 2024-07-09T04:16:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9619",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9619",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9619.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9619.patch",
"merged_at": "2024-07-09T04:16:04"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9619/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9619/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9618 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9618/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9618/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9618/events | https://github.com/NVIDIA/NeMo/pull/9618 | 2,392,510,447 | PR_kwDOC_bI7s50iH81 | 9,618 | fix: remove non_blocking from PTL's .cuda call | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-05T12:25:43 | 2024-07-05T15:11:15 | 2024-07-05T15:11:14 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9618",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9618",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9618.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9618.patch",
"merged_at": "2024-07-05T15:11:14"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9618/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9618/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9616 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9616/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9616/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9616/events | https://github.com/NVIDIA/NeMo/pull/9616 | 2,390,798,907 | PR_kwDOC_bI7s50cVIs | 9,616 | Fix serialization of AutoResume | {
"login": "sararb",
"id": 17721108,
"node_id": "MDQ6VXNlcjE3NzIxMTA4",
"avatar_url": "https://avatars.githubusercontent.com/u/17721108?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sararb",
"html_url": "https://github.com/sararb",
"followers_url": "https://api.github.com/users/sararb/followers",
"following_url": "https://api.github.com/users/sararb/following{/other_user}",
"gists_url": "https://api.github.com/users/sararb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sararb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sararb/subscriptions",
"organizations_url": "https://api.github.com/users/sararb/orgs",
"repos_url": "https://api.github.com/users/sararb/repos",
"events_url": "https://api.github.com/users/sararb/events{/privacy}",
"received_events_url": "https://api.github.com/users/sararb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-04T12:49:44 | 2024-07-04T14:04:47 | 2024-07-04T14:04:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9616",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9616",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9616.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9616.patch",
"merged_at": "2024-07-04T14:04:45"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9616/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9616/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9615 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9615/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9615/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9615/events | https://github.com/NVIDIA/NeMo/issues/9615 | 2,390,767,492 | I_kwDOC_bI7s6OgDeE | 9,615 | Very poor WER for Conformer_CTC_large model in streaming mode | {
"login": "SerhiiArtemuk",
"id": 32684588,
"node_id": "MDQ6VXNlcjMyNjg0NTg4",
"avatar_url": "https://avatars.githubusercontent.com/u/32684588?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SerhiiArtemuk",
"html_url": "https://github.com/SerhiiArtemuk",
"followers_url": "https://api.github.com/users/SerhiiArtemuk/followers",
"following_url": "https://api.github.com/users/SerhiiArtemuk/following{/other_user}",
"gists_url": "https://api.github.com/users/SerhiiArtemuk/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SerhiiArtemuk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SerhiiArtemuk/subscriptions",
"organizations_url": "https://api.github.com/users/SerhiiArtemuk/orgs",
"repos_url": "https://api.github.com/users/SerhiiArtemuk/repos",
"events_url": "https://api.github.com/users/SerhiiArtemuk/events{/privacy}",
"received_events_url": "https://api.github.com/users/SerhiiArtemuk/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.gi... | null | [
"An offline model is not supposed to be used with cache-aware scripts, specially with small chunk sizes. You need to use cache-aware models like:\r\nhttps://huggingface.co/nvidia/stt_en_fastconformer_hybrid_large_streaming_multi\r\n\r\nRiva does not support cache-aware models publicly yet as far as I know. You may ... | 2024-07-04T12:33:39 | 2024-09-09T01:57:04 | 2024-09-09T01:57:03 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello. I am testing the [STT En Conformer-CTC Large](https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_en_conformer_ctc_large/files) model in streaming mode. To do this, I use the [speech_to_text_cache_aware_streaming_infer.py](https://github.com/NVIDIA/NeMo/blob/main/examples/asr/asr_cache_aware_streaming/speech_to_text_cache_aware_streaming_infer.py) script and the [librispeech-test-other](https://www.openslr.org/12) dataset. With the default `chunk_size` value of 4000 ms, everything works quite well. The WER is 8.67%. However, when I reduce the `chunk_size` to 800 ms, I get very poor results. The WER increases to 35.6%.
I understand that this model was trained with full context in offline mode. And the accuracy would not be very good with small chunks. But I also tested this model in streaming mode (`chunk_size` = 800ms) with RIVA. I converted the nemo model to riva with [nemo2riva](https://github.com/nvidia-riva/nemo2riva) and built a pipeline. In this case, the WER was 7.9%. I understand that the RIVA service contains certain techniques and optimizations for working with the streaming mode. But I wonder why there is such a difference in WER when using the same model and the same chunk size.
Can anyone explain this behavior? Maybe RIVA reconfigures the model in some way or something else that I might have missed? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9615/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9615/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9614 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9614/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9614/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9614/events | https://github.com/NVIDIA/NeMo/issues/9614 | 2,390,642,552 | I_kwDOC_bI7s6Ofk94 | 9,614 | [question] What datasets are used in the training of stt eu model? | {
"login": "SatenHarutyunyan",
"id": 21352981,
"node_id": "MDQ6VXNlcjIxMzUyOTgx",
"avatar_url": "https://avatars.githubusercontent.com/u/21352981?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SatenHarutyunyan",
"html_url": "https://github.com/SatenHarutyunyan",
"followers_url": "https://api.github.com/users/SatenHarutyunyan/followers",
"following_url": "https://api.github.com/users/SatenHarutyunyan/following{/other_user}",
"gists_url": "https://api.github.com/users/SatenHarutyunyan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SatenHarutyunyan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SatenHarutyunyan/subscriptions",
"organizations_url": "https://api.github.com/users/SatenHarutyunyan/orgs",
"repos_url": "https://api.github.com/users/SatenHarutyunyan/repos",
"events_url": "https://api.github.com/users/SatenHarutyunyan/events{/privacy}",
"received_events_url": "https://api.github.com/users/SatenHarutyunyan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.gi... | null | [
"Also, did you use nemo text normalization for text preprocessing? If yes, did you use only it?",
"> Hi. I'm interested what datasets did you use for this model? https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_multilingual_fastconformer_hybrid_large_pc_blend_eu\r\n\r\nWe used a combination of the... | 2024-07-04T11:26:58 | 2024-08-20T16:46:11 | 2024-08-20T16:46:11 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi. I'm interested what datasets did you use for this model?
https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_multilingual_fastconformer_hybrid_large_pc_blend_eu | {
"login": "erastorgueva-nv",
"id": 80532067,
"node_id": "MDQ6VXNlcjgwNTMyMDY3",
"avatar_url": "https://avatars.githubusercontent.com/u/80532067?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erastorgueva-nv",
"html_url": "https://github.com/erastorgueva-nv",
"followers_url": "https://api.github.com/users/erastorgueva-nv/followers",
"following_url": "https://api.github.com/users/erastorgueva-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/erastorgueva-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erastorgueva-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erastorgueva-nv/subscriptions",
"organizations_url": "https://api.github.com/users/erastorgueva-nv/orgs",
"repos_url": "https://api.github.com/users/erastorgueva-nv/repos",
"events_url": "https://api.github.com/users/erastorgueva-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/erastorgueva-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9614/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9614/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9613 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9613/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9613/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9613/events | https://github.com/NVIDIA/NeMo/pull/9613 | 2,390,602,388 | PR_kwDOC_bI7s50bsM5 | 9,613 | Allows non-strict load with distributed checkpoints | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https... | null | [] | 2024-07-04T11:10:16 | 2024-07-12T13:12:28 | 2024-07-12T13:12:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9613",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9613",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9613.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9613.patch",
"merged_at": "2024-07-12T13:12:26"
} | # What does this PR do ?
With distributed checkpoints, the mismatches between the runtime model and checkpoint model manifest during `dist_checkpoint.load` (not during `model.load_state_dict` as with regular checkpoints).
This PR adds a flag that allows to adjust load strictness (e.g. ignore unexpected keys).
This PR relies on MCore feature that is not merged yet (merge ETA 5th July): https://gitlab-master.nvidia.com/ADLR/megatron-lm/-/merge_requests/1628
**Collection**: NLP
# Changelog
- Add `model.dist_ckpt_load_strictness` flag to control dist ckpt load strictness. The most useful value is `log_all` which warns about all mismatches but performs the checkpoint load for a matching state dict subset.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9613/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9613/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9612 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9612/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9612/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9612/events | https://github.com/NVIDIA/NeMo/pull/9612 | 2,390,497,802 | PR_kwDOC_bI7s50bU1W | 9,612 | Alit/mamba tmp | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-07-04T10:15:46 | 2024-07-05T18:00:02 | 2024-07-05T18:00:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9612",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9612",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9612.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9612.patch",
"merged_at": "2024-07-05T18:00:01"
} | # What does this PR do ?
Adding Mamba but commented to resolve mcore hash issue
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9612/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9612/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9611 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9611/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9611/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9611/events | https://github.com/NVIDIA/NeMo/pull/9611 | 2,389,572,138 | PR_kwDOC_bI7s50YLHX | 9,611 | Jsonl support | {
"login": "adityavavre",
"id": 43115743,
"node_id": "MDQ6VXNlcjQzMTE1NzQz",
"avatar_url": "https://avatars.githubusercontent.com/u/43115743?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adityavavre",
"html_url": "https://github.com/adityavavre",
"followers_url": "https://api.github.com/users/adityavavre/followers",
"following_url": "https://api.github.com/users/adityavavre/following{/other_user}",
"gists_url": "https://api.github.com/users/adityavavre/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adityavavre/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adityavavre/subscriptions",
"organizations_url": "https://api.github.com/users/adityavavre/orgs",
"repos_url": "https://api.github.com/users/adityavavre/repos",
"events_url": "https://api.github.com/users/adityavavre/events{/privacy}",
"received_events_url": "https://api.github.com/users/adityavavre/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-03T22:08:16 | 2024-07-04T21:10:51 | 2024-07-04T21:10:51 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9611",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9611",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9611.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9611.patch",
"merged_at": "2024-07-04T21:10:51"
} | # What does this PR do ?
Support for preprocessing jsonl files in a folder.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```
python preprocess_data_for_megatron.py \
--input=/path/to/input/dir \
--preproc-folder \
--json-keys=text \
--tokenizer-library=huggingface \
--tokenizer-type=/path/to/hftokenizer/ \
--output-prefix=/path/to/output/prefix \
--workers=224 \
--log-interval=100000 \
--append-eod
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9611/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9611/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9609 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9609/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9609/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9609/events | https://github.com/NVIDIA/NeMo/pull/9609 | 2,389,186,410 | PR_kwDOC_bI7s50W1Eu | 9,609 | Fix the dictionary format returned by the `scheduler` method | {
"login": "sararb",
"id": 17721108,
"node_id": "MDQ6VXNlcjE3NzIxMTA4",
"avatar_url": "https://avatars.githubusercontent.com/u/17721108?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sararb",
"html_url": "https://github.com/sararb",
"followers_url": "https://api.github.com/users/sararb/followers",
"following_url": "https://api.github.com/users/sararb/following{/other_user}",
"gists_url": "https://api.github.com/users/sararb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sararb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sararb/subscriptions",
"organizations_url": "https://api.github.com/users/sararb/orgs",
"repos_url": "https://api.github.com/users/sararb/repos",
"events_url": "https://api.github.com/users/sararb/events{/privacy}",
"received_events_url": "https://api.github.com/users/sararb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-03T18:09:25 | 2024-07-03T21:46:47 | 2024-07-03T21:46:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9609",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9609",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9609.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9609.patch",
"merged_at": "2024-07-03T21:46:45"
} | # What does this PR do ?
I am changing the dict format returned by `scheduler` method in the new `lightning/optim` module.
I followed the example of `LRSchedulerModule` to create a custom cosine annealing scheduler. My scheduler was returning the dict format:
```
return {
"optimizer": optimizers,
# REQUIRED: The scheduler instance
# `interval` is the unit of the scheduler's step size, could also be 'step'.
# 'epoch' updates the scheduler on epoch end whereas 'step'
# updates it after a optimizer update.
"scheduler": lr_scheduler,
"interval": self.interval,
"frequency": self.frequency,
# Metric to monitor for schedulers like `ReduceLROnPlateau`
"monitor": self.monitor,
}
```
With this format, I was getting a warning:
```
[NeMo W 2024-07-03 16:27:38 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/pytorch_lightning/core/optimizer.py:376: Found unsupported keys in the optimizer configuration: {'scheduler', 'frequency', 'interval'}
```
and the learning rate was not decreasing (which is wrong)
changing it to the following format fixed the issue:
```
return {
"optimizer": optimizers,
# REQUIRED: The scheduler instance
# `interval` is the unit of the scheduler's step size, could also be 'step'.
# 'epoch' updates the scheduler on epoch end whereas 'step'
# updates it after a optimizer update.
"lr_scheduler": {
"scheduler": lr_scheduler,
"interval": self.interval,
"frequency": self.frequency,
},
# Metric to monitor for schedulers like `ReduceLROnPlateau`
"monitor": self.monitor,
}
```
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "sararb",
"id": 17721108,
"node_id": "MDQ6VXNlcjE3NzIxMTA4",
"avatar_url": "https://avatars.githubusercontent.com/u/17721108?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sararb",
"html_url": "https://github.com/sararb",
"followers_url": "https://api.github.com/users/sararb/followers",
"following_url": "https://api.github.com/users/sararb/following{/other_user}",
"gists_url": "https://api.github.com/users/sararb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sararb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sararb/subscriptions",
"organizations_url": "https://api.github.com/users/sararb/orgs",
"repos_url": "https://api.github.com/users/sararb/repos",
"events_url": "https://api.github.com/users/sararb/events{/privacy}",
"received_events_url": "https://api.github.com/users/sararb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9609/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9609/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9608 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9608/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9608/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9608/events | https://github.com/NVIDIA/NeMo/pull/9608 | 2,389,130,700 | PR_kwDOC_bI7s50Wo8T | 9,608 | NeVA Minor Fixes | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
... | closed | false | null | [] | null | [] | 2024-07-03T17:32:35 | 2024-07-06T00:06:51 | 2024-07-06T00:06:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9608",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9608",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9608.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9608.patch",
"merged_at": "2024-07-06T00:06:50"
} | # What does this PR do ?
Fixed an issue for PP > 1 resume.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9608/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9608/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9607 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9607/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9607/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9607/events | https://github.com/NVIDIA/NeMo/pull/9607 | 2,389,072,092 | PR_kwDOC_bI7s50Wb_W | 9,607 | [NeMo-UX] Fix nemo logger when trainer has no loggers | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-03T16:55:53 | 2024-07-03T19:20:11 | 2024-07-03T19:20:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9607",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9607",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9607.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9607.patch",
"merged_at": "2024-07-03T19:20:09"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9607/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9607/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9606 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9606/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9606/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9606/events | https://github.com/NVIDIA/NeMo/pull/9606 | 2,388,941,745 | PR_kwDOC_bI7s50V_az | 9,606 | unpin transformers version | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-07-03T15:39:31 | 2024-07-10T16:37:38 | 2024-07-10T16:37:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9606",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9606",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9606.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9606.patch",
"merged_at": "2024-07-10T16:37:37"
} | # What does this PR do ?
1. Unpins transformers package version.
2. Guards deprecated imports in NeMo which were deleted in transformers >= 4.40
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9606/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9606/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9605 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9605/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9605/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9605/events | https://github.com/NVIDIA/NeMo/pull/9605 | 2,388,287,951 | PR_kwDOC_bI7s50TvAf | 9,605 | Fix bug on Llama 2/3 NeMo to hf convertion | {
"login": "AtsunoriFujita",
"id": 40932835,
"node_id": "MDQ6VXNlcjQwOTMyODM1",
"avatar_url": "https://avatars.githubusercontent.com/u/40932835?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AtsunoriFujita",
"html_url": "https://github.com/AtsunoriFujita",
"followers_url": "https://api.github.com/users/AtsunoriFujita/followers",
"following_url": "https://api.github.com/users/AtsunoriFujita/following{/other_user}",
"gists_url": "https://api.github.com/users/AtsunoriFujita/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AtsunoriFujita/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AtsunoriFujita/subscriptions",
"organizations_url": "https://api.github.com/users/AtsunoriFujita/orgs",
"repos_url": "https://api.github.com/users/AtsunoriFujita/repos",
"events_url": "https://api.github.com/users/AtsunoriFujita/events{/privacy}",
"received_events_url": "https://api.github.com/users/AtsunoriFujita/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "htt... | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was c... | 2024-07-03T10:38:46 | 2024-09-16T01:59:18 | 2024-09-16T01:59:17 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9605",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9605",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9605.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9605.patch",
"merged_at": null
} | # What does this PR do ?
Fix the script to convert Llama 2/3 from .nemo format to hf format. This will resolve #9496
**Collection**: [Note which collection this PR will affect]
# Changelog
- In Llama3, basically `AutoTokenizer` (fast tokenizer) is used, but in Llama2 and other derivatives, both (`LlamaTokenizer` and `AutoTokenizer`) are used. This PR works both patterns.
# Usage
No changes in API
```python
# llama3
export INPUT="/workspace/models/Meta-Llama-3-8B.nemo"
export OUTPUT="/workspace/models/llama3-8b/pytorch_model.bin"
python /opt/NeMo/scripts/checkpoint_converters/convert_llama_nemo_to_hf.py \
--input_name_or_path=${INPUT} \
--output_path=${OUTPUT} \
--hf_input_path /workspace/models/Meta-Llama-3-8B \
--hf_output_path /workspace/models/llama3-8b \
--input_tokenizer /workspace/models/Meta-Llama-3-8B \
--hf_output_tokenizer /workspace/models/llama3-8b
# llama2
export INPUT="/workspace/models/Llama-2-7b-hf.nemo"
export OUTPUT="/workspace/models/llama2-7b/pytorch_model.bin"
python /opt/NeMo/scripts/checkpoint_converters/convert_llama_nemo_to_hf.py \
--input_name_or_path=${INPUT} \
--output_path=${OUTPUT} \
--hf_input_path /workspace/models/Llama-2-7b-hf \
--hf_output_path /workspace/models/llama2-7b \
--input_tokenizer /workspace/models/Llama-2-7b-hf \
--hf_output_tokenizer /workspace/models/llama2-7b
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #9496
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9605/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9605/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9604 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9604/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9604/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9604/events | https://github.com/NVIDIA/NeMo/pull/9604 | 2,388,069,001 | PR_kwDOC_bI7s50S_DE | 9,604 | Support enabling inference server only in megatron_gpt_eval.py | {
"login": "gleibovich-nvidia",
"id": 150582838,
"node_id": "U_kgDOCPm2Ng",
"avatar_url": "https://avatars.githubusercontent.com/u/150582838?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gleibovich-nvidia",
"html_url": "https://github.com/gleibovich-nvidia",
"followers_url": "https://api.github.com/users/gleibovich-nvidia/followers",
"following_url": "https://api.github.com/users/gleibovich-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/gleibovich-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gleibovich-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gleibovich-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/gleibovich-nvidia/orgs",
"repos_url": "https://api.github.com/users/gleibovich-nvidia/repos",
"events_url": "https://api.github.com/users/gleibovich-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/gleibovich-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "htt... | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-07-03T08:55:05 | 2024-07-18T07:33:41 | 2024-07-18T07:33:41 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9604",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9604",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9604.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9604.patch",
"merged_at": null
} | # What does this PR do ?
Support enabling inference server only in megatron_gpt_eval.py, thus overriding the first and second examples if `cfg.prompts` is empty.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "gleibovich-nvidia",
"id": 150582838,
"node_id": "U_kgDOCPm2Ng",
"avatar_url": "https://avatars.githubusercontent.com/u/150582838?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gleibovich-nvidia",
"html_url": "https://github.com/gleibovich-nvidia",
"followers_url": "https://api.github.com/users/gleibovich-nvidia/followers",
"following_url": "https://api.github.com/users/gleibovich-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/gleibovich-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gleibovich-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gleibovich-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/gleibovich-nvidia/orgs",
"repos_url": "https://api.github.com/users/gleibovich-nvidia/repos",
"events_url": "https://api.github.com/users/gleibovich-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/gleibovich-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9604/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9604/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9603 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9603/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9603/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9603/events | https://github.com/NVIDIA/NeMo/pull/9603 | 2,388,065,883 | PR_kwDOC_bI7s50S-Y2 | 9,603 | Akoumparouli/nemo ux mixtral export | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.co... | null | [] | 2024-07-03T08:53:33 | 2024-07-05T08:43:27 | 2024-07-05T08:43:26 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9603",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9603",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9603.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9603.patch",
"merged_at": "2024-07-05T08:43:26"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9603/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9603/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9602 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9602/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9602/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9602/events | https://github.com/NVIDIA/NeMo/pull/9602 | 2,388,002,654 | PR_kwDOC_bI7s50Swme | 9,602 | Remove .cuda calls, use device isntead | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.co... | null | [] | 2024-07-03T08:23:22 | 2024-07-05T06:05:06 | 2024-07-05T06:05:04 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9602",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9602",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9602.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9602.patch",
"merged_at": "2024-07-05T06:05:04"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9602/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9602/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9601 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9601/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9601/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9601/events | https://github.com/NVIDIA/NeMo/pull/9601 | 2,387,910,490 | PR_kwDOC_bI7s50Scyq | 9,601 | Set no_sync_func & grad_sync_fucn | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.co... | null | [] | 2024-07-03T07:39:10 | 2024-07-03T16:55:52 | 2024-07-03T16:55:50 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9601",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9601",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9601.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9601.patch",
"merged_at": "2024-07-03T16:55:50"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9601/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9601/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9600 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9600/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9600/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9600/events | https://github.com/NVIDIA/NeMo/pull/9600 | 2,387,875,271 | PR_kwDOC_bI7s50SVL3 | 9,600 | Triton deployment improvements for in-framework models | {
"login": "jukim-nv",
"id": 18061559,
"node_id": "MDQ6VXNlcjE4MDYxNTU5",
"avatar_url": "https://avatars.githubusercontent.com/u/18061559?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jukim-nv",
"html_url": "https://github.com/jukim-nv",
"followers_url": "https://api.github.com/users/jukim-nv/followers",
"following_url": "https://api.github.com/users/jukim-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/jukim-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jukim-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jukim-nv/subscriptions",
"organizations_url": "https://api.github.com/users/jukim-nv/orgs",
"repos_url": "https://api.github.com/users/jukim-nv/repos",
"events_url": "https://api.github.com/users/jukim-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/jukim-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [
"Could you please address all of these CodeQL reviews?"
] | 2024-07-03T07:21:11 | 2024-07-09T17:30:18 | 2024-07-09T17:30:18 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9600",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9600",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9600.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9600.patch",
"merged_at": "2024-07-09T17:30:18"
} | # What does this PR do ?
Adding better support for triton deployment of in-framework models using `MegatronLLMDeployable`.
**Collection**: [Note which collection this PR will affect]
scripts/deploy
tests/deploy
# Changelog
- Add `NemoQueryLLMPyTorch` class for easy query of `MegatronLLMDeployable`
- Changes to `nemo_export.py` to accurately test `MegatronLLMDeployable` models
- A separate `deploy_inframework_triton.py` deployment script to easily deploy `MegatronLLMDeployable` on a Triton server
# Usage
```
python scripts/deploy/nlp/deploy_inframework_triton.py -nc <path to .nemo checkpoint> -tmn TritonModelName
python tests/export/nemo_export.py --checkpoint_dir <path to .nemo checkpoint> --model_type gpt --min_tps 1 --max_output_len 24 --test_deployment False --in_framework True --model_name TritonModelName
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9600/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9600/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9599 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9599/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9599/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9599/events | https://github.com/NVIDIA/NeMo/pull/9599 | 2,387,850,686 | PR_kwDOC_bI7s50SP0N | 9,599 | [NeMo-UX] Fix Megatron-optimizer | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-03T07:08:17 | 2024-07-03T16:53:27 | 2024-07-03T16:47:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9599",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9599",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9599.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9599.patch",
"merged_at": "2024-07-03T16:47:50"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9599/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9599/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9598 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9598/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9598/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9598/events | https://github.com/NVIDIA/NeMo/issues/9598 | 2,387,597,833 | I_kwDOC_bI7s6OT9oJ | 9,598 | Internal error when running model.transcribe() on FastConformer-Hybrid-Transducer-CTC-BPE model. | {
"login": "MarcisTU",
"id": 40321296,
"node_id": "MDQ6VXNlcjQwMzIxMjk2",
"avatar_url": "https://avatars.githubusercontent.com/u/40321296?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MarcisTU",
"html_url": "https://github.com/MarcisTU",
"followers_url": "https://api.github.com/users/MarcisTU/followers",
"following_url": "https://api.github.com/users/MarcisTU/following{/other_user}",
"gists_url": "https://api.github.com/users/MarcisTU/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MarcisTU/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MarcisTU/subscriptions",
"organizations_url": "https://api.github.com/users/MarcisTU/orgs",
"repos_url": "https://api.github.com/users/MarcisTU/repos",
"events_url": "https://api.github.com/users/MarcisTU/events{/privacy}",
"received_events_url": "https://api.github.com/users/MarcisTU/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
... | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.gi... | null | [
"@KunalDhawan pls have a look at this issue. ",
"Hi @MarcisTU, Thank you for the detailed description! Could you please help me reproduce the issue? \r\n\r\nI tried to replicate the issue on my end but I am able to run the code snippet you shared above without any errors. Let me describe my replication setup in d... | 2024-07-03T03:43:25 | 2024-12-06T14:19:37 | 2024-09-09T01:57:07 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
After following installation instructions for Linux there is a weird bug about torch tensor not being on CPU when converting to numpy.
```
Transcribing: 0%| | 0/1 [00:02<?, ?it/s]
Traceback (most recent call last):
File "/root/inference_fastconformer_stt_lv.py", line 29, in <module>
hypotheses = asr_model.transcribe(input_wav, return_hypotheses=True)
File "/opt/conda/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/nemo/collections/asr/models/hybrid_rnnt_ctc_models.py", line 138, in transcribe
return super().transcribe(
File "/opt/conda/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/nemo/collections/asr/models/rnnt_models.py", line 279, in transcribe
return super().transcribe(
File "/opt/conda/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/nemo/collections/asr/parts/mixins/transcription.py", line 274, in transcribe
for processed_outputs in generator:
File "/opt/conda/lib/python3.10/site-packages/nemo/collections/asr/parts/mixins/transcription.py", line 385, in transcribe_generator
processed_outputs = self._transcribe_output_processing(model_outputs, transcribe_cfg)
File "/opt/conda/lib/python3.10/site-packages/nemo/collections/asr/models/hybrid_rnnt_ctc_models.py", line 179, in _transcribe_output_processing
return super()._transcribe_output_processing(outputs, trcfg)
File "/opt/conda/lib/python3.10/site-packages/nemo/collections/asr/models/rnnt_models.py", line 908, in _transcribe_output_processing
best_hyp, all_hyp = self.decoding.rnnt_decoder_predictions_tensor(
File "/opt/conda/lib/python3.10/site-packages/nemo/collections/asr/parts/submodules/rnnt_decoding.py", line 510, in rnnt_decoder_predictions_tensor
hypotheses[hyp_idx] = self.compute_rnnt_timestamps(hypotheses[hyp_idx], timestamp_type)
File "/opt/conda/lib/python3.10/site-packages/nemo/collections/asr/parts/submodules/rnnt_decoding.py", line 741, in compute_rnnt_timestamps
char_offsets = self._compute_offsets(hypothesis, token_repetitions, self.blank_id)
File "/opt/conda/lib/python3.10/site-packages/nemo/collections/asr/parts/submodules/rnnt_decoding.py", line 851, in _compute_offsets
start_indices = np.concatenate(([start_index], end_indices[:-1]))
File "/opt/conda/lib/python3.10/site-packages/torch/_tensor.py", line 1062, in __array__
return self.numpy()
TypeError: can't convert cuda:0 device type tensor to numpy. Use Tensor.cpu() to copy the tensor to host memory first.
```
**Steps/Code to reproduce bug**
Code to reproduce:
```
import copy
import torch
import librosa
from omegaconf import OmegaConf, open_dict
from nemo.collections.asr.models import EncDecHybridRNNTCTCBPEModel
if __name__ == "__main__":
asr_model_path = "./nemo_experiments/FastConformer-Hybrid-Transducer-CTC-BPE/2024-07-02_09-14-19/checkpoints/FastConformer-Hybrid-Transducer-CTC-BPE.nemo"
asr_model = EncDecHybridRNNTCTCBPEModel.restore_from(restore_path=asr_model_path)
device = torch.device('cuda' if torch.cuda.is_available() else 'cpu')
audio_path = "./test_data/2321187.wav"
input_wav, sr = librosa.load(audio_path, sr=16000)
decoding_cfg = copy.deepcopy(asr_model.cfg.decoding)
with open_dict(decoding_cfg):
decoding_cfg.preserve_alignments = True
decoding_cfg.compute_timestamps = True
asr_model.change_decoding_strategy(decoding_cfg)
# specify flag `return_hypotheses=True``
hypotheses = asr_model.transcribe(input_wav, return_hypotheses=True)
# if hypotheses form a tuple (from RNNT), extract just "best" hypotheses
if type(hypotheses) == tuple and len(hypotheses) == 2:
hypotheses = hypotheses[0]
timestamp_dict = hypotheses[0].timestep # extract timesteps from hypothesis of first (and only) audio file
print("Hypothesis contains following timestep information :", list(timestamp_dict.keys()))
# For a FastConformer model, you can display the word timestamps as follows:
# 80ms is duration of a timestep at output of the Conformer
time_stride = 8 * asr_model.cfg.preprocessor.window_stride
word_timestamps = timestamp_dict['word']
for stamp in word_timestamps:
start = stamp['start_offset'] * time_stride
end = stamp['end_offset'] * time_stride
word = stamp['char'] if 'char' in stamp else stamp['word']
print(f"Time : {start:0.2f} - {end:0.2f} - {word}")
```
**Expected behavior**
Inference code runs and it is possible to get the result.
**Environment overview (please complete the following information)**
- Environment location: Vast.ai instance.
- Method of NeMo install: pip install from source.
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version Ubuntu 22
- PyTorch version 2.2.1
- Python version 3.11
**Additional context**
Also tried to install in WSL2 windows, but got the same bug.
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9598/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9598/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9597 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9597/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9597/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9597/events | https://github.com/NVIDIA/NeMo/pull/9597 | 2,387,274,499 | PR_kwDOC_bI7s50QSHe | 9,597 | Fix semi_sorted paper link | {
"login": "orena1",
"id": 8983713,
"node_id": "MDQ6VXNlcjg5ODM3MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/8983713?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/orena1",
"html_url": "https://github.com/orena1",
"followers_url": "https://api.github.com/users/orena1/followers",
"following_url": "https://api.github.com/users/orena1/following{/other_user}",
"gists_url": "https://api.github.com/users/orena1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/orena1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/orena1/subscriptions",
"organizations_url": "https://api.github.com/users/orena1/orgs",
"repos_url": "https://api.github.com/users/orena1/repos",
"events_url": "https://api.github.com/users/orena1/events{/privacy}",
"received_events_url": "https://api.github.com/users/orena1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
... | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"@titu1994 why this was closed? ",
"@nithinraok why is this closed? sh... | 2024-07-02T22:38:18 | 2024-10-04T11:42:04 | 2024-10-04T11:42:04 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9597",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9597",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9597.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9597.patch",
"merged_at": "2024-10-04T11:42:04"
} | # What does this PR do ?
Fix semi_sorted paper link
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9597/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9597/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9596 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9596/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9596/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9596/events | https://github.com/NVIDIA/NeMo/pull/9596 | 2,387,024,434 | PR_kwDOC_bI7s50Pame | 9,596 | vLLM Export Improvements | {
"login": "apanteleev",
"id": 11079788,
"node_id": "MDQ6VXNlcjExMDc5Nzg4",
"avatar_url": "https://avatars.githubusercontent.com/u/11079788?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/apanteleev",
"html_url": "https://github.com/apanteleev",
"followers_url": "https://api.github.com/users/apanteleev/followers",
"following_url": "https://api.github.com/users/apanteleev/following{/other_user}",
"gists_url": "https://api.github.com/users/apanteleev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/apanteleev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/apanteleev/subscriptions",
"organizations_url": "https://api.github.com/users/apanteleev/orgs",
"repos_url": "https://api.github.com/users/apanteleev/repos",
"events_url": "https://api.github.com/users/apanteleev/events{/privacy}",
"received_events_url": "https://api.github.com/users/apanteleev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-02T19:45:01 | 2024-07-03T13:28:12 | 2024-07-03T13:28:11 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9596",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9596",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9596.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9596.patch",
"merged_at": "2024-07-03T13:28:11"
} | # What does this PR do ?
Adds support for LLAMA3 and fixes a few other issues with vLLM.
**Collection**: NLP
# Changelog
- Separated the vLLM export functionality from the common deployment script into deploy_vllm_triton.py.
- Fixed LLAMA3 exprot (wrong vocab_size)
- Improved the export test.
**PR Type**:
- [X] Bugfix
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9596/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9596/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9595 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9595/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9595/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9595/events | https://github.com/NVIDIA/NeMo/pull/9595 | 2,386,848,426 | PR_kwDOC_bI7s50OzYu | 9,595 | [NeMo-UX] Dataloading enhancements and bug fixes | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-02T18:02:20 | 2024-07-04T08:00:41 | 2024-07-04T08:00:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9595",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9595",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9595.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9595.patch",
"merged_at": "2024-07-04T08:00:39"
} | # What does this PR do ?
- Adds support for passing multiple paths to `PreTrainingDataModule`
- Provides support for resuming dataloader when restoring from a checkpoint
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9595/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9595/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9594 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9594/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9594/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9594/events | https://github.com/NVIDIA/NeMo/pull/9594 | 2,386,696,347 | PR_kwDOC_bI7s50OSMh | 9,594 | Update NeMo Clip to Use MCore Modules | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-07-02T16:34:39 | 2024-07-08T16:20:35 | 2024-07-08T16:20:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9594",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9594",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9594.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9594.patch",
"merged_at": "2024-07-08T16:20:33"
} | # What does this PR do ?
Update NeMo Clip to Use MCore Modules. Add SigLIP supports.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9594/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9594/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9593 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9593/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9593/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9593/events | https://github.com/NVIDIA/NeMo/pull/9593 | 2,386,581,346 | PR_kwDOC_bI7s50N4yG | 9,593 | Set n_gpu to None in nemo export | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-07-02T15:35:07 | 2024-07-02T19:59:37 | 2024-07-02T19:59:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9593",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9593",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9593.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9593.patch",
"merged_at": "2024-07-02T19:59:36"
} | # What does this PR do ?
Change ngpu to none to use tensor_parallelism_size param. | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9593/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9593/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9592 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9592/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9592/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9592/events | https://github.com/NVIDIA/NeMo/pull/9592 | 2,386,475,536 | PR_kwDOC_bI7s50NhVq | 9,592 | [Nemo-UX] Expose transformer_layer_spec inside GPTConfig | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-02T14:50:39 | 2024-07-08T15:50:38 | 2024-07-08T15:50:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9592",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9592",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9592.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9592.patch",
"merged_at": "2024-07-08T15:50:37"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9592/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9592/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9591 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9591/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9591/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9591/events | https://github.com/NVIDIA/NeMo/pull/9591 | 2,386,169,544 | PR_kwDOC_bI7s50Mdkq | 9,591 | [NeMo-UX] Some improvements to NeMoLogger | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-02T12:48:30 | 2024-07-02T18:36:56 | 2024-07-02T18:36:55 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9591",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9591",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9591.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9591.patch",
"merged_at": "2024-07-02T18:36:55"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9591/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9591/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9590 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9590/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9590/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9590/events | https://github.com/NVIDIA/NeMo/pull/9590 | 2,386,145,193 | PR_kwDOC_bI7s50MYQU | 9,590 | Use torch sdpa implementation in ASR mha | {
"login": "WoodieDudy",
"id": 55787608,
"node_id": "MDQ6VXNlcjU1Nzg3NjA4",
"avatar_url": "https://avatars.githubusercontent.com/u/55787608?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/WoodieDudy",
"html_url": "https://github.com/WoodieDudy",
"followers_url": "https://api.github.com/users/WoodieDudy/followers",
"following_url": "https://api.github.com/users/WoodieDudy/following{/other_user}",
"gists_url": "https://api.github.com/users/WoodieDudy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/WoodieDudy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/WoodieDudy/subscriptions",
"organizations_url": "https://api.github.com/users/WoodieDudy/orgs",
"repos_url": "https://api.github.com/users/WoodieDudy/repos",
"events_url": "https://api.github.com/users/WoodieDudy/events{/privacy}",
"received_events_url": "https://api.github.com/users/WoodieDudy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [
"I also attempted to run the tests in the repository but encountered an issue. NaNs appear when a mask with a fully False row is passed to MHA. Because of such mask, filling the `matrix_bd` with `-inf` values using `matrix_bd.masked_fill_(mask.logical_not(), float(\"-inf\"))` results in a row of only `-inf`, and af... | 2024-07-02T12:37:17 | 2024-10-16T02:17:19 | 2024-10-16T02:17:19 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9590",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9590",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9590.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9590.patch",
"merged_at": "2024-10-16T02:17:19"
} | Hola. I changed the mha implementation for the ASR modules so that it uses `torch.nn.functional.scaled_dot_product_attention`.
This accelerated forward in the mha by 27% and backward by 17% on the A100.
Pytorch sdpa is continuously being optimized, ensuring that we benefit from the latest performance improvements.
My code uses [memory efficient backend](https://pytorch.org/docs/stable/generated/torch.nn.functional.scaled_dot_product_attention.html) in sdpa because flash attention doesn't support custom attention bias. There is ongoing work to contribute custom bias support in the flash-attention repository. [PR](https://github.com/Dao-AILab/flash-attention/pull/617).
What else do I need to do to merge this pr?
## Usage
There is also my benchmark:
```python
import torch
import torch.nn as nn
import torch.utils.benchmark as benchmark
from nemo.collections.asr.parts.submodules.multi_head_attention import RelPositionMultiHeadAttention
torch.manual_seed(123)
device = "cuda"
batch_size = 32
seq_len = 1024
d_model = 512
n_head = 8
query = torch.rand(batch_size, seq_len, d_model, device=device, requires_grad=True)
key = torch.rand(batch_size, seq_len, d_model, device=device, requires_grad=True)
value = torch.rand(batch_size, seq_len, d_model, device=device, requires_grad=True)
mask = torch.ones(batch_size, seq_len, seq_len, device=device, requires_grad=False)
mask = torch.triu(mask, diagonal=1).bool() # mask: True - make zero, False - leave unchanged
mask = None
pos_emb = torch.rand(batch_size, seq_len, d_model, device=device, requires_grad=True)
attention_sdpa = RelPositionMultiHeadAttention(n_head, d_model, 0.0, None, None, use_pytorch_sdpa=True).to(device)
attention_original = RelPositionMultiHeadAttention(n_head, d_model, 0.0, None, None, use_pytorch_sdpa=False).to(device)
for original_param, sdpa_param in zip(attention_original.parameters(), attention_sdpa.parameters()):
original_param.data.copy_(sdpa_param.data)
# attention_sdpa = torch.compile(attention_sdpa)
# attention_original = torch.compile(attention_original)
def measure_time(attention, query, key, value, mask, pos_emb):
timer = benchmark.Timer(
stmt='attention(query, key, value, mask, pos_emb);torch.cuda.synchronize()',
setup='torch.cuda.synchronize()',
globals={'attention': attention, 'query': query, 'key': key, 'value': value, 'mask': mask, 'pos_emb': pos_emb}
)
with torch.no_grad():
torch.cuda.synchronize()
results = timer.blocked_autorange(min_run_time=10)
forward_time = results.mean
output = attention(query, key, value, mask, pos_emb)
return forward_time, output
def measure_fwd_bwd_time(attention, query, key, value, mask, pos_emb):
timer = benchmark.Timer(
stmt='loss=attention(query, key, value, mask, pos_emb).sum();torch.cuda.synchronize();loss.backward();torch.cuda.synchronize()',
globals={'attention': attention, 'query': query, 'key': key, 'value': value, 'mask': mask, 'pos_emb': pos_emb}
)
torch.cuda.synchronize()
results = timer.blocked_autorange(min_run_time=10)
fwd_bwd_time = results.mean
return fwd_bwd_time
time_fwd_original, output_original = measure_time(attention_original, query, key, value, mask, pos_emb)
time_fwd_sdpa, output_sdpa = measure_time(attention_sdpa, query, key, value, mask, pos_emb)
print(f"Original implementation time: {time_fwd_original:.6f} seconds")
print(f"SDPA implementation time: {time_fwd_sdpa:.6f} seconds")
print(f"SDPA boost {(time_fwd_original - time_fwd_sdpa) / time_fwd_original * 100:.2f}%")
time_fwd_bwd_original = measure_fwd_bwd_time(attention_original, query, key, value, mask, pos_emb)
time_fwd_bwd_sdpa = measure_fwd_bwd_time(attention_sdpa, query, key, value, mask, pos_emb)
time_bwd_original = time_fwd_bwd_original - time_fwd_original
time_bwd_sdpa = time_fwd_bwd_sdpa - time_fwd_sdpa
print(f"Original implementation backward time: {time_bwd_original:.6f} seconds")
print(f"SDPA implementation backward time: {time_bwd_sdpa:.6f} seconds")
print(f"SDPA backward boost {(time_bwd_original - time_bwd_sdpa) / time_bwd_original * 100:.2f}%")
print(f"Outputs are {'the same' if torch.allclose(output_original, output_sdpa, atol=1e-5) else 'different'}")
# Original implementation time: 0.049075 seconds
# SDPA implementation time: 0.035598 seconds
# SDPA boost 27.46%
# Original implementation backward time: 0.127004 seconds
# SDPA implementation backward time: 0.104986 seconds
# SDPA backward boost 17.34%
# Outputs are the same
```
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
## Who can review?
cc @titu1994 @SeanNaren
## Additional Information
* Related to [(issue)](https://github.com/NVIDIA/NeMo/issues/6257)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9590/reactions",
"total_count": 4,
"+1": 3,
"-1": 0,
"laugh": 0,
"hooray": 1,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9590/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9589 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9589/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9589/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9589/events | https://github.com/NVIDIA/NeMo/pull/9589 | 2,386,012,387 | PR_kwDOC_bI7s50L7Cn | 9,589 | [Nemo-UX] Add SDK-factories to llm-collection | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-02T11:31:18 | 2024-07-02T12:59:28 | 2024-07-02T12:59:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9589",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9589",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9589.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9589.patch",
"merged_at": "2024-07-02T12:59:27"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9589/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9589/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9588 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9588/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9588/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9588/events | https://github.com/NVIDIA/NeMo/pull/9588 | 2,385,476,044 | PR_kwDOC_bI7s50KGwN | 9,588 | Updating NeVA tutorial | {
"login": "paul-gibbons",
"id": 87940629,
"node_id": "MDQ6VXNlcjg3OTQwNjI5",
"avatar_url": "https://avatars.githubusercontent.com/u/87940629?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/paul-gibbons",
"html_url": "https://github.com/paul-gibbons",
"followers_url": "https://api.github.com/users/paul-gibbons/followers",
"following_url": "https://api.github.com/users/paul-gibbons/following{/other_user}",
"gists_url": "https://api.github.com/users/paul-gibbons/gists{/gist_id}",
"starred_url": "https://api.github.com/users/paul-gibbons/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/paul-gibbons/subscriptions",
"organizations_url": "https://api.github.com/users/paul-gibbons/orgs",
"repos_url": "https://api.github.com/users/paul-gibbons/repos",
"events_url": "https://api.github.com/users/paul-gibbons/events{/privacy}",
"received_events_url": "https://api.github.com/users/paul-gibbons/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "htt... | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-02T07:35:43 | 2024-07-30T01:50:42 | 2024-07-30T01:50:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9588",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9588",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9588.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9588.patch",
"merged_at": null
} | # What does this PR do ?
Adding information regarding new features in Neva and refreshes the training script examples to account for changes in upcoming NeMo release.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9588/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9588/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9587 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9587/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9587/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9587/events | https://github.com/NVIDIA/NeMo/pull/9587 | 2,385,031,967 | PR_kwDOC_bI7s50ImYn | 9,587 | Gemma 2 | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [
"closing this in favor of #9672"
] | 2024-07-02T01:55:12 | 2024-07-10T18:36:59 | 2024-07-10T18:36:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9587",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9587",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9587.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9587.patch",
"merged_at": null
} | # What does this PR do ?
Add Gemma 2 support
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9587/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9587/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9586 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9586/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9586/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9586/events | https://github.com/NVIDIA/NeMo/pull/9586 | 2,384,951,999 | PR_kwDOC_bI7s50IVcL | 9,586 | [pre-commit.ci] pre-commit suggestions | {
"login": "pre-commit-ci[bot]",
"id": 66853113,
"node_id": "MDM6Qm90NjY4NTMxMTM=",
"avatar_url": "https://avatars.githubusercontent.com/in/68672?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D",
"html_url": "https://github.com/apps/pre-commit-ci",
"followers_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-02T00:18:22 | 2024-07-24T01:50:30 | 2024-07-24T01:50:29 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9586",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9586",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9586.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9586.patch",
"merged_at": null
} | <!--pre-commit.ci start-->
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.6.0](https://github.com/pre-commit/pre-commit-hooks/compare/v4.3.0...v4.6.0)
- [github.com/psf/black-pre-commit-mirror: 24.3.0 → 24.4.2](https://github.com/psf/black-pre-commit-mirror/compare/24.3.0...24.4.2)
<!--pre-commit.ci end--> | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9586/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9586/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9585 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9585/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9585/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9585/events | https://github.com/NVIDIA/NeMo/pull/9585 | 2,384,771,161 | PR_kwDOC_bI7s50HtVe | 9,585 | Set TE flag in legacy -> mcore conversion script | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-01T21:31:42 | 2024-07-12T17:05:08 | 2024-07-01T23:46:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9585",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9585",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9585.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9585.patch",
"merged_at": "2024-07-01T23:46:53"
} | # What does this PR do ?
Fix TE flag in response to recent change where mcore models now default to mcore local specs unless `transformer_engine` flag is set to true. Previously, it always used TE specs.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9585/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9585/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9584 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9584/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9584/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9584/events | https://github.com/NVIDIA/NeMo/pull/9584 | 2,384,656,787 | PR_kwDOC_bI7s50HTx7 | 9,584 | Adding support for mcore T5 PEFT | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "htt... | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-01T20:15:09 | 2024-11-19T17:11:28 | 2024-08-01T01:55:17 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9584",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9584",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9584.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9584.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9584/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9584/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9583 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9583/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9583/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9583/events | https://github.com/NVIDIA/NeMo/pull/9583 | 2,384,655,510 | PR_kwDOC_bI7s50HTf9 | 9,583 | Adding support for mcore T5 generating/inferencing | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "htt... | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-01T20:14:20 | 2024-07-24T01:50:31 | 2024-07-24T01:50:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9583",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9583",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9583.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9583.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9583/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9583/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9582 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9582/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9582/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9582/events | https://github.com/NVIDIA/NeMo/pull/9582 | 2,384,648,289 | PR_kwDOC_bI7s50HR5_ | 9,582 | first commit, adding support for T5 PEFT | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-01T20:09:17 | 2024-07-01T20:14:48 | 2024-07-01T20:14:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9582",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9582",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9582.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9582.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9582/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9582/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9581 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9581/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9581/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9581/events | https://github.com/NVIDIA/NeMo/pull/9581 | 2,384,630,056 | PR_kwDOC_bI7s50HN5E | 9,581 | Huvu/mcore t5 inference | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
... | closed | false | null | [] | null | [] | 2024-07-01T19:57:47 | 2024-07-01T20:13:46 | 2024-07-01T20:13:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9581",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9581",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9581.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9581.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9581/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9581/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9580 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9580/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9580/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9580/events | https://github.com/NVIDIA/NeMo/pull/9580 | 2,384,513,675 | PR_kwDOC_bI7s50G1bp | 9,580 | Update click version requirement | {
"login": "thomasdhc",
"id": 9426164,
"node_id": "MDQ6VXNlcjk0MjYxNjQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/thomasdhc",
"html_url": "https://github.com/thomasdhc",
"followers_url": "https://api.github.com/users/thomasdhc/followers",
"following_url": "https://api.github.com/users/thomasdhc/following{/other_user}",
"gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions",
"organizations_url": "https://api.github.com/users/thomasdhc/orgs",
"repos_url": "https://api.github.com/users/thomasdhc/repos",
"events_url": "https://api.github.com/users/thomasdhc/events{/privacy}",
"received_events_url": "https://api.github.com/users/thomasdhc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-01T18:47:20 | 2024-07-01T20:00:09 | 2024-07-01T20:00:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9580",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9580",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9580.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9580.patch",
"merged_at": "2024-07-01T20:00:07"
} | # What does this PR do ?
Update click version requirement.
**Collection**: [test]
# Changelog
- Update click version requirement to be greater or equal to 8.1
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "thomasdhc",
"id": 9426164,
"node_id": "MDQ6VXNlcjk0MjYxNjQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/thomasdhc",
"html_url": "https://github.com/thomasdhc",
"followers_url": "https://api.github.com/users/thomasdhc/followers",
"following_url": "https://api.github.com/users/thomasdhc/following{/other_user}",
"gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions",
"organizations_url": "https://api.github.com/users/thomasdhc/orgs",
"repos_url": "https://api.github.com/users/thomasdhc/repos",
"events_url": "https://api.github.com/users/thomasdhc/events{/privacy}",
"received_events_url": "https://api.github.com/users/thomasdhc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9580/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9580/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9579 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9579/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9579/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9579/events | https://github.com/NVIDIA/NeMo/pull/9579 | 2,384,387,644 | PR_kwDOC_bI7s50Gak7 | 9,579 | NeMo MoE docs | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.co... | null | [] | 2024-07-01T17:31:58 | 2024-08-07T21:42:11 | 2024-07-24T03:38:12 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9579",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9579",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9579.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9579.patch",
"merged_at": "2024-07-24T03:38:12"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9579/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9579/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9578 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9578/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9578/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9578/events | https://github.com/NVIDIA/NeMo/pull/9578 | 2,384,171,936 | PR_kwDOC_bI7s50FqpR | 9,578 | LITA integration | {
"login": "Slyne",
"id": 6286804,
"node_id": "MDQ6VXNlcjYyODY4MDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6286804?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Slyne",
"html_url": "https://github.com/Slyne",
"followers_url": "https://api.github.com/users/Slyne/followers",
"following_url": "https://api.github.com/users/Slyne/following{/other_user}",
"gists_url": "https://api.github.com/users/Slyne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Slyne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Slyne/subscriptions",
"organizations_url": "https://api.github.com/users/Slyne/orgs",
"repos_url": "https://api.github.com/users/Slyne/repos",
"events_url": "https://api.github.com/users/Slyne/events{/privacy}",
"received_events_url": "https://api.github.com/users/Slyne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://a... | closed | false | null | [] | null | [
"TO DO LIST:\r\n1. to move `convert_llava_hf_to_nemo.py`\r\n2. to add tutorial"
] | 2024-07-01T15:43:37 | 2024-07-11T01:24:24 | 2024-07-11T01:24:24 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9578",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9578",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9578.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9578.patch",
"merged_at": "2024-07-11T01:24:24"
} | # What does this PR do ?
This PR aims to add [LITA](https://github.com/NVlabs/LITA) from checkpoint conversion, dataset preprocessing for DVC datasets to finetuning.
It also adds vila to the lita model.
**Collection**: [Note which collection this PR will affect]
* multimodal
* nlp
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9578/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9578/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9577 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9577/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9577/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9577/events | https://github.com/NVIDIA/NeMo/pull/9577 | 2,384,121,641 | PR_kwDOC_bI7s50Ffm0 | 9,577 | [Nemo-UX] Add fabric-API for manual forward-pass | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-01T15:19:22 | 2024-07-02T11:14:51 | 2024-07-02T11:14:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9577",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9577",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9577.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9577.patch",
"merged_at": "2024-07-02T11:14:50"
} | # What does this PR do ?
Adds the Fabric-API to nemo 2
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
from nemo import lightning as nl
from nemo.collections.llm import MistralModel, MockDataModule
trainer = nl.Trainer(
devices=2,
strategy=nl.MegatronStrategy(tensor_model_parallel_size=2),
plugins=nl.MegatronMixedPrecision(precision='16-mixed')
)
fabric = trainer.to_fabric()
# Import model
model = fabric.import_model("hf://mistralai/Mistral-7B-v0.1", MistralModel)
# Load model
# model = fabric.load_model("/workspaces/llm-workspace/nemo_experiments/default/2024-07-02_01-14-20/checkpoints/default--reduced_train_loss=nan-epoch=0")
fabric.print(type(model))
# The model here will be the MistralModel wrapped by the MegatronStrategy
# Some dummy data
dataset = MockDataModule(tokenizer=model.module.tokenizer).train_dataloader()
batch = next(iter(dataset))
fabric.print(batch)
# Manual model forward
output = model(
batch,
forward_step=model.config.forward_step_fn,
loss_reduction=model.module.validation_loss_reduction(),
)
fabric.print(output)
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9577/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9577/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9576 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9576/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9576/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9576/events | https://github.com/NVIDIA/NeMo/pull/9576 | 2,384,043,701 | PR_kwDOC_bI7s50FOlP | 9,576 | Add "offline" data cache generation support | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [
"What is the reasoning behind overloading num_workers for the num_dataset_builder_threads, instead of passing num_dataset_builder_threads in as a separate config parameter? \r\n\r\nI could imagine a case where I set num_dataset_builder_threads to a very large number (64 or 128) but wouldn't want that many workers d... | 2024-07-01T14:43:52 | 2024-07-23T16:45:08 | 2024-07-23T16:45:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9576",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9576",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9576.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9576.patch",
"merged_at": "2024-07-23T16:45:06"
} | # What does this PR do ?
1. Adds "offline" data cache generation support. The training script will be stopped once data cache is generated.
2. Enable mcore's `num_dataset_builder_threads` param usage.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9576/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9576/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9575 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9575/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9575/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9575/events | https://github.com/NVIDIA/NeMo/pull/9575 | 2,384,043,371 | PR_kwDOC_bI7s50FOgq | 9,575 | Alit/mamba | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-07-01T14:43:42 | 2024-07-06T18:04:34 | 2024-07-06T18:04:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9575",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9575",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9575.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9575.patch",
"merged_at": "2024-07-06T18:04:32"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9575/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9575/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9574 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9574/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9574/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9574/events | https://github.com/NVIDIA/NeMo/pull/9574 | 2,383,670,001 | PR_kwDOC_bI7s50D8li | 9,574 | PTQ refinements | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-07-01T12:06:12 | 2024-07-01T14:21:45 | 2024-07-01T14:21:43 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9574",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9574",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9574.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9574.patch",
"merged_at": "2024-07-01T14:21:43"
} | # What does this PR do ?
Refinements in PTQ workflow (calibration + export) including:
* script & config rename for consistency with https://github.com/NVIDIA/NeMo/pull/9326
* `model_type` as optional parameter for "qnemo" export
* other minor updates
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Refactoring
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9574/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9574/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9573 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9573/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9573/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9573/events | https://github.com/NVIDIA/NeMo/pull/9573 | 2,383,342,968 | PR_kwDOC_bI7s50Czv1 | 9,573 | Akoumparouli/mcore tokenizer signature pairing dense log utils | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "htt... | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.co... | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"This PR is stale because it has been open for 14 days with no activity.... | 2024-07-01T09:36:44 | 2024-08-23T01:52:02 | 2024-08-23T01:52:01 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9573",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9573",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9573.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9573.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9573/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9573/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9572 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9572/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9572/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9572/events | https://github.com/NVIDIA/NeMo/pull/9572 | 2,383,326,725 | PR_kwDOC_bI7s50CwJc | 9,572 | Fix Dockerfile: make consistent with `Dockerfile.ci`, test ASR import | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"Closing, since created a new PR to r2.0.0rc1 branch #9784"
] | 2024-07-01T09:29:19 | 2024-07-18T08:30:34 | 2024-07-18T08:30:25 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9572",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9572",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9572.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9572.patch",
"merged_at": null
} | # What does this PR do ?
Makes `Dockerfile` consistent with [`Dockerfile.ci`](https://github.com/NVIDIA/NeMo/blob/main/Dockerfile.ci) and fixes build errors:
- fixes `Megatron-LM` commit
- fixes `TransformerEngine` commit
- fixes `Apex` commit
- add ASR import (sanity check)
- fix problems with TransformerEngine (`OSError: libcuda.so.1: cannot open shared object file: No such file or directory`)
Build log: https://gitlab-master.nvidia.com/vbataev/nemo_containers/-/jobs/101973040
**Collection**: [CI]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9572/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9572/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9571 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9571/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9571/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9571/events | https://github.com/NVIDIA/NeMo/pull/9571 | 2,383,097,183 | PR_kwDOC_bI7s50B9-R | 9,571 | [NeMo-UX] Fix Trainer serialization | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-01T07:43:04 | 2024-07-01T17:57:29 | 2024-07-01T17:57:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9571",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9571",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9571.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9571.patch",
"merged_at": "2024-07-01T17:57:28"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9571/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9571/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9570 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9570/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9570/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9570/events | https://github.com/NVIDIA/NeMo/pull/9570 | 2,382,613,224 | PR_kwDOC_bI7s50AUUz | 9,570 | Expose MCore path_to_cache option | {
"login": "maanug-nv",
"id": 109391026,
"node_id": "U_kgDOBoUssg",
"avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maanug-nv",
"html_url": "https://github.com/maanug-nv",
"followers_url": "https://api.github.com/users/maanug-nv/followers",
"following_url": "https://api.github.com/users/maanug-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions",
"organizations_url": "https://api.github.com/users/maanug-nv/orgs",
"repos_url": "https://api.github.com/users/maanug-nv/repos",
"events_url": "https://api.github.com/users/maanug-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/maanug-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-01T01:41:08 | 2024-07-01T08:49:13 | 2024-07-01T08:49:11 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9570",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9570",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9570.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9570.patch",
"merged_at": "2024-07-01T08:49:11"
} | # What does this PR do ?
Useful option for separating the `.npy` cache files.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9570/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9570/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9569 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9569/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9569/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9569/events | https://github.com/NVIDIA/NeMo/pull/9569 | 2,382,224,325 | PR_kwDOC_bI7s5z_Fgs | 9,569 | chore: update formatter.py | {
"login": "eltociear",
"id": 22633385,
"node_id": "MDQ6VXNlcjIyNjMzMzg1",
"avatar_url": "https://avatars.githubusercontent.com/u/22633385?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/eltociear",
"html_url": "https://github.com/eltociear",
"followers_url": "https://api.github.com/users/eltociear/followers",
"following_url": "https://api.github.com/users/eltociear/following{/other_user}",
"gists_url": "https://api.github.com/users/eltociear/gists{/gist_id}",
"starred_url": "https://api.github.com/users/eltociear/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eltociear/subscriptions",
"organizations_url": "https://api.github.com/users/eltociear/orgs",
"repos_url": "https://api.github.com/users/eltociear/repos",
"events_url": "https://api.github.com/users/eltociear/events{/privacy}",
"received_events_url": "https://api.github.com/users/eltociear/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "htt... | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-30T12:04:53 | 2024-07-23T01:50:36 | 2024-07-23T01:50:35 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9569",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9569",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9569.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9569.patch",
"merged_at": null
} |
# What does this PR do ?
lenth -> length
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9569/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9569/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9567 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9567/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9567/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9567/events | https://github.com/NVIDIA/NeMo/pull/9567 | 2,381,547,630 | PR_kwDOC_bI7s5z84iQ | 9,567 | Akoumparouli/mistral import instruct chat template fix | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.co... | null | [] | 2024-06-29T07:13:21 | 2024-07-05T06:04:33 | 2024-07-05T06:04:32 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9567",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9567",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9567.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9567.patch",
"merged_at": "2024-07-05T06:04:32"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9567/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9567/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9566 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9566/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9566/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9566/events | https://github.com/NVIDIA/NeMo/pull/9566 | 2,381,041,562 | PR_kwDOC_bI7s5z7M1j | 9,566 | Adding support for mcore generate | {
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [
"Tested that it works. The output of the old code and the new code are exactlly the same. The old code for tp2pp2 gpt3 43b, takes 15 seconds for generating 100 tokens . The new code takes 8.5 seconds all same settings. The text outputs are exactly the same: \r\nOLD CODE :\r\nTOTAL TIME TAKEN 14.98s\r\n************... | 2024-06-28T19:23:15 | 2024-07-08T16:52:23 | 2024-07-08T16:52:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9566",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9566",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9566.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9566.patch",
"merged_at": "2024-07-08T16:52:21"
} | # What does this PR do ?
Supports generating though megatron core
**Collection**: NLP
# Changelog
- Added deprecation notice to old generate.
- Added support for generation using mcore.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9566/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9566/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9565 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9565/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9565/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9565/events | https://github.com/NVIDIA/NeMo/pull/9565 | 2,380,743,140 | PR_kwDOC_bI7s5z6KzT | 9,565 | fix converter defautl args | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.co... | null | [] | 2024-06-28T16:07:44 | 2024-07-05T07:35:28 | 2024-07-05T07:35:26 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9565",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9565",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9565.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9565.patch",
"merged_at": "2024-07-05T07:35:26"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9565/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9565/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9564 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9564/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9564/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9564/events | https://github.com/NVIDIA/NeMo/pull/9564 | 2,380,695,879 | PR_kwDOC_bI7s5z6AYf | 9,564 | Add megatron-lm Dist Ckpt -> NeMo Conversion Script | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://a... | closed | false | null | [] | null | [
"can you please also add docs under docs checkpoint part?",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"Hi, @suiy... | 2024-06-28T15:37:27 | 2024-09-03T05:40:40 | 2024-07-24T01:50:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9564",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9564",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9564.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9564.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9564/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9564/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9563 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9563/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9563/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9563/events | https://github.com/NVIDIA/NeMo/issues/9563 | 2,380,636,424 | I_kwDOC_bI7s6N5aEI | 9,563 | Fastconformer-CTC crashing with Watchdog caught collective operation timeout | {
"login": "duhtapioca",
"id": 173154737,
"node_id": "U_kgDOClIhsQ",
"avatar_url": "https://avatars.githubusercontent.com/u/173154737?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/duhtapioca",
"html_url": "https://github.com/duhtapioca",
"followers_url": "https://api.github.com/users/duhtapioca/followers",
"following_url": "https://api.github.com/users/duhtapioca/following{/other_user}",
"gists_url": "https://api.github.com/users/duhtapioca/gists{/gist_id}",
"starred_url": "https://api.github.com/users/duhtapioca/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/duhtapioca/subscriptions",
"organizations_url": "https://api.github.com/users/duhtapioca/orgs",
"repos_url": "https://api.github.com/users/duhtapioca/repos",
"events_url": "https://api.github.com/users/duhtapioca/events{/privacy}",
"received_events_url": "https://api.github.com/users/duhtapioca/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
... | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.gi... | null | [
"I have the same issue. Have you solved it? How can we avoid it？",
"First, to triage whether it's the model or data store as the problem, run with a subset of data, maybe 50 hours of so. What is the max duration of the data ? Reduce it to at most 40 seconds, preferably 30 sec. We have some tools to segment data a... | 2024-06-28T15:02:00 | 2024-09-18T01:55:49 | 2024-09-18T01:55:48 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
We're trying to finetune the stt_en fastconformer_ctc large model on around 20k hours of data on 2 h100s. We're using 128 batch size and 8 num_workers and we trained the tokenizer with 1024 vocab_size. The training is taking very long, more than 30 hours per epoch and after around 70-80% of the first epoch it's crashing with the following error:
```
Epoch 0: 78%|█████████████████████████████████████████████████████████████▎ | 64809/83556 [25:06:58<7:15:54, 1.40s/it, v_num=18][rank1]:[E ProcessGroupNCCL.cpp:563] [Rank
1] Watchdog caught collective operation timeout: WorkNCCL(SeqNum=1363596, OpType=BROADCAST, NumelIn=5158880, NumelOut=5158880, Timeout(ms)=1800000) ran for 1800047 milliseconds before timin
g out.
[rank1]:[E ProcessGroupNCCL.cpp:1316] [PG 0 Rank 1] Heartbeat monitor timed out! Process will be terminated after dumping debug info. workMetaList_.size()=2
[rank1]:[E ProcessGroupNCCL.cpp:1153] [PG 0 Rank 1] ProcessGroupNCCL preparing to dump debug info.
[rank1]:[F ProcessGroupNCCL.cpp:1169] [PG 0 Rank 1] [PG 0 Rank 1] ProcessGroupNCCL's watchdog got stuck for 600 seconds without making progress in monitoring enqueued collectives. This typi
cally indicates a NCCL/CUDA API hang blocking the watchdog, and could be triggered by another thread holding the GIL inside a CUDA api, or other deadlock-prone behaviors.If you suspect the
watchdog is not actually stuck and a longer timeout would help, you can either increase the timeout (TORCH_NCCL_HEARTBEAT_TIMEOUT_SEC) to a larger value or disable the heartbeat monitor (TO
RCH_NCCL_ENABLE_MONITORING=0).If either of aforementioned helps, feel free to file an issue to PyTorch about the short timeout or false positive abort; otherwise, please attempt to debug th
e hang. workMetaList_.size() = 2
[rank0]:[E ProcessGroupNCCL.cpp:563] [Rank 0] Watchdog caught collective operation timeout: WorkNCCL(SeqNum=1363598, OpType=ALLREDUCE, NumelIn=1, NumelOut=1, Timeout(ms)=1800000) ran for 18
00095 milliseconds before timing out.
[rank0]:[E ProcessGroupNCCL.cpp:1537] [PG 0 Rank 0] Timeout at NCCL work: 1363598, last enqueued NCCL work: 1363598, last completed NCCL work: 1363597.
[rank0]:[E ProcessGroupNCCL.cpp:577] [Rank 0] Some NCCL operations have failed or timed out. Due to the asynchronous nature of CUDA kernels, subsequent GPU operations might run on corrupted
/incomplete data.
[rank0]:[E ProcessGroupNCCL.cpp:583] [Rank 0] To avoid data inconsistency, we are taking the entire process down.
[rank0]:[E ProcessGroupNCCL.cpp:1414] [PG 0 Rank 0] Process group watchdog thread terminated with exception: [Rank 0] Watchdog caught collective operation timeout: WorkNCCL(SeqNum=1363598,
OpType=ALLREDUCE, NumelIn=1, NumelOut=1, Timeout(ms)=1800000) ran for 1800095 milliseconds before timing out.
Exception raised from checkTimeout at ../torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp:565 (most recent call first):
frame #0: c10::Error::Error(c10::SourceLocation, std::string) + 0x57 (0x7f47fd81e897 in /anaconda/envs/nemo_hindi/lib/python3.10/site-packages/torch/lib/libc10.so)
frame #1: c10d::ProcessGroupNCCL::WorkNCCL::checkTimeout(std::optional<std::chrono::duration<long, std::ratio<1l, 1000l> > >) + 0x1d2 (0x7f47feaf7c62 in /anaconda/envs/nemo_hindi/lib/python
3.10/site-packages/torch/lib/libtorch_cuda.so)
frame #2: c10d::ProcessGroupNCCL::watchdogHandler() + 0x1a0 (0x7f47feafca80 in /anaconda/envs/nemo_hindi/lib/python3.10/site-packages/torch/lib/libtorch_cuda.so)
frame #3: c10d::ProcessGroupNCCL::ncclCommWatchdog() + 0x10c (0x7f47feafddcc in /anaconda/envs/nemo_hindi/lib/python3.10/site-packages/torch/lib/libtorch_cuda.so)
frame #4: <unknown function> + 0xdbbf4 (0x7f484a5a6bf4 in /anaconda/envs/nemo_hindi/bin/../lib/libstdc++.so.6)
frame #5: <unknown function> + 0x8609 (0x7f484ba9b609 in /lib/x86_64-linux-gnu/libpthread.so.0)
frame #6: clone + 0x43 (0x7f484b866353 in /lib/x86_64-linux-gnu/libc.so.6)
Aborted (core dumped)
```
How do we avoid this issue? Should we consider reducing the finetuning data size? If we save intermediate checkpoints, is there a way to also save the lr scheduler state to effectively resume the training if it crashes? Any guidance regarding this would be of great help.
Also, unrelated to the issue, we noticed we didn't get much boost by using h100 instead of a100, and sometimes using bf16-mixed was slower on h100 than using fp16 on h100, on the other hand, bf16-mixed is almost always faster on a100 than fp16, is this expected?
Thank you! | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9563/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9563/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9562 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9562/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9562/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9562/events | https://github.com/NVIDIA/NeMo/pull/9562 | 2,380,623,186 | PR_kwDOC_bI7s5z5wod | 9,562 | [NeMo-UX] Checkpointing bug fixes | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-28T14:55:10 | 2024-06-28T16:03:45 | 2024-06-28T16:03:43 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9562",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9562",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9562.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9562.patch",
"merged_at": "2024-06-28T16:03:43"
} | # What does this PR do ?
Fixes
- optimizer state restore
- model state dict loading
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
* | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9562/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9562/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9561 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9561/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9561/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9561/events | https://github.com/NVIDIA/NeMo/issues/9561 | 2,380,118,412 | I_kwDOC_bI7s6N3bmM | 9,561 | Segmentation fault when fine-tuning Ambernet | {
"login": "Oscaarjs",
"id": 37636054,
"node_id": "MDQ6VXNlcjM3NjM2MDU0",
"avatar_url": "https://avatars.githubusercontent.com/u/37636054?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oscaarjs",
"html_url": "https://github.com/Oscaarjs",
"followers_url": "https://api.github.com/users/Oscaarjs/followers",
"following_url": "https://api.github.com/users/Oscaarjs/following{/other_user}",
"gists_url": "https://api.github.com/users/Oscaarjs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oscaarjs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oscaarjs/subscriptions",
"organizations_url": "https://api.github.com/users/Oscaarjs/orgs",
"repos_url": "https://api.github.com/users/Oscaarjs/repos",
"events_url": "https://api.github.com/users/Oscaarjs/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oscaarjs/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | [
"@fayejf maybe you have an idea? Thanks in advance",
"Updating from Cuda 12.2 to Cuda 12.3 seems to have solved the issue.",
"Closing"
] | 2024-06-28T10:36:48 | 2024-07-01T08:56:01 | 2024-07-01T08:56:01 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I'm trying to fine-tune the Ambernet model on Cantonese and Chinese.
But I'm getting this Segmentation fault;
```
Sanity Checking DataLoader 0: 0%| | 0/2 [00:00<?, ?it/s]
Segmentation fault
```
[full_output.txt](https://github.com/user-attachments/files/16029811/full_output.txt)
**Steps/Code to reproduce bug**
The config I'm using; (converted to json to be able to upload it here)
[ambernet_config.json](https://github.com/user-attachments/files/16029835/ambernet_config.json)
My manifests look like this;
```
{"audio_filepath": "/home/<masked>/finetune-lid/data/cv-corpus-18.0-2024-06-14/yue/clips/common_voice_yue_32329425.mp3", "duration": 3.78, "label": "yue"}
{"audio_filepath": "/home/<masked>/finetune-lid/data/cv-corpus-18.0-2024-06-14/yue/clips/common_voice_yue_38973572.mp3", "duration": 3.276, "label": "yue"}
{"audio_filepath": "/home/<masked>/finetune-lid/data/cv-corpus-18.0-2024-06-14/yue/clips/common_voice_yue_38956269.mp3", "duration": 3.168, "label": "yue"}
{"audio_filepath": "/home/<masked>/finetune-lid/data/cv-corpus-18.0-2024-06-14/zh-CN/clips/common_voice_zh-CN_32666586.mp3", "duration": 2.88, "label": "zh-CN"}
{"audio_filepath": "/home/<masked>/finetune-lid/data/cv-corpus-18.0-2024-06-14/zh-CN/clips/common_voice_zh-CN_33111477.mp3", "duration": 5.796, "label": "zh-CN"}
```
I run this script;
```
!python speech_to_label.py --config-path="configs/" --config-name="ambernet_config" \
model.train_ds.manifest_filepath="manifests/train_manifest.json" \
model.validation_ds.manifest_filepath="manifests/val_manifest.json" \
model.test_ds.manifest_filepath="manifests/test_manifest.json" \
model.decoder.num_classes=2 \
trainer.devices=1 \
trainer.max_epochs=40 \
trainer.accelerator="gpu" \
exp_manager.create_wandb_logger=False \
exp_manager.wandb_logger_kwargs.name="titanet" \
exp_manager.wandb_logger_kwargs.project="langid" \
+exp_manager.checkpoint_callback_params.monitor="val_acc_macro" \
+exp_manager.checkpoint_callback_params.mode="max" \
+trainer.precision=16
```
**Environment overview**
- Environment location: GCE VM
- Method of NeMo install: [pip install or from source]. Please specify exact commands you used to install.
```
apt-get update && apt-get install -y libsndfile1 ffmpeg
pip install Cython packaging
pip install nemo_toolkit['asr']
```
**Environment details**
- OS version
```
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
NAME="Debian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
```
- PyTorch version: 2.3.1+cu121
- Nemo Version: 2.0.0rc0 (also on 1.23.0)
- Python version: 3.10.14
**Additional context**
Add any other context about the problem here.
Example: GPU model
```
+-----------------------------------------------------------------------------------------+
| NVIDIA-SMI 550.90.07 Driver Version: 550.90.07 CUDA Version: 12.4 |
|-----------------------------------------+------------------------+----------------------+
| GPU Name Persistence-M | Bus-Id Disp.A | Volatile Uncorr. ECC |
| Fan Temp Perf Pwr:Usage/Cap | Memory-Usage | GPU-Util Compute M. |
| | | MIG M. |
|=========================================+========================+======================|
| 0 Tesla T4 On | 00000000:00:04.0 Off | 0 |
| N/A 36C P8 9W / 70W | 1MiB / 15360MiB | 0% Default |
| | | N/A |
+-----------------------------------------+------------------------+----------------------+
+-----------------------------------------------------------------------------------------+
| Processes: |
| GPU GI CI PID Type Process name GPU Memory |
| ID ID Usage |
|=========================================================================================|
| No running processes found |
+-----------------------------------------------------------------------------------------+
```
```
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2023 NVIDIA Corporation
Built on Tue_Jul_11_02:20:44_PDT_2023
Cuda compilation tools, release 12.2, V12.2.128
Build cuda_12.2.r12.2/compiler.33053471_0
```
| {
"login": "Oscaarjs",
"id": 37636054,
"node_id": "MDQ6VXNlcjM3NjM2MDU0",
"avatar_url": "https://avatars.githubusercontent.com/u/37636054?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oscaarjs",
"html_url": "https://github.com/Oscaarjs",
"followers_url": "https://api.github.com/users/Oscaarjs/followers",
"following_url": "https://api.github.com/users/Oscaarjs/following{/other_user}",
"gists_url": "https://api.github.com/users/Oscaarjs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oscaarjs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oscaarjs/subscriptions",
"organizations_url": "https://api.github.com/users/Oscaarjs/orgs",
"repos_url": "https://api.github.com/users/Oscaarjs/repos",
"events_url": "https://api.github.com/users/Oscaarjs/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oscaarjs/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9561/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9561/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9559 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9559/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9559/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9559/events | https://github.com/NVIDIA/NeMo/pull/9559 | 2,379,144,092 | PR_kwDOC_bI7s5z0zFd | 9,559 | GPU unit tests: Mark flaky tests to be fixed | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-06-27T21:51:55 | 2024-06-27T23:34:35 | 2024-06-27T23:34:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9559",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9559",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9559.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9559.patch",
"merged_at": "2024-06-27T23:34:33"
} | GPU unit tests: Mark flaky tests to be fixed | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9559/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9559/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9558 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9558/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9558/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9558/events | https://github.com/NVIDIA/NeMo/pull/9558 | 2,378,804,055 | PR_kwDOC_bI7s5zzpOd | 9,558 | Add tps and pps params to the export script | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"CI passed (test that failed flaky & is now fixed): https://github.com/NVIDIA/NeMo/actions/runs/9702936067"
] | 2024-06-27T18:13:20 | 2024-06-28T17:07:55 | 2024-06-28T17:07:55 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9558",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9558",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9558.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9558.patch",
"merged_at": "2024-06-28T17:07:55"
} | # What does this PR do ?
Update tps and pps and depricate n_gpus param in the scripts. | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9558/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9558/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9557 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9557/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9557/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9557/events | https://github.com/NVIDIA/NeMo/pull/9557 | 2,378,621,637 | PR_kwDOC_bI7s5zzC2u | 9,557 | Bump PTL version | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-27T16:38:22 | 2024-06-28T04:31:33 | 2024-06-28T04:31:31 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9557",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9557",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9557.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9557.patch",
"merged_at": "2024-06-28T04:31:31"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9557/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9557/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9556 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9556/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9556/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9556/events | https://github.com/NVIDIA/NeMo/pull/9556 | 2,378,579,125 | PR_kwDOC_bI7s5zy58O | 9,556 | ci: Do not attempt to send slack on fork | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api... | closed | false | null | [] | null | [] | 2024-06-27T16:14:30 | 2024-06-27T20:38:27 | 2024-06-27T20:38:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9556",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9556",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9556.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9556.patch",
"merged_at": "2024-06-27T20:38:26"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9556/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9556/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9555 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9555/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9555/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9555/events | https://github.com/NVIDIA/NeMo/pull/9555 | 2,378,298,314 | PR_kwDOC_bI7s5zx9kG | 9,555 | [NeMo-UX] Fix tokenizer IO | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "htt... | closed | false | null | [] | null | [] | 2024-06-27T14:18:30 | 2024-06-27T16:19:18 | 2024-06-27T16:19:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9555",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9555",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9555.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9555.patch",
"merged_at": "2024-06-27T16:19:16"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9555/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9555/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9554 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9554/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9554/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9554/events | https://github.com/NVIDIA/NeMo/issues/9554 | 2,377,824,713 | I_kwDOC_bI7s6NurnJ | 9,554 | Citrinet CTC Decoder Alphabet size mismatch. | {
"login": "huks0",
"id": 53513835,
"node_id": "MDQ6VXNlcjUzNTEzODM1",
"avatar_url": "https://avatars.githubusercontent.com/u/53513835?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huks0",
"html_url": "https://github.com/huks0",
"followers_url": "https://api.github.com/users/huks0/followers",
"following_url": "https://api.github.com/users/huks0/following{/other_user}",
"gists_url": "https://api.github.com/users/huks0/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huks0/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huks0/subscriptions",
"organizations_url": "https://api.github.com/users/huks0/orgs",
"repos_url": "https://api.github.com/users/huks0/repos",
"events_url": "https://api.github.com/users/huks0/events{/privacy}",
"received_events_url": "https://api.github.com/users/huks0/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
... | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.gi... | null | [
"yes, it is due to additional `<blank>` token that gets added to the provided tokenizer. ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being mar... | 2024-06-27T10:51:35 | 2024-09-09T01:57:09 | 2024-09-09T01:57:08 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I trained a Citrinet and intended to use the CTC Decoder to retrieve a corrected output.
Using the CTC Beam Search Decoder of DeepSpeech I get the following error:
[ctc_beam_search_decoder.cpp:279] FATAL: "(alphabet.GetSize()+1) == (class_dim)" check failed. Number of output classes in acoustic model does not match number of labels in the alphabet file. Alphabet file must be the same one that was used to train the acoustic model.
I have controlled the alphabet and it has the size of 1023, even though I built it with 1024 characters. I built the tokenizer and alphabet with the nemo script setting the vocab size to 1024, spe and unigram. The output shape of the model is 1025. I believe the mismatch is 1 character. I thought of blank or unk token, but I aint sure if that is the cause of the error. Any idea why this happens or how to solve it? I appreciate your help!!
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9554/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9554/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9553 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9553/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9553/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9553/events | https://github.com/NVIDIA/NeMo/pull/9553 | 2,376,610,642 | PR_kwDOC_bI7s5zs6eF | 9,553 | Add MegatronNevaDeployable for serving multimodal models on Triton server | {
"login": "jukim-nv",
"id": 18061559,
"node_id": "MDQ6VXNlcjE4MDYxNTU5",
"avatar_url": "https://avatars.githubusercontent.com/u/18061559?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jukim-nv",
"html_url": "https://github.com/jukim-nv",
"followers_url": "https://api.github.com/users/jukim-nv/followers",
"following_url": "https://api.github.com/users/jukim-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/jukim-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jukim-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jukim-nv/subscriptions",
"organizations_url": "https://api.github.com/users/jukim-nv/orgs",
"repos_url": "https://api.github.com/users/jukim-nv/repos",
"events_url": "https://api.github.com/users/jukim-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/jukim-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "htt... | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR is st... | 2024-06-27T02:34:08 | 2024-10-18T01:59:14 | 2024-10-18T01:59:13 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9553",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9553",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9553.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9553.patch",
"merged_at": null
} | # What does this PR do ?
Adds a `MegatronNevaDeployable` class implementing `ITritonDeployable` enabling deployment of multimodal models like LLaVA/Neva to Triton inference server directly from .nemo checkpoints.
Currently this has only been tested with a LLaVA 1.5 model created with the instructions [here](https://docs.nvidia.com/nemo-framework/user-guide/latest/multimodalmodels/multimodallanguagemodel/neva/dataprep.html).
**Collection**: [Note which collection this PR will affect]
deploy/
# Changelog
- Add `MegatronNevaDeployable` class
- Add `NemoQueryMultimodalPyTorch` class
- Add `test_neva_deploy.py` script for testing deployment
- Add `query_inframework.py` script for easy use of `NemoQueryMultimodalPyTorch`
# Usage
See `test_neva_deploy.py` for full example on how to use `MegatronNevaDeployable`.
```python
megatron_deployable = MegatronNevaDeployable(args.nemo_checkpoint, args.num_gpus)
...
nm = DeployPyTriton(
model=megatron_deployable,
triton_model_name=model_name,
triton_model_version=1,
max_batch_size=8,
port=8000,
address="0.0.0.0",
streaming=False,
)
nm.deploy()
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9553/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9553/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9552 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9552/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9552/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9552/events | https://github.com/NVIDIA/NeMo/pull/9552 | 2,376,561,938 | PR_kwDOC_bI7s5zsy7v | 9,552 | support save tensorrt_llm checkpoint | {
"login": "QiJune",
"id": 22017000,
"node_id": "MDQ6VXNlcjIyMDE3MDAw",
"avatar_url": "https://avatars.githubusercontent.com/u/22017000?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/QiJune",
"html_url": "https://github.com/QiJune",
"followers_url": "https://api.github.com/users/QiJune/followers",
"following_url": "https://api.github.com/users/QiJune/following{/other_user}",
"gists_url": "https://api.github.com/users/QiJune/gists{/gist_id}",
"starred_url": "https://api.github.com/users/QiJune/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/QiJune/subscriptions",
"organizations_url": "https://api.github.com/users/QiJune/orgs",
"repos_url": "https://api.github.com/users/QiJune/repos",
"events_url": "https://api.github.com/users/QiJune/events{/privacy}",
"received_events_url": "https://api.github.com/users/QiJune/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-27T02:12:26 | 2024-07-19T01:49:53 | 2024-07-19T01:49:53 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9552",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9552",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9552.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9552.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9552/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9552/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9551 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9551/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9551/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9551/events | https://github.com/NVIDIA/NeMo/pull/9551 | 2,376,479,094 | PR_kwDOC_bI7s5zsiBw | 9,551 | [Nemo CICD] Make GPU Unit Tests non-optional | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api... | closed | false | null | [] | null | [] | 2024-06-27T00:25:21 | 2024-06-27T00:49:57 | 2024-06-27T00:49:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9551",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9551",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9551.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9551.patch",
"merged_at": "2024-06-27T00:49:27"
} | [Nemo CICD] Make GPU Unit Tests non-optional | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9551/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9551/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9550 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9550/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9550/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9550/events | https://github.com/NVIDIA/NeMo/pull/9550 | 2,376,376,347 | PR_kwDOC_bI7s5zsNRa | 9,550 | [NeMo-UX] Make TE and Apex dependencies optional | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://a... | closed | false | null | [] | null | [] | 2024-06-26T22:28:06 | 2024-07-15T04:06:24 | 2024-07-15T04:06:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9550",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9550",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9550.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9550.patch",
"merged_at": "2024-07-15T04:06:22"
} | # What does this PR do ?
This PR provides a fallback codepath that defaults to pure Pytorch/jit when TE and Apex are not installed. Note that this is specifically designed to work with NeMo 2.0, so there are no guarantees when running with NeMo 1.0 models.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9550/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9550/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9549 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9549/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9549/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9549/events | https://github.com/NVIDIA/NeMo/issues/9549 | 2,376,290,394 | I_kwDOC_bI7s6No1Ba | 9,549 | Failed to generate timestamp for parakeet-tdt-1.1b | {
"login": "anshulwadhawan",
"id": 25061477,
"node_id": "MDQ6VXNlcjI1MDYxNDc3",
"avatar_url": "https://avatars.githubusercontent.com/u/25061477?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anshulwadhawan",
"html_url": "https://github.com/anshulwadhawan",
"followers_url": "https://api.github.com/users/anshulwadhawan/followers",
"following_url": "https://api.github.com/users/anshulwadhawan/following{/other_user}",
"gists_url": "https://api.github.com/users/anshulwadhawan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anshulwadhawan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anshulwadhawan/subscriptions",
"organizations_url": "https://api.github.com/users/anshulwadhawan/orgs",
"repos_url": "https://api.github.com/users/anshulwadhawan/repos",
"events_url": "https://api.github.com/users/anshulwadhawan/events{/privacy}",
"received_events_url": "https://api.github.com/users/anshulwadhawan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.gi... | null | [
"answered here: https://github.com/NVIDIA/NeMo/issues/9695 "
] | 2024-06-26T21:11:40 | 2024-08-01T13:19:22 | 2024-08-01T13:19:22 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
When I tried to generate timestamp with model: nvidia/parakeet-tdt-1.1b, I got following error,
```
ValueError: `char_offsets`: [{'char': [tensor(524)], 'start_offset': 2, 'end_offset': 3}, {'char': [tensor(106)], 'start_offset': 5, 'end_offset': 6}, {'char': [tensor(40)], 'start_offset': 6, 'end_offset': 7}, {'char': [tensor(556)], 'start_offset': 7, 'end_offset': 8}, {'char': [tensor(988)], 'start_offset': 9, 'end_offset': 10}, {'char': [tensor(8)], 'start_offset': 10, 'end_offset': 11}, {'char': [tensor(88)], 'start_offset': 11, 'end_offset': 12}, {'char': [tensor(1002)], 'start_offset': 12, 'end_offset': 13}] and `processed_tokens`: [524, 106, 40, 556, 988, 8, 88, 1002] have to be of the same length, but are: `len(offsets)`: 8 and `len(processed_tokens)`: 8
```
call stack,
```
----> 1 hypotheses = asr_model.transcribe(['test.wav'], return_hypotheses=True)
requirements/lib/python3.10/site-packages/torch/utils/_contextlib.py in decorate_context(*args, **kwargs)
113 def decorate_context(*args, **kwargs):
114 with ctx_factory():
--> 115 return func(*args, **kwargs)
116
117 return decorate_context
requirements/lib/python3.10/site-packages/nemo/collections/asr/models/hybrid_rnnt_ctc_models.py in transcribe(self, audio, batch_size, return_hypotheses, partial_hypothesis, num_workers, channel_selector, augmentor, verbose, override_config)
136 )
137
--> 138 return super().transcribe(
139 audio=audio,
140 batch_size=batch_size,
requirements/lib/python3.10/site-packages/torch/utils/_contextlib.py in decorate_context(*args, **kwargs)
113 def decorate_context(*args, **kwargs):
114 with ctx_factory():
--> 115 return func(*args, **kwargs)
116
117 return decorate_context
requirements/lib/python3.10/site-packages/nemo/collections/asr/models/rnnt_models.py in transcribe(self, audio, batch_size, return_hypotheses, partial_hypothesis, num_workers, channel_selector, augmentor, verbose, override_config)
277 * An optional list of beam search transcript texts / Hypothesis / NBestHypothesis.
278 """
--> 279 return super().transcribe(
280 audio=audio,
281 batch_size=batch_size,
requirements/lib/python3.10/site-packages/torch/utils/_contextlib.py in decorate_context(*args, **kwargs)
113 def decorate_context(*args, **kwargs):
114 with ctx_factory():
--> 115 return func(*args, **kwargs)
116
117 return decorate_context
requirements/lib/python3.10/site-packages/nemo/collections/asr/parts/mixins/transcription.py in transcribe(self, audio, batch_size, return_hypotheses, num_workers, channel_selector, augmentor, verbose, override_config, **config_kwargs)
275 generator = self.transcribe_generator(audio, override_config=transcribe_cfg)
276
--> 277 for processed_outputs in generator:
278 # Store results
279 if isinstance(processed_outputs, list):
requirements/lib/python3.10/site-packages/nemo/collections/asr/parts/mixins/transcription.py in transcribe_generator(self, audio, override_config)
387 # Run forward pass
388 model_outputs = self._transcribe_forward(test_batch, transcribe_cfg)
--> 389 processed_outputs = self._transcribe_output_processing(model_outputs, transcribe_cfg)
390
391 # clear up memory
requirements/lib/python3.10/site-packages/nemo/collections/asr/models/hybrid_rnnt_ctc_models.py in _transcribe_output_processing(self, outputs, trcfg)
177 ) -> Tuple[List['Hypothesis'], List['Hypothesis']]:
178 if self.cur_decoder == "rnnt":
--> 179 return super()._transcribe_output_processing(outputs, trcfg)
180
181 # CTC Path
requirements/lib/python3.10/site-packages/nemo/collections/asr/models/rnnt_models.py in _transcribe_output_processing(self, outputs, trcfg)
906 encoded_len = outputs.pop('encoded_len')
907
--> 908 best_hyp, all_hyp = self.decoding.rnnt_decoder_predictions_tensor(
909 encoded,
910 encoded_len,
requirements/lib/python3.10/site-packages/nemo/collections/asr/parts/submodules/rnnt_decoding.py in rnnt_decoder_predictions_tensor(self, encoder_output, encoded_lengths, return_hypotheses, partial_hypotheses)
508 timestamp_type = self.cfg.get('rnnt_timestamp_type', 'all')
509 for hyp_idx in range(len(hypotheses)):
--> 510 hypotheses[hyp_idx] = self.compute_rnnt_timestamps(hypotheses[hyp_idx], timestamp_type)
511
512 if return_hypotheses:
requirements/lib/python3.10/site-packages/nemo/collections/asr/parts/submodules/rnnt_decoding.py in compute_rnnt_timestamps(self, hypothesis, timestamp_type)
751
752 if num_flattened_tokens != len(hypothesis.text):
--> 753 raise ValueError(
754 f"`char_offsets`: {char_offsets} and `processed_tokens`: {hypothesis.text}"
755 " have to be of the same length, but are: "
```
**Steps/Code to reproduce bug**
```
asr_model = nemo_asr.models.ASRModel.from_pretrained("nvidia/parakeet-tdt-1.1b")
decoding_cfg = asr_model.cfg.decoding
with open_dict(decoding_cfg):
decoding_cfg.preserve_alignments = True
decoding_cfg.compute_timestamps = True
asr_model.change_decoding_strategy(decoding_cfg)
asr_model.change_decoding_strategy(decoding_cfg)
hypothesis = asr_model.transcribe([audio], return_hypotheses=True)[0][0]
timestamp_dict = hypothesis.timestep
word_timestamps = timestamp_dict['word']
print(word_timestamps)
```
**Expected behavior**
It should output word timestamps instead of exception.
**Environment overview (please complete the following information)**
- Environment location: run in local redhat 7.9 machine.
- Method of NeMo install: pip install nemo_toolkit['asr']==2.0.0rc0
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version: redhat 7.9
- PyTorch version: 2.0.1+cu117
- Python version: 3.10.13
**Additional context**
This is a replica of the issue: https://github.com/NVIDIA/NeMo/issues/8451 which got closed due to inactivity.
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9549/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9549/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9548 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9548/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9548/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9548/events | https://github.com/NVIDIA/NeMo/pull/9548 | 2,376,117,727 | PR_kwDOC_bI7s5zrUKy | 9,548 | Support configurable extra fields for LazyNeMoTarredIterator | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "htt... | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-06-26T19:31:26 | 2024-07-19T01:34:46 | 2024-07-19T01:34:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9548",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9548",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9548.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9548.patch",
"merged_at": "2024-07-19T01:34:44"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9548/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9548/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9547 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9547/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9547/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9547/events | https://github.com/NVIDIA/NeMo/pull/9547 | 2,376,011,824 | PR_kwDOC_bI7s5zq8sl | 9,547 | Fix nemo export test | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"CI passed: https://github.com/NVIDIA/NeMo/actions/runs/9700346398/job/26771667785"
] | 2024-06-26T18:27:33 | 2024-06-27T21:13:50 | 2024-06-27T21:13:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9547",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9547",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9547.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9547.patch",
"merged_at": "2024-06-27T21:13:50"
} | # What does this PR do ?
Fixes nemo export test. | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9547/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9547/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9546 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9546/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9546/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9546/events | https://github.com/NVIDIA/NeMo/pull/9546 | 2,375,428,749 | PR_kwDOC_bI7s5zo7-r | 9,546 | Fix lhotse tests for v1.24.2 | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "htt... | closed | false | null | [] | null | [] | 2024-06-26T13:53:22 | 2024-06-26T19:29:31 | 2024-06-26T19:29:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9546",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9546",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9546.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9546.patch",
"merged_at": "2024-06-26T19:29:29"
} | # What does this PR do ?
These tests were failing on main when torchaudio was present in the container. The changes are caused by the dynamic bucketing sampler optimization in the new lhotse version - the sampler simply draws different buckets in the test setup. I removed the conditional trigger on torchaudio since newer lhotse versions don't require it for the functionalities under test anymore.
Edit: also fixing a new regression in RIR test (the random seed was not fixed).
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9546/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9546/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9545 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9545/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9545/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9545/events | https://github.com/NVIDIA/NeMo/pull/9545 | 2,375,234,009 | PR_kwDOC_bI7s5zoQlO | 9,545 | [NeMo UX] Move mistral_7b.py to mistral.py | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.co... | null | [] | 2024-06-26T12:41:11 | 2024-06-27T17:36:40 | 2024-06-27T17:36:38 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9545",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9545",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9545.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9545.patch",
"merged_at": "2024-06-27T17:36:38"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9545/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9545/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9544 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9544/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9544/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9544/events | https://github.com/NVIDIA/NeMo/pull/9544 | 2,374,810,716 | PR_kwDOC_bI7s5zmyeq | 9,544 | Test C++ runtime on demand in nemo_export.py to avoid possible OOMs | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-26T09:17:08 | 2024-06-26T18:24:22 | 2024-06-26T18:24:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9544",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9544",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9544.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9544.patch",
"merged_at": "2024-06-26T18:24:20"
} | # What does this PR do ?
- Fix OOM issues that may happen for large models when both Python and C++ runtime are tested at once. The latter test is only launched when explicitly required by specifying `--test_cpp_runtime True`.
- Also, the MR enables C++ runtime test by passing `use_python_runtime=False` to `TensorRTLLM` exporter.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9544/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9544/timeline | null | null | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.