before_code stringlengths 14 465k | reviewer_comment stringlengths 16 64.5k | after_code stringlengths 9 467k | diff_context stringlengths 0 97k | file_path stringlengths 5 226 | comment_line int32 0 26 | language stringclasses 37
values | quality_score float32 0.07 1 | comment_type stringclasses 9
values | comment_length int32 16 64.5k | before_lines int32 1 17.2k | after_lines int32 1 12.1k | is_negative bool 2
classes | pr_title stringlengths 1 308 | pr_number int32 1 299k | repo_name stringclasses 533
values | repo_stars int64 321 419k | repo_language stringclasses 27
values | reviewer_username stringlengths 0 39 | author_username stringlengths 2 39 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
'id': 'ed063cd5-72c8-46b5-a60a-569243edcea8',
'ext': 'mp4',
'title': '11 - Kryptographie - 24.11.2015',
'thumbnail': r're:^https?://.*\.jpg$',
'timestamp': 1606208400,
'upload_date': '20201124',
'season_id': ... | ```suggestion
_VALID_URL = rf'''(?x)
https?://(?P<host>{OpencastBaseIE._INSTANCES_RE})(
/engage/ui/index.html\?(?:[^#]+&)?epFrom=|
/lttools/index.html\?(?:[^#]+&)?series=
)(?P<id>{OpencastBaseIE._UUID_RE})'''
``` | 'ext': 'mp4',
'title': '11 - Kryptographie - 24.11.2015',
'thumbnail': r're:^https?://.*\.jpg$',
'timestamp': 1606208400,
'upload_date': '20201124',
'season_id': 'cf68a4a1-36b1-4a53-a6ba-61af5705a0d0',
'serie... | @@ -134,10 +137,12 @@ def _real_extract(self, url):
class OpencastPlaylistIE(OpencastBaseIE):
- _VALID_URL = r'''(?x)
- https?://(?P<host>%s)/engage/ui/index.html\?.*?
- epFrom=(?P<id>%s)
- ''' % (OpencastBaseIE._INSTANCES_RE, OpencastBase... | yt_dlp/extractor/opencast.py | 26 | Python | 0.929 | suggestion | 262 | 51 | 51 | false | [extractor/opencast] Add ltitools interface to OpencastPlaylistIE and fix Tests | 6,371 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
info = self._search_json_ld(self._download_webpage(url, video_id), video_id, default={})
video_data = self._download_json(
f'https://player.api.yle.fi/v1/preview/{video_id}.json?app_id=player_static_prod&app_key=8930d72170e48303cf5f3867780d549b',
video_id, headers={
... | Do reverse imo
```py
kaltura_id = ...
if kalutra_id:
info = {...}
else:
info = {...}
return {
**info,
'title': ...,
...
}
``` | info = self._search_json_ld(self._download_webpage(url, video_id), video_id, default={})
video_data = self._download_json(
f'https://player.api.yle.fi/v1/preview/{video_id}.json?app_id=player_static_prod&app_key=8930d72170e48303cf5f3867780d549b',
video_id, headers={
... | @@ -91,12 +106,7 @@ def _real_extract(self, url):
'name': sub.get('kind'),
})
- return {
- '_type': 'url_transparent',
- 'url': smuggle_url(
- f'kaltura:1955031:{video_data["data"]["ongoing_ondemand"]["kaltura"]["id"]}',
- ... | yt_dlp/extractor/yle_areena.py | 26 | Python | 0.714 | suggestion | 157 | 51 | 51 | false | [extractor/yle_areena] Extract non-Kaltura videos | 6,402 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | bashonly |
if format_id == 'hls':
hls_formats = self._extract_m3u8_formats(
format_url, video_id, 'mp4',
entry_protocol='m3u8_native', m3u8_id='hls', fatal=False)
self._check_formats(hls_formats, video_id)
formats.extend(hls_format... | I gave `\w+` in example code since idk how the ids can be. But looking at above extractor, it should be `\d+`? | if format_id == 'hls':
hls_formats = self._extract_m3u8_formats(
format_url, video_id, 'mp4',
entry_protocol='m3u8_native', m3u8_id='hls', fatal=False)
self._check_formats(hls_formats, video_id)
formats.extend(hls_format... | @@ -157,3 +157,24 @@ def _real_extract(self, url):
'thumbnails': thumbnails,
'age_limit': 18,
}
+
+
+class XVideosQuickiesIE(InfoExtractor):
+ IE_NAME = 'xvideos:quickies'
+ _VALID_URL = r'https?://(?P<domain>(?:[^/]+\.)?xvideos2?\.com)/amateur-channels/[^#]+#quickies/a/(?P<id>\... | yt_dlp/extractor/xvideos.py | 26 | Python | 0.571 | refactor | 110 | 43 | 43 | false | [xvideos] Added support for quickies | 6,414 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Yakabuff |
'title': title,
'duration': duration,
'thumbnails': thumbnails,
'age_limit': 18,
}
class XVideosQuickiesIE(InfoExtractor):
IE_NAME = 'xvideos:quickies'
_VALID_URL = r'https?://(?P<domain>(?:[^/]+\.)?xvideos2?\.com)/amateur-channels/[^#]+#quickies/a/(?P<i... | ```suggestion
return self.url_result(f'https://{domain}/video{id_}/_', XVideosIE, id_)
``` | 'title': title,
'duration': duration,
'thumbnails': thumbnails,
'age_limit': 18,
}
class XVideosQuickiesIE(InfoExtractor):
IE_NAME = 'xvideos:quickies'
_VALID_URL = r'https?://(?P<domain>(?:[^/]+\.)?xvideos2?\.com)/amateur-channels/[^#]+#quickies/a/(?P<i... | @@ -157,3 +157,24 @@ def _real_extract(self, url):
'thumbnails': thumbnails,
'age_limit': 18,
}
+
+
+class XVideosQuickiesIE(InfoExtractor):
+ IE_NAME = 'xvideos:quickies'
+ _VALID_URL = r'https?://(?P<domain>(?:[^/]+\.)?xvideos2?\.com)/amateur-channels/[^#]+#quickies/a/(?P<id>\... | yt_dlp/extractor/xvideos.py | 26 | Python | 0.714 | suggestion | 100 | 27 | 27 | false | [xvideos] Added support for quickies | 6,414 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | Yakabuff |
'responsive_web_text_conversations_enabled': False,
'responsive_web_uc_gql_enabled': True,
'standardized_nudges_misinfo': True,
'tweet_with_visibility_results_prefer_gql_limited_actions_policy_enabled': False,
'tweetypie_unmention_optimizat... | ```suggestion
}), 'retweeted_status', None)
``` | 'responsive_web_text_conversations_enabled': False,
'responsive_web_uc_gql_enabled': True,
'standardized_nudges_misinfo': True,
'tweet_with_visibility_results_prefer_gql_limited_actions_policy_enabled': False,
'tweetypie_unmention_optimizat... | @@ -949,13 +971,13 @@ def _real_extract(self, url):
status = self._graphql_to_legacy(result, twid)
else:
- status = self._call_api(f'statuses/show/{twid}.json', twid, {
+ status = traverse_obj(self._call_api(f'statuses/show/{twid}.json', twid, {
'cards_plat... | yt_dlp/extractor/twitter.py | 26 | Python | 0.571 | suggestion | 61 | 51 | 51 | false | [extractor/twitter] fix extraction through rest api on links to retweet id | 6,422 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | selfisekai |
import re
from .common import InfoExtractor
from ..utils import (
clean_html,
remove_end,
str_or_none,
traverse_obj,
urljoin,
)
class MediaStreamBaseIE(InfoExtractor):
_EMBED_BASE_URL = 'https://mdstrm.com/embed'
_BASE_URL_RE = r'https?://mdstrm\.com/(?:embed|live-stream)'
def _extra... | If you can make this a `classmethod`, then it can be defined as `MediaStreamIE_extract_embed_urls`. Base-class and _extract_from_webpage aren't needed then. | import re
from .common import InfoExtractor
from ..utils import (
clean_html,
remove_end,
traverse_obj,
urljoin,
)
class MediaStreamBaseIE(InfoExtractor):
_EMBED_BASE_URL = 'https://mdstrm.com/embed'
_BASE_URL_RE = r'https?://mdstrm\.com/(?:embed|live-stream)'
def _extract_mediastream_ur... | @@ -2,16 +2,43 @@
from .common import InfoExtractor
from ..utils import (
+ clean_html,
remove_end,
str_or_none,
- strip_or_none,
traverse_obj,
urljoin,
)
-class MediaStreamIE(InfoExtractor):
- _VALID_URL = r'https?://mdstrm.com/(?:embed|live-stream)/(?P<id>\w+)'
+class MediaStream... | yt_dlp/extractor/mediastream.py | 16 | Python | 0.571 | refactor | 156 | 41 | 41 | false | [extractor/mediastream] Improve `WinSportsVideo` and embed extraction | 6,426 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | bashonly |
import re
from .common import InfoExtractor
from ..utils import (
clean_html,
remove_end,
traverse_obj,
urljoin,
)
class MediaStreamBaseIE(InfoExtractor):
_EMBED_BASE_URL = 'https://mdstrm.com/embed'
_BASE_URL_RE = r'https?://mdstrm\.com/(?:embed|live-stream)'
def _extract_mediastream_ur... | ```suggestion
mediastream_url, MediaStreamIE, display_id, title, url_transparent=True, display_id=display_id)
``` | 'thumbnail': r're:^https?://[^?#]+6402adb62bbf3b18d454e1b0',
'ext': 'mp4',
},
'params': {'skip_download': 'm3u8'},
}]
def _real_extract(self, url):
display_id = self._match_id(url)
webpage = self._download_webpage(url, display_id)
data = self._sea... | @@ -158,21 +171,36 @@ class WinSportsVideoIE(InfoExtractor):
'ext': 'mp4',
},
'params': {'skip_download': 'm3u8'},
+ }, {
+ 'url': 'https://www.winsports.co/videos/bucaramanga-se-quedo-con-el-grito-de-gol-en-la-garganta',
+ 'info_dict': {
+ 'id': '6402adb62bbf3... | yt_dlp/extractor/mediastream.py | 26 | Python | 0.714 | suggestion | 127 | 207 | 27 | false | [extractor/mediastream] Improve `WinSportsVideo` and embed extraction | 6,426 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | bashonly |
def _perform_login(self, username, password):
urlh = self._request_webpage(
'https://tube.tugraz.at/Shibboleth.sso/Login?target=/paella/ui/index.html',
None, fatal=False, note='downloading login page', errnote='unable to fetch login page')
if not urlh:
return
... | ```suggestion
if not self._html_search_regex(
r'<p\b[^>]*>(Bitte geben Sie einen OTP-Wert ein:)</p>',
content, 'TFA prompt', default=None):
``` |
def _perform_login(self, username, password):
urlh = self._request_webpage(
'https://tube.tugraz.at/Shibboleth.sso/Login?target=/paella/ui/index.html',
None, fatal=False, note='downloading login page', errnote='unable to fetch login page')
if not urlh:
return
... | @@ -21,17 +21,43 @@ def _perform_login(self, username, password):
if not urlh:
return
- urlh = self._request_webpage(
+ content, urlh = self._download_webpage_handle(
urlh.geturl(), None, fatal=False, headers={'referer': urlh.geturl()},
note='logging in', ... | yt_dlp/extractor/tubetugraz.py | 26 | Python | 0.714 | suggestion | 187 | 51 | 51 | false | [extractor/tubetugraz] Implement two-factor authentication (#6424) | 6,427 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Ferdi265 |
urlh = self._request_webpage(
urlh.geturl(), None, fatal=False, headers={'referer': urlh.geturl()},
note='logging in', errnote='unable to log in', data=urlencode_postdata({
'lang': 'de',
'_eventId_proceed': '',
'j_username': username,
... | ```suggestion
content, urlh = self._download_webpage_handle(
urlh.geturl(), None, fatal=False, headers={'referer': urlh.geturl()},
note='logging in with TFA', errnote='unable to log in with TFA',
data=urlencode_postdata({
'lang': 'de',
'_... | content, urlh = self._download_webpage_handle(
urlh.geturl(), None, fatal=False, headers={'referer': urlh.geturl()},
note='logging in', errnote='unable to log in',
data=urlencode_postdata({
'lang': 'de',
'_eventId_proceed': '',
... | @@ -21,17 +21,43 @@ def _perform_login(self, username, password):
if not urlh:
return
- urlh = self._request_webpage(
+ content, urlh = self._download_webpage_handle(
urlh.geturl(), None, fatal=False, headers={'referer': urlh.geturl()},
note='logging in', ... | yt_dlp/extractor/tubetugraz.py | 26 | Python | 0.929 | suggestion | 419 | 51 | 51 | false | [extractor/tubetugraz] Implement two-factor authentication (#6424) | 6,427 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Ferdi265 |
'_eventId_proceed': '',
'j_username': username,
'j_password': password
}))
if urlh and urlh.geturl() != 'https://tube.tugraz.at/paella/ui/index.html':
self.report_warning('unable to login: incorrect password')
def _extract_episode(sel... | This doesnt make sense to me. If the call fails `not urlh`, then give no warning? | 'lang': 'de',
'_eventId_proceed': '',
'j_username': username,
'j_password': password
}))
if not urlh or urlh.geturl() == 'https://tube.tugraz.at/paella/ui/index.html':
return
if not self._html_search_regex(
... | @@ -21,17 +21,43 @@ def _perform_login(self, username, password):
if not urlh:
return
- urlh = self._request_webpage(
+ content, urlh = self._download_webpage_handle(
urlh.geturl(), None, fatal=False, headers={'referer': urlh.geturl()},
note='logging in', ... | yt_dlp/extractor/tubetugraz.py | 26 | Python | 0.357 | bug | 81 | 51 | 51 | false | [extractor/tubetugraz] Implement two-factor authentication (#6424) | 6,427 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Ferdi265 |
class TubeTuGrazBaseIE(InfoExtractor):
_NETRC_MACHINE = 'tubetugraz'
_API_EPISODE = 'https://tube.tugraz.at/search/episode.json'
_FORMAT_TYPES = ('presentation', 'presenter')
def _perform_login(self, username, password):
urlh = self._request_webpage(
'https://tube.tugraz.at/Shibb... | ```suggestion
if not urlh or urlh.geturl() == 'https://tube.tugraz.at/paella/ui/index.html':
return
``` |
class TubeTuGrazBaseIE(InfoExtractor):
_NETRC_MACHINE = 'tubetugraz'
_API_EPISODE = 'https://tube.tugraz.at/search/episode.json'
_FORMAT_TYPES = ('presentation', 'presenter')
def _perform_login(self, username, password):
urlh = self._request_webpage(
'https://tube.tugraz.at/Shibb... | @@ -21,17 +21,43 @@ def _perform_login(self, username, password):
if not urlh:
return
- urlh = self._request_webpage(
+ content, urlh = self._download_webpage_handle(
urlh.geturl(), None, fatal=False, headers={'referer': urlh.geturl()},
note='logging in', ... | yt_dlp/extractor/tubetugraz.py | 26 | Python | 0.714 | suggestion | 128 | 51 | 51 | false | [extractor/tubetugraz] Implement two-factor authentication (#6424) | 6,427 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Ferdi265 |
ExtractorError,
clean_html,
determine_ext,
make_archive_id,
merge_dicts,
mimetype2ext,
parse_duration,
traverse_obj,
unified_timestamp,
urljoin,
url_or_none,
)
class TeamcocoBaseIE(TurnerBaseIE):
_QUALITIES = {
'low': (480, 272),
'sd': (640, 360),
... | FYI:
```suggestion
for src in traverse_obj(info, ('src', ..., {dict})):
```
is the recommended way now | ExtractorError,
clean_html,
determine_ext,
make_archive_id,
merge_dicts,
mimetype2ext,
parse_duration,
parse_qs,
traverse_obj,
unified_timestamp,
urljoin,
url_or_none,
)
class TeamcocoBaseIE(TurnerBaseIE):
_QUALITIES = {
'low': (480, 272),
'sd': (640... | @@ -1,57 +1,108 @@
import json
+import re
from .turner import TurnerBaseIE
from ..utils import (
- determine_ext,
ExtractorError,
- int_or_none,
+ clean_html,
+ determine_ext,
+ make_archive_id,
+ merge_dicts,
mimetype2ext,
parse_duration,
- parse_iso8601,
- qualities,
+ t... | yt_dlp/extractor/teamcoco.py | 26 | Python | 0.714 | suggestion | 114 | 51 | 51 | false | [extractor/teamcoco] Fix extractor | 6,437 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | bashonly |
'url': 'http://teamcoco.com/video/full-episode-mon-6-1-joel-mchale-jake-tapper-and-musical-guest-courtney-barnett?playlist=x;eyJ0eXBlIjoidGFnIiwiaWQiOjl9',
'info_dict': {
'id': '89341',
'ext': 'mp4',
'title': 'Full Episode - Mon. 6/1 - Joel McHale,... | display_id can have `/`. You don't have to change this if this is ur preference though | }, {
'url': 'http://teamcoco.com/video/full-episode-mon-6-1-joel-mchale-jake-tapper-and-musical-guest-courtney-barnett?playlist=x;eyJ0eXBlIjoidGFnIiwiaWQiOjl9',
'info_dict': {
'id': '89341',
'ext': 'mp4',
'title': 'Full Episode - Mon. 6/1 -... | @@ -76,126 +124,157 @@ class TeamcocoIE(TurnerBaseIE):
}, {
'url': 'http://teamcoco.com/israel/conan-hits-the-streets-beaches-of-tel-aviv',
'only_matching': True,
- }, {
- 'url': 'https://conan25.teamcoco.com/video/ice-cube-kevin-hart-conan-share-lyft',
- ... | yt_dlp/extractor/teamcoco.py | 26 | Python | 0.429 | suggestion | 86 | 51 | 51 | false | [extractor/teamcoco] Fix extractor | 6,437 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | bashonly |
'title': 'Full Episode - Mon. 6/1 - Joel McHale, Jake Tapper, And Musical Guest Courtney Barnett',
'description': 'Guests: Joel McHale, Jake Tapper, And Musical Guest Courtney Barnett',
},
'skip': 'This video is no longer available.',
}, {
'url... | ```suggestion
info = merge_dicts(*traverse_obj(data, ('blocks',
lambda _, v: v['name'] in ('meta-tags', 'video-player', 'video-info'),
'props', {dict})))
```
(may need re-formatting) | 'ext': 'mp4',
'title': 'Full Episode - Mon. 6/1 - Joel McHale, Jake Tapper, And Musical Guest Courtney Barnett',
'description': 'Guests: Joel McHale, Jake Tapper, And Musical Guest Courtney Barnett',
},
'skip': 'This video is no longer available.',... | @@ -76,126 +124,157 @@ class TeamcocoIE(TurnerBaseIE):
}, {
'url': 'http://teamcoco.com/israel/conan-hits-the-streets-beaches-of-tel-aviv',
'only_matching': True,
- }, {
- 'url': 'https://conan25.teamcoco.com/video/ice-cube-kevin-hart-conan-share-lyft',
- ... | yt_dlp/extractor/teamcoco.py | 26 | Python | 0.786 | suggestion | 219 | 51 | 51 | false | [extractor/teamcoco] Fix extractor | 6,437 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | bashonly |
}, {
'url': 'http://teamcoco.com/video/the-conan-audiencey-awards-for-04/25/18',
'only_matching': True,
}, {
'url': 'http://teamcoco.com/italy/conan-jordan-schlansky-hit-the-streets-of-florence',
'only_matching': True,
}, {
'url': 'http... | that's a weird way to get video_id | 'skip': 'This video is no longer available.',
}, {
'url': 'http://teamcoco.com/video/the-conan-audiencey-awards-for-04/25/18',
'only_matching': True,
}, {
'url': 'http://teamcoco.com/italy/conan-jordan-schlansky-hit-the-streets-of-florence',
'o... | @@ -76,126 +124,157 @@ class TeamcocoIE(TurnerBaseIE):
}, {
'url': 'http://teamcoco.com/israel/conan-hits-the-streets-beaches-of-tel-aviv',
'only_matching': True,
- }, {
- 'url': 'https://conan25.teamcoco.com/video/ice-cube-kevin-hart-conan-share-lyft',
- ... | yt_dlp/extractor/teamcoco.py | 26 | Python | 0.071 | suggestion | 34 | 51 | 51 | false | [extractor/teamcoco] Fix extractor | 6,437 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | bashonly |
'playable_in_embed': True,
},
},
]
def _real_extract(self, url):
video_id = self._match_id(url)
data = self._download_json(
'https://api.parler.com/v0/public/parleys/' + video_id, video_id)['data']
if data.get('link'):
return ... | This could be done as dict key traversal w/transformations:
```suggestion
**traverse_obj(data, {
'url': ('video', 'videoSrc'),
'thumbnail': ('video', 'thumbnailUrl'),
'title': ('title', {strip_or_none}),
'description': ('body', {clean_htm... | import functools
from .common import InfoExtractor
from .youtube import YoutubeIE
from ..utils import (
clean_html,
int_or_none,
strip_or_none,
traverse_obj,
unified_timestamp,
urljoin,
)
class ParlerIE(InfoExtractor):
IE_DESC = 'Posts on parler.com'
_VALID_URL = r'https://parler\.com... | @@ -87,25 +86,22 @@ class ParlerIE(InfoExtractor):
def _real_extract(self, url):
video_id = self._match_id(url)
data = self._download_json(
- 'https://parler.com/open-api/ParleyDetailEndpoint.php', video_id,
- data=urlencode_postdata({'uuid': video_id}))['data'][0]
- ... | yt_dlp/extractor/parler.py | 26 | Python | 0.857 | suggestion | 1,027 | 28 | 92 | false | [Parler] update parler extraction with new api call | 6,446 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | JChris246 |
'upload_date': '20220716',
'duration': 1267,
'uploader': 'Mahesh Chookolingo',
'uploader_id': 'maheshchookolingo',
'uploader_url': 'http://www.youtube.com/user/maheshchookolingo',
'channel': 'Mahesh Chookolingo',
... | ```suggestion
f'https://api.parler.com/v0/public/parleys/{video_id}', video_id)['data']
``` | 'uploader_url': 'http://www.youtube.com/@maheshchookolingo',
},
},
]
def _real_extract(self, url):
video_id = self._match_id(url)
data = self._download_json(f'https://api.parler.com/v0/public/parleys/{video_id}',
video_id)['... | @@ -87,25 +86,24 @@ class ParlerIE(InfoExtractor):
def _real_extract(self, url):
video_id = self._match_id(url)
data = self._download_json(
- 'https://parler.com/open-api/ParleyDetailEndpoint.php', video_id,
- data=urlencode_postdata({'uuid': video_id}))['data'][0]
- ... | yt_dlp/extractor/parler.py | 26 | Python | 0.714 | suggestion | 105 | 47 | 29 | false | [Parler] update parler extraction with new api call | 6,446 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | JChris246 |
'uploader_id': 'maheshchookolingo',
'uploader_url': 'http://www.youtube.com/user/maheshchookolingo',
'channel': 'Mahesh Chookolingo',
'channel_id': 'UCox6YeMSY1PQInbCtTaZj_w',
'channel_url': 'https://www.youtube.com/channel/UCox6YeMSY1PQInb... | ```suggestion
return self.url_result(data['link'], YoutubeIE)
``` | ]
def _real_extract(self, url):
video_id = self._match_id(url)
data = self._download_json(f'https://api.parler.com/v0/public/parleys/{video_id}',
video_id)['data']
if data.get('link'):
return self.url_result(data['link'], YoutubeIE)
... | @@ -87,25 +86,24 @@ class ParlerIE(InfoExtractor):
def _real_extract(self, url):
video_id = self._match_id(url)
data = self._download_json(
- 'https://parler.com/open-api/ParleyDetailEndpoint.php', video_id,
- data=urlencode_postdata({'uuid': video_id}))['data'][0]
- ... | yt_dlp/extractor/parler.py | 26 | Python | 0.571 | suggestion | 79 | 44 | 26 | false | [Parler] update parler extraction with new api call | 6,446 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | JChris246 |
'live_status': 'not_live',
'view_count': int,
'comment_count': int,
'like_count': int,
'channel_follower_count': int,
'age_limit': 0,
'playable_in_embed': True,
},
},
]
def _real_... | ```suggestion
'description': ('body', {clean_html}, {lambda x: x or None}),
``` | import functools
from .common import InfoExtractor
from .youtube import YoutubeIE
from ..utils import (
clean_html,
int_or_none,
strip_or_none,
traverse_obj,
unified_timestamp,
urljoin,
)
class ParlerIE(InfoExtractor):
IE_DESC = 'Posts on parler.com'
_VALID_URL = r'https://parler\.com... | @@ -87,25 +86,24 @@ class ParlerIE(InfoExtractor):
def _real_extract(self, url):
video_id = self._match_id(url)
data = self._download_json(
- 'https://parler.com/open-api/ParleyDetailEndpoint.php', video_id,
- data=urlencode_postdata({'uuid': video_id}))['data'][0]
- ... | yt_dlp/extractor/parler.py | 26 | Python | 0.571 | suggestion | 97 | 36 | 92 | false | [Parler] update parler extraction with new api call | 6,446 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | JChris246 |
'uploader': 'Mimicc',
'timestamp': 1605580939,
'upload_date': '20201117',
'uploader_id': '5156321',
'thumbnail': 'https://cdn.medal.tv/5156321/thumbnail-36787208-360p.jpg?t=1080p&c=202046&missing',
'uploader_url': 'https://medal.tv/users/5156321',
... | ```suggestion
r'<script[^>]*>(?:var\s+)?hydrationData\s*=', webpage,
```
`.*?` can cause catastrophic backtracking if the page changes in future resulting in yt-dlp getting stuck indefinitely. Do u have any better idea? | 'uploader': 'Mimicc',
'timestamp': 1605580939,
'upload_date': '20201117',
'uploader_id': '5156321',
'thumbnail': 'https://cdn.medal.tv/5156321/thumbnail-36787208-360p.jpg?t=1080p&c=202046&missing',
'uploader_url': 'https://medal.tv/users/5156321',
... | @@ -80,25 +80,14 @@ class MedalTVIE(InfoExtractor):
def _real_extract(self, url):
video_id = self._match_id(url)
- path = self._match_valid_url(url).group('path')
webpage = self._download_webpage(url, video_id)
- next_data = self._search_json(
- '<script[^>]*__NEXT_... | yt_dlp/extractor/medaltv.py | 26 | Python | 0.857 | question | 234 | 51 | 51 | false | [extractor/medaltv] Fix medal.tv clips URL (#6489) | 6,502 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | xenova |
BBCCoUkIE,
BBCCoUkArticleIE,
BBCCoUkIPlayerEpisodesIE,
BBCCoUkIPlayerGroupIE,
BBCCoUkPlaylistIE,
BBCIE,
)
from .beeg import BeegIE
from .behindkink import BehindKinkIE
from .bellmedia import BellMediaIE
from .beatbump import (
BeatBumpVideoIE,
BeatBumpPlaylistIE,
)
from .beatport import ... | Why not keep capitalization style from previous version? | BBCCoUkIE,
BBCCoUkArticleIE,
BBCCoUkIPlayerEpisodesIE,
BBCCoUkIPlayerGroupIE,
BBCCoUkPlaylistIE,
BBCIE,
)
from .beeg import BeegIE
from .behindkink import BehindKinkIE
from .bellmedia import BellMediaIE
from .beatbump import (
BeatBumpVideoIE,
BeatBumpPlaylistIE,
)
from .beatport import ... | @@ -204,7 +204,11 @@
BFMTVLiveIE,
BFMTVArticleIE,
)
-from .bibeltv import BibelTVIE
+from .bibeltv import (
+ BibelTVIE,
+ BibelTvLiveIE, | yt_dlp/extractor/_extractors.py | 26 | Python | 0.214 | question | 56 | 51 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | Since we dont use `media` this should be traversed instead
```suggestion
for media_url in traverse_obj(data, (..., 'src', {url_or_none})):
``` | media_ext = determine_ext(media_url)
if media_ext == 'm3u8':
m3u8_formats, m3u8_subs = self._extract_m3u8_formats_and_subtitles(
media_url, crn_id, live=is_live)
formats.extend(m3u8_formats)
subtitles.update(m3u8_subs)
... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.786 | suggestion | 153 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | ```suggestion
formats.append({'url': media_url})
``` | else:
self.report_warning(f'Unknown format {media_ext!r}')
return formats, subtitles
@staticmethod
def _extract_base_info(data):
return {
'id': data['crn'],
**traverse_obj(data, {
'title': 'title',
'description... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.571 | suggestion | 70 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | Use `int_or_none` or `float_or_none`, with a scale | 'view_count': 'viewCount',
'like_count': 'likeCount',
}),
'thumbnails': orderedSet(traverse_obj(data, ('images', ..., {
'url': ('url', {url_or_none}),
}))),
}
def _extract_url_info(self, data):
return {
... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.429 | suggestion | 50 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | `self.url_result()`? Also this might be cleaner as traversal with a `dict` key | AUTH_TOKEN = 'j88bRXY8DsEqJ9xmTdWhrByVi5Hm'
def _extract_formats_and_subtitles(self, data, crn_id, *, is_live=False):
formats = []
subtitles = {}
for media_url in traverse_obj(data, (..., 'src', {url_or_none})):
media_ext = determine_ext(media_url)
if media_ext =... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.357 | suggestion | 78 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | use `traverse_obj` here instead:
```suggestion
traverse_obj(json_data, ('video', 'videoUrls', ..., {url_or_none})), crn_id)
``` | if data.get('drm'):
self.report_drm(crn_id)
json_data = self._download_json(
format_field(data, 'id', f'{self.API_URL}/video/%s'), crn_id,
headers={'Authorization': self.AUTH_TOKEN}, fatal=False,
errnote='No formats available') or {}
formats, sub... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.786 | suggestion | 142 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | ```suggestion
video_data = traverse_obj(
self._search_nextjs_data(self._download_webpage(url, crn_id), crn_id),
('props', 'pageProps', 'videoPageData', 'videos', 0, {dict}))
``` | IE_NAME = 'bibeltv:video'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/344436-alte-wege',
'md5': 'ec1c07efe54353780512e8a4103b612e',
'info_dict': {
'id': '344436',
'ext': 'mp4',
'title': 'Alte Wege',
'description': 'md5:2f4e... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.786 | suggestion | 215 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | Do not subclass from a concrete IE. Instead, create a `BibelTVBaseIE` and implement `_extract_video`/`_extract_url_info`/`API_URL`/... on that. Additionally `_extract_video` and `_extract_url_info` seem very close and could possibly be further abstracted (`_extract_video` calls `_extract_url_info`?). | 'ext': 'mp4',
'title': 'Alte Wege',
'description': 'md5:2f4eb7294c9797a47b8fd13cccca22e9',
'timestamp': 1677877071,
'duration': 150.0,
'upload_date': '20230303',
'thumbnail': r're:https://bibeltv\.imgix\.net/[\w-]+\.jpg',
'e... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.643 | refactor | 301 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | ```suggestion
video_data = traverse_obj(serie_data, ('videos', ..., {dict}))
``` |
class BibelTVSeriesIE(BibelTVBaseIE):
IE_DESC = 'BibelTV series playlist'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/serien/(?P<id>\d+)[\w-]+'
IE_NAME = 'bibeltv:series'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/serien/333485-ein-wunder-fuer-jeden-tag',
'playli... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.571 | suggestion | 90 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | Maybe call this `series_data` since thats the english name? Perhaps thats also relevant for the `BibelTvSerienIE`? | ('props', 'pageProps', 'videoPageData', 'videos', 0, {dict}))
if not video_data:
raise ExtractorError('Missing video data.')
return self._extract_video_info(video_data)
class BibelTVSeriesIE(BibelTVBaseIE):
IE_DESC = 'BibelTV series playlist'
_VALID_URL = r'https?://(?... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.5 | question | 114 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | Same, use `traverse_obj` pref. | 'title': 're:Bibel TV',
'live_status': 'is_live',
'thumbnail': 'https://streampreview.bibeltv.de/bibeltv.webp',
},
'params': {'skip_download': 'm3u8'},
}, {
'url': 'https://www.bibeltv.de/livestreams/impuls/',
'only_matching': True,
}]
def... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.286 | suggestion | 30 | 28 | 29 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | Maybe `format_field` makes more sense here? That will result in a falsy value instead of an invalid url...
```suggestion
'url': format_field(data, 'slug', 'https://www.bibeltv.de/mediathek/videos/%s'),
``` | 'timestamp': ('schedulingStart', {parse_iso8601}),
'season_number': 'seasonNumber',
'episode_number': 'episodeNumber',
'view_count': 'viewCount',
'like_count': 'likeCount',
}),
'thumbnails': orderedSet(traverse_obj(d... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.857 | suggestion | 220 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | Why did you define this? It should be handled by IE? | from functools import partial
from .common import InfoExtractor
from ..utils import (
ExtractorError,
clean_html,
determine_ext,
format_field,
int_or_none,
js_to_json,
orderedSet,
parse_iso8601,
traverse_obj,
url_or_none,
)
class BibelTVBaseIE(InfoExtractor):
_GEO_COUNTRIE... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 16 | Python | 0.429 | question | 52 | 28 | 41 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | This might be cleaner? Are there direct duplicates?
```suggestion
'thumbnails': [{'url': url} for url in set(traverse_obj(data, ('images', ..., 'url', {url_or_none})))],
``` | }),
'thumbnails': orderedSet(traverse_obj(data, ('images', ..., {
'url': ('url', {url_or_none}),
}))),
}
def _extract_url_info(self, data):
return {
'_type': 'url',
'url': format_field(data, 'slug', 'https://www.bibeltv.de/... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.714 | refactor | 188 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | ```suggestion
return self.playlist_result(
list(map(self._extract_url_info, video_data)), crn_id,
serie_data.get('title'), clean_html(serie_data.get('description')))
```
Since there is no API calls, there's no need for it to be lazylist | 'url': 'https://www.bibeltv.de/mediathek/serien/333485-ein-wunder-fuer-jeden-tag',
'playlist_mincount': 400,
'info_dict': {
'id': '333485',
'title': 'Ein Wunder für jeden Tag',
'description': 'Tägliche Kurzandacht mit Déborah Rosenkranz.',
},
}]
... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.857 | refactor | 273 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | We should probably modify js_to_json to support `, but out of scope for this PR |
_TESTS = [{
'url': 'https://www.bibeltv.de/livestreams/bibeltv/',
'info_dict': {
'id': 'bibeltv',
'ext': 'mp4',
'title': 're:Bibel TV',
'live_status': 'is_live',
'thumbnail': 'https://streampreview.bibeltv.de/bibeltv.webp',
},
... | @@ -1,27 +1,204 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ LazyList,
+ clean_html,
+ determine_ext,
+ js_to_json,
+ parse_iso8601,
+ try_get
+)
class BibelTVIE(InfoExtractor):
+ IE_DESC = 'BibelTV'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/medi... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.429 | suggestion | 79 | 28 | 35 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | ```suggestion
```
This is not needed as `traverse_obj` filters the `None` returned by `url_or_none` already. | formats.extend(m3u8_formats)
subtitles.update(m3u8_subs)
elif media_ext == 'mpd':
mpd_formats, mpd_subs = self._extract_mpd_formats_and_subtitles(media_url, crn_id)
formats.extend(mpd_formats)
subtitles.update(mpd_subs)
... | @@ -1,27 +1,202 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ clean_html,
+ determine_ext,
+ format_field,
+ int_or_none,
+ js_to_json,
+ orderedSet,
+ parse_iso8601,
+ traverse_obj,
+ try_get,
+ url_or_none,
+)
class BibelTVIE(InfoExtractor):
+ ... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.714 | suggestion | 110 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | ```suggestion
series_data = traverse_obj(nextjs_data, ('props', 'pageProps', 'seriePageData', {dict})) dict)
```
This also removes the `try_get` from imports. | self._search_nextjs_data(self._download_webpage(url, crn_id), crn_id),
('props', 'pageProps', 'videoPageData', 'videos', 0, {dict}))
if not video_data:
raise ExtractorError('Missing video data.')
return self._extract_video_info(video_data)
class BibelTVSeriesIE(Bib... | @@ -1,27 +1,202 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ clean_html,
+ determine_ext,
+ format_field,
+ int_or_none,
+ js_to_json,
+ orderedSet,
+ parse_iso8601,
+ traverse_obj,
+ try_get,
+ url_or_none,
+)
class BibelTVIE(InfoExtractor):
+ ... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.786 | suggestion | 169 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | If we make it a `list`, we can make use of `traverse_obj` inline:
```suggestion
return self.playlist_result(
traverse_obj(series_data, ('videos', ..., {dict}, {self._extract_url_info})),
crn_id, serie_data.get('title'), clean_html(serie_data.get('description')))
``` |
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/serien/333485-ein-wunder-fuer-jeden-tag',
'playlist_mincount': 400,
'info_dict': {
'id': '333485',
'title': 'Ein Wunder für jeden Tag',
'description': 'Tägliche Kurzandacht mit Déborah Rosenkranz.',
... | @@ -1,27 +1,202 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ clean_html,
+ determine_ext,
+ format_field,
+ int_or_none,
+ js_to_json,
+ orderedSet,
+ parse_iso8601,
+ traverse_obj,
+ try_get,
+ url_or_none,
+)
class BibelTVIE(InfoExtractor):
+ ... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.857 | refactor | 303 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | Since the id changed, wouldn't `_old_archive_id` have to be set? Ignore if it cannot be calculated. | json_data = self._download_json(
format_field(data, 'id', f'{self.API_URL}/video/%s'), crn_id,
headers={'Authorization': self.AUTH_TOKEN}, fatal=False,
errnote='No formats available') or {}
formats, subtitles = self._extract_formats_and_subtitles(
travers... | @@ -1,27 +1,192 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ clean_html,
+ determine_ext,
+ format_field,
+ int_or_none,
+ js_to_json,
+ orderedSet,
+ parse_iso8601,
+ traverse_obj,
+ url_or_none,
+)
-class BibelTVIE(InfoExtractor):
- _VALID_URL =... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.429 | suggestion | 99 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | ```suggestion
series_data = traverse_obj(self._search_nextjs_data(webpage, crn_id), (
'props', 'pageProps', 'seriePageData', {dict}))
```
as per "don't create variables used only once" policy | if not video_data:
raise ExtractorError('Missing video data.')
return self._extract_video_info(video_data)
class BibelTVSeriesIE(BibelTVBaseIE):
IE_DESC = 'BibelTV series playlist'
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/serien/(?P<id>\d+)[\w-]+'
IE_NAME = 'bib... | @@ -1,27 +1,192 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ clean_html,
+ determine_ext,
+ format_field,
+ int_or_none,
+ js_to_json,
+ orderedSet,
+ parse_iso8601,
+ traverse_obj,
+ url_or_none,
+)
-class BibelTVIE(InfoExtractor):
- _VALID_URL =... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.857 | suggestion | 215 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | I feel like this is easier to read. Might just be me though, feel free to ignore
```suggestion
'thumbnails': orderedSet(traverse_obj(data, ('images', ..., {
'url': ('url', {url_or_none}),
}))),
``` | for media_url in traverse_obj(data, (..., 'src', {url_or_none})):
media_ext = determine_ext(media_url)
if media_ext == 'm3u8':
m3u8_formats, m3u8_subs = self._extract_m3u8_formats_and_subtitles(
media_url, crn_id, live=is_live)
formats.... | @@ -1,27 +1,192 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ clean_html,
+ determine_ext,
+ format_field,
+ int_or_none,
+ js_to_json,
+ orderedSet,
+ parse_iso8601,
+ traverse_obj,
+ url_or_none,
+)
-class BibelTVIE(InfoExtractor):
- _VALID_URL =... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.786 | suggestion | 242 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | ```suggestion
return {
'id': data['crn'],
**traverse_obj(data, {
'title': 'title',
'description': 'description',
'duration': ('duration', {functools.partial(int_or_none, scale=1000)},
'timestamp': ('schedulingStart', ... | subtitles.update(mpd_subs)
elif media_ext == 'mp4':
formats.append({'url': media_url})
else:
self.report_warning(f'Unknown format {media_ext!r}')
return formats, subtitles
@staticmethod
def _extract_base_info(data):
return... | @@ -1,27 +1,192 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ clean_html,
+ determine_ext,
+ format_field,
+ int_or_none,
+ js_to_json,
+ orderedSet,
+ parse_iso8601,
+ traverse_obj,
+ url_or_none,
+)
-class BibelTVIE(InfoExtractor):
- _VALID_URL =... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.786 | suggestion | 605 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | flashdagger |
from .common import InfoExtractor
class BibelTVIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?bibeltv\.de/mediathek/videos/(?:crn/)?(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.bibeltv.de/mediathek/videos/329703-sprachkurs-in-malaiisch',
'md5': '252f908192d611de038b8504b08bf97f',
... | Can't this be added to _extract_base_info? | 'thumbnails': orderedSet(traverse_obj(data, ('images', ..., {
'url': ('url', {url_or_none}),
}))),
}
def _extract_url_info(self, data):
return {
'_type': 'url',
'url': format_field(data, 'slug', 'https://www.bibeltv.de/mediathek/videos... | @@ -1,27 +1,192 @@
from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ clean_html,
+ determine_ext,
+ format_field,
+ int_or_none,
+ js_to_json,
+ orderedSet,
+ parse_iso8601,
+ traverse_obj,
+ url_or_none,
+)
-class BibelTVIE(InfoExtractor):
- _VALID_URL =... | yt_dlp/extractor/bibeltv.py | 26 | Python | 0.143 | refactor | 42 | 28 | 51 | false | [bibeltv] new implementation | 6,505 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | flashdagger |
'was_live': True,
'live_status': 'was_live',
'timestamp': 1635874720,
'release_timestamp': 1635874720,
'release_date': '20211102',
'upload_date': '20211102',
'dislike_count': int,
'like_count': int,
'tags': ['Fre... | If they change the url format, instead of failing, this would just put `video_url = timeline_url` which we don't want. Maybe instead of `re.sub`, `_search_regex` the slug out first?
Like this, for e.g.
```suggestion
if video_url in (None, 'fake.m3u8'):
video_url = format_field(self._search_reg... | 'is_live': False,
'was_live': True,
'live_status': 'was_live',
'timestamp': 1635874720,
'release_timestamp': 1635874720,
'release_date': '20211102',
'upload_date': '20211102',
'dislike_count': int,
'like_count': ... | @@ -100,6 +100,10 @@ def _real_extract(self, url):
else 'not_live')
video_url = traverse_obj(metadata, 'url', ('content', 'contentUrl'), expected_type=url_or_none)
+ timeline_url = traverse_obj(metadata, 'timelineUrl', ('content', 'timelineUrl'), expected_type=url_or_none)
+ ... | yt_dlp/extractor/rokfin.py | 26 | Python | 1 | bug | 585 | 51 | 51 | false | rokfin: extract premium video url from timeline url | 6,507 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | vampirefrog |
'repost_count': int,
'artist': 'Akihitoko',
'track': 'original sound',
'description': 'md5:edc3e7ea587847f8537468f2fe51d074',
'uploader': 'akihitoko1',
'creator': 'Akihitoko',
},
}, {
'url': 'https://vt.tiktok.com/ZSe4FqkKd',
... | ```suggestion
_VALID_URL = r'''(?x)https?://(?:
(?:www\.)?tiktok\.com/@(?P<uploader>[\w.-]+)/live|
m\.tiktok\.com/share/live/(?P<id>\d+)
)'''
``` | 'thumbnail': r're:https://.+\.webp.*',
'uploader_url': 'https://www.tiktok.com/@MS4wLjABAAAAdZ_NcPPgMneaGrW0hN8O_J_bwLshwNNERRF5DxOw2HKIzk0kdlLrR8RkVl1ksrMO',
'duration': 29,
'timestamp': 1654680400,
'repost_count': int,
'artist': 'Akihitoko',
... | @@ -984,39 +984,119 @@ def _real_extract(self, url):
class TikTokLiveIE(InfoExtractor):
- _VALID_URL = r'https?://(?:www\.)?tiktok\.com/@(?P<id>[\w\.-]+)/live'
+ _VALID_URL = r'''(?x)
+ https?://(?:
+ (?:www\.)?tiktok\.com/@(?P<uploader>[\w.-]+)/live|
+ ... | yt_dlp/extractor/tiktok.py | 26 | Python | 0.714 | suggestion | 174 | 51 | 51 | false | [extractor/tiktok] Improve `TikTokLive` extractor | 6,520 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | bashonly |
'creator': 'Pilarmagenta',
'uploader': 'pilarmagenta',
'uploader_id': '6624846890674683909',
'live_status': 'is_live',
'concurrent_view_count': int,
},
'skip': 'Livestream',
}, {
'url': 'https://m.tiktok.com/share/live/7209423610325... | ```suggestion
get_quality = qualities(('SD1', 'SD2', 'HD1', 'pm_mt_video_720p60', 'FULL_HD1', 'pm_mt_video_1080p60', 'rtmp', 'ORIGION', 'hls'))
```
since u never access the tuple directly | 'id': '7210809319192726273',
'ext': 'mp4',
'title': r're:ウェザーニュースLiVE[\d\s:-]*',
'creator': 'ウェザーニュースLiVE',
'uploader': 'weathernewslive',
'uploader_id': '6621496731283095554',
'uploader_url': 'https://www.tiktok.com/@weathernewslive',
... | @@ -984,39 +984,119 @@ def _real_extract(self, url):
class TikTokLiveIE(InfoExtractor):
- _VALID_URL = r'https?://(?:www\.)?tiktok\.com/@(?P<id>[\w\.-]+)/live'
+ _VALID_URL = r'''(?x)
+ https?://(?:
+ (?:www\.)?tiktok\.com/@(?P<uploader>[\w.-]+)/live|
+ ... | yt_dlp/extractor/tiktok.py | 26 | Python | 0.714 | suggestion | 194 | 51 | 51 | false | [extractor/tiktok] Improve `TikTokLive` extractor | 6,520 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | bashonly |
import json
from .common import InfoExtractor
from ..utils import int_or_none, traverse_obj
class PlaySuisseIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?playsuisse\.ch/(watch|detail)/(.*\?episodeId=)?(?P<id>[0-9]+)?'
_TESTS = [
{
# episode in a series
'url': 'https://w... | md5 for thumbnail is a bad idea. Can u use `re:` instead | import json
from .common import InfoExtractor
from ..utils import int_or_none, traverse_obj
class PlaySuisseIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?playsuisse\.ch/(?:watch|detail)/(?:[^#]*[?&]episodeId=)?(?P<id>[0-9]+)'
_TESTS = [
{
# Old URL
'url': 'https://www.p... | @@ -21,10 +22,10 @@ class PlaySuisseIE(InfoExtractor):
'season_number': 1,
'episode': 'Knochen',
'episode_number': 1,
- 'thumbnail': 'md5:9260abe0c0ec9b69914d0a10d54c5878'
+ 'thumbnail': 'md5:3cd4006d1f42cecbfdbd1ac35479c3dc' | yt_dlp/extractor/playsuisse.py | 25 | Python | 0.429 | suggestion | 56 | 50 | 50 | false | [extractor/playsuisse] fix new url format | 6,528 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | sbor23 |
import json
from .common import InfoExtractor
from ..utils import int_or_none, traverse_obj
class PlaySuisseIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?playsuisse\.ch/(watch|detail)/(.*\?episodeId=)?(?P<id>[0-9]+)?'
_TESTS = [
{
# episode in a series
'url': 'https://w... | * Avoid `.*`
* Use non-capturing groups `(?:...)`
* There can be other query
* Why did you make `id` optional?
```suggestion
_VALID_URL = r'https?://(?:www\.)?playsuisse\.ch/(?:watch|detail)(?:[^#]*[?&]episodeId=)?(?P<id>[0-9]+)'
``` | import json
from .common import InfoExtractor
from ..utils import int_or_none, traverse_obj
class PlaySuisseIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?playsuisse\.ch/(?:watch|detail)/(?:[^#]*[?&]episodeId=)?(?P<id>[0-9]+)'
_TESTS = [
{
# Old URL
'url': 'https://www.p... | @@ -5,10 +5,11 @@
class PlaySuisseIE(InfoExtractor):
- _VALID_URL = r'https?://(?:www\.)?playsuisse\.ch/watch/(?P<id>[0-9]+)'
+ _VALID_URL = r'https?://(?:www\.)?playsuisse\.ch/(watch|detail)/(.*\?episodeId=)?(?P<id>[0-9]+)?' | yt_dlp/extractor/playsuisse.py | 8 | Python | 0.857 | suggestion | 243 | 33 | 33 | false | [extractor/playsuisse] fix new url format | 6,528 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | sbor23 |
def _parse_mediapackage(self, video, video_id):
formats = []
base_media_url = video['.transformUrl'].replace('/thumbnail?', '/videomanifest?')
base_media_url += f"&cTag={video['.ctag']}&action=Access&part=index"
metadata = json.loads(video.get('MediaServiceFastMetadata'))
... | This seems like a bad way to de-duplicate. Can't we compare URLs? Or, just return everything - it's better than accidentally removing unique formats | 'uploader_id': '8dcec565-a956-4b91-95e5-bacfb8bc015f',
},
}, {
'url': 'https://greaternyace.sharepoint.com/:v:/s/acementornydrive/ETski5eAfNVEoPRZUAyy1wEBpLgVFYWso5bjbZjfBLlPUg?e=PQUfVb',
'md5': 'c496a01644223273bff12e93e501afd1',
'info_dict': {
'id': '01QI4AV... | @@ -0,0 +1,65 @@
+import json
+
+from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ traverse_obj,
+)
+
+
+class SharePointIE(InfoExtractor):
+ _VALID_URL = r'https?://[^\.]+\.sharepoint\.com/:v:/g/[^/]+/[^/]+/(?P<id>[^/?]+)'
+
+ _TESTS = [
+ {
+ 'url': 'https://lut... | yt_dlp/extractor/sharepoint.py | 26 | Python | 0.429 | refactor | 148 | 42 | 51 | false | [extractor/sharepoint] New extractor for Microsoft Sharepoint | 6,531 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
# but we always get all formats back no matter what settings you send
formats.extend(self._extract_mpd_formats(
f"{base_media_url}&format=dash", video_id, mpd_id='dash', fatal=False
))
formats.extend(self._extract_m3u8_formats(
f"{base_media_url}&format=hls", vide... | ```suggestion
video_id = self._match_id(url)
``` | 'duration': 3797.326,
'thumbnail': r're:https://.+/thumbnail',
},
}, {
'url': 'https://lut-my.sharepoint.com/personal/juha_eerola_student_lab_fi/_layouts/15/stream.aspx?id=%2Fpersonal%2Fjuha_eerola_student_lab_fi%2FDocuments%2FM-DL%2FCmvpJST.mp4&ga=1&referrer=StreamWebApp.Web... | @@ -0,0 +1,65 @@
+import json
+
+from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ traverse_obj,
+)
+
+
+class SharePointIE(InfoExtractor):
+ _VALID_URL = r'https?://[^\.]+\.sharepoint\.com/:v:/g/[^/]+/[^/]+/(?P<id>[^/?]+)'
+
+ _TESTS = [
+ {
+ 'url': 'https://lut... | yt_dlp/extractor/sharepoint.py | 26 | Python | 0.571 | suggestion | 58 | 32 | 51 | false | [extractor/sharepoint] New extractor for Microsoft Sharepoint | 6,531 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
import json
from .common import InfoExtractor
from ..utils import (
float_or_none,
traverse_obj,
)
class SharePointIE(InfoExtractor):
_VALID_URL = r'https?://[^\.]+\.sharepoint\.com/:v:/g/[^/]+/[^/]+/(?P<id>[^/?]+)'
_TESTS = [
{
'url': 'https://lut-my.sharepoint.com/:v:/g/persona... | Doesn't make sense to be a function imo | import json
import urllib.parse
from .common import InfoExtractor
from ..utils import determine_ext, int_or_none, url_or_none
from ..utils.traversal import traverse_obj
class SharePointIE(InfoExtractor):
_BASE_URL_RE = r'https?://[\w-]+\.sharepoint\.com/'
_VALID_URL = [
rf'{_BASE_URL_RE}:v:/[a-z]/(?:... | @@ -0,0 +1,65 @@
+import json
+
+from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ traverse_obj,
+)
+
+
+class SharePointIE(InfoExtractor):
+ _VALID_URL = r'https?://[^\.]+\.sharepoint\.com/:v:/g/[^/]+/[^/]+/(?P<id>[^/?]+)'
+
+ _TESTS = [
+ {
+ 'url': 'https://lut... | yt_dlp/extractor/sharepoint.py | 26 | Python | 0.071 | suggestion | 39 | 51 | 51 | false | [extractor/sharepoint] New extractor for Microsoft Sharepoint | 6,531 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
)
class SharePointIE(InfoExtractor):
_VALID_URL = r'https?://[^\.]+\.sharepoint\.com/:v:/g/[^/]+/[^/]+/(?P<id>[^/?]+)'
_TESTS = [
{
'url': 'https://lut-my.sharepoint.com/:v:/g/personal/juha_eerola_student_lab_fi/EUrAmrktb4ZMhUcY9J2PqMEBD_9x_l0DyYWVgAvp-TTOMw?e=ZpQOOw',
'info_d... | * This is still fatal and gets no benefit from the `.get`. ~~Use `self._parse_json` instead~~ See Grub4k's suggestion below
* Move it below near where it's actually used |
class SharePointIE(InfoExtractor):
_BASE_URL_RE = r'https?://[\w-]+\.sharepoint\.com/'
_VALID_URL = [
rf'{_BASE_URL_RE}:v:/[a-z]/(?:[^/?#]+/)*(?P<id>[^/?#]{{46}})/?(?:$|[?#])',
rf'{_BASE_URL_RE}(?!:v:)(?:[^/?#]+/)*stream\.aspx\?(?:[^#]+&)?id=(?P<id>[^&#]+)',
]
_TESTS = [{
'url'... | @@ -0,0 +1,65 @@
+import json
+
+from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ traverse_obj,
+)
+
+
+class SharePointIE(InfoExtractor):
+ _VALID_URL = r'https?://[^\.]+\.sharepoint\.com/:v:/g/[^/]+/[^/]+/(?P<id>[^/?]+)'
+
+ _TESTS = [
+ {
+ 'url': 'https://lut... | yt_dlp/extractor/sharepoint.py | 26 | Python | 0.571 | suggestion | 170 | 51 | 51 | false | [extractor/sharepoint] New extractor for Microsoft Sharepoint | 6,531 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
float_or_none,
traverse_obj,
)
class SharePointIE(InfoExtractor):
_VALID_URL = r'https?://[^\.]+\.sharepoint\.com/:v:/g/[^/]+/[^/]+/(?P<id>[^/?]+)'
_TESTS = [
{
'url': 'https://lut-my.sharepoint.com/:v:/g/personal/juha_eerola_student_lab_fi/EUrAmrktb4ZMhUcY9J2PqMEBD_9x_l0DyYWVgAvp... | ```suggestion
base_media_url = (video['.transformUrl'].replace('/thumbnail?', '/videomanifest?')
+ '&cTag={video[".ctag"]}&action=Access&part=index'))
```
Normally, I dislike +, but this is a good exception since below looks ugly
```py
base_media_url = (f'{video[".transfo... | from ..utils import determine_ext, int_or_none, url_or_none
from ..utils.traversal import traverse_obj
class SharePointIE(InfoExtractor):
_BASE_URL_RE = r'https?://[\w-]+\.sharepoint\.com/'
_VALID_URL = [
rf'{_BASE_URL_RE}:v:/[a-z]/(?:[^/?#]+/)*(?P<id>[^/?#]{{46}})/?(?:$|[?#])',
rf'{_BASE_URL_... | @@ -0,0 +1,65 @@
+import json
+
+from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ traverse_obj,
+)
+
+
+class SharePointIE(InfoExtractor):
+ _VALID_URL = r'https?://[^\.]+\.sharepoint\.com/:v:/g/[^/]+/[^/]+/(?P<id>[^/?]+)'
+
+ _TESTS = [
+ {
+ 'url': 'https://lut... | yt_dlp/extractor/sharepoint.py | 26 | Python | 1 | suggestion | 456 | 51 | 51 | false | [extractor/sharepoint] New extractor for Microsoft Sharepoint | 6,531 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
import json
from .common import InfoExtractor
from ..utils import (
float_or_none,
traverse_obj,
)
class SharePointIE(InfoExtractor):
_VALID_URL = r'https?://[^\.]+\.sharepoint\.com/:v:/g/[^/]+/[^/]+/(?P<id>[^/?]+)'
_TESTS = [
{
'url': 'https://lut-my.sharepoint.com/:v:/g/persona... | ```suggestion
_VALID_URL = r'https?://[^.]+\.sharepoint\.com/:v:/g/(?:[^/]+/){2}(?P<id>[^/?#]+)'
``` | import json
import urllib.parse
from .common import InfoExtractor
from ..utils import determine_ext, int_or_none, url_or_none
from ..utils.traversal import traverse_obj
class SharePointIE(InfoExtractor):
_BASE_URL_RE = r'https?://[\w-]+\.sharepoint\.com/'
_VALID_URL = [
rf'{_BASE_URL_RE}:v:/[a-z]/(?:... | @@ -0,0 +1,65 @@
+import json
+
+from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ traverse_obj,
+)
+
+
+class SharePointIE(InfoExtractor):
+ _VALID_URL = r'https?://[^\.]+\.sharepoint\.com/:v:/g/[^/]+/[^/]+/(?P<id>[^/?]+)' | yt_dlp/extractor/sharepoint.py | 11 | Python | 0.714 | suggestion | 106 | 36 | 36 | false | [extractor/sharepoint] New extractor for Microsoft Sharepoint | 6,531 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
'params': {'skip_download': 'm3u8'}
},
]
def _parse_mediapackage(self, video, video_id):
formats = []
base_media_url = video['.transformUrl'].replace('/thumbnail?', '/videomanifest?')
base_media_url += f"&cTag={video['.ctag']}&action=Access&part=index"
meta... | ```suggestion
formats = self._extract_mpd_formats(
f'{base_media_url}&format=dash', video_id, mpd_id='dash', fatal=False)
formats.extend(self._extract_m3u8_formats(
f'{base_media_url}&format=hls', video_id, m3u8_id='hls', fatal=False))
formats.extend(self._extract_m3... | 'title': 'CmvpJST',
'duration': 54.567,
'thumbnail': r're:https://.+/thumbnail',
'uploader_id': '8dcec565-a956-4b91-95e5-bacfb8bc015f',
},
}, {
'url': 'https://greaternyace.sharepoint.com/:v:/s/acementornydrive/ETski5eAfNVEoPRZUAyy1wEBpLgVFYWso5bjbZjfB... | @@ -0,0 +1,65 @@
+import json
+
+from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ traverse_obj,
+)
+
+
+class SharePointIE(InfoExtractor):
+ _VALID_URL = r'https?://[^\.]+\.sharepoint\.com/:v:/g/[^/]+/[^/]+/(?P<id>[^/?]+)'
+
+ _TESTS = [
+ {
+ 'url': 'https://lut... | yt_dlp/extractor/sharepoint.py | 26 | Python | 0.857 | refactor | 432 | 45 | 51 | false | [extractor/sharepoint] New extractor for Microsoft Sharepoint | 6,531 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
metadata = json.loads(video.get('MediaServiceFastMetadata'))
# Normally the player is configured with all possible options added to the format URLs,
# but we always get all formats back no matter what settings you send
formats.extend(self._extract_mpd_formats(
f"{base_media... | Perhaps this is cleaner as
```suggestion
'duration': traverse_obj(video, ('MediaServiceFastMetadata', {json.loads}, 'media', 'duration', {lambda x: x / 10000000})),
``` | 'id': '01QI4AVTZ3ESFZPAD42VCKB5CZKAGLFVYB',
'display_id': 'ETski5eAfNVEoPRZUAyy1wEBpLgVFYWso5bjbZjfBLlPUg',
'ext': 'mp4',
'title': '930103681233985536',
'duration': 3797.326,
'thumbnail': r're:https://.+/thumbnail',
},
}, {
'url... | @@ -0,0 +1,65 @@
+import json
+
+from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ traverse_obj,
+)
+
+
+class SharePointIE(InfoExtractor):
+ _VALID_URL = r'https?://[^\.]+\.sharepoint\.com/:v:/g/[^/]+/[^/]+/(?P<id>[^/?]+)'
+
+ _TESTS = [
+ {
+ 'url': 'https://lut... | yt_dlp/extractor/sharepoint.py | 26 | Python | 0.714 | suggestion | 183 | 36 | 51 | false | [extractor/sharepoint] New extractor for Microsoft Sharepoint | 6,531 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | C0D3D3V |
import json
from urllib.parse import (
parse_qs,
urlencode,
urljoin,
urlparse,
urlunparse,
)
from .common import InfoExtractor
from ..utils import (
traverse_obj,
)
class SharePointIE(InfoExtractor):
_VALID_URL = r'https?://[^.]+\.sharepoint\.com/:v:/g/(?:[^/]+/){2}(?P<id>[^/?#]+)'
... | ```suggestion
from ..utils.traversal import traverse_obj
``` | import json
import urllib.parse
from .common import InfoExtractor
from ..utils import determine_ext, int_or_none, url_or_none
from ..utils.traversal import traverse_obj
class SharePointIE(InfoExtractor):
_BASE_URL_RE = r'https?://[\w-]+\.sharepoint\.com/'
_VALID_URL = [
rf'{_BASE_URL_RE}:v:/[a-z]/(?:... | @@ -0,0 +1,71 @@
+import json
+
+from urllib.parse import (
+ parse_qs,
+ urlencode,
+ urljoin,
+ urlparse,
+ urlunparse,
+)
+
+from .common import InfoExtractor
+from ..utils import (
+ traverse_obj,
+) | yt_dlp/extractor/sharepoint.py | 14 | Python | 0.571 | suggestion | 62 | 39 | 39 | false | [extractor/sharepoint] New extractor for Microsoft Sharepoint | 6,531 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | C0D3D3V |
import json
from urllib.parse import (
parse_qs,
urlencode,
urljoin,
urlparse,
urlunparse,
)
from .common import InfoExtractor
from ..utils import (
traverse_obj,
)
class SharePointIE(InfoExtractor):
_VALID_URL = r'https?://[^.]+\.sharepoint\.com/:v:/g/(?:[^/]+/){2}(?P<id>[^/?#]+)'
... | ```suggestion
_VALID_URL = r'https?://[\w-]+\.sharepoint\.com/:v:/g/(?:[^/?#]+/){2}(?P<id>[^/?#]+)'
``` | import json
import urllib.parse
from .common import InfoExtractor
from ..utils import determine_ext, int_or_none, url_or_none
from ..utils.traversal import traverse_obj
class SharePointIE(InfoExtractor):
_BASE_URL_RE = r'https?://[\w-]+\.sharepoint\.com/'
_VALID_URL = [
rf'{_BASE_URL_RE}:v:/[a-z]/(?:... | @@ -0,0 +1,71 @@
+import json
+
+from urllib.parse import (
+ parse_qs,
+ urlencode,
+ urljoin,
+ urlparse,
+ urlunparse,
+)
+
+from .common import InfoExtractor
+from ..utils import (
+ traverse_obj,
+)
+
+
+class SharePointIE(InfoExtractor):
+ _VALID_URL = r'https?://[^.]+\.sharepoint\.com/:v:/g/... | yt_dlp/extractor/sharepoint.py | 18 | Python | 0.714 | suggestion | 109 | 43 | 43 | false | [extractor/sharepoint] New extractor for Microsoft Sharepoint | 6,531 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | C0D3D3V |
video_id = self._match_id(url)
webpage = self._download_webpage(url, video_id)
video = self._search_json(r'g_fileInfo\s*=', webpage, 'player config', video_id)
parsed_url = urlparse(video['.transformUrl'])
base_media_url = urlunparse(parsed_url._replace(
path=urljoi... | ```suggestion
hls_format['quality'] = -2
``` | 'title': '930103681233985536',
'duration': 3797.326,
'thumbnail': r're:https://.+/thumbnail',
},
}, {
'url': 'https://lut-my.sharepoint.com/personal/juha_eerola_student_lab_fi/_layouts/15/stream.aspx?id=%2Fpersonal%2Fjuha_eerola_student_lab_fi%2FDocuments%2FM-DL%2... | @@ -0,0 +1,71 @@
+import json
+
+from urllib.parse import (
+ parse_qs,
+ urlencode,
+ urljoin,
+ urlparse,
+ urlunparse,
+)
+
+from .common import InfoExtractor
+from ..utils import (
+ traverse_obj,
+)
+
+
+class SharePointIE(InfoExtractor):
+ _VALID_URL = r'https?://[^.]+\.sharepoint\.com/:v:/g/... | yt_dlp/extractor/sharepoint.py | 26 | Python | 0.571 | suggestion | 58 | 39 | 51 | false | [extractor/sharepoint] New extractor for Microsoft Sharepoint | 6,531 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | C0D3D3V |
import urllib.parse
from yt_dlp.extractor.common import InfoExtractor
from yt_dlp.utils import (
determine_ext,
ExtractorError,
url_or_none,
urlencode_postdata,
)
class OwnCloudIE(InfoExtractor):
_INSTANCES_RE = r'''(?:
sciebo\.de|
[^\.]+\.s... | ```suggestion
_INSTANCES_RE = '|'.join((
r'(?:[^\.]+\.)?sciebo\.de',
r'cloud\.uni-koblenz-landau\.de',
))
_VALID_URL = f'https?://(?:{_INSTANCES_RE})/s/(?P<id>[\w.-]+)'
``` | import re
import urllib.parse
from .common import InfoExtractor
from ..utils import (
ExtractorError,
determine_ext,
url_or_none,
urlencode_postdata,
)
class OwnCloudIE(InfoExtractor):
_INSTANCES_RE = '|'.join((
r'(?:[^\.]+\.)?sciebo\.de',
r'cloud\.uni-koblenz-landau\.de',
))
... | @@ -0,0 +1,88 @@
+import urllib.parse
+
+from yt_dlp.extractor.common import InfoExtractor
+from yt_dlp.utils import (
+ determine_ext,
+ ExtractorError,
+ url_or_none,
+ urlencode_postdata,
+)
+
+
+class OwnCloudIE(InfoExtractor):
+ _INSTANCES_RE = r'''(?:
+ sciebo\.de|
+ ... | yt_dlp/extractor/owncloud.py | 20 | Python | 0.786 | suggestion | 206 | 45 | 45 | false | [extractor/owncloud] New Extractor for Owncloud | 6,533 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
class OwnCloudIE(InfoExtractor):
_INSTANCES_RE = r'''(?:
sciebo\.de|
[^\.]+\.sciebo\.de|
cloud\.uni-koblenz-landau\.de|
)'''
_VALID_URL = rf'''(?x)
(?P<server>https?://{_INSTANCES_RE})/s/
... | ```suggestion
video_id = self._match_id(url)
webpage, urlh = self._download_webpage_handle(url, video_id)
``` |
class OwnCloudIE(InfoExtractor):
_INSTANCES_RE = '|'.join((
r'(?:[^\.]+\.)?sciebo\.de',
r'cloud\.uni-koblenz-landau\.de',
))
_VALID_URL = rf'https?://(?:{_INSTANCES_RE})/s/(?P<id>[\w.-]+)'
_TESTS = [
{
'url': 'https://ruhr-uni-bochum.sciebo.de/s/wWhqZzh9jTumVFN',
... | @@ -0,0 +1,88 @@
+import urllib.parse
+
+from yt_dlp.extractor.common import InfoExtractor
+from yt_dlp.utils import (
+ determine_ext,
+ ExtractorError,
+ url_or_none,
+ urlencode_postdata,
+)
+
+
+class OwnCloudIE(InfoExtractor):
+ _INSTANCES_RE = r'''(?:
+ sciebo\.de|
+ ... | yt_dlp/extractor/owncloud.py | 26 | Python | 0.857 | suggestion | 128 | 51 | 51 | false | [extractor/owncloud] New Extractor for Owncloud | 6,533 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
cloud\.uni-koblenz-landau\.de|
)'''
_VALID_URL = rf'''(?x)
(?P<server>https?://{_INSTANCES_RE})/s/
(?P<id>[\w\-\.]+)'''
_TESTS = [
{
'url': 'https://ruhr-uni-bochum.sciebo.de/s/wWhqZzh9jTumVFN',
'info_dict': {
... | Why use `urlh.geturl()`? If just `url` is insufficient, add test for it
```suggestion
webpage, urlh = self._verify_video_password(webpage, url, video_id)
``` | r'cloud\.uni-koblenz-landau\.de',
))
_VALID_URL = rf'https?://(?:{_INSTANCES_RE})/s/(?P<id>[\w.-]+)'
_TESTS = [
{
'url': 'https://ruhr-uni-bochum.sciebo.de/s/wWhqZzh9jTumVFN',
'info_dict': {
'id': 'wWhqZzh9jTumVFN',
'ext': 'mp4',
... | @@ -0,0 +1,88 @@
+import urllib.parse
+
+from yt_dlp.extractor.common import InfoExtractor
+from yt_dlp.utils import (
+ determine_ext,
+ ExtractorError,
+ url_or_none,
+ urlencode_postdata,
+)
+
+
+class OwnCloudIE(InfoExtractor):
+ _INSTANCES_RE = r'''(?:
+ sciebo\.de|
+ ... | yt_dlp/extractor/owncloud.py | 26 | Python | 0.786 | question | 172 | 51 | 51 | false | [extractor/owncloud] New Extractor for Owncloud | 6,533 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
# Password protected
webpage, urlh = self._verify_video_password(webpage, urlh.geturl(), video_id)
hidden_inputs = self._hidden_inputs(webpage)
title = hidden_inputs['filename']
return {
'id': video_id,
'title': title,
'url': url_or_n... | ```suggestion
password = self.get_param('videopassword')
if password is None:
raise ExtractorError(
'This video is protected by a password, use the --video-password option',
expected=True)
``` | ]
def _real_extract(self, url):
video_id = self._match_id(url)
webpage, urlh = self._download_webpage_handle(url, video_id)
if re.search(r'<label[^>]+for="password"', webpage):
webpage = self._verify_video_password(webpage, urlh.geturl(), video_id)
hidden_inputs = ... | @@ -0,0 +1,88 @@
+import urllib.parse
+
+from yt_dlp.extractor.common import InfoExtractor
+from yt_dlp.utils import (
+ determine_ext,
+ ExtractorError,
+ url_or_none,
+ urlencode_postdata,
+)
+
+
+class OwnCloudIE(InfoExtractor):
+ _INSTANCES_RE = r'''(?:
+ sciebo\.de|
+ ... | yt_dlp/extractor/owncloud.py | 26 | Python | 1 | refactor | 258 | 50 | 42 | false | [extractor/owncloud] New Extractor for Owncloud | 6,533 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
def _extend_to_download_url(self, url: str) -> str:
# Adds /download to the end of the URL path
url_parts = list(urllib.parse.urlparse(url))
url_parts[2] = url_parts[2].rstrip('/') + '/download'
return urllib.parse.urlunparse(url_parts)
def _verify_video_password(self, webpage, ... | ```suggestion
validation_response, urlh = self._download_webpage_handle(
url, video_id, 'Validating Password', 'Wrong password?',
data=urlencode_postdata({
'requesttoken': self._search_regex(
r'<input[^>]+?name="requesttoken" value="([^\"]+)"',
... | return {
'id': video_id,
'title': title,
'url': url_or_none(hidden_inputs.get('downloadURL')) or parsed_url._replace(
path=urllib.parse.urljoin(parsed_url.path, 'download')).geturl(),
'ext': determine_ext(title),
}
def _verify_video_pa... | @@ -0,0 +1,88 @@
+import urllib.parse
+
+from yt_dlp.extractor.common import InfoExtractor
+from yt_dlp.utils import (
+ determine_ext,
+ ExtractorError,
+ url_or_none,
+ urlencode_postdata,
+)
+
+
+class OwnCloudIE(InfoExtractor):
+ _INSTANCES_RE = r'''(?:
+ sciebo\.de|
+ ... | yt_dlp/extractor/owncloud.py | 26 | Python | 0.929 | bug | 425 | 37 | 29 | false | [extractor/owncloud] New Extractor for Owncloud | 6,533 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
if password is None:
raise ExtractorError(
'This video is protected by a password, use the --video-password option',
expected=True
)
data = urlencode_postdata(
{
'requesttoken': self._search_regex(
r... | ```suggestion
if re.search(r'<label[^>]+?for="password"', validation_response):
warning = self._search_regex(
r'<div[^>]+class="warning">([^<]*)</div>', validation_response,
'warning', default='The password is wrong')
``` | import re
import urllib.parse
from .common import InfoExtractor
from ..utils import (
ExtractorError,
determine_ext,
url_or_none,
urlencode_postdata,
)
class OwnCloudIE(InfoExtractor):
_INSTANCES_RE = '|'.join((
r'(?:[^\.]+\.)?sciebo\.de',
r'cloud\.uni-koblenz-landau\.de',
))
... | @@ -0,0 +1,88 @@
+import urllib.parse
+
+from yt_dlp.extractor.common import InfoExtractor
+from yt_dlp.utils import (
+ determine_ext,
+ ExtractorError,
+ url_or_none,
+ urlencode_postdata,
+)
+
+
+class OwnCloudIE(InfoExtractor):
+ _INSTANCES_RE = r'''(?:
+ sciebo\.de|
+ ... | yt_dlp/extractor/owncloud.py | 26 | Python | 0.786 | bug | 278 | 29 | 81 | false | [extractor/owncloud] New Extractor for Owncloud | 6,533 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
(?P<server>https?://{_INSTANCES_RE})/s/
(?P<id>[\w\-\.]+)'''
_TESTS = [
{
'url': 'https://ruhr-uni-bochum.sciebo.de/s/wWhqZzh9jTumVFN',
'info_dict': {
'id': 'wWhqZzh9jTumVFN',
'ext': 'mp4',
'title': 'CmvpJST.mp4',
... | ```suggestion
title = hidden_inputs.get('filename')
``` |
_TESTS = [
{
'url': 'https://ruhr-uni-bochum.sciebo.de/s/wWhqZzh9jTumVFN',
'info_dict': {
'id': 'wWhqZzh9jTumVFN',
'ext': 'mp4',
'title': 'CmvpJST.mp4',
},
},
{
'url': 'https://ruhr-uni-bochum.sc... | @@ -0,0 +1,88 @@
+import urllib.parse
+
+from yt_dlp.extractor.common import InfoExtractor
+from yt_dlp.utils import (
+ determine_ext,
+ ExtractorError,
+ url_or_none,
+ urlencode_postdata,
+)
+
+
+class OwnCloudIE(InfoExtractor):
+ _INSTANCES_RE = r'''(?:
+ sciebo\.de|
+ ... | yt_dlp/extractor/owncloud.py | 26 | Python | 0.571 | suggestion | 65 | 51 | 51 | false | [extractor/owncloud] New Extractor for Owncloud | 6,533 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
def _real_extract(self, url):
server, video_id = self._match_valid_url(url).group('server', 'id')
webpage, urlh = self._download_webpage_handle(f'{server}/s/{video_id}', video_id, 'Downloading webpage')
if self._search_regex(r'<label[^>]+?for="(password)"', webpage, 'password field',
... | ```suggestion
def _extend_to_download_url(self, url):
parsed = urllib.parse.urlparse(url)
return parsed._replace(
path=urllib.parse.urljoin(parsed.path, 'download')).geturl()
```
idk if this should even be a function | 'id': 'WNDuFu0XuFtmm3f',
'ext': 'mp4',
'title': 'CmvpJST.mp4',
},
'params': {
'videopassword': '12345',
},
},
]
def _real_extract(self, url):
video_id = self._match_id(url)
webpage, urlh ... | @@ -0,0 +1,88 @@
+import urllib.parse
+
+from yt_dlp.extractor.common import InfoExtractor
+from yt_dlp.utils import (
+ determine_ext,
+ ExtractorError,
+ url_or_none,
+ urlencode_postdata,
+)
+
+
+class OwnCloudIE(InfoExtractor):
+ _INSTANCES_RE = r'''(?:
+ sciebo\.de|
+ ... | yt_dlp/extractor/owncloud.py | 26 | Python | 0.857 | suggestion | 254 | 51 | 50 | false | [extractor/owncloud] New Extractor for Owncloud | 6,533 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
import urllib.parse
from yt_dlp.extractor.common import InfoExtractor
from yt_dlp.utils import (
determine_ext,
ExtractorError,
url_or_none,
urlencode_postdata,
)
class OwnCloudIE(InfoExtractor):
_INSTANCES_RE = r'''(?:
sciebo\.de|
[^\.]+\.s... | ```suggestion
from .common import InfoExtractor
from ..utils import (
```
convention | import re
import urllib.parse
from .common import InfoExtractor
from ..utils import (
ExtractorError,
determine_ext,
url_or_none,
urlencode_postdata,
)
class OwnCloudIE(InfoExtractor):
_INSTANCES_RE = '|'.join((
r'(?:[^\.]+\.)?sciebo\.de',
r'cloud\.uni-koblenz-landau\.de',
))
... | @@ -0,0 +1,88 @@
+import urllib.parse
+
+from yt_dlp.extractor.common import InfoExtractor
+from yt_dlp.utils import ( | yt_dlp/extractor/owncloud.py | 4 | Python | 0.643 | refactor | 88 | 29 | 29 | false | [extractor/owncloud] New Extractor for Owncloud | 6,533 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | C0D3D3V |
'https://api.bilibili.com/x/player/playurl', video_id,
query={'bvid': video_id, 'cid': cid, 'fnval': 4048},
note='Extracting festival video formats')['data']
thumbnail = traverse_obj(
initial_state, ('sectionEpisodes', lambda _, v: v['bvid'] =... | this shares a lot of common code with the non-festival return dict
you could do something like this instead
```diff
diff --git a/yt_dlp/extractor/bilibili.py b/yt_dlp/extractor/bilibili.py
index 50013c4fe..78f39b098 100644
--- a/yt_dlp/extractor/bilibili.py
+++ b/yt_dlp/extractor/bilibili.py
@@ -357,48 +357,42... | play_info = self._download_json(
'https://api.bilibili.com/x/player/playurl', video_id,
query={'bvid': video_id, 'cid': cid, 'fnval': 4048},
note='Extracting festival video formats')['data']
festival_info = traverse_obj(initial_state, {
... | @@ -316,6 +357,34 @@ def _real_extract(self, url):
cid = traverse_obj(video_data, ('pages', part_id - 1, 'cid')) if part_id else video_data.get('cid')
+ if is_festival:
+ play_info = self._download_json(
+ 'https://api.bilibili.com/x/player/playurl', video_id,
+ ... | yt_dlp/extractor/bilibili.py | 26 | Python | 0.857 | refactor | 4,605 | 51 | 51 | false | [extractor/bilibili] Support festival videos | 6,547 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | qbnu |
for idx in itertools.count(1):
replies = traverse_obj(
self._download_json(
f'https://api.bilibili.com/x/v2/reply?pn={idx}&oid={aid}&type=1&jsonp=jsonp&sort=2&_=1567227301685',
aid, note=f'Extracting comments from page {idx}', fatal=False),
... | ```suggestion
_VALID_URL = r'https?://www\.bilibili\.com/(?:video/|festival/\w+\?(?:[^#]+&)?bvid=)[aAbB][vV](?P<id>[^/?#&]+)'
``` | for idx in itertools.count(1):
replies = traverse_obj(
self._download_json(
f'https://api.bilibili.com/x/v2/reply?pn={idx}&oid={aid}&type=1&jsonp=jsonp&sort=2&_=1567227301685',
aid, note=f'Extracting comments from page {idx}', fatal=False),
... | @@ -133,7 +133,7 @@ def _get_all_children(self, reply):
class BiliBiliIE(BilibiliBaseIE):
- _VALID_URL = r'https?://www\.bilibili\.com/video/[aAbB][vV](?P<id>[^/?#&]+)'
+ _VALID_URL = r'https?://www\.bilibili\.com/(?:video/|festival/\w+\?(?:.*?&)?bvid=)[aAbB][vV](?P<id>[^/?#&]+)' | yt_dlp/extractor/bilibili.py | 26 | Python | 0.714 | suggestion | 135 | 51 | 51 | false | [extractor/bilibili] Support festival videos | 6,547 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | qbnu |
if is_anthology:
part_id = part_id or 1
title += f' p{part_id:02d} {traverse_obj(page_list_json, (part_id - 1, "part")) or ""}'
aid = video_data.get('aid')
old_video_id = format_field(aid, None, f'%s_part{part_id or 1}')
cid = traverse_obj(video_data, ('pages',... | just noticed duration was duplicated
```suggestion
festival_info = traverse_obj(initial_state, {
'uploader': ('videoInfo', 'upName'),
'uploader_id': ('videoInfo', 'upMid', {str_or_none}),
'like_count': ('videoStatus', 'like', {int_or_none}),
... |
if is_anthology:
part_id = part_id or 1
title += f' p{part_id:02d} {traverse_obj(page_list_json, (part_id - 1, "part")) or ""}'
aid = video_data.get('aid')
old_video_id = format_field(aid, None, f'%s_part{part_id or 1}')
cid = traverse_obj(video_data, ('pages',... | @@ -316,20 +357,42 @@ def _real_extract(self, url):
cid = traverse_obj(video_data, ('pages', part_id - 1, 'cid')) if part_id else video_data.get('cid')
+ festival_info = {}
+ if is_festival:
+ play_info = self._download_json(
+ 'https://api.bilibili.com/x/player/play... | yt_dlp/extractor/bilibili.py | 26 | Python | 0.786 | refactor | 438 | 51 | 51 | false | [extractor/bilibili] Support festival videos | 6,547 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | qbnu |
'expected_warnings': ['Ignoring subtitle tracks'],
}, {
'url': 'https://www.dr.dk/lyd/p4kbh/regionale-nyheder-kh4/p4-nyheder-2019-06-26-17-30-9',
'only_matching': True,
}, {
'url': 'https://www.dr.dk/drtv/se/bonderoeven_71769',
'info_dict': {
'id': '0095193001... | should we be using `_extract_m3u8_formats_and_subtitles` instead of `_extract_m3u8_formats`? | 'url': 'https://www.dr.dk/lyd/p4kbh/regionale-nyheder-kh4/p4-nyheder-2019-06-26-17-30-9',
'only_matching': True,
}, {
'url': 'https://www.dr.dk/drtv/se/bonderoeven_71769',
'info_dict': {
'id': '00951930010',
'ext': 'mp4',
'title': 'Bonderøven 2019 ... | @@ -101,18 +102,21 @@ class DRTVIE(InfoExtractor):
'ext': 'mp4',
'title': 'Bonderøven 2019 (1:8)',
'description': 'md5:b6dcfe9b6f0bea6703e9a0092739a5bd',
- 'timestamp': 1603188600,
- 'upload_date': '20201020',
+ 'timestamp': 1654856100,
+ ... | yt_dlp/extractor/drtv.py | 26 | Python | 0.429 | refactor | 92 | 51 | 51 | false | [extractor/drtv] Fix video id parsing on radio pages | 6,552 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | viktor-enzell |
'url': 'https://www.dr.dk/drtv/episode/bonderoeven_71769',
'only_matching': True,
}, {
'url': 'https://dr-massive.com/drtv/se/bonderoeven_71769',
'only_matching': True,
}, {
'url': 'https://www.dr.dk/drtv/program/jagten_220924',
'only_matching': True,
}, {
... | add a new test instead of overwriting the old one | 'url': 'https://dr-massive.com/drtv/se/bonderoeven_71769',
'only_matching': True,
}, {
'url': 'https://www.dr.dk/drtv/program/jagten_220924',
'only_matching': True,
}, {
'url': 'https://www.dr.dk/lyd/p4aarhus/regionale-nyheder-ar4/regionale-nyheder-2022-05-05-12-30-3',
... | @@ -123,22 +127,19 @@ class DRTVIE(InfoExtractor):
'url': 'https://www.dr.dk/drtv/program/jagten_220924',
'only_matching': True,
}, {
- 'url': 'https://www.dr.dk/lyd/p4aarhus/regionale-nyheder-ar4/regionale-nyheder-2022-05-05-12-30-3',
+ 'url': 'https://www.dr.dk/lyd/p4kbh/regionale... | yt_dlp/extractor/drtv.py | 26 | Python | 0.143 | suggestion | 49 | 51 | 51 | false | [extractor/drtv] Fix video id parsing on radio pages | 6,552 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | viktor-enzell |
if '>Programmet er ikke længere tilgængeligt' in webpage:
raise ExtractorError(
'Video %s is not available' % raw_video_id, expected=True)
video_id = self._search_regex(
(r'data-(?:material-identifier|episode-slug)="([^"]+)"',
r'data-resource="[^>"]... | can radio pages also have a `dr.dk/radio` url?
maybe we should do it like this:
```diff
_VALID_URL = r'''(?x)
https?://
(?:
- (?:www\.)?dr\.dk/(?:tv/se|nyheder|(?:radio|lyd)(?:/ondemand)?)/(?:[^/]+/)*|
+ ... | 'timestamp': 1678786200,
'duration': 120.043,
'season_id': 'urn:dr:mu:bundle:63a4f7c87140143504b6710f',
'series': 'P4 København regionale nyheder',
'upload_date': '20230314',
'release_year': 0,
'description': 'Hør seneste regionale nyhe... | @@ -170,15 +171,25 @@ def _real_extract(self, url):
programcard_url = '%s/%s' % (_PROGRAMCARD_BASE, video_id)
else:
programcard_url = _PROGRAMCARD_BASE
- page = self._parse_json(
- self._search_regex(
- r'data\s*=\s*({.+?})\s*(?:;|</script)... | yt_dlp/extractor/drtv.py | 26 | Python | 0.857 | refactor | 834 | 51 | 51 | false | [extractor/drtv] Fix video id parsing on radio pages | 6,552 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | viktor-enzell |
r'data-resource="[^>"]+mu/programcard/expanded/([^"]+)"'),
webpage, 'video id', default=None)
if not video_id:
video_id = self._search_regex(
r'(urn(?:%3A|:)dr(?:%3A|:)mu(?:%3A|:)programcard(?:%3A|:)[\da-f]+)',
webpage, 'urn', default=None)
... | ```suggestion
video_id = self._search_nextjs_data(
webpage, raw_video_id)['props']['pageProps']['episode']['productionNumber']
``` | 'season': 'Regionale nyheder',
'title': 'Regionale nyheder',
},
}]
def _real_extract(self, url):
raw_video_id, is_radio_url = self._match_valid_url(url).group('id', 'radio')
webpage = self._download_webpage(url, raw_video_id)
if '>Programmet er ikke læn... | @@ -170,15 +171,25 @@ def _real_extract(self, url):
programcard_url = '%s/%s' % (_PROGRAMCARD_BASE, video_id)
else:
programcard_url = _PROGRAMCARD_BASE
- page = self._parse_json(
- self._search_regex(
- r'data\s*=\s*({.+?})\s*(?:;|</script)... | yt_dlp/extractor/drtv.py | 26 | Python | 0.714 | suggestion | 169 | 51 | 51 | false | [extractor/drtv] Fix video id parsing on radio pages | 6,552 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | viktor-enzell |
_PROGRAMCARD_BASE = 'https://www.dr.dk/mu-online/api/1.4/programcard'
query = {'expanded': 'true'}
if video_id:
programcard_url = '%s/%s' % (_PROGRAMCARD_BASE, video_id)
else:
programcard_url = _PROGRAMCARD_BASE
is_radio_url = 'dr.dk/lyd' in url
... | I know this is just old code / not yours, but it could be modernized/simplified with `_search_json` and `traverse_obj`
```suggestion
else:
json_data = self._search_json(
r'window\.__data\s*=', webpage, 'data', raw_video_id)
video_id = traverse_obj(jso... | if '>Programmet er ikke længere tilgængeligt' in webpage:
raise ExtractorError(
'Video %s is not available' % raw_video_id, expected=True)
video_id = self._search_regex(
(r'data-(?:material-identifier|episode-slug)="([^"]+)"',
r'data-resource="[^>"]+... | @@ -170,15 +171,25 @@ def _real_extract(self, url):
programcard_url = '%s/%s' % (_PROGRAMCARD_BASE, video_id)
else:
programcard_url = _PROGRAMCARD_BASE
- page = self._parse_json(
- self._search_regex(
- r'data\s*=\s*({.+?})\s*(?:;|</script)... | yt_dlp/extractor/drtv.py | 26 | Python | 1 | performance | 594 | 51 | 51 | false | [extractor/drtv] Fix video id parsing on radio pages | 6,552 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | viktor-enzell |
_PROGRAMCARD_BASE = 'https://www.dr.dk/mu-online/api/1.4/programcard'
query = {'expanded': 'true'}
if video_id:
programcard_url = '%s/%s' % (_PROGRAMCARD_BASE, video_id)
else:
programcard_url = _PROGRAMCARD_BASE
page = self._parse_json(
... | It's always string?
```suggestion
if is_radio_url == 'radio':
``` | webpage = self._download_webpage(url, raw_video_id)
if '>Programmet er ikke længere tilgængeligt' in webpage:
raise ExtractorError(
'Video %s is not available' % raw_video_id, expected=True)
video_id = self._search_regex(
(r'data-(?:material-identifier|e... | @@ -170,15 +187,17 @@ def _real_extract(self, url):
programcard_url = '%s/%s' % (_PROGRAMCARD_BASE, video_id)
else:
programcard_url = _PROGRAMCARD_BASE
- page = self._parse_json(
- self._search_regex(
- r'data\s*=\s*({.+?})\s*(?:;|</script)... | yt_dlp/extractor/drtv.py | 26 | Python | 0.571 | suggestion | 80 | 51 | 51 | false | [extractor/drtv] Fix video id parsing on radio pages | 6,552 | yt-dlp/yt-dlp | 132,642 | Python | Lesmiscore | viktor-enzell |
}, {
'url': 'https://iwara.tv/video/1ywe1sbkqwumpdxz5/',
'md5': '20691ce1473ec2766c0788e14c60ce66',
'info_dict': {
'id': '1ywe1sbkqwumpdxz5',
'ext': 'mp4',
'age_limit': 18,
'title': 'Aponia 阿波尼亚SEX Party Tonight 手动脱衣 大奶 裸腿',
'descr... | What if URL ends in `/`?
```suggestion
paths = up.path.rstrip('/').split('/')
``` | },
}, {
'url': 'https://iwara.tv/video/1ywe1sbkqwumpdxz5/',
'md5': '20691ce1473ec2766c0788e14c60ce66',
'info_dict': {
'id': '1ywe1sbkqwumpdxz5',
'ext': 'mp4',
'age_limit': 18,
'title': 'Aponia 阿波尼亚SEX Party Tonight 手动脱衣 大奶 裸腿',
... | @@ -1,239 +1,190 @@
-import itertools
-import re
+import functools
import urllib.parse
+import hashlib
from .common import InfoExtractor
from ..utils import (
- int_or_none,
+ OnDemandPagedList,
mimetype2ext,
- remove_end,
- strip_or_none,
- unified_strdate,
- url_or_none,
- urljoin,
+ ... | yt_dlp/extractor/iwara.py | 26 | Python | 0.571 | question | 92 | 51 | 51 | false | [extractor/iwara] Overhaul extractors | 6,557 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Lesmiscore |
'description': 'md5:0c4c310f2e0592d68b9f771d348329ca',
'uploader': '龙也zZZ',
'uploader_id': 'user792540',
'tags': [
'uncategorized'
],
'like_count': 1809,
'view_count': 25156,
'comment_count': 1,
'... | ```suggestion
'url': ('src', ('view', 'download'), {self._proto_relative_url}),
```
should be enough, no? | 'title': 'Aponia 阿波尼亚SEX Party Tonight 手动脱衣 大奶 裸腿',
'description': 'md5:0c4c310f2e0592d68b9f771d348329ca',
'uploader': '龙也zZZ',
'uploader_id': 'user792540',
'tags': [
'uncategorized'
],
'like_count': 1809,
'... | @@ -1,239 +1,190 @@
-import itertools
-import re
+import functools
import urllib.parse
+import hashlib
from .common import InfoExtractor
from ..utils import (
- int_or_none,
+ OnDemandPagedList,
mimetype2ext,
- remove_end,
- strip_or_none,
- unified_strdate,
- url_or_none,
- urljoin,
+ ... | yt_dlp/extractor/iwara.py | 26 | Python | 0.786 | question | 124 | 51 | 51 | false | [extractor/iwara] Overhaul extractors | 6,557 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Lesmiscore |
'uploader_id': 'user792540',
'tags': [
'uncategorized'
],
'like_count': 1809,
'view_count': 25156,
'comment_count': 1,
'timestamp': 1678732213,
'modified_timestamp': 1679110271,
},
}]
def _ex... | Pls explain why this is `preference` and not just `quality`. Remember, preference takes priority over any `-S` user gives
```suggestion
'preference': ('name', {lambda x: int_or_none(x) or 1e4}),
``` | 'uploader': '龙也zZZ',
'uploader_id': 'user792540',
'tags': [
'uncategorized'
],
'like_count': 1809,
'view_count': 25156,
'comment_count': 1,
'timestamp': 1678732213,
'modified_timestamp': 167911027... | @@ -1,239 +1,190 @@
-import itertools
-import re
+import functools
import urllib.parse
+import hashlib
from .common import InfoExtractor
from ..utils import (
- int_or_none,
+ OnDemandPagedList,
mimetype2ext,
- remove_end,
- strip_or_none,
- unified_strdate,
- url_or_none,
- urljoin,
+ ... | yt_dlp/extractor/iwara.py | 26 | Python | 0.857 | suggestion | 217 | 51 | 51 | false | [extractor/iwara] Overhaul extractors | 6,557 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Lesmiscore |
'tags': [
'uncategorized'
],
'like_count': 1809,
'view_count': 25156,
'comment_count': 1,
'timestamp': 1678732213,
'modified_timestamp': 1679110271,
},
}]
def _extract_formats(self, video_id, fileurl):
... | ```suggestion
'height': ('name', {int_or_none}),
``` | 'uploader_id': 'user792540',
'tags': [
'uncategorized'
],
'like_count': 1809,
'view_count': 25156,
'comment_count': 1,
'timestamp': 1678732213,
'modified_timestamp': 1679110271,
},
}]
def _ex... | @@ -1,239 +1,190 @@
-import itertools
-import re
+import functools
import urllib.parse
+import hashlib
from .common import InfoExtractor
from ..utils import (
- int_or_none,
+ OnDemandPagedList,
mimetype2ext,
- remove_end,
- strip_or_none,
- unified_strdate,
- url_or_none,
- urljoin,
+ ... | yt_dlp/extractor/iwara.py | 26 | Python | 0.571 | suggestion | 70 | 51 | 51 | false | [extractor/iwara] Overhaul extractors | 6,557 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Lesmiscore |
'height': ('name', {lambda x: int(x)}),
}, get_all=False)
def _real_extract(self, url):
video_id = self._match_id(url)
video_data = self._download_json(f'http://api.iwara.tv/video/{video_id}', video_id)
return {
'id': video_id,
'age_limit... | ```suggestion
'thumbnail': ('file', 'id', {str}, {
lambda x: f'https://files.iwara.tv/image/thumbnail/{x}/thumbnail-00.jpg'}),
}),
'formats': list(self._extract_formats(video_id, video_data.get('fileUrl'))),
``` | 'quality': ('name', {lambda x: int_or_none(x) or 1e4}),
'height': ('name', {int_or_none}),
}, get_all=False)
def _real_extract(self, url):
video_id = self._match_id(url)
video_data = self._download_json(f'http://api.iwara.tv/video/{video_id}', video_id)
... | @@ -1,239 +1,190 @@
-import itertools
-import re
+import functools
import urllib.parse
+import hashlib
from .common import InfoExtractor
from ..utils import (
- int_or_none,
+ OnDemandPagedList,
mimetype2ext,
- remove_end,
- strip_or_none,
- unified_strdate,
- url_or_none,
- urljoin,
+ ... | yt_dlp/extractor/iwara.py | 26 | Python | 0.857 | refactor | 276 | 51 | 51 | false | [extractor/iwara] Overhaul extractors | 6,557 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Lesmiscore |
'url': 'https://iwara.tv/profile/theblackbirdcalls/videos',
'info_dict': {
'id': 'theblackbirdcalls',
},
'playlist_mincount': 723,
}, {
'url': 'https://iwara.tv/profile/user792540',
'only_matching': True,
}, {
'url': 'https://iwara.tv/profile/t... | ```suggestion
for x in traverse_obj(videos, ('results', ..., 'id')):
yield self.url_result(f'https://iwara.tv/video/{x}')
```
`yield from ... for ...` is weird | 'url': 'https://iwara.tv/profile/theblackbirdcalls/videos',
'info_dict': {
'id': 'theblackbirdcalls',
},
'playlist_mincount': 723,
}, {
'url': 'https://iwara.tv/profile/user792540',
'only_matching': True,
}, {
'url': 'https://iwara.tv/profile/t... | @@ -1,239 +1,190 @@
-import itertools
-import re
+import functools
import urllib.parse
+import hashlib
from .common import InfoExtractor
from ..utils import (
- int_or_none,
+ OnDemandPagedList,
mimetype2ext,
- remove_end,
- strip_or_none,
- unified_strdate,
- url_or_none,
- urljoin,
+ ... | yt_dlp/extractor/iwara.py | 26 | Python | 0.714 | suggestion | 183 | 51 | 51 | false | [extractor/iwara] Overhaul extractors | 6,557 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Lesmiscore |
note=f'Downloading page {page}',
query={
'page': page,
'sort': 'date',
'user': user_id,
'limit': self._PER_PAGE,
})
yield from (
self.url_result(f'https://iwara.tv/video/{x}')
for x in tra... | I agree, but it may be useful to have a `UUID_RE` in utils | note=f'Downloading page {page}',
query={
'page': page,
'sort': 'date',
'user': user_id,
'limit': self._PER_PAGE,
})
for x in traverse_obj(videos, ('results', ..., 'id')):
yield self.url_result(f'https... | @@ -1,239 +1,190 @@
-import itertools
-import re
+import functools
import urllib.parse
+import hashlib
from .common import InfoExtractor
from ..utils import (
- int_or_none,
+ OnDemandPagedList,
mimetype2ext,
- remove_end,
- strip_or_none,
- unified_strdate,
- url_or_none,
- urljoin,
+ ... | yt_dlp/extractor/iwara.py | 26 | Python | 0.429 | suggestion | 58 | 51 | 51 | false | [extractor/iwara] Overhaul extractors | 6,557 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Lesmiscore |
class IwaraPlaylistIE(InfoExtractor):
# the ID is an UUID but I don't think it's necessary to write concrete regex
_VALID_URL = r'https?://(?:www\.)?iwara\.tv/playlist/(?P<id>[0-9a-f-]+)'
IE_NAME = 'iwara:playlist'
_PER_PAGE = 32
_TESTS = [{
'url': 'https://iwara.tv/playlist/458e5486-36a4-... | ```suggestion
videos = self._download_json(
'https://api.iwara.tv/videos', playlist_id, f'Downloading page {page}',
query={'page': page, 'limit': self._PER_PAGE}) if page else first_page
for x in traverse_obj(videos, ('results', ..., 'id')):
yield self.url_result... | class IwaraPlaylistIE(InfoExtractor):
# the ID is an UUID but I don't think it's necessary to write concrete regex
_VALID_URL = r'https?://(?:www\.)?iwara\.tv/playlist/(?P<id>[0-9a-f-]+)'
IE_NAME = 'iwara:playlist'
_PER_PAGE = 32
_TESTS = [{
'url': 'https://iwara.tv/playlist/458e5486-36a4-4... | @@ -1,239 +1,190 @@
-import itertools
-import re
+import functools
import urllib.parse
+import hashlib
from .common import InfoExtractor
from ..utils import (
- int_or_none,
+ OnDemandPagedList,
mimetype2ext,
- remove_end,
- strip_or_none,
- unified_strdate,
- url_or_none,
- urljoin,
+ ... | yt_dlp/extractor/iwara.py | 26 | Python | 0.786 | suggestion | 356 | 39 | 33 | false | [extractor/iwara] Overhaul extractors | 6,557 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Lesmiscore |
self._downloader.write_debug(f'Identified {num} {name}{format_field(note, None, "; %s")}')
def _extra_manifest_info(self, info, manifest_url, is_info_dict=True):
extra_info = {}
if self._configuration_arg('fragment_query'):
query_string = urllib.parse.urlparse(manifest_url).que... | ```suggestion
for fmt in self._downloader._get_formats(info):
fmt['url'] = update_url_query(fmt['url'], query)
``` | self._downloader.write_debug(f'Identified {num} {name}{format_field(note, None, "; %s")}')
def _extra_manifest_info(self, info, manifest_url):
if self._configuration_arg('fragment_query'):
query_string = urllib.parse.urlparse(manifest_url).query
if query_string:
... | @@ -2184,12 +2186,30 @@ def report_detected(self, name, num=1, note=None):
self._downloader.write_debug(f'Identified {num} {name}{format_field(note, None, "; %s")}')
- def _fragment_query(self, url):
+ def _extra_manifest_info(self, info, manifest_url, is_info_dict=True):
+ extra_info = {}
+
... | yt_dlp/extractor/generic.py | 26 | Python | 0.714 | suggestion | 145 | 51 | 51 | false | [extractor/generic] Add extractor-args `hls_key` and `variant_query` | 6,567 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | bashonly |
'age_limit': 18,
},
},
]
def report_following_redirect(self, new_url):
"""Report information extraction."""
self._downloader.to_screen('[redirect] Following redirect to %s' % new_url)
def report_detected(self, name, num=1, note=None):
if num > 1:... | ```suggestion
info['extra_param_to_segment_url'] = query_string
```
Why have an `extra_info`? | 'age_limit': 18,
},
},
]
def report_following_redirect(self, new_url):
"""Report information extraction."""
self._downloader.to_screen('[redirect] Following redirect to %s' % new_url)
def report_detected(self, name, num=1, note=None):
if num > 1:... | @@ -2184,12 +2186,30 @@ def report_detected(self, name, num=1, note=None):
self._downloader.write_debug(f'Identified {num} {name}{format_field(note, None, "; %s")}')
- def _fragment_query(self, url):
+ def _extra_manifest_info(self, info, manifest_url, is_info_dict=True):
+ extra_info = {}
+
... | yt_dlp/extractor/generic.py | 26 | Python | 0.714 | question | 112 | 51 | 51 | false | [extractor/generic] Add extractor-args `hls_key` and `variant_query` | 6,567 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | bashonly |
def report_detected(self, name, num=1, note=None):
if num > 1:
name += 's'
elif not num:
return
else:
num = 'a'
self._downloader.write_debug(f'Identified {num} {name}{format_field(note, None, "; %s")}')
def _extra_manifest_info(self, info, ma... | ```suggestion
is_hex = lambda _, v: re.fullmatch(r'(?i)(0x)?[\da-f]+', v)
info['hls_aes'] = traverse_obj(self._configuration_arg('hls_key'), {
'uri': (0, {url_or_none}), 'key': (0, is_hex), 'iv': (1, is_hex),
})
``` | def report_detected(self, name, num=1, note=None):
if num > 1:
name += 's'
elif not num:
return
else:
num = 'a'
self._downloader.write_debug(f'Identified {num} {name}{format_field(note, None, "; %s")}')
def _extra_manifest_info(self, info, ma... | @@ -2184,12 +2186,30 @@ def report_detected(self, name, num=1, note=None):
self._downloader.write_debug(f'Identified {num} {name}{format_field(note, None, "; %s")}')
- def _fragment_query(self, url):
+ def _extra_manifest_info(self, info, manifest_url, is_info_dict=True):
+ extra_info = {}
+
... | yt_dlp/extractor/generic.py | 26 | Python | 0.786 | suggestion | 256 | 51 | 51 | false | [extractor/generic] Add extractor-args `hls_key` and `variant_query` | 6,567 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | bashonly |
'season': 'Season 2',
'thumbnail': r're:^https://.+\.jpg',
'age_limit': 14,
},
'params': {'skip_download': 'm3u8'},
}, {
'url': 'https://www.bravotv.com/below-deck/season-3/ep-14-reunion-part-1',
'only_matching': True,
}]
def _real_extract... | ```suggestion
metadata = self._parse_json(tve.get('data-normalized-video'), display_id, fatal=False)
``` | 'duration': 68.235,
'season': 'Season 2',
'thumbnail': r're:^https://.+\.jpg',
'age_limit': 14,
},
'params': {'skip_download': 'm3u8'},
}, {
'url': 'https://www.bravotv.com/below-deck/season-3/ep-14-reunion-part-1',
'only_matching': Tru... | @@ -1,117 +1,184 @@
-import re
-
from .adobepass import AdobePassIE
from ..utils import (
- smuggle_url,
- update_url_query,
- int_or_none,
+ extract_attributes,
float_or_none,
- try_get,
- dict_get,
+ get_element_html_by_class,
+ int_or_none,
+ merge_dicts,
+ parse_age_limit,
+ ... | yt_dlp/extractor/bravotv.py | 26 | Python | 0.714 | suggestion | 118 | 51 | 51 | false | [extractor/bravotv] Fix extractor | 6,568 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | bashonly |
import re
from .common import InfoExtractor, ExtractorError
from ..utils import (
int_or_none,
float_or_none,
js_to_json,
traverse_obj,
urljoin,
)
class RTFVPlayBaseIE(InfoExtractor):
_BASE_VALID_URL = r'https?://(?:www\.)?rtvcplay\.co'
def _extract_player_config(self, webpage, video_id)... | `RTFV` should be `RTVC`? typo? | import re
from .common import InfoExtractor, ExtractorError
from ..utils import (
clean_html,
determine_ext,
int_or_none,
float_or_none,
js_to_json,
mimetype2ext,
traverse_obj,
urljoin,
url_or_none,
)
class RTVCPlayBaseIE(InfoExtractor):
_BASE_VALID_URL = r'https?://(?:www\.)?... | @@ -0,0 +1,286 @@
+import re
+
+from .common import InfoExtractor, ExtractorError
+from ..utils import (
+ int_or_none,
+ float_or_none,
+ js_to_json,
+ traverse_obj,
+ urljoin,
+)
+
+
+class RTFVPlayBaseIE(InfoExtractor): | yt_dlp/extractor/rtvcplay.py | 13 | Python | 0.286 | question | 30 | 38 | 38 | false | [extractors/rtvc] Add extractors | 6,578 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | elyse0 |
import re
from .common import InfoExtractor, ExtractorError
from ..utils import (
int_or_none,
float_or_none,
js_to_json,
traverse_obj,
urljoin,
)
class RTFVPlayBaseIE(InfoExtractor):
_BASE_VALID_URL = r'https?://(?:www\.)?rtvcplay\.co'
def _extract_player_config(self, webpage, video_id)... | hm, so the `url` values look like this before `re.sub` and `js_to_json`:
```
url: "https://streaming.rtvc.gov.co/RTVCPlay-vod/smil:"+"497115" +".smil/playlist.m3u8"
```
I wonder if an improvement could be made to `js_to_json` to handle this | import re
from .common import InfoExtractor, ExtractorError
from ..utils import (
clean_html,
determine_ext,
int_or_none,
float_or_none,
js_to_json,
mimetype2ext,
traverse_obj,
urljoin,
url_or_none,
)
class RTVCPlayBaseIE(InfoExtractor):
_BASE_VALID_URL = r'https?://(?:www\.)?... | @@ -0,0 +1,286 @@
+import re
+
+from .common import InfoExtractor, ExtractorError
+from ..utils import (
+ int_or_none,
+ float_or_none,
+ js_to_json,
+ traverse_obj,
+ urljoin,
+)
+
+
+class RTFVPlayBaseIE(InfoExtractor):
+ _BASE_VALID_URL = r'https?://(?:www\.)?rtvcplay\.co'
+
+ def _extract_play... | yt_dlp/extractor/rtvcplay.py | 22 | Python | 1 | suggestion | 244 | 47 | 47 | false | [extractors/rtvc] Add extractors | 6,578 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | elyse0 |
traverse_obj,
urljoin,
)
class RTFVPlayBaseIE(InfoExtractor):
_BASE_VALID_URL = r'https?://(?:www\.)?rtvcplay\.co'
def _extract_player_config(self, webpage, video_id):
return self._search_json(
r'<script\b[^>]*>[^<]*(?:var|let|const)\s+config\s*=', re.sub(r'"\s*\+\s*"', '', webpag... | there's also this way:
```suggestion
def _extract_formats_and_subtitles_player_config(self, player_config, video_id):
formats, subtitles = [], {}
for source in traverse_obj(player_config, ('sources', ..., lambda _, v: url_or_none(v['url']))):
ext = mimetype2ext(source.get('mimetype'... | float_or_none,
js_to_json,
mimetype2ext,
traverse_obj,
urljoin,
url_or_none,
)
class RTVCPlayBaseIE(InfoExtractor):
_BASE_VALID_URL = r'https?://(?:www\.)?rtvcplay\.co'
def _extract_player_config(self, webpage, video_id):
return self._search_json(
r'<script\b[^>]*>... | @@ -0,0 +1,286 @@
+import re
+
+from .common import InfoExtractor, ExtractorError
+from ..utils import (
+ int_or_none,
+ float_or_none,
+ js_to_json,
+ traverse_obj,
+ urljoin,
+)
+
+
+class RTFVPlayBaseIE(InfoExtractor):
+ _BASE_VALID_URL = r'https?://(?:www\.)?rtvcplay\.co'
+
+ def _extract_play... | yt_dlp/extractor/rtvcplay.py | 26 | Python | 1 | refactor | 784 | 51 | 51 | false | [extractors/rtvc] Add extractors | 6,578 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | elyse0 |
}, {
'url': 'https://www.rtvcplay.co/series-al-oido/relato-de-un-naufrago-una-travesia-del-periodismo-a-la-literatura',
'info_dict': {
'id': 'relato-de-un-naufrago-una-travesia-del-periodismo-a-la-literatura',
'title': 'Relato de un náufrago: una travesía del periodismo a la ... | ```suggestion
r'window\.__RTVCPLAY_STATE__\s*=', webpage, 'hydration', video_id, transform_source=js_to_json)
```
.
or, since it looks like we don't traverse outside of `currentContent`, we could do this:
```suggestion
r'window\.__RTVCPLAY_STATE__\s*=', webpage, 'hydration', video_id, tran... | 'title': 'Profe en tu casa',
'description': 'md5:47dbe20e263194413b1db2a2805a4f2e',
'thumbnail': r're:^https?://.*\.(?:jpg|png)',
},
'playlist_mincount': 537,
}, {
'url': 'https://www.rtvcplay.co/series-al-oido/relato-de-un-naufrago-una-travesia-del-period... | @@ -0,0 +1,286 @@
+import re
+
+from .common import InfoExtractor, ExtractorError
+from ..utils import (
+ int_or_none,
+ float_or_none,
+ js_to_json,
+ traverse_obj,
+ urljoin,
+)
+
+
+class RTFVPlayBaseIE(InfoExtractor):
+ _BASE_VALID_URL = r'https?://(?:www\.)?rtvcplay\.co'
+
+ def _extract_play... | yt_dlp/extractor/rtvcplay.py | 26 | Python | 0.857 | suggestion | 472 | 51 | 51 | false | [extractors/rtvc] Add extractors | 6,578 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | elyse0 |
'title': 'Relato de un náufrago: una travesía del periodismo a la literatura',
'description': 'md5:6da28fdca4a5a568ea47ef65ef775603',
'thumbnail': r're:^https?://.*\.(?:jpg|png)',
},
'playlist_mincount': 5,
}, {
'url': 'https://www.rtvcplay.co/series-al-oi... | should this be fatal if there's an `if not hls_url` statement below? | 'playlist_mincount': 537,
}, {
'url': 'https://www.rtvcplay.co/series-al-oido/relato-de-un-naufrago-una-travesia-del-periodismo-a-la-literatura',
'info_dict': {
'id': 'relato-de-un-naufrago-una-travesia-del-periodismo-a-la-literatura',
'title': 'Relato de un náufrago:... | @@ -0,0 +1,286 @@
+import re
+
+from .common import InfoExtractor, ExtractorError
+from ..utils import (
+ int_or_none,
+ float_or_none,
+ js_to_json,
+ traverse_obj,
+ urljoin,
+)
+
+
+class RTFVPlayBaseIE(InfoExtractor):
+ _BASE_VALID_URL = r'https?://(?:www\.)?rtvcplay\.co'
+
+ def _extract_play... | yt_dlp/extractor/rtvcplay.py | 26 | Python | 0.429 | question | 68 | 51 | 51 | false | [extractors/rtvc] Add extractors | 6,578 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | elyse0 |
},
'playlist_mincount': 20,
}]
def _real_extract(self, url):
video_id, category = self._match_valid_url(url).group('id', 'category')
webpage = self._download_webpage(url, video_id)
hydration = self._search_json(
r'window.__RTVCPLAY_STATE__\s*=', webpage, 'hy... | ```suggestion
metadata = traverse_obj(hydration, ('content', 'currentContent', {
'title': 'title',
'description': 'description',
'thumbnail': ((('channel', 'image', 'logo'), ('resource', 'image', 'cover_desktop')), 'path'),
}), get_all=False)
``` | 'info_dict': {
'id': 'diez-versiones',
'title': 'Diez versiones',
'description': 'md5:997471ed971cb3fd8e41969457675306',
'thumbnail': r're:^https?://.*\.(?:jpg|png)',
},
'playlist_mincount': 20,
}]
def _real_extract(self, url):
vid... | @@ -0,0 +1,286 @@
+import re
+
+from .common import InfoExtractor, ExtractorError
+from ..utils import (
+ int_or_none,
+ float_or_none,
+ js_to_json,
+ traverse_obj,
+ urljoin,
+)
+
+
+class RTFVPlayBaseIE(InfoExtractor):
+ _BASE_VALID_URL = r'https?://(?:www\.)?rtvcplay\.co'
+
+ def _extract_play... | yt_dlp/extractor/rtvcplay.py | 26 | Python | 0.786 | suggestion | 304 | 51 | 51 | false | [extractors/rtvc] Add extractors | 6,578 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | elyse0 |
if asset_id:
hls_url = hydration['content']['currentContent']['base_url_hls'].replace('[node:field_asset_id]', asset_id)
else:
hls_url = traverse_obj(hydration, ('content', 'currentContent', 'channel', 'hls'))
metadata = {
'thumbnail': traverse_obj(
... | `url_transparent=True`, right? or else the entry metadata being passed is only for --flat-playlist?
Also, the test URL `https://www.rtvcplay.co/series-al-oido/diez-versiones` has its playlist result handed off to the generic extractor because the URLs are direct mp3 links. Should we be returning info_dict entries in... |
hydration = self._search_json(
r'window\.__RTVCPLAY_STATE__\s*=', webpage, 'hydration',
video_id, transform_source=js_to_json)['content']['currentContent']
asset_id = traverse_obj(hydration, ('video', 'assetid'))
if asset_id:
hls_url = hydration['base_url_hl... | @@ -0,0 +1,286 @@
+import re
+
+from .common import InfoExtractor, ExtractorError
+from ..utils import (
+ int_or_none,
+ float_or_none,
+ js_to_json,
+ traverse_obj,
+ urljoin,
+)
+
+
+class RTFVPlayBaseIE(InfoExtractor):
+ _BASE_VALID_URL = r'https?://(?:www\.)?rtvcplay\.co'
+
+ def _extract_play... | yt_dlp/extractor/rtvcplay.py | 26 | Python | 0.643 | refactor | 346 | 51 | 51 | false | [extractors/rtvc] Add extractors | 6,578 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | elyse0 |
metadata = {
'thumbnail': traverse_obj(
hydration, ('content', 'currentContent', 'channel', 'image', 'logo', 'path'),
('content', 'currentContent', 'resource', 'image', 'cover_desktop', 'path')),
**traverse_obj(hydration, ('content', 'currentContent', {
... | I was getting some html tags during testing and warnings about non-numeric season number fields
```suggestion
'description': ('description', {clean_html}),
'episode_number': ('chapter_number', {int_or_none}),
'season_number': ('season', {int_or_none}),
``... |
asset_id = traverse_obj(hydration, ('video', 'assetid'))
if asset_id:
hls_url = hydration['base_url_hls'].replace('[node:field_asset_id]', asset_id)
else:
hls_url = traverse_obj(hydration, ('channel', 'hls'))
metadata = traverse_obj(hydration, {
'tit... | @@ -0,0 +1,286 @@
+import re
+
+from .common import InfoExtractor, ExtractorError
+from ..utils import (
+ int_or_none,
+ float_or_none,
+ js_to_json,
+ traverse_obj,
+ urljoin,
+)
+
+
+class RTFVPlayBaseIE(InfoExtractor):
+ _BASE_VALID_URL = r'https?://(?:www\.)?rtvcplay\.co'
+
+ def _extract_play... | yt_dlp/extractor/rtvcplay.py | 26 | Python | 0.786 | suggestion | 321 | 51 | 51 | false | [extractors/rtvc] Add extractors | 6,578 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | elyse0 |
if not seasons:
podcast_episodes = traverse_obj(hydration, ('content', 'currentContent', 'audios'))
if not podcast_episodes:
raise ExtractorError('Could not find asset_id nor program playlist nor podcast episodes')
return self.playlist_res... | intermediate dict is not necessary
```suggestion
entries = []
for season in seasons:
for episode in traverse_obj(season, ('contents', ...)):
entries.append(self.url_result(
urljoin(url, episode['slug']), url_transparent=True,
... | hydration, ('widgets', lambda _, y: y['type'] == 'seasonList', 'contents'),
get_all=False)
if not seasons:
podcast_episodes = hydration.get('audios')
if not podcast_episodes:
raise ExtractorError('Could not find asset_id nor... | @@ -0,0 +1,286 @@
+import re
+
+from .common import InfoExtractor, ExtractorError
+from ..utils import (
+ int_or_none,
+ float_or_none,
+ js_to_json,
+ traverse_obj,
+ urljoin,
+)
+
+
+class RTFVPlayBaseIE(InfoExtractor):
+ _BASE_VALID_URL = r'https?://(?:www\.)?rtvcplay\.co'
+
+ def _extract_play... | yt_dlp/extractor/rtvcplay.py | 26 | Python | 0.786 | suggestion | 1,526 | 51 | 51 | false | [extractors/rtvc] Add extractors | 6,578 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | elyse0 |
hls_url = hydration['base_url_hls'].replace('[node:field_asset_id]', asset_id)
else:
hls_url = traverse_obj(hydration, ('channel', 'hls'))
metadata = traverse_obj(hydration, {
'title': 'title',
'description': 'description',
'thumbnail': ((('ch... | using transformations like this is more readable imo
```suggestion
'episode_number': ('chapter_number', {float_or_none}, {int_or_none}),
'season_number': ('season', {int_or_none}),
```
and `season_number` needs `int_or_none` | hls_url = hydration['base_url_hls'].replace('[node:field_asset_id]', asset_id)
else:
hls_url = traverse_obj(hydration, ('channel', 'hls'))
metadata = traverse_obj(hydration, {
'title': 'title',
'description': 'description',
'thumbnail': ((('ch... | @@ -0,0 +1,291 @@
+import re
+
+from .common import InfoExtractor, ExtractorError
+from ..utils import (
+ clean_html,
+ determine_ext,
+ int_or_none,
+ float_or_none,
+ js_to_json,
+ mimetype2ext,
+ traverse_obj,
+ urljoin,
+ url_or_none,
+)
+
+
+class RTVCPlayBaseIE(InfoExtractor):
+ _BA... | yt_dlp/extractor/rtvcplay.py | 26 | Python | 0.786 | suggestion | 277 | 51 | 51 | false | [extractors/rtvc] Add extractors | 6,578 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | elyse0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.