before_code stringlengths 14 465k | reviewer_comment stringlengths 16 64.5k | after_code stringlengths 9 467k | diff_context stringlengths 0 97k | file_path stringlengths 5 226 | comment_line int32 0 26 | language stringclasses 37
values | quality_score float32 0.07 1 | comment_type stringclasses 9
values | comment_length int32 16 64.5k | before_lines int32 1 17.2k | after_lines int32 1 12.1k | is_negative bool 2
classes | pr_title stringlengths 1 308 | pr_number int32 1 299k | repo_name stringclasses 533
values | repo_stars int64 321 419k | repo_language stringclasses 27
values | reviewer_username stringlengths 0 39 | author_username stringlengths 2 39 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
},
'playlist': [{
'info_dict': {
'id': 'A6E6D475ECCC6FE5C1257EF90034817F',
'ext': 'mp4',
'title': 'Konferencja prasowa - Stanowisko SLD ws. składu nowego rządu',
'duration': 514,
},
}],
}, {
'url'... | ```suggestion
title = strip_or_none(data.get('title'))
``` | 'live_status': 'was_live',
},
'playlist': [{
'info_dict': {
'id': 'A6E6D475ECCC6FE5C1257EF90034817F',
'ext': 'mp4',
'title': 'Konferencja prasowa - Stanowisko SLD ws. składu nowego rządu',
'duration': 514,
... | @@ -0,0 +1,217 @@
+from .common import InfoExtractor
+from .redge import RedCDNLivxIE
+from ..utils import (
+ clean_html,
+ js_to_json,
+ strip_or_none,
+ traverse_obj,
+ update_url_query,
+)
+
+import datetime
+
+
+def is_dst(date):
+ year = date.year
+ # last sunday of march and october, respect... | yt_dlp/extractor/sejmpl.py | 26 | Python | 0.571 | suggestion | 68 | 51 | 51 | false | redcdn livx and sejm.pl extractors | 8,676 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | selfisekai |
def add_entry(file, legacy_file=False):
if not file:
return
file = self._proto_relative_url(file)
if not legacy_file:
file = update_url_query(file, {'startTime': start_time})
if stop_time is not None:
file = ... | ```suggestion
'title': join_nonempty(title, stream_id, delim=' - '),
``` |
def add_entry(file, legacy_file=False):
if not file:
return
file = self._proto_relative_url(file)
if not legacy_file:
file = update_url_query(file, {'startTime': start_time})
if stop_time is not None:
file =... | @@ -0,0 +1,217 @@
+from .common import InfoExtractor
+from .redge import RedCDNLivxIE
+from ..utils import (
+ clean_html,
+ js_to_json,
+ strip_or_none,
+ traverse_obj,
+ update_url_query,
+)
+
+import datetime
+
+
+def is_dst(date):
+ year = date.year
+ # last sunday of march and october, respect... | yt_dlp/extractor/sejmpl.py | 26 | Python | 0.571 | suggestion | 94 | 51 | 51 | false | redcdn livx and sejm.pl extractors | 8,676 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | selfisekai |
import functools
from .common import InfoExtractor
from ..networking import HEADRequest
from ..utils import (
float_or_none,
int_or_none,
join_nonempty,
parse_qs,
traverse_obj,
update_url_query,
)
class RedCDNLivxIE(InfoExtractor):
_VALID_URL = r'https?://[^.]+\.(?:dcs\.redcdn|atmcdn)\.pl... | ```suggestion
update_url_query,
)
from ..utils.traversal import traverse_obj
``` | import functools
from .common import InfoExtractor
from ..networking import HEADRequest
from ..utils import (
float_or_none,
int_or_none,
join_nonempty,
parse_qs,
update_url_query,
)
from ..utils.traversal import traverse_obj
class RedCDNLivxIE(InfoExtractor):
_VALID_URL = r'https?://[^.]+\.(... | @@ -0,0 +1,135 @@
+import functools
+
+from .common import InfoExtractor
+from ..networking import HEADRequest
+from ..utils import (
+ float_or_none,
+ int_or_none,
+ join_nonempty,
+ parse_qs,
+ traverse_obj,
+ update_url_query,
+)
+ | yt_dlp/extractor/redge.py | 13 | Python | 0.571 | suggestion | 88 | 38 | 38 | false | redcdn livx and sejm.pl extractors | 8,676 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | selfisekai |
for attachment in attachments:
ns = (try_get(attachment, lambda x: x['all_subattachments']['nodes'], list)
or traverse_obj(attachment, (..., 'attachments', ..., 'styles', 'attachment'), expected_type=dict) or [])
for n in ns:
... | Could you explain this change? | 'description': description,
})
else:
info['title'] = description or 'Facebook video #%s' % v_id
entries.append(info)
def parse_attachment(attachment, key='media'):
med... | @@ -637,7 +638,7 @@ def parse_attachment(attachment, key='media'):
if len(entries) > 1:
return self.playlist_result(entries, video_id)
- video_info = entries[0]
+ video_info = entries[0] if len(entries) > 0 else {'id': video_id} | yt_dlp/extractor/facebook.py | 26 | Python | 0.143 | question | 30 | 51 | 51 | false | [ie/Facebook] Fix Unhandled IndexError | 8,681 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | kclauhk |
or float_or_none(video.get('length_in_second'))),
}
process_formats(info)
description = try_get(video, lambda x: x['savable_description']['text'])
title = video.get('name')
if title:
... | ```suggestion
ns = traverse_obj(attachment, ('all_subattachments', 'nodes', ..., {dict}),
(..., 'attachments', ..., 'styles', 'attachment', {dict}))
``` | formats.append({
'format_id': format_id,
# sd, hd formats w/o resolution info should be deprioritized below DASH
'quality': q(format_id) - 3,
'url': playable_url,
... | @@ -612,9 +612,10 @@ def parse_attachment(attachment, key='media'):
nodes = variadic(traverse_obj(data, 'nodes', 'node') or [])
attachments = traverse_obj(nodes, (
..., 'comet_sections', 'content', 'story', (None, 'attached_story'), 'attachments',
- ... | yt_dlp/extractor/facebook.py | 26 | Python | 0.786 | suggestion | 213 | 51 | 51 | false | [ie/Facebook] Fix Unhandled IndexError | 8,681 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | kclauhk |
'uploader_id': traverse_obj(video, ('owner', 'id', {str_or_none})),
'timestamp': traverse_obj(video, 'publish_time', 'creation_time', expected_type=int_or_none),
'duration': (float_or_none(video.get('playable_duration_in_ms'), 1000)
... | At least from my testing it seems to always be under `['throwbackStyles']['attachment_target_renderer']`. Did you observe something else?
```suggestion
..., ('styles', 'style_type_renderer', ('throwbackStyles', 'attachment_target_renderer')),
'attachment'), expected_type=dict)... | if determine_ext(playable_url) == 'mpd':
formats.extend(self._extract_mpd_formats(playable_url, video_id))
else:
formats.append({
'format_id': format_id,
... | @@ -612,9 +612,10 @@ def parse_attachment(attachment, key='media'):
nodes = variadic(traverse_obj(data, 'nodes', 'node') or [])
attachments = traverse_obj(nodes, (
..., 'comet_sections', 'content', 'story', (None, 'attached_story'), 'attachments',
- ... | yt_dlp/extractor/facebook.py | 26 | Python | 0.929 | suggestion | 331 | 51 | 51 | false | [ie/Facebook] Fix Unhandled IndexError | 8,681 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | kclauhk |
or float_or_none(video.get('length_in_second'))),
}
process_formats(info)
description = try_get(video, lambda x: x['savable_description']['text'])
title = video.get('name')
if title:
... | Same here, did you see this ever not under `target`?
```suggestion
('target', 'attachments', ..., 'styles', 'attachment', {dict}))
``` | formats.append({
'format_id': format_id,
# sd, hd formats w/o resolution info should be deprioritized below DASH
'quality': q(format_id) - 3,
'url': playable_url,
... | @@ -612,9 +612,10 @@ def parse_attachment(attachment, key='media'):
nodes = variadic(traverse_obj(data, 'nodes', 'node') or [])
attachments = traverse_obj(nodes, (
..., 'comet_sections', 'content', 'story', (None, 'attached_story'), 'attachments',
- ... | yt_dlp/extractor/facebook.py | 26 | Python | 0.714 | suggestion | 175 | 51 | 51 | false | [ie/Facebook] Fix Unhandled IndexError | 8,681 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | kclauhk |
}, {
# data.node.comet_sections.content.story.attachments[].style_type_renderer.attachment.media
'url': 'https://www.facebook.com/groups/1024490957622648/permalink/1396382447100162/',
'info_dict': {
'id': '202882990186699',
'ext': 'mp4',
'title': 'birb (O ... | The test is incomplete.
```suggestion
'uploader_id': 'pfbid0FuZhHCeWDAxWxEbr3yKPFaRstXvRxgsp9uCPG6GjD4J2AitB35NUAuJ4Q75KcjiDl',
'thumbnail': r're:^https?://.*',
'duration': 148.435,
``` | }, {
# data.node.comet_sections.content.story.attachments[].style_type_renderer.attachment.media
'url': 'https://www.facebook.com/groups/1024490957622648/permalink/1396382447100162/',
'info_dict': {
'id': '202882990186699',
'ext': 'mp4',
'title': 'birb (O ... | @@ -232,6 +232,19 @@ class FacebookIE(InfoExtractor):
'uploader_id': '100013949973717',
},
'skip': 'Requires logging in',
+ }, {
+ # data.node.comet_sections.content.story.attachments[].throwbackStyles.attachment_target_renderer.attachment.target.attachments[].styles.attachment.... | yt_dlp/extractor/facebook.py | 26 | Python | 0.786 | suggestion | 226 | 51 | 51 | false | [ie/Facebook] Fix Unhandled IndexError | 8,681 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | kclauhk |
'timestamp': traverse_obj(video, 'publish_time', 'creation_time', expected_type=int_or_none),
'duration': (float_or_none(video.get('playable_duration_in_ms'), 1000)
or float_or_none(video.get('length_in_second'))),
... | we're branching, so `or []` is unnecessary
```suggestion
..., ('styles', 'style_type_renderer', ('throwbackStyles', 'attachment_target_renderer')),
'attachment', {dict}))
``` | 'timestamp': traverse_obj(video, 'publish_time', 'creation_time', expected_type=int_or_none),
'duration': (float_or_none(video.get('playable_duration_in_ms'), 1000)
or float_or_none(video.get('length_in_second'))),
... | @@ -612,9 +627,11 @@ def parse_attachment(attachment, key='media'):
nodes = variadic(traverse_obj(data, 'nodes', 'node') or [])
attachments = traverse_obj(nodes, (
..., 'comet_sections', 'content', 'story', (None, 'attached_story'), 'attachments',
- ... | yt_dlp/extractor/facebook.py | 26 | Python | 0.929 | suggestion | 218 | 51 | 51 | false | [ie/Facebook] Fix Unhandled IndexError | 8,681 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | kclauhk |
'uploader': 'wILLIAM PIP',
'upload_date': '20220328',
}
}, {
'url': 'https://www.loom.com/share/c43a642f815f4378b6f80a889bb73d8d',
'md5': '281c57772c6364c7a860fc222ea8d222',
'info_dict': {
'id': 'c43a642f815f4378b6f80a889bb73d8d',
'ext'... | `self._download_json(..., data=b'')` makes POST | _EMBED_REGEX = [rf'<iframe[^>]+\bsrc=["\'](?P<url>{_VALID_URL})']
_TESTS = [{
# m3u8 raw-url, mp4 transcoded-url, cdn url == raw-url, json subs only
'url': 'https://www.loom.com/share/43d05f362f734614a2e81b4694a3a523',
'md5': 'bfc2d7e9c2e0eb4813212230794b6f42',
'info_dict': {
... | @@ -0,0 +1,103 @@
+from .common import InfoExtractor
+import json
+import urllib.request
+from datetime import datetime
+
+'''
+This scraper was made really fast without really following best practices.
+The webpage string has json data inside it and it would be better if the
+video data was grabbed from there instead ... | yt_dlp/extractor/loom.py | 26 | Python | 0.214 | suggestion | 47 | 51 | 51 | false | Added Extractor for Loom | 8,686 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | hruzgar |
from .common import InfoExtractor
import json
import urllib.request
from datetime import datetime
'''
This scraper was made really fast without really following best practices.
The webpage string has json data inside it and it would be better if the
video data was grabbed from there instead of using regex.
Because loo... | Remove this and all other comments. | import json
import textwrap
import urllib.parse
import uuid
from .common import InfoExtractor
from ..utils import (
ExtractorError,
determine_ext,
filter_dict,
get_first,
int_or_none,
parse_iso8601,
update_url,
url_or_none,
variadic,
)
from ..utils.traversal import traverse_obj
cl... | @@ -0,0 +1,103 @@
+from .common import InfoExtractor
+import json
+import urllib.request
+from datetime import datetime
+
+'''
+This scraper was made really fast without really following best practices.
+The webpage string has json data inside it and it would be better if the
+video data was grabbed from there instead ... | yt_dlp/extractor/loom.py | 12 | Python | 0.143 | refactor | 35 | 37 | 37 | false | Added Extractor for Loom | 8,686 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | hruzgar |
from .common import InfoExtractor
from datetime import datetime
from yt_dlp.utils.traversal import traverse_obj
class LoomIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?loom\.com/share/(?P<id>[a-z0-9]+)'
_TESTS = [{
'url': 'https://www.loom.com/share/43d05f362f734614a2e81b4694a3a523',
'm... | the IDs look to be hex chars only
```suggestion
_VALID_URL = r'https?://(?:www\.)?loom\.com/share/(?P<id>[\da-f]+)'
``` | import json
import textwrap
import urllib.parse
import uuid
from .common import InfoExtractor
from ..utils import (
ExtractorError,
determine_ext,
filter_dict,
get_first,
int_or_none,
parse_iso8601,
update_url,
url_or_none,
variadic,
)
from ..utils.traversal import traverse_obj
cl... | @@ -0,0 +1,62 @@
+from .common import InfoExtractor
+from datetime import datetime
+from yt_dlp.utils.traversal import traverse_obj
+
+
+class LoomIE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?loom\.com/share/(?P<id>[a-z0-9]+)' | yt_dlp/extractor/loom.py | 7 | Python | 0.714 | suggestion | 126 | 32 | 32 | false | Added Extractor for Loom | 8,686 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | hruzgar |
'ext': 'mp4',
'title': 'A Ruler for Windows - 28 March 2022',
'uploader': 'wILLIAM PIP',
'upload_date': '20220328',
}
}, {
'url': 'https://www.loom.com/share/c43a642f815f4378b6f80a889bb73d8d',
'md5': '281c57772c6364c7a860fc222ea8d222',
... | - don't use `json` for var name, it leads to confusion (e.g. is this stdlib `json`?)
- this is only used for non-mandatory metadata, so make it non-fatal
- use single-quotes whenever possible
- line too long
```suggestion
metadata = self._search_json(
r'window\.loomSSRVideo\s*=', webpage, 'met... | parse_iso8601,
update_url,
url_or_none,
variadic,
)
from ..utils.traversal import traverse_obj
class LoomIE(InfoExtractor):
IE_NAME = 'loom'
_VALID_URL = r'https?://(?:www\.)?loom\.com/(?:share|embed)/(?P<id>[\da-f]{32})'
_EMBED_REGEX = [rf'<iframe[^>]+\bsrc=["\'](?P<url>{_VALID_URL})']
... | @@ -0,0 +1,62 @@
+from .common import InfoExtractor
+from datetime import datetime
+from yt_dlp.utils.traversal import traverse_obj
+
+
+class LoomIE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?loom\.com/share/(?P<id>[a-z0-9]+)'
+ _TESTS = [{
+ 'url': 'https://www.loom.com/share/43d05f362f734614a2e... | yt_dlp/extractor/loom.py | 26 | Python | 0.857 | refactor | 355 | 51 | 51 | false | Added Extractor for Loom | 8,686 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | hruzgar |
_TESTS = [{
'url': 'https://www.loom.com/share/43d05f362f734614a2e81b4694a3a523',
'md5': '2b0d36e4999c39fabdb617188f21ea1e',
'info_dict': {
'id': '43d05f362f734614a2e81b4694a3a523',
'ext': 'mp4',
'title': 'A Ruler for Windows - 28 March 2022',
... | - unnecessary method; we can inline this below
- in the future, don't redefine built-ins such as `id`
```suggestion
``` | ExtractorError,
determine_ext,
filter_dict,
get_first,
int_or_none,
parse_iso8601,
update_url,
url_or_none,
variadic,
)
from ..utils.traversal import traverse_obj
class LoomIE(InfoExtractor):
IE_NAME = 'loom'
_VALID_URL = r'https?://(?:www\.)?loom\.com/(?:share|embed)/(?P<i... | @@ -0,0 +1,62 @@
+from .common import InfoExtractor
+from datetime import datetime
+from yt_dlp.utils.traversal import traverse_obj
+
+
+class LoomIE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?loom\.com/share/(?P<id>[a-z0-9]+)'
+ _TESTS = [{
+ 'url': 'https://www.loom.com/share/43d05f362f734614a2e... | yt_dlp/extractor/loom.py | 26 | Python | 0.714 | suggestion | 122 | 51 | 51 | false | Added Extractor for Loom | 8,686 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | hruzgar |
'title': 'A Ruler for Windows - 28 March 2022',
'uploader': 'wILLIAM PIP',
'upload_date': '20220328',
}
}, {
'url': 'https://www.loom.com/share/c43a642f815f4378b6f80a889bb73d8d',
'md5': '281c57772c6364c7a860fc222ea8d222',
'info_dict': {
... | we can inline this further below
```suggestion
``` | update_url,
url_or_none,
variadic,
)
from ..utils.traversal import traverse_obj
class LoomIE(InfoExtractor):
IE_NAME = 'loom'
_VALID_URL = r'https?://(?:www\.)?loom\.com/(?:share|embed)/(?P<id>[\da-f]{32})'
_EMBED_REGEX = [rf'<iframe[^>]+\bsrc=["\'](?P<url>{_VALID_URL})']
_TESTS = [{
... | @@ -0,0 +1,62 @@
+from .common import InfoExtractor
+from datetime import datetime
+from yt_dlp.utils.traversal import traverse_obj
+
+
+class LoomIE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?loom\.com/share/(?P<id>[a-z0-9]+)'
+ _TESTS = [{
+ 'url': 'https://www.loom.com/share/43d05f362f734614a2e... | yt_dlp/extractor/loom.py | 26 | Python | 0.571 | suggestion | 52 | 50 | 51 | false | Added Extractor for Loom | 8,686 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | hruzgar |
'uploader': 'wILLIAM PIP',
'upload_date': '20220328',
}
}, {
'url': 'https://www.loom.com/share/c43a642f815f4378b6f80a889bb73d8d',
'md5': '281c57772c6364c7a860fc222ea8d222',
'info_dict': {
'id': 'c43a642f815f4378b6f80a889bb73d8d',
'ext'... | - use `determine_ext` from utils instead of manually searching w/ regex
- core code calls `determine_ext` on format URLs after the info dict is returned, so this is unnecessary here
```suggestion
``` | url_or_none,
variadic,
)
from ..utils.traversal import traverse_obj
class LoomIE(InfoExtractor):
IE_NAME = 'loom'
_VALID_URL = r'https?://(?:www\.)?loom\.com/(?:share|embed)/(?P<id>[\da-f]{32})'
_EMBED_REGEX = [rf'<iframe[^>]+\bsrc=["\'](?P<url>{_VALID_URL})']
_TESTS = [{
# m3u8 raw-ur... | @@ -0,0 +1,62 @@
+from .common import InfoExtractor
+from datetime import datetime
+from yt_dlp.utils.traversal import traverse_obj
+
+
+class LoomIE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?loom\.com/share/(?P<id>[a-z0-9]+)'
+ _TESTS = [{
+ 'url': 'https://www.loom.com/share/43d05f362f734614a2e... | yt_dlp/extractor/loom.py | 26 | Python | 0.857 | suggestion | 202 | 49 | 51 | false | Added Extractor for Loom | 8,686 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | hruzgar |
'url': 'https://www.loom.com/share/c43a642f815f4378b6f80a889bb73d8d',
'md5': '281c57772c6364c7a860fc222ea8d222',
'info_dict': {
'id': 'c43a642f815f4378b6f80a889bb73d8d',
'ext': 'mp4',
'title': 'Lilah Nielsen Intro Video',
'uploader': 'Lilah Nielsen... | - if the time (not just the date) is available, it's better to return a unix `timestamp` instead of `upload_date`, as core code will calculate and add the `upload_date` for us then
- we should inline this in the return
```suggestion
``` |
class LoomIE(InfoExtractor):
IE_NAME = 'loom'
_VALID_URL = r'https?://(?:www\.)?loom\.com/(?:share|embed)/(?P<id>[\da-f]{32})'
_EMBED_REGEX = [rf'<iframe[^>]+\bsrc=["\'](?P<url>{_VALID_URL})']
_TESTS = [{
# m3u8 raw-url, mp4 transcoded-url, cdn url == raw-url, json subs only
'url': 'ht... | @@ -0,0 +1,62 @@
+from .common import InfoExtractor
+from datetime import datetime
+from yt_dlp.utils.traversal import traverse_obj
+
+
+class LoomIE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?loom\.com/share/(?P<id>[a-z0-9]+)'
+ _TESTS = [{
+ 'url': 'https://www.loom.com/share/43d05f362f734614a2e... | yt_dlp/extractor/loom.py | 26 | Python | 0.857 | suggestion | 239 | 45 | 51 | false | Added Extractor for Loom | 8,686 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | hruzgar |
}
}]
def fetch_loom_download_url(self, id):
json = self._download_json(f"https://www.loom.com/api/campaigns/sessions/{id}/transcoded-url", video_id=id, data=b'')
return json["url"]
def _real_extract(self, url):
video_id = self._match_id(url)
webpage = self._download... | inline below
```suggestion
``` | 'url': 'https://www.loom.com/share/43d05f362f734614a2e81b4694a3a523',
'md5': 'bfc2d7e9c2e0eb4813212230794b6f42',
'info_dict': {
'id': '43d05f362f734614a2e81b4694a3a523',
'ext': 'mp4',
'title': 'A Ruler for Windows - 28 March 2022',
'uploader': 'wIL... | @@ -0,0 +1,62 @@
+from .common import InfoExtractor
+from datetime import datetime
+from yt_dlp.utils.traversal import traverse_obj
+
+
+class LoomIE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?loom\.com/share/(?P<id>[a-z0-9]+)'
+ _TESTS = [{
+ 'url': 'https://www.loom.com/share/43d05f362f734614a2e... | yt_dlp/extractor/loom.py | 26 | Python | 0.429 | suggestion | 32 | 37 | 51 | false | Added Extractor for Loom | 8,686 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | hruzgar |
json = self._search_json(start_pattern=r'window\.loomSSRVideo\s*=', string=webpage, name="Json from Loom Webpage", video_id=video_id)
videourl = self.fetch_loom_download_url(video_id)
ext = self._search_regex(r'([a-zA-Z0-9]+)(?=\?)', videourl, 'ext', fatal=False)
date_string = json.get... | - If we are only extracting a single format, the format fields (including `url`) can be returned in the info dict root. This reduces the complexity the extractor code
- we can use one `traverse_obj` call to extract all the values from the `metadata` var
- set syntax in a traversal path (`{example}`) is special. If a ... | },
}, {
# webm raw-url, mp4 transcoded-url, cdn url == transcoded-url, no subs
'url': 'https://www.loom.com/share/c43a642f815f4378b6f80a889bb73d8d',
'md5': '70f529317be8cf880fcc2c649a531900',
'info_dict': {
'id': 'c43a642f815f4378b6f80a889bb73d8d',
'ex... | @@ -0,0 +1,62 @@
+from .common import InfoExtractor
+from datetime import datetime
+from yt_dlp.utils.traversal import traverse_obj
+
+
+class LoomIE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?loom\.com/share/(?P<id>[a-z0-9]+)'
+ _TESTS = [{
+ 'url': 'https://www.loom.com/share/43d05f362f734614a2e... | yt_dlp/extractor/loom.py | 26 | Python | 1 | performance | 1,462 | 27 | 51 | false | Added Extractor for Loom | 8,686 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | hruzgar |
from .common import InfoExtractor
from datetime import datetime
from yt_dlp.utils.traversal import traverse_obj
class LoomIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?loom\.com/share/(?P<id>[a-z0-9]+)'
_TESTS = [{
'url': 'https://www.loom.com/share/43d05f362f734614a2e81b4694a3a523',
'm... | ```suggestion
from ..utils import int_or_none, parse_iso8601
``` | import json
import textwrap
import urllib.parse
import uuid
from .common import InfoExtractor
from ..utils import (
ExtractorError,
determine_ext,
filter_dict,
get_first,
int_or_none,
parse_iso8601,
update_url,
url_or_none,
variadic,
)
from ..utils.traversal import traverse_obj
cl... | @@ -0,0 +1,62 @@
+from .common import InfoExtractor
+from datetime import datetime | yt_dlp/extractor/loom.py | 2 | Python | 0.571 | suggestion | 66 | 27 | 27 | false | Added Extractor for Loom | 8,686 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | hruzgar |
from .common import InfoExtractor
from datetime import datetime
from yt_dlp.utils.traversal import traverse_obj
class LoomIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?loom\.com/share/(?P<id>[a-z0-9]+)'
_TESTS = [{
'url': 'https://www.loom.com/share/43d05f362f734614a2e81b4694a3a523',
'm... | use relative imports
```suggestion
from ..utils.traversal import traverse_obj
``` | import json
import textwrap
import urllib.parse
import uuid
from .common import InfoExtractor
from ..utils import (
ExtractorError,
determine_ext,
filter_dict,
get_first,
int_or_none,
parse_iso8601,
update_url,
url_or_none,
variadic,
)
from ..utils.traversal import traverse_obj
cl... | @@ -0,0 +1,62 @@
+from .common import InfoExtractor
+from datetime import datetime
+from yt_dlp.utils.traversal import traverse_obj | yt_dlp/extractor/loom.py | 3 | Python | 0.643 | suggestion | 84 | 28 | 28 | false | Added Extractor for Loom | 8,686 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | hruzgar |
}
class ARDBetaMediathekIE(ARDMediathekBaseIE):
_VALID_URL = r'''(?x)https://
(?:(?:beta|www)\.)?ardmediathek\.de/
(?:(?P<client>[^/]+)/)?
(?:player|live|video|(?P<playlist>sendung|serie|sammlung))/
(?:(?P<display_id>(?(playlist)[^?#]+?|[^?#]+))/)?
(?P<id>(?(playlis... | A value of `None` is treated like the absence of a value:
```suggestion
``` | }
class ARDBetaMediathekIE(ARDMediathekBaseIE):
_VALID_URL = r'''(?x)https://
(?:(?:beta|www)\.)?ardmediathek\.de/
(?:(?P<client>[^/]+)/)?
(?:player|live|video|(?P<playlist>sendung|serie|sammlung))/
(?:(?P<display_id>(?(playlist)[^?#]+?|[^?#]+))/)?
(?P<id>(?(playlis... | @@ -403,26 +403,26 @@ class ARDBetaMediathekIE(ARDMediathekBaseIE):
_VALID_URL = r'''(?x)https://
(?:(?:beta|www)\.)?ardmediathek\.de/
(?:(?P<client>[^/]+)/)?
- (?:player|live|video|(?P<playlist>sendung|sammlung))/
+ (?:player|live|video|(?P<playlist>sendung|serie|sammlung))/
... | yt_dlp/extractor/ard.py | 26 | Python | 0.571 | suggestion | 77 | 51 | 51 | false | Support ARD Mediathek URLs with "serien" (fixes #7666) | 8,687 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | lstrojny |
'id': 'bjhh-nbcja',
'title': 'アイドルマスター ミリオンライブ！ 765プロch 原っぱ通信',
},
'playlist_mincount': 16,
}, {
'url': 'https://asobichannel.asobistore.jp/tag/hvm5qw3c6od',
'info_dict': {
'id': 'hvm5qw3c6od',
'title': 'アイマスMOIW2023ラジオ',
},
... | ```suggestion
'url': f'https://asobichannel.asobistore.jp/watch/{metadata["id"]}',
``` |
_VALID_URL = r'https?://asobichannel\.asobistore\.jp/tag/(?P<id>[a-z0-9-_]+)'
_TESTS = [{
'url': 'https://asobichannel.asobistore.jp/tag/bjhh-nbcja',
'info_dict': {
'id': 'bjhh-nbcja',
'title': 'アイドルマスター ミリオンライブ！ 765プロch 原っぱ通信',
},
'playlist_mincount': 16... | @@ -0,0 +1,160 @@
+import datetime
+
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601, traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _extract_info(... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.714 | suggestion | 100 | 31 | 39 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | Snack-X |
class AsobiChannelTagURLIE(AsobiChannelBaseIE):
IE_NAME = 'asobichannel:tag'
IE_DESC = 'ASOBI CHANNEL'
_VALID_URL = r'https?://asobichannel\.asobistore\.jp/tag/(?P<id>[a-z0-9-_]+)'
_TESTS = [{
'url': 'https://asobichannel.asobistore.jp/tag/bjhh-nbcja',
'info_dict': {
'id': '... | Since this is only used for the title, I would move it down at make it non fatal.
```python
title = traverse_obj(self._search_nextjs_data(
webpage, tag_id, fatal=False), ('props', 'pageProps', 'data', 'name'))
```
`fatal=False` does not currently work as expected for `_search_nextjs_data`, but that should be ... | return merge_dicts(info, self._process_live(video_id, metadata))
raise ExtractorError(f'Unexpected video type {video_type!r}')
class AsobiChannelTagURLIE(AsobiChannelBaseIE):
IE_NAME = 'asobichannel:tag'
IE_DESC = 'ASOBI CHANNEL'
_VALID_URL = r'https?://asobichannel\.asobistore\.jp/t... | @@ -0,0 +1,160 @@
+import datetime
+
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601, traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _extract_info(... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.857 | suggestion | 346 | 39 | 47 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | Snack-X |
'https://asobichannel-api.asobistore.jp/api/v1/vspf/token', video_id,
note='Retrieving API token')
return {'Authorization': f'Bearer {request_token}'}
def _process_vod(self, video_id, metadata):
content_id = metadata['contents']['video_id']
vod_data = self._download... | This seems odd. Could we maybe use the `Player_type` to determine if a stream is upcoming? i.e. `"poster"` = upcoming?
Upcoming streams currently also seem to error due to a 404 response from the streaming endpoint. | },
}]
_survapi_header = None
def _real_initialize(self):
token = self._download_json(
'https://asobichannel-api.asobistore.jp/api/v1/vspf/token', None,
note='Retrieving API token')
self._survapi_header = {'Authorization': f'Bearer {token}'}
def _process... | @@ -0,0 +1,160 @@
+import datetime
+
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601, traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _extract_info(... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.786 | suggestion | 218 | 51 | 51 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | Snack-X |
return {
'formats': self._extract_m3u8_formats(m3u8_url, video_id),
}
def _process_live(self, video_id, metadata):
now_ts = datetime.datetime.now().timestamp()
content_id = metadata['contents']['video_id']
live_start = traverse_obj(metadata, ('period', 'start',... | Should set `live=True` if live. |
vod_data = self._download_json(
f'https://survapi.channel.or.jp/proxy/v1/contents/{content_id}/get_by_cuid', video_id,
headers=self._survapi_header, note='Downloading vod data')
return {
'formats': self._extract_m3u8_formats(vod_data['ex_content']['streaming_url'], ... | @@ -0,0 +1,160 @@
+import datetime
+
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601, traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _extract_info(... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.286 | suggestion | 31 | 51 | 51 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | Snack-X |
'release_date': '20231012',
'modified_timestamp': 1698381162,
'modified_date': '20231027',
'channel': 'アイドルマスター',
'channel_id': 'idolmaster',
},
}, {
'url': 'https://asobichannel.asobistore.jp/watch/redigiwnjzqj',
'md5': '229fa8fb5c... | Should this token be saved in case of multiple requests?
Also maybe move to `_real_initialize`? | 'ext': 'mp4',
'title': 'アイドルマスター ミリオンライブ！ 765プロch 原っぱ通信 #1',
'description': 'md5:b930bd2199c9b2fd75951ce4aaa7efd2',
'thumbnail': 'https://images.microcms-assets.io/assets/d2420de4b9194e11beb164f99edb1f95/a8e6f84119f54eb9ab4ce16729239905/%E3%82%B5%E3%83%A0%E3%83%8D%20(1).p... | @@ -0,0 +1,160 @@
+import datetime
+
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601, traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _extract_info(... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.429 | question | 96 | 51 | 51 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | Snack-X |
'modified_date': '20231020',
'release_timestamp': 1697261769,
'release_date': '20231014',
'channel': 'アイドルマスター',
'channel_id': 'idolmaster',
},
}]
def _get_survapi_header(self, video_id):
request_token = self._download_json(
... | No need for single use variables
```suggestion
return {
'formats': self._extract_m3u8_formats(vod_data['ex_content']['streaming_url'], video_id),
}
``` | 'ext': 'mp4',
'title': '【おまけ放送】アイドルマスター ミリオンライブ！ 765プロch 原っぱ通信 #1',
'description': 'md5:7d9cd35fb54425a6967822bd564ea2d9',
'thumbnail': 'https://images.microcms-assets.io/assets/d2420de4b9194e11beb164f99edb1f95/20e5c1d6184242eebc2512a5dec59bf0/P1_%E5%8E%9F%E3%81%A3%E3%81%... | @@ -0,0 +1,160 @@
+import datetime
+
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601, traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _extract_info(... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.786 | refactor | 184 | 51 | 51 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | Snack-X |
'id': 'bjhh-nbcja',
'title': 'アイドルマスター ミリオンライブ！ 765プロch 原っぱ通信',
},
'playlist_mincount': 16,
}, {
'url': 'https://asobichannel.asobistore.jp/tag/hvm5qw3c6od',
'info_dict': {
'id': 'hvm5qw3c6od',
'title': 'アイマスMOIW2023ラジオ',
},
... | ```suggestion
'url': f'https://asobichannel.asobistore.jp/watch/{metadata["id"]}',
'ie_key': AsobiChannelIE.ie_key(),
``` | IE_DESC = 'ASOBI CHANNEL'
_VALID_URL = r'https?://asobichannel\.asobistore\.jp/tag/(?P<id>[a-z0-9-_]+)'
_TESTS = [{
'url': 'https://asobichannel.asobistore.jp/tag/bjhh-nbcja',
'info_dict': {
'id': 'bjhh-nbcja',
'title': 'アイドルマスター ミリオンライブ！ 765プロch 原っぱ通信',
},
... | @@ -0,0 +1,159 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601
+from ..utils.traversal import traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _ex... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.714 | suggestion | 148 | 31 | 40 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | Snack-X |
from .common import InfoExtractor
from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601
from ..utils.traversal import traverse_obj
class AsobiChannelBaseIE(InfoExtractor):
_MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
def _extract_info(self, metadata):... | ```suggestion
'id': ('id', {str}),
'title': ('title', {str}),
'description': ('body', {clean_html}),
'thumbnail': ('contents', 'video_thumb', 'url'),
'timestamp': ('publishedAt', {parse_iso8601}),
'modified_timestamp': ('updatedAt', {parse_is... | from .common import InfoExtractor
from ..utils import (
ExtractorError,
clean_html,
merge_dicts,
parse_iso8601,
url_or_none,
)
from ..utils.traversal import traverse_obj
class AsobiChannelBaseIE(InfoExtractor):
_MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
... | @@ -0,0 +1,160 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601
+from ..utils.traversal import traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _ex... | yt_dlp/extractor/asobichannel.py | 18 | Python | 0.786 | suggestion | 438 | 43 | 43 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | Snack-X |
from .common import InfoExtractor
from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601
from ..utils.traversal import traverse_obj
class AsobiChannelBaseIE(InfoExtractor):
_MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
def _extract_info(self, metadata):... | ```suggestion
_VALID_URL = r'https?://asobichannel\.asobistore\.jp/watch/(?P<id>[\w-]+)'
``` | from .common import InfoExtractor
from ..utils import (
ExtractorError,
clean_html,
merge_dicts,
parse_iso8601,
url_or_none,
)
from ..utils.traversal import traverse_obj
class AsobiChannelBaseIE(InfoExtractor):
_MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
... | @@ -0,0 +1,160 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601
+from ..utils.traversal import traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _ex... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.571 | suggestion | 98 | 51 | 51 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | Snack-X |
class AsobiChannelTagURLIE(AsobiChannelBaseIE):
IE_NAME = 'asobichannel:tag'
IE_DESC = 'ASOBI CHANNEL'
_VALID_URL = r'https?://asobichannel\.asobistore\.jp/tag/(?P<id>[a-z0-9-_]+)'
_TESTS = [{
'url': 'https://asobichannel.asobistore.jp/tag/bjhh-nbcja',
'info_dict': {
'id': '... | ```suggestion
tag_id = self._match_id(url)
webpage = self._download_webpage(url, tag_id)
title = traverse_obj(self._search_nextjs_data(
webpage, tag_id, fatal=False), ('props', 'pageProps', 'data', 'name', {str}))
``` | if video_type == 'LIVE':
return merge_dicts(info, self._process_live(video_id, metadata))
raise ExtractorError(f'Unexpected video type {video_type!r}')
class AsobiChannelTagURLIE(AsobiChannelBaseIE):
IE_NAME = 'asobichannel:tag'
IE_DESC = 'ASOBI CHANNEL'
_VALID_URL = r'https?... | @@ -0,0 +1,160 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601
+from ..utils.traversal import traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _ex... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.786 | suggestion | 258 | 40 | 48 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | Snack-X |
_VALID_URL = r'https?://asobichannel\.asobistore\.jp/tag/(?P<id>[a-z0-9-_]+)'
_TESTS = [{
'url': 'https://asobichannel.asobistore.jp/tag/bjhh-nbcja',
'info_dict': {
'id': 'bjhh-nbcja',
'title': 'アイドルマスター ミリオンライブ！ 765プロch 原っぱ通信',
},
'playlist_mincount': 16,... | avoid using "list" var names if the var is not actually a list
```suggestion
media = self._download_json(
f'https://channel.microcms.io/api/v1/media?limit=999&filters=(tag[contains]{tag_id})',
tag_id, headers=self._MICROCMS_HEADER)
``` |
class AsobiChannelTagURLIE(AsobiChannelBaseIE):
IE_NAME = 'asobichannel:tag'
IE_DESC = 'ASOBI CHANNEL'
_VALID_URL = r'https?://asobichannel\.asobistore\.jp/tag/(?P<id>[a-z0-9-_]+)'
_TESTS = [{
'url': 'https://asobichannel.asobistore.jp/tag/bjhh-nbcja',
'info_dict': {
'id':... | @@ -0,0 +1,160 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601
+from ..utils.traversal import traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _ex... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.857 | suggestion | 272 | 36 | 44 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | Snack-X |
'url': 'https://asobichannel.asobistore.jp/tag/hvm5qw3c6od',
'info_dict': {
'id': 'hvm5qw3c6od',
'title': 'アイマスMOIW2023ラジオ',
},
'playlist_mincount': 13,
}]
def _real_extract(self, url):
tag_id = self._match_id(url)
webpage = self._downloa... | ```suggestion
return self.playlist_result(entries(), tag_id, title)
``` | 'info_dict': {
'id': 'bjhh-nbcja',
'title': 'アイドルマスター ミリオンライブ！ 765プロch 原っぱ通信',
},
'playlist_mincount': 16,
}, {
'url': 'https://asobichannel.asobistore.jp/tag/hvm5qw3c6od',
'info_dict': {
'id': 'hvm5qw3c6od',
'title': 'アイマスMOIW2... | @@ -0,0 +1,160 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601
+from ..utils.traversal import traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _ex... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.571 | suggestion | 81 | 27 | 35 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | Snack-X |
'playlist_mincount': 16,
}, {
'url': 'https://asobichannel.asobistore.jp/tag/hvm5qw3c6od',
'info_dict': {
'id': 'hvm5qw3c6od',
'title': 'アイマスMOIW2023ラジオ',
},
'playlist_mincount': 13,
}]
def _real_extract(self, url):
tag_id = self._matc... | ```suggestion
def entries():
for metadata in traverse_obj(media, ('contents', lambda _, v: v['id'])):
yield {
'_type': 'url',
'url': f'https://asobichannel.asobistore.jp/watch/{metadata["id"]}',
'ie_key': AsobiChannelI... | _TESTS = [{
'url': 'https://asobichannel.asobistore.jp/tag/bjhh-nbcja',
'info_dict': {
'id': 'bjhh-nbcja',
'title': 'アイドルマスター ミリオンライブ！ 765プロch 原っぱ通信',
},
'playlist_mincount': 16,
}, {
'url': 'https://asobichannel.asobistore.jp/tag/hvm5qw3c6od',
... | @@ -0,0 +1,160 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601
+from ..utils.traversal import traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _ex... | yt_dlp/extractor/asobichannel.py | 26 | Python | 1 | refactor | 408 | 29 | 37 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | Snack-X |
_survapi_header = None
def _real_initialize(self):
token = self._download_json(
'https://asobichannel-api.asobistore.jp/api/v1/vspf/token', None,
note='Retrieving API token')
self._survapi_header = {'Authorization': f'Bearer {token}'}
def _process_vod(self, video_id... | ```suggestion
player_type = traverse_obj(event_data, ('data', 'Player_type', {str}))
``` | 'upload_date': '20231014',
'channel': 'アイドルマスター',
'channel_id': 'idolmaster',
},
}]
_survapi_header = None
def _real_initialize(self):
token = self._download_json(
'https://asobichannel-api.asobistore.jp/api/v1/vspf/token', None,
... | @@ -0,0 +1,160 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601
+from ..utils.traversal import traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _ex... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.714 | suggestion | 98 | 51 | 51 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | Snack-X |
vod_data = self._download_json(
f'https://survapi.channel.or.jp/proxy/v1/contents/{content_id}/get_by_cuid', video_id,
headers=self._survapi_header, note='Downloading vod data')
return {
'formats': self._extract_m3u8_formats(vod_data['ex_content']['streaming_url'], ... | include unsupported player type in error msg
```suggestion
raise ExtractorError('Unsupported player type {player_type!r}')
``` | 'https://asobichannel-api.asobistore.jp/api/v1/vspf/token', None,
note='Retrieving API token')
self._survapi_header = {'Authorization': f'Bearer {token}'}
def _process_vod(self, video_id, metadata):
content_id = metadata['contents']['video_id']
vod_data = self._down... | @@ -0,0 +1,160 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601
+from ..utils.traversal import traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _ex... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.929 | refactor | 141 | 51 | 51 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | Snack-X |
event_data['data']['Channel']['Custom_live_url'], video_id, live=True)
else:
raise ExtractorError('Unexpected player type')
return {
'release_timestamp': traverse_obj(metadata, ('period', 'start', {parse_iso8601})),
'live_status': live_status,
... | ```suggestion
raise ExtractorError(f'Unexpected video type {video_type!r}')
``` | self.raise_no_formats('Live event has not yet started', expected=True)
live_status = 'is_upcoming'
formats = []
elif player_type == 'player':
live_status = 'is_live'
formats = self._extract_m3u8_formats(
event_data['data']['Channel']['C... | @@ -0,0 +1,160 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601
+from ..utils.traversal import traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _ex... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.786 | refactor | 89 | 51 | 51 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | Snack-X |
self.raise_no_formats('Live event has not yet started', expected=True)
live_status = 'is_upcoming'
formats = []
elif player_type == 'player':
live_status = 'is_live'
formats = self._extract_m3u8_formats(
event_data['data']['Channel']['C... | ```suggestion
video_type = traverse_obj(metadata, ('contents', 'video_type', 0, {str}))
``` | event_data = self._download_json(
f'https://survapi.channel.or.jp/ex/events/{content_id}?embed=channel', video_id,
headers=self._survapi_header, note='Downloading event data')
player_type = traverse_obj(event_data, ('data', 'Player_type', {str}))
if player_type == 'poste... | @@ -0,0 +1,160 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, clean_html, merge_dicts, parse_iso8601
+from ..utils.traversal import traverse_obj
+
+
+class AsobiChannelBaseIE(InfoExtractor):
+ _MICROCMS_HEADER = {'X-MICROCMS-API-KEY': 'qRaKehul9AHU8KtL0dnq1OCLKnFec6yrbcz3'}
+
+ def _ex... | yt_dlp/extractor/asobichannel.py | 26 | Python | 0.857 | suggestion | 101 | 51 | 51 | false | [ie/asobichannel] Implement Asobi Channel extractor | 8,700 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | Snack-X |
from .common import InfoExtractor
from ..utils import (
parse_iso8601,
traverse_obj,
)
class TrtWorldIE(InfoExtractor):
_VALID_URL = r'https?://www\.trtworld\.com/video/([a-zA-Z0-9-]+)/([a-zA-Z0-9-]+)-(?P<id>[0-9]+)'
_TESTS = [{
'url': 'https://www.trtworld.com/video/news/turkiye-switches-to-... | ```suggestion
_VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
``` | from .common import InfoExtractor
from ..utils import ExtractorError, determine_ext, parse_iso8601, url_or_none
from ..utils.traversal import traverse_obj
class TrtWorldIE(InfoExtractor):
_VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.trtwo... | @@ -0,0 +1,44 @@
+from .common import InfoExtractor
+from ..utils import (
+ parse_iso8601,
+ traverse_obj,
+)
+
+
+class TrtWorldIE(InfoExtractor):
+ _VALID_URL = r'https?://www\.trtworld\.com/video/([a-zA-Z0-9-]+)/([a-zA-Z0-9-]+)-(?P<id>[0-9]+)' | yt_dlp/extractor/trtworld.py | 9 | Python | 0.571 | suggestion | 99 | 34 | 34 | false | TrtWorld add extractor | 8,701 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | ufukk |
'url': 'https://www.trtworld.com/video/news/turkiye-switches-to-sustainable-tourism-16067690',
'info_dict': {
'id': '16067690',
'ext': 'mp4',
'title': 'Türkiye switches to sustainable tourism',
'release_timestamp': 1701529569,
'release_date': '... | I would write this like so in order to extract the http URLs and also extract the YouTube URL if the site does not host the video.
```suggestion
nuxtjs_data = self._search_nuxt_data(webpage, display_id)['videoData']['content']
formats = []
for media_url in traverse_obj(nuxtjs_data, (
... | 'id': '16067690',
'ext': 'mp4',
'title': 'Türkiye switches to sustainable tourism',
'release_timestamp': 1701529569,
'release_date': '20231202',
'thumbnail': 'https://cdn-i.pr.trt.com.tr/trtworld/17647563_0-0-1920-1080.jpeg',
'descripti... | @@ -0,0 +1,44 @@
+from .common import InfoExtractor
+from ..utils import (
+ parse_iso8601,
+ traverse_obj,
+)
+
+
+class TrtWorldIE(InfoExtractor):
+ _VALID_URL = r'https?://www\.trtworld\.com/video/([a-zA-Z0-9-]+)/([a-zA-Z0-9-]+)-(?P<id>[0-9]+)'
+
+ _TESTS = [{
+ 'url': 'https://www.trtworld.com/vi... | yt_dlp/extractor/trtworld.py | 26 | Python | 1 | bug | 1,628 | 34 | 51 | false | TrtWorld add extractor | 8,701 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | ufukk |
'release_date': '20231202'
}
}, {
'url': 'https://www.trtworld.com/video/one-offs/frames-from-anatolia-recreating-a-james-bond-scene-in-istanbuls-grand-bazaar-14541780',
'info_dict': {
'id': '14541780',
'ext': 'mp4',
'title': 'Frames From Anato... | `_match_id` will return a string anyway. I would also extract some more metadata:
```suggestion
'id': display_id,
'formats': formats,
**traverse_obj(nuxtjs_data, ('platforms', ('website', 'ott'), {
'title': ('fields', 'title', 'text'),
'descripti... | 'description': 'md5:0a975c04257fb529c8f99c7b76a2cf12',
}
}, {
'url': 'https://www.trtworld.com/video/one-offs/frames-from-anatolia-recreating-a-james-bond-scene-in-istanbuls-grand-bazaar-14541780',
'info_dict': {
'id': '14541780',
'ext': 'mp4',
... | @@ -0,0 +1,44 @@
+from .common import InfoExtractor
+from ..utils import (
+ parse_iso8601,
+ traverse_obj,
+)
+
+
+class TrtWorldIE(InfoExtractor):
+ _VALID_URL = r'https?://www\.trtworld\.com/video/([a-zA-Z0-9-]+)/([a-zA-Z0-9-]+)-(?P<id>[0-9]+)'
+
+ _TESTS = [{
+ 'url': 'https://www.trtworld.com/vi... | yt_dlp/extractor/trtworld.py | 26 | Python | 0.857 | refactor | 584 | 28 | 51 | false | TrtWorld add extractor | 8,701 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | ufukk |
from .common import InfoExtractor, ExtractorError, url_or_none
from ..utils import (
parse_iso8601,
traverse_obj,
)
class TrtWorldIE(InfoExtractor):
_VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.trtworld.com/video/news/turkiye-swit... | ```suggestion
from .common import InfoExtractor
from ..utils import ExtractorError, parse_iso8601, url_or_none
from ..utils.traversal import traverse_obj
``` | from .common import InfoExtractor
from ..utils import ExtractorError, determine_ext, parse_iso8601, url_or_none
from ..utils.traversal import traverse_obj
class TrtWorldIE(InfoExtractor):
_VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.trtwo... | @@ -0,0 +1,107 @@
+from .common import InfoExtractor, ExtractorError, url_or_none
+from ..utils import (
+ parse_iso8601,
+ traverse_obj,
+) | yt_dlp/extractor/trtworld.py | 5 | Python | 0.929 | refactor | 161 | 30 | 30 | false | TrtWorld add extractor | 8,701 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | ufukk |
from .common import InfoExtractor, ExtractorError, url_or_none
from ..utils import (
parse_iso8601,
traverse_obj,
)
class TrtWorldIE(InfoExtractor):
_VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.trtworld.com/video/news/turkiye-swit... | Should be md5:
```suggestion
'description': 'md5:0a975c04257fb529c8f99c7b76a2cf12',
``` | from .common import InfoExtractor
from ..utils import ExtractorError, determine_ext, parse_iso8601, url_or_none
from ..utils.traversal import traverse_obj
class TrtWorldIE(InfoExtractor):
_VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.trtwo... | @@ -0,0 +1,107 @@
+from .common import InfoExtractor, ExtractorError, url_or_none
+from ..utils import (
+ parse_iso8601,
+ traverse_obj,
+)
+
+
+class TrtWorldIE(InfoExtractor):
+ _VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
+
+ _TESTS = [{
+ 'url': 'https://www.trtwor... | yt_dlp/extractor/trtworld.py | 20 | Python | 0.786 | suggestion | 102 | 45 | 45 | false | TrtWorld add extractor | 8,701 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | ufukk |
class TrtWorldIE(InfoExtractor):
_VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.trtworld.com/video/news/turkiye-switches-to-sustainable-tourism-16067690',
'info_dict': {
'id': '16067690',
'ext': 'mp4',
... | ```suggestion
'description': 'md5:4050e21570cc3c40b6c9badae800a94f',
``` | class TrtWorldIE(InfoExtractor):
_VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
_TESTS = [{
'url': 'https://www.trtworld.com/video/news/turkiye-switches-to-sustainable-tourism-16067690',
'info_dict': {
'id': '16067690',
'ext': 'mp4',
... | @@ -0,0 +1,107 @@
+from .common import InfoExtractor, ExtractorError, url_or_none
+from ..utils import (
+ parse_iso8601,
+ traverse_obj,
+)
+
+
+class TrtWorldIE(InfoExtractor):
+ _VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
+
+ _TESTS = [{
+ 'url': 'https://www.trtwor... | yt_dlp/extractor/trtworld.py | 26 | Python | 0.571 | suggestion | 86 | 51 | 51 | false | TrtWorld add extractor | 8,701 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | ufukk |
}, {
'url': 'https://www.trtworld.com/video/africa-matters/locals-learning-to-cope-with-rising-tides-of-kenyas-great-lakes-16059545',
'info_dict': {
'id': 'zEns2dWl00w',
'ext': 'mp4',
'title': "Locals learning to cope with rising tides of Kenya's Great Lakes",
... | Should be single quotes
```suggestion
'thumbnail': 'https://i.ytimg.com/vi/zEns2dWl00w/maxresdefault.jpg',
'description': 'md5:3ad9d7c5234d752a4ead4340c79c6b8d',
'channel_id': 'UC7fWeaHhqgM4Ry-RMpM2YYw',
'channel_url': 'https://www.youtube.com/channel/UC7fWeaHhqgM4Ry... | 'info_dict': {
'id': 'zEns2dWl00w',
'ext': 'mp4',
'title': "Locals learning to cope with rising tides of Kenya's Great Lakes",
'thumbnail': 'https://i.ytimg.com/vi/zEns2dWl00w/maxresdefault.jpg',
'description': 'md5:3ad9d7c5234d752a4ead4340c79c6b8d',
... | @@ -0,0 +1,107 @@
+from .common import InfoExtractor, ExtractorError, url_or_none
+from ..utils import (
+ parse_iso8601,
+ traverse_obj,
+)
+
+
+class TrtWorldIE(InfoExtractor):
+ _VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
+
+ _TESTS = [{
+ 'url': 'https://www.trtwor... | yt_dlp/extractor/trtworld.py | 26 | Python | 0.857 | suggestion | 897 | 51 | 51 | false | TrtWorld add extractor | 8,701 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | ufukk |
"thumbnail": "https://i.ytimg.com/vi/zEns2dWl00w/maxresdefault.jpg",
"description": "The great lakes of Kenya are a major tourist attraction, and support the livelihoods of millions of residents. But in recent years, their levels have been steadily rising, wreaking havoc. \n\nAlexandria Majalla ... | Like count is int
```suggestion
'like_count': int,
``` | 'channel_id': 'UC7fWeaHhqgM4Ry-RMpM2YYw',
'channel_url': 'https://www.youtube.com/channel/UC7fWeaHhqgM4Ry-RMpM2YYw',
'duration': 210,
'view_count': int,
'age_limit': 0,
'webpage_url': 'https://www.youtube.com/watch?v=zEns2dWl00w',
'cate... | @@ -0,0 +1,107 @@
+from .common import InfoExtractor, ExtractorError, url_or_none
+from ..utils import (
+ parse_iso8601,
+ traverse_obj,
+)
+
+
+class TrtWorldIE(InfoExtractor):
+ _VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
+
+ _TESTS = [{
+ 'url': 'https://www.trtwor... | yt_dlp/extractor/trtworld.py | 26 | Python | 0.571 | suggestion | 69 | 51 | 51 | false | TrtWorld add extractor | 8,701 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | ufukk |
'webpage_url': 'https://www.youtube.com/watch?v=zEns2dWl00w',
'categories': ['News & Politics'],
'channel': 'TRT World',
'channel_follower_count': int,
'channel_is_verified': True,
'uploader': 'TRT World',
'uploader_id': '@trtworld',
... | ```suggestion
# NB: Website sometimes serves mp4 files under `hls_url` key
``` | 'webpage_url': 'https://www.youtube.com/watch?v=zEns2dWl00w',
'categories': ['News & Politics'],
'channel': 'TRT World',
'channel_follower_count': int,
'channel_is_verified': True,
'uploader': 'TRT World',
'uploader_id': '@trtworld',
... | @@ -0,0 +1,101 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, parse_iso8601, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class TrtWorldIE(InfoExtractor):
+ _VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
+
+ _TESTS = [{
+ 'url': 'http... | yt_dlp/extractor/trtworld.py | 26 | Python | 0.571 | suggestion | 92 | 49 | 49 | false | TrtWorld add extractor | 8,701 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | ufukk |
'categories': ['News & Politics'],
'channel': 'TRT World',
'channel_follower_count': int,
'channel_is_verified': True,
'uploader': 'TRT World',
'uploader_id': '@trtworld',
'uploader_url': 'https://www.youtube.com/@trtworld',
... | better to use `determine_ext` here (import from utils)
```suggestion
if determine_ext(media_url) == 'm3u8':
``` | 'categories': ['News & Politics'],
'channel': 'TRT World',
'channel_follower_count': int,
'channel_is_verified': True,
'uploader': 'TRT World',
'uploader_id': '@trtworld',
'uploader_url': 'https://www.youtube.com/@trtworld',
... | @@ -0,0 +1,101 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, parse_iso8601, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class TrtWorldIE(InfoExtractor):
+ _VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
+
+ _TESTS = [{
+ 'url': 'http... | yt_dlp/extractor/trtworld.py | 26 | Python | 0.786 | suggestion | 126 | 48 | 48 | false | TrtWorld add extractor | 8,701 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | ufukk |
def _real_extract(self, url):
display_id = self._match_id(url)
webpage = self._download_webpage(url, display_id)
nuxtjs_data = self._search_nuxt_data(webpage, display_id)['videoData']['content']
formats = []
for media_url in traverse_obj(nuxtjs_data, (
'platfo... | I would probably add a `{str}` just to be safe
```suggestion
'title': ('fields', 'title', 'text', {str}),
'description': ('fields', 'description', 'text', {str}),
``` | def _real_extract(self, url):
display_id = self._match_id(url)
webpage = self._download_webpage(url, display_id)
nuxtjs_data = self._search_nuxt_data(webpage, display_id)['videoData']['content']['platforms']
formats = []
for media_url in traverse_obj(nuxtjs_data, (
... | @@ -0,0 +1,101 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, parse_iso8601, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class TrtWorldIE(InfoExtractor):
+ _VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
+
+ _TESTS = [{
+ 'url': 'http... | yt_dlp/extractor/trtworld.py | 26 | Python | 0.786 | suggestion | 202 | 31 | 31 | false | TrtWorld add extractor | 8,701 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | ufukk |
'channel_url': 'https://www.youtube.com/channel/UC7fWeaHhqgM4Ry-RMpM2YYw',
'duration': 210,
'view_count': int,
'age_limit': 0,
'webpage_url': 'https://www.youtube.com/watch?v=zEns2dWl00w',
'categories': ['News & Politics'],
'channel': '... | Maybe this should also include `'platforms'` as we only ever access that later on?
```suggestion
nuxtjs_data = self._search_nuxt_data(webpage, display_id)['videoData']['content']['platforms']
``` | 'channel_url': 'https://www.youtube.com/channel/UC7fWeaHhqgM4Ry-RMpM2YYw',
'duration': 210,
'view_count': int,
'age_limit': 0,
'webpage_url': 'https://www.youtube.com/watch?v=zEns2dWl00w',
'categories': ['News & Politics'],
'channel': '... | @@ -0,0 +1,101 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, parse_iso8601, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class TrtWorldIE(InfoExtractor):
+ _VALID_URL = r'https?://www\.trtworld\.com/video/[\w-]+/[\w-]+-(?P<id>\d+)'
+
+ _TESTS = [{
+ 'url': 'http... | yt_dlp/extractor/trtworld.py | 26 | Python | 0.857 | suggestion | 206 | 51 | 51 | false | TrtWorld add extractor | 8,701 | yt-dlp/yt-dlp | 132,642 | Python | Grub4K | ufukk |
return subtitles
def _perform_login(self, username, password):
try:
access_token = (self._download_json(
self._API_BASE_URL + 'authentication/login', None,
'Logging in', self._LOGIN_ERR_MESSAGE, fatal=False,
data=urlencode_postdata({
... | Don't add this to _HEADERS. The same IE class is used for multiple URLs. Just add the header locally to relevant calls | ssa += os.linesep + 'Dialogue: Marked=0,%s,%s,Default,,0,0,0,,%s%s' % (
ass_subtitles_timecode(start),
ass_subtitles_timecode(end),
'{\\a%d}' % alignment if alignment != 2 else '',
text.replace('\n', '\\N').replace('<i>', '{... | @@ -147,6 +158,8 @@ def _perform_login(self, username, password):
self.report_warning(message or self._LOGIN_ERR_MESSAGE)
def _real_extract(self, url):
+ if 'network.de' in url:
+ self._HEADERS['X-Target-Distribution'] = 'de' | yt_dlp/extractor/adn.py | 26 | Python | 0.429 | suggestion | 118 | 51 | 51 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | infanf |
'id': '9841',
'ext': 'mp4',
'title': 'Fruits Basket - Episode 1',
'description': 'md5:14be2f72c3c96809b0ca424b0097d336',
'series': 'Fruits Basket',
'duration': 1437,
'release_date': '20190405',
'comment_count': int,
... | Did you mean
```suggestion
'skip': 'Only available in Germany',
``` | _PLAYER_BASE_URL = f'{_API_BASE_URL}player/'
_HEADERS = {}
_LOGIN_ERR_MESSAGE = 'Unable to log in'
_RSA_KEY = (0x9B42B08905199A5CCE2026274399CA560ECB209EE9878A708B1C0812E1BB8CB5D1FB7441861147C1A1F2F3A0476DD63A9CAC20D3E983613346850AA6CB38F16DC7D720FD7D86FC6E5B3D5BBC72E14CD0BF9E869F2CEA2CCAD648F1DCE38F1FF... | @@ -49,6 +49,15 @@ class ADNIE(InfoExtractor):
}, {
'url': 'http://animedigitalnetwork.fr/video/blue-exorcist-kyoto-saga/7778-episode-1-debut-des-hostilites',
'only_matching': True,
+ }, {
+ 'url': 'https://animationdigitalnetwork.de/video/tokyo-mew-mew-new/19818-folge-1',
+ 'inf... | yt_dlp/extractor/adn.py | 26 | Python | 0.571 | suggestion | 80 | 51 | 51 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | infanf |
'id': '9841',
'ext': 'mp4',
'title': 'Fruits Basket - Episode 1',
'description': 'md5:14be2f72c3c96809b0ca424b0097d336',
'series': 'Fruits Basket',
'duration': 1437,
'release_date': '20190405',
'comment_count': int,
... | Try running the test locally after commenting out `skip` | _PLAYER_BASE_URL = f'{_API_BASE_URL}player/'
_HEADERS = {}
_LOGIN_ERR_MESSAGE = 'Unable to log in'
_RSA_KEY = (0x9B42B08905199A5CCE2026274399CA560ECB209EE9878A708B1C0812E1BB8CB5D1FB7441861147C1A1F2F3A0476DD63A9CAC20D3E983613346850AA6CB38F16DC7D720FD7D86FC6E5B3D5BBC72E14CD0BF9E869F2CEA2CCAD648F1DCE38F1FF... | @@ -49,6 +49,15 @@ class ADNIE(InfoExtractor):
}, {
'url': 'http://animedigitalnetwork.fr/video/blue-exorcist-kyoto-saga/7778-episode-1-debut-des-hostilites',
'only_matching': True,
+ }, {
+ 'url': 'https://animationdigitalnetwork.de/video/tokyo-mew-mew-new/19818-folge-1',
+ 'inf... | yt_dlp/extractor/adn.py | 26 | Python | 0.357 | suggestion | 56 | 51 | 51 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | infanf |
for sub_lang, sub in subtitles_json.items():
ssa = '''[Script Info]
ScriptType:V4.00
[V4 Styles]
Format: Name,Fontname,Fontsize,PrimaryColour,SecondaryColour,TertiaryColour,BackColour,Bold,Italic,BorderStyle,Outline,Shadow,Alignment,MarginL,MarginR,MarginV,AlphaLevel,Encoding
Style: Default,Arial,18... | ```suggestion
elif sub_lang == 'vostde':
``` | if subtitle_location:
enc_subtitles = self._download_webpage(
subtitle_location, video_id, 'Downloading subtitles data',
fatal=False, headers={'Origin': 'https://' + self._BASE})
if not enc_subtitles:
return None
# http://animationdigitaln... | @@ -116,6 +125,8 @@ def _get_subtitles(self, sub_url, video_id):
if sub_lang == 'vostf':
sub_lang = 'fr'
+ if sub_lang == 'vostde': | yt_dlp/extractor/adn.py | 26 | Python | 0.571 | suggestion | 58 | 51 | 51 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | infanf |
formats.extend(m3u8_formats)
video = (self._download_json(
self._API_BASE_URL + 'video/%s' % video_id, video_id,
'Downloading additional video metadata', fatal=False) or {}).get('video') or {}
show = video.get('show') or {}
return {
'id': vid... | Subclassing from another concrete extractor invites so many unexpected bugs. Create a `ADNBaseIE` with common methods from which both can be derived | m3u8_url, video_id, 'mp4', 'm3u8_native',
m3u8_id=format_id, fatal=False)
if format_id == 'vf':
for f in m3u8_formats:
f['language'] = 'fr'
elif format_id == 'vde':
for f in m3u8_forma... | @@ -255,3 +280,44 @@ def _real_extract(self, url):
'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
'comment_count': int_or_none(video.get('commentsCount')),
}
+
+
+class ADNSeasonIE(ADNIE): | yt_dlp/extractor/adn.py | 26 | Python | 0.714 | bug | 148 | 51 | 51 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | infanf |
class ADNBaseIE(InfoExtractor):
IE_DESC = 'Animation Digital Network'
_NETRC_MACHINE = 'animationdigitalnetwork'
_BASE = 'animationdigitalnetwork.fr'
_API_BASE_URL = 'https://gw.api.' + _BASE + '/'
_PLAYER_BASE_URL = _API_BASE_URL + 'player/'
_HEADERS = {}
_LOGIN_ERR_MESSAGE = 'Unable to log... | I would just add an additional capture group
```suggestion
_VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digitalnetwork\.(?P<lang>fr|de)/video/[^/]+/(?P<id>\d+)'
```
You can then use
```python
lang, video_id = self._match_valid_url(url).group('lang', 'id')
```
instead of `_get_distribution_language... |
class ADNBaseIE(InfoExtractor):
IE_DESC = 'Animation Digital Network'
_NETRC_MACHINE = 'animationdigitalnetwork'
_BASE = 'animationdigitalnetwork.fr'
_API_BASE_URL = f'https://gw.api.{_BASE}/'
_PLAYER_BASE_URL = f'{_API_BASE_URL}player/'
_HEADERS = {}
_LOGIN_ERR_MESSAGE = 'Unable to log in... | @@ -25,9 +25,32 @@
)
-class ADNIE(InfoExtractor):
+class ADNBaseIE(InfoExtractor):
IE_DESC = 'Animation Digital Network'
- _VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digitalnetwork\.fr/video/[^/]+/(?P<id>\d+)'
+ _NETRC_MACHINE = 'animationdigitalnetwork'
+ _BASE = 'animationdigitalnetwork.f... | yt_dlp/extractor/adn.py | 26 | Python | 0.857 | suggestion | 355 | 51 | 51 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | infanf |
'duration': int_or_none(video_info.get('duration') or video.get('duration')),
'release_date': unified_strdate(video.get('releaseDate')),
'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
'comment_count': int_or_none(video.get('commentsCount')),
... | Use f-strings and inline single use variables
```suggestion
show = self._download_json(
f'{self._API_BASE_URL}show/{video_show_slug}/', video_show_slug,
'Downloading show JSON metadata', headers=self._HEADERS)['show']
``` | 'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
'comment_count': int_or_none(video.get('commentsCount')),
}
class ADNSeasonIE(ADNBaseIE):
_VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digitalnetwork\.(?P<lang>fr|de)/video/(?P<id>[^/?#]+)/?(?:$|[#... | @@ -255,3 +290,42 @@ def _real_extract(self, url):
'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
'comment_count': int_or_none(video.get('commentsCount')),
}
+
+
+class ADNSeasonIE(ADNBaseIE):
+ _VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digi... | yt_dlp/extractor/adn.py | 26 | Python | 0.857 | suggestion | 258 | 45 | 41 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | infanf |
class ADNSeasonIE(ADNBaseIE):
_VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digitalnetwork\.(fr|de)/video/(?P<id>[^/]+)/?$'
_TESTS = [{
'url': 'https://animationdigitalnetwork.fr/video/tokyo-mew-mew-new',
'playlist_count': 12,
'info_dict': {
'id': 911,
'tit... | Use f-string.
This API request does not require the use of `self._HEADERS`? | _TESTS = [{
'url': 'https://animationdigitalnetwork.fr/video/tokyo-mew-mew-new',
'playlist_count': 12,
'info_dict': {
'id': '911',
'title': 'Tokyo Mew Mew New',
},
# 'skip': 'Only available in French end German speaking Europe',
}]
def _real_e... | @@ -255,3 +290,42 @@ def _real_extract(self, url):
'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
'comment_count': int_or_none(video.get('commentsCount')),
}
+
+
+class ADNSeasonIE(ADNBaseIE):
+ _VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digi... | yt_dlp/extractor/adn.py | 26 | Python | 0.429 | question | 76 | 38 | 34 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | infanf |
}]
def _real_extract(self, url):
video_show_slug = self._match_id(url)
video_base_url = self._API_BASE_URL + 'show/%s/' % video_show_slug
show = self._download_json(
video_base_url, video_show_slug,
'Downloading show JSON metadata',
headers=self._HEAD... | ```suggestion
for episode_id in traverse_obj(episodes, ('videos', ..., 'id', {str})):
entries.append(self.url_result(
f'https://animationdigitalnetwork.{lang}/video/{video_show_slug}/{episode_id}',
ADNIE, episode_id))
```
Add `from ..utils.traversal import trave... | import base64
import binascii
import json
import os
import random
from .common import InfoExtractor
from ..aes import aes_cbc_decrypt_bytes, unpad_pkcs7
from ..compat import compat_b64decode
from ..networking.exceptions import HTTPError
from ..utils import (
ass_subtitles_timecode,
bytes_to_intlist,
bytes_... | @@ -255,3 +290,42 @@ def _real_extract(self, url):
'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
'comment_count': int_or_none(video.get('commentsCount')),
}
+
+
+class ADNSeasonIE(ADNBaseIE):
+ _VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digi... | yt_dlp/extractor/adn.py | 26 | Python | 0.786 | suggestion | 344 | 28 | 328 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | infanf |
def _real_extract(self, url):
video_show_slug = self._match_id(url)
video_base_url = self._API_BASE_URL + 'show/%s/' % video_show_slug
show = self._download_json(
video_base_url, video_show_slug,
'Downloading show JSON metadata',
headers=self._HEADERS)['s... | Title should be non fatal
```suggestion
return self.playlist_result(entries, show_id, show.get('title'))
``` | import base64
import binascii
import json
import os
import random
from .common import InfoExtractor
from ..aes import aes_cbc_decrypt_bytes, unpad_pkcs7
from ..compat import compat_b64decode
from ..networking.exceptions import HTTPError
from ..utils import (
ass_subtitles_timecode,
bytes_to_intlist,
bytes_... | @@ -255,3 +290,42 @@ def _real_extract(self, url):
'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
'comment_count': int_or_none(video.get('commentsCount')),
}
+
+
+class ADNSeasonIE(ADNBaseIE):
+ _VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digi... | yt_dlp/extractor/adn.py | 26 | Python | 0.786 | suggestion | 119 | 27 | 328 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | infanf |
'season_number': int_or_none(video.get('season')),
'duration': int_or_none(video_info.get('duration') or video.get('duration')),
'release_date': unified_strdate(video.get('releaseDate')),
'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
... | ```suggestion
show_id = str(show['id'])
``` | 'season_number': int_or_none(video.get('season')),
'duration': int_or_none(video_info.get('duration') or video.get('duration')),
'release_date': unified_strdate(video.get('releaseDate')),
'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
... | @@ -255,3 +288,38 @@ def _real_extract(self, url):
'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
'comment_count': int_or_none(video.get('commentsCount')),
}
+
+
+class ADNSeasonIE(ADNBaseIE):
+ _VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digi... | yt_dlp/extractor/adn.py | 26 | Python | 0.571 | suggestion | 53 | 42 | 44 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | infanf |
return {
'id': video_id,
'title': title,
'description': strip_or_none(metas.get('summary') or video.get('summary')),
'thumbnail': video_info.get('image') or player.get('image'),
'formats': formats,
'subtitles': self.extract_subtitles(sub_u... | ```suggestion
'id': '911',
``` |
return {
'id': video_id,
'title': title,
'description': strip_or_none(metas.get('summary') or video.get('summary')),
'thumbnail': video_info.get('image') or player.get('image'),
'formats': formats,
'subtitles': self.extract_subtitles(sub_u... | @@ -255,3 +288,38 @@ def _real_extract(self, url):
'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
'comment_count': int_or_none(video.get('commentsCount')),
}
+
+
+class ADNSeasonIE(ADNBaseIE):
+ _VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digi... | yt_dlp/extractor/adn.py | 26 | Python | 0.429 | suggestion | 44 | 51 | 51 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | infanf |
video = (self._download_json(
self._API_BASE_URL + 'video/%s' % video_id, video_id,
'Downloading additional video metadata', fatal=False) or {}).get('video') or {}
show = video.get('show') or {}
return {
'id': video_id,
'title': title,
... | ```suggestion
_VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digitalnetwork\.(?P<lang>fr|de)/video/(?P<id>[^/]+)/?(?:$|[#?])'
``` |
video = (self._download_json(
self._API_BASE_URL + 'video/%s' % video_id, video_id,
'Downloading additional video metadata', fatal=False) or {}).get('video') or {}
show = video.get('show') or {}
return {
'id': video_id,
'title': title,
... | @@ -255,3 +288,38 @@ def _real_extract(self, url):
'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
'comment_count': int_or_none(video.get('commentsCount')),
}
+
+
+class ADNSeasonIE(ADNBaseIE):
+ _VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digi... | yt_dlp/extractor/adn.py | 26 | Python | 0.714 | suggestion | 141 | 51 | 51 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | infanf |
unified_strdate,
urlencode_postdata,
)
class ADNBaseIE(InfoExtractor):
IE_DESC = 'Animation Digital Network'
_NETRC_MACHINE = 'animationdigitalnetwork'
_BASE = 'animationdigitalnetwork.fr'
_API_BASE_URL = 'https://gw.api.' + _BASE + '/'
_PLAYER_BASE_URL = _API_BASE_URL + 'player/'
_HEA... | ```suggestion
_VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digitalnetwork\.(?P<lang>fr|de)/video/[^/?#]+/(?P<id>\d+)'
``` | urlencode_postdata,
)
from ..utils.traversal import traverse_obj
class ADNBaseIE(InfoExtractor):
IE_DESC = 'Animation Digital Network'
_NETRC_MACHINE = 'animationdigitalnetwork'
_BASE = 'animationdigitalnetwork.fr'
_API_BASE_URL = f'https://gw.api.{_BASE}/'
_PLAYER_BASE_URL = f'{_API_BASE_URL}... | @@ -19,15 +20,34 @@
long_to_bytes,
pkcs1pad,
strip_or_none,
+ str_or_none,
try_get,
unified_strdate,
urlencode_postdata,
)
-class ADNIE(InfoExtractor):
+class ADNBaseIE(InfoExtractor):
IE_DESC = 'Animation Digital Network'
- _VALID_URL = r'https?://(?:www\.)?(?:animation|an... | yt_dlp/extractor/adn.py | 26 | Python | 0.714 | suggestion | 135 | 51 | 51 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | infanf |
video = (self._download_json(
self._API_BASE_URL + 'video/%s' % video_id, video_id,
'Downloading additional video metadata', fatal=False) or {}).get('video') or {}
show = video.get('show') or {}
return {
'id': video_id,
'title': title,
... | ```suggestion
_VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digitalnetwork\.(?P<lang>fr|de)/video/(?P<id>[^/?#]+)/?(?:$|[#?])'
``` |
video = (self._download_json(
self._API_BASE_URL + 'video/%s' % video_id, video_id,
'Downloading additional video metadata', fatal=False) or {}).get('video') or {}
show = video.get('show') or {}
return {
'id': video_id,
'title': title,
... | @@ -255,3 +288,38 @@ def _real_extract(self, url):
'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
'comment_count': int_or_none(video.get('commentsCount')),
}
+
+
+class ADNSeasonIE(ADNBaseIE):
+ _VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digi... | yt_dlp/extractor/adn.py | 26 | Python | 0.714 | suggestion | 143 | 51 | 51 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | infanf |
'title': 'Tokyo Mew Mew New',
},
# 'skip': 'Only available in French end German speaking Europe',
}]
def _real_extract(self, url):
lang, video_show_slug = self._match_valid_url(url).group('lang', 'id')
show = self._download_json(
f'{self._API_BASE_URL}sho... | ```suggestion
})
def entries():
for episode_id in traverse_obj(episodes, ('videos', ..., 'id', {str_or_none})):
yield self.url_result(
f'https://animationdigitalnetwork.{lang}/video/{video_show_slug}/{episode_id}',
ADNIE, ep... | 'title': 'Tokyo Mew Mew New',
},
# 'skip': 'Only available in French end German speaking Europe',
}]
def _real_extract(self, url):
lang, video_show_slug = self._match_valid_url(url).group('lang', 'id')
show = self._download_json(
f'{self._API_BASE_URL}sho... | @@ -255,3 +288,38 @@ def _real_extract(self, url):
'average_rating': float_or_none(video.get('rating') or metas.get('rating')),
'comment_count': int_or_none(video.get('commentsCount')),
}
+
+
+class ADNSeasonIE(ADNBaseIE):
+ _VALID_URL = r'https?://(?:www\.)?(?:animation|anime)digi... | yt_dlp/extractor/adn.py | 26 | Python | 0.786 | suggestion | 412 | 27 | 29 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | infanf |
from ..networking.exceptions import HTTPError
from ..utils.traversal import traverse_obj
from ..utils import (
ass_subtitles_timecode,
bytes_to_intlist,
bytes_to_long,
ExtractorError,
float_or_none,
int_or_none,
intlist_to_bytes,
long_to_bytes,
pkcs1pad,
strip_or_none,
str_or... | ```suggestion
_API_BASE_URL = f'https://gw.api.{_BASE}/'
_PLAYER_BASE_URL = f'{_API_BASE_URL}player/'
``` | from ..networking.exceptions import HTTPError
from ..utils import (
ass_subtitles_timecode,
bytes_to_intlist,
bytes_to_long,
ExtractorError,
float_or_none,
int_or_none,
intlist_to_bytes,
long_to_bytes,
pkcs1pad,
strip_or_none,
str_or_none,
try_get,
unified_strdate,
... | @@ -19,15 +20,34 @@
long_to_bytes,
pkcs1pad,
strip_or_none,
+ str_or_none,
try_get,
unified_strdate,
urlencode_postdata,
)
-class ADNIE(InfoExtractor):
+class ADNBaseIE(InfoExtractor):
IE_DESC = 'Animation Digital Network'
- _VALID_URL = r'https?://(?:www\.)?(?:animation|an... | yt_dlp/extractor/adn.py | 26 | Python | 0.714 | suggestion | 116 | 51 | 51 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | infanf |
import os
import random
from .common import InfoExtractor
from ..aes import aes_cbc_decrypt_bytes, unpad_pkcs7
from ..compat import compat_b64decode
from ..networking.exceptions import HTTPError
from ..utils.traversal import traverse_obj
from ..utils import (
ass_subtitles_timecode,
bytes_to_intlist,
bytes... | ```suggestion
)
from ..utils.traversal import traverse_obj
``` | import os
import random
from .common import InfoExtractor
from ..aes import aes_cbc_decrypt_bytes, unpad_pkcs7
from ..compat import compat_b64decode
from ..networking.exceptions import HTTPError
from ..utils import (
ass_subtitles_timecode,
bytes_to_intlist,
bytes_to_long,
ExtractorError,
float_or_... | @@ -19,15 +20,34 @@
long_to_bytes,
pkcs1pad,
strip_or_none,
+ str_or_none,
try_get,
unified_strdate,
urlencode_postdata,
)
| yt_dlp/extractor/adn.py | 26 | Python | 0.571 | suggestion | 67 | 51 | 51 | false | feat(ADN): Add German variant and season downloads | 8,708 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | infanf |
import argparse
import os
import re
import subprocess
import sys
from pathlib import Path
IE_TEST_PATTERN = re.compile(r'IE(_all|_\d+)?$')
def parse_args():
parser = argparse.ArgumentParser(description='Run selected yt-dlp tests')
parser.add_argument(
'test', help='An extractor test, or one of "test... | ```suggestion
'test', help='An extractor test, or one "core" or "download"', nargs='*')
``` | #!/usr/bin/env python3
import argparse
import functools
import os
import re
import subprocess
import sys
from pathlib import Path
fix_test_name = functools.partial(re.compile(r'IE(_all|_\d+)?$').sub, r'\1')
def parse_args():
parser = argparse.ArgumentParser(description='Run selected yt-dlp tests')
parser.a... | @@ -0,0 +1,49 @@
+import argparse
+import os
+import re
+import subprocess
+import sys
+from pathlib import Path
+
+
+IE_TEST_PATTERN = re.compile(r'IE(_all|_\d+)?$')
+
+
+def parse_args():
+ parser = argparse.ArgumentParser(description='Run selected yt-dlp tests')
+ parser.add_argument(
+ 'test', help='An... | devscripts/run_tests.py | 15 | Python | 0.786 | refactor | 101 | 40 | 40 | false | Create `run_tests.py` | 8,720 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Grub4K |
import argparse
import os
import re
import subprocess
import sys
from pathlib import Path
IE_TEST_PATTERN = re.compile(r'IE(_all|_\d+)?$')
def parse_args():
parser = argparse.ArgumentParser(description='Run selected yt-dlp tests')
parser.add_argument(
'test', help='An extractor test, or one "core" o... | ```suggestion
'test', help='An extractor test, or one of "core" or "download"', nargs='*')
``` | #!/usr/bin/env python3
import argparse
import functools
import os
import re
import subprocess
import sys
from pathlib import Path
fix_test_name = functools.partial(re.compile(r'IE(_all|_\d+)?$').sub, r'\1')
def parse_args():
parser = argparse.ArgumentParser(description='Run selected yt-dlp tests')
parser.a... | @@ -0,0 +1,49 @@
+import argparse
+import os
+import re
+import subprocess
+import sys
+from pathlib import Path
+
+
+IE_TEST_PATTERN = re.compile(r'IE(_all|_\d+)?$')
+
+
+def parse_args():
+ parser = argparse.ArgumentParser(description='Run selected yt-dlp tests')
+ parser.add_argument(
+ 'test', help='An... | devscripts/run_tests.py | 15 | Python | 0.786 | refactor | 104 | 40 | 40 | false | Create `run_tests.py` | 8,720 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | Grub4K |
#!/usr/bin/env python3
import argparse
import functools
import os
import re
import subprocess
import sys
from pathlib import Path
IE_TEST_PATTERN = re.compile(r'IE(_all|_\d+)?$')
fix_test_name = functools.partial(IE_TEST_PATTERN.sub, r'\1')
def parse_args():
parser = argparse.ArgumentParser(description='Run se... | ```suggestion
fix_test_name = functools.partial(re.compile(r'IE(_all|_\d+)?$').sub, r'\1')
```
nitpick | #!/usr/bin/env python3
import argparse
import functools
import os
import re
import subprocess
import sys
from pathlib import Path
fix_test_name = functools.partial(re.compile(r'IE(_all|_\d+)?$').sub, r'\1')
def parse_args():
parser = argparse.ArgumentParser(description='Run selected yt-dlp tests')
parser.a... | @@ -0,0 +1,68 @@
+#!/usr/bin/env python3
+
+import argparse
+import functools
+import os
+import re
+import subprocess
+import sys
+from pathlib import Path
+
+
+IE_TEST_PATTERN = re.compile(r'IE(_all|_\d+)?$')
+fix_test_name = functools.partial(IE_TEST_PATTERN.sub, r'\1') | devscripts/run_tests.py | 13 | Python | 0.714 | suggestion | 105 | 38 | 38 | false | Create `run_tests.py` | 8,720 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Grub4K |
#!/usr/bin/env sh
>&2 echo 'run_tests.sh is deprecated. Please use `devscripts/run_tests.py` instead'
python3 -Werror devscripts/run_tests.py "$1"
| Would it be possible to force `-bb -Werror` in run_tests.py?
PS: Maybe not -bb, but -Werror is definitely possible | #!/usr/bin/env sh
>&2 echo 'run_tests.sh is deprecated. Please use `devscripts/run_tests.py` instead'
python3 devscripts/run_tests.py "$1"
| @@ -1,14 +1,4 @@
#!/usr/bin/env sh
-if [ -z "$1" ]; then
- test_set='test'
-elif [ "$1" = 'core' ]; then
- test_set="-m not download"
-elif [ "$1" = 'download' ]; then
- test_set="-m download"
-else
- echo 'Invalid test type "'"$1"'". Use "core" | "download"'
- exit 1
-fi
-
-python3 -bb -Werror -m pyt... | devscripts/run_tests.sh | 5 | Shell | 0.643 | question | 117 | 5 | 5 | false | Create `run_tests.py` | 8,720 | yt-dlp/yt-dlp | 132,642 | Python | pukkandan | Grub4K |
import functools
from .common import InfoExtractor
from ..utils import (
ExtractorError,
str_or_none,
traverse_obj,
url_or_none,
urljoin,
)
class AsobiStageIE(InfoExtractor):
IE_DESC = 'ASOBISTAGE (アソビステージ)'
_VALID_URL = r'https://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>\w+)/... | nitpick
```suggestion
from ..utils import ExtractorError, str_or_none, url_or_none, urljoin
from ..utils.traversal import traverse_obj
``` | import functools
from .common import InfoExtractor
from ..utils import str_or_none, url_or_none
from ..utils.traversal import traverse_obj
class AsobiStageIE(InfoExtractor):
IE_DESC = 'ASOBISTAGE (アソビステージ)'
_VALID_URL = r'https?://asobistage\.asobistore\.jp/event/(?P<id>(?P<event>\w+)/(?P<type>archive|player... | @@ -0,0 +1,160 @@
+import functools
+
+from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ str_or_none,
+ traverse_obj,
+ url_or_none,
+ urljoin,
+) | yt_dlp/extractor/asobistage.py | 10 | Python | 0.929 | refactor | 142 | 35 | 35 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | pzhlkj6612 |
'url': 'https://asobistage.asobistore.jp/event/idolmaster_idolworld2023_goods/archive/live',
'info_dict': {
'id': 'idolmaster_idolworld2023_goods/archive/live/3aef7110',
'title': 'asobistore_station_1020_serverREC',
'live_status': 'was_live',
'thumbnail': ... | `metadata_available=False` is the default
```suggestion
self.raise_login_required()
``` | 'info_dict': {
'id': 'idolmaster_idolworld2023_goods/archive/live',
'title': 'md5:378510b6e830129d505885908bd6c576',
'thumbnail': r're:^https?://[\w.-]+/\w+/\w+',
},
'playlist_count': 1,
'playlist': [{
'info_dict': {
'id': '... | @@ -0,0 +1,160 @@
+import functools
+
+from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ str_or_none,
+ traverse_obj,
+ url_or_none,
+ urljoin,
+)
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https://asobistage\.asobistore\.j... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.714 | suggestion | 102 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | pzhlkj6612 |
'id': 'idolmaster_idolworld2023_goods/archive/live/3aef7110',
'title': 'asobistore_station_1020_serverREC',
'live_status': 'was_live',
'thumbnail': r're:^https?://[\w.-]+/\w+/\w+',
},
'params': {
'skip_download': True,
'ignore_no_fo... | ```suggestion
raise ExtractorError(f'Unknown error: {error!r}')
``` | 'title': 'md5:378510b6e830129d505885908bd6c576',
'thumbnail': r're:^https?://[\w.-]+/\w+/\w+',
},
'playlist_count': 1,
'playlist': [{
'info_dict': {
'id': '3aef7110',
'ext': 'mp4',
'title': 'asobistore_station_10... | @@ -0,0 +1,160 @@
+import functools
+
+from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ str_or_none,
+ traverse_obj,
+ url_or_none,
+ urljoin,
+)
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https://asobistage\.asobistore\.j... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.786 | refactor | 81 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | pzhlkj6612 |
'skip_download': True,
'ignore_no_formats_error': True,
},
}, {
'url': 'https://asobistage.asobistore.jp/event/ijigenfes_utagassen/player/day1',
'only_matching': True,
}]
def _check_login(self, video_id):
check_login_json = self._download_json(
... | Can just use `_download_json`
```suggestion
return self._download_json(
'https://asobistage-api.asobistore.jp/api/v1/vspf/token', video_id,
note='Getting token', errnote='Unable to get token')
```
As the tokens are valid for a whole week, maybe move this to `_real_initialize`? | 'id': '3aef7110',
'ext': 'mp4',
'title': 'asobistore_station_1020_serverREC',
'thumbnail': r're:^https?://[\w.-]+/\w+/\w+',
},
}],
}, {
'url': 'https://asobistage.asobistore.jp/event/sidem_fclive_bpct/archive/premium_hc',
... | @@ -0,0 +1,160 @@
+import functools
+
+from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ str_or_none,
+ traverse_obj,
+ url_or_none,
+ urljoin,
+)
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https://asobistage\.asobistore\.j... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.857 | refactor | 315 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | pzhlkj6612 |
if not error:
return
elif error == 'notlogin':
self.raise_login_required(metadata_available=False)
else:
raise ExtractorError(f'Unknown error: {error}')
def _get_token(self, video_id):
return self._search_regex(r'\"([^"]+)\"', self._download_webpa... | ```suggestion
video_id, video_type_name = self._match_valid_url(url).group('id', 'type')
``` | }, {
'url': 'https://asobistage.asobistore.jp/event/ijigenfes_utagassen/player/day1',
'only_matching': True,
}]
_API_HOST = 'https://asobistage-api.asobistore.jp'
_HEADERS = {}
_is_logged_in = False
@functools.cached_property
def _owned_tickets(self):
owned_tickets ... | @@ -0,0 +1,160 @@
+import functools
+
+from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ str_or_none,
+ traverse_obj,
+ url_or_none,
+ urljoin,
+)
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https://asobistage\.asobistore\.j... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.857 | suggestion | 102 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | pzhlkj6612 |
self.raise_login_required(metadata_available=False)
else:
raise ExtractorError(f'Unknown error: {error}')
def _get_token(self, video_id):
return self._search_regex(r'\"([^"]+)\"', self._download_webpage(
'https://asobistage-api.asobistore.jp/api/v1/vspf/token', v... | Should login be checked first?
```suggestion
self._check_login(video_id)
webpage = self._download_webpage(url, video_id)
``` | }]
_API_HOST = 'https://asobistage-api.asobistore.jp'
_HEADERS = {}
_is_logged_in = False
@functools.cached_property
def _owned_tickets(self):
owned_tickets = set()
if not self._is_logged_in:
return owned_tickets
for path, name in [
('api/v1/pur... | @@ -0,0 +1,160 @@
+import functools
+
+from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ str_or_none,
+ traverse_obj,
+ url_or_none,
+ urljoin,
+)
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https://asobistage\.asobistore\.j... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.786 | suggestion | 146 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | pzhlkj6612 |
return self._search_regex(r'\"([^"]+)\"', self._download_webpage(
'https://asobistage-api.asobistore.jp/api/v1/vspf/token', video_id,
note='Getting token', errnote='Unable to get token'),
name="token")
def _get_owned_tickets(self, video_id):
for url, name in [
... | I think I would just
```suggestion
video_type_id = {
'archive': 'archives',
'player': 'broadcasts',
}.get(video_type_name)
``` |
@functools.cached_property
def _owned_tickets(self):
owned_tickets = set()
if not self._is_logged_in:
return owned_tickets
for path, name in [
('api/v1/purchase_history/list', 'ticket purchase history'),
('api/v1/serialcode/list', 'redemption history... | @@ -0,0 +1,160 @@
+import functools
+
+from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ str_or_none,
+ traverse_obj,
+ url_or_none,
+ urljoin,
+)
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https://asobistage\.asobistore\.j... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.857 | suggestion | 172 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | pzhlkj6612 |
headers={'Authorization': f'Bearer {token}'})
channel_data = traverse_obj(channel_json, ('ex_content', {
'm3u8_url': 'streaming_url',
'title': 'title',
'thumbnail': ('thumbnail', 'url'),
}))
elif ... | And then
```suggestion
'is_live': video_type_id == 'broadcasts',
``` | f'https://survapi.channel.or.jp/proxy/v1/contents/{channel_id}/get_by_cuid', channel_id,
'Getting archive channel info', 'Unable to get archive channel info', fatal=False,
headers=self._HEADERS)
channel_data = traverse_obj(channel_json, ('ex_co... | @@ -0,0 +1,160 @@
+import functools
+
+from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ str_or_none,
+ traverse_obj,
+ url_or_none,
+ urljoin,
+)
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https://asobistage\.asobistore\.j... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.714 | suggestion | 87 | 38 | 32 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | pzhlkj6612 |
def _real_extract(self, url):
video_id = self._match_id(url)
video_type_name = self._match_valid_url(url).group('type')
webpage = self._download_webpage(url, video_id)
self._check_login(video_id)
video_type_id, live_status = {
'archive': ['archives', 'was_live']... | As far as I can tell, `https://asobistage.asobistore.jp/cdn/v101/events/` has been hardcoded in the JS since at least 2022.
I would just write `f'https://asobistage.asobistore.jp/cdn/v101/events/{event_id}/{video_type_id}.json'`. Any reason not to? | self._is_logged_in = False
break
owned_tickets.update(
traverse_obj(response, ('payload', 'value', ..., 'digital_product_id', {str_or_none})))
return owned_tickets
def _get_available_channel_id(self, channel):
channel_id = traverse_obj(ch... | @@ -0,0 +1,160 @@
+import functools
+
+from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ str_or_none,
+ traverse_obj,
+ url_or_none,
+ urljoin,
+)
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https://asobistage\.asobistore\.j... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.714 | question | 249 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | pzhlkj6612 |
channel_data = {}
if video_type_name == 'archive':
channel_json = self._download_json(
f'https://survapi.channel.or.jp/proxy/v1/contents/{channel_id}/get_by_cuid', f'{video_id}/{channel_id}',
note='Getting archive channel info', errnote='U... | Maybe just `self.report_warning` and `continue` if no m3u8 URL was found since we are returning a playlist? | 'channels', lambda _, v: v['chennel_vspf_id'] != '00000'))
entries = []
for channel_id in traverse_obj(available_channels, (..., {self._get_available_channel_id})):
if video_type == 'archives':
channel_json = self._download_json(
f'https://sur... | @@ -0,0 +1,160 @@
+import functools
+
+from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ str_or_none,
+ traverse_obj,
+ url_or_none,
+ urljoin,
+)
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https://asobistage\.asobistore\.j... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.5 | question | 107 | 44 | 38 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | pzhlkj6612 |
'https://asobistage-api.asobistore.jp/api/v1/check_login', video_id, expected_status=(400),
note='Checking login status', errnote='Unable to check login status')
error = traverse_obj(check_login_json, ('payload', 'error_message'), ('error'), get_all=False)
if not error:
... | I think this should also work:
```suggestion
yield from traverse_obj(self._download_json(
url, video_id, note=f'Downloading {name}', errnote=f'Unable to download {name}'),
('payload', 'value', ..., 'digital_product_id', {str}))
``` | 'id': 'sidem_fclive_bpct/archive/premium_hc',
'title': '315 Production presents F＠NTASTIC COMBINATION LIVE ～BRAINPOWER!!～/～CONNECTIME!!!!～',
'thumbnail': r're:^https?://[\w.-]+/\w+/\w+',
},
}, {
'url': 'https://asobistage.asobistore.jp/event/ijigenfes_utagassen/pl... | @@ -0,0 +1,160 @@
+import functools
+
+from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ str_or_none,
+ traverse_obj,
+ url_or_none,
+ urljoin,
+)
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https://asobistage\.asobistore\.j... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.857 | suggestion | 280 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | pzhlkj6612 |
from .common import InfoExtractor
from ..utils import ExtractorError, str_or_none, url_or_none
from ..utils.traversal import traverse_obj
class AsobiStageIE(InfoExtractor):
IE_DESC = 'ASOBISTAGE (アソビステージ)'
_VALID_URL = r'https://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>\w+)/\w+)(?:[?#]|$)'
_TE... | ```suggestion
_VALID_URL = r'https?://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>\w+)/\w+)(?:[?#]|$)'
``` | import functools
from .common import InfoExtractor
from ..utils import str_or_none, url_or_none
from ..utils.traversal import traverse_obj
class AsobiStageIE(InfoExtractor):
IE_DESC = 'ASOBISTAGE (アソビステージ)'
_VALID_URL = r'https?://asobistage\.asobistore\.jp/event/(?P<id>(?P<event>\w+)/(?P<type>archive|player... | @@ -0,0 +1,147 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, str_or_none, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>\w... | yt_dlp/extractor/asobistage.py | 8 | Python | 0.857 | suggestion | 121 | 33 | 33 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | pzhlkj6612 |
raise ExtractorError('Unknown video type')
event_data = self._search_nextjs_data(webpage, video_id)
event_id = traverse_obj(event_data, ('query', 'event', {str}))
event_slug = traverse_obj(event_data, ('query', 'player_slug', {str}))
event_title = traverse_obj(event_data, ('... | ```suggestion
entries = []
for channel_id in traverse_obj(available_channels, (..., 'chennel_vspf_id', {str})):
``` |
return owned_tickets
def _get_available_channel_id(self, channel):
channel_id = traverse_obj(channel, ('chennel_vspf_id', {str}))
if not channel_id:
return None
# if rights_type_id == 6, then 'No conditions (no login required - non-members are OK)'
if traverse_o... | @@ -0,0 +1,147 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, str_or_none, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>\w... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.714 | suggestion | 134 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | pzhlkj6612 |
'title': '315passion_FRAME_only',
'live_status': 'was_live',
'thumbnail': r're:^https?://[\w.-]+/\w+/\w+',
},
'params': {
'skip_download': True,
'ignore_no_formats_error': True,
},
}, {
'url': 'https://asobistage.asobistore.... | ```suggestion
_TOKEN = None
``` | 'info_dict': {
'id': '315passionhour_2022summer/archive/frame',
'title': '315プロダクションプレゼンツ 315パッションアワー!!!',
'thumbnail': r're:^https?://[\w.-]+/\w+/\w+',
},
'playlist_count': 1,
'playlist': [{
'info_dict': {
'id': 'edff52f2',... | @@ -0,0 +1,145 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, str_or_none, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https?://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>\... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.429 | suggestion | 37 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | pzhlkj6612 |
'params': {
'skip_download': True,
'ignore_no_formats_error': True,
},
}, {
'url': 'https://asobistage.asobistore.jp/event/idolmaster_idolworld2023_goods/archive/live',
'info_dict': {
'id': 'idolmaster_idolworld2023_goods/archive/live/3aef7110',
... | ```suggestion
'https://asobistage-api.asobistore.jp/api/v1/check_login', video_id, expected_status=400,
``` | },
'playlist_count': 1,
'playlist': [{
'info_dict': {
'id': 'edff52f2',
'ext': 'mp4',
'title': '315passion_FRAME_only',
'thumbnail': r're:^https?://[\w.-]+/\w+/\w+',
},
}],
}, {
'url': 'ht... | @@ -0,0 +1,145 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, str_or_none, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https?://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>\... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.714 | suggestion | 121 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | pzhlkj6612 |
'ignore_no_formats_error': True,
},
}, {
'url': 'https://asobistage.asobistore.jp/event/idolmaster_idolworld2023_goods/archive/live',
'info_dict': {
'id': 'idolmaster_idolworld2023_goods/archive/live/3aef7110',
'title': 'asobistore_station_1020_serverREC',... | we aren't branching here (we are traversing two entirely different paths) so `get_all=False` isn't needed, but expecting the type would be good
```suggestion
error = traverse_obj(check_login_json, ('payload', 'error_message'), ('error'), expected_type=str)
``` | 'playlist': [{
'info_dict': {
'id': 'edff52f2',
'ext': 'mp4',
'title': '315passion_FRAME_only',
'thumbnail': r're:^https?://[\w.-]+/\w+/\w+',
},
}],
}, {
'url': 'https://asobistage.asobistore.jp/event/ido... | @@ -0,0 +1,145 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, str_or_none, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https?://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>\... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.929 | suggestion | 271 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | pzhlkj6612 |
'live_status': 'was_live',
'thumbnail': r're:^https?://[\w.-]+/\w+/\w+',
},
'params': {
'skip_download': True,
'ignore_no_formats_error': True,
},
}, {
'url': 'https://asobistage.asobistore.jp/event/ijigenfes_utagassen/player/day1',
... | ```suggestion
raise ExtractorError(f'Unknown error: {error!r}')
``` | }],
}, {
'url': 'https://asobistage.asobistore.jp/event/idolmaster_idolworld2023_goods/archive/live',
'info_dict': {
'id': 'idolmaster_idolworld2023_goods/archive/live',
'title': 'md5:378510b6e830129d505885908bd6c576',
'thumbnail': r're:^https?://[\w.-]+/\... | @@ -0,0 +1,145 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, str_or_none, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https?://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>\... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.786 | refactor | 77 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | pzhlkj6612 |
def _get_owned_tickets(self, video_id):
for url, name in [
('https://asobistage-api.asobistore.jp/api/v1/purchase_history/list', 'ticket purchase history'),
('https://asobistage-api.asobistore.jp/api/v1/serialcode/list', 'redemption history'),
]:
yield from traver... | we should check if it's not a supported url before doing anything else, and include the unsupported type in the error output
```suggestion
video_type_id = {
'archive': 'archives',
'player': 'broadcasts',
}.get(video_type_name)
if not video_type_id:
rais... | 'only_matching': True,
}]
_API_HOST = 'https://asobistage-api.asobistore.jp'
_HEADERS = {}
_is_logged_in = False
@functools.cached_property
def _owned_tickets(self):
owned_tickets = set()
if not self._is_logged_in:
return owned_tickets
for path, nam... | @@ -0,0 +1,145 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, str_or_none, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https?://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>\... | yt_dlp/extractor/asobistage.py | 26 | Python | 1 | refactor | 480 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | pzhlkj6612 |
event_id = traverse_obj(event_data, ('query', 'event', {str}))
event_slug = traverse_obj(event_data, ('query', 'player_slug', {str}))
event_title = traverse_obj(event_data, ('props', 'pageProps', 'eventCMSData', 'event_name', {str}))
if not all((event_id, event_slug, event_title)):
... | why are we using `f'{video_id}/{channel_id}'` as the video_id in multiple requests but not returning it as the entry id? regardless it should be a variable
```suggestion
f'https://survapi.channel.or.jp/proxy/v1/contents/{channel_id}/get_by_cuid', f'{video_id}/{channel_id}',
``` | def _get_available_channel_id(self, channel):
channel_id = traverse_obj(channel, ('chennel_vspf_id', {str}))
if not channel_id:
return None
# if rights_type_id == 6, then 'No conditions (no login required - non-members are OK)'
if traverse_obj(channel, ('viewrights', lamb... | @@ -0,0 +1,145 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, str_or_none, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https?://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>\... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.857 | question | 301 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | pzhlkj6612 |
def _get_owned_tickets(self, video_id):
for url, name in [
('https://asobistage-api.asobistore.jp/api/v1/purchase_history/list', 'ticket purchase history'),
('https://asobistage-api.asobistore.jp/api/v1/serialcode/list', 'redemption history'),
]:
yield from trave... | since we are only matching supported URLs now, we don't need to worry about raising
```suggestion
video_type_id = {
'archive': 'archives',
'player': 'broadcasts',
}[video_type_name]
``` | }, {
'url': 'https://asobistage.asobistore.jp/event/ijigenfes_utagassen/player/day1',
'only_matching': True,
}]
_API_HOST = 'https://asobistage-api.asobistore.jp'
_HEADERS = {}
_is_logged_in = False
@functools.cached_property
def _owned_tickets(self):
owned_tickets ... | @@ -0,0 +1,134 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, str_or_none, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https?://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>a... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.929 | suggestion | 231 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | pzhlkj6612 |
IE_DESC = 'ASOBISTAGE (アソビステージ)'
_VALID_URL = r'https?://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>archive|player)/\w+)(?:[?#]|$)'
_TESTS = [{
'url': 'https://asobistage.asobistore.jp/event/315passionhour_2022summer/archive/frame',
'info_dict': {
'id': '315passionhour_... | It seems to me that `--no-playlist`/`yes_playlist()` is not applicable in this extractor.
We can test the playlist info dict and the entry info dicts.
`'live_status': 'was_live'` is no longer correct
```suggestion
'url': 'https://asobistage.asobistore.jp/event/315passionhour_2022summer/archive/frame',
... |
class AsobiStageIE(InfoExtractor):
IE_DESC = 'ASOBISTAGE (アソビステージ)'
_VALID_URL = r'https?://asobistage\.asobistore\.jp/event/(?P<id>(?P<event>\w+)/(?P<type>archive|player)/(?P<slug>\w+))(?:[?#]|$)'
_TESTS = [{
'url': 'https://asobistage.asobistore.jp/event/315passionhour_2022summer/archive/frame',
... | @@ -0,0 +1,132 @@
+from .common import InfoExtractor
+from ..utils import ExtractorError, str_or_none, url_or_none
+from ..utils.traversal import traverse_obj
+
+
+class AsobiStageIE(InfoExtractor):
+ IE_DESC = 'ASOBISTAGE (アソビステージ)'
+ _VALID_URL = r'https?://asobistage\.asobistore\.jp/event/(?P<id>\w+/(?P<type>a... | yt_dlp/extractor/asobistage.py | 26 | Python | 0.857 | refactor | 1,549 | 51 | 51 | false | [ie/asobistage] Add extractor for live and archives | 8,735 | yt-dlp/yt-dlp | 132,642 | Python | bashonly | pzhlkj6612 |
'quality': 1,
})
if 'hd_url' in json:
add_format({
'url': 'https://mx3.ch/' + json['hd_url'],
'format_id': 'hd',
'quality': 10,
})
# the "download" feature is not available everywhere
if f'/tracks/{trac... | This can be written like so:
```suggestion
'genre': genre,
**traverse_obj(json, {
'title': ('title', {str}),
'artist': ('artist', {str}),
'composer': ('composer_name', {str}),
'thumbnail': (('picture_url_xlarge', 'picture_url... | 'artist': (('performer_name', 'artist'), {str}),
'album_artist': ('artist', {str}),
'composer': ('composer_name', {str}),
'thumbnail': (('picture_url_xlarge', 'picture_url'), {url_or_none}),
}, get_all=False),
}
class Mx3IE(Mx3BaseIE)... | @@ -0,0 +1,98 @@
+import re
+
+from .common import InfoExtractor
+from ..utils import urlhandle_detect_ext
+from ..networking import HEADRequest
+
+
+class Mx3IE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?mx3\.ch/t/(?P<id>[0-9A-Za-z]+)'
+ _TESTS = [{
+ 'url': 'https://mx3.ch/t/1Cru',
+ 'md5... | yt_dlp/extractor/mx3.py | 26 | Python | 0.786 | suggestion | 490 | 28 | 51 | false | [extractor/mx3] Add extractor | 8,736 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | martinxyz |
'title': 'The Broots-Larytta remix "Begging For Help"',
}
}, {
'url': 'https://mx3.ch/t/1C6E',
'md5': '1afcd578493ddb8e5008e94bb6d97e25',
'info_dict': {
'id': '1C6E',
# This one has a download button, yielding a WAV.
'ext': 'wav',
... | With those changes, this can be removed.
```suggestion
```
I see you are prepending the artists to the title here. I'd say it is probably better to keep the title untouched.
I could potentially see removing the artist name from the title if the site consistently prepends it.
That way, the user can use an output te... | 'quality': 2,
}]
def _extract_formats(self, track_id):
formats = []
for fmt in self._FORMATS:
format_url = f'https://{self._DOMAIN}/tracks/{track_id}/{fmt["url"]}'
urlh = self._request_webpage(
HEADRequest(format_url), track_id, fatal=False, expec... | @@ -0,0 +1,98 @@
+import re
+
+from .common import InfoExtractor
+from ..utils import urlhandle_detect_ext
+from ..networking import HEADRequest
+
+
+class Mx3IE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?mx3\.ch/t/(?P<id>[0-9A-Za-z]+)'
+ _TESTS = [{
+ 'url': 'https://mx3.ch/t/1Cru',
+ 'md5... | yt_dlp/extractor/mx3.py | 26 | Python | 0.857 | suggestion | 399 | 51 | 51 | false | [extractor/mx3] Add extractor | 8,736 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | martinxyz |
urlh = self._request_webpage(HEADRequest(fmt['url']), track_id, note='Fetching media headers', fatal=False)
if urlh:
fmt['ext'] = urlhandle_detect_ext(urlh)
formats.append(fmt)
add_format({
'url': 'https://mx3.ch/' + json['url'],
'... | I wonder if given that we need to make a HEAD request anyway, we should just attempt to add all formats:
```suggestion
add_format({
'url': f'https://mx3.ch/tracks/{track_id}/player_asset',
'format_id': 'default',
'quality': 1,
})
add_format({
... | 'formats': self._extract_formats(track_id),
'genre': self._html_search_regex(
r'<div\b[^>]+class="single-band-genre"[^>]*>([^<]+)</div>', webpage, 'genre', default=None),
'release_year': int_or_none(get_info_field('Year of creation')),
'description': get_i... | @@ -0,0 +1,98 @@
+import re
+
+from .common import InfoExtractor
+from ..utils import urlhandle_detect_ext
+from ..networking import HEADRequest
+
+
+class Mx3IE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?mx3\.ch/t/(?P<id>[0-9A-Za-z]+)'
+ _TESTS = [{
+ 'url': 'https://mx3.ch/t/1Cru',
+ 'md5... | yt_dlp/extractor/mx3.py | 26 | Python | 0.857 | suggestion | 829 | 36 | 51 | false | [extractor/mx3] Add extractor | 8,736 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | martinxyz |
'artist': 'Alien Bubblegum',
'genre': 'Punk',
'thumbnail': 'https://mx3.ch/pictures/mx3/file/0101/1551/square_xlarge/pandora-s-box-cover-with-title.png?1627054733',
'title': 'Alien Bubblegum - Wide Awake',
}
}]
def _real_extract(self, url):
track_... | You can add the file size:
```suggestion
fmt['ext'] = urlhandle_detect_ext(urlh)
fmt['filesize'] = int_or_none(urlh.headers.get('Content-Length'))
```
import `int_or_none` from `..utils` | note=f'Checking for format {fmt["format_id"]}')
if urlh and urlh.status == 200:
formats.append({
**fmt,
'url': format_url,
'ext': urlhandle_detect_ext(urlh),
'filesize': int_or_none(urlh.headers.g... | @@ -0,0 +1,98 @@
+import re
+
+from .common import InfoExtractor
+from ..utils import urlhandle_detect_ext
+from ..networking import HEADRequest
+
+
+class Mx3IE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?mx3\.ch/t/(?P<id>[0-9A-Za-z]+)'
+ _TESTS = [{
+ 'url': 'https://mx3.ch/t/1Cru',
+ 'md5... | yt_dlp/extractor/mx3.py | 26 | Python | 0.929 | suggestion | 223 | 51 | 51 | false | [extractor/mx3] Add extractor | 8,736 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | martinxyz |
'info_dict': {
'id': '1LIY',
# This is a music video. 'file' says: ISO Media, MP4 Base Media v1 [ISO 14496-12:2003]
'ext': 'mp4',
'artist': 'The Broots',
'genre': 'Electro',
'thumbnail': 'https://mx3.ch/pictures/mx3/file/0110/0003/video_xla... | Actually, looking around the page, there is a bunch more optional data on the webpage that isn't in the JSON.
If you like, you can also try to extract those.
`Year of creation` -> `release_year`
`single-stats` -> `view_count`
`Added on` -> `upload_date`
`Description` -> `description` (not always present)
`Tag` ->... | }, {
'url': 'download',
'format_id': 'download',
'quality': 2,
}, {
'url': 'player_asset?quality=source',
'format_id': 'source',
'quality': 2,
}]
def _extract_formats(self, track_id):
formats = []
for fmt in self._FORMATS:
form... | @@ -0,0 +1,98 @@
+import re
+
+from .common import InfoExtractor
+from ..utils import urlhandle_detect_ext
+from ..networking import HEADRequest
+
+
+class Mx3IE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?mx3\.ch/t/(?P<id>[0-9A-Za-z]+)'
+ _TESTS = [{
+ 'url': 'https://mx3.ch/t/1Cru',
+ 'md5... | yt_dlp/extractor/mx3.py | 26 | Python | 0.643 | refactor | 383 | 51 | 51 | false | [extractor/mx3] Add extractor | 8,736 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | martinxyz |
import re
from .common import InfoExtractor
from ..utils import urlhandle_detect_ext
from ..networking import HEADRequest
class Mx3IE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?mx3\.ch/t/(?P<id>[0-9A-Za-z]+)'
_TESTS = [{
'url': 'https://mx3.ch/t/1Cru',
'md5': '82510bf4c21f17da41bff7e1f... | There also exists https://neo.mx3.ch/ and https://volksmusik.mx3.ch/
I think the extractor will also need to be slightly adjusted to work with both. | import re
from .common import InfoExtractor
from ..networking import HEADRequest
from ..utils import (
get_element_by_class,
int_or_none,
try_call,
url_or_none,
urlhandle_detect_ext,
)
from ..utils.traversal import traverse_obj
class Mx3BaseIE(InfoExtractor):
_VALID_URL_TMPL = r'https?://(?:w... | @@ -0,0 +1,98 @@
+import re
+
+from .common import InfoExtractor
+from ..utils import urlhandle_detect_ext
+from ..networking import HEADRequest
+
+
+class Mx3IE(InfoExtractor):
+ _VALID_URL = r'https?://(?:www\.)?mx3\.ch/t/(?P<id>[0-9A-Za-z]+)' | yt_dlp/extractor/mx3.py | 9 | Python | 0.429 | refactor | 149 | 34 | 34 | false | [extractor/mx3] Add extractor | 8,736 | yt-dlp/yt-dlp | 132,642 | Python | seproDev | martinxyz |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.