before_code
stringlengths
14
465k
reviewer_comment
stringlengths
16
64.5k
after_code
stringlengths
9
467k
diff_context
stringlengths
0
97k
file_path
stringlengths
5
226
comment_line
int32
0
26
language
stringclasses
37 values
quality_score
float32
0.07
1
comment_type
stringclasses
9 values
comment_length
int32
16
64.5k
before_lines
int32
1
17.2k
after_lines
int32
1
12.1k
is_negative
bool
2 classes
pr_title
stringlengths
1
308
pr_number
int32
1
299k
repo_name
stringclasses
533 values
repo_stars
int64
321
419k
repo_language
stringclasses
27 values
reviewer_username
stringlengths
0
39
author_username
stringlengths
2
39
'skip_download': 'Livestream', }, }, { 'url': 'https://maraya.sba.net.ae/live/14', 'info_dict': { 'id': '14', 'title': str, 'description': str, 'ext': 'mp4', 'live_status': 'is_live', }, 'params': { ...
I'd parse the entire NUXT config ```suggestion config_data = self._search_json( r'window\.__NUXT__\.config=', webpage, 'config', video_id, transform_source=js_to_json) api_base = config_data['public']['TRANSLATIONS_API_URL'] ```
}, 'params': { 'skip_download': 'Livestream', }, }, { 'url': 'https://sat7plus.org/fa/live/arabic', 'only_matching': True, }] def _real_extract(self, url): video_id = self._match_id(url) webpage = self._download_webpage(url, video_id) ...
@@ -0,0 +1,102 @@ +import re + +from .common import InfoExtractor +from ..utils import ExtractorError +from ..utils.traversal import traverse_obj + + +class FaulioLiveIE(InfoExtractor): + _VALID_URL = ( + r'https?://(?P<domain>aloula\.sba\.sa|maraya\.sba\.net\.ae|sat7plus\.org)/' + r'(?:en/)?live/(?P<f...
yt_dlp/extractor/faulio.py
26
Python
0.786
suggestion
261
51
46
false
[ie/FaulioLive] Add extractor
13,421
yt-dlp/yt-dlp
132,642
Python
seproDev
CasperMcFadden95
'description': str, 'ext': 'mp4', 'live_status': 'is_live', }, 'params': { 'skip_download': 'Livestream', }, }, { 'url': 'https://maraya.sba.net.ae/live/14', 'info_dict': { 'id': '14', 'title': str, ...
Headers don't seem to be required. Even if they were, we could just use `url` ```suggestion video_id = self._match_id(url) webpage = self._download_webpage(url, video_id) ```
'id': 'sat7.faulio.com_pars', 'title': str, 'description': str, 'ext': 'mp4', 'live_status': 'is_live', }, 'params': { 'skip_download': 'Livestream', }, }, { 'url': 'https://sat7plus.org/fa/live/arabic', ...
@@ -0,0 +1,102 @@ +import re + +from .common import InfoExtractor +from ..utils import ExtractorError +from ..utils.traversal import traverse_obj + + +class FaulioLiveIE(InfoExtractor): + _VALID_URL = ( + r'https?://(?P<domain>aloula\.sba\.sa|maraya\.sba\.net\.ae|sat7plus\.org)/' + r'(?:en/)?live/(?P<f...
yt_dlp/extractor/faulio.py
26
Python
0.786
suggestion
194
51
51
false
[ie/FaulioLive] Add extractor
13,421
yt-dlp/yt-dlp
132,642
Python
seproDev
CasperMcFadden95
import re from .common import InfoExtractor from ..utils import ExtractorError from ..utils.traversal import traverse_obj class FaulioLiveIE(InfoExtractor): _VALID_URL = ( r'https?://(?P<domain>aloula\.sba\.sa|maraya\.sba\.net\.ae|sat7plus\.org)/' r'(?:en/)?live/(?P<faulio_url>[a-zA-Z0-9\-]+)' ...
```suggestion _VALID_URL = r'https?://(?:aloula\.sba\.sa|maraya\.sba\.net\.ae|sat7plus\.org)/(?:(?:en|ar|fa)/)?live/(?P<id>[a-zA-Z0-9\-]+)' ```
import re import urllib.parse from .common import InfoExtractor from ..utils import js_to_json, url_or_none from ..utils.traversal import traverse_obj class FaulioLiveIE(InfoExtractor): _DOMAINS = ( 'aloula.sba.sa', 'maraya.sba.net.ae', 'sat7plus.org', ) _VALID_URL = fr'https?://(...
@@ -0,0 +1,102 @@ +import re + +from .common import InfoExtractor +from ..utils import ExtractorError +from ..utils.traversal import traverse_obj + + +class FaulioLiveIE(InfoExtractor): + _VALID_URL = ( + r'https?://(?P<domain>aloula\.sba\.sa|maraya\.sba\.net\.ae|sat7plus\.org)/' + r'(?:en/)?live/(?P<f...
yt_dlp/extractor/faulio.py
13
Python
0.714
suggestion
149
38
38
false
[ie/FaulioLive] Add extractor
13,421
yt-dlp/yt-dlp
132,642
Python
seproDev
CasperMcFadden95
'live_status': 'is_live', }, 'params': { 'skip_download': 'Livestream', }, }] def _real_extract(self, url): mobj = self._match_valid_url(url) faulio_url = mobj.group('faulio_url') webpage = self._download_webpage(url, faulio_url) ...
Can also be simplified using `traverse_obj` ```suggestion channel = traverse_obj( self._download_json(f'{api_base}/channels', video_id), (lambda k, v: v['url'] == video_id, any)) ```
def _real_extract(self, url): video_id = self._match_id(url) webpage = self._download_webpage(url, video_id) config_data = self._search_json( r'window\.__NUXT__\.config=', webpage, 'config', video_id, transform_source=js_to_json) api_base = config_data['public']['TRANSLA...
@@ -0,0 +1,102 @@ +import re + +from .common import InfoExtractor +from ..utils import ExtractorError +from ..utils.traversal import traverse_obj + + +class FaulioLiveIE(InfoExtractor): + _VALID_URL = ( + r'https?://(?P<domain>aloula\.sba\.sa|maraya\.sba\.net\.ae|sat7plus\.org)/' + r'(?:en/)?live/(?P<f...
yt_dlp/extractor/faulio.py
26
Python
0.786
suggestion
219
47
37
false
[ie/FaulioLive] Add extractor
13,421
yt-dlp/yt-dlp
132,642
Python
seproDev
CasperMcFadden95
webpage = self._download_webpage(url, faulio_url) api_url_match = re.search(r'TRANSLATIONS_API_URL\s*:\s*"(https?://[^"]+)"', webpage) if not api_url_match: raise ExtractorError('Could not find TRANSLATIONS_API_URL in the page') api_base = api_url_match.group(1) ch...
Let's extract both hls and dash for fault tolerance ```suggestion formats = [] subtitles = {} if hls_url := traverse_obj(channel, ('streams', 'hls', {url_or_none})): fmts, subs = self._extract_m3u8_formats_and_subtitles( hls_url, video_id, 'mp4', m3u8_id='hls', ...
(lambda k, v: v['url'] == video_id, any)) formats = [] subtitles = {} if hls_url := traverse_obj(channel, ('streams', 'hls', {url_or_none})): fmts, subs = self._extract_m3u8_formats_and_subtitles( hls_url, video_id, 'mp4', m3u8_id='hls', live=True, fatal=...
@@ -0,0 +1,102 @@ +import re + +from .common import InfoExtractor +from ..utils import ExtractorError +from ..utils.traversal import traverse_obj + + +class FaulioLiveIE(InfoExtractor): + _VALID_URL = ( + r'https?://(?P<domain>aloula\.sba\.sa|maraya\.sba\.net\.ae|sat7plus\.org)/' + r'(?:en/)?live/(?P<f...
yt_dlp/extractor/faulio.py
26
Python
0.857
refactor
748
37
27
false
[ie/FaulioLive] Add extractor
13,421
yt-dlp/yt-dlp
132,642
Python
seproDev
CasperMcFadden95
api_url_match = re.search(r'TRANSLATIONS_API_URL\s*:\s*"(https?://[^"]+)"', webpage) if not api_url_match: raise ExtractorError('Could not find TRANSLATIONS_API_URL in the page') api_base = api_url_match.group(1) channels_json = self._download_json(f'{api_base}/channels', fa...
Let's prepend the domain to have unique IDs ```suggestion domain = urllib.parse.urlparse(api_base).hostname return { 'id': f'{domain}:{video_id}', ```
import re import urllib.parse from .common import InfoExtractor from ..utils import js_to_json, url_or_none from ..utils.traversal import traverse_obj class FaulioLiveIE(InfoExtractor): _DOMAINS = ( 'aloula.sba.sa', 'maraya.sba.net.ae', 'sat7plus.org', ) _VALID_URL = fr'https?://(...
@@ -0,0 +1,102 @@ +import re + +from .common import InfoExtractor +from ..utils import ExtractorError +from ..utils.traversal import traverse_obj + + +class FaulioLiveIE(InfoExtractor): + _VALID_URL = ( + r'https?://(?P<domain>aloula\.sba\.sa|maraya\.sba\.net\.ae|sat7plus\.org)/' + r'(?:en/)?live/(?P<f...
yt_dlp/extractor/faulio.py
26
Python
0.714
suggestion
183
34
93
false
[ie/FaulioLive] Add extractor
13,421
yt-dlp/yt-dlp
132,642
Python
seproDev
CasperMcFadden95
channel_json = next( (c for c in channels_json if str(c.get('url')) == faulio_url), None, ) if not channel_json: raise ExtractorError(f'Channel "{faulio_url}" not found in API') hls_url = traverse_obj(channel_json, ('streams', 'hls')) if not ...
Rewritten using `traverse_obj` ```suggestion 'formats': formats, 'subtitles': subtitles, 'is_live': True, **traverse_obj(channel, { 'title': ('title', {str}), 'description': ('description', {str}), }), ```
import re import urllib.parse from .common import InfoExtractor from ..utils import js_to_json, url_or_none from ..utils.traversal import traverse_obj class FaulioLiveIE(InfoExtractor): _DOMAINS = ( 'aloula.sba.sa', 'maraya.sba.net.ae', 'sat7plus.org', ) _VALID_URL = fr'https?://(...
@@ -0,0 +1,102 @@ +import re + +from .common import InfoExtractor +from ..utils import ExtractorError +from ..utils.traversal import traverse_obj + + +class FaulioLiveIE(InfoExtractor): + _VALID_URL = ( + r'https?://(?P<domain>aloula\.sba\.sa|maraya\.sba\.net\.ae|sat7plus\.org)/' + r'(?:en/)?live/(?P<f...
yt_dlp/extractor/faulio.py
26
Python
0.786
suggestion
306
28
93
false
[ie/FaulioLive] Add extractor
13,421
yt-dlp/yt-dlp
132,642
Python
seproDev
CasperMcFadden95
import urllib.parse from .common import InfoExtractor from ..utils import js_to_json, url_or_none from ..utils.traversal import traverse_obj class FaulioLiveIE(InfoExtractor): _VALID_URL = r'https?://(?:aloula\.sba\.sa|maraya\.sba\.net\.ae|sat7plus\.org)/(?:(?:en|ar|fa)/)?live/(?P<id>[a-zA-Z0-9\-]+)' _TESTS ...
```suggestion _DOMAINS = ( 'aloula.sba.sa', 'maraya.sba.net.ae', 'sat7plus.org', ) _VALID_URL = fr'https?://(?:{"|".join(map(re.escape, _DOMAINS))})/(?:(?:en|ar|fa)/)?live/(?P<id>[a-zA-Z0-9-]+)' ```
import re import urllib.parse from .common import InfoExtractor from ..utils import js_to_json, url_or_none from ..utils.traversal import traverse_obj class FaulioLiveIE(InfoExtractor): _DOMAINS = ( 'aloula.sba.sa', 'maraya.sba.net.ae', 'sat7plus.org', ) _VALID_URL = fr'https?://(...
@@ -0,0 +1,87 @@ +import urllib.parse + +from .common import InfoExtractor +from ..utils import js_to_json, url_or_none +from ..utils.traversal import traverse_obj + + +class FaulioLiveIE(InfoExtractor): + _VALID_URL = r'https?://(?:aloula\.sba\.sa|maraya\.sba\.net\.ae|sat7plus\.org)/(?:(?:en|ar|fa)/)?live/(?P<id>[a...
yt_dlp/extractor/faulio.py
9
Python
0.786
security
241
34
34
false
[ie/FaulioLive] Add extractor
13,421
yt-dlp/yt-dlp
132,642
Python
bashonly
CasperMcFadden95
config_data = self._search_json( r'window\.__NUXT__\.config=', webpage, 'config', video_id, transform_source=js_to_json) api_base = config_data['public']['TRANSLATIONS_API_URL'] channel = traverse_obj( self._download_json(f'{api_base}/channels', video_id), (...
```suggestion return { 'id': f'{urllib.parse.urlparse(api_base).hostname}:{video_id}', ```
'only_matching': True, }] def _real_extract(self, url): video_id = self._match_id(url) webpage = self._download_webpage(url, video_id) config_data = self._search_json( r'window\.__NUXT__\.config=', webpage, 'config', video_id, transform_source=js_to_json) ap...
@@ -0,0 +1,87 @@ +import urllib.parse + +from .common import InfoExtractor +from ..utils import js_to_json, url_or_none +from ..utils.traversal import traverse_obj + + +class FaulioLiveIE(InfoExtractor): + _VALID_URL = r'https?://(?:aloula\.sba\.sa|maraya\.sba\.net\.ae|sat7plus\.org)/(?:(?:en|ar|fa)/)?live/(?P<id>[a...
yt_dlp/extractor/faulio.py
26
Python
0.714
suggestion
113
35
40
false
[ie/FaulioLive] Add extractor
13,421
yt-dlp/yt-dlp
132,642
Python
bashonly
CasperMcFadden95
if match_exception(err): return raise else: break if is_playlist: self.assertTrue(res_dict['_type'] in ['playlist', 'multi_video']) self.assertTrue('entries' in res_dict) ...
these messages are incorrect because if there is `playlist_count` or `playlist_maxcount` in the `test_case`, then we are never extracting all of the entries (we are only extracting 1 more than the expected count)
try_num += 1 except YoutubeDLError as err: if match_exception(err): return raise else: break if is_playlist: self.assertTrue(res_dict['_type'] in ['playlis...
@@ -196,25 +199,19 @@ def try_rm_tcs_files(tcs=None): if 'playlist_mincount' in test_case: assertGreaterEqual( - self, - len(res_dict['entries']), - test_case['playlist_mincount'], - 'Expected at least %d in play...
test/test_download.py
26
Python
0.643
bug
212
51
51
false
[test:download] Support `playlist_maxcount`
13,433
yt-dlp/yt-dlp
132,642
Python
bashonly
InvalidUsernameException
if tc.get('expected_exception'): continue info_dict = tc.get('info_dict', {}) params = tc.get('params', {}) if not info_dict.get('id'): raise Exception(f'Test {tname} definition incorrect - "id" key is not present') elif not inf...
it's ok to use the default param here, and IMO easier to read ```suggestion params.setdefault('playlistend', max( test_case.get('playlist_mincount', -1), test_case.get('playlist_count', -2) + 1, test_case.get('playlist_maxcount', -2) + 1)) ```
if tc.get('expected_exception'): continue info_dict = tc.get('info_dict', {}) params = tc.get('params', {}) if not info_dict.get('id'): raise Exception(f'Test {tname} definition incorrect - "id" key is not present') elif not inf...
@@ -122,8 +123,10 @@ def print_skipping(reason): params['outtmpl'] = tname + '_' + params['outtmpl'] if is_playlist and 'playlist' not in test_case: params.setdefault('extract_flat', 'in_playlist') - params.setdefault('playlistend', test_case.get( - 'playlist_min...
test/test_download.py
26
Python
0.857
suggestion
309
51
51
false
[test:download] Support `playlist_maxcount`
13,433
yt-dlp/yt-dlp
132,642
Python
bashonly
InvalidUsernameException
# Check if the exception is not a network related one if not isinstance(err.exc_info[1], (TransportError, UnavailableVideoError)) or (isinstance(err.exc_info[1], HTTPError) and err.exc_info[1].status == 503): if match_exception(err): ...
```suggestion num_entries = len(res_dict.get('entries', [])) ```
force_generic_extractor=params.get('force_generic_extractor', False)) except (DownloadError, ExtractorError) as err: # Check if the exception is not a network related one if not isinstance(err.exc_info[1], (TransportError, UnavailableVideoE...
@@ -194,27 +197,23 @@ def try_rm_tcs_files(tcs=None): self.assertTrue('entries' in res_dict) expect_info_dict(self, res_dict, test_case.get('info_dict', {})) + num_entries = len(res_dict['entries'])
test/test_download.py
26
Python
0.571
suggestion
78
51
51
false
[test:download] Support `playlist_maxcount`
13,433
yt-dlp/yt-dlp
132,642
Python
bashonly
InvalidUsernameException
if tc.get('expected_exception'): continue info_dict = tc.get('info_dict', {}) params = tc.get('params', {}) if not info_dict.get('id'): raise Exception(f'Test {tname} definition incorrect - "id" key is not present') elif not inf...
```suggestion params.setdefault('skip_download', True) if 'playlist_duration_sum' not in test_case: params.setdefault('extract_flat', 'in_playlist') ```
if tc.get('expected_exception'): continue info_dict = tc.get('info_dict', {}) params = tc.get('params', {}) if not info_dict.get('id'): raise Exception(f'Test {tname} definition incorrect - "id" key is not present') elif not inf...
@@ -122,8 +123,10 @@ def print_skipping(reason): params['outtmpl'] = tname + '_' + params['outtmpl'] if is_playlist and 'playlist' not in test_case: params.setdefault('extract_flat', 'in_playlist') - params.setdefault('playlistend', test_case.get( - 'playlist_min...
test/test_download.py
26
Python
0.786
refactor
196
51
51
false
[test:download] Support `playlist_maxcount`
13,433
yt-dlp/yt-dlp
132,642
Python
bashonly
InvalidUsernameException
}) title = f'{artist} - {track}' if artist else track if not duration: duration = float_or_none(self._html_search_meta( 'duration', webpage, default=None)) return { 'id': track_id, 'title': title, 'thumbna...
`get_elements_by_class` can be fatal, and all metadata extraction should be non-fatal, so let's use traversal instead (which is non-fatal): ```suggestion 'tags': traverse_obj(webpage, ({find_elements(cls='tag')}, ..., {clean_html})), ``` (import `find_elements` from `..utils.traversal` and import `clea...
}) title = f'{artist} - {track}' if artist else track if not duration: duration = float_or_none(self._html_search_meta( 'duration', webpage, default=None)) return { 'id': track_id, 'title': title, 'thumbna...
@@ -252,6 +262,7 @@ def _real_extract(self, url): 'album': embed.get('album_title'), 'album_artist': album_artist, 'formats': formats, + 'tags': get_elements_by_class('tag', webpage),
yt_dlp/extractor/bandcamp.py
26
Python
0.857
refactor
345
51
51
false
[ie/bandcamp] Extract tags
13,480
yt-dlp/yt-dlp
132,642
Python
bashonly
WouterGordts
'timestamp': 1749547434, 'upload_date': '20250610', 'release_timestamp': 1749646802, 'release_date': '20250611', 'modified_timestamp': 1749647146, 'modified_date': '20250611', 'live_status': 'not_live', }, }] def _real_...
more precise extraction of metadata relying on `<h3>` tag for the title is fatal in certain edge cases, it overwrites STREAKS title with `None` (e.g. https://cu.tbs.co.jp/program/13952) ```diff @@ -47,16 +47,27 @@ def _real_extract(self, url): return { - **self._extract_from_streaks_api('...
'thumbnail': 'md5:d8855c8c292683c95a84cafdb42300bc', 'categories': ['エンタメ', '水曜日のダウンタウン', 'ダウンタウン', '浜田雅功', '松本人志', '水ダウ', '動画', 'バラエティ'], 'cast': ['浜田 雅功', '藤本 敏史', 'ビビる 大木', '千原 ジュニア', '横澤 夏子', 'せいや', 'あの', '服部 潤'], 'genres': ['variety'], 'series': '水曜日のダウンタ...
@@ -40,28 +44,8 @@ def _real_extract(self, url): meta = self._search_json(r'window\.app\s*=', webpage, 'episode info', video_id, fatal=False) episode = traverse_obj(meta, ('falcorCache', 'catalog', 'episode', video_id, 'value')) - tf_path = self._search_regex( - r'<script[^>]+src=[...
yt_dlp/extractor/tbsjp.py
26
Python
1
bug
2,664
51
51
false
[ie/tbsjp] Fix extractor
13,485
yt-dlp/yt-dlp
132,642
Python
doe1080
garret1317
_GEO_BYPASS = False _TESTS = [{ 'url': 'https://cu.tbs.co.jp/episode/14694_2090934_1000117476', 'skip': 'geo-blocked to japan + 7-day expiry', 'info_dict': { 'title': '次世代リアクション王発掘トーナメント', 'id': '14694_2090934_1000117476', 'ext': 'mp4', 'di...
update `_TESTS` to reflect changes below ```diff @@ -15,26 +15,31 @@ class TBSJPEpisodeIE(StreaksBaseIE): _TESTS = [{ 'url': 'https://cu.tbs.co.jp/episode/14694_2090934_1000117476', - 'skip': 'geo-blocked to japan + 7-day expiry', 'info_dict': { - 'title': '次世代リアクション王発掘トー...
return self._search_json(r'window\.app\s*=', webpage, f'{name} info', item_id, **kwargs) class TBSJPEpisodeIE(TBSJPBaseIE): _VALID_URL = r'https?://cu\.tbs\.co\.jp/episode/(?P<id>[\d_]+)' _TESTS = [{ 'url': 'https://cu.tbs.co.jp/episode/14694_2094162_1000123656', 'skip': 'geo-blocked t...
@@ -1,36 +1,40 @@ from .common import InfoExtractor -from ..networking.exceptions import HTTPError +from .streaks import StreaksBaseIE from ..utils import ( - ExtractorError, clean_html, int_or_none, str_or_none, unified_timestamp, - urljoin, ) from ..utils.traversal import find_element, t...
yt_dlp/extractor/tbsjp.py
26
Python
1
suggestion
1,975
51
51
false
[ie/tbsjp] Fix extractor
13,485
yt-dlp/yt-dlp
132,642
Python
doe1080
garret1317
from .common import InfoExtractor from .streaks import StreaksBaseIE from ..utils import ( clean_html, int_or_none, str_or_none, unified_timestamp, ) from ..utils.traversal import find_element, traverse_obj class TBSJPEpisodeIE(StreaksBaseIE): _VALID_URL = r'https?://cu\.tbs\.co\.jp/episode/(?P<id...
doesn’t the geo-restriction seem to be applied only by STREAKS and not TBS FREE? If so, is `_GEO_BYPASS` really necessary?
from .streaks import StreaksBaseIE from ..utils import ( clean_html, int_or_none, str_or_none, unified_timestamp, url_or_none, ) from ..utils.traversal import traverse_obj class TBSJPBaseIE(StreaksBaseIE): def _search_window_app_json(self, webpage, name, item_id, **kwargs): return self...
@@ -1,36 +1,40 @@ from .common import InfoExtractor -from ..networking.exceptions import HTTPError +from .streaks import StreaksBaseIE from ..utils import ( - ExtractorError, clean_html, int_or_none, str_or_none, unified_timestamp, - urljoin, ) from ..utils.traversal import find_element, t...
yt_dlp/extractor/tbsjp.py
14
Python
0.5
question
122
39
39
false
[ie/tbsjp] Fix extractor
13,485
yt-dlp/yt-dlp
132,642
Python
doe1080
garret1317
from .common import InfoExtractor from .streaks import StreaksBaseIE from ..utils import ( clean_html, int_or_none, str_or_none, unified_timestamp, ) from ..utils.traversal import find_element, traverse_obj class TBSJPEpisodeIE(StreaksBaseIE): _VALID_URL = r'https?://cu\.tbs\.co\.jp/episode/(?P<id...
How about defining a BaseIE like this to avoid code duplication? ```suggestion class TBSJPBaseIE(StreaksBaseIE): _CU_BASE = 'https://cu.tbs.co.jp' def _window_app(self, webpage, name, item_id, fatal=True): return self._search_json( r'window\.app\s*=', webpage, f'{name} info', item_id...
from .streaks import StreaksBaseIE from ..utils import ( clean_html, int_or_none, str_or_none, unified_timestamp, url_or_none, ) from ..utils.traversal import traverse_obj class TBSJPBaseIE(StreaksBaseIE): def _search_window_app_json(self, webpage, name, item_id, **kwargs): return self...
@@ -1,36 +1,40 @@ from .common import InfoExtractor -from ..networking.exceptions import HTTPError +from .streaks import StreaksBaseIE from ..utils import ( - ExtractorError, clean_html, int_or_none, str_or_none, unified_timestamp, - urljoin, ) from ..utils.traversal import find_element, t...
yt_dlp/extractor/tbsjp.py
11
Python
0.857
question
339
36
36
false
[ie/tbsjp] Fix extractor
13,485
yt-dlp/yt-dlp
132,642
Python
doe1080
garret1317
from .streaks import StreaksBaseIE from ..utils import ( clean_html, int_or_none, str_or_none, unified_timestamp, url_or_none, ) from ..utils.traversal import traverse_obj class TBSJPBaseIE(StreaksBaseIE): def _window_app(self, webpage, name, item_id, fatal=True): return self._search_j...
my mistake, sorry ```suggestion return self._search_json(r'window\.app\s*=', webpage, f'{name} info', item_id, fatal=fatal, default={}) ```
from .streaks import StreaksBaseIE from ..utils import ( clean_html, int_or_none, str_or_none, unified_timestamp, url_or_none, ) from ..utils.traversal import traverse_obj class TBSJPBaseIE(StreaksBaseIE): def _search_window_app_json(self, webpage, name, item_id, **kwargs): return self...
@@ -1,104 +1,105 @@ -from .common import InfoExtractor -from ..networking.exceptions import HTTPError +from .streaks import StreaksBaseIE from ..utils import ( - ExtractorError, clean_html, int_or_none, str_or_none, unified_timestamp, - urljoin, + url_or_none, ) -from ..utils.traversal im...
yt_dlp/extractor/tbsjp.py
14
Python
0.714
suggestion
150
39
39
false
[ie/tbsjp] Fix extractor
13,485
yt-dlp/yt-dlp
132,642
Python
doe1080
garret1317
'uploader': 'TBS', 'uploader_id': 'tbs', 'duration': 2761, 'thumbnail': 'md5:76882f287053dfec6a5adffad70ff1e3', 'categories': ['エンタメ', '水曜日のダウンタウン', 'ダウンタウン', '浜田雅功', '松本人志', '水ダウ', 'バラエティ', '動画'], 'cast': ['浜田\u3000雅功', '千原\u3000ジュニア', 'くっきー!(野性爆弾...
```suggestion meta = self._window_app(webpage, 'episode', video_id, fatal=False) ```
'uploader': 'TBS', 'uploader_id': 'tbs', 'duration': 2752, 'thumbnail': 'md5:d8855c8c292683c95a84cafdb42300bc', 'categories': ['エンタメ', '水曜日のダウンタウン', 'ダウンタウン', '浜田雅功', '松本人志', '水ダウ', '動画', 'バラエティ'], 'cast': ['浜田 雅功', '藤本 敏史', 'ビビる 大木', '千原 ジュニア', '横...
@@ -1,104 +1,105 @@ -from .common import InfoExtractor -from ..networking.exceptions import HTTPError +from .streaks import StreaksBaseIE from ..utils import ( - ExtractorError, clean_html, int_or_none, str_or_none, unified_timestamp, - urljoin, + url_or_none, ) -from ..utils.traversal im...
yt_dlp/extractor/tbsjp.py
26
Python
0.571
suggestion
94
51
51
false
[ie/tbsjp] Fix extractor
13,485
yt-dlp/yt-dlp
132,642
Python
doe1080
garret1317
'series_id': '14694', 'episode': '次世代リアクション王発掘トーナメント', 'episode_number': 335, 'episode_id': '14694_2090934_1000117476', 'timestamp': 1749547434, 'upload_date': '20250610', 'release_timestamp': 1749646802, 'release_date': '20...
filter out `['']` ```suggestion 'cast': ('credit', ..., 'name', ..., 'value', {clean_html}, any, {lambda x: x.split(',')}, ..., {str.strip}, filter, all, filter), ```
'series_id': '14694', 'episode': 'クロちゃん、寝て起きたら川のほとりにいてその向こう岸に亡くなった父親がいたら死の淵にいるかと思う説 ほか', 'episode_number': 341, 'episode_id': '14694_2094162_1000123656', 'timestamp': 1753778992, 'upload_date': '20250729', 'release_timestamp': 175388040...
@@ -1,104 +1,105 @@ -from .common import InfoExtractor -from ..networking.exceptions import HTTPError +from .streaks import StreaksBaseIE from ..utils import ( - ExtractorError, clean_html, int_or_none, str_or_none, unified_timestamp, - urljoin, + url_or_none, ) -from ..utils.traversal im...
yt_dlp/extractor/tbsjp.py
26
Python
0.857
suggestion
185
51
51
false
[ie/tbsjp] Fix extractor
13,485
yt-dlp/yt-dlp
132,642
Python
doe1080
garret1317
from .streaks import StreaksBaseIE from ..utils import ( clean_html, int_or_none, str_or_none, unified_timestamp, url_or_none, ) from ..utils.traversal import traverse_obj class TBSJPBaseIE(StreaksBaseIE): def _window_app(self, webpage, name, item_id, fatal=True): return self._search_j...
- to stick with convention let's begin the method name with a verb - passing a `default` value other than `NO_DEFAULT` to `_search_json()` will always result in `fatal=False`. let's simplify by just using `**kwargs` instead ```suggestion def _search_window_app_json(self, webpage, name, item_id, **kwargs): ...
from .streaks import StreaksBaseIE from ..utils import ( clean_html, int_or_none, str_or_none, unified_timestamp, url_or_none, ) from ..utils.traversal import traverse_obj class TBSJPBaseIE(StreaksBaseIE): def _search_window_app_json(self, webpage, name, item_id, **kwargs): return self...
@@ -1,104 +1,105 @@ -from .common import InfoExtractor -from ..networking.exceptions import HTTPError +from .streaks import StreaksBaseIE from ..utils import ( - ExtractorError, clean_html, int_or_none, str_or_none, unified_timestamp, - urljoin, + url_or_none, ) -from ..utils.traversal im...
yt_dlp/extractor/tbsjp.py
14
Python
0.857
refactor
416
39
39
false
[ie/tbsjp] Fix extractor
13,485
yt-dlp/yt-dlp
132,642
Python
bashonly
garret1317
'uploader': 'TBS', 'uploader_id': 'tbs', 'duration': 2761, 'thumbnail': 'md5:76882f287053dfec6a5adffad70ff1e3', 'categories': ['エンタメ', '水曜日のダウンタウン', 'ダウンタウン', '浜田雅功', '松本人志', '水ダウ', 'バラエティ', '動画'], 'cast': ['浜田\u3000雅功', '千原\u3000ジュニア', 'くっきー!(野性爆弾...
```suggestion meta = self._search_window_app_json(webpage, 'episode', video_id, fatal=False) ```
'uploader': 'TBS', 'uploader_id': 'tbs', 'duration': 2752, 'thumbnail': 'md5:d8855c8c292683c95a84cafdb42300bc', 'categories': ['エンタメ', '水曜日のダウンタウン', 'ダウンタウン', '浜田雅功', '松本人志', '水ダウ', '動画', 'バラエティ'], 'cast': ['浜田 雅功', '藤本 敏史', 'ビビる 大木', '千原 ジュニア', '横...
@@ -1,104 +1,105 @@ -from .common import InfoExtractor -from ..networking.exceptions import HTTPError +from .streaks import StreaksBaseIE from ..utils import ( - ExtractorError, clean_html, int_or_none, str_or_none, unified_timestamp, - urljoin, + url_or_none, ) -from ..utils.traversal im...
yt_dlp/extractor/tbsjp.py
26
Python
0.714
suggestion
106
51
51
false
[ie/tbsjp] Fix extractor
13,485
yt-dlp/yt-dlp
132,642
Python
bashonly
garret1317
'duration': ('duration', {int_or_none}), 'episode_number': ('episode_number', {int_or_none}), 'series_id': ('show_content_id', {str}), })), 'id': video_id, } class TBSJPProgramIE(TBSJPBaseIE): _VALID_URL = r'https?://cu\.tbs\.co\.jp/p...
```suggestion meta = self._search_window_app_json(webpage, 'programme', programme_id) ```
}), **traverse_obj(episode, ('tv_episode_info', { 'duration': ('duration', {int_or_none}), 'episode_number': ('episode_number', {int_or_none}), 'series_id': ('show_content_id', {str}), })), 'id': video_id, } class ...
@@ -1,104 +1,105 @@ -from .common import InfoExtractor -from ..networking.exceptions import HTTPError +from .streaks import StreaksBaseIE from ..utils import ( - ExtractorError, clean_html, int_or_none, str_or_none, unified_timestamp, - urljoin, + url_or_none, ) -from ..utils.traversal im...
yt_dlp/extractor/tbsjp.py
26
Python
0.571
suggestion
99
51
51
false
[ie/tbsjp] Fix extractor
13,485
yt-dlp/yt-dlp
132,642
Python
bashonly
garret1317
'id': programme_id, **traverse_obj(programme, { 'categories': ('keywords', ...), 'id': ('tv_episode_info', 'show_content_id', {str_or_none}), 'description': ('custom_data', 'program_description'), 'series': ('custom_data', 'program_...
```suggestion meta = self._search_window_app_json(webpage, 'playlist', playlist_id) ```
'entries': [self.url_result(f'https://cu.tbs.co.jp/episode/{video_id}', TBSJPEpisodeIE, video_id) for video_id in traverse_obj(programme, ('custom_data', 'seriesList', 'episodeCode', ...))], 'id': programme_id, **traverse_obj(programme, { 'cate...
@@ -129,8 +130,8 @@ class TBSJPPlaylistIE(InfoExtractor): def _real_extract(self, url): playlist_id = self._match_id(url) - page = self._download_webpage(url, playlist_id) - meta = self._search_json(r'window\.app\s*=', page, 'playlist info', playlist_id) + webpage = self._download_w...
yt_dlp/extractor/tbsjp.py
26
Python
0.571
suggestion
97
44
46
false
[ie/tbsjp] Fix extractor
13,485
yt-dlp/yt-dlp
132,642
Python
bashonly
garret1317
'series_id': '14694', 'episode': '次世代リアクション王発掘トーナメント', 'episode_number': 335, 'episode_id': '14694_2090934_1000117476', 'timestamp': 1749547434, 'upload_date': '20250610', 'release_timestamp': 1749646802, 'release_date': '20...
line too long ```suggestion 'cast': ( 'credit', ..., 'name', ..., 'value', {clean_html}, any, {lambda x: x.split(',')}, ..., {str.strip}, filter, all, filter), ```
'series_id': '14694', 'episode': 'クロちゃん、寝て起きたら川のほとりにいてその向こう岸に亡くなった父親がいたら死の淵にいるかと思う説 ほか', 'episode_number': 341, 'episode_id': '14694_2094162_1000123656', 'timestamp': 1753778992, 'upload_date': '20250729', 'release_timestamp': 175388040...
@@ -1,104 +1,105 @@ -from .common import InfoExtractor -from ..networking.exceptions import HTTPError +from .streaks import StreaksBaseIE from ..utils import ( - ExtractorError, clean_html, int_or_none, str_or_none, unified_timestamp, - urljoin, + url_or_none, ) -from ..utils.traversal im...
yt_dlp/extractor/tbsjp.py
26
Python
0.929
refactor
224
51
51
false
[ie/tbsjp] Fix extractor
13,485
yt-dlp/yt-dlp
132,642
Python
bashonly
garret1317
'cast': ['浜田 雅功', '藤本 敏史', 'ビビる 大木', '千原 ジュニア', '横澤 夏子', 'せいや', 'あの', '服部 潤'], 'genres': ['variety'], 'series': '水曜日のダウンタウン', 'series_id': '14694', 'episode': 'クロちゃん、寝て起きたら川のほとりにいてその向こう岸に亡くなった父親がいたら死の淵にいるかと思う説 ほか', 'episode_number': 341, ...
```suggestion 'tbs', f'ref:{video_id}', headers={'Origin': 'https://cu.tbs.co.jp'}), ```
'cast': ['浜田 雅功', '藤本 敏史', 'ビビる 大木', '千原 ジュニア', '横澤 夏子', 'せいや', 'あの', '服部 潤'], 'genres': ['variety'], 'series': '水曜日のダウンタウン', 'series_id': '14694', 'episode': 'クロちゃん、寝て起きたら川のほとりにいてその向こう岸に亡くなった父親がいたら死の淵にいるかと思う説 ほか', 'episode_number': 341, ...
@@ -1,104 +1,107 @@ -from .common import InfoExtractor -from ..networking.exceptions import HTTPError +from .streaks import StreaksBaseIE from ..utils import ( - ExtractorError, clean_html, int_or_none, str_or_none, unified_timestamp, - urljoin, + url_or_none, ) -from ..utils.traversal im...
yt_dlp/extractor/tbsjp.py
26
Python
0.714
suggestion
106
51
51
false
[ie/tbsjp] Fix extractor
13,485
yt-dlp/yt-dlp
132,642
Python
bashonly
garret1317
from .common import InfoExtractor class FilmArchivIE(InfoExtractor): IE_NAME = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/(?:de|en)/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' _TESTS = [{ 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p7xKrXUPBwoNE9x6mh', ...
```suggestion r'<title-div[^>]*>\s*(.+?)\s*</title-div>', ```
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,...
@@ -0,0 +1,45 @@ +from .common import InfoExtractor + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/(?:de|en)/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' + _TESTS = [{ + 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p...
yt_dlp/extractor/filmarchiv.py
24
Python
0.571
suggestion
75
46
49
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
grqz
4elta
_TESTS = [{ 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p7xKrXUPBwoNE9x6mh', 'md5': 'TODO: md5 sum of the first 10241 bytes of the video file (use --test)', 'info_dict': { 'id': 'f_0305p7xKrXUPBwoNE9x6mh', 'ext': 'mkv', 'title': 'Der Wur...
```suggestion 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p7xKrXUPBwoNE9x6mh', 'md5': '54a6596f6a84624531866008a77fa27a', 'info_dict': { 'id': 'f_0305p7xKrXUPBwoNE9x6mh', 'ext': 'mp4', 'title': 'Der Wurstelprater zur Kaiserzeit', ...
) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,})' _TESTS = [{ 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p7xKrXUPBwoNE9x6mh', 'md5': '54a6596f6a84624531866008...
@@ -0,0 +1,45 @@ +from .common import InfoExtractor + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/(?:de|en)/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' + _TESTS = [{ + 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p...
yt_dlp/extractor/filmarchiv.py
26
Python
0.786
suggestion
501
40
47
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
grqz
4elta
class FilmArchivIE(InfoExtractor): IE_NAME = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/(?:de|en)/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' _TESTS = [{ 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p7xKrXUPBwoNE9x6mh', 'md5': 'TODO: md5 sum of the firs...
```suggestion description = traverse_obj(webpage, ( {find_elements( tag='div', attr='class', value=r'[^\'"]*(?<=[\'"\s])border-base-content(?=[\'"\s])[^\'"]*', html=False, regex=True)}, ..., {find_elements( tag='div',...
find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,})' _TESTS = [{ 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p7xKrX...
@@ -0,0 +1,45 @@ +from .common import InfoExtractor + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/(?:de|en)/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' + _TESTS = [{ + 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p...
yt_dlp/extractor/filmarchiv.py
26
Python
0.786
suggestion
526
43
50
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
grqz
4elta
'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p7xKrXUPBwoNE9x6mh', 'md5': 'TODO: md5 sum of the first 10241 bytes of the video file (use --test)', 'info_dict': { 'id': 'f_0305p7xKrXUPBwoNE9x6mh', 'ext': 'mkv', 'title': 'Der Wurstelprater zur K...
```suggestion og_img = self._html_search_meta('og:image', webpage, 'image URL', fatal=True) prefix = self._search_regex( r'/videostatic/([^/]+/[^_]+_[^/]+)/poster.jpg', og_img, 'prefix') ```
class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,})' _TESTS = [{ 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p7xKrXUPBwoNE9x6mh', 'md5': '54a6596f6a84624531866008a7...
@@ -0,0 +1,45 @@ +from .common import InfoExtractor + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/(?:de|en)/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' + _TESTS = [{ + 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p...
yt_dlp/extractor/filmarchiv.py
26
Python
0.786
suggestion
222
39
46
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
grqz
4elta
'id': 'f_0305p7xKrXUPBwoNE9x6mh', 'ext': 'mkv', 'title': 'Der Wurstelprater zur Kaiserzeit', 'description': 'md5:9843f92df5cc9a4975cee7aabcf6e3b2', 'thumbnail': 'https://img.filmarchiv.at/unsafe/1024x1024/videostatic/f_0305/p7xKrXUPBwoNE9x6mh_v1/poster.jpg', ...
```suggestion formats, subtitles = self._extract_m3u8_formats_and_subtitles( f'https://cdn.filmarchiv.at/{prefix}_sv1/playlist.m3u8', media_id) ```
IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,})' _TESTS = [{ 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p7xKrXUPBwoNE9x6mh', 'md5': '54a6596f6a84624531866008a77fa27a', 'info_dict': { ...
@@ -0,0 +1,45 @@ +from .common import InfoExtractor + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/(?:de|en)/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' + _TESTS = [{ + 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p...
yt_dlp/extractor/filmarchiv.py
26
Python
0.786
refactor
170
36
43
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
grqz
4elta
}] def _real_extract(self, url): media_id = self._match_id(url) webpage = self._download_webpage(url, media_id) title = self._html_search_regex( r'<title-div [^>]+>\s*(.+?)\s*</title-div>', webpage, 'title') description = self._html_search_regex( ...
```suggestion 'thumbnail': f'https://cdn.filmarchiv.at/{prefix}/poster.jpg', ```
'id': 'f_0305p7xKrXUPBwoNE9x6mh', 'ext': 'mp4', 'title': 'Der Wurstelprater zur Kaiserzeit', 'description': 'md5:9843f92df5cc9a4975cee7aabcf6e3b2', 'thumbnail': r're:https://cdn\.filmarchiv\.at/f_0305/p7xKrXUPBwoNE9x6mh_v1/poster\.jpg', }, }, { ...
@@ -0,0 +1,45 @@ +from .common import InfoExtractor + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/(?:de|en)/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' + _TESTS = [{ + 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p...
yt_dlp/extractor/filmarchiv.py
26
Python
0.571
suggestion
94
30
37
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
grqz
4elta
from .common import InfoExtractor class FilmArchivIE(InfoExtractor): IE_NAME = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/(?:de|en)/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' _TESTS = [{ 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p7xKrXUPBwoNE9x6mh', ...
```suggestion from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import find_elements, traverse_obj ```
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,...
@@ -0,0 +1,45 @@ +from .common import InfoExtractor
yt_dlp/extractor/filmarchiv.py
1
Python
0.786
refactor
144
26
26
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
grqz
4elta
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import find_elements, traverse_obj class FilmArchivIE(InfoExtractor): IE_NAME = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/(?:de|en)/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' _TESTS = [{ ...
```suggestion _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/(?:de|en)/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' ``` can you provide a test url for `en` as well
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,...
@@ -0,0 +1,55 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import find_elements, traverse_obj + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/(?:de|en)/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)'
yt_dlp/extractor/filmarchiv.py
8
Python
0.714
suggestion
170
33
33
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
grqz
4elta
from ..utils import clean_html from ..utils.traversal import find_elements, traverse_obj class FilmArchivIE(InfoExtractor): IE_NAME = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' _TESTS = [{ 'url': 'https://www.filmarchiv.at/de/film...
```suggestion title = self._html_search_regex( r'<title-div[^>]*>\s*(.+?)\s*</title-div>', webpage, 'title') ``` can be put in one line since the regex is short enough
from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,})' _TESTS = [{ 'url':...
@@ -0,0 +1,55 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import find_elements, traverse_obj + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' + _...
yt_dlp/extractor/filmarchiv.py
26
Python
0.714
suggestion
191
51
51
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
grqz
4elta
def _real_extract(self, url): media_id = self._match_id(url) webpage = self._download_webpage(url, media_id) title = self._html_search_regex( r'<title-div[^>]*>\s*(.+?)\s*</title-div>', webpage, 'title') description = traverse_obj(webpage, ( {find_elements(...
the `websockets` library is an optional dependency for yt-dlp. Can you add more tests to make sure this url always works?
'description': 'md5:9843f92df5cc9a4975cee7aabcf6e3b2', 'thumbnail': r're:https://cdn\.filmarchiv\.at/f_0305/p7xKrXUPBwoNE9x6mh_v1/poster\.jpg', }, }, { 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0306vI3wO0tJIsfrqYFQXF', 'md5': '595385d7f54cb6529140ee8d...
@@ -0,0 +1,54 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import find_elements, traverse_obj + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' + _...
yt_dlp/extractor/filmarchiv.py
26
Python
0.5
question
121
36
34
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
grqz
4elta
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import find_elements, traverse_obj class FilmArchivIE(InfoExtractor): IE_NAME = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' _TESTS = [{ 'url': ...
```suggestion title = self._html_search_regex(r'(?s)<title-div\b[^>]*>([^<]+)</title-div>', webpage, 'title') ``` lets avoid `.+?`
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,...
@@ -0,0 +1,54 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import find_elements, traverse_obj + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' + _...
yt_dlp/extractor/filmarchiv.py
26
Python
0.786
suggestion
141
51
51
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
grqz
4elta
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import find_elements, traverse_obj class FilmArchivIE(InfoExtractor): IE_NAME = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' _TESTS = [{ 'url': ...
```suggestion from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) ```
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,...
@@ -0,0 +1,53 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import find_elements, traverse_obj
yt_dlp/extractor/filmarchiv.py
3
Python
0.714
suggestion
112
28
28
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
doe1080
4elta
webpage = self._download_webpage(url, media_id) title = traverse_obj(webpage, ({find_elements(tag='title-div')}, {clean_html})) description = traverse_obj(webpage, ( {find_elements( tag='div', attr='class', value=r'[^\'"]*(?<=[\'"\s])border-base-cont...
```suggestion 'title': traverse_obj(webpage, ({find_element(tag='title-div')}, {clean_html})), ```
}, { 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0306vI3wO0tJIsfrqYFQXF', 'md5': '595385d7f54cb6529140ee8de7d1c3c7', 'info_dict': { 'id': 'f_0306vI3wO0tJIsfrqYFQXF', 'ext': 'mp4', 'title': 'Vor 70 Jahren: Wettgehen der Briefträger in Wien', ...
@@ -0,0 +1,53 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import find_elements, traverse_obj + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' + _...
yt_dlp/extractor/filmarchiv.py
26
Python
0.714
suggestion
112
32
31
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
doe1080
4elta
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_NAME = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' ...
```suggestion _TESTS = [{ ```
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,...
@@ -0,0 +1,68 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import ( + find_element, + find_elements, + traverse_obj, +) + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/...
yt_dlp/extractor/filmarchiv.py
14
Python
0.429
suggestion
35
39
39
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
bashonly
4elta
'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0306vI3wO0tJIsfrqYFQXF', 'md5': '595385d7f54cb6529140ee8de7d1c3c7', 'info_dict': { 'id': 'f_0306vI3wO0tJIsfrqYFQXF', 'ext': 'mp4', 'title': 'Vor 70 Jahren: Wettgehen der Briefträger in Wien', ...
can we simplify these regex patterns? it will make this much more readable and compact enough to actually inline in the return now ```suggestion description = traverse_obj(webpage, ( {find_elements(tag='div', attr='class', value=r'.*\bborder-base-content\b', regex=True)}, ..., {find_...
'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0306vI3wO0tJIsfrqYFQXF', 'md5': '595385d7f54cb6529140ee8de7d1c3c7', 'info_dict': { 'id': 'f_0306vI3wO0tJIsfrqYFQXF', 'ext': 'mp4', 'title': 'Vor 70 Jahren: Wettgehen der Briefträger in Wien', ...
@@ -0,0 +1,65 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import ( + find_element, + find_elements, + traverse_obj, +) + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/...
yt_dlp/extractor/filmarchiv.py
26
Python
0.857
refactor
444
43
30
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
bashonly
4elta
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_NAME = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' ...
```suggestion 'thumbnail': r're:https://cdn\.filmarchiv\.at/f_0305/p7xKrXUPBwoNE9x6mh_v1/poster\.jpg', ```
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,...
@@ -0,0 +1,65 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import ( + find_element, + find_elements, + traverse_obj, +) + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/...
yt_dlp/extractor/filmarchiv.py
21
Python
0.714
suggestion
120
46
46
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
bashonly
4elta
traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_NAME = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' _TESTS = [{ 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p7xKrXUPBwoNE9x6mh', 'md5': '54a6596f6a...
```suggestion 'thumbnail': r're:https://cdn\.filmarchiv\.at/f_0306/vI3wO0tJIsfrqYFQXF_v1/poster\.jpg', ```
traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,})' _TESTS = [{ 'url': 'https://www.filmarchiv.at/de/filmarchiv-on/video/f_0305p7xKrXUPBwoNE9x6mh', 'md5': '54a659...
@@ -0,0 +1,65 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import ( + find_element, + find_elements, + traverse_obj, +) + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/...
yt_dlp/extractor/filmarchiv.py
26
Python
0.714
suggestion
120
51
48
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
bashonly
4elta
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_NAME = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>[0-9a-zA-Z_]+)' ...
```suggestion _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,})' ```
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,...
@@ -0,0 +1,65 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import ( + find_element, + find_elements, + traverse_obj, +) + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/...
yt_dlp/extractor/filmarchiv.py
12
Python
0.714
suggestion
122
37
37
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
bashonly
4elta
'thumbnail': r're:https://cdn.filmarchiv.at/f_0306/vI3wO0tJIsfrqYFQXF[^/]*/poster.jpg$', }, }] def _real_extract(self, url): media_id = self._match_id(url) webpage = self._download_webpage(url, media_id) description = traverse_obj(webpage, ( {find_elemen...
It looks like we can get everything we need from the `media_id` ```suggestion path = '/'.join((media_id[:6], media_id[6:])) formats, subtitles = self._extract_m3u8_formats_and_subtitles( f'https://cdn.filmarchiv.at/{path}_sv1/playlist.m3u8', media_id) ```
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,...
@@ -0,0 +1,65 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import ( + find_element, + find_elements, + traverse_obj, +) + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/...
yt_dlp/extractor/filmarchiv.py
26
Python
0.857
refactor
288
36
53
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
bashonly
4elta
webpage = self._download_webpage(url, media_id) description = traverse_obj(webpage, ( {find_elements( tag='div', attr='class', value=r'[^\'"]*(?<=[\'"\s])border-base-content(?=[\'"\s])[^\'"]*', html=False, regex=True)}, ..., {find_...
```suggestion 'thumbnail': f'https://cdn.filmarchiv.at/{path}_v1/poster.jpg', ```
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,...
@@ -0,0 +1,65 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import ( + find_element, + find_elements, + traverse_obj, +) + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON' + _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/...
yt_dlp/extractor/filmarchiv.py
26
Python
0.571
suggestion
95
30
53
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
bashonly
4elta
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_NAME = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,...
```suggestion IE_DESC = 'FILMARCHIV ON' ```
from .common import InfoExtractor from ..utils import clean_html from ..utils.traversal import ( find_element, find_elements, traverse_obj, ) class FilmArchivIE(InfoExtractor): IE_DESC = 'FILMARCHIV ON' _VALID_URL = r'https?://(?:www\.)?filmarchiv\.at/de/filmarchiv-on/video/(?P<id>f_[0-9a-zA-Z]{5,...
@@ -0,0 +1,52 @@ +from .common import InfoExtractor +from ..utils import clean_html +from ..utils.traversal import ( + find_element, + find_elements, + traverse_obj, +) + + +class FilmArchivIE(InfoExtractor): + IE_NAME = 'FILMARCHIV ON'
yt_dlp/extractor/filmarchiv.py
11
Python
0.429
suggestion
49
36
36
false
[ie/filmarchiv] Add extractor
13,490
yt-dlp/yt-dlp
132,642
Python
bashonly
4elta
class TheHighWireIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?thehighwire\.com/ark-videos/(?P<id>[^/?#]+)' _EMBED_URL = 'https://app.arkengine.com/embed/{id}' _TESTS = [{ 'url': 'https://thehighwire.com/ark-videos/the-deposition-of-stanley-plotkin/', 'info_dict': { 'id': ...
more simply ```suggestion embed_url = traverse_obj(webpage, ( {find_element(cls='ark-video-embed', html=True)}, {extract_attributes}, 'src', {url_or_none}, {require('embed URL')})) embed_page = self._download_webpage(embed_url, display_id) ```
clean_html, extract_attributes, url_or_none, ) from ..utils.traversal import ( find_element, require, traverse_obj, ) class TheHighWireIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?thehighwire\.com/ark-videos/(?P<id>[^/?#]+)' _TESTS = [{ 'url': 'https://thehighwire.com/a...
@@ -0,0 +1,42 @@ +from .common import InfoExtractor + +class TheHighWireIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?thehighwire\.com/ark-videos/(?P<id>[^/?#]+)' + _EMBED_URL = 'https://app.arkengine.com/embed/{id}' + _TESTS = [{ + 'url': 'https://thehighwire.com/ark-videos/the-deposition-of-s...
yt_dlp/extractor/thehighwire.py
26
Python
0.857
refactor
289
41
42
false
[ie/TheHighWire] Add extractor
13,505
yt-dlp/yt-dlp
132,642
Python
doe1080
swayll
display_id = self._match_id(url) webpage = self._download_webpage(url, display_id) iframe_url = self._search_regex( r'<iframe[^>]+src=["\'](https?://app\.arkengine\.com/embed/[^"\']+)', webpage, 'iframe URL') video_id = self._search_regex( r'embed/([a...
`_parse_html5_media_entries` takes on most processing ```suggestion return { 'id': display_id, **traverse_obj(webpage, { 'title': ({find_element(cls='section-header')}, {clean_html}), 'description': ({find_element(cls='episode-description__copy')}, {...
'url': 'https://thehighwire.com/ark-videos/the-deposition-of-stanley-plotkin/', 'info_dict': { 'id': 'the-deposition-of-stanley-plotkin', 'ext': 'mp4', 'title': 'THE DEPOSITION OF STANLEY PLOTKIN', 'description': 'md5:6d0be4f1181daaa10430fd8b945a5e54', ...
@@ -0,0 +1,42 @@ +from .common import InfoExtractor + +class TheHighWireIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?thehighwire\.com/ark-videos/(?P<id>[^/?#]+)' + _EMBED_URL = 'https://app.arkengine.com/embed/{id}' + _TESTS = [{ + 'url': 'https://thehighwire.com/ark-videos/the-deposition-of-s...
yt_dlp/extractor/thehighwire.py
26
Python
0.786
suggestion
469
27
28
false
[ie/TheHighWire] Add extractor
13,505
yt-dlp/yt-dlp
132,642
Python
doe1080
swayll
from .common import InfoExtractor class TheHighWireIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?thehighwire\.com/ark-videos/(?P<id>[^/?#]+)' _EMBED_URL = 'https://app.arkengine.com/embed/{id}' _TESTS = [{ 'url': 'https://thehighwire.com/ark-videos/the-deposition-of-stanley-plotkin/', ...
```suggestion from .common import InfoExtractor from ..utils import ( clean_html, extract_attributes, url_or_none, ) from ..utils.traversal import ( find_element, require, traverse_obj, ) ```
from .common import InfoExtractor from ..utils import ( clean_html, extract_attributes, url_or_none, ) from ..utils.traversal import ( find_element, require, traverse_obj, ) class TheHighWireIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?thehighwire\.com/ark-videos/(?P<id>[^/?#]+)' ...
@@ -0,0 +1,42 @@ +from .common import InfoExtractor
yt_dlp/extractor/thehighwire.py
1
Python
0.857
refactor
229
26
26
false
[ie/TheHighWire] Add extractor
13,505
yt-dlp/yt-dlp
132,642
Python
doe1080
swayll
from .common import InfoExtractor class TheHighWireIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?thehighwire\.com/ark-videos/(?P<id>[^/?#]+)' _EMBED_URL = 'https://app.arkengine.com/embed/{id}' _TESTS = [{ 'url': 'https://thehighwire.com/ark-videos/the-deposition-of-stanley-plotkin/', ...
```suggestion _TESTS = [{ 'url': 'https://thehighwire.com/ark-videos/the-deposition-of-stanley-plotkin/', 'info_dict': { 'id': 'the-deposition-of-stanley-plotkin', 'ext': 'mp4', 'title': 'THE DEPOSITION OF STANLEY PLOTKIN', 'description': 'md5:6...
from .common import InfoExtractor from ..utils import ( clean_html, extract_attributes, url_or_none, ) from ..utils.traversal import ( find_element, require, traverse_obj, ) class TheHighWireIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?thehighwire\.com/ark-videos/(?P<id>[^/?#]+)' ...
@@ -0,0 +1,42 @@ +from .common import InfoExtractor + +class TheHighWireIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?thehighwire\.com/ark-videos/(?P<id>[^/?#]+)' + _EMBED_URL = 'https://app.arkengine.com/embed/{id}' + _TESTS = [{ + 'url': 'https://thehighwire.com/ark-videos/the-deposition-of-s...
yt_dlp/extractor/thehighwire.py
14
Python
0.786
suggestion
457
39
39
false
[ie/TheHighWire] Add extractor
13,505
yt-dlp/yt-dlp
132,642
Python
doe1080
swayll
'id': 'the-deposition-of-stanley-plotkin', 'ext': 'mp4', 'title': 'THE DEPOSITION OF STANLEY PLOTKIN', 'description': 'md5:6d0be4f1181daaa10430fd8b945a5e54', 'thumbnail': r're:https?://static\.arkengine\.com/video/.+\.jpg', }, }] def _real_ext...
sorry, an extra blank line slipped in ```suggestion ```
'id': 'the-deposition-of-stanley-plotkin', 'ext': 'mp4', 'title': 'THE DEPOSITION OF STANLEY PLOTKIN', 'description': 'md5:6d0be4f1181daaa10430fd8b945a5e54', 'thumbnail': r're:https?://static\.arkengine\.com/video/.+\.jpg', }, }] def _real_ext...
@@ -0,0 +1,44 @@ +from .common import InfoExtractor +from ..utils import ( + clean_html, + extract_attributes, + url_or_none, +) +from ..utils.traversal import ( + find_element, + require, + traverse_obj, +) + + +class TheHighWireIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?thehighwire\.c...
yt_dlp/extractor/thehighwire.py
26
Python
0.571
suggestion
59
27
26
false
[ie/TheHighWire] Add extractor
13,505
yt-dlp/yt-dlp
132,642
Python
doe1080
swayll
import hashlib import random import re import urllib.parse from .common import InfoExtractor from ..utils import ( ExtractorError, clean_html, int_or_none, parse_duration, str_or_none, try_get, unescapeHTML, update_url, update_url_query, url_or_none, ) from ..utils.traversal imp...
please don't unnecessarily move the line when you are changing it; it makes eyeballing the diff more difficult when reviewing. please revert the added newline also
import hashlib import random import re import urllib.parse from .common import InfoExtractor from ..utils import ( ExtractorError, clean_html, int_or_none, parse_duration, str_or_none, try_get, unescapeHTML, update_url, update_url_query, url_or_none, ) from ..utils.traversal imp...
@@ -7,23 +7,25 @@ from .common import InfoExtractor from ..utils import ( ExtractorError, + clean_html, int_or_none, parse_duration, str_or_none, try_get, unescapeHTML, - unified_strdate, + update_url, update_url_query, url_or_none, ) from ..utils.traversal import tr...
yt_dlp/extractor/huya.py
26
Python
0.429
style
164
51
51
false
[ie/huya:live] Fix extractor
13,520
yt-dlp/yt-dlp
132,642
Python
bashonly
doe1080
'view_count': int, }, }] def _real_extract(self, url: str): video_id = self._match_id(url) moment = self._download_json( 'https://liveapi.huya.com/moment/getMomentContent', video_id, query={'videoId': video_id})['data']['moment'] formats = []...
no point to this if it's not expected; core code will `raise_no_formats` if we return an empty formats list ```suggestion ```
}, }] def _real_extract(self, url: str): video_id = self._match_id(url) moment = self._download_json( 'https://liveapi.huya.com/moment/getMomentContent', video_id, query={'videoId': video_id})['data']['moment'] formats = [] for definition in trav...
@@ -139,73 +141,106 @@ def encrypt(self, params, stream_info, stream_name): class HuyaVideoIE(InfoExtractor): - _VALID_URL = r'https?://(?:www\.)?huya\.com/video/play/(?P<id>\d+)\.html' IE_NAME = 'huya:video' IE_DESC = '虎牙视频' + _VALID_URL = r'https?://(?:www\.)?huya\.com/video/play/(?P<id>\d+)\.h...
yt_dlp/extractor/huya.py
26
Python
0.714
suggestion
127
48
45
false
[ie/huya:live] Fix extractor
13,520
yt-dlp/yt-dlp
132,642
Python
bashonly
doe1080
note=f'Downloading space page {page_idx}', headers={'Referer': url}) except ExtractorError as e: if isinstance(e.cause, HTTPError) and e.cause.status == 412: raise ExtractorError( 'Request is blocked by server (412), please wait...
I know it's old code, but let's clean it up while we're here ```suggestion for entry in traverse_obj(page_data, ('list', 'vlist', ..., {dict})): ```
query=self._sign_wbi(query, playlist_id), note=f'Downloading space page {page_idx}', headers={'Referer': url}) except ExtractorError as e: if isinstance(e.cause, HTTPError) and e.cause.status == 412: raise ExtractorError( ...
@@ -1283,7 +1302,13 @@ def get_metadata(page_data): def get_entries(page_data): for entry in traverse_obj(page_data, ('list', 'vlist')) or []:
yt_dlp/extractor/bilibili.py
26
Python
0.714
suggestion
163
51
51
false
[ie/BilibiliSpaceVideo] Extract hidden-mode collections as playlists
13,533
yt-dlp/yt-dlp
132,642
Python
bashonly
c-basalt
if isinstance(e.cause, HTTPError) and e.cause.status == 412: raise ExtractorError( 'Request is blocked by server (412), please wait and try later.', expected=True) raise status_code = response['code'] if status_code == -...
```suggestion # hidden-mode collection doesn't show its videos in uploads; extract as playlist instead ```
except ExtractorError as e: if isinstance(e.cause, HTTPError) and e.cause.status == 412: raise ExtractorError( 'Request is blocked by server (412), please wait and try later.', expected=True) raise status_code = response...
@@ -1283,7 +1302,13 @@ def get_metadata(page_data): def get_entries(page_data): for entry in traverse_obj(page_data, ('list', 'vlist')) or []: - yield self.url_result(f'https://www.bilibili.com/video/{entry["bvid"]}', BiliBiliIE, entry['bvid']) + if traverse_obj(ent...
yt_dlp/extractor/bilibili.py
26
Python
0.786
refactor
128
51
51
false
[ie/BilibiliSpaceVideo] Extract hidden-mode collections as playlists
13,533
yt-dlp/yt-dlp
132,642
Python
bashonly
c-basalt
first_page = fetch_page(0) metadata = get_metadata(first_page) paged_list = InAdvancePagedList( lambda idx: get_entries(fetch_page(idx) if idx else first_page), metadata['page_count'], metadata['page_size']) return metadata, paged_list class BilibiliSpaceVideo...
```suggestion }, { # Hidden-mode collection 'url': 'https://space.bilibili.com/3669403/video', ```
first_page = fetch_page(0) metadata = get_metadata(first_page) paged_list = InAdvancePagedList( lambda idx: get_entries(fetch_page(idx) if idx else first_page), metadata['page_count'], metadata['page_size']) return metadata, paged_list class BilibiliSpaceVideo...
@@ -1226,6 +1226,25 @@ class BilibiliSpaceVideoIE(BilibiliSpaceBaseIE): 'id': '313580179', }, 'playlist_mincount': 92, + }, { + 'url': 'https://space.bilibili.com/3669403/video',
yt_dlp/extractor/bilibili.py
26
Python
0.714
suggestion
122
51
51
false
[ie/BilibiliSpaceVideo] Extract hidden-mode collections as playlists
13,533
yt-dlp/yt-dlp
132,642
Python
bashonly
c-basalt
from .common import InfoExtractor from .kaltura import KalturaIE class UnitedNationsWebTvIE(InfoExtractor): _VALID_URL = r'https?://webtv.un.org/(ar|zh|en|fr|ru|es)/asset/\w+/(?P<id>\w+)' _TESTS = [{ 'url': 'https://webtv.un.org/en/asset/k1o/k1o7stmi6p', 'md5': 'b2f8b3030063298ae841b4b7ddc0147...
```suggestion _VALID_URL = r'https?://webtv.un.org/(?:ar|zh|en|fr|ru|es)/asset/\w+/(?P<id>\w+)' ```
from .common import InfoExtractor from .kaltura import KalturaIE class UnitedNationsWebTvIE(InfoExtractor): _VALID_URL = r'https?://webtv\.un\.org/(?:ar|zh|en|fr|ru|es)/asset/\w+/(?P<id>\w+)' _TESTS = [{ 'url': 'https://webtv.un.org/en/asset/k1o/k1o7stmi6p', 'md5': 'b2f8b3030063298ae841b4b7ddc...
@@ -0,0 +1,32 @@ +from .common import InfoExtractor +from .kaltura import KalturaIE + + +class UnitedNationsWebTvIE(InfoExtractor): + _VALID_URL = r'https?://webtv.un.org/(ar|zh|en|fr|ru|es)/asset/\w+/(?P<id>\w+)'
yt_dlp/extractor/unitednations.py
6
Python
0.714
suggestion
105
31
31
false
[ie/UnitedNationsWebTv] Add extractor
13,538
yt-dlp/yt-dlp
132,642
Python
bashonly
averageFOSSenjoyer
from .common import InfoExtractor from .kaltura import KalturaIE class UnitedNationsWebTvIE(InfoExtractor): _VALID_URL = r'https?://webtv.un.org/(?:ar|zh|en|fr|ru|es)/asset/\w+/(?P<id>\w+)' _TESTS = [{ 'url': 'https://webtv.un.org/en/asset/k1o/k1o7stmi6p', 'md5': 'b2f8b3030063298ae841b4b7ddc01...
```suggestion _VALID_URL = r'https?://webtv\.un\.org/(?:ar|zh|en|fr|ru|es)/asset/\w+/(?P<id>\w+)' ```
from .common import InfoExtractor from .kaltura import KalturaIE class UnitedNationsWebTvIE(InfoExtractor): _VALID_URL = r'https?://webtv\.un\.org/(?:ar|zh|en|fr|ru|es)/asset/\w+/(?P<id>\w+)' _TESTS = [{ 'url': 'https://webtv.un.org/en/asset/k1o/k1o7stmi6p', 'md5': 'b2f8b3030063298ae841b4b7ddc...
@@ -0,0 +1,32 @@ +from .common import InfoExtractor +from .kaltura import KalturaIE + + +class UnitedNationsWebTvIE(InfoExtractor): + _VALID_URL = r'https?://webtv.un.org/(?:ar|zh|en|fr|ru|es)/asset/\w+/(?P<id>\w+)'
yt_dlp/extractor/unitednations.py
6
Python
0.714
suggestion
107
31
31
false
[ie/UnitedNationsWebTv] Add extractor
13,538
yt-dlp/yt-dlp
132,642
Python
bashonly
averageFOSSenjoyer
from .common import InfoExtractor class BTVPlusIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?btvplus\.bg/produkt/predavaniya/(?P<id>\d+)/.*' _TESTS = [{ 'url': 'https://btvplus.bg/produkt/predavaniya/60119/sezon-1/ostrovat-na-100-te-grivni-sezon-1-epizod-11-02-10-2024', 'info_dict': { ...
Don't need the trailing part of the regex and might as well match the other sections ```suggestion _VALID_URL = r'https?://(?:www\.)?btvplus\.bg/produkt/(?:predavaniya|seriali|novini)/(?P<id>\d+)' ```
from .common import InfoExtractor from ..utils import ( bug_reports_message, clean_html, get_element_by_class, js_to_json, mimetype2ext, strip_or_none, url_or_none, urljoin, ) from ..utils.traversal import traverse_obj class BTVPlusIE(InfoExtractor): _VALID_URL = r'https?://(?:www\...
@@ -0,0 +1,43 @@ +from .common import InfoExtractor + + +class BTVPlusIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?btvplus\.bg/produkt/predavaniya/(?P<id>\d+)/.*'
yt_dlp/extractor/btvplus.py
5
Python
0.786
suggestion
207
30
30
false
[ie/BTVPlus] Add extractor
13,541
yt-dlp/yt-dlp
132,642
Python
seproDev
bubo
from .common import InfoExtractor class BTVPlusIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?btvplus\.bg/produkt/predavaniya/(?P<id>\d+)/.*' _TESTS = [{ 'url': 'https://btvplus.bg/produkt/predavaniya/60119/sezon-1/ostrovat-na-100-te-grivni-sezon-1-epizod-11-02-10-2024', 'info_dict': { ...
I don't think you ever actually ran the tests. The ID doesn't match and the thumbnail and ext is missing. ```suggestion _TESTS = [{ 'url': 'https://btvplus.bg/produkt/predavaniya/67271/btv-reporterite/btv-reporterite-12-07-2025-g', 'info_dict': { 'ext': 'mp4', 'id': '67...
from .common import InfoExtractor from ..utils import ( bug_reports_message, clean_html, get_element_by_class, js_to_json, mimetype2ext, strip_or_none, url_or_none, urljoin, ) from ..utils.traversal import traverse_obj class BTVPlusIE(InfoExtractor): _VALID_URL = r'https?://(?:www\...
@@ -0,0 +1,43 @@ +from .common import InfoExtractor + + +class BTVPlusIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?btvplus\.bg/produkt/predavaniya/(?P<id>\d+)/.*' + _TESTS = [{ + 'url': 'https://btvplus.bg/produkt/predavaniya/60119/sezon-1/ostrovat-na-100-te-grivni-sezon-1-epizod-11-02-10-2024', ...
yt_dlp/extractor/btvplus.py
13
Python
0.786
suggestion
977
38
38
false
[ie/BTVPlus] Add extractor
13,541
yt-dlp/yt-dlp
132,642
Python
seproDev
bubo
from .common import InfoExtractor class BTVPlusIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?btvplus\.bg/produkt/predavaniya/(?P<id>\d+)/.*' _TESTS = [{ 'url': 'https://btvplus.bg/produkt/predavaniya/60119/sezon-1/ostrovat-na-100-te-grivni-sezon-1-epizod-11-02-10-2024', 'info_dict': { ...
```suggestion player_url = self._search_regex( r'var\s+videoUrl\s*=\s*[\'"]([^\'"]+)[\'"]', webpage, 'player URL') ```
from .common import InfoExtractor from ..utils import ( bug_reports_message, clean_html, get_element_by_class, js_to_json, mimetype2ext, strip_or_none, url_or_none, urljoin, ) from ..utils.traversal import traverse_obj class BTVPlusIE(InfoExtractor): _VALID_URL = r'https?://(?:www\...
@@ -0,0 +1,43 @@ +from .common import InfoExtractor + + +class BTVPlusIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?btvplus\.bg/produkt/predavaniya/(?P<id>\d+)/.*' + _TESTS = [{ + 'url': 'https://btvplus.bg/produkt/predavaniya/60119/sezon-1/ostrovat-na-100-te-grivni-sezon-1-epizod-11-02-10-2024', ...
yt_dlp/extractor/btvplus.py
21
Python
0.714
suggestion
154
44
46
false
[ie/BTVPlus] Add extractor
13,541
yt-dlp/yt-dlp
132,642
Python
seproDev
bubo
from .common import InfoExtractor class BTVPlusIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?btvplus\.bg/produkt/predavaniya/(?P<id>\d+)/.*' _TESTS = [{ 'url': 'https://btvplus.bg/produkt/predavaniya/60119/sezon-1/ostrovat-na-100-te-grivni-sezon-1-epizod-11-02-10-2024', 'info_dict': { ...
```suggestion player_config = self._download_json( urljoin('https://btvplus.bg', player_url), video_id)['config'] ```
from .common import InfoExtractor from ..utils import ( bug_reports_message, clean_html, get_element_by_class, js_to_json, mimetype2ext, strip_or_none, url_or_none, urljoin, ) from ..utils.traversal import traverse_obj class BTVPlusIE(InfoExtractor): _VALID_URL = r'https?://(?:www\...
@@ -0,0 +1,43 @@ +from .common import InfoExtractor + + +class BTVPlusIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?btvplus\.bg/produkt/predavaniya/(?P<id>\d+)/.*' + _TESTS = [{ + 'url': 'https://btvplus.bg/produkt/predavaniya/60119/sezon-1/ostrovat-na-100-te-grivni-sezon-1-epizod-11-02-10-2024', ...
yt_dlp/extractor/btvplus.py
25
Python
0.714
suggestion
140
44
50
false
[ie/BTVPlus] Add extractor
13,541
yt-dlp/yt-dlp
132,642
Python
seproDev
bubo
'title': 'Островът на 100-те гривни Сезон 1, епизод 11', 'formats': 'count:1', }, }] def _real_extract(self, url): video_id = self._match_id(url) webpage = self._download_webpage(url, video_id) product_url = self._search_regex( r"var videoUrl...
core code takes care of the default title. We can also partially inline this below. Also extended to properly parse the videojs object ```suggestion videojs_data = self._search_json( r'videojs\(["\'][^"\']+["\'],', player_config, 'videojs data', video_id, transform_source=js_to_json)...
urljoin, ) from ..utils.traversal import traverse_obj class BTVPlusIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?btvplus\.bg/produkt/(?:predavaniya|seriali|novini)/(?P<id>\d+)' _TESTS = [{ 'url': 'https://btvplus.bg/produkt/predavaniya/67271/btv-reporterite/btv-reporterite-12-07-2025-g', ...
@@ -0,0 +1,43 @@ +from .common import InfoExtractor + + +class BTVPlusIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?btvplus\.bg/produkt/predavaniya/(?P<id>\d+)/.*' + _TESTS = [{ + 'url': 'https://btvplus.bg/produkt/predavaniya/60119/sezon-1/ostrovat-na-100-te-grivni-sezon-1-epizod-11-02-10-2024', ...
yt_dlp/extractor/btvplus.py
26
Python
1
bug
948
35
51
false
[ie/BTVPlus] Add extractor
13,541
yt-dlp/yt-dlp
132,642
Python
seproDev
bubo
webpage = self._download_webpage(url, video_id) product_url = self._search_regex( r"var videoUrl\s*=\s*['\"]([^'\"]+)['\"];", webpage, 'product player URL') product_url = 'https://btvplus.bg' + product_url player_data = self._download_json(product_url, video_id...
For the title searching for `<span class="title">` also matches way too much (every episode title on the page). I changed it to use the og tag. ```suggestion 'formats': formats, 'subtitles': subtitles, 'title': strip_or_none( self._og_search_title(webpage, defaul...
_TESTS = [{ 'url': 'https://btvplus.bg/produkt/predavaniya/67271/btv-reporterite/btv-reporterite-12-07-2025-g', 'info_dict': { 'ext': 'mp4', 'id': '67271', 'title': 'bTV Репортерите - 12.07.2025 г.', 'thumbnail': 'https://cdn.btv.bg/media/images/940x52...
@@ -0,0 +1,43 @@ +from .common import InfoExtractor + + +class BTVPlusIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?btvplus\.bg/produkt/predavaniya/(?P<id>\d+)/.*' + _TESTS = [{ + 'url': 'https://btvplus.bg/produkt/predavaniya/60119/sezon-1/ostrovat-na-100-te-grivni-sezon-1-epizod-11-02-10-2024', ...
yt_dlp/extractor/btvplus.py
26
Python
0.857
suggestion
569
28
51
false
[ie/BTVPlus] Add extractor
13,541
yt-dlp/yt-dlp
132,642
Python
seproDev
bubo
from .common import InfoExtractor class BTVPlusIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?btvplus\.bg/produkt/predavaniya/(?P<id>\d+)/.*' _TESTS = [{ 'url': 'https://btvplus.bg/produkt/predavaniya/60119/sezon-1/ostrovat-na-100-te-grivni-sezon-1-epizod-11-02-10-2024', 'info_dict': { ...
```suggestion from .common import InfoExtractor from ..utils import ( bug_reports_message, clean_html, get_element_by_class, js_to_json, strip_or_none, url_or_none, urljoin, ) from ..utils.traversal import traverse_obj ```
from .common import InfoExtractor from ..utils import ( bug_reports_message, clean_html, get_element_by_class, js_to_json, mimetype2ext, strip_or_none, url_or_none, urljoin, ) from ..utils.traversal import traverse_obj class BTVPlusIE(InfoExtractor): _VALID_URL = r'https?://(?:www\...
@@ -0,0 +1,43 @@ +from .common import InfoExtractor
yt_dlp/extractor/btvplus.py
1
Python
1
bug
262
26
26
false
[ie/BTVPlus] Add extractor
13,541
yt-dlp/yt-dlp
132,642
Python
seproDev
bubo
def _real_extract(self, url): video_id = self._match_id(url) webpage = self._download_webpage(url, video_id) player_url = self._search_regex( r'var\s+videoUrl\s*=\s*[\'"]([^\'"]+)[\'"]', webpage, 'player URL') player_config = self._download_json( ...
```suggestion self.report_warning(f'Unknown format type {ext}{bug_reports_message()}') ```
def _real_extract(self, url): video_id = self._match_id(url) webpage = self._download_webpage(url, video_id) player_url = self._search_regex( r'var\s+videoUrl\s*=\s*[\'"]([^\'"]+)[\'"]', webpage, 'player URL') player_config = self._download_json( ...
@@ -0,0 +1,74 @@ +from .common import InfoExtractor +from ..utils import ( + bug_reports_message, + clean_html, + get_element_by_class, + js_to_json, + mimetype2ext, + strip_or_none, + url_or_none, + urljoin, +) +from ..utils.traversal import traverse_obj + + +class BTVPlusIE(InfoExtractor): + ...
yt_dlp/extractor/btvplus.py
26
Python
0.857
bug
108
38
37
false
[ie/BTVPlus] Add extractor
13,541
yt-dlp/yt-dlp
132,642
Python
seproDev
bubo
player_config = self._download_json( urljoin('https://btvplus.bg', player_url), video_id)['config'] videojs_data = self._search_json( r'videojs\(["\'][^"\']+["\'],', player_config, 'videojs data', video_id, transform_source=js_to_json) formats = [] s...
`clean_html` already strips IIRC, but this doesn't really matter I guess ```suggestion 'title': ( strip_or_none(self._og_search_title(webpage, default=None)) or clean_html(get_element_by_class('product-title', webpage))), ```
player_config = self._download_json( urljoin('https://btvplus.bg', player_url), video_id)['config'] videojs_data = self._search_json( r'videojs\(["\'][^"\']+["\'],', player_config, 'videojs data', video_id, transform_source=js_to_json) formats = [] s...
@@ -0,0 +1,73 @@ +from .common import InfoExtractor +from ..utils import ( + bug_reports_message, + clean_html, + get_element_by_class, + js_to_json, + mimetype2ext, + strip_or_none, + url_or_none, + urljoin, +) +from ..utils.traversal import traverse_obj + + +class BTVPlusIE(InfoExtractor): + ...
yt_dlp/extractor/btvplus.py
26
Python
0.786
suggestion
274
30
30
false
[ie/BTVPlus] Add extractor
13,541
yt-dlp/yt-dlp
132,642
Python
bashonly
bubo
res = parse_resolution(k, lenient=True) or parse_resolution(img_url, lenient=True) width, height = res.get('width'), res.get('height') thumbnails.append({ 'id': f'{name}_{width}x{height}', 'url': img_url, 'ext':...
Can you clarify what we're doing here with a comment, please? I'm assuming you need to be authenticated to load the `/my` page? But then we're manually setting a cookie?
'timestamp': 1617029400, 'upload_date': '20210329', 'uploader': '株式会社ドワンゴ', 'view_count': int, }, 'params': {'skip_download': True}, }] def _real_extract(self, url): video_id = self._match_id(url) webpage, urlh = self._download_web...
@@ -779,39 +779,64 @@ class NiconicoLiveIE(NiconicoBaseIE): IE_DESC = 'ニコニコ生放送' _VALID_URL = r'https?://(?:sp\.)?live2?\.nicovideo\.jp/(?:watch|gate)/(?P<id>lv\d+)' _TESTS = [{ - 'note': 'this test case includes invisible characters for title, pasting them as-is', - 'url': 'https://live.nic...
yt_dlp/extractor/niconico.py
26
Python
0.5
security
172
51
51
false
[ie/niconico:live] Support age-restricted streams
13,549
yt-dlp/yt-dlp
132,642
Python
bashonly
doe1080
'thumbnail': r're:https?://.+', 'timestamp': 1617029400, 'upload_date': '20210329', 'uploader': '株式会社ドワンゴ', 'view_count': int, }, 'params': {'skip_download': True}, }] def _real_extract(self, url): video_id = self._match_id(url...
and under what circumstances do we just error? Can this be bypassed logging in? should we `raise_login_required`?
class NicovideoTagURLIE(NicovideoSearchBaseIE): IE_NAME = 'niconico:tag' IE_DESC = 'NicoNico video tag URLs' _SEARCH_TYPE = 'tag' _VALID_URL = r'https?://(?:www\.)?nicovideo\.jp/tag/(?P<id>[^?#&]+)?' _TESTS = [{ 'url': 'https://www.nicovideo.jp/tag/ドキュメンタリー淫夢', 'info_dict': { ...
@@ -779,39 +779,64 @@ class NiconicoLiveIE(NiconicoBaseIE): IE_DESC = 'ニコニコ生放送' _VALID_URL = r'https?://(?:sp\.)?live2?\.nicovideo\.jp/(?:watch|gate)/(?P<id>lv\d+)' _TESTS = [{ - 'note': 'this test case includes invisible characters for title, pasting them as-is', - 'url': 'https://live.nic...
yt_dlp/extractor/niconico.py
26
Python
0.714
question
113
51
51
false
[ie/niconico:live] Support age-restricted streams
13,549
yt-dlp/yt-dlp
132,642
Python
bashonly
doe1080
from urllib import parse from .common import InfoExtractor from ..networking import HEADRequest from ..utils import ( UserNotLive, determine_ext, float_or_none, int_or_none, merge_dicts, parse_iso8601, str_or_none, traverse_obj, unified_timestamp, url_or_none, ) class KickBas...
`session_token` is the cookie for your logged-in session, right? I don't have that cookie set when I'm not logged in. If so, then we don't need the "setting up session" request anymore; in fact, I don't think `_real_initialize` is even necessary either. ```py @functools.cached_property def _api_headers(...
import functools import urllib.parse from .common import InfoExtractor from ..utils import ( UserNotLive, determine_ext, float_or_none, int_or_none, parse_iso8601, str_or_none, traverse_obj, unified_timestamp, url_or_none, ) class KickBaseIE(InfoExtractor): @functools.cached_p...
@@ -19,13 +21,12 @@ class KickBaseIE(InfoExtractor): def _real_initialize(self): self._request_webpage( HEADRequest('https://kick.com/'), None, 'Setting up session', fatal=False, impersonate=True) - xsrf_token = self._get_cookies('https://kick.com/').get('XSRF-TOKEN') - if not x...
yt_dlp/extractor/kick.py
24
Python
0.786
security
835
49
49
false
[ie/kick] Support subscriber-only content
13,550
yt-dlp/yt-dlp
132,642
Python
bashonly
helpimnotdrowning
from urllib import parse from .common import InfoExtractor from ..networking import HEADRequest from ..utils import ( UserNotLive, determine_ext, float_or_none, int_or_none, merge_dicts, parse_iso8601, str_or_none, traverse_obj, unified_timestamp, url_or_none, ) class KickBas...
`from` imports go against the project's coding conventions ```suggestion import urllib.parse ```
import functools import urllib.parse from .common import InfoExtractor from ..utils import ( UserNotLive, determine_ext, float_or_none, int_or_none, parse_iso8601, str_or_none, traverse_obj, unified_timestamp, url_or_none, ) class KickBaseIE(InfoExtractor): @functools.cached_p...
@@ -1,4 +1,6 @@ +from urllib import parse
yt_dlp/extractor/kick.py
2
Python
0.571
suggestion
99
27
27
false
[ie/kick] Support subscriber-only content
13,550
yt-dlp/yt-dlp
132,642
Python
bashonly
helpimnotdrowning
import functools import urllib.parse from .common import InfoExtractor from ..utils import ( UserNotLive, determine_ext, float_or_none, int_or_none, parse_iso8601, str_or_none, traverse_obj, unified_timestamp, url_or_none, ) class KickBaseIE(InfoExtractor): @functools.cached_...
no hanging parentheses in function calls ```suggestion ('session_token', 'value', {urllib.parse.unquote})) ```
import functools import urllib.parse from .common import InfoExtractor from ..utils import ( UserNotLive, determine_ext, float_or_none, int_or_none, parse_iso8601, str_or_none, traverse_obj, unified_timestamp, url_or_none, ) class KickBaseIE(InfoExtractor): @functools.cached_p...
@@ -16,21 +17,18 @@ class KickBaseIE(InfoExtractor): - def _real_initialize(self): - self._request_webpage( - HEADRequest('https://kick.com/'), None, 'Setting up session', fatal=False, impersonate=True) - xsrf_token = self._get_cookies('https://kick.com/').get('XSRF-TOKEN') - if ...
yt_dlp/extractor/kick.py
25
Python
0.714
suggestion
125
50
50
false
[ie/kick] Support subscriber-only content
13,550
yt-dlp/yt-dlp
132,642
Python
bashonly
helpimnotdrowning
import functools import urllib.parse from .common import InfoExtractor from ..utils import ( UserNotLive, determine_ext, float_or_none, int_or_none, parse_iso8601, str_or_none, traverse_obj, unified_timestamp, url_or_none, ) class KickBaseIE(InfoExtractor): @functools.cached_...
```suggestion import functools import urllib.parse ```
import functools import urllib.parse from .common import InfoExtractor from ..utils import ( UserNotLive, determine_ext, float_or_none, int_or_none, parse_iso8601, str_or_none, traverse_obj, unified_timestamp, url_or_none, ) class KickBaseIE(InfoExtractor): @functools.cached_p...
@@ -1,12 +1,13 @@ +import functools +import urllib.parse
yt_dlp/extractor/kick.py
3
Python
0.571
suggestion
57
28
28
false
[ie/kick] Support subscriber-only content
13,550
yt-dlp/yt-dlp
132,642
Python
bashonly
helpimnotdrowning
import re from .common import InfoExtractor class MixlrIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/events/(?P<id>\d+)' _TESTS = [{ 'url': 'https://suncity-104-9fm.mixlr.com/events/4261962', 'info_dict': { 'id': '4261962', 'titl...
Let's simplify ```suggestion username, event_id = self._match_valid_url(url).group('username', 'id') ```
from .common import InfoExtractor from ..networking import HEADRequest from ..utils import int_or_none, parse_iso8601, url_or_none, urlhandle_detect_ext from ..utils.traversal import traverse_obj class MixlrIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/events/(?P<id>\d+)' ...
@@ -0,0 +1,73 @@ +import re + +from .common import InfoExtractor + + +class MixlrIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/events/(?P<id>\d+)' + _TESTS = [{ + 'url': 'https://suncity-104-9fm.mixlr.com/events/4261962', + 'info_dict': { + 'id': ...
yt_dlp/extractor/mixlr.py
24
Python
0.786
refactor
115
49
49
false
[ie/mixlr] Add extractors
13,561
yt-dlp/yt-dlp
132,642
Python
seproDev
ShockedPlot7560
def _real_extract(self, url): mobj = self._match_valid_url(url) username = mobj.group('username') event_id = mobj.group('id') api_url = f'https://apicdn.mixlr.com/v3/channel_view/{username}' channel_info = self._download_json(api_url, event_id) user_data = channel_i...
I would just use the dedicated event api to only get returned that one event and broadcast ```suggestion broadcast_info = self._download_json( f'https://api.mixlr.com/v3/channels/{username}/events/{event_id}', event_id) ```
'release_timestamp': 1751943764, 'release_date': '20250708', 'live_status': 'is_live', }, }, { 'url': 'https://brcountdown.mixlr.com/events/4395480', 'info_dict': { 'id': '4395480', 'ext': 'aac', 'title': r're:Beats Revo...
@@ -0,0 +1,73 @@ +import re + +from .common import InfoExtractor + + +class MixlrIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/events/(?P<id>\d+)' + _TESTS = [{ + 'url': 'https://suncity-104-9fm.mixlr.com/events/4261962', + 'info_dict': { + 'id': ...
yt_dlp/extractor/mixlr.py
26
Python
1
suggestion
247
51
51
false
[ie/mixlr] Add extractors
13,561
yt-dlp/yt-dlp
132,642
Python
seproDev
ShockedPlot7560
for item in included: if item.get('type') == 'broadcast': broadcast_data = item.get('attributes', {}) elif item.get('type') == 'event' and item.get('id') == event_id: event_data = item.get('attributes', {}) if broadcast_data and event_data: ...
Sadly the stream is not always mp3, but for some streams also aac and we need make a HEADRequest. The server sometimes randomly also returns `octet-stream` as the content type so I added some logic to deal with that ```suggestion formats = [] format_url = traverse_obj( broadcast_info, ('...
'thumbnail': r're:https://imagecdn\.mixlr\.com/cdn-cgi/image/[^/?#]+/c48727a59f690b87a55d47d123ba0d6d.jpg', 'timestamp': 1752354007, 'upload_date': '20250712', 'release_timestamp': 1752354000, 'release_date': '20250712', 'live_status': 'is_live', ...
@@ -0,0 +1,73 @@ +import re + +from .common import InfoExtractor + + +class MixlrIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/events/(?P<id>\d+)' + _TESTS = [{ + 'url': 'https://suncity-104-9fm.mixlr.com/events/4261962', + 'info_dict': { + 'id': ...
yt_dlp/extractor/mixlr.py
26
Python
0.929
suggestion
1,131
42
51
false
[ie/mixlr] Add extractors
13,561
yt-dlp/yt-dlp
132,642
Python
seproDev
ShockedPlot7560
streaming_url = broadcast_data.get('progressive_stream_url') title = event_data.get('title') or f'Mixlr broadcast by {username}' description = event_data.get('description') or broadcast_data.get('description') or '' formats = [] if streaming_url: formats.append({ ...
We can extract some more info and use `traverse_obj` ```suggestion 'uploader': username, 'formats': formats, **traverse_obj(broadcast_info, ('included', 0, 'attributes', { 'title': ('title', {str}), 'timestamp': ('started_at', {parse_iso8601}), ...
broadcast_info = self._download_json( f'https://api.mixlr.com/v3/channels/{username}/events/{event_id}', event_id) formats = [] format_url = traverse_obj( broadcast_info, ('included', 0, 'attributes', 'progressive_stream_url', {url_or_none})) if format_url: ...
@@ -0,0 +1,73 @@ +import re + +from .common import InfoExtractor + + +class MixlrIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/events/(?P<id>\d+)' + _TESTS = [{ + 'url': 'https://suncity-104-9fm.mixlr.com/events/4261962', + 'info_dict': { + 'id': ...
yt_dlp/extractor/mixlr.py
26
Python
1
refactor
1,122
28
51
false
[ie/mixlr] Add extractors
13,561
yt-dlp/yt-dlp
132,642
Python
seproDev
ShockedPlot7560
import re from .common import InfoExtractor class MixlrIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/events/(?P<id>\d+)' _TESTS = [{ 'url': 'https://suncity-104-9fm.mixlr.com/events/4261962', 'info_dict': { 'id': '4261962', 'titl...
I also added an extractor for recordings: ```suggestion } class MixlrRecoringIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/recordings/(?P<id>\d+)' _TESTS = [{ 'url': 'https://biblewayng.mixlr.com/recordings/2375193', 'info_dict': { ...
'duration': 10968, 'thumbnail': r're:https://imagecdn\.mixlr\.com/cdn-cgi/image/[^/?#]+/ceca120ef707f642abeea6e29cd74238.jpg', 'timestamp': 1708544542, 'upload_date': '20240221', }, }] def _real_extract(self, url): username, recording_id = self._m...
@@ -0,0 +1,73 @@ +import re + +from .common import InfoExtractor + + +class MixlrIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/events/(?P<id>\d+)' + _TESTS = [{ + 'url': 'https://suncity-104-9fm.mixlr.com/events/4261962', + 'info_dict': { + 'id': ...
yt_dlp/extractor/mixlr.py
26
Python
0.857
refactor
1,702
74
27
false
[ie/mixlr] Add extractors
13,561
yt-dlp/yt-dlp
132,642
Python
seproDev
ShockedPlot7560
MindsChannelIE, MindsGroupIE, MindsIE, ) from .minoto import MinotoIE from .mirrativ import ( MirrativIE, MirrativUserIE, ) from .mirrorcouk import MirrorCoUKIE from .mit import ( OCWMITIE, TechTVMITIE, ) from .mitele import MiTeleIE from .mixch import ( MixchArchiveIE, MixchIE, ...
```suggestion from .mixlr import ( MixlrIE, MixlrRecoringIE, ) ```
MindsChannelIE, MindsGroupIE, MindsIE, ) from .minoto import MinotoIE from .mirrativ import ( MirrativIE, MirrativUserIE, ) from .mirrorcouk import MirrorCoUKIE from .mit import ( OCWMITIE, TechTVMITIE, ) from .mitele import MiTeleIE from .mixch import ( MixchArchiveIE, MixchIE, ...
@@ -1173,6 +1173,7 @@ MixcloudPlaylistIE, MixcloudUserIE, ) +from .mixlr import MixlrIE
yt_dlp/extractor/_extractors.py
26
Python
0.571
suggestion
79
51
51
false
[ie/mixlr] Add extractors
13,561
yt-dlp/yt-dlp
132,642
Python
seproDev
ShockedPlot7560
import re from .common import InfoExtractor class MixlrIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/events/(?P<id>\d+)' _TESTS = [{ 'url': 'https://suncity-104-9fm.mixlr.com/events/4261962', 'info_dict': { 'id': '4261962', 'titl...
I know they will expire, still wanted to add one test for mp3 and one for aac ```suggestion _TESTS = [{ 'url': 'https://suncity-104-9fm.mixlr.com/events/4387115', 'info_dict': { 'id': '4387115', 'ext': 'mp3', 'title': r're:SUNCITY 104.9FM\'s live audio \d{4...
from .common import InfoExtractor from ..networking import HEADRequest from ..utils import int_or_none, parse_iso8601, url_or_none, urlhandle_detect_ext from ..utils.traversal import traverse_obj class MixlrIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/events/(?P<id>\d+)' ...
@@ -0,0 +1,73 @@ +import re + +from .common import InfoExtractor + + +class MixlrIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/events/(?P<id>\d+)' + _TESTS = [{ + 'url': 'https://suncity-104-9fm.mixlr.com/events/4261962', + 'info_dict': { + 'id': ...
yt_dlp/extractor/mixlr.py
18
Python
0.786
suggestion
1,496
43
43
false
[ie/mixlr] Add extractors
13,561
yt-dlp/yt-dlp
132,642
Python
seproDev
ShockedPlot7560
import re from .common import InfoExtractor class MixlrIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/events/(?P<id>\d+)' _TESTS = [{ 'url': 'https://suncity-104-9fm.mixlr.com/events/4261962', 'info_dict': { 'id': '4261962', 'titl...
```suggestion from .common import InfoExtractor from ..networking import HEADRequest from ..utils import int_or_none, parse_iso8601, url_or_none, urlhandle_detect_ext from ..utils.traversal import traverse_obj ```
from .common import InfoExtractor from ..networking import HEADRequest from ..utils import int_or_none, parse_iso8601, url_or_none, urlhandle_detect_ext from ..utils.traversal import traverse_obj class MixlrIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\.com/events/(?P<id>\d+)' ...
@@ -0,0 +1,73 @@ +import re + +from .common import InfoExtractor
yt_dlp/extractor/mixlr.py
3
Python
1
refactor
218
28
28
false
[ie/mixlr] Add extractors
13,561
yt-dlp/yt-dlp
132,642
Python
seproDev
ShockedPlot7560
'title': r're:Beats Revolution Countdown Episodio 461 \d{4}-\d{2}-\d{2} \d{2}:\d{2}', 'description': 'md5:5cacd089723f7add3f266bd588315bb3', 'uploader': 'brcountdown', 'like_count': int, 'thumbnail': r're:https://imagecdn\.mixlr\.com/cdn-cgi/image/[^/?#]+/c487...
```suggestion if urlh and urlh.status == 200: ```
'title': r're:Beats Revolution Countdown Episodio 461 \d{4}-\d{2}-\d{2} \d{2}:\d{2}', 'description': 'md5:5cacd089723f7add3f266bd588315bb3', 'uploader': 'brcountdown', 'like_count': int, 'thumbnail': r're:https://imagecdn\.mixlr\.com/cdn-cgi/image/[^/?#]+/c487...
@@ -0,0 +1,130 @@ +from .common import InfoExtractor +from ..networking import HEADRequest +from ..utils import int_or_none, parse_iso8601, url_or_none, urlhandle_detect_ext +from ..utils.traversal import traverse_obj + + +class MixlrIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\...
yt_dlp/extractor/mixlr.py
26
Python
0.571
suggestion
63
51
51
false
[ie/mixlr] Add extractors
13,561
yt-dlp/yt-dlp
132,642
Python
bashonly
ShockedPlot7560
'timestamp': 1752354007, 'upload_date': '20250712', 'release_timestamp': 1752354000, 'release_date': '20250712', 'live_status': 'is_live', }, }] def _real_extract(self, url): username, event_id = self._match_valid_url(url).group('usern...
```suggestion self.report_warning( 'The server did not return a valid file extension for the stream URL. ' 'Assuming an mp3 stream; postprocessing may fail if this is incorrect') ```
'timestamp': 1752354007, 'upload_date': '20250712', 'release_timestamp': 1752354000, 'release_date': '20250712', 'live_status': 'is_live', }, }, { 'url': 'https://www.brcountdown.mixlr.com/events/4395480', 'only_matching': True, ...
@@ -0,0 +1,130 @@ +from .common import InfoExtractor +from ..networking import HEADRequest +from ..utils import int_or_none, parse_iso8601, url_or_none, urlhandle_detect_ext +from ..utils.traversal import traverse_obj + + +class MixlrIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\...
yt_dlp/extractor/mixlr.py
26
Python
0.786
bug
254
51
51
false
[ie/mixlr] Add extractors
13,561
yt-dlp/yt-dlp
132,642
Python
bashonly
ShockedPlot7560
username, event_id = self._match_valid_url(url).group('username', 'id') broadcast_info = self._download_json( f'https://api.mixlr.com/v3/channels/{username}/events/{event_id}', event_id) formats = [] format_url = traverse_obj( broadcast_info, ('included', 0, 'at...
can we extract `release_timestamp` before this point and give a better message if the start time is in the future?
}] def _real_extract(self, url): username, event_id = self._match_valid_url(url).group('username', 'id') broadcast_info = self._download_json( f'https://api.mixlr.com/v3/channels/{username}/events/{event_id}', event_id) formats = [] format_url = traverse_obj( ...
@@ -0,0 +1,130 @@ +from .common import InfoExtractor +from ..networking import HEADRequest +from ..utils import int_or_none, parse_iso8601, url_or_none, urlhandle_detect_ext +from ..utils.traversal import traverse_obj + + +class MixlrIE(InfoExtractor): + _VALID_URL = r'https?://(?:www\.)?(?P<username>[\w-]+)\.mixlr\...
yt_dlp/extractor/mixlr.py
26
Python
0.571
refactor
114
51
51
false
[ie/mixlr] Add extractors
13,561
yt-dlp/yt-dlp
132,642
Python
bashonly
ShockedPlot7560
if self.get_param('ignore_no_formats_error'): fatal = False if not m3u8_url: if errnote is not False: errnote = errnote or 'Failed to obtain m3u8 URL' if fatal: raise ExtractorError(errnote, video_id=video_id) ...
```suggestion msg = 'Response data has no m3u header' if fatal: raise ExtractorError(msg, video_id=video_id) self.report_warning(bug_reports_message(f'{msg}; '), video_id=video_id) return [], {} ```
if self.get_param('ignore_no_formats_error'): fatal = False if not m3u8_url: if errnote is not False: errnote = errnote or 'Failed to obtain m3u8 URL' if fatal: raise ExtractorError(errnote, video_id=video_id) ...
@@ -2129,21 +2130,30 @@ def _extract_m3u8_formats_and_subtitles( raise ExtractorError(errnote, video_id=video_id) self.report_warning(f'{errnote}{bug_reports_message()}') return [], {} - - res = self._download_webpage_handle( - m3u8_url, video_id, - ...
yt_dlp/extractor/common.py
26
Python
1
bug
288
51
51
false
[ie] Implement check for HLS streaming header
13,563
yt-dlp/yt-dlp
132,642
Python
bashonly
Grub4K
import functools from .common import InfoExtractor from ..utils import ( ExtractorError, OnDemandPagedList, clean_html, determine_ext, format_field, int_or_none, join_nonempty, parse_codecs, parse_iso8601, url_or_none, urljoin, ) from ..utils.traversal import traverse_obj ...
To simplify things, let's just keep this as `_real_extract`. We can use `self._BASE_URL` where needed and add a `_IMPERSONATE_TARGET` class var as well ```suggestion def _real_extract(self, url, video_id): ```
import functools from .common import InfoExtractor from ..utils import ( ExtractorError, OnDemandPagedList, clean_html, determine_ext, format_field, int_or_none, join_nonempty, parse_codecs, parse_iso8601, url_or_none, urljoin, ) from ..utils.traversal import traverse_obj ...
@@ -17,8 +17,107 @@ from ..utils.traversal import traverse_obj -class FloatplaneIE(InfoExtractor): +class FloatplaneBaseIE(InfoExtractor): + def _base_extract(self, url, base_url, do_impersonate):
yt_dlp/extractor/floatplane.py
21
Python
0.857
refactor
216
46
46
false
[ie/sauceplus] Add extractor
13,567
yt-dlp/yt-dlp
132,642
Python
bashonly
ceandreasen
import functools from .common import InfoExtractor from ..utils import ( ExtractorError, OnDemandPagedList, clean_html, determine_ext, format_field, int_or_none, join_nonempty, parse_codecs, parse_iso8601, url_or_none, urljoin, ) from ..utils.traversal import traverse_obj ...
see above comment ```suggestion f'{self._BASE_URL}/api/v3/content/post', post_id, query={'id': post_id}, note='Downloading post data', errnote='Unable to download post data', impersonate=self._IMPERSONATE_TARGET) ```
import functools from .common import InfoExtractor from ..utils import ( ExtractorError, OnDemandPagedList, clean_html, determine_ext, format_field, int_or_none, join_nonempty, parse_codecs, parse_iso8601, url_or_none, urljoin, ) from ..utils.traversal import traverse_obj ...
@@ -17,8 +17,107 @@ from ..utils.traversal import traverse_obj -class FloatplaneIE(InfoExtractor): +class FloatplaneBaseIE(InfoExtractor): + def _base_extract(self, url, base_url, do_impersonate): + post_id = self._match_id(url) + + post_data = self._download_json( + f'{base_url}/api/v3...
yt_dlp/extractor/floatplane.py
26
Python
0.786
suggestion
257
51
51
false
[ie/sauceplus] Add extractor
13,567
yt-dlp/yt-dlp
132,642
Python
bashonly
ceandreasen
clean_html, determine_ext, format_field, int_or_none, join_nonempty, parse_codecs, parse_iso8601, url_or_none, urljoin, ) from ..utils.traversal import traverse_obj class FloatplaneBaseIE(InfoExtractor): def _base_extract(self, url, base_url, do_impersonate): post_id = ...
```suggestion post_data, [('creator', 'urlname')], f'{self._BASE_URL}/channel/%s/home') or None ```
clean_html, determine_ext, format_field, int_or_none, join_nonempty, parse_codecs, parse_iso8601, url_or_none, urljoin, ) from ..utils.traversal import traverse_obj class FloatplaneBaseIE(InfoExtractor): def _real_extract(self, url): post_id = self._match_id(url) ...
@@ -17,8 +17,107 @@ from ..utils.traversal import traverse_obj -class FloatplaneIE(InfoExtractor): +class FloatplaneBaseIE(InfoExtractor): + def _base_extract(self, url, base_url, do_impersonate): + post_id = self._match_id(url) + + post_data = self._download_json( + f'{base_url}/api/v3...
yt_dlp/extractor/floatplane.py
26
Python
0.714
suggestion
113
51
51
false
[ie/sauceplus] Add extractor
13,567
yt-dlp/yt-dlp
132,642
Python
bashonly
ceandreasen
'uploader_url': uploader_url, 'channel_url': urljoin(f'{uploader_url}/', traverse_obj(post_data, ('channel', 'urlname'))), 'availability': self._availability(needs_subscription=True), **traverse_obj(post_data, { 'uploader': ('creator', 'title', {str}), ...
```suggestion }, note=f'Downloading {media_typ} stream data', impersonate=self._IMPERSONATE_TARGET) ```
common_info = { 'uploader_url': uploader_url, 'channel_url': urljoin(f'{uploader_url}/', traverse_obj(post_data, ('channel', 'urlname'))), 'availability': self._availability(needs_subscription=True), **traverse_obj(post_data, { 'uploader': ('creato...
@@ -17,8 +17,107 @@ from ..utils.traversal import traverse_obj -class FloatplaneIE(InfoExtractor): +class FloatplaneBaseIE(InfoExtractor): + def _base_extract(self, url, base_url, do_impersonate): + post_id = self._match_id(url) + + post_data = self._download_json( + f'{base_url}/api/v3...
yt_dlp/extractor/floatplane.py
26
Python
0.714
suggestion
138
51
51
false
[ie/sauceplus] Add extractor
13,567
yt-dlp/yt-dlp
132,642
Python
bashonly
ceandreasen
post_info = { **common_info, 'id': post_id, 'display_id': post_id, **traverse_obj(post_data, { 'title': ('title', {str}), 'description': ('text', {clean_html}), 'like_count': ('likes', {int_or_none}), ...
```suggestion _BASE_URL = 'https://www.floatplane.com' _IMPERSONATE_TARGET = None _TESTS = [{ ```
errnote=join_nonempty('Failed to download', format_id, 'HLS AES key', delim=' ')) if urlh: hls_aes['key'] = urlh.read().hex() formats.append({ **traverse_obj(quality, { 'format_no...
@@ -17,8 +17,107 @@ from ..utils.traversal import traverse_obj -class FloatplaneIE(InfoExtractor): +class FloatplaneBaseIE(InfoExtractor): + def _base_extract(self, url, base_url, do_impersonate): + post_id = self._match_id(url) + + post_data = self._download_json( + f'{base_url}/api/v3...
yt_dlp/extractor/floatplane.py
26
Python
0.714
suggestion
113
51
51
false
[ie/sauceplus] Add extractor
13,567
yt-dlp/yt-dlp
132,642
Python
bashonly
ceandreasen
from .floatplane import FloatplaneBaseIE class SauceplusIE(FloatplaneBaseIE): _VALID_URL = r'https?://(?:(?:www|beta)\.)?sauceplus\.com/post/(?P<id>\w+)' _BASE_URL = 'https://www.sauceplus.com' _HEADERS = {'Origin': _BASE_URL, 'Referer': _BASE_URL + '/'} _TESTS = [{ 'url': 'htt...
are `_HEADERS` used anywhere? ```suggestion _IMPERSONATE_TARGET = True _TESTS = [{ ```
from .floatplane import FloatplaneBaseIE class SaucePlusIE(FloatplaneBaseIE): IE_DESC = 'Sauce+' _VALID_URL = r'https?://(?:(?:www|beta)\.)?sauceplus\.com/post/(?P<id>\w+)' _BASE_URL = 'https://www.sauceplus.com' _HEADERS = { 'Origin': _BASE_URL, 'Referer': f'{_BASE_URL}/', } _...
@@ -0,0 +1,40 @@ +from .floatplane import FloatplaneBaseIE + + +class SauceplusIE(FloatplaneBaseIE): + _VALID_URL = r'https?://(?:(?:www|beta)\.)?sauceplus\.com/post/(?P<id>\w+)' + _BASE_URL = 'https://www.sauceplus.com' + _HEADERS = {'Origin': _BASE_URL, + 'Referer': _BASE_URL + '/'} + _TEST...
yt_dlp/extractor/sauceplus.py
9
Python
0.643
suggestion
98
34
34
false
[ie/sauceplus] Add extractor
13,567
yt-dlp/yt-dlp
132,642
Python
bashonly
ceandreasen
'title': 'Scare the Coyote - Episode 3', 'description': '', 'thumbnail': r're:^https?://.*\.jpe?g$', 'duration': 2975, 'comment_count': int, 'like_count': int, 'dislike_count': int, 'release_date': '20250627', 'r...
```suggestion self.raise_login_required() ```
'info_dict': { 'id': 'eit4Ugu5TL', 'ext': 'mp4', 'display_id': 'YbBwIa2A5g', 'title': 'Scare the Coyote - Episode 3', 'description': '', 'thumbnail': r're:^https?://.*\.jpe?g$', 'duration': 2975, 'comment_count': int...
@@ -0,0 +1,40 @@ +from .floatplane import FloatplaneBaseIE + + +class SauceplusIE(FloatplaneBaseIE): + _VALID_URL = r'https?://(?:(?:www|beta)\.)?sauceplus\.com/post/(?P<id>\w+)' + _BASE_URL = 'https://www.sauceplus.com' + _HEADERS = {'Origin': _BASE_URL, + 'Referer': _BASE_URL + '/'} + _TEST...
yt_dlp/extractor/sauceplus.py
26
Python
0.571
suggestion
59
27
28
false
[ie/sauceplus] Add extractor
13,567
yt-dlp/yt-dlp
132,642
Python
bashonly
ceandreasen
raise ExtractorError('Post does not contain a video or audio track', expected=True) uploader_url = format_field( post_data, [('creator', 'urlname')], f'{base_url}/channel/%s/home') or None common_info = { 'uploader_url': uploader_url, 'channel_url': urlj...
```suggestion f'{self._BASE_URL}/api/v3/content/{media_typ}', media_id, query={'id': media_id}, note=f'Downloading {media_typ} metadata', impersonate=self._IMPERSONATE_TARGET) ```
if not any(traverse_obj(post_data, ('metadata', ('hasVideo', 'hasAudio')))): raise ExtractorError('Post does not contain a video or audio track', expected=True) uploader_url = format_field( post_data, [('creator', 'urlname')], f'{self._BASE_URL}/channel/%s/home') or None ...
@@ -17,8 +17,107 @@ from ..utils.traversal import traverse_obj -class FloatplaneIE(InfoExtractor): +class FloatplaneBaseIE(InfoExtractor): + def _base_extract(self, url, base_url, do_impersonate): + post_id = self._match_id(url) + + post_data = self._download_json( + f'{base_url}/api/v3...
yt_dlp/extractor/floatplane.py
26
Python
0.786
suggestion
214
51
51
false
[ie/sauceplus] Add extractor
13,567
yt-dlp/yt-dlp
132,642
Python
bashonly
ceandreasen
post_data, [('creator', 'urlname')], f'{base_url}/channel/%s/home') or None common_info = { 'uploader_url': uploader_url, 'channel_url': urljoin(f'{uploader_url}/', traverse_obj(post_data, ('channel', 'urlname'))), 'availability': self._availability(needs_subscri...
```suggestion f'{self._BASE_URL}/api/v2/cdn/delivery', media_id, query={ ```
uploader_url = format_field( post_data, [('creator', 'urlname')], f'{self._BASE_URL}/channel/%s/home') or None common_info = { 'uploader_url': uploader_url, 'channel_url': urljoin(f'{uploader_url}/', traverse_obj(post_data, ('channel', 'urlname'))), 'avai...
@@ -17,8 +17,107 @@ from ..utils.traversal import traverse_obj -class FloatplaneIE(InfoExtractor): +class FloatplaneBaseIE(InfoExtractor): + def _base_extract(self, url, base_url, do_impersonate): + post_id = self._match_id(url) + + post_data = self._download_json( + f'{base_url}/api/v3...
yt_dlp/extractor/floatplane.py
26
Python
0.571
suggestion
94
51
51
false
[ie/sauceplus] Add extractor
13,567
yt-dlp/yt-dlp
132,642
Python
bashonly
ceandreasen
}, note=f'Downloading {media_typ} stream data', impersonate=self._IMPERSONATE_TARGET) path_template = traverse_obj(stream, ('resource', 'uri', {str})) def format_path(params): path = path_template for i, val in (params or {}).item...
```suggestion format_id = traverse_obj(quality, ('name', {str})) m3u8_data = self._download_webpage( url, media_id, fatal=False, impersonate=self._IMPERSONATE_TARGET, note=join_nonempty('Downloading', format_id, 'm3u8 information', delim=' ')...
}, note=f'Downloading {media_typ} stream data', impersonate=self._IMPERSONATE_TARGET) path_template = traverse_obj(stream, ('resource', 'uri', {str})) def format_path(params): path = path_template for i, val in (params or {}).item...
@@ -17,8 +17,112 @@ from ..utils.traversal import traverse_obj -class FloatplaneIE(InfoExtractor): +class FloatplaneBaseIE(InfoExtractor): + def _real_extract(self, url): + post_id = self._match_id(url) + + post_data = self._download_json( + f'{self._BASE_URL}/api/v3/content/post', post...
yt_dlp/extractor/floatplane.py
26
Python
0.786
bug
1,807
51
51
false
[ie/sauceplus] Add extractor
13,567
yt-dlp/yt-dlp
132,642
Python
bashonly
ceandreasen
stream = self._download_json( f'{self._BASE_URL}/api/v2/cdn/delivery', media_id, query={ 'type': 'vod' if media_typ == 'video' else 'aod', 'guid': metadata['guid'], }, note=f'Downloading {media_typ} stream data', impers...
just for line length ```suggestion m3u8_data = self._download_webpage( url, media_id, fatal=False, impersonate=self._IMPERSONATE_TARGET, headers=self._HEADERS, note=join_nonempty('Downloading', format_id, 'm3u8 information', delim=' '), er...
stream = self._download_json( f'{self._BASE_URL}/api/v2/cdn/delivery', media_id, query={ 'type': 'vod' if media_typ == 'video' else 'aod', 'guid': metadata['guid'], }, note=f'Downloading {media_typ} stream data', impers...
@@ -17,8 +17,133 @@ from ..utils.traversal import traverse_obj -class FloatplaneIE(InfoExtractor): +class FloatplaneBaseIE(InfoExtractor): + def _real_extract(self, url): + post_id = self._match_id(url) + + post_data = self._download_json( + f'{self._BASE_URL}/api/v3/content/post', post...
yt_dlp/extractor/floatplane.py
26
Python
0.786
bug
409
51
51
false
[ie/sauceplus] Add extractor
13,567
yt-dlp/yt-dlp
132,642
Python
bashonly
ceandreasen
'type': 'vod' if media_typ == 'video' else 'aod', 'guid': metadata['guid'], }, note=f'Downloading {media_typ} stream data', impersonate=self._IMPERSONATE_TARGET) path_template = traverse_obj(stream, ('resource', 'uri', {str})) ...
for readability ```suggestion continue hls_aes = {} ```
'type': 'vod' if media_typ == 'video' else 'aod', 'guid': metadata['guid'], }, note=f'Downloading {media_typ} stream data', impersonate=self._IMPERSONATE_TARGET) path_template = traverse_obj(stream, ('resource', 'uri', {str})) ...
@@ -17,8 +17,133 @@ from ..utils.traversal import traverse_obj -class FloatplaneIE(InfoExtractor): +class FloatplaneBaseIE(InfoExtractor): + def _real_extract(self, url): + post_id = self._match_id(url) + + post_data = self._download_json( + f'{self._BASE_URL}/api/v3/content/post', post...
yt_dlp/extractor/floatplane.py
26
Python
0.571
suggestion
97
51
51
false
[ie/sauceplus] Add extractor
13,567
yt-dlp/yt-dlp
132,642
Python
bashonly
ceandreasen
path = path_template for i, val in (params or {}).items(): path = path.replace(f'{{qualityLevelParams.{i}}}', val) return path formats = [] for quality in traverse_obj(stream, ('resource', 'data', 'qualityLevels', ...)): ...
we don't need to add the headers here? (if you want to add them, please test if they're harmful first) ```suggestion urlh = self._request_webpage( key_url, media_id, fatal=False, impersonate=self._IMPERSONATE_TARGET, headers=self._HEADERS, note=joi...
path = path_template for i, val in (params or {}).items(): path = path.replace(f'{{qualityLevelParams.{i}}}', val) return path formats = [] for quality in traverse_obj(stream, ('resource', 'data', 'qualityLevels', ...)): ...
@@ -17,8 +17,133 @@ from ..utils.traversal import traverse_obj -class FloatplaneIE(InfoExtractor): +class FloatplaneBaseIE(InfoExtractor): + def _real_extract(self, url): + post_id = self._match_id(url) + + post_data = self._download_json( + f'{self._BASE_URL}/api/v3/content/post', post...
yt_dlp/extractor/floatplane.py
26
Python
0.786
bug
495
51
51
false
[ie/sauceplus] Add extractor
13,567
yt-dlp/yt-dlp
132,642
Python
bashonly
ceandreasen