diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/string_ext.rb b/lib/string_ext.rb index abc1234..def5678 100644 --- a/lib/string_ext.rb +++ b/lib/string_ext.rb @@ -0,0 +1,9 @@+String.class_eval do + def constantize + const = Kernel + self.split('::').each do |const_str| + const = const.const_get const_str + end + return const + en...
Add constantize to String object if the String object cannot constantize.
diff --git a/lib/tankulator.rb b/lib/tankulator.rb index abc1234..def5678 100644 --- a/lib/tankulator.rb +++ b/lib/tankulator.rb @@ -1,43 +1,45 @@-require 'tankulator/entry' -require 'tankulator/gastank' - module Tankulator + # Starts running everything + # Returns nothing def self.run - inputFileName = '' + requi...
Print out USAGE when not properly called
diff --git a/lib/tara/shell.rb b/lib/tara/shell.rb index abc1234..def5678 100644 --- a/lib/tara/shell.rb +++ b/lib/tara/shell.rb @@ -4,6 +4,7 @@ class Shell def self.exec(command) output = %x(#{command}) + $stderr.puts(%(#{command}: #{output})) if ENV['TARA_DEBUG'] unless $?.success? ...
Add debug statement to Shell.exec For, you know, debugging purposes. I’d prefer to have some kind of logger, but for now this’ll work.
diff --git a/LightRoute.podspec b/LightRoute.podspec index abc1234..def5678 100644 --- a/LightRoute.podspec +++ b/LightRoute.podspec @@ -1,7 +1,7 @@ Pod::Spec.new do |s| s.name = "LightRoute" - s.version = "2.1.9" + s.version = "2.1.10" s.summary = "LightRoute is easy transition between...
Update spec to version 2.1.10
diff --git a/cookbooks/omf/recipes/default.rb b/cookbooks/omf/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/omf/recipes/default.rb +++ b/cookbooks/omf/recipes/default.rb @@ -6,9 +6,18 @@ # # All rights reserved - Do Not Redistribute # -%w(ruby ruby-dev build-essential libssl-dev).each do |p| - pac...
Add package requirements for RHEL
diff --git a/Library/Homebrew/cmd/versions.rb b/Library/Homebrew/cmd/versions.rb index abc1234..def5678 100644 --- a/Library/Homebrew/cmd/versions.rb +++ b/Library/Homebrew/cmd/versions.rb @@ -11,7 +11,7 @@ Please use the homebrew-versions tap instead: https://github.com/Homebrew/homebrew-versions E...
Use .each, not .all? to enumerate formulae
diff --git a/lib/oboe_fu.rb b/lib/oboe_fu.rb index abc1234..def5678 100644 --- a/lib/oboe_fu.rb +++ b/lib/oboe_fu.rb @@ -1,6 +1,6 @@ require 'oboefu/util' -if defined?(Rails) and Rails::VERSION::MAJOR == "3" +if defined?(Rails) and Rails::VERSION::MAJOR == 3 module OboeFu class Railtie < Rails::Railtie ...
Change string to integer in init code
diff --git a/server.rb b/server.rb index abc1234..def5678 100644 --- a/server.rb +++ b/server.rb @@ -33,7 +33,7 @@ sleep 1 end - printer.close_all_windows + ncurses_printer.close_all_windows rescue => ex Curses.close_screen puts ex.message
Fix closing old printer and not curses printer
diff --git a/spec/models/micropost_spec.rb b/spec/models/micropost_spec.rb index abc1234..def5678 100644 --- a/spec/models/micropost_spec.rb +++ b/spec/models/micropost_spec.rb @@ -24,14 +24,6 @@ it { should be_valid } - describe "accessible attributes" do - it "should not allow access to user_id" do - e...
Remove mass assignmente test, because rails 4 move this funcionality to controller
diff --git a/lib/villein.rb b/lib/villein.rb index abc1234..def5678 100644 --- a/lib/villein.rb +++ b/lib/villein.rb @@ -3,3 +3,6 @@ module Villein # Your code goes here... end + +require 'villein/client' +require 'villein/agent'
Load Villein::Client, Agent in default
diff --git a/lib/yumlcmd.rb b/lib/yumlcmd.rb index abc1234..def5678 100644 --- a/lib/yumlcmd.rb +++ b/lib/yumlcmd.rb @@ -26,8 +26,9 @@ opts.parse!(args) lines = IO.readlines(input).collect!{|l| l.gsub("\n", "")}.reject{|l| l =~ /#/} - - writer = open("yuml-output.#{ext}", "wb") + output = input.rep...
Use input filename as base for output filename
diff --git a/lib/appium_console.rb b/lib/appium_console.rb index abc1234..def5678 100644 --- a/lib/appium_console.rb +++ b/lib/appium_console.rb @@ -6,45 +6,8 @@ module Appium; end unless defined? Appium module Appium::Console - # Check for env vars in .txt - toml = File.join Dir.pwd, 'appium.txt' - - class Env -...
Move appium.txt loading to appium_lib
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'messaging' - s.version = '0.4.0.0' + s.version = '0.4.1.0' s.summary = 'Messaging primitives for Eve...
Package version increased from 0.4.0.0 to 0.4.1.0
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-messaging' - s.version = '0.12.3.0' + s.version = '0.12.3.1' s.summary = 'Messaging primitives f...
Package version is increased from 0.12.3.0 to 0.12.3.1
diff --git a/exercises/nth-prime/nth_prime_test.rb b/exercises/nth-prime/nth_prime_test.rb index abc1234..def5678 100644 --- a/exercises/nth-prime/nth_prime_test.rb +++ b/exercises/nth-prime/nth_prime_test.rb @@ -1,27 +1,7 @@ #!/usr/bin/env ruby -# frozen_string_literal: true gem 'minitest', '>= 5.0.0' require 'min...
Remove constraint on Prime class usage. Since this was throwing an error in new versions of Ruby it is best to remove it since it was impacting the exercise.
diff --git a/spec/http_spec.rb b/spec/http_spec.rb index abc1234..def5678 100644 --- a/spec/http_spec.rb +++ b/spec/http_spec.rb @@ -16,7 +16,7 @@ async 'returns false when the request failed' do HTTP.get('data/non_existant.txt') do |response| - run_async { response.ok?.should be_true } + run...
Fix broken http spec (bad spec)
diff --git a/db/data_migration/20140131115415_add_endorsing_sponsoring_and_supporting_visa_applicants_mainstream_category.rb b/db/data_migration/20140131115415_add_endorsing_sponsoring_and_supporting_visa_applicants_mainstream_category.rb index abc1234..def5678 100644 --- a/db/data_migration/20140131115415_add_endorsin...
Add 'Endorsing, sponsoring and supporting visa applicants' https://www.pivotaltracker.com/story/show/64751384
diff --git a/lib/romaji_kit/cli.rb b/lib/romaji_kit/cli.rb index abc1234..def5678 100644 --- a/lib/romaji_kit/cli.rb +++ b/lib/romaji_kit/cli.rb @@ -2,10 +2,16 @@ module RomajiKit class CLI < Thor + class_option :upcase, type: :boolean, aliases: '-u' + desc 'hepburnize', 'Convert kana to hepburn' - opti...
Add `nihon` method for CLI
diff --git a/lib/syncer/actions.rb b/lib/syncer/actions.rb index abc1234..def5678 100644 --- a/lib/syncer/actions.rb +++ b/lib/syncer/actions.rb @@ -12,7 +12,7 @@ return unless env[:machine].config.syncer.run_on_startup - # If Vagrant up/reload/resume exited successfully, run this rsync-auto + ...
Fix extra word in comment
diff --git a/lib/vail/generator.rb b/lib/vail/generator.rb index abc1234..def5678 100644 --- a/lib/vail/generator.rb +++ b/lib/vail/generator.rb @@ -21,7 +21,7 @@ end end - @config[:repetitions].times.each do + (@config[:repetitions].times.inject([]) { |r,i| r << instructions }).each do |ins...
Refactor of building the morse instructions - first pass
diff --git a/spec/factories/ecm_comments_comments.rb b/spec/factories/ecm_comments_comments.rb index abc1234..def5678 100644 --- a/spec/factories/ecm_comments_comments.rb +++ b/spec/factories/ecm_comments_comments.rb @@ -1,7 +1,7 @@ FactoryGirl.define do factory :ecm_comments_comment, class: Ecm::Comments::Comment d...
Change creator and commentable factories.
diff --git a/spec/acceptance/whos_dated_who_spec.rb b/spec/acceptance/whos_dated_who_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/whos_dated_who_spec.rb +++ b/spec/acceptance/whos_dated_who_spec.rb @@ -0,0 +1,21 @@+require 'spec_helper' + +describe WhosDatedWho do + let(:client) { WhosDatedWho::Client.n...
Add an acceptance test that hits the network
diff --git a/spec/features/create_a_project_spec.rb b/spec/features/create_a_project_spec.rb index abc1234..def5678 100644 --- a/spec/features/create_a_project_spec.rb +++ b/spec/features/create_a_project_spec.rb @@ -11,8 +11,8 @@ fill_in 'Name', with: 'Project Jellyfish' fill_in 'Icon', with: 'http://www.exam...
Update start and end dates in test Validations where failing because we were trying to schedule a project start date for before today.
diff --git a/spec/will_paginate/materialize_spec.rb b/spec/will_paginate/materialize_spec.rb index abc1234..def5678 100644 --- a/spec/will_paginate/materialize_spec.rb +++ b/spec/will_paginate/materialize_spec.rb @@ -5,7 +5,5 @@ expect(WillPaginate::Materialize::VERSION).not_to be nil end - it 'does something...
Add TODO to write specs
diff --git a/app/controllers/progress_updates_controller.rb b/app/controllers/progress_updates_controller.rb index abc1234..def5678 100644 --- a/app/controllers/progress_updates_controller.rb +++ b/app/controllers/progress_updates_controller.rb @@ -36,6 +36,11 @@ end end + def destroy + ProgressUpdate.find...
Add progress update destroy route
diff --git a/app/controllers/renalware/events_controller.rb b/app/controllers/renalware/events_controller.rb index abc1234..def5678 100644 --- a/app/controllers/renalware/events_controller.rb +++ b/app/controllers/renalware/events_controller.rb @@ -10,9 +10,9 @@ end def create - @event = Event.new(event...
Leverage association when building model
diff --git a/spec/time_spec.rb b/spec/time_spec.rb index abc1234..def5678 100644 --- a/spec/time_spec.rb +++ b/spec/time_spec.rb @@ -3,6 +3,10 @@ describe "parsing an iso8601 formatted time to a Time object" do before do @time = Time.iso8601("2012-05-31T19:41:33Z") + end + + it "should be a time" do...
Add a spec verifying that Time.iso8601 returns an instance of Time
diff --git a/core/app/classes/opinion_type.rb b/core/app/classes/opinion_type.rb index abc1234..def5678 100644 --- a/core/app/classes/opinion_type.rb +++ b/core/app/classes/opinion_type.rb @@ -1,4 +1,4 @@-class OpinionType +module OpinionType def self.types ['believes', 'disbelieves', 'doubts'] end
Use module instead of class
diff --git a/tinkey.rb b/tinkey.rb index abc1234..def5678 100644 --- a/tinkey.rb +++ b/tinkey.rb @@ -6,8 +6,8 @@ class Tinkey < Formula desc "A command line tool to generate and manipulate keysets for the Tink cryptography library" homepage "https://github.com/google/tink/tree/master/tools/tinkey" - url "https:/...
Update Tinkey URL and SHA-256 hash for Tink 1.6.0. PiperOrigin-RevId: 374341425
diff --git a/week-9/nums_to_words.rb b/week-9/nums_to_words.rb index abc1234..def5678 100644 --- a/week-9/nums_to_words.rb +++ b/week-9/nums_to_words.rb @@ -0,0 +1,24 @@+# Numbers to English Words + + +# I worked on this challenge [Alone]. +# This challenge took me [#] hours. + + +# Pseudocode__________________________...
Add working directory for w9
diff --git a/core/threadgroup/default_spec.rb b/core/threadgroup/default_spec.rb index abc1234..def5678 100644 --- a/core/threadgroup/default_spec.rb +++ b/core/threadgroup/default_spec.rb @@ -0,0 +1,11 @@+require File.expand_path('../../../spec_helper', __FILE__) + +describe "ThreadGroup::Default" do + it "is a Threa...
Add spec for ThreadGroup::Default constant Based on MRI docs and passing in MIR 1.9.3
diff --git a/work/consider/having.rb b/work/consider/having.rb index abc1234..def5678 100644 --- a/work/consider/having.rb +++ b/work/consider/having.rb @@ -0,0 +1,75 @@+## THIS IS NOT THUROUGH ENOUGH +## PROBABY SHOULD MAKE SPECIAL SUBCLASSES +## OF HASH TO HANDLE THIS CONCEPT. +# +# IMPORTANT TODO!!!! + +# + +class H...
Add considertion to work directory. [admin]
diff --git a/environment.rb b/environment.rb index abc1234..def5678 100644 --- a/environment.rb +++ b/environment.rb @@ -13,4 +13,4 @@ end end -DB = Sequel.connect(ENV['DATABASE'] || "postgres://localhost/#{Db.name}") +DB = Sequel.connect(ENV['DATABASE_URL'] || "postgres://localhost/#{Db.name}")
Rollback previous commit to use DATABSE_URL
diff --git a/spec/acceptance/upload_spec.rb b/spec/acceptance/upload_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/upload_spec.rb +++ b/spec/acceptance/upload_spec.rb @@ -40,3 +40,18 @@ Warden.test_reset! end end + +describe 'upload from URL', :type => :feature do + before(:each) do + user = c...
Add spec to test uploading from URL
diff --git a/spec/models/item_model_spec.rb b/spec/models/item_model_spec.rb index abc1234..def5678 100644 --- a/spec/models/item_model_spec.rb +++ b/spec/models/item_model_spec.rb @@ -0,0 +1,27 @@+require 'rails_helper' + +RSpec.describe Item do + let(:item) { FactoryBot.create(:item)} + + before do + # Do nothin...
Improve item tests, part 2
diff --git a/spec/support/database_setup.rb b/spec/support/database_setup.rb index abc1234..def5678 100644 --- a/spec/support/database_setup.rb +++ b/spec/support/database_setup.rb @@ -2,6 +2,6 @@ config.before(:suite) do DatabaseCleaner[:mongoid].strategy = :truncation DatabaseCleaner.clean - Rails.appl...
Change to seed-fu for seeding during tests too.
diff --git a/spec/support/helper_methods.rb b/spec/support/helper_methods.rb index abc1234..def5678 100644 --- a/spec/support/helper_methods.rb +++ b/spec/support/helper_methods.rb @@ -13,7 +13,8 @@ def metric_not_activated?(metric_name) MetricFu.configuration.configure_metrics - if MetricFu::Metric.get_metric(me...
Check if metric is activated; was bypassing ripper check
diff --git a/week-6/gps.rb b/week-6/gps.rb index abc1234..def5678 100644 --- a/week-6/gps.rb +++ b/week-6/gps.rb @@ -0,0 +1,42 @@+# Your Names +# 1)Catie Stallings +# 2) + +# We spent [#] hours on this challenge. + +# Bakery Serving Size portion calculator. + +def serving_size_calc(item_to_make, num_of_ingredients) + ...
Add initial file for GPS 2.3
diff --git a/lib/clarifai/client/curator_search.rb b/lib/clarifai/client/curator_search.rb index abc1234..def5678 100644 --- a/lib/clarifai/client/curator_search.rb +++ b/lib/clarifai/client/curator_search.rb @@ -2,14 +2,28 @@ class Client # Defines methods related to Curator Index management module Curator...
Add support for searching using tags operator
diff --git a/lib/redmine_git_hosting/patches/project_patch.rb b/lib/redmine_git_hosting/patches/project_patch.rb index abc1234..def5678 100644 --- a/lib/redmine_git_hosting/patches/project_patch.rb +++ b/lib/redmine_git_hosting/patches/project_patch.rb @@ -22,7 +22,7 @@ # Find all repositories owned by projec...
Fix repo order with Postgres
diff --git a/lib/minitest_to_rspec/exp/hash_exp.rb b/lib/minitest_to_rspec/exp/hash_exp.rb index abc1234..def5678 100644 --- a/lib/minitest_to_rspec/exp/hash_exp.rb +++ b/lib/minitest_to_rspec/exp/hash_exp.rb @@ -8,8 +8,11 @@ @exp = sexp.dup end + # A slightly nicer implementation would be: + ...
Fix ruby 2.0 compatability issue
diff --git a/lib/ossboard/services/task_twitter.rb b/lib/ossboard/services/task_twitter.rb index abc1234..def5678 100644 --- a/lib/ossboard/services/task_twitter.rb +++ b/lib/ossboard/services/task_twitter.rb @@ -26,6 +26,7 @@ end # Keep extra 5 symbols for spaces and ... + # TODO: update length to 200 ...
Add one more tech debt todo
diff --git a/test/inputs/hidden_input_test.rb b/test/inputs/hidden_input_test.rb index abc1234..def5678 100644 --- a/test/inputs/hidden_input_test.rb +++ b/test/inputs/hidden_input_test.rb @@ -20,10 +20,11 @@ assert_no_select 'label' end - test 'required/optional options should not be generated for hidden inp...
Test aria-required for hidden inputs. [#780]
diff --git a/app/mailers/devise_mailer.rb b/app/mailers/devise_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/devise_mailer.rb +++ b/app/mailers/devise_mailer.rb @@ -13,7 +13,7 @@ def confirmation_instructions(record, opts) if record.individual? document_renderer = DocumentRenderer.new - a...
Stop image showing up as an attachment
diff --git a/jsrebuild.gemspec b/jsrebuild.gemspec index abc1234..def5678 100644 --- a/jsrebuild.gemspec +++ b/jsrebuild.gemspec @@ -19,6 +19,6 @@ s.executables = ["jsrebuild"] - s.files = %w(History.txt LICENCE README.md) + - Dir.glob("{bin,lib}/**/*") + s.files = Dir.glob("{bi...
Fix a file name error in the gemspec.
diff --git a/gretel.gemspec b/gretel.gemspec index abc1234..def5678 100644 --- a/gretel.gemspec +++ b/gretel.gemspec @@ -17,6 +17,6 @@ gem.test_files = gem.files.grep(%r{^test/}) gem.require_paths = ["lib"] - gem.add_dependency "rails", ">= 3.2.0" + gem.add_dependency "rails", ">= 3.1.0" gem.add_developm...
Downgrade rails dependency to 3.1
diff --git a/Library/Homebrew/dependencies.rb b/Library/Homebrew/dependencies.rb index abc1234..def5678 100644 --- a/Library/Homebrew/dependencies.rb +++ b/Library/Homebrew/dependencies.rb @@ -51,6 +51,10 @@ deps == other.deps end alias_method :eql?, :== + + def inspect + "#<#{self.class.name}: #{to_a.ins...
Improve inspect output for dependency collections
diff --git a/db/migrate/20180207095200_create_repository_list_values.rb b/db/migrate/20180207095200_create_repository_list_values.rb index abc1234..def5678 100644 --- a/db/migrate/20180207095200_create_repository_list_values.rb +++ b/db/migrate/20180207095200_create_repository_list_values.rb @@ -1,9 +1,13 @@+require Fi...
Fix migration for better search [SCI-2108]
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -16,6 +16,8 @@ def send_invitations @vip_clients = VipClients.all - return Birthday.greetings(@vip_clients) if @vip_clients.any? +if @vip_clients.any? + Birthday.greetings(@vip_clients) +end end
Change if condition for gretting call
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -4,7 +4,7 @@ require 'phone' require './lib/models' require './lib/greeter' -require './lib/unlocker_stub' +require './lib/unlocker' require './lib/twilio_watcher' require './lib/zulip_watcher'
Change away from unlocker stub
diff --git a/Casks/font-geo-sans-light.rb b/Casks/font-geo-sans-light.rb index abc1234..def5678 100644 --- a/Casks/font-geo-sans-light.rb +++ b/Casks/font-geo-sans-light.rb @@ -2,6 +2,6 @@ url 'http://moorstation.org/typoasis/designers/klein03/text02/pc/GeosansLight.zip' homepage 'http://moorstation.org/typoasis/d...
Update Geo Sans Light to sha256 checksums
diff --git a/periscope.gemspec b/periscope.gemspec index abc1234..def5678 100644 --- a/periscope.gemspec +++ b/periscope.gemspec @@ -18,4 +18,6 @@ s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n") s.executables = `git ls-files -- bin/*`.split("\n").map{|f| File.basename(f) } s.require_pat...
Add the activesupport 3 dependency.
diff --git a/db/migrate/20101026184949_create_users.rb b/db/migrate/20101026184949_create_users.rb index abc1234..def5678 100644 --- a/db/migrate/20101026184949_create_users.rb +++ b/db/migrate/20101026184949_create_users.rb @@ -0,0 +1,29 @@+class CreateUsers < ActiveRecord::Migration + def up + unless table_exists...
Add migration to create a spree_users table if it doesn't already exist
diff --git a/lib/sastrawi/morphology/disambiguator/disambiguator_prefix_rule34.rb b/lib/sastrawi/morphology/disambiguator/disambiguator_prefix_rule34.rb index abc1234..def5678 100644 --- a/lib/sastrawi/morphology/disambiguator/disambiguator_prefix_rule34.rb +++ b/lib/sastrawi/morphology/disambiguator/disambiguator_pref...
Add implementation of thirtieth-fourth rule of disambiguator prefix
diff --git a/cookbooks/docker/recipes/default.rb b/cookbooks/docker/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/docker/recipes/default.rb +++ b/cookbooks/docker/recipes/default.rb @@ -9,6 +9,12 @@ package "docker-engine" +group 'docker' do + action :modify + append true + members [ENV['SUDO_...
Add user to docker group - Fixes "Cannot connect to docker daemon"
diff --git a/cookbooks/docker/recipes/default.rb b/cookbooks/docker/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/docker/recipes/default.rb +++ b/cookbooks/docker/recipes/default.rb @@ -1,9 +1,9 @@- -remote_file "/tmp/install_docker" do - source "https://get.docker.com/" - mode 0755 +apt_repository...
Use docker repo rather than shell installer
diff --git a/lib/rupture/fn.rb b/lib/rupture/fn.rb index abc1234..def5678 100644 --- a/lib/rupture/fn.rb +++ b/lib/rupture/fn.rb @@ -20,20 +20,28 @@ not call(*args) end end -end -class Object - def fn(name) - block = instance_method(name) - lambda do |object, *args| - block.bind(object)[*arg...
Improve syntax for working with first-order functions
diff --git a/lib/tasks/om.rake b/lib/tasks/om.rake index abc1234..def5678 100644 --- a/lib/tasks/om.rake +++ b/lib/tasks/om.rake @@ -1,6 +1,7 @@ namespace :om do desc "Fetch data for all cafeterias" task :fetch => :environment do + Rails.logger.info "[INFO] Fetch cafeteria data..." date = Time.zone.now.to...
Add log notice for cron task
diff --git a/test/boxen_preflight_etc_my_cnf_test.rb b/test/boxen_preflight_etc_my_cnf_test.rb index abc1234..def5678 100644 --- a/test/boxen_preflight_etc_my_cnf_test.rb +++ b/test/boxen_preflight_etc_my_cnf_test.rb @@ -0,0 +1,10 @@+require 'boxen/test' +require 'boxen/preflight/etc_my_cnf' + +class BoxenPreflightEtcM...
Add test around /etc/my.cnf Preflight
diff --git a/app/views/components/pageflow/admin/members_tab.rb b/app/views/components/pageflow/admin/members_tab.rb index abc1234..def5678 100644 --- a/app/views/components/pageflow/admin/members_tab.rb +++ b/app/views/components/pageflow/admin/members_tab.rb @@ -4,7 +4,7 @@ def build(entry) if entry.me...
Add CSS Class to name Column of Admin Table Feature spec depends on exact class name.
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -38,7 +38,11 @@ get '/:map_name' do @location = Location.find_by_map_name(params[:map_name]) - !!@location ? erb :'show' : redirect to('/error') + if @location + erb :'show' + else + redirect to('/erro...
Change ternary operator to if else statement
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -14,7 +14,7 @@ end get '/news-form' do - send_file File.join('public/app/news-form.html') + send_file File.join('app/views/news-form.html') end get '/form' do
Change file path for news-form
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -0,0 +1,50 @@+require 'pry' +require 'sinatra/base' +require_relative 'lib/tictactoe_rules' +require_relative 'lib/tictactoe_board' +require_relative 'lib/comp_player' +require_relative 'lib/web_game_engine' + +class TicTacToe < Sin...
Create controller at root dir
diff --git a/app/helpers/github_url_helper.rb b/app/helpers/github_url_helper.rb index abc1234..def5678 100644 --- a/app/helpers/github_url_helper.rb +++ b/app/helpers/github_url_helper.rb @@ -6,7 +6,7 @@ end def github_avatar(user, options={}) - uri = URI.parse(user.avatar_url) rescue DEFAULT_AVATAR + uri...
Fix appending size to github urls
diff --git a/spec/features/project/shortcuts_spec.rb b/spec/features/project/shortcuts_spec.rb index abc1234..def5678 100644 --- a/spec/features/project/shortcuts_spec.rb +++ b/spec/features/project/shortcuts_spec.rb @@ -0,0 +1,21 @@+require 'spec_helper' + +feature 'Project shortcuts', feature: true do + let(:project...
Add Rspec test for "i" shortcut
diff --git a/Re-Lax.podspec b/Re-Lax.podspec index abc1234..def5678 100644 --- a/Re-Lax.podspec +++ b/Re-Lax.podspec @@ -18,4 +18,5 @@ spec.requires_arc = true spec.platform = ['tvos'] spec.tvos.deployment_target = '9.0' + spec.swift_version = '4.1' end
Update Podspec to specify swift version support
diff --git a/aggregator.gemspec b/aggregator.gemspec index abc1234..def5678 100644 --- a/aggregator.gemspec +++ b/aggregator.gemspec @@ -8,8 +8,8 @@ spec.version = Aggregator::VERSION spec.authors = ["Joao Carlos"] spec.email = ["joao@adtile.me"] - spec.summary = %q{TODO: Write a shor...
Add gem description and summary
diff --git a/C4.podspec b/C4.podspec index abc1234..def5678 100644 --- a/C4.podspec +++ b/C4.podspec @@ -12,9 +12,11 @@ s.license = "MIT" s.authors = { "Travis" => "info@c4ios.com", "Alejandro Isaza" => "al@isaza.ca" } - s.platform = :ios - s.ios.deployment_target = '9.0' - s.source = { :g...
Declare tvOS support for CocoaPods
diff --git a/business_calendar.gemspec b/business_calendar.gemspec index abc1234..def5678 100644 --- a/business_calendar.gemspec +++ b/business_calendar.gemspec @@ -23,7 +23,6 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" spec.add_development_dependency "pry" - s...
Remove pry-debugger from dev dependencies
diff --git a/lib/online_pimp/verificators/service_example.rb b/lib/online_pimp/verificators/service_example.rb index abc1234..def5678 100644 --- a/lib/online_pimp/verificators/service_example.rb +++ b/lib/online_pimp/verificators/service_example.rb @@ -1,5 +1,5 @@ module OnlinePimp::Verificators - class ServiceExample...
Make sure example inherits from base
diff --git a/app/models/idea.rb b/app/models/idea.rb index abc1234..def5678 100644 --- a/app/models/idea.rb +++ b/app/models/idea.rb @@ -7,7 +7,7 @@ has_many :voters, :through => :votes, :source => :user, :class_name => 'User' has_many :comments, -> { order(created_at: :asc) }, :dependent => :destroy do def v...
Update method for finding visible Comments Old method is deprecated. Use newer 'where(conditions)' instead.
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -9,7 +9,6 @@ validates :name, presence: true, length: { maximum: 50 } # crop_attached_file :avatar enum privacy_setting: [:public_profile, :restricted_profile, :private_profil...
Remove unnecessary attr_accessor in User model
diff --git a/app/models/vote.rb b/app/models/vote.rb index abc1234..def5678 100644 --- a/app/models/vote.rb +++ b/app/models/vote.rb @@ -1,4 +1,6 @@ class Vote < ActiveRecord::Base + + self.primary_keys = :idea_id, :user_id belongs_to :idea belongs_to :user
Add primary keys to Vote model Specify the 'idea_id' and 'user_id' attributes are to be used as unique primary keys. Records will be uniquely identified by this composite key, not the 'id' field created and used by Rails by default.
diff --git a/app/helpers/supporters_helper.rb b/app/helpers/supporters_helper.rb index abc1234..def5678 100644 --- a/app/helpers/supporters_helper.rb +++ b/app/helpers/supporters_helper.rb @@ -18,11 +18,12 @@ end def plan_change_word_past_tense(from_plan, to_plan) - word = plan_change_word(from_plan, to_plan)...
Remove unused logic path in helper
diff --git a/app/mailers/newsletter_mailer.rb b/app/mailers/newsletter_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/newsletter_mailer.rb +++ b/app/mailers/newsletter_mailer.rb @@ -13,9 +13,9 @@ @newsletter_user = newsletter_user @newsletter_user.name = @newsletter_user.extract_name_from_email ...
Use NewsletterSetting instead of StringBox as welcome_user mail content
diff --git a/spec/features/user_visits_roster_transactions_page_spec.rb b/spec/features/user_visits_roster_transactions_page_spec.rb index abc1234..def5678 100644 --- a/spec/features/user_visits_roster_transactions_page_spec.rb +++ b/spec/features/user_visits_roster_transactions_page_spec.rb @@ -2,12 +2,13 @@ feature...
Add Default League ID to spec
diff --git a/spec/service_methods/miq_ae_service_classification_spec.rb b/spec/service_methods/miq_ae_service_classification_spec.rb index abc1234..def5678 100644 --- a/spec/service_methods/miq_ae_service_classification_spec.rb +++ b/spec/service_methods/miq_ae_service_classification_spec.rb @@ -1,5 +1,4 @@ require 'sp...
Automate methods can access categories and entries https://bugzilla.redhat.com/show_bug.cgi?id=1254953 Made the tests directly call the service model methods instead of calling automate methods. Makes the tests run faster without the overhead of Automate models (transferred from ManageIQ/manageiq@08e224a7f06a2...
diff --git a/app/services/registry_service.rb b/app/services/registry_service.rb index abc1234..def5678 100644 --- a/app/services/registry_service.rb +++ b/app/services/registry_service.rb @@ -4,13 +4,19 @@ def self.sync_rules last_sync = SyncAttempt.last - cl = XA::Registry::Client.new(ENV.fetch('XA_REGIST...
Deal with Registry connection problems
diff --git a/attributes/intellij_community_edition.rb b/attributes/intellij_community_edition.rb index abc1234..def5678 100644 --- a/attributes/intellij_community_edition.rb +++ b/attributes/intellij_community_edition.rb @@ -1,15 +1,15 @@ case node[:platform] when "centos", "redhat", "debian", "ubuntu" - default['int...
Update to Community Edition 14.0.1
diff --git a/db/migrate/20160719141858_change_lgsl_230_to_107_on_local_transaction.rb b/db/migrate/20160719141858_change_lgsl_230_to_107_on_local_transaction.rb index abc1234..def5678 100644 --- a/db/migrate/20160719141858_change_lgsl_230_to_107_on_local_transaction.rb +++ b/db/migrate/20160719141858_change_lgsl_230_to...
Change sheltered housing transaction to LGSL 107 We want to use LGSL 107 (instead of 230) for the sheltered housing local transaction as it is supported in England and Wales. This migration is one of the last bits of the puzzle from this Trello card: https://trello.com/c/Zb42F6Jq/417-switch-local-transaction-for-appl...
diff --git a/spec/ruboty/toggle_switch/storage_spec.rb b/spec/ruboty/toggle_switch/storage_spec.rb index abc1234..def5678 100644 --- a/spec/ruboty/toggle_switch/storage_spec.rb +++ b/spec/ruboty/toggle_switch/storage_spec.rb @@ -2,7 +2,7 @@ describe Ruboty::ToggleSwitch::Storage do subject(:storage) { Ruboty::Togg...
Use real brain instead of stub
diff --git a/app/mailers/digest_mailer.rb b/app/mailers/digest_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/digest_mailer.rb +++ b/app/mailers/digest_mailer.rb @@ -14,6 +14,7 @@ end private + def posts_to_email(history) return history.daily_posts if history.frequency == 'daily' return h...
Add blank line after private
diff --git a/app/models/procedure_path.rb b/app/models/procedure_path.rb index abc1234..def5678 100644 --- a/app/models/procedure_path.rb +++ b/app/models/procedure_path.rb @@ -1,5 +1,5 @@ class ProcedurePath < ApplicationRecord - validates :path, format: { with: /\A[a-z0-9_\-]{3,50}\z/ }, presence: true, allow_blank:...
Add uniqueness validation to procedure path
diff --git a/frontend/app/controllers/application_controller.rb b/frontend/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/frontend/app/controllers/application_controller.rb +++ b/frontend/app/controllers/application_controller.rb @@ -26,7 +26,11 @@ def current_user=(user) @curren...
Fix deleting current user from session on signout
diff --git a/test/nidyx/test_model_base.rb b/test/nidyx/test_model_base.rb index abc1234..def5678 100644 --- a/test/nidyx/test_model_base.rb +++ b/test/nidyx/test_model_base.rb @@ -0,0 +1,26 @@+require "minitest/autorun" +require "nidyx/model_base" + +class TestModelBase < Minitest::Test + + MOCK_OPTS = { + :author...
Add option tests for model base Closes #1
diff --git a/benchmarks/allocations/helper.rb b/benchmarks/allocations/helper.rb index abc1234..def5678 100644 --- a/benchmarks/allocations/helper.rb +++ b/benchmarks/allocations/helper.rb @@ -14,10 +14,17 @@ end results = stats.allocations(alias_paths: true).group_by(*columns).from_pwd.sort_by_size.to...
Add totals to allocation output.
diff --git a/app/sweepers/post_sweeper.rb b/app/sweepers/post_sweeper.rb index abc1234..def5678 100644 --- a/app/sweepers/post_sweeper.rb +++ b/app/sweepers/post_sweeper.rb @@ -1,26 +1,5 @@ class PostSweeper < ActionController::Caching::Sweeper observe CrowdblogCore::Post - def after_create(post) - expire_all(...
Remove sweeper code, let the implementation to be done in the container app
diff --git a/lib/helpers/find_or_create_students.rb b/lib/helpers/find_or_create_students.rb index abc1234..def5678 100644 --- a/lib/helpers/find_or_create_students.rb +++ b/lib/helpers/find_or_create_students.rb @@ -3,7 +3,7 @@ # def find_or_create_student(username) user_created = nil - using_cache = !!@user_cach...
QUALITY: Use .nil? over double negation
diff --git a/lib/paperclip/storage/dropbox/generator_factory.rb b/lib/paperclip/storage/dropbox/generator_factory.rb index abc1234..def5678 100644 --- a/lib/paperclip/storage/dropbox/generator_factory.rb +++ b/lib/paperclip/storage/dropbox/generator_factory.rb @@ -7,7 +7,7 @@ def self.build_url_generator(storag...
Fix "undefined method `generate' for nil:NilClass" Fixes #45
diff --git a/lib/tasks/gobierto_budgets/missing_categories.rake b/lib/tasks/gobierto_budgets/missing_categories.rake index abc1234..def5678 100644 --- a/lib/tasks/gobierto_budgets/missing_categories.rake +++ b/lib/tasks/gobierto_budgets/missing_categories.rake @@ -0,0 +1,44 @@+# frozen_string_literal: true + +namespace...
Add task to check missing category names
diff --git a/spec/models/repository_protected_branche_spec.rb b/spec/models/repository_protected_branche_spec.rb index abc1234..def5678 100644 --- a/spec/models/repository_protected_branche_spec.rb +++ b/spec/models/repository_protected_branche_spec.rb @@ -31,6 +31,8 @@ it { should validate_presence_of(:permissions...
Add test for ProtectBranche uniqueness
diff --git a/app/models/item.rb b/app/models/item.rb index abc1234..def5678 100644 --- a/app/models/item.rb +++ b/app/models/item.rb @@ -2,4 +2,6 @@ validates :name, presence: { message: "Name field can't be left blank"}, length: { in: 3..64, message: "Name must be between 3 and 64 characters in length" } validate...
Update Item price validation. Include comment pointing out that format still needs to be set
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -12,6 +12,6 @@ validates :name, presence: true def twitter=(handle) - write_attribute :twitter, handle.gsub(/\A@/,'') + write_attribute :twitter, handle.gsub(/\A@/,'') if ...
Fix setting a User's twitter handle to nil
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -2,6 +2,9 @@ # https://github.com/EppO/rolify rolify + + # Public: Username for user. + # column :username # Public: Name of user. # column :name @@ -14,6 +17,9 @@ ...
Add comments for new User attributes.
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-messaging' - s.version = '0.29.0.12' + s.version = '1.0.0.0' s.summary = 'Common primitives for ...
Package version is increased from 0.29.0.12 to 1.0.0.0
diff --git a/lib/generators/draper/model/templates/model.rb b/lib/generators/draper/model/templates/model.rb index abc1234..def5678 100644 --- a/lib/generators/draper/model/templates/model.rb +++ b/lib/generators/draper/model/templates/model.rb @@ -1,4 +1,5 @@ class <%= singular_name.camelize %>Decorator < Draper::Base...
Update template to generate 'decorates' line
diff --git a/lib/validates_email_format_of/rspec_matcher.rb b/lib/validates_email_format_of/rspec_matcher.rb index abc1234..def5678 100644 --- a/lib/validates_email_format_of/rspec_matcher.rb +++ b/lib/validates_email_format_of/rspec_matcher.rb @@ -6,7 +6,7 @@ actual.send(:"#{attribute}=", "invalid@example.") ...
Fix rspec run fail when using custom error message
diff --git a/app/app.rb b/app/app.rb index abc1234..def5678 100644 --- a/app/app.rb +++ b/app/app.rb @@ -17,7 +17,7 @@ Player.mute end get '/playing' do - "<img src='/playing.png'><br/>#{Player.playing}" + Player.playing end put '/next' do Player.next
Revert add art to playing in web.
diff --git a/modelling.gemspec b/modelling.gemspec index abc1234..def5678 100644 --- a/modelling.gemspec +++ b/modelling.gemspec @@ -18,7 +18,5 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ['lib'] - # specify any dependencies here; for example: - # s.ad...
Move rspec to development dependency
diff --git a/env.rb b/env.rb index abc1234..def5678 100644 --- a/env.rb +++ b/env.rb @@ -3,7 +3,7 @@ end configure :production do - db = URI.parse(ENV['DATABASE_URL'] || 'postgres:///localhost/mydb') + db = URI.parse(ENV['HEROKU_POSTGRESQL_ONYX_URL'] || 'postgres:///localhost/mydb') ActiveRecord::Base.establi...
Fix DB URL on Heroku